Shelley Vohr
0cb4fdd0f2
fix: allow disabling all NSMenuItems ( #48598 )
...
fix: allow disabling all NSMenuItems
2025-10-28 11:20:55 -04:00
electron-roller[bot]
29e0948f7b
chore: bump chromium to 143.0.7497.0 (main) ( #48657 )
...
* chore: bump chromium in DEPS to 143.0.7492.0
* chore: bump chromium in DEPS to 143.0.7493.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update printing.patch
Avoid a reachable NOTREACHED() in PrintingContextLinux | https://chromium-review.googlesource.com/c/chromium/src/+/7081117
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
patch reapplied manually due to context shear
Cleanup: format some content files | https://chromium-review.googlesource.com/c/chromium/src/+/7083290
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
patch manually reapplied for files moved upstream
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update revert_cleanup_remove_feature_windelayspellcheckserviceinit.patch
no manual changes; patch applied with fuzz
[spelling+grammar restrictions] fix feature param name | https://chromium-review.googlesource.com/c/chromium/src/+/7081186
* chore: update patches
* chore: fix broken includes in ElectronBrowserMainParts
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: bump chromium in DEPS to 143.0.7495.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 143.0.7497.0
* chore: fixup patch indices
* 7085081: Roll libc++ from d6739a332fe9 to bc00f6e9f739 (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/7085081
* 7081087: Move os_crypt/sync and os_crypt/async shared code to os_crypt/common
https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* test: fix failing spec
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-28 11:17:29 -04:00
michal-pichlinski-openfin
28f1cf1f11
feat: Focus DevTools when breakpoint is triggered ( #46386 )
...
`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
if (life_stage_ != kLoadCompleted)
return;
\#if BUILDFLAG(IS_ANDROID)
NOTIMPLEMENTED();
\#else
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.
Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.
Only supported for DevTools manged by `electron::InspectableWebContents`.
Closes : #37388
2025-10-28 08:46:33 -04:00
Charles Kerr
e44b96bbd3
refactor: avoid deprecated views a11y api ( #47674 )
...
* refactor: use GetViewAccessibility().SetName() instead of SetAccessibleName()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5537333
* refactor: use GetViewAccessibility().SetRole() instead of SetAccessibleRole()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5337377
* fixup! refactor: use GetViewAccessibility().SetRole() instead of SetAccessibleRole()
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-27 14:05:25 -05:00
Shelley Vohr
b389377c63
feat: add app.isHardwareAccelerationEnabled() ( #47614 )
...
* feat: add app.isHardwareAccelerationEnabled()
* chore: address review feedback
2025-10-27 14:03:08 -05:00
Shelley Vohr
eda0a7e749
fix: crash on empty dialog extensions array on Windows ( #48640 )
2025-10-25 18:14:55 +02:00
electron-roller[bot]
6d8196fba3
chore: bump chromium to 143.0.7489.0 (main) ( #48642 )
...
* chore: bump chromium in DEPS to 143.0.7489.0
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Remove BackForwardTransitions flag | https://chromium-review.googlesource.com/c/chromium/src/+/7022596
* chore: update process_singleton.patch
patch reapplied manually due to context shear
Use an empty prefix for socket temporary directory. | https://chromium-review.googlesource.com/c/chromium/src/+/7062192
* chore: update add_electron_deps_to_license_credits_file.patch
no manual changes; patch applied with fuzz
* chore: update expose_ripemd160.patch
Apply modernize-use-nullptr fixes in all .cc files | https://boringssl-review.googlesource.com/c/boringssl/+/83067
* chore: update feat_expose_several_extra_cipher_functions.patch
Apply modernize-use-nullptr fixes in all .cc files | https://boringssl-review.googlesource.com/c/boringssl/+/83067
* Pass Bus::Options by value with std::move. | https://chromium-review.googlesource.com/c/chromium/src/+/7056670
* chore: update patches
* Remove some includes of base/callback_list.h | https://chromium-review.googlesource.com/c/chromium/src/+/7055621
* chore: run gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-23 16:28:51 -04:00
electron-roller[bot]
9235dc0159
chore: bump chromium to 143.0.7485.0 (main) ( #48618 )
...
* chore: bump chromium in DEPS to 143.0.7485.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Patch applied manually due to context shear
* Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
* chore: e patches all
* chore: check for file existence before setting utime
* chore: stop disabling kWinDelaySpellcheckServiceInit
[cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087
This flag has been removed upstream. We've used it since c2d7164#38248 )
to fix a crash originally described in 97b353a#34993 ):
> Delaying spell check initialization is causing specs for
> 'custom dictionary word list API' to fail in Electron.
Since we haven't touched this in a few years, and since there's a
clear success criteria (a passing/failing spec), and since the patch
to restore this flag would be pretty large (~750 lines), I'm going
to try just removing the flag from our source to see if the spec
passes or fails.
* Revert "chore: stop disabling kWinDelaySpellcheckServiceInit"
This reverts commit e688880396https://chromium-review.googlesource.com/c/chromium/src/+/7012087
We currently need this feature
* fixup! chore: check for file existence before setting utime
* fixup! Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Address Robo's code review @ 64c7fd21edcharles@charleskerr.com >
2025-10-23 08:30:29 -05:00
Shelley Vohr
f784ea6f4f
fix: icon in Windows toast notification ( #48543 )
2025-10-21 15:12:26 -04:00
Tau Gärtli
7ec0ebc50a
feat: Add getAccentColor on Linux ( #48027 )
...
* feat: Implement `getAccentColor` on Linux
* doc: Update OS support for accent color APIs
2025-10-21 14:26:30 -04:00
Shelley Vohr
e766d378e1
feat: enable more granular a11y feature management ( #48042 )
...
* feat: enable more granular a11y feature management
* Update docs/api/app.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-21 10:56:14 -04:00
Shelley Vohr
0a19176917
feat: enable resetting accent color ( #48274 )
2025-10-21 10:49:08 -04:00
Shelley Vohr
6562d6ed0b
fix: systemPreferences.getAccentColor inverted color ( #48511 )
...
fix: systemPreferences.getAccentColor inverted color
2025-10-21 10:46:46 -04:00
Shelley Vohr
0b179f8f05
fix: devtools crashing on Linux in detach mode ( #48600 )
2025-10-21 10:45:02 -04:00
Shelley Vohr
89d3067dd4
fix: trafficLightPosition incorrect with customButtonsOnHover ( #48538 )
...
fix: trafficLightPosition incorrect with customButtonsOnHover
2025-10-21 10:43:04 -04:00
electron-roller[bot]
00a3031357
chore: bump chromium to 143.0.7483.0 (main) ( #48590 )
...
* chore: bump chromium in DEPS to 143.0.7482.0
* chore: bump chromium in DEPS to 143.0.7483.0
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update mas_avoid_private_macos_api_usage.patch.patch
[graphite] Refactor backpressure fences on Mac to avoid GLContext | https://chromium-review.googlesource.com/c/chromium/src/+/7047167
* chore: update disable_compositor_recycling.patch
no manual changes; patch applied with fuzz
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update feat_allow_code_cache_in_custom_schemes.patch
[url] Change Add*Scheme*(...) functions to accept std::string_view | https://chromium-review.googlesource.com/c/chromium/src/+/7046471
* chore: e patches all
* [memory] Replace bool success with MemoryDumpRequestOutcome enum. | https://chromium-review.googlesource.com/c/chromium/src/+/7029767
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-21 08:11:09 -05:00
Mitchell Cohen
0c27c1a395
fix: position window titlebar buttons correctly in Ubuntu on Wayland ( #48490 )
2025-10-20 12:42:23 -07:00
Shelley Vohr
413803188d
fix: background hover contrast for WCO buttons ( #48568 )
2025-10-20 09:54:14 +02:00
electron-roller[bot]
1cc2fce905
chore: bump chromium to 143.0.7477.0 (main) ( #48584 )
...
* chore: bump chromium in DEPS to 143.0.7477.0
* 7049117: [CodeCache] Adjust PersistentCache for CodeCache feature
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7049117
* chore: update patches
* chore: add missing includes of ui/gfx/image/image_skia.h
* 7028738: Rename several ipc_* files used by param_traits*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7028738
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-19 21:46:34 +02:00
electron-roller[bot]
3bfe1f2363
chore: bump chromium to 143.0.7474.0 (main) ( #48572 )
...
* chore: bump chromium in DEPS to 143.0.7474.0
* 7006208: [Mac] Fix rendering bug for manual occlusion detection on macOS 26
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006208
* chore: update patches
* 7038563: Forward declare more in page_navigator.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7038563
* 7023417: Remove ipc/ipc_message_macros.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023417
* 7006340: Move icon_util files to win/ subdrectory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006340
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-17 13:04:24 -04:00
electron-roller[bot]
471a14432f
chore: bump chromium to 143.0.7469.0 (main) ( #48548 )
...
* chore: bump chromium in DEPS to 143.0.7469.0
* 7021651: [//gpu] Fold handle creation into D3DImageBackingFactory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7021651
* 7013047: Fix various C++23 build errors in //chrome
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7013047
* 7010850: [//ui] Port screen_mac.mm's calls to DisplayColorSpaces
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7010850
* 7007933: Remove superfluous mojom includes in //content/public headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7007933
* 7023196: Trim os_crypt/sync visibility list
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023196
* 7008912: Remove GURL::*_piece() method
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7008912
* 7003989: Add wrapper struct for CopyFromSurface output
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7003989
* 7017889: [MemoryPressureListener] Remove type aliases
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7017889
* 7027780: Delete viz::ResourceSizes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7027780
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6989572
* 6495189: [api] Delete old String::Write* APIs
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6495189
* chore: update patches
* chore: run script/gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-15 14:10:10 -07:00
CezaryKulakowski
357e42d907
fix: fixed white flash on call to BrowserWindow.show ( #47151 )
2025-10-14 15:58:27 +02:00
electron-roller[bot]
d920c82fc4
chore: bump chromium to 143.0.7451.0 (main) ( #48362 )
...
* chore: bump chromium in DEPS to 142.0.7429.0
* chore: bump chromium in DEPS to 142.0.7430.0
* 6954508: Reland Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6954508
* https://chromium-review.googlesource.com/c/chromium/src/+/6955633
* 5584820: Fix font face resolution when renderer is blocked | https://chromium-review.googlesource.com/c/chromium/src/+/5584820
* chore: export patches
* chore: remove patch that keeley says is ok to remove in comments
* chore: bump chromium in DEPS to 142.0.7432.0
* chore: export patches
* chore: bump chromium in DEPS to 142.0.7434.0
* 6973697: Use type tags for data stored in V8 internal fields | https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* 6976272: Revert Reland mac: click through content area in main window | https://chromium-review.googlesource.com/c/chromium/src/+/6976272
* chore: export patches
* 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086
* 6951252: Correct PersistentCache backed code cache context grouping
* chore: bump chromium in DEPS to 142.0.7436.0
* 6981628: Reland Use unordered_map in AcceleratorMap | https://chromium-review.googlesource.com/c/chromium/src/+/6981628
* chore: export patches
* chore: resolve patch conflict with main
* chore: merge conflict with main
* chore: bump chromium in DEPS to 142.0.7438.0
* chore: bump chromium in DEPS to 142.0.7440.0
* chore: bump chromium in DEPS to 142.0.7442.0
* chore: bump chromium in DEPS to 142.0.7444.0
* chore: bump chromium in DEPS to 143.0.7445.0
* chore: bump chromium in DEPS to 143.0.7447.0
* chore: bump chromium in DEPS to 143.0.7449.0
* chore: bump chromium in DEPS to 143.0.7451.0
* 7001364: Migrate GURL accessors to Get* variants in //content | https://chromium-review.googlesource.com/c/chromium/src/+/7001364
* 6986521: Implicit second value 'any' instead of 'span-all' for fallback query | https://chromium-review.googlesource.com/c/chromium/src/+/6986521
* chore: update chromium patches
* chore: update chromium patches
* chore: update patches
* fix: parse macOS SDK version across line break
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* fix: replace v8::Object::SetPrototype() usage
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
https://github.com/nodejs/node/pull/55453
* fix: regenerate filenames.libcxx.gni
https://chromium-review.googlesource.com/c/chromium/src/+/6980307
* fix: replace additional usages of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* build: use macos 15 minimum
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* ci: ignore missing dir for strip_universal_deep
* fix: js2c compilation failure
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
See patch description explaining MacOS 26 SDK headers incompatibility.
* fixup! chore: export patches
* feat: add new memory-eviction exit reason
https://chromium-review.googlesource.com/c/chromium/src/+/6991933
* fix: set JSON reader parsing options
https://chromium-review.googlesource.com/c/chromium/src/+/6992114
* fix: provide DeviceEmulationCacheBehavior param
https://chromium-review.googlesource.com/c/chromium/src/+/6965238
* fix: views::NonClientFrameView -> views::FrameView
https://chromium-review.googlesource.com/c/chromium/src/+/7005027
https://chromium-review.googlesource.com/c/chromium/src/+/6966937
* fix: check new forced colors enum value
https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fix: migrate NetworkConditions -> MatchedNetworkConditions
https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fix: migrate GURL string methods to Get*()
https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: disable C++ modules in electron_lib builds
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
* fix: partially revert is_headless_mode removal
https://chromium-review.googlesource.com/c/chromium/src/+/6955633
This patch should likely be reworked. For now, this partially reverts the
removal of a required class property to restore behavior.
* Revert "build: use macos 15 minimum"
This reverts commit 2fc12d6acchttps://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* build: switch to macos-15 runner
build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The
macos 15 runners default to an Xcode using the 15 SDK and removes older
versions.
* fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: use std::u16string for Extension::Create() error parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6975452
* fix: add missing image_skia include
https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fix: remove outdated V8 flag
https://chromium-review.googlesource.com/c/v8/v8/+/6948286
* fix: disable protocol handler DCHECK
https://chromium-review.googlesource.com/c/chromium/src/+/6727594
Ignore the extension custom protocol handler registry DCHECK until
we invest in supporting it. Replacing this DCHECK seems harmless
and will unblock the roll.
* fix: replace deprecated usage of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* chore: remove patch already included in roll
* chore: remove extraneous formatting added to patch
* chore: remove fix_harden_blink_scriptstate_maybefrom.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
No longer needed since the above CL landed.
* 6973697: Use type tags for data stored in V8 internal fields
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* chore: update patches
* fixup! chore: export patches
* chore: restore electron embedder data tag patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-13 12:21:54 -04:00
Shelley Vohr
dd25a6361b
fix: auth required websocket crash ( #48510 )
2025-10-13 10:13:32 +02:00
Zuohui Yang
16b5776b01
fix: launch crash when null device is disabled on Windows ( #47870 )
...
fix: fix launch crash when null device is disabled on Windows
add node flag node::ProcessInitializationFlags::kNoStdioInitialization
Co-authored-by: yangzuohui <yangzuohui@bytedance.com >
Co-authored-by: yangliu <yangliu.leo@bytedance.com >
2025-10-11 18:00:04 -04:00
Shelley Vohr
b992ead837
fix: dialog.showMessageBox defaultid on Windows ( #48216 )
...
* fix: dialog.showMessageBox defaultid on Windows
* Update shell/browser/ui/message_box_win.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-10-10 15:39:23 +02:00
Shelley Vohr
11f76118db
fix: unexpected openExternal dialog on macOS Tahoe ( #48502 )
...
fix: unexpected openExternal dialog on macOS Tahoe
2025-10-10 12:48:44 +02:00
reito
9e46efb8f7
feat: offscreen rendering support rgbaf16 hdr output format. ( #48265 )
...
* feat: offscreen rendering support rgbaf16
* docs: update doc
* docs: update doc.
2025-10-09 10:33:34 +02:00
zoy
3a53c71324
fix: broken transparent window styles on resizable change ( #48378 )
...
* fix: wrong api call
* fix: consistency of the resize state
* fix: edge cases
* chore: add detailed comments
* fix: lint
* chore: only windows
* chore: use transparent
2025-10-09 09:49:20 +02:00
Fedor Indutny
e8e91c331a
feat: dynamic ESM import in preload without context isolation ( #48375 )
...
Dynamic ESM import in non-context-isolated preload
Extend `HostImportModuleWithPhaseDynamically`'s routing to support
Node.js import resolution in non-context-isolated preloads through
`v8_host_defined_options` length check. The length of host defined
options is distinct between Blink and Node.js and we can use it to
determine which resolver to use.
2025-10-08 10:44:09 +02:00
Charles Kerr
49c1139ab9
chore: remove unused reference to api::BrowserView ( #48474 )
...
chore: remove unused reference to api::BrowserView
Unused since #35658 / 15c60143
2025-10-08 10:43:28 +02:00
Charles Kerr
a1ca9a8d55
refactor: DRY in App::SetAppLogPath() ( #48452 )
2025-10-05 12:32:28 -05:00
Charles Kerr
38e491689a
perf: avoid a little extra work in InvokeIpcCallback() ( #48456 )
...
perf: two minor perf refactors in InvokeIpcCallback()
1. Allocate the CallbackScope on the stack instead of the heap
2. Skip a redundant call to node::Environment::GetCurrent()
2025-10-04 21:52:53 -07:00
Charles Kerr
01cab978f7
refactor: remove gin_helper::Arguments ( #48374 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in StopRecording()
* refactor: use gin::Arguments in ImageView::New()
* refactor: use gin::Arguments in AppendSwitch()
* refactor: use gin::Arguments WebContentsView::New()
* refactor: make gin::Arguments arg const in WrappableBase::InitWithArgs()
This makes explicit that we are using it for wrapper + isolate, not the args values
* refactor: remove gin_helper::Arguments arg from ExposeAPI()
refactor: remove gin_helper::Arguments arg from ExposeAPIInWorld()
* refactor: remove gin_helper::Arguments arg from ElectronBindings::GetSystemMemoryInfo()
* refactor: remove gin_helper::Arguments arg from preload_utils::GetBinding()
* refactor: use gin::Arguments in OpenExternal()
* refactor: use gin::Arguments in ExecuteInWorld()
* refactor: use gin::Arguments in ExecuteJavaScript()
* refactor: use gin::Arguments in InvokeNew()
* refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
* refactor: remove unused GetNextArgument() marshaller for gin_helper::Arguments
* refactor: remove unused #include gin_helper/arguments.h
* chore: remove unused gin_helper::Arguments
* fixup! refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
Xref: https://github.com/electron/electron/pull/48447
2025-10-03 14:10:29 -05:00
zoy
7cb1552614
fix: accentColor set distinguishes the frame ( #48405 )
...
* fix: accentColor set distinguishes the frame
* chore: invalid change
* fix: lint
2025-10-03 20:10:18 +02:00
Robo
37a115b8fd
fix: initialze featurelist before parsing features ( #48411 )
2025-10-03 01:18:14 +02:00
Shelley Vohr
e7e29ea876
fix: snapped window restoring to correct position ( #48296 )
2025-10-02 18:14:48 +02:00
Fedor Indutny
6f9cd718c4
fix: runtime JS error that crashes GetPackageJSON ( #48293 )
...
We overriden the `GetPackageJSON` in Node.js to let us read files
straight from the ASAR file instead of disk. The override works by
providing a JS method with the limitation that it should not throw a
runtime error. However, this invariant was accidentally violated by
`asar.splitPath` that sometimes contrary to its' TypeScript definition
returned `false`.
2025-09-30 18:32:13 +02:00
BILL SHEN
d4a5fdc8fc
fix: add missed enum SaveRequestType to PdfViewerPrivate function ( #48372 )
...
fix: add missed SaveRequestType enum to PdfViewerPrivate function
2025-09-26 16:34:06 -04:00
avarayr
3a7c6dd4a5
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load ( #48376 )
...
fix: macOS stop overriding private cornerMask API to fix WindowServer GPU load spike
Electron fetched a custom `_cornerMask` for `ElectronNSWindow` to smooth
vibrancy corners. On macOS 15 (Tahoe) that private hook forces the window
shadow to be rendered from a fully transparent surface, causing the
WindowServer GPU load regression. Remove the `cornerMask` property and
the `_cornerMask` override so we stay on Apple’s default shadow path.
2025-09-26 12:41:16 -07:00
Charles Kerr
26a473db98
refactor: make api::Menu inherit from gin::Wrappable ( #48351 )
...
* refactor: make api::Menu inherit from gin::Wrappable*
* refactor: make api::Menu::kWrapperInfo const
* refactor: use three-arg version of GetConstructor in Menu
refactor: undo branch changes to two-arg version of GetConstructor
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
fix: return type of Menu::New
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
make MenuMac's constructor public so that cppgc can use it
* refactor: Pinnable -> SelfKeepAlive
2025-09-24 19:42:22 -05:00
Charles Kerr
6661457cdf
refactor: prefer upstream gin::Arguments::ThrowTypeError() over gin_helper ( #48368 )
...
* refactor: use gin::Arguments::ThrowTypeError() in AutoUpdater::SetFeedURL()
* refactor: use gin::Arguments::ThrowTypeError() in Browser::Focus()
* refactor: use gin::Arguments::ThrowTypeError() in SystemPreferences::SetUserDefault()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::Create()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::PostMessage()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBundleMover::ShouldContinueMove()
* refactor: use gin::Arguments::ThrowTypeError() in OnClientCertificateSelected()
* refactor: use gin::Arguments::ThrowTypeError() in Session::ClearData()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBrowserContext::DisplayMediaDeviceChosen()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::ReplaceMisspelling()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::Print()
* chore: iwyu shell/common/gin_helper/error_thrower.h
2025-09-24 19:10:05 -05:00
Charles Kerr
235fdc41f6
refactor: use gin::Arguments in BaseWindow ( #48355 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in BaseWindow::MoveAbove()
refactor: use gin::Arguments in BaseWindow::SetAlwaysOnTop()
refactor: use gin::Arguments in BaseWindow::SetIgnoreMouseEvent()
* refactor: use gin::Arguments in BaseWindow::SetProgresBar()
* refactor: use gin::Arguments in BaseWindow::SetVisibleOnAllWorkspaces()
* refactor: use gin::Arguments in BaseWindow::SetVibrancy()
* refactor: use gin::Arguments in BaseWindow::SetAspectRatio()
* refactor: use gin::Arguments in BaseWindow::PreviewFile()
* refactor: use gin::Arguments in BaseWindow::SetThumbarButtons()
* refactor: use gin::Arguments in BaseWindow::SetBounds()
* refactor: use gin::Arguments in BaseWindow::SetContentBounds()
* refactor: use gin::Arguments in BaseWindow::SetSize()
* refactor: use gin::Arguments in BaseWindow::SetContentSize()
* refactor: use gin::Arguments in BaseWindow::SetSheetOffset()
* refactor: use gin::Arguments in BaseWindow::SetPosition()
* refactor: use gin::Arguments in BaseWindow::AddTabbedWindow()
* refactor: use gin::Arguments in BaseWindow::SetParentWindow()
* refactor: use gin::Arguments in BaseWindow::BaseWindow()
* refactor: use gin::Arguments in BaseWindow::SetAccentColor()
* refactor: use gin::Arguments in BaseWindow::SetTitleBarOverlay()
2025-09-24 09:39:16 -04:00
Charles Kerr
6bbbc1232e
chore: remove unused, undocumented, untested executionMode arg from web_frame.executeJavaScriptInIsolatedWorld() ( #48361 )
...
chore: remove unused, undocumented execution mode arg from web_frame.executeJavaScriptInIsolatedWorld()
2025-09-24 08:13:49 -05:00
electron-roller[bot]
1fda08b8c8
chore: bump chromium to 142.0.7417.0 (main) ( #48275 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
* chore: fixup patch indices
* chore: bump chromium in DEPS to 142.0.7402.0
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
* chore: fixup patch indices
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
* chore: fix patch
* chore: bump chromium in DEPS to 142.0.7403.0
* build: remove ninja logs
* chore: fixup patch indices
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
* build: don't kill blink/web_tests
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
* chore: bump chromium in DEPS to 142.0.7405.0
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
* chore: fixup patch indices
* fix: Protocol complex inline dtor
* chore: bump chromium in DEPS to 142.0.7407.0
* chore: bump chromium in DEPS to 142.0.7409.0
* chore: bump chromium in DEPS to 142.0.7411.0
* chore: bump chromium in DEPS to 142.0.7413.0
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* chore: fixup patch indices
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
* chore: bump chromium in DEPS to 142.0.7415.0
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
* chore: update patches
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
* fixup for lint
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 142.0.7417.0
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
* chore: update patches
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* Revert "build: remove ninja logs"
This reverts commit 72874740fdshelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-09-22 20:16:27 -07:00
Charles Kerr
19256a07dd
refactor: use gin::Arguments in api::Clipboard ( #48354 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBuffer()
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBookmark()
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in api::Clipboard
2025-09-23 04:12:47 +09:00
Robo
048d620701
fix: remove unneeded handlescope from JS callbacks ( #48318 )
...
fix: remove handlescope from JS callbacks
2025-09-16 06:56:38 +09:00
Charles Kerr
15cdae1cf0
refactor: make api::NetLog inherit from gin::Wrappable ( #48308 )
...
* refactor: remove unused v8::Isolate* arg from NetLog ctor
* refactor: allocate api::NetLog on cpp heap
* refactor: make electron::api::Session::net_log_ a cppgc::Member<api::NetLog>
* refactor: remove unnecessary EscapableHandleScope
* chore: code style consistency
2025-09-16 06:29:46 +09:00
Shelley Vohr
bac383c219
feat: add fileSystem to ses.setPermissionCheckHandler ( #48170 )
...
feat: add fileSystem to ses.setPermissionCheckHandler
2025-09-15 17:00:58 -04:00
Charles Kerr
a468ed7f10
refactor: narrow or remove gin arguments ( #48300 )
...
* refactor: narrow App:SetJumpList() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow WebContents::AddWorkSpace() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowMessageBox() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowOpenDialog() arg from gin::Arguments* to v8::Isolate*
* refactor: remove unused gin::Arguments* arg from OverrideGlobalPropertyFromIsolatedWorld()
* refactor: narrow WebContents::StartDrag() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow NetLog::StopLogging() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow Protocol::IsProtocolHandled() arg from gin::Arguments* to v8::Isolate*
2025-09-13 08:19:07 +09:00
