432 Commits

Author	SHA1	Message	Date
Charles Kerr	6c49cb3b27	fix: add MicrotasksScope for worker exit emit in ContextWillDestroy (#51326) ... a39108c5a4 (#47244) replaced gin_helper::EmitEvent with a direct `v8::Function::Call()` in `WebWorkerObserver::ContextWillDestroy` to avoid re-entering the microtask checkpoint during worker teardown. V8 `DCHECK()`s that a policy is set. Under the old code path, this happened with a node::CallbackScope. Under the new code path, it's possible for a policy to not be set, causing that `DCHECK()` to fail. This PR copies a39108c5a4's changes in `ShareEnvironmentWithContext()`: it explicitly adds a `kDoNotRunMicrotasks` scope.	2026-04-27 16:18:09 -04:00
electron-roller[bot]	b93642678c	chore: bump chromium to 149.0.7798.0 (main) (#50814) ... * chore: bump chromium in DEPS to 149.0.7779.0 * chore: bump chromium in DEPS to 149.0.7781.0 * 7726883: Add secondary label support to SimpleMenuModel and update views_examples Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7726883 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patches (trivial only) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fix: IWYU for base/logging.h Upstream is removing transitive includes of base/logging.h as part of crbug.com/499476145. Several CLs landed in this roll that required adding explicit includes across Electron source and patches. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7732103 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7735571 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7732482: [bedrock] Create BrowserProcess setters for system tray icons Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7732482 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patches (trivial only) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * 7739543: Add RenderWidgetHostView::HasSavedFrame Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7739543 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: bump chromium in DEPS to 149.0.7783.0 * chore: bump chromium in DEPS to 149.0.7789.0 * chore: update patches (trivial only) * 7703728: DedicatedWorker: Enforce same-origin check for main script fetch. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7703728 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7720140: Remove GetPrefServiceForContext from ExtensionsBrowserClient Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7720140 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: update patches (trivial only) * 7728375: Disable reentrancy by default except for Android and iOS Upstream changed the default ObserverList reentrancy policy from kAllowReentrancy to kDisallowReentrancy. Electron's observer lists are re-entered when macOS AppKit delivers synchronous window notifications (e.g. windowDidResignMain: during windowDidChangeOcclusionState:) because JS event handlers can trigger window state changes mid-iteration. Explicitly opt into kAllowReentrancy for now. A follow-up should convert synchronous Emit calls in window observer callbacks to EmitEventSoon to eliminate the reentrancy. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7728375 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump chromium in DEPS to 149.0.7791.1 * chore: update patches (trivial only) * 7696481: [pdf] Rename PdfViewerStreamManager to MimeHandlerStreamManager Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7696481 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7745796: Printing: Remove parameter from ShowScriptedPrintPreview() interface Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7745796 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7688714: [Lens / Cookies] Grant secure cookie exemptions for Lens side panel Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7688714 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7752609: don't show glic button for non-normal BWIs. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7752609 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 7749860: [media] Remove VideoFrame::WrapSharedImage with coded_size Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7749860 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump chromium in DEPS to 149.0.7793.0 * chore: bump chromium in DEPS to 149.0.7795.0 * chore: bump chromium in DEPS to 149.0.7797.0 * chore: update patches * chore: remove upstreamed patches - fix_pass_trigger_for_global_shortcuts_on_wayland.patch: https://chromium-review.googlesource.com/c/chromium/src/+/7620219 - gin_mark_argumentholder_as_cppgc_stack_allocated.patch: https://chromium-review.googlesource.com/c/chromium/src/+/7728865 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump chromium in DEPS to 149.0.7798.0 * chore: update filenames.libcxx.gni * 7760061: Reland Reland Add a client-side decorated frame view for non-browser widgets on Linux Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7760061 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7760945: Rename WebString::UTF8ConversionMode to Utf8ConversionMode Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7760945 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: update patches * chore: remove upstreamed patches - patches/devtools_frontend/fix_context_selector_not_showing_execution_contexts.patch: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761316 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7719004: [extensions] Gate dict-format mime_types_handler parsing Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7719004 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7716681: [pdf] Introduce MimeHandlerStreamDelegate and plumb ownership Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7716681 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7725342: Rename WebString::FromUTF8 to FromUtf8 in Blink Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7725342 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7615475: Add a native frame view for non-browser widgets on Linux Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7615475 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7735248: Move ManifestV2ExperimentManager to //extensions Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7735248 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7725187: linux: set env FC_FONTATIONS and EGL_PLATFORM early Move Ozone pre-init from ElectronBrowserMainParts::PreEarlyInitialization() to ElectronMainDelegate::PreSandboxStartup() to match upstream's rename and relocation. The call has to run before threads are created. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7725187 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 7743280: Introduce client ID for network throttling conditions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7743280 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: disable ml-kem node test incompatible with BoringSSL test-crypto-pqc-key-objects-ml-kem: BoringSSL's ML-KEM support is inconsistent with the test's OpenSSL-version-based assumptions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test: update V8 serialization wire format version to 16 V8 14.9 (Chromium 149) bumped the serialization wire format from version 15 to 16. Update the hardcoded expected bytes in the test-v8-serdes.js test. Remove this patch once upstream Node.js catches up via its next V8 roll. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: clavin <clavin@electronjs.org>	2026-04-23 16:32:10 -05:00
Samuel Attard	abffba4548	fix: use CreateDataProperty when copying objects across contextBridge (#50900)	2026-04-16 12:39:53 +02:00
Shelley Vohr	a39108c5a4	fix: nodeIntegrationInWorker not working in AudioWorklet (#47244) ... * fix: nodeIntegrationInWorker not working in AudioWorklet * fix: deadlock on Windows when destroying non-AudioWorklet worker contexts The previous change kept the WebWorkerObserver alive across ContextWillDestroy so the worker thread could be reused for the next context (AudioWorklet thread pooling, Chromium CL:5270028). This is correct for AudioWorklet but wrong for PaintWorklet and other worker types, which Blink does not pool — each teardown destroys the thread. For those worker types, ~NodeBindings was deferred to the thread-exit TLS callback. By that point set_uv_env(nullptr) had already run, so on Windows the embed thread was parked in GetQueuedCompletionStatus with a stale async_sent latch that swallowed the eventual WakeupEmbedThread() from ~NodeBindings. uv_thread_join then blocked forever, deadlocking renderer navigation. The worker-multiple-destroy crash case timed out on win-x64/x86/arm64 as a result. macOS/Linux (epoll/kqueue) don't have the latch and were unaffected. Plumb is_audio_worklet from WillDestroyWorkerContextOnWorkerThread into ContextWillDestroy. For non-AudioWorklet contexts, restore the pre-existing behavior of calling lazy_tls->Set(nullptr) at the end of the last-context cleanup so ~NodeBindings runs while the worker thread is still healthy. AudioWorklet continues to keep the observer alive so the next pooled context can share NodeBindings. * chore: address review feedback * fix: stop embed thread before destroying environments in worker teardown FreeEnvironment (called via environments_.clear()) runs uv_run to drain handle close callbacks. On Windows, both that uv_run and the embed thread's PollEvents call GetQueuedCompletionStatus on the same IOCP handle. IOCP completions are consumed by exactly one waiter, so the embed thread can steal completions that FreeEnvironment needs, causing uv_run to block indefinitely. On Linux/Mac epoll_wait/kevent can wake multiple waiters for the same event so the race doesn't manifest. Add NodeBindings::StopPolling() which cleanly joins the embed thread without destroying handles or the loop, and allows PrepareEmbedThread + StartPolling to restart it later. Call StopPolling() in WebWorkerObserver::ContextWillDestroy before environments_.clear() so FreeEnvironment's uv_run is the only thread touching the IOCP. Split PrepareEmbedThread's handle initialization (uv_async_init, uv_sem_init) from thread creation via a new embed_thread_prepared_ flag so the handles survive across stop/restart cycles for pooled worklets while the embed thread itself can be recreated. * chore: address outstanding feedback	2026-04-13 10:27:30 +02:00
Alexey	8d8847d478	feat: capture JS stack trace on renderer OOM (#50043) ... * feat: capture JS stack trace on renderer OOM When a renderer process approaches its V8 heap limit, capture the JavaScript stack trace and write it to both a Crashpad crash key ("js-oom-stack") and stderr. The stack trace is captured via RequestInterrupt rather than directly inside the NearHeapLimitCallback because CurrentStackTrace is unsafe to call during OOM — V8 FATALs on optimized (TurboFan) frames that have had their deoptimization data garbage-collected. RequestInterrupt defers the capture to the next V8 safe point, where all frames are guaranteed to have deopt data available. This matches Node.js's approach of never capturing JS stacks inside the heap limit callback. The callback is registered once per isolate via an atomic guard in RendererClientBase::DidCreateScriptContext, preventing the CHECK failure V8 raises on duplicate AddNearHeapLimitCallback registrations (which would otherwise occur on page navigations or multiple contexts). Refs: #46078 Made-with: Cursor * Update shell/renderer/oom_stack_trace.cc Co-authored-by: Niklas Wenzel <dev@nikwen.de> * Update shell/renderer/oom_stack_trace.cc Co-authored-by: Niklas Wenzel <dev@nikwen.de> * test: add crash reporter test for OOM JS stack trace Add a test that verifies the `electron.v8-oom.stack` crash key contains the JS stack trace (including function names) when a renderer process runs out of memory. Also deduplicate the heap info formatting in oom_stack_trace.cc. Refs: #46078 Made-with: Cursor * fix: lint formatting in oom_stack_trace.cc Made-with: Cursor * fix: use proper logger API instead of cstdio * fix: check heap headroom before capturing OOM stack trace deepak1556: "Should there be check for available heap size [for] CurrentStackTrace and formatting" CurrentStackTrace allocates StackTraceInfo + StackFrameInfo on the V8 heap. If the 20 MB bump is partially consumed by the time the interrupt fires, these allocations trigger a secondary OOM. Guard with a 2 MB headroom check. Made-with: Cursor * fix: handle V8 cage limit when bumping heap for OOM stack capture deepak1556: "Does this bumping work when we are at the cage limit of 4GB" V8's pointer compression cage caps the heap at ~4 GB. When current_heap_limit is already near the ceiling, our 20 MB bump gets clamped to zero and the interrupt never fires. Detect this and record heap info as the final crash key instead of waiting for a stack trace that won't arrive. Made-with: Cursor * feat: add V8 heap statistics as OOM crash keys deepak1556: "V8 seems to capture heap stats as crash keys but it gets missed today due to the OOM callback override... wonder if we can include that to get some more heuristics in the dump." Record heap used/total/limit/available, per-space stats for old_space and large_object_space, native/detached context counts, and utilization percentage as crash keys. Also add heap stats in the V8OOMErrorCallback in node_bindings.cc for the final OOM crash report. Made-with: Cursor * feat: support worker thread isolates for OOM stack trace deepak1556: "You need a separate registration for worker threads via WorkerScriptReadyForEvaluationOnWorkerThread but that also means the process global g_registered_isolate would break." Chromium has one V8 isolate per thread (main + one per web worker), so thread_local is equivalent to per-isolate storage. Replace the global atomic + mutex/set with a constinit thread_local OomState* that holds the isolate pointer and per-isolate is_in_oom flag. The void* data parameter on AddNearHeapLimitCallback delivers OomState* directly into callbacks, so the hot path needs no TLS lookup. Add WorkerScriptReadyForEvaluationOnWorkerThread and WillDestroyWorkerContextOnWorkerThread overrides to RendererClientBase so both ElectronRendererClient and ElectronSandboxedRendererClient get worker OOM registration. Update ElectronRendererClient to call the base class in both worker lifecycle methods. Add a web worker OOM test that spawns a dedicated Worker with a memory leak and verifies the stack trace captures the worker function name. Made-with: Cursor * fix: register OOM callback for all script contexts When context isolation is enabled, ShouldNotifyClient skips DidCreateScriptContext for the main world, but user JS still runs there and can OOM. Register in DidInstallConditionalFeatures which fires for every script context. The TLS dedup guard prevents double-registration on the same isolate. Made-with: Cursor * fix: guard against division by zero and cage size changes in OOM handler Add a zero-guard on heap_size_limit before computing utilization percentage — maximizes robustness in an OOM code path. Add static_assert on kPtrComprCageReservationSize to catch any upstream V8 change to the cage size at compile time. Made-with: Cursor * fix: address review feedback on OOM stack trace PR - Remove redundant RegisterOomStackTraceCallback from electron_render_frame_observer.cc; DidCreateScriptContext is sufficient since main world and isolated world share the same isolate - Replace thread_local OomState* with base::ThreadLocalOwnedPointer wrapped in base::NoDestructor per Chromium style for non-trivially destructible types - Change heap-headroom and cage-limit logs from ERROR to INFO since users cannot act on these diagnostics - Add comment explaining why base class is called last in WillDestroyWorkerContextOnWorkerThread (OOM deregistration ordering) Made-with: Cursor * fix: skip OOM stack trace registration for worklet contexts Worklets can share a thread and isolate via WorkletThreadHolder's per-process singleton pattern. With per-thread OOM state, the first worklet to be destroyed would prematurely remove the callback for any remaining worklets on the same thread. Skip worklets entirely to avoid this; can be revisited with ref-counting if needed. Made-with: Cursor * fix: prevent dangling raw_ptr<v8::Isolate> in OOM state The OomState held a raw_ptr<v8::Isolate> that outlived the isolate on the main thread: gin::IsolateHolder destroyed the isolate during shutdown, but the OomState (stored in thread-local storage) was only released later in JavascriptEnvironment::~JavascriptEnvironment. This triggers a dangling pointer check when building with enable_dangling_raw_ptr_checks. Register OomState as a gin::PerIsolateData::DisposeObserver so it clears the raw_ptr and removes the NearHeapLimitCallback before the isolate is destroyed, regardless of destructor ordering. Suggested-by: Deepak Mohan Made-with: Cursor * test: verify OOM crash keys end-to-end via crash reporter Replace stderr-based OOM tests with end-to-end crash dump validation. Instead of parsing log output, start a crash reporter server, trigger renderer OOM, and verify the uploaded crash dump contains the expected `electron.v8-oom.*` annotations — the same code path production crash reports take. Consolidate all OOM test scenarios (basic heap leak, JSON.stringify, web worker) into a single `describe('OOM crash keys')` block inside api-crash-reporter-spec using the existing crash fixture app with new renderer-oom-json and renderer-oom-worker crash types. The web worker test verifies that OOM crash keys are present but does not assert on the JS function name: the 20 MB heap bump may be exhausted before V8 reaches a safe point to fire the stack-capture interrupt, leaving the crash key at "(stack pending)". Increasing the bump or switching to a synchronous capture strategy would fix this but is left for a follow-up. Remove the standalone oom-stack-trace-spec.ts and its fixture app. Made-with: Cursor --------- Co-authored-by: Niklas Wenzel <dev@nikwen.de>	2026-04-10 15:13:16 -04:00
Robo	9be03cbe54	fix: enable blink gc plugin (#50465) ... chore: address blink gc plugin errors Key fixes: - Replace `base::WeakPtrFactory` with `gin::WeakCellFactory` in MenuMac, MenuViews, and NetLog, since weak pointers to cppgc-managed objects must go through weak cells - Replace `v8::Global<v8::Value>` with `cppgc::Persistent<Menu>` for the menu reference in BaseWindow - Stop using `gin_helper::Handle<T>` with cppgc types; use raw `T*` and add a `static_assert` to prevent future misuse - Add proper `Trace()` overrides for Menu, MenuMac, MenuViews, and NetLog to ensure cppgc members are visited during garbage collection - Replace `SelfKeepAlive` prevent-GC mechanism in Menu with a `cppgc::Persistent` prevent-GC captured in `BindSelfToClosure` - Introduce `GC_PLUGIN_IGNORE` macro to suppress known-safe violations: mojo::Remote fields, ObjC bridging pointers, and intentional persistent self-references - Mark `ArgumentHolder` as `CPPGC_STACK_ALLOCATED()` in both Electron's and gin's function_template.h to silence raw-pointer-to-GC-type warnings	2026-04-11 03:21:39 +09:00
Charles Kerr	b417696d6b	refactor: migrate electron::api::Protocol to cppgc (#50857) ... refactor: migrate api::Protocol to cppgc	2026-04-10 15:58:33 +09:00
electron-roller[bot]	afd5fb4a60	chore: bump chromium to 148.0.7778.0 (main) (#50769) ... * chore: bump chromium in DEPS to 148.0.7776.0 * chore: bump chromium in DEPS to 148.0.7778.0 * fix(patch): buffered_data_source_host_impl include added upstream Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7712714 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fix(patch): ASan process info callback added upstream Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7724018 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fix(patch): ServiceProcessHost per-instance observer migration Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7700794 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fix(patch): FSA BlockPath factory method refactor Upstream refactored BlockPath initialization to use factory methods (CreateRelative, CreateAbsolute, CreateSuffix) and a switch statement. Updated the exposed code in the header to match. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7665590 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fix(patch): service process tracker per-instance observer refactor Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7700794 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * chore: update patches (trivial only) * 7723958: Rename blink::WebString::FromUTF16() to FromUtf16() Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7723958 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * fixup! fix(patch): ASan process info callback added upstream --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>	2026-04-08 13:34:24 -04:00
Charles Kerr	8679522922	chore: iwyu commonly-included headers in shell/ (#50778) ... * chore: iwyu in shell/browser/api/electron_api_web_contents.h * chore: iwyu in shell/browser/browser.h * chore: iwyu in shell/browser/javascript_environment.h * chore: iwyu in shell/common/gin_hhelper/function_template.h * chore: do not include node_includes.h if we are not using it * chore: fix transitive include	2026-04-08 09:33:42 -05:00
Charles Kerr	7eccea1315	refactor: remove use of deprecated class base::MemoryPressureListener (#50763)	2026-04-07 20:11:02 -05:00
electron-roller[bot]	6aaf490aa5	chore: bump chromium to 148.0.7768.0 (main) (#50599) ... * chore: bump chromium in DEPS to 148.0.7765.0 * chore: bump chromium in DEPS to 148.0.7766.0 * fix(patch-conflict): update packed_resources dep name after upstream rename Upstream renamed //chrome:packed_resources_integrity_header to //chrome:packed_resources. Updated the patch to guard the new dependency name with !is_electron_build while preserving the same intent. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7714543 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch-conflict): update code_cache_host_impl.cc for upstream includes and TODO Upstream added #include <stdint.h> and a TODO comment in code_cache_host_impl.cc which conflicted with the Electron code cache custom schemes patch. Resolved by keeping both upstream additions and the Electron ProcessLockURLIsCodeCacheScheme function. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7615151 Co-Authored-By: Claude <noreply@anthropic.com> * chore: update patch hunk headers Co-Authored-By: Claude <noreply@anthropic.com> * 7700837: update RecordContentToVisibleTimeRequest from mojom to native struct Upstream typemapped RecordContentToVisibleTimeRequest from a Mojo struct to a native C++ struct. Updated OSR virtual method signatures from blink::mojom::RecordContentToVisibleTimeRequestPtr to std::optional<blink::RecordContentToVisibleTimeRequest> and blink::RecordContentToVisibleTimeRequest to match. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7700837 Co-Authored-By: Claude <noreply@anthropic.com> * 7714579: update WebString::FromASCII to FromUTF8 Upstream renamed blink::WebString::FromASCII to FromAscii. Updated Electron's usage to FromUTF8 which is equivalent for ASCII scheme strings and avoids a dependency on the renamed method. Also fixed blink::String::FromUTF8 to use the String constructor directly. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7714579 Co-Authored-By: Claude <noreply@anthropic.com> * 7696480: add stream_info dep after StreamInfo extraction Upstream extracted extensions::StreamInfo from PdfViewerStreamManager to a standalone class in extensions/browser/mime_handler/stream_info.h. Added the new target as a dependency since Electron's streams_private and pdf_viewer_private APIs use PdfViewerStreamManager which now depends on the separate StreamInfo target. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7696480 Co-Authored-By: Claude <noreply@anthropic.com> * chore: bump chromium in DEPS to 148.0.7768.0 * fix(patch-conflict): update PiP patch for new toggle_mute_button in overlay window Upstream added a toggle_mute_button to the live caption dialog controls in VideoOverlayWindowViews::SetLiveCaptionDialogVisibility. Extended the existing #if 0 guard to include the new button handling since Electron disables live caption dialog functionality. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7682308 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch-conflict): update packed_resource_integrity patch after upstream dep removal Upstream removed the deps += [ "//chrome:packed_resources" ] line from the if (!is_win) block in chrome/browser/BUILD.gn. The Electron patch no longer needs to guard this dep with !is_electron_build in this location since the dep was already relocated by an earlier upstream CL. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7714543 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch-conflict): update WebSocket throttling revert for DisconnectWebSocketOnBFCache guard Upstream added a DisconnectWebSocketOnBFCacheEnabled() runtime feature check that wraps the WebSocket BFCache feature registration. Updated the Electron revert patch to place the kAllowAggressiveThrottlingWithWebSocket ternary inside the new conditional guard. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7698838 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch-conflict): update SCContentSharingPicker patch for upstream native picker refactor Upstream added is_native_picker and filter_ based native picker session validation to ScreenCaptureKitDeviceMac. Electron's patch uses its own native picker approach (active_streams_ counter + direct SCContentSharingPicker API), so marked the new upstream parameters as [[maybe_unused]] and kept Electron's implementation. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7713560 Co-Authored-By: Claude <noreply@anthropic.com> * chore: update patch hunk headers Co-Authored-By: Claude <noreply@anthropic.com> * 7708800: update StartDragging signature to use RenderFrameHost Upstream refactored StartDragging to take a RenderFrameHost& instead of separate source_origin and source_rwh parameters. Updated OffScreenWebContentsView to match the new signature and derive the RenderWidgetHostImpl from the RenderFrameHost internally. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7708800 Co-Authored-By: Claude <noreply@anthropic.com> * 7682308: add toggle_mute_button to chromium_src build sources Upstream added a ToggleMuteButton to the PiP overlay window controls. Added the new toggle_mute_button.cc/h source files to Electron's chromium_src/BUILD.gn to resolve linker errors. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7682308 Co-Authored-By: Claude <noreply@anthropic.com> * chore: update patches after main rebase * fixup! 7708800: update StartDragging signature to use RenderFrameHost fix linting * 7705541: [trap-handler] Track individual Wasm memories | https://chromium-review.googlesource.com/c/v8/v8/+/7705541 Moved the SetUpWebAssemblyTrapHandler() call to before the V8 isolate is created * fixup! fix utility process tests --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>	2026-04-06 20:38:46 -07:00
Samuel Attard	3e1666be08	chore: remove dead C++ code from shell/ (#50513) ... Removes unreferenced code found via codebase sweep. Each category below may indicate a missing feature rather than truly-unused code — see PR description. Dead class (1): ElectronNavigationUIData — never instantiated; ElectronBrowserClient uses upstream ExtensionNavigationUIData directly Unused methods (7): CertificateManagerModel: ImportUserCert, ImportCACerts, ImportServerCert, Delete, is_user_db_available (only PKCS12 path is used) AutofillDriverFactory::AddDriverForFrame + CreationCallback type ZoomLevelDelegate::SetDefaultZoomLevelPref gtk_util: GetOpenLabel, GetSaveLabel Unused members (2): AutofillPopup::selected_index_ InspectableWebContents::synced_setting_names_ Declaration fixes (6): menu_util.h: BuildMenuItemWithImage signature corrected (GtkWidget* → gfx::Image&) win_frame_view.h: GetReadableFeatureColor (impl removed, decl left behind) frameless_view.h: friend class NativeWindowsViews (typo, class does not exist) Forward decls: WebDialogHelper, ChromeContentRendererClient, ElectronNativeWindowObserver, ValueStoreFactory	2026-03-30 10:36:00 -07:00
Niklas Wenzel	4eff8f20f2	feat: make Chrome extensions work on custom protocols (#49951)	2026-03-26 20:00:51 -04:00
Shelley Vohr	ccb2c77c17	fix: InspectorFrontendHost override in embedded windows (#49794) ... fix: InspectorFrontendHost override in embedded windows	2026-03-09 10:53:02 +01:00
Samuel Attard	603679cb18	fix: read nodeIntegrationInWorker from per-frame WebPreferences (#50122) ... Previously the renderer checked a process-wide command-line switch to decide whether to create a Node.js environment for dedicated workers. When a renderer process hosted multiple WebContents with different nodeIntegrationInWorker values (e.g. via window.open with overridden webPreferences in setWindowOpenHandler), all workers in the process used whichever value the first WebContents set on the command line. Instead, plumb the flag through blink's WorkerSettings at worker creation time, copying it from the initiating frame's WebPreferences. The check on the worker thread then reads the per-worker value. Nested workers inherit the flag from their parent worker via WorkerSettings::Copy. The --node-integration-in-worker command-line switch is removed as it is no longer consumed.	2026-03-09 00:50:01 -07:00
electron-roller[bot]	9f80b64617	chore: bump chromium to 147.0.7719.0 (main) (#50061) ... * chore: bump chromium in DEPS to 147.0.7716.0 * chore: bump chromium in DEPS to 147.0.7717.0 * chore: bump chromium in DEPS to 147.0.7719.0 * chore: update patches Refs https://chromium-review.googlesource.com/c/chromium/src/+/7618634 Refs https://chromium-review.googlesource.com/c/chromium/src/+/7622595 * [Extensions] Track service worker lifecycle more precisely Refs https://chromium-review.googlesource.com/c/chromium/src/+/7567646 * Make Clipboard::ReadAsciiText|ReadData|ReadText|ReadAvailableTypes asynchronous Refs https://chromium-review.googlesource.com/c/chromium/src/+/7609958 https://chromium-review.googlesource.com/c/chromium/src/+/7600360 https://chromium-review.googlesource.com/c/chromium/src/+/7595942 https://chromium-review.googlesource.com/c/chromium/src/+/7594881 * fixup! Make Clipboard::ReadAsciiText|ReadData|ReadText|ReadAvailableTypes asynchronous --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2026-03-08 06:22:11 +09:00
Samuel Attard	838d30510f	fix: use destination context when wrapping VideoFrame in contextBridge (#49997) ... Enter the destination context scope before creating the VideoFrame V8 wrapper, matching the sibling Element and Blob branches. Without this, ScriptState::ForCurrentRealm resolved to the calling context instead of the target context, producing an incorrect wrapper. Also switch to ScriptState::From with an explicit context argument to make the intent clearer. Adds spec coverage for VideoFrame crossing the bridge in both directions and adds VideoFrame to the existing prototype checks.	2026-03-02 08:18:19 -08:00
Samuel Attard	ee76e549fa	fix: use setter's creation context when proxying setter in OverrideGlobalPropertyFromIsolatedWorld (#49990) ... The setter branch was deriving source_context from getter-> instead of setter->. Currently latent since the only call site passes both from the same preload context, but this would crash or mis-resolve if a future call site passed a setter without a getter or from a different context.	2026-03-02 08:18:00 -08:00
electron-roller[bot]	227cc02aee	chore: bump chromium to 147.0.7703.0 (main) (#49935) ... * chore: bump chromium in DEPS to 147.0.7702.0 * chore: update patches (trivial only) Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * chore: bump chromium in DEPS to 147.0.7703.0 * 7582039: [Extensions] Use dependency injection for ManifestHandlerRegistry Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7582039 Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * 7582477: spanification: migrate base::ReadUnicodeCharacter usage to string_view Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7582477 Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * chore: update patches (trivial only) Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * 7590029: Remove 5 unused deprecated sync methods in ui::Clipboard Migrate clipboard API calls from synchronous methods to async callback-based methods with RunLoop pattern. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7590029 * 7599553: [rust png] Chromium: Update `png` to version `0.18.1`. https://chromium-review.googlesource.com/c/chromium/src/+/7599553 Chromium updated their to Rust PNG implementation which produces different (but valid) PNG output. Update tests to compare raw bitmap data instead of encoded PNG data URLs. * test: fixup clipboard tests to properly handle urls Needed after migrating clipboard API calls from synchronous methods to async callback-based methods with RunLoop pattern. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7590029 * fixup "7599553: [rust png] Chromium: Update `png` to version `0.18.1`." https://chromium-review.googlesource.com/c/chromium/src/+/7599553 Chromium updated their Rust PNG implementation which produces different (but valid) PNG data URLs. --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>	2026-02-26 08:21:31 -05:00
Robo	05061544ab	feat: enable WASM trap handlers in all Node.js processes (#48983) ... fix: enable WASM trap handlers in all Node.js processes ``` Original reason for revert: Some apps started throwing exception on startup https://github.com/electron/electron/issues/48956 ``` We now move the trap handler registeration before any user script execution. Add a fuse to support disabling the feature is application needs to run in memory constrained environments.	2026-02-18 12:08:03 +09:00
electron-roller[bot]	a65cfed500	chore: bump chromium to 146.0.7666.0 (main) (#49528) ... * chore: bump chromium in DEPS to 146.0.7652.0 * fix(patch-conflict): update mas_avoid_private_macos_api_usage context for constrainFrameRect method The upstream CL added a new constrainFrameRect:toScreen: method override to NativeWidgetMacNSWindow as part of headless mode window zoom implementation. The MAS patch's #endif for frameViewClassForStyleMask now correctly appears after that method, since constrainFrameRect is a public API override that doesn't need to be guarded. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7487666 * fix(patch-conflict): update printing.patch for base::DictValue rename Updated printing.patch to use the new base::DictValue type name instead of base::Value::Dict following Chromium's type renaming change. This affects CompleteUpdatePrintSettings() signature and related code. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * fix(patch-conflict): update accessibility_ui patch for base::DictValue/ListValue rename Updated adjust_accessibility_ui_for_electron.patch to use the new base::DictValue and base::ListValue type names instead of base::Value::Dict and base::Value::List following Chromium's type renaming change. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * chore: update patches * 6625736: Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency | https://chromium-review.googlesource.com/c/chromium/src/+/6625736 * chore: bump chromium in DEPS to 146.0.7653.0 * chore: update patches * 7000847: add type tag to v8::External for gin_helper function templates The upstream gin function templates now use v8::ExternalPointerTypeTag for type safety when using v8::External. Updated Electron's forked gin_helper function template to use the same kGinInternalCallbackHolderBaseTag that Chromium's gin uses. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * fix(patch-update): extend V8 Object API deprecation patch for Node.js Extended the existing patch to cover additional files that use GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField: - src/stream_base-inl.h - src/udp_wrap.cc - src/js_udp_wrap.cc - src/node_process_methods.cc - src/node_snapshotable.cc - src/base_object.cc These APIs now require an EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * 7000847: add type tag to v8::External calls in shared_texture Updated v8::External::New and v8::External::Value calls to use the kExternalPointerTypeTagDefault tag as required by the V8 API change that deprecates the tagless versions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * 7508687: use ChildProcessId for file permission APIs The ChildProcessSecurityPolicy::CanReadFile and GrantReadFile APIs now require ChildProcessId instead of int. Updated to use GetID() instead of GetDeprecatedID() for these specific calls. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7508687 * 7000847: add type tag to v8::External calls in callback and osr_converter The v8::External API now requires an EmbedderPointerTypeTag parameter for both New() and Value() methods to improve V8 sandbox type safety. Updated calls in: - callback.cc: TranslatorHolder constructor and CallTranslator - osr_converter.cc: OffscreenSharedTextureValue converter Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7000847 * fixup! 7087956: [api] Promote deprecation of v8::Context and v8::Object API methods Extended the Node.js patch to cover histogram.cc which also uses SetAlignedPointerInInternalField and GetAlignedPointerFromInternalField APIs that now require the EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * chore: bump chromium in DEPS to 146.0.7655.0 * chore: update patches * 7509043: update WebSpellingMarker type for API change The upstream Chromium API changed - WebSpellingMarker was moved from a nested type within WebTextCheckClient to a standalone type in the blink namespace. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509043 * 7498491: update process_id to use OriginatingProcess type The upstream Chromium API changed - URLLoaderFactoryParams::process_id was changed from an integer to a union type network::OriginatingProcess that distinguishes between browser and renderer processes. - For browser process requests, use OriginatingProcess::browser() - For renderer process lookups, check !is_browser() and use renderer_process().value() to get the child_id Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7498491 * 5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception | https://chromium-review.googlesource.com/c/chromium/src/+/5710330 5710330 added a new NSNextStepFrame interface extension and implementations for NativeWidgetMacNSWindowTitledFrame and NativeWidgetMacNSWindowBorderlessFrame. These use private macOS APIs that are not available in Mac App Store builds. * chore: update patches * chore: bump chromium in DEPS to 146.0.7661.0 * chore: bump chromium in DEPS to 146.0.7663.0 * fix(patch-conflict): update accessibility_ui for string_view API change Upstream removed redundant std::string(default_api_type) conversion as part of a string_view optimization cleanup. Updated patch context to match. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7514107 * fix(patch-conflict): update service process launch options for sandbox API refactor Upstream removed content/common/sandbox_init_win.cc and content/public/common/sandbox_init_win.h, moving the functionality directly into ChildProcessLauncherHelper. Updated patch to call sandbox::policy::SandboxWin::StartSandboxedProcess directly with the LaunchOptions pointer instead of going through the removed helper. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7528253 * fix(patch-conflict): update MAS safestorage for keychain API refactor Upstream refactored KeychainPassword::GetPassword() to use a new GetPasswordImpl() helper function with improved error tracking via base::expected<std::string, OSStatus>. Adapted patch to use the new GetPasswordImpl with the suffixed account name and handle migration from legacy accounts through the new API. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7516438 * chore: update patches * chore: bump chromium in DEPS to 146.0.7663.0 * fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: include new cookie exclusion reason https://chromium-review.googlesource.com/c/chromium/src/+/7486527 * fix: enable libc++ ABI flag for trivially copyable std::vector<bool> Required for changes introduced in the following CL https://chromium-review.googlesource.com/c/chromium/src/+/7513653 * fixup! fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: spellcheck not working in tests https://chromium-review.googlesource.com/c/chromium/src/+/7452579 * fix: cookie test failing due to multiple rejection reasons https://chromium-review.googlesource.com/c/chromium/src/+/7506629 * fix: macos sizing unmaximized window incorrectly https://chromium-review.googlesource.com/c/chromium/src/+/7487666 Changes to headless mode caused the unmaximized window to subtract the height of the menubar. * fix: skip tests for incompatible BoringSSL ML-DSA crypto https://boringssl-review.googlesource.com/c/boringssl/+/84929 * test: fix pseudonymization registration in utility process on Linux Ref: 7486913: Pass pseudonymization salt via shared memory at process launch | https://chromium-review.googlesource.com/c/chromium/src/+/7486913 * fix: restore MAS patch-outs Restores some `#if !IS_MAS_BUILD()` gates dropped in 773054ad59 * fixup! 7508687: use ChildProcessId for file permission APIs * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor * chore: add note about parallel upstream change * fixup! Merge remote-tracking branch 'origin/main' into roller/chromium/main * Revert "fixup! 7508687: use ChildProcessId for file permission APIs" This reverts commit 05c43e4e5d. The _impl version has the signature, but not the public interface. :oof: * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org> Co-authored-by: clavin <clavin@electronjs.org>	2026-02-12 12:37:56 -05:00
electron-roller[bot]	b847299f19	chore: bump chromium to 146.0.7650.0 (main) (#49496) ... * chore: bump chromium in DEPS to 146.0.7650.0 * 7496671: WaaP: Control hung delay for Initial WebUI Refs https://chromium-review.googlesource.com/c/chromium/src/+/7496671 * 7494302: [//media] Rename renderable_gpu_memory_buffer_video_frame_pool* Refs https://chromium-review.googlesource.com/c/chromium/src/+/7494302 * chore: update patches * 7502996: [DevTools] Add ability to toggle Chromium feature flags from DevTools Refs https://chromium-review.googlesource.com/c/chromium/src/+/7502996 * 7456200: Vectorize StringImpl::CopyChars and EqualIgnoringASCIICase using Highway. Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200 * 7236627: spellcheck: supply full spelling marker info, incld. marker type Refs https://chromium-review.googlesource.com/c/chromium/src/+/7236627 * chore: rm dependency on wtf::string from blink public headers Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200 added a public dependency on //third_party/highway for //third_party/blink/renderer/platform/wtf:wtf which will not be inherited by //content/renderer since wtf is internal dependency of blink leading to the following compilation error ``` In file included from ../../content/public/renderer/window_features_converter.cc:5: In file included from ../../content/public/renderer/window_features_converter.h:10: In file included from ../../third_party/blink/public/web/web_window_features.h:38: In file included from ../../third_party/blink/renderer/platform/wtf/text/wtf_string.h:40: ../../third_party/blink/renderer/platform/wtf/text/string_impl.h:27:10: fatal error: 'hwy/highway.h' file not found 27 | #include <hwy/highway.h> | ^~~~~~~~~~~~~~~ 1 error generated. ``` Use `gn desc out/Testing content/renderer:renderer_sources --blame` to verify the inherited config and dependency list. * 7493995: Restore directive part of wasm-eval error message Refs https://chromium-review.googlesource.com/c/chromium/src/+/7493995 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2026-01-26 11:18:09 -08:00
electron-roller[bot]	d689f76ff9	chore: bump chromium to 146.0.7645.0 (main) (#49453) ... * chore: bump chromium in DEPS to 146.0.7643.0 * chore: bump chromium in DEPS to 146.0.7645.0 * chore: update patches * 7402162: Refactor app shims to call ContentMain Refs https://chromium-review.googlesource.com/c/chromium/src/+/7402162 * 7454282: Add master key management for HTTP Cache Encryption Refs https://chromium-review.googlesource.com/c/chromium/src/+/7454282 * 7490440: Reland "Delete unused base::Contains()" Refs https://chromium-review.googlesource.com/c/chromium/src/+/7490440 * chore: update patches * 7414864: Pass CSSParserLocalContext down to CSSMathExpressionNodeParser Refs https://chromium-review.googlesource.com/c/chromium/src/+/7414864 * 7460969: Move child_process_id.h to common Refs https://chromium-review.googlesource.com/c/chromium/src/+/7460969 * 7474608: [api] Remove deprecated v8::PropertyCallbackInfo<T>::This() Refs https://chromium-review.googlesource.com/c/v8/v8/+/7474608 * 7461067: [Viz] Rename kPreferGpuMemoryBuffer Refs https://chromium-review.googlesource.com/c/chromium/src/+/7461067 * 7487174: Remove GLHelper Refs https://chromium-review.googlesource.com/c/chromium/src/+/7487174 * 7457538: Set timeout from multi source page context fetcher Refs https://chromium-review.googlesource.com/c/chromium/src/+/7457538 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>	2026-01-22 17:01:09 -05:00
Shelley Vohr	bad88c6ed4	fix: potential devtools crash on empty (#49468)	2026-01-21 17:05:26 -08:00
Charles Kerr	cf2e283332	fix: clang-tidy warnings, pt. 1 (#49083) ... * fix: google-readability-casting warning about the uint32_t cast * fix: modernize-use-equals-default warnings * fix: readability-redundant-member-init warning * fix: modernize-make-unique warnings * fix: modernize-use-emplace warning: use emplace_back instead of push_back * refactor: address code review feedback	2026-01-09 22:57:38 -08:00
electron-roller[bot]	809ab09b6f	chore: bump chromium to 145.0.7596.0 (main) (#49224) ... * chore: bump chromium in DEPS to 145.0.7588.0 * fix(patch-conflict): update scroll_bounce_flag for split overscroll methods Chromium split IsElasticOverscrollEnabled() into two methods: IsElasticOverscrollEnabledOnRoot() and IsElasticOverscrollSupported(). Updated patch to apply the scroll-bounce command-line switch to both methods. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7233733 * fix(patch-conflict): update exclusive_access patch context Upstream refactored the profile variable declaration. Updated patch to match new surrounding context with brace-style if statement. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7239252 * fix(patch-conflict): update screen capture kit non-shareable filter Upstream refactored PiP window exclusion to use GetWindowsToExclude() helper function. Updated patch to combine non-shareable window filtering with the new helper's output. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7274596 * fix(patch-conflict): update corner smoothing CSS property id position Upstream added new internal overscroll CSS properties. Updated patch to add kElectronCornerSmoothing after the new entries. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7234051 * fix(patch-conflict): update permission patches for new permission types Upstream added new permission types: LOCAL_NETWORK, LOOPBACK_NETWORK, and GEOLOCATION_APPROXIMATE. Updated Electron permission patches to include these new types and renumber Electron-specific permissions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7231952 * fix(patch-conflict): update memory query fallback for new function signature Upstream added AmountOfTotalPhysicalMemory() with PCHECK. Updated patch to maintain fallback logic with correct ByteSize return type. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254886 * chore: update patch hunk headers * fix(patch): update reclient-configs patch to use new file mode The fix_add_python_remote_wrapper patch was using 'copy from' mode which caused inconsistent behavior between local and CI git versions. Changed to 'new file' mode for consistent patch application. * fix(patch-conflict): remove duplicate GEOLOCATION_APPROXIMATE case Upstream moved GEOLOCATION_APPROXIMATE earlier in the switch statement in GetPermissionString(). The 3-way merge kept both the old and new positions, causing a duplicate case error. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/6397637 * chore: update libcxx filenames for new headers * chore: bump chromium in DEPS to 145.0.7590.0 * chore: update patch hunk headers * fix(patch): update memory fallback return type to ByteSize Upstream changed the return type from ByteCount to ByteSize. * fix: suppress nodiscard warning in node_file.cc libc++ added [[nodiscard]] to std::filesystem::copy_options operator|= which causes build failures with -Werror. * 7229082: update CopyFromSurface to use CopyFromSurfaceResult Upstream changed CopyFromSurface callback to return base::expected<viz::CopyOutputBitmapWithMetadata, std::string> instead of SkBitmap, enabling better error handling. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7229082 * 7254070: add ip_address_space param to OnLocalNetworkAccessPermissionRequired Upstream added IPAddressSpace parameter to check address space for proper permission handling in Local Network Access. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254070 * 7136679: add spelling_markers param to RequestCheckingOfText Upstream added spelling_markers parameter to report misspelling ranges from Blink to Spellcheck to IME. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7136679 * 7240487: remove second param from RegisterWebSafeIsolatedScheme Upstream removed the schemes_okay_to_appear_as_origin_headers_ parameter. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7240487 * 7254577: use explicit WebElement constructor WebElement default constructor now requires explicit construction rather than brace initialization. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254577 * 7256335: remove override from CreateGlobalFeaturesForTesting Upstream removed BrowserProcess::CreateGlobalFeaturesForTesting virtual method so the override specifier is no longer valid. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7256335 * chore: add missing SingleThreadTaskRunner include A transitive include of SingleThreadTaskRunner was removed upstream, requiring an explicit include. Ref: Unable to locate specific CL (transitive include change) * 7260483: add LOCAL_NETWORK, LOOPBACK_NETWORK permission type cases Upstream added new permission types for Local Network Access split permissions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7260483 * chore: update patch hunk headers * 7264893: update postMessage tests for file: origin serialization change Chromium now serializes file: origins as 'null' in MessageEvent per spec. This is a security improvement aligning with the HTML spec behavior. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7264893 * fix: add paths to custom scheme URLs in protocol tests Custom scheme URLs without paths (e.g. test-scheme://foo) cause a DCHECK crash in ASAN builds when CorsURLLoader tries to log the request via GenerateRequestLine -> PathForRequest, which asserts that the path is non-empty. Adding trailing slashes ensures URLs have valid paths. * chore: bump chromium in DEPS to 145.0.7592.0 * chore: update patches (trivial only) * chore: bump chromium in DEPS to 145.0.7594.0 * chore: bump chromium in DEPS to 145.0.7596.0 * chore: update accelerator.patch no manual changes; patch applied with fuzz 2 (offset 1 line) * chore: update patches (trivial only) * chore: node ./script/gen-libc++-filenames.js --------- Co-authored-by: Alice Zhao <alicelovescake@anthropic.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>	2025-12-25 17:15:53 -06:00
electron-roller[bot]	95e87e46ab	chore: bump chromium to 144.0.7547.0 (main) (#49058) ... * chore: bump chromium in DEPS to 144.0.7543.0 * Pass PipScreenCaptureCoordinatorProxy to ScreenCaptureKitDeviceMac https://chromium-review.googlesource.com/c/chromium/src/+/7157590 * chore: update patches * chore: update filenames.libcxx.gni * 7142359: Spanification of process_singleton_posix.cc https: //chromium-review.googlesource.com/c/chromium/src/+/7142359 Co-Authored-By: Charles Kerr <70381+ckerr@users.noreply.github.com> * Move logging::LoggingSettings to base/logging/logging_settings.h https://chromium-review.googlesource.com/c/chromium/src/+/7173024 * chore: bump chromium in DEPS to 144.0.7545.0 * 7159368: update PluginService API for sync GetPlugins Upstream removed async PluginService APIs: - GetPluginsAsync() removed, use synchronous GetPlugins() - RegisterInternalPlugin() now takes single argument (remove add_at_beginning) - RefreshPlugins() removed entirely Updated ElectronPluginInfoHostImpl to use synchronous plugin loading and simplified ElectronBrowserMainParts internal plugin registration. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159368 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159328 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159056 (cherry picked from commit 88cdf50b0a) * 7159184: add missing base/files/file_path.h include Add explicit include for base/files/file_path.h in electron_browser_context.h. After removal of superfluous Mojo includes from content headers, base::FilePath is no longer transitively included via content/public/browser/browser_context.h. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159184 (cherry picked from commit 6ca8ea03ec) * 7126479: add ShouldForceRefreshTextCheckService parameter to SpellCheckClient Upstream added a force-refresh parameter to WebTextCheckClient::RequestCheckingOfText to bypass spell check cache. Add the new ShouldForceRefreshTextCheckService parameter to SpellCheckClient's override (currently unused in Electron). Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7126479 (cherry picked from commit 879c0401c4) * 7083663: remove fingerprinting_protection_ruleset_service override Upstream deleted external references to Fingerprinting Protection Filter (FPF) component. Remove the fingerprinting_protection_ruleset_service() override from BrowserProcessImpl as the method no longer exists in the base class. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7083663 (cherry picked from commit 8350d152f9) * 7155287: implement WebContentsView::GetSize and Resize Upstream delegated WebContents::GetSize() and Resize() to WebContentsView, making them pure virtual. Add const qualifier to GetSize() and implement the Resize() override in OffScreenWebContentsView (no-op for offscreen). Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7155287 (cherry picked from commit 084eaa568e) * 7184238: add OnUnconfirmedTapConvertedToTap override Upstream added OnUnconfirmedTapConvertedToTap as a pure virtual method to RenderWidgetHostViewBase to inform root view when child frame converts an unconfirmed tap. Add empty override for offscreen rendering. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7184238 (cherry picked from commit ef03400d9a) * 7143586: add widget parameter to OnCommandsChanged GlobalAcceleratorListener::OnCommandsChanged gained a gfx::AcceleratedWidget parameter for window association in the GlobalShortcutListenerLinux implementation. Pass gfx::kNullAcceleratedWidget for Electron's usage. Ref: : Pass parent handle to GlobalAcceleratorListenerLinux::BindShortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/7143586 (cherry picked from commit 38306e2bfc) Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> * chore: update patches Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> * chore: bump chromium in DEPS to 144.0.7547.0 * chore: update patches * 7189232: Add support for UnownedUserData in GlobalFeatures https: //chromium-review.googlesource.com/c/chromium/src/+/7189232 * Refactor: Use std::u16string for extension load error messages https://chromium-review.googlesource.com/c/chromium/src/+/7185844 * fixup Add support for UnownedUserData in GlobalFeatures * 7165650: Remove ResourceContext https://chromium-review.googlesource.com/c/chromium/src/+/7165650 * fixup BUILD.gn for lint * 7202164: Reland "Reland "Remove GenericScopedHandle:IsValid"" https://chromium-review.googlesource.com/c/chromium/src/+/7202164 * advance deprecation of v8::ReturnValue<void>::Set(Local<S>). 7168624: [runtime][api] Relax requirements for setter/definer/deleter callbacks | https://chromium-review.googlesource.com/c/v8/v8/+/7168624 * fixup advance deprecation of v8::ReturnValue<void>::Set(Local<S>) * chore: skip setting LPAC ACLs * Revert "chore: skip setting LPAC ACLs" This reverts commit e187aec488. * chore: revert Convert to UNSAFE_TODO in sandbox revert https://chromium-review.googlesource.com/c/chromium/src/+/7131661 to see if it fixes the Windows sandbox issue. * Revert "chore: revert Convert to UNSAFE_TODO in sandbox" This reverts commit 57afbfefe5. * chore: Revert "Enable network sandbox by default on Windows" see if this fixes the Windows sandbox issue * Enable network sandbox by default on Windows https://chromium-review.googlesource.com/c/chromium/src/+/7204292 * Revert "chore: Revert "Enable network sandbox by default on Windows"" This reverts commit 530ab6af82. * fixup! Enable network sandbox by default on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/7204292 * fixup!: Correct flag name, add kLocalNetworkAccessChecks to all platforms --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <70381+ckerr@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@anthropic.com> Co-authored-by: Samuel Attard <MarshallOfSound@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>	2025-12-04 16:40:04 -08:00
Keeley Hammond	3809093511	build: add header for SetStackDumpFirstChanceCallback in renderer client (#48978)	2025-11-15 11:32:08 +01:00
Keeley Hammond	71be38f87f	fix: revert enabling WASM trap handlers in all Node.js processes (#48973) ... Revert "fix: enable wasm trap handlers in all Node.js processes (#48788)" This reverts commit ca0b46b413.	2025-11-14 15:23:15 -08:00
Robo	87d1ff59cb	build: add missing header for SetStackDumpFirstChanceCallback (#48860)	2025-11-10 18:12:02 +09:00
electron-roller[bot]	595920a308	chore: bump chromium to 144.0.7512.1 (main) (#48768) ... * chore: bump chromium in DEPS to 144.0.7507.0 * chore: bump chromium in DEPS to 144.0.7508.0 * chore: update patches * 7101838: [pathbuilder] Enforce immutable SkPath APIs globally https://chromium-review.googlesource.com/c/chromium/src/+/7101838 * chore: update filenames.libcxx.gni * [pathbuilder] Enforce immutable SkPath APIs globally https://chromium-review.googlesource.com/c/chromium/src/+/7101838 * Reduce service_worker_info.h includes in headers https://chromium-review.googlesource.com/c/chromium/src/+/7108401 * chore: bump chromium in DEPS to 144.0.7510.0 * chore: update patches * Use internal popup menus for tabs in actor-controlled states https://chromium-review.googlesource.com/c/chromium/src/+/7074751 * [api] Delete deprecated fields on v8::Isolate https://chromium-review.googlesource.com/c/v8/v8/+/7081397 xref: 98d243aea0 * Fixup Reduce service_worker_info.h includes in headers * Promote deprecation of v8::Context and v8::Object API methods https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * fixup Promote deprecation of v8::Context and v8::Object API methods * chore: bump chromium in DEPS to 144.0.7512.1 * chore: update patches * fixup [pathbuilder] Enforce immutable SkPath APIs global * chore: update filenames.hunspell.gni * fix deprecation of v8::Context and v8::Object API methods for nan https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * [PDF] Implement PdfHelpBubbleHandlerFactory https://chromium-review.googlesource.com/c/chromium/src/+/7056325 also: [PDF Ink Signatures] Hook up IPH https://chromium-review.googlesource.com/c/chromium/src/+/7056207 * Remove base/hash/md5.h https://chromium-review.googlesource.com/c/chromium/src/+/7113738 * fixup for lint * Remove deprecated interceptor callback types and AccessControl enum https://chromium-review.googlesource.com/c/v8/v8/+/7112747 * fixup for lint * fixup [PDF] Implement PdfHelpBubbleHandlerFactory * use base::SHA1HashString instead of std::hash --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2025-11-07 10:13:45 -05:00
Robo	ca0b46b413	fix: enable wasm trap handlers in all Node.js processes (#48788) ... * fix: enable wasm trap handlers in all Node.js processes * fix: separate registrations to account for featurelist init	2025-11-07 20:56:51 +09:00
BILL SHEN	513a6ee80a	fix: draw smoothing round rect corner (#48769)	2025-11-05 10:33:05 +01:00
electron-roller[bot]	ba135e2f7f	chore: bump chromium to 144.0.7506.0 (main) (#48744) ... * chore: bump chromium in DEPS to 144.0.7504.0 * chore: bump chromium in DEPS to 144.0.7506.0 * chore: update patches * Revert "build: explicitly disable reclient" This reverts commit e08c6adb08. No longer needed after https://crrev.com/c/7099239 * 7097498: Remove MSG_ROUTING_* constants from ipc_message.h https://chromium-review.googlesource.com/c/chromium/src/+/7097498 * 7090671: [//gpu] Remove unneeded GpuInfo methods https://chromium-review.googlesource.com/c/chromium/src/+/7090671 * 7103701: Remove IPC::PlatformFileForTransit. https://chromium-review.googlesource.com/c/chromium/src/+/7103701 (This should have been removed with https://github.com/electron/electron/pull/17406). * chore: update filenames.libcxx.gni --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2025-11-03 21:26:16 -08:00
electron-roller[bot]	9235dc0159	chore: bump chromium to 143.0.7485.0 (main) (#48618) ... * chore: bump chromium in DEPS to 143.0.7485.0 * chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264 Patch applied manually due to context shear * Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264 * chore: e patches all * chore: check for file existence before setting utime * chore: stop disabling kWinDelaySpellcheckServiceInit [cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087 This flag has been removed upstream. We've used it since c2d7164 (#38248) to fix a crash originally described in 97b353a (#34993): > Delaying spell check initialization is causing specs for > 'custom dictionary word list API' to fail in Electron. Since we haven't touched this in a few years, and since there's a clear success criteria (a passing/failing spec), and since the patch to restore this flag would be pretty large (~750 lines), I'm going to try just removing the flag from our source to see if the spec passes or fails. * Revert "chore: stop disabling kWinDelaySpellcheckServiceInit" This reverts commit e688880396. Unfortunately, the crash persists. * Revert [cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087 We currently need this feature * fixup! chore: check for file existence before setting utime * fixup! Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264 Address Robo's code review @ 64c7fd21ed * fixup! fixup! chore: check for file existence before setting utime fix: oops typo --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>	2025-10-23 08:30:29 -05:00
electron-roller[bot]	1cc2fce905	chore: bump chromium to 143.0.7477.0 (main) (#48584) ... * chore: bump chromium in DEPS to 143.0.7477.0 * 7049117: [CodeCache] Adjust PersistentCache for CodeCache feature Refs https://chromium-review.googlesource.com/c/chromium/src/+/7049117 * chore: update patches * chore: add missing includes of ui/gfx/image/image_skia.h * 7028738: Rename several ipc_* files used by param_traits* Refs https://chromium-review.googlesource.com/c/chromium/src/+/7028738 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>	2025-10-19 21:46:34 +02:00
electron-roller[bot]	3bfe1f2363	chore: bump chromium to 143.0.7474.0 (main) (#48572) ... * chore: bump chromium in DEPS to 143.0.7474.0 * 7006208: [Mac] Fix rendering bug for manual occlusion detection on macOS 26 Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006208 * chore: update patches * 7038563: Forward declare more in page_navigator.h Refs https://chromium-review.googlesource.com/c/chromium/src/+/7038563 * 7023417: Remove ipc/ipc_message_macros.h Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023417 * 7006340: Move icon_util files to win/ subdrectory Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006340 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>	2025-10-17 13:04:24 -04:00
electron-roller[bot]	471a14432f	chore: bump chromium to 143.0.7469.0 (main) (#48548) ... * chore: bump chromium in DEPS to 143.0.7469.0 * 7021651: [//gpu] Fold handle creation into D3DImageBackingFactory Refs https://chromium-review.googlesource.com/c/chromium/src/+/7021651 * 7013047: Fix various C++23 build errors in //chrome Refs https://chromium-review.googlesource.com/c/chromium/src/+/7013047 * 7010850: [//ui] Port screen_mac.mm's calls to DisplayColorSpaces Refs https://chromium-review.googlesource.com/c/chromium/src/+/7010850 * 7007933: Remove superfluous mojom includes in //content/public headers Refs https://chromium-review.googlesource.com/c/chromium/src/+/7007933 * 7023196: Trim os_crypt/sync visibility list Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023196 * 7008912: Remove GURL::*_piece() method Refs https://chromium-review.googlesource.com/c/chromium/src/+/7008912 * 7003989: Add wrapper struct for CopyFromSurface output Refs https://chromium-review.googlesource.com/c/chromium/src/+/7003989 * 7017889: [MemoryPressureListener] Remove type aliases Refs https://chromium-review.googlesource.com/c/chromium/src/+/7017889 * 7027780: Delete viz::ResourceSizes Refs https://chromium-review.googlesource.com/c/chromium/src/+/7027780 Refs https://chromium-review.googlesource.com/c/chromium/src/+/6989572 * 6495189: [api] Delete old String::Write* APIs Refs https://chromium-review.googlesource.com/c/v8/v8/+/6495189 * chore: update patches * chore: run script/gen-libc++-filenames.js --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>	2025-10-15 14:10:10 -07:00
Charles Kerr	38e491689a	perf: avoid a little extra work in InvokeIpcCallback() (#48456) ... perf: two minor perf refactors in InvokeIpcCallback() 1. Allocate the CallbackScope on the stack instead of the heap 2. Skip a redundant call to node::Environment::GetCurrent()	2025-10-04 21:52:53 -07:00
Charles Kerr	01cab978f7	refactor: remove gin_helper::Arguments (#48374) ... * refactor: make api::Clipboard::GetClipboardBuffer() private * refactor: move GetClipboadBuffer() into anonymous namespace * refactor: use gin::Arguments in StopRecording() * refactor: use gin::Arguments in ImageView::New() * refactor: use gin::Arguments in AppendSwitch() * refactor: use gin::Arguments WebContentsView::New() * refactor: make gin::Arguments arg const in WrappableBase::InitWithArgs() This makes explicit that we are using it for wrapper + isolate, not the args values * refactor: remove gin_helper::Arguments arg from ExposeAPI() refactor: remove gin_helper::Arguments arg from ExposeAPIInWorld() * refactor: remove gin_helper::Arguments arg from ElectronBindings::GetSystemMemoryInfo() * refactor: remove gin_helper::Arguments arg from preload_utils::GetBinding() * refactor: use gin::Arguments in OpenExternal() * refactor: use gin::Arguments in ExecuteInWorld() * refactor: use gin::Arguments in ExecuteJavaScript() * refactor: use gin::Arguments in InvokeNew() * refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld() * refactor: remove unused GetNextArgument() marshaller for gin_helper::Arguments * refactor: remove unused #include gin_helper/arguments.h * chore: remove unused gin_helper::Arguments * fixup! refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld() Xref: https://github.com/electron/electron/pull/48447	2025-10-03 14:10:29 -05:00
Charles Kerr	6bbbc1232e	chore: remove unused, undocumented, untested executionMode arg from web_frame.executeJavaScriptInIsolatedWorld() (#48361) ... chore: remove unused, undocumented execution mode arg from web_frame.executeJavaScriptInIsolatedWorld()	2025-09-24 08:13:49 -05:00
electron-roller[bot]	1fda08b8c8	chore: bump chromium to 142.0.7417.0 (main) (#48275) ... * chore: bump chromium in DEPS to 142.0.7401.0 * 6911185: Reland "Send touch moves async immediately after scroll starts." https://chromium-review.googlesource.com/c/chromium/src/+/6911185 * 6906887: mac: click through content area in main window https://chromium-review.googlesource.com/c/chromium/src/+/6906887 * 6916667: Expose helper to eliminate duplicate recipes. https://chromium-review.googlesource.com/c/chromium/src/+/6916667 * 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h. https://chromium-review.googlesource.com/c/chromium/src/+/6909842 * 6884056: Remove the SecKeychain implementation for the Keychain interface https://chromium-review.googlesource.com/c/chromium/src/+/6884056 * 6904906: Remove `WTF::` in renderer/core/[p-x].*/ https://chromium-review.googlesource.com/c/chromium/src/+/6904906 * 6556585: [persistent_cache]: PersistentCache for CodeCache https://chromium-review.googlesource.com/c/chromium/src/+/6556585 * 6904864: Layout: Support abort on the text placeholder layout https://chromium-review.googlesource.com/c/chromium/src/+/6904864 * chore: fixup patch indices * chore: bump chromium in DEPS to 142.0.7402.0 * fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache * chore: fixup patch indices * 6905244: [api] Remove deprecated `GetIsolate` https://chromium-review.googlesource.com/c/v8/v8/+/6905244 * 6897694: Remove NativeTheme::UserHasContrastPreference(). https://chromium-review.googlesource.com/c/chromium/src/+/6897694 * 6897477: Remove GetPlatformHighContrastColorScheme() and enum. https://chromium-review.googlesource.com/c/chromium/src/+/6897477 * 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()" https://chromium-review.googlesource.com/c/chromium/src/+/6918198 * 6907147: [LNA] add use counter for websocket mixed-content issues https://chromium-review.googlesource.com/c/chromium/src/+/6907147 * 6914538: Replace WTF::String with blink::String https://chromium-review.googlesource.com/c/website/+/6914538 * 6892538: [video pip] Allow touchscreen users to toggle live caption https://chromium-review.googlesource.com/c/chromium/src/+/6892538 * chore: fix patch * chore: bump chromium in DEPS to 142.0.7403.0 * build: remove ninja logs * chore: fixup patch indices * 6920670: [PDF] Change pdf_extension_util to return dictionaries https://chromium-review.googlesource.com/c/chromium/src/+/6920670 * 6917864: Devirtualize and inline various NativeTheme getters. https://chromium-review.googlesource.com/c/chromium/src/+/6917864 * 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL() https://chromium-review.googlesource.com/c/chromium/src/+/6920873 * build: don't kill blink/web_tests * 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions) https://chromium-review.googlesource.com/c/chromium/src/+/6923655 * 6905242: Reland "[CSP] Clarify report-only console messages." https://chromium-review.googlesource.com/c/chromium/src/+/6905242 * fixup! 6897694: Remove NativeTheme::UserHasContrastPreference(). * chore: bump chromium in DEPS to 142.0.7405.0 * 6910012: [LNA] Enable LNA enforcement by default https://chromium-review.googlesource.com/c/chromium/src/+/6910012 * 6929444: Combine GetInstanceForXXX() implementations. https://chromium-review.googlesource.com/c/chromium/src/+/6929444 * 6927873: Rename native_widget_types.h -> native_ui_types.h https://chromium-review.googlesource.com/c/chromium/src/+/6927873 * 6853978: Init perfetto really early in WebView https://chromium-review.googlesource.com/c/chromium/src/+/6853978 * 6874886: Use only one picker observer to avoid getting duplicate notifications https://chromium-review.googlesource.com/c/chromium/src/+/6874886 * chore: fixup patch indices * fix: Protocol complex inline dtor * chore: bump chromium in DEPS to 142.0.7407.0 * chore: bump chromium in DEPS to 142.0.7409.0 * chore: bump chromium in DEPS to 142.0.7411.0 * chore: bump chromium in DEPS to 142.0.7413.0 * fixup! 6905242: Reland "[CSP] Clarify report-only console messages." * 6927233: Remove NativeTheme "use dark colors" bit. https://chromium-review.googlesource.com/c/chromium/src/+/6927233 * chore: fixup patch indices * 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes https://chromium-review.googlesource.com/c/chromium/src/+/6899206 * chore: bump chromium in DEPS to 142.0.7415.0 * 6936895: [headless] Remove headless flag from views::Widget class https://chromium-review.googlesource.com/c/chromium/src/+/6936895 We should probably followup on this to see if there is a way to do this without reverting this CL. * 6937023: Reland "Use new DBus type system in dbus_xdg::Request" https://chromium-review.googlesource.com/c/chromium/src/+/6937023 * chore: update patches * 6944749: Add GN visibility list to //components/os_crypt/sync https://chromium-review.googlesource.com/c/chromium/src/+/6944749 * Further replace sub_capture_target_version with CaptureVersion https://chromium-review.googlesource.com/c/chromium/src/+/6935455 * fixup for lint * chore: update filenames.libcxx.gni * chore: bump chromium in DEPS to 142.0.7417.0 * 6944136: Reorder NativeTheme headers/.cc files. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136 * 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701 * 6944404: Remove extraneous callback call Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404 * 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124 * chore: update patches * fixup! 6927233: Remove NativeTheme "use dark colors" bit. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233 * fixup! 6917864: Devirtualize and inline various NativeTheme getters. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864 * 6937588: Add initial OsSettingsProvider object, supplying caret blink interval. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588 * fixup! 6905242: Reland "[CSP] Clarify report-only console messages." Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242 * 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515 * 6910482: [Save to Drive] Implement retry functionality Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482 * fixup! 6927233: Remove NativeTheme "use dark colors" bit. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233 * Revert "build: remove ninja logs" This reverts commit 72874740fd. * test: fix flakey test picked from PR 48205 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: David Sanders <dsanders11@ucsbalum.com> Co-authored-by: Alice Zhao <alicelovescake@anthropic.com>	2025-09-22 20:16:27 -07:00
Charles Kerr	a468ed7f10	refactor: narrow or remove gin arguments (#48300) ... * refactor: narrow App:SetJumpList() arg from gin::Arguments* to v8::Isolate* * refactor: narrow WebContents::AddWorkSpace() arg from gin::Arguments* to v8::Isolate* * refactor: narrow ShowMessageBox() arg from gin::Arguments* to v8::Isolate* * refactor: narrow ShowOpenDialog() arg from gin::Arguments* to v8::Isolate* * refactor: remove unused gin::Arguments* arg from OverrideGlobalPropertyFromIsolatedWorld() * refactor: narrow WebContents::StartDrag() arg from gin::Arguments* to v8::Isolate* * refactor: narrow NetLog::StopLogging() arg from gin::Arguments* to v8::Isolate* * refactor: narrow Protocol::IsProtocolHandled() arg from gin::Arguments* to v8::Isolate*	2025-09-13 08:19:07 +09:00
electron-roller[bot]	793565e4be	chore: bump chromium to 141.0.7390.7 (main) (#48212) ... * chore: bump chromium in DEPS to 141.0.7381.3 * chore: update patches * chore: bump chromium in DEPS to 141.0.7382.0 * chore: update patches * chore: bump chromium in DEPS to 141.0.7384.0 * chore: bump chromium in DEPS to 141.0.7386.0 * [Extensions] Move devtools_page and chrome_url_overrides handlers Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700 * Reland "[api] Advance deprecation of GetIsolate" Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273 * Move "system integrated UI" concept out of NativeTheme. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375 * chore: update patches * Reland "[PermissionOptions] Return PermissionResult in callback for requests" Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838 * Reland "[exit-time-destructors] Enable by default" Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042 * chore: update patches * [FSA] Revoke Read access after removing file via FileSystemAccess API Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249 * chore: IWYU * [DevToolsUIBindings] Accept an object for `dispatchHttpRequest` params Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528 * chore: IWYU * Pass navigation UI parameters on EnterFullscreen in EAM Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923 * chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch * Remove unused PreHandleMouseEvent Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411 * 6878583: siso: update to version 1.4.1 https://chromium-review.googlesource.com/c/chromium/src/+/6878583 * Fold native_theme_browser into native_theme. https://chromium-review.googlesource.com/c/chromium/src/+/6882627 * fixup: Reland "[exit-time-destructors] Enable by default https://chromium-review.googlesource.com/c/chromium/src/+/6859042 * chore: update filenames.libcxx.gni * chore: IWYU * fixup: chore: IWYU * fixup: Reland "[exit-time-destructors] Enable by default * fixup: Reland "[exit-time-destructors] Enable by default * Remove common_theme.*; place its method in NativeTheme instead. https://chromium-review.googlesource.com/c/chromium/src/+/6886029 * fixup: Reland "[exit-time-destructors] Enable by default * Better track when WebPreferences need updates for color-related changes. Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797 * chore: bump chromium in DEPS to 141.0.7390.7 * 6904664: Reland "Make BrowserContext::GetPath() const" https://chromium-review.googlesource.com/c/chromium/src/+/6904664 * Restore read access after certain file modification operations https://chromium-review.googlesource.com/c/chromium/src/+/6861041 * fixup: Move "system integrated UI" concept out of NativeTheme. * fixup: Reland "[exit-time-destructors] Enable by default * chore: update patches * 6906096: Remove GetSysSkColor(). https://chromium-review.googlesource.com/c/chromium/src/+/6906096 * Inline implementation of SysColorChangeListener into the lone user. https://chromium-review.googlesource.com/c/chromium/src/+/6905083 Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096 * fixup: 6906096: Remove GetSysSkColor() --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2025-09-08 12:57:15 +02:00
reito	095e622a6a	feat: context bridge support VideoFrame (#47316) ... * feat: context bridge support VideoFrame * docs: add VideoFrame to docs	2025-08-07 16:41:49 -04:00
electron-roller[bot]	3b0f35a7e8	chore: bump chromium to 140.0.7339.2 (main) (#47929) ... * chore: bump chromium in DEPS to 140.0.7330.0 * chore: bump chromium in DEPS to 140.0.7331.0 * chore: update patches * fix: gn check failing on crashpad.h Not yet sure what caused this * fix: predictors::PreconnectManager -> content::PreconnectManager CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473 * chore: bump chromium in DEPS to 140.0.7333.0 * chore: bump chromium in DEPS to 140.0.7335.0 * chore: bump chromium in DEPS to 140.0.7337.0 * chore: update patches * chore: restore some gin utility * 6804057: [Extensions] Validate nodoc is specified as a boolean in schemas https://chromium-review.googlesource.com/c/chromium/src/+/6804057 * fixup! chore: restore some gin utility * fixup! fix: predictors::PreconnectManager -> content::PreconnectManager CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473 * 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected https://chromium-review.googlesource.com/c/chromium/src/+/6772346 Not certain about what the "correct" argument to pass here is. A quick dive into the CL suggests that passing `false` is safe to keep things working. The blast radius if this assumption is wrong is that "fling" scroll gestures may not work as expected with the OSR. * 6789383: Uninstall SODA language pack after 30 days of inactivity https://chromium-review.googlesource.com/c/chromium/src/+/6789383 * chore: update libcxx filenames * chore: bump chromium in DEPS to 140.0.7339.0 * chore: update patches * fixup! 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected https://chromium-review.googlesource.com/c/chromium/src/+/6772346 * chore: bump chromium in DEPS to 140.0.7339.2 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Samuel Maddock <smaddock@slack-corp.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: clavin <clavin@electronjs.org>	2025-08-06 20:14:23 -04:00
Charles Kerr	7a13c6f175	refactor: avoid deprecated v8::Context::GetIsolate() pt 4 (#47961) ... * refactor: remove GetIsolate() calls from SetPrivate() * refactor: remove excess GetIsolate() calls in PassValueToOtherContextInner() * refactor: remove GetIsolate() calls from GetPrivate() * refactor: add a v8::Isolate* local to ProxyFunctionWrapper() * refactor: remove error_context->GetIsolate() call from PassValueToOtherContextInner() * refactor: remove GetIsolate() call from ProxyFunctionWrapper() * refactor: pass source and destination isolate as arg to CreateProxyForAPI()	2025-08-05 20:08:04 -05:00
Robo	4ca10a1056	chore: move gin::Handle to gin_helper (#47959) ... * chore: move gin::Handle to gin_helper * chore: fix lint	2025-08-05 02:03:06 +09:00
Robo	9d05454dc7	chore: move gin::DeprecatedWrappable to gin_helper (#47958) ... * chore: move gin::DeprecatedWrappable to gin_helper This is in preparation for migrating to gin::Wrappable based on cppgc #47922 The upstream class will be deleted soon via roller PR but the cppgc migration should happen outside the roll, this change retains the current functionality by copying the implementation into //electron/shell/common/gin_helper. The class can be deleted once the cppgc migration is complete. * chore: fix lint:cpp	2025-08-04 23:28:01 +09:00
Sam Maddock	bdaf3b9a2b	refactor: replace webFrame.routingId with sync IPC (#47717) ... * refactor: replace webFrame.routingId with sync IPC * fix: GetConstructor missing isolate * fix: missing isolate	2025-08-02 11:00:42 -04:00