trop[bot]
cd673a3697
docs: --force-fieldtrials was h2 rather than h3 ( #29181 )
...
All the other argument headers were h3 (`###`) but `--force-fieldtrials` was h2 (`##`) for some reason.
I changed it to make it consistent with the others.
Co-authored-by: Noelle Leigh <5957867+noelleleigh@users.noreply.github.com >
2021-05-16 18:15:39 -07:00
trop[bot]
0097a370e3
fix: remove background color hack in vibrancy ( #29165 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-05-14 18:30:27 -07:00
trop[bot]
692c510867
fix: illegal access errors with nodeIntegrationInSubFrames ( #29170 )
2021-05-14 17:43:18 +02:00
trop[bot]
e6f15c4380
fix: ensure extensions w/o a background page have file access ( #29171 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-05-14 17:42:55 +02:00
Electron Bot
cce8dda92f
Bump v13.0.0-beta.26
2021-05-13 06:32:01 -07:00
trop[bot]
034f750c46
Create README.md ( #29149 )
...
Co-authored-by: Ondreas <74183220+OndreasCZ@users.noreply.github.com >
2021-05-12 23:40:50 -07:00
Erick Zhao
120a8acfd0
docs: rework sandbox guide ( #29104 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-05-13 11:08:01 +09:00
trop[bot]
01992fd65c
chore: remove no-op EnableWebComponentsV0 feature ( #29127 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-13 11:07:09 +09:00
trop[bot]
af6a5e6c30
fix: Menu.setApplicationMenu can return a useless array 29088 ( #29129 )
...
Co-authored-by: tabishmahfuz1 <tabish.mahfuz1@gmail.com >
2021-05-12 17:35:23 -07:00
trop[bot]
caac2e8fc7
fix: prevent crash on web-contents creation when error is thrown ( #29106 )
...
* fix: prevent crash when error occurs during event emitter CallMethod
* wip: emit error event within trycatch
* fix: handle uncaught exceptions within node on web_contents init
* fix: create gin_helper::CallMethodCatchException
* test: add web-contents create crash to test cases
* test: clean up test data for web-contents crash
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* fix: convert CatchException to WebContents static helper method
* fix: restore try_catch to callsite
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-12 12:03:34 -07:00
Jeremy Rose
9a4a049498
chore: cherry-pick 8089dbfc616f from chromium ( #29109 )
...
* chore: cherry-pick 8089dbfc616f from chromium
* resolve conflicts
2021-05-12 12:03:09 -07:00
trop[bot]
68059d69a5
build: merge double space in SHASUM validation logic ( #29120 )
...
Co-authored-by: Samuel Attard <sam@electronjs.org >
2021-05-12 01:53:51 -07:00
Electron Bot
0f7334a77e
Bump v13.0.0-beta.25
2021-05-11 18:10:53 -07:00
Electron Bot
eee8bee71b
Revert "Bump v13.0.0-beta.25"
...
This reverts commit 2795185d46
2021-05-11 17:19:54 -07:00
Electron Bot
2795185d46
Bump v13.0.0-beta.25
2021-05-11 13:59:38 -07:00
trop[bot]
877f096d6b
build: offload hash checking logic to lambda worker during release ( #29105 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-05-11 13:57:32 -07:00
trop[bot]
b33bb3a860
fix: update NSView radii on fullscreen transition ( #29099 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-05-11 16:44:18 +02:00
Milan Burda
86f4126051
fix: webFrame spell checker APIs crashing in sandboxed renderers ( #29053 ) ( #29087 )
2021-05-10 16:42:30 -07:00
Electron Bot
f895162234
Bump v13.0.0-beta.24
2021-05-10 12:16:53 -07:00
Electron Bot
05e41f89b4
chore: bump chromium to 91.0.4472.38 (13-x-y) ( #29045 )
2021-05-07 09:29:33 -07:00
Electron Bot
d7378f953a
Bump v13.0.0-beta.23
2021-05-07 00:28:38 -07:00
trop[bot]
ed0b654fee
chore: cherry-pick 7abc7e45b2 from node ( #29048 )
...
Backports: https://github.com/nodejs/node/pull/38506
Co-authored-by: Fedor Indutny <fedor@indutny.com >
2021-05-07 00:19:03 -07:00
Electron Bot
c1c8cbf995
Bump v13.0.0-beta.22
2021-05-06 06:31:26 -07:00
trop[bot]
ab3aa3581a
fix: drag region BrowserView calculations on macOS ( #29017 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-05-06 20:29:06 +09:00
trop[bot]
20a43d9a72
fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29025 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-05-06 20:25:18 +09:00
trop[bot]
27d04084c2
docs: menu must be added on whenReady ( #29043 )
...
* Add that that menu must be added on whenReady
When an application menu is added before 'whenReady' all items seem to work except 'recent documents'
This causes the issue listed here: https://github.com/electron/electron/issues/17388
* Make example more complete
* Remove semicolons
* Update docs/tutorial/recent-documents.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Matthijs Groen <matthijs.groen@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-05-06 20:23:30 +09:00
trop[bot]
46649965c9
spec: attempt to fix flaky nativeTheme spec ( #29036 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-05-05 21:49:48 -07:00
trop[bot]
bea84969d6
docs: link to BrowserView from webview page ( #29008 )
...
* docs: Link to `BrowserView` from `webview` page
* fix relative link
Co-authored-by: Hamish Macpherson <hamstu@gmail.com >
2021-05-05 11:30:52 -07:00
trop[bot]
ae67ec24f3
refactor: use "as const" for constant mappings ( #29000 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-05-05 15:59:47 +09:00
Electron Bot
d379693967
Bump v13.0.0-beta.21
2021-05-04 14:15:15 -07:00
Keeley Hammond
2fe16c60ea
revert: build: fix dump_syms.py to work with python 3 ( #28998 )
2021-05-04 14:07:32 -07:00
Electron Bot
0853536e04
Revert "Bump v13.0.0-beta.21"
...
This reverts commit 4e48867af8
2021-05-04 13:19:01 -07:00
Electron Bot
4e48867af8
Bump v13.0.0-beta.21
2021-05-04 11:49:07 -07:00
Samuel Attard
6bb1d1c5b0
build: import execute method in symbols zip script
2021-05-04 11:40:21 -07:00
Samuel Attard
696cc7c414
build: delete dsyms after they have been zipped in release builds
2021-05-04 11:39:58 -07:00
Samuel Attard
c0c8116a29
build: free up space on macOS some more
2021-05-04 11:39:51 -07:00
trop[bot]
a98ed69874
build: disable pseudolocales in Electron ( #28995 )
...
* build: disable pseudolocales in Electron
* Update build/args/all.gn
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-04 11:38:43 -07:00
trop[bot]
3c230ad272
build: fix dump_syms.py to work with python 3 ( #28996 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-05-04 11:38:30 -07:00
Electron Bot
f93a9607b5
Revert "Bump v13.0.0-beta.21"
...
This reverts commit e7a944e356
2021-05-04 09:39:00 -07:00
Electron Bot
e7a944e356
Bump v13.0.0-beta.21
2021-05-04 08:09:51 -07:00
trop[bot]
9131a3216a
docs: update REPL guide ( #28986 )
...
* docs: update REPL guide
* Update docs/tutorial/repl.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2021-05-04 09:57:46 -04:00
trop[bot]
288985f032
fix: close attached sheet on window close ( #28988 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-05-04 09:31:42 -04:00
trop[bot]
9c1c8787e9
fix: allow Node.js to manage microtasks queue ( #28973 )
...
* fix: allow Node.js to manage microtasks queue
When `uv_run()` resulted in invocation of JS functions the microtask
queue checkpoint in Node's CallbackScope was a no-op because the
expected microtask queue policy was `kExplicit` and Electron ran under
`kScoped` policy. This change switches policy to `kExplicit` right
before `uv_run()` and reverts it back to original value after `uv_run()`
completes to provide better compatibility with Node.
* add comment
Co-authored-by: Fedor Indutny <fedor@indutny.com >
2021-05-03 23:00:44 -07:00
trop[bot]
c55cfa7a9c
chore: Browser::SetAppUserModelID is Windows only ( #28970 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-05-03 18:52:49 -07:00
Electron Bot
f72597be06
chore: bump chromium to 91.0.4472.33 (13-x-y) ( #28660 )
...
* chore: bump chromium in DEPS to 91.0.4472.5
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
(cherry picked from commit 68e369c945https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
(cherry picked from commit 52208297487613ca268ec0c5f45195ea6f3e096e8d9aa4f1f279e84fb72b543fb6dae7https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
(cherry picked from commit d36de6e2d67c148e9102https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
(cherry picked from commit fd954aefd4https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
(cherry picked from commit f676453fb8https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
(cherry picked from commit 27c5d9da5ehttps://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
(cherry picked from commit 285db29015https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 06ac6c5d6ahttps://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
(cherry picked from commit 2b0cb2ca2ahttps://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
(cherry picked from commit bfe55a9c68https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
(cherry picked from commit 2622e91c44https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
(cherry picked from commit 0497272fabhttps://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
(cherry picked from commit 77eacd8073https://chromium-review.googlesource.com/c/chromium/src/+/2785973
(cherry picked from commit 4bcf9d58b0https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
(cherry picked from commit 4e33ee0ad3https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
(cherry picked from commit 70759ad342https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
(cherry picked from commit 48f437b478https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
(cherry picked from commit 866e02999a4444596af5https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
(cherry picked from commit c97cef7059https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 7effb909b6https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
(cherry picked from commit a237fc9affhttps://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
(cherry picked from commit bf9ef3b636https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
(cherry picked from commit c4558b031df509f1b8cchttps://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
(cherry picked from commit 11608d2745https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
(cherry picked from commit 2d4c79413bhttps://chromium-review.googlesource.com/c/chromium/src/+/2771318
(cherry picked from commit f69e95824f96195f845b5d64fa28d5https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
(cherry picked from commit ce541697e5https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
(cherry picked from commit 6ec5c72878https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit 8ae0b0d740https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit d5b017208b218952ec9dhttps://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
(cherry picked from commit 6fe734f5cahttps://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
(cherry picked from commit b760f7162bhttps://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
(cherry picked from commit d9cdb18eb7https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
(cherry picked from commit 6ee282b27ahttps://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
(cherry picked from commit fbf5c04716https://chromium-review.googlesource.com/c/chromium/src/+/2668974
(cherry picked from commit 74577f2156https://chromium-review.googlesource.com/c/chromium/src/+/2802766
(cherry picked from commit 409328fc38https://chromium-review.googlesource.com/c/chromium/src/+/2802823
(cherry picked from commit 43658b0ed3https://chromium-review.googlesource.com/c/chromium/src/+/2803041
(cherry picked from commit 01f514f537https://chromium-review.googlesource.com/c/chromium/src/+/2798873
(cherry picked from commit 5384398823https://chromium-review.googlesource.com/c/chromium/src/+/2733595
(cherry picked from commit f6cf612ee3f078eddc2bhttps://chromium-review.googlesource.com/c/chromium/src/+/2795107
(cherry picked from commit 93077afbfb8f2abcee38https://chromium-review.googlesource.com/c/chromium/src/+/2710023
(cherry picked from commit 4a4da7ad6aa1f0bbb0b5186528aab93129ea403dhttps://chromium-review.googlesource.com/c/chromium/src/+/2724817
(cherry picked from commit dacbf3d60dhttps://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 945890fcf9https://chromium-review.googlesource.com/c/chromium/src/+/2805553
(cherry picked from commit db74b380fd2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit deca961382https://chromium-review.googlesource.com/c/chromium/src/+/2784730
(cherry picked from commit 0fac051a0c01235ba336https://chromium-review.googlesource.com/c/chromium/src/+/2810174
(cherry picked from commit c8a7225cachttps://chromium-review.googlesource.com/c/chromium/src/+/2807829
(cherry picked from commit 39f0c263d7https://chromium-review.googlesource.com/c/chromium/src/+/2791362
(cherry picked from commit fa0d3a0f75https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit 28253c6ccc19c9e94014ae70252e0988baf8835c01a1c37999a203347075https://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 9d31092db8https://chromium-review.googlesource.com/c/chromium/src/+/2628496
(cherry picked from commit 4985c57685ec782c1bdehttps://chromium-review.googlesource.com/c/chromium/src/+/2714464
(cherry picked from commit 2772241a2c186528aab92ce2f73a0c898f8448f82622e91c44f8f388573c93077afbfb20cd4cb875a1d19bc2124e33ee0ad33632067c10e455f68b6460cc150a17https://chromium-review.googlesource.com/c/chromium/src/+/2709931
(cherry picked from commit f835dd1c2ae0720df6d472ca89b31196027e018662faa304df52562150ca572987a15ff771dfe0abd4eb5efdb3https://chromium-review.googlesource.com/c/chromium/src/+/2478082
* run specs separately on WOA
* Update comment
* escape %
* specify files properly
* revert WOA testing changes
* chore: bump chromium in DEPS to 91.0.4472.33
* chore: update patches
* Trigger CI
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-05-03 20:09:30 -04:00
trop[bot]
5c12606b13
feat: add session.storagePath to get path on disk for session data ( #28866 )
...
* feat: add session.storagePath to get path on disk for session data
* spec: add session.storagePath tests
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-05-03 12:14:53 -04:00
trop[bot]
f9bf319e66
docs: remove reference to global Electron install ( #28969 )
...
* docs: remove reference to global Electron install
This is a pattern that we actively want to discourage.
* docs: update as per review suggestion
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-05-03 11:38:53 -04:00
Electron Bot
b5c3ac3e7b
Bump v13.0.0-beta.20
2021-05-03 08:01:43 -07:00
trop[bot]
824028a367
build: add release-env context to publish-macos ( #28939 )
...
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2021-04-29 15:24:01 -07:00
trop[bot]
2b23b145d9
docs: uniformize module API doc format ( #28926 )
...
This PR ensures that all API modules are present in the README doc,
as there were a couple missing. It also formats all modules to contain
a level-1 heading and a blockquote description.
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-04-29 13:38:32 -07:00
