Keeley Hammond
8a89ff06c9
fix: revert SameParty cookie attribute removal
2023-09-21 16:25:46 -07:00
Fredy Whatley
7c2df8860b
docs: tiny update on example message-ports.md ( #39884 )
...
Update message-ports.md
fix multiplying object * a number. It would multiply number * number.
2023-09-21 11:46:23 -04:00
github-actions[bot]
56e45baeb8
build: update appveyor image to latest version - e-119.0.6019.2 ( #39924 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-21 09:49:04 -04:00
Robo
5f712fa325
chore: cherry-pick tls shutdown crash fix from upstream ( #39928 )
2023-09-21 09:47:31 -04:00
John Kleinschmidt
ba8915242a
ci: fix linux builds of forks ( #39933 )
2023-09-21 12:10:46 +02:00
Milan Burda
c9eb3deab5
chore: remove deprecated scroll-touch-{begin,end,edge} events ( #39814 )
...
* chore: remove deprecated `scroll-touch-{begin,end,edge}` events
* update spec/ts-smoke
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 17:41:29 -04:00
Valentin Hăloiu
58fd8825d2
fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var ( #39792 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 16:21:23 -04:00
Milan Burda
6a8b70639b
fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 ( #39920 )
...
fix: app.runningUnderARM64Translation() always returning true on ARM64
2023-09-20 16:15:19 -04:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:13:43 -04:00
electron-roller[bot]
28eda03aba
chore: bump chromium to 119.0.6019.2 (main) ( #39925 )
...
* chore: bump chromium in DEPS to 119.0.6018.4
* chore: update patches
* chore: bump chromium in DEPS to 119.0.6019.2
* chore: update patches
* 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4876292
* 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts
https://chromium-review.googlesource.com/c/chromium/src/+/4851616
* 4869393: [Extensions UserScripts] Add error messages for script matching errors
https://chromium-review.googlesource.com/c/chromium/src/+/4869393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:08:26 -04:00
George Xu
7685f27b31
feat: expose app accessibility transparency settings api ( #39631 )
...
* feat: expose app accessibility transparency settings api
* docs: fix typo
* chore: add doc
* change to property
* add as property instead of method
* chore: fix lint
* rename function name in header
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-20 12:48:02 -07:00
Shelley Vohr
463586a6c5
chore(deps): roll nan to pick up upstreams ( #39916 )
2023-09-20 15:37:10 +02:00
electron-roller[bot]
a39c0ee659
chore: bump chromium to 119.0.6017.0 (main) ( #39922 )
...
* chore: bump chromium in DEPS to 119.0.6017.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-20 11:30:38 +02:00
github-actions[bot]
0b0a8a5ef3
build: update appveyor image to latest version, e-119.0.6006.0 ( #39908 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-19 23:46:47 -07:00
electron-roller[bot]
986becdb4d
chore: bump chromium to 119.0.6016.0 (main) ( #39898 )
...
* chore: bump chromium in DEPS to 119.0.6016.0
* chore: update patches
* 4839124: Rename chrome/app/ branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/4839124
* 4846834: Clean up PrintRenderFrameHelper interaction with Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/4846834
* 4850759: Cache bounds of document pip windows
https://chromium-review.googlesource.com/c/chromium/src/+/4850759
* 4864669: Roll libc++ from 84fb809dd6da to 68a6f0b88287 (352 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4864669
* 4863987: Remove five gpu workarounds.
https://chromium-review.googlesource.com/c/chromium/src/+/4863987
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-19 19:34:56 +02:00
Samuel Attard
75ea294b6f
build: use afs on aks instead of circle cache ( #39881 )
...
* build: use afs on aks instead of circle cache
* build: do not use aks logic on linux hosts checking out for macOS
* build: fix gn-check could-be-aks
* build: sigh
* build: no ls mnt
* build: keep build alive while debugging
* build: make debuggable
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-19 03:12:14 -07:00
spencer17x
18717ee62d
docs: add a more detailed explanation to cookies.flushStore() ( #37572 )
...
* docs: cookies.flushStore()
* docs: modify cookies.flushStore()
* Update docs/api/cookies.md
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-18 16:51:46 -04:00
electron-roller[bot]
73e33bc876
chore: bump chromium to 119.0.6006.0 (main) ( #39774 )
...
* chore: bump chromium in DEPS to 119.0.5994.0
* chore: update patches
* Add some more debugging for navigation origin & process lock mismatch
https://chromium-review.googlesource.com/c/chromium/src/+/4829483
* chore: bump chromium in DEPS to 119.0.5996.2
* chore: bump chromium in DEPS to 119.0.5997.0
* chore: bump chromium in DEPS to 119.0.6000.0
* chore: bump chromium in DEPS to 119.0.6002.0
* 4781766: Port remaining control color ids to the color pipeline
https://chromium-review.googlesource.com/c/chromium/src/+/4781766
* 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/
https://chromium-review.googlesource.com/c/chromium/src/+/4846057
* chore: fixup patch indices
* 4848108: Pass v8::Isolate into FromV8Value calls on blink API
https://chromium-review.googlesource.com/c/chromium/src/+/4848108
* 4834471: Reland "[api] allow v8::Data as internal field"
https://chromium-review.googlesource.com/c/v8/v8/+/4834471
* 4808884: Major overhaul of ExceptionState in the v8 bindings
https://chromium-review.googlesource.com/c/chromium/src/+/4808884
* 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap
https://chromium-review.googlesource.com/c/v8/v8/+/4791643
* chore: bump chromium in DEPS to 119.0.6005.0
* 4776268: [v8][etw] Enables filtering of ETW tracing by URL
https://chromium-review.googlesource.com/c/chromium/src/+/4776268
* chore: fixup patch indices
* 4673258: WebSQL: Disable WebSQL by default
https://chromium-review.googlesource.com/c/chromium/src/+/4673258
* chore: bump chromium in DEPS to 119.0.6006.0
* chore: update patches
* 4854732: Reland^2 "[iterator-helpers] Unship due to incompat"
https://chromium-review.googlesource.com/c/v8/v8/+/4854732
* 4794133: [AWC] Add `display-state` CSS @media feature
https://chromium-review.googlesource.com/c/chromium/src/+/4794133
* fixup! Add some more debugging for navigation origin & process lock mismatch
* Revert "fixup! Add some more debugging for navigation origin & process lock mismatch"
This reverts commit 38fef075fc .
* 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks"
https://chromium-review.googlesource.com/c/chromium/src/+/4858437
* refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879 )
* chore: 4869108: handle absolute and relative gn imports in autoninja
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108
* chore: set GOMA_DIR for autoninja
* Revert "chore: 4869108: handle absolute and relative gn imports in autoninja"
This reverts commit d94c7720ba .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com >
2023-09-18 16:44:09 -04:00
John Kleinschmidt
c8544e25df
build: fixup autoninja ( #39896 )
...
chore: set GOMA_DIR for autoninja
(cherry picked from commit 94f24bde4d )
(cherry picked from commit 90c1f6e1cb8d22d94dd01791dc4b9c3e0a7e86fc)
2023-09-18 16:43:27 -04:00
Milan Burda
9c7086074e
docs: add missing ipcRenderer.off() / ipcRenderer.addListener() aliases ( #39816 )
...
* docs: add missing `ipcRenderer.off()` / `ipcRenderer.addListener()` aliases
* Update docs/api/ipc-renderer.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix ipcRenderer.removeListener
* update ts-smoke
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-19 01:58:20 +09:00
Milan Burda
d7e4bb6608
chore: remove no-op fullscreenWindowTitle option ( #39815 )
2023-09-19 01:55:47 +09:00
David Sanders
706653d5e4
ci: fix issue-commented workflow sytnax ( #39875 )
2023-09-17 19:23:59 -07:00
John Kleinschmidt
65952abc99
test: fixup node flakes ( #39871 )
...
chore: fixup node flakes
2023-09-15 03:43:13 -07:00
Athul Iddya
50ce02c312
fix: check PipeWire init before creating generic capturer ( #39846 )
...
Check if PipeWire can be initialized before creating generic capturer.
This harmonizes the conditions with the ones used in Linux
implementations of DesktopCapturer::CreateRawScreenCapturer and
DesktopCapturer::CreateRawWindowCapturer.
2023-09-14 15:50:20 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
David Sanders
d6c04a3787
ci: ignore actions taken by triage bot ( #39855 )
...
* ci: ignore actions taken by triage bot
* ci: don't remove blocked label on bot comment
2023-09-14 14:01:07 -04:00
Samuel Attard
2791474a01
build: run on circle hosts for forks ( #39858 )
2023-09-14 11:07:11 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
David Sanders
650ef9a51c
build: update @electron/lint-roller to 1.9.0 ( #39812 )
2023-09-12 12:38:31 +02:00
Charles Kerr
a1c44a18e2
fix: NodeService order-of-destruction issue ( #39783 )
...
* refactor: make ElectronRendererClient::node_bindings_ a const ptr
refactor: make ElectronRendererClient::electron_bindings_ a const ptr
* fix: order-of-destruction bug in NodeService
js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_
* chore: revert unintentional commit
2023-09-12 12:27:14 +02:00
Shelley Vohr
ec9c8476fe
fix: keyCodes being incorrectly converted in webContents.sendInputEvent() ( #39776 )
...
fix: sendInputEvent keyCodes being incorrectly converted
2023-09-12 11:28:45 +02:00
Samuel Attard
470a14d8d4
docs: add missing macOS tag
2023-09-11 14:07:25 -07:00
Samuel Attard
5bff0fe342
feat: add new ElectronSquirrelPreventDowngrades flag ( #38625 )
...
* sketch
* feat: add new ElectronSquirrelPreventDowngrades flag
* test: remove only
* chore: fix lint
2023-09-11 11:54:51 -07:00
Samuel Attard
16aec702b4
fix: ensure app load is limited to real asar files when appropriate ( #39788 )
2023-09-11 11:51:14 -07:00
Samuel Attard
ac040bf734
build: update @electron/typescript-definitions to fix titlebaroverlay ( #39799 )
...
build: update @electron/typescript-definitions to fix titlebarstyle
2023-09-11 11:36:36 -07:00
David Sanders
aceb432f45
chore: remove deprecated systemPreferences APIs ( #39696 )
2023-09-11 11:34:13 -04:00
Calvin
d182794179
fix: frameless mica/acrylic windows ( #39708 )
...
* fix: backgroundMaterial works with frameless
* TODO: fix frameless mica/acrylic windows
* update caption color appropriately
* set background color properly
* refactor translucency method
* actualization
2023-09-11 14:51:54 +02:00
Shelley Vohr
ab185c058f
fix: fullscreen crashing with no roundedCorners and no frame ( #39747 )
2023-09-11 09:38:10 +02:00
David Sanders
2324c4d8fd
ci: ignore blocked label removed on closed issues ( #39793 )
2023-09-11 09:33:39 +02:00
Charles Kerr
792037b338
fix: raw_ptr destruction order in NodeBindings ( #39762 )
2023-09-07 18:25:17 -05:00
Samuel Attard
0b44f433c8
fix: make titlebar opaque while fullscreen ( #39759 )
2023-09-07 15:55:17 -07:00
github-actions[bot]
5fa9dee68a
build: update appveyor image to latest version e-118.0.5993.0 ( #39765 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-07 09:40:42 -04:00
Shelley Vohr
75bad34131
fix: prevent errors when extensions listen for chrome.tabs events ( #39729 )
...
* fix: prevent errors when extensions listen for chrome.tabs events
* chore: mark events unsupported in Electron
2023-09-07 12:41:24 +02:00
Robo
0a064cece9
fix: devtools allow restoring saved dock state on Windows ( #39734 )
...
* fix: devtools allow restoring saved dock state on Windows
* chore: address feedback
2023-09-07 17:14:01 +09:00
Milan Burda
f6e8544ef6
refactor: use replaceAll() instead of replace() when appropriate ( #39721 )
...
refactor: use replaceAll() instead of replace() when appropriate
2023-09-07 15:50:14 +09:00
electron-roller[bot]
029127a8b6
chore: bump chromium to 118.0.5993.0 (main) ( #39745 )
...
* chore: bump chromium in DEPS to 118.0.5993.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-06 19:27:25 -04:00
Milan Burda
e71a56d11e
refactor: const Module = require('module') as NodeJS.ModuleInternal; ( #38757 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-09-06 18:04:25 -04:00
Samuel Attard
65901f4c6a
fix: restore flag that allowed websockets to not be backgrounded ( #39738 )
2023-09-06 11:23:17 -07:00
github-actions[bot]
feb804cea8
build: update appveyor image to latest version ( #39716 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-06 14:07:34 -04:00
Shelley Vohr
34b79c15c2
build: fix depot_tools patch application ( #39742 )
...
build: fix depot_tools patch application
2023-09-06 07:49:00 -04:00
electron-roller[bot]
d9ba26273a
chore: bump chromium to 118.0.5991.0 (main) ( #39714 )
...
* chore: bump chromium in DEPS to 118.0.5982.0
* chore: bump chromium in DEPS to 118.0.5983.0
* chore: bump chromium in DEPS to 118.0.5985.0
* chore: bump chromium in DEPS to 118.0.5987.0
* chore: update v8 patches
* chore: update chromium patches
* chore: update patches
* [PEPC] Add new structs to contain permission request data
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4756727
* Add ThumbnailCapturer interface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4812256
* Reland "[ChromeRefresh2023] Update document pip windows for Chrome Refresh"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4814275
* chore: bump chromium in DEPS to 118.0.5989.0
* chore: bump chromium in DEPS to 118.0.5991.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-05 21:17:56 -04:00
David Sanders
c96bb9958f
chore: remove deprecated webContents.getPrinters() ( #39663 )
2023-09-05 10:16:41 +02:00
Milan Burda
d76a35afe4
test: remove a few casts to any ( #39713 )
2023-09-05 11:22:41 +09:00
Milan Burda
c5b20eeb13
test: add missing tests to api-web-frame-spec.ts ( #39720 )
...
test: add missing tests to spec/api-web-frame-spec.ts
2023-09-05 11:20:58 +09:00
John Kleinschmidt
4cc0f6fb78
test: fix flaky content tracing test ( #39682 )
2023-09-04 14:08:26 +02:00
Milan Burda
f27b034045
test: convert a few more specs to async/await ( #39712 )
2023-09-04 12:33:29 +02:00
Shelley Vohr
54d8402a6c
fix: broken chrome.scripting compilation ( #39725 )
...
fix: broken chrome.scripting impl after roll
2023-09-04 16:03:10 +09:00
Samuel Attard
89659fa9c9
chore: fix broken patches on main ( #39715 )
2023-09-01 01:28:01 -07:00
electron-roller[bot]
89117fdd99
chore: bump chromium to 118.0.5975.0 (main) ( #39531 )
...
* chore: bump chromium in DEPS to 118.0.5951.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4727894
No logic changes, but patch needed to be manually re-applied due to upstream code shear
* chore: update port_autofill_colors_to_the_color_pipeline.patch
No manual changes; patch applied with fuzz
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5953.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5955.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5957.0
* chore: update patches
* chore: include path of native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
* chore: remove reference to eextensions/browser/notification-types.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4771627
* chore: update references to renamed upstream field NativeWebKeyboardEvent.skip_if_unhandled (formerly known as skip_in_browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
Need a second pair of eyes on this commit. In particular the reference in content_converter.cc, skipInBrowser, seems to not be set or documented anywhere? Is this unused/vestigal code?
* chore: sync signature of ElectronExtensionsBrowserClient::IsValidContext() to upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4784198
* chore: add auto_pip_setting_helper.[cc,h] to chromium_src build
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4688277
Exiting upstream code used by chromium_src now depends on this new upstream class
* chore: bump chromium in DEPS to 118.0.5959.0
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
manually adjust patch to minor upstream chagnes
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5961.0
* chore: bump chromium in DEPS to 118.0.5963.0
* chore: update patches
* 4780994: Rename various base files to "apple" since iOS uses them too
https://chromium-review.googlesource.com/c/chromium/src/+/4780994
* Many files moved from `mac` -> `apple`
This commit follows a handful of CLs that simply rename files/symbols to change `mac`
to `apple`
to signify their use across both macOS and iOS:
- 4784010: Move scoped_nsautorelease_pool to base/apple, leave a forwarding header
- 4790744: Move foundation_util to base/apple, leave a forwarding header
- 4790741: Move scoped_cftypreref to base/apple, leave a forwarding header
- 4787627: Move and rename macOS+iOS base/ files in PA to "apple"
- 4780399: Move OSStatus logging to base/apple
- 4787387: Remove forwarding headers
- 4781113: Rename message_pump_mac to "apple" because iOS uses it too
* fixup minor patch update error
A function param got dropped from this patch somewhere earlier
* chore: bump chromium in DEPS to 118.0.5965.2
* chore: update patches
* 4799213: Move ScopedTypeRef and ScopedCFTypeRef into base::apple::
https://chromium-review.googlesource.com/c/chromium/src/+/4799213
* Fix removed include to BrowserContext
In crrev.com/c/4767962 an include to BrowserContext was removed,
which was necessary for compilation. This broke only for us because
"chrome/browser/profiles/profile.h" includes that class, but we remove
all references to profiles.
* chore: bump chromium in DEPS to 118.0.5967.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5969.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5971.0
* chore: bump chromium in DEPS to 118.0.5973.0
* chore: update patches
* 4772121: [OOPIF PDF] Replace PDFWebContentsHelper with PDFDocumentHelper
https://chromium-review.googlesource.com/c/chromium/src/+/4772121
* 4811164: [Extensions] Do some cleanup in ChromeManagementAPIDelegate.
https://chromium-review.googlesource.com/c/chromium/src/+/4811164
* 4809488: Remove duplicate dnd functionality between Web and Renderer prefs
https://chromium-review.googlesource.com/c/chromium/src/+/4809488
Given that this is no longer an option of web preferences, we should
consider deprecating this option and then removing it.
* chore: bump chromium in DEPS to 118.0.5975.0
* chore: update patches
* fixup! chore: add auto_pip_settings_helper.{cc|h} to chromium_src build
* Reland "[windows] Remove RegKey::DeleteEmptyKey"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4813255
* Ensure StrCat means StrCat
Refs https://chromium-review.googlesource.com/c/chromium/src/+/1117180
* fixup! Remove RegKey::DeleteEmptyKey
* Consistently reject large p and large q in DH
Refs https://boringssl-review.googlesource.com/c/boringssl/+/62226
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-09-01 15:54:59 +09:00
Milan Burda
0b0707145b
refactor: replace .forEach() with for-of ( #39691 )
...
* refactor: replace `.forEach()` with `for-of`
* refactor docs/fiddles/features/web-hid/renderer.js
2023-08-31 23:36:43 +09:00
David Sanders
7858921a1f
docs: fix return typing of ses.getExtension ( #39697 )
2023-08-30 18:10:32 -07:00
Samuel Attard
ac031bf8de
feat: I guess it's esm ( #37535 )
...
* fix: allow ESM loads from within ASAR files
* fix: ensure that ESM entry points finish loading before app ready
* fix: allow loading ESM entrypoints via default_app
* fix: allow ESM loading for renderer preloads
* docs: document current known limitations of esm
* chore: add patches to support blending esm handlers
* refactor: use SetDefersLoading instead of JoinAppCode in renderers
Blink has it's own event loop so pumping the uv loop in the renderer is not enough, luckily in blink we can suspend the loading of the frame while we do additional work.
* chore: add patch to expose SetDefersLoading
* fix: use fileURLToPath instead of pathname
* chore: update per PR feedback
* fix: fs.exists/existsSync should never throw
* fix: convert path to file url before importing
* fix: oops
* fix: oops
* Update docs/tutorial/esm-limitations.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* windows...
* windows...
* chore: update patches
* spec: fix tests and document empty body edge case
* Apply suggestions from code review
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* spec: add tests for esm
* spec: windows
* chore: update per PR feedback
* chore: update patches
* Update shell/common/node_bindings.h
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: update patches
* rebase
* use cjs loader by default for preload scripts
* chore: fix lint
* chore: update patches
* chore: update patches
* chore: fix patches
* build: debug depshash
* ?
* Revert "build: debug depshash"
This reverts commit 0de82523fb .
* chore: allow electron as builtin protocol in esm loader
* Revert "Revert "build: debug depshash""
This reverts commit ff86b1243c .
* chore: fix esm doc
* chore: update node patches
---------
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
2023-08-30 17:38:07 -07:00
Erick Zhao
b8ac798344
docs: use node: imports for node core modules ( #39681 )
...
docs: use `node:` imports for node builtin modules
2023-08-30 11:55:23 -04:00
David Sanders
2182202e8e
ci: use new GitHub App for issue triage related actions ( #39635 )
2023-08-30 11:09:33 -04:00
Milan Burda
e66c1f6c56
refactor: generate 'chrome:// pages' specs to remove duplicate code ( #39684 )
2023-08-30 11:07:41 -04:00
Milan Burda
9280b79112
docs: enable contextIsolation in fiddles ( #39613 )
2023-08-29 15:52:16 -04:00
Milan Burda
2e79f34c84
docs: fix the minimum supported macOS version to Catalina ( #39667 )
...
docs: update the minimum supported macOS version to Catalina
2023-08-29 09:01:11 +09:00
Tomasz
f30fbebb98
fix: promise resolved to early when browser initiated in-page navigation v2 ( #39597 )
2023-08-28 12:37:28 -04:00
Shelley Vohr
f0ad357af2
feat: support chrome.scripting extension APIs ( #39395 )
...
feat: support chrome.scripting extension APIs
2023-08-28 10:39:28 -04:00
Milan Burda
5078cae861
chore: remove deprecated ipcRenderer.sendTo() ( #39087 )
...
chore: remove deprecated ipcRenderer.sendTo()
2023-08-28 10:29:27 -04:00
Robo
b5997a012d
chore: enable v8_enable_private_mapping_fork_optimization by default ( #39253 )
...
* chore: enable v8_enable_private_mapping_fork_optimization by default
* chore: cherry-pick 292a4a6 from v8
2023-08-28 10:16:20 -04:00
Shelley Vohr
f369b144d6
feat: add more extensions manifest key options ( #39599 )
...
feat: add more manifest key options
2023-08-28 10:02:22 -04:00
Milan Burda
f2f83a73fc
docs: use electron/main & electron/renderer imports in fiddles ( #39666 )
2023-08-28 20:23:10 +09:00
Shelley Vohr
d42a94ddde
fix: webview exiting fullscreen presentation mode ( #39616 )
2023-08-25 14:11:58 -04:00
David Sanders
3bdc7ce64a
ci: don't mark status/confirmed labeled issues as stale ( #39659 )
2023-08-25 14:09:28 -04:00
David Sanders
48e14bc54e
ci: fix deprecation review automation for PRs ( #39649 )
2023-08-25 14:09:12 -04:00
John Kleinschmidt
83760bd5c6
ci: explicitly use python3 to start goma ( #39650 )
...
* ci: explicitly use python3 to start goma
* ci: explicitly use python3 for goma
2023-08-24 21:43:24 -04:00
wanted002
e14964ccd0
feat: add setter and getter apis to specify udp port range for webrtc ( #39046 )
...
* feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042)
* lint error fix for PR#39046
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview
* fix lint error
* fix lint errors in file api-web-contents-spec.ts
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc
* fix lint error
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter
2023-08-24 17:21:22 -04:00
Athul Iddya
33000c4b42
feat: enable WaylandWindowDecorations by default ( #39582 )
2023-08-24 17:02:05 -04:00
Shelley Vohr
33e66b5cd0
fix: ensure windows respect fullscreenability with different resizability values ( #39620 )
...
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen
* test: add an extra resize test
2023-08-24 16:54:08 -04:00
Shelley Vohr
2affecd4dd
feat: allow generating accessible pdf with printToPDF ( #39563 )
...
* feat: allow generating accessible pdf with printToPDF
* docs: mark generateTaggedPDF experimental
2023-08-24 11:01:59 -04:00
Erick Zhao
381c955bca
docs: mention alternative tooling ( #39337 )
...
* docs: mention alternative tooling
* Update forge-overview.md
* Update forge-overview.md
2023-08-24 12:03:30 +02:00
Charles Kerr
35969939a1
refactor: node::Environment self-cleanup ( #39604 )
...
* chore: savepoint
* chore: turn raw_ptr tests back off
2023-08-23 09:56:16 -04:00
Shelley Vohr
a8999bc529
fix: ensure BrowserView bounds are always relative to window ( #39605 )
...
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
Shelley Vohr
522bba3dc6
chore: cleanup arc migration helpers ( #39606 )
2023-08-23 09:54:21 -04:00
Shelley Vohr
ddc7e3ebb3
fix: assert module in the renderer process ( #39540 )
2023-08-23 11:38:47 +02:00
Bruno Henrique da Silva
2481f94b4e
fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack ( #39074 )
...
return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack
2023-08-23 10:49:24 +02:00
Shelley Vohr
e1d63794e5
fix: chrome.tabs 'url' and 'title' are privileged information ( #39595 )
...
fix: tabs url and title are privileged information
2023-08-22 14:56:58 +02:00
Cheng Zhao
bfa58df7c9
chore: move node headers generation to electron ( #39589 )
2023-08-22 11:13:49 +02:00
Milan Burda
c1898c39bf
chore: remove obsolete "simple" object annotations for the remote module ( #39486 )
2023-08-22 13:43:30 +09:00
Milan Burda
3102a257af
feat: expose dummy module.exports to the sandboxed preload scripts ( #39484 )
2023-08-22 13:43:08 +09:00
Milan Burda
90865fa97d
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition() ( #39479 )
...
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
2023-08-21 15:58:09 +02:00
Charles Kerr
3a91d1f1e1
fix: dangling raw_ptr in ElectronBrowserMainParts dtor ( #39539 )
...
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor
* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor
Browser::WhenReady() holds a reference to JsEnv isolate so must come after
2023-08-21 10:29:25 +02:00
Milan Burda
09190085c0
refactor: add gin_helper::Dictionary::CreateEmpty() helper ( #39547 )
2023-08-21 10:43:41 +09:00
tr2-harada
9937a2bbe8
fix: explorer restart does not recreated thumbnail toolbar buttons ( #39551 )
...
fix: explorer restart does not recreated thumbnail toolbar buttons.
2023-08-21 09:43:49 +09:00
Shelley Vohr
95bf9d8adb
fix: chrome://gpu failing to load ( #39556 )
...
fix: chrome://gpu failing to load
2023-08-21 09:41:00 +09:00
Athul Iddya
c75e193a3e
fix: use tiled edges to calculate frame inset sizes in Linux ( #39523 )
...
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
2023-08-17 14:26:49 -04:00
Shelley Vohr
0621f39296
test: enable parallel/test-debugger-random-port-with-inspect-port ( #39533 )
...
test: enable parallel/test-debugger-random-port-with-inspect-port
2023-08-17 12:16:14 -04:00
Shelley Vohr
aeb89b143b
chore: cleanup asar initialization logic ( #39532 )
2023-08-17 16:42:53 +02:00
Charles Kerr
213388cd87
refactor: prefer Sorted variant of MakeFixedFlatSet() ( #39537 )
...
perf: prefer Sorted variant of MakeFixedFlatSet()
https://chromium-review.googlesource.com/c/chromium/src/+/4660000
says that the sorted version is simpler at compile time because it
can skip MakeFixedFlatSet()'s compile-time dynamic sorting.
2023-08-17 08:58:04 -05:00
David Sanders
8374b9c2ad
ci: add prev-major variable to release board templating ( #39454 )
2023-08-17 14:24:57 +02:00
Shelley Vohr
00746e662b
feat: allow headers to be sent with webContents.downloadURL() ( #39455 )
...
feat: allow headers to be sent with webContents.downloadURL()
2023-08-17 14:17:55 +02:00
Shelley Vohr
31dfde7fa6
docs: note macOS bounds Tray offset ( #39512 )
...
* docs: note macOS bounds Tray offset
* Update docs/api/browser-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-08-17 11:02:03 +02:00
Charles Kerr
dd8df3b0c4
fix: destruction order of js env fields ( #39521 )
...
isolate_ depends on isolate_holder_ and so must be destroyed first.
2023-08-16 23:06:24 -05:00
Milan Burda
b04ce6a5c8
docs: add missing webview render-process-gone event ( #39494 )
...
docs: add mising webview 'render-process-gone' event
2023-08-17 08:52:15 +09:00
Keeley Hammond
fce9ed65d6
build: update NMV to 118 ( #39538 )
2023-08-16 11:46:16 -07:00
github-actions[bot]
a4a3ba9341
build: update appveyor image to latest version - e-118.0.5949.0. ( #39524 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-16 14:06:19 -04:00
John Kleinschmidt
9d6d606192
build: fixup libcxx zip ( #39536 )
2023-08-16 14:05:39 -04:00
Shelley Vohr
1eb398b328
fix: crash when calling BrowserWindow.moveTop() on modal children ( #39499 )
...
fix: crash when calling moveTop() on modal children
2023-08-16 13:28:29 +02:00
Sergei Chestakov
f7a7085019
docs: fix typo in open-url API docs ( #39513 )
...
* Fix typo in open-url API docs
* Update app.md
2023-08-16 12:26:02 +02:00
electron-roller[bot]
0c45d160d6
chore: bump chromium to 118.0.5949.0 (main) ( #39505 )
...
* chore: bump chromium in DEPS to 118.0.5949.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4705386
no manual code changes; existing patch applied with fuzz
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4779059
no manual code changes; existing patch applied with fuzz
* chore: add OffScreenRenderWidgetHostView::InvalidateLocalSurfaceIdAndAllocationGroup()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4563504
Add an impl for a new pure virtual method that was added upstream.
Local impl inspired by upstream implementations in same CL
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-08-15 15:44:24 -04:00
Shelley Vohr
22429e2112
refactor: clean up Node.js cli arg parsing ( #39465 )
...
* refactor: clean up Node.js arg parsing
* chore: feedback from review
2023-08-15 14:49:21 -04:00
David Sanders
1d20ec5b99
ci: fix @electron/github-app-auth CLI usage ( #39507 )
2023-08-15 11:41:29 -07:00
Michaela Laurencin
22c359ac4f
docs: update timelines for E27 ( #39493 )
2023-08-15 12:57:48 -05:00
electron-roller[bot]
c3036d4557
chore: bump chromium to 117.0.5938.0 (main) ( #39375 )
...
* chore: bump chromium in DEPS to 117.0.5929.0
* chore: bump chromium in DEPS to 117.0.5931.0
* chore: bump chromium in DEPS to 117.0.5932.0
* chore: update patches
* 4728317: Prevent PrintRenderFrameHelper from printing when already printing
| https://chromium-review.googlesource.com/c/chromium/src/+/4728317
* 4739501: Use base::SequenceBound to manage SerialPortManagerImpl |
https://chromium-review.googlesource.com/c/chromium/src/+/4739501
* 4702051: Allow overriding source in install-sysroot.py | https://chromium-review.googlesource.com/c/chromium/src/+/4702051
* chore: update filenames.libcxx.gni
* 4727002: Rename "enable_arc2" to "enable_arc" |
https://chromium-review.googlesource.com/c/chromium/src/+/4727002
* chore: bump chromium in DEPS to 117.0.5934.0
* 4736873: Rename ColorSpaces methods on display::Display | https://chromium-review.googlesource.com/c/chromium/src/+/4736873
* 4727203: Replace bool with an enum in as suggested in DevtoolsManagerDelegate. | https://chromium-review.googlesource.com/c/chromium/src/+/4727203
* 4744479: [DevTools] Add 'generateTaggedPDF' option to DevTools Page.printToPDF | https://chromium-review.googlesource.com/c/chromium/src/+/4744479
* 4735893: Don't share WebUSB permissions with webviews | https://chromium-review.googlesource.com/c/chromium/src/+/4735893
* revert: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 117.0.5936.0
* chore: update patches
* 4746465: SAA: Query for embargoed StorageAccess permissions | https://chromium-review.googlesource.com/c/chromium/src/+/4746465
* 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
* chore: bump chromium in DEPS to 117.0.5938.0
* chore: bump chromium in DEPS to 118.0.5939.0
* chore: update patches
* Send line bounds through CursorAnchorInfo on requestCursorUpdate
https://chromium-review.googlesource.com/c/chromium/src/+/4394588
* Fixup lint for Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src
* 4700305: [mac] Fix override of CHILD_PROCESS_EXE
https://chromium-review.googlesource.com/c/chromium/src/+/4700305
Needed because of 4729689: Reland "Remove redundant existence check in PathService" | https://chromium-review.googlesource.com/c/chromium/src/+/4729689
* 4753759: More consistent icon handling for menus.
https://chromium-review.googlesource.com/c/chromium/src/+/4753759
* chore: bump chromium in DEPS to 118.0.5941.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5938.0
* test: update nan-spec-runner cflags
* build: fix isystem include path in nan-spec-runner
* fixup! 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
fix a few more instances of the old path
libc++.a and libc++abi.a are still in buildtools/
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-15 10:49:41 -05:00
Robo
bee5d94886
feat: support dns-result-order Node.js cli flag ( #39376 )
...
* feat: support dns-result-order Node.js cli flag
* chore: update docs
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* chore: remove patch
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-08-15 12:19:45 +02:00
electron-roller[bot]
ef5d5f888d
chore: bump node to v18.17.1 (main) ( #39457 )
...
* chore: bump node in DEPS to v18.17.1
* chore: update patches
* policy: disable process.binding() when enabled
d4570fae35
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-08-15 10:06:55 +02:00
wgsheng
127584dc37
feat: add a 'title' parameter to openDevTools() ( #39047 )
...
* [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar
* all titles->title
* add GetDevToolsTitle(),update docs
* fix:lint error
* fix:lint error
* add setDevToolTitle
* lint errror
* lint errror
* ling errror (.md)
* build error
* build error in mac
* build error
* build error
* change docs
* std::string->std::u16string
* lint error
* build error
* build error
2023-08-15 14:32:53 +09:00
Shelley Vohr
8e3dcc8b17
refactor: update WebContentsZoomController ( #39428 )
...
refactor: update WebContentsZoomController
2023-08-15 10:33:30 +09:00
David Sanders
5d11c30720
ci: improve blocked/need-repro workflow ( #39451 )
...
* ci: improve blocked/need-repro workflow
* ci: let maintainer comments suppress bot comment
* ci: ensure failures bubble up
2023-08-15 10:32:38 +09:00
David Sanders
813853297d
ci: automation for deprecation project board ( #39477 )
2023-08-15 10:28:42 +09:00
David Sanders
dbff7bb531
ci: automation for issue triage board ( #39464 )
2023-08-15 10:28:17 +09:00
David Sanders
effafdf498
test: use as const to remove some usages of as any ( #39475 )
2023-08-15 10:24:32 +09:00
Shelley Vohr
9eeef55469
test: resolve failing Node.js line number failure ( #39490 )
2023-08-14 13:08:55 -04:00
David Sanders
1b3e4dae8d
chore: document deprecated systemPreferences APIs ( #39343 )
...
* chore: document deprecated systemPreferences APIs
* chore: forgot systemPreferences.appLevelAppearance
* test: expect deprecation messages
2023-08-14 11:34:04 +02:00
Milan Burda
d5f31c2208
docs: remove duplicate fiddles (part #2 ) ( #39474 )
...
docs: remove duplicate fiddles
2023-08-14 10:44:07 +02:00
David Sanders
d166182865
chore: remove deprecated systemPreferences color scheme events ( #39341 )
2023-08-14 10:37:18 +02:00
Cheng Zhao
cf658b700d
fix: use nested run loop in clipboard.readImage ( #39466 )
2023-08-14 10:35:37 +02:00
Milan Burda
08bbff5361
docs: handle opening links in the default browser in main.js (part #2 ) ( #39473 )
...
docs: handle opening links in the default browser in main.js
2023-08-14 10:04:29 +02:00
Shelley Vohr
117d5310f5
revert: promise resolved too early when browser initiates in-page navigation ( #39481 )
...
This reverts commit a0effaf9b8 .
2023-08-14 13:13:15 +09:00
John Kleinschmidt
f16dffccd0
ci: fixup known hosts for linux publish ( #39437 )
...
* ci: fixup known hosts for linux publish
* build: use 2023 known hosts
* build: use rebuilt docker image
* Revert "build: use rebuilt docker image"
This reverts commit f9506a9cc0 .
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-08-10 12:40:58 -04:00
Milan Burda
255064659f
docs: update external links ( #39421 )
2023-08-10 11:55:52 +02:00
David Sanders
11600c5f96
chore: document deprecated webContents.getPrinters API ( #39356 )
...
* chore: document deprecated webContents.getPrinters API
* chore: remove duplicate deprecation warning
2023-08-10 11:50:30 +02:00
Milan Burda
1ce2fdd63d
docs: fix take-screenshot fiddle to use desktopCapturer in main.js ( #39420 )
2023-08-10 10:53:23 +02:00
Milan Burda
c4d417b6f6
docs: remove duplicate fiddles ( #39419 )
2023-08-10 10:52:52 +02:00
Milan Burda
0f49868234
chore: deprecate senderId and senderIsMainFrame ( #39381 )
2023-08-09 10:38:48 -04:00
Shelley Vohr
70508b5273
chore: update _api_features manifest requirements ( #39412 )
...
chore: update api_resources manifest requirements
2023-08-09 10:38:13 -04:00
Tomasz
a0effaf9b8
fix: promise resolved to early when browser initiated in-page navigation ( #39260 )
2023-08-09 16:06:39 +02:00
Shelley Vohr
d9329042e2
feat: add support for chrome.tabs.query ( #39330 )
...
* feat: add support for tabs.query
* fix: scope to webContents in current session
* test: add test for session behavior
2023-08-09 14:47:19 +02:00
David Sanders
0425454687
test: helper to expect deprecation warnings ( #39405 )
2023-08-09 11:01:52 +02:00
Samuel Attard
d24d8f1f78
fix: avoid package.json check on built-in modules ( #39418 )
2023-08-09 00:32:00 -07:00
electron-roller[bot]
ab08803959
chore: bump node to v18.17.0 (main) ( #39154 )
...
* chore: bump node in DEPS to v18.17.0
* chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch
Xref: https://github.com/nodejs/node/pull/46930
manually sync patch to minor upstream code shear
* chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch
Xref: https://github.com/nodejs/node/pull/48248
manually sync patch to minor upstream code shear
* chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/47824
chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it
* chore: update api_pass_oomdetails_to_oomerrorcallback.patch
Xref: https://github.com/nodejs/node/pull/47695
manually sync patch to minor upstream code shear
* chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch
Xref: https://github.com/nodejs/node/pull/46979 (upstreamed patch)
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related)
* chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch
Xref: https://github.com/nodejs/node/pull/47274
manually sync patch to minor upstream code shear
some tests moved from sequential to parallel
* chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch
Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch
Xref: https://github.com/nodejs/node/pull/47339
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: rebuild filenames.json
several files removed/added/changed upstream
* chore: update build_add_gn_build_files.patch
upstream dep histogram 0.11.7 moved its include path from src/ to include/
Xref: https://github.com/nodejs/node/pull/47742
* chore: update fix_crypto_tests_to_run_with_bssl.patch
Xref: https://github.com/nodejs/node/pull/47160
BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of
BIO_s_mem()), so use BIO_s_mem() instead.
Related discussion of secure heap support in BoringSSL:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: ftbfs in node dep ada
* fix: ftbfs in node dep uvwasi
* chore: rebuild patches
* chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch
Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`.
BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead.
Upstream Node.js change that prompted this:
https://github.com/nodejs/node/pull/47160
Related discussion of BoringSSL support of secure heap:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: work around Node 18 isURL() regression
* chore: sort script/node-disabled-tests.json alphabetically
* test: add parallel/test-snapshot-argv1 to disabled list
test: add parallel/test-snapshot-namespaced-builtin to disabled list
We don't support that type of snapshotting at the moment.
* chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error
fails upstream in v18.x on my box as well
* ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
* fixup! fix: work around Node 18 isURL() regression
fix: infinite loop regression
* fixup! fix: work around Node 18 isURL() regression
* chore: patch fixtures/errors/force_colors.snapshot
The line numbers in the stacktrace from our v8 build don't match what
Node's tests are expecting, so update the stacktrace to match our build.
The specific numbers probably aren't t needed for the force_colors test,
which is trying to see whether or not the lines are greyed out. One option
is to upstream a test change to stop hardcoding the stacktrace.
* fixup! fix: work around Node 18 isURL() regression
fix; pull in upstream bugfix
* fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js
* chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-08 17:52:51 -05:00
Shelley Vohr
5e59ddca1a
chore: update chrome.runtime.getPlatformInfo impl ( #39392 )
...
chore: update chrome.runtime.getPlatformInfo impl
2023-08-08 22:29:03 +02:00
Shelley Vohr
1b3c63145c
chore: remove i18n JSON spec ( #39391 )
2023-08-08 14:02:16 -04:00
Samuel Attard
814735cb72
build: use aks backed runners for linux builds ( #39403 )
...
* build: test aks runner
* build: stress test
* build: use super-large nodes for publish jobs
* build: try using aks for everything...
* build: shared host not great
* build: clean up
* build: apparently tests dont run in kube infra?
* build: do not change test size
2023-08-08 09:56:41 -07:00
David Sanders
dcf1c65426
chore: fix ipcRenderer.sendTo deprecation warning ( #39342 )
2023-08-08 13:49:56 +02:00
Milan Burda
24c9cbcc0a
docs: handle opening links in the default browser in main.js ( #39379 )
...
docs: handle opening links in the default browser in the main process
2023-08-08 12:35:59 +02:00
Robo
eecfaec8c9
fix: crash when closing active macOS native tab ( #39394 )
...
fix: crash when closing current active macOS native tab
2023-08-08 17:45:03 +09:00
Shelley Vohr
8f4f82618c
fix: removeBrowserView draggable region removal ( #39387 )
...
fix: removeBrowserView draggable region removal
Closes https://github.com/electron/electron/issues/39377 .
2023-08-08 10:23:14 +02:00
github-actions[bot]
1548a2f9fb
build: update appveyor image to e-117.0.5921.0 ( #39390 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-07 13:08:53 -07:00
Milan Burda
3d45429667
refactor: use for-of instead of for simple array iteration ( #39338 )
2023-08-07 11:30:15 +02:00
Shelley Vohr
67523a47b4
fix: chrome.tabs.update return value ( #39365 )
...
fix: chrome.tabs.update return value
2023-08-07 10:03:45 +02:00
David Sanders
330c775252
docs: fix description of pageRanges ( #39378 )
...
Co-authored-by: Alain BUFERNE <albu.consult@gmail.com >
2023-08-07 09:56:36 +02:00
Shelley Vohr
dc707ee938
fix: macOS tray button selection with VoiceOver ( #39352 )
2023-08-07 09:52:18 +02:00
John Kleinschmidt
1eb6e45a36
ci: fix hang when validating AppVeyor artifacts ( #39362 )
2023-08-07 09:51:53 +02:00
Shelley Vohr
2e0517c0ad
feat: allow more Node.js cli flags in main process ( #39344 )
...
* feat: allow more Node.js cli flags in main process
* docs: update cli switch documentation
2023-08-04 19:59:40 +09:00
electron-roller[bot]
c5b9f766f3
chore: bump chromium to 117.0.5923.0 (main) ( #39304 )
...
* chore: bump chromium in DEPS to 117.0.5921.0
* chore: update chromium patches
* 4721409: Remove redundant ARC configuration in /components | https://chromium-review.googlesource.com/c/chromium/src/+/4721409
* 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* 4022621: Re-register status item when owner of status watcher is changed | https://chromium-review.googlesource.com/c/chromium/src/+/4022621
* chore: update V8/boringssl patches
* fixup! 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* chore: bump chromium in DEPS to 117.0.5923.0
* build [debug]: remove assert
4722125: Update enterprise content analysis buildflags usage | https://chromium-review.googlesource.com/c/chromium/src/+/4722125
* chore: manually rollback to 117.0.5921.0
* build [arc]: ARC conversion in auto_updater
* build [arc]: ARC conversion in browser/api
* build [arc]: ARC conversion in notifications/mac
* build [arc]: ARC conversion in in_app_purchase
* build [arc]: ARC conversion in browser/ui
* build [arc]: ARC conversion in ui/cocoa
* build [arc]: ARC conversion in shell/common
* build [arc]: ARC conversion in OSR
* build [arc]: ARC conversion in login_helper
* build [arc]: ARC conversion in app_mas
* build [arc]: fix up ARC syntax (thanks @codebytere!)
* 4726946: [Extensions] Work around dangling BrowserContext pointer. | https://chromium-review.googlesource.com/c/chromium/src/+/4726946
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-08-04 10:47:29 +02:00
Shelley Vohr
6d0e8044eb
fix: update chrome.tabs for Manifest v3 ( #39317 )
2023-08-03 18:34:02 +02:00
Shelley Vohr
f8b05bc127
feat: support minimum_chrome_version manifest key ( #39256 )
...
feat: support minimum_chrome_version extension key
2023-08-03 11:38:31 -04:00
David Sanders
e6931a788f
docs: clean up removed systemPreferences methods ( #39334 )
2023-08-03 14:40:29 +02:00
Robo
e96b1613a4
fix: destroy message port backend when JS env exits ( #39335 )
2023-08-03 14:30:19 +02:00
Milan Burda
fe93f69e5a
refactor: use Set instead of Array when appropriate ( #39324 )
2023-08-03 14:29:57 +02:00
Milan Burda
c5e50e4882
refactor: use more appropriate array methods ( #39321 )
2023-08-02 19:43:45 +02:00
Shelley Vohr
7686d1c379
docs: correct powerSaveBlocker.stop(id) return type ( #39320 )
...
doc: correct powerSaveBlocker.stop return type
2023-08-02 11:39:40 +02:00
Shelley Vohr
303b707fbf
fix: update chrome.i18n for Manifest v3 ( #39291 )
...
fix: update chrome.i18n for Manifest v3
2023-08-02 11:02:16 +02:00
github-actions[bot]
aaae2abf20
build: update appveyor image to latest version e-117.0.5911.0. ( #39318 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-02 10:23:21 +02:00
David Sanders
0eef6c67d1
docs: fix return type for ipcMain handle functions ( #39237 )
2023-08-01 10:02:20 +02:00
Shelley Vohr
1f19a74417
fix: potential crash calling tray.popUpContextMenu() ( #39231 )
...
fix: potential crash calling tray.popUpContextMenu
2023-08-01 15:07:30 +09:00
Shelley Vohr
c8f7a0e052
fix: Chrome Extensions service worker host registration ( #39290 )
2023-08-01 15:04:38 +09:00
David Sanders
b2c62d6ad1
fix: initial dark mode title bar on Windows 10 ( #39287 )
2023-07-31 22:02:23 -07:00
electron-roller[bot]
cfc0826b65
chore: bump chromium to 117.0.5913.0 (main) ( #39172 )
...
* chore: bump chromium in DEPS to 117.0.5899.0
* 4686653: webui: Filter out non-chrome scheme URLs in WebUIConfigMap
https://chromium-review.googlesource.com/c/chromium/src/+/4686653
* 4696355: Remove deprecated version of base::CommandLine::CopySwitchesFrom()
https://chromium-review.googlesource.com/c/chromium/src/+/4696355
* chore: fixup patch indices
* 4603888: Reland "Enable raw_ref check on linux"
https://chromium-review.googlesource.com/c/chromium/src/+/4603888
* chore: bump chromium in DEPS to 117.0.5901.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5903.0
* chore: bump chromium in DEPS to 117.0.5903.2
* chore: bump chromium in DEPS to 117.0.5905.0
* 4706792: Printing: Add debug code for a DispatchBeforePrintEvent() failure
https://chromium-review.googlesource.com/c/chromium/src/+/4706792
* 4704786: Refactor libunwind build rules/flags
https://chromium-review.googlesource.com/c/chromium/src/+/4704786
* 4701710: [Linux Ui] Set toolkit dark preference based on FDO dark preference
https://chromium-review.googlesource.com/c/chromium/src/+/4701710
* chore: fixup patch indices
* chore: bump chromium in DEPS to 117.0.5907.0
* chore: bump chromium in DEPS to 117.0.5909.2
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5911.0
* chore: update patches
* chore: build-what-we-include
* fix: set allowFileAccess on devtools extensions correctly
Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725
* 4670615: Reland "[iterator-helpers] Shipping iterator helpers"
https://chromium-review.googlesource.com/c/v8/v8/+/4670615
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-07-31 10:47:32 -07:00
Shelley Vohr
8e5bb4949b
fix: skip artifact validation for doc-only PRs ( #39296 )
2023-07-31 09:59:51 -04:00
Milan Burda
724f90a2a7
refactor: throw errors directly in async functions ( #39233 )
2023-07-31 10:39:37 +02:00
David Sanders
68701c4c3c
chore: update @electron/lint-roller and improve doc type checks ( #39262 )
2023-07-31 10:39:01 +02:00
hunter
2b283724ce
docs: fix some string union type ( #39258 )
...
* docs: fix some string union types
Improve Type Union Typings in the Docs
* test: add smoke tests
* test: update `ses.clearStorageData` test case
* test: update `ses.clearStorageData` test case
---------
Co-authored-by: mhli <mhli@hillinsight.com >
2023-07-31 10:32:59 +02:00
Shelley Vohr
6df392162f
fix: pageVisibility state when backgroundThrottling disabled ( #39223 )
...
fix: pageVisibility state when backgroundThrottling disabled
2023-07-28 10:48:25 +02:00
Milan Burda
c9bae5da8e
refactor: use optional catch binding ( #39232 )
2023-07-27 10:53:45 -04:00
Samuel Attard
8dea783805
fix: do not resolve electron entrypoints on disk ( #39247 )
2023-07-26 22:10:58 -07:00
Shelley Vohr
695fcf3cb2
fix: reparenting after BrowserWindow.destroy() ( #39062 )
...
fix: reparenting after BrowserWindow.destroy()
2023-07-26 16:47:32 +02:00
Athul Iddya
fa5b1be6f3
fix: delete desktop capturers when they're not needed ( #39194 )
...
* fix: delete desktop capturers when they're not needed
Delete desktop capturer objects by resetting the DesktopMediaList
objects that own them after the sources have been collected. Capturers
that are not delegated are already being reset via a patch on
NativeDesktopMediaList. That is not safe for delegated capturers as
thumbnail generation depends on user events. Deleting the
DesktopMediaList operation is safe for all capturers and releases OS
capture resources as soon as possible.
* fix: add a patch to clean up PipeWire resources
Adding a patch to workaround a Chromium issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1467060
The patch can be removed when the issue is resolved.
2023-07-26 10:40:19 +02:00
Shelley Vohr
38c3d8df29
fix: traffic lights not working when child windows are restored via parent window ( #39225 )
2023-07-26 10:10:34 +02:00
Shelley Vohr
12548294c0
fix: resizable: false should disable fullscreen button at start ( #39086 )
...
fix: resizable should disable fullscreen button at start
2023-07-25 12:18:36 -04:00
Milan Burda
455f57322f
refactor: use TypeError instead of generic Error when appropriate ( #39209 )
...
refactor: use TypeError instead of generic Error when appropriate
2023-07-25 12:08:46 -04:00
George Xu
77cc1d6ffa
chore: add dependencies upgrade policy to readme ( #39163 )
...
* chore: add dependencies upgrade policy to readme
as per wg-releases july 19 meeting
https://docs.google.com/document/d/1XWdD4uAu9m8Gcpiw1j5fLwwZ_hU4rce9JyTpuKU6uM8/edit?pli=1
* Update CONTRIBUTING.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-07-25 11:58:16 +02:00
John Kleinschmidt
e543126957
ci: fail appveyor build if artifacts are missing ( #39210 )
2023-07-24 16:38:34 -04:00
Shelley Vohr
1231f0a734
docs: document idleDetector permissions ( #39180 )
...
doc: document idleDetector permissions
2023-07-24 14:57:41 -04:00
github-actions[bot]
cd408a826c
build: update appveyor image to latest version - e-117.0.5897.0 ( #38970 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-07-24 12:44:27 -04:00
Milan Burda
3df6d337f3
feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo() ( #38868 )
...
* feat: add isMainFrame to events emitted via ipcRenderer.sendTo()
* chore: rename isMainFrame to senderIsMainFrame
2023-07-24 14:27:30 +02:00
Michaela Laurencin
09e6e4b9a7
docs: update window-open.md to include target ( #39162 )
...
Update window-open.md to include target
2023-07-24 12:33:41 +02:00
David Sanders
2caf08059e
docs: update @electron/fuses code examples ( #39175 )
2023-07-24 12:33:26 +02:00
David Sanders
1ca3a7d3c9
docs: fill in Node.js version for v25 release ( #39187 )
2023-07-24 12:33:10 +02:00
Milan Burda
2c52eb7e1c
refactor: replace .indexOf() with .includes() ( #39195 )
2023-07-24 12:32:54 +02:00
Athul Iddya
9cd5de7588
fix: use generic capturer to list both screens and windows when possible ( #39111 )
...
Screensharing with PipeWire via XDG Desktop Portal requires explicit
user permission via permission dialogs. Chromium has separate tabs for
screens and windows and thus its portal implementation requests
permissions separately for each. However, the screencast portal has no
such limitation and supports both screens and windows in a single
request.
WebRTC now supports this type of capture in a new method called
called `CreateGenericCapturer`. The `desktopCapturer` implementation has
been modified to use it. Additionally, Chromium has been patched to use
same generic capturer to ensure that the source IDs remain valid for
`getUserMedia`.
2023-07-21 16:03:01 -07:00
David Sanders
a83f9c06d7
docs: update binding linking example in creating API doc ( #39177 )
2023-07-21 14:33:39 -07:00
David Sanders
b66449add5
ci: don't set column for draft issues on new project board ( #39178 )
2023-07-21 14:33:14 -07:00
Milan Burda
ada8eb33b2
feat: deprecate ipcRenderer.sendTo() ( #39091 )
...
* feat: deprecate ipcRenderer.sendTo()
* docs: add _Deprecated_ to ipcRenderer.sendTo()
2023-07-21 11:16:44 +02:00
David Sanders
3a5e2dd90c
docs: remove redundant IPC event sections ( #39133 )
...
* docs: use correct names for IPC events
* docs: remove redundant IPC event sections
2023-07-20 11:43:08 -07:00
Shelley Vohr
6688b0f31a
build: fix Appveyor test workflow checkout ( #39137 )
...
* build: fix Appveyor test workflow checkout
* fix: +refs/pull/num/merge -> +refs/pull/num/head
* chore: add to appveyor-woa as well
2023-07-20 11:19:57 +02:00
David Sanders
565705bd1d
docs: fix casing of _Deprecated_ ( #39152 )
2023-07-20 11:16:20 +02:00
electron-roller[bot]
e02cf8674d
chore: bump chromium to 117.0.5897.0 (main) ( #39147 )
...
* chore: bump chromium in DEPS to 117.0.5896.0
* chore: update patches
* 4622260: [Service Workers] Allow fetches from workers to use auto-picked certs
https://chromium-review.googlesource.com/c/chromium/src/+/4622260
* chore: bump chromium in DEPS to 117.0.5897.0
* 4665672: [ProfileSelections] Transition extension keyed factories to use Profile Selections
https://chromium-review.googlesource.com/c/chromium/src/+/4665672
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-20 09:36:59 +02:00
dependabot[bot]
3e7c904f02
build(deps): bump word-wrap from 1.2.3 to 1.2.4 ( #39148 )
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-19 19:24:26 +02:00
Charles Kerr
f2b32af1f6
perf: small perf changes in HidChooserController ( #39057 )
...
* perf: avoid string temporary in HidChooserController::PhysicalDeviceIdFromDeviceInfo()
return a const ref instead of a new string
* perf: avoid second map lookup in HidChooserController::AddDeviceInfo()
2023-07-19 16:54:30 +02:00
Cheng Zhao
cc39ddb728
test: add some environment variables for controlling tests ( #39149 )
...
chore: add some environment variables for controlling tests
2023-07-19 16:54:08 +02:00
electron-roller[bot]
bbdd037219
chore: bump chromium to 117.0.5892.0 (main) ( #39118 )
...
* chore: bump chromium in DEPS to 117.0.5892.0
* 4670267: Don't send javascript: or empty URLs to browser in CreateNewWindow.
https://chromium-review.googlesource.com/c/chromium/src/+/4670267
* 4662090: Add metrics for WebGPU support
https://chromium-review.googlesource.com/c/chromium/src/+/4662090
* 4672599: Use set_defaults for mac_app_bundle
https://chromium-review.googlesource.com/c/chromium/src/+/4672599
* 4663771: usb: Add connection count tracking methods for UsbDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/4663771
* 4664578: Remove unused parameter from ExtensionsGuestViewManagerDelegate ctor
https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* 4622253: usb: Create classes for usb system tray icon
https://chromium-review.googlesource.com/c/chromium/src/+/4622253
* 4678263: Remove ARC support from scoped_nsobject
https://chromium-review.googlesource.com/c/chromium/src/+/4678263
* chore: follow-up ARC changes and missing guard corrections
* chore: don't mark 0-param ctor explicit
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* chore: fixup patch indices
* 4670865: Merge ObjectProxy::CallMethodAndBlock{,WithErrorDetails}.
https://chromium-review.googlesource.com/c/chromium/src/+/4670865
* chore: follow-up ARC changes and missing guard corrections
* fixup: retain ElectronApplicationDelegate
* fix: correct rustc binary
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-19 00:26:27 +02:00
Shelley Vohr
ee4460ac68
build: correct codespaces devcontainer extensions settings ( #39123 )
2023-07-19 00:20:11 +02:00
Shelley Vohr
00d96970cb
build: fixup Codespaces build-tools setup ( #39138 )
...
* build: fixup Codespaces build-tools setup
* oops evm.testing1.json -> evm.testing.json
2023-07-18 22:58:26 +02:00
Keeley Hammond
139774ce48
docs: update stable dates ( #39128 )
2023-07-18 09:30:04 -07:00
Milan Burda
47951cc95b
refactor: use Date.now() instead of +new Date() ( #38901 )
...
refactor: use Date.now()
2023-07-18 10:58:02 +02:00
Shelley Vohr
8874306dc0
fix: window.open causing occasional Node.js crashes ( #38754 )
...
* fix: window.open causing occasional Node.js crashes
* chore: always free isolate data
* chore: clear pending ticks in worker thread
* fix: UAF crash when creating WebWorkerObserver
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-07-18 10:41:50 +02:00
ZWJKFLC
4ab0a5ade4
docs: fix a capitalization problem in messagePort tutorial ( #39083 )
...
fix a capitalization problem
For a rookie, this little mistake took a long time to find out.
2023-07-17 10:41:46 -07:00
Milan Burda
626f46f75a
refactor: use node scheme imports in docs/fiddles ( #39110 )
2023-07-17 10:30:53 +02:00
electron-roller[bot]
9645f7f6d8
chore: bump chromium to 117.0.5884.1 (main) ( #38969 )
...
* chore: bump chromium in DEPS to 117.0.5866.0
* chore: bump chromium in DEPS to 117.0.5868.0
* chore: update mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Minor manual patch syncing due to upstream code shear
* chore: update mas_disable_remote_layer.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4647191
Manually sync patch to minor upstream code shear
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641746
No manual changes; patch applied with fuzz
* chore: update mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Manually sync base/process/launch_mac.cc to minor upstream shear
Manually sync base/mac/foundation_util.mm to upstream changes:
_CFIsObjC use has been removed upstream, so we no longer need
to remove it 🎉
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658496
Manually sync patch to minor upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4625254
Manually sync patch to minor upstream code shear
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Xref: services/network/public/cpp/resource_request.cc
No manual changes; patch applied with fuzz
* chore: update add_electron_deps_to_license_credits_file.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634961
No manual changes; patch applied with fuzz
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4648411
No manual changes; patch applied with fuzz
* chore: update patches
* fixup! chore: update add_electron_deps_to_license_credits_file.patch
chore: license files must be an array
* chore: bump chromium in DEPS to 117.0.5870.0
* chore: update patches
* chore: run ./script/gen-libc++-filenames.js
* chore: update json_parse_errors_made_user-friendly.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4652014
v8 error message changed upstream; update Node test to match it
* chore: bump chromium in DEPS to 117.0.5872.0
* chore: update patches
* chore: explicitly cast x11::Window to unsigned int
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661049
This is an `enum class Window : uint32_t` defined in ui/gfx/x/xproto.h.
Previous versions of clang let this implicit cast happen,
but it generates a warning in the new clang roll.
* chore: remove unused #include
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4650453
header was removed upstream, so FTBFS unless removed here
* chore: add include guard patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4628373
h/t @jkleinsc
* chore: bump chromium in DEPS to 117.0.5874.0
* chore: update render_widget_host_view_mac.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661244
Manually sync patch to minor upstream code
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to upstream code shear
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to minor upstream code shear
* chore: update GetInitiatorProcessId()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641991
trivial upstream naming change: s/ProcessID/ProcessId/
* chore: sync to upstream SetInputRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4665245
Simple upstream chang: SetInputRegion() used to take a gfx::Rect* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<gfx::Rect> w/the same meaning.
* chore: sync to upstream SetOpaqueRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4656738
Simple upstream chang: SetOpaqueRegion() used to take a vector<Rect>* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<std::vector<gfx::Rect>> w/the same meaning.
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5876.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658375
We no longer need to patch out a field that's now removed upstream.
RenderWidgetHostNSViewBridgeOwner.remote_accessibility_element_
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658680
Manually sync patch to upstream code shear (ARC adoption).
* chore: update patches
* fix: -Werror,-Wshadow error in Node.js
* chore: bump chromium in DEPS to 117.0.5878.0
* chore: bump chromium in DEPS to 117.0.5880.0
* chore: bump chromium in DEPS to 117.0.5880.4
* chore: update patches
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
* WIP: 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* chore: update printing patch after rebase
* chore: bump chromium in DEPS to 117.0.5882.0
* Revert "WIP: 4658680: Convert /content/browser to use ARC"
This reverts commit c8559ea448 .
* Revert "4669995: Remove CFToNSCast and NSToCFCast"
This reverts commit 38e145f33d .
* chore: bump chromium in DEPS to 117.0.5874.0
* 4661244: Convert /content/browser/renderer_host to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4661244
* 4653209: Convert /ui/views:views to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4653209
* chore: fixup mas_disable_remote_accessibility.patch
* chore: fixup render_widget_host_view_mac.patch
* chore: update to newer clang
* chore: bump chromium in DEPS to 117.0.5884.1
(cherry picked from commit a3879acfde8f3d962d58d6ad0632164ccb88ee63)
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
(cherry picked from commit 38e145f33d )
(cherry picked from commit b1224ab7e00aedbd0e5dc78ebb3c6162573b28c4)
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
(cherry picked from commit 77039a323b9ebb3e8edb3a92a3b94a8d7d026a32)
* Rename and cleanup ExtensionsBrowserClient functions
| https://chromium-review.googlesource.com/c/chromium/src/+/4665670
(cherry picked from commit 677a2e646a8d82da60dc252b08b320c3ddff6be6)
* chore: bump chromium in DEPS to 117.0.5886.0
* chore: update patches
* Revert "chore: update patches"
This reverts commit db9294f944 .
* Revert "chore: bump chromium in DEPS to 117.0.5886.0"
This reverts commit a7de0276e6 .
* build: use built toolchains instead of locally installed VSCode
* fixup: build: use built toolchains instead of locally installed VSCode
* chore: add missing mojo dep
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-16 16:14:43 +02:00
Shelley Vohr
f61425efdb
fix: clipboard.readImage() should be synchronous ( #39069 )
...
* feat: clipboard.readImage returns a Promise
* chore: update breaking changes doc
* fix: make function synchronous
* Update docs/api/native-image.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-07-13 16:59:14 -04:00
Robo
34e7c3696a
feat: expose safestorage backend information on linux ( #38873 )
...
* feat: expose safestorage backend information on linux
* Remove gnome-keyring
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704
2023-07-13 11:14:33 +02:00
Charles Kerr
dc671804da
perf: avoid redundant lookup in BluetoothChooser::AddOrUpdateDevice() ( #39059 )
...
perf: avoid redundant map lookup in BluetoothChooser::AddOrUpdateDevice()
2023-07-13 10:16:25 +02:00
Milan Burda
b14b876d50
docs: fix fiddles ( #39060 )
...
* refactor: replace Array.prototype.forEach.call with plain for-of
* fix: add missing contextIsolation: false
* fix: open links in default browser
2023-07-13 10:10:37 +02:00
Charles Kerr
a8622aed7b
perf: avoid redundant map lookup in NativeImage::GetHICON() ( #39058 )
...
perf: avoid double map lookup in NativeImage::GetHICON()
2023-07-13 15:37:43 +09:00
Shelley Vohr
da3475998f
fix: BrowserWindow.moveAbove() not working for child windows ( #39034 )
...
fix: BrowserWindow.moveAbove() not working for child windows
2023-07-12 17:42:24 +02:00
Alka Vats
9d1a16b2e6
docs: updated the markup tag i with the em ( #39041 )
2023-07-12 15:52:10 +02:00
Shelley Vohr
b142fce229
fix: protocol.handle not intercepting file protocol ( #39048 )
...
fix: protocol.handle not intercepting file protocol
2023-07-12 11:42:49 +02:00
Mikhail Leliakin
f959fb0c96
feat: browserWindow.getBrowserViews() to return sorted by z-index array ( #38943 )
2023-07-11 11:01:30 +02:00
Athul Iddya
905e41bbdd
fix: use StartUpdating method for PipeWire capturer ( #38833 )
...
* fix: use StartUpdating method for PipeWire capturer
Fixed a crash related to PipeWire capturer by adapting to Chromium's
interface changes. Chromium expects a call to
`NativeDesktopMediaList::StartUpdating` with an implementation of
`DesktopMediaListObserver` for delegated capturers like PipeWire. This
interface allows listening to user permission events and listing
sources only after the user has made a choice on the permission dialog.
The interface has been implemented by an inner class to allow listening
to screen and window capture permissions concurrently using two
instances of the class. A patch that was resetting the capturer on the
first refresh has been changed to exclude PipeWire. PipeWire capturer
object will follow the lifecycle of `NativeDesktopMediaList`, as is the
case in Chromium.
Fixes #37463
* fix: wait for thumbnails from PipeWire when necessary
The PipeWire stream starts after the dialog is dismissed. If the sources
are listed immediately afterwards, the thumbnail may not have been
generated by that time. Explicitly wait for both thumbnail generation
and a selection on the source dialog before listing sources.
2023-07-11 10:21:11 +02:00
Athul Iddya
3e3152008f
fix: remove types from GTK CSS selectors ( #39003 )
...
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.
Fixes #38786
Co-authored-by: Athul Iddya <athul@iddya.com >
2023-07-10 22:52:12 +02:00
Anton Gilgur
f3f3f53904
docs: add link to Travis CI headless page ( #38990 )
...
docs(headless): link to Travis CI docs
- Travis has a specific page in its docs all about headless, with several different methods of using `xvfb`
- c.f. https://docs.travis-ci.com/user/gui-and-headless-browsers/
2023-07-10 16:45:18 -04:00
Shelley Vohr
117a700724
fix: printing optional access crash on Windows ( #38976 )
2023-07-10 09:26:29 -04:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
Mikhail Leliakin
56b5c00312
feat: add BrowserWindow.showAllTabs() for macOS ( #38965 )
2023-07-10 10:43:37 +02:00
John Kleinschmidt
040e9a027a
build: disable unneeded depot_tools update on Windows CI ( #39011 )
...
build: disable unneeded depot_tools update
2023-07-06 16:13:20 -04:00
Shelley Vohr
a97028bacf
fix: Notification 'Show' button visible when no actions exist ( #38997 )
2023-07-06 15:50:08 -04:00
Shelley Vohr
cc7d724a3b
fix: menu border being created properly on Windows 11 ( #38998 )
...
* fix: menu border being created properly on Windows 11
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-07-06 15:46:12 +02:00
Shelley Vohr
c7a64ab994
fix: webview crash when removing in close event ( #38996 )
2023-07-06 10:20:34 +02:00
Shelley Vohr
5a77c75753
revert: compensate for title bar height when setting bounds on BrowserView ( #38981 )
...
This reverts commit 75f9573e53 .
2023-07-06 09:50:08 +02:00
Varun Sood
ec4c9024b9
docs: Improved the Documentation on BrowserWindow type attribute ( #38666 )
...
* docs: Documentation changes
* made the required changes in the docs
* made the toolbar type text correction
2023-07-05 16:26:39 -04:00
Cheng Zhao
3fa15ebb7e
fix: use Chromium's way to compute min/max sizes ( #38974 )
2023-07-05 11:02:05 -04:00
David Sanders
52fe76ca28
ci: automate release board creation ( #38629 )
...
* ci: refactor determining major branch
* ci: automate release board creation
2023-07-03 10:34:57 +02:00
Sergei Chestakov
e991c1868e
docs: fix misleading code sample for handling deeplinks on Linux ( #38862 )
...
Fix misleading docs for handling deeplinks in Linux
2023-07-03 10:30:45 +02:00
electron-roller[bot]
ccd4531bfb
chore: bump chromium to 117.0.5852.0 (main) ( #38891 )
...
* chore: bump chromium in DEPS to 117.0.5846.0
* chore: update patches
* 4628901: Bump the macOS deployment target to 10.15
https://chromium-review.googlesource.com/c/chromium/src/+/4628901
* 4593350: [Private Network Access] Trigger Permission Prompt
https://chromium-review.googlesource.com/c/chromium/src/+/4593350
* 4631011: Remove unlaunched "InstallReplacementAndroidApp" Platform App APIs
https://chromium-review.googlesource.com/c/chromium/src/+/4631011
* chore: disable API deprecation warnings in NSKeyedArchiver
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 117.0.5848.2
* chore: update feat_add_set_theme_source_to_allow_apps_to.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629743
No manual changes; patch succeeded with fuzz
* chore: update process_singleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4605398
Trivial manual patch adjustments to account for code shear.
* chore: remove electron::BrowserContext::GetMediaDeviceIDSalt()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4608130
upstream tldr:
- content::BrowserContext::GetMediaDeviceIDSalt()
- content::ContentBrowserClient::ArePersistentMediaDeviceIDsAllowed()
+ content::ContentBrowserClient::GetMediaDeviceIDSalt()
This commit leaves ElectronBrowserContext::GetMediaDeviceIDSalt() in
place (now non-virtual, non-override). It is now called by the new
function ElectronBrowserClient::GetMediaDeviceIDSalt().
As a followup, we might want to consider using the new upstream
media_device_salt::MediaDeviceSaltService and removing our
electron::MediaDeviceIDSalt code. CC @MarshallOfSound for 2nd
opinion since he has done the most work on MediaDeviceIDSalt and
may have more context.
* chore: fix iwyu breakage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629624
electron_browser_main_parts.cc uses ui::ColorProviderManager but didn't
include it. Things worked anyway because we got it indirectly from
content/public/browser/web_contents.h until 4629624.
* chore: remove call to base::mac::IsAtLeastOS10_14
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in IAP
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in electron_application_delegate
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove broken-before-macOS-10.15 patch in mas_avoid_usage_of_private_macos_apis.patch
Upstream has bumped minimum to macOS 10.15
* chore: remove @available(macOS 10.14) check
Upstream minimum requirement for macOS is now 10.15
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5850.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5852.0
* chore: update patches
* Move two params from NetworkContextParams to NetworkContextFilePaths.
https://chromium-review.googlesource.com/c/chromium/src/+/4615930
* WebUSB: Add exclusionFilters to USBRequestDeviceOptions
https://chromium-review.googlesource.com/c/chromium/src/+/4614682
* Convert /chrome/browser/ui to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4615920
* fixup! Bump the macOS deployment target to 10.15
* fixup! Bump the macOS deployment target to 10.15
* chore: update libcxx files
* win: Remove 10Glass from Windows10Glass function and var names
https://chromium-review.googlesource.com/c/chromium/src/+/4641314
* chore: revert 392e5f43 from chromium
* Add an ExecutionContext to ScriptState
https://chromium-review.googlesource.com/c/chromium/src/+/4609446
* fixup! Add an ExecutionContext to ScriptState
* chore: fix header
* Revert "chore: revert 392e5f43 from chromium"
This reverts commit b7f782943e4ce83cae8cd35780d8d3618cf0772c.
* fix: return correct min/max sizes in WinFrameView
* fixup! Revert chore: revert 392e5f43 from chromium
* fixup! Add an ExecutionContext to ScriptState
* Revert "fixup! Revert chore: revert 392e5f43 from chromium"
This reverts commit 7e2c7281abfc4f309255339fdba073d90a9ae3eb.
* Revert "fix: return correct min/max sizes in WinFrameView"
This reverts commit 3f418b1ab5155686730e087ae6cabe4a21b4bb61.
* Revert "Revert "chore: revert 392e5f43 from chromium""
This reverts commit 56296d8b7c434147e032e3c3b08c0e371b6c27ba.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2023-07-01 16:22:55 -04:00
Samuel Attard
499d893040
feat: add support for keyboard initialized menu popup ( #38903 )
...
* feat: add support for keyboard initialized menu popup
* Update docs/api/menu.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: add patch to chromium for keyboard accessibility menu behavior
* refactor: s/initiatedByKeyboard/sourceType
* fix: ignore initial mouse event to retain keyboard initiated focus
* Update docs/api/menu.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2023-06-29 15:54:06 -07:00
Milan Burda
607e71d563
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() ( #38929 )
2023-06-27 16:57:33 -04:00
Cheng Zhao
09669f9d21
fix: child window may have opener removed ( #38910 )
2023-06-26 17:04:54 -04:00
github-actions[bot]
ff6d0df2d5
build: update appveyor image to latest version e-116.0.5845.0 ( #38913 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-26 15:57:10 -04:00
Milan Burda
81a454d148
chore: re-enable node/no-deprecated-api linting ( #38899 )
...
* chore: re-enable node/no-deprecated-api linting
* chore: re-enable no-global-assign linting
2023-06-26 13:51:59 -04:00
Charles Kerr
acba6d79fb
docs: document e27 breaking change of dropping macOS 10.13, 10.14 ( #38917 )
...
docs: document e27 breaking change of dropping macOS 10.13, 10.14 support
2023-06-26 13:29:00 -04:00
electron-roller[bot]
327af3b03c
chore: bump node to v18.16.1 (main) ( #38869 )
...
* chore: bump node in DEPS to v18.16.1
* chore: update patches
* deps: update c-ares to 1.19.1
https://github.com/nodejs/node/pull/48115
* chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
* chore: disable x509 bssl test
new test added in bf3e2c892
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix related -Werror,-Wunused-function FTBFS
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix another related -Werror,-Wunused-function FTBFS
* fixup! chore: disable x509 bssl test
fix yet another -Werror,-Wunused-function FTBFS
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-26 12:03:30 -04:00
Milan Burda
ef6569b7d3
chore: cleanup unusued variables + enable linting ( #38898 )
2023-06-26 02:51:54 -07:00
dependabot[bot]
e900f6ecc3
build(deps-dev): bump semver from 5.7.0 to 7.5.2 ( #38916 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.0 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.0...v7.5.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-23 13:17:43 -07:00
Milan Burda
9226cc662b
refactor: use types for once() return values in spec ( #38872 )
2023-06-22 14:38:52 -04:00
Milan Burda
abec9ead06
refactor: use node scheme imports in scripts ( #38846 )
...
* refactor: use node scheme imports in script
* refactor: use node scheme imports in build
2023-06-22 16:21:42 +02:00
Charles Kerr
395b608dd5
refactor: more constexpr lookup tables ( #38886 )
...
* refactor: use constexpr lookup table in electron_api_web_contents.cc
* refactor: make KeyboardCodeFromStr() private
it is only used as a helper to KeyboardCodeFromStr()
* chore: savepoint
* chore: make lint happy
* fixup! refactor: make KeyboardCodeFromStr() private
* refactor: use constexpr lookup table in electron_url_loader_factory
* refactor: use constexpr lookup table in electron_api_tray
* refactor: use constexpr lookup table in web_contents_preferences.cc
* refactor: use constexpr lookup table in content_converter
2023-06-22 14:33:44 +02:00
electron-roller[bot]
1eb19f3078
chore: bump chromium to 116.0.5845.0 (main) ( #38827 )
...
* chore: bump chromium in DEPS to 116.0.5835.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5837.0
* chore: bump chromium in DEPS to 116.0.5839.0
* chore: bump chromium in DEPS to 116.0.5841.0
* chore: bump chromium in DEPS to 116.0.5843.0
* Update patches
CLs that affected printing.patch:
- 4616791: Refactor PrintViewManagerBase::PrintNow()
https://chromium-review.googlesource.com/c/chromium/src/+/4616791
- 4602776: Make PrintNodeUnderContextMenu operation go through PrintViewManager
https://chromium-review.googlesource.com/c/chromium/src/+/4602776
* 4506614: geolocation: Add LocationProvider::FillDiagnostics
https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* chore: bump chromium in DEPS to 116.0.5845.0
* chore: update patches
* fixup! 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* 4609704: Remove gnome-keyring
https://chromium-review.googlesource.com/c/chromium/src/+/4609704
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2023-06-22 10:51:15 +02:00
Shelley Vohr
a00a25376d
fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents ( #38842 )
...
fix: crash calling removeBrowserView() with destroyed webContents
https://github.com/electron/electron/issues/37642
2023-06-21 15:20:54 -04:00
Michaela Laurencin
ce6fe040fe
fix: set minimize visibility true with enable ( #38860 )
2023-06-21 14:58:33 -04:00
Shelley Vohr
e73edb5481
feat: allow headers to be sent with session.downloadURL() ( #38785 )
2023-06-21 15:31:28 +02:00
Milan Burda
74d73166d9
chore: remove deleted guest-window-proxy.ts from CODEOWNERS ( #38848 )
...
chore: remove deleted /lib/browser/guest-window-proxy.ts from CODEOWNERS
2023-06-20 17:19:33 -04:00
Milan Burda
6bd02bf181
refactor: use node scheme imports in default_app ( #38847 )
2023-06-20 17:17:03 -04:00
github-actions[bot]
a595044989
build: update appveyor image to latest version - e-116.0.5833.0. ( #38803 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-20 14:15:00 -04:00
Shelley Vohr
f6bbc34658
fix: set supported scale factors on startup ( #38836 )
2023-06-20 12:24:03 -04:00
Milan Burda
2b3902e526
refactor: use content::GlobalRenderFrameHostId ( #38843 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-20 15:32:31 +02:00
Milan Burda
93024be3b2
build: rename spec/.eslintrc -> spec/.eslintrc.json ( #38838 )
...
chore: rename spec/.eslintrc -> spec/.eslintrc.json
2023-06-19 14:19:11 +02:00
Shelley Vohr
b693f88491
fix: crash on nativeTheme change during context menu close ( #38824 )
2023-06-19 11:26:54 +02:00
Charles Kerr
97132ece33
refactor: use constexpr lookup tables in gin helper ( #38818 )
...
* feat: add gin_helper::FromV8WithLookup()
feat: add gin_helper::FromV8WithLowerLookup()
* refactor: use constexpr lookup table in gin Converters
2023-06-19 10:33:09 +02:00
Charles Kerr
41ab5f327f
refactor: remove unused InspectableWebContentsView::GetWebView() ( #38799 )
2023-06-16 00:44:19 -05:00
electron-roller[bot]
7219142a54
chore: bump chromium to 116.0.5833.0 (main) ( #38809 )
...
* chore: bump chromium in DEPS to 116.0.5833.0
* chore: update patches
* 4530656: Add DeviceLoginScreenWebHidAllowDevicesForUrls policy
https://chromium-review.googlesource.com/c/chromium/src/+/4530656
* Split CertDatabase notifications between trust changes and client cert changes
https://chromium-review.googlesource.com/c/chromium/src/+/4596317
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-15 16:37:01 -04:00
Shelley Vohr
46fb0d8f5f
fix: webContents.print({ silent: true }) not working correctly ( #38741 )
...
fix: webContents.print({ silent: true }) not working correctly
2023-06-15 10:46:38 -04:00
Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-15 10:42:27 -04:00
Charles Kerr
bf1ba4a857
refactor: constexpr lookup tables ( #38771 )
...
* refactor: use a constexpr lookup table in GetPathConstant()
* refactor: use a constexpr lookup table in SystemPreferences::GetColor()
* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
2023-06-14 17:00:46 -04:00
electron-roller[bot]
bb4e9b27b5
chore: bump chromium to 116.0.5831.0 (main) ( #38784 )
...
* chore: bump chromium in DEPS to 116.0.5831.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-14 16:59:54 -04:00
github-actions[bot]
30579859c4
build: update appveyor image to latest version - e-116.0.5829.0 ( #38779 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-14 15:35:25 -04:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
Shelley Vohr
f7c0a29d89
build: update to latest TypeScript ( #38763 )
2023-06-14 11:06:46 -07:00
Shelley Vohr
10852b3fd5
fix: preferCSSPageSize error type ( #38761 )
...
fix: preferCSSPageSize error type
2023-06-14 10:49:00 -04:00
Milan Burda
dc2e822dc7
fix: asar integration for require('node:child_process') ( #38742 )
2023-06-14 18:03:53 +09:00
Samuel Attard
46458ab517
build: update typescript-generator and docs-parser ( #38747 )
...
* build: update typescript-generator and docs-parser
* again...
* build: handle more specific pageSize types
2023-06-13 16:22:53 -07:00
Keeley Hammond
9aefe5db33
build: move chrome_lib_arc to chromium_src/BUILD.gn ( #38764 )
2023-06-13 16:23:11 -04:00
Charles Kerr
167c2b250e
refactor: use compile-time cli arg sets. ( #38748 )
...
We're currently building these on the heap with `std::set<std::string>`
but this can be a very small compile-time container instead.
Marking as 'refactor' rather than 'perf' since this isn't called often,
but moving from heap to compile-time is good and using this container
makes the code more readable.
2023-06-13 14:37:59 -05:00
Milan Burda
1621fcf5d3
docs: add missing isSameDocument property to will-frame-navigate event details ( #37940 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 15:15:20 -04:00
github-actions[bot]
18d484f39c
build: update appveyor image to latest version e-116.0.5815.0. ( #38739 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-13 14:56:43 -04:00
Milan Burda
e37111edcc
build: remove enable_osr build flag ( #38703 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 14:48:53 -04:00
electron-roller[bot]
80a3ba5c68
chore: bump chromium to 116.0.5829.0 (main) ( #38726 )
...
* chore: bump chromium in DEPS to 116.0.5823.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5825.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5827.0
* chore: update patches
* 4568811: Integrate Search Prefetch with Extensions.
https://chromium-review.googlesource.com/c/chromium/src/+/4568811
* 4567511: [DevTools] Add recordCountHistogram API.
https://chromium-review.googlesource.com/c/chromium/src/+/4567511
* 4507692: Delete base/guid.h
https://chromium-review.googlesource.com/c/chromium/src/+/4507692
* 4589551: Convert some of /base to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4589551
Also:
4601769: Convert immersive mode controllers to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4601769
* [viz] Convert MaybeSizeInBytes() to take in SharedImageFormat
https://chromium-review.googlesource.com/c/chromium/src/+/4594677
* 4564108: [BRP] Enable check_raw_ptr_fields for Mac
https://chromium-review.googlesource.com/c/chromium/src/+/4564108
* chore: bump chromium in DEPS to 116.0.5828.0
* chore: bump chromium in DEPS to 116.0.5829.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-13 14:45:48 -04:00
Shelley Vohr
678d1aa37d
docs: clarify supported accelerator punctuation ( #38740 )
...
doc: clarify supported accelerator punctuation
2023-06-13 12:42:55 +02:00
David Sanders
f5869b6fb9
chore: change remaining usages of process.mainModule ( #38705 )
2023-06-12 09:55:36 +02:00
Charles Kerr
ab49e98401
perf: prefer base::StringPiece over std::string for build-time strings ( #38717 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
2023-06-12 09:55:22 +02:00
Shelley Vohr
fa6d14c22d
fix: webContents.print() cancellation callback ( #38709 )
...
fix: webContents.print() cancellation callback
2023-06-12 09:42:18 +02:00
Milan Burda
5d123765d9
feat: support node: prefixed requires in sandboxed renderer preloads ( #38567 )
...
feat: support node: prefixed requires in sandboxed renderer preloads
2023-06-10 14:36:16 -04:00
electron-roller[bot]
fd5e6fbc14
chore: bump chromium to 116.0.5817.0 (main) ( #38465 )
...
* chore: bump chromium in DEPS to 116.0.5793.3
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5795.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5797.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5799.0
* 4522192: [serial] Allow Bluetooth ports to be requested by service class ID. | https://chromium-review.googlesource.com/c/chromium/src/+/4522192
* 4545385: Create base::apple::Owned[frameworktype], use it for gfx::NativeEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4545385
* chore: bump chromium in DEPS to 116.0.5801.0
* chore: update patches
* 4562796: Use base::apple::Owned[frameworktype] for ui::PlatformEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4562796
* 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
* chore: bump chromium in DEPS to 116.0.5803.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5805.2
* chore: update patches
* 4547630: Move content/public/common/network_service_util.h to c/p/browser/ | https://chromium-review.googlesource.com/c/chromium/src/+/4547630
* 4510075: Adding extensions to network response experiment | https://chromium-review.googlesource.com/c/chromium/src/+/4510075
* 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: bump chromium in DEPS to 116.0.5807.0
* chore: update patches
* 4533536: [Privacy Hub] Geolocation manager used directly | https://chromium-review.googlesource.com/c/chromium/src/+/4533536
* chore: patch out ARC support from /chrome/browser
4571955: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4571955
* chore: bump chromium in DEPS to 116.0.5809.2
* chore: bump chromium in DEPS to 116.0.5811.0
* chore: update patches
* 4573627: Adopt base::NoDestructor for KeyedService factories | https://chromium-review.googlesource.com/c/chromium/src/+/4573627
* 4576878: Reland "Shared Storage: Add mojo method for observing response headers" | https://chromium-review.googlesource.com/c/chromium/src/+/4576878
* chore: bump chromium in DEPS to 116.0.5813.0
* chore: update patches
* fixup! 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: fix up lint
* test: (debug) use Promise.all in asan tests
* chore: manually roll DEPS to 116.0.5815.0
* chore: update patches
* 4585150: Convert /printing to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4585150
* test: (asan) extend timeout, clean up debugging
* chore: remove ARC chromium patch
* chore: update patches after main sync
* 4546398: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* build: add chrome_lib_arc for chromium_src/BUILD.gn sources
* fixup! 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-06-09 16:08:36 -07:00
Charles Kerr
a3448376a1
refactor: api web contents ownership ( #38695 )
...
* refactor: aggregate api::WebContents::exclusive_access_manager_ directly
* refactor: make WebContents::devtools_file_system_indexer_ scoped_refptr const
* refactor: make WebContents::file_task_runner_ scoped_refptr const
* refactor: make WebContents::print_task_runner_ scoped_refptr const
2023-06-09 15:28:11 -05:00
Shelley Vohr
c0d9764de9
fix: webContents.print parameter validation error ( #38614 )
2023-06-09 21:41:01 +02:00
Samuel Maddock
e8fd5fd3a8
fix: WCO transparent background ( #38693 )
...
* fix: WCO transparency
* doc: wco color transparency
* fix: transparent buttons when calling setTitleBarOverlay
2023-06-09 09:57:57 -07:00
Charles Kerr
d95ae19edf
refactor: add SessionPreferences::CreateForBrowserContext() ( #38656 )
...
Copy the NativeWindowRelay::CreateForWebContents() idiom
to simplify SessionPreferences's constructor and lifecycle.
2023-06-09 11:20:43 -05:00
Samuel Attard
12b85a77a8
build: upload node checksums before validating them ( #38710 )
2023-06-09 02:30:26 -07:00
Samuel Attard
38dc43f649
build: actually use m1.large for publish job ( #38706 )
2023-06-08 23:56:26 -07:00
Samuel Attard
43f5cf1eae
build: update sentry cli for m1 support ( #38704 )
2023-06-08 16:31:15 -07:00
David Sanders
2a81b2aea3
build: move uploadIndexJson to just before publishRelease ( #38659 )
...
* build: move uploadIndexJson to just before publishRelease
* chore: move uploadNodeShasums as well
2023-06-08 16:41:23 -04:00
Milan Burda
05d39d8313
build: remove enable_run_as_node build flag ( #38413 )
...
* feat: remove enable_run_as_node flag
* drop features.isRunAsNodeEnabled()
* use IsEnvSet() helper in electron_main_linux.cc
* cleanup [[maybe_unused]]
---------
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-08 16:40:08 -04:00
John Kleinschmidt
806f00285c
build: ensure correct dsymutil is downloaded for macOS ( #38692 )
2023-06-08 13:39:13 -07:00
Cheng Zhao
534bf77d9b
chore: modify patches so we can build other chromium targets ( #38637 )
...
chore: tune patches so we can build other chromium targets
2023-06-08 13:30:36 -04:00
Charles Kerr
9d8da7839e
fix: dangling pointer warning when updating menus ( #38643 )
2023-06-08 09:29:32 -05:00
Charles Kerr
95d6a932ca
build: use upstream's presubmit cpplint filters. ( #38638 )
2023-06-08 09:25:56 -05:00
David Sanders
4956bcc6bd
ci: remove release dependencies workflow ( #38646 )
2023-06-08 12:33:35 +02:00
wgsheng
c8bdd014c8
fix: menu bar visibility when exiting full screen ( #38599 )
2023-06-08 12:19:34 +02:00
Shelley Vohr
5ee890fb6f
fix: reparenting UAF crash on macOS ( #38603 )
2023-06-08 12:18:37 +02:00
Shelley Vohr
9a9d8ae5ea
refactor: add ARC scaffolding for macOS ( #38621 )
2023-06-08 10:26:33 +02:00
Milan Burda
0294debc31
build: remove enable_picture_in_picture build flag ( #38620 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-07 23:56:31 -07:00
Shelley Vohr
933544d449
chore: clean up ElectronPermissionManager ( #38636 )
...
chore: clean up ElectronPermissionManager
2023-06-07 23:55:36 -07:00
David Sanders
bbfba4fc24
build: fix semver/none label on appveyor update PR ( #38647 )
2023-06-07 23:52:05 -07:00
Dani Haro
be45614f6f
docs: indicate app.setBadgeCount() needs notifications permission to work ( #38648 )
...
docs: match docs for `app.badgeCount` and `app.setBadgeCount()`
2023-06-07 23:51:49 -07:00
Erick Zhao
1f08e46bca
docs: use local img for contents.adjustSelection api ( #38655 )
...
* docs: use local img for contents.adjustSelection api
* fixup
2023-06-07 23:49:19 -07:00
David Sanders
714402b08e
build: improve error output in release.js ( #38658 )
2023-06-07 16:49:12 -07:00
Samuel Attard
08ab45535d
build: use m1 hosts to build apple silicon binaries ( #38258 )
...
* build: try m1 speed test
* yolo?
* build: fix gn binary on m1
* build: remove arm64 snapshot logic
* build: strip x64 on arm64 hosts...
* if is fi
* build: no more GENERATE_CROSS_ARCH_SNAPSHOT
* build: chromedriver inline on arm64 darwin
* build: no copy chromedriver
* build: use m1 for publish
* medium?
2023-06-07 16:34:02 -07:00
Charles Kerr
69790f4b2a
refactor: remove unused OffScreenRenderWidgetHostView fields ( #38623 )
2023-06-07 16:28:35 -05:00
Shelley Vohr
c5972ba43c
fix: bad error passing webContents.print(null) ( #38612 )
...
fix: bad error passing webContents.print(null)
2023-06-07 19:18:26 +02:00
Shelley Vohr
86824c070e
fix: validate response in protocol.handle() ( #38587 )
...
fix: validate response in protocol.handle()
2023-06-07 09:29:04 +02:00
Charles Kerr
5931f69f18
fix: sync api::Screen wrapper method sigs to upstream ( #38597 )
...
refactor: sync api::Screen getter sigs to upstream
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(),
and GetDisplayNearestPoint() methods are all const, so make our wrappers
const too.
ui::Display GetAllDisplays() returns a const reference, so make our
wrapper return a const reference too. This avoids creating a new
std::vector<display::Display> each time it's called.
2023-06-07 09:28:50 +02:00
John Kleinschmidt
80246cf97f
docs: removed outdated Appveyor doc ( #38622 )
2023-06-06 15:38:07 -07:00
zeeker999
28332c94bf
feat: Allow customizing the default math font ( #38514 )
2023-06-06 17:26:32 -04:00
Charles Kerr
5c1321b20a
refactor: remove redundant resizing strategy equality check ( #38596 )
...
* refactor: remove redundant resizing strategy equality check
Upstream already checks this.
2023-06-06 14:03:39 -05:00
Shelley Vohr
7982c6cee2
build: remove V8 patch for ArrayBuffer DCHECK ( #38591 )
2023-06-06 10:21:58 +02:00
Shelley Vohr
b2059f288a
fix: account for BrowserView bounds in setting autofill popup bounds ( #38489 )
2023-06-06 10:21:42 +02:00
Milan Burda
bb2ba35b51
refactor: use process_util.h helpers ( #38574 )
...
refactor: use process_util.h helpers
2023-06-06 17:19:13 +09:00
Shelley Vohr
8d689c565a
fix: file selection when disallowed on macOS ( #38557 )
2023-06-05 14:08:10 +02:00
David Sanders
905aad9cb6
chore: type check JS in docs ( #38423 )
...
* build(deps): update @electron/lint-roller
* chore: type check JS in docs
* docs: add @ts-check and @ts-expect-error to code blocks
* chore: fix type check errors in docs
* chore: add ts-type to blocks
2023-06-05 16:26:26 +09:00
David Sanders
4c89061e0e
docs: fix SerialPort typing ( #38544 )
2023-06-05 15:58:30 +09:00
Milan Burda
8fdd7de3d2
docs: clarify which electron modules are exposed in sandboxed renderers ( #38568 )
2023-06-05 15:57:15 +09:00
Charles Kerr
83d023747c
refactor: use direct aggregation in NativeWindowViews ( #38559 )
...
* refactor: in NativeWindowViews, aggregate root_view_ directly
* refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly
* refactor: make NativeWindowClientView::window_ a raw_ref
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields
Prefer const raw_ref<T> whenever the held pointer will never be null
* chore: make lint happy
2023-06-05 14:37:46 +09:00
Charles Kerr
05db963f87
chore: remove unused electron::api::View code ( #38561 )
...
chore: remove unused electron::api::View methods
Remove code that was added in 2c8dc9e but never used.
2023-06-03 10:40:44 -05:00
Charles Kerr
f247ca3f62
perf: avoid unnecessary base value clone ( #38537 )
2023-06-02 08:38:29 -05:00
Shelley Vohr
d818f35ad4
build: fix doc-only early exit on Appveyor ( #38547 )
2023-06-01 10:40:35 -04:00
Sergey
9ffffdb6ef
docs: fix performance tutorial ( #38469 )
...
* docs: fixed "Analyze runtime performance" link
* docs: added missing list item
2023-05-31 15:56:06 -04:00
Charles Kerr
c14f7b7d0b
refactor: remove unused switches ( #38497 )
...
* refactor: remove unused declaration of electron::kSHA1Certificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MajorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MinorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kCertificateError
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificateDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription
usage removed in 497f5a1
* refactor: remove electron::options::kPreloadScripts
removed in bad8d5e0
* refactor: remove electron::options::kImageAnimationPolicy
removed in 385d0f5
2023-05-31 15:55:21 -04:00
David Sanders
74b8133a93
ci: set description for release labels ( #38528 )
2023-05-31 15:49:16 -04:00
Shelley Vohr
57147d1b8d
fix: navigator.connection not working as intended ( #38491 )
...
* fix: navigator.connection not working as intended
* chore: make network quality methods private
2023-05-31 11:06:25 -04:00
Milan Burda
67f273a6d6
docs: add <webview> new-window event removal to breaking-changes.md ( #36985 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-31 10:47:08 -04:00
Shelley Vohr
b454f8c7c1
build: combine and elaborate on exposed BoringSSL ciphers ( #38506 )
...
build: combine and elaborate on exposed BoringSSL ciphers
2023-05-31 10:30:04 -04:00
Shelley Vohr
663497dc6b
chore: make contentTracing.stopRecording() failure clearer ( #38488 )
...
chore: make contentTracing.stopRecording() failure clearer
2023-05-31 09:54:41 -04:00
Shelley Vohr
115d37477e
build: shrink unnecessary test changes in patch revert ( #38505 )
...
build: shrink unneccesary test changes in patch revert
2023-05-31 09:52:13 -04:00
Matt Henkes
2c742cfadb
chore: cherry-pick 0e1cc35 from v8 ( #38490 )
2023-05-31 11:58:48 +02:00
Shelley Vohr
40e724e5dd
fix: DCHECK minimizing parent window with non-modal child ( #38460 )
2023-05-31 11:57:44 +02:00
github-actions[bot]
13f9e2db40
build: update appveyor image to latest version ( #38449 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-30 21:13:33 -04:00
Shelley Vohr
a769b48164
ci: clean up docs only change logic ( #38456 )
2023-05-30 12:38:41 -04:00
John Kleinschmidt
b4ec363b3d
feat: add USB protected classes handler ( #38263 )
...
* feat: add USB protected classes handler
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs
* chore: apply review suggestions
* update doc per suggestion
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-05-30 12:35:25 -04:00
Milan Burda
71fb19ea14
chore: upgrade to eslint v8 ( #38472 )
...
chore: upgrade to eslint@8
2023-05-30 13:10:22 +02:00
Milan Burda
a6f7c7690d
refactor: use literals instead of new RegExp() where possible ( #38458 )
2023-05-30 10:53:11 +02:00
Charles Kerr
0203bd3305
refactor: prefer base::Contains() over find() + end() ( #38443 )
...
* refactor: use base::Contains() in KeyWeakMap::Has()
* refactor: use base::Contains() in WebRequest::RequestFilter::MatchesType()
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in DeepFreeze()
* refactor: use base::Contains() in Clipboard::Read()
* Revert "refactor: use base::Contains() in BaseWindow::AddBrowserView()"
This reverts commit 60152359d3978451ebdd7c8eed602c2fb8a9cafa.
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in IsDevToolsFileSystemAdded()
* refactor: use base::Contains() in MessagePort::DisentanglePorts()
* refactor: use base::Contains() in PowerSaveBlocker::IsStarted()
* refactor: use base::Contains() in SpellCheckClient::OnSpellCheckDone()
* refactor: use base::Contains() in ShowTaskDialogWstr()
* refactor: use base::Contains() in PrintViewManagerElectron::ScriptedPrint()
* refactor: use base::Contains() in PrintViewManagerElectron::DidGetPrintedPagesCount()
* refactor: use base::Contains() in NativeWindow::AddDraggableRegionProvider()
* refactor: use base::Contains() in ElectronBindings::ActivateUVLoop()
* refactor: use base::Contains() in NativeWindowViews::IsVisibleOnAllWorkspaces()
* refactor: use base::Contains() in HidChooserController::OnDeviceAdded()
* refactor: use base::Contains() in ElectronSandboxedRendererClient::WillReleaseScriptContext()
* refactor: use base::Contains() in ElectronRendererClient::WillDestroyWorkerContextOnWorkerThread()
* refactor: use base::Contains() in GlobalShortcut::OnKeyPressed()
2023-05-30 10:28:43 +02:00
Shelley Vohr
9640ac441d
build: make ReactiveObjC/Mantle deps format consistent ( #38450 )
2023-05-29 10:44:21 +02:00
Shelley Vohr
b233d0805a
chore: process.mainModule -> require.main ( #38452 )
...
chore: process.mainModule -> require.main
2023-05-29 10:44:09 +02:00
Shelley Vohr
56138d879e
fix: Windows FrameView always appearing inactive ( #38468 )
2023-05-28 18:39:13 -04:00
electron-roller[bot]
ddcec84ace
chore: bump chromium to 116.0.5791.0 (main) ( #38448 )
...
* chore: bump chromium in DEPS to 116.0.5791.0
* 4504298: Relax checks in BlobDataBuilder::AppendBlob.
https://chromium-review.googlesource.com/c/chromium/src/+/4504298
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-25 16:10:08 +02:00
Milan Burda
185180a8e2
refactor: tweak bindings in typings/internal-ambient.d.ts for readability ( #38411 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-25 14:53:23 +02:00
Milan Burda
470b1d9e9d
refactor: split clipboard module implementation for browser / renderer ( #38429 )
2023-05-25 20:36:12 +09:00
Charles Kerr
a20896f519
refactor: remove InspectableWebContents::GetAll() ( #38442 )
...
It is unused and also keeps a persistent std::list<>, so remove it.
2023-05-25 17:23:19 +09:00
electron-roller[bot]
64045fd058
chore: bump chromium to 115.0.5790.0 (main) ( #38418 )
...
* chore: bump chromium in DEPS to 115.0.5789.0
* 4550346: Revert "Convert /chrome/browser to use ARC"
https://chromium-review.googlesource.com/c/chromium/src/+/4550346
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5790.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-25 09:54:26 +02:00
David Sanders
294f196907
build: upgrade @electron/github-app-auth to 2.0.0 ( #38435 )
2023-05-25 09:54:09 +02:00
Milan Burda
82af000a37
chore: cleanup eslint suppressions ( #38417 )
...
* chore: cleanup eslint suppressions
* address feedback
* revert script/lib/azput.js
* revert spec/fixtures/apps/remote-control/main.js
* address feedback
* revert typings/internal-ambient.d.ts
2023-05-25 10:09:17 +09:00
github-actions[bot]
1c075e5ea0
chore: update appveyor image to latest version ( #38426 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-24 17:03:14 -04:00
Shelley Vohr
ec85be3fb0
docs: ensure app.md examples are runnable ( #38416 )
...
docs: ensure app.md examples are runnable
2023-05-24 16:41:29 -04:00
Milan Burda
06cc9caeaa
build: remove enable_desktop_capturer flag ( #38412 )
...
feat: remove enable_desktop_capturer flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 15:32:31 -04:00
Milan Burda
13fae292a7
build: remove unused enable_color_chooser build flag ( #38419 )
...
chore: remove unused enable_color_chooser build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 21:24:42 +02:00
Alexey Kuzmin
c4c17d7534
build: fix build with "enable_pdf_viewer=false" ( #38421 )
...
* build: fix build with "enable_pdf_viewer=false"
* fixup! build: fix build with "enable_pdf_viewer=false"
2023-05-24 14:37:07 -04:00
Milan Burda
a043a60b89
refactor: cleanup global variable declarations ( #38410 )
...
refactor: eliminate duplicate isolatedApi typing
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:01:07 +02:00
Milan Burda
2f8e68f8b3
chore: remove ViewsDelegate::IsWindowInMetro() override ( #38409 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:00:52 +02:00
Shelley Vohr
16cd486356
fix: MediaDevices missing DisplayMediaInformation ( #38390 )
...
fix: MediaDevices missing DisplayMediaInformation
2023-05-24 11:17:08 -04:00
David Sanders
f07b040cb9
build: update yarn.lock ( #38422 )
2023-05-24 10:19:47 +02:00
Milan Burda
b6ef4a3929
build: remove unused enable_tts build flag ( #38420 )
...
chore: remove unused enable_tts build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 10:18:43 +02:00
Cheng Zhao
dec9a1d9db
chore: remove dead draggable region code ( #38404 )
2023-05-24 10:03:07 +02:00
Charles Kerr
b6c80ba646
fix: dangling_raw_ptr warning in electron_api_web_contents ( #38403 )
...
fix: dangling_raw_ptr warning in electron_api_web_contents
2023-05-23 21:52:07 -04:00
Charles Kerr
30e992dec4
chore: bump chromium to 115.0.5786.0 (main) ( #38301 )
...
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609a ),
but upstream has removed this API.
CC @codebytere
* fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch
* chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
https://chromium-review.googlesource.com/c/chromium/src/+/4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
https://chromium-review.googlesource.com/c/chromium/src/+/4521894
* 4525355: Move backup_util and bundle_locations to base/apple
https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
https://chromium-review.googlesource.com/c/chromium/src/+/4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
https://chromium-review.googlesource.com/c/chromium/src/+/4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
https://chromium-review.googlesource.com/c/v8/v8/+/4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-23 21:58:58 +02:00
Kilian Valkhof
e7b8bb4766
docs: disablewebsecurity on webview-tag can not be changed for an active session ( #38373 )
...
disablewebsecurity on webview-tag can not be changed for an active session
2023-05-22 16:29:41 +02:00
Shelley Vohr
aebcd3a8c4
build: try removing V8 symbol export patch for Windows ( #38391 )
2023-05-22 15:10:29 +02:00
Bruno Pitrus
395abf5620
fix: linker error missing uv__strtok ( #38382 )
...
fix: linker error missing uv__strtok
This symbol is referenced inside what seems to be dead code
in `uv__search_path` in third_party/electron_node/deps/uv/src/unix/core.c
When compiling in LTO mode, the reference is removed,
but not during a non-LTO build.
2023-05-22 13:00:45 +02:00
Keeley Hammond
508d7c1353
docs: update timelines for E26 ( #38378 )
...
docs: update E26 timeline, add E22 support note
2023-05-19 12:05:45 -07:00
Shelley Vohr
826c29abcc
build: use @octokit/request v6.2.4 ( #38346 )
2023-05-18 15:37:58 -07:00
Milan Burda
2acb97aa85
chore: eliminate a few uses of base::AdaptCallbackForRepeating() ( #38293 )
2023-05-18 17:01:44 -04:00
Shelley Vohr
642950a00e
build: try removing V8 DCHECK patch ( #38341 )
2023-05-18 20:53:15 +02:00
Shelley Vohr
b35ec4a23c
build: modify gclient.py with unified patch ( #38351 )
...
* build: modify gclient.py with unified patch
* ci: ensure depot_tools does not update
* ci: move auto-update disable outside if
2023-05-17 14:54:26 -04:00
David Sanders
e138f5f915
docs: fix typing of message box type value ( #38336 )
...
* docs: fix typing of dialog type value
* test: add smoke tests
* test: update test
2023-05-17 10:33:30 -07:00
David Sanders
a22635bd9f
docs: update example to use app.whenReady() ( #38337 )
...
* docs: update example to use app.whenReady()
* docs: retain async
2023-05-17 10:32:59 -07:00
Shelley Vohr
683235daf0
build: combine V8 BUILD.gn patches ( #38342 )
...
* build: combine V8 BUILD.gn patches
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-17 13:17:52 +02:00
Shelley Vohr
32d8f84cad
fix: getNormalBounds() for transparent windows on Windows ( #38218 )
2023-05-17 13:11:43 +02:00
Shelley Vohr
ad07712561
fix: win.isMaximized() for transparent windows on Windows ( #38234 )
2023-05-17 10:17:08 +02:00
Shelley Vohr
9902e01d2c
build: remove CppHeapCreateParams patch ( #38321 )
...
build: remove CppHeapCreateParams patch
2023-05-17 09:52:29 +02:00
Shelley Vohr
e08c583dea
build: remove V8 ARM undefined symbol patch ( #38316 )
2023-05-17 09:52:10 +02:00
Samuel Attard
2a16c73834
chore: cherry-pick e6e23ba00379 from chromium ( #38323 )
...
* chore: cherry-pick e6e23ba00379 from chromium
* make it work
2023-05-16 15:21:22 -07:00
David Sanders
c7ca29e80f
chore: add smoke test for devtools-open-url ( #38302 )
2023-05-16 16:42:24 -04:00
Calvin
fa81f77f40
test: re-enable tests that aren't broken & remove old test ( #38251 )
2023-05-16 14:30:25 +02:00
Shelley Vohr
c05051e307
chore: remove obsoleted DecrementCapturerCount patch ( #38294 )
...
chore: remove obsoleted DecrementCapturerCount patch
2023-05-16 14:29:01 +02:00
Shelley Vohr
8b63a3fc8a
build: bump brew cache to v6 ( #38312 )
2023-05-16 12:38:30 +02:00
Shelley Vohr
e83197669c
fix: unify BrowserWindow.isVisible() logic cross-platform ( #38242 )
2023-05-16 11:46:45 +02:00
Shelley Vohr
9bd9d312f8
fix: enable BrowserWindow.id access post-destruction ( #38241 )
...
fix: enable BrowserWindow id access post-destruction
2023-05-16 09:29:00 +02:00
Shelley Vohr
042663e190
fix: isMaximized after minimize/fullscreen on macOS ( #38291 )
...
fix: isMaximized after isMinimized on macOS
2023-05-16 09:26:41 +02:00
Shelley Vohr
e19500fa03
feat: support Mica/Acrylic on Windows ( #38163 )
...
* feat: support Mica/Acrylic on Windows
* chore: feedback from review
2023-05-15 16:31:57 -04:00
Shelley Vohr
c2d7164021
chore: remove unnecessary spellchecker revert patch ( #38248 )
2023-05-15 16:17:00 -04:00
Shelley Vohr
a1b2dae68e
build: add labels to appveyor update PR ( #38292 )
2023-05-15 16:52:25 +02:00
David Sanders
c591ecf518
test: prewarm Node headers cache if specifying Electron version ( #38287 )
2023-05-15 02:10:22 -07:00
Samuel Attard
d1c5e623fa
build: drop python2 from CI ( #38259 )
...
* build: drop python2 from CI
* python3
* python3 uses linux not linux2
2023-05-15 02:06:12 -07:00
github-actions[bot]
9ac4787325
build: update appveyor image to latest version ( #38257 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-15 10:53:38 +02:00
Cesar Kohl
6645f49a9d
chore: variable name should comply with naming convention ( #38249 )
2023-05-15 10:30:22 +02:00
Shelley Vohr
e7fc1a422d
feat: add missing 'cursor-changed' type values ( #38210 )
2023-05-15 10:27:09 +02:00
David Sanders
eeb1e7d499
chore: fix lint:js-in-markdown script ( #38260 )
2023-05-15 09:58:35 +02:00
Milan Burda
0149ae72e6
refactor: use standard naming for enum class values ( #38232 )
2023-05-12 15:24:01 +02:00
Milan Burda
88a9962e22
refactor: convert HashAlgorithm to enum class ( #38233 )
2023-05-12 15:23:42 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Keeley Hammond
141175c723
build: disable v8 builtins pgo ( #38252 )
2023-05-10 20:53:18 -07:00
Keeley Hammond
95cd84f140
build: fix octokit resolution with patch-package ( #38250 )
2023-05-10 20:52:59 -07:00
electron-roller[bot]
894e056e6b
chore: bump chromium to 115.0.5760.0 (main) ( #38033 )
...
* chore: bump chromium in DEPS to 114.0.5721.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5723.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5725.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5727.0
* chore: bump chromium in DEPS to 114.0.5729.0
* chore: bump chromium in DEPS to 114.0.5731.0
* chore: update patches
* 4450570: Clean up content shell
https://chromium-review.googlesource.com/c/chromium/src/+/4450570
* 4262527: geolocation: Introduce mojom::GeopositionResult
https://chromium-review.googlesource.com/c/chromium/src/+/4262527
* 4450327 : Android/Nav: Stop taking content timeout timer from old host.
https://chromium-review.googlesource.com/c/chromium/src/+/4450327
Also, see:
4451366: Reland "Prerender: Fix prerender new content timeout start timing"
https://chromium-review.googlesource.com/c/chromium/src/+/4451366
* chore: bump chromium in DEPS to 114.0.5733.2
* chore: update patches
* chore: bump CircleCI xcode version
this will hopefully get us the necessary macOS sdk 13.3 on CI.
* chore: bump chromium in DEPS to 114.0.5735.0
* chore: update patches
* test: fix geolocation test
* chore: bump chromium in DEPS to 115.0.5736.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5738.0
* chore: update patches
* fix: remove profiles from spellcheck service
* chore: update libc++ filenames
* chore: bump chromium in DEPS to 115.0.5740.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5742.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5744.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5746.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 115.0.5748.0
* chore: update patches
* build: update libcxx filenames
* chore: bump chromium in DEPS to 115.0.5750.0
* chore: bump chromium in DEPS to 115.0.5752.2
* chore: bump chromium in DEPS to 115.0.5754.0
* chore: bump chromium in DEPS to 115.0.5756.0
* chore: bump chromium in DEPS to 115.0.5758.0
* chore: update patches
* chore: update patch after rebase
* 4500969: Delete content/dev_ui_content_resources.grd file.
https://chromium-review.googlesource.com/c/chromium/src/+/4500969
* Use base.Value.Dict in OmahaAttributesHandler related code
https://chromium-review.googlesource.com/c/chromium/src/+/4506402
* chore: bump chromium in DEPS to 115.0.5760.0
* chore: update patches
* chore: fixup line endings
* 4336172: Include client-drawn window decorations in aspect ratio. |
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4336172
(cherry picked from commit 27c2f6c43e )
* spec: fix race condition in alwaysOnTop test
(cherry picked from commit 2ec5213fa0 )
* build: use xcode 14.2 not 14.3
(cherry picked from commit b7c62351a7 )
* build: use macOS 12 to run tests
The new macOS 13 VMs appear to have different screen / display behavior
(cherry picked from commit 14dc1dbc24 )
* Remove always-true flag --harmony-sharedarraybuffer
https://chromium-review.googlesource.com/c/v8/v8/+/4429630
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2023-05-10 10:47:48 -04:00
Shelley Vohr
2806feede2
docs: fix devtools-open-url ts definition ( #38231 )
...
docs: fix devtools-open-url ts definition
2023-05-10 11:25:50 +02:00
Shelley Vohr
13e309e1fb
fix: only exit fullscreen conditionally with setKiosk ( #38219 )
...
fix: only exit fullscreen conditionally with setKiosk
2023-05-09 12:28:37 -04:00
Shelley Vohr
f432245456
fix: handle AXManualAccessibility attribute cross-protocol ( #38142 )
...
* fix: handle AXManualAccessibility attribute cross-protocol
* Update shell/browser/mac/electron_application.mm
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2023-05-09 11:13:14 +02:00
Shelley Vohr
0212c264ca
build: fix CRLF endings in messages.json ( #38212 )
2023-05-08 14:51:24 -04:00
David Sanders
9ccf2275d2
chore: migrate to @electron/lint-roller for Markdown linting ( #38191 )
2023-05-08 12:50:42 +02:00
David Sanders
911900eae9
build: add pretest script to create TS definitions ( #38201 )
2023-05-08 11:30:06 +02:00
David Sanders
7a03509b71
ci: automate release label tasks ( #38181 )
2023-05-08 10:39:28 +02:00
Shelley Vohr
a6c9aefb4a
chore: fix TrustedTypes policy in chrome://accessibility ( #38179 )
...
chore: fix TrustedTypes policy in chrome://accessibility
2023-05-08 10:39:04 +02:00
Calvin
13be6dc8b4
test: enable CircleCI's "re-run failed tests only" feature ( #38178 )
...
* test: enable CircleCI rerun failed *tests* only
* .
* .
* console.log never fails 🤷
* normalize the filtered paths
circleci gives us a list of absolute paths here
* remove test output check
sometimes rerunning only failed tests results in some runners having
no tests to run, and thus no output
* keep relative paths the same
* error for when no tests match
* cleanup
* .
2023-05-08 17:14:59 +09:00
David Sanders
3a7cfe300a
ci: do conditional in blocked/need-repro workflows at job level ( #38186 )
2023-05-08 17:07:04 +09:00
Adam Stone-Lord
88710612a3
docs: update dead link to Apple Human Interface notification guidelines ( #38187 )
2023-05-08 17:05:50 +09:00
Calvin
58d49927a3
test: disable flaky asar worker test on ASan build ( #38193 )
2023-05-08 17:03:30 +09:00
Shelley Vohr
534e90c2a6
build: force LF checkout of more files ( #38194 )
2023-05-08 17:02:42 +09:00
Shelley Vohr
35a03a6bc1
refactor: remove IPC from mouse_util ( #38183 )
2023-05-08 09:50:30 +02:00
David Sanders
a7adbae543
docs: fix typing of session.setDevicePermissionHandler ( #38188 )
2023-05-08 09:46:35 +02:00
Shelley Vohr
f8d534f33e
chore: stop using a RenderWidgetHost observer in FileSelectHelper ( #38168 )
...
chore: stop using a RenderWidgetHost observer in FileSelectHelper
2023-05-04 21:43:29 +02:00
David Sanders
ec75172d68
ci: update CircleCI CLI install URL ( #38176 )
2023-05-04 10:40:01 -04:00
Shelley Vohr
bb490161fb
fix: printing crash when settings invalid ( #38165 )
2023-05-04 09:10:54 -04:00
Alexey Kuzmin
bc957e3945
test: use await to call "closeWindow" ( #38166 )
...
* test: wait for an async "closeWindow" call
* fixup! test: wait for an async "closeWindow" call
2023-05-04 07:14:46 +09:00
Shelley Vohr
ee1e6aab3e
chore: implement WebContentsDelegate::GetFullscreenState ( #38141 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4255184
2023-05-03 15:55:47 +02:00
Russell Carpenella
7f5364f98d
docs: moves icpMain.handle call in tutorial part 3 ( #38138 )
2023-05-03 14:52:02 +02:00
Shelley Vohr
a8c0ed890f
feat: surface more webContents text selection commands ( #37978 )
...
* feat: surface more text selection commands
* refactor: use options argument
* docs: correct for review
2023-05-02 21:14:29 -04:00
David Sanders
a26343f3e0
fix: falsy transparent shouldn't affect webContents background ( #36914 )
2023-05-02 14:44:34 -07:00
Shelley Vohr
d95f9d2c63
chore: add OCR scaffolding to PDF Viewer ( #38127 )
2023-05-02 10:27:32 +02:00
Fedor Indutny
c548f8f59e
feat: net.resolveHost ( #37853 )
2023-05-02 09:53:00 +02:00
Milan Burda
7c482518bf
chore: add missing content::WebContentsDelegate section ( #38133 )
2023-05-01 09:23:47 -04:00
Shelley Vohr
a2d35e9cf5
test: re-enable extensions test with http server ( #38129 )
2023-04-28 01:20:46 +02:00
Shelley Vohr
ba8887f586
feat: emit context-menu event from extensions ( #38029 )
...
feat: emit context-menu event from extensions
2023-04-27 12:54:51 +02:00
Shelley Vohr
f35b9b3f06
fix: AXManualAccessibility showing failure ( #38102 )
...
fix: AXManualAccessibility showing failure
2023-04-26 19:41:56 +02:00
Bruno Pitrus
a0a44f07dd
chore: correct extra qualification causing build error with GCC ( #37548 )
...
* chore: correct extra qualification causing build error with GCC
* fixup for lint
* chore: fix lint
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-26 10:40:02 -04:00
David Sanders
08593fd2bd
chore: fix clang-tidy warnings ( #38079 )
...
* chore: fix clang-tidy warnings
* refactor: avoid need for NOLINTNEXTLINE
2023-04-26 10:09:54 -04:00
Shelley Vohr
fe5cdd39d6
test: re-enable passing Node.js tests ( #38116 )
2023-04-26 12:08:50 +02:00
Shelley Vohr
05faabe9e8
test: re-enable multi-window fullscreen test ( #38119 )
2023-04-26 10:13:36 +02:00
Shelley Vohr
9d525f9861
test: formally mark some Node.js tests as flaky ( #38117 )
2023-04-26 10:11:14 +02:00
Milan Burda
e823869bb0
docs: add separate linkable browser-window-options.md and web-preferences.md ( #34633 )
2023-04-25 15:16:11 +02:00
Shelley Vohr
f4b7e59b2d
fix: crash on missing RenderWidgetHostView ( #38100 )
...
chore: fix crash on missing RenderWidgetHostView
2023-04-25 11:30:16 +02:00
Francis Chartrand
a0a1a3645b
docs: fix start highlight tutorial-2-first-app.md ( #38069 )
...
doc: fix start highlight tutorial-2-first-app.md
2023-04-25 11:19:14 +02:00
David Sanders
9b41ab1e53
chore: always lint JS in docs/fiddles ( #38025 )
2023-04-24 10:35:14 -04:00
Black-Hole️
141f65b291
fix: webContents return type incorrect ( #38026 )
...
* fix: webContents type incorrect
* fix: ci failed
* fix: ci failed 2
2023-04-24 10:28:21 -04:00
Quang Lam
b626be5e33
docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings ( #38035 )
...
* Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings
* Add webContents
2023-04-23 22:16:38 +02:00
Milan Burda
964934c161
fix: defaults broken in shell.openExternal() options ( #38038 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-04-21 13:13:59 -04:00
github-actions[bot]
f727da4a74
ci: update appveyor image to latest version ( #38015 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-21 10:37:02 -04:00
Jason Etcovitch
cf4c46c8e0
build: fix Codespaces prebuilds with missing comma ( #38052 )
...
Add missing comma
2023-04-20 15:41:54 -07:00
Robo
0240f6664e
fix: crash in utilityProcess when generating code from strings ( #38014 )
2023-04-20 09:27:02 +09:00
Shelley Vohr
f12e12b341
chore: remove --no-harmony-atomics related code ( #38030 )
...
chore: remove --no-harmony-atomics related code
2023-04-19 10:29:18 -04:00
Shelley Vohr
7e715b66ae
test: re-enable reporting specs ( #35936 )
2023-04-19 14:24:38 +02:00
Jeremy Rose
ba835ddac1
feat: add thermal states to powerMonitor ( #37935 )
...
* feat: add thermal states to powerMonitor
* update docs
2023-04-19 11:46:55 +02:00
electron-roller[bot]
b2411e05a8
chore: bump chromium to 114.0.5719.0 (main) ( #38017 )
...
* chore: bump chromium in DEPS to 114.0.5719.0
* chore: update patches
* revert eb07a797cc
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-18 14:23:22 -07:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) ( #37973 )
...
* chore: bump node in DEPS to v18.16.0
* build,test: add proper support for IBM i
https://github.com/nodejs/node/pull/46739
* lib: enforce use of trailing commas
https://github.com/nodejs/node/pull/46881
* src: add initial support for single executable applications
https://github.com/nodejs/node/pull/45038
* lib: do not crash using workers with disabled shared array buffers
https://github.com/nodejs/node/pull/41023
* src: remove shadowed variable in OptionsParser::Parse
https://github.com/nodejs/node/pull/46672
* src: allow embedder control of code generation policy
https://github.com/nodejs/node/pull/46368
* src: allow optional Isolate termination in node::Stop()
https://github.com/nodejs/node/pull/46583
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* chore: fixup patch indices
* chore: sync filenames.json
* fix: add simdutf dep to src/inspector BUILD.gn
- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472
* deps: replace url parser with Ada
https://github.com/nodejs/node/pull/46410
* tls: support automatic DHE
https://github.com/nodejs/node/pull/46978
* fixup! src: add initial support for single executable applications
* http: unify header treatment
https://github.com/nodejs/node/pull/46528
* fix: libc++ buffer overflow in string_view ctor
https://github.com/nodejs/node/pull/46410
* test: include strace openat test
https://github.com/nodejs/node/pull/46150
* fixup! fixup! src: add initial support for single executable applications
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-18 22:23:11 +02:00
Samuel Attard
941153be32
build: bump dependencies to clean yarn audit ( #37998 )
...
* build: bump dependencies to clean yarn audit
* build: add url
2023-04-18 16:54:16 +02:00
Shelley Vohr
32afdda9ee
feat: add did-resign-active event on app ( #37933 )
...
feat: add did-resign-active event on app
2023-04-18 16:53:39 +02:00
github-actions[bot]
f4b172b9ec
ci: update appveyor image to latest version ( #37817 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-17 20:04:12 -04:00
electron-roller[bot]
7a6af1a529
chore: bump chromium to 114.0.5715.0 (main) ( #37976 )
...
* chore: bump chromium in DEPS to 114.0.5712.0
* chore: update patches
* 4401084: Remove extensions::InfoMap which is no longer needed. | https://chromium-review.googlesource.com/c/chromium/src/+/4401084
* 4415646: Add more details to print settings error log | https://chromium-review.googlesource.com/c/chromium/src/+/4415646
* chore: bump chromium in DEPS to 114.0.5714.0
* chore: update patches
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 114.0.5715.0
* chore: update patches
* fix extensions test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-17 14:40:26 -07:00
Alexey Kuzmin
1ffe7ee76b
build: fix building with no PDF support ( #38003 )
2023-04-17 11:02:43 -04:00
Shelley Vohr
c857c9b7e2
docs: add note to win.setFullScreen(flag) ( #37921 )
...
docs: add note to win.setFullScreen(flag)
2023-04-17 10:45:40 +02:00
Shelley Vohr
f0e1848a5e
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator& ( #37948 )
...
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator&
2023-04-16 17:08:37 -07:00
David Sanders
d1cddf2517
docs: update github.com links ( #37958 )
2023-04-15 21:20:59 -07:00
David Sanders
c7ea887227
chore: drop patch for fixed Linux menus issue in Views ( #37984 )
2023-04-15 21:20:34 -07:00
Shelley Vohr
fa3379a5d5
chore: fix lint ( #37971 )
2023-04-13 15:54:41 +02:00
Calvin
cdace75389
chore: disable flaky node test ( #37900 )
2023-04-13 13:27:45 +02:00
David Sanders
e84bcb39e7
fix: defaultFontFamily in webPreferences ( #37863 )
...
* fix: defaultFontFamily in webPreferences
* chore: check if default_font_family_ is empty
2023-04-13 11:30:25 +02:00
Shelley Vohr
fceeb64e7c
fix: swipe event emission on macOS ( #37946 )
2023-04-13 11:28:22 +02:00
Zenkie Bear
f03315ad4d
docs: Fix the syntax error for code fragment ( #37939 )
...
By using `app.on('ready').then(xxx)`, application will throw a TypeError
2023-04-13 10:00:27 +02:00
Michaela Laurencin
6f2ab392ab
docs: update 22-x-y EOL dates ( #37955 )
...
To account for https://www.electronjs.org/blog/electron-22-0#windows-7881-support-update
Not sure if it is worth adding as a historical change though
2023-04-12 18:10:47 -07:00
electron-roller[bot]
33a625d0ee
chore: bump chromium to 114.0.5710.0 (main) ( #37950 )
...
* chore: bump chromium in DEPS to 114.0.5710.0
* chore: update patches
* 4411421: [json-schema-compiler] Support separating numbers in enum entries |
https://chromium-review.googlesource.com/c/chromium/src/+/4411421
* 4400251: Remove MayBlock and TaskShutdownBehavior from BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4400251
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-04-12 18:10:31 -07:00
David Sanders
2ad1324b9d
ci: only remove blocked/need-repro on comment ( #37879 )
2023-04-12 16:33:59 -07:00
Jeremy Rose
fef1b04238
feat: remove on(ready) requirement from powerMonitor ( #37937 )
2023-04-12 15:37:52 -07:00
electron-roller[bot]
908bef7ca9
chore: bump chromium to 114.0.5708.0 (main) ( #37834 )
...
* chore: bump chromium in DEPS to 114.0.5696.0
* chore: update patches
* chore: revert clang revert
(cherry picked from commit 4c3ffa8001b5fdbfc99374bf77895d8d8e35ee31)
* test: remove unneeded test for title on ses.setCertificateVerifyProc
This test is unnecessary because all that really needs to be verified is that the request was rejected.
* chore: Revert "Reland "[BRP] Enable clang plugin check for Linux""
* chore: bump chromium in DEPS to 114.0.5697.0
* chore: bump chromium in DEPS to 114.0.5698.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5700.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5702.0
* chore: bump chromium in DEPS to 114.0.5704.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5705.0
* 4368281: Add bottom-up CertVerifier change observer flow. |
https://chromium-review.googlesource.com/c/chromium/src/+/4368281
* 4402277: Enable check_raw_ptr_fields for Linux |
https://chromium-review.googlesource.com/c/chromium/src/+/4402277
* 4389621: [ChromeAppsDeprecation] Remove deprecated chrome apps from AppService |
https://chromium-review.googlesource.com/c/chromium/src/+/4389621
* 4402191: Allow default initializing BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4402191
* chore: bump chromium in DEPS to 114.0.5708.0
* chore: remove incorrectly re-added clang patch
* chore: update patches (clean sync)
* ci: use newer clang for 32-bit Linux ARM
Fixes crash on compiling skia/skia/SkPatchUtils.cpp
* build: generate new libcxx filenames
* 4409898: Update paper printable area in UpdatePrintSettings |
https://chromium-review.googlesource.com/c/chromium/src/+/4409898
* chore: update sysroots.json
Sysroot CL: https://chromium-review.googlesource.com/c/chromium/src/+/4383374
Chromium CL: 4246577: media/gpu: Add CQP AV1 VA-API video encoder | https://chromium-review.googlesource.com/c/chromium/src/+/4246577
* 4336198: [task] Move source location and use it in v8 platform | https://chromium-review.googlesource.com/c/v8/v8/+/4336198
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-04-12 07:37:48 -04:00
Darshan Sen
c326b0068e
fix: recommended node-gyp version in node.h error ( #37829 )
...
fix: recommended node-gyp version in node.h error
In
https://github.com/electron/electron/blob/main/docs/tutorial/using-native-node-modules.md#using-npm ,
we recommend setting the `npm_config_disturl` variable but doing that
does not work on node-gyp v8.4.0 because after
https://github.com/nodejs/node-gyp/pull/2497
landed, the dist URL was read only from `gyp.opts['dist-url']`. The fix
for reading the value from `npm_config_disturl` by parsing
`gyp.opts.disturl` was landed in
https://github.com/nodejs/node-gyp/pull/2547 and that change was
released in node-gyp v9.0.0, so this change updates the error macro to
recommend node-gyp v9.0.0 as the minimum required version.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2023-04-11 13:26:26 +02:00
Samuel Attard
c01dff8d89
fix: exceptions during function/promise result conversions live in calling world ( #37904 )
2023-04-11 11:57:48 +02:00
Shelley Vohr
c65632d404
fix: broken buttons in PDF viewer ( #37856 )
2023-04-11 15:30:36 +09:00
David Sanders
adb1172066
chore: use nested namespaces ( #37855 )
2023-04-11 15:30:25 +09:00
David Sanders
e929b2140d
chore: change some for loops to range-based ( #37857 )
2023-04-11 15:27:07 +09:00
David Sanders
82442239bc
chore: use emplace when possible ( #37877 )
2023-04-11 15:21:03 +09:00
David Sanders
3c0c4d5c27
fix: menus on Linux after window modification ( #37798 )
...
* fix: menus on Linux after window modification
* test: don't run on CI
2023-04-11 15:17:45 +09:00
Samuel Attard
6958668448
fix: exceptions in nested conversions live in the target world ( #37895 )
2023-04-10 14:58:27 -07:00