Compare commits

...

6 Commits

Author SHA1 Message Date
Jeremy Rose
15bd6948d1 Merge remote-tracking branch 'origin/main' into no-onwindowshow 2024-04-09 10:26:14 -07:00
Jeremy Rose
d3d9e919a8 Merge remote-tracking branch 'origin/main' into no-onwindowshow 2023-11-17 11:38:12 -08:00
Jeremy Rose
9a51f74bd8 Merge branch 'main' into no-onwindowshow 2023-11-09 12:04:26 -08:00
Jeremy Rose
4f6712c8e8 also wait on win32 2023-04-11 15:50:22 -07:00
Jeremy Rose
ebdedf6c02 try more timeouts yeah? 2023-04-11 15:21:33 -07:00
Jeremy Rose
e2bf1aa5fd refactor: remove BrowserWindow::OnWindow{Show,Hide} 2023-04-10 16:45:29 -07:00
3 changed files with 1 additions and 13 deletions

View File

@@ -380,16 +380,6 @@ void BrowserWindow::NotifyWindowUnresponsive() {
}
}
void BrowserWindow::OnWindowShow() {
web_contents()->WasShown();
BaseWindow::OnWindowShow();
}
void BrowserWindow::OnWindowHide() {
web_contents()->WasOccluded();
BaseWindow::OnWindowHide();
}
// static
gin_helper::WrappableBase* BrowserWindow::New(gin_helper::ErrorThrower thrower,
gin::Arguments* args) {

View File

@@ -68,8 +68,6 @@ class BrowserWindow : public BaseWindow,
void Focus() override;
void Blur() override;
void SetBackgroundColor(const std::string& color_name) override;
void OnWindowShow() override;
void OnWindowHide() override;
// BrowserWindow APIs.
void FocusOnWebView();

View File

@@ -79,7 +79,7 @@ ifdescribe(process.platform !== 'linux')('document.visibilityState', () => {
show: true
}, async () => {
// TODO(MarshallOfSound): Figure out if we can work around this 1 tick issue for users
if (process.platform === 'darwin') {
if (process.platform === 'darwin' || process.platform === 'win32') {
// Wait for a tick, the window being "shown" takes 1 tick on macOS
await setTimeout(10000);
}