yangzuohui
71526af2fb
fix: fix launch crash when null device is disabled on Windows
...
add node flag node::ProcessInitializationFlags::kNoStdioInitialization
Co-Authored-By: yangliu <yangliu.leo@bytedance.com >
2025-10-10 12:37:45 -04:00
Niklas Wenzel
550e054168
docs: update Azure Trusted Signing availability ( #48494 )
...
* docs: update Azure Trusted Signing availability
Source: https://github.com/Azure/trusted-signing-action/issues/93#issuecomment-3383517386
* docs: remove unused link
2025-10-10 11:43:29 -04:00
Shelley Vohr
b992ead837
fix: dialog.showMessageBox defaultid on Windows ( #48216 )
...
* fix: dialog.showMessageBox defaultid on Windows
* Update shell/browser/ui/message_box_win.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-10-10 15:39:23 +02:00
Shelley Vohr
11f76118db
fix: unexpected openExternal dialog on macOS Tahoe ( #48502 )
...
fix: unexpected openExternal dialog on macOS Tahoe
2025-10-10 12:48:44 +02:00
Robo
37c7487600
fix: crash when inspector evaluates on provisional frames ( #48503 )
2025-10-10 11:34:09 +02:00
reito
9e46efb8f7
feat: offscreen rendering support rgbaf16 hdr output format. ( #48265 )
...
* feat: offscreen rendering support rgbaf16
* docs: update doc
* docs: update doc.
2025-10-09 10:33:34 +02:00
dependabot[bot]
9c38917a14
build(deps): bump actions/github-script from 7.0.1 to 8.0.0 ( #48329 )
...
Bumps [actions/github-script](https://github.com/actions/github-script ) from 7.0.1 to 8.0.0.
- [Release notes](https://github.com/actions/github-script/releases )
- [Commits](60a0d83039...ed597411d8 )
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 8.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-09 10:33:24 +02:00
zoy
3a53c71324
fix: broken transparent window styles on resizable change ( #48378 )
...
* fix: wrong api call
* fix: consistency of the resize state
* fix: edge cases
* chore: add detailed comments
* fix: lint
* chore: only windows
* chore: use transparent
2025-10-09 09:49:20 +02:00
David Sanders
0d478ec69c
ci: ignore lost communication with server annotation in audit ( #48493 )
2025-10-09 09:48:56 +02:00
Erick Zhao
9143f7c6e2
docs: clarify postinstall requirements ( #48485 )
...
postinstall
2025-10-09 09:48:47 +02:00
Erick Zhao
df86312e2f
docs: add note for node_modules for Yarn and pnpm ( #48484 )
...
* Add instructions on using node_modules with Yarn
* update text for pnpm
---------
Co-authored-by: CodingOtto <otto+github@fysiker.fi >
2025-10-09 09:48:22 +02:00
Ulises Gascón
ffbae02a95
docs: add security escalation policy ( #48317 )
2025-10-08 15:19:07 -07:00
Sam Maddock
a87ee21f5c
build: bump version in .nvmrc to 22 ( #48413 )
2025-10-08 14:21:55 -04:00
electron-roller[bot]
ea8f43f9b9
chore: bump node to v22.20.0 (main) ( #48383 )
...
* chore: bump node in DEPS to v22.20.0
* chore: fixup patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-08 15:19:08 +02:00
Fedor Indutny
e8e91c331a
feat: dynamic ESM import in preload without context isolation ( #48375 )
...
Dynamic ESM import in non-context-isolated preload
Extend `HostImportModuleWithPhaseDynamically`'s routing to support
Node.js import resolution in non-context-isolated preloads through
`v8_host_defined_options` length check. The length of host defined
options is distinct between Blink and Node.js and we can use it to
determine which resolver to use.
2025-10-08 10:44:09 +02:00
Charles Kerr
49c1139ab9
chore: remove unused reference to api::BrowserView ( #48474 )
...
chore: remove unused reference to api::BrowserView
Unused since #35658 / 15c60143
2025-10-08 10:43:28 +02:00
dependabot[bot]
16bcd645b5
build(deps): bump actions/stale from 9.1.0 to 10.1.0 ( #48477 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.1.0 to 10.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](5bef64f19d...5f858e3efb )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-version: 10.1.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-08 09:56:23 +02:00
John Kleinschmidt
6756974828
build: fixup chromedriver and mksnapshot ( #48470 )
...
* build: update build tools to get proper exit codes from e build
xref: https://github.com/electron/build-tools/pull/759
* build: target zips directly
mksnapshot and chromedriver have issues with siso trying to run a separate build and zip step, so just target the zip target
* build: don't unzip chromedriver and mksnapshot in tests
The contents of these files are not used in testing, so we shouldn't unzip them.
2025-10-06 23:22:55 -04:00
Keeley Hammond
d6dfd4ed7a
build: handle Metal toolchain being unbundled from Xcode 26 ( #48467 )
...
* chore: add metal patch dir
* chore: cherry-pick 2f564f1ca07b from angle (#48465 )
* chore: update patch
2025-10-06 10:17:46 -04:00
Charles Kerr
a1ca9a8d55
refactor: DRY in App::SetAppLogPath() ( #48452 )
2025-10-05 12:32:28 -05:00
Charles Kerr
38e491689a
perf: avoid a little extra work in InvokeIpcCallback() ( #48456 )
...
perf: two minor perf refactors in InvokeIpcCallback()
1. Allocate the CallbackScope on the stack instead of the heap
2. Skip a redundant call to node::Environment::GetCurrent()
2025-10-04 21:52:53 -07:00
Niklas Wenzel
6e2be00f0f
docs: recommend calling renderer process modules from preload script ( #48427 )
2025-10-04 18:44:10 +02:00
Charles Kerr
497b5a68a4
docs: clarify optional args in webFrame.executeJavaScript() ( #48447 )
2025-10-04 09:28:06 -05:00
Kaiichiro Ota
715808ecbe
docs: mention that webUtils should be used via preload script ( #45861 )
...
* docs: mention that webUtils should be used via preload script
* docs: suppress lint errors
* docs: clarify webUtils usage scope
* docs: exclude potentially dangerous alert() in the example code
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: make linter happy
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: minor change
* docs: minor change
* docs: remove preload line
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2025-10-03 13:07:38 -07:00
Charles Kerr
01cab978f7
refactor: remove gin_helper::Arguments ( #48374 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in StopRecording()
* refactor: use gin::Arguments in ImageView::New()
* refactor: use gin::Arguments in AppendSwitch()
* refactor: use gin::Arguments WebContentsView::New()
* refactor: make gin::Arguments arg const in WrappableBase::InitWithArgs()
This makes explicit that we are using it for wrapper + isolate, not the args values
* refactor: remove gin_helper::Arguments arg from ExposeAPI()
refactor: remove gin_helper::Arguments arg from ExposeAPIInWorld()
* refactor: remove gin_helper::Arguments arg from ElectronBindings::GetSystemMemoryInfo()
* refactor: remove gin_helper::Arguments arg from preload_utils::GetBinding()
* refactor: use gin::Arguments in OpenExternal()
* refactor: use gin::Arguments in ExecuteInWorld()
* refactor: use gin::Arguments in ExecuteJavaScript()
* refactor: use gin::Arguments in InvokeNew()
* refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
* refactor: remove unused GetNextArgument() marshaller for gin_helper::Arguments
* refactor: remove unused #include gin_helper/arguments.h
* chore: remove unused gin_helper::Arguments
* fixup! refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
Xref: https://github.com/electron/electron/pull/48447
2025-10-03 14:10:29 -05:00
zoy
7cb1552614
fix: accentColor set distinguishes the frame ( #48405 )
...
* fix: accentColor set distinguishes the frame
* chore: invalid change
* fix: lint
2025-10-03 20:10:18 +02:00
Niklas Wenzel
49c37b4daa
docs: update allowed window.open options ( #48428 )
2025-10-03 01:29:26 +02:00
Robo
37a115b8fd
fix: initialze featurelist before parsing features ( #48411 )
2025-10-03 01:18:14 +02:00
Shelley Vohr
e7e29ea876
fix: snapped window restoring to correct position ( #48296 )
2025-10-02 18:14:48 +02:00
Erick Zhao
b40a4befd4
docs: fix formatting in asar integrity ( #48431 )
2025-10-01 22:27:28 -07:00
dependabot[bot]
61a7303531
build(deps): bump github/codeql-action from 3.30.1 to 3.30.5 ( #48420 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.30.1 to 3.30.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f1f6e5f6af...3599b3baa1 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-30 18:36:57 +02:00
Fedor Indutny
6f9cd718c4
fix: runtime JS error that crashes GetPackageJSON ( #48293 )
...
We overriden the `GetPackageJSON` in Node.js to let us read files
straight from the ASAR file instead of disk. The override works by
providing a JS method with the limitation that it should not throw a
runtime error. However, this invariant was accidentally violated by
`asar.splitPath` that sometimes contrary to its' TypeScript definition
returned `false`.
2025-09-30 18:32:13 +02:00
Samuel Attard
a95180e080
build: add missing copied tarball to cloudstore paths ( #48408 )
...
It's guarunteed that `iojs-*` and `node-*` were the same origin file (we azcopy them) but this was missing in logs and it annoyed me
2025-09-29 11:16:39 -07:00
BILL SHEN
d4a5fdc8fc
fix: add missed enum SaveRequestType to PdfViewerPrivate function ( #48372 )
...
fix: add missed SaveRequestType enum to PdfViewerPrivate function
2025-09-26 16:34:06 -04:00
avarayr
3a7c6dd4a5
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load ( #48376 )
...
fix: macOS stop overriding private cornerMask API to fix WindowServer GPU load spike
Electron fetched a custom `_cornerMask` for `ElectronNSWindow` to smooth
vibrancy corners. On macOS 15 (Tahoe) that private hook forces the window
shadow to be rendered from a fully transparent surface, causing the
WindowServer GPU load regression. Remove the `cornerMask` property and
the `_cornerMask` override so we stay on Apple’s default shadow path.
2025-09-26 12:41:16 -07:00
Robo
26e886c517
fix: disable NSAutoFillHeuristicController on macOS 26 ( #48379 )
...
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-09-26 08:40:55 +09:00
Charles Kerr
26a473db98
refactor: make api::Menu inherit from gin::Wrappable ( #48351 )
...
* refactor: make api::Menu inherit from gin::Wrappable*
* refactor: make api::Menu::kWrapperInfo const
* refactor: use three-arg version of GetConstructor in Menu
refactor: undo branch changes to two-arg version of GetConstructor
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
fix: return type of Menu::New
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
make MenuMac's constructor public so that cppgc can use it
* refactor: Pinnable -> SelfKeepAlive
2025-09-24 19:42:22 -05:00
Charles Kerr
6661457cdf
refactor: prefer upstream gin::Arguments::ThrowTypeError() over gin_helper ( #48368 )
...
* refactor: use gin::Arguments::ThrowTypeError() in AutoUpdater::SetFeedURL()
* refactor: use gin::Arguments::ThrowTypeError() in Browser::Focus()
* refactor: use gin::Arguments::ThrowTypeError() in SystemPreferences::SetUserDefault()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::Create()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::PostMessage()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBundleMover::ShouldContinueMove()
* refactor: use gin::Arguments::ThrowTypeError() in OnClientCertificateSelected()
* refactor: use gin::Arguments::ThrowTypeError() in Session::ClearData()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBrowserContext::DisplayMediaDeviceChosen()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::ReplaceMisspelling()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::Print()
* chore: iwyu shell/common/gin_helper/error_thrower.h
2025-09-24 19:10:05 -05:00
John Kleinschmidt
b51e82c5fb
test: rerun failed tests individually ( #48205 )
...
* test: rerun failed tests individually
* ci: use screencapture-nag-remover
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
* Revert "chore: test with 1st quadrant of the window"
No longer needed because of the addition of the
screencapture-nag-remover script.
This reverts commit f4a7e04c0b .
* test: fixup navigationHistory flake
* rerun test up to 3 times
2025-09-24 13:35:14 -07:00
Charles Kerr
235fdc41f6
refactor: use gin::Arguments in BaseWindow ( #48355 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in BaseWindow::MoveAbove()
refactor: use gin::Arguments in BaseWindow::SetAlwaysOnTop()
refactor: use gin::Arguments in BaseWindow::SetIgnoreMouseEvent()
* refactor: use gin::Arguments in BaseWindow::SetProgresBar()
* refactor: use gin::Arguments in BaseWindow::SetVisibleOnAllWorkspaces()
* refactor: use gin::Arguments in BaseWindow::SetVibrancy()
* refactor: use gin::Arguments in BaseWindow::SetAspectRatio()
* refactor: use gin::Arguments in BaseWindow::PreviewFile()
* refactor: use gin::Arguments in BaseWindow::SetThumbarButtons()
* refactor: use gin::Arguments in BaseWindow::SetBounds()
* refactor: use gin::Arguments in BaseWindow::SetContentBounds()
* refactor: use gin::Arguments in BaseWindow::SetSize()
* refactor: use gin::Arguments in BaseWindow::SetContentSize()
* refactor: use gin::Arguments in BaseWindow::SetSheetOffset()
* refactor: use gin::Arguments in BaseWindow::SetPosition()
* refactor: use gin::Arguments in BaseWindow::AddTabbedWindow()
* refactor: use gin::Arguments in BaseWindow::SetParentWindow()
* refactor: use gin::Arguments in BaseWindow::BaseWindow()
* refactor: use gin::Arguments in BaseWindow::SetAccentColor()
* refactor: use gin::Arguments in BaseWindow::SetTitleBarOverlay()
2025-09-24 09:39:16 -04:00
Charles Kerr
6bbbc1232e
chore: remove unused, undocumented, untested executionMode arg from web_frame.executeJavaScriptInIsolatedWorld() ( #48361 )
...
chore: remove unused, undocumented execution mode arg from web_frame.executeJavaScriptInIsolatedWorld()
2025-09-24 08:13:49 -05:00
Niklas Wenzel
49335805d5
docs: mention setContentProtection macOS limitations ( #48290 )
2025-09-23 16:28:21 -05:00
John Kleinschmidt
b27e721f69
build: update patches ( #48364 )
...
chore: update patches
2025-09-23 16:37:38 -04:00
electron-roller[bot]
1fda08b8c8
chore: bump chromium to 142.0.7417.0 (main) ( #48275 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
* chore: fixup patch indices
* chore: bump chromium in DEPS to 142.0.7402.0
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
* chore: fixup patch indices
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
* chore: fix patch
* chore: bump chromium in DEPS to 142.0.7403.0
* build: remove ninja logs
* chore: fixup patch indices
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
* build: don't kill blink/web_tests
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
* chore: bump chromium in DEPS to 142.0.7405.0
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
* chore: fixup patch indices
* fix: Protocol complex inline dtor
* chore: bump chromium in DEPS to 142.0.7407.0
* chore: bump chromium in DEPS to 142.0.7409.0
* chore: bump chromium in DEPS to 142.0.7411.0
* chore: bump chromium in DEPS to 142.0.7413.0
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* chore: fixup patch indices
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
* chore: bump chromium in DEPS to 142.0.7415.0
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
* chore: update patches
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
* fixup for lint
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 142.0.7417.0
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
* chore: update patches
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* Revert "build: remove ninja logs"
This reverts commit 72874740fd .
* test: fix flakey test picked from PR 48205
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-09-22 20:16:27 -07:00
Charles Kerr
19256a07dd
refactor: use gin::Arguments in api::Clipboard ( #48354 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBuffer()
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBookmark()
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in api::Clipboard
2025-09-23 04:12:47 +09:00
John Kleinschmidt
f62d7254c4
build: update build tools to get siso for forks fix ( #48345 )
2025-09-18 00:04:09 -04:00
Keeley Hammond
c7aa0b537d
chore: cherry-pick ec6c18478382 from v8 ( #48335 )
...
* chore: cherry-pick ec6c18478382 from v8
* chore: update patches
2025-09-16 19:08:15 -07:00
Robo
048d620701
fix: remove unneeded handlescope from JS callbacks ( #48318 )
...
fix: remove handlescope from JS callbacks
2025-09-16 06:56:38 +09:00
Charles Kerr
15cdae1cf0
refactor: make api::NetLog inherit from gin::Wrappable ( #48308 )
...
* refactor: remove unused v8::Isolate* arg from NetLog ctor
* refactor: allocate api::NetLog on cpp heap
* refactor: make electron::api::Session::net_log_ a cppgc::Member<api::NetLog>
* refactor: remove unnecessary EscapableHandleScope
* chore: code style consistency
2025-09-16 06:29:46 +09:00
Shelley Vohr
bac383c219
feat: add fileSystem to ses.setPermissionCheckHandler ( #48170 )
...
feat: add fileSystem to ses.setPermissionCheckHandler
2025-09-15 17:00:58 -04:00
John Kleinschmidt
49eb165ef9
ci: Use Local Execution, Remote Caching (LERC) for fork PRS ( #48319 )
...
cleanup
2025-09-15 16:31:49 -04:00
Charles Kerr
a468ed7f10
refactor: narrow or remove gin arguments ( #48300 )
...
* refactor: narrow App:SetJumpList() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow WebContents::AddWorkSpace() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowMessageBox() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowOpenDialog() arg from gin::Arguments* to v8::Isolate*
* refactor: remove unused gin::Arguments* arg from OverrideGlobalPropertyFromIsolatedWorld()
* refactor: narrow WebContents::StartDrag() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow NetLog::StopLogging() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow Protocol::IsProtocolHandled() arg from gin::Arguments* to v8::Isolate*
2025-09-13 08:19:07 +09:00
Calvin
5444738721
fix: set ozone platform for wayland ( #48301 )
...
* fix: set ozone platform for wayland
* whoops, includes. thx charles
2025-09-13 08:17:06 +09:00
Charles Kerr
a6959ca97b
refactor: allocate api::Debugger on cpp heap ( #48266 )
...
* refactor: remove unused isolate arg from Debugger ctor
* refactor: make Debugger ctor, dtor public
needed for cppgc::MakeGarbageCollected()
This is what upstream does, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/6722236
* fixup! refactor: remove unused isolate arg from Debugger ctor
mark Debugger ctor as explicit
* refactor: in EventEmitterMixin, handle both old and new WrapperInfo types
* refactor: make electron::api::Debugger inherit from gin::Wrappable
* refactor: add api::Debugger::GetTypeName()
* refactor: add api::Debugger::GetClassName()
2025-09-11 16:03:17 -04:00
dependabot[bot]
45353ae38c
build(deps): bump actions/setup-node from 4.4.0 to 5.0.0 ( #48282 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.4.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](49933ea528...a0853c2454 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-10 21:35:54 -05:00
Charles Kerr
f702327dce
refactor: avoid unused inheritance in ServiceWorkerMain ( #48279 )
...
ServiceWorkerMain does not need to inherit from EventEmitterMixin
2025-09-10 11:16:35 -05:00
dependabot[bot]
fda3a3d493
build(deps): bump github/codeql-action from 3.29.11 to 3.30.1 ( #48283 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.11 to 3.30.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](3c3833e0f8...f1f6e5f6af )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-10 09:47:34 -05:00
Michaela Laurencin
dae5dad167
docs: update release timeline for unsupported v35 ( #48285 )
2025-09-09 15:03:48 -07:00
John Kleinschmidt
940ebb6c7a
chore: update patches ( #48278 )
2025-09-08 15:44:47 -04:00
electron-roller[bot]
793565e4be
chore: bump chromium to 141.0.7390.7 (main) ( #48212 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7382.0
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7384.0
* chore: bump chromium in DEPS to 141.0.7386.0
* [Extensions] Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
* chore: update patches
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update patches
* [FSA] Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
* chore: IWYU
* [DevToolsUIBindings] Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
* chore: IWYU
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update filenames.libcxx.gni
* chore: IWYU
* fixup: chore: IWYU
* fixup: Reland "[exit-time-destructors] Enable by default
* fixup: Reland "[exit-time-destructors] Enable by default
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
* fixup: Reland "[exit-time-destructors] Enable by default
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
* chore: bump chromium in DEPS to 141.0.7390.7
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
* fixup: Move "system integrated UI" concept out of NativeTheme.
* fixup: Reland "[exit-time-destructors] Enable by default
* chore: update patches
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* fixup: 6906096: Remove GetSysSkColor()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-09-08 12:57:15 +02:00
electron-roller[bot]
1f322ebce3
chore: bump node to v22.19.0 (main) ( #48222 )
...
* chore: bump node in DEPS to v22.19.0
* chore: fixup patch indices
* crypto: add tls.setDefaultCACertificates()
https://github.com/nodejs/node/pull/58822
* esm: js-string Wasm builtins in ESM Integration
https://github.com/nodejs/node/pull/59179
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-09-05 17:16:45 -04:00
Samuel Attard
f009e077f2
build: update spec deps for clean audit ( #48238 )
2025-09-03 15:05:49 -04:00
Calvin
fed73040e2
docs: move some planned breaking changes to 39 ( #48236 )
2025-09-01 14:55:11 -07:00
Shelley Vohr
828fd59a72
fix: file-only picker incorrectly allowing some directories ( #48198 )
2025-08-29 13:14:45 -04:00
Shelley Vohr
e892840975
fix: ensure dragging works again after emitting contextmenu event ( #48199 )
2025-08-29 10:37:37 -04:00
Shelley Vohr
7373173e44
fix: showMessageDialog should center dialog to parent ( #48181 )
2025-08-29 09:56:51 +02:00
electron-roller[bot]
5d5e672f17
chore: bump chromium to 141.0.7361.0 (main) ( #48054 )
...
* chore: bump chromium in DEPS to 141.0.7352.0
* chore: update patches
* 6830573: Revert 'Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable' | https://chromium-review.googlesource.com/c/chromium/src/+/6830573
* chore: bump chromium in DEPS to 141.0.7354.0
* chore: bump chromium in DEPS to 141.0.7356.0
* chore: bump chromium in DEPS to 141.0.7357.0
* chore: bump chromium in DEPS to 141.0.7359.0
* chore: bump chromium in DEPS to 141.0.7361.0
* 6838518: [Mac] Correctly deallocate sandbox error buffers and prevent crash resulting from nullptr assignment | https://chromium-review.googlesource.com/c/chromium/src/+/6838518
* 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* chore: update patches
* fixup! 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* fixup! 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* fix: unsafe buffer warning in fix_properly_honor_printing_page_ranges.patch
* fix: FTBFS in src_remove_dependency_on_wrapper-descriptor-based_cppheap.patch
This change should be upstreamed.
Fixes this error:
../../third_party/electron_node/src/env.cc:606:3: error: no matching function for call to 'Wrap'
606 | v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1076:14: note: candidate function template not viable: cannot convert argument of incomplete type 'void *' to 'v8::Object::Wrappable *' for 3rd argument
1076 | void Object::Wrap(v8::Isolate* isolate, const v8::Local<v8::Object>& wrapper,
| ^
1077 | v8::Object::Wrappable* wrappable) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1084:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const PersistentBase<Object>' for 2nd argument
1084 | void Object::Wrap(v8::Isolate* isolate, const PersistentBase<Object>& wrapper,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1093:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const BasicTracedReference<Object>' for 2nd argument
1093 | void Object::Wrap(v8::Isolate* isolate,
| ^
1094 | const BasicTracedReference<Object>& wrapper,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
* [v8-init] Access crash key only from main thread | https://chromium-review.googlesource.com/c/chromium/src/+/6827167
* chore: e patches all
* chore: remove chore_restore_some_deprecated_wrapper_utility_in_gin.patch from patches
this remove line got re-added when rebasing roller/chromium/main
* chore: e patches all
* fix: include base/time/time.h when using base::Time
* chore: update patches
* Make --host-rules an alias for --host-resolver-rules.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4867872
* ci: update BUILD_TOOLS_SHA
Refs https://github.com/electron/build-tools/pull/746
* [Fontations] Remove Fontations suffix from font names
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6835930
* temp: debug macOS addon build failure
* Revert "temp: debug macOS addon build failure"
This reverts commit 40bc8abab65dc83e17c4ab97cb6e7522a193fb44.
* test: run tests with Xcode 16.4
* ci: fix tccdb update for macOS 15
* spec: disable opening external application for loadURL
on macOS opening unknown external application will bring
up dialog to choose apps from application store which will
break our other test suites that want to capture screen
for pixel matching.
The loadURL spec that tests bad-scheme://foo is sufficient
that we hit the permission handler for openExternal since
at that point we already know the runtime gave up on handling
the scheme.
* chore: rebase patches
* chore: disable codesiging tests
* ci: update ScreenCaptureApprovals.plist for /bin/bash
* ci: try updating tcc permissions
* ci: update TCC permissions
Refs https://www.rainforestqa.com/blog/macos-tcc-db-deep-dive
* chore: test with 1st quadrant of the window
* chore: adjust for macOS 15 menubar height
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-08-29 12:31:47 +09:00
LZL
e39943bf45
fix: BrowserWindow add the same BrowserView ( #48053 )
...
fix: BrowserWindow add the same BrowserView (#48057 )
2025-08-28 10:31:41 +02:00
David Sanders
f331606e07
build: bump NMV to 140 ( #48196 )
2025-08-27 18:57:00 -07:00
David Sanders
cca55117e4
build: refactor Linux binary stripping to align with upstream ( #47932 )
2025-08-27 18:56:31 -07:00
Erick Zhao
bf29d2f0bd
docs: fix some module headings ( #48177 )
2025-08-27 14:52:26 -07:00
John Kleinschmidt
fea1a2a987
ci: use free GH arm runners ( #47872 )
2025-08-27 10:01:36 -04:00
dependabot[bot]
a51c56aca9
build(deps): bump amannn/action-semantic-pull-request from 6.0.1 to 6.1.1 ( #48175 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 6.0.1 to 6.1.1.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](fdd4d3ddf6...48f256284b )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-version: 6.1.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:52:36 +02:00
dependabot[bot]
89f25e6af3
build(deps): bump github/codeql-action from 3.29.10 to 3.29.11 ( #48174 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.10 to 3.29.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](96f518a34f...3c3833e0f8 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.11
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:49:43 +02:00
Robo
e0db4046b2
refactor: allocate gin_helper::internal::Event on cpp heap ( #48161 )
2025-08-27 09:30:50 +09:00
Calvin
3b9130d815
docs: add release timeline for Electron 39 ( #48167 )
2025-08-26 14:19:56 -07:00
Shelley Vohr
52ed4646d9
chore: remove upstream OSR temp fix ( #48162 )
2025-08-26 16:22:45 -04:00
John Kleinschmidt
68098c317f
build: remove no longer needed arg for siso ( #48164 )
...
* build: remove no longer needed arg for siso
* chore: test ffmpeg zip
* build: fix ffmpeg build with siso
* Revert "chore: test ffmpeg zip"
This reverts commit 2bbcc86039 .
2025-08-25 16:46:36 -04:00
dependabot[bot]
52e0307cc1
build(deps): bump github/codeql-action from 3.29.7 to 3.29.10 ( #48113 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.7 to 3.29.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](51f77329af...96f518a34f )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.10
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-25 13:23:15 +02:00
dependabot[bot]
7fffe77909
build(deps-dev): bump stream-json and @types/stream-json ( #48114 )
...
Bumps [stream-json](https://github.com/uhop/stream-json ) and [@types/stream-json](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/stream-json ). These dependencies needed to be updated together.
Updates `stream-json` from 1.8.0 to 1.9.1
- [Commits](https://github.com/uhop/stream-json/compare/1.8.0...1.9.1 )
Updates `@types/stream-json` from 1.7.7 to 1.7.8
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/stream-json )
---
updated-dependencies:
- dependency-name: stream-json
dependency-version: 1.9.1
dependency-type: direct:development
update-type: version-update:semver-minor
- dependency-name: "@types/stream-json"
dependency-version: 1.7.8
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-25 12:58:38 +02:00
Robo
3ccb1bc0a8
refactor: allocate api::Session on cpp heap ( #48141 )
2025-08-25 18:52:06 +09:00
Shelley Vohr
0917ed5f6f
fix: snapped restoration after minimization ( #48142 )
2025-08-22 14:37:45 -04:00
Samuel Attard
a67aad0f50
build: use siso instead of reclient ( #47534 )
2025-08-22 14:17:02 -04:00
reito
ceb6d28fd3
fix: webContent.fromId should be number instead of string ( #48059 )
2025-08-22 11:40:10 -04:00
Shelley Vohr
e12ab6708e
chore: improve failed notification error messages on Windows ( #48131 )
2025-08-22 11:35:39 -04:00
Shelley Vohr
6101025368
fix: net.isOnline always true in utility processes ( #48111 )
...
* fix: net.isOnline always true in utilityProcesses
* Update shell/services/node/node_service.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-08-22 14:30:41 +02:00
dependabot[bot]
97b0280ad4
build(deps): bump amannn/action-semantic-pull-request from 5.5.3 to 6.0.1 ( #48115 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.3 to 6.0.1.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](0723387faa...fdd4d3ddf6 )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-21 10:44:27 +02:00
John Kleinschmidt
1044fe675d
build: use new 7z command line switch ( #48136 )
...
-snld20 replaces -snld
2025-08-20 17:05:25 -04:00
John Kleinschmidt
42af60cc7e
docs: update 38.0 breaking changes ( #48117 )
2025-08-20 14:15:01 -04:00
John Kleinschmidt
cadba11088
build: fixup docs only condition ( #48128 )
2025-08-20 12:58:54 -04:00
Shelley Vohr
8aeee3f714
refactor: use XmlWriter for Windows toasts ( #48065 )
...
refactor: use XmlWriter for Windows toasts
2025-08-20 16:06:51 +02:00
Robo
dd54e84a58
refactor: allocate api::App on cpp heap ( #48118 )
2025-08-20 20:35:08 +09:00
John Kleinschmidt
d4b7d9e9cf
build: get source cache for docs only pipeline ( #48120 )
2025-08-20 11:07:00 +02:00
BILL SHEN
83a5ba1e2c
feat: add fileBacked and purgeable fields to process.getSystemMemoryInfo() for macOS ( #47628 )
...
* fix: Optimize the value of memory.free in the return data of getSystemMemoryInfo().
* fix: Improve the value of memory in the return data of getSystemMemoryInfo().
* fix: complete API doc.
* Update docs/api/process.md
Co-authored-by: Will Anderson <will@itsananderson.com >
* fix: update name to fileBacked.
* fix: fix with code conflict
---------
Co-authored-by: Will Anderson <will@itsananderson.com >
2025-08-20 09:49:41 +02:00
Shelley Vohr
13d955a73e
fix: system accent color parsing hex order ( #48085 )
...
fix: system accent color parsing
2025-08-19 10:01:41 +02:00
Samuel Attard
fdf29ce838
fix: ensure snapshot is valid ( #48101 )
2025-08-18 14:35:58 -07:00
Samuel Attard
3770bb31a7
fix: avoid deprecated login item methods ( #48090 )
2025-08-17 22:00:52 -07:00
dependabot[bot]
ed4a99ba5b
build(deps-dev): bump @azure/storage-blob from 12.25.0 to 12.28.0 ( #48055 )
...
Bumps [@azure/storage-blob](https://github.com/Azure/azure-sdk-for-js ) from 12.25.0 to 12.28.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases )
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md )
- [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/storage-blob_12.25.0...@azure/storage-blob_12.28.0 )
---
updated-dependencies:
- dependency-name: "@azure/storage-blob"
dependency-version: 12.28.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-16 09:39:46 +02:00
Shelley Vohr
0e6c26096f
fix: shell.openPath should be non-blocking ( #48079 )
...
fix: shell.openPath should be non-blocking
2025-08-15 13:55:31 -07:00
Keeley Hammond
7792ed1efa
build: revert bump @octokit/rest from 20.1.2 to 22.0.0 ( #48082 )
...
Revert "build(deps-dev): bump @octokit/rest from 20.1.2 to 22.0.0 (#48014 )"
This reverts commit 13ed526ca7 .
2025-08-14 20:50:09 -07:00
Robo
c75c390ccf
chore: add uma results in macOS keychain patch ( #48080 )
2025-08-15 11:10:37 +09:00
Shelley Vohr
4c3c3049e1
build: disallow non-maintainer changes to GitHub Actions workflows ( #48038 )
2025-08-14 13:54:05 -07:00
Shelley Vohr
68e7b38c05
build: use quick tunnels for ssh debugging ( #47938 )
...
* build: use dynamic local tunnels for ssh debugging
* weeee
* that'll do
* chore: pretty output
* build: allow ssh input
---------
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2025-08-14 07:41:07 -04:00
dependabot[bot]
a051c7c274
build(deps): bump actions/download-artifact from 4.3.0 to 5.0.0 ( #48052 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.3.0 to 5.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](d3f86a106a...634f93cb29 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-13 14:33:48 +02:00
Shelley Vohr
53003d7af9
fix: app.accessibilitySupportEnabled ( #48041 )
...
fix: app.accessibilitySupportEnabled on macOS
2025-08-12 16:51:27 -04:00
David Sanders
63d7f609cd
ci: manually fetch author_association in workflow automations ( #48013 )
2025-08-12 10:30:41 -07:00
electron-roller[bot]
01291623af
chore: bump chromium to 141.0.7350.0 (main) ( #48032 )
...
* chore: bump chromium in DEPS to 141.0.7349.0
* chore: bump chromium in DEPS to 141.0.7350.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-08-12 11:31:17 +02:00
dependabot[bot]
13ed526ca7
build(deps-dev): bump @octokit/rest from 20.1.2 to 22.0.0 ( #48014 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.2 to 22.0.0.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.2...v22.0.0 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 22.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-12 11:18:08 +02:00
Shelley Vohr
afb0ee418c
fix: re-entrancy issues in webContents.loadURL() ( #48004 )
...
fix: re-entrancy issues in webContents.loadURL()
2025-08-11 11:20:35 -04:00
electron-roller[bot]
55d8b71d72
chore: bump chromium to 141.0.7346.0 (main) ( #47983 )
...
* chore: bump chromium in DEPS to 141.0.7341.0
* chore: bump chromium in DEPS to 141.0.7342.0
* chore: update patches
manually resolved conflict in `osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch` due to https://crrev.com/c/6681354
* 6819541: WebShare: Improve mac share behavior when sharing a URL
https://chromium-review.googlesource.com/c/chromium/src/+/6819541
* Add missing include for SkBitmap
Couldn't quickly find where we lost the full definition in this file's includes. 🤷
* 6771055: [SxS] Move devtools to ContentsContainerView supporting side-by-side.
https://chromium-review.googlesource.com/c/chromium/src/+/6771055
There may be some simplification possible here (set_x, Rect position, ...), but this change is satisfactory to maintain the current behavior.
* 6813689: Switch SystemMemoryInfoKB to use ByteCount
https://chromium-review.googlesource.com/c/chromium/src/+/6813689
* 6818486: Track DevTools feature usage in new badge tracker
https://chromium-review.googlesource.com/c/chromium/src/+/6818486
* chore: bump chromium in DEPS to 141.0.7344.0
* Remove ELECTRON_OZONE_PLATFORM_HINT env var
6819616: Remove OzonePlatformHint | https://chromium-review.googlesource.com/c/chromium/src/+/6819616
See: https://github.com/electron/electron/issues/48001
* chore: update patches
* Add missing include for `base::NumberToString`
* Remove `DESKTOP_STARTUP_ID` code
This was removed upstream in https://chromium-review.googlesource.com/c/chromium/src/+/6819616 and I confirmed with the author that it was an intentional change. Going to mirror upstream and remove it here too.
* chore: bump chromium in DEPS to 141.0.7346.0
* chore: update patches
* 6828465: Reland "Remove BluezDBusThreadManager"
https://chromium-review.googlesource.com/c/chromium/src/+/6828465
* Patch change to Node.js test output
V8 enhanced the stack trace of "thenable" async tasks. A couple of Node.js tests needed to have their snapshots updates to accomodate the extra stack trace frames in the output.
This patch should be upstreamed to Node.js.
See:
6826001: fix thenable async stack trace
https://chromium-review.googlesource.com/c/v8/v8/+/6826001
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2025-08-11 12:57:31 +09:00
Calvin
b9ceaabb85
docs: deprecate ELECTRON_OZONE_PLATFORM_HINT env var ( #48002 )
2025-08-10 21:49:23 +02:00
David Sanders
d6c0691a63
fix: importing from electron/utility in ESM ( #47998 )
2025-08-09 09:47:47 +02:00
David Sanders
a201d6c541
build: drop @types/webpack-env in favor of webpack/module types ( #47798 )
...
* build: drop @types/webpack-env in favor of webpack/module types
* chore: improve type when assigning to global.require
2025-08-08 18:09:23 -07:00
John Kleinschmidt
51add3e847
ci: cleanup use new arc cluster ( #47916 )
2025-08-08 09:26:10 -04:00
reito
9dcdec5015
feat: paint event move texture data to handle, add colorSpace ( #47315 )
...
* feat: paint event move shared texture to handle, add color space
* feat: add breaking change
* fix: properties.
* fix: remove utf8 bom
2025-08-08 10:13:56 +02:00
reito
095e622a6a
feat: context bridge support VideoFrame ( #47316 )
...
* feat: context bridge support VideoFrame
* docs: add VideoFrame to docs
2025-08-07 16:41:49 -04:00
Shelley Vohr
a0d983e4b5
feat: allow macOS tray to maintain position ( #47838 )
...
* feat: allow macOS tray to maintain position
* refactor: just use guid
* test: fixup tests
* docs: clarify UUID format
2025-08-07 19:25:50 +02:00
wujinli
f49a645c06
fix: compilation error when disabling extensions and pdf_viewer ( #47964 )
2025-08-07 11:18:32 -04:00
John Kleinschmidt
8ab5ac9069
ci: fixup mac runner hang ( #47982 )
2025-08-07 10:52:26 +02:00
Will Anderson
27a8cc531b
chore: Remove redundant IS_WIN check inside electron_main_win.cc ( #47967 )
2025-08-07 09:54:13 +02:00
David Sanders
26ffc8505c
fix: allow importing from electron/utility at runtime ( #47968 )
2025-08-07 09:53:42 +02:00
electron-roller[bot]
3b0f35a7e8
chore: bump chromium to 140.0.7339.2 (main) ( #47929 )
...
* chore: bump chromium in DEPS to 140.0.7330.0
* chore: bump chromium in DEPS to 140.0.7331.0
* chore: update patches
* fix: gn check failing on crashpad.h
Not yet sure what caused this
* fix: predictors::PreconnectManager -> content::PreconnectManager
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473
* chore: bump chromium in DEPS to 140.0.7333.0
* chore: bump chromium in DEPS to 140.0.7335.0
* chore: bump chromium in DEPS to 140.0.7337.0
* chore: update patches
* chore: restore some gin utility
* 6804057: [Extensions] Validate nodoc is specified as a boolean in schemas
https://chromium-review.googlesource.com/c/chromium/src/+/6804057
* fixup! chore: restore some gin utility
* fixup! fix: predictors::PreconnectManager -> content::PreconnectManager CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473
* 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected
https://chromium-review.googlesource.com/c/chromium/src/+/6772346
Not certain about what the "correct" argument to pass here is. A quick dive into the CL suggests that passing `false` is safe to keep things working. The blast radius if this assumption is wrong is that "fling" scroll gestures may not work as expected with the OSR.
* 6789383: Uninstall SODA language pack after 30 days of inactivity
https://chromium-review.googlesource.com/c/chromium/src/+/6789383
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 140.0.7339.0
* chore: update patches
* fixup! 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected https://chromium-review.googlesource.com/c/chromium/src/+/6772346
* chore: bump chromium in DEPS to 140.0.7339.2
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-08-06 20:14:23 -04:00
David Sanders
8769d5ba9e
build: check zip manifest for chromedriver.zip ( #47972 )
2025-08-06 20:04:19 -04:00
dependabot[bot]
7f8b7c3873
build(deps-dev): bump @electron/lint-roller from 3.1.1 to 3.1.2 ( #47963 )
...
Bumps [@electron/lint-roller](https://github.com/electron/lint-roller ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/electron/lint-roller/releases )
- [Changelog](https://github.com/electron/lint-roller/blob/main/.releaserc.json )
- [Commits](https://github.com/electron/lint-roller/compare/v3.1.1...v3.1.2 )
---
updated-dependencies:
- dependency-name: "@electron/lint-roller"
dependency-version: 3.1.2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-06 11:21:55 +02:00
David Sanders
8bf4260e3e
test: add TS smoke test for electron/utility ( #47969 )
2025-08-06 10:30:39 +02:00
Charles Kerr
7a13c6f175
refactor: avoid deprecated v8::Context::GetIsolate() pt 4 ( #47961 )
...
* refactor: remove GetIsolate() calls from SetPrivate()
* refactor: remove excess GetIsolate() calls in PassValueToOtherContextInner()
* refactor: remove GetIsolate() calls from GetPrivate()
* refactor: add a v8::Isolate* local to ProxyFunctionWrapper()
* refactor: remove error_context->GetIsolate() call from PassValueToOtherContextInner()
* refactor: remove GetIsolate() call from ProxyFunctionWrapper()
* refactor: pass source and destination isolate as arg to CreateProxyForAPI()
2025-08-05 20:08:04 -05:00
Keeley Hammond
678fb400fd
fix: video scrubbing on playback ( #47703 )
...
* fix: fix video scrubbing on playback
* chore: address review feedback
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-05 18:48:52 +02:00
Shelley Vohr
8806499904
fix: offscreen mode under window.open creation ( #47868 )
...
fix: offscreen mode under new window creation
2025-08-05 14:56:33 +02:00
dependabot[bot]
637a504e28
build(deps): bump github/codeql-action from 3.29.4 to 3.29.5 ( #47962 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.4 to 3.29.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4e828ff8d4...51f77329af )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-05 14:41:57 +02:00
electron-roller[bot]
40cdfdb1d1
chore: bump node to v22.18.0 (main) ( #47937 )
...
* chore: bump node in DEPS to v22.18.0
* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define
https://github.com/nodejs/node/pull/58845
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58960
* permission: propagate permission model flags on spawn
https://github.com/nodejs/node/pull/58853
* esm: syncify default path of ModuleLoader\.load
https://github.com/nodejs/node/pull/57419
* src: remove fast API for InternalModuleStat
https://github.com/nodejs/node/pull/58489
* src: simplify adding fast APIs to ExternalReferenceRegistry
https://github.com/nodejs/node/pull/58896/
* chore: fixup patch indices
* src: fix internalModuleStat v8 fast path
https://github.com/nodejs/node/pull/58054
* test: add tests to ensure that node.1 is kept in sync with cli.md
https://github.com/nodejs/node/pull/58878
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58942
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-04 14:40:36 -04:00
Robo
4ca10a1056
chore: move gin::Handle to gin_helper ( #47959 )
...
* chore: move gin::Handle to gin_helper
* chore: fix lint
2025-08-05 02:03:06 +09:00
Robo
9d05454dc7
chore: move gin::DeprecatedWrappable to gin_helper ( #47958 )
...
* chore: move gin::DeprecatedWrappable to gin_helper
This is in preparation for migrating to gin::Wrappable
based on cppgc #47922
The upstream class will be deleted soon via roller PR but
the cppgc migration should happen outside the roll, this
change retains the current functionality by copying the
implementation into //electron/shell/common/gin_helper.
The class can be deleted once the cppgc migration is complete.
* chore: fix lint:cpp
2025-08-04 23:28:01 +09:00
dependabot[bot]
0e862bba61
build(deps-dev): bump remark-preset-lint-markdown-style-guide from 4.0.0 to 6.0.1 ( #47940 )
...
build(deps-dev): bump remark-preset-lint-markdown-style-guide
Bumps [remark-preset-lint-markdown-style-guide](https://github.com/remarkjs/remark-lint ) from 4.0.0 to 6.0.1.
- [Release notes](https://github.com/remarkjs/remark-lint/releases )
- [Changelog](https://github.com/remarkjs/remark-lint/blob/main/changelog.md )
- [Commits](https://github.com/remarkjs/remark-lint/commits )
---
updated-dependencies:
- dependency-name: remark-preset-lint-markdown-style-guide
dependency-version: 6.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-04 14:29:36 +02:00
Shelley Vohr
4232ed2814
fix: crash on window.close() with webContents on blur ( #47933 )
...
fix: crash on window.close with WebContentsView on blur
2025-08-04 10:35:29 +02:00
Will Anderson
e7683bdd25
feat: Use DIR_ASSETS path to locate resource bundles ( #47439 )
...
* feat: Use DIR_ASSETS path to locate resource bundles
* Use DIR_ASSETS for calculating ASAR relative paths
* Add test to verify 'assets' matches parent dir of 'exe'
* Add Mac-specific test for assets path (but it is failing)
* test: Update app.getPath('assets') to expect an exception on Mac
* docs: Update docs for 'assets' path to indicate that it's only available on Windows + Linux
* fix: Don't define 'assets' mapping on macOS
2025-08-04 12:34:08 +09:00
Sam Maddock
bdaf3b9a2b
refactor: replace webFrame.routingId with sync IPC ( #47717 )
...
* refactor: replace webFrame.routingId with sync IPC
* fix: GetConstructor missing isolate
* fix: missing isolate
2025-08-02 11:00:42 -04:00
Shelley Vohr
5c98e3609f
feat: add {get|set}AccentColor on Windows ( #47741 )
...
* feat: add setAccentColor on Windows
* refactor: unify GetSystemAccentColor
* refactor: remove redundant parsing
* chore: fixup documentation
* Update docs/api/browser-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
* Update docs/api/base-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
---------
Co-authored-by: Will Anderson <andersonw@dropbox.com >
2025-08-01 22:29:02 +02:00
dependabot[bot]
2cfccac074
build(deps-dev): bump folder-hash from 2.1.2 to 4.1.1 ( #47931 )
...
Bumps [folder-hash](https://github.com/marc136/node-folder-hash ) from 2.1.2 to 4.1.1.
- [Release notes](https://github.com/marc136/node-folder-hash/releases )
- [Changelog](https://github.com/marc136/node-folder-hash/blob/main/CHANGELOG.md )
- [Commits](https://github.com/marc136/node-folder-hash/compare/v2.1.2...v4.1.1 )
---
updated-dependencies:
- dependency-name: folder-hash
dependency-version: 4.1.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-01 19:16:43 +02:00
electron-roller[bot]
03aad28412
chore: bump chromium to 140.0.7327.0 (main) ( #47902 )
...
* chore: bump chromium in DEPS to 140.0.7324.0
* chore: bump chromium in DEPS to 140.0.7325.0
* chore: remove @dsanders11's unused include patch
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6782507
* fix: apply keychain patch to new apple subdir
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update chromium patches
* chore: update other patches
* chore: bump chromium in DEPS to 140.0.7327.0
* fix: mistake in reapplied patch
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update patches
* fix: remove OnPrivateNetworkAccessPermissionRequired override
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6769208
* fix: update colorSpace property to use new unified value
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6795085
* fix: include OverlayWindowLiveCaptionButton
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787420
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* fix: format chromium_src/BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* fix: format BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* chore: include script/ in logged path
* fix: update filenames.libcxx.gni
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787279
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-31 18:11:00 -04:00
Sam Maddock
25e2459f31
feat: webFrameMain.fromFrameToken ( #47850 )
...
* feat: webFrameMain.fromFrameToken
* refactor: return null instead of undefined
* docs: mention renderer webFrame property
* chore: undo null->undefined in wfm.fromId api
this will be updated in another pr
2025-07-31 16:41:44 -04:00
Shelley Vohr
18af498cf1
build: roll build-images to 933c7d6 ( #47880 )
2025-07-31 12:08:45 -04:00
John Kleinschmidt
9f43503b3e
chore: revert "ci: fixup mac runners" ( #47917 )
...
This reverts commit 06d7a51a58 .
2025-07-31 11:08:43 -04:00
Shelley Vohr
ecb1eb0b5d
feat: add app.getRecentDocuments() ( #45839 )
...
feat: add app.getRecentDocuments()
2025-07-31 16:15:33 +02:00
dependabot[bot]
2c916cfa33
build(deps-dev): bump @octokit/rest from 20.1.1 to 20.1.2 ( #47818 )
...
* build(deps-dev): bump @octokit/rest from 20.1.1 to 22.0.0
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.1 to 22.0.0.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.1...v22.0.0 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 22.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: bump octokit/rest to 20.1.2
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-07-31 14:30:45 +02:00
Shelley Vohr
4c9ab8765b
fix: dark mode on Linux default themeing ( #47869 )
2025-07-31 10:54:55 +02:00
dependabot[bot]
051f78dd1d
build(deps): bump actions-cool/issues-helper from 3.6.0 to 3.6.2 ( #47905 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.6.0 to 3.6.2.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](a610082f8a...50068f49b7 )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.6.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-31 10:54:25 +02:00
dependabot[bot]
c796a74467
build(deps): bump github/codeql-action from 3.29.2 to 3.29.4 ( #47904 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.2 to 3.29.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](181d5eefc2...4e828ff8d4 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-31 10:54:03 +02:00
John Kleinschmidt
0d0cbaf7b4
ci: use new arc cluster ( #47897 )
2025-07-30 13:45:24 -04:00
Charles Kerr
63c452dcc7
refactor: avoid deprecated v8::Context::GetIsolate() calls pt 3 context get isolate pt 3 ( #47901 )
...
* refactor: add a v8::Isolate* arg to RendererClientBase::IsWebViewFrame()
Needed for creating gin dictionaries
refactor: add a v8::Isolate* arg to ShouldLoadPreload()
Needed for calling IsWebViewFrame()
* refactor: add a v8::Isolate* arg to electron::util::CompileAndCall()
* refactor: add a v8::Isolate* arg to OnCreatePreloadableV8Context()
* refactor: add a v8::Isolate* arg to InvokeEmitProcessEvent()
* refactor: add a v8::Isolate* arg to ServiceWorkerData's constructor
* refactor: add a v8::Isolate* arg to RendererClientBase::SetupMainWorldOverrides()
* refactor: add a v8::Isolate* arg to RendererClientBase::WilLReleaseScriptContext()
* docs: update docs to avoid v8::Context::GetIsolate()
* refactor: add a v8::Isolate* arg to ElectronSandboxedRendererClient::InitializeBindings()
* refactor: avoid v8::Context::GetIsolate() call in PromiseBase::SettleScope::~SettleScope()
2025-07-30 09:14:38 -05:00
electron-roller[bot]
f6407b4949
chore: bump chromium to 140.0.7314.0 (main) ( #47882 )
...
* chore: bump chromium in DEPS to 140.0.7314.0
* 6769821: Delegate checking whether preconnect is enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769821
* 6632993: PDF Searchify IPH: Use embedder WebContents for GuestView PDF
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6632993
* 6769214: [ios blink] Set IOSurface shared memory region on all GMB handles
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769214
* chore: update patches
* 6769572: [soft navs]: Move AsyncSameDocumentNavigationStarted to TaskAttributionTracker
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769572
* chore: node gen-libc++-filenames.js
* 6765740: [SxS] Implement support for split view in extensions API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6765740
* 6769821: Delegate checking whether preconnect is enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769821
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-28 15:31:54 -07:00
John Kleinschmidt
06d7a51a58
ci: fixup mac runners ( #47877 )
...
ci: make sure camera and bluetooth are available on macos
ci: turn off spotlight indexing
2025-07-28 13:37:05 -04:00
Charles Kerr
2255bb620a
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) ( #47879 )
...
* refactor: add a v8::Isolate* arg to Constructible::GetConstructor()
* refactor: add a v8::Isolate* arg to NodeBindings::Initialize()
This is needed for the GetConstructor() call
* refactor: avoid v8::Context::GetIsolate() call in GetIpcObject() by taking it as an arg
* refactor: avoid v8::Context::GetIsolate() call in ipc_native::EmitIPCEvent() by taking it as an arg
2025-07-28 10:22:27 -05:00
Charles Kerr
084c6ef549
refactor: prefer GetCreationContextChecked(v8::Isolate*) over GetCreationContextChecked() ( #47878 )
...
* refactor: pass an isolate when calling GetCreationContextChecked() in V8FunctionInvoker
* refactor: pass an isolate when calling GetCreationContextChecked() in RendererClientBase
* refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::Completed()
* refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::CopyResultToCallingContextAndFinalize()
* refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame()
* refactor: pass an isolate when calling GetCreationContextChecked() in gin_helper::internal::CallMethodWithArgs()
* refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalPropertyFromIsolatedWorld()
* refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalValueFromIsolatedWorld()
* refactor: pass an isolate when calling GetCreationContextChecked() in ProxyFunctionWrapper()
* refactor: pass an isolate when calling GetCreationContextChecked() in PassValueToOtherContextInner()
* fixup! refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame()
2025-07-25 09:06:57 -05:00
Shelley Vohr
01faaa30ea
fix: window content protection on older Windows versions ( #47856 )
2025-07-24 12:05:28 -07:00
electron-roller[bot]
c569d5e4ba
chore: bump chromium to 140.0.7312.0 (main) ( #47862 )
...
* chore: bump chromium in DEPS to 140.0.7312.0
* 6769540: Move NetworkTrafficAnnotationTag out of PreconnectManager.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769540
* 6771377: Roll libc++ from 3eda1e62e799 to 569aa83b4bbc (7 revisions)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771377
* 6771398: Remove unnecessary std::optional wrappers in ResolveHostClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771398
* chore: update patches
* 6776165: Use shared session bus for MPRIS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6776165
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-23 16:26:30 -07:00
Shelley Vohr
670da27305
ci: add ability to debug SSH sessions in CI ( #47819 )
2025-07-23 10:57:06 -04:00
dependabot[bot]
5f901174c5
build(deps): bump slackapi/slack-github-action from 2.1.0 to 2.1.1 ( #47748 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](b0fa283ad8...91efab103c )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-version: 2.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-23 11:24:17 +02:00
xufuhang
b39a1fb877
fix: webContents.downloadURL() did not support referer header ( #47625 )
...
Signed-off-by: xufuhang <576484918@qq.com >
2025-07-23 10:37:24 +02:00
Robo
2156ccb577
ci: update llvmobjdump package as part of fix sync ( #47858 )
2025-07-23 17:05:30 +09:00
electron-roller[bot]
9e2f7065a0
chore: bump chromium to 140.0.7309.0 (main) ( #47848 )
...
* chore: bump chromium in DEPS to 140.0.7309.0
* 6762172: Replace MSG_ROUTING_NONE with IPC::mojom::kRoutingIdNone.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6762172
* 6759543: [exit-time-destructors] Exclude target with warnings
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6759543
* 6765167: Split PreconnectManager into interface and implementation.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6765167
* 6766775: [media] Clarify coded and visible size in FrameResources
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6766775
* 6760878: Move PreconnectRequest to //content/public
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6760878
* 6718973: Implement media playback trust check for the video PiP overlay window
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6718973
* chore: add missing include of <iterator> in ada
* chore: update patches
* chore: node gen-libc++-filenames.js
* 6759633: [media] Use format from shared image in FrameResources
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6759633
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-22 16:09:47 -07:00
Niklas Wenzel
51bfe07da9
build: extend Chromium options in bug report template ( #47829 )
...
* build: extend Chromium options in bug report template
As predicted by @dsanders11 and others, we got a bunch of bug reports with clearly incorrect values for "does this issue appear in Chromium?" because people didn't test or didn't know how to test.
This PR adds an "I didn't know how to test" option.
* build: update wording to use present tense
2025-07-21 15:26:02 -04:00
Shelley Vohr
4699761649
build: improve check-zip-manifest ( #47828 )
...
* build: improve check-zip-manifest
* fix: unicode on Windows
2025-07-21 15:20:27 -04:00
electron-roller[bot]
26e1bda335
chore: bump chromium to 140.0.7301.0 (main) ( #47747 )
...
* chore: bump chromium in DEPS to 140.0.7296.0
* chore: update patches
* 6702959: Remove OwnedByWidgetPassKey usage from content analysis dialog tests | https://chromium-review.googlesource.com/c/chromium/src/+/6702959
* 6722750: Remove un-used `stream_id` argument for `AidaCodeComplete` | https://chromium-review.googlesource.com/c/chromium/src/+/6722750
* 6696478: Reland Reland [video pip] Add fade in/out animation to controls visibility changes | https://chromium-review.googlesource.com/c/chromium/src/+/6696478
* chore: update libc++-filenames
* build: explicitly include cstdlib in Boyer-Moore patch
* chore: bump chromium in DEPS to 140.0.7297.0
* chore: update patches
* 6729537: [FPF] Pipe flag state from the browser to the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6729537
* 6727996: [Win] Detect pre-IPC crashes in sandboxed utility processes | https://chromium-review.googlesource.com/c/chromium/src/+/6727996
* 6707182: Move wtf/cross_thread_copier*.* to "blink" namespace | https://chromium-review.googlesource.com/c/chromium/src/+/6707182
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* chore: bump chromium in DEPS to 140.0.7299.0
* chore: update patches
* chore: update main patches
* build: reset the minimum macOS SDK to 15 to match upstream
This reverts commit 499e987c77 .
* 6730215: Remove IPC_MESSAGE_LOG_ENABLED ifdef blocks. | https://chromium-review.googlesource.com/c/chromium/src/+/6730215
* 6690442: Delete ppapi/buildflags/buildflags.h | https://chromium-review.googlesource.com/c/chromium/src/+/6690442
* [wip]: 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
* chore: bump chromium in DEPS to 140.0.7301.0
* chore: update patches
* 6656309: extensions: Port proxy API to desktop Android | https://chromium-review.googlesource.com/c/chromium/src/+/6656309
* 6758510: Reland 'Move GN enable_plugins variable out of //ppapi' | https://chromium-review.googlesource.com/c/chromium/src/+/6758510
* 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* 6735979: [FSA] Replace `request_writable` with a new enum `FileSystemAccessPermissionMode`. | https://chromium-review.googlesource.com/c/chromium/src/+/6735979
* 6712080: Reland "Turn on gender translation PAK generation everywhere" | https://chromium-review.googlesource.com/c/chromium/src/+/6712080
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* build: restore minimum macOS SDK to 10, restore patch
This reverts commit a04c579b99 .
* fixup! 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* chore: correct node patches
* fixup! 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-21 09:32:53 -07:00
Shelley Vohr
cf871bce4e
build: fix ffmpeg generation on Windows non-x64 ( #47768 )
...
* build: fix ffmpeg generation on Windows non-x64
* test: ffmpeg artifact
2025-07-21 11:33:42 -04:00
Charles Kerr
39cca586f6
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) ( #47760 )
...
* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment()
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615
* refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext()
* fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
2025-07-21 16:34:38 +02:00
Shelley Vohr
2f4a070c39
fix: dialog file filters and macOS app bundles ( #47825 )
2025-07-21 13:57:50 +02:00
electron-roller[bot]
2b098408a8
chore: bump node to v22.17.1 (main) ( #47776 )
...
* chore: bump node in DEPS to v22.17.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-18 15:18:18 -04:00
Shelley Vohr
fa844268ec
ci: remove kTCCServiceMicrophone change ( #47816 )
...
ci: remove kTCCServiceMicrophone change
2025-07-18 10:02:06 +02:00
Shelley Vohr
a29a72c3ab
build: update codespace on-create-command ( #47810 )
...
build: update codespace on-create-command
2025-07-18 10:01:49 +02:00
Shelley Vohr
4601aeccde
chore: clean up NativeWindowMac::UpdateVibrancyRadii ( #47665 )
...
chore: clean up NativeWindowMac::UpdateVibrancyRadii
2025-07-17 11:45:24 -04:00
Shelley Vohr
31b18c9830
fix: abnormal behavior of windows background material ( #47386 )
...
* fix: abnormal behavior of windows background material
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches
* fix: setting background material after init
---------
Co-authored-by: zoy <zoy-l@outlook.com >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-17 14:50:12 +02:00
Shelley Vohr
895bf9103e
fix: handle missing NativeWindowMac in ElectronNSWindow ( #47751 )
...
fix: handle missing NativeWindowMac in ElectronNSWindow
2025-07-17 14:49:37 +02:00
David Sanders
bf51d345c8
build(dev-deps): drop unused @types/webpack dep ( #47767 )
2025-07-17 11:04:11 +02:00
Shelley Vohr
6eef170d9a
test: re-enable native module tests ( #46747 )
2025-07-17 11:03:15 +02:00
Shelley Vohr
31725b4a86
fix: window accentColor should adhere to native window behavior ( #47740 )
...
* fix: window accentColor should adhere to native window behavior
* fix: address review feedback
* chore: remove duplicate UpdateWindowAccentColor call in ctor
2025-07-17 10:59:42 +02:00
John Kleinschmidt
ec748eb915
test: cleanup RenderFrame lifespan tests ( #47746 )
...
* test: cleanup RenderFrame lifespan tests
* test: disable navigator.serial tests on arm64 mac
debug the hang
test: disable navigator.bluetooth on arm64 mac
Revert "test: disable navigator.bluetooth on arm64 mac"
This reverts commit 4b53a8485a5ff391832c7da93d859f1aa8722e70.
Revert "debug the hang"
This reverts commit 00338f0d49a7918224822087b4510fa9db0686c3.
Revert "test: disable navigator.serial tests on arm64 mac"
This reverts commit fb515ce447a9d42185e84b17b460e4fb6d1bf71d.
Reapply "test: disable navigator.serial tests on arm64 mac"
This reverts commit 0e5608108ffebbe8b8b27af9ea06aadae2ea85dd.
Reapply "test: disable navigator.bluetooth on arm64 mac"
This reverts commit f4c7d3fc0624a22421cba5d3d75df8c5d4367eea.
fixup
* test: add waitUntil for flaky test
2025-07-16 16:19:55 -04:00
Shelley Vohr
5feb91e2f4
test: fix extensions console flake ( #47750 )
2025-07-16 18:27:20 +02:00
Shelley Vohr
5128ebeddb
test: deflake clipboard read/write specs ( #47752 )
2025-07-16 18:27:11 +02:00
Calvin
389927dce8
fix: corner smoothing feature gate crash ( #47759 )
...
* fix: corner smoothing feature gate crash
* Fix ElectronCornerSmoothing::CSSValueFromComputedStyleInternal
2025-07-16 08:39:17 -07:00
Calvin
67afc10b75
fix: add macos memory query fallback patch to avoid crash ( #47765 )
2025-07-16 08:18:54 -07:00
Pratyush
f570e6967f
docs: fix broken sentence in crashReporter.start() documentation ( #47688 )
2025-07-16 15:05:45 +02:00
Shelley Vohr
09ab71de43
fix: deprecation warning crash when no Node.js environment available ( #47700 )
2025-07-16 12:45:59 +02:00
Milan Burda
21b325b034
docs: improve win.setContentProtection() docs ( #46596 )
...
* docs: improve win.setContentProtection() docs
* docs: update Windows display affinity value
* docs: update Windows behavior description
* Revert "docs: update Windows behavior description"
This reverts commit 6d1942c53a .
* Revert "docs: update Windows display affinity value"
This reverts commit c15363e75d .
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-07-15 15:16:56 -07:00
Erick Zhao
cc9ca4bee2
docs: add Menu module tutorials ( #47268 )
...
* docs: add `Menu` module tutorials
* link API docs to new tutorials
* removed unreferenced fiddles
* add wording for new types
* fix import sort errors
* delete accelerator.md
* fixes
2025-07-15 15:09:32 -07:00
Shelley Vohr
17dba93587
fix: missing SQLite builtin support in Node.js ( #47706 )
...
https://github.com/nodejs/node/pull/58122
2025-07-15 15:39:16 +02:00
electron-roller[bot]
603cafad7e
chore: bump chromium to 140.0.7281.0 (main) ( #47616 )
...
* chore: bump chromium in DEPS to 140.0.7269.2
* chore: bump chromium in DEPS to 140.0.7270.0
* chore: bump chromium in DEPS to 140.0.7271.0
* chore: bump chromium in DEPS to 140.0.7273.0
* 6516731: [ExclusiveAccessForAndroid] remove unneeded includes & deps | https://chromium-review.googlesource.com/c/chromium/src/+/6516731
* 6694809: dbus: Ensure systemd scope is started before using any portal services | https://chromium-review.googlesource.com/c/chromium/src/+/6694809
* chore: patch chromium
* chore: export patches
* chore: bump chromium in DEPS to 140.0.7275.0
* 6677511: [pepper] More pepper removal | https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: export chromium patches
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: bump chromium in DEPS to 140.0.7277.0
* chore: bump chromium in DEPS to 140.0.7279.0
* chore: bump chromium in DEPS to 140.0.7281.0
* 6677314: Plumb enabled client hints in the network requestion to network layer
https://chromium-review.googlesource.com/c/chromium/src/+/6677314
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* 6700077: [renderer] Avoid calls to deprecated GetIsolate methods
https://chromium-review.googlesource.com/c/chromium/src/+/6700077
* 6692873: Reland "Reland "FSA: Only normalize the hardcoded rules once during initialization""
https://chromium-review.googlesource.com/c/chromium/src/+/6692873
* 6686234: [gin] Cleanup NamedPropertyInterceptor for Wrappable
https://chromium-review.googlesource.com/c/chromium/src/+/6686234
* chore: export patches
* 6667723: Remove content_enable_legacy_ipc GN arg.
https://chromium-review.googlesource.com/c/chromium/src/+/6667723
* 6646566: ui: Move NativeWindowTracker to its own directory
https://chromium-review.googlesource.com/c/chromium/src/+/6646566
* fix: add missing includes
* 6580522: [WAR, DNR] Fix unsafe redirect error to web accessible resource
https://chromium-review.googlesource.com/c/chromium/src/+/6580522
* 6680477: Implement `completeCode` endpoint and expose to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/6680477
* 6677511: [pepper] More pepper removal
https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6696689: Rename views::WidgetFocusManager -> NativeViewFocusManager
https://chromium-review.googlesource.com/c/chromium/src/+/6696689
* 6702812: Move wtf/text/string_impl*.* to "blink" namespace
https://chromium-review.googlesource.com/c/chromium/src/+/6702812
* chore: fix dialog patch
* 6702431: [animation-trigger] Parse timeline-trigger-name
https://chromium-review.googlesource.com/c/chromium/src/+/6702431
* chore: fixup patch indices
* feat: replace webFrame.routingId with webFrame.frameToken
* feat: WebFrameMain.prototype.frameToken
* test: refactor to use replacement APIs
* chore: fixup pip patch
* test: adjust webFrame tests for frameToken changes
* 6703757: Reland "Enable -fsanitize=array-bounds in non-UBSan builds"
https://chromium-review.googlesource.com/c/chromium/src/+/6703757
* test: switch to frameTokens
* test: routingId is fine to test in the main process
* docs: add routingId to breaking changes
* docs: update plugin-crashed event
* chore: fixup linux dialog patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-14 13:42:37 -07:00
Shelley Vohr
09f269426e
test: add response to bluetooth request possibilities ( #47725 )
2025-07-14 13:12:27 -04:00
Shelley Vohr
3bbb82b42b
ci: roll BUILD_TOOLS_SHA for macOS 15.5 SDK ( #47694 )
...
ci: roll BUILD_TOOLS_SHA for macOS 15.5 SDK
2025-07-14 13:11:07 -04:00
Shelley Vohr
a9504abde9
build: roll sysroots ( #47710 )
2025-07-14 11:27:19 -04:00
BILL SHEN
9f3636ffe2
build: add platform-specific conditions to the source_set in chromium_src ( #47627 )
...
* build: Add platform-specific if conditions to the source sets in chromium_src.
* build: Add platform-specific if conditions to the source sets in chromium_src.
2025-07-14 11:25:16 +02:00
Shelley Vohr
4a89068fb7
ci: add kTCCServiceAppleEvents perm override to fix AppleScript errors ( #47726 )
...
ci: add kTCCServiceAppleEvents perm override to fix AppleScript errors
2025-07-13 21:05:52 +02:00
John Kleinschmidt
137d4ec329
build: cleanup symlinks in cache ( #47727 )
...
* build: cleanup symlinks in cache
* build: ignore broken links
* try --ignore-failed-read
* build: dont deref symlinks
* build: add flag to 7zip to resolve symlink error
Needed to ignore Dangerous symbolic link path was ignored errors
* Revert "build: cleanup symlinks in cache"
This reverts commit 69e53cdc88 .
2025-07-11 16:13:12 -04:00
David Sanders
624d085632
build: deep update brace-expansion to resolve an audit alert ( #47692 )
2025-07-11 09:57:41 +02:00
Robo
600b6b3315
build: reenable v8_enable_temporal_support ( #47699 )
...
* build: reenable v8_enable_temporal_support
* ci: test with increased vm map count
* chore: backport PA use fewer vmas by default on linux
* chore: update patches
* Revert "ci: test with increased vm map count"
This reverts commit b626c9a5ab7ad3f01e17d77c330abfd8096a8b02.
* ci: remove logs
---------
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-11 02:49:54 +09:00
David Sanders
9e67bd3508
ci: update audit CI workflow dependencies ( #47691 )
...
* ci: update audit CI workflow dependencies
* ci: bump to @electron/fiddle-core@2.0.1
2025-07-10 19:19:36 +02:00
Shelley Vohr
909fd3d55a
ci: set git core.longpaths to true ( #47695 )
...
ci: set git core.longpaths to true
2025-07-10 19:13:39 +02:00
Niklas Wenzel
f2429c31c1
build: ask bug reporters to check if it is a Chromium issue ( #47702 )
...
* build: ask bug reporters to check if it is a Chromium issue
Inspiration: https://github.com/electron/electron/issues/47672#issuecomment-3051298922
* build: fix options
2025-07-10 08:47:04 -07:00
Shelley Vohr
fbb83be785
refactor: use dbus_thread_linux::GetSharedSessionBus() ( #47685 )
...
refactor: use dbus_thread_linux::GetSharedSessionBus()
2025-07-10 10:17:34 +02:00
Shelley Vohr
1eab19fc7c
build: remove unused script ( #47642 )
2025-07-09 10:35:04 -04:00
Shelley Vohr
02f2feabe6
docs: update build prerequisites ( #47680 )
2025-07-09 12:07:24 +02:00
David Sanders
712262597d
build: drop eslint-plugin-unicorn ( #47676 )
2025-07-08 15:20:56 +02:00
Shelley Vohr
31bc5ca903
fix: default to system accent color on invalid user color ( #47660 )
...
fix: default to system accent color on invalid user color"
2025-07-08 11:15:13 +02:00
Shelley Vohr
03a02fc31e
fix: fullscreen for windows without rounded corners ( #47664 )
2025-07-08 11:14:14 +02:00
Shelley Vohr
5ef6897bc7
fix: accent color should reflect system settings without restart ( #47629 )
...
fix: accentColor should reflect system settings without restart
2025-07-03 18:13:39 +02:00
Charles Kerr
bc585b6a3f
refactor: avoid a few unnecessary strings ( #47644 )
...
* perf: replace string temporary with string_view in GetXdgAppId()
* perf: replace string temporary with string_view in ToV8(WindowOpenDisposition)
* perf: replace string temporary with string_view in ToV8(electron::api::WebContents::Type)
2025-07-03 11:08:59 -05:00
David Sanders
4c460df0a4
ci: fix audit workflow alerting on stale results ( #47643 )
2025-07-03 14:42:04 +02:00
Shelley Vohr
cf193b279b
fix: crash on source capture with empty thumbnail size ( #47641 )
2025-07-03 14:41:19 +02:00
Shelley Vohr
655037fbdf
fix: window.open popups are always resizable ( #47540 )
...
fix: window.open popups are always resizable
Closes https://github.com/electron/electron/issues/43591 .
Per current WHATWG spec, the `window.open` API should always
create a resizable popup window. This change updates the
`parseFeaturesString` function to ensure that windows opened
with `window.open` are always resizable, regardless of the
`resizable` feature string.
2025-07-02 15:02:59 +02:00
Samuel Attard
07338bb1cf
build: update yarn to 1.22.22 ( #47635 )
2025-07-02 12:11:42 +02:00
reito
fb0b77b731
feat: add ColorSpace ( #47314 )
2025-07-02 00:09:09 -07:00
Keeley Hammond
499e987c77
build: set the minimum macOS SDK to 10.15 ( #47634 )
...
* build: set the minumum macOS SDK to 10.15
* build: revert "Update mac_sdk_min to match minimum required SDK version"
This reverts commit 3d4654fc18 .
2025-07-01 18:51:08 -07:00
Cas_
f7138344d8
docs: discoverability of chromium switches ( #44947 )
...
* docs: document discoverability of chromium switches
* docs: fixed typo
* docs: reference chromium endorsed list of swithes
* docs: reorder command-line-switches
* fix: address review
* fix: typo
* fix: wording
* Update command-line-switches.md
fix: lint space
* fix: Update docs/api/command-line-switches.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-07-01 14:31:49 -07:00
dependabot[bot]
b9248e6782
build(deps): bump github/codeql-action from 3.29.0 to 3.29.2 ( #47622 )
2025-07-01 11:12:15 +02:00
Shelley Vohr
af39dcfb09
refactor: use non-deprecated macOS API in RemoveAsDefaultProtocolClient ( #47506 )
...
refactor: use non-deprecated macOS API in RemoveAsDefaultProtocolClient
2025-07-01 10:19:28 +02:00
Samuel Attard
d347632046
build: write abi version to published npm package ( #47598 )
2025-06-30 15:01:09 -07:00
electron-roller[bot]
4f69c5835e
chore: bump chromium to 140.0.7261.0 (main) ( #47561 )
...
* chore: bump chromium in DEPS to 140.0.7259.0
* chore: update patches
* Add fade in animation to Picture-in-Picture windows
https://chromium-review.googlesource.com/c/chromium/src/+/6538268
* [v8] Use V8 Apis that don't return JSGlobalObject
Refs https://issues.chromium.org/issues/333672197
* chore: IWYU
* chore: bump chromium in DEPS to 140.0.7261.0
* chore: update patches
* revert: update to siso-chromium image
* [v8] Use v8::Object::WrapGlobal()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6650977
* chore: IWYU
* chore: fix --trace-startup spec
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-30 12:30:05 -04:00
Taiki Komoda
fa15332587
docs: update automated-testing.md ( #47017 )
...
* Update automated-testing.md
* fixed lint error
2025-06-30 10:56:48 +02:00
Shelley Vohr
e299a1d098
feat: support complete WebUSB device properties ( #47459 )
...
* feat: support complete WebUSB device properties
* docs: correct type consistency
2025-06-30 10:28:21 +02:00
Charles Kerr
c2302960a8
refactor: reduce scope of temporaries when getting dictionary values ( #47581 )
...
refactor: reduce scale of temporaries when getting dictionary values
2025-06-29 21:58:18 +02:00
Charles Kerr
5e862f398e
fix: Reland "[accessibility] Platform node lifetime cleanups" ( #47590 )
...
Reland "[accessibility] Platform node lifetime cleanups"
https://chromium-review.googlesource.com/c/chromium/src/+/6462552
2025-06-29 21:57:48 +02:00
Shelley Vohr
61c245761c
test: fix nan tests on macOS ( #47583 )
2025-06-29 21:57:44 +02:00
Charles Kerr
7c55b24be2
refactor: avoid copies of large objects in range based for loops ( #47588 )
...
* Avoid copies of large objects in range-based for-loops.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6527689
* Avoid copies of large objects in range-based for-loops in Browser::ShowAboutPanel()
2025-06-29 21:32:26 +02:00
Charles Kerr
4af248f2b6
perf: avoid copying a vector when calling ConvertToWeakPtrVector() ( #47593 )
2025-06-29 21:32:03 +02:00
Erick Zhao
69e9b653ba
docs: update example apps ( #47597 )
2025-06-29 21:31:42 +02:00
electron-roller[bot]
4dccccadbb
chore: bump node to v22.17.0 (main) ( #47557 )
...
* chore: bump node in DEPS to v22.17.0
* build: use //third_party/simdutf by default in GN
https://github.com/nodejs/node/pull/58115
* chore: adjust crypto specs:
- https://github.com/nodejs/node/pull/58117
- https://github.com/nodejs/node/pull/58387
* deps: update libuv to 1.51.0
https://github.com/nodejs/node/pull/58124
* test: fix test-buffer-tostring-range on allocation failure
https://github.com/nodejs/node/pull/58416
* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
https://github.com/nodejs/node/pull/58090
* build: use //third_party/simdutf by default in GN
https://github.com/nodejs/node/pull/58115
* inspector: add protocol method Network.dataReceived
https://github.com/nodejs/node/pull/58001
* test: force slow JSON.stringify path for overflow
https://github.com/nodejs/node/pull/58181
* chore: fixup patch indices
* 6049967: Remove protocol::Maybe and roll inspector_protocol
https://chromium-review.googlesource.com/c/chromium/src/+/6049967
* chore: fixup crypto test patch
* src: fix module buffer allocation
https://github.com/nodejs/node/pull/57738
* crypto: expose process.features.openssl_is_boringssl
https://github.com/nodejs/node/pull/58387
* util: add internal assignFunctionName() function
https://github.com/nodejs/node/pull/57916
* build: fix pointer compression builds
https://github.com/nodejs/node/pull/58171
* chore: put back config options
* fixup! deps: update libuv to 1.51.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-06-28 16:33:09 +02:00
Charles Kerr
79cd6a2614
refactor: sync IsKillURL() with upstream impl in extension_tab_util.cc ( #47580 )
...
Use base::MakeFixedFlatSet()
2025-06-27 15:49:41 -05:00
Charles Kerr
2ba8fe9140
refactor: extract-constant static Windows registry keys in Browser code ( #47569 )
...
* refactor: extract-constant for registry key in GetProcessExecPath()
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
* refactor: extract-constant for registry key in Browser::GetLoginItemSettings()
* chore: document the symbolic constants
* refactor: prefer base::wcstring_view::c_str() to data() to make zero-termination clearer
2025-06-27 10:34:55 -05:00
Charles Kerr
b21c4b0f88
refactor: make context bridge's private keys hidden, constexpr string_views ( #47562 )
...
* refactor: local functions GetPrivate(), SetPrivate() now take std::string_views
* refactor: make local keys std::string_views instead of C-style char arrays
* refactor: make local keys constexpr
* refactor: move local keys into local anonymous namespace
2025-06-27 09:29:53 -05:00
Charles Kerr
f50ad3d022
refactor: remove stray .c_str() calls for absl::StrFormat() ( #47548 )
...
refactor: remove stray .c_str() calls for absl::StrFormat()
StrFormat() understands std::string, std::string_view
2025-06-26 11:41:30 +02:00
Keeley Hammond
7a274a711c
fix: revert upstream MacOS mouse event routing ( #47560 )
...
* fix: revert upstream MacOS mouse event routing
* fix: reduce patch surface area
* chore: update patches
2025-06-26 11:41:11 +02:00
Niklas Wenzel
bc499ffb8a
docs: fix --experimental-network-inspection spelling ( #47565 )
...
doc: fix `--experimental-network-inspection` spelling
2025-06-26 11:40:55 +02:00
Niklas Wenzel
0a74e91580
docs: update asar integrity fuse availability ( #47528 )
2025-06-25 23:15:59 +02:00
electron-roller[bot]
035879357e
chore: bump chromium to 139.0.7256.0 (main) ( #47481 )
...
* chore: bump chromium in DEPS to 139.0.7242.0
* chore: update render_widget_host_view_mac.patch
no code changes; just updating patch context
Do a cleanup pass on the history swiper code | https://chromium-review.googlesource.com/c/chromium/src/+/6604367
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no code changes; just updating patch context
[tracing] Delete base/trace_event/base_tracing.h | https://chromium-review.googlesource.com/c/chromium/src/+/6624012
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
no manual changes; just updating patch context
[ActorFramework] Refactor Actor Task Management | https://chromium-review.googlesource.com/c/chromium/src/+/6618684
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
[pip] Tuck picture-in-picture windows when a file dialog is open | https://chromium-review.googlesource.com/c/chromium/src/+/6449682
Reland "[document pip] Restrict the size that a website can request" | https://chromium-review.googlesource.com/c/chromium/src/+/6372104
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
Xref: corner-shape: constraint radii based on opposite corner overlap | https://chromium-review.googlesource.com/c/chromium/src/+/6592572
* chore: update revert_code_health_clean_up_stale_macwebcontentsocclusion.patch
no manual changes; just updating patch context
* chore: update fix_rename_sqlite_win32_exports_to_avoid_conflicts_with_node_js.patch
no code changes; just updating patch context
* chore: e patches all
* Plumb Verify2QwacBinding and hook it up in QwacWebContentsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/6624719
* [Extensions] Remove host delegate OnMainFrameCreatedForBackgroundPage
https://chromium-review.googlesource.com/c/chromium/src/+/6631123
* Extensions: Rename GetResourceURL to ResolveExtensionURL
https://chromium-review.googlesource.com/c/chromium/src/+/6625053
* [NonClientFrameView] Consolidate NativeFrameViewMac
https://chromium-review.googlesource.com/c/chromium/src/+/6614239
* ICWYU
* [views-ax] Remove dead code WidgetAXTreeIDMap
https://chromium-review.googlesource.com/c/chromium/src/+/6619701
* Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS"
https://chromium-review.googlesource.com/c/chromium/src/+/6630056
* NavigationThrottleRunner2: Remove MaybeAddThrottle
https://chromium-review.googlesource.com/c/chromium/src/+/6628079
* [pip] Tuck picture-in-picture windows when a file dialog is open
https://chromium-review.googlesource.com/c/chromium/src/+/6449682
* build: fix snapshot_blob.bin build error
xref: https://issues.chromium.org/issues/416540976
* chore: e patches all
* build: freeup disk space on macos
* chore: bump chromium in DEPS to 139.0.7244.0
* chore: update printing.patch
no manual changes; just updating patch context
* chore: remove upstreamed ignore_parse_errors_for_resolveshortcutproperties.patch
Prevent Windows crash on unexpected shortcut type | https://chromium-review.googlesource.com/c/chromium/src/+/6633298
* chore: e patches all
* Revert "Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS""
This reverts commit 77c4f967a6 .
Revert CL for the high confidence crash culprit for http://crash/28f897bb9743dfe0 | https://chromium-review.googlesource.com/c/chromium/src/+/6641819
* Fix spec's expected base64-encoded PNG strings to match upstream changes.
[rust png] Enable by default. | https://chromium-review.googlesource.com/c/chromium/src/+/6085801
* chore: bump chromium in DEPS to 139.0.7246.0
* chore: e patches all
* chore: bump chromium in DEPS to 139.0.7248.0
* chore: update patches
* siso: Enable Siso by default for non-Google builds
https://chromium-review.googlesource.com/c/chromium/src/+/6638830
Disabling for now until we are ready to build siso on all platforms.
* Revert "revert Don't use static variable for UseExternalPopupMenus"
This reverts commit e91e3894e6 .
* Update mac_sdk_min to match minimum required SDK version
https://chromium-review.googlesource.com/c/chromium/src/+/6493969
(cherry picked from commit 3e7cbe912d )
* [video pip] Use default window styling on Mac
https://chromium-review.googlesource.com/c/chromium/src/+/6648665
* Reland "Force the unintentional renderer process creation check by default"
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* chore: bump chromium in DEPS to 139.0.7249.0
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* chore: update patches
* chore: bump chromium in DEPS to 139.0.7250.0
* chore: bump chromium in DEPS to 139.0.7252.0
* chore: bump chromium in DEPS to 139.0.7254.0
* 6638187: browser level TOCTOU check for coordinate target
https://chromium-review.googlesource.com/c/chromium/src/+/6638187
* chore: fixup patch indices
* chore: add missing base/notimplemented includes
* 6652910: [Frame Cleanup] Push down/hide implementation-specific API
https://chromium-review.googlesource.com/c/chromium/src/+/6652910
* chore: bump chromium in DEPS to 139.0.7256.0
* chore: fix lint
* fixup! 6652910: [Frame Cleanup] Push down/hide implementation-specific API
* fix: move HandleScope location
* chore: bump chromium in DEPS to 139.0.7258.0
* fixup! [NonClientFrameView] Consolidate NativeFrameViewMac
* Revert "chore: bump chromium in DEPS to 139.0.7258.0"
This reverts commit 264b2e934f .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-26 00:12:49 +09:00
Felix Rieseberg
e4c37e4b38
docs: Add C++/Linux tutorial ( #46822 )
2025-06-25 12:57:43 +02:00
Calvin
828fc84e60
build: update NMV to 139 ( #47529 )
2025-06-24 12:24:17 -04:00
Shelley Vohr
51fbc964a6
fix: ensure /dev/null fd is closed on failure ( #47525 )
...
* fix: ensure /dev/null fd is closed on failure
* chore: ignore closehandle for windows
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-06-24 17:44:50 +02:00
Shelley Vohr
3e8e87d186
feat: support customizing window accent color on Windows ( #47285 )
2025-06-24 14:43:02 +02:00
Samuel Attard
498f4bc98c
build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed ( #47401 )
...
* build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed
* again
(cherry picked from commit a21afc3e45 )
* use pr head ref
(cherry picked from commit 0edcc985fa )
2025-06-23 22:26:43 -07:00
Michaela Laurencin
a6ad5a6e60
docs: update timelines for E38 ( #47488 )
...
Update electron-timelines.md
2025-06-23 15:50:22 +02:00
Shelley Vohr
93d5152a25
fix: chrome://accessibility loading correctly ( #47497 )
...
fix: chrome://accessibility loading correctly
2025-06-23 14:38:29 +02:00
Shelley Vohr
fb65124234
chore: fix nightly issues getting unsupported label comment ( #47503 )
...
* chore: fix nightly issues getting unsupported label comment
* chore: address review feedback
2025-06-23 14:22:41 +02:00
dependabot[bot]
93f4b3cf9f
build(deps): bump github/codeql-action from 3.28.19 to 3.29.0 ( #47486 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.19 to 3.29.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fca7ace96b...ce28f5bb42 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-23 11:24:18 +02:00
Charles Kerr
bb22eaccec
refactor: simplify titlebar overlay initialization ( #47480 )
2025-06-23 11:24:05 +02:00
David Sanders
90a14299fd
ci: fix sending Slack message in CI audit workflow ( #47494 )
2025-06-23 11:23:39 +02:00
Shelley Vohr
60924690d9
build: combine dependent libc patch ( #47491 )
2025-06-23 11:22:35 +02:00
John Kleinschmidt
9b158238dc
build: update cache action to latest ( #47501 )
2025-06-23 11:22:14 +02:00
Samuel Attard
dac5e0cd1a
build: add siso backend.star ( #47509 )
2025-06-20 11:25:27 -07:00
Robo
626895848e
fix: utilityProcess running user script after process.exit is called ( #47469 )
...
* fix: utilityProcess running user script after process.exit is called
* docs: update breaking changes
* chore: update spec
* chore: update spec/api-utility-process-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: remove interface bound checks
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-18 04:36:22 +09:00
Keeley Hammond
3536d4976a
fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() ( #47482 )
...
Revert "refactor: move `IsClosed()` and `IsClosable()` tests into `NativeWindow::Close()` (#46888 )"
This reverts commit 3faddd5ae2 .
2025-06-16 16:41:19 -07:00
Shelley Vohr
2ad762e075
feat: support HIDDevice.collections ( #47391 )
...
* feat: support HIDDevice.collections
* Update docs/api/structures/hid-device.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
---------
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
2025-06-16 15:56:08 -04:00
electron-roller[bot]
6779769d22
chore: bump chromium to 139.0.7219.0 (main) ( #47348 )
...
* chore: bump chromium in DEPS to 139.0.7205.0
* 6543986: Mac: decouple deserializing and applying sandbox policy
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6543986
* 6580079: Reland 'Remove the third-party blocking feature'
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6580079
* 6505716: guest-contents: Add components/guest_contents
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6505716
* 6572556: Move LogMessageManager out of gpu_service_impl.cc.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6572556
* 6566111: Change UtilityProcessHost to manage its instance internally
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6550237: Rename ReconnectEventObserver to ConnectionChangeObserverClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6550237
* 6565918: Validate path is valid UTF8 in SelectFileDialogLinuxPortal
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6565918
* 6579713: Remove base::NotFatalUntil::M130 usage
6566111: Change UtilityProcessHost to manage its instance internally
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/6579713
https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* chore: update chromium patches
* chore: update remaining patches
* fixup! 6566111: Change UtilityProcessHost to manage its instance internally Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6577970: Remove superfluous includes for base/strings/stringprintf.h in headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6577970
* 6568811: Add FunctionCall structured metrics event for DevTools
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6568811
* [PDF Ink Signatures] Support PdfAnnotationsEnabled policy
https://chromium-review.googlesource.com/c/chromium/src/+/6558970
* build: disable libcxx modules for rbe
* chore: bump chromium in DEPS to 139.0.7217.0
* chore: bump chromium in DEPS to 139.0.7218.0
* chore: update patches
fix_use_delegated_generic_capturer_when_available.patch was updated to handle a small change:
6582142: Use content::Create*Capturer in DesktopCaptureDevice. | https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* 6594615: Change Chromium's deployment target to macOS 12
https://chromium-review.googlesource.com/c/chromium/src/+/6594615
Updated the assertion message to match the docs structure now too. I removed the callout to the supported versions doc because it has moved and doesn't contain minimum platform version information.
* 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_
https://chromium-review.googlesource.com/c/chromium/src/+/6606232
|NativeWindow::GetContentMinimumSize| and |NativeWindow::GetContentMaximumSize| may be good opportunities for a refactor now.
* add squirrel.mac patch for removed function
This was triggered by the macOS 12.0 deployment upgrade change.
See: https://developer.apple.com/documentation/coreservices/1444079-uttypeconformsto?language=objc
* 6582142: Use content::Create*Capturer in DesktopCaptureDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* 6579732: Two minor API "quality of life" cleanups in OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/6579732
* chore: add include for base::SingleThreadTaskRunner
Not sure what change caused this, I expect it would be a removed include somewhere else, but it's likely not important to track down.
* chore: update libcxx filenames
* chore: update CI build-tools commit target for macOS SDK 15.4
The following change uses an API that was added in the macOS 15.4 SDK. Support for that SDK version was added later than the current build-tools commit target.
6575804: Use a quick-and-dirty solution to avoid glitching with paste-and-go | https://chromium-review.googlesource.com/c/chromium/src/+/6575804
See: https://developer.apple.com/documentation/appkit/nspasteboard/accessbehavior-swift.enum?language=objc
* fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ https://chromium-review.googlesource.com/c/chromium/src/+/6606232
* chore: bump chromium in DEPS to 139.0.7220.0
* chore: update patches
Minor changes due to:
6613978: pwa: let events fall through in the transparent area of TopContainerView | https://chromium-review.googlesource.com/c/chromium/src/+/6613978
6614778: Refactor auto pip tab observer for Android support | https://chromium-review.googlesource.com/c/chromium/src/+/6614778
* 6543986: Mac: decouple deserializing and applying sandbox policy
https://chromium-review.googlesource.com/c/chromium/src/+/6543986
The DecodeVarInt and DecodeString functions look benign from a MAS perspective. I suspect they were patched out to avoid "unused function" errors. Their complements for encoding are unpatched, supporting this idea.
The code that uses these functions was refactored out of the section that we patch out. Instead of patching out that new function, I decided to treat it the same as the serialization function that is unpatched.
* chore: bump chromium in DEPS to 139.0.7222.0
* chore: bump chromium in DEPS to 139.0.7224.0
* chore: bump chromium in DEPS to 139.0.7226.0
* chore: bump chromium in DEPS to 139.0.7228.0
* chore: update patches
* Don't use static variable for UseExternalPopupMenus
https://chromium-review.googlesource.com/c/chromium/src/+/6534657
* Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59
https://chromium-review.googlesource.com/c/chromium/src/+/6607589
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* revert Don't use static variable for UseExternalPopupMenus
* tls: remove deprecated tls.createSecurePair and SecurePair
https://github.com/nodejs/node/pull/57361
* Revert "Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59"
This reverts commit 33e1436a0c .
* test: cleanup api-desktop-capturer-spec.ts
* test: more cleanup of api-desktop-capturer-spec.ts
* chore: debug dcheck error in webrtc on linux
* fixup patch
* add debugging to desktop capturer spec
* test: fixup api-desktop-capturer-spec.ts for linux
* chore: remove debugging patch
* Revert "fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ https://chromium-review.googlesource.com/c/chromium/src/+/6606232 "
This reverts commit 32e75651c1 .
* Revert "6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_"
This reverts commit 89c51aa1c7 .
* [views] Remove DesktopWindowTreeHostWin::window_enlargement_
https://chromium-review.googlesource.com/c/chromium/src/+/6606232
Reverting as we need this functionality for now.
* fixup: remove patch that was accidentally added back
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-06-16 12:46:06 -05:00
Shelley Vohr
96fcc2f8c8
chore: exempt upgrade-follow-up issues from stale ( #47460 )
...
chore: exempt upgrade-follow-upissues from stale
2025-06-14 21:43:57 -07:00
Charles Kerr
3c9b8475a2
refactor: move gin::Converter<PreloadScript> impl to a .cc file ( #47445 )
...
refactor: move gin::Converter<PreloadScript> impl to a .cc file
2025-06-13 10:15:32 +02:00
Charles Kerr
6f915e85e2
refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> ( #47428 )
...
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
2025-06-12 12:25:40 +02:00
Anny Yang
0259abe920
docs: update remaining references to electron-quick-start ( #47405 )
...
* chore: udpate remaining references to electron-quick-start
* chore: Update docs/tutorial/tutorial-1-prerequisites.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: Update docs/tutorial/tutorial-3-preload.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: Update docs/tutorial/tutorial-2-first-app.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: linebreak
* chore: swap minimal-repro for npx create-electron-app
* chore: add back code commands
* chore: add whitespace
* chore: remove reference to repo containing old quick start
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-06-12 10:32:17 +02:00
Shelley Vohr
38fe14041d
fix: crash calling Fetch.continueResponse with WebContentsView ( #47434 )
...
fix: crash calling Fetch.continueResponse with WebContentsView
2025-06-11 15:43:47 +02:00
dependabot[bot]
996945d3e3
build(deps): bump github/codeql-action from 3.28.18 to 3.28.19 ( #47426 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.18 to 3.28.19.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff0a06e83c...fca7ace96b )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.19
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-11 11:24:03 +02:00
Niklas Wenzel
d7ef8b79ae
docs: mention kwallet6 command line option ( #47427 )
2025-06-10 16:12:31 -04:00
Erick Zhao
6aa3665b96
docs: no class inheritance ( #47403 )
2025-06-10 10:00:06 +02:00
Robo
c964296ec3
feat: add support for --no-experimental-global-navigator ( #47370 )
...
chore: add support for --no-experimental-global-navigator
2025-06-09 14:57:27 +09:00
David Sanders
6f48e3ab12
ci: fix up branch CI audit workflow ( #47404 )
2025-06-07 09:58:48 +02:00
Shelley Vohr
06bc59be88
fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation ( #47361 )
...
* fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-06-07 08:00:30 +02:00
David Sanders
0b84c68229
ci: ignore network-related error annotations in audit ( #47333 )
...
* ci: ignore network-related error annotation in audit
* chore: add another error message
2025-06-06 16:52:25 -04:00
Shelley Vohr
09a0926c5b
fix: printing PDF via webContents.print() ( #47377 )
...
fix: printing PDF via webContents.print()
2025-06-06 14:20:37 -04:00
Shelley Vohr
6606230813
fix: silent printing of PDFs with webContents.print ( #47378 )
...
fix: silent printing
2025-06-06 14:19:08 -04:00
David Sanders
a42afaa866
chore: fix docs lint ( #47389 )
2025-06-06 10:01:26 +02:00
John Kleinschmidt
b1f0ab11c5
build: cache gitcache dir ( #47328 )
...
* revert build: migrate to new chromium git auth
* build: cache gitcache dir
2025-06-05 17:00:21 -04:00
David Sanders
4c3e2eb560
build(deps-dev): bump husky and lint-staged ( #47291 )
2025-06-05 20:23:55 +02:00
Niklas Wenzel
72340e79e8
docs: remove electron-quick-start from README ( #47359 )
...
Refs https://github.com/electron/.permissions/pull/293
The repo was renamed to `minimal-repro` and is no longer intended to be used as a way to start new projects (see PR above).
Since we really want bugs in `electron/electron` to be reported with a Fiddle gist instead of a standalone repo (makes reproducing and bisecting sooo much easier and safer!), I removed the repo from the README completely instead of mentioning as an issue reproduction starting point.
2025-06-05 20:12:21 +02:00
Niklas Wenzel
7196a28d3a
docs: mention Azure Trusted Signing ( #47323 )
2025-06-05 19:13:39 +02:00
Shelley Vohr
6c96979b6c
chore: remove unused spec-chromium ( #47367 )
...
chore: remove unused spec-chromium
2025-06-05 15:50:19 +02:00
Felix Rieseberg
5cbab906c9
docs: Add Swift/macOS tutorial ( #46697 )
...
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2025-06-05 15:45:04 +02:00
Erick Zhao
2a51a997eb
docs: update link to runAsNode fuse ( #47350 )
2025-06-05 10:03:58 +02:00
Shelley Vohr
fbb3fa7503
feat: allow intercepting mouse events ( #47280 )
...
* feat: allow intercepting mouse events
* test: add specs
* Update spec/api-web-contents-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-04 14:10:33 +02:00
Shelley Vohr
c22f94037a
docs: document possible print failureReasons ( #47337 )
...
docs: document possible print failureReasons
2025-06-04 14:09:24 +02:00
John Kleinschmidt
ba7c3bbdf7
chore: update patches ( #47346 )
2025-06-03 13:52:17 -04:00
electron-roller[bot]
53fd879043
chore: bump chromium to 138.0.7190.0 (main) ( #47107 )
...
* chore: bump chromium in DEPS to 138.0.7180.0
* 6546797: Add a metric for the overall success of the "safe storage" item retrieval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6546797
* 6548078: extensions: Fix TODO in ScriptInjectionTracker for desktop Android
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6548078
* 6544950: Revert "FSA: Only normalize the hardcoded rules once during initialization"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6544950
* chore: bump chromium in DEPS to 138.0.7181.0
* chore: update patches
* fix: correctly clamp HSL shift values between 0 and 1
* chore: bump DEPS to 138.0.7183.0
* 6553142: Remove SelectFileDialogLinuxKde | https://chromium-review.googlesource.com/c/chromium/src/+/6553142
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7184.0
* chore: bump chromium in DEPS to 138.0.7186.0
* chore: bump chromium in DEPS to 138.0.7190.0
* chore: update patches
* 6547778: Remove some superfluous //ui/gfx includes from //chrome headers | https://chromium-review.googlesource.com/c/chromium/src/+/6547778
* 6556022 : Reland FSA: Only normalize the hardcoded rules once during initialization | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: remove pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/4099130
This was removed 2 years ago in Chrome.
* fix: provide BrowserContext to pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/6558173
* fixup! 6556022 : Reland FSA: Only normalize the hardcoded rules once during initialization | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: pass in navigation throttle registry
https://chromium-review.googlesource.com/c/chromium/src/+/6536175
* fixup! 6556022 : Reland "FSA: Only normalize the hardcoded rules once during initialization" | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
This partially reverts commit 20d709dd15ba0ff332e24ee314149d642dc5d47c.
* 6545984: corner-shape: render dashed & dotted borders
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6545984
* Update corner smoothing expected images
* Apply "future" revert commit to fix windows build
> Reason for revert: Multiple eng reporting that this is causing build failures due to too-long pathnames, with no immediate feasible workaround
This issue also affects our CI builds.
Problematic CL in current roll: 6494836: [webgl] Add stub WebGL[2]RenderingContextWebGPU | https://chromium-review.googlesource.com/c/chromium/src/+/6494836
"Future" revert CL: 6565622: Revert "[webgl] Add stub WebGL[2]RenderingContextWebGPU" | https://chromium-review.googlesource.com/c/chromium/src/+/6565622
This patch should automatically disappear when we roll the revert.
* 6533919: win: don't add WS_CAPTION style to popup windows
https://chromium-review.googlesource.com/c/chromium/src/+/6533919
This mirrors the change made earlier to the code ours is based on: 6374074: [headless] Provide headless aware window metrics on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-06-03 11:19:20 -04:00
Shelley Vohr
5f5e8d012d
fix: add back fallback wasm-trap handling ( #47186 )
...
* fix: add back fallback wasm-trap handling
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5372409
This change sets up wasm-trap handling for the case where content_shell
has not enabled crash reporting but moves the responsibility to
ElectronRendererClient. The default ContentRendererClient assumes
that crash reporting is enabled (crashpad enabled by default) and does
not set up its own handler.
* chore: fix build
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-03 15:31:23 +02:00
Calvin
508c601996
fix: do not load source for electron module in ESM loader synchronous flow ( #46810 )
2025-06-03 12:50:17 +02:00
Sta Zhu
158176f0f3
fix: addChildView() crashes when adding a closed WebContentsView ( #47099 )
...
fix: addChildView() crashes when add a closed WebContentsView
2025-06-03 10:53:25 +02:00
dependabot[bot]
d1e64c37a2
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 ( #47329 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](f49aabe0b5...05b42c6244 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-version: 2.4.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-03 10:18:03 +02:00
Shelley Vohr
17ba863f69
docs: correct 'select-bluetooth-device' requirement ( #47325 )
2025-06-03 10:16:16 +02:00
electron-roller[bot]
82a59d9894
chore: bump node to v22.16.0 (main) ( #47217 )
...
* chore: bump node in DEPS to v22.16.0
* crypto: remove BoringSSL dh-primes addition
https://github.com/nodejs/node/pull/57023
* tools: enable linter in test/fixtures/test\-runner/output
https://github.com/nodejs/node/pull/57698
* src: improve thread safety of TaskQueue
https://github.com/nodejs/node/pull/57910
* buffer: define global v8::CFunction objects as const
https://github.com/nodejs/node/pull/57676
* src: disable abseil deadlock detection
https://github.com/nodejs/node/pull/57582
* zlib: fix pointer alignment
https://github.com/nodejs/node/pull/57727
* chore: fixup patch indices
* src: set default config as node.config.json
https://github.com/nodejs/node/pull/57171
* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
https://github.com/nodejs/node/pull/57578
* test: disable chmod tests failing in Docker
https://github.com/nodejs/node/issues/58326
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-06-02 17:30:15 -04:00
David Sanders
55006fe9a8
ci: change patches stats DataDog metric type to gauge ( #47319 )
2025-06-02 14:49:44 -04:00
zeeker999
dc5efca0f6
feat: [net] add "priority" option to net.request ( #42628 )
...
document the default value of priority option
Update the priority test to not use the httpbin.org as server
Fixed the lint errors
Fixed the build error
2025-05-30 15:28:13 -04:00
David Sanders
cf6c662702
ci: upload stats about patches to DataDog ( #47206 )
2025-05-30 11:14:57 -04:00
Shelley Vohr
c84e8c6c22
feat: expose win.isContentProtected() ( #47242 )
...
* feat: expose win.isContentProtected()
* chore: remove stray _isContentProtected
2025-05-30 11:00:13 +02:00
John Kleinschmidt
46921d3652
docs: document commit signing requirement ( #47290 )
2025-05-30 10:59:29 +02:00
David Sanders
b303413a04
build: drop shx dependency ( #47293 )
2025-05-30 10:59:11 +02:00
David Sanders
83524adf17
chore: fix lint for ImageView doc ( #47304 )
2025-05-29 17:10:41 -04:00
David Sanders
14b3183eb5
ci: add a problem matcher for ESLint output ( #47303 )
2025-05-29 16:58:17 -04:00
David Sanders
0d70389ccb
chore: lint code blocks in docs with ESLint ( #42113 )
2025-05-29 12:45:26 -07:00
Niklas Wenzel
4e61f5b26f
fix: Squirrel.Mac crash when zip extraction fails ( #47271 )
...
* fix: Squirrel.Mac crash when zip extraction process fails to launch
* chore: add end-to-end test
2025-05-29 10:31:46 -07:00
Will Anderson
5b5f900e34
docs: add documentation for ImageView ( #46760 )
...
* docs: Add documentation for ImageView
* docs: Add ImageView main process module list in README.md
* test: Add some basic tests for ImageView
* test: Fill out Window embedding tests to better reflect how someone might use an ImageView
* docs: Add notes about using ImageView as a splash screen
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: Update ImageView example to show a more complete splash screen example
* docs: Remove view resizing logic since the ImageView automatically gets resized
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-29 10:24:16 -07:00
David Sanders
2e0b4eca94
build: remove unnecessary eslint-plugin-standard package ( #47283 )
2025-05-28 13:58:14 +02:00
David Sanders
3a32f25750
ci: audit important branches for CI errors ( #47207 )
...
* ci: audit important branches for CI errors
* chore: move message to Slack workflow
2025-05-27 11:35:33 -04:00
Erick Zhao
f6b8ee0731
chore: add .eslintrc.json for docs/fiddles ( #47269 )
2025-05-27 09:13:10 -05:00
Robo
5ccbfa2faf
fix: regression with directory selection in macOS dialogs ( #47259 )
2025-05-27 19:08:11 +09:00
Shelley Vohr
f89c2a0ef4
fix: titlebar showing in content protected window ( #47241 )
...
Closes https://github.com/electron/electron/issues/47152 .
2025-05-26 09:46:04 +02:00
Shelley Vohr
c6f368acc6
chore: debug crash on DevTools SetOwnerWindow ( #47243 )
2025-05-26 09:45:43 +02:00
David Sanders
5e3b5ef04c
chore: update @electron/lint-roller to 3.1.1 ( #47202 )
...
* chore: update @electron/lint-roller to 3.1.1
* docs: fix broken link in breaking-changes.md
* chore: fix for Node.js versions without require(esm)
2025-05-25 07:58:55 -05:00
John Kleinschmidt
ac5e3c76f3
build: migrate to new chromium git auth ( #47230 )
2025-05-25 07:57:20 -05:00
Gellert Hegyi
b9b96a96f7
feat: add menu item role palette and header ( #45538 )
...
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-05-23 12:43:49 -04:00
Charles Kerr
2248de847d
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop() ( #47201 )
...
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop()
2025-05-22 18:20:39 -05:00
Charles Kerr
38e7ff944e
refactor: make NativeWindow::has_frame_ const ( #47200 )
...
* refactor: make NativeWindow::is_modal_ const
* refactor: make NativeWindow::title_bar_style_ const and private
* refactor: make NativeWindow::has_client_frame() protected
refactor: make NativeWindow::transparent() protected
* refactor: make NativeWindow::enable_larger_than_screen() protected
* refactor: make NativeWindow::has_frame_ const
* fixup! refactor: make NativeWindow::has_client_frame() protected
fix: GetExpandedWindowSize()
2025-05-22 17:32:46 -05:00
David Sanders
8f09d7037b
ci: add problem matcher for patch conflict output ( #47183 )
2025-05-22 09:27:23 -04:00
David Sanders
d0102ff392
ci: add problem matcher for clang output ( #46577 )
2025-05-22 09:25:57 -04:00
Keeley Hammond
274e1df1ca
build: revert bump @octokit/rest from 20.1.1 to 21.1.1 ( #47208 )
...
Revert "build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 (#47159 )"
This reverts commit 517f5c15b9 .
2025-05-21 18:39:24 -07:00
John Kleinschmidt
b2d0074cc6
build: fix depot tool pathing on Windows ( #47194 )
...
build: properly set depot_tools pathing for Windows
2025-05-21 16:05:50 -07:00
Charles Kerr
2e8fc17f07
refactor: pass views::Widget* into constructors of our TreeHosts and NativeWidgets ( #47177 )
...
* refactor: remove unnecessary downcast in MenuViews::PopupAt()
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostLinux ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopNativeWidgetAura ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostWin ctor
* refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
* fixup! refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
fix: tyop
2025-05-21 16:02:55 -05:00
Charles Kerr
4af0c5d762
refactor: make NativeWindow::transparent_ const ( #47172 )
...
* refactor: use in-class member initialization for NativeWindow::widget_
* refactor: make NativeWindow::transparent_ const
refactor: make NativeWindow::enable_larger_than_screen_ const
* chore: make linter happy after rebase
2025-05-21 19:42:08 +02:00
Charles Kerr
a7a3e10300
refactor: prefer base::circular_deque over std::deque ( #47171 )
...
* refactor: use base::circular_deque in ResolveProxyHelper
* refactor: use base::circular_deque in GetExtraCrashKeys()
refactor: reduce visibility of kMaxCrashKeyValueSize
This change is to match Chromium's usage advice from
base/containers/README.md: `base:circular_deque` is preferred over
`std::deque` to provide consistent performance across platforms.
2025-05-21 12:04:36 -05:00
Shelley Vohr
7b77a24211
fix: remove extra 'suspend'/'resume' handling from powerMonitor ( #47162 )
...
fix: remove extra 'suspend'/'resume' handling from powerMonitor
2025-05-21 10:00:38 -05:00
David Sanders
7112c592c9
test: strip color output in ESM spec ( #47185 )
2025-05-21 10:50:06 +02:00
Charles Kerr
d6638f9564
refactor: make NativeWindow::pending_transitions_ a base::queue ( #47157 )
...
refactor: make NativeWindow::pending_transitions a base::queue
Follow the base/containers/README.md advice that "Chromium code should
always use `base::circular_deque` or `base::queue` in preference to
`std::deque` or `std::queue` due to memory usage and platform variation."
2025-05-20 17:35:51 -05:00
Charles Kerr
9f8bcc4d98
refactor: make NativeWindow::has_client_frame_ const ( #47156 )
2025-05-20 17:14:28 -05:00
Charles Kerr
21155679a0
refactor: add NativeWindowViews::GetClientFrameViewLinux() ( #47130 )
...
* refactor: add NativeWindowViews::GetClientFrameViewLinux()
* chore: clarify code comment
2025-05-20 14:15:06 -05:00
Charles Kerr
211faed848
refactor: add NativeWindow::IsActive() ( #47148 )
...
this was already present on macOS; use in NativeWindowViews too
2025-05-20 11:08:44 -04:00
Shelley Vohr
296e39456a
refactor: match upstream macOS a11y handling ( #47144 )
2025-05-20 11:06:57 -04:00
John Kleinschmidt
a19198d784
build: update_depot_tools on initial install ( #47160 )
...
this ensures that python is setup for proper use from depot_tools
2025-05-20 10:40:48 -04:00
reito
263c76df09
fix: prevent gc monitor 2nd pass crash ( #46987 )
2025-05-20 22:54:03 +09:00
dependabot[bot]
517f5c15b9
build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 ( #47159 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.1 to 21.1.1.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.1...v21.1.1 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 21.1.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-20 09:57:30 +02:00
dependabot[bot]
d29293556d
build(deps): bump github/codeql-action from 3.28.15 to 3.28.18 ( #47158 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.15 to 3.28.18.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](45775bd823...ff0a06e83c )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.18
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-20 09:56:54 +02:00
Shelley Vohr
e0ea069859
build: remove fix_linter_error.patch ( #47150 )
...
build: remove fix_linter_error.patch
2025-05-19 22:52:01 +02:00
electron-roller[bot]
7cc76c094a
chore: bump node to v22.15.1 (main) ( #47105 )
...
* chore: bump node in DEPS to v22.15.1
* chore: fixup patch indices
* src: fix error handling on async crypto operations
https://github.com/nodejs-private/node-private/pull/709
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-19 16:12:48 -04:00
Charles Kerr
3660432f42
refactor: NativeWindows should prefer widget() over GetWidget() for internal use ( #47133 )
2025-05-19 21:43:16 +02:00
Charles Kerr
687e50b4f3
refactor: add NativeWindowViews::SetTitleBarOverlay() ( #47126 )
...
* refactor: move SetTitleBarOverlay() impl to NativeWindowViews
* refactor: make NativeWindowViews::set_overlay_button_color() private
refactor: make NativeWindowViews::set_overlay_symbol_color() private
refactor: make NativeWindow::set_titlebar_overlay_height() protected
* refactor: simplify downcasting in NativeWindowViews::SetTitleBarOverlay()
2025-05-19 08:19:03 -05:00
David Sanders
d426667a01
build(dev-deps): update @electron/lint-roller and markdownlint-cli2 ( #47082 )
2025-05-19 14:19:04 +02:00
Charles Kerr
208bbc0504
refactor: add NativeWindow::SetShape() ( #47131 )
...
use NativeWindow::SetShape() in api::BaseWindow
2025-05-19 10:29:29 +02:00
dependabot[bot]
e2f496cfbc
build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.7.0 to 8.32.1 ( #47135 )
...
build(deps-dev): bump @typescript-eslint/eslint-plugin
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 8.7.0 to 8.32.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.32.1/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-version: 8.32.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-19 10:27:22 +02:00
Charles Kerr
1da150f9a3
chore: remove gclient sync macOS CI hack patch ( #47123 )
...
chore: remove hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch
2025-05-19 10:26:58 +02:00
Calvin
5dd6481e53
fix: explicit microtask scope DCHECK condition ( #47134 )
2025-05-19 12:08:59 +09:00
dependabot[bot]
d72e622a3f
build(deps): bump slackapi/slack-github-action from 2.0.0 to 2.1.0 ( #47060 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](485a9d42d3...b0fa283ad8 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-version: 2.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 12:55:00 -05:00
Charles Kerr
8efd24c339
perf: don't create unused menuitem icons ( #47100 )
...
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
2025-05-16 02:43:03 -05:00
Erick Zhao
dc34e8732c
docs: add note on DIP and DPI ( #47080 )
2025-05-15 16:51:49 -05:00
Charles Kerr
77c58658c5
refactor: decouple NativeWindowViews and GlobalMenuBarX11 ( #47094 )
...
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
2025-05-15 16:10:56 -05:00
Charles Kerr
d720aea700
refactor: make TrackableObject::weak_map_id() constexpr ( #47092 )
...
* refactor: make TrackableObject::weak_map_id() constexpr
refactor: make BaseWindow::GetID() inline and constexpr
* refactor: make NativeWindow::window_id() constexpr too
2025-05-15 16:10:33 -05:00
Charles Kerr
e2bcd8f0aa
test: fix desktopCapturer mocha syntax ( #47088 )
...
* test: fix desktopCapturer mocha syntax
do not nest `it` calls in desktopCapturer specs
* empty commit
2025-05-15 16:54:49 -04:00
Robo
99a3e360ec
fix: opening package paths as directory on macOS ( #47077 )
2025-05-15 12:47:46 -05:00
electron-roller[bot]
883f48b9b4
chore: bump chromium to 138.0.7178.0 (main) ( #47086 )
...
* chore: bump chromium in DEPS to 138.0.7178.0
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* chore: update patches
* 6509682: extensions: Use ChromeExtensionsBrowserClient on desktop Android, part 2
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6509682
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-15 12:47:07 -05:00
Charles Kerr
9a7b73b533
refactor: use kKeyModifiers in IsAltModifier() ( #47066 )
...
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
2025-05-14 11:00:00 -04:00
Charles Kerr
6170a5af40
chore: combine all the "patch out Profiles" changes into a single patch ( #47063 )
...
* chore: fold the profile patches into one patch
* chore: e patches all
* chore: patch out ProfileSelections::ApplyProfileSelection()
Another profile reference. Referenced iff making a debug build.
2025-05-14 09:21:11 -05:00
electron-roller[bot]
d65a856bf3
chore: bump chromium to 138.0.7177.0 (main) ( #47081 )
...
* chore: bump chromium in DEPS to 138.0.7177.0
* 6530423: [WebContents] Fix IsNeverComposited() calls during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6530423
* 6512551: [ios] Enable -Wobjc-property-assign-on-object-type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512551
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-14 10:08:31 -04:00
Shelley Vohr
f2639d13cc
refactor: remove CreateViewForWidget patch ( #46981 )
...
* refactor: remove CreateViewForWidget patch
* chore: rm unintended osr change
* Trigger CI
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-14 21:43:23 +09:00
Charles Kerr
11fa915724
refactor: remove introduce_ozoneplatform_electron_can_call_x11_property.patch ( #47075 )
...
* refactor: use x11_util::IsX11() in BuildSubmenuFromModel()
* refactor: use x11_util::IsX11() in ElectronDesktopWindowTreeHostLinux::OnBoundsChanged()
* refactor: use skia_can_fall_back_to_x11 in x11_util::IsX11()
it is identical in practice to electron_can_call_x11 and does not require a Chromium patch
* chore: remove introduce_ozoneplatform_electron_can_call_x11_property.patch
* refactor: use ui::GetOzonePlatformId() to test for x11
2025-05-14 13:38:35 +09:00
David Sanders
9aacc473e6
build: remove patch that landed upstream ( #47079 )
2025-05-13 20:10:48 -05:00
Charles Kerr
c218128675
chore: remove disable_unload_metrics.patch ( #47059 )
2025-05-13 14:55:59 -04:00
electron-roller[bot]
e3e647d21e
chore: bump chromium to 138.0.7175.0 (main) ( #46986 )
...
* chore: bump chromium in DEPS to 138.0.7166.0
* chore: bump chromium in DEPS to 138.0.7166.2
* 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* 6470924: Introduce auto-populated Search Engine icons.
https://chromium-review.googlesource.com/c/chromium/src/+/6470924
* 6502977: Force same tab navigation while actor coordinator is acting on a tab
https://chromium-review.googlesource.com/c/chromium/src/+/6502977
* chore: bump chromium in DEPS to 138.0.7168.0
* chore: update patches
* fix grit patch
* chore: bump Chromium to 138.0.7169.2
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
* 6493688: NavigationThrottleRunner2: void CreateThrottlesForNavigation
https://chromium-review.googlesource.com/c/chromium/src/+/6493688
* 6488755: Reland "WebSQL: Remove WebPreference"
https://chromium-review.googlesource.com/c/chromium/src/+/6488755
* 6428707: FSA: Only normalize the hardcoded rules once during initialization
https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* chore: fixup patch indices
* chore: bump chromium in DEPS to 138.0.7170.0
* 6514121: Remove origin calculation debug info and related methods
https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* chore: bump chromium in DEPS to 138.0.7172.0
* chore: bump chromium in DEPS to 138.0.7173.0
* chore: bump chromium in DEPS to 138.0.7175.0
* fixup! 6514121: Remove origin calculation debug info and related methods
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* 6531585: Don't retry LayerTreeSink creation on the high priority queue
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6531585
* 6512253: Modernize base::apple's base bundle ID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512253
* fixup! 6428707: FSA: Only normalize the hardcoded rules once during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-13 14:51:20 -04:00
Shelley Vohr
7ab032f594
fix: white window flicker on window creation ( #47022 )
2025-05-10 18:24:35 -05:00
Erick Zhao
2493e530d0
docs: unify [!NOTE] structure ( #46893 )
...
* docs: unify [!NOTE] structure
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/browser-window.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/download-item.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/global-shortcut.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* revert line break
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-09 14:36:42 -07:00
Michaela Laurencin
10e4f9ad37
feat: enable secondary label for macOS menu ( #46887 )
...
* feat: enable secondary label for macOS menu
* Update shell/browser/ui/cocoa/electron_menu_controller.mm
Co-authored-by: Robo <hop2deep@gmail.com >
* fix for lint
* update docs for sublabel
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-05-09 12:05:26 -04:00
Michaela Laurencin
b9f0aebb2f
feat: enable innerWidth and innerHeight for window open ( #46749 )
...
* feat: enable innerWidth and innerHeight for window open
* update comment for added special innerWidth and innerHeight
* update 100 min spec requirement handling
* update testing to include getContentSize
* update macOS min requirement handling
* adjust refactored consts
* update const values from nativewindowviews
2025-05-09 12:03:45 -04:00
Shelley Vohr
8ecd731e96
fix: webview crash on focus ( #46979 )
2025-05-09 17:56:22 +02:00
Shelley Vohr
75cf8ea96d
fix: restore previous Windows screenshotting ( #47020 )
...
Fixes https://github.com/electron/electron/issues/45990
We previously made a change in https://github.com/electron/electron/pull/45868
to fix content protection being lost on hide and re-show. However, this
cause a breaking change where protected windows were made opaque black
instead of being hidden as before. This overrides relevant methods in
ElectronDesktopWindowTreeHostWin to restore the previous behavior.
without regressing the original issue.
2025-05-09 09:38:27 -05:00
Aman Karmani
376634c75a
feat: add support for --experimental-network-inspection ( #46690 )
...
* feat: add support for `--experimental-network-inspection`
* docs: fix minor formatting issues
visible on both GH[1] and the docs site[2]
[1] https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags
[2] https://www.electronjs.org/docs/latest/api/command-line-switches#--inspect-brkhostport
* docs: add entry for new nodejs flag
2025-05-09 09:44:14 -04:00
Robo
8e8d3a4f3e
fix: use-after-move of bus connection in xdg portal detection ( #47008 )
2025-05-09 18:32:08 +09:00
Charles Kerr
2cbd968da5
refactor: use gin_helper::Dictionary::ValueOrDefault() ( #46982 )
...
* refactor: use ValueOrDefault() in electron_api_web_contents.cc
* refactor: use ValueOrDefault() in electron_api_url_loader.cc
* refactor: use ValueOrDefault() in electron_download_manager_delegate.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in electron_url_loader_factory.cc
* refactor: use ValueOrDefault() in electron_browser_context.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in blink_converter.cc
* feat: add ValueOrDefault() to PersistentDictionary
* empty commit
* refactor: use ValueOrDefault() in blink_converter.cc
* refactor: inline the rectangle base::Value::Dict
* refactor: remove has_scroll temporary
---------
Co-authored-by: Deepak Mohan <hop2deep@gmail.com >
2025-05-08 14:17:22 -05:00
Keeley Hammond
aea7b4ae8c
build: update hasher return value ( #47009 )
2025-05-08 11:34:21 -07:00
Charles Kerr
9f8a629126
refactor: reduce use of NativeWidgetPrivate ( #46942 )
...
* refactor: do not use native_widget_private() in NativeWindowViews::SetContentProtection()
refactor: do not use native_widget_private() in NativeWindowViews::IsContentProtected()
* refactor: do not use native_widget_private() in NativeWindowViews::Show()
* chore: remove native_widget_private #include from native_window_views_win
Not needed since Feb 2025: 9199d5c6
2025-05-08 09:02:19 -05:00
Charles Kerr
d4ca829069
test: enable hasShadow tests on Linux ( #46984 )
...
refactor: enable hasShadow tests on Linux
2025-05-08 10:07:10 +02:00
Charles Kerr
54a6bbb4cb
build: remove skip_atk_toolchain_check.patch ( #46988 )
...
chore: remove skip_atk_toolchain_check.patch
2025-05-08 10:06:55 +02:00
Charles Kerr
24f1f7ed57
build: remove deps_add_v8_object_setinternalfieldfornodecore.patch ( #46992 )
...
chore: remove deps_add_v8_object_setinternalfieldfornodecore.patch
This was a Node 20-specific workaround that's no longer needed in Node 22.
Xref: https://github.com/nodejs/node/pull/49874 .
2025-05-08 09:39:58 +02:00
Keeley Hammond
153dae5b48
build: move release script to new hasher function ( #46989 )
...
build: move to new hasher function
2025-05-08 01:15:08 -05:00
Calvin
580fa57a29
refactor: Node.js temporary "explicit" microtask policy scope pattern ( #46973 )
...
refactor: Node.js explicit microtask scope pattern
2025-05-08 10:21:39 +09:00
Calvin
37639b5400
refactor: replace gin_helper::MicrotasksScope with v8::MicrotasksScope ( #46963 )
...
* Remove microtasks_scope.h and microtasks_scope.cc
* Use v8::MicrotasksScope when ignoring browser checkpoint
These call always skip the browser checkpoint, so they are equivalent to using v8::MicrotasksScope directly (modulo the optional wrapper behavior).
* Remove MicrotasksScope from node_bindings.cc
This code seems contradictory: it explicitly specifies "do not run microtasks" yet runs a microtask checkpoint in the browser process.
Looking at its history, it [was introduced][1] with the intention to not run microtasks, but a [subtle C++ language behavior][2] caused it to do the opposite later in the same roll. Since the original intention was to not run microtasks, and since that is also the simplest explanation, we can assume `ignore_browser_checkpoint` should be true and migrate this to `v8::MicrotasksScope` as it is equivalent (modulo the optional wrapper behavior).
[1]: a4ea80dd47 (diff-efe58cf03c97028f37f801db044d396a5f428686da6595d2c692f1c052bbd09c)
[2]: https://github.com/electron/electron/pull/43185
* Migrate gin_helper/promise.h and gin_helper/promise.cc to v8::MicrotasksScope
Restores the [original][1] behavior of running the microtask checkpoint at destruction, but preserves the behavior of running microtasks in the browser process. This had last changed in the migration to gin_helper::MicroTasks.
[1]: https://github.com/electron/electron/pull/16401
2025-05-07 14:10:34 -05:00
electron-roller[bot]
a8695d4387
chore: bump chromium to 138.0.7166.0 (main) ( #46975 )
...
* chore: bump chromium in DEPS to 138.0.7165.0
* 6492127: Add new less invasive context menu mode for mobile interesttarget
https://chromium-review.googlesource.com/c/chromium/src/+/6492127
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-07 13:04:15 -04:00
Charles Kerr
924a8da940
refactor: use WidgetDelegate::SetAccessibleTitle() ( #46765 )
...
* refactor: use WidgetDelegate::SetAccessibleTitle()
* test: add window.accessibleTitle tests
2025-05-07 10:44:53 -05:00
Shelley Vohr
c16ea8d54e
fix: printing when no mediaSize specified ( #46937 )
...
fix: printing when no mediaSize specified
2025-05-06 19:12:25 -05:00
Charles Kerr
b7ae162716
refactor: add gin_helper::Dictionary::ValueOrDefault() ( #46939 )
...
* feat: add gin_helper::Dictionary::ValueOrDefault()
A convenience function for using a default value if the
specified key isn't present in the dictionary.
* refactor: use ValueOrDefault() in native_window.cc
* refactor: use ValueOrDefault() in native_window_mac.mm
* refactor: use ValueOrDefault() in native_window_views.cc
* refactor: use ValueOrDefault() in electron_api_native_image.cc
2025-05-06 15:20:12 -05:00
Shelley Vohr
e876cecbc7
test: test menu rendering accelerators ( #44634 )
...
* test: test menu rendering accelerators
* Update spec/api-menu-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-06 14:09:35 -04:00
electron-roller[bot]
c4ac192aa4
chore: bump chromium to 138.0.7164.0 (main) ( #46948 )
...
* chore: bump chromium in DEPS to 138.0.7164.0
* 6508870: Add missing PermissionType mapping and remove default case.
https://chromium-review.googlesource.com/c/chromium/src/+/6508870
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-06 14:01:37 -04:00
Charles Kerr
8308ac29c8
refactor: pass gfx::ResizeEdge by value ( #46935 )
...
refactor: pass gfx::ResizeEdge by value
It is an enum class, so no reason to pass by reference
2025-05-06 11:57:53 -05:00
Shelley Vohr
206544cbc0
fix: crash on macOS dialog after window-all-closed ( #46927 )
...
fix: crash on dialog after window-all-closed
2025-05-06 07:47:50 -05:00
Shelley Vohr
a5ec3f7476
fix: allowed dialog file types with one filter ( #46900 )
2025-05-06 10:31:00 +02:00
Erick Zhao
be399f2fee
docs: use correct heading level for API function ( #46892 )
2025-05-05 16:10:37 -05:00
electron-roller[bot]
b90de7d07e
chore: bump chromium to 138.0.7160.0 (main) ( #46915 )
...
* chore: bump chromium in DEPS to 138.0.7158.0
* chore: bump chromium in DEPS to 138.0.7160.0
* 6509206: Move Keychain UI suppression code into apple_keychain.cc
https://chromium-review.googlesource.com/c/chromium/src/+/6509206
* 6489036: Fix DesktopDataControlsDialog for Glic
https://chromium-review.googlesource.com/c/chromium/src/+/6489036
* chore: fixup patch indices
* 6506662: Reland "NavigationThrottleRunner2: content::NavigationThrottleRegistry"
https://chromium-review.googlesource.com/c/chromium/src/+/6506662
* 6499811: [video pip] Add live caption dialog
https://chromium-review.googlesource.com/c/chromium/src/+/6499811
* 6487926: Add GetMaxImageDimension function to ScreenAI service API for OCR.
https://chromium-review.googlesource.com/c/chromium/src/+/6487926
* 6494942: [json] Activate stringify fast-path by default
https://chromium-review.googlesource.com/c/v8/v8/+/6494942
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-05 13:58:40 -04:00
Charles Kerr
9460300506
refactor: devirtualize NativeWindow methods ( #46904 )
...
* refactor: devirtualize NativeWindow::SetSize()
refactor: devirtualize NativeWindow::GetSize()
refactor: devirtualize NativeWindow::SetPosition()
refactor: devirtualize NativeWindow::GetPosition()
* refactor: devirtualize NativeWinodw::SetMinimumSize()
refactor: devirtualize NativeWinodw::GetMinimumSize()
refactor: devirtualize NativeWinodw::SetMaximumSize()
refactor: devirtualize NativeWinodw::GetMaximumSize()
* refactor: devirtualize NativeWindow::SetSheetOffset()
refactor: devirtualize NativeWindow::GetSheetOffsetX()
refactor: devirtualize NativeWindow::GetSheetOffsetY()
* refactor: devirtualize NativeWindow::GetContentMinimumSize()
refactor: devirtualize NativeWindow::GetContentMaximumSize()
2025-05-05 09:29:05 -05:00
Charles Kerr
3362db0655
refactor: remove some NativeWindow public API ( #46919 )
...
* refactor: make NativeWindow::titlebar_overlay_height_ private
* refactor: make NativeWindow::set_has_frame() protected
* refactor: remove NativeWindow::background_material()
It's only used once, in NativeWindow, so use |background_material_| directly.
* refactor: remove NativeWindow::vibrancy()
It's only used once, in a NativeWindow method, so use |vibrancy_| directly.
* refactor: unfriend api::BrowserView
It was added in Oct 2022 by 23d4a25 for access to protected NativeWindow
methods add_inspectable_view() and remove_inspectable_view().
That dependency was removed in Nov 2022 by 184ac2b , so BrowserView
doesn't need access to NativeWindow's private fields & methods anymore.
* refactor: make NativeWindow::ContentBoundsToWindowBounds() protected
refactor: make NativeWindow::WindowBoundsToContentBounds() protected
2025-05-05 09:28:49 -05:00
Charles Kerr
2e2776611f
refactor: simplify NativeWindow::FullScreenTransitionState ( #46918 )
...
* refactor: make NativeWindow::fullscreen_transition_state_ private
* refactor: add NativeWindow::is_transitioning_fullscreen() helper
* refactor: remove unused NativeWindow::fullscreen_transition_state()
* refactor: replace NativeWindow::set_fullscreen_transition_state() with NativeWindow::set_is_transitioning_fullscreen()
refactor: remove unused NativeWindow::FullScreenTransitionState
2025-05-05 09:28:29 -05:00
Charles Kerr
1f4f1b4afc
refactor: add NativeWindow::FromWidget() helper ( #46917 )
...
refactor: add NativeWindow::FromWidet() helper
refactor: make kElectronNativeWindowKey a protected field
2025-05-05 09:27:41 -05:00
electron-roller[bot]
cb445b3bbd
chore: bump node to v22.15.0 (main) ( #46742 )
...
* chore: bump node in DEPS to v22.15.0
* inspector: fix GN build
https://github.com/nodejs/node/pull/56798
* test: search cctest files
https://github.com/nodejs/node/pull/56791
* crypto: fix missing OPENSSL_NO_ENGINE guard
https://github.com/nodejs/node/pull/57012
* test,crypto: make tests work for BoringSSL
https://github.com/nodejs/node/pull/57021
* module: use synchronous hooks for preparsing in import(cjs)
https://github.com/nodejs/node/pull/55698
* deps: update simdjson to 3.12.0
https://github.com/nodejs/node/pull/56874
* build: remove explicit linker call to libm on macOS
https://github.com/nodejs/node/pull/56901
* test: make eval snapshot comparison more flexible
https://github.com/nodejs/node/pull/57020
* src: allow embedder customization of OOMErrorHandler
https://github.com/nodejs/node/pull/57325
* src: do not pass nullptr to std::string ctor
https://github.com/nodejs/node/pull/57354
* src: lock the isolate properly in IsolateData destructor
https://github.com/nodejs/node/pull/57031
* chore: shrink --trace-atomics-wait patch
* chore: fixup patch indices
* build: fix GN build failure
https://github.com/nodejs/node/pull/57013
* crypto: expose security levels
https://github.com/nodejs/node/pull/56601
* zlib: add zstd support
https://github.com/nodejs/node/pull/52100
* test: move crypto related common utilities in common/crypto
https://github.com/nodejs/node/pull/56714
* cli: move --trace-atomics-wait to eol
https://github.com/nodejs/node/pull/52747
* test: disable test-https-client-renegotiation-limit
BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-05 10:23:17 +02:00
Robo
91626a8eac
fix: xdg portal version detection for file dialogs on linux ( #46905 )
...
* chore: use dbus thread for portal version detection
* Update shell/browser/ui/file_dialog_linux_portal.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-05-05 16:57:20 +09:00
electron-roller[bot]
5390728cb7
chore: bump chromium to 138.0.7156.0 (main) ( #46902 )
...
* chore: bump chromium in DEPS to 138.0.7156.0
* chore: update patches
* chore: ICWYU
* Allow SecKeychain and SecItem implementations of AppleKeychain to coexist
https://chromium-review.googlesource.com/c/chromium/src/+/6444777
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-02 21:06:50 -04:00
Derek Cicerone
074b9344b5
fix: prevent log files being written to current directory on Windows ( #44413 )
...
* fix: prevent log files being written to current directory on Windows
* Update shell/common/logging.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* chore: add test
* chore: update includes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6418805
* chore: address review feedback
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-05-02 16:27:29 -05:00
Charles Kerr
3faddd5ae2
refactor: move IsClosed() and IsClosable() tests into NativeWindow::Close() ( #46888 )
...
refactor: devirtualize NativeWindow::IsClosed()
2025-05-02 13:21:29 -05:00
Yuri
7153008bfa
docs: clarified usage of createFromPath() ( #46809 )
...
* docs: clarified usage of createFromPath()
* Update docs/api/native-image.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-02 11:11:54 +02:00
Charles Kerr
f6b297a06a
refactor: use base::ObserverList::Notify() ( #46875 )
...
* refactor: use ObserverList::Notify() in shell/browser/window_list.cc
* refactor: use ObserverList::Notify() in shell/browser/web_contents_zoom_controller.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/usb_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/electron_usb_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/views/menu_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/tray_icon.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/electron_menu_model.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/serial_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/native_window.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/electron_serial_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/browser.cc
* refactor: use ObserverList::Notify() in shell/browser/api/electron_api_web_contents.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/electron_hid_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/hid_chooser_context.cc
2025-05-02 11:10:52 +02:00
Shelley Vohr
ede84fc327
feat: support dip <-> screen conversion on Linux X11 ( #46211 )
...
feat: support dip <-> screen conversion on Linux
2025-05-02 10:31:45 +02:00
electron-roller[bot]
2b07e6450c
chore: bump chromium to 138.0.7154.0 (main) ( #46872 )
...
* chore: bump chromium in DEPS to 138.0.7152.0
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7154.0
* chore: update patches
* ozone/wayland: Fix bookmark dropdown right click context menu
https://chromium-review.googlesource.com/c/chromium/src/+/6488801
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* [A11yPerformance] Remove Add/Remove AXMode methods
https://chromium-review.googlesource.com/c/chromium/src/+/6418444
xref: https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* build: update filenames.libcxx.gni
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* Use getters to expose NativePixmapHandle from GpuMemoryBufferHandle
https://chromium-review.googlesource.com/c/chromium/src/+/6374406
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-01 23:53:40 -05:00
Keeley Hammond
63114e2b8e
fix: revert macOS content protection logic refactor ( #46886 )
...
Revert "refactor: use upstream content protection logic on macOS (#46813 )"
This reverts commit 34adb976b6 .
2025-05-01 13:49:55 -07:00
Charles Kerr
df4564dc39
refactor: don't call deprecated WidgetDelegate API in NativeWindowViews ( #46858 )
...
* refactor: don't call RegisterDeleteDelegateCallback()
move NativeWindowViews' on-widget-delegate-destroyed callback logic to
the NativeWindowViews destructor.
Since NativeWindowViews subclasses from WidgetDelegate and |this| *is*
the delegate being destroyed, we can handle this more cleanly in
~NativeWindowViews() instead of in a separate callback.
* chore: remove NativeWindowViews from the grandfathered-classes-that-can-call-deprecated-views-behavior patch
* refactor: don't call RegisterDeleteDelegateCallback()
RegisterDeleteDelegateCallback() is private upstream API, so we
shouldn't be using it.
Move the on-widget-delegate-destroyed callback logic over to our methods
NativeWindowViews::OnWidgetDestroying() and
NativeWindowViews::OnWidgetDestroyed().
2025-05-01 12:07:20 -05:00
David Sanders
4f89c31956
refactor: add EmitDeprecationWarning helper ( #46860 )
...
* refactor: add EmitDeprecationWarning helper
Also switches EmitWarning to using Node's ProcessEmitWarningGeneric
* chore: use node namespace for function call
2025-04-30 13:48:35 -05:00
Charles Kerr
25d77fd1ce
refactor: use WidgetDelegate's title property ( #46849 )
...
* refactor: use WidgetDelegate::SetTitle()
* Make NativeWindow::SetTitle() and NativeWindow::GetTitle() non-virtual.
Use WidgetDelegate for their implementation.
* Add NativeWindow::OnTitleChanged(), a new protected virtual method to update
subclasses (e.g. NativeWindowMac needs to redraw the button proxy).
* In NativeWindowMac, replace SetTitle() and GetTitle() with OnTitleChanged().
* In NativeWindowViews, replace SetTitle() and GetTitle() with OnTitleChanged().
* test: enable BrowserWindow.title tests on Linux
* test: add a test to confirm win.title changes when document.title is set in the renderer
2025-04-30 08:22:27 -07:00
electron-roller[bot]
d842d17ff3
chore: bump chromium to 137.0.7151.0 (main) ( #46854 )
...
* chore: bump chromium in DEPS to 137.0.7151.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-04-29 16:49:44 -04:00
dependabot[bot]
ecd745305e
build(deps): bump actions/download-artifact from 4.2.1 to 4.3.0 ( #46852 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](95815c38cf...d3f86a106a )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 4.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-29 11:20:23 -04:00
Charles Kerr
2734088d20
fix: fix and enable accessibilitySupportEnabled tests ( #46825 )
...
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* test: enable accessibilitySupportEnabled tests
test: check both getters after calling each setter
fix: do not assume the default initial value of accessibilitySupportEnabled
* chore: remove redundant test case
* chore: disable accessibilitySupportEnabled tests on Linux
2025-04-28 23:52:26 -05:00
zoy
4641bc9619
fix: fullscreen fillet / recovery is incorrect ( #46641 )
...
* fix: fullscreen fillet / recovery is incorrect
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
* fix: maintain frameless consistency on windows 11
* fix: maintain frameless consistency on windows 11
* chore: modify the comments
---------
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
2025-04-28 16:54:08 -04:00
Charles Kerr
3f3c297c7a
fix: enable some tests that were accidentally disabled ( #46816 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* chore: make the process.platform test simpler
* fix: tests that were not run in api-app-spec due to nested it()
* fix: tests that were not run in api-browser-window-spec due to nested it()
* chore: annotate disabled test
* fix: enable `autoHideMenuBar` tests on Linux and Windows (#46818 )
* fix: enable autoHideMenuBar tests
* docs: mark autoHideMenuBar as supported on Linux, Windows
2025-04-28 12:32:57 -05:00
Bruno Pitrus
062d3a6168
fix: build error with enable_electron_extensions=false ( #46812 )
...
Fix build error with enable_electron_extensions=false
In file included from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.h:13,
from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr.h:50,
from ../../base/memory/raw_ptr.h:11,
from ../../base/memory/weak_ptr.h:82,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:14,
from ../../electron/shell/browser/usb/electron_usb_delegate.cc:5:
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:279:3: warning: multi-line comment [-Wcomment]
279 | // \
| ^
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:281:3: warning: multi-line comment [-Wcomment]
281 | // \
| ^
In file included from /usr/include/c++/14/memory:78,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:8:
/usr/include/c++/14/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = device::mojom::UsbDeviceInfo]’:
/usr/include/c++/14/bits/unique_ptr.h:399:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = device::mojom::UsbDeviceInfo; _Dp = std::default_delete<device::mojom::UsbDeviceInfo>]’
399 | get_deleter()(std::move(__ptr));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../../mojo/public/cpp/bindings/struct_ptr.h:48:3: required from ‘constexpr void std::destroy_at(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
48 | ~StructPtr() = default;
| ^
/usr/include/c++/14/bits/stl_construct.h:149:22: required from ‘constexpr void std::_Destroy(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
149 | std::destroy_at(__pointer);
| ~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:163:19: required from ‘static constexpr void std::_Destroy_aux<<anonymous> >::__destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; bool <anonymous> = false]’
163 | std::_Destroy(std::__addressof(*__first));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:193:44: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*]’
193 | return std::_Destroy_aux<false>::__destroy(__first, __last);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/alloc_traits.h:981:20: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator, allocator<_T2>&) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
981 | std::_Destroy(__first, __last);
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_vector.h:735:15: required from ‘constexpr std::vector<_Tp, _Alloc>::~vector() [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>; _Alloc = std::allocator<mojo::StructPtr<device::mojom::UsbDeviceInfo> >]’
735 | std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
736 | _M_get_Tp_allocator());
| ~~~~~~~~~~~~~~~~~~~~~~
../../electron/shell/browser/usb/electron_usb_delegate.cc:231:74: required from here
231 | std::move(callback).Run(std::vector<device::mojom::UsbDeviceInfoPtr>());
| ^
/usr/include/c++/14/bits/unique_ptr.h:91:23: error: invalid application of ‘sizeof’ to incomplete type ‘device::mojom::UsbDeviceInfo’
91 | static_assert(sizeof(_Tp)>0,
| ^~~~~~~~~~~
2025-04-28 11:56:17 -04:00
electron-roller[bot]
f2240e07f0
chore: bump chromium to 137.0.7149.0 (main) ( #46777 )
...
* chore: bump chromium in DEPS to 137.0.7144.0
* chore: bump chromium in DEPS to 137.0.7145.0
* chore: bump chromium in DEPS to 137.0.7147.0
* chore: update patches
* Remove deprecated GetVar(std::string_view, std::string*) overload
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6468873
* fixup! Remove deprecated GetVar(std::string_view, std::string*) overload
* fixup! Remove deprecated GetVar(std::string_view, std::string*) overload
* chore: bump chromium in DEPS to 137.0.7149.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-28 11:39:12 -04:00
David Sanders
0c103f390c
test: refactor deprecate-helpers.ts to warning-helpers.ts ( #46808 )
...
Add a generic expectWarningMessages and start checking warning names
2025-04-28 11:18:34 -04:00
Charles Kerr
27f6adf8df
fix: run visibleOnAllWorkspaces tests on the right platforms ( #46815 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* chore: make the process.platform test simpler
2025-04-28 10:34:00 -04:00
Shelley Vohr
b03c71213e
refactor: use upstream content protection logic on macOS ( #46780 )
...
* refactor: use upstream content protection logic on macOS
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-26 11:31:30 -05:00
Charles Kerr
c2ab63f6d7
refactor: use absl::InlinedVector in ToV8(ElectronPermissionManager) ( #44854 )
...
perf: use a stack-allocated string_view array in ToV8(USBProtectedClasses)
2025-04-25 16:11:15 -05:00
Calvin
b92c68b053
docs: call out breaking change for GTK 4 default on GNOME ( #46793 )
...
docs: add breaking change for GTK 4 default on GNOME
2025-04-25 13:31:28 -07:00
Charles Kerr
450b2d0ba3
refactor: remove public method BrowserWindow::GetWeakPtr() ( #46763 )
...
refactor: remove public method electron::api::BrowserWindow::GetWeakPtr()
2025-04-25 15:01:52 -05:00
Charles Kerr
b40b4dc015
refactor: use std::map::try_emplace() over std::map::insert() ( #46761 )
...
refactor: prefer std::map::try_emplace() over std::map::insert()
2025-04-25 13:11:53 -05:00
Evan Simkowitz
8fa7d324d1
fix: set XDG_CURRENT_DESKTOP env var back to original value before invoking xdg utils ( #45310 )
...
* Fix XDG_CURRENT_DESKTOP before invoking XDGUtil
* apply suggestion
* use existing XDG_CURRENT_DESKTOP const
2025-04-25 11:31:36 -05:00
Felix Rieseberg
7fa297a849
docs: Add ObjC/macOS tutorial ( #46694 )
2025-04-25 10:29:25 -05:00
John Kleinschmidt
55505ba4df
docs: additional update of breaking changes for 36-x-y ( #46781 )
2025-04-25 11:28:33 -04:00
Shelley Vohr
372cdb5dee
fix: bluetooth crash in select-bluetooth-device event ( #46745 )
...
fix: bluetooth crash on bluetooth off
2025-04-25 10:26:19 -05:00
Calvin
973e5d0249
build: update NMV to 136 for Electron 37 ( #46764 )
...
build: update NMV to 136 for Electron 36
2025-04-25 11:20:29 -04:00
Michaela Laurencin
0171f648b1
docs: correct breaking-changes.md for 36.0.0 release ( #46762 )
2025-04-25 16:10:35 +02:00
Charles Kerr
74c4ae0b55
refactor: use net::CanonicalCookie::IsDomainMatch() ( #46748 )
...
* refactor: use net::CanonicalCookie::IsDomainMatch()
Previously we had been rolling our own impl
* test: add pattern-matching tests for our cookie API
2025-04-25 16:08:16 +02:00
Charles Kerr
06a99d6770
refactor: make node Buffers more friendly to base::span / std::span ( #46724 )
...
* refactor: add electron::Buffer namespace; move the Buffer as_byte_span() into it
* feat: add electron::Buffer::Copy()
a span-friendly version of node::Buffer::Copy()
* refactor: use electron::Buffer::Copy() in electron_api_base_window.cc
* refactor: use electron::Buffer::Copy() in electron_api_data_pipe_holder.cc
* refactor: use electron::Buffer::Copy() in electron_api_safe_storage.cc
* refactor: use electron::Buffer::Copy() in electron_api_clipboard.cc
* refactor: use electron::Buffer::Copy() in osr_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_native_image.cc
* refactor: use electron::Buffer::Copy() in net_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_web_contents.cc
* refactor: make NewEmptyBuffer() return a Local<Value>
2025-04-25 08:00:09 -05:00
Shelley Vohr
1976e935e7
fix: missing HandleScope in RemoveFromParentChildWindows ( #46758 )
2025-04-25 14:04:25 +02:00
Calvin
51dbe69e45
fix: vibrancy window border ( #46648 )
...
* fix: vibrancy window border
* Use WidgetDelegate::OnWidgetInitialized instead
2025-04-25 11:42:48 +02:00
Calvin
08318dc05d
fix: corner smoothing with 0 radii ( #46751 )
2025-04-25 10:54:04 +02:00
wujinli
3e78bbde6a
fix: crash when renderer process crashes while webview is reloading ( #46735 )
...
WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
and triggers a fatal NOTREACHED.
2025-04-25 10:10:27 +02:00
electron-roller[bot]
37f8db15e9
chore: bump chromium to 137.0.7143.0 (main) ( #46757 )
...
* chore: bump chromium in DEPS to 137.0.7142.0
* chore: bump chromium in DEPS to 137.0.7143.0
* Add accelerator API to get shortcut vector representation
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6442193
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-25 14:53:51 +09:00
electron-roller[bot]
08b7a1f801
chore: bump chromium to 137.0.7141.0 (main) ( #46725 )
...
* chore: bump chromium in DEPS to 137.0.7139.0
* chore: bump chromium in DEPS to 137.0.7141.0
* chore: update patches
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6474596
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6443472
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6471184
* [ServiceWorker] Pipe is_for_service_worker into OverrideURLLoaderFactoryParams
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6459481
* Reland "[PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6455975
* clickiness: Check attestation and user settings on origins
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6356796
* extensions : Move ReloadExtension from ExtensionService
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6472812
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6472777
* fixup! Update AppleKeychain API to be friendlier
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6443472
* chore: script/gen-libc++-filenames.js
* Rename ColorVariant::CovertToSkColor() to ColorVariant::ResolveToSkColor()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6373793
* [headless] Provide headless aware window metrics on Windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-24 17:18:38 +09:00
Charles Kerr
e9f279afd1
chore: remove WebContents.getNativeView() ( #46734 )
...
chore: remove never-used WebContents.getNativeView().
This was added in https://github.com/electron/electron/pull/10308 but
was never used and never documented, not even as experimental API.
2025-04-23 20:33:50 -05:00
Charles Kerr
c7b0bdab7e
fix: explicitly call GetNativeNSView() on macOS ( #46733 )
...
* fix: explicitly call GetNativeNSView() on macOS
* chore: move macOS impl to a .mm file
This is needed in order to access gfx::NativeView::GetNativeNSView()
2025-04-23 17:55:18 -05:00
Charles Kerr
686ae47696
refactor: remove redundant NativeImage::GetBitmap() ( #46696 )
...
* refactor: remove redundant NativeImage::GetBitmap()
* docs: mark NativeImage.getBitmap() as deprecated
* have getBitmap() emit a deprecation warning
* docs: update obsolete refefence to getBitmap()
* test: update obsolete refefences to getBitmap()
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-04-23 11:00:43 +02:00
electron-roller[bot]
dd03cceda0
chore: bump chromium to 137.0.7128.1 (main) ( #46482 )
...
* chore: bump chromium in DEPS to 137.0.7107.0
* chore: bump chromium in DEPS to 137.0.7109.0
* chore: bump chromium in DEPS to 137.0.7111.0
* chore: bump chromium in DEPS to 137.0.7113.0
* 6384240: Remove double-declaration for accessibility on macOS | https://chromium-review.googlesource.com/c/chromium/src/+/6384240
* 6422872: Remove unused includes in isolation_info_mojom_traits.h | https://chromium-review.googlesource.com/c/chromium/src/+/6422872
* chore: update patches
* 6400733: Avoid ipc_message_macros.h usage in some foo_param_traits_macros.h files | https://chromium-review.googlesource.com/c/chromium/src/+/6400733
* chore: update patches
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: iwyu
* refactor: prefer value initialization over memset()
From the looks up upstream commits in base/, it looks like memset()
could trigger `-Wunsafe-buffer-usage` warnings soon?
Value initialization is more C++ish and less error-prone anyway,
due to memset()'s easily swappable parameters.
* refactor: NotifyIcon::InitIconData() returns a NOTIFYICONDATA
This follows F.20 in the C++ Core Guidelines and also removes the need
for memset()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- strcmp()
* fixup! 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* 6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: bump chromium in DEPS to 137.0.7115.0
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: update patches
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* fix: add pragma for MacSDK unsafe buffers | 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: bump chromium in DEPS to 137.0.7117.0
* chore: update patches
* chore: update filesnames.libcxx.gni
* 6431756: Replace SetOwnedByWidget() bool arg with a PassKey. | https://chromium-review.googlesource.com/c/chromium/src/+/6431756
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* 6428345: Remove ExtensionService usage from ChromeExtensionRegistrarDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/6428345
* 6384315: Migrate extensions_enabled from ExtensionService to Registrar | https://chromium-review.googlesource.com/c/chromium/src/+/6384315
* 6428749: [extensions] Refactor ExtensionService for AddNewAndUpdateExtension. | https://chromium-review.googlesource.com/c/chromium/src/+/6428749
* chore: bump chromium in DEPS to 137.0.7119.0
* 6440290: corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* 6429230: FSA: Move blocked paths to the PermissionContext class | https://chromium-review.googlesource.com/c/chromium/src/+/6429230
* chore: update patches
* chore: bump chromium in DEPS to 137.0.7121.0
* chore: update patches
* fix: partially revert 6443473: Remove ItemDelete from the Mac version of AppleKeychain | https://chromium-review.googlesource.com/c/chromium/src/+/6443473
* fix: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 137.0.7123.0
* chore: update patches
* chore: "grandfather in" electron views too
Lock further access to View::set_owned_by_client() | https://chromium-review.googlesource.com/c/chromium/src/+/6448510
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* refactor: grandfather in AutofillPopupView as a subclass of WidgetDelegateView
Add a PassKey for std::make_unique<WidgetDelegateView>() | https://chromium-review.googlesource.com/c/chromium/src/+/6442265
* Provide dbus appmenu information on Wayland | https://chromium-review.googlesource.com/c/chromium/src/+/6405535
* [extensions] Move OnExtensionInstalled out of ExtensionService. | https://chromium-review.googlesource.com/c/chromium/src/+/6443325
* refactor: grandfather in NativeWindowViews for delete callbacks
6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: merge the four "grandfather" patches into one
* [A11yPerformance] Remove IsAccessibilityAllowed() | 6404386: [A11yPerformance] Remove IsAccessibilityAllowed() | https://chromium-review.googlesource.com/c/chromium/src/+/6404386
NB: the changes here are copied from the upstream changes in
chrome/browser/ui/webui/accessibility/accessibility_ui.cc
* 6420753: [PermissionOptions] Use PermissionDescriptorPtr in PermissionController | https://chromium-review.googlesource.com/c/chromium/src/+/6420753
* 6429573: [accessibility] Move mode change out of AccessibilityNotificationWaiter | https://chromium-review.googlesource.com/c/chromium/src/+/6429573
* chore: e patches all
* 6419936: [win] Change ScreenWin public static methods to virtual | https://chromium-review.googlesource.com/c/chromium/src/+/6419936
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- fprintf()
- fputs()
- snprintf()
- vsnprintf()
* fix: size conversion FTBFS on Win
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcscpy_s()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcsncpy_s()
* chore: update mas_avoid_private_macos_api_usage.patch.patch
6394283: Remove double-declaration for accessibility on iOS | https://chromium-review.googlesource.com/c/chromium/src/+/6394283
Lots of context shear in this commit but the only interesting part is:
-+ return nullptr;
++ return {};
Which is needed because the return type is sometimes not a pointer.
* chore: e patches all
* chore: disable -Wmacro-redefined warning in electron_main_win.cc
* chore: bump chromium in DEPS to 137.0.7123.5
* refactor: patch electron PermissionTypes into blink
6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: e patches all
* chore: remove the box_painter_base.cc part of feat_corner_smoothing_css_rule_and_blink_painting.patch
as per code review @ https://github.com/electron/electron/pull/46482#pullrequestreview-2777338370
* test: enable window-smaller-than-64x64 test on Linux
* chore: bump chromium in DEPS to 137.0.7124.1
* chore: bump chromium in DEPS to 137.0.7125.1
* chore: bump chromium in DEPS to 137.0.7127.3
* 6459201: [Extensions] Remove ExtensionSystem::FinishDelayedInstallationIfReady() | https://chromium-review.googlesource.com/c/chromium/src/+/6459201
* 6454796: [Extensions] Move (most) registrar delayed install logic to //extensions | https://chromium-review.googlesource.com/c/chromium/src/+/6454796
* chore: bump chromium in DEPS to 137.0.7128.1
* chore: e patches all
* chore: node ./script/gen-libc++-filenames.js
* [views] Gate DesktopWindowTreeHostWin::window_enlargement_ behind flag
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428649
* feat: allow opt-out animated_content_sampler.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6438681
* Trigger CI
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-04-22 15:53:29 -04:00
Kolja
d0e13cc262
fix: file dialog filters not working correctly ( #46660 )
2025-04-22 13:31:04 +02:00
Shelley Vohr
858a93f886
build: don't kill ssh sessions on checkout failure ( #46708 )
2025-04-22 13:30:27 +02:00
Michaela Laurencin
e383eaa465
fix: stop menu minimization if set false ( #46279 )
2025-04-22 10:58:30 +02:00
Milan Burda
274b148554
docs: cleanup docs/tutorial/custom-window-styles.md ( #46597 )
2025-04-22 10:23:35 +02:00
Charles Kerr
7083419361
refactor: make electron::api::BaseWindow fields private ( #46689 )
...
refactor: make electron::api::BaseWindow fields private
2025-04-22 10:19:11 +02:00
reito
ac2c0c76fe
fix: osr stutter fix backport for electron. ( #46650 )
...
* fix: osr stutter fix backport for electron.
* nit: chromium upstream patch link
2025-04-22 10:18:21 +02:00
Michaela Laurencin
3ad87787f8
docs: update timelines for E37 ( #46704 )
2025-04-21 13:34:02 -07:00
Robo
ec8f7f185e
fix: crash on reconversion with google IME and editcontext on macOS ( #46688 )
2025-04-21 09:49:14 +09:00
Calvin
f15fa56e38
refactor: reduce & remove no-op MicrotasksScope calls ( #46681 )
...
* fix: do not run microtasks in V8Serializer in browser process
* Remove no-op MicrotasksScope in `shell/browser/api/electron_api_auto_updater.cc`
This call was added in https://github.com/electron/electron/pull/40576 as an expansion of `gin_helper::EmitEvent`.
Since this only runs in the browser process and `bool ignore_browser_checkpoint = true` this code is a no-op.
Node should perform a microtask checkpoint if necessary in `node::MakeCallback`.
* Remove no-op MicrotasksScope in `shell/common/api/electron_bindings.cc`
This method is only called by the browser process. The containing function, `ElectronBindings::DidReceiveMemoryDump`, is only used in two places:
* `ElectronBindings::GetProcessMemoryInfo` in the same file, which has a `CHECK` that it's running in the browser process at the top.
* From `shell/browser/api/electron_api_web_contents.cc`, which is only run in the browser process.
Added a DCHECK for clarity and validation.
* Replace `gin_helper::MicrotasksScope` with `v8::MicrotasksScope` in `shell/renderer/`
The browser check is unnecessary in the renderer. Since `gin_helper::MicrotasksScope` will always act exactly like `v8::MicrotasksScope`, it's clear to just use the v8 object directly. This also brings them in line with the many other uses of `v8::MicrotasksScope` in `shell/renderer/`.
2025-04-19 12:18:03 -05:00
Charles Kerr
297c4297b1
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver() ( #46672 )
...
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver()
2025-04-19 10:51:52 -05:00
Calvin
3a982ecad5
fix: do not run microtasks in V8Serializer in browser process ( #46668 )
2025-04-19 11:43:02 +09:00
Charles Kerr
926a6ee8bd
refactor: remove WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK ( #46670 )
...
refactor: remove electron::WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK
This was added in 344aba0 . In the time when this PR initially went up and
when 344aba0 landed, upstream added blink::PermissionTypes::KEYBOARD_LOCK.
Our duplicate copy can be removed.
2025-04-18 16:14:45 -05:00
Shelley Vohr
437542767a
fix: backgroundMaterial on initial activate ( #46657 )
...
* fix: backgroundMaterial on initial activate
Closes https://github.com/electron/electron/issues/38466
* Update patches/chromium/fix_activate_background_material_on_windows.patch
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-17 20:34:45 +02:00
Shelley Vohr
a29e1170b9
feat: support Web Serial & WebUSB blocklists ( #46600 )
2025-04-17 20:34:34 +02:00
Shelley Vohr
352a403efd
fix: postMessage crash with invalid transferrable ( #46639 )
2025-04-17 15:09:48 +02:00
John Kleinschmidt
e8117f8e40
build: update build tools ( #46656 )
...
* build: update build tools
* chore: fix core.fscache
* chore: fix core.preloadindex
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-17 10:32:17 +02:00
Shelley Vohr
32fea719b3
refactor: migrate to non-deprecated allowedContentTypes on macOS ( #46623 )
...
refactor: migrated to non-deprecated allowedContentTypes on macOS
2025-04-15 09:51:34 -05:00
Shelley Vohr
14df4aab83
fix: window border on Gnome Wayland ( #46624 )
2025-04-15 15:45:33 +02:00
dependabot[bot]
24e46849c7
build(deps): bump actions/setup-node from 4.3.0 to 4.4.0 ( #46636 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](cdca7365b2...49933ea528 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 4.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-15 15:44:04 +02:00
Shelley Vohr
489d30edfb
build: roll build-images ( #46625 )
2025-04-14 16:10:46 -04:00
Shelley Vohr
e748b521b2
test: fix node spec disabled tests ( #46627 )
2025-04-14 11:38:27 -04:00
Shelley Vohr
51bffb533e
fix: paint and flash issues on macOS ( #46615 )
...
* fix: paint and flash issues on macOS
* Adhere to paintWhenInitiallyHidden
2025-04-14 16:29:07 +02:00
Shelley Vohr
62b5b5f99d
fix: handle potential missing close event property ( #46605 )
...
fix: handle missing close event property
2025-04-11 13:07:26 -04:00
Keeley Hammond
a9b2ec514b
fix: fallback to old MacOS context menu behavior if no frame is present ( #46595 )
...
* fix: fallback to old MacOS context menu behavior if no frame is present
Co-authored-by: georgexu99 <georgexu99@electronjs.org >
Co-authored-by: erickzhao <erickzhao@electronjs.org >
Co-authored-by: clavin <calvin@electronjs.org >
* docs: add additional option for focusedFrame
* fix: handle frame found, but no view update from rfh
* fix: fix conditional
Co-authored-by: Calvin <clavin@users.noreply.github.com >
---------
Co-authored-by: georgexu99 <georgexu99@electronjs.org >
Co-authored-by: erickzhao <erickzhao@electronjs.org >
Co-authored-by: clavin <calvin@electronjs.org >
Co-authored-by: Calvin <clavin@users.noreply.github.com >
2025-04-11 10:15:35 -04:00
Shelley Vohr
3064b24c9d
refactor: use default printing path when no user options ( #46587 )
2025-04-11 10:14:29 -04:00
David Sanders
74d641c7b3
build: ignore files in .git when running markdownlint-cli2 ( #46608 )
2025-04-10 18:37:07 -05:00
Shelley Vohr
446d0769ed
feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI ( #46438 )
...
feat: expose shouldUseDarkColorsForSystemIntegratedUI
Closes https://github.com/electron/electron/issues/46429 .
Refs https://github.com/electron/electron/pull/19735 .
This PR adds a new API `shouldUseDarkColorsForSystemIntegratedUI` to the
`nativeTheme` module. This API returns a boolean indicating whether the
system is using dark colors for system integrated UI elements. This is
useful for applications that want to adapt their UI to match the system
theme, especially for those that use system integrated UI elements like
the shell theme or taskbar appearance.
2025-04-10 12:08:29 +02:00
Jemil Suleimanov
013133867b
docs: unify documentation example and fiddle for IPC pattern-1 ( #46517 )
...
* docs: unify documentation examples and fiddle
* docs: remove changes in ipc documentation
2025-04-10 12:08:10 +02:00
Yuri
de407e82b7
docs: updated tray doc with tooltip removing ( #46515 )
...
added tooltip removing doc
2025-04-09 11:50:08 -04:00
Charles Kerr
c6e6a03a24
fix: NativeWindow.window_id() returns same value for all windows ( #46562 )
...
fix: NativeWindow.window_id() returns same value for all windows
2025-04-09 10:45:06 -05:00
Shelley Vohr
c1c74b0a6c
fix: re-enable OOP printing on Linux ( #46529 )
2025-04-09 15:42:16 +02:00
Shelley Vohr
45a0494287
fix: remove obsoleted --inspect-brk logic ( #46560 )
...
fix: remove obsoleted --inspect-brk logic
2025-04-09 15:35:40 +02:00
Shelley Vohr
521108e2a5
fix: crash on parent window close and focur/blur ( #46559 )
2025-04-09 15:35:30 +02:00
dependabot[bot]
93a51cc756
build(deps): bump github/codeql-action from 3.28.13 to 3.28.15 ( #46554 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.13 to 3.28.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](1b549b9259...45775bd823 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.15
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-09 10:36:38 +02:00
Charles Kerr
ab23758e51
refactor: use v8::True(isolate) and v8::False(isolate) ( #46544 )
2025-04-08 12:58:39 -05:00
Charles Kerr
9069542d0b
refactor: remove unnecessary const_cast ( #46543 )
...
refactor: remove unnecessary const_cast
unnecessary since July 2019 in 50b9c70
2025-04-08 12:58:28 -05:00
Charles Kerr
636cbc19ac
refactor: simplify some BaseWindow JS getters ( #46542 )
...
* refactor: return a std::array<int 2> from BaseWindow::GetMaximumSize()
* refactor: return a std::array<int 2> from BaseWindow::GetMinimumSize()
* refactor: return a std::array<int 2> from BaseWindow::GetPosition()
* refactor: return a std::array<int 2> from BaseWindow::GetSize()
* refactor: return a std::array<int 2> from BaseWindow::GetContentSize()
* refactor: extract helper method ToArray(const gfx::Size)
* refactor: #include correctness
2025-04-08 10:58:12 -05:00
Shelley Vohr
1a6de10da8
fix: assert.ok in the renderer process ( #46528 )
...
fix: assert.ok in the renderer process
2025-04-08 07:09:54 -05:00
Charles Kerr
b1731407bc
refactor: make TrackableObjectBase::weak_map_id_ const ( #46524 )
...
refactor: make TrackableObjectBase::weak_map_id_ const
simplify declaration and initialization
2025-04-07 20:49:05 -05:00
Charles Kerr
4bb7a4ceb0
refactor: make api::View methods const, private ( #46545 )
...
* refactor: make api::View::GetBounds() const
* refactor: make api::View::OnViewBoundsChanged() private
refactor: make api::View::OnViewIsDeleting() private
refactor: make api::View::OnChildViewRemoved() private
* refactor: make ChildPair private
2025-04-07 16:23:36 -05:00
Shelley Vohr
e22b83abf2
build: update codespaces config ( #46533 )
2025-04-07 16:29:33 -04:00
Niklas Wenzel
bbc9d1cdc1
build: emphasize the need for a testcase in our issue template ( #46447 )
2025-04-07 10:50:59 -07:00
Charles Kerr
85dce12be3
refactor: migrate to View::AddChildView(std::unique_ptr<ui::View*>) ( #46474 )
...
* refactor: use AddChildView(std::unique_ptr<View>) in OpaqueFrameView::CreateButton()
Xref: https://issues.chromium.org/issues/40485510
* refactor: use AddChildView(std::unique_ptr<View>) in MenuBar::RebuildChildren()
* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux labels
* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux buttons
* refactor: use AddChildView(std::unique_ptr<View>) in AutofillPopupView
* refactor: use AddChildViewRaw() to flag the edge cases that we still need to fix
* chore: use west coast const for consistency
2025-04-07 09:20:46 -05:00
Charles Kerr
a6875c732c
docs: note that titleBarOverlay.symbolColor is supported on Linux ( #46492 )
...
docs: note that titleBarOverlay.symbolColor is supported on Linux
this is supported via OpaqueFrameView
2025-04-07 11:10:54 +02:00
Charles Kerr
c0fdf09f28
perf: on Windows, make Archive::HeaderIntegrity() faster ( #46509 )
...
* perf: do not clone the map each time we call Archive::HeaderIntegrity()
* perf: use absl::flat_hash_map for the integrity cache
* perf: do not clone the JSON payload string
* perf: preallocate capacity for the integrity cache
* perf: use move variant of insert_or_assign()
* refactor: simplify integrity cache building
remove unnecessary std::optional<>
* refactor: use base::FindOrNull()
* refactor: remove unused #includes
* refactor: make variable types explicit
* fix: make res_size unsigned
* refactor: put GetIntegrityConfigCache() in an unnamed namespace
refator: put LoadIntegrityConfig() in an unnamed namespace
* fix: oops, missing rel_path_utf8 key
* fix: oops, fix Wunreachable-code-return
2025-04-07 11:10:29 +02:00
Charles Kerr
41d8f90d68
refactor: use base::flat_set in WebContents::DidUpdateFaviconUrl() ( #46475 )
...
* refactor: add gin::Converter<std::span>::ToV8()
* feat: add ToV8(const base::flat_set<T>&)
* perf: use a flat_set in WebContents::TitleWasSet()
* refactor: add gin::Converter<std::array>::ToV8()
2025-04-07 10:16:02 +02:00
Charles Kerr
3c5c9c8e19
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal() ( #46508 )
...
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal()
Why waste time make lot call when few call do trick?
2025-04-06 19:02:04 -07:00
Hailey
ac18decc56
revert: allow NSMenuItems to be disabled ( #46502 )
...
Revert "fix: allow NSMenuItems to be disabled (#46307 )"
This reverts commit ac616ef41d .
2025-04-06 20:42:05 -05:00
Charles Kerr
052da50aeb
refactor: remove unused electron::api::App::FileIconCallback ( #46490 )
...
refactor: remove electron::api::App::FileIconCallback
last use removed in 2018 by 3f15f516
2025-04-05 00:39:17 -05:00
Charles Kerr
4e33d1690d
refactor: instantiate navigation_entries local variable on the stack ( #46453 )
...
* refactor: instantiate navigation_entries on the stack instead of the heap
* refactor: reserve the full size of navigation_entries
* refactor: use emplace_back to simplify the code a little
2025-04-04 16:55:27 -05:00
Shelley Vohr
c2ae4afb8f
fix: destroy parent port backend when JS env exits ( #46437 )
...
* fix: destroy parent port backend when JS env exits
* fix: close parent port before destroying
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-04 11:02:54 -05:00
Felix Rieseberg
e81e3acd2d
docs: Add C++/Win32 tutorial ( #46160 )
...
* docs: Add C++/Win32 tutorial
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* docs: make linter happy
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-04 08:00:45 -05:00
electron-roller[bot]
9c019b6147
chore: bump chromium to 136.0.7095.0 (main) ( #46118 )
...
* chore: bump chromium in DEPS to 136.0.7076.0
* chore: bump chromium in DEPS to 136.0.7077.0
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6356528: Clean up LegacyRenderWidgetHostHWND code | https://chromium-review.googlesource.com/c/chromium/src/+/6356528
* chore: export patches
* 6339113: [Viewport Segments] Add CDP commands to override Viewport Segments without overriding other device properties. | https://chromium-review.googlesource.com/c/chromium/src/+/6339113
* 6352169: [DevTools][MultiInstance] Support new tab in another window on Android | https://chromium-review.googlesource.com/c/chromium/src/+/6352169
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6360858:Clickiness: Wire response from URLLoader to DB, add e2e tests| https://chromium-review.googlesource.com/c/chromium/src/+/6360858
* chore: bump chromium in DEPS to 136.0.7079.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7081.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7083.0
* 6361987: Remove double-declaration with gfx::NativeView and gfx::NativeWindow | https://chromium-review.googlesource.com/c/chromium/src/+/6361987
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7087.0
* chore: export patches
* fix: include node patch for missing AtomicsWaitEvent
https://chromium-review.googlesource.com/c/chromium/src/+/6385540
* build: add depot_tools python to path
* fix: cppgc init and unregistering v8 isolate
https://chromium-review.googlesource.com/c/v8/v8/+/6333562
CppGc is now initialized earlier so Node can skip reinitializing it.
Additionally, gin::IsolateHandle was attempting to destruct an already destructed
v8::Isolate upon electron::JavaScriptEnvironment destruction. By removing the call
to NodePlatform::UnregisterIsolate, this fixes the crash on app shutdown.
* fix: unregister isolate after destruction
See code comment.
* chore: bump chromium in DEPS to 136.0.7095.0
* chore: sync patches
* fix: add script_parsing::ContentScriptType parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6298395
* fix: migrate content::BrowserAccessibilityState methods
https://chromium-review.googlesource.com/c/chromium/src/+/6401437
https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* feat: enableHappyEyeballs option for host resolver
https://chromium-review.googlesource.com/c/chromium/src/+/6332599
* fix: add new cookie exclusion reason
https://chromium-review.googlesource.com/c/chromium/src/+/6343479
* fix: add new url loader method
https://chromium-review.googlesource.com/c/chromium/src/+/6337340
* fix: add new cppgc header file for electron_node headers
https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* fix: disable CREL on Linux ARM64
https://chromium-review.googlesource.com/q/I3a62f02f564f07be63173b0773b4ecaffbe939b9
* fixup! fix: add new cppgc header file for electron_node headers https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* chore: update corner smoothing patch
* fixup! chore: update corner smoothing patch
* chore: disable NAN weak tests
These two tests are incompatible with a V8 change that disallows running JS code from a weak finalizer callback.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
* test: fix task starvation in node test
A V8 change makes these contexts get collected in a task that is posted
and run asynchronously. The tests were synchronously GC'ing in an
infinite loop, preventing the task loop from running the task that would
GC these contexts.
This change should be upstreamed in some way.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2025-04-03 19:02:49 -05:00
Charles Kerr
0a5da83a1b
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged() ( #46451 )
...
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged()
2025-04-03 17:51:37 -05:00
Fedor Indutny
7601af5200
fix: don't copy 'package.json's out of ASAR file ( #46390 )
...
New Node.js module resolution system reads `package.json` from imported
modules by reading from the file natively in C++ without calling into
`fs.readFileSync`. The ASAR FS wrapper code had copied files out into a
temporary folder as a workaround, but it is inefficient and does not
cover all module resolution mechanisms in Node.js.
In this change we expose `overrideReadFileSync` method on the `modules`
binding in Node.js, and use this override to call into ASAR-supporting
`fs.readFileSync`.
2025-04-03 13:39:53 -07:00
yangllu
e46b0c8ddc
fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 ( #46434 )
...
* fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8
* fix: use CleanedUpAtExit to control the lifetime of GPUInfoManager
2025-04-03 10:12:12 -07:00
Samuel Attard
0e3246e20d
fix: ensure maximize is emitted when reduce motion is enabled on macOS ( #46459 )
...
* fix: ensure maximize is emitted when reduce motion is enabled on macOS
* Revert "build: reenable graphics effects for macOS tests (#46454 )"
This reverts commit 682ea345ac .
2025-04-03 11:14:16 -05:00
Charles Kerr
0ff98810ba
fix: NativeWindowViews::GetRestoredState() can return wrong state when maximized ( #46450 )
...
fix: NativeWindowViews::GetRestoredState() returning wrong state
Introduced by the af58931 Chromium 131.0.6744.0 roll, specifically
https://github.com/electron/electron/pull/43948/commits/9840662#diff-f9d7ef7
98406626
2025-04-03 08:55:04 -05:00
Shelley Vohr
f48680a983
fix: zlib pointer alignment ( #46435 )
...
fix: fix zlib pointer alignment
2025-04-03 09:35:38 -04:00
Niklas Wenzel
682ea345ac
build: reenable graphics effects for macOS tests ( #46454 )
2025-04-02 21:33:12 -05:00
Charles Kerr
a21c805ece
perf: avoid redundant call to virtual methods GetProcess() and GetID() ( #46409 )
2025-04-02 11:57:09 -05:00
Charles Kerr
6f24dbaab4
perf: prefer absl::flat_hash_set over std::set when sorted order is not needed ( #46410 )
...
* perf: use an absl::flat_hash_set for UsbChooserContext::ephemeral_devices_
* perf: use an absl::flat_hash_set for GlobalMenuBarRegistrarX11::live_windows_
* perf: use an absl::flat_hash_set for NativeWindowViews::forwarding_windows_
* perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::guest_host_views_
perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::proxy_views_
* perf: use an absl::flat_hash_set for NativeWindow::injected_frames_
* perf: use an absl::flat_hash_set for NativeWindow::background_throttling_sources_
2025-04-02 11:03:36 -05:00
Charles Kerr
36e233797c
perf: cache the return value of IsX11() ( #46391 )
...
* perf: cache the return value of IsX11()
* fix: mark as nodiscard for those who call, but mark as maybe_unused for Windows
2025-04-01 15:28:01 -05:00
Shelley Vohr
c02e5bc72c
build: make it clearer when cookie auth runs ( #46406 )
2025-04-01 10:44:51 -07:00
Charles Kerr
5499c800a7
perf: avoid redundant map lookup in UsbChooserContext::OnDeviceRemoved() ( #46387 )
2025-04-01 12:39:34 -05:00
Charles Kerr
0492f0f745
perf: have ErrorThrower lazily lookup the current isolate ( #46388 )
...
perf: have ErrorThrower lazy-lookup the current isolate
ErrorThrower's default constructor is marked as "should rarely if ever
be used" because it's expensive to call.
Unfortunately, nearly every instance of ErrorThrower comes as an argument
in gin_helper's JS-->C++ function marshalling where a thrower is
default-constructed and then populated in gin_helper::GetNextArgument()
with an assignment operator to a temporary ErrorThrower constructed
with the gin::Arguments' isolate.
tldr: most of the time we use the slow constructor first, then throw
that work away unused by overwriting with a fast-constructed one.
This refactor avoids that cost by deferring the expensive work to
`ErrorThrower::isolate()`, where it happens only as a fallback iff
isolate_ hasn't been set.
2025-04-01 12:25:27 -05:00
Charles Kerr
ac1ffb1bff
fix: leaked gfx::Canvas in AutofillPopupView::OnPaint() ( #46384 )
...
* perf: avoid redundant call to popup_bounds_in_view()
* refactor: use a std::optional<> for paint_canvas local
* fix: fix leaked gfx::Canvas in AutofillPopupView::OnPaint()
* refactor: remove redundant get() call when testing smart pointer for nonempty
* refactor: remove unnecessary draw_canvas variable
* refactor: rename bitmap to offscreen_bitmap for symmetry
* refactor: avoid another redundant call to popup_bounds_in_view()
2025-04-01 11:22:26 -05:00
Charles Kerr
5a6f1ede6a
feat!: remove support for ProtocolResponse.session null value ( #46264 )
...
BREAKING CHANGE
This was deprecated in f7ba0d3b & is now being removed for Electron 37.
2025-04-01 08:52:12 -05:00
zoy
0e687d3082
fix: rounded corners disappear momentarily on window close ( #46382 )
...
fix: Explicitly set rounded corners in borderless mode on Windows 11
Signed-off-by: zoy <zoy-l@outlook.com >
2025-04-01 15:43:54 +02:00
Calvin
08da2b0b07
chore: move build files to build/ dir ( #46368 )
2025-04-01 13:42:14 +02:00
Shelley Vohr
9c4720766d
fix: UtilityProcess.fork crash before app ready ( #46380 )
...
fix: UtilityProcess.fork crash before app ready
2025-04-01 13:42:03 +02:00
Shelley Vohr
5da75c4a97
feat: support system-context-menu on Linux ( #45848 )
...
feat: support system-context-menu on Linux
2025-04-01 11:00:39 +02:00
Charles Kerr
77833eddfb
perf: avoid unnecessary vector copy in GetMimeTypeToExtensionIdMap() ( #46373 )
...
* perf: avoid making an unnecessary copy of the vector
MimeTypesHandler::GetMIMETypeAllowlist() returns a const&, so we can
iterate that directly instead of making a temporary copy of it.
* perf: move the call to ExtensionRegistry::Get() outside of the loop
Also, keep the previous behavior of not calling it at all if there
aren't any whitelisted extensions.
* perf: avoid redundant map lookup
* refactor: const correctness
* refactor: cleanup
2025-03-31 21:52:49 -05:00
Calvin
1730062c8f
fix: flicker and ghosting in transparent windows on macOS ( #46353 )
...
* fix: transparent flicker on MAS
* Gate condition on `IsTranslucent` instead
2025-03-31 18:12:35 -05:00
Calvin
09135443a0
feat: Corner Smoothing CSS rule (Reland) ( #46278 )
...
* feat: Corner Smoothing CSS rule (Reland)
Reland of #45185
* Fix patch conflicts
* fixup! Fix patch conflicts
* Update expected image
The dashed border is subtly different. The new version is correct and the old one was incorrect.
2025-03-31 11:22:23 -05:00
Charles Kerr
fcd836e34f
refactor: remove field unused weak_factory_ ( #46363 )
...
refactor: remove unused weak_factory_
Appears to have been added in e3f61b46 but never used
2025-03-31 10:39:21 +02:00
Charles Kerr
28fd7c5a17
perf: improve temporaries in WebWorkerObserver::WorkerScriptReadyForEvaluation() ( #46347 )
...
refactor: small refactor to WebWorkerObserver::WorkerScriptReadyForEvaluation()
- replace a std::vector<std::string> local with a compile-time array
of std::string_view
- remove .c_str() pessimization when making v8 Strings from string_views
2025-03-30 23:21:39 -05:00
Charles Kerr
ae6930030a
perf: prefer absl::flat_hash_set over std::unordered_set ( #46348 )
...
* perf: use absl::flat_hash_set in SpellCheckClient::SpellCheckText()
* perf: use absl::flat_hash_set in MessagePort::DisentanglePorts()
2025-03-30 23:21:18 -05:00
Charles Kerr
2fa4fb0da9
refactor: use v8::String::Empty() when creating empty strings ( #46349 )
...
refactor: use v8::String::Empty() when creating empty strings
2025-03-30 21:14:18 -05:00
Charles Kerr
bf93427cbb
perf: avoid double map lookup in HidChooserContext::DeviceRemoved() ( #46343 )
2025-03-28 21:34:24 -05:00
Charles Kerr
72fc65d2c5
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance() ( #46339 )
...
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance()
2025-03-28 21:33:45 -05:00
Charles Kerr
2baa4a3514
perf: avoid a double-map lookup in NotificationPresenter::RemoveNotification() ( #46338 )
...
perf: avoid a double-map lokup in NotificationPresenter::RemoveNotification()
2025-03-28 21:33:11 -05:00
Samuel Attard
49aba471dc
feat: add support for associating a Menu with a WebFrameMain ( #45138 )
...
* feat: add support for associating a Menu with a WebFrameMain
This allows certain OS level features to activate such as Writing Tools, Autofill.. and Services.
There appears to be a bug in macOS where the responder chain isn't traversed if the menu is not popped up using an event, as such we spoof a fake mouse event at the write coordinates in the right window and use that to open the menu.
* build: fix build on non-mac
* build: oops missed a header
* fix: safely handle optional T* by checking nullptr too
* build: fix gn check and build errors
* docs: suggested changes
* feat: default `frame` to `window.webContents.mainFrame` when possible
* fix: avoid deref nullptr view
* Revert "feat: default `frame` to `window.webContents.mainFrame` when possible"
This reverts commit 2e88836819 .
* fix: lint
* Remove redundant scoped objects
This code, including the comments, matches almost exactly the behavior of this argument to the function.
* Add ScopedPumpMessagesInPrivateModes patch
* More null pointer safety
---------
Co-authored-by: clavin <clavin@electronjs.org >
2025-03-28 11:50:07 -07:00
Charles Kerr
46b108e9a4
perf: avoid redundant map lookups in GetStorageMask() ( #46315 )
...
* perf: avoid a redundant map lookuop in GetStorageMask()
* perf: avoid a redundant map lookup in GetDataTypeMask()
2025-03-28 00:25:25 -05:00
Hailey
ac616ef41d
fix: allow NSMenuItems to be disabled ( #46307 )
...
* fix: disable NSMenu autoenable feature to allow disabling of NSMenuItems
* style: fix linter issues and update comments
* chore: remove unneeded comment
2025-03-27 17:43:46 -07:00
Charles Kerr
e09712f0e1
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges() ( #46306 )
...
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges()
2025-03-27 14:32:27 -05:00
Charles Kerr
35c90fd807
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() ( #46293 )
...
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost()
2025-03-27 14:32:01 -05:00
Shelley Vohr
756423e81e
build: validate Chromium cookie authentication ( #46274 )
2025-03-27 14:29:01 -05:00
Shelley Vohr
dc61a6ab80
fix: possible crash in shell.readShortcutLink ( #46294 )
...
fix: possible crash in shell.readShortcutLink
2025-03-27 14:27:32 -05:00
Shelley Vohr
a0c859fc4f
build: roll build-images SHAs ( #46291 )
2025-03-27 10:39:02 +01:00
Shelley Vohr
17e38230d5
fix: crash when drag-dropping some files ( #46253 )
...
* fix: crash when drag-dropping some files
* fix: extra destination context scope
2025-03-26 17:17:23 -05:00
Charles Kerr
3ae285b614
perf: avoid std::map temporaries in WebContents::DevToolsRequestFileSystems() ( #46268 )
...
* perf: move the GetDevToolsWebContents() call outside of the loop
* perf: remove std::map temporary in WebContents::DevToolsRequestFileSystems()
* refactor: remove unused GetAddedFileSystemPaths()
* perf: remove std::vector temporary in WebContents::DevToolsRequestFileSystems()
2025-03-26 16:26:56 -05:00
Shelley Vohr
3212f60d69
fix: set userAgent on navigationHistory.restore() ( #46260 )
...
fix: set userAgent on navigationHistory restore
2025-03-26 10:59:19 -05:00
Charles Kerr
a5076a663b
perf: avoid redundant map lookup in WebContents::DevToolsIndexPath() ( #46254 )
...
perf: avoid double map lookup in WebContents::DevToolsIndexPath()
2025-03-26 10:30:02 -05:00
Shelley Vohr
d2c2261c58
fix: hard crash on invalid command line switches ( #46004 )
...
* fix: hard crash on invalid command line switch
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: feedback from review
* docs: Add breaking change note
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-03-26 08:14:03 -05:00
Charles Kerr
8412d78310
perf: avoid redundant map lookup in AddComponentResourceEntries() ( #46255 )
...
* perf: avoid double map lookup in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
* perf: move the path key when calling try_emplace()
2025-03-26 08:12:16 -05:00
Charles Kerr
48a38c0289
fix: build failure when printing is disabled ( #46283 )
...
fix: ftbfs when printing is disabled
2025-03-26 10:04:39 +01:00
Charles Kerr
6e44662f15
perf: avoid redundant map lookup in WebFrameMain constructor ( #46238 )
...
perf: avoid double map lookup in WebFrameMain constructor
2025-03-25 16:53:24 -05:00
Charles Kerr
c8d3184a95
refactor: migrate hashing code to new upstream crypto::hash API ( #46237 )
...
* refactor: migrate AsarFileValidator to crypto::hash
This change migrates AsarFileValidator's uses of crypto::secure_hash
to the new crypto::hash API, which has more memory safety and less
heap allocations.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6287609
* refactor: migrate ValidateIntegrityOrDie to crypto::hash
This change migrates ValidateIntegrityOrDie's use of crypto::SHA256Hash
to the new crypto::hash API, which has more memory safety and less heap
allocations.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6287609
2025-03-25 15:01:17 -05:00
dependabot[bot]
bb0ddcad27
build(deps): bump actions/setup-node from 4.2.0 to 4.3.0 ( #46092 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1d0ff469b7...cdca7365b2 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-25 13:29:22 -05:00
John Kleinschmidt
4eda76de36
build: fixup windows source cache for release ( #46236 )
...
* build: fixup windows source cache for release
* build: fixup ffmpeg gn gen
* build: add build-tools depot_tools to PATH
There are some cases where it is still expected that depot_tools be in the path
* put back regular gn gen for ffmpeg
* build: add retry to moving source cache
This resolves the error: `Move-Item : The process cannot access the file because it is being used by another process.`
2025-03-25 14:24:58 -04:00
Charles Kerr
ced8fdbce8
perf: avoid std::map temporaries in IsDevToolsFileSystemAdded() ( #46230 )
...
* refactor: extract-method GetAddedFileSystems()
* refactor: use GetAddedFileSystems() in GetAddedFileSystemPaths()
* refactor: use GetAddedFileSystems() in IsDevToolsFileSystemAdded()
2025-03-25 11:42:58 -05:00
Charles Kerr
f7ba0d3b4b
docs: deprecate setting ProtocolResponse.session to null ( #46131 )
...
* docs: deprecate setting ProtocolResponse.session to null
* docs: mark null ProtocolResponse.session as deprecated in struct docs
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-03-25 10:04:21 -05:00
Charles Kerr
4f4e23a3b3
perf: avoid redundant map lookups in GlobalShortcut ( #46229 )
...
* perf: avoid redundant map lookup in GlobalShortcut::OnKeyPressed()
* perf: avoid redundant map lookup in GlobalShortcut::ExecuteCommand()
2025-03-25 09:46:03 -05:00
Shelley Vohr
1d6cb348b4
fix: webContents.printToPDF() with cross-process subframes ( #46218 )
...
fix: webContents.printToPDF() with cross-process subframes
2025-03-25 08:16:47 -05:00
dependabot[bot]
8e856dfdb8
build(deps): bump github/codeql-action from 3.28.11 to 3.28.13 ( #46240 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.11 to 3.28.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](6bb031afdd...1b549b9259 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-25 12:21:23 +01:00
John Beutner
cf82c3215f
perf: don't wait for thumbnails if they were not requested on macOS ( #46138 )
...
When using the SCK thumbnail capturer, the first refresh has the list of
sources, and the second refresh has the thumbnails. If thumbnails are
not needed, only wait for the first refresh.
2025-03-25 12:20:38 +01:00
Robo
307d4f94c7
fix: oob string read when parsing node_options ( #46210 )
...
* fix: oob string read when parsing node_options
* chore: re-enable test
* fix: missing linux server env for tests
2025-03-25 19:33:10 +09:00
dependabot[bot]
cfada0347e
build(deps): bump actions/download-artifact from 4.1.9 to 4.2.1 ( #46239 )
2025-03-25 08:47:33 +01:00
dependabot[bot]
7cb921369b
build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2 ( #46241 )
2025-03-25 08:46:18 +01:00
Robo
a86e44b176
fix: NODE_OPTIONS parsing for child processes on macOS ( #46209 )
...
* fix: NODE_OPTIONS parsing for child processes on macOS
* chore: temporarily disable test
* chore: apply review feedback
* chore: fix build
2025-03-25 13:01:37 +09:00
Calvin
abaef13c0b
fix: Revert "feat: Corner Smoothing CSS rule" ( #46231 )
...
Revert "feat: Corner Smoothing CSS rule (#45185 )"
This reverts commit b75e802280 .
2025-03-24 20:36:49 +01:00
John Beutner
cfd64b5f89
fix: handle OnDelegatedSourceListDismissed asynchronously ( #46112 )
...
This fixes a crash with the PipeWire capturer caused by a Chromium
change introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/5783826 .
DesktopMediaListBase now calls Refresh(true) after dispatching
DesktopMediaListObserver::OnDelegatedSourceListDismissed, so it's
important not to call DesktopCapturer::HandleFailure (which deallocates
the DesktopMediaList) synchronously from OnDelegatedSourceListDismissed.
2025-03-24 20:09:11 +01:00
John Kleinschmidt
cbcd779610
build: fixup release builds ( #46228 )
2025-03-24 14:34:57 -04:00
Calvin
b75e802280
feat: Corner Smoothing CSS rule ( #45185 )
...
* feat: Corner Smoothing
* Patch Blink to add CSS rule and Painting
* Add `system-ui` keyword
* Add `cornerSmoothingCSS` web preference
* Add tests
* Documentation
* fixup! Documentation
* fix: initialize smoothness value
* Use a 1.0 scale factor in tests
* Fix tests for CI
* Fix tests
* fixup! Merge branch 'main' into clavin/corner-smoothing
* Add code docs
* Document `system-ui` keyword values
* Address review comments
* fixup! Address review comments
* Address review comments
* Update patch to address upstream changes
The patch went from 694 lines to 505 lines, which is a 27.2% smaller!
* fixup! Update patch to address upstream changes
2025-03-24 11:46:12 -04:00
Shelley Vohr
9ec14b91e7
feat: add BrowserWindow.isSnapped() ( #46079 )
...
* feat: add BrowserWindow.isSnapped() on Windows
* docs: mark _Readonly_
2025-03-24 12:09:14 +01:00
Shelley Vohr
47cf4e7bfd
fix: Wayland resizing border ( #46155 )
...
* fix: Wayland resizing border
Closes https://github.com/electron/electron/issues/44543
Refs CL:5180720
Fixes an issue where the resizing border didn't work as expected on Wayland windows.
* fix: border insets when fullscreen
2025-03-24 12:08:24 +01:00
Charles Kerr
b8150f33db
refactor: remove unused weak_factory_ in electron_management_api_delegate.cc ( #46200 )
...
refactor: remove unused weak_factory_
Appears to have been added in 3745b76da but never used
2025-03-24 12:07:49 +01:00
Charles Kerr
02a4bd5942
refactor: remove unused method ProxyingWebSocket::web_request_api() ( #46201 )
...
Appears to have been added in c608d6d7 but never used
2025-03-24 10:09:24 +01:00
Charles Kerr
7ed4f0ca27
perf: use absl::flat_hash_map instead of std::unordered_map ( #46202 )
...
* perf: make ElectronUsbDelegate::controller_map_ an absl::flat_hash_map
* perf: make ElectronSerialDelegate::controller_map_ an absl::flat_hash_map
* perf: make ElectronHidDelegate::controller_map_ an absl::flat_hash_map
* perf: make FrameTreeNodeIdMap an absl::flat_hash_map
* perf: make AutofillDriverFactory::driver_map_ an absl::flat_hash_map
* perf: make asar::Archive::external_files_ an absl::flat_hash_map
* perf: make VersionIdMap an absl::flat_hash_map
* perf: make ObjectCache::proxy_map_ an absl::flat_hash_map
* docs: add TODO to investigate absl map in KeyWeakMap
2025-03-24 10:09:14 +01:00
Shelley Vohr
964090d086
fix: ensure TraverseParent bails on resource path exit ( #46100 )
...
* fix: ensure TraverseParent bails on resource path exit
* Address review changes
2025-03-24 10:06:59 +01:00
Erik Moura
e9082ea57a
docs: fix capitalization for InputEvent.modifiers ( #46130 )
2025-03-23 16:38:15 -05:00
Charles Kerr
5623c96dd7
refactor: remove unused field ServiceWorkerMain::weak_factory_ ( #46171 )
...
refactor: remove unused field ServiceWorkerMain::weak_factory_
Added in a467d06 , appears to have never been used
2025-03-23 10:14:45 +01:00
Charles Kerr
3fd35abe98
refactor: remove unused method ElectronBrowserContext::GetWeakPtr() ( #46170 )
...
* refactor: use forward declaration of MediaDeviceIDSalt in electron_browser_context.h
* refactor: remove unused #include from browser_context.h
* refactor: remove unused ElectronBrowserContext::GetWeakPtr()
last use removed in Aug 2020 by bac2f46
2025-03-22 10:15:15 -05:00
Charles Kerr
a81e11d9de
refactor: use = default to define trivial destructors ( #46165 )
...
refactor: use '= default' to define trivial destructors
2025-03-21 16:15:34 -05:00
John Kleinschmidt
db47267be4
build: Use windows src cache ( #45881 )
...
build: use source cache on windows
2025-03-21 14:45:08 -04:00
Charles Kerr
6723bfbe32
refactor: reduce coupling in electron::api::Protocol ( #46122 )
...
* refactor: decouple api::Protocol from ElectronBrowserContext
now they do not know about each other
* refactor: make electron::api::ProtocolError private
* refactor: remove unused isolate arg in Protocol constructor
* refactor: use =default for trivial destructor
2025-03-21 07:33:25 -05:00
Shelley Vohr
603057b198
fix: remove File.path from types ( #46005 )
2025-03-21 08:40:49 +01:00
Shelley Vohr
9ccc63d682
fix: add missing cpp_heap to Node.js worker CreateParams ( #46104 )
2025-03-21 08:40:28 +01:00
LZL
4d7161f36e
feat: add ffmpeg.dll to delay load configuration ( #46151 )
...
feat: set ffmpeg.dll as a delay-loaded DLL
Updated the /DELAYLOAD linker config in BUILD.gn to set ffmpeg.dll
as a delay-loaded DLL. This reduces startup overhead and prevents unnecessary
loading when ffmpeg-related functionality is not used (e.g., the browser process
was unnecessarily loading it).
2025-03-21 16:24:34 +09:00
Shelley Vohr
32141eacfb
refactor: use upstream Widget::IsVisibleOnAllWorkspaces() ( #45887 )
...
* refactor: use upstream Widget::IsVisibleOnAllWorkspaces()
* chore: add to breaking changes
2025-03-20 23:43:47 -05:00
Charles Kerr
1b5db9989e
refactor: make URLPipeLoader private ( #46113 )
...
Move the URLPipeLoader class into an anonymous namespace in
electron_url_loader_factory.cc.
2025-03-20 15:47:47 -05:00
Charles Kerr
46967ca9c9
refactor: Add ElectronBrowserContext::BrowserContexts() ( #46089 )
...
* refactor: add ElectronBrowserContext::BrowserContexts()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronBrowserMainParts::PostMainMessageLoopRun()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::IsValidContext()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::BroadcastEventToRenderers()
* refactor: move PartitionKey, BrowserContextMap private
* refactor: add ElectronBrowserContext::IsValidContext()
decouple ElectronExtensionsBrowserClient from the internals of ElectronBrowserContext
2025-03-20 11:17:26 -05:00
Charles Kerr
273baf4ec2
refactor: use base::NumberToString() ( #46141 )
...
base::NumberToString() is slightly more efficient than
absl::StrFormat("%u").
2025-03-20 10:13:28 +01:00
Charles Kerr
c4800d9934
refactor: remove ToV8(isolate, const char*) ( #46108 )
2025-03-20 10:04:50 +01:00
Shelley Vohr
86cc9f626f
fix: APNS token ids are lowercase ASCII ( #46101 )
2025-03-20 07:57:50 +01:00
Shelley Vohr
09a3bcf0f0
fix: webContents.print() crash on Linux ( #46087 )
2025-03-20 06:41:00 +01:00
Shelley Vohr
bf64967b68
build: combine pipewire patches ( #46129 )
2025-03-19 23:26:06 -05:00
Niklas Wenzel
bf1d377e08
docs: use optional chaining for app.dock ( #46119 )
...
docs: use optional chaining for app.dock
2025-03-19 18:34:03 -05:00
Shelley Vohr
d424c3aee7
test: disable parallel/test-worker-resource-limits ( #46105 )
...
test: disable parallel/test-worker-resource-limits
2025-03-19 22:03:26 +01:00
Niklas Wenzel
e4d660af86
docs: fix code example in breaking-changes.md ( #46093 )
2025-03-19 11:20:22 +01:00
Shelley Vohr
2efd75e2ca
build: fail for out of date patches on forks ( #46080 )
2025-03-19 10:05:51 +01:00
electron-roller[bot]
b13f05e2dc
chore: bump chromium to 136.0.7067.0 (main) ( #46018 )
...
* chore: bump chromium in DEPS to 136.0.7066.0
* chore: bump chromium in DEPS to 136.0.7067.0
* 6325710: [LNA] Add Local Network Access permission type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6325710
* 6342514: Create frame mojo endpoints in renderer during window.open()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6342514
* 6344040: Create widget mojo endpoints in renderer process for window.open()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6344040
* chore: update patches
* 6349218: Move ExtensionService::install_directory() to ExtensionRegistrar
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6349218
* 6349395: Move ExtensionService::extensions_enabled() to ExtensionRegistrar
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6349395
* 6331510: Migrate views::Background class to ui::ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6331510
* build: reorder set-cookie step https://github.com/electron/electron/pull/46091
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: alice <alice@makenotion.com >
2025-03-18 19:20:54 -04:00
Shelley Vohr
dcbab692c0
test: fix app.dock for corrected type ( #46110 )
...
test: fix app.dock for corrected type
2025-03-18 17:44:39 -04:00
Niklas Wenzel
71f3ff6bf2
docs: fix types of app.dock ( #46073 )
2025-03-18 13:14:08 +01:00
Alice Zhao
ff0a14a7c6
build: move set chromium cookie before build tools step ( #46091 )
...
build: move set cookie before build tools
2025-03-18 10:07:05 +01:00
Charles Kerr
4bf99c9bea
refactor: add ElectronBrowserContext::GetDefaultBrowserContext() ( #46065 )
...
* refactor: add ElectronBrowserContext::DestroyAllContexts()
Simpler semantics than previous implementation; also hides the
"default context must be destroyed last" implementation detail.
* refactor: add ElectronBrowserContext::GetDefaultBrowserContext()
clearer semantics than everyone calling From("", false)
2025-03-17 08:43:23 -05:00
Charles Kerr
9513486bf3
refactor: use GetDefaultStoragePartition() instead of GetStoragePartition(nullptr) ( #46064 )
...
refactor: use GetDefaultStoragePartition()
Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr)
- It improves code uniformity, since we use get-default everywhere else
- It's more readable
- It's marginally faster, since GetStoragePartition() has more steps
Added in 49b0a1bf4a
2025-03-17 08:39:55 -05:00
Charles Kerr
bea7d618f1
fix: warning in file picker UI ( #46067 )
2025-03-16 20:49:15 -05:00
Charles Kerr
4ad20ccb39
chore: e patches all ( #46068 )
2025-03-16 14:04:01 -05:00
Charles Kerr
73a017577e
perf: avoid redundant map lookup in ElectronBrowserContext::From() ( #46044 )
...
perf: avoid redundant map lookup in ElectronBrowserContext::FromPath()
2025-03-15 09:51:20 -05:00
Shelley Vohr
2d8a547692
build: fix compound bash conditional in patchup ( #46047 )
2025-03-15 09:57:59 +01:00
Charles Kerr
5f0603ed28
fix: ElectronBrowserContext raw_ptr bug + remove dead code ( #46030 )
...
refactor: remove unused ElectronBrowserContext::extension_system()
Last use removed on Jul 21, 2020 by 2fb14f5 in PR #24575
This fixes a raw_ptr warning by letting us remove the raw_ptr field
`ElectronBrowserContext::extension_system_`.
2025-03-14 23:35:10 -05:00
Sam Maddock
afca4e271e
feat: ServiceWorkerMain.scriptURL ( #45863 )
...
feat: serviceWorker.scriptURL
2025-03-14 21:00:13 -04:00
Charles Kerr
30d2fadb28
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #46024 )
...
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
2025-03-14 17:14:32 -05:00
Charles Kerr
3271b82094
refactor: remove unused system header includes ( #46015 )
...
* chore: remove unused #include <string>
* chore: remove unused #include <optional>
* chore: remove unused #include <vector>
* chore: remove unused #include <string_view>
* chore: remove unused #include <memory>
* chore: remove unused #include <utility>
* chore: remove unused #include <tuple>
* chore: remove unused #include <unordered_set>
* chore: remove unused #include <functional>
* chore: iwyu <set>
* chore: iwyu <map>
2025-03-14 10:59:15 -05:00
Shelley Vohr
c0e180758b
fix: don't crash Utility Processes on unhandled rejections ( #45921 )
...
* fix: don't crash on unhandled rejections
* Update docs/breaking-changes.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-03-14 09:09:02 -05:00
Shelley Vohr
5817d27429
fix: take Snapped status into account when showing a window ( #46006 )
2025-03-14 09:07:27 -05:00
Michaela Laurencin
4812b4e6c2
fix: prevent title change for within page navigation ( #45981 )
...
* fix: prevent title change for on page navigation
* add back and forward testing
* update Chromium comment
* remove errant script tag
2025-03-14 12:10:23 +01:00
Shelley Vohr
7c0b7b417b
fix: emit context-menu event in Windows draggable regions ( #45851 )
...
fix: emit context-menu event in Windows draggable regions
2025-03-14 10:29:29 +01:00
Charles Kerr
785fe5f3b6
refactor: make a variadic gin_helper::internal::InvokeFactory() ( #45988 )
...
refactor: make a variadic gin_helper::internal::InvokeFactory()
2025-03-13 17:24:49 -05:00
Shelley Vohr
502a6b0166
build: roll sysroots again ( #46016 )
2025-03-13 16:28:53 -05:00
Shelley Vohr
4a28e60e89
fix: package import existence verification ( #45997 )
2025-03-13 14:51:43 -05:00
Shelley Vohr
a90d50e13f
fix: don't crash Web Workers on unhandled rejections ( #45992 )
2025-03-13 13:09:23 -05:00
electron-roller[bot]
962d8b325a
chore: bump chromium to 136.0.7064.0 (main) ( #45985 )
...
* chore: bump chromium in DEPS to 136.0.7063.0
* chore: bump chromium in DEPS to 136.0.7064.0
* 6169919: Instantiate Linux (or CrOS) system fonts using Fontations
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6169919
* 6341209: Remove file-wide unsafe buffer suppression from content/ [1 of N].
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6341209
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-03-13 12:02:06 -05:00
Charles Kerr
c813bc2a92
refactor: use private inheritance from mojo::MessageReceiver ( #45973 )
...
* refactor: make UtilityProcessWrapper inherit privately from mojo::MessageReceiver
* refactor: make ParentPort inherit privately from mojo::MessageReceiver
* refactor: make MessagePort inherit privately from mojo::MessageReceiver
2025-03-12 19:06:41 +01:00
Shelley Vohr
5ce41bac8d
fix: system-context-menu should only fire in draggable regions ( #45893 )
...
fix: system-context-menu should only fire in draggable regions
2025-03-12 13:47:58 +01:00
David Sanders
6bc7bde229
ci: don't fail branch created workflow if previous board not found ( #45986 )
2025-03-12 09:27:40 +01:00
electron-roller[bot]
2de8fd7d93
chore: bump chromium to 136.0.7062.0 (main) ( #45957 )
...
* chore: bump chromium in DEPS to 136.0.7059.0
* chore: bump chromium in DEPS to 136.0.7060.0
* chore: bump chromium in DEPS to 136.0.7062.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-11 17:44:08 -04:00
Shelley Vohr
dcd319cfbe
build: roll sysroots to pick up glibc fix ( #45974 )
2025-03-11 17:31:48 -04:00
Shelley Vohr
cd56b96544
refactor: remove usage of V8's {Attach|Detach}CppHeap() ( #45922 )
...
* refactor: remove usage of V8's {Attach|Detach}CppHeap()
* chore: remove revert patch
2025-03-11 18:54:33 +01:00
Charles Kerr
22262c14f1
test: fix timing issue in utilityProcess test fixtures ( #45964 )
...
* fix: potential timing issue in utilityProcess test
* fix: potential timing issue in utilityProcess esm test
2025-03-11 17:41:42 +01:00
dependabot[bot]
6e056709be
build(deps): bump github/codeql-action from 3.28.10 to 3.28.11 ( #45970 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.10 to 3.28.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b56ba49b26...6bb031afdd )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-11 10:44:00 -05:00
dependabot[bot]
2f63b20acf
build(deps): bump dsanders11/project-actions from 1.5.2 to 1.7.0 ( #45969 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.5.2 to 1.7.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](7fc3c5441a...2134fe7cc7 )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-11 10:43:46 -05:00
Felix Rieseberg
eb126eecb0
docs: Add 'Native Code and Electron' ( #45882 )
...
* docs: Add 'Native Code and Electron'
* docs: Add node-gyp requirements
* Update docs/tutorial/native-code-and-electron.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Cross-platform clean command
* Mention napi-rs
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Fix lint, fix more comments
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-03-10 13:45:33 -07:00
Shelley Vohr
4e1a915f1a
build: remove patches merged upstream ( #45963 )
2025-03-10 20:00:28 +01:00
Charles Kerr
f2b09ff0bd
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call ( #45929 )
...
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call
This appears to be a copy-paste error introduced in 465dee2c
2025-03-10 09:44:24 -05:00
electron-roller[bot]
b0c11371e0
chore: bump chromium to 136.0.7058.1 (main) ( #45928 )
...
* chore: bump chromium in DEPS to 136.0.7056.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no manual changes; patch applied with fuzz
* chore: update fix_adapt_exclusive_access_for_electron_needs.patch
patch applied manually due to context shear
6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
no manual changes; patch applied with fuzz
6311876: Expose captured surface resolution for MacOS | https://chromium-review.googlesource.com/c/chromium/src/+/6311876
* chore: e patches all
* 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958
* 6326673: views: Delete the single-parameter Widget::InitParams constructor. | https://chromium-review.googlesource.com/c/chromium/src/+/6326673
* https://chromium-review.googlesource.com/c/chromium/src/+/6331102
* 6331102: [A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties | https://chromium-review.googlesource.com/c/chromium/src/+/6331102
Sync with shell/browser/ui/webui/accessibility_ui.cc to
upstream chrome/browser/accessibility/accessibility_ui.cc
changes in 4af8657
* chore: bump Chromium 136.0.7058.1 (#45933 )
chore: bump chromium in DEPS to 136.0.7058.1
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-10 00:30:34 -05:00
Samuel Attard
9b2e7db469
chore: cherry-pick 9dacf5694dfd from chromium ( #45936 )
2025-03-09 16:26:06 -07:00
Samuel Attard
f04c06a0db
chore: cherry-pick 521faebc8a7c from chromium ( #45941 )
2025-03-09 16:23:04 -07:00
Charles Kerr
8ac061ebe7
fix: race condition in utilityProcess tests ( #45926 )
2025-03-09 17:37:35 -05:00
Milan Burda
b30f31e1f6
refactor: eliminate duplicate code in spec/api-process-spec.ts ( #45927 )
2025-03-09 17:37:14 -05:00
Charles Kerr
288ef37b1d
perf: prefer base::SplitStringPiece() over base::SplitString() ( #45924 )
...
* perf: use base::SplitStringPiece() in SetNodeOptions()
* perf: use base::SplitStringPiece() in StringToAccelerator()
* refactor: StringToAccelerator() now takes a std::string_view
2025-03-09 17:36:13 -05:00
electron-roller[bot]
20414f66ca
chore!: bump chromium to 136.0.7054.0 (main) ( #45923 )
...
* chore: bump chromium in DEPS to 136.0.7054.0
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5906158
patch applied manually due to context shear
* chore: e patches all
* refactor!: Session.clearStorageData(syncable)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6309405
Remove syncable type from opts.quota in Session.clearStorageData(opts)
because it that category has been removed upstream.
BREAKING CHANGE: Removed ses.clearDataStorage({ quota: 'syncable' })
* docs: deprecate Session.clearDataStorage({ quota })
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-07 17:49:21 -06:00
electron-roller[bot]
458b14b8ed
chore: bump chromium to 136.0.7053.1 (main) ( #45906 )
...
* chore: bump chromium in DEPS to 136.0.7052.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6318359
patch applied manually due to context shear
* chore: update preconnect_manager.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420
patch applied manually due to context shear
* chore: e patches all
* chore: bump chromium to 136.0.7053.1
* chore: update fix_remove_profiles_from_spellcheck_service.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575
patch applied manually due to context shear
* chore: e patches all
* chore: revert removal of v8 API used by Node.js
* devtools: Remove DevToolsUIBindings::SendJsonRequest() | https://chromium-review.googlesource.com/c/chromium/src/+/6326236
* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461
* 6313744: Migrate views::Background factory methods to ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6313744
* 6314545: Remove multiple argument support from base::ToString() | https://chromium-review.googlesource.com/c/chromium/src/+/6314545
* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | https://chromium-review.googlesource.com/c/chromium/src/+/6317362
* 6308998: Add SettingAccess structured metrics event for DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/6308998
* 6295214: Remove redundant state field in per-extension preferences | https://chromium-review.googlesource.com/c/chromium/src/+/6295214
NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc
* fix: ui/ linter error
This is showing up in an eslint build step in Electron:
> /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts
> 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion
>
> ✖ 1 problem (1 error, 0 warnings)
> 1 error and 0 warnings potentially fixable with the `--fix` option.
However, removing the assertion causes a typescript build failure:
> gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'.
> Type 'null' is not assignable to type 'HTMLElement'.
>
> 77 items.indexOf(this.querySelector<HTMLElement>(':focus'));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
So I think the two different steps may be picking up typescript definitions.
This patch should be removed after the issue is tracked down
and fixed in a followup task.
* fix: -Wnonnull warning
Fixes this warning:
> 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
> 2025-03-07T01:05:01.8638267Z 257 | return nullptr;
> 2025-03-07T01:05:01.8638481Z | ^~~~~~~
> 2025-03-07T01:05:01.8638700Z 1 error generated.
Not sure why this warning was never triggered before; `git blame`
indicates this code hasn't changed in ages:
> c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG
> 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) }
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr;
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) }
Presumably this is failing in this Chromium roll due to a
clang version bump.
We should remove this patch after upstreaming it.
* docs: add upstream pr link for Node patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-07 11:35:59 -06:00
Robo
530ccfe350
fix: resolve font list in default prefernce values ( #45905 )
...
* fix: resolve font list in default prefernce values
* chore: fix unsafe buffer usage
* docs: add code comment
2025-03-07 18:22:03 +09:00
Robo
041ada1586
build: match upstream with unsafe buffer paths ( #45853 )
...
* build: match upstream with unsafe buffer paths
* Don't assume STL iterators are pointers
Refs https://issues.chromium.org/issues/328308661
* chore: spanify process_singleton_win.cc
2025-03-06 16:04:18 -05:00
yangllu
d987bee007
fix: javascript heap OOM is not raised ( #45895 )
...
fix: javascript heap oom is not raised in node::OOMErrorHandler
node::OOMErrorHandler terminates the process directly without raising an
oom exception. To fix it, set an oom handler into node from electron.
2025-03-06 17:34:19 +01:00
Erick Zhao
431a791a99
chore: emphasize documentation style guide ( #45639 )
...
docs: emphasize documentation style guide
2025-03-06 17:17:06 +01:00
dependabot[bot]
9441cf4627
build(deps): bump dsanders11/project-actions from 1.5.1 to 1.5.2 ( #45901 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](9c80cd31f5...7fc3c5441a )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-06 16:38:31 +01:00
Charles Kerr
bb1c3dff21
chore: bump chromium to 135.0.7049.7 (main) ( #45900 )
...
chore: bump chromium in DEPS to 135.0.7049.7
2025-03-05 16:36:52 -05:00
electron-roller[bot]
49a27cba6b
chore: bump chromium to 135.0.7049.5 (main) ( #45898 )
...
chore: bump chromium in DEPS to 135.0.7049.5
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-05 09:47:38 -06:00
Shelley Vohr
99c943df23
fix: setContentProtection(true) after hide on Windows ( #45868 )
...
fix: content protection after hide on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5789117
2025-03-04 16:39:59 -05:00
Sam Maddock
8c11764800
feat: WebContents.focusedFrame ( #45667 )
...
feat: webContents.focusedFrame
2025-03-04 11:38:58 -05:00
electron-roller[bot]
54136042c6
chore: bump chromium to 135.0.7049.0 (main) ( #45885 )
...
* chore: bump chromium in DEPS to 135.0.7049.0
* 6312439: Revert "Preconnect to the Glic FRE when the button is hovered."
https://chromium-review.googlesource.com/c/chromium/src/+/6312439
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-04 11:20:25 -05:00
dependabot[bot]
28ed8a821a
build(deps): bump actions/download-artifact from 4.1.8 to 4.1.9 ( #45883 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](fa0a91b85d...cc20338598 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-04 12:44:46 +01:00
Niklas Wenzel
ec9b589402
ci: preserve blocked/* labels on collaborator comments ( #45877 )
...
ci: keep `blocked/*` labels on collaborator comments
2025-03-04 10:49:14 +01:00
marekharanczyk
2a7133b7a6
fix: correct electron gin embedder indices ( #45389 )
...
fix: correct gin embedder indices.
Move electron extra embedders to the end of the enum so they do not
interfere with chromium embedders indices.
Also use kEmbedderBlinkTag directly in its index calculation without
adding extra indices from other tags.
2025-03-03 17:03:54 -05:00
electron-roller[bot]
64158114aa
chore: bump chromium to 135.0.7047.0 (main) ( #45873 )
...
chore: bump chromium in DEPS to 135.0.7047.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-03 19:15:23 +01:00
electron-roller[bot]
e8631b2f3a
chore: bump chromium to 135.0.7047.0 (main) ( #45859 )
...
* chore: bump chromium in DEPS to 135.0.7043.0
* chore: bump chromium in DEPS to 135.0.7045.0
* 6305947: Preconnect to the Glic FRE when the button is hovered.
https://chromium-review.googlesource.com/c/chromium/src/+/6305947
* 6207093: Remove line_bounds from ImeCompositionRangeChanged
https://chromium-review.googlesource.com/c/chromium/src/+/6207093
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-03 14:26:52 +01:00
Sam Maddock
21ad7cdda5
test: service worker contextBridge leak ( #45852 )
...
* test: contextBridge prototype leak in service workers
* test: deep prototype checks
2025-03-01 09:56:03 +01:00
electron-roller[bot]
add374ef6a
chore: bump chromium to 135.0.7041.2 (main) ( #45850 )
...
* chore: bump chromium in DEPS to 135.0.7041.2
* [Extensions] Remove ExtensionsBrowserClient::GetUserAgent()
https://chromium-review.googlesource.com/c/chromium/src/+/6306854
* chore: update patches
* [api] Remove deprecated FunctionCallbackInfo::Holder()
https://chromium-review.googlesource.com/c/v8/v8/+/6309166
* [test] Add createExternalizableTwoByteString to extension
https://chromium-review.googlesource.com/c/v8/v8/+/6304942
* fixup [test] Add createExternalizableTwoByteString to extension
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-28 17:29:23 -05:00
David Sanders
eac270bea7
build: bump NMV to 135 ( #45789 )
2025-02-28 09:53:02 -05:00
co63oc
36ec9d7236
docs: fix spelling errors in code comments ( #45842 )
...
chore: Fix typos
2025-02-28 12:24:00 +01:00
Michaela Laurencin
3041fd66cd
docs: update timelines for E36 ( #45785 )
...
Update electron-timelines.md
2025-02-28 11:24:40 +01:00
Charles Kerr
b504f65ace
docs: update breaking-changes.md for 35.0.0 ( #45822 )
...
* docs: update breaking-changes.md for 35.0.0
* fixup! docs: update breaking-changes.md for 35.0.0
docs: make lint happy
2025-02-27 22:01:26 -06:00
electron-roller[bot]
5cb87b7110
chore: bump chromium to 135.0.7040.0 (main) ( #45846 )
...
chore: bump chromium in DEPS to 135.0.7040.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-27 21:59:50 -06:00
Charles Kerr
d19cac6772
docs: fix PrinterInfo info in breaking-changes.md ( #45843 )
...
> ### Removed:`isDefault` and `status` properties on `PrinterInfo`
> These properties have been removed from the PrinterInfo Object
> because they have been removed from upstream Chromium.
These properties won't be removed until Electron 36, but
breaking-changes.md lists them as being removed in 35.
This PR corrects the error.
2025-02-27 17:49:58 -06:00
Shelley Vohr
eac1a7ff68
fix: context-menu event emitted in draggable regions ( #45813 )
...
* fix: context-menu event emitted in draggable regions
* fix: only trigger on mouse release
2025-02-27 14:44:46 -05:00
electron-roller[bot]
00089a951b
chore: bump chromium to 135.0.7039.0 (main) ( #45836 )
...
* chore: bump chromium in DEPS to 135.0.7039.0
* chore: update patches
* extensions: Refactor ExtensionService GrantPermissionsAndEnableExtension
https://chromium-review.googlesource.com/c/chromium/src/+/6302374
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-27 13:20:42 -05:00
reito
b8d0f18ff8
docs: add docs about shared texture mode osr ( #45670 )
...
* docs: add docs about shared texture mode osr
* docs: add docs about shared texture mode osr
* docs: fix dot
* 更新 web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2025-02-27 11:10:58 -05:00
co63oc
96c2022483
chore: Fix typos ( #45825 )
2025-02-27 14:31:21 +01:00
Dietrich Ayala
ff05d4a96c
docs: dialog.md - typo fix s/wndow/window/ ( #45831 )
...
Update dialog.md - typo fix
2025-02-27 10:32:42 +01:00
Charles Kerr
989918a59c
refactor: simplify Invoker::IsOK() ( #45803 )
...
* refactor: simplify Invoker::IsOK()
* refactor: might as well make it [[nodiscard]] as well
2025-02-26 18:50:57 -06:00
electron-roller[bot]
6c4b5d81dd
chore: bump chromium to 135.0.7037.0 (main) ( #45811 )
...
* chore: bump chromium in DEPS to 135.0.7036.0
* chore: bump chromium in DEPS to 135.0.7037.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-26 17:30:11 +01:00
Charles Kerr
7d045dcddb
refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) ( #45793 )
...
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)
2025-02-25 19:50:09 -06:00
Charles Kerr
199f6d64db
perf: avoid redundant method calls in EventEmitter ( #45786 )
...
* refactor: move EventEmitter::EmitWithEvent() into EventEmitter::Emit()
* perf: remove redundant calls to isolate() in EventEmitter::Emit()
* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitEvent()
* perf: remove redundant calls to isolate() in EventEmitter::EmitWithoutEvent()
* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitWithoutEvent()
* refactor: remove unused method EventEmitter::isolate()
* refactor: remove unused method EventEmitter::GetWrapper(v8::Isolate*)
* refactor: remove unused method EventEmitter::GetWrapper()
refactor: make the EventEmitter::Base typedef private
* refactor: remove unused typedef EventEmitter::Base
See "Workarounds" section in
https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members
* refactor: remove redundant gin_helper:: namespace use
2025-02-25 19:20:33 -06:00
dependabot[bot]
b82e4585cf
build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 ( #45792 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9e8d0789d4...b56ba49b26 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 15:25:24 -05:00
electron-roller[bot]
9303a3fae9
chore: bump chromium to 135.0.7035.0 (main) ( #45764 )
...
* chore: bump chromium in DEPS to 135.0.7028.0
* chore: bump chromium in DEPS to 135.0.7029.0
* chore: bump chromium in DEPS to 135.0.7031.0
* chore: bump chromium in DEPS to 135.0.7033.0
* Split //component/embedder_support:browser_util into multiple targets
https://chromium-review.googlesource.com/c/chromium/src/+/6246155
* chore: update patches
* build: update filenames.libcxx.gni
* 6275531: Enable Float16Array
https://chromium-review.googlesource.com/c/chromium/src/+/6275531
* chore: bump chromium in DEPS to 135.0.7035.0
* chore: update patches
* Move Service Process Host files to a separate folder
https://chromium-review.googlesource.com/c/chromium/src/+/6089368
* Remove NOTREACHED()s after return statements
https://chromium-review.googlesource.com/c/chromium/src/+/6297811
* Move ServiceProcessTracker and UtilityProcessClient into separate files
https://chromium-review.googlesource.com/c/chromium/src/+/6088677
* chore: update filenames.libcxx.gni
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-25 15:16:15 -05:00
Keeley Hammond
9b6ba1ced1
fix: re-enable MacWebContentsOcclusion feature flag ( #45775 )
2025-02-25 09:28:09 -08:00
dependabot[bot]
7870ade07a
build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 ( #45791 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](62b2cac7ed...f49aabe0b5 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 08:13:06 +01:00
dependabot[bot]
9699422cd6
build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 ( #45790 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65c4c4a1dd...4cec3d8aa0 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 08:13:01 +01:00
Charles Kerr
3ee2ec8e4f
build: re-enable unsafe buffer checks ( #45770 )
2025-02-24 20:06:30 -06:00
Charles Kerr
0de1e8e610
refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor ( #45773 )
...
refactor: remove unused isolate arg from GlobalShortcut constructor
has not been used since f1a0d5e811 (#22755 )
2025-02-24 19:38:20 -06:00
Shelley Vohr
01554f39a8
revert: drag and drop icons on Windows ( #45779 )
...
This reverts commit 698cce6707 .
2025-02-24 11:35:29 -06:00
Charles Kerr
69eb076bca
refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc ( #45771 )
...
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
2025-02-24 11:09:01 -05:00
reito
f3259be73c
feat: remove osr framerate limit when use shared texture ( #45669 )
...
feat: remove framerate limit, if use shared texture osr.
2025-02-24 10:21:46 -05:00
David Sanders
698cce6707
fix: drag and drop icons on Windows ( #45767 )
2025-02-24 09:54:08 +01:00
Nilay Arya
3eab549369
docs: added upstream doc links for node, chromium, and v8 in default_app ( #45392 )
2025-02-22 10:15:36 -06:00
Shelley Vohr
3e51ee516e
fix: rework and improve legacyMainResolve patch ( #45754 )
...
fix: rework and improve legacyMainResolve patch
2025-02-22 10:06:04 -06:00
Sam Maddock
e3f61b465d
refactor: move extension APIs to session.extensions ( #45597 )
...
refactor: move extensions to session.extensions
2025-02-21 17:36:51 -06:00
Erick Zhao
a63f6143ea
docs: clarify navigationhistory offsets ( #45616 )
...
* docs: clarify navigationhistory offsets
* "relative offset"
2025-02-21 17:35:17 -06:00
Charles Kerr
2a383e9ddd
refactor: use C++20's contains() method ( #45742 )
...
* chore: use std::map<>::contains() instead of count() or find()
* chore: use std::map<>::contains() instead of base::Contains()
2025-02-21 17:33:43 -06:00
electron-roller[bot]
612da3ec47
chore: bump chromium to 135.0.7027.0 (main) ( #45677 )
...
* chore: bump chromium in DEPS to 135.0.7021.0
* chore: bump chromium in DEPS to 135.0.7023.0
* chore: update patches
* chore: gen-libc++-filenames.js
* [Extensions] Add a BUILD.gn file for the chrome.system.display API.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6227347
* chore: bump chromium in DEPS to 135.0.7025.0
* fixup! [Extensions] Add a BUILD.gn file for the chrome.system.display API.
* [DevTools] Add support for automatic workspace folders.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6275926
* Add UseCounter for potential PNA 2.0 breakage
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6259197
* Remove references to NavigationEntry/Controller in Zoom code.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6258070
* chore: update patches
* Allow DevTools to record UmaHistogramMediumTimes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6183713
* chore: update patches
* [gpu] Remove unnecessary media_buildflags include
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6286526
* chore: bump chromium in DEPS to 135.0.7027.0
* chore: update patches
* Remove type alias
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6280957
* [Refactor] Make ExtensionRegistrar a browser keyed service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6285230
* Remove unused functions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6278736
* chore: IWYU
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-02-21 14:46:51 -08:00
Keeley Hammond
6248c2436a
fix: re-enable synchronous spellcheck on Windows ( #45712 )
...
* fix: re-enable synchronous spellcheck on Windows
* revert: fix: empty suggestions with windows platform checker
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-02-21 14:45:46 -08:00
Charles Kerr
8d58999135
refactor: use base's map utills in WebFrameMain ( #45741 )
...
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameTreeNodeId()
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameToken()
2025-02-21 15:28:00 -06:00
Shelley Vohr
324fc0f62a
fix: crash on getUserMedia with invalid chromeMediaSourceId ( #45733 )
...
* fix: crash on getUserMedia with invalid chromeMediaSourceId
* test: add a test
2025-02-21 10:17:52 -06:00
Charles Kerr
f62668e2e3
refactor: use base::as_byte_span() in EncodeToken(). ( #45723 )
...
This matches the change in upstream's serial_chooser_context.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/5247305
2025-02-20 20:20:16 -05:00
Charles Kerr
a15fa87558
refactor: use base::as_bytes() in WriteAsciiChunk() ( #45724 )
...
refactor: use base::as_bytes() in WriteAsciiChunk()
this avoids a reinterpret_cast and a static_cast
2025-02-20 20:19:48 -05:00
Charles Kerr
ceaa0e26c7
refactor: use base::as_string_view() ( #45722 )
...
Use `base::as_string_view()` as a safer alternative to `reinterpret_cast`
in a couple of places.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5472408
2025-02-20 18:19:36 -06:00
Shelley Vohr
4867b5dc75
refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected ( #45671 )
...
* refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected
https://chromium-review.googlesource.com/c/chromium/src/+/5737296
* chore: review feedback
2025-02-20 16:44:35 -06:00
Shelley Vohr
340fdaf511
feat: allow setting roundedCorners on Windows ( #45594 )
...
* feat: allow setting roundedCorners on Windows
* Update docs/api/structures/base-window-options.md
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: Will Anderson <will@itsananderson.com >
2025-02-20 15:39:12 -05:00
Sam Maddock
5ea885c87f
build: skip chromium git cookie on forks ( #45735 )
2025-02-20 14:38:20 -05:00
Shelley Vohr
d8baceb08c
fix: crash loading about:blank in subframes ( #45694 )
...
fix: crash loading about:blank in subframes
2025-02-20 12:07:15 -05:00
Charles Kerr
d6f4982522
fix: possible timing issue in utility-process spec ( #45690 )
...
This fixture has been calling process.exit() immediately after writing
to stdout and stderr, which the Node.js docs say is risky behavior:
> Calling process.exit() will force the process to exit as quickly as
> possible even if there are still asynchronous operations pending that
> have not yet completed fully, including I/O operations to
> process.stdout and process.stderr.
This fixture's been around for years without problems (AFAIK).
The writes are very small ('hello\n' and 'world') and finish quickly.
But recently I've been testing on a very slow CI machine. There, I see
this spec flaking when it expects stderr to be 'world' but it gets ''.
This PR changes the fixture to wait for stdout & stderr to flush
before calling process.exit().
2025-02-19 23:28:04 -06:00
Sam Maddock
9d558cec5e
fix: action.openPopup function missing ( #45697 )
2025-02-19 18:05:02 -05:00
Shelley Vohr
159e1a42b3
refactor: track downloads by guid ( #45675 )
2025-02-19 16:49:34 -06:00
Sam Maddock
b50066f420
fix: extension web workers net request failing ( #45698 )
2025-02-19 13:08:28 -05:00
Milan Burda
22b7403cd1
chore: remove deprecated systemPreferences.isAeroGlassEnabled() ( #45563 )
2025-02-18 18:59:00 -06:00
Charles Kerr
670e0ca076
chore: disable 'should lock the keyboard' test on macOS ( #45681 )
2025-02-18 18:00:01 -06:00
Sam Maddock
ee67bc7dcb
fix: dangling speculative frames ( #45609 )
...
* fix: dangling speculative frames
* harden lifecycle state checks
* feedback
* add const
2025-02-18 17:52:05 -05:00
John Kleinschmidt
ecd7eb36ac
build: remove appveyor bake ( #45073 )
2025-02-18 12:04:47 -08:00
electron-roller[bot]
47572286f3
chore: bump chromium to 135.0.7015.0 (main) ( #45500 )
...
* https://chromium-review.googlesource.com/c/chromium/src/+/6230977
* chore: bump chromium to 135.0.7012.0
* chore: update accelerator.patch
Support parsing Ctrl+Alt shortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/6238137
* 6234236: Reapply bindings: Pass CppHeap on Isolate creation | https://chromium-review.googlesource.com/c/chromium/src/+/6234236
* 6234614: [ios blink] Move to use external begin frame source | https://chromium-review.googlesource.com/c/chromium/src/+/6234614
* chore: update chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
no manual changes; patch applied with fuzz
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch applied with fuzz
* chore: remove chromium/cherry-pick-dd8e2822e507.patch
landed upstream
* 6188884: Grit: Remove output_all_resource_defines from list of valid attributes. | https://chromium-review.googlesource.com/c/chromium/src/+/6188884
* 6226981: [views-ax] Remove View::GetAccessibleNodeData() method | https://chromium-review.googlesource.com/c/chromum/src/+/6226981
* 6214895: [views-ax] Deprecate View::NotifyAccessibilityEvent | https://chromium-review.googlesource.com/c/chromium/src/+/6214895
* 6196494: Remove ImageView::SetImage() with ImageSkia param | https://chromium-review.googlesource.com/c/chromium/src/+/6196494
* 6236267: [cleanup] Remove unused PrinterBasicInfo fields | https://chromium-review.googlesource.com/c/chromium/src/+/6236267
* refactor: remove status, isDefault properties from PrinterInfo
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6236267
* chore: lint
* fixup: added mas bypass to new file added in https://chromium-review.googlesource.com/c/chromium/src/+/6208630 see slack for more context
* chore: node script/gen-libc++-filenames.js
* chore: e patches all
* fix: duplicate crdtp symbols
* chore: update patches
* fixup! [Media Features] Remove launched features
---------
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-02-18 11:51:27 -05:00
Sam Maddock
6be1151ffc
fix: win.closeFilePreview recreates panel when called twice ( #45319 )
...
* fix: close quick look during tests on macOS
* use longer delay 🤷
* fix: sharedPreviewPanel being recreated on close
* test: ensure preview panel gets closed
2025-02-17 17:25:19 -05:00
Sam Maddock
c0422d7cc9
refactor: dispatch IPC messages from Session ( #45452 )
...
* refactor: dispatch IPC messages from Session
* refactor: move MessageHost to Session
2025-02-17 16:36:28 -05:00
reito
e9ba5876d1
fix: osr stutter fix backport for electron. ( #45572 )
2025-02-17 22:13:44 +01:00
Alice Zhao
02be7c1185
feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering ( #44692 )
...
* feat: add excludeUrls to web request filter
* refactor: add deprecated field
* test: update tests
* lint: newline
* docs: improve API doc
* fix: add is filter defined property to match all urls
* refactor: remove includeUrls
* refactor: remove typescript binding
* refactor: all_url
* refactor: remove isDefined methods
* refactor: remove comment
* fix: logic
* docs: add to breaking changes
2025-02-17 12:40:47 -08:00
Shelley Vohr
7dfcec931a
build: run source cache clean daily ( #45652 )
2025-02-17 13:57:22 -05:00
John Kleinschmidt
a329024793
build: make sure chromium cookie is set everywhere ( #45631 )
2025-02-14 13:19:43 -05:00
Robo
137a552641
fix: support for v8.setHeapSnapshotNearHeapLimit api ( #45606 )
...
* fix: support for v8.setHeapSnapshotNearHeapLimit api
* docs: add support
2025-02-14 10:00:39 -06:00
electron-roller[bot]
a841d6484c
chore: bump node to v22.14.0 (main) ( #45578 )
...
* chore: bump node in DEPS to v22.14.0
* src: move more crypto impl detail to ncrypto dep
https://github.com/nodejs/node/pull/56421
* test: move crypto related common utilities in common/crypto
https://github.com/nodejs/node/pull/56714
* module: add findPackageJSON util
https://github.com/nodejs/node/pull/55412
* module: mark evaluation rejection in require(esm) as handled
https://github.com/nodejs/node/pull/56122
* chore: fixup patch indices
* deps: move inspector_protocol to deps
https://github.com/nodejs/node/pull/56649
* fixup! src: move more crypto impl detail to ncrypto dep
* fixup! deps: move inspector_protocol to deps
* fixup! src: move more crypto impl detail to ncrypto dep
* crypto: fix checkPrime crash with large buffers
https://github.com/nodejs/node/pull/56559
* tls: fix error stack conversion in cryptoErrorListToException()
https://github.com/nodejs/node/pull/56554
* module: add findPackageJSON util
https://github.com/nodejs/node/pull/55412
Our revert of native legacyMainResolve makes this very difficult to make
work, so disable for now.
* lib: add typescript support to STDIN eval
https://github.com/nodejs/node/pull/56359
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-14 11:05:01 +01:00
Shelley Vohr
2af57c4b6a
fix: osr crash on window close ( #45573 )
2025-02-14 11:01:00 +01:00
Shelley Vohr
47dbab3856
fix: pointer lock permission after focus loss and regain ( #45574 )
2025-02-14 10:22:13 +01:00
Charles Kerr
a1e4550c9e
chore: disable flaky content tracing tests on Linux ( #45612 )
2025-02-14 10:18:42 +01:00
Charles Kerr
2b8706bf44
chore: change node test timeout from 20m to 30m ( #45611 )
2025-02-13 17:27:35 -06:00
Shelley Vohr
3a3595f2af
build: remove PDF edited saved files patch ( #45604 )
2025-02-13 14:52:31 -05:00
Shay Molcho
9a2ee763d0
docs: added missing period for consistency and readability ( #45333 )
...
Added missing period for consistency and readability
Added a missing period in a specific part of the text to maintain consistency across the document. This ensures a uniform writing style, improves readability, and aligns with the formatting used throughout the content.
2025-02-13 10:55:43 +01:00
Keeley Hammond
237429bb85
build: set chromium cookie on depot tools requests ( #45581 )
...
* build: set chromium cookie on depot tools requests
* build: correct secrets syntax
* build: handle windows cmd
2025-02-12 17:44:43 +01:00
Will Anderson
50d1c803dd
chore: remove var declarations from DEPS that no longer have any effect ( #45535 )
...
* chore: Remove checkout_google_benchmark var that no longer has any effect
This variable stopped having any effect in https://chromium-review.googlesource.com/c/chromium/src/+/4322306
It was removed from Chromium entirely in https://chromium-review.googlesource.com/c/chromium/src/+/4339138
* chore: remove checkout_oculus_sdk and checkout_libaom from DEPS
2025-02-12 10:51:11 +01:00
John Kleinschmidt
0d3e34d0be
test: disable unexpectedly quit dialog on macOS ( #45553 )
...
* test: disable unexpectedly quit dialog on macOS
* test: take screenshot before keyboard lock test
* Revert "test: take screenshot before keyboard lock test"
This reverts commit 3ba5c6984f .
2025-02-11 21:08:38 -05:00
Charles Kerr
aa06b065c0
chore: bump chromium to 134.0.6998.10 (main) ( #45564 )
...
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com >
2025-02-11 17:26:39 -06:00
Felix Rieseberg
9f47c9a051
feat: Restore webContents navigation history and page state ( #45433 )
...
* feat: Working navigationHistory.restore with just title/url
* feat: Restore page state, too
* chore: Docs, lint, tests
* Implement feedback
* More magic
* Make _awaitNextLoad truly private
* Implement API group feedback
* One more round of feedback
2025-02-11 15:09:38 -08:00
Will Anderson
6fdfca6e49
build: make gen-libc++-filenames.js produce the same results on Windows ( #45556 )
2025-02-11 12:56:05 +01:00
dependabot[bot]
196352bf0b
build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 ( #45561 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.8 to 3.28.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](dd746615b3...9e8d0789d4 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-11 11:39:29 +01:00
Robo
46d316692d
fix: asan build on macOS ( #45541 )
...
* fix: asan build on macOS
* chore: fix build
2025-02-11 15:04:07 +09:00
Josh Jancourtz
2f288bc7cc
docs: fix grammar in preload tutorial summary ( #45522 )
2025-02-10 16:15:32 -05:00
Calvin
f5025b6246
fix: avoid IPC for renderer webFrame.getZoom... APIs ( #45499 )
...
* fix: avoid IPC for renderer `webFrame.getZoom...` APIs
* Remove `DoGetZoomLevel` IPC
* Fix synchronous behavior & nullptr deref
* Use local root
2025-02-10 16:09:11 -05:00
Milan Burda
e055ce7c39
chore: deprecate systemPreferences.isAeroGlassEnabled() ( #45434 )
2025-02-10 15:17:07 -05:00
John Kleinschmidt
14fe0932f0
test: make sure test window is on top for focus tests ( #45435 )
2025-02-10 13:40:27 -05:00
dependabot[bot]
3ba85878a5
build(deps): bump github/codeql-action from 3.28.6 to 3.28.8 ( #45453 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.6 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](17a820bf2e...dd746615b3 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-10 19:40:01 +01:00
Keeley Hammond
70168c8bdc
fix: fix mksnapshot gen/v8 path ( #45488 )
...
* fix: fix mksnapshot gen/v8 path
* build: use 7z compression
* build: unzip mksnapshot on Windows and update zip
* chore: escape backslashes
* chore: try another attempt
* chore: remove rmdir for now
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-10 10:21:29 -05:00
Sam Maddock
e4cd162433
docs: fix powerMonitor event types ( #45518 )
...
* fix: powerMonitor event types
* fix: thermal-state-change missing Returns
2025-02-10 10:13:11 -05:00
Calvin
4085185e2d
docs: transactions-updated event type ( #45527 )
...
fix: `transactions-updated` event type
2025-02-10 10:12:17 -05:00
Shelley Vohr
a141f68c83
refactor: use node::tracing::Agent() directly ( #45489 )
...
refactor: use node::tracing::Agent()
2025-02-09 21:36:42 +01:00
Shelley Vohr
9199d5c610
fix: window maximizing with Mica ( #45456 )
...
* fix: window maximizing with Mica
* Fix rounded corners after restore
2025-02-07 15:00:36 -05:00
michal-pichlinski-openfin
96460becf9
fix: Update widget visibility in NativeWindowMac::ShowInactive ( #45427 )
...
When using `views::WebView` on macOS `NativeWidgetMacNSWindowHost`
contains a layer and compositor responsible for drawing web contents.
To trigger drawing `NativeWidgetMacNSWindowHost::OnVisibilityChanged`
needs to be called and `[NSWindow orderFrontRegardless]` does not trigger
`[NSWindow orderWindow:relativeTo:]` which can change
`NativeWidgetMacNSWindowHost` visiblity with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::OnVisibilityChanged()
-[ViewsNSWindowDelegate onWindowOrderChanged:]
-[NativeWidgetMacNSWindow orderWindow:relativeTo:]
```
`views::Widget` has method for showing inactive window:
`views::Widget::ShowInactive` which triggers
`NativeWidgetMacNSWindowHost::OnVisibilityChanged` with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMacNSWindowHost::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMac::Show(ui::mojom::WindowShowState, gfx::Rect const&)
views::Widget::ShowInactive() + 168
```
However this call seems to be insufficient to bring window to front,
therefore `[NSWindow orderFrontRegardless]` still needs to be called.
Calling `views::Widget::ShowInactive` ensures that all logic related to
showing Chromium widget will be properly executed, but onfortunately it
does not call `[NSWindow orderWindow:relativeTo:]` which is used to
disabling headless mode by the `ElectronNSWindow`, therefore we need to
trigger it manually through exposed `[ElectronNSWindow disableHeadlessMode]`.
Fixes : #45415
2025-02-07 11:31:08 -08:00
Charles Kerr
d7c6fb8250
refactor: follow upstream's suggestions on when to use EmptyGURL() ( #45498 )
...
- Prefer GURL() when we want to return a non-reference empty URL.
- In ServiceWorkerMain::GetStorageKey(), use a reference instead
of instantiating a new temporary GURL.
From url/gurl.h:
> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
2025-02-07 13:58:31 -05:00
Charles Kerr
3db691804b
chore: bump chromium 134.0.6990.0 ( #45507 )
...
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6219304
Partially upstreamed by @codebytere
* chore: e patches all
2025-02-07 10:25:46 -06:00
David Sanders
4512b2b5c4
chore: remove remaining references to AppVeyor ( #45339 )
2025-02-07 12:57:36 +01:00
John Kleinschmidt
7bde100a1a
build: make sure there is at least 35GB free for source cache ( #45501 )
...
build: make sure there is at least 35GB free for cache
2025-02-07 12:03:38 +01:00
Kavindu Udara
d0110d897d
docs: remove width and height params ( #45331 )
...
remove width and height params
2025-02-07 11:42:16 +01:00
Charles Kerr
ef34892a76
chore: bump chromium 134.0.6989.0 ( #45506 )
...
* chore: bump chromium to 134.0.6989.0
* chore: update patches/chromium/cherry-pick-dd8e2822e507.patch
* chore: e patches all
2025-02-07 10:00:09 +01:00
Charles Kerr
67f5ac5bbc
fix: RenderFrameHost nullptr dereference ( #45487 )
...
* fix: add nullptr tests before using render_frame_
* refactor: extract-method HasRenderFrame()
2025-02-06 22:02:57 -06:00
Milan Burda
517935cd55
refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor ( #45484 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
2025-02-07 10:44:19 +09:00
Samuel Attard
326957009a
chore: cherry-pick dd8e2822e507 from chromium ( #45495 )
2025-02-06 14:33:42 -08:00
electron-roller[bot]
213165a467
chore: bump chromium to 134.0.6988.0 (main) ( #45334 )
...
* chore: bump chromium in DEPS to 134.0.6976.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6171046
process_info_mac.cc -> process_info_mac.mm
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6196857
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6182296
https://chromium-review.googlesource.com/c/chromium/src/+/6183404
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
A lot changed in the upstream implementation. There's a good chance I got
this wrong as threading has changed and moved some variables into globals.
* chore: remove build_remove_vr_directx_helpers_dependency.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6186102
This landed upstream
* chore: e patches all
* chore: update net::CookieInclusionStatus::ExclusionReason enum
https://chromium-review.googlesource.com/c/chromium/src/+/6183252
https://chromium-review.googlesource.com/c/chromium/src/+/6185544
* chore: update content::WebAuthenticationDelegate import
https://chromium-review.googlesource.com/c/chromium/src/+/6189769
* Revert "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 1a57ba5d59 .
* chore: bump chromium in DEPS to 134.0.6978.0
* chore: bump chromium in DEPS to 134.0.6980.0
* chore: bump chromium in DEPS to 134.0.6982.0
* chore: bump chromium in DEPS to 134.0.6984.0
* 6196281: Allow direct embedder IsPdfInternalPluginAllowedOrigin() interaction
https://chromium-review.googlesource.com/c/chromium/src/+/6196281
* 6196283: Delete PdfInternalPluginDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/6196283
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6986.0
* chore: update patches
* 6205762: Support option to use window.showSaveFilePicker() in PDF attachment code
https://chromium-review.googlesource.com/c/chromium/src/+/6205762
See also:
* https://issues.chromium.org/issues/373852607
* 5939153: [PDF] Add PdfUseShowSaveFilePicker feature flag | https://chromium-review.googlesource.com/c/chromium/src/+/5939153
* 6205761: Delete spurious Ink-specific code in pdf_viewer.ts | https://chromium-review.googlesource.com/c/chromium/src/+/6205761
* 6209609: Remove WebVector: Automatic changes
https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6205488: UI: make QT5 optional
https://chromium-review.googlesource.com/c/chromium/src/+/6205488
* 6178281: Rename pak files from branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/6178281
* fixup! 6209609: Remove WebVector: Automatic changes https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6193249: Switch from safe_browsing::EventResult to enterprise_connectors:EventResult
https://chromium-review.googlesource.com/c/chromium/src/+/6193249
* 6197457: Remove Pause/ResumeReadingBodyFromNet IPCs
https://chromium-review.googlesource.com/c/chromium/src/+/6197457
* 6191230: Record total time spent on a picture in picture window
https://chromium-review.googlesource.com/c/chromium/src/+/6191230
* chore: bump chromium in DEPS to 134.0.6988.0
* chore: update patches
* 6215440: Remove base/ranges/.
https://chromium-review.googlesource.com/c/chromium/src/+/6215440
* Disable unsafe buffers error
Not sure what changed, but we're now seeing unsafe buffer errors in Chromium code, at least when using reclient. Will update this comment if we find out the cause.
* 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* fix `setDisplayMediaRequestHandler` test
Given how this test is written, I would expect this assertion to be false. It seems the oppositue was true before, but that was also acknowledged to be suprising. Seems that the underlying implementation is now fixed and works as expected.
* fixup! 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* chore: udpate patches
* Multiple PRS: https://chromium-review.googlesource.com/c/chromium/src/+/6185544 | https://chromium-review.googlesource.com/c/chromium/src/+/6183252
* fix: cast enum class to numeric type
* fix: add 1 to MAX_EXCLUSION_REASON because enum values are zero-based, and we want the total count of reasons.
* Reapply "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 760b1a519b .
* refactor: use ExclusionReasonBitset::kValueCount for size
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-06 15:30:54 -05:00
David Sanders
3dad07f338
test: dump Electron process PID to path if environment variable set ( #45481 )
2025-02-06 09:15:10 -06:00
Anh Le
6adc737a89
docs: use correct headings in tutorial/security.md ( #45397 )
2025-02-06 11:16:24 +01:00
max54nj
c0282eb9c8
docs: style fixes ( #45458 )
...
* docs: fix code field
* docs: add missing space
2025-02-05 15:10:07 -05:00
Maria Alejandra Arias Frontanilla
471b1a873d
fix: fix typo in docs why-electron.md ( #45437 )
2025-02-05 09:26:47 -06:00
Shelley Vohr
aee8ea8b10
fix: WCO not working with some window configurations ( #45422 )
2025-02-05 12:48:51 +01:00
Shelley Vohr
57cf4fc846
fix: legacyMainResolve respecting permission model ( #45421 )
...
fix: legacyMainResolve respecting permission model
2025-02-05 12:48:34 +01:00
Charles Kerr
9fe12cd01b
fix: handle exclude aliasing in InclusionStatusToString() ( #45454 )
...
* refactor: use MakeFixedFlatMap() in InclusionStatusToString()
* fix: add log message for EXCLUDE_ALIASING
refactor: add static_assert() to ensure our messages stay
in sync with the CookieInclusion reasons in net/cookies/
2025-02-05 12:48:11 +01:00
Shelley Vohr
6486ce8191
build: remove debugger agent timeout patch ( #45457 )
2025-02-05 12:47:54 +01:00
Robo
bec6ddda70
feat: route deprecated sync clipboard read through permission checks ( #45377 )
...
* feat: route deprecated clipboard commands through permission checks
* docs: address review feedback
* fix: enable checks for child windows
2025-02-05 15:13:29 +09:00
Shelley Vohr
e9d5eeb118
build: try removing embedder exception patch ( #45429 )
2025-02-04 19:39:20 +01:00
Keeley Hammond
c147e4fa81
build: add win toolchain for release builds ( #45380 )
...
* build: add win toolchain for release builds
* build: fix installed_software.json script
* chore: run pwsh script within src
* build: fixup uploader arch
2025-02-03 22:06:01 -08:00
Niklas Wenzel
1d27a27813
docs: document deletion of databases directory ( #45412 )
2025-02-03 16:28:44 -05:00
Niklas Wenzel
d3bead5e0e
docs: mention C++20 requirement in breaking changes document ( #45413 )
...
* docs: mention C++20 requirement in breaking changes document
* chore: fix linter issue
2025-02-03 13:19:26 -08:00
David Sanders
9f1bb531ba
build: always use python3 in script/lib/get-version.js ( #45400 )
...
build: always use python3 in script/lib/get-version.js
2025-02-03 16:13:36 -05:00
Shelley Vohr
9971087678
build: remove outdated Node.js serdes patch ( #45401 )
...
build: remove outdates Node.js serdes patch
2025-02-03 14:09:02 +01:00
Shelley Vohr
e7fa5c709c
fix: incorrect WCO tooltip in RTL ( #45405 )
2025-02-03 10:50:50 +01:00
Shelley Vohr
7a1d410e0a
fix: default path not working on KDE Linux ( #45402 )
2025-02-03 09:49:48 +01:00
Sam Maddock
e2a7981dd3
feat: view.getVisible() ( #44999 )
...
* feat: view.getVisible()
* test: visible apis
* docs: clarify getVisible
2025-01-31 13:27:16 -05:00
Sam Maddock
26da3c5d6e
feat: service worker preload scripts for improved extensions support ( #44411 )
...
* feat: preload scripts for service workers
* feat: service worker IPC
* test: service worker preload scripts and ipc
2025-01-31 09:32:45 -05:00
Shelley Vohr
bc22ee7897
build: fix slack-github-action for backports ( #45388 )
...
build: fix slack-github-action for backports
2025-01-31 10:29:50 +01:00
Shelley Vohr
784201ecee
build: try removing Read/WriteBarrier patch ( #45393 )
...
build: try removing Read/WriteBarrier patch
2025-01-31 10:29:34 +01:00
Shelley Vohr
6e72cbb5e0
fix: multiple directory selection on Linux ( #45373 )
2025-01-30 16:34:44 +01:00
Shelley Vohr
233b99a0a8
chore: update chrome.scripting.execute logic ( #45369 )
...
chore: update chrome.scripting.execute logic
Refs:
- https://chromium-review.googlesource.com/c/chromium/src/+/6123601
- https://chromium-review.googlesource.com/c/chromium/src/+/6142377
- https://chromium-review.googlesource.com/c/chromium/src/+/6173554
2025-01-30 12:56:44 +01:00
Shelley Vohr
43e328f363
chore: update pdf_viewer_private.idl ( #45370 )
...
chore: update pdf_viewer_private.idl
- https://chromium-review.googlesource.com/c/chromium/src/+/6160067
2025-01-30 11:03:27 +01:00
John Kleinschmidt
8543820d98
build: fixup concurrent builds on protected branches ( #45355 )
2025-01-29 16:47:25 -05:00
electron-roller[bot]
93f4a93e12
chore: bump node to v22.13.1 (main) ( #45307 )
...
* chore: bump node in DEPS to v22.13.1
* chore: fixup GN build file
* https://github.com/nodejs/node/pull/55529
* https://github.com/nodejs/node/pull/55798
* https://github.com/nodejs/node/pull/55530
* module: simplify --inspect-brk handling
https://github.com/nodejs/node/pull/55679
* src: fix outdated js2c.cc references
https://github.com/nodejs/node/pull/56133
* crypto: include openssl/rand.h explicitly
https://github.com/nodejs/node/pull/55425
* build: use variable for crypto dep path
https://github.com/nodejs/node/pull/55928
* crypto: fix RSA_PKCS1_PADDING error message
https://github.com/nodejs/node/pull/55629
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* test,crypto: make crypto tests work with BoringSSL
https://github.com/nodejs/node/pull/55491
* fix: suppress clang -Wdeprecated-declarations in libuv
https://github.com/libuv/libuv/pull/4486
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
* test: make test-node-output-v8-warning more flexible
https://github.com/nodejs/node/pull/55401
* [v22.x] Revert "v8: enable maglev on supported architectures"
https://github.com/nodejs/node/pull/54384
* fix: potential WIN32_LEAN_AND_MEAN redefinition
https://github.com/c-ares/c-ares/pull/869
* deps: update nghttp2 to 1.64.0
https://github.com/nodejs/node/pull/55559
* src: provide workaround for container-overflow
https://github.com/nodejs/node/pull/55591
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* chore: fixup patch indices
* fixup! module: simplify --inspect-brk handling
* lib: fix fs.readdir recursive async
https://github.com/nodejs/node/pull/56041
* lib: avoid excluding symlinks in recursive fs.readdir with filetypes
https://github.com/nodejs/node/pull/55714/
This doesn't currently play well with ASAR - this should be fixed in a follow up
* test: disable CJS permission test for config.main
This has diverged as a result of our revert of
src,lb: reducing C++ calls of esm legacy main resolve
* fixup! lib: fix fs.readdir recursive async
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-29 15:41:00 -05:00
Robo
ecd5d0a3a4
fix: crash in gin::wrappable::secondweakcallback ( #45368 )
2025-01-29 10:20:37 -08:00
Niklas Wenzel
8cf2e46c1f
docs: reference security guide in ipcRenderer.on docs ( #45325 )
2025-01-29 12:50:20 +01:00
dependabot[bot]
50387043d1
build(deps): bump github/codeql-action from 3.28.1 to 3.28.6 ( #45351 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.1 to 3.28.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b6a472f63d...17a820bf2e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-29 07:01:15 +01:00
Keeley Hammond
e715607178
build: use Python311 exe ( #45360 )
...
build: yse Python311 exe
2025-01-28 11:59:04 -08:00
Milan Burda
0e388bce3e
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist ( #45318 )
...
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist
2025-01-28 14:58:48 +01:00
dependabot[bot]
9457a56607
build(deps): bump actions/setup-node from 4.1.0 to 4.2.0 ( #45353 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](39370e3970...1d0ff469b7 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 14:57:39 +01:00
dependabot[bot]
f9553a35d5
build(deps): bump actions/stale from 9.0.0 to 9.1.0 ( #45354 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](28ca103628...5bef64f19d )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 14:56:34 +01:00
dependabot[bot]
e2ef160beb
build(deps): bump actions/checkout from 4.1.6 to 4.2.2 ( #45352 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 10:48:35 +01:00
David Lönnhager
ae56a03e33
fix: crash parsing CLSID in shell.readShortcutLink() ( #45195 )
...
* fix: crash parsing CLSID in shell.readShortcutLink
* fix: ignore clsid if it could not be set
2025-01-27 15:22:56 -05:00
Keeley Hammond
4629e449a9
build: remove generate-sas-token ( #45347 )
2025-01-27 12:21:53 -08:00
Keeley Hammond
74c6669a8e
build: use windows builders for win-publish ( #45340 )
2025-01-24 14:43:38 -08:00
Niklas Wenzel
5c67cd9150
docs: fix broken code in drag and drop example ( #45332 )
2025-01-24 13:28:30 -08:00
Niklas Wenzel
f66a0c2acf
build: create maintainer issue template and disable blank issues ( #45309 )
...
* build: create maintainer task issue template and disable blank issues
* Implement review feedback by @dsanders11
* Rename issue template file
2025-01-24 13:28:05 -08:00
Sam Maddock
a467d0684e
feat: ServiceWorkerMain ( #45232 )
...
* feat: ServiceWorkerMain
* refactor: disconnect remote
* handle version_info_ nullptr case
* initiate finish request when possible and enumerate errors
* explicit name for test method
* oops
* fix: wait for redundant version to stop before destroying
* docs: clarify when undefined is returned
* chore: remove extra semicolons
2025-01-24 08:33:44 -05:00
electron-roller[bot]
75eac86506
chore: bump chromium to 134.0.6968.0 (main) ( #45172 )
...
* chore: bump chromium in DEPS to 134.0.6948.0
* chore: update can_create_window.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6151982
no patch code changes, but had to manually apply due to upstream context shear
* chore: update proxy_config_monitor.patch
no manual changes; patch applied with fuzz 2
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6126219
* chore: update build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6149256
* chore: update adjust_accessibility_ui_for_electron.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6105650
no patch code changes, but had to manually apply due to upstream context shear
* chore: e patches all
* chore: use fully-qualified path for all.gn
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* chore: do not use a variable when assigning rtc_use_h264
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* Move GlobalShortcutListenerLinux to //ui/base
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6097375
* [MPArch Guest View] Make WebPreferences queried per frame tree root
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6096390
* [Status Icons] Allow vector resources
https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* [Extensions] Move MatchOriginAsFallbackBehavior to Mojom
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6141793
* Remove StrongAlias::Hasher
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6132291
* Rename text-change and select-change methods and related stuff
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6148816
* [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker
https://chromium-review.googlesource.com/c/chromium/src/+/6115161
* [Extensions Cleanup] Move creation of tab-based ports to factory method
https://chromium-review.googlesource.com/c/chromium/src/+/6143725
* refactor: add StatusIconGtk::SetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
copied from chrome/browser/status_icons/status_icon.cc
* refactor: add TrayIconLinux::GetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
remove unused filter_ field
* chore: bump chromium in DEPS to 134.0.6950.0
* chore: bump chromium in DEPS to 134.0.6952.0
* chore: bump chromium in DEPS to 134.0.6954.0
* chore: bump chromium in DEPS to 134.0.6956.0
* chore: update Chromium patches
* 6165749: Check scanout support in RenderableGpuMemoryBufferPool | https://chromium-review.googlesource.com/c/chromium/src/+/6165749
* 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6958.0
* chore: bump chromium in DEPS to 134.0.6960.0
* chore: update chromium patches
* 6168371: Remove extensions GlobalShortcutListener wrapper | https://chromium-review.googlesource.com/c/chromium/src/+/6168371
* chore: update patches
* 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | https://chromium-review.googlesource.com/c/chromium/src/+/6161637
* chore: bump chromium in DEPS to 134.0.6962.0
* 6177329: Remove policy.used_policy_certificates pref on ChromeOS | https://chromium-review.googlesource.com/c/chromium/src/+/6177329
* 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | https://chromium-review.googlesource.com/c/chromium/src/+/6180524
* 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6144831
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6964.0
* 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | https://chromium-review.googlesource.com/c/chromium/src/+/6181010
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6966.0
* 6180598: [api] Remove Reallocate | https://chromium-review.googlesource.com/c/v8/v8/+/6180598
* 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | https://chromium-review.googlesource.com/c/chromium/src/+/6170781
* chore: update filenames.libcxx.gni
* 6168207: cdm: Remove widevine_cdm_version.h | https://chromium-review.googlesource.com/c/chromium/src/+/6168207
* chore: bump chromium in DEPS to 134.0.6968.0
* 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | https://chromium-review.googlesource.com/c/chromium/src/+/6030552
* fix: use explicit copy to replace realloc impl
https://chromium-review.googlesource.com/c/v8/v8/+/6180598
https://issues.chromium.org/issues/331326406
As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway"
* fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* fix: undefine win32 StrCat
https://chromium-review.googlesource.com/c/chromium/src/+/6172292
* fix: //device/vr:directx_helpers breaking the build
https://chromium-review.googlesource.com/c/chromium/src/+/6064548
Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/6186102
* fix: avoid calling ui::Layer::SetFillsBoundsOpaquely
https://chromium-review.googlesource.com/c/chromium/src/+/6175787
The layer opacity is determined by the background color's alpha value
* fix: build with proprietary_codecs
The explicit setting of rtc_use_h264 is no longer needed since
https://webrtc-review.googlesource.com/c/src/+/62380
* fix: increase empty trace file size threshold
https://chromium-review.googlesource.com/c/chromium/src/+/6176642
Traces now contain a net-constants property to allow them to be converted to a net log.
These contain ~1240 new properties with formatted JSON data.
* fix: node tests missing resource management globals
https://chromium-review.googlesource.com/c/chromium/src/+/6174695
* fixup! fix: use explicit copy to replace realloc impl
* chore: disable focus handling test due to win32/ia32 regression
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org >
2025-01-23 23:07:43 -05:00
Sam Maddock
996477152d
feat: contextBridge.executeInMainWorld ( #45229 )
2025-01-23 21:12:46 -05:00
Sam Maddock
e09577b123
feat: redesign preload APIs ( #45230 )
...
* feat: redesign preload APIs
* docs: remove service-worker mentions for now
* fix lint
* remove service-worker ipc code
* add filename
* fix: web preferences preload not included
* fix: missing common init
* fix: preload bundle script error
2025-01-23 21:12:23 -05:00
Felix Rieseberg
26d228ccfe
docs: Add note about directly exposing Electron APIs in preload ( #45241 )
...
* docs: Add note about directly exposing Electron APIs in preload
* Implement feedback
2025-01-23 13:59:00 -08:00
Keeley Hammond
aafb1ba72c
build: migrate Windows release builds to GHA ( #45137 )
...
* build: migrate release builds to GHA
* build: alter CI jobs release script
2025-01-23 14:10:24 -05:00
Charles Kerr
db7ef90159
chore: better logging if Node initialization fails ( #45286 )
...
feat: better logging if Node initialization fails
2025-01-23 08:55:28 -06:00
electron-roller[bot]
863faea542
chore: bump node to v22.11.0 (main) ( #44530 )
...
* chore: bump node in DEPS to v22.11.0
* src: move evp stuff to ncrypto
https://github.com/nodejs/node/pull/54911
* crypto: add Date fields for validTo and validFrom
https://github.com/nodejs/node/pull/54159
* module: fix discrepancy between .ts and .js
https://github.com/nodejs/node/pull/54461
* esm: do not interpret "main" as a URL
https://github.com/nodejs/node/pull/55003
* src: modernize likely/unlikely hints
https://github.com/nodejs/node/pull/55155
* chore: update patch indices
* crypto: add validFromDate and validToDate fields to X509Certificate
https://github.com/nodejs/node/pull/54159
* chore: fixup perfetto patch
* fix: clang warning in simdjson
* src: add receiver to fast api callback methods
https://github.com/nodejs/node/pull/54408
* chore: fixup revert patch
* fixup! esm: do not interpret "main" as a URL
* fixup! crypto: add Date fields for validTo and validFrom
* fix: move ArrayBuffer test patch
* src: fixup Error.stackTraceLimit during snapshot building
https://github.com/nodejs/node/pull/55121
* fix: bad rebase
* chore: fixup amaro
* chore: address feedback from review
* src: revert filesystem::path changes
https://github.com/nodejs/node/pull/55015
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-22 12:16:26 -05:00
Shelley Vohr
5aabb6bec5
fix: potential crash in chrome.tabs.update() ( #45276 )
...
fix: potential crash in chrome.tabs.update()
2025-01-22 10:02:29 -06:00
dependabot[bot]
5e05dff949
build(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0 ( #45274 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](6f51ac03b9...65c4c4a1dd )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-22 12:29:23 +01:00
Maksim Sisov
3ea623364b
feat: support global shortcuts via GlobalShortcutsPortal feature with ozone/wayland ( #45171 )
...
* fix: backport patch to fix systemd unit activation in Chromium
This backports a patch from Chromium, which fixes systemd unit
activation. That is, a globalShortcuts feature that Chromium has
needs to create a systemd unit and rename it properly. Portal's
global shortcuts uses that name afterwards to map the app with
the shortcuts bound. However, there might be a race between
Chromium binding shortcuts and renaming the unit.
This is a first step to add Portal's globalShortcuts to
Electron.
* feat: Support global shortcuts via GlobalShortcutsPortal feature
Chromium has a new feature called GlobalShortcutsPortal. It
allows clients to use Portal's globalShortcuts to register and
listen to shortcuts.
This patches adds necessary bits, which allows Electron to
use that feature.
In order to make it work, one has to add
--enable-features=GlobalShortcutsPortal
Test: tested manually with a sample app.
* docs: add GlobalShortcutsPortal feature to globalShortcuts docs
Electron supports Portal's globalShortcuts API now via Chromium, and Electron
apps can use that in a Wayland session. Update the docs with the required
feature flag that must be passed to be able to use that implementation.
2025-01-22 11:59:48 +01:00
Erick Zhao
cf67dc8898
docs: add DocCardList component for index doc ( #45275 )
2025-01-22 10:27:30 +01:00
David Sanders
d7b568a1c0
ci: fix issue workflow failures ( #45294 )
2025-01-22 09:40:10 +01:00
Charles Kerr
fe9031eb23
refactor: in StopTracing(), use string literals instead of optional<string> ( #45270 )
...
refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>
We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
2025-01-21 17:41:52 -06:00
Charles Kerr
f5eba67f0d
refactor: simplify ParseUserScript() ( #45269 )
...
refactor: simplify ParseUserScript()
local variable user_script no longer needed after #43205
2025-01-21 15:21:56 -05:00
Charles Kerr
e1762e6e44
fix: consume the file permission callback when used ( #45267 )
...
fixes 0e5fe3f regression
2025-01-21 11:59:38 -06:00
Shelley Vohr
9d32b6ddfc
fix: webContents.print() with OOP printing ( #45266 )
...
* fix: webContents.print() with OOP printing
* Update patches/chromium/printing.patch
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-01-21 11:39:21 -05:00
David Sanders
7a413ff2ad
ci: don't fail issue triage workflows if issue not found on project ( #45252 )
2025-01-21 16:06:24 +01:00
Shelley Vohr
0090d171fd
chore: align clipboard blink::web_pref::WebPreferences with upstream ( #45277 )
...
chore: align clipboard blink::web_pref::WebPreferences with upstream
2025-01-21 06:50:36 -08:00
dependabot[bot]
980b68e9cc
build(deps): bump github/codeql-action from 3.28.0 to 3.28.1 ( #45272 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](48ab28a6f5...b6a472f63d )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-21 15:12:42 +01:00
dependabot[bot]
44a630e634
build(deps): bump mikefarah/yq from 4.44.6 to 4.45.1 ( #45271 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.6 to 4.45.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](4839dbbf80...8bf425b4d1 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-21 15:12:29 +01:00
Shelley Vohr
81d12fa452
build: fix clang-format duplicate message ( #45235 )
2025-01-20 11:05:40 +01:00
Shelley Vohr
83666ddc36
fix: page scaling in silent mode printing ( #45218 )
2025-01-20 11:05:15 +01:00
Shelley Vohr
fa5de40f86
fix: two possible FSA crashes ( #45233 )
...
* 5786874: Change Observer: Fix crash when navigating to new page
https://chromium-review.googlesource.com/c/chromium/src/+/5786874
* 5794141: Change Observer: Fix Get*PermissionGrant crash
https://chromium-review.googlesource.com/c/chromium/src/+/5794141
2025-01-20 10:23:57 +01:00
Shelley Vohr
7d05fb2a1b
fix: broken OOP window.print() on macOS/Linux ( #45214 )
...
fix: broken OOP printing on macOS/Linux
2025-01-20 10:23:44 +01:00
Sam Maddock
51a249f380
chore: skip flaky contentTracing test ( #45240 )
2025-01-20 09:57:10 +01:00
Sam Maddock
90754e5fd2
test: quit Finder ( #45239 )
2025-01-20 09:54:26 +01:00
Shelley Vohr
0e5fe3fa60
fix: getAsFileSystemHandle failure when drag-dropping two directories ( #45234 )
...
fix: drag-dropping two directories
2025-01-20 09:54:12 +01:00
michal-pichlinski-openfin
6953f5505f
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #44628 )
...
* refactor: remove InspectableWebContentsViewMac in favor of the Views version
* cherry-pick: refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )
commit e67ab9a93d
Confilcts not resolved, except removal of the files removed
by the original commit.
* resolved conflicts and build issues after cherry-pick
* cherry-picked: fix: add method allowing to disable headless mode in native widget
https://github.com/electron/electron/pull/42996
fixing
https://github.com/electron/electron/issues/42995
* fix: displaying select popup in window created as fullscreen window
`constrainFrameRect:toScreen:` is not being call for windows created
with `fullscreen: true` therefore `headless` mode was not being removed
and `RenderWidgetHostNSViewBridge::DisplayPopupMenu` ignored displaying
popup.
Issue could be fixed by placing additional removal of `headless` mode
in the `toggleFullScreen:`, but `orderWindow:relativeTo:` is called
both for a regular and a fullscreen window, therefore there will be
a single place fixing both cases.
Because `electron::NativeWindowMac` lifetime may be shorter than
`ElectronNSWindow` on which macOS may execute `orderWindow:relativeTo:`
we need to clear `shell_` when `NativeWindow` is being closed.
Fixes #43010 .
* fix: Content visibility when using `vibrancy`
We need to put `NSVisualEffectView` before `ViewsCompositorSuperview`
otherwise when using `vibrancy` in `BrowserWindow` `NSVisualEffectView`
will hide content displayed by the compositor.
Fixes #43003
Fixes #42336
In fact main issues reported in these tickets were not present after
cherry-picking original refactor switching to `views::WebView`, so
text could be selected and click event was properly generated. However
both issues testcases were using `vibrancy` and actual content was
invisible, because it was covered by the `NSVisualEffectView`.
* fix: EXCEPTION_ACCESS_VIOLATION crash on BrowserWindow.destroy()
Restored postponed deletion of the `NativeWindow`.
Restoration caused `DCHECK(new_parent_ui_layer->GetCompositor());` failure
in `BrowserCompositorMac::SetParentUiLayer` after the spec test:
`chrome extensions chrome.webRequest does not take precedence over Electron webRequest - http`
with stack:
```
7 Electron Framework 0x000000011fe07830 content::BrowserCompositorMac::SetParentUiLayer(ui::Layer*) + 628
8 Electron Framework 0x000000011fe0c154 content::RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer*) + 220
9 Electron Framework 0x000000011fe226a8 content::WebContentsViewMac::CreateViewForWidget(content::RenderWidgetHost*) + 600
10 Electron Framework 0x000000011fd37e4c content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager(content::RenderViewHost*) + 164
11 Electron Framework 0x000000011fb32278 content::RenderFrameHostManager::CreateSpeculativeRenderFrame(content::SiteInstanceImpl*, bool, scoped_refptr<content::BrowsingContextState> const&) + 816
12 Electron Framework 0x000000011fb2ab8c content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost(content::SiteInstanceImpl*, content::SiteInstanceImpl*, bool) + 1308
13 Electron Framework 0x000000011fb28598 content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, content::BrowsingContextGroupSwap*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) + 1796
14 Electron Framework 0x000000011fa78660 content::NavigationRequest::SelectFrameHostForOnRequestFailedInternal(bool, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&) + 280
15 Electron Framework 0x000000011fa6a994 content::NavigationRequest::OnRequestFailedInternal(network::URLLoaderCompletionStatus const&, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&, bo
+ 1008
16 Electron Framework 0x000000011fa7772c content::NavigationRequest::OnRequestFailed(network::URLLoaderCompletionStatus const&) + 72
17 Electron Framework 0x000000011f8554ac content::NavigationURLLoaderImpl::NotifyRequestFailed(network::URLLoaderCompletionStatus const&) + 248
```
This was probably the reason of removing `NativeWindow` immediately
in order to cleanup `views_host_` in `WebContentsViewMac` to prevent
using layer without compositor in `WebContentsViewMac::CreateViewForWidget`.
`[ElectronNSWindowDelegate windowWillClose:]` is deleting window host
and the compositor used by the `NativeWindow` therefore detach `NativeWindow`
contents from parent. This will clear `views_host_` and prevent failing
mentioned `DCHECK`.
Fixes #42975
* chore: Applied review suggestions
* refactor: directly cleanup shell
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-01-17 10:21:10 -05:00
Felix Rieseberg
45f90cd5dd
docs: Why Electron? ( #45191 )
...
* docs: Why Electron?
* Apply suggestions from code review
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/why-electron.md
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-01-15 18:32:56 -05:00
Anny Yang
8294f44c74
docs: remove quickstart ( #45194 )
2025-01-15 14:42:53 -08:00
Calvin
6f7999ad0d
fix: session.clearData avoidClosingConnections default to false ( #45187 )
2025-01-15 11:38:50 -05:00
Keeley Hammond
d829ee3145
build: bump NMV to 133 ( #45145 )
2025-01-15 11:36:34 -05:00
Keeley Hammond
88b4e1a9b7
build: bump actions/cache past deprecated version ( #45192 )
2025-01-15 11:33:46 +01:00
dependabot[bot]
7c784a1758
build(deps): bump actions/setup-node from 4.0.4 to 4.1.0 ( #45049 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.4 to 4.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/v4.0.4...39370e3970a6d050c480ffad4ff0ed4d3fdee5af )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-15 11:06:10 +01:00
wujinli
5680c628b6
fix: only remove the 'v' prefix from the git tag name ( #45132 )
...
In the old version of get-version.js, it replaces the leading 'v',
i.e. |output.stdout.toString().trim().replace(/^v/g, '')|. However,
in the new version of get-git-version.py, it directly replaces all
'v'. Obviously, it does not conform to the original semantics.
Although it will not affect the existing electron version calculation,
it may affect other developers' customized git-tag-version, such as
v0.0.0-dev.xxx, which will lose the 'v' of dev.
2025-01-13 22:36:03 -05:00
Calvin
e57b69f106
docs: correct breaking changes versions ( #45173 )
2025-01-13 14:15:24 -08:00
Michaela Laurencin
19ee4464c2
docs: update timelines for E35 ( #45167 )
2025-01-10 16:21:08 -08:00
electron-roller[bot]
7d05b78479
chore: bump chromium to 133.0.6920.0 (main) ( #45055 )
...
* chore: bump chromium in DEPS to 133.0.6902.0
* chore: bump chromium in DEPS to 133.0.6903.0
* chore: update patches
* Update PdfViewer Save File Picker to use showSaveFilePicker.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6074308
* Code Health: Clean up stale MacWebContentsOcclusion
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Change RenderProcessHost::GetID to RenderProcessHost::GetDeprecatedID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6065543
* [WebRTC] Make WebRTC IP Handling policy a mojo enum
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6063620
* chore: gen filenames.libcxx.gni
* Remove allow_unsafe_buffers pragma in //printing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6092280
* refactor: to use ChildProcessId where possible
Refs https://issues.chromium.org/issues/379869738
* [Win] Update TabletMode detection code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6003486
* chore: bump chromium in DEPS to 133.0.6905.0
* chore: update patches
* Reland "Move global shortcut listener to //ui/base"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6099035
* [shared storage] Implement the batch `with_lock` option for response header
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6072742
* chore: bump chromium in DEPS to 133.0.6907.0
* chore: bump chromium in DEPS to 133.0.6909.0
* chore: bump chromium in DEPS to 133.0.6911.0
* chore: bump chromium in DEPS to 133.0.6912.0
* chore: update patches
* WebUI: Reveal hidden deps to ui/webui/resources.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6096291
* chore: bump chromium in DEPS to 133.0.6913.0
* chore: bump chromium in DEPS to 133.0.6915.0
* Code Health: Clean up stale base::Feature "AccessibilityTreeForViews"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6104174
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix: remove fastapitypedarray usage
* chore: update patches
* chore: script/gen-libc++-filenames.js
* Code Health: Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6109477
* fix: empty suggestions with windows platform checker
Amends the fix from https://github.com/electron/electron/pull/29690
since the feature flag is no longer available. We follow the
same pattern as //chrome/browser/renderer_context_menu/spelling_menu_observer.cc
to generate the suggestion list on demand when context menu action
is invoked.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fixup! fix: empty suggestions with windows platform checker
* fixup! fix: empty suggestions with windows platform checker
* revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Revert "revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344 "
This reverts commit 9cacda452e .
* chore: bump to 133.0.6920.0, update patches
* Revert "6078344: Code Health: Clean up stale MacWebContentsOcclusion"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* fixup! Update PdfViewer Save File Picker to use showSaveFilePicker.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-01-10 10:52:34 -06:00
Charles Kerr
062d14e553
perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set ( #45143 )
...
* perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set
* chore: remove unused #include
2025-01-08 20:46:17 -06:00
Charles Kerr
59ed1db9a2
refactor: remove redundant CreateExtensionsClient() ( #45135 )
2025-01-08 10:36:08 -06:00
dependabot[bot]
da8288106b
build(deps): bump github/codeql-action from 3.27.9 to 3.28.0 ( #45090 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.9 to 3.28.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](df409f7d92...48ab28a6f5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-06 15:11:28 -05:00
dependabot[bot]
679eb3c266
build(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #45089 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](b4b15b8c7c...6f51ac03b9 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-06 15:11:06 -05:00
David Sanders
c2d0a28fa2
ci: enable debugging mode when building electron_dist_zip ( #45108 )
2025-01-06 14:41:48 -05:00
John Kleinschmidt
2745771a22
test: reenable disabled GHA windows tests ( #45062 )
...
* test: renable GHA on Windows disabled tests
* test: close edge after shell.openExternal
* test: close edge sync after shell.openExternal
2024-12-20 14:49:55 -05:00
dependabot[bot]
1ecb2a2998
build(deps): bump actions/checkout from 4.1.6 to 4.2.2 ( #45048 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-19 17:22:01 -05:00
electron-roller[bot]
e0f72dc332
chore: bump chromium to 133.0.6887.0 (main) ( #44986 )
...
* chore: bump chromium in DEPS to 133.0.6887.0
* chore: update render_widget_host_view_base.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5952851
* chore: update osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6068570
* chore: e patches all
* Remove ClipboardFormatType::GetType()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6075792
* Remove raw byte range methods from network::ResourceRequestBody
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6038757
* fix: update patches/chromium/fix_crash_loading_non-standard_schemes_in_iframes.patch:wq
Refs https://issues.chromium.org/issues/40092527
* fix: windows gn check
* chore: update patches/chromium/render_widget_host_view_base.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-12-18 15:45:19 +09:00
George Xu
caf24ef417
fix: add patch to fix desktopCapturer.getSources not returning electron windows on Windows ( #45000 )
...
* fix: add patch to fix desktopCapturer.getSources not returning electron window on Windows
* add chromium link
* Update patches/chromium/fix_desktop_capturer_show_own_window.patch
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* fix on electron side
* set flag to true
* wrong capturer
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-12-17 15:20:44 -08:00
dependabot[bot]
ff13bcd08d
build(deps): bump github/codeql-action from 3.27.6 to 3.27.9 ( #45047 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.6 to 3.27.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](aa57810251...df409f7d92 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-17 10:09:56 +01:00
Quinn
dc74092a09
fix: better prompt not supported message in window-setup.ts ( #45017 )
...
Update window-setup.ts
The message should simply read "is not supported" or, alternatively, "is not, and will not, be supported", but not "is and will not be supported".
2024-12-16 15:38:25 -05:00
Kavindu Udara
f89813401d
docs: remove extra " ( #45029 )
...
remove extra "
2024-12-16 13:20:17 -05:00
Sam Maddock
3aa0014d23
fix: chrome.i18n unavailable in extension service workers ( #45031 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
2024-12-16 09:46:20 -05:00
John Kleinschmidt
69479b2fb7
build: update build tools to correct sha ( #45018 )
...
chore: update build tools to correct sha
2024-12-13 17:26:25 -08:00
Jesper Ek
e2e71502b1
fix: custom spell-checker stuck in infinite loop ( #45001 )
...
`ReadUnicodeCharacter` updates index to the last character read, and not after it. We need to manually increment it to move to the next character.
It also doesn't validate that the index is valid, so we need to check that index is within bounds.
Refs: #44336
2024-12-13 11:47:29 -05:00
Samuel Attard
be1a3dce83
build: use github actions for windows ( #44136 )
...
* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094
and https://chromium-review.googlesource.com/c/chromium/src/+/5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37 .
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d6 )
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a180658376 .
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f538 .
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129 .
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffe .
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01 .
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049 .
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7 .
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839 .
* Revert "remove debugging"
This reverts commit f18dd8b1a5 .
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f .
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd4322 .
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1 .
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d .
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-12 11:51:24 -05:00
Alice Zhao
a5b4339884
fix: add missing index arg in navigationHistory.canGoToOffset ( #44989 )
...
fix: add missing arg
2024-12-12 10:56:27 -05:00
Sam Maddock
6961e9458a
chore: update vm module warning ( #44985 )
...
* chore: update vm module warning
* Update lib/renderer/init.ts
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-12-11 17:22:50 -05:00
electron-appveyor-updater[bot]
2191e9b8e1
build: update appveyor image to latest version ( #44992 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-11 13:27:21 -05:00
Sam Maddock
2c698d3f75
fix: context-menu emitted twice ( #44978 )
...
* fix: context-menu emitted twice
* refactor: simplify disabling draggable regions
* cleanup
2024-12-11 11:42:48 -05:00
electron-roller[bot]
cf5a4640f5
chore: bump chromium to 133.0.6878.0 (main) ( #44831 )
...
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
https://chromium-review.googlesource.com/c/chromium/src/+/6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
https://chromium-review.googlesource.com/c/chromium/src/+/6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
https://chromium-review.googlesource.com/c/chromium/src/+/6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
https://chromium-review.googlesource.com/c/chromium/src/+/6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | https://chromium-review.googlesource.com/c/chromium/src/+/6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | https://chromium-review.googlesource.com/c/chromium/src/+/6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | https://chromium-review.googlesource.com/c/chromium/src/+/6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | https://chromium-review.googlesource.com/c/chromium/src/+/6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | https://chromium-review.googlesource.com/c/chromium/src/+/6051058
* 6038981: Remove most remaining CHECK(false)s | https://chromium-review.googlesource.com/c/chromium/src/+/6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-10 13:16:07 -06:00
dependabot[bot]
3bd5f14cee
build(deps): bump github/codeql-action from 3.27.5 to 3.27.6 ( #44981 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.5 to 3.27.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f09c1c0a94...aa57810251 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:52:27 +01:00
dependabot[bot]
7462d449e0
build(deps): bump mikefarah/yq from 4.44.5 to 4.44.6 ( #44980 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.5 to 4.44.6.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bc5b54cb1d...4839dbbf80 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:51:25 +01:00
Calvin
82ea3faae5
docs: update security scoped bookmarks info ( #44968 )
2024-12-09 10:44:43 -08:00
Charles Kerr
578c1e5dae
fix: build failure when PDF viewer is disabled ( #44960 )
...
* fix: unused variable warning when the PDF viewer is disabled
* fix: unused function error when PDF viewer is disabled
error: unused function ParseManifest [-Werror,-Wunused-function]
2024-12-06 17:54:04 +09:00
Shelley Vohr
208dc568d8
fix: context-menu event with BaseWindows ( #44940 )
...
fix: context-menu event with BaseWindows
2024-12-04 13:35:28 -08:00
Felix Rieseberg
687a59b43b
feat: Add shared dictionary management APIs ( #44750 )
...
* Add bare-bones GetSharedDictionaryUsageInfo
* Add GetSharedDictionaryInfo()
* Improve API, use isolation keys
* Add documentation
* Update docs/api/session.md
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* Add tests
* Implement feedback <3
* Improve tests
* chore: lint
* docs: add note about clearing cache in ses.clearData
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-12-04 12:25:11 -05:00
Charles Kerr
158a87d494
fix: modernize-use-equals-default warnings ( #44935 )
...
fix: use '= default' to define a trivial destructor [modernize-use-equals-default]
2024-12-03 16:25:48 -06:00
Shelley Vohr
229c2a8f50
chore: make version parsing more tolerant ( #44918 )
...
* chore: make version parsing more tolerant
* Update .github/workflows/issue-opened.yml
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-03 17:03:43 -05:00
Niklas Wenzel
5324c0e6c3
docs: fix grammar in app.relaunch docs ( #44920 )
2024-12-03 09:56:09 -08:00
Sam Maddock
2222920429
feat: WebFrameMain.collectJavaScriptCallStack() ( #44204 )
...
* feat: WebFrameMain.unresponsiveDocumentJSCallStack
* Revert "feat: WebFrameMain.unresponsiveDocumentJSCallStack"
This reverts commit e0612bc1a00a5282cba5df97da3c9c90e96ef244.
* feat: frame.collectJavaScriptCallStack()
* feat: frame.collectJavaScriptCallStack()
* Update web-frame-main.md
2024-12-03 13:32:24 +09:00
Charles Kerr
6d4c271268
chore: remove unused registry arg from GetPrivilegeRequiredByUrl() ( #44908 )
...
this has never been used; introduced by 91071570
2024-12-02 14:02:47 -05:00
Niklas Wenzel
c6b4bde7b5
docs: clarify what session.clearData() with data type 'cache' deletes ( #44852 )
...
* docs: clarify what session.clearData() with data type 'cache' deletes
* docs: include `shadercache`, too
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2024-12-02 13:50:35 -05:00
Niklas Wenzel
bba9ee1cb8
docs: clarify session.clearData() can delete more types than listed ( #44851 )
...
docs: warn that session.clearData() might delete more than expected
2024-12-02 13:29:25 -05:00
Charles Kerr
a7fa6e89b5
chore: remove unused arg from BaseWindow::GetBackgroundColor() ( #44906 )
...
chore: remove unused gin_helper::Arguments* arg from BaseWindow::GetBackgroundColor()
looks like this was added in db79734b but never used
2024-12-02 11:39:10 -05:00
Charles Kerr
06612cf5d4
chore: remove unused isolate argument from Cookies constructor ( #44907 )
...
* chore: remove unused isolate argument from Cookies constructor
unused since the ginify cookies refactor in Mar 2020, commit 22202255
* fix: constructor only takes one arg now, so mark it explicit
2024-12-02 11:34:21 -05:00
electron-appveyor-updater[bot]
49b294628c
build: update appveyor image to latest version ( #44840 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-02 11:14:41 -05:00
Charles Kerr
493e3c4537
fix: don't use deprecated ui::MouseEvent constructor ( #44868 )
...
* refactor: do not use deprecated gfx::Point constructor for MouseEvent
Deprecated in https://chromium-review.googlesource.com/c/1444251
* refactor: use WebInputEvent::GetTypeAsUiEventType() instead of rolling our own
Added in https://chromium-review.googlesource.com/c/chromium/src/+/2180291
2024-12-02 11:13:38 -05:00
Charles Kerr
b2ce5296af
fix: remove unused id argument from TranslateToStock() ( #44900 )
...
unused since fb537d91fc
2024-12-01 16:34:48 -06:00
illusory-dream
4e40b49d1a
docs: fix a syntax issue in document breaking changes ( #44841 )
...
fix: syntax issue in docs
2024-11-30 21:44:33 -08:00
Niklas Wenzel
d8149aa376
docs: specify default value for respondToAuthRequestsFromMainProcess ( #44855 )
...
docs: specify default value for respondToAuthRequestsFromMainProcess
2024-11-30 21:33:33 -08:00
Charles Kerr
033a0abb59
refactor: reduce scope of relauncher's internal constants ( #44860 )
...
* refactor: make kRelauncherArgSeparator private to relauncher.cc
* refactor: make kRelauncherTypeArg private to relauncher.cc
* refactor: remove unused type relauncher::CharType
* refactor: move private constants into standalone private namespace
* refactor: move kWaitEventName into the only function that uses it
2024-11-30 06:54:40 -06:00
Shelley Vohr
8f00cc9c0e
build: remove context-aware patch ( #44862 )
2024-11-29 11:45:33 -06:00
Charles Kerr
f7e823ac80
refactor: return-braced-init-list pt 2 of 2 ( #44870 )
...
* refactor: more return-braced-init-list, this time for v8 and gin objects
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
2024-11-29 11:44:33 -06:00
Charles Kerr
4a695d07c6
fix: misc-use-internal-linkage warnings ( #44843 )
...
* refactor: misc-use-internal-linkage warnings in context bridge
move impl functions into anonymous namespace so that they're not visible
to other compilation units:
- ExposeAPIInWorld()
- IsCalledFromMainWorld()
- OverrideGlobalPropertyFromIsolatedWorld()
- OverrideGlobalValueFromIsolatedWorld()
- TraceKeyPath()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct ScaleFactorPair
- kScaleFactorPairs[]
- GetScaleFactorFromPath()
- AddImageSkiaRepFromPath()
* refactor: misc-use-internal-linkage warnings in printing util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFullPagePlugin()
* refactor: misc-use-internal-linkage warnings in blijnk converter
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetKeyLocationCode()
- ModifiersToArray()
* refactor: misc-use-internal-linkage warnings in extrension system
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- ParseManifest()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFrameTokenMap()
- GetFrameTreeNodeIdMap()
* refactor: misc-use-internal-linkage warnings in electron_api_utility_process.cc
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetAllUtilityProcessWrappers()
* refactor: misc-use-internal-linkage warnings in electron_api_menu
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- InvokeBoolMethod()
* refactor: misc-use-internal-linkage warnings in platform util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct TrashItemResult
- TrashItemOnBlockingThread()
2024-11-27 10:40:39 -06:00
Charles Kerr
4aa1855e39
refactor: use base::Extend in AddAdditionalSchemes() ( #44839 )
2024-11-27 07:55:54 -06:00
Charles Kerr
f595443a22
refactor: fix modernize-return-braced-init-list warnings ( #44838 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
2024-11-27 09:41:46 +09:00
dependabot[bot]
9f1e23c405
build(deps): bump github/codeql-action from 3.27.4 to 3.27.5 ( #44837 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.4 to 3.27.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ea9e4e3799...f09c1c0a94 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-26 11:26:35 +01:00
Charles Kerr
93f49d1189
fix: modernize-use-using clang-tidy warnings ( #44806 )
2024-11-25 10:50:33 -05:00
Charles Kerr
3c941c7e8f
fix: modernize-avoid-c-arrays ( #44813 )
...
use string_view for constants used in methods that take string_view args
2024-11-25 10:49:58 -05:00
Charles Kerr
024fee4e44
fix: modernize-use-nodiscard clang-tidy warnings ( #44808 )
2024-11-25 10:48:28 -05:00
electron-roller[bot]
7e7010dacf
chore: bump chromium to 133.0.6852.0 (main) ( #44748 )
...
* chore: bump chromium in DEPS to 133.0.6847.0
* chore: bump chromium in DEPS to 133.0.6848.0
* chore: update patches
* implement extensions::GlobalShortcutListener::ExecuteCommand stub
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* fix: ismediakey patch, oops
* fix: another missing bracket
* chore: bump chromium in DEPS to 133.0.6850.0
* chore: update patches
* SharedStorageOperationPtr -> SharedStorageModifierMethodPtr
https://chromium-review.googlesource.com/c/chromium/src/+/5990970
* build GlobalShortcutListenerLinux
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* chore: bump chromium in DEPS to 133.0.6851.0
* fix: include full type for network::mojom::SharedStorageModifierMethod
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6852.0
* chore: update patches
* build: remove duplicated icudtl.dat and snapshot_blob.bin
https://chromium-review.googlesource.com/c/chromium/src/+/5999387
* fix: include static methods in node tests involving call stacks
https://chromium-review.googlesource.com/c/v8/v8/+/5907815
* revert: moved code in picture-in-picture.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-25 10:45:47 -05:00
Ajay Kemparaj
fbe01cdc16
docs: correct stable release dates for v34.0.0 ( #44807 )
...
* docs: correct stable release dates for v34.0.0
* docs: correct stable release dates for v34.0.0
2024-11-25 10:43:56 -05:00
Niklas Wenzel
b8b2e12c9c
docs: fix wording in auto-updater.md ( #44787 )
...
* docs: fix wording in auto-updater.md
* docs: update wording
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-11-24 13:00:42 -08:00
Charles Kerr
94a65df270
refactor: remove unnecessary constructor code ( #44816 )
2024-11-24 08:55:46 -06:00
Charles Kerr
24df5f96d7
fix: remove unused local variables ( #44815 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de5
* chore: only declare program_name local variable if used
We declared it everywhere but only used it on Windows
* chore: remove unused local non-trivial variable path from UnregisterXWindow
it became unused in 2020 by 72a08926
2024-11-23 17:34:51 -06:00
David Sanders
4a3513377c
docs: update new GitHub issue link ( #44791 )
2024-11-22 11:48:59 -08:00
Savely Krasovsky
c5ea177b3d
feat: add query-session-end and improve session-end events on Windows ( #44598 )
...
* feat: add query-session-end event for Windows
* fix: remove debug line
* feat: notify with reason on session-end
* docs: add comments and return params
* docs: add same docs to the BrowserWindow
* fix: add shutdown reason if lParam == 0
* docs: remove 'force' word
* docs: revert multithreading.md change
* docs: add reasons documentation, reason variable renamed to reasons
* docs: improve 'shutdown' reason wording
* docs: reword with 'can be'
* fix: pass reasons by reference
* fix: use newer approach which expose reasons value directly on Event object
* docs: add escaping
* style: linter fixes
* fix: project now should compile
* fix: EmitWithoutEvent method added, EmitWithEvent moved to private again
* docs: typo fix
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* docs: dedicated WindowSessionEndEvent type created
* docs: better wording for session-end event description
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Will Anderson <will@itsananderson.com >
2024-11-22 11:47:36 -08:00
Shelley Vohr
0285592d61
fix: crash calling shell.readShortcutLink ( #44784 )
...
fix: crash calling shell.readShortcutLink
2024-11-22 09:37:17 -05:00
Shelley Vohr
86e4529d26
fix: ensure context-menu emitted for draggable regions ( #44761 )
...
* fix: ensure context-menu emitted for draggable regions
* chore: address suggestions from review
2024-11-22 12:33:38 +01:00
Charles Kerr
4fd1b5b186
fix: big endian bug in V8 serialization ( #44776 )
2024-11-22 12:04:53 +01:00
BILL SHEN
1d55eb9a45
build: remove duplicate line in gn file ( #44786 )
...
style: remove duplicate line in gn file
2024-11-22 12:03:49 +01:00
Charles Kerr
0005ae9557
docs: sync 34.0.0 release date to Chromium 132 release date ( #44766 )
2024-11-21 10:51:19 -06:00
Charles Kerr
86962ba2c3
fix: clang-tidy performance-inefficient-vector-operation warnings ( #44743 )
...
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-20 18:11:00 -06:00
Charles Kerr
6789431f74
fix: performance-no-automatic-move clang-tidy warnings ( #44742 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
2024-11-20 18:10:30 -06:00
nilaoda
0ea64850af
fix: windows save dialog extension bug ( #44296 )
...
* fix: windows save dialog extension bug
* refactor: simplify firstSpec extraction
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: split when necessary
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2024-11-20 17:27:49 -05:00
Den Delimarsky
769b045c8b
docs: removes redundant phrasing in the code signing documentation ( #44716 )
...
Update code-signing.md
2024-11-20 16:41:01 -05:00
Charles Kerr
85e2622b68
refactor: use gdk_display_beep() on Linux ( #44734 )
...
* refactor: use gdk_display_beep() to beep on Linux
* chore: make a stub declaration for gdk_display_beep()
* chore: remove unused file electron_gtk.sigs
* chore: remove unused #includes to make gn check happy
2024-11-20 16:24:59 -05:00
electron-appveyor-updater[bot]
15c3064780
build: update appveyor image to latest version ( #44751 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-20 16:18:01 -05:00
Shelley Vohr
f95e1d8ea0
chore: fix textured window conditional on macOS ( #44728 )
2024-11-20 10:34:46 -06:00
Shelley Vohr
eba0edf81e
build: allow unbundling of Node.js dependencies ( #44754 )
2024-11-20 11:34:37 -05:00
Sam Maddock
8223ebc111
test: run script to help target discovery and reduce flakes ( #44741 )
2024-11-20 08:55:09 -06:00
Shelley Vohr
54d53bfa51
fix: tooltips in WCO caption buttons ( #44721 )
...
fix: tooltips in WCO capton buttons
2024-11-20 12:45:08 +01:00
dependabot[bot]
8ed48e2295
build(deps): bump mikefarah/yq from 4.44.3 to 4.44.5 ( #44714 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.3 to 4.44.5.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bbdd97482f...bc5b54cb1d )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 10:49:50 +01:00
electron-roller[bot]
43ed763f18
chore: bump chromium to 133.0.6846.0 (main) ( #44665 )
...
* chore: bump chromium in DEPS to 133.0.6836.0
* chore: bump chromium in DEPS to 133.0.6838.0
* chore: update patches
* 6006096: [Sync ESB] Integrate Chrome Toast UI
https://chromium-review.googlesource.com/c/chromium/src/+/6006096
* Confine enable_device_bound_sessions buildflag to //net
https://chromium-review.googlesource.com/c/chromium/src/+/6014679
* revert [api] Delete deprecated struct FastApiTypedArray
https://chromium-review.googlesource.com/c/v8/v8/+/5982984
Also
https://chromium-review.googlesource.com/c/v8/v8/+/5979766/1
* fixup revert [api] Delete deprecated struct FastApiTypedArray
* Migrate remaining NOTREACHED()s in chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* [Reland][Extensions] Remove ExtensionHostDelegate::GetJavaScriptDialogManager()
https://chromium-review.googlesource.com/c/chromium/src/+/6020106
* Remove NOTREACHED_IN_MIGRATION()
https://chromium-review.googlesource.com/c/chromium/src/+/6021996
* Remove Lock screen apps [#8 ] : remove lock screen extension
https://chromium-review.googlesource.com/c/chromium/src/+/6005846
* Reland "Add CrashReporterClient::GetProductInfo(ProductInfo*)"
https://chromium-review.googlesource.com/c/chromium/src/+/6012631
* Ozone/Wayland: remove lacros specific window states
https://chromium-review.googlesource.com/c/chromium/src/+/6011215
* chore: bump chromium in DEPS to 133.0.6840.0
* chore: bump chromium in DEPS to 133.0.6841.0
* chore: bump chromium in DEPS to 133.0.6844.0
* implement virtual WebContents::CanUserEnterFullscreen
* OnSearchifyStateChange -> OnSearchifyStarted
* regen libc++ filenames
* chore: bump chromium in DEPS to 133.0.6846.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-19 19:52:20 -08:00
Charles Kerr
ac61c74ddc
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44708 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image.cc:155:26: warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int32_t' (aka 'int') is implementation-defined [bugprone-narrowing-conversions]
155 | new_memory_usage = image_skia->bitmap()->computeByteSize();
* fix: bugprone-narrowing-conversions warnings in NativeImage::CreateFromBitmap()
`SkImageInfo::MakeN32()` and `SkBitmap::allocN32Pixels()` both take int
width and height args, but we were feeding them unsigned ints.
../../electron/shell/common/api/electron_api_native_image.cc:508:36: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:508:43: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:25: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:32: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:528:48: warning: narrowing conversion from 'double' to 'float' [bugprone-narrowing-conversions]
528 | gfx::ImageSkia::CreateFromBitmap(bitmap, scale_factor);
2024-11-19 16:04:18 -06:00
Charles Kerr
1cf5e6d88c
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h ( #44705 )
...
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
2024-11-19 13:45:18 -06:00
Robo
48c9149a52
fix: utility process exit code for graceful termination (reland) ( #44726 )
...
* chore: reland "fix: utility process exit code for graceful termination"
This reverts commit 1cae73ba09 .
* fix: exit code on posix when killed via api
* chore: fix code style
2024-11-20 02:48:15 +09:00
Robo
0d6743e79b
fix: destroy url loader wrapper when JS env exits ( #44574 )
...
* fix: destroy url loader wrapper when JS env exits
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
* fix: double free of JSChunkedDataPipeGetter
* fix: crash on process exit after stream completes
2024-11-19 11:32:48 -05:00
Shelley Vohr
7a5e9613d2
build: rework header generation in Node.js ( #44657 )
...
* build: rework header generation in Node.js
* build: fix patch location error
* fix: set --root-dir correctly
2024-11-19 10:57:38 -05:00
dependabot[bot]
9d1be5f824
build(deps): bump the npm_and_yarn group across 2 directories with 1 update ( #44701 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
---
updated-dependencies:
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 15:06:42 +01:00
Shelley Vohr
4b3d1caae4
fix: improve single-pixel resize handling on Windows ( #44700 )
...
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-11-19 13:24:07 +01:00
dependabot[bot]
2cea2282eb
build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 ( #44715 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.27.0 to 2.0.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](37ebaef184...485a9d42d3 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 11:45:56 +01:00
dependabot[bot]
8efc4c7a56
build(deps): bump github/codeql-action from 3.27.1 to 3.27.4 ( #44713 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4f3212b617...ea9e4e3799 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 11:45:09 +01:00
David Sanders
febf305a4f
chore: fix unsupported major comment in issue automation ( #44706 )
2024-11-19 10:52:08 +01:00
Robo
1cae73ba09
chore: Revert "fix: utility process exit code for graceful termination" ( #44717 )
...
Revert "fix: utility process exit code for graceful termination (#44698 )"
This reverts commit 36e1a0bf00 .
2024-11-18 22:13:23 -06:00
Will Anderson
10d967028a
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44651 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
* fix: clear all listeners before running ipcMain removeAllListeners tests
2024-11-18 14:44:30 -08:00
Niklas Wenzel
aa7a5e6ca9
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44680 )
...
Fixes #44450
2024-11-18 14:36:41 -08:00
Shelley Vohr
58dc990f7a
chore: fix multi-version parsing in issue assignment ( #44679 )
...
* chore: fix multi-version parsing
* chore: tweak for review
2024-11-18 21:25:20 +01:00
Robo
36e1a0bf00
fix: utility process exit code for graceful termination ( #44698 )
2024-11-18 23:57:06 +09:00
Shelley Vohr
d320840a54
build: re-enable container_overflow ASAN check ( #44699 )
...
build: re-enable container_overflow ASAN check
2024-11-18 09:22:17 -05:00
Shelley Vohr
dd50afa8c2
fix: utilityProcess pid should be undefined after exit ( #44677 )
...
fix: utilityProcess pid should be undefined after exit
2024-11-18 10:06:27 +01:00
electron-appveyor-updater[bot]
15ff999bdc
build: update appveyor image to latest version ( #44675 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-15 14:54:00 -05:00
Shelley Vohr
a15e42e9ff
chore: cleanup following internal switch to readPackageJSON ( #44644 )
...
chore: cleanup following internal switch to readPackageJSON
2024-11-15 11:36:18 -05:00
Sam Maddock
aca84be970
chore: update extensions features ( #44653 )
...
* chore: update extensions features
* restore header
2024-11-15 11:32:43 -05:00
Robo
4fb5aab2ef
fix: revert required portal version for file chooser dialogs ( #44426 )
...
* feat: add support for configuring xdg portal version at runtime
* doc: update command-line-switches.md
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* doc: required portal version for defaultPath support
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* doc: update more occurrances
* fix: remove warning from save dialogs
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-15 09:31:33 -05:00
Shelley Vohr
27fe6cc97f
fix: WebContentsView removal should compare directly ( #44656 )
...
* fix: WebContentsView removal should compare directly
* fixup view comparision
* chore: use erase_if
* Apply review suggestions
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-14 22:11:20 -05:00
electron-roller[bot]
b1957f52e3
chore: bump chromium to 132.0.6834.0 (main) ( #44602 )
...
* chore: bump chromium in DEPS to 132.0.6827.0
* chore: bump chromium in DEPS to 132.0.6828.0
* chore: bump chromium in DEPS to 132.0.6830.0
* chore: bump chromium in DEPS to 132.0.6832.0
* chore: bump chromium in DEPS to 132.0.6834.0
* chore: update chromium patches
* 5977022: Apply os setting of overlay scrollbar to web instances | https://chromium-review.googlesource.com/c/chromium/src/+/5977022
* 5991440: Cleanup //ui/compositor from LaCros support code. | https://chromium-review.googlesource.com/c/chromium/src/+/5991440
* chore: update all patches
* 6000058: Add base_subdirs to file_chooser.mojom NativeFileInfo | https://chromium-review.googlesource.com/c/chromium/src/+/6000058
* 6009949: Rename NOTREACHED_NORETURN() uses to NOTREACHED() | https://chromium-review.googlesource.com/c/chromium/src/+/6009949
* 5966419: [freezing] Expose frozen state to extensions (3/3 - add frozen to chrome.tabs.Tab).
https://chromium-review.googlesource.com/c/chromium/src/+/5966419
Also https://chromium-review.googlesource.com/c/chromium/src/+/6006424
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-14 18:18:11 +01:00
Charles Kerr
8a67e77f03
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44650 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
* chore: remove some unused imports
* fix: E711 warning 'Comparison to should be '
2024-11-14 12:27:20 +01:00
Sam Maddock
41b5d7e312
refactor: unfilter unresponsive events ( #44629 )
...
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4 .
* fix: emit unresponsive if close not prevented
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-11-13 17:59:13 -08:00
Keeley Hammond
946ab5f1d7
build: reland bump Node.js to v22.9.0 ( #44597 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-13 15:34:30 +01:00
Shelley Vohr
0fd16dc9e2
fix: WCO buttons hidden on Linux in fullscreen ( #44621 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
2024-11-13 15:11:58 +01:00
BILL SHEN
a120d87570
fix: add theme data source for devtools. ( #44114 )
...
* fix: add theme data source for devtools.
* chore: add ut.
* chore: remove recording histograms
* fix: add theme data source for devtools.
* chore: separate files
* chore: separate files
* chore: remove pragma once
* chore: fix lint issue.
2024-11-13 13:23:37 +01:00
David Sanders
d380cda14a
ci: remove from issue triage on issue transferred ( #44631 )
2024-11-13 12:05:11 +01:00
Shelley Vohr
80ff7a14c6
test: exercise fuller globalShortcut matrix ( #44488 )
...
test: test fuller globalShortcut matrix
2024-11-12 15:31:39 -05:00
Gellert Hegyi
7a79d4c96e
feat: add optional animation parameter to BrowserWindow.setVibrancy ( #35987 )
...
adds optional animation parameter to BrowserWindow.setVibrancy
2024-11-12 09:03:30 -08:00
dependabot[bot]
a6390b539c
build(deps): bump github/codeql-action from 3.27.0 to 3.27.1 ( #44611 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.0 to 3.27.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](662472033e...4f3212b617 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-12 10:29:59 -05:00
John Kleinschmidt
777e547922
fix: segfault when moving WebContentsView between BrowserWindows ( #44599 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
* chore: actually enable fix
* fixup segfault when moving WebContentsView between BrowserWindows
2024-11-11 18:44:13 -05:00
dependabot[bot]
c6c430bff1
build(deps): bump dsanders11/project-actions from 1.3.0 to 1.4.0 ( #44566 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](eb760c4889...438b25e007 )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 21:30:31 +01:00
electron-appveyor-updater[bot]
928c0301e7
build: update appveyor image to latest version ( #44606 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-11 13:56:59 -05:00
electron-roller[bot]
6e3a5daf62
chore: bump chromium to 132.0.6826.0 (main) ( #44584 )
...
* chore: bump chromium in DEPS to 132.0.6821.0
* chore: bump chromium in DEPS to 132.0.6822.0
* chore: update patches
* chore: bump chromium in DEPS to 132.0.6824.0
* chore: update patches
* 5998172: Migrate remaining NOTREACHED()s in chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* 5872484: Pass along accelerators for menu items coming from DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/5872484
* chore: update patches
* 5872913: Enable `raw_span` clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
* fixup! picture-in-picture import
* 5912245: [video pip] Add progress bar to 2024 UI | https://chromium-review.googlesource.com/c/chromium/src/+/5912245
* fixup! 5872913: Enable raw_span clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-11-08 16:12:42 -08:00
Keeley Hammond
f9a04012b9
build: revert bump Node.js to v22.9.0 ( #44596 )
...
* Revert "chore: bump Node.js to v22.9.0 (#44281 )"
This reverts commit c63d0d61e7 .
* chore: update patches
2024-11-07 19:20:50 -08:00
John Kleinschmidt
4b57a8fb1a
chore: remove revert_mojo_force_blink_headers_to_only_be_included_in_blink.patch ( #44589 )
2024-11-07 12:30:57 -08:00
Samuel Attard
e3d75b3087
build: also lint mjs files ( #44581 )
2024-11-06 18:46:09 -05:00
electron-appveyor-updater[bot]
ea7b0a4cc8
build: update appveyor image to latest version ( #44570 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-06 13:54:39 -05:00
Charles Kerr
2002472b10
chore: remove unused gin::Converter<char[]>::ToV8(isolate, const char*) ( #44568 )
...
No longer needed after #44498
2024-11-06 08:49:25 -06:00
electron-roller[bot]
adbd25f699
chore: bump chromium to 132.0.6820.0 (main) ( #44544 )
...
* chore: bump chromium in DEPS to 132.0.6817.0
* chore: update chromium patches
* 5979290: Temoporarily disable crel on arm. | https://chromium-review.googlesource.com/c/chromium/src/+/5979290
* 5981701: Include callback.h instead of callback_forward.h | https://chromium-review.googlesource.com/c/chromium/src/+/5981701
* 5964918: [v8 code cache] Add a wpt_internal test demonstrating the code cache 304 problem | https://chromium-review.googlesource.com/c/chromium/src/+/5964918
* 5969697: Add NetworkTrafficAnnotationTag to PreconnectManager | https://chromium-review.googlesource.com/c/chromium/src/+/5969697
* chore: update remaining patches
* chore: bump chromium in DEPS to 132.0.6818.0
* chore: update patches
* 5983492: MPArch GuestView: Have executeScript target correct frame | https://chromium-review.googlesource.com/c/chromium/src/+/5983492
* chore: bump chromium in DEPS to 132.0.6820.0
* chore: update patches
* 5989717: Revert "win: Remove special check for 10.0.22621.2428 Win SDK version" | https://chromium-review.googlesource.com/c/chromium/src/+/5989717
* 5968218: Send PDF Searchifier running state to browser to show UX elements. | https://chromium-review.googlesource.com/c/chromium/src/+/5968218
* build: also update the MSVS_HASH for WOA
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-11-05 16:46:57 -08:00
Charles Kerr
3090e40c09
chore: remove executable flag from docs/api/app.md file permissions ( #44548 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
2024-11-05 11:48:23 -05:00
Niklas Wenzel
4f2fb7b1a0
docs: clarify that sessions use cache by default ( #44547 )
2024-11-05 10:27:19 -06:00
Charles Kerr
9bf067dd5a
fix: ftbfs when including simdjson in Node.js ( #44567 )
2024-11-04 20:28:44 -05:00
John Kleinschmidt
f0d3e42338
test: fixup flaky session tests ( #44545 )
...
test: fixup broken tests in 32-x-y (#44389 )
* test: fixup broken tests in 32-x-y
* test: fixup additional failing test
(cherry picked from commit c61bb1654e )
2024-11-04 17:26:19 -05:00
Charles Kerr
24dc9ddf5c
fix: remove use of banned std::to_string() ( #44514 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
2024-11-04 16:42:42 -05:00
Charles Kerr
1835c0ab6c
docs: capitalize POSIX and Windows correctly ( #44546 )
...
* docs: capitalize POSIX correctly
* docs: capitalize Windows correctly
2024-11-04 13:12:23 -08:00
John Kleinschmidt
1c1eb3e19d
build: add new status to verify if all the required gha jobs have run ( #44432 )
2024-11-04 14:35:10 -05:00
Charles Kerr
726d439399
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #44515 )
...
refactor: replace base::StringPrintf() calls with absl::StFormat()
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
2024-11-04 12:58:16 -06:00
Shelley Vohr
c63d0d61e7
chore: bump Node.js to v22.9.0 ( #44281 )
...
* chore: bump Node.js to v22.9.0
* build: drop base64 dep in GN build
https://github.com/nodejs/node/pull/52856
* build,tools: make addons tests work with GN
https://github.com/nodejs/node/pull/50737
* fs: add fast api for InternalModuleStat
https://github.com/nodejs/node/pull/51344
* src: move package_json_reader cache to c++
https://github.com/nodejs/node/pull/50322
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* src: shift more crypto impl details to ncrypto
https://github.com/nodejs/node/pull/54028
* src: switch crypto APIs to use Maybe<void>
https://github.com/nodejs/node/pull/54775
* crypto: remove DEFAULT_ENCODING
https://github.com/nodejs/node/pull/47182
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* build: fix conflict gyp configs
https://github.com/nodejs/node/pull/53605
* lib,src: drop --experimental-network-imports
https://github.com/nodejs/node/pull/53822
* esm: align sync and async load implementations
https://github.com/nodejs/node/pull/49152
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* module: detect ESM syntax by trying to recompile as SourceTextModule
https://github.com/nodejs/node/pull/52413
* test: adapt debugger tests to V8 11.4
https://github.com/nodejs/node/pull/49639
* lib: update usage of always on Atomics API
https://github.com/nodejs/node/pull/49639
* test: adapt test-fs-write to V8 internal changes
https://github.com/nodejs/node/pull/49639
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* src: use non-deprecated v8::Uint8Array::kMaxLength
https://github.com/nodejs/node/pull/50115
* src: update default V8 platform to override functions with location
https://github.com/nodejs/node/pull/51362
* src: add missing TryCatch
https://github.com/nodejs/node/pull/51362
* lib,test: handle new Iterator global
https://github.com/nodejs/node/pull/51362
* src: use non-deprecated version of CreateSyntheticModule
https://github.com/nodejs/node/pull/50115
* src: remove calls to recently deprecated V8 APIs
https://github.com/nodejs/node/pull/52996
* src: use new V8 API to define stream accessor
https://github.com/nodejs/node/pull/53084
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
* src: migrate to new V8 interceptors API
https://github.com/nodejs/node/pull/52745
* src: use supported API to get stalled TLA messages
https://github.com/nodejs/node/pull/51362
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* test: make snapshot comparison more flexible
https://github.com/nodejs/node/pull/54375
* test: do not set concurrency on parallelized runs
https://github.com/nodejs/node/pull/52177
* src: move FromNamespacedPath to path.cc
https://github.com/nodejs/node/pull/53540
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* build: add option to enable clang-cl on Windows
https://github.com/nodejs/node/pull/52870
* chore: fixup patch indices
* chore: add/remove changed files
* esm: drop support for import assertions
https://github.com/nodejs/node/pull/54890
* build: compile with C++20 support
https://github.com/nodejs/node/pull/52838
* deps: update nghttp2 to 1.62.1
https://github.com/nodejs/node/pull/52966
* src: parse inspector profiles with simdjson
https://github.com/nodejs/node/pull/51783
* build: add GN build files
https://github.com/nodejs/node/pull/47637
* deps,lib,src: add experimental web storage
https://github.com/nodejs/node/pull/52435
* build: add missing BoringSSL dep
* src: rewrite task runner in c++
https://github.com/nodejs/node/pull/52609
* fixup! build: add GN build files
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
* fix: shadow variable
* build: add back incorrectly removed SetAccessor patch
* fixup! fixup! build: add GN build files
* crypto: fix integer comparison in crypto for BoringSSL
* src,lib: reducing C++ calls of esm legacy main resolve
https://github.com/nodejs/node/pull/48325
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* chore: fixup GN files for previous commit
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* Fixup Perfetto ifdef guards
* fix: missing electron_natives dep
* fix: node_use_node_platform = false
* fix: include src/node_snapshot_stub.cc in libnode
* 5507047: [import-attributes] Remove support for import assertions
https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fix: restore v8-sandbox.h in filenames.json
* fix: re-add original-fs generation logic
* fix: ngtcp2 openssl dep
* test: try removing NAPI_VERSION undef
* chore(deps): bump @types/node
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
* lib: rewrite AsyncLocalStorage without async_hooks
https://github.com/nodejs/node/pull/48528
* module: print amount of load time of a cjs module
https://github.com/nodejs/node/pull/52213
* test: skip reproducible snapshot test on 32-bit
https://github.com/nodejs/node/pull/53592
* fixup! src: move more crypto_dh.cc code to ncrypto
* test: adjust emittedUntil return type
* chore: remove redundant wpt streams patch
* fixup! chore(deps): bump @types/node
* fix: gn executable name on Windows
* fix: build on Windows
* fix: rename conflicting win32 symbols in //third_party/sqlite
On Windows otherwise we get:
lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
* docs: remove unnecessary ts-expect-error after types bump
* src: move package resolver to c++
https://github.com/nodejs/node/pull/50322
* build: set ASAN detect_container_overflow=0
https://github.com/nodejs/node/issues/55584
* chore: fixup rebase
* test: disable failing ASAN test
* win: almost fix race detecting ESRCH in uv_kill
https://github.com/libuv/libuv/pull/4341
2024-11-04 13:41:56 -05:00
Charles Kerr
e3f2ca1425
chore: remove use of banned absl::optional ( #44513 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
2024-11-04 12:37:04 -06:00
Charles Kerr
f5bdbdb1e8
refactor: more inline constexpr string view ( #44498 )
...
* chore: remove unused electron::kHidProductIdKey
* refactor: make electron::kHidDeviceNameKey inline constexpr std::string_view
refactor: make electron::kHidGuidKey inline constexpr std::string_view
* refactor: make serial_chooser_context keys inline constexpr std::string_view
* refactor: make native_window keys inline constexpr std::string_view
* refactor: make electron::options keys inline constexpr std::string_view pt 1
* fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
chore: make kElectronNativeWindowKey a base::cstring_view
ui::Widget::GetNativeWindowProperty requires a const char*
* refactor: make electron::options keys inline constexpr std::string_view pt 2
* refactor: make electron::options keys inline constexpr std::string_view pt 3
* refactor: make electron::options keys inline constexpr std::string_view pt 4
* refactor: make electron::options keys inline constexpr std::string_view pt 5
* refactor: make electron::options keys inline constexpr std::string_view pt 6
* refactor: make electron::options keys inline constexpr std::string_view pt 7
* refactor: make electron::options keys inline constexpr std::string_view pt 8
* chore: remove unused file shell/common/options_switches.cc
* docs: add code comment explaining use of base::cstring_view
* fixup! fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
* chore: use consistent capitalization of the word 'fullscreen'
2024-11-04 12:27:49 -06:00
electron-roller[bot]
48801be8e9
chore: bump chromium to 132.0.6807.0 (main) ( #44360 )
...
* chore: bump chromium in DEPS to 132.0.6791.0
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5804481
* chore: try revert PA CL
* chore: bump chromium in DEPS to 132.0.6793.0
* chore: bump chromium in DEPS to 132.0.6794.0
* 5952404: Clean up //ui/base/resource from Lacros code.
https://chromium-review.googlesource.com/c/chromium/src/+/5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
https://chromium-review.googlesource.com/c/chromium/src/+/5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
https://chromium-review.googlesource.com/c/chromium/src/+/5943708
* chore: fixup patch indices
* 5937004: Remove components/services/language_detection
https://chromium-review.googlesource.com/c/chromium/src/+/5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
https://chromium-review.googlesource.com/c/chromium/src/+/5920322
* chore: bump chromium in DEPS to 132.0.6797.0
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
https://chromium-review.googlesource.com/c/chromium/src/+/5947724
* chore: fixup patch indices
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
https://chromium-review.googlesource.com/c/chromium/src/+/5948024
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/5945209
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5942398
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5963016
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6805.0
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5924816
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
* 5829616: MPArch based GuestViews basic implementation
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5829616
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5953710
* chore: fixup patch indices
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | https://chromium-review.googlesource.com/c/chromium/src/+/5938657
* chore: bump chromium in DEPS to 132.0.6807.0
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5868889
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5956408
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962696
* chore: update patches
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973073
* chore: update filenames.libcxx.gni
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 09:10:00 -05:00
Ani Betts
d9a9d5b8fe
docs: Update Squirrel Run at Login docs to be modern ( #44487 )
...
Update Squirrel Run at Login docs to be modern
The current docs for setting up Run at Login use the legacy way that
Squirrel does shortcuts. This was replaced by an easier method, let's
use that instead
2024-11-02 15:56:02 -05:00
Charles Kerr
7fea537fbf
docs: fix apostrophe typo "Electrons" -> "Electron's" ( #44516 )
...
s/Electrons/Electron's/
2024-11-02 15:52:22 -05:00
David Sanders
bc6c7bd757
build: remove unused lint package ( #44525 )
2024-11-02 13:57:15 -05:00
Charles Kerr
9137d96ef4
refactor: remove unused C string ToV8() gin converter ( #44500 )
2024-11-01 18:11:46 -05:00
Charles Kerr
b985d8eb28
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter ( #44501 )
2024-11-01 15:01:09 -05:00
Anny Yang
2081f771e4
docs: add custom titlebar example ( #43693 )
...
* docs: add custom titlebar example
* docs: add links and other small edits
* docs: add panel window docs
* docs: remove panel example
* docs: specify expected emphasis style
* docs: responding to feedback
* docs: fix section names in links
* docs: rework baseWindow note
* docs: making window customization its own section
* responding to feedback
2024-11-01 11:04:37 -04:00
Shelley Vohr
15151c6853
fix: EventSource undefined in Renderer/Worker ( #44475 )
2024-10-31 15:24:44 -04:00
John Kleinschmidt
8be4ae4bab
build: handle out of disk space on source cache ( #44490 )
...
* build: handle out of disk space on source cache
* build: add cron job to free up source cache disk space
2024-10-31 15:03:28 -04:00
Sam Maddock
31f8e7553b
fix: flaky utility and BrowserView tests ( #44451 )
...
* fix: flake wait for crash with specific serviceName
* fix: flake when unrelated WebContents exists during BrowserView tests
* fix: wait for crash before forking
* use name
2024-10-30 20:29:01 -05:00
Charles Kerr
7cdf1a01b8
docs: fix win.setContentView() arg type ( #44478 )
...
fix: setContentView type
2024-10-30 15:56:10 -04:00
Charles Kerr
a720c8daf6
perf: remove isolate scope from DidProcessTask() ( #44439 )
2024-10-29 23:25:40 -05:00
Charles Kerr
fb959f8d30
build: enable -Wunsafe-buffer-usage warnings ( #44056 )
2024-10-29 17:28:34 -05:00
Alice Zhao
de04fc3b90
fix: update shell.openExternal to correctly focus on external window ( #44408 )
...
* fix: Use openURL:configuration:completionHandler instead of openUrl
* test: add a test
* fix: add dispatch_async to replace GetUIThreadTaskRunner
* refactor: remove unused import
* fix: update to use BindPostTaskToCurrentDefault
* test: add regression test for window focus
* refactor: update to explicit task runner
2024-10-29 15:10:10 -07:00
Shelley Vohr
7ff7160135
docs: fix win.getContentView() return type ( #44430 )
...
docs: fix win.getContentView() return type
2024-10-29 21:41:44 +01:00
Shelley Vohr
9fc94a162b
build: fix python util verbose mode logic ( #44431 )
...
build: fix verbose mode logic
2024-10-29 11:35:57 -04:00
Devin Binnie
53458da01e
docs: Fix powerMonitor docs for type generation of speed-limit-change ( #44391 )
...
Fix `powerMonitor` docs for type generation of `speed-limit-change`
2024-10-29 10:16:29 -05:00
Charles Kerr
dffe00b232
fix: -Wunsafe-buffer-usage warnings with argc, argv ( #44366 )
...
* refactor: move uv_setup_args() calls to startup
* refactor: call base::CommandLine::Init() before ContentMain()
* feat: add ElectronCommandLine::AsUtf8()
* refactor: call base::CommandLine::Init() before NodeMain()
* refactor: use ElectronCommandLine::AsUtf8() in NodeMain()
* fix: -Wunsafe-buffer-usage warning in ElectronCommandLine::Init()
* chore: add a DCHECK to confirm ElectronCommandLine was initialized before AsUtf8() is called
* chore: const correctness in ElectronCommandLine::Init() args
* chore: add ElectronCommandLine to macOS Electron Helper app
* chore: move argc, argvc setup into electron_library_main on macOS
* chore: revert BUILD.gn changes
* fix: WideToUTF8() call in ElectronCommandLine::AsUtf8()
* build: add uv to the include paths for app/electron_main_linux
* build: add uv to the include paths for app/electron_library_main.mm
* chore: revert unrelated changes
these were intended for another branch
2024-10-29 13:23:08 +01:00
Shelley Vohr
39b24aed92
refactor: move node ofs script to electron ( #44425 )
...
* refactor: move node ofs script to electron
* chore: remove empty file
2024-10-29 13:22:26 +01:00
dependabot[bot]
f7ead785cd
build(deps): bump actions/setup-node from 4.0.4 to 4.1.0 ( #44433 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.4 to 4.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](0a44ba7841...39370e3970 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 13:21:09 +01:00
Charles Kerr
b3c2e83243
refactor: prefer inline constexpr string_view for string constants ( #44405 )
...
* refactor: BaseWindow::OnExecuteAppCommand() now takes a std::string_view
* refactor: NativeWindow::NotifyWindowExecuteAppCommand() takes a std::string_view
* refactor: AppCommandToString() returns a std::string_view, is now constexpr
* refactor: make kBrowserBackward, kBrowserForward inline constexpr std::string_view
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: use inline constexpr string_view for kDevice*Key constants
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: IsEnvSet now takes a base::cstring_view
* refactor: use inline constexpr cstring_view for kRunAsNode
* refactor: use inline constexpr string_view for kPDF*PluginName
* refactor: use base::FilePath::FromASCII() since "internal-pdf-viewer" is ascii
* chore: remove unused shell/common/electron_constants.cc
* fixup! refactor: IsEnvSet now takes a base::cstring_view
2024-10-29 10:30:12 +01:00
dependabot[bot]
cc3359f126
build(deps): bump actions/checkout from 4.2.1 to 4.2.2 ( #44435 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901b )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 09:59:22 +01:00
Shelley Vohr
46561fc5bc
build: improve gen-libc++-filenames output ( #44424 )
...
build: improve gen-libc++-filenames output
2024-10-29 09:59:10 +01:00
dependabot[bot]
214c8228ed
build(deps): bump github/codeql-action from 3.26.13 to 3.27.0 ( #44434 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.13 to 3.27.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f779452ac5...662472033e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 01:05:46 -05:00
Robo
739688214b
fix: keep gdk_pixbuf a dynamic dependency ( #44423 )
2024-10-29 09:44:20 +09:00
Charles Kerr
5d0d15a0b3
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals ( #44412 )
...
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
* perf: string length is known when calling NewFromUtf8(), so use it
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
2024-10-28 14:12:32 +01:00
Sam Maddock
348801b20e
fix: crash on netlog connection error ( #44406 )
...
* fix: crash on netlog connection error
* refactor: remove default PromiseBase constructor
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d .
* remove dcheck
2024-10-28 10:24:54 +01:00
John Kleinschmidt
57920e7747
test: deflake flaky tests on linux ( #44383 )
2024-10-24 20:47:17 -04:00
John Kleinschmidt
a0f51d816e
build: update linux container ( #44392 )
2024-10-24 16:58:36 -04:00
Charles Kerr
83d7040096
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44348 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
* refactor: use base::HexEncode() instead of rolling our own
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
2024-10-23 14:18:22 -05:00
John Kleinschmidt
c42fb09fc9
test: fixup flaky tests ( #44349 )
...
* test: fixup flaky test
* test: disable flaky protocol speed test on macOS
* test: fixup flaky test in api-browser-window-spec.ts
2024-10-23 15:14:50 -04:00
Shelley Vohr
fd500477ac
docs: clarify utilityProcess child.pid value ( #44339 )
2024-10-22 13:09:33 -04:00
electron-appveyor-updater[bot]
d60d526df6
build: update appveyor image to latest version ( #44334 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-10-22 10:40:00 -04:00
Charles Kerr
e3e94d45ee
fix: silence -Wunsafe-buffer-usage warning in GetPreferredLanguages() ( #44333 )
...
fix: use UNSAFE_BUFFERS macro in GetPreferredLanguages()
2024-10-21 18:20:00 -05:00
Sam Maddock
fff6ea438a
fix: software compositing infinite loop ( #44318 )
...
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-10-21 18:56:03 -04:00
Robo
3e77faf2f7
fix: crash when generating shortcut text for super accelerator ( #44341 )
2024-10-22 03:26:38 +09:00
John Kleinschmidt
cc9d85d3ca
build: fixup reclient use for prod builds ( #44340 )
2024-10-21 14:07:02 -04:00
electron-roller[bot]
d3d02ef111
chore: bump chromium to 132.0.6789.0 (main) ( #44337 )
...
chore: bump chromium in DEPS to 132.0.6789.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-21 10:48:59 -04:00
electron-roller[bot]
e70f70f5b4
chore: bump chromium to 132.0.6788.0 (main) ( #44331 )
...
chore: bump chromium in DEPS to 132.0.6788.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-20 23:54:06 -05:00
electron-roller[bot]
0d948da4b9
chore: bump chromium to 132.0.6787.0 (main) ( #44329 )
...
* chore: bump chromium in DEPS to 132.0.6785.0
* chore: bump chromium in DEPS to 132.0.6787.0
* 5837702: mac fullscreen: always show traffic lights
https://chromium-review.googlesource.com/c/chromium/src/+/5837702
* 5892572: Move SimpleMenuModel out of ui/base
https://chromium-review.googlesource.com/c/chromium/src/+/5892572
* 5938185: Remove lacros code from //ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/5938185
* chore: fixup patch indices
* 5939514: Wire up the preference of overlay scrollbars to the ChromeOS settings
https://chromium-review.googlesource.com/c/chromium/src/+/5939514
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-20 19:02:21 -05:00
dependabot[bot]
2cf59b3885
build(deps-dev): bump webpack from 5.94.0 to 5.95.0 ( #44309 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.94.0 to 5.95.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.94.0...v5.95.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-20 10:40:03 +02:00
Sam Maddock
87bd665e41
feat: expose frame & move properties to console-message event object ( #43617 )
...
* feat: expose frame on console-message event
refactor: use property names similar to ServiceWorker's console-message event
refactor: don't use deprecated params in tests
doc: console-message breaking change
chore: add deprecation warning
docs: restore deprecated argument descriptions
* move console-message deprecations to v34
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 16:07:06 -04:00
John Beutner
35aeab6ecd
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44078 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 14:29:52 -04:00
electron-roller[bot]
738533dec7
chore: bump chromium to 132.0.6783.0 (main) ( #44307 )
...
* chore: bump chromium in DEPS to 132.0.6782.0
* chore: bump chromium in DEPS to 132.0.6783.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 12:06:33 -04:00
electron-appveyor-updater[bot]
456aac1f94
build: update appveyor image to latest version ( #44311 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-10-18 11:24:24 -04:00
dependabot[bot]
6c6e5c002a
build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3 ( #44173 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](50769540e7...b4b15b8c7c )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-18 15:39:55 +02:00
electron-roller[bot]
089f233054
chore: bump chromium to 132.0.6781.0 (main) ( #44301 )
...
* chore: bump chromium in DEPS to 132.0.6781.0
* chore: update patches
* 5933789: [MappableSI] Remove kill-switch from RenderableGpuMemoryBufferVideoFramePool.
https://chromium-review.googlesource.com/c/chromium/src/+/5933789
* 5938992: Reland: Remove `force_guest_profile` param from context getters.
https://chromium-review.googlesource.com/c/chromium/src/+/5938992
* 5928743: spanification: Add WTF::String::FromUTF8(span<>) overloads
https://chromium-review.googlesource.com/c/chromium/src/+/5928743
* 5898835: Update windows SDK version to 10.0.26100.1742
https://chromium-review.googlesource.com/c/chromium/src/+/5898835
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-17 20:00:59 -04:00
dependabot[bot]
2b0624f2f1
build(deps-dev): bump remark-cli from 10.0.0 to 12.0.1 ( #44258 )
...
Bumps [remark-cli](https://github.com/remarkjs/remark ) from 10.0.0 to 12.0.1.
- [Release notes](https://github.com/remarkjs/remark/releases )
- [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md )
- [Commits](https://github.com/remarkjs/remark/compare/10.0.0...remark-cli@12.0.1 )
---
updated-dependencies:
- dependency-name: remark-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-17 15:15:48 -04:00
Keeley Hammond
ac09d11ed1
build: fix main printing patch conflict ( #44302 )
...
build: update patches
2024-10-17 11:29:04 -04:00
John Kleinschmidt
9280add5b4
chore: fixup reclient read only access on forks ( #44280 )
2024-10-17 11:17:54 -04:00
Mayur
44c398fedb
docs: removed AngularJS Batarang from the Devtool Extension Support ( #44261 )
...
docs: update Devtool Extension Support
2024-10-17 10:55:05 -04:00
David Sanders
cbc12d6675
ci: use Node.js 20 in Bake AppVeyor Image workflow ( #44290 )
...
* ci: use Node.js 20 in Bake AppVeyor Image workflow
* chore: add bake workflow to CODEOWNERS
2024-10-17 10:35:50 -04:00
electron-roller[bot]
d801bad5d2
chore: bump chromium to 132.0.6779.0 (main) ( #44273 )
...
* chore: bump chromium in DEPS to 132.0.6779.0
* chore: update patches
* 5904951: controlledframe: Disable File System Access for <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5904951
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-16 21:41:31 -04:00
Shelley Vohr
d386664900
build: use new Issue Template types in templates ( #44224 )
...
* build: use new Issue Template types in templates
* build: restore existing labels for now
2024-10-16 15:34:35 -04:00
David Sanders
67775d19ec
build: remove dead code in prepare release script ( #44256 )
2024-10-16 15:05:09 -04:00
Shelley Vohr
cbe3cb770a
fix: Linux crash after webContents.print() with no parent window ( #44246 )
...
fix: Linux crash after print with no parent window
2024-10-16 13:15:21 -04:00
Shelley Vohr
bd4ea5ba72
fix: use proper PDF save approach ( #44248 )
2024-10-16 11:33:21 -04:00
Robo
af6e2fb257
fix: trace-startup crashing child process on macOS ( #44257 )
2024-10-16 11:03:00 -04:00
Shelley Vohr
df45474b58
fix: ensure utilityProcess only emits one 'exit' event ( #44243 )
...
fix: ensure utilityProcess only emits one exit
2024-10-16 10:47:12 +02:00
Charles Kerr
b5acebf3ba
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44238 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
2024-10-15 18:31:44 -05:00
electron-roller[bot]
ef84f13650
chore: bump chromium to 131.0.6778.0 (main) ( #44251 )
...
* chore: bump chromium in DEPS to 131.0.6778.0
* 5803393: [UI] Add alias for mojo version of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5803393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-15 16:41:14 -04:00
electron-roller[bot]
36b7cf341e
chore: bump chromium to 131.0.6776.0 (main) ( #44137 )
...
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs 4017a6c8b4
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
https://github.com/nodejs/node/pull/54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092fc51 .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-15 11:51:11 -04:00
Niklas Wenzel
72802c374b
docs: add section on resource management to base-window.md ( #43610 )
2024-10-15 11:49:54 -04:00
David Sanders
d3e368003b
ci: use env variable in branch created workflow ( #44240 )
2024-10-15 11:16:04 -04:00
dependabot[bot]
0064b23440
build(deps): bump github/codeql-action from 3.26.12 to 3.26.13 ( #44239 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.12 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c36620d31a...f779452ac5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 10:51:34 +02:00
Shelley Vohr
1cab6bde94
build: update devcontainer sha ( #44229 )
2024-10-15 10:35:43 +02:00
George Xu
9ecb848c67
docs: update timelines for E34 ( #44210 )
...
update dates for e34
2024-10-14 10:52:18 -04:00
John Kleinschmidt
48156aee06
test: run visibility-state-spec.ts first ( #44206 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2024-10-14 09:40:22 -04:00
Charles Kerr
566c72cd46
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44211 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
* refactor: restore node buffer span util
* refactor: remove redundant span wrapper
2024-10-14 10:46:24 +02:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:33:53 -04:00
Charles Kerr
527efc01a4
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44185 )
2024-10-11 14:29:00 -05:00
dependabot[bot]
6c1b377192
build(deps): bump actions/checkout from 4.1.7 to 4.2.1 ( #44140 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...eef61447b9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 12:28:45 -05:00
dependabot[bot]
13b39e0eeb
build(deps): bump github/codeql-action from 3.26.8 to 3.26.12 ( #44139 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.8 to 3.26.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](294a9d9291...c36620d31a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:32:17 +02:00
Samuel Attard
7402648ee3
build: update ts defs and docs parser ( #43985 )
...
* build: update ts defs and docs parser
* build: update dig
2024-10-11 10:44:18 -04:00
Niklas Wenzel
5400c04e43
docs: clarify interplay between utility process events ( #44015 )
2024-10-11 10:25:25 -04:00
Robo
dd5b36f557
fix: clang variable configuration in generated node headers ( #44189 )
...
* fix: clang variable configuration in generated node headers
* chore: restore value in common.gypi
2024-10-11 10:22:56 -04:00
John Kleinschmidt
8201623d92
test: fix visibility-state-spec.ts flaky test ( #44037 )
...
* test: refactor visibility-state-spec
* ci: shard tests
* test: update split-tests for use on Windows
* test: run visibility-state-spec.ts first
2024-10-11 10:00:22 -04:00
John Kleinschmidt
d93285dde1
ci: don't call datadog test logging on forks ( #44181 )
2024-10-11 12:08:51 +02:00
Charles Kerr
3d2f68a9df
refactor: spanify image utils ( #44127 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
* feat: add Node-buffer-to-base-span helper function
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
* refactor: use base::as_byte_span()
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
* chore: add // SAFETY comment for Node-buffer-to-span func
* chore: add // SAFETY comment for NSData-to-span func
2024-10-10 09:34:55 -04:00
Michaela Laurencin
d51ef7d794
build: update NMV to 132 ( #44135 )
...
Node PR: https://github.com/nodejs/node/pull/55306
Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34
Please merge this PR before branching 34-x-y
2024-10-09 11:55:59 -07:00
Charles Kerr
78fa477726
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44133 )
2024-10-09 13:02:00 -05:00
Charles Kerr
dbbdf55493
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44134 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
2024-10-09 12:18:19 -05:00
Charles Kerr
b5227b4a17
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 )
...
fixup e8948397 really fix the warning this time
2024-10-09 09:12:48 -05:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
John Kleinschmidt
ebeae6f301
ci: only upload to datadog when running tests ( #44152 )
2024-10-08 15:07:17 -04:00
Charles Kerr
4cf69f396f
fix: context shear in cli_remove_deprecated_v8_flag.patch ( #44148 )
...
fix: patch shear in cli_remove_deprecated_v8_flag.patch
2024-10-08 07:54:33 -07:00
electron-roller[bot]
bcbc8d3bb2
chore: bump chromium to 131.0.6762.0 (main) ( #44117 )
...
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-10-07 18:06:47 -05:00
John Kleinschmidt
aa40e817c8
ci: add datadog test logging ( #44094 )
2024-10-07 18:51:23 -04:00
electron-roller[bot]
b95ee8964c
chore: bump node to v20.18.0 (main) ( #44119 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-07 18:51:08 -04:00
electron-roller[bot]
ab1488a1be
chore: bump chromium to 131.0.6754.0 (main) ( #44110 )
...
* chore: bump chromium in DEPS to 131.0.6754.0
* chore: update gin_enable_disable_v8_platform.patch
fix minor context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5901115
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-03 13:35:03 -04:00
Samuel Attard
122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
Charles Kerr
684e345f68
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44068 )
...
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
2024-10-02 16:44:28 -04:00
Charles Kerr
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
Keeley Hammond
93dd9fc17b
build: use node 20.17 on Windows ( #44065 )
...
* build: rebake image
* build: use e-131.0.6734.0-node-20.17-0
* build: bump msvs version to 2022
2024-10-02 20:12:41 +02:00
electron-roller[bot]
59a43ef2e3
chore: bump chromium to 131.0.6752.0 (main) ( #44093 )
...
* chore: bump chromium in DEPS to 131.0.6752.0
* chore: update refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
adjust to upstream #include shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5872830
* chore: e patches all
* Remove the <selectlist> prototype implementation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5855076
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 08:35:18 -07:00
electron-roller[bot]
5a97ee26ff
chore: bump chromium to 131.0.6751.0 (main) ( #44087 )
...
chore: bump chromium in DEPS to 131.0.6751.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:30:40 -05:00
Samuel Attard
5b34138db8
build: fix relative file read during npm publish ( #44088 )
2024-10-01 17:09:57 -07:00
electron-roller[bot]
1fc2064f6a
chore: bump chromium to 131.0.6750.0 (main) ( #44066 )
...
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-01 19:34:32 -04:00
Samuel Attard
f4ffd018e6
build: cleanup release scripts, separate cli entrypoints from logic ( #44058 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 13:51:40 -07:00
Charles Kerr
15c8759ee0
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() ( #44053 )
2024-10-01 10:06:02 -07:00
Charles Kerr
06bce8166b
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44055 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
2024-10-01 10:05:46 -07:00
Charles Kerr
6f88f0c795
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44067 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-01 10:04:57 -07:00
Samuel Attard
f828c1da09
build: remove github actions dependabot on release branches ( #44054 )
2024-10-01 08:50:42 -07:00
Samuel Attard
47cf1e3acd
build: use ts-node to spawn the version-bumper ( #44057 )
...
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-09-30 21:19:59 -07:00
Samuel Attard
61565465fd
build: convert all release scripts to typescript ( #44035 )
...
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
2024-09-30 17:55:27 -07:00
Keeley Hammond
7ebc427bf5
build: update appveyor to node 20.17 ( #44026 )
...
* build: update appveyor to node 20.17
* build: bake new images with npm dir
* build: use e-131.0.6734.0-node-20.17-1
2024-09-30 16:14:46 -04:00
electron-roller[bot]
5d9800e176
chore: bump chromium to 131.0.6748.0 (main) ( #44027 )
...
* chore: bump chromium in DEPS to 131.0.6748.0
* chore: gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 13:32:50 -04:00
Charles Kerr
1d4b86cb3e
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44024 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
2024-09-30 11:01:24 -05:00
Charles Kerr
77f7ba96ca
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44014 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: remove logging
* fix: unconditionally write
* chore: naming
* chore: add code comments
* chore: more code comments
* chore: remove unrelated changes
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: naming
* refactor: naming
* refactor: naming
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
2024-09-30 15:09:36 +02:00
electron-roller[bot]
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 14:54:44 +02:00
Charles Kerr
eb40d2cbfa
fix: FTBFS when building with enable_plugins = false ( #44003 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
2024-09-29 17:10:34 -05:00
John Kleinschmidt
27d2a8f9e2
ci: write test logging to console on Windows ( #43990 )
...
test: write logging to console on Windows
2024-09-27 15:17:32 -04:00
Shelley Vohr
d4e4cdee6c
fix: remove resize listener when BrowserWindow closed ( #43972 )
2024-09-27 10:34:00 -04:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-27 10:17:06 +09:00
Charles Kerr
8397fef3ef
chore: remove unused nogncheck includes ( #43964 )
2024-09-26 17:09:42 -05:00
Charles Kerr
852f9ff329
perf: build g_dgettext domain name at compile time ( #43960 )
...
perf: build GettextPackage name at compile time
2024-09-26 13:10:30 -04:00
Charles Kerr
a974b74e82
fix: replace deprecated libnotify API calls ( #43962 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 11:21:45 -05:00
Shelley Vohr
da6ab92353
fix: ensure correct WebContents when checking PDFReadyToPrint ( #43943 )
...
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
2024-09-26 10:54:13 -04:00
Charles Kerr
ddd45db6ca
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43956 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
2024-09-26 08:32:43 -05:00
John Kleinschmidt
40cae71df8
test: re-enable tests that were disabled in chromium rolls ( #43968 )
...
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
2024-09-26 08:53:27 -04:00
electron-appveyor-updater[bot]
b60013fcf1
build: update appveyor image to latest version ( #43971 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-26 13:10:34 +02:00
Samuel Attard
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
Fedor Indutny
15db63e26d
fix: SCContentSharingPicker crash in iframes ( #43905 )
...
When running `getDisplayMedia` from an `iframe` and then destroying that
`iframe`, the destrutcor for ScreenCaptureKitDeviceMac gets run, but it
doesn't clean up the observers for the shared macOS picker.
In this change we remove the observer on cleanup and fix the associated
crash:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x12c024123a0> was mutated while being enumerated.'
0 CoreFoundation 0x000000018eda0ec0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018e886cd8 objc_exception_throw + 88
2 CoreFoundation 0x000000018ee47f80 -[__NSSingleObjectEnumerator init] + 0
3 ScreenCaptureKit 0x000000022971f3e0 -[SCContentSharingPicker contentPickerDidSelectFilter:forStream:] + 436
4 ReplayKit 0x00000001d7b879d8 -[RPScreenRecorder contentPickerDidSelectFilter:forStream:] + 84
5 ReplayKit 0x00000001d7b95ce0 -[RPDaemonProxy contentPickerDidSelectFilter:forStream:] + 224
6 CoreFoundation 0x000000018ed0e8b4 __invoking___ + 148
7 CoreFoundation 0x000000018ed0e72c -[NSInvocation invoke] + 428
8 ReplayKit 0x00000001d7b91678 -[RPDaemonProxy connection:handleInvocation:isReply:] + 316
9 Foundation 0x0000000190899f64 -[NSXPCConnection _decodeAndInvokeMessageWithEvent:reply:flags:] + 1108
10 Foundation 0x000000019089b7d0 message_handler_message + 88
11 Foundation 0x000000018feb0160 message_handler + 152
12 libxpc.dylib 0x000000018e954460 _xpc_connection_call_event_handler + 144
13 libxpc.dylib 0x000000018e952bb4 _xpc_connection_mach_event + 1120
14 libdispatch.dylib 0x000000018ea94718 _dispatch_client_callout4 + 20
15 libdispatch.dylib 0x000000018eab0c00 _dispatch_mach_msg_invoke + 464
16 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
17 libdispatch.dylib 0x000000018eab1954 _dispatch_mach_invoke + 456
18 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
19 libdispatch.dylib 0x000000018ea9c79c _dispatch_lane_invoke + 432
20 libdispatch.dylib 0x000000018eaa77e8 _dispatch_root_queue_drain_deferred_wlh + 288
21 libdispatch.dylib 0x000000018eaa7034 _dispatch_workloop_worker_thread + 540
22 libsystem_pthread.dylib 0x000000018ec433d8 _pthread_wqthread + 288
23 libsystem_pthread.dylib 0x000000018ec420f0 start_wqthread + 8
2024-09-25 16:43:23 -07:00
dependabot[bot]
ff36ff84b7
build(deps-dev): bump eslint-plugin-promise from 4.3.1 to 7.1.0 ( #43935 )
...
Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise ) from 4.3.1 to 7.1.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-promise/releases )
- [Changelog](https://github.com/eslint-community/eslint-plugin-promise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint-community/eslint-plugin-promise/compare/v4.3.1...v7.1.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-promise
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 16:49:03 -05:00
dependabot[bot]
846b31b77d
build(deps-dev): bump @types/chai-as-promised from 7.1.3 to 8.0.1 ( #43936 )
...
Bumps [@types/chai-as-promised](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai-as-promised ) from 7.1.3 to 8.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai-as-promised )
---
updated-dependencies:
- dependency-name: "@types/chai-as-promised"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 09:06:26 -05:00
John Beutner
c8895d0547
fix: close all open sheets before closing window on macOS ( #43706 )
2024-09-25 13:23:49 +02:00
Charles Kerr
1d3b1284c4
test: ensure sender-pid hint is set in Linux notifications ( #43928 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
2024-09-25 13:20:36 +02:00
electron-roller[bot]
30fbeec036
chore: bump chromium to 131.0.6734.0 (main) ( #43769 )
...
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119 : Declutter: Allow opening to a specific feature
https://chromium-review.googlesource.com/c/chromium/src/+/5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
https://chromium-review.googlesource.com/c/chromium/src/+/5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-09-25 06:19:39 -05:00
Charles Kerr
af54c5a4b6
test: add tests dbus notification images ( #43938 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
2024-09-25 13:17:27 +02:00
Shelley Vohr
bcf4095ace
fix: crash when focusing WebView webContents ( #43921 )
...
fix: crash when focusing WebView
2024-09-24 18:19:04 -05:00
Charles Kerr
500d4f0d05
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43896 )
2024-09-24 15:41:24 -05:00
CezaryKulakowski
e64a66bfd3
fix: detach native view when its removed from parent on macOS ( #43627 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
2024-09-24 15:28:36 +02:00
dependabot[bot]
7222a9fe1f
build(deps-dev): bump null-loader from 4.0.0 to 4.0.1 ( #43904 )
...
Bumps [null-loader](https://github.com/webpack-contrib/null-loader ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/webpack-contrib/null-loader/releases )
- [Changelog](https://github.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/null-loader/compare/v4.0.0...v4.0.1 )
---
updated-dependencies:
- dependency-name: null-loader
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 10:13:43 +02:00
dependabot[bot]
65e3c336e0
build(deps-dev): bump eslint from 8.41.0 to 8.57.1 ( #43903 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.41.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.41.0...v8.57.1 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:31:47 -07:00
Charles Kerr
79627deea3
refactor: add SerialChooserController::web_contents_ ( #43823 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
2024-09-23 22:38:13 -07:00
Charles Kerr
9598d88b7c
refactor: remove C-style void arg type for no-arg functions ( #43884 )
...
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-23 22:37:32 -07:00
Charles Kerr
01330805cb
refactor: prefer member initializers in asar structs ( #43883 )
...
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
2024-09-23 22:37:18 -07:00
Charles Kerr
33d7c9ac3e
refactor: hide printing impl details in api::WebContents ( #43893 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
* refactor: remove unused #include
2024-09-23 22:36:55 -07:00
Keeley Hammond
a3af8ea768
build: use Node 20 in Appveyor images ( #43897 )
...
* build: update Appveyor to Node 20
* build: update appveyor images
* chore: return bake script to original form
2024-09-23 16:58:46 -07:00
dependabot[bot]
82879d1f43
build(deps-dev): bump webpack-cli from 4.10.0 to 5.1.4 ( #43880 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.10.0 to 5.1.4.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.10.0...webpack-cli@5.1.4 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 18:21:43 -05:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Alice Zhao
ceea1225a2
docs: navigation history example ( #42980 )
...
* docs: add fiddle example
* docs: add tutorial guide
* refactor: PR review comments
* refactor: add eof
* refactor: render navigation history and make demo better.
* refactor: fix broken links
* refactor: add eof newline
* docs: review feedback :)
* chore: lint add space around list
* doc: transformURL
2024-09-23 10:18:26 -07:00
Samuel Attard
517d04de16
build: add support for fetching github token from sudowoodo ( #43808 )
...
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 09:39:54 -07:00
dependabot[bot]
f0afcaa777
build(deps-dev): bump @types/w3c-web-serial from 1.0.3 to 1.0.7 ( #43879 )
...
Bumps [@types/w3c-web-serial](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/w3c-web-serial ) from 1.0.3 to 1.0.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/w3c-web-serial )
---
updated-dependencies:
- dependency-name: "@types/w3c-web-serial"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 08:07:53 -05:00
Samuel Attard
be68d4f336
build: update-check-skip on dependabot backport PRs ( #43874 )
2024-09-23 11:08:03 +02:00
dependabot[bot]
0fb50c408b
build(deps): bump github/codeql-action from 3.26.7 to 3.26.8 ( #43826 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8214744c54...294a9d9291 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 11:04:21 +02:00
dependabot[bot]
1b52f005ee
build(deps): bump actions/setup-node from 4.0.3 to 4.0.4 ( #43825 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1e60f620b9...0a44ba7841 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-22 23:40:30 -07:00
Samuel Attard
da449b00dd
build: stop dependabot doing things ( #43871 )
2024-09-22 23:10:23 -07:00
Samuel Attard
8be458d1a2
build: enable dependabot on supported branches ( #43755 )
2024-09-22 22:57:23 -07:00
Charles Kerr
e894839709
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43803 )
2024-09-21 17:21:02 -05:00
Shelley Vohr
f89bd745d5
fix: createWindow shouldn't load URL for webContents ( #43775 )
...
* fix: createWindow shouldn't load URL for webContents
* chore: add non about blank test
2024-09-20 09:56:03 +02:00
Charles Kerr
bcb7362ab9
docs: document Windows pitfall when updating patches ( #43787 )
2024-09-19 23:35:21 -05:00
Charles Kerr
53e89b565d
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43795 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
* chore: add a DCHECK to confirm the BigBuffer is full
2024-09-19 23:10:35 -05:00
Fedor Indutny
6aa6bada79
fix: third time screen sharing on macOS ( #43767 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com >
2024-09-19 18:28:28 -07:00
Charles Kerr
d100921289
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43794 )
2024-09-19 19:02:49 -05:00
BILL SHEN
855f219301
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43773 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
2024-09-19 13:01:36 +02:00
dependabot[bot]
0ac8ff6439
build(deps): bump path-to-regexp from 1.8.0 to 1.9.0 in /spec in the npm_and_yarn group across 1 directory ( #43753 )
...
build(deps): bump path-to-regexp
Bumps the npm_and_yarn group with 1 update in the /spec directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp ).
Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 10:34:06 +02:00
Charles Kerr
5904d31264
perf: hold V8FunctionInvoker args in a std::array ( #43752 )
...
perf: hold V8FunctionInvoker args in a std::array
2024-09-18 16:23:29 -05:00
Samuel Attard
8cff5a7d20
build: let darwin/mas run concurrently ( #43788 )
2024-09-18 13:54:58 -07:00
Charles Kerr
d897359b82
perf: hold Emit() arg arrays in a std::array ( #43750 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
2024-09-18 09:40:14 -05:00
electron-appveyor-updater[bot]
02fd8bbcc1
build: update appveyor image to latest version ( #43772 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-18 09:39:49 -05:00
electron-roller[bot]
4bcbc955dd
chore: bump chromium to 130.0.6695.0 (main) ( #43454 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2024-09-17 18:12:11 -07:00
Samuel Attard
de33cc68f6
build: split darwin/mas macOS publish jobs ( #43754 )
2024-09-17 15:32:47 -07:00
Samuel Attard
f987f8ad83
build: improve logging on http errors during release process (again, but more) ( #43758 )
2024-09-17 15:01:02 -07:00
Samuel Attard
cf4ab2186c
build: improve logging on http errors during release process (again) ( #43757 )
2024-09-17 14:49:59 -07:00
Samuel Attard
10ba87a85e
build: improve logging on http errors during release process ( #43756 )
2024-09-17 14:30:51 -07:00
Charles Kerr
233724fe00
chore: iwyu mojom-forward header files ( #43741 )
...
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-17 12:58:56 -07:00
dependabot[bot]
4dc923a327
build(deps): bump the npm_and_yarn group across 2 directories with 5 updates ( #43681 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [send](https://github.com/pillarjs/send ).
Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0 )
Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases )
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/body-parser/compare/1.20.2...1.20.3 )
Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10 )
Updates `serve-static` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/expressjs/serve-static/releases )
- [Changelog](https://github.com/expressjs/serve-static/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/serve-static/compare/v1.15.0...1.16.0 )
Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases )
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md )
- [Commits](https://github.com/pillarjs/send/compare/0.16.2...0.19.0 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: body-parser
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: serve-static
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: send
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-17 11:27:32 -04:00
Charles Kerr
5a76655fb8
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43729 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
2024-09-17 09:00:52 -05:00
Shelley Vohr
aa719a4066
fix: resizing border on Linux WCO caption buttons ( #43724 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
2024-09-17 11:56:43 +02:00
Samuel Attard
c1c8fbfd9a
build: make is_mas_build a generated header instead of config ( #43737 )
2024-09-17 01:38:56 -07:00
dependabot[bot]
b83810982e
build(deps): bump github/codeql-action from 3.26.6 to 3.26.7 ( #43738 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.6 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4dd16135b6...8214744c54 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-16 23:09:24 -05:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
05dfd14913
refactor: add EmitWarning(v8::Isolate*) helper ( #43722 )
...
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-16 15:53:04 -05:00
John Kleinschmidt
7d4f202c1c
ci: move Archaeologist to GHA ( #43701 )
...
* chore: move Archaeologist to GHA
* chore: test archaelogist changes
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a .
* chore: properly name steps in archaeologist-dig
2024-09-16 15:58:51 -04:00
Niklas Wenzel
f84ffc8fc8
fix: prevent loading spinner when launching utility process on Windows ( #43657 )
...
fix: prevent spinning cursor when launching utility process on Windows
2024-09-16 14:20:42 -04:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Charles Kerr
1c3a5ba5d1
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43690 )
...
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-12 15:44:14 -05:00
Piotr Płaczek
29c2744e57
feat: hide menu bar on windows fullscreen ( #43402 )
...
* feat: hide menu bar on windows fullscreen
* test: state prior to html fullscreen transition
* refactor: restore `#ifdef` for readability
Reference: https://github.com/electron/electron/pull/43402#discussion_r1729356262
* docs: menu bar behavior changed
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-12 20:13:04 +02:00
Charles Kerr
3dd7e46291
refactor: avoid minor code repetition in native_image.cc ( #43689 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
2024-09-12 10:56:15 -05:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Shelley Vohr
3c8321a987
fix: EyeDropper working in devtools ( #43685 )
2024-09-12 15:40:56 +02:00
Shelley Vohr
74b54278bf
fix: native View wrapper crash missing when adding child view ( #43638 )
...
fix: native View wrapper crash missing when adding child view
2024-09-12 10:01:05 +02:00
Shelley Vohr
dea6a4e5fb
fix: ensure SetPluginCanSave updated in PDFs ( #43667 )
...
fix: ensure SetPluginCanSave updated in PDFs
2024-09-11 09:25:05 -04:00
Shelley Vohr
90fbf30491
build: compile Node.js with C++20 support ( #43555 )
...
* build: compile with C++20 support
* build: update build-image-sha for gcc 10
2024-09-11 09:01:46 -04:00
dependabot[bot]
5580349c3a
build(deps-dev): bump webpack from 5.76.0 to 5.94.0 in the npm_and_yarn group across 1 directory ( #43659 )
...
build(deps-dev): bump webpack
Bumps the npm_and_yarn group with 1 update in the / directory: [webpack](https://github.com/webpack/webpack ).
Updates `webpack` from 5.76.0 to 5.94.0
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.0...v5.94.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 09:56:03 +02:00
Keeley Hammond
309d5dade3
feat: add support for system picker in setDisplayMediaRequestHandler ( #43581 )
...
* tmp
* feat: add support for system picker in setDisplayMediaRequestHandler
* oops
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* stuff
* well...
* seems legit
* chore: update patch to handle screenCapturer
* feat: modify API to use useSystemPicker
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
* fix: don't use native picker with legacy media selection
* chore: code review, boolean set & docs update
* fix: add cancelCallback
* docs: clarify session & desktopCapturer docs
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-09-10 16:05:57 -07:00
Charles Kerr
a3df950281
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() ( #43642 )
2024-09-10 15:05:05 -05:00
Milan Burda
0cc60500ed
fix: restore Chromium default Content-Disposition header parsing ( #43611 )
...
* fix: restore Chromium default Content-Disposition header parsing
* Update api-web-request-spec.ts
2024-09-10 15:32:30 +02:00
Charles Kerr
f1019c2c4a
fix: -Wunsafe-buffer-usage warnings in asar file IO ( #43624 )
...
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()
* fix: -Wunsafe-buffer-usage warnings in Archive::Init()
2024-09-09 16:34:42 -04:00
Charles Kerr
5718ea4e1e
fix: out-of-scope Local handle in node::CallbackScope ( #43622 )
...
refactor: use an EscapableHandleScope
2024-09-09 12:14:40 -05:00
Charles Kerr
2844e346b9
refactor: use std::optional in MicrotasksScope ( #43621 )
...
avoid an unnecessary heap allocation/free
2024-09-09 12:51:42 -04:00
Zorro Liu
e2fe8f50e2
fix: update BrowserView#lastWindowSize after window resize ( #43463 )
...
fix: update BrowserView#lastWindowSize after window resize (#43462 )
2024-09-09 14:22:30 +02:00
Charles Kerr
8c5e7bbf6b
fix: UvHandle move semantics ( #43615 )
...
reassign the uv_handle_t of the source
2024-09-09 14:13:39 +02:00
dependabot[bot]
0d4d752c1b
build(deps): bump the npm_and_yarn group across 2 directories with 3 updates ( #43511 )
...
* build(deps): bump the npm_and_yarn group across 2 directories with 3 updates
Bumps the npm_and_yarn group with 1 update in the / directory: [braces](https://github.com/micromatch/braces ).
Bumps the npm_and_yarn group with 3 updates in the /spec directory: [braces](https://github.com/micromatch/braces ), [pdfjs-dist](https://github.com/mozilla/pdf.js ) and [ws](https://github.com/websockets/ws ).
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `pdfjs-dist` from 2.16.105 to 4.2.67
- [Release notes](https://github.com/mozilla/pdf.js/releases )
- [Commits](https://github.com/mozilla/pdf.js/compare/v2.16.105...v4.2.67 )
Updates `ws` from 7.5.9 to 7.5.10
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.5.9...7.5.10 )
---
updated-dependencies:
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: pdfjs-dist
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: ws
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: update api-web-contents-spec to us newer version of pdfjs-dist
* test: create fixture to read PDF files for verification
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-09 11:49:43 +02:00
Charles Kerr
0568686340
perf: avoid redundant Promise.GetContext calls ( #43609 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
2024-09-07 23:39:42 -05:00
Charles Kerr
44a4328ea8
refactor: take a uint8_t span in ValidateIntegrityOrDie() ( #43592 )
...
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
2024-09-06 20:22:44 -05:00
Charles Kerr
18b1b33adc
refactor: NativeWindow::Create() returns a unique_ptr ( #43576 )
...
refactor: NativeWindow::Create() returns a unique_ptr
2024-09-06 12:59:32 -04:00
Charles Kerr
fe0d4274e2
fix: confirm a v8::Value is a v8::Object before casting it ( #43575 )
...
fix: confirm a v8::Value is a v8::Object before casting it
2024-09-06 11:20:04 -05:00
Charles Kerr
cc5aa65cb4
fix: delete UvTaskRunner's timers only after they're closed ( #43561 )
...
* fix: free UvTaskRunner timers only after they are closed
* refactor: UvTaskRunner now holds UvHandles
2024-09-06 07:16:56 -05:00
Shelley Vohr
25f4691e78
fix: ensure version of xdg-dialog-portal with defaultPath support ( #43570 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
Closes https://github.com/electron/electron/issues/43310
2024-09-06 11:12:16 +02:00
Charles Kerr
3fde574db1
fix: -Wunsafe-buffer-usage warnings in url-loader ( #43564 )
...
Use v8::ArrayBufferView::CopyContents() instead of doing the pointer
math + memcpy() ourselves. This not only solves the buffer warnings,
but may also avoid some additional overhead:
> Copy the contents of the ArrayBufferView's buffer to an
> embedder defined memory without additional overhead that
> calling ArrayBufferView::Buffer might incur.
2024-09-05 20:22:03 -05:00
Shelley Vohr
eff862b083
build: use proper targets for building ( #43550 )
2024-09-05 17:03:07 -04:00
Kilian Valkhof
32d5f9e3ef
docs: explain ipcRenderer behavior in context-bridge.md ( #43455 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev >
* Update context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Erik Moura <erikian@erikian.dev >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-09-05 16:48:22 -04:00
Orko Garai
69df09dc90
fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland ( #43480 )
...
* fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland
Ensure apps are launched with the activation token received from
xdg_activation_v1 protocol.
* add focus_launched_process option
2024-09-05 13:07:10 -05:00
dependabot[bot]
6aae1264dd
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43530 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 11:26:17 -05:00
dependabot[bot]
4b5a831979
build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 ( #43528 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.6 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](834a144ee9...50769540e7 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 12:04:52 +02:00
David Sanders
2c3840af76
ci: remove blocked/need-info label on user comment ( #43562 )
2024-09-05 10:12:02 +02:00
John Kleinschmidt
73d480d401
build: fix telemetry error when using autoninja ( #43563 )
2024-09-05 10:08:27 +02:00
Charles Kerr
2d868ecb8d
perf: use v8::Local<v8::Object> as the key in ObjectCache ( #43519 )
...
* perf: use v8::Object* as direct keys instead of using hash + a linked list
* refactor: use v8::Local<v8::Object> as the key
2024-09-04 22:53:06 -05:00
Charles Kerr
0467790aee
chore: migrate to v8::Object::SetPrototypeV2() ( #43535 )
...
chore: migrate to v8::Object::SetPrototypeV2().
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5600627
[api] Mark v8::Object::GetPrototype() for deprecation
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 20:30:54 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final ( #43527 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-04 18:40:02 -05:00
Keeley Hammond
94f2722fa3
build: don't run symbol generation on PS ( #43554 )
...
fix: don't run symbol generation on PS
2024-09-04 17:18:57 +01:00
Charles Kerr
054cbcd6eb
fix: don't use deprecate-soon class v8::String::Value ( #43518 )
...
* fix: remove use of deprecated v8::String::Value
Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.
The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().
Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk
v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)
History on why we used it:
80c1a9739d
f49ed30f72
* Update shell/common/gin_converters/file_path_converter.h
Co-authored-by: Robo <hop2deep@gmail.com >
* fixup! Update shell/common/gin_converters/file_path_converter.h
do not return success for all non-Null non-Strings
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2024-09-04 08:56:14 -05:00
dependabot[bot]
4c83016cf3
build(deps): bump github/codeql-action from 3.26.3 to 3.26.6 ( #43529 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.3 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](883d8588e5...4dd16135b6 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-04 09:35:09 -04:00
Orko Garai
53dcda1fe9
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app ( #43481 )
...
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
2024-09-04 12:54:00 +02:00
George Xu
635d421123
fix: systemMediaPermissionDenied should not check camera perms when the request is asking for screen share ( #43517 )
...
* fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera
* Revert "fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera"
This reverts commit e9cc672165 .
* should only do these checks for audio or video, but not screenshare
* no service
* oops
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 09:56:26 +01:00
Charles Kerr
b42c0ae00d
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() ( #43477 )
...
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()
* chore: improve code comments for CheckCommandLineArguments()
* chore: reduce diffs from main
* refactor: CheckCommandLineArguments takes a StringVector arg
Fixes another buffer warning!
2024-09-03 21:51:39 -04:00
John Kleinschmidt
90ba2df4fa
build: free up macos disk space as soon as possible ( #43533 )
...
* chore: free up macos disk space as soon as possible
* build: free up disk space on gn check too
2024-09-03 21:32:05 -04:00
John Kleinschmidt
c41a28d7c8
chore: speed up cache only reclient for fork PRs ( #43497 )
2024-08-29 13:51:06 -04:00
Robo
41b8fdca5c
fix: devtools dock state with WCO on linux ( #43490 )
2024-08-29 09:17:00 +09:00
electron-roller[bot]
38512efd25
chore: bump node to v20.17.0 (main) ( #43428 )
...
* chore: bump node in DEPS to v20.17.0
* module: disallow CJS <-> ESM edges in a cycle from require(esm)
https://github.com/nodejs/node/pull/52264
* src: expose LookupAndCompile with parameters
https://github.com/nodejs/node/pull/53886
* src: fix -Wshadow warning
https://github.com/nodejs/node/pull/53885
* lib: convert WeakMaps in cjs loader with symbol properties
https://github.com/nodejs/node/pull/52095
* src: reduce unnecessary serialization of CLI options in C++
https://github.com/nodejs/node/pull/52451
* build: ensure v8_pointer_compression_sandbox is enabled on 64bit
https://github.com/nodejs/node/pull/53884
* lib: improve error message when index not found on cjs
https://github.com/nodejs/node/pull/53859
* src,lib: expose getCategoryEnabledBuffer to use on node.http
https://github.com/nodejs/node/pull/53602
* deps: update c-ares to v1.32.2
https://github.com/nodejs/node/pull/53865
* chore: fixup patch indices
* deps: update V8 to 12.2
https://github.com/nodejs/node/pull/51362
* stream: Expose DuplexPair API
https://github.com/nodejs/node/pull/34111
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-26 15:09:33 -04:00
Charles Kerr
7cea992926
refactor: simplify KeyWeakMap impl ( #43461 )
2024-08-26 13:19:05 -05:00
Charles Kerr
2390706030
refactor: prefer std::ranges over begin() and end() ( #43464 )
2024-08-26 10:58:32 -04:00
David Sanders
56829f75c1
chore: cleanup include groupings ( #43478 )
2024-08-26 10:44:20 -04:00
Charles Kerr
5994b34a5d
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha ( #43448 )
...
added in Aug 2021 (41646d11 , #29600 ) but never used
2024-08-23 20:59:41 -05:00
electron-appveyor-updater[bot]
e6555ac5e1
build: update appveyor image to latest version ( #43451 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-23 18:36:32 -04:00
Charles Kerr
5a1eeea102
perf: prefer GURL string_view getters ( #43443 )
...
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()
* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()
* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()
* refactor: add std::less<> to HandlersMap
This lets us search it using string_view keys
* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view
* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()
* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view
* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
2024-08-23 17:15:45 -05:00
Charles Kerr
7f34b0e6f5
chore: remove unused method asar::ClearArchives() ( #43442 )
...
chore: remove unused asar::ClearArchives()
last use removed in Jun 2021 (b1d1ac65 , #29293 )
2024-08-23 14:53:01 -05:00
John Kleinschmidt
c1eee18e41
test: add -pdf-ready-to-print event to WebContents for testing ( #43436 )
2024-08-23 12:34:26 -05:00
Charles Kerr
9ce0ca74c3
build: remove fix_disable_scope_reuse_associated_dchecks.patch ( #43441 )
...
chore: remove fix_disable_scope_reuse_associated_dchecks.patch
2024-08-23 11:04:20 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43430 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
2024-08-23 11:02:43 -04:00
Shelley Vohr
6e4d90fcdb
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43431 )
...
* fix: ensure bounds stability in OnWidgetBoundsChanged
* Update shell/browser/native_window_views.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-23 11:02:05 -04:00
Erick Zhao
fd8d9f06fd
chore: mention signed commit requirement ( #43406 )
...
chore: mentioned signed commit requirement
2024-08-23 15:52:33 +02:00
Alexander Cyon
ca0837c852
chore: fix typos in 'shell/' folder. ( #43373 )
2024-08-22 19:48:32 -05:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering ( #42953 )
...
* feat: GPU shared texture offscreen rendering
* docs: clarify texture infos that passed by the paint event.
* feat: make gpu osr spec test optional
* fix: osr image compare
* fix: remove duplicate test
* fix: update patch file
* fix: code review
* feat: expose more metadata
* feat: use better switch design
* feat: add warning when user forget to release the texture.
* fix: typo
* chore: update patch
* fix: update patch
* fix: update patch description
* fix: update docs
* fix: apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: apply suggested fixes
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-22 19:23:13 -05:00
electron-roller[bot]
b481966f02
chore: bump chromium to 130.0.6672.0 (main) ( #43445 )
...
chore: bump chromium in DEPS to 130.0.6672.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-22 18:27:25 -05:00
electron-roller[bot]
baf0182a42
chore: bump chromium to 130.0.6671.0 (main) ( #43429 )
...
* chore: bump chromium in DEPS to 130.0.6671.0
* 5802591: [Partitioned Popins] (6) Add permissions policy for popin
https://chromium-review.googlesource.com/c/chromium/src/+/5802591
* 5794132: [video pip] Move back to tab button to the header
https://chromium-review.googlesource.com/c/chromium/src/+/5794132
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-22 13:16:40 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Shelley Vohr
7391db93e2
build: roll sysroots ( #43261 )
2024-08-22 16:22:12 +02:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors ( #43366 )
...
chore: fix typos in 'docs/' folder.
2024-08-22 15:44:55 +02:00
Alexander Cyon
ae0c8881c3
chore: fix typos in 'spec/' folder (and one in 'lib/' folder) ( #43374 )
2024-08-22 15:44:15 +02:00
Shelley Vohr
4ae43dcb3b
fix: touch bar functionality on BaseWindow ( #43353 )
...
* fix: touch bar functionality on BaseWindow
* test: add test for BaseWindow.setTouchBar
2024-08-22 12:48:25 +02:00
electron-appveyor-updater[bot]
46bed807ca
build: update appveyor image to latest version ( #43369 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-22 10:12:57 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification ( #43377 )
...
* docs: clarify icon value in Notification
* Update docs/api/notification.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-08-21 19:38:06 -05:00
Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace ( #43372 )
2024-08-21 15:26:06 -05:00
electron-roller[bot]
f366caac84
chore: bump chromium to 130.0.6669.0 (main) ( #43397 )
...
* chore: bump chromium in DEPS to 130.0.6669.0
* 5789734: Consolidate all the accessibility scale factor utility code into one file
https://chromium-review.googlesource.com/c/chromium/src/+/5789734
* 5798543: [autofill] Don't emit autofill audit reports if inspector not connected
https://chromium-review.googlesource.com/c/chromium/src/+/5798543
* 5797073: [wasm] Spill all loop inputs before entering loop
https://chromium-review.googlesource.com/c/v8/v8/+/5797073
* chore: fixup patch indices
* 5795224: Version 13.0.0
https://chromium-review.googlesource.com/c/v8/v8/+/5795224
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-21 12:34:18 -04:00
David Sanders
4874233aae
chore: set wg-infra as CODEOWNER for GHA build configs ( #43223 )
...
* chore: set wg-releases as CODEOWNER for GHA build configs
* chore: change to wg-infra
2024-08-21 10:49:22 +02:00
David Sanders
b7af0537c8
docs: update timelines for E33 ( #43389 )
2024-08-20 15:47:32 -07:00
Keeley Hammond
7da9c0b2f7
docs: update window customization tutorial ( #43388 )
2024-08-20 15:29:01 -07:00
Shelley Vohr
46af43db49
chore: cherry-pick 9797576 from v8 ( #43376 )
2024-08-20 16:49:02 -04:00
Charles Kerr
93a6f3e607
refactor: NodeBindings::Create() returns a unique_ptr ( #43361 )
...
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
2024-08-20 15:34:59 -04:00
Charles Kerr
a2de94dda1
chore: remove unused ConvertableToTraceFormatWrapper ( #43356 )
...
* chore: remove unused ConvertableToTraceFormatWrapper
Last use removed in Apr 2024 (39bf441b , #41880 )
* fixup! chore: remove unused ConvertableToTraceFormatWrapper
remove now-unused trace_event.h header, too
2024-08-20 15:21:43 -04:00
electron-roller[bot]
2cc14c6e8f
chore: bump chromium to 129.0.6668.0 (main) ( #43368 )
...
* chore: bump chromium in DEPS to 129.0.6668.0
* 5787687: [Extensions] Remove EventRouterForwarder from BrowserProcess
https://chromium-review.googlesource.com/c/chromium/src/+/5787687
* 5788808: Resolve Blob URL's origin using info from browser process
https://chromium-review.googlesource.com/c/chromium/src/+/5788808
* chore: fixup patch indices
* 5786747: Remove "int WriteFile"
https://chromium-review.googlesource.com/c/chromium/src/+/5786747
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-20 16:54:27 +02:00
dependabot[bot]
945aabfaee
build(deps): bump github/codeql-action from 3.26.0 to 3.26.3 ( #43365 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.0 to 3.26.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](eb055d739a...883d8588e5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-20 13:11:50 +02:00
Charles Kerr
3186c2f0ef
refactor: remove unused SetWMSpecState ( #43347 )
...
last use removed in Aug 2022 by 53cd2315 #35179
2024-08-19 17:15:19 -04:00
Charles Kerr
44e4e4521c
chore: remove unused method Erase() ( #43348 )
...
Last use removed in Mar 2018 by 4b39d17e
2024-08-19 17:14:57 -04:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
electron-roller[bot]
4c3014944c
chore: bump chromium to 129.0.6664.0 (main) ( #43329 )
...
* chore: bump chromium in DEPS to 129.0.6657.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6658.0
* chore: update patches
* 5743786: [ServiceWorker] Populate service worker start token to WorkerId.
https://chromium-review.googlesource.com/c/chromium/src/+/5743786
* 5784424: [Extensions] Move ownership of Dispatcher to ExtensionsRendererClient
https://chromium-review.googlesource.com/c/chromium/src/+/5784424
* chore: bump chromium in DEPS to 129.0.6659.0
* chore: bump chromium in DEPS to 129.0.6660.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6662.0
* chore: bump chromium in DEPS to 129.0.6664.0
* 5789627: [Partitioned Popins] (3) `popin` feature triggers third-party storage partitioning
https://chromium-review.googlesource.com/c/chromium/src/+/5789627
* 5791367: Remove some chrome:: namespace from chrome/browser/app_mode/*
https://chromium-review.googlesource.com/c/chromium/src/+/5791367
* 5791522: [SCK] Skip redundant getShareableContentWithCompletionHandler
https://chromium-review.googlesource.com/c/chromium/src/+/5791522
* 5761330: Send refresh rate prefs b/w RefreshRateController and DisplayPrivate
https://chromium-review.googlesource.com/c/chromium/src/+/5761330
* chore: fixup patch indices
* 5793591: Remove unused GetHeader overload
https://chromium-review.googlesource.com/c/chromium/src/+/5793591
* 5787624: [Extensions] Simplify ExtensionsRendererClient::RenderThreadStarted()
https://chromium-review.googlesource.com/c/chromium/src/+/5787624
* 5721709: Fix Incorrect last_accessed_time Tracking for Tabs
https://chromium-review.googlesource.com/c/chromium/src/+/5721709
* 5789215: [Extensions] Add a //chrome/common/extensions build target
https://chromium-review.googlesource.com/c/chromium/src/+/5789215
* Roll V8 from 48f669a0758c to eee3eb91d01c
48f669a075..eee3eb91d0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-19 14:52:53 -04:00
Shelley Vohr
cc16de7032
fix: printing occasionally showing failed when cancelled ( #43337 )
...
Closes https://github.com/electron/electron/issues/36084
2024-08-19 14:25:14 -04:00
Piotr Płaczek
4d51edc504
docs: api history ( #42982 )
...
* feat(api-history): api history schema
Reference: f36e0a8483/text/0004-api-history-schema.md
* feat(api-history): add `lint:api-history` to `package.json`
* docs(api-history): add api history to `styleguide.md`
* docs(api-history): `win.flashFrame(flag)`
* docs(api-history): `new WebContentsView([options])`
* docs(api-history): non-navigation APIs on `WebContents`
* docs(api-history): `nativeImage.toDataURL`
* docs(api-history): `window.flashFrame(bool)`
* docs(api-history): `browser-view.md`
* docs(api-history): `ipcRenderer`
* docs(api-history): `protocol.*Protocol`
* revert: `new WebContentsView([options])`
This reverts commit 0a11efcf57 .
* Apply suggestions from code review
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix(api-history): remove incorrect `pr-url`
Reference: https://github.com/electron/electron/pull/42982/files#r1692532877
* docs(api-history): schema word choice
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Reference: 0b1b6a7cc0
* docs(api-history): nicer format example in `styleguide.md`
Reference: https://github.com/electron/electron/pull/42982#discussion_r1692539906
* docs(api-history): Always use double quotes for descriptions
* docs(api-history): `styleguide.md` improvements
* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`
* docs(api-history): `styleguide.md` placement
* docs(api-history): add migration guide
* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`
Reference: 7b03c0703d (r1703444772)
* docs(api-history): move migration guide
Reference: https://github.com/electron/electron/pull/42982#discussion_r1703441001
* docs(api-history): update `breaking-changer-header`
Reference: https://github.com/electron/electron/pull/43217
* docs(api-history): deprecate `browser-view.md`
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-08-19 11:17:10 -07:00
Calvin
8474bbe689
build: update NMV to 130 for Electron 33 ( #43325 )
2024-08-19 12:47:40 -04:00
Shelley Vohr
3f71ed7355
build: fix valid versions in issue version parsing ( #43346 )
2024-08-19 11:04:30 +02:00
Shelley Vohr
d7689bb9b5
docs: expand dialog window to BaseWindow ( #43334 )
...
docs: expand dialog window to BaseWindow
2024-08-16 10:49:10 -04:00
Shelley Vohr
b497700e36
test: fixup Node.js snapshot tests to run correctly ( #43332 )
2024-08-16 11:17:42 +02:00
electron-appveyor-updater[bot]
1c991ff765
build: update appveyor image to latest version ( #43331 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-15 16:09:47 -04:00
Shelley Vohr
4801a54d08
refactor: migrate deprecated platform_util_mac calls ( #43161 )
...
refactor: migrate deprecated platform_util_mac calls
2024-08-15 10:53:38 -04:00
electron-roller[bot]
a7c52f1fb2
chore: bump chromium to 129.0.6656.0 (main) ( #43323 )
...
* chore: bump chromium in DEPS to 129.0.6656.0
* chore: update patches
* 5750664: Introduce Signin.NumberOfActiveAccounts.* metrics
https://chromium-review.googlesource.com/c/chromium/src/+/5750664
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-14 16:47:37 -04:00
Shelley Vohr
286384258b
fix: blank page when printing pdf ( #43309 )
2024-08-14 15:47:47 -04:00
Shelley Vohr
f6bae51025
build: remove upstreamed DraggableRegions patch ( #43311 )
...
build: remove upstreamed patch
2024-08-14 10:11:02 -04:00
electron-appveyor-updater[bot]
ffcbc32031
build: update appveyor image to latest version ( #43318 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-14 10:10:33 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
David Sanders
62406708cd
docs: fix formatting in fuses tutorial ( #43303 )
2024-08-13 15:27:44 -04:00
electron-roller[bot]
d004329f6f
chore: bump chromium to 129.0.6654.0 (main) ( #43312 )
...
* chore: bump chromium in DEPS to 129.0.6654.0
* chore: update patches
* 5766075: Chromium UI for integration with the MacOS SCContentSharingPicker
https://chromium-review.googlesource.com/c/chromium/src/+/5766075
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-13 15:04:43 -04:00
electron-appveyor-updater[bot]
275b6a13b7
build: update appveyor image to latest version ( #43308 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-13 11:25:05 -04:00
dependabot[bot]
a9e56f2c36
build(deps): bump dsanders11/github-app-commit-action from 1.4.0 to 1.5.0 ( #43305 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](48d2ff8c1a...43de6da2f4 )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-13 15:13:55 +02:00
electron-roller[bot]
bc2628ad7e
chore: bump chromium to 129.0.6652.0 (main) ( #43298 )
...
* chore: bump chromium in DEPS to 129.0.6652.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-12 13:47:27 -04:00
Charles Kerr
bba31189a0
feat: accept-encoding zstd ( #43150 )
...
* fix: accept-encoding zstd
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
* chore: make lint happy
---------
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-08-12 10:00:04 -04:00
electron-appveyor-updater[bot]
0f55b45282
build: update appveyor image to latest version ( #43268 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-12 09:32:52 -04:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
electron-roller[bot]
c9b7806418
chore: bump chromium to 129.0.6650.0 (main) ( #43266 )
...
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b6 ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-12 10:28:33 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d3 .
2024-08-12 09:56:51 +02:00
Charles Kerr
bff298987f
chore: remove unused Notification fields icon_path_, has_icon_ ( #43286 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584 )
Last use of `has_icon_` was removed on May 30, 2017 (5048425e )
2024-08-12 09:55:54 +02:00
Shelley Vohr
6d13c503c5
refactor: update chrome.scripting extensions api impls ( #43205 )
2024-08-11 21:31:37 +02:00
Charles Kerr
7721fdf886
chore: remove unused method ElectronDesktopWindowTreeHostLinux::UpdateClientDecorationHints() ( #43283 )
...
Xref: dff980c9c2
Removed in #41868
2024-08-10 18:55:10 -05:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Charles Kerr
c4dfff9844
fix: accidental handle copying in a range loop ( #43260 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
2024-08-09 13:38:03 -05:00
Shelley Vohr
346244ef9e
build: add nacl back to buildtools gitignore ( #43238 )
2024-08-09 19:09:01 +02:00
dependabot[bot]
4edc7a4372
build(deps): bump actions/upload-artifact from 4.3.4 to 4.3.6 ( #43245 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.4 to 4.3.6.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](0b2256b8c0...834a144ee9 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-09 10:43:51 +02:00
Shelley Vohr
f49f6ff68b
fix: check screen capture permissions in desktopCapturer ( #43080 )
...
fix: check screen capture permissions in desktopCapturer
2024-08-09 10:08:49 +02:00
Shelley Vohr
0718c2b9ee
fix: system-context-menu with frameless BrowserWindows ( #43243 )
2024-08-09 10:08:01 +02:00
electron-roller[bot]
1a6563fb66
chore: bump chromium to 129.0.6644.0 (main) ( #43224 )
...
* chore: bump chromium in DEPS to 129.0.6640.0
* chore: update patches
* Reland "DEPS: update ninja to 1.12.1"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5645474
* chore: bump chromium in DEPS to 129.0.6642.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6644.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-08 17:16:59 -05:00
electron-appveyor-updater[bot]
11fdc6f78e
build: update appveyor image to latest version ( #43237 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-08 16:10:16 +02:00
dependabot[bot]
0fcc18359f
build(deps): bump github/codeql-action from 3.25.15 to 3.26.0 ( #43246 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.15 to 3.26.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](afb54ba388...eb055d739a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-08 16:09:14 +02:00
Shelley Vohr
70dda694e2
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43206 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
2024-08-07 14:51:38 +02:00
David Sanders
aa19087bed
ci: set labels on Dependabot PRs for GitHub Actions deps ( #43222 )
2024-08-07 11:57:40 +02:00
Felix Rieseberg
3fabf7837e
docs: Document ideal iconPath size ( #43149 )
2024-08-07 11:43:05 +02:00
dependabot[bot]
8d5ad8afe1
build(deps): bump mikefarah/yq from 4.44.2 to 4.44.3 ( #43220 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.2 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](f15500b20a...bbdd97482f )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-07 10:02:31 +02:00
Shelley Vohr
45891aa75b
build: fix patchup logic only running on one platform ( #43139 )
2024-08-07 10:01:59 +02:00
Charles Kerr
6293bbced0
perf: avoid redundant calls to GetView() ( #43216 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
Piotr Płaczek
f42331f277
docs: add missing deprecations to breaking-changes.md ( #43217 )
...
* docs: deprecate `BrowserView`
Reference: https://github.com/electron/electron/pull/35658
* docs: deprecate `webContents.goToIndex(index)`
Reference: https://github.com/electron/electron/pull/41752/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6R1165-R1167
* docs: deprecate some protocol methods
Reference: https://github.com/electron/electron/pull/36674/files#diff-74861ecada868821b139e79f244ea32b840a93f60de572d585117a0ff8d165c8R380
2024-08-06 09:07:36 -07:00
electron-roller[bot]
29fd2d343b
chore: bump chromium to 129.0.6638.0 (main) ( #43207 )
...
* chore: bump chromium in DEPS to 129.0.6638.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-06 17:43:48 +09:00
electron-appveyor-updater[bot]
c70f86fe03
build: update appveyor image to latest version ( #43204 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-05 16:41:40 -04:00
Samuel Attard
701a09d44f
build: use smaller instances for gn-check ( #43187 )
2024-08-05 15:42:41 -04:00
John Kleinschmidt
a4dcb0fb32
build: fixup patches in main ( #43218 )
...
chore: fixup patches in main
2024-08-05 13:51:17 -04:00
David Sanders
acd39bd077
ci: auto label bug issues with platform ( #43198 )
2024-08-05 09:52:49 -04:00
Charles Kerr
3d766e9ccb
perf: don't build unused vectors in HidChooserContext ( #43192 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
* refactor: use structured bindings for readability
2024-08-05 15:31:58 +02:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
Shelley Vohr
e64302cc91
refactor: simplify window moveAbove/moveTop impl on macOS ( #43157 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
2024-08-05 09:57:16 +02:00
Shelley Vohr
2a613cabaa
refactor: migrate electron_login_helper to non-deprecated API ( #43182 )
...
refactor: migrate electron_login_helper to non-deprecated API
2024-08-05 09:56:18 +02:00
Shelley Vohr
78995b956e
fix: potential draggable regions crash in DevTools ( #43179 )
2024-08-05 09:56:08 +02:00
electron-roller[bot]
f508f6b6b5
chore: bump chromium to 129.0.6636.0 (main) ( #43194 )
...
* chore: bump chromium in DEPS to 129.0.6636.0
* chore: e patches all
to make GH actions happy
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 11:36:40 -05:00
electron-roller[bot]
20e77afe0f
chore: bump chromium to 129.0.6634.0 (main) ( #43189 )
...
* chore: bump chromium in DEPS to 129.0.6634.0
* chore: update chore_add_electron_deps_to_gitignores.patch
no manual changes. patch applied with fuzz 1.
* chore: e patches all
* chore: update call to gfx::Image::CreateFrom1xPNGBytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597
The call now takes a base::span
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 07:31:31 -05:00
Charles Kerr
5a809a6694
refactor: prefer std::ranges over base::ranges ( #43172 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5668999
Xref: https://groups.google.com/a/chromium.org/g/cxx/c/ZnIbkfJ0Glw
2024-08-02 21:21:59 -05:00
Charles Kerr
305b28e9c7
chore: bump chromium to 129.0.6632.0 ( #43184 )
...
* chore: bump chromium in DEPS to 129.0.6632.0
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5755242
* chore: e patches all
2024-08-02 13:58:13 -05:00
Charles Kerr
5b18cc46bc
chore: bump chromium to 129.0.6630.0 (main) ( #43087 )
...
* chore: bump chromium in DEPS to 129.0.6623.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654
* chore: update fix_disable_scope_reuse_associated_dchecks.patch
We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076
* chore: e patches all
* Bump the Chrome macOS deployment target to 11.0
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361
BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0
* src: stop using deprecated fields of `v8::FastApiCallbackOptions`
Xref: d0000b118d
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741336
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199
* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch
chore: re-disable DCHECKs
yep, it is still needed
* refactor use non-deprecated variant of openApplicationAtURL
old version is deprecated now in macOS 11
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl
* chore: bump chromium in DEPS to 129.0.6626.0
* chore: e patches all
* chore: disable NSUserNotification deprecation errors
* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors
Xref: https://github.com/electron/electron/issues/43125
* chore: disable deprecation errors in platform_util_mac.mm
* chore: disable launchApplication deprecation errors
* chore: bump chromium in DEPS to 129.0.6630.0
* chore: update refactor_expose_file_system_access_blocklist.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444
* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch
no manual changes. patch applied with fuzz 1 (offset -5 lines)
* chore: e patches all
* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 09:02:11 -05:00
Tingsong (Terrence) Ou
7c79221a54
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc ( #43129 )
...
fixed electron-fiddle build and config links
2024-08-01 20:28:50 -05:00
Charles Kerr
e7ca92a574
chore: remove unused internal env.unSetVar() ( #43148 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260 , #25623 ) but never used
2024-08-01 18:41:41 -05:00
Shelley Vohr
3a07bd8821
fix: take bluetooth serial ports into account in serial.getPorts() ( #43101 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
* chore: remove port.path.LossyDisplayName()
2024-08-01 11:13:31 -05:00
dependabot[bot]
cc956420ef
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 ( #43094 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7ed )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:47:56 +02:00
cptpcrd
2337d8676d
fix: handle failing to enter fullscreen on macOS ( #43112 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
2024-08-01 12:13:13 +02:00
Charles Kerr
45e5ccc55e
chore: remove unused KeyWeakMap JS bindings ( #43111 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8 #25711 )
- Jun 2020 (e1e73fa5 #24115 )
- Jun 2020 (c0182bca #24116 ).
2024-07-31 16:37:04 -05:00
Charles Kerr
a68a33f036
docs: fix broken link in bug report template ( #43105 )
...
chore: fix broken link in bug report template
2024-07-31 11:45:07 -04:00
Shelley Vohr
791e6df82a
docs: update Node.js stable release policy ( #43100 )
...
* docs: update Node.js stable release policy
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-31 16:33:58 +02:00
dependabot[bot]
283810dbfc
build(deps): bump github/codeql-action from 3.25.13 to 3.25.15 ( #43095 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.13 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](2d790406f5...afb54ba388 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-31 10:00:39 +02:00
Shelley Vohr
ed3242adc1
fix: vibrant view is inserted into Views API hierarchy ( #43078 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-30 18:21:20 -05:00
John Kleinschmidt
87fb2ad70c
build: fixup ffmpeg release on x64 macOS ( #43093 )
...
chore: fixup arch on x64 macOS ffmpeg
2024-07-30 16:35:11 -04:00
Charles Kerr
1bcc566ad8
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43090 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a (#26659 )
2024-07-30 15:25:37 -05:00
electron-appveyor-updater[bot]
60bb4a2617
build: update appveyor image to latest version ( #43098 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-30 11:44:18 -04:00
Charles Kerr
47dde3b6e2
chore: remove unused class electron::ObjectLifeMonitor ( #43089 )
...
* chore: remove unused electron::ObjectLifeMonitor
The last users were removed in June 2020 e1e73fa5f (#24115 )
and May 2020 9d7ba982 (#23592 ).
* fixup! chore: remove unused electron::ObjectLifeMonitor
fix: oops
2024-07-30 08:25:28 -05:00
John Kleinschmidt
1a6e651844
test: fixup flaky visibility test ( #43064 )
2024-07-30 09:14:45 -04:00
Shelley Vohr
d09a2e513c
fix: showInactive window not showing ( #43079 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
2024-07-30 12:37:27 +02:00
Charles Kerr
7e9eb9e3f1
perf: avoid duplicate calculations in gin_helper::Dictionary getters ( #43073 )
...
* perf: cache the dictionary handle
* refactor: prefer result.IsJust() over !result.IsNothing()
for consistency
* refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust()
the inlined code is simpler
* refactor: simplify Get() impl
* refactor: add private helper Dictionary::MakeKey()
refactor: add private helper Dictionary::MakeHiddenKey()
2024-07-29 12:43:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
electron-roller[bot]
92496c1930
chore: bump chromium to 129.0.6616.0 (main) ( #43012 )
...
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076
* chore: export patches
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | https://chromium-review.googlesource.com/c/chromium/src/+/5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | https://chromium-review.googlesource.com/c/chromium/src/+/5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | https://chromium-review.googlesource.com/c/chromium/src/+/5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | https://chromium-review.googlesource.com/c/chromium/src/+/5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | https://chromium-review.googlesource.com/c/chromium/src/+/5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-29 09:37:35 -04:00
Alice Zhao
4286234721
fix: redirect webview navigation methods ( #42981 )
2024-07-29 13:00:51 +02:00
Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
2024-07-27 12:25:43 -05:00
Keeley Hammond
8db1563d73
fix: remove InspectableWebContentsViewMac ( #43033 )
...
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93d .
* build: fix gn check
* chore: implement setCornerRadii in inspectable_web_contents_view_mac
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: pass in cornerRadii value in setCornerRadii
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: forward declaration
* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-27 11:44:22 -05:00
electron-roller[bot]
b3d52c01e8
chore: bump node to v20.16.0 (main) ( #43029 )
...
* chore: bump node in DEPS to v20.16.0
* test: skip unstable shadow realm gc tests
https://github.com/nodejs/node/pull/52855
* test: extend env for `test-node-output-errors`
https://github.com/nodejs/node/pull/53535
* src: fix typo in env.cc
https://github.com/nodejs/node/pull/53418
* src: reset `process.versions` during pre-execution
https://github.com/nodejs/node/pull/53444
* chore: fixup patch indices
* src,permission: --allow-wasi & prevent WASI exec
https://github.com/nodejs/node/pull/53124
* tls: use SSL_get_peer_tmp_key
https://github.com/nodejs/node/pull/53366
* deps: update c-ares to 1.29.0
https://github.com/nodejs/node/pull/53155
* src: account for OpenSSL unexpected version
* crypto: fix propagation of "memory limit exceeded"
https://github.com/nodejs/node/pull/53300
* process: add process.getBuiltinModule(id)
https://github.com/nodejs/node/pull/52762
* windows 32bit: config change callback needs to be stdcall
8f265c9d51
* fix: building with UNICODE
https://github.com/c-ares/c-ares/pull/802
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-07-26 12:52:05 -04:00
BILL SHEN
77ba40bc01
chore: avoid crash while notification removal ( #43040 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
* fix notification removal crash due to the nullptr presenter
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-07-26 15:34:40 +02:00
Keeley Hammond
2fd04a78a1
fix: revert BrowserWindow unresponsive handling refactor ( #43034 )
...
* Revert "refactor: JSify BrowserWindow unresponsive handling (#37902 )"
This reverts commit 67ba30402b .
* chore: remove BrowserWindow::SetTitleBarOverlay
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-25 13:02:02 -07:00
electron-appveyor-updater[bot]
0886d2f50f
build: update appveyor image to latest version ( #43021 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-25 15:21:02 -04:00
Charles Kerr
660872c048
refactor: move safe_storage functions into anonymous namespace ( #43032 )
2024-07-25 13:18:13 -05:00
Shelley Vohr
976f5d1b75
fix: File System API permissions should reset on WebContents destruction ( #43009 )
...
fix: active File System API permissions should reset on WebContents destruction
2024-07-25 09:53:30 -04:00
Charles Kerr
aa23198ad8
chore: remove more unused #include calls ( #43000 )
...
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b (##41610)
* chore: iwyu electron/fuses.h
* chore: iwyu media/base/video_frame.h
* chore: iwyu base/functional/callback.h
* chore: iwyu base/task/cancelable_task_tracker.h
* chore: iwyu shell/browser/draggable_region_provider.h
* chore: iwyu shell/browser/ui/inspectable_web_contents_view.h
* chore: iwyu ui/aura/window.h
* chore: iwyu ui/base/win/shell.h
* chore: iwyu ui/display/win/screen_win.h
* chore: iwyu ui/gfx/geometry/insets.h
* chore: iwyu ui/display/display.h
* chore: iwyu ui/gfx/geometry/skia_conversions.h
* chore: iwyu ui/gfx/geometry/rect_conversions.h
* chore: iwyu ui/gfx/geometry/point.h
* chore: iwyu ui/gfx/scoped_canvas.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu ui/accessibility/ax_node_data.h
* chore: iwyu ui/views/animation/ink_drop_highlight.h
* chore: iwyu ui/gfx/font_list.h
* chore: iwyu ui/linux/nav_button_provider.h
* chore: iwyu shell/browser/ui/views/frameless_view.h
* chore: iwyu services/metrics/public/cpp/ukm_source_id.h
* chore: iwyu net/http/http_util.h
* chore: iwyu net/base/mime_util.h
* chore: iwyu content/public/common/content_client.h
* chore: iwyu <list>
* chore: iwyu <optional>
* chore: iwyu <memory>
* chore: iwyu base/files/file_path.h
* chore: iwyu ui/base/cursor/cursor.h
* chore: iwyu build/build_config.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/hid/hid_chooser_context.h
* chore: iwyu shell/common/platform_util.h
* chore: iwyu base/task/single_thread_task_runner.h
* chore: iwyu content/browser/renderer_host/render_widget_host_impl.h
* chore: iwyu content/public/browser/render_widget_host.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu content/public/browser/web_contents_observer.h
* chore: iwyu content/public/browser/render_frame_host.h
* chore: iwyu content/public/browser/media_stream_request.h
* chore: iwyu chrome/common/chrome_paths.h
* chore: iwyu chrome/browser/icon_manager.h
* chore: iwyu printing/print_settings.h
* chore: iwyu renderer/pepper_helper.h
* chore: iwyu shell/browser/api/process_metric.h
* chore: iwyu shell/browser/electron_browser_client.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu shell/browser/api/electron_api_session.h
* chore: iwyu shell/browser/api/electron_api_app.h
* chore: iwyu shell/browser/ui/views/client_frame_view_linux.h
* chore: iwyu shell/browser/native_window_views.h
* chore: iwyu base/win/windows_version.h
* chore: iwyu shell/common/electron_paths.h
* chore: iwyu content/public/common/content_switches.h
* chore: iwyu third_party/skia/include/core/SkRRect.h
* chore: iwyu third_party/skia/include/core/SkBitmap.h
* chore: iwyu third_party/skia
* chore: iwyu shell/browser/osr/osr_host_display_client.h
* chore: iwyu shell/browser/login_handler.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu shell/browser/event_emitter_mixin.h
* fix: mac
* fix: mac
* chore: iwyu base/nix/xdg_util.h
* fix: win
* fix: win
* fix: win
* fix: win
2024-07-25 11:25:45 +02:00
Shelley Vohr
cfdcf48e1b
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43013 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
* test: oops fix showing
2024-07-25 11:17:37 +02:00
David Sanders
c2c079dc82
build: update docs-parser and typescript-definitions packages ( #43038 )
...
build: update docs-parser and typescript-definitions pacakges
2024-07-25 11:00:32 +02:00
David Sanders
f979d4c742
test: add test for nodeCliInspect fuse ( #43035 )
2024-07-25 11:00:02 +02:00
Charles Kerr
df524c6eca
chore: use v8::Local<>, not v8::Handle<> ( #43019 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
2024-07-24 18:24:07 -05:00
Shelley Vohr
5669a40d5c
feat: add transparency checking to nativeTheme ( #42862 )
...
* feat: add transparency checking to nativeTheme
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870
* chore: deprecate previous function
* chore: fix lint
2024-07-24 14:38:22 +02:00
Shelley Vohr
9fc760bc4c
docs: note macOS fullscreen events in fullscreen query ( #42997 )
...
docs: note macOS fullscreen events in fs query
2024-07-23 16:40:59 -04:00
electron-roller[bot]
3e22f992b0
chore: bump chromium to 128.0.6611.0 (main) ( #42779 )
...
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-23 08:59:44 -07:00
dependabot[bot]
364631ee0b
build(deps): bump github/codeql-action from 3.25.12 to 3.25.13 ( #42999 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.12 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4fa2a79536...2d790406f5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 12:38:02 +02:00
Shelley Vohr
3c9d4452c6
docs: improve desktop capture example ( #42957 )
2024-07-23 11:55:23 +02:00
dependabot[bot]
daa8244cdf
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42998 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.3...0b2256b8c012f0828dc542b3febcab082c67f72b )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 10:18:36 +02:00
Shelley Vohr
8454f4e49f
feat: emit an event when accessing restricted path in File System Access API ( #42561 )
...
* fix: show a dialog when accessing restricted path in File System Access API
* fix: allow overriding initial blocked paths
* docs: fix doc
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: change block to deny for consistency
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-22 12:18:15 +02:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
David Sanders
296a558c32
build: update @electron/lint-roller to 2.3.0 ( #42950 )
2024-07-22 10:45:49 +02:00
Charles Kerr
780677e00f
chore: remove unused BaseWindow::GetWeakPtr() ( #42973 )
...
last caller removed in 67ba3040 (#37902 )
2024-07-22 10:44:34 +02:00
Charles Kerr
8c8a7709e6
chore: remove unused WrappableBase::AfterInit() ( #42974 )
...
last caller removed in 6159066c (#22916 )
2024-07-22 10:44:21 +02:00
Charles Kerr
c72a714dd5
refactor: remove WindowListObserver::OnWindowAdded() ( #42979 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
2024-07-22 10:44:08 +02:00
Charles Kerr
7a101a1c4b
refactor: remove unused web contents preferences methods ( #42947 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c
* chore: remove unused WebContentsPreferences::GetSafeDialogsMessage()
caller removed in 85bc005c
* refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath>
* refactor: make WebContentsPreferences::last_preference() const
2024-07-19 12:26:57 -05:00
Charles Kerr
5b7ed6097e
chore: remove unused typedef CreateDownloadPathCallback ( #42949 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
2024-07-19 11:49:58 -05:00
Charles Kerr
32a74b0942
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42956 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
2024-07-19 11:48:52 -05:00
Charles Kerr
5773a2dce6
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42933 )
2024-07-17 23:30:09 -05:00
Charles Kerr
bc345db351
fix: dangling raw_ptr<views::View> in api::View ( #42929 )
2024-07-17 21:31:48 -05:00
David Sanders
ce45450c28
ci: refactor non-maintainer lockfile change check to request changes ( #42855 )
2024-07-17 12:28:08 -07:00
arno renevier
81bdba67ec
feat: Implement password delegate for NSS ( #41205 )
...
* feat: Implement password delegate for NSS (#41188 )
Introduce an app event client-certificate-request-password. It allows
the user to display a UI to prompt for the password.
An alternative would have been to implement a class similar to
CryptoModulePasswordDialogView, to provide the UI. This might have been
simpler for the user, comparing to letting them implement the UI. But it
seems like electron does not have an i18n framework, so it's not
possible to provide a locale aware UI.
* fix lint:markdown error
* address review comments
* use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler
* use properties on the Event object instead of positional parameters
* remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_)
* address review comments second round
- backslash escape parametrized TypeScript
- rename hostName param to hostname
- use base::ScopedAllowBaseSyncPrimitivesForTesting
- and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate
* Update docs/api/app.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/app.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Arno Renevier <arnaud@switchboard.app >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-17 09:48:03 -04:00
dependabot[bot]
c210ae9b33
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #42831 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:41 +02:00
dependabot[bot]
734ba50ee1
build(deps): bump amannn/action-semantic-pull-request from 5.5.2 to 5.5.3 ( #42834 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.2 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](cfb60706e1...0723387faa )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:33 +02:00
wujinli
9023707b9b
fix: crash with creating OffScreenWebContentsView ( #42920 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
2024-07-17 13:09:32 +02:00
dependabot[bot]
2875fab452
build(deps): bump actions/setup-node from 4.0.2 to 4.0.3 ( #42917 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...1e60f620b9 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 11:36:52 +02:00
Shelley Vohr
fd907bc0a3
fix: getUserMedia needs macOS system permissions check ( #42899 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
2024-07-17 11:30:05 +02:00
Sam Maddock
c7709747d0
ci: upload test artifacts ( #42925 )
...
* Upload test-artifacts directory
* Rename test artifacts directory to avoid conflicts
* Update .gitignore
* Upload test artifacts
* Update .gitignore
* Update move-artifacts.sh
* Update artifacts.ts
* Update pipeline-segment-electron-test.yml
* Make output less noisy
* reduce artifact image size
2024-07-16 22:56:56 -07:00
Sam Maddock
778d3098a0
feat: customize border radius of Views ( #42320 )
...
* feat: add View#setBorderRadius
test: initial setBorderRadius tests
fix: robustly set border radius
chore: add PAUSE_CAPTURE_TESTS for easier screencap dev
feat: add view border radius support
test: view border radius
refactor: cleanup view code
* maybe delay capture to fix tests?
* refactor: retry screen captures in an attempt to fix flakiness
* refactor: ScreenCapture constructor no longer async
* increase screen capture timeout, feels a little short
* refactor: move rounded rect util into chromium_src
* skip some capture tests on mas
2024-07-16 20:16:25 -04:00
Shelley Vohr
cbd11bb605
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42824 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
2024-07-16 20:11:49 +02:00
Calvin
81351dd1a9
build: fix clang format location helper (again) ( #42911 )
2024-07-16 11:21:18 -04:00
dependabot[bot]
f575e52586
build(deps): bump github/codeql-action from 3.25.11 to 3.25.12 ( #42916 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.11 to 3.25.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b611370bb5...4fa2a79536 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-16 11:25:42 +02:00
Theo Gravity
bab3fcc9ab
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42805 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
2024-07-15 19:32:44 -04:00
David Sanders
0fddfd1b28
ci: auto comment on new issues for unsupported majors ( #42856 )
2024-07-15 15:25:47 -04:00
Keeley Hammond
c006e129b3
build: remove CircleCI ( #42844 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
2024-07-15 14:26:41 -04:00
reito
f173a0637a
chore: fix npm run lint not working on Windows ( #42281 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-07-15 18:08:33 +02:00
Shelley Vohr
ae1a684d10
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42851 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
2024-07-15 10:41:38 -04:00
Robo
1e1dc22e16
fix: crash when resolving proxy due to network service restart ( #42878 )
2024-07-15 17:46:24 +09:00
Shelley Vohr
bbd7f4a5ad
fix: File System Access API should remember last picked directory ( #42850 )
2024-07-14 18:43:37 +02:00
Calvin
493bc3ac9d
fix: desktopCapturer and screen display ids should match ( #42883 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
* simplify wide-to-utf8 conversion
* remove unnecessary include
2024-07-14 09:51:57 +02:00
John Kleinschmidt
3a6a201534
build: fixup GHA running on fork PRs ( #42880 )
...
* chore: update build-tools for GHA
* chore: don't rely on environment variables for source cache location
2024-07-13 13:38:03 -04:00
Samuel Attard
53d7cca7a2
build: use new arc runner names ( #42881 )
2024-07-12 22:22:49 -07:00
David Sanders
7dd6d7697d
chore: allow multiple OS selection on bug reports ( #42854 )
2024-07-11 13:23:43 -07:00
John Kleinschmidt
514e9bbb04
build: update build-tools for GHA ( #42870 )
...
chore: update build-tools for GHA
2024-07-11 16:18:26 -04:00
Shelley Vohr
dab006b1cf
ci: fix Nan test failure on Linux ( #42863 )
...
ci: Nan test failure on Linux
2024-07-11 10:47:02 -04:00
Shelley Vohr
4e10eeb87e
fix: desktopCapturer and screen source ids should match screen ids ( #42781 )
...
* fix: desktopCapturer screen source ids should match screen ids
* test: add a regression test
2024-07-10 16:32:29 -07:00
Shelley Vohr
fa6ce4f0f8
fix: High Contrast mode not working on Windows ( #42853 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
2024-07-10 15:14:02 -07:00
Charles Kerr
f9d94211bb
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener ( #42806 )
...
All the listener functions are empty stubs (and have been since d4e3c39 )
so it doesn't seem like we need a listener?
SpeechRecognitionManagerDelegate declares this method:
> // Checks whether the delegate is interested (returning a non nullptr
> // ptr) or not (returning nullptr) in receiving a copy of all sessions
> // events. This is called on the IO thread.
> virtual SpeechRecognitionEventListener* GetEventListener() = 0;
This PR has ElectronSpeechRecognitionManagerDelegate stop subclassing
from the Listener and changes GetEventListener() to return nullptr.
2024-07-10 15:32:50 +02:00
electron-roller[bot]
48fc352bcf
chore: bump node to v20.15.1 (main) ( #42841 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-10 14:52:06 +02:00
John Kleinschmidt
1a9f99b3ed
chore: speed up azcopy on src cache ( #42742 )
2024-07-09 16:20:18 -04:00
dependabot[bot]
34e7648478
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11 ( #42832 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](23acc5c183...b611370bb5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:27:37 +02:00
dependabot[bot]
c2ea3881fc
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42833 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:25:07 +02:00
David Sanders
170b72ccfa
ci: fix CircleCI config ( #42829 )
...
* ci: fix CircleCI config
* ci: fix syntax error
2024-07-08 21:38:05 -04:00
Shelley Vohr
e54ffdf7ed
build: clean up BoringSSL patch ( #42730 )
2024-07-08 16:35:54 -04:00
Charles Kerr
e9db02948e
fix: multiple move() calls on the same unique_ptr ( #42788 )
2024-07-08 11:04:35 -04:00
Charles Kerr
27e3273f0a
refactor: minor electron browser context cleanup ( #42789 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
* refactor: remove unused forward declarations of v8 classes
* chore: forward declare gin::Arguments
* refactor: use unique_ptr operator bool
2024-07-08 16:49:41 +02:00
electron-appveyor-updater[bot]
e99e554655
build: update appveyor image to latest version ( #42771 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-08 12:56:52 +02:00
Charles Kerr
5ff91159cd
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42785 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
2024-07-08 12:56:03 +02:00
Charles Kerr
e89da2bad2
fix: dangling raw_ptr<Session> in UserDataLink ( #42786 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
* chore: make linter happy
2024-07-08 12:55:48 +02:00
Shelley Vohr
cb2e7f130b
fix: potentially closed webContents in BrowserView ( #42633 )
2024-07-08 12:13:53 +02:00
Shelley Vohr
2f4a46f47a
fix: video and audio capture should be separate ( #42775 )
2024-07-08 10:11:40 +02:00
Shelley Vohr
ac074a5548
refactor: run Windows SelectFileDialog out of process ( #42758 )
...
* refactor: run Windows SelectFileDialog out of process
* fix: add missing IS_WIN guard
* refactor: use upstream SelectFileDialogFactory
* fix: build chrome/services/util_win/public/mojom target
2024-07-05 11:36:44 +02:00
electron-roller[bot]
19e030a6e8
chore: bump chromium to 128.0.6573.0 (main) ( #42766 )
...
* chore: bump chromium in DEPS to 128.0.6573.0
* chore: update patches
* 5665092: Remove default arguments on virtual functions in WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/5665092
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-05 09:51:21 +02:00
Shelley Vohr
5bff883c40
chore: clean up outdated goma references ( #42762 )
2024-07-05 09:44:34 +02:00
Shelley Vohr
25eb1bd4b2
build: remove all publish & build on macOS ( #42763 )
2024-07-03 15:17:17 -04:00
electron-roller[bot]
07e6b34a07
chore: bump chromium to 128.0.6571.0 (main) ( #42749 )
...
* chore: bump chromium in DEPS to 128.0.6571.0
* 5636652: [4/n] Introduce RenderInputRouterClient and move InputRouterClient implementation to RenderInputRouter.
https://chromium-review.googlesource.com/c/chromium/src/+/5636652
* 5655811: Revert "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"""
https://chromium-review.googlesource.com/c/chromium/src/+/5655811
* 5581006: [tracing] Forward startup tracing config as shmem
https://chromium-review.googlesource.com/c/chromium/src/+/5581006
* chore: fixup patch indices
* 5608450: [Views AX] Move Image Auto Captioning strings to ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5608450
* 5648900: [Extensions] Move ExtensionAPIEnabledForServiceWorkerScript()
https://chromium-review.googlesource.com/c/chromium/src/+/5648900
* 5651681: Remove Web Speech API profanity masking
https://chromium-review.googlesource.com/c/chromium/src/+/5651681
* 5651361: `content::RenderFrame::GetBrowserInterfaceBroker`: return a const-ref.
https://chromium-review.googlesource.com/c/chromium/src/+/5651361
* 5604943: Start capture of toolbar after gesture end events are received
https://chromium-review.googlesource.com/c/chromium/src/+/5604943
* 5624392: [BRP] Enforce raw_ptr/ref in Renderer code
https://chromium-review.googlesource.com/c/chromium/src/+/5624392
* 5659259: Portals: Remove WebContentsView::TransferDragSecurityInfo
https://chromium-review.googlesource.com/c/chromium/src/+/5659259
* 5230721: Move ComposeStatus to components/compose
https://chromium-review.googlesource.com/c/chromium/src/+/5230721
* 5647894: [api] Cleanup usages of v8::ReturnValue<void>::Set[NonEmpty](..)
https://chromium-review.googlesource.com/c/v8/v8/+/5647894
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-03 11:15:35 -04:00
Charles Kerr
cf5fb4505e
refactor: make session::browser_context_ a const raw_ref ( #42728 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-02 17:53:36 -04:00
Erick Zhao
0a8eae9019
docs(autoUpdater): document static storage strategy ( #42690 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
2024-07-02 19:06:38 +02:00
Erick Zhao
6cca75ac76
docs(autoUpdater): signing is only a pre-req on macOS ( #42709 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
2024-07-02 19:06:25 +02:00
electron-appveyor-updater[bot]
67d7944271
build: update appveyor image to latest version ( #42748 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-02 10:38:43 -04:00
Shelley Vohr
1729a9868c
fix: use BlockedRequest struct to handle webRequest data ( #42647 )
...
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.
This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33d .
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-02 09:51:33 +02:00
Anny Yang
14303a0a71
docs: grammar fix in isBeingCaptured docs ( #42692 )
2024-07-01 15:01:27 -04:00
Chris Stringer
2b5342cb49
docs - Update net.md ( #42691 )
...
Update net.md
Changes heading level for net.resolveHost() entry to H3
2024-07-01 14:45:49 -04:00
Alice Zhao
e9a93a8c5c
fix: setTopBrowserView focus issue with reordering ( #42653 )
...
* fix: reorder top browser view instead of adding/removing
* fix: update browserViews order
* test: add a test for setTopBrowserView
2024-07-01 11:36:04 +02:00
Keeley Hammond
efff369639
build: remove MacOS x64 from CircleCI ( #42718 )
2024-07-01 11:34:37 +02:00
Keeley Hammond
3ac57e17d5
build: fix clang format/lint ( #42715 )
...
* build: fix clang format path
* fix: use gclient sync instead of gclient runhooks
Refs https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5659261
* fix: use gclient sync instead of gclient runhooks in GHA
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-06-28 13:30:07 -07:00
Shelley Vohr
398dde9dfb
build: use inputs for target_arch in build ( #42684 )
2024-06-27 08:11:10 -07:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
David Sanders
1d4b00692d
build: bump version in .nvmrc to 20 ( #42668 )
2024-06-27 13:46:11 +02:00
electron-roller[bot]
ec24b51808
chore: bump node to v20.15.0 (main) ( #42616 )
...
* chore: bump node in DEPS to v20.15.0
* doc: Add OpenSSL errors to API docs
https://github.com/nodejs/node/pull/34213
* test: crypto-rsa-dsa testing for dynamic openssl
https://github.com/nodejs/node/pull/52781
* src: allow preventing debug signal handler start
https://github.com/nodejs/node/pull/46681
* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler
https://github.com/nodejs/node/pull/52766
* chore: fixup indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-27 13:34:39 +02:00
Shelley Vohr
c628de52d9
fix: defaultPath should apply on all dialog types in Linux Portal ( #42655 )
...
fix: defaultPath should apply on all dialog types in Linux Portal dialogs
2024-06-27 11:07:26 +02:00
Shelley Vohr
2b31d8459d
fix: param passed to showSaveDialogSync on Linux ( #42652 )
...
fix: pass correct param to sync functions on Linux
2024-06-27 10:23:18 +02:00
Keeley Hammond
912706b23a
build: strip linux release binaries ( #42675 )
2024-06-26 17:41:36 -07:00
Samuel Attard
b31acfb706
docs: clarify security semantics of safeStorage ( #42666 )
...
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-06-26 13:24:06 -07:00
Shelley Vohr
607b9b8f11
build: clean up upload-index-json error handling ( #42657 )
2024-06-26 09:25:58 -07:00
Keeley Hammond
a8baa6f1ad
build: remove CircleCI from release pipeline ( #42651 )
...
* build: remove CircleCI from release pipeline
* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
2024-06-25 14:25:04 -07:00
Shelley Vohr
3534923bd2
build: account for subjectAndDescription null in patch linting ( #42636 )
...
fix: account for subjectAndDescription null in patch linting
2024-06-24 22:32:43 -07:00
Keeley Hammond
66b8b79229
build: turn on GitHub Actions by default for all branches and pull requests ( #42623 )
...
* build: turn GitHub Actions on by default for push and pull_request
* build: try env var build-image-sha
* build: use ternery for input vs default
* build: pain
* build: modify setup to cascade build-image-sha
* build: move outputs into setup step
* build: add SAS key generation on re-run
* build: only build on push, not pull_request
* build: only build on push for main & release branches, build on PR for everything else
* build: rebase with main, handle asan build
* build: add exit 1, sha value
2024-06-24 12:06:13 +02:00
Corbin Crutchley
243be0a638
docs: fix typo in ASAR integrity docs ( #42538 )
...
Fix typo in ASAR integrity docs
2024-06-22 20:26:23 +02:00
Charles Kerr
24d6c28b5a
chore: remove walkdir dev dependency ( #42591 )
2024-06-21 10:31:10 -04:00
George Xu
ba8ad4716b
feat: expose system preferences to utility process ( #42203 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
2024-06-20 11:15:57 -04:00
Shelley Vohr
37608933ae
fix: fetch-dependent interfaces in Web Workers ( #42579 )
2024-06-20 11:01:50 -04:00
Keeley Hammond
edb939ae80
build: Add ASan Linux build to Actions build/test ( #42545 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-20 12:11:53 +02:00
Milan Burda
003c32331d
chore: add/fix interface comments for sections of methods ( #42566 )
2024-06-20 10:49:07 +02:00
Shelley Vohr
18abeb3add
build: re-enable self-cert codesigning on x64 macOS ( #42576 )
...
build: re-enable self-cert codesigning
2024-06-19 10:28:07 -04:00
Charles Kerr
dad6e130f5
build: remove fs-extra devdep ( #42533 )
...
* build: remove fs-extra dependency from script/gen-filenames.ts
* build: remove fs-extra dependency from script/spec-runner.js
* build: remove fs-extra dependency from script/gn-asar.js
* build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts
* build: remove fs-extra dependency from spec/api-safe-storage-spec.ts
* build: remove fs-extra dependency from spec/lib/codesign-helpers.ts
* build: remove fs-extra dependency from spec/api-app-spec.ts
* build: remove fs-extra dependency from spec/esm-spec.ts
* build: remove fs-extra dependency from spec/lib/fs-helpers.ts
* build: remove fs-extra dependency from spec/lib/api-shell-spec.ts
* build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* build: remove fs-extra dependency from spec/asar-integrity-spec.ts
* build: remove fs-extra dependency from spec/node-spec.ts
* build: remove fs-extra devdiv
* fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* fix: use force: true when removing directories
* chore: reduce diffs to main
2024-06-19 10:10:16 -04:00
Shelley Vohr
8e8ea3ee8b
fix: MessagePort closing unexpectedly with non-cloneable objects ( #42535 )
...
* fix: MessagePort closing unexpectedly with non-cloneable objects
* fix: handle serialization failure in parentPort
2024-06-19 11:27:07 +02:00
Keeley Hammond
6d2c72b14e
build: correct GCLIENT_EXTRA_ARGS in linux-publish ( #42575 )
2024-06-18 21:54:20 -07:00