trop[bot]
a05ebed03d
fix: segfault when moving WebContentsView between BrowserWindows ( #44614 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-12 10:34:02 -05:00
trop[bot]
2d150ccb33
chore: remove executable flag from docs/api/app.md file permissions ( #44579 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-05 12:12:23 -05:00
trop[bot]
7037042566
build: add new status to verify if all the required gha jobs have run ( #44560 )
...
build: add new status to verify if all the required gha jobs have run (#44432 )
(cherry picked from commit 1c1eb3e19d )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 21:13:54 -06:00
trop[bot]
b0698ec9f4
build: remove unused lint package ( #44533 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-11-04 19:22:24 -05:00
trop[bot]
aa16c04abc
build: handle out of disk space on source cache ( #44491 )
...
* build: handle out of disk space on source cache
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: add cron job to free up source cache disk space
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-31 20:27:27 -04:00
Pedro Pontes
15f8a19c98
chore: cherry-pick 2 changes from 1-M130 ( #44483 )
...
* chore: cherry-pick 2 changes from 1-M130
* chore: cherry-pick 1 change from 2-M130
2024-10-31 17:31:19 -04:00
Pedro Pontes
098680c4bb
chore: cherry-pick 1 change from 2-M130 ( #44485 )
2024-10-31 14:43:15 -04:00
Charles Kerr
17c9c79202
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (31-x-y) ( #44455 )
...
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (#44238 )
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
2024-10-29 21:41:36 +01:00
trop[bot]
9e9bb3dc7a
fix: crash on netlog connection error ( #44421 )
...
* fix: crash on netlog connection error
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* refactor: remove default PromiseBase constructor
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d .
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* remove dcheck
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-10-28 14:37:47 +01:00
trop[bot]
1e000ff2d6
test: deflake flaky tests on linux ( #44404 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-25 15:54:57 -05:00
Keeley Hammond
87947793d5
chore: cherry-pick 3 changes from 2-M129 ( #44236 )
...
* chore: [31-x-y] cherry-pick 3 changes from 2-M129
* 56be91796b85 from chromium
* c333ed995449 from chromium
* a7766feb0a90 from v8
* chore: update patches
* chore: update patches
* Remove an unnecessary backport, update another.
---------
Co-authored-by: Pedro Pontes <pepontes@microsoft.com >
2024-10-23 17:18:11 -04:00
Pedro Pontes
c6714ee45c
chore: backport 15 changes from 2-M127 to 1-M129 ( #44355 )
...
chore: backport 18 changes from 2-M127 to 1-M129
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-22 16:20:35 +02:00
Pedro Pontes
afad838a8b
chore: backport 2 changes from 0-M130 ( #44356 )
2024-10-22 11:53:48 +02:00
trop[bot]
a826f895d2
build: fixup reclient use for prod builds ( #44343 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-21 16:32:30 -05:00
trop[bot]
028863a93c
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44323 )
...
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com >
2024-10-18 16:19:15 -04:00
trop[bot]
ff024cd396
chore: fixup reclient read only access on forks ( #44310 )
...
chore: fixup reclient read only access on forks (#44280 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 12:05:31 -04:00
Keeley Hammond
c2c6bc57c1
chore: cherry-pick 3 changes from 1-M129 ( #44255 )
...
* chore: [31-x-y] cherry-pick 3 changes from 1-M129
* 85dd0fcc70ed from chromium
* 8068f489ec2c from v8
* f612d9a40b19 from v8
* chore: update patches
* chore: remove cherry-pick-85dd0fcc70ed.patch
* 901496: [M126-LTS][ganesh] Avoid int overflow in DrawAtlasOpImpl | https://skia-review.googlesource.com/c/skia/+/901496
* Trigger CI
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 09:52:41 -04:00
trop[bot]
2f247ad050
fix: Linux crash after webContents.print() with no parent window ( #44283 )
...
fix: Linux crash after print with no parent window
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-17 22:22:27 -04:00
trop[bot]
9d2c0ac9fe
build: remove dead code in prepare release script ( #44288 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-10-17 10:21:34 -04:00
trop[bot]
00e5d0ad56
fix: ensure utilityProcess only emits one 'exit' event ( #44267 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-16 15:04:26 +02:00
Keeley Hammond
1ab051bb69
chore: cherry-pick 2 changes from 3-M129 ( #44232 )
...
* chore: [31-x-y] cherry-pick 2 changes from 3-M129
* 9542895cdd3d from v8
* 81155a8f3b20 from v8
* chore: update patches
2024-10-14 22:10:02 -05:00
Charles Kerr
48b962898d
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (31-x-y) ( #44215 )
...
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44185 )
2024-10-13 20:04:33 +02:00
Charles Kerr
dce705efc0
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 ) ( #44216 )
...
fixup e8948397 really fix the warning this time
2024-10-13 20:04:18 +02:00
trop[bot]
e206378680
fix: clang variable configuration in generated node headers ( #44202 )
...
* fix: clang variable configuration in generated node headers
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: restore value in common.gypi
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 14:52:49 -04:00
trop[bot]
4ccf4fa97d
ci: don't call datadog test logging on forks ( #44194 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 09:42:10 -04:00
trop[bot]
d262568f77
ci: add datadog test logging ( #44165 )
...
* ci: add datadog test logging
(cherry picked from commit 394ea2979f )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* ci: only upload to datadog when running tests
(cherry picked from commit c3200d8f15 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-10 10:21:38 +02:00
trop[bot]
dbfe4742d5
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44168 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-09 19:36:05 -05:00
trop[bot]
478defb15c
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44172 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-09 16:47:48 -05:00
electron-roller[bot]
ba88433eb3
chore: bump node to v20.18.0 (31-x-y) ( #44115 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafc )
(cherry picked from commit 4b76e4e493 )
* chore: update patches
(cherry picked from commit 1f30195649 )
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-09 09:53:12 -04:00
Samuel Attard
ba6d9291d2
build: add import/order eslint rule ( #44108 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-03 15:21:54 -07:00
trop[bot]
6da785fd10
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (31-x-y) ( #44100 )
...
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44053 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 20:46:47 -05:00
trop[bot]
daca2d327f
fix: remove use of deprecated API base::Hash() ( #44101 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 20:46:26 -05:00
trop[bot]
f7159b6898
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (31-x-y) ( #44104 )
...
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (#44067 )
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 19:13:48 -05:00
trop[bot]
8e1e4541af
build: fix relative file read during npm publish ( #44090 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2024-10-01 17:19:43 -07:00
Samuel Attard
01e64d3932
build: cleanup release scripts, separate cli entrypoints from logic ( #44083 )
...
build: cleanup release scripts, separate cli entrypoints from logic (#44058 )
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 14:08:20 -07:00
Samuel Attard
075a297347
build: ensure consistent usage of getRepo ( #44079 )
2024-10-01 13:27:02 -07:00
Samuel Attard
5bdaa42b01
build: update some build dependencies ( #44071 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
* build: node 20 on windows
2024-10-01 13:14:08 -07:00
trop[bot]
9222396159
fix: ensure correct WebContents when checking PDFReadyToPrint (31-x-y) ( #44010 )
2024-10-01 18:32:31 +02:00
trop[bot]
a0802f7ce6
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (31-x-y) ( #44036 )
...
* fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014 )
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use string_view.rfind() instead of base::RSplitStringOnce()
base::RSplitStringOnce() does not exist in Chromium 128
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-01 12:17:16 -04:00
Samuel Attard
9ee51dbe92
build: convert all release scripts to typescript ( #44061 )
...
* build: convert all release scripts to typescript (#44035 )
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
* build: use ts-node to spawn the version-bumper (#44057 )
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-10-01 08:49:36 -07:00
trop[bot]
0a4b0de4f7
fix: ensure SetPluginCanSave updated in PDFs ( #44020 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-30 14:52:14 +02:00
trop[bot]
c895d45a6d
ci: write test logging to console on Windows ( #44006 )
...
test: write logging to console on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-29 10:13:04 +02:00
trop[bot]
60e0355b73
fix: remove resize listener when BrowserWindow closed ( #43999 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-27 14:46:03 -04:00
trop[bot]
6010fda0c7
perf: build g_dgettext domain name at compile time ( #43986 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-26 18:59:06 -05:00
trop[bot]
514fc26eb2
fix: replace deprecated libnotify API calls ( #43982 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-26 17:08:12 -05:00
dependabot[bot]
af9969a3ff
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.27.0 ( #43907 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](6c661ce588...37ebaef184 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-26 11:56:20 -04:00
trop[bot]
328afb8a09
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43981 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-26 10:55:35 -05:00
trop[bot]
a66e01b555
test: add tests dbus notification images ( #43965 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-26 09:56:22 -04:00
trop[bot]
e99de2b5c6
test: ensure sender-pid hint is set in Linux notifications ( #43951 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-25 14:02:07 -05:00
trop[bot]
6c1233a7d2
fix: close all open sheets before closing window on macOS ( #43953 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com >
2024-09-25 13:09:40 -05:00
dependabot[bot]
3c7a49fdb1
build(deps): bump actions/upload-artifact from 4.3.1 to 4.4.0 ( #43910 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...50769540e7f4bd5e21e526ee35c689e35e0d6874 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 12:14:21 -05:00
trop[bot]
d241d1f3b3
refactor: remove C-style void arg type for no-arg functions ( #43942 )
...
refactor: remove C-style void arg type for no-arg functions (#43884 )
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-25 12:13:22 -05:00
dependabot[bot]
1495f01e2e
build(deps): bump mikefarah/yq from 4.40.7 to 4.44.3 ( #43909 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...bbdd97482f )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 11:45:58 -05:00
trop[bot]
ad82142eb0
fix: detach native view when its removed from parent on macOS ( #43924 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co >
2024-09-25 13:17:47 +02:00
trop[bot]
a5f4f08a9e
fix: crash when focusing WebView webContents ( #43933 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-25 06:17:06 -05:00
trop[bot]
d8e3555e01
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43929 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-25 11:21:44 +02:00
Charles Kerr
f15fea8d03
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (31-x-y) ( #43926 )
...
* fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
* empty commit
2024-09-25 11:21:15 +02:00
dependabot[bot]
615825f40e
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #43906 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](82e99438bd...eb760c4889 )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 16:06:34 -05:00
dependabot[bot]
67590867c1
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 ( #43908 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...0a44ba7841 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:26:21 -07:00
trop[bot]
f387325079
fix: EyeDropper working in devtools (31-x-y) ( #43895 )
...
fix: EyeDropper working in devtools (#43685 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-23 22:36:18 -07:00
Samuel Attard
4e5de0ca44
build: add support for fetching github token from sudowoodo ( #43888 )
...
build: add support for fetching github token from sudowoodo (#43808 )
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 13:56:29 -07:00
Shelley Vohr
2cc8a33f11
fix: createWindow shouldn't load URL for webContents ( #43878 )
2024-09-23 21:55:17 +02:00
dependabot[bot]
ec63fbf0b1
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #43845 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:55:47 -07:00
dependabot[bot]
5aaf470e78
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #43843 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:55:31 -07:00
dependabot[bot]
a164109d50
build(deps): bump actions/checkout from 4.1.1 to 4.1.7 ( #43839 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...692973e3d937129bcbf40652eb9f2f61becf3332 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:54:12 -07:00
dependabot[bot]
6652a3e05c
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.5.0 ( #43833 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...43de6da2f4 )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:50:46 -07:00
dependabot[bot]
7fdf729ca2
build(deps): bump github/codeql-action from 3.24.0 to 3.26.8 ( #43831 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...294a9d9291 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:49:52 -07:00
trop[bot]
334a3fbea6
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43812 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: add a DCHECK to confirm the BigBuffer is full
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-20 08:48:00 -05:00
trop[bot]
568314240e
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43805 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-20 00:18:21 -05:00
Charles Kerr
48805ee46e
refactor: remove use of deprecated API BuildServiceInstanceFor() (31-x-y) ( #43782 )
...
refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690 )
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-19 10:01:00 +02:00
Charles Kerr
e62c322b2d
refactor: declare gin::Wrapper subclasses as final ( #43783 )
...
refactor: declare gin::Wrapper subclasses as final (#43527 )
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-19 09:57:24 +02:00
trop[bot]
ea3c48e7c1
build: let darwin/mas run concurrently ( #43790 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2024-09-18 16:36:24 -07:00
trop[bot]
062d3b8161
build: split darwin/mas macOS publish jobs ( #43765 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2024-09-17 20:07:40 -07:00
trop[bot]
d519913bfa
build: improve logging on http errors during release process ( #43760 )
...
* build: improve logging on http errors during release process (#43756 )
Co-authored-by: Samuel Attard <sam@electronjs.org >
* build: improve logging on http errors during release process (again) (#43757 )
Co-authored-by: Samuel Attard <sam@electronjs.org >
* build: improve logging on http errors during release process (again, but more) (#43758 )
Co-authored-by: Samuel Attard <sam@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-09-17 20:05:56 -07:00
trop[bot]
c5e1a336f2
fix: resizing border on Linux WCO caption buttons ( #43745 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-17 21:54:10 +02:00
trop[bot]
0846294d70
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43748 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-17 14:40:13 -05:00
trop[bot]
c481be0028
ci: move Archaeologist to GHA ( #43734 )
...
* chore: move Archaeologist to GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: test archaelogist changes
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a .
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: properly name steps in archaeologist-dig
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-17 11:49:51 -04:00
trop[bot]
ca2a30c484
docs: document View.removeChildView edge case ( #43727 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-09-16 12:52:58 +02:00
trop[bot]
ee572aac74
refactor: avoid minor code repetition in native_image.cc ( #43702 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-12 20:13:39 +02:00
trop[bot]
f93cc252ba
fix: native View wrapper crash missing when adding child view ( #43697 )
...
fix: native View wrapper crash missing when adding child view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-12 19:20:47 +02:00
trop[bot]
87f5d788c0
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() ( #43674 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-10 22:18:31 -05:00
trop[bot]
99416b8576
perf: use v8::Local<v8::Object> as the key in ObjectCache ( #43672 )
...
* perf: use v8::Object* as direct keys instead of using hash + a linked list
* refactor: use v8::Local<v8::Object> as the key
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-10 15:43:44 -05:00
trop[bot]
2c3416627f
fix: restore Chromium default Content-Disposition header parsing ( #43669 )
...
* fix: restore Chromium default Content-Disposition header parsing
Co-authored-by: Milan Burda <milan.burda@gmail.com >
* Update api-web-request-spec.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2024-09-10 13:27:22 -04:00
trop[bot]
54899c3b4b
docs: update window customization tutorial ( #43661 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-09-10 10:12:11 +02:00
trop[bot]
f292be6630
build: fix patchup logic only running on one platform ( #43656 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-10 09:58:44 +02:00
trop[bot]
43687aca8a
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43658 )
...
fix: ensure bounds stability in OnWidgetBoundsChanged
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-09 21:56:42 -05:00
trop[bot]
96fe03b200
test: add -pdf-ready-to-print event to WebContents for testing ( #43651 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-09 21:56:16 -05:00
trop[bot]
4b5d29201c
chore: remove unused ConvertableToTraceFormatWrapper ( #43653 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-09 21:55:42 -05:00
trop[bot]
f6bc0b0953
fix: -Wunsafe-buffer-usage warnings in asar file IO ( #43649 )
...
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: -Wunsafe-buffer-usage warnings in Archive::Init()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-09 17:58:41 -05:00
trop[bot]
e4113ddd69
fix: out-of-scope Local handle in node::CallbackScope ( #43641 )
...
refactor: use an EscapableHandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-09 17:23:16 -05:00
Shelley Vohr
4de345574a
fix: ensure version of xdg-dialog-portal with defaultPath support ( #43630 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
2024-09-09 19:21:37 +02:00
trop[bot]
97f0a9a545
fix: UvHandle move semantics ( #43632 )
...
reassign the uv_handle_t of the source
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-09 11:52:57 -05:00
electron-roller[bot]
e3908eca41
chore: bump node to v20.17.0 (31-x-y) ( #43423 )
...
* chore: bump node in DEPS to v20.17.0
* module: disallow CJS <-> ESM edges in a cycle from require(esm)
https://github.com/nodejs/node/pull/52264
* src: expose LookupAndCompile with parameters
https://github.com/nodejs/node/pull/53886
* src: fix -Wshadow warning
https://github.com/nodejs/node/pull/53885
* lib: convert WeakMaps in cjs loader with symbol properties
https://github.com/nodejs/node/pull/52095
* src: reduce unnecessary serialization of CLI options in C++
https://github.com/nodejs/node/pull/52451
* lib: improve error message when index not found on cjs
https://github.com/nodejs/node/pull/53859
* src,lib: expose getCategoryEnabledBuffer to use on node.http
https://github.com/nodejs/node/pull/53602
* deps: update c-ares to v1.32.2
https://github.com/nodejs/node/pull/53865
* chore: fixup patch indices
* deps: update V8 to 12.2
https://github.com/nodejs/node/pull/51362
* stream: Expose DuplexPair API
https://github.com/nodejs/node/pull/34111
* chore: remove patch
* chore: fixup patch misapplication
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-09 18:39:28 +02:00
trop[bot]
87ecd1e62b
fix: update BrowserView#lastWindowSize after window resize ( #43635 )
...
fix: update BrowserView#lastWindowSize after window resize (#43462 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Zonglong Liu <83216456+mai-121@users.noreply.github.com >
2024-09-09 17:40:31 +02:00
trop[bot]
a3a595383d
perf: avoid redundant Promise.GetContext calls ( #43618 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-08 10:37:26 -05:00
trop[bot]
00c0948e7b
refactor: take a uint8_t span in ValidateIntegrityOrDie() ( #43614 )
...
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-06 22:16:51 -05:00
trop[bot]
5f97f97f7c
fix: confirm a v8::Value is a v8::Object before casting it ( #43603 )
...
fix: confirm a v8::Value is a v8::Object before casting it
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-06 15:26:33 -05:00
trop[bot]
5c424edcca
refactor: NativeWindow::Create() returns a unique_ptr ( #43605 )
...
refactor: NativeWindow::Create() returns a unique_ptr
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-06 14:19:50 -05:00
trop[bot]
9da190f786
fix: delete UvTaskRunner's timers only after they're closed ( #43598 )
...
* fix: free UvTaskRunner timers only after they are closed
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: UvTaskRunner now holds UvHandles
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-06 11:18:52 -05:00
trop[bot]
a461a95b60
build: use proper targets for building ( #43586 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-06 10:59:29 +02:00
trop[bot]
98c7dfbdaf
docs: explain ipcRenderer behavior in context-bridge.md ( #43585 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev >
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
2024-09-05 17:05:19 -04:00
trop[bot]
722bc116f8
fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland ( #43578 )
...
* fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland
Ensure apps are launched with the activation token received from
xdg_activation_v1 protocol.
Co-authored-by: Orko Garai <orko@igalia.com >
* add focus_launched_process option
Co-authored-by: Orko Garai <orko@igalia.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Orko Garai <orko@igalia.com >
2024-09-05 15:16:49 -05:00
trop[bot]
9bc59d1c2b
build: fix telemetry error when using autoninja ( #43572 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-05 09:07:37 -04:00
trop[bot]
73f43ae46b
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() ( #43542 )
...
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: improve code comments for CheckCommandLineArguments()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: reduce diffs from main
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: CheckCommandLineArguments takes a StringVector arg
Fixes another buffer warning!
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: use base::CommandLine::StringPieceType
base:CommandLine::StringViewType has not been invented yet
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-04 21:27:00 -05:00
trop[bot]
cb7eb6747d
build: don't run symbol generation on PS ( #43557 )
...
fix: don't run symbol generation on PS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-09-04 20:19:08 -05:00
trop[bot]
3b3f2112d5
fix: don't use deprecate-soon class v8::String::Value ( #43553 )
...
* fix: remove use of deprecated v8::String::Value
Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.
The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().
Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk
v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)
History on why we used it:
80c1a9739d
f49ed30f72
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update shell/common/gin_converters/file_path_converter.h
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! Update shell/common/gin_converters/file_path_converter.h
do not return success for all non-Null non-Strings
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-04 12:54:19 -05:00
trop[bot]
d025ecfa6b
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app ( #43547 )
...
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Orko Garai <orko@igalia.com >
2024-09-04 17:28:02 +02:00
John Kleinschmidt
523b4cb27a
build: free up macos disk space as soon as possible ( #43538 )
...
* chore: free up macos disk space as soon as possible
* build: free up disk space on gn check too
2024-09-04 12:19:30 +02:00
trop[bot]
16a8ac15be
chore: speed up cache only reclient for fork PRs ( #43504 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-03 21:40:20 -04:00
trop[bot]
f7404bceea
fix: devtools dock state with WCO on linux ( #43500 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-29 13:27:14 -04:00
trop[bot]
0fa92e0fea
refactor: simplify KeyWeakMap impl ( #43484 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-26 18:10:34 -04:00
trop[bot]
44e57c6cbb
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha ( #43475 )
...
added in Aug 2021 (41646d11 , #29600 ) but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-24 00:11:00 -05:00
trop[bot]
3251f84328
chore: remove unused method asar::ClearArchives() ( #43469 )
...
chore: remove unused asar::ClearArchives()
last use removed in Jun 2021 (b1d1ac65 , #29293 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-23 17:02:34 -05:00
trop[bot]
62c63ea35a
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43458 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-23 10:39:06 -05:00
trop[bot]
a373ab027b
fix: menu should allow focused BaseWindow where possible ( #43439 )
...
fix: menu should allow focused BaseWindow
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-22 18:33:44 -05:00
trop[bot]
557d5c901a
fix: documentation spelling errors ( #43434 )
...
chore: fix typos in 'docs/' folder.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alexander Cyon <alex.cyon@gmail.com >
2024-08-22 16:04:06 +02:00
trop[bot]
1b657869c2
fix: touch bar functionality on BaseWindow ( #43420 )
...
* fix: touch bar functionality on BaseWindow
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: add test for BaseWindow.setTouchBar
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-22 15:43:47 +02:00
trop[bot]
a7459bc93b
refactor: move impl functions into private namespace ( #43410 )
...
* refactor: move into unnamed namespace: IsKillURL()
refactor: move into unnamed namespace: ResolvePossiblyRelativeURL()
refactor: move into unnamed namespace: AllowFileAccess()
refactor: move into unnamed namespace: PrepareURLForNavigation()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetMonitors()
refactor: move into unnamed namespace: GetEDIDProperty()
refactor: move into unnamed namespace: MonitorAtomIdToDisplayId()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetPermissionInfos() } refactor: move into unnamed namespace: GetPermissionAliases()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: OnOpenExternal()
refactor: move into unnamed namespace: HandleExternalProtocolInUI()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: BindMimeHandlerService()
refactor: move into unnamed namespace: BindBeforeUnloadControl()
refactor: move into unnamed namespace: BindBadgeServiceForServiceWorker()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetClientIdPath()
refactor: move into unnamed namespace: ReadClientId()
refactor: move into unnamed namespace: WriteClientId()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: HasExplicitLogFile()
refactor: move into unnamed namespace: DetermineLoggingDestination()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetArchiveCache()
refactor: move into unnamed namespace: GetArchiveCacheLock()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetParameters()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: GetDoomed()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move into unnamed namespace: EncodeToken()
refactor: move into unnamed namespace: PortInfoToValue()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-21 21:29:25 -05:00
trop[bot]
5080b647c8
refactor: NodeBindings::Create() returns a unique_ptr ( #43393 )
...
refactor: NodeBindings::Create() returns a unique_ptr (#43361 )
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-21 10:56:59 -04:00
Charles Kerr
aa47f3efc3
refactor: remove unused SetWMSpecState ( #43383 )
...
refactor: remove unused SetWMSpecState (#43347 )
last use removed in Aug 2022 by 53cd2315 #35179
2024-08-21 10:26:30 +02:00
Charles Kerr
3596197562
chore: remove unused method Erase() ( #43382 )
...
chore: remove unused method Erase() (#43348 )
Last use removed in Mar 2018 by 4b39d17e
2024-08-21 10:15:17 +02:00
Keeley Hammond
054679ee99
chore: cherry-pick 9797576 from v8 ( #43386 )
...
* chore: cherry-pick 9797576 from v8 (#43376 )
* chore: update patches
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-20 17:05:47 -07:00
Shelley Vohr
7df2211c30
build: use smaller instances for gn-check ( #43359 )
...
build: use smaller instances for gn-check (#43187 )
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-08-20 09:58:11 +02:00
trop[bot]
b80d708fc1
feat: accept-encoding zstd ( #43301 )
...
* fix: accept-encoding zstd
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: make lint happy
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-16 11:24:07 +02:00
trop[bot]
a959476dc2
fix: blank page when printing pdf ( #43327 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-15 10:30:22 -04:00
trop[bot]
bd70c3a740
refactor: update chrome.scripting extensions api impls ( #43290 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-12 12:09:34 +02:00
trop[bot]
997afe62f2
chore: remove unused Notification fields icon_path_, has_icon_ ( #43295 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584 )
Last use of `has_icon_` was removed on May 30, 2017 (5048425e )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-12 12:09:25 +02:00
trop[bot]
dd1dcad81c
fix: system-context-menu with frameless BrowserWindows ( #43274 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-11 21:30:37 +02:00
trop[bot]
10dd33c16e
fix: check screen capture permissions in desktopCapturer ( #43271 )
...
fix: check screen capture permissions in desktopCapturer
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-11 21:30:27 +02:00
trop[bot]
c3a7f0001c
fix: accidental handle copying in a range loop ( #43281 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-10 09:59:36 +02:00
trop[bot]
a780a75dec
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43250 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-08 10:59:15 +02:00
electron-roller[bot]
6e69cb0191
chore: bump chromium to 126.0.6478.234 (31-x-y) ( #43252 )
...
chore: bump chromium in DEPS to 126.0.6478.234
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-08 01:10:00 +09:00
trop[bot]
520a147244
docs: Document ideal iconPath size ( #43241 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-08-07 11:57:17 +02:00
trop[bot]
36cebb95c6
refactor: simplify window moveAbove/moveTop impl on macOS ( #43201 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-06 16:41:49 -04:00
trop[bot]
be842d6267
perf: avoid redundant calls to GetView() ( #43229 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: avoid discarded GetView() call
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-06 13:23:21 -05:00
trop[bot]
8fb3a04eee
fix: potential draggable regions crash in DevTools ( #43200 )
...
* fix: potential draggable regions crash in DevTools
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patch after rebase
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-06 20:12:16 +02:00
trop[bot]
17cb664e39
perf: don't build unused vectors in HidChooserContext ( #43214 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use structured bindings for readability
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-06 09:57:00 -05:00
trop[bot]
54b31f153c
fix: gin_helper::MicrotasksScope instantiation ( #43209 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-05 21:46:51 -05:00
Charles Kerr
cbf1adb1b7
fix: 31-x-y gn sync fail when patching dawn, dxc ( #43215 )
...
* chore: remove reland_deps_update_dxc_to_patched_branch.patch
Xref: https://dawn-review.googlesource.com/c/dawn/+/200494
This patch has (re)landed upstream
* chore: remove cherry-pick-9463ce9cd8d9.patch
Xref: https://chromium-review.googlesource.com/c/external/github.com/microsoft/DirectXShaderCompiler/+/5715228
* chore: remove unused patch dirs
h/t @jkleinsc
* fixup! chore: remove unused patch dirs
fix: oops
2024-08-05 15:41:43 -04:00
Keeley Hammond
3f0dcb75df
chore: cherry-pick 1 change from 3-M126 ( #43140 )
...
* chore: [31-x-y] cherry-pick 9 changes from 3-M126
* d54105311590 from chromium
* c5dd8839bfaf from chromium
* cdbc1d9684a3 from v8
* 38e4483e47f9 from chromium
* 70d2fe6b7c47 from v8
* 901377bb2f3b from v8
* 1b9040817119 from chromium
* 99cafbf4b4b9 from chromium
* bc545b15a0ee from v8
* chore: update patches
* 5639725: [wasm] Fix scanning of wasm-to-js params | https://chromium-review.googlesource.com/c/v8/v8/+/5639725
Fix was already applied upstream
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-02 15:17:25 +02:00
electron-roller[bot]
7da10ffced
chore: bump chromium to 126.0.6478.226 (31-x-y) ( #43164 )
...
chore: bump chromium in DEPS to 126.0.6478.226
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 14:54:08 +02:00
Pedro Pontes
a9f81e63c4
chore: cherry-pick 3 changes from 0-M127 ( #43158 )
...
* chore: [31-x-y] cherry-pick 3 changes from 0-M127
* 44b7fbf35b10 from chromium
* c9815acd5a88 from dawn
* 9463ce9cd8d9 from DirectXShaderCompiler
* chore: e patches all
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-02 10:11:13 +02:00
trop[bot]
1c368f13f8
fix: take bluetooth serial ports into account in serial.getPorts() ( #43170 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: remove port.path.LossyDisplayName()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-01 23:10:46 -07:00
trop[bot]
2ad5d1ff71
chore: remove unused internal env.unSetVar() ( #43175 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260 , #25623 ) but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-01 21:32:17 -05:00
trop[bot]
f3fc1e626d
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc ( #43178 )
...
fixed electron-fiddle build and config links
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: terrence-ou <outerrencedl@gmail.com >
2024-08-01 20:47:41 -05:00
electron-roller[bot]
05fbbebca5
chore: bump node to v20.16.0 (31-x-y) ( #43026 )
...
chore: bump node in DEPS to v20.16.0
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-01 15:34:51 +02:00
trop[bot]
cdb0540cf0
fix: handle failing to enter fullscreen on macOS ( #43154 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com >
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com >
2024-08-01 14:50:23 +02:00
Shelley Vohr
832090d01c
feat: add transparency checking to nativeTheme ( #43137 )
...
feat: add transparency checking to nativeTheme
2024-08-01 12:14:07 +02:00
trop[bot]
8e21aad444
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43114 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a (#26659 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-31 20:07:30 -05:00
trop[bot]
31551aba9d
fix: vibrant view is inserted into Views API hierarchy ( #43128 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu >
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-31 19:59:27 -05:00
trop[bot]
dbcd56209a
chore: remove unused KeyWeakMap JS bindings ( #43144 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8 #25711 )
- Jun 2020 (e1e73fa5 #24115 )
- Jun 2020 (c0182bca #24116 ).
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-31 18:56:54 -05:00
trop[bot]
ce426cd957
docs: update Node.js stable release policy ( #43134 )
...
* docs: update Node.js stable release policy
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-31 10:44:23 -04:00
trop[bot]
1fe01eb0b1
build: fixup ffmpeg release on x64 macOS ( #43121 )
...
chore: fixup arch on x64 macOS ffmpeg
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-30 19:28:48 -05:00
Keeley Hammond
24db198d52
fix: remove InspectableWebContentsViewMac ( #43096 )
...
* fix: remove InspectableWebContentsViewMac (#43033 )
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93d .
* build: fix gn check
* chore: implement setCornerRadii in inspectable_web_contents_view_mac
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: pass in cornerRadii value in setCornerRadii
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: forward declaration
* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: remove custom border radius feat (#42320 )
* fix: fix views::Widget::InitParams params
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-30 14:51:51 -04:00
trop[bot]
b1921b362e
chore: remove unused class electron::ObjectLifeMonitor ( #43109 )
...
chore: remove unused class `electron::ObjectLifeMonitor` (#43089 )
The last users were removed in June 2020 e1e73fa5f (#24115 )
and May 2020 9d7ba982 (#23592 ).
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-30 13:27:12 -05:00
trop[bot]
35b73514b7
fix: showInactive window not showing ( #43102 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-30 13:02:03 -05:00
trop[bot]
6322c329bf
fix: always terminate active Node Streams ( #43071 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
2024-07-27 14:47:12 -05:00
trop[bot]
b6e19c5a45
chore: avoid crash while notification removal ( #43061 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
Co-authored-by: bill.shen <shenyb32768@gmail.com >
* fix notification removal crash due to the nullptr presenter
Co-authored-by: bill.shen <shenyb32768@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-07-26 16:32:43 -04:00
trop[bot]
871136bf91
refactor: move safe_storage functions into anonymous namespace ( #43051 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-25 22:32:17 +02:00
trop[bot]
94381733ff
fix: File System API permissions should reset on WebContents destruction ( #43048 )
...
fix: active File System API permissions should reset on WebContents destruction
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-25 16:01:56 -04:00
electron-roller[bot]
ca9027bc38
chore: bump chromium to 126.0.6478.185 (31-x-y) ( #43027 )
...
chore: bump chromium in DEPS to 126.0.6478.185
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-07-25 10:21:03 -04:00
trop[bot]
139abe73a1
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43044 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: oops fix showing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-25 15:35:23 +02:00
trop[bot]
097a3e9024
chore: use v8::Local<>, not v8::Handle<> ( #43037 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-25 11:00:05 +02:00
trop[bot]
9e14f8d828
feat: emit an event when accessing restricted path in File System Access API ( #42994 )
...
* fix: show a dialog when accessing restricted path in File System Access API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: allow overriding initial blocked paths
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* docs: fix doc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: change block to deny for consistency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-24 13:23:33 -04:00
trop[bot]
f797f92716
docs: note macOS fullscreen events in fullscreen query ( #43016 )
...
docs: note macOS fullscreen events in fs query
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-23 16:56:58 -04:00
trop[bot]
7f6eab8c25
docs: improve desktop capture example ( #43005 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-23 12:35:00 +02:00
trop[bot]
b288f3ee59
refactor: remove WindowListObserver::OnWindowAdded() ( #42984 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-22 19:12:59 +02:00
trop[bot]
b833c3f02a
chore: remove unused BaseWindow::GetWeakPtr() ( #42988 )
...
last caller removed in 67ba3040 (#37902 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-22 10:20:27 -05:00
trop[bot]
d53f1d8ff4
chore: remove unused WrappableBase::AfterInit() ( #42986 )
...
last caller removed in 6159066c (#22916 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-22 15:52:56 +02:00
trop[bot]
e259dd591f
chore: remove unused typedef CreateDownloadPathCallback ( #42968 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-19 21:44:54 -05:00
trop[bot]
daf8d22e07
refactor: remove unused web contents preferences methods ( #42969 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove unused WebContentsPreferences::GetSafeDialogsMessage()
caller removed in 85bc005c
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make WebContentsPreferences::last_preference() const
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-19 18:55:07 -05:00
electron-roller[bot]
6249f596f9
chore: bump chromium to 126.0.6478.183 (31-x-y) ( #42942 )
...
* chore: bump chromium in DEPS to 126.0.6478.182
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6478.184
* chore: bump chromium in DEPS to 126.0.6478.183
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-19 16:30:41 -05:00
trop[bot]
6c1409ae57
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42965 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-19 14:37:32 -05:00
trop[bot]
0d9918cd24
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42955 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-19 12:26:37 -05:00
trop[bot]
bb093817ed
fix: dangling raw_ptr<views::View> in api::View ( #42951 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-17 23:31:40 -05:00
trop[bot]
1de0bb30b1
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42915 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Theo Gravity <theo@suteki.nu >
2024-07-17 09:49:05 -07:00
trop[bot]
e429b6f745
fix: crash with creating OffScreenWebContentsView ( #42941 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com >
2024-07-17 09:10:00 -05:00
trop[bot]
e3a5895c2b
fix: getUserMedia needs macOS system permissions check ( #42937 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-17 13:08:34 +02:00
Calvin
5951712f2e
build: fix clang format location helper ( #42926 )
...
* build: fix clang format location helper (again)
* use gclient sync in lint workflow for downloading clang-format
2024-07-17 11:30:36 +02:00
trop[bot]
85cb6d9476
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42928 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-17 11:29:22 +02:00
trop[bot]
5029bce65c
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42901 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-16 12:32:35 +02:00
trop[bot]
697f468f36
chore: fix npm run lint not working on Windows ( #42906 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com >
2024-07-16 12:32:07 +02:00
John Kleinschmidt
9659dab19e
build: remove CircleCI ( #42844 ) ( #42909 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
(cherry picked from commit c006e129b3 )
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-07-15 16:00:20 -07:00
electron-roller[bot]
398e34967f
chore: bump node to v20.15.1 (31-x-y) ( #42839 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-15 17:29:57 -04:00
trop[bot]
9833c7f1e6
build: fixup GHA running on fork PRs ( #42904 )
...
* chore: update build-tools for GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: don't rely on environment variables for source cache location
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-15 14:29:41 -04:00
trop[bot]
266b23745b
fix: File System Access API should remember last picked directory ( #42893 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-15 17:22:56 +02:00
trop[bot]
65f431ab78
fix: crash when resolving proxy due to network service restart ( #42897 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-07-15 14:50:41 +02:00
trop[bot]
5c2a8b9047
fix: desktopCapturer and screen display ids should match ( #42890 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
Co-authored-by: clavin <clavin@electronjs.org >
* simplify wide-to-utf8 conversion
Co-authored-by: clavin <clavin@electronjs.org >
* remove unnecessary include
Co-authored-by: clavin <clavin@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2024-07-14 18:30:34 +02:00
Samuel Attard
05abc2bab2
build: use new arc runner names ( #42886 )
...
build: use new arc runner names (#42881 )
2024-07-13 12:10:40 -07:00
trop[bot]
c916070300
build: update build-tools for GHA ( #42873 )
...
chore: update build-tools for GHA
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-12 11:17:39 +02:00
trop[bot]
f392f558e0
fix: desktopCapturer and screen source ids should match screen ids ( #42861 )
...
* fix: desktopCapturer screen source ids should match screen ids
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: add a regression test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-11 15:47:33 -04:00
trop[bot]
54d920165e
ci: fix Nan test failure on Linux ( #42865 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-11 15:46:42 -04:00
trop[bot]
c3868809df
chore: speed up azcopy on src cache ( #42847 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-11 09:46:23 -04:00
trop[bot]
e768a1f228
fix: dangling raw_ptr<Session> in UserDataLink ( #42852 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-11 14:53:06 +02:00
trop[bot]
217e740791
fix: High Contrast mode not working on Windows ( #42859 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-10 16:48:24 -07:00
trop[bot]
dc065dfa5a
fix: potentially closed webContents in BrowserView ( #42810 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-10 15:33:27 +02:00
Shelley Vohr
6a15e168ce
build: remove all publish & build on macOS ( #42827 )
...
* build: remove all publish & build on macOS
* ci: fix CircleCI config (#42829 )
* ci: fix CircleCI config
* ci: fix syntax error
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-07-10 14:52:30 +02:00
Keeley Hammond
7084258dd4
build: fix release, add newVersion for tagging ( #42843 )
2024-07-09 11:08:59 -07:00
Shelley Vohr
56c3507ef2
refactor: run Windows SelectFileDialog out of process ( #42825 )
...
refactor: run Windows SelectFileDialog out of process
2024-07-09 19:03:13 +02:00
trop[bot]
650b8e6777
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42813 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-09 11:03:45 +02:00
trop[bot]
7353fa88cd
refactor: minor electron browser context cleanup ( #42815 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused forward declarations of v8 classes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: forward declare gin::Arguments
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use unique_ptr operator bool
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-08 13:49:23 -04:00
trop[bot]
50864bcd08
fix: multiple move() calls on the same unique_ptr ( #42821 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-08 13:48:47 -04:00
trop[bot]
e36d79706e
fix: video and audio capture should be separate ( #42809 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-08 16:46:41 +02:00
trop[bot]
342ef8e7e1
feat: enable Windows Control Overlay on Linux ( #42682 )
...
* feat: enable Windows Control Overlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* docs: update documentation for Linux WCO
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: initial symbol painting
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: enable WCO tests for Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: add missing Layer include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix gn-check failure
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: enable BrowserWindow.setTitleBarOverlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: fix test for maximize event on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: geometry updating on BrowserWindow.setTitleBarOverlay
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: crash when invalid titleBarStyle set
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: clean up ordering and comments
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update docs/api/structures/base-window-options.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* feat: enable customizing symbolColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* docs: correct symbolColor reference
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: remove Chrome-specific padding
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-03 16:09:12 -04:00
trop[bot]
89d09922f7
fix: use BlockedRequest struct to handle webRequest data ( #42751 )
...
* refactor: use BlockedRequest model to handle webRequest
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* refactor: finish de-templating
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: address some feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-03 14:46:29 +02:00
trop[bot]
339c30f48b
docs(autoUpdater): document static storage strategy ( #42756 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-03 11:49:56 +02:00
trop[bot]
6caad0a5f6
docs(autoUpdater): signing is only a pre-req on macOS ( #42753 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-03 11:43:03 +02:00
trop[bot]
9d3195bec1
fix: setTopBrowserView focus issue with reordering ( #42734 )
2024-07-02 14:09:28 +02:00
trop[bot]
3ab4b22460
build: strip linux release binaries ( #42744 )
...
build: strip linux release binaries (#42675 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-07-02 13:54:10 +02:00
electron-roller[bot]
286da15a2c
chore: bump chromium to 126.0.6478.127 (31-x-y) ( #42646 )
...
* chore: bump chromium in DEPS to 126.0.6478.126
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6478.127
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-01 17:28:53 -04:00
trop[bot]
4d10825e7a
build: remove MacOS x64 from CircleCI ( #42732 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-07-01 06:33:34 -04:00
Keeley Hammond
ba9b3d4421
build: migrate to GitHub Actions ( #42720 )
...
* build: migrate to GitHub Actions
* build: use old clang-format binary path
* debug (do not merge): intentionally bust Linux cache
* build: unskip cache creation
2024-07-01 06:33:12 -04:00
Charles Kerr
70bb34ed11
fix: potential null dereference in normalizeSpawnArguments() patch ( #42697 )
...
fix: potential null dereference in normalizeSpawnArguments() patch (#42260 )
fix: potential null deref in normalizeSpawnArguments() patch
Use upstream's practice of using `env = options.env || process.env`.
Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD
and CRASHPAD_HANDLER_PID to options.env.
2024-06-28 16:06:53 -05:00
trop[bot]
e480e29cfc
build: remove fs-extra devdep ( #42708 )
...
* build: remove fs-extra dependency from script/gen-filenames.ts
* build: remove fs-extra dependency from script/spec-runner.js
* build: remove fs-extra dependency from script/gn-asar.js
* build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts
* build: remove fs-extra dependency from spec/api-safe-storage-spec.ts
* build: remove fs-extra dependency from spec/lib/codesign-helpers.ts
* build: remove fs-extra dependency from spec/api-app-spec.ts
* build: remove fs-extra dependency from spec/esm-spec.ts
* build: remove fs-extra dependency from spec/lib/fs-helpers.ts
* build: remove fs-extra dependency from spec/lib/api-shell-spec.ts
* build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* build: remove fs-extra dependency from spec/asar-integrity-spec.ts
* build: remove fs-extra dependency from spec/node-spec.ts
* build: remove fs-extra devdiv
* fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* fix: use force: true when removing directories
* chore: reduce diffs to main
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-06-28 12:13:46 -05:00
trop[bot]
2c3a9fd3c5
build: remove klaw dependency ( #42701 )
...
* refactor: remove klaw dependency
Node 20 added recursive readdir() so klaw is not needed
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! refactor: remove klaw dependency
findMatchingFiles returns a Promise<string[]>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-06-28 10:11:42 +02:00
Shelley Vohr
8322c61a0a
fix: defaultPath should apply on all dialog types in Linux Portal ( #42685 )
2024-06-27 19:49:29 +02:00
electron-roller[bot]
6a058ed6cd
chore: bump node to v20.15.0 (31-x-y) ( #42614 )
...
* chore: bump node in DEPS to v20.15.0
* doc: Add OpenSSL errors to API docs
https://github.com/nodejs/node/pull/34213
* test: crypto-rsa-dsa testing for dynamic openssl
https://github.com/nodejs/node/pull/52781
* src: allow preventing debug signal handler start
https://github.com/nodejs/node/pull/46681
* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler
https://github.com/nodejs/node/pull/52766
* chore: fixup patch indices
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-27 15:58:43 +02:00
trop[bot]
2f6c4d8d24
fix: param passed to showSaveDialogSync on Linux ( #42678 )
...
fix: pass correct param to sync functions on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-27 13:45:39 +02:00
trop[bot]
afd288b660
docs: clarify security semantics of safeStorage ( #42672 )
...
* docs: clarify security semantics of safeStorage
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Samuel Attard <sam@electronjs.org >
* Update safe-storage.md
Co-authored-by: Samuel Attard <sam@electronjs.org >
* Update safe-storage.md
Co-authored-by: Samuel Attard <sam@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-06-27 07:52:22 +02:00
trop[bot]
5933cd11cd
build: clean up upload-index-json error handling ( #42664 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-26 21:36:41 +02:00
trop[bot]
156dbd57ba
docs: fix typo in ASAR integrity docs ( #42625 )
...
Fix typo in ASAR integrity docs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Corbin Crutchley <git@crutchcorn.dev >
2024-06-24 11:53:23 +02:00
electron-roller[bot]
04b6a162ea
chore: bump chromium to 126.0.6478.114 (31-x-y) ( #42584 )
...
* chore: bump chromium in DEPS to 126.0.6478.114
* chore: update patches
* Fix decoration insets getting out-of-sync
https://chromium-review.googlesource.com/c/chromium/src/+/5636771
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-22 20:20:18 +02:00
trop[bot]
3e92b72aef
feat: expose system preferences to utility process ( #42598 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com >
2024-06-20 15:33:21 -04:00
trop[bot]
3d139fc424
fix: fetch-dependent interfaces in Web Workers ( #42597 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-20 15:31:01 -04:00
trop[bot]
82664bfdcc
fix: MessagePort closing unexpectedly with non-cloneable objects ( #42580 )
...
* fix: MessagePort closing unexpectedly with non-cloneable objects
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: handle serialization failure in parentPort
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-19 16:43:36 -04:00
trop[bot]
ddccf79f2d
chore: cherry-pick f8010390 from chromium ( #42570 )
...
* chore: cherry-pick f8010390 from chromium
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update .patches after trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-19 07:50:35 +02:00
trop[bot]
920391a85d
test: use longer timeout on contentTracing tests on WOA ( #42554 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-18 09:25:40 -05:00
trop[bot]
c7219bf9e3
chore: improve error message on failed SMApp register/unregister ( #42557 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-18 14:15:36 +02:00
trop[bot]
a4410e20a8
docs: add backticks around example URL ( #42543 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-06-17 20:32:31 -05:00
electron-roller[bot]
d061a0cadf
chore: bump chromium to 126.0.6478.61 (31-x-y) ( #42503 )
...
chore: bump chromium in DEPS to 126.0.6478.61
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-06-14 11:55:53 -05:00
electron-roller[bot]
e87b0b565a
chore: bump chromium to 126.0.6478.55 (31-x-y) ( #42458 )
...
* chore: bump chromium in DEPS to 126.0.6478.55
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-12 16:25:47 -05:00
trop[bot]
16e7e26a2b
docs(web-embeds): replace BrowserView ref with WebContentsView ( #42468 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2024-06-12 16:20:28 -05:00
trop[bot]
e4fd9da529
docs: clean up MAS submission guide ( #42466 )
...
* docs: clean up MAS submission guide
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* add info from osx-sign wiki
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-06-12 15:17:37 -05:00
trop[bot]
c519ee59b2
fix: don't observe WebUSB for in-memory partitions ( #42462 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-12 15:04:46 -05:00
trop[bot]
da6235ff55
docs: fix info admonitions in security.md ( #42464 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: voidfill <71205200+voidfill@users.noreply.github.com >
2024-06-12 13:50:45 -05:00
trop[bot]
8903eecbb6
build: add an option to skip the install-sysroot hooks ( #42444 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-06-12 09:58:11 -05:00
trop[bot]
68dfa0440a
fix: missing fetch-dependent interfaces in Node.js ( #42453 )
...
fix: missing fetch-dependent interfaces in Node.js
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-12 09:33:26 -05:00
trop[bot]
931f4b8dec
docs: update timelines for E32 ( #42452 )
...
docs: update timelines for e32
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: George Xu <george.xu@slack-corp.com >
2024-06-11 22:29:49 -05:00
trop[bot]
3e177536ba
fix: bad js-flags shouldn't crash the app ( #42441 )
...
* fix: bad js-flags shouldn't crash the app
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update shell/browser/javascript_environment.cc
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-11 12:10:42 -05:00
trop[bot]
2633298855
build: fix generate_gn_filenames_json.py ( #42427 )
...
build: fix generate_gn_filenames_json.py
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-11 08:31:09 -05:00
trop[bot]
f272c5fb98
fix: multiple selection in //shell_dialogs Portal/KDE implementations ( #42424 )
...
* fix: multiple selection in //shell_dialogs portal implementation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: allow multiple directory selection in KDE implementation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-10 11:34:47 -05:00
trop[bot]
9ab67cc2f6
fix: restore wasOpenedAtLogin functionality ( #42422 )
...
fix: restore opened at login functionality
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-10 11:34:21 -05:00
trop[bot]
8035effa1a
fix: iframe.contentWindow.document.fonts resolution ( #42385 )
...
fix: iframe.contentWindow.document.fonts resolution
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-06-10 11:34:02 -05:00
trop[bot]
038e261069
feat: Allow WebContentsView to accept webContents object. ( #42319 )
...
feat: Allow WebContentsView to accept webContents object
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Krzysztof Halwa <krzysztofhalwa@outlook.com >
2024-06-10 07:41:12 -07:00
trop[bot]
0d12131f50
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42372 )
...
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed (#42353 )
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org >
2024-06-10 07:40:53 -07:00
trop[bot]
993d3331fa
refactor: improve cookie failure rejection messages ( #42400 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-07 13:01:23 -05:00
trop[bot]
5f78c626d1
fix: utilityProcess exit codes ( #42397 )
...
* fix: utilityProcess exit codes
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: retain disconnect_with_reason_handler
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: move node::Environment check to CallMethodWithArgs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: address feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-07 15:44:55 +02:00
trop[bot]
2021c2e8e9
fix: loginService -> loginItemService ( #42404 )
...
fix: loginService -> loginItemService
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-07 15:30:14 +02:00
Shelley Vohr
52bc1dc085
build: fix depot_tools patch ( #42401 )
2024-06-07 12:21:02 +02:00
electron-roller[bot]
540d88f809
chore: bump chromium to 126.0.6478.36 (31-x-y) ( #42167 )
...
* chore: bump chromium in DEPS to 126.0.6468.2
* chore: bump chromium in DEPS to 126.0.6478.4
* chore: bump chromium in DEPS to 126.0.6478.9
* chore: bump chromium in DEPS to 126.0.6478.8
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
(cherry picked from commit 01bbc6b9609954e6f5e8ed2d7c5864e6f2a7929b)
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
(cherry picked from commit 284bbbdf86d640cfbe27831524a7cefa1f0ec344)
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
(cherry picked from commit 41acddd97e2f4f79dba13a3916c1af46d47fa6f5)
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
(cherry picked from commit ffc88b3b2a7bee830a1e78b64afb6dfe6aff7347)
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
(cherry picked from commit 5a48cf6952f0c3fde8a4d2b717ac5b2d50d13671)
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
(cherry picked from commit 8deba32e729d3ded310be6645a27a78458046d69)
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
(cherry picked from commit 7aef2f0ad890bb778fa8843bd262daf6909c5f52)
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
(cherry picked from commit 368eb3924a3b9b58430c7340b930254a3db6f1a3)
* chore: update patches
(cherry picked from commit 9d6dac074b0f173e43d8e587edbe7de1565de3d6)
* chore: update patches
(cherry picked from commit fb4134d68204ea85a095d496b31216905f801878)
* update patches
(cherry picked from commit 6f6fff5b0b08c4cccdbc98950f8cbb399caf6340)
* only disable enterprise_cloud_content_analysis
(cherry picked from commit 5426d227ee5f4ce60ed3f1c863fe506ee706e78b)
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
(cherry picked from commit 2030447cf5bbce26b73e2e9b054dee38438f9fdd)
* chore: update patches
* chore: fixup patch
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5513528: Move service_provider_config files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5513528
* chore: bump chromium in DEPS to 126.0.6478.17
* chore: bump chromium in DEPS to 126.0.6478.26
* chore: update patches
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
(cherry picked from commit fccef2b6ba8769da9d8b1bd81fda5cc61b2086e0)
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
(cherry picked from commit e71852729fbf3575d1bc37774deadddfebdeefb4)
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
(cherry picked from commit ef0c441dbaa97478828ad481a39d0c2c93748729)
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
(cherry picked from commit 6f03785eadea8d8629970c24393f0900fc3fa4af)
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
(cherry picked from commit 4fd7f5bbb603b0461482fee027de7bfdbf02ceac)
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
(cherry picked from commit 4b5f43d7838062834de6d634033fe10af2f9d01a)
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
(cherry picked from commit 368005f2b2f9195bcffb5325041e3ff1041a3830)
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
(cherry picked from commit 142c6e16b10496b3fffddc9924001fb94096852e)
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
(cherry picked from commit 1e20ffb24ef6d0b0aeec8c314393cb77631ab279)
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
(cherry picked from commit ceb6182b199e2471c64700203bf42b73052a38c6)
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
(cherry picked from commit a11b8e637cdc0868b6152dd5b0ed3b582f446aa7)
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
(cherry picked from commit fc93c876b481a988a6c1d5eb69d97035dc5ad64a)
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
(cherry picked from commit fbfe3c998c8251f28b76c2703a3212b5b0175a84)
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
(cherry picked from commit ccf9a5137efdf2ca18d9ee9851388338c26d036e)
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
(cherry picked from commit fd3e6ce148b3c5ab27e234d28b9405933ba32b14)
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
(cherry picked from commit 9a900e734a8c08e534317ca4d7411bfadd9087f5)
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
(cherry picked from commit fd94de9736125c3121aed99f50f2702fc430ba26)
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
(cherry picked from commit 2abb5d1737083241b6b6a4c05d5982693e956a22)
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
(cherry picked from commit 11905a9840f1e8dce21cfdda1a23f328e8ff6a6a)
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
(cherry picked from commit e00faacb58545c37cfbf8a38a0cbe4ccb9f9df06)
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2 , was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ | https://chromium-review.googlesource.com/c/chromium/src/+/5527572
(cherry picked from commit b0e2a7eab6c0decf982f913a892d5dfdb2501084)
* chore: update patches
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
(cherry picked from commit ae65fea668baad44cac7073cbe0a64bca36bccac)
* views: use CalculatePreferredSize(SizeBounds) in '/chrome/browser/ui/views/[frame, infobars, /test]'.
https://chromium-review.googlesource.com/c/chromium/src/+/5493169
Needed because of 5504212: views: remove CalculatePreferredSize() | https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* fixup: views: use CalculatePreferredSize(SizeBounds)
* 5499157: Enable kBlockMidiByDefault by default
https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* 5518756: Reland^2: [heap] Add shared trusted spaces
| https://chromium-review.googlesource.com/c/v8/v8/+/5518756
ececfe7aea
* chore: bump chromium in DEPS to 126.0.6478.36
* chore: update patches
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
(cherry picked from commit bc35c93efd2d3301e33116d2dd09abaf8eddbf70)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-07 10:22:46 +02:00
trop[bot]
bd17a98386
fix: WebUSB should not crash when using in-memory partitions ( #42365 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-05 17:25:33 -04:00
trop[bot]
ea76144fa1
chore: cherry-pick 22db6918bac9 from chromium ( #42316 )
...
* chore: cherry-pick 22db6918bac9 from chromium
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-04 23:58:17 +02:00
electron-roller[bot]
9a879385c1
chore: bump node to v20.14.0 (31-x-y) ( #42295 )
...
* chore: bump node in DEPS to v20.13.1
* chore: bump node in DEPS to v20.14.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
https://github.com/nodejs/node/pull/52217
* test: skip test for dynamically linked OpenSSL
https://github.com/nodejs/node/pull/52542
* lib, url: add a `windows` option to path parsing
https://github.com/nodejs/node/pull/52509
* src: use dedicated routine to compile function for builtin CJS loader
https://github.com/nodejs/node/pull/52016
* test: mark test as flaky
https://github.com/nodejs/node/pull/52671
* build,tools: add test-ubsan ci
https://github.com/nodejs/node/pull/46297
* src: preload function for Environment
https://github.com/nodejs/node/pull/51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
https://github.com/nodejs/node/pull/52285
* chore: handle updated filenames
* events: extract addAbortListener for safe internal use
https://github.com/nodejs/node/pull/52081
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* fs: add stacktrace to fs/promises
https://github.com/nodejs/node/pull/49849
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-31 23:37:42 +02:00
trop[bot]
bd4d0ae2d3
fix: dialogs should work with BaseWindows internally ( #42326 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-31 20:56:29 +02:00
trop[bot]
fea722b621
docs: fix broken notification-spec markdown link ( #42309 )
...
* docs: fix broken notification-spec markdown link
Co-authored-by: IsmaelMartinez <ISMAELMARTINEZ@GMAIL.COM >
* docs: update notification-spec linkt to point to freedesktop
Co-authored-by: Ismael Martinez Ramos <ismael.martinez@postcodelottery.co.uk >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: IsmaelMartinez <ISMAELMARTINEZ@GMAIL.COM >
Co-authored-by: Ismael Martinez Ramos <ismael.martinez@postcodelottery.co.uk >
2024-05-30 11:06:16 +02:00
trop[bot]
b0ba1a2113
build: update NMV to 125 ( #42314 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: mlaurencin <mlaurencin@electronjs.org >
2024-05-29 14:54:15 -07:00
trop[bot]
420e834a31
docs: ensure all links are on a single line ( #42298 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-05-29 11:41:15 +02:00
trop[bot]
8edbefcfa3
fix: restore original BrowserWindow.show() behavior ( #42305 )
...
The new activate API on macOS is pretty bad, we should just keep using
the old API. Similar to #42180 . Restores non-panel behavior to pre-panel
support.
Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-29 11:39:46 +02:00
trop[bot]
e21c70a9e0
fix: fixed the type of WebviewTag.webpreferences ( #42279 )
...
fix: fixed the type of WebviewTag.webpreferences
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: EvolutionX <85353424+EvolutionX-10@users.noreply.github.com >
2024-05-26 21:48:31 +02:00
trop[bot]
6b86fb4bbb
fix: calculate a hash for the Tag property of ToastNotification. ( #42272 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
Co-authored-by: bill.shen <shenyb32768@gmail.com >
* fix: calculate a hash for the Tag property of ToastNotification.
Co-authored-by: bill.shen <shenyb32768@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-05-26 20:05:45 +02:00
Keeley Hammond
81c184ffc1
chore: cherry-pick 3e037e195e50 from v8 ( #42254 )
...
* chore: cherry-pick 3e037e195e50 from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-23 18:28:35 +02:00
Shelley Vohr
31a753ff7a
fix: setTitleBarOverlay should be implemented on BaseWindow ( #42150 )
2024-05-23 11:08:36 +02:00
trop[bot]
7ff3905120
fix: ensure showInactive actually shows ( #42227 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-20 15:34:48 -07:00
trop[bot]
18da367676
docs: fix broken anchors ( #42216 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-05-17 12:04:37 +02:00
trop[bot]
b029f38750
fix: win.center() on Windows ( #42197 )
...
fix: win.center() on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-16 10:15:54 -07:00
trop[bot]
e4bcd82590
fix: webContents.navigationHistory should be enumerable ( #42182 )
...
fix: webContents.navigationHistory should be enumerable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-15 10:49:24 +02:00
trop[bot]
a3c6dd9767
chore: remove focus ring patch ( #42188 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-05-14 17:44:51 -07:00
trop[bot]
c2540f555c
fix: restore non-panel focus behavior ( #42186 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-14 17:44:38 -07:00
trop[bot]
a0500a5faa
fix: fix cast in ElectronDesktopWindowTreeHostLinux ( #42184 )
...
Fix cast in ElectronDesktopWindowTreeHostLinux
The frame view of the widget is an `ClientFrameViewLinux` instance only
when both `frame` and `client_frame` booleans are set to `true`.
Otherwise it is an instance of a different class and thus casting to
`ClientFrameViewLinux` is incorrect and leads to crashes.
Fix : #41839
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <indutny@signal.org >
2024-05-14 17:33:49 -07:00
Keeley Hammond
ebf09b587b
chore: cherry-pick b3c01ac1e60a from v8 ( #42173 )
...
* chore: cherry-pick b3c01ac1e60a from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 12:50:36 -07:00
trop[bot]
41feba221d
build: update appveyor image to latest version ( #42155 )
...
* build: update appveyor image to latest version
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 14:26:13 +02:00
Keeley Hammond
bd900fb10f
chore: update patches after #42126 was merged ( #42156 )
...
chore: update patches after focus ring was merged
2024-05-13 16:36:32 -07:00
trop[bot]
ea3001dd39
test: add tests for electron fuses ( #42147 )
...
* spec: add tests for electron fuses
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* spec: fix tests for windows
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* spec: handle weird crash codes on win32
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* spec: disable fuse tests on arm64 windows
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-13 13:36:03 -07:00
trop[bot]
7294c766ac
fix: partially revert invalidate focus ring ( #42146 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2024-05-13 12:11:58 -07:00
trop[bot]
fb9d3ec897
chore: bump chromium to 126.0.6445.0 (31-x-y) ( #42119 )
...
* chore: bump chromium to 126.0.6445.0 31-x-y
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update .patches after trop
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 20:19:31 +02:00
trop[bot]
75cefdb527
fix: BrowserView autoresizing conversion error ( #42138 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-13 16:59:43 +02:00
trop[bot]
9694e7593f
docs: improve protocol.handle file examples ( #42142 )
...
* docs: improve protocol.handle file examples
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: fix lint
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-05-13 16:59:34 +02:00
trop[bot]
8d41e6ea9b
fix: View reordering on re-addition to same parent ( #42116 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-13 11:48:51 +02:00
trop[bot]
e282ff6e4a
fix: ensure originalFs.promises.cp works ( #42134 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-13 10:25:48 +02:00
Keeley Hammond
282ffa10e5
chore: cherry-pick f320600cd1f4 from v8 ( #42121 )
2024-05-11 14:17:19 -07:00
trop[bot]
72d85e90ac
refactor: use //ui/shell_dialogs on Linux ( #42109 )
2024-05-10 11:31:48 +02:00
trop[bot]
2fc89a6b2c
fix: CHECK when adding view as its own child ( #42108 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-10 10:30:58 +02:00
trop[bot]
12bc4dc6c0
fix: BrowserWindow.center() should center relative to screen ( #42101 )
...
* fix: BrowserWindow.center() should center relative to screen
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: feedback from review & remove test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-05-09 10:43:41 +02:00
Samuel Attard
cdf508a734
chore: cherry-pick b2cc7b7ac538 from chromium ( #42095 )
...
* chore: cherry-pick b2cc7b7ac538 from chromium
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-08 14:29:58 -07:00
trop[bot]
1dd99250c3
docs: make corrections for BrowserViews since it is deprecated ( #42084 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Peter Xu <sysu.peter.hsu@gmail.com >
2024-05-08 13:09:39 +02:00
trop[bot]
d2cb956a75
docs: update formatting for mdx3 compatibility ( #42070 )
...
docs: update formatting for mdx3 compat
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-05-07 21:50:07 -05:00
trop[bot]
004ca01049
fix: avoid crash after upgrade on Linux ( #42062 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com >
2024-05-07 20:31:49 -04:00
trop[bot]
ec4ffa99b6
fix: requestFullscreen from WebContentsView ( #41995 )
...
fix: requestFullscreen from WebContentsView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-05-01 12:59:39 -04:00
trop[bot]
844265303c
fix: recentDocuments on macOS not working ( #41993 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-05-01 11:52:20 -04:00
trop[bot]
aee588b650
chore: fixup gn check when enable_pdf_viewer is false ( #42009 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-05-01 09:20:03 -04:00
trop[bot]
8f51e8fb5d
chore: disable tests that require nut.js ( #42010 )
...
* chore: disable tests that require nut.js
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! chore: disable tests that require nut.js
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-04-30 22:46:53 -04:00
trop[bot]
773777f209
refactor: address changes and fix errors in chrome://accessibility ( #41948 )
...
refactor: address changes and fix errors in chrome://accessibility
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-23 21:14:14 -05:00
trop[bot]
9437dd3ea8
docs: Windows typo in Tutorial document ( #41952 )
...
Update tutorial-6-publishing-updating.md
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: South Drifted <shiy2008@gmail.com >
2024-04-23 21:13:34 -05:00
trop[bot]
fb5ffd2876
fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer ( #41908 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* also fix shell.openExternal
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-04-23 15:12:46 -04:00
trop[bot]
2d36065a15
docs: correct the return value for canceled showSaveDialog ( #41947 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
2024-04-23 12:49:30 -04:00
trop[bot]
e19963b0ac
build: fixup codespaces on-create ( #41936 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-23 12:05:43 -04:00
trop[bot]
9c631ea744
fix: data corruption in protocol.handle ( #41932 )
...
* fix: data corruption in protocol.handle
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* slice instead of subarray
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-04-23 09:51:31 -04:00
trop[bot]
9ab77e77b1
fix: offscreen rendering does not paint after gpu process crashed ( #41924 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com >
2024-04-22 14:51:42 -04:00
trop[bot]
eb56416cb5
build: use latest devcontainer buildimage with codespaces ( #41922 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-22 11:10:18 -04:00
trop[bot]
703241e1e7
fix: EINVAL when spawning cmd files on Windows ( #41906 )
...
fix: EINVAL when spawning on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-22 09:48:43 -04:00
trop[bot]
0a8ed258da
build: enable Perfetto in Chromium ( #41910 )
...
* build: enable perfetto in Chromium
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* refactor: delete TracingControllerImpl
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: TraceObject isn't present when v8_use_perfetto is true
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: update lib/internal/http for perfetto
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: remove stray log
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-19 16:32:41 -04:00
trop[bot]
7ef5402599
chore: remove unused hash function ( #41886 )
...
Unused since e1e73fa #24115
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-04-18 09:42:47 -04:00
trop[bot]
a799513b2e
docs: update build docs,support Powershell on Windows ( #41882 )
...
* docs: update build docs,support Powershell on Windows
Co-authored-by: nashaofu <diaocheng@outlook.com >
* chore: fix capitalization
Co-authored-by: nashaofu <diaocheng@outlook.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: nashaofu <diaocheng@outlook.com >
2024-04-17 20:06:15 -04:00
James Yuzawa
bf754a3cae
fix: make window.flashFrame(bool) flash continuously on macOS ( #41391 )
...
fix: window.flashFrame to flash continuously on mac
This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest ) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest ) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos ).
2024-04-17 12:42:34 -04:00
electron-roller[bot]
7120c58297
chore: bump node to v20.12.2 (main) ( #41710 )
...
* chore: bump node in DEPS to v20.12.0
* chore: update build_add_gn_build_files.patch
* chore: update patches
* chore: bump node in DEPS to v20.12.1
* chore: update patches
* build: encode non-ASCII Latin1 characters as one byte in JS2C
https://github.com/nodejs/node/pull/51605
* crypto: use EVP_MD_fetch and cache EVP_MD for hashes
https://github.com/nodejs/node/pull/51034
* chore: update filenames.json
* chore: bump node in DEPS to v20.12.2
* chore: update patches
* src: support configurable snapshot
https://github.com/nodejs/node/pull/50453
* test: remove test-domain-error-types flaky designation
https://github.com/nodejs/node/pull/51717
* src: avoid draining platform tasks at FreeEnvironment
https://github.com/nodejs/node/pull/51290
* chore: fix accidentally deleted v8 dep
* lib: define FormData and fetch etc. in the built-in snapshot
https://github.com/nodejs/node/pull/51598
* chore: rebase on main
* chore: remove stray log
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Cheng <zcbenz@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-04-17 12:39:13 -04:00
Shelley Vohr
b118c70f77
refactor: fold silent print into settings ( #41873 )
...
* refactor: fold silent print into settings
* chore: feedback
2024-04-17 12:04:47 -04:00
electron-appveyor-updater[bot]
cdafe09ffb
build: update appveyor image to latest version ( #41871 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-04-17 10:51:13 -04:00
Charles Kerr
b428315c6d
perf: remove unnecessary .c_str() calls ( #41869 )
...
* perf: remove unnecessary c_str() call when invoking promise.RejectWithErrorMessage()
RejectWithErrorMessage() takes a std::string_view
* perf: remove unnecessary c_str() call when invoking Environment::SetVar()
the val arg to Environment::SetVar() takes a const std::string&
* refactor: use string_view variant of base::UTF8ToWide()
* perf: remove unnecessary c_str() call when instantiating a ScopedHString
ScopedHString has always taken a StringPiece
* refactor: use simpler invocation of base::make_span()
* perf: remove unnecessary c_str() call when calling base::CommandLine::HasSwitch()
HasSwitch() already takes a string_piece
* perf: remove unnecessary c_str() call when calling net::HttpResponseHeaders::AddHeader()
AddHeader() already takes a StringPiece arg
* perf: omit unnecessary str -> wstr -> str conversion in DesktopCapturer::UpdateSourcesList()
this conversion was made redundant by c670e38
2024-04-16 19:48:54 -04:00
electron-roller[bot]
c670e38b4b
chore: bump chromium to 125.0.6412.0 (main) ( #41610 )
...
* chore: bump chromium in DEPS to 124.0.6361.0
* chore: bump chromium in DEPS to 124.0.6363.0
* chore: update patches
Manually apply printing.patch w/no code changes due to upstream shear.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5349263
* chore: bump chromium in DEPS to 124.0.6365.0
* chore: bump chromium in DEPS to 124.0.6367.0
* update patches
* 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple
https://chromium-review.googlesource.com/c/chromium/src/+/5371735
* missed a MAS bit
* chore: update windows toolchain
5350823: New toolchain for Windows 11 10.0.22621.2428 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/5350823
* chore: bump chromium in DEPS to 125.0.6368.0
* fix patches
* chore: update patches
* 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2)
https://chromium-review.googlesource.com/c/chromium/src/+/5232401
* revert https://chromium-review.googlesource.com/c/chromium/src/+/5380898
* chore: bump chromium in DEPS to 125.0.6370.0
* build: use updated windows toolchain
* fix patches
* chore: update patches
* more pdf_util to components
* 5372414: [Extensions] Remove DispatcherDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5372414
* fix accessibility_ui patch
* chore: bump chromium in DEPS to 125.0.6372.0
* chore: bump chromium in DEPS to 125.0.6374.0
* chore: bump chromium in DEPS to 125.0.6376.0
* chore: bump chromium in DEPS to 125.0.6378.0
* chore: bump chromium in DEPS to 125.0.6379.3
* chore: update patches (+ MAS patch changes)
* chore: update patches
* 5381159: Cleanup media::KeySystemSupportObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5381159
* 5382233: Reland "Web `Speech to Text` with SODA backend"
https://chromium-review.googlesource.com/c/chromium/src/+/5382233
* chore: update `exclusive_access` patch
- 5367497: Add a metric for the website state when Fullscreen API is requested
- https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: add build dependency
5367497: Add a metric for the website state when Fullscreen API is requested
https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: bump chromium in DEPS to 125.0.6382.0
* chore: update libcxx filenames
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6384.0
* chore: remove old patch
* 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files
https://chromium-review.googlesource.com/c/chromium/src/+/5394039
* fix: remove deprecated errno constants in node/libuv
* 5362194: Return expected from ProcessMetrics CPU methods
https://chromium-review.googlesource.com/c/chromium/src/+/5362194
* 5383927: Add new Pickle factory functions with explicit ownership
https://chromium-review.googlesource.com/c/chromium/src/+/5383927
* 5373340: Simplify app-region/Draggable Region implementation
https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* 5386875: Cleanup printing preferences files
https://chromium-review.googlesource.com/c/chromium/src/+/5386875
* chore: update libc++ filenames
* fix: add enterprise buildflags dep
* chore: bump chromium in DEPS to 125.0.6386.0
* chore: add build dep
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6388.0
* chore: bump chromium in DEPS to 125.0.6390.0
* chore: update patches
* 4918014: preloading: Add NewTabPagePageLoadMetricsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/4918014
* 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API
https://chromium-review.googlesource.com/c/chromium/src/+/5401234
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* fixup! 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* fixup! chore: add build dep
* chore: remove dead code & dead patch
Was dealing with https://chromium-review.googlesource.com/c/chromium/src/+/5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514 ).
The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay!
* chore: bump chromium in DEPS to 125.0.6392.0
* chore: bump chromium in DEPS to 125.0.6393.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6394.0
* chore: bump chromium in DEPS to 125.0.6396.0
* chore: bump chromium in DEPS to 125.0.6397.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5100842
No code changes, but had to apply patch manually due to upstream code shear
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 2
* chore: silence "space before tab in indent" git rebase-apply warning
* chore: e patches all
* build: update all.gn to avoid FTBFS when disabling raw_ptr
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5371737
* Rename PdfService Mojo interface to PdfHost
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5411957
* chore: bump chromium in DEPS to 125.0.6398.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6400.0
* chore: update patches
* [media] Remove unused `GetSupportedKeySystems` from MediaClient
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5420247
* chore: update JSInjection::New call to match upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5403967
[Extensions] Wire up the renderer for multiple user script worlds
* 5362362: Derive display ID from monitor adapter ID instead of szDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/5362362
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* chore: add v8-sandbox.h to electron-node
* chore: update patches
* chore: update patches
* fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files
* chore: bump chromium in DEPS to 125.0.6412.0
* chore: update patches
* chore: node script/gen-libc++-filenames.js
* [FPF] Create Fingerprinting Protection ruleset service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5420158
* Add ExclusiveAccessPermissionManager
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5273787
* Preserve the PNG colorspace when decoding into a SkBitmap.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5421254
* chore: iwyu
* fix: abstract-socket compilation
* ci: bump container for node 20 support
* fixup! abstract-socket compilation
* fix: compiling nan specs
* chore: revert winreg version bump
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient
test suite. Should be revisited separately.
* ci: set node 20 for darwin x64 tests
* fix: broken patch export
* chore: cleanup mas_avoid_private_macos_api_usage.patch.patch
Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-04-15 18:10:32 -04:00
lauren n. liberda
6aa9a003c8
fix: stop using std::vector<const uint8_t> in ProcessingSingleton ( #41832 )
2024-04-15 10:32:48 -07:00
Shelley Vohr
2a6ad42113
chore: delete unused PrintPreviewMessageHandler ( #41841 )
2024-04-15 11:34:56 -04:00
lauren n. liberda
d80c5f8377
build: redundant regex character class in generate-config-gypi.py ( #41858 )
...
fix: redundant regex character class in generate-config-gypi.py
'\w' already includes '_'. solves a SyntaxWarning on python 3.12.
2024-04-15 11:33:55 -04:00
Erick Zhao
755f7d5ed0
docs: clarify before ready usage ( #41849 )
2024-04-15 10:38:58 -04:00
Cedrik Ewers
734395bea9
docs: use "id" instead of "label" for positions ( #41843 )
...
Co-authored-by: Cedrik Ewers <C.Ewers@beckhoff.com >
2024-04-14 17:10:09 -07:00
dependabot[bot]
75dae2e004
build(deps): bump tar from 6.1.13 to 6.2.1 in the npm_and_yarn group across 1 directory ( #41842 )
...
build(deps): bump tar in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [tar](https://github.com/isaacs/node-tar ).
Updates `tar` from 6.1.13 to 6.2.1
- [Release notes](https://github.com/isaacs/node-tar/releases )
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.13...v6.2.1 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-12 13:28:37 -07:00
Robo
b446ce7f22
fix: package <__assertion_handler> as part of libcxx headers ( #41830 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5208502
2024-04-12 23:50:03 +09:00
Mitchell Cohen
05fba85aa3
fix: do not activate app when showing a panel on Mac ( #41750 )
...
* fix: do not activate app when showing or focusing a panel on Mac
* restored panel activation test
2024-04-12 14:27:59 +02:00
Shelley Vohr
db11090e58
fix: silent printing default dpi on Windows ( #41811 )
2024-04-11 19:56:39 -04:00
Calvin
df22e62bf4
docs: update release timeline ( #41825 )
2024-04-11 19:37:47 -04:00
Erick Zhao
f8c832d80d
docs: update ASAR integrity tutorial ( #41828 )
...
* docs: document windows asar integrity
* docs: update ASAR integrity tutorial
* fix lint
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-04-11 13:41:58 -07:00
Shelley Vohr
344aba0838
feat: implement File System API support ( #41419 )
2024-04-10 22:06:47 +02:00
RoboSchmied
41ba963392
fix: typos in comment section of in_app_purchase.mm ( #41788 )
...
fix 2 typo
Signed-off-by: Michael Seibt <github@roboschmie.de >
2024-04-10 11:54:56 -04:00
Shelley Vohr
43a9f70d19
feat: support NODE_EXTRA_CA_CERTS ( #41689 )
...
* feat: support NODE_EXTRA_CA_CERTS
* chore: allow disabling NODE_EXTRA_CA_CERTS
* chore: call base::Environment::UnSetVar
* docs: link to fuses from env vars
* chore: update patch to match upstream
* docs: note enabled by default
* Update environment-variables.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-10 10:30:35 -04:00
Kaitlin Newson
0a7df0ef3d
docs: typo fix ( #41787 )
...
Typo fix
2024-04-10 10:25:13 +02:00
Shelley Vohr
38ef9a7690
refactor: move PDF viewer to OOPIF ( #41728 )
...
https://issues.chromium.org/issues/40268279
2024-04-09 19:59:48 -04:00
Shelley Vohr
ba3b647fd7
fix: WCO maximize button visibility when non-maximizable ( #41793 )
...
fix: WCO button visibility when non-maximizable
2024-04-09 13:14:29 +02:00
Jeremy Rose
76f7bbb0a8
fix: move BrowserWindow's WebContentsView to be a child of rootview ( #41256 )
2024-04-08 10:30:23 -07:00
Bruno Pitrus
22c149812c
build: add missing header for content::SyntheticGestureTarget ( #41789 )
...
IWYU: add missing header for `content::SyntheticGestureTarget`
GNU libstdc++ does not allow using std::unique_ptr on incomplete types,
leading to a compile error.
2024-04-08 18:17:00 +02:00
David Sanders
42164d7081
build: add Markdown lint check for unescaped angle brackets ( #41753 )
2024-04-04 14:50:35 -04:00
Calvin
3eb94b72ba
feat: Options parameter for Session.clearData API ( #41355 )
...
* feat: Options parameter for `Session.clearData` API
* Consolidate & curate data type categories
* Update docs for better typing
* off-by-one typo
* refactor to use `std::shared_ptr` instead of `base::RefCounted`
* fix compile errors
* std::enable_shared_from_this didn't work 🤷
* Refine docs with defaults
2024-04-01 12:09:01 -04:00
Keeley Hammond
752f2eb124
build: add GH Actions to release-build script ( #41639 )
...
* build: add GH Actions to release-build script
* Update script/release/ci-release-build.js
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-01 10:02:26 -04:00
Shelley Vohr
beafbfd511
build: combine ImportModuleDynamically patches ( #41712 )
...
build: combine ImportModuleDynamically patches
2024-03-29 13:34:56 +01:00
dependabot[bot]
d54645e554
build(deps-dev): bump express from 4.18.2 to 4.19.2 ( #41716 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 16:12:14 -07:00
Shelley Vohr
0bf53a3876
fix: Storage.{get|set|clear}Cookies via CDP not working ( #41718 )
2024-03-28 16:09:27 -07:00
Shelley Vohr
62d4b21819
test: disable flaky <webview>.capturePage() specs ( #41713 )
...
test: disable flaky <webview>.capturePage() specs
2024-03-28 22:37:14 +01:00
Shelley Vohr
61457c9498
feat(serial): allow Bluetooth ports to be requested by service class ID ( #41638 )
...
* feat(serial): allow Bluetooth ports to be requested by service class ID
* fix: bluetooth dependency
2024-03-28 18:23:13 +01:00
Jeremy Rose
c6102b9278
docs: add missing headers option to ClientRequest options ( #41723 )
2024-03-28 09:38:16 -07:00
daihere1993
72c2b9e862
fix: recognize 'undefined' header value in ClientRequest ( #41615 )
...
Co-authored-by: zowu <luke.wu@nokia-sbell.com >
2024-03-27 16:46:07 -07:00
Shelley Vohr
08241669bc
test: add tests for Storage Access API ( #41698 )
2024-03-27 19:52:24 +01:00
Samuel Attard
6e36153799
build: fix potential source of errors in issue workflow ( #41715 )
2024-03-27 09:50:55 -07:00
taoky
4f76fff978
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41691 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
2024-03-27 10:53:23 +01:00
Alice Zhao
c82ec0c72b
test: remove hardcoded url ( #41706 )
2024-03-27 10:53:02 +01:00
Alice Zhao
c57ce31e84
test: fix flaky tests in webContents.navigationHistory ( #41705 )
...
test: fix flaky tests by replacing real urls with data urls
2024-03-27 13:49:11 +09:00
Shelley Vohr
32b44aa5c8
fix: crash on extension unload when script validation finishes ( #41686 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5225796
2024-03-26 14:32:06 +01:00
Shelley Vohr
7032c0d03c
test: add test and api_feature definition for chrome.scripting.globalParams ( #41685 )
...
chore: add test and api_feature for chrome.scripting.globalParams
2024-03-26 12:33:47 +01:00
Erick Zhao
b9c4b27781
docs: backslash escape parametrized TypeScript types ( #41575 )
...
* docs: backslash escape parametrized TypeScript types
* missing instances
2024-03-25 11:19:44 +01:00
Shelley Vohr
8c427253b3
refactor: update gin_helper/function_template ( #41534 )
...
* refactor: update gin_helper/function_template
* fix: crash in Node.js Worker threads
2024-03-25 10:01:54 +01:00
Shelley Vohr
ed28ead8ac
fix: WTF-8 decoding issue in node:fs ( #41673 )
...
fix: WTF-8 decoding issue in node:fs
2024-03-24 20:39:37 +01:00
Piotr Płaczek
90a7e5acae
fix: normalize path before calling showItemInFolder and openPath ( #41642 )
...
* fix: normalize path before calling ShowItemInFolder
* fix: normalize path before calling OpenPath
2024-03-22 10:28:44 -04:00
Shelley Vohr
707b9a58cc
fix: app.setLoginItemSettings error getting swallowed by gin conversion ( #41647 )
...
* fix: errors getting swallowed by gin conversion
* fix: Windows build
* test: re-enable disabled test
2024-03-22 09:00:21 -04:00
Shelley Vohr
a32705fd30
test: add test for setJumpList arguments ( #41650 )
...
test: add test for setJumpList arguments
2024-03-21 19:01:54 -04:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41577 )
2024-03-21 14:59:23 -07:00
John Kleinschmidt
1036d824fe
ci: use CircleCI hosted macOS arm64 runners for testing ( #41649 )
2024-03-21 14:07:18 -04:00
Kenneth Gerald Hamilton
587b66acc1
docs: nodejs trademark policy link broken ( #41558 )
...
* Fix broken Trademark Policy link
* add durable link
Per codebyter: https://github.com/electron/electron/pull/41558#discussion_r1522938560
2024-03-21 10:25:35 -04:00
Shelley Vohr
040acaaf30
fix: support withFileTypes in fs.{readdir|readdirSync} ( #41627 )
...
fix: support withFileTypes in fs.{readdir|readdirSync}
2024-03-21 10:22:40 -04:00
David Sanders
dd3fd78e63
ci: automatically add the 'has-repro-gist' label ( #41646 )
...
ci: automatically add the 'has-gist-repro' label
2024-03-21 10:22:14 -04:00
Charles Kerr
61ddb1aa07
chore: bump pylint to 2.17 ( #41576 )
...
* build: bump pylint to 2.17
Xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345
* fix pylint consider-using-f-string warnings pt 1: use flynt for automated fixes
* fix pylint consider-using-f-string warnings pt 2: manual fixes
* fix pylint consider-using-with warnings
* fix pylint line-too-long warnings
* fix pylint unspecified-encoding warnings
* fix py lint consider-using-generator warning
* fixup! fix pylint unspecified-encoding warnings
* fix pylint line-too-long warnings
2024-03-21 09:48:23 -04:00
David Sanders
00da7279cb
ci: set issue status to triaged on status/{confirmed,reviewed} label ( #41645 )
2024-03-21 09:43:40 -04:00
electron-appveyor-updater[bot]
7609156ae1
build: update appveyor image to latest version ( #41617 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-20 11:50:10 -04:00
Shelley Vohr
66dec24e32
fix: serial-port-added should respect filters ( #41621 )
...
fix: serial-port-added should respect filters
2024-03-20 10:18:41 -04:00
Shelley Vohr
433d6c33d8
fix: missing badge text on Windows ( #41618 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5053607
2024-03-19 12:50:30 +01:00
Shelley Vohr
b02918883f
fix: support recursive readdir in Asar files ( #41582 )
2024-03-19 11:10:14 +01:00
Shelley Vohr
1cd7419718
build: work around ScreenCaptureKit bad feature flag parsing in Chromium ( #41622 )
2024-03-19 10:49:41 +01:00
Shelley Vohr
daecbb90fe
test: modify remote specs to allow skip or only ( #41620 )
2024-03-19 10:49:24 +01:00
electron-roller[bot]
193e162ec6
chore: bump chromium to 124.0.6359.0 (main) ( #41584 )
...
* chore: bump chromium in DEPS to 124.0.6355.0
* 5341411: view-transition: Ensure resources are cleaned up in all cases.
https://chromium-review.googlesource.com/c/chromium/src/+/5341411
* chore: fixup patch indices
* 5354013: Return nullopt on error from ProcessMetrics CPU measurements
https://chromium-review.googlesource.com/c/chromium/src/+/5354013
* chore: bump chromium in DEPS to 124.0.6357.0
* chore: update patches
* 5368769: Reland "[mojo] Use large worker for mojom_parser action"
https://chromium-review.googlesource.com/c/chromium/src/+/5368769
* 5336171: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5336171
* 5367334: [FS Shortcut] Refactor ExclusiveAccessManager
https://chromium-review.googlesource.com/c/chromium/src/+/5367334
* 5354161: Rename GeolocationManager to GeolocationSystemPermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5354161
* fixup: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
* chore: bump chromium in DEPS to 124.0.6359.0
* chore: update patches
* 5371370: [Extensions] Move core NativeHandler registration
https://chromium-review.googlesource.com/c/chromium/src/+/5371370
* 5370702: [Extensions] Introduce ShellExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5370702
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-15 14:03:42 -04:00
Fedor Indutny
3759e59bbd
fix: asan build on macos ( #41587 )
2024-03-15 13:06:43 +09:00
electron-appveyor-updater[bot]
41b2102d10
build: update appveyor image to latest version ( #41591 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-14 13:03:13 -04:00
Shelley Vohr
1bfd3e0631
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain ( #41538 )
...
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-14 09:50:52 +01:00
electron-appveyor-updater[bot]
122a2fd177
build: update appveyor image to latest version ( #41579 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-13 13:15:29 -04:00
Shelley Vohr
1840d7b7ee
fix: improve caption button appearance on Windows 11 ( #41561 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4428171
2024-03-13 10:58:48 -04:00
Shelley Vohr
6cb84ddbfb
test: disable transparency tests on macOS arm64 ( #41580 )
2024-03-13 15:05:10 +01:00
David Sanders
02020fbb63
build: update @electron/lint-roller to 1.11.1 ( #41522 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-13 11:14:10 +01:00
electron-roller[bot]
26752d3a06
chore: bump chromium to 124.0.6353.0 (main) ( #41566 )
...
* chore: bump chromium in DEPS to 124.0.6353.0
* chore: update patches
* 5365462: Add missing perfetto::Flow and TRACE_EVENT includes
https://chromium-review.googlesource.com/c/chromium/src/+/5365462
* 5356336: Ensure destruction of mojo channel when destructing KeySystemsImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5356336
* 5332839: [Extensions] Register NativeHandlers with the RendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5332839
* 5148827: Add permission types for keyboard lock and pointer lock [1/N]
https://chromium-review.googlesource.com/c/chromium/src/+/5148827
* 5358818: Revert "[object] Fast path for adding props with existing transition"
https://chromium-review.googlesource.com/c/v8/v8/+/5358818
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-13 09:44:49 +01:00
Shelley Vohr
80f34ecd2c
test: re-enable app.getGPUInfo() specs on Linux ( #41568 )
...
test: re-enable getGPUInfo() specs on Linux
2024-03-12 12:39:29 -04:00
Erick Zhao
2f133f5e28
docs: nativeImage api cleanup ( #41519 )
...
* docs: `nativeImage` api cleanup
* Update docs/api/native-image.md
* Update native-image.md
* Update docs/api/native-image.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Update link to app icon
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
2024-03-12 12:33:56 -04:00
electron-roller[bot]
150c2bcef9
chore: bump chromium to 124.0.6351.0 (main) ( #41514 )
...
* chore: bump chromium in DEPS to 124.0.6339.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6341.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6343.0
* chore: bump chromium in DEPS to 124.0.6345.0
* chore: update patches
* build: temporarily patch out usage of reclient inputs cfg
* chore: implement missing OnPortConnectedStateChanged
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5039155
* fix: move NativeHandlers in extensions to new RendererAPIProvider
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5332839
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5334058
* chore: add missing websocket method
* refactor: use std::erase instead of base::Erase
Ref: https://issues.chromium.org/issues/40256229
* build: fix reclient inputs processor bug (workaround)
* fix: delay extensions::Dispatcher construction
* chore: bump chromium in DEPS to 124.0.6347.0
* chore: bump chromium in DEPS to 124.0.6349.0
* 5326217: [ViewsAX] Remove WebAXPlatformTreeManagerDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5326217
* 5347916: Get origin from parent for process-isolated srcdoc.
https://chromium-review.googlesource.com/c/chromium/src/+/5347916
* chore: patches fixup
* 4866222: [api] Deprecate vector<v8::Local>, part 1
https://chromium-review.googlesource.com/c/v8/v8/+/4866222
* 5337304: Remove DXDiag telemetry code.
https://chromium-review.googlesource.com/c/chromium/src/+/5337304
* 5328275: Implement watermark routing to the BrowserView
https://chromium-review.googlesource.com/c/chromium/src/+/5328275
* [libc++] Rename __fwd/hash.h to __fwd/functional.h and add reference_wrapper
* chore: bump chromium in DEPS to 124.0.6351.0
* chore: update patches
* 5342763: [object] Fast path for adding props with existing transition
https://chromium-review.googlesource.com/c/v8/v8/+/5342763
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-12 10:15:41 +01:00
Shelley Vohr
1252f92431
chore: remove 8088 from codespaces port forwarding ( #41557 )
2024-03-10 18:18:56 +01:00
electron-appveyor-updater[bot]
c0f9d0eeed
build: update appveyor image to latest version ( #41523 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-08 14:32:08 -05:00
Felix Rieseberg
4ec4efd3e5
docs: Update code signing documentation ( #41535 )
2024-03-08 10:02:39 -08:00
John Kleinschmidt
fb1b5ca4ce
test: disable CapturableScreen tests on Windows x64 ( #41543 )
...
* test: disable CapturableScreen tests on Windows x64
* test: disable js-execute-iframe" case should not crash on win 32-bit
2024-03-07 19:17:39 -05:00
Shelley Vohr
f826506218
fix: chrome://process-internals failing to load ( #41476 )
...
fix: chrome://process-internals failing to load
2024-03-07 15:31:16 +01:00
Shelley Vohr
62331f5ac1
chore: add missing gin::Wrappable GetTypeName overrides ( #41512 )
...
chore: add missing gin::Wrappable GetTypeName overrides
2024-03-06 12:45:28 +01:00
Shelley Vohr
a7d664e3a3
fix: user-did-{resign|become}-active events on macOS ( #41506 )
...
fix: user-did-{resign|become}-active events on macOS
2024-03-06 12:43:39 +01:00
Shelley Vohr
62a897b75b
chore: fix fs overrides for asar ( #41507 )
...
fix: fs overrides for asar
2024-03-06 10:39:30 +01:00
Shelley Vohr
cc7e80c4e3
docs: correct release timeline inaccuracy ( #41510 )
...
docs: correct timeline inaccuracy
2024-03-05 10:49:21 -08:00
electron-roller[bot]
9f673c859d
chore: bump chromium to 124.0.6331.0 (main) ( #41474 )
...
* chore: bump chromium in DEPS to 124.0.6329.0
* chore: update patches
* 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5321532: [//ui] Remove ContextFactory::SharedMainThreadContextProvider() | https://chromium-review.googlesource.com/c/chromium/src/+/5321532
* fixup! 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5319141: [OOPIF PDF] Create PdfNavigationThrottle for main frame navigations | https://chromium-review.googlesource.com/c/chromium/src/+/5319141
* test: disable webview.capturePage test for mac arm64
* chore: bump chromium in DEPS to 124.0.6337.0
* chore: update patches
* build: roll back DEPS to 124.0.6331.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-03-05 11:47:48 -05:00
Jeremy Rose
e67ab9a93d
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #41326 )
2024-03-04 09:32:40 -08:00
Cheng Zhao
814ba71dc1
chore: update src_preload_function_for_environment.patch ( #41500 )
2024-03-04 13:11:14 +01:00
David Sanders
cc9e21c260
build: update appveyor image to latest version ( #41483 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-01 15:54:10 -05:00
David Sanders
9565b7de74
chore: set wg-releases as CODEOWNER for AppVeyor configs ( #41485 )
2024-03-01 15:53:30 -05:00
Shelley Vohr
d5912fd05a
fix: webContents.print options should be optional ( #41467 )
2024-02-29 10:19:44 -05:00
Krzysztof Halwa
a0dad83ded
feat: Allow creation of new window to be customizable. ( #41432 )
2024-02-29 10:15:01 -05:00
electron-roller[bot]
04df5ce492
chore: bump chromium to 124.0.6323.0 (main) ( #41412 )
...
* chore: bump chromium in DEPS to 124.0.6315.0
* chore: update patches
* 5279678: Stream AIDA responses
https://chromium-review.googlesource.com/c/chromium/src/+/5279678
* 5276439: Remove non_network_url_loader_factory_remotes_
https://chromium-review.googlesource.com/c/chromium/src/+/5276439
* 5310165: Add DevTools API to show search results
https://chromium-review.googlesource.com/c/chromium/src/+/5310165
* chore: bump chromium in DEPS to 124.0.6317.0
* chore: update patches
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
https://chromium-review.googlesource.com/c/chromium/src/+/5314269
* browser: Make cmd line non-const in process singleton callback
https://chromium-review.googlesource.com/c/chromium/src/+/5311256
* chore: bump chromium in DEPS to 124.0.6319.0
* chore: bump chromium in DEPS to 124.0.6321.0
* chore: bump chromium in DEPS to 124.0.6323.0
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
https://chromium-review.googlesource.com/c/chromium/src/+/5318335
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
https://chromium-review.googlesource.com/c/chromium/src/+/5318051
* chore: fixup patch indices
* 4946553: Delegate HID permission to Chrome App in webview
https://chromium-review.googlesource.com/c/chromium/src/+/4946553
* 5310001: DevTools UI binding for reporting client events to AIDA
https://chromium-review.googlesource.com/c/chromium/src/+/5310001
* [libc++] Refactor the predicate taking variant of `__cxx_atomic_wait`
* chore: fix browser_view patch harder
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
https://chromium-review.googlesource.com/c/chromium/src/+/5293937
* fix: filter {video|audio} devices by eligible device id
* 5267921: enable speak content under the pointer on PWA and WV2
https://chromium-review.googlesource.com/c/chromium/src/+/5267921
* 5310195: heap: Remove Blink's GCTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/5310195
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-29 10:31:13 +01:00
David Sanders
13e601e35c
ci: verified commits for appveyor update PR ( #41470 )
2024-02-28 21:36:56 -08:00
Calvin
a6133e85d1
test: disable flaky macOS panel test & refactor screen capture testing ( #41441 )
...
* Disable flaky test
* Add helper for storing test artifacts
* Refactor screen capture tests
We have a pattern for inspecting a screen capture, so this refactor codifies that pattern into a helper. This gives us shorter test code, consistency (previously, the display in test code and the display captured could theoretically be different), and better debugging/observability on failure.
2024-02-28 12:54:20 +09:00
John Kleinschmidt
267c0796dd
ci: add logging to uploading to GitHub releases ( #41453 )
2024-02-27 19:55:08 -05:00
Shelley Vohr
b468b5e6e8
build: print error and retry on symstore fail ( #41452 )
2024-02-27 15:40:42 -08:00
Shelley Vohr
d89ad1106f
chore: add engflow-reclient-configs to gitignore ( #41447 )
2024-02-27 15:39:41 -08:00
Milan Burda
3885011220
chore: remove deprecated inputFieldType ( #41239 )
...
chore: remove deprecated inputFieldType
2024-02-26 07:47:16 -05:00
Milan Burda
3394ee71f0
chore: fix import from patches.py in script/lib/git.py ( #41430 )
2024-02-26 11:36:30 +09:00
Calvin
12d7a8ff66
feat: Session#clearData API ( #40983 )
...
* WIP: Session.clearBrowsingData API
* impl API method
* clean up
* tidy types and comments
* add docs
* add barebones test
* forgot a `#` :(
* tidy: address review comments
* use format macro for cross-platform build
* add another test
* amend docs to disambiguate
* Rename to `clearData`
2024-02-26 09:39:17 +09:00
Shelley Vohr
e95673b052
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} ( #41400 )
...
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
2024-02-23 10:35:20 +01:00
Robo
26131b23b8
feat: add support for configuring system network context proxies ( #41335 )
...
* feat: add support for configuring system network context proxies
* chore: add specs
* chore: fix lint
* fix: address review feedback
2024-02-22 12:08:25 -05:00
Shelley Vohr
136762b45f
build: don't modify deps/v8/tools paths ( #41386 )
...
build: don't modify deps/v8/tools paths
2024-02-22 11:35:06 -05:00
github-actions[bot]
d73a937375
build: update appveyor image to latest version-e-123.0.6312.5 ( #41408 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-22 11:10:52 -05:00
Samuel Attard
ddd93529d5
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher ( #41397 )
...
This fixes a nasty warning / permission dialog that pops up to end-users
when consuming legacy APIs. Chrome has flipped these flags via field trials
as have other Electron apps. It should just be the default.
2024-02-21 12:59:49 -08:00
electron-roller[bot]
e72f4f7f26
chore: bump chromium to 123.0.6312.5 (main) ( #41337 )
...
* chore: bump chromium in DEPS to 123.0.6300.2
* chore: bump chromium in DEPS to 123.0.6301.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6302.0
* chore: bump chromium in DEPS to 123.0.6304.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6306.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6308.0
* chore: update patches
* Refactor //components/pdf/common constants
https://chromium-review.googlesource.com/c/chromium/src/+/5292816
* Rename URLLoaderFactoryParams::is_corb_enabled to is_orb_enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5277040
* Add placeholder of speaker-selection permission.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5278243
* Move kPdfMimeType to //components/pdf/common/constants.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293155
* chore: gen-libc++-filenames.js
* Make GetClassName non virtual
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293075
Refs https://issues.chromium.org/issues/324596267
* chore: bump chromium in DEPS to 123.0.6310.0
* chore: update filenames.libcxx.gni
* 5282732: Compute input region using correct pixel size.
https://chromium-review.googlesource.com/c/chromium/src/+/5282732
* fixup: Make GetClassName non virtual
* chore: bump chromium in DEPS to 123.0.6312.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6312.5
* fixup: Make GetClassName non virtual
* docs: document speaker-selection
https://chromium-review.googlesource.com/c/chromium/src/+/5278243
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-02-21 15:27:05 -05:00
Keeley Hammond
f350cce64f
docs: update breaking changes language ( #41387 )
2024-02-21 11:25:53 -08:00
Keeley Hammond
94e643ab33
build: bump NMV to 123 for Electron 30 ( #41370 )
2024-02-21 10:02:36 -08:00
electron-roller[bot]
e87746ff0f
chore: bump node to v20.11.1 (main) ( #41353 )
...
* chore: bump node in DEPS to v20.11.1
* chore: update patches
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-21 12:49:20 -05:00
Keeley Hammond
136d7e7e6a
fix: check for draggable regions outside of main frame ( #41377 )
2024-02-20 19:10:43 -08:00
Charles Kerr
7cd23a4900
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient() ( #41347 )
...
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient()
- (perf) GetBlinkPreferences() returns a const&, so we can use that
reference instead of making a temporary copy
- (perf) Don't create url object unless it's needed.
- (refactor) Move is_main_world() and is_isolated_world() from the
header into an anonymous namespace in the .cc file so they can
be inlined and made constexpr
2024-02-20 13:29:11 +01:00
Keeley Hammond
995f3dc120
fix: revert to legacyMainResolve in JavaScript for asar compatibility ( #41367 )
2024-02-18 23:21:13 -08:00
Keeley Hammond
d0b4489b7d
ci: fix helperPath calls in ci configs ( #41363 )
...
* ci: fix helperPath calls in ci configs
Co-authored-by: codebytere <codebytere@electronjs.org >
* ci: fix helperPaths harder
---------
Co-authored-by: codebytere <codebytere@electronjs.org >
2024-02-17 15:04:36 -08:00
Michaela Laurencin
ca0920872d
chore: update breaking-changes.md to reflect WebContentsView revert ( #41361 )
2024-02-17 09:20:53 -08:00
Henrik Gaßmann
80906c0adb
fix: properly stream uploadData in protocol.handle() ( #41052 )
...
* refactor(protocol): extract file stream factory
Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
* fix: properly flatten streams in `protocol.handle()`
Refs: electron/electron#39658
* fix: `protocol.handle()` filter null origin header
Refs: electron/electron#40754
* fix: remove obsolete TODO comment
Refs: electron/electron#38929
* fix: forward `Blob` parts in `protocol.handle()`
Refs: electron/electron#40826
* fix: explicitly error out on unknown chunk parts
2024-02-16 14:29:29 -05:00
Shelley Vohr
d4413a8e53
chore: remove unused anonymous namespace methods ( #41333 )
2024-02-16 10:31:34 -06:00
Calvin
0356812026
docs: update release schedule for E30 ( #41339 )
2024-02-15 12:38:07 -08:00
github-actions[bot]
6acacf061c
build: update appveyor image to latest version - e-123.0.6296.0. ( #41350 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-15 14:56:41 -05:00
Samuel Attard
7d6a754d47
fix: skip the first two invalid updates when SCK is enabled ( #41340 )
2024-02-14 11:56:29 -08:00
electron-roller[bot]
0dad99561b
chore: bump chromium to 123.0.6296.0 (main) ( #41204 )
...
* chore: bump chromium in DEPS to 123.0.6273.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6274.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6276.0
* chore: update patches
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* chore: bump chromium in DEPS to 123.0.6278.0
* chore: bump chromium in DEPS to 123.0.6280.0
* chore: update patches
* chore: use net::CanonicalCookie::SecureAttribute()
renamed from IsSecure()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
* refactor: handle multiple requested device ids
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5132210
* refactor: trigger View layouts async with View::InvalidateLayout()
Upstream has introduced a PassKey to restrict who can call Layout()
directly. I've opted for calling `InvalidateLayout()` which is the
approach that upstream recommends.
If for some reason this approach doesn't work for us, we could use
`DeprecatedLayoutImmediately()` as a stopgap.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Xref: https://chromium.googlesource.com/chromium/src/+/main/ui/views/view.h#809
Xref: https://chromium.googlesource.com/chromium/src/+/main/docs/ui/learn/bestpractices/layout.md?pli=1#don_t-invoke-layout_directly
* chore: bump chromium in DEPS to 123.0.6282.0
* chore: bump chromium in DEPS to 123.0.6284.0
* chore: update patches
* refactor: remove use of blink::MainThreadIsolate() pt 1/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 2/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 3/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* chore: update enum name to ui::AXMode::kPDFPrinting
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5270301
* chore: rebuild filenames.libcxx.gni
* chore: sync with upstream rename of PortProvider.TaskForHandle()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5259103
* chore: bump chromium in DEPS to 123.0.6286.0
* chore: bump chromium in DEPS to 123.0.6288.0
* WebPreferences: Initialize in declaration.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5277099
* chore: update webview_fullscreen.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5053508
Simple update to fix patch shear
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5254861
Simple update to fix patch shear
* chore: add IWC::Delegate::RecordResize() stub to fix FTBFS
https://chromium-review.googlesource.com/c/chromium/src/+/5268963
* chore: add FormControlType::kButtonPopover to the FormControlType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
* chore: e patches all
* chore: node script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 123.0.6290.0
* chore: bump chromium in DEPS to 123.0.6291.0
* chore: bump chromium in DEPS to 123.0.6292.0
* chore: bump chromium in DEPS to 123.0.6294.0
* chore: update fix_aspect_ratio_with_max_size.patch
Xref: fix_aspect_ratio_with_max_size.patch
note: simple absl::optional -> std::optional conversion
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5272337
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; just adjusting line patch offsets
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5258688
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5281322
* chore: update fix_select_The_first_menu_item_when_opened_via_keyboard.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5279376
note: simple absl::optional -> std::optional conversion
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5268792
* chore: script/export_all_patches.py
* chore: bump chromium in DEPS to 123.0.6296.0
* chore: update patches
* fixup! chore: update feat_allow_code_cache_in_custom_schemes.patch
* fix: restore MessagePort close event
* spec: fix CORB testing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5231506
* fix: use sync layout when content view changes
* fixup! chore: update feat_configure_launch_options_for_service_process.patch
* Add remote-cocoa support for context menus.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5259806
* Rename //net/base/mac directory to //net/base/apple (1/n)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5211389
* fixup! Add remote-cocoa support for context menus.
* [Clipboard] Don't add meta charset tag for async write() method on Mac.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5187335
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-02-14 12:33:32 -05:00
David Sanders
7e241eef7c
ci: update GitHub actions workflow dependencies ( #41321 )
2024-02-14 11:13:03 +01:00
Mikhail Leliakin
79147e4dd8
fix: Ignore -webkit-app-region: drag; when window is in full screen mode. ( #41307 )
...
Co-authored-by: Mikhail Leliakin <lelyakin.aus@gmail.com >
2024-02-14 11:12:41 +01:00
Samuel Attard
32920af4b7
fix: add capability to use ScreenCaptureKit for thumbnail generation ( #41328 )
...
This aligns us with Chromiums flags / capabilities in regards to using SCK for
everything. Currently on 14.4 Electron apps will pop warnings for usage of
deprecated APIs. With this change and a few "enable-features" toggles.
`--enable-features="ScreenCaptureKitMac,ScreenCaptureKitStreamPickerSonoma,ThumbnailCapturerMac:capture_mode/sc_screenshot_manager"`
As Chromium enables these by default Electron will inherit those changes, apps wishing to skip ahead can apply these flags early.
2024-02-13 20:46:51 -08:00
Shelley Vohr
0218af9af0
fix: work around unarchivedObjectOfClass requiring secureCoding ( #41319 )
2024-02-13 19:08:03 -08:00
Charles Kerr
6a616ab70c
feat: allow custom refs for patch import & export ( #41306 )
...
* feat: allow custom refs for patch import & export
feat: add Patch-Dir metainfo, a sibling to Patch-Filename
* chore: copyediting
* refactor: minor copyediting
2024-02-12 10:05:53 -06:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54 .
2024-02-12 09:35:34 +01:00
Shelley Vohr
4ded4d16a8
fix: destroy NodeService message pipe last ( #41277 )
...
refactor: destroy NodeService message pipe last
2024-02-09 22:44:35 +01:00
Shelley Vohr
c894645ac6
fix: crash on macOS non-programmatic close ( #41264 )
2024-02-09 22:44:24 +01:00
Charles Kerr
9655ae7d6a
fix: GetCursorScreenpoint() sometimes wrongly returns (0,0) ( #41275 )
2024-02-09 09:44:46 -06:00
Charles Kerr
cee51785e1
refactor: inline simple getters, pt . 2 ( #41254 )
...
* refactor: inline AutofillPopup::line_count()
refactor: inline AutofillPopup::value_at()
refactor: inline AutofillPopup::label_at()
* refactor: inline NativeWindow::aspect_ratio()
refactor: inline NativeWindow::aspect_ratio_extra_size()
* refactor: inline BrowserProcessImpl::linux_storage_backend()
* refactor: inline ElectronMenuModel::sharing_item()
* refactor: inline Browser::badge_count()
* refactor: inline WebContents::is_guest()
refactor: inline InspectableWebContents::is_guest()
* refactor: inline InspectableWebContents::dev_tool_bounds()
* refactor: inline WebContents::type()
2024-02-09 10:29:14 +01:00
Charles Kerr
b253d52faf
build: export matching patches ( #41174 )
...
* build: make patches/config.json an array of objects
This file was previously an object of patch_dir keys to repo values;
Now is an array of objects containing `patch_dir` and `repo` properties.
This makes other per-target properties (e.g. `grep`) possible.
* build: include Note metadata when exporting patches
* build: support keyword filtering in export_patches()
* build: add optional `--grep` arg to git-export-patches script
* build: update export_all_patches to understand new config file
* fixup! build: update export_all_patches to understand new config file
chore: make lint happy
* fixup! build: make patches/config.json an array of objects
chore: fix oops
* refactor: remove support for the old file format
There is more code using config.json than I thought, so the
effort-to-reward of supporting the old format is not worth it.
* build: update apply_all_patches to understand new config file
* build: update lint.js to understand new config file
* build: update patches-mtime-cache.py to understand new config file
* fixup! build: update apply_all_patches to understand new config file
fix: oops
* fixup! build: update apply_all_patches to understand new config file
fix minor syntax wart
* fixup! build: support keyword filtering in export_patches()
refactor: use idiomatic python
* refactor: warn if config.json has an invalid repo
2024-02-08 13:47:59 -05:00
github-actions[bot]
4d060afc98
build: update appveyor image to latest version ( #41206 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-08 15:01:05 +01:00
Shelley Vohr
8eb580e79a
docs: note EXIF data unsupported in nativeImage ( #41261 )
...
* docs: note EXIF data unsupported in nativeImage
* Update docs/api/native-image.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 14:59:46 +01:00
Bogdan Cerovac
42087e306c
fix: add language to html in quick-start.md ( #41225 )
...
Add language to html in quick-start.md
We must define language in HTML for different reasons (accessibility++)
2024-02-08 10:27:50 +09:00
Milan Burda
2ea569e0d2
docs: fix docs/api/base-window.md ( #41240 )
...
* docs: fix docs/api/base-window.md
* Update docs/api/base-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 10:13:48 +09:00
Felix Rieseberg
4367c5ad9e
docs: Properly document runAsNode utility process option ( #41255 )
...
* docs: Properly document runAsNode utility process option
* Update docs/api/utility-process.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-02-06 15:54:36 -08:00
Cheng Zhao
92c5ff30a7
build: add flag for setting vendor version ( #41247 )
2024-02-06 14:23:17 -08:00
Charles Kerr
5686f88bd2
refactor: KeyWeakMap cleanup ( #41242 )
...
* refactor: make KeyWeakMap::KeyObject private
* perf: avoid redundant map lookup
* refactor: remove unused KeyWeakMap::Has()
* refactor: make KeyWeakMap dtor nonvirtual
no inheritance used, so no need for virtual dtor?
* chore: fix KeyWeakMap code comment
* refactor: use if statement in KeyWeakMap::Get()
* refactor: use better variable names in KeyWeakMap::Values()
2024-02-06 09:18:05 -06:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded() ( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Charles Kerr
08236f7a9e
refactor: remove deprecated BrowserContext::ResourceContext ( #41221 )
...
* refactor: remove ResourceContext* arg from GetNSSCertDatabaseForResourceContext()
* refactor: remove ResourceContext* arg from CertificateManagerModel::GetCertDBOnIOThread()
* refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
* refactor: remove unused forward declarations
* refactor: rename method to GetNSSCertDatabase()
* fixup! refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
chore: remove unneeded line
2024-02-05 18:12:34 -06:00
Shelley Vohr
5dfa9e3317
fix: original-fs import replacement ( #41209 )
...
fix: original-fs import replacement
2024-02-05 09:51:04 +01:00
wujinli
fb888a6989
fix: crash problem with message_port close event ( #41201 )
...
When worker_thread shutdown, it will destory context and close
message_port. In this case, it should not dispatch close event.
Because it forbid script running during NotifyContextDestroyed in
ContextLifecycleNotifier.
Now chromium has implemented close_event and will not crash,
so we remove the patch with #22532 and add one test.
2024-02-05 16:38:30 +09:00
marekharanczyk
398ca2a019
fix: make sure invalid URL loads promises are fulfilled. ( #41194 )
...
* fix: make sure invalid URL loads promisses are fulfilled.
* fixup! fix: make sure invalid URL loads promisses are fulfilled.
2024-02-05 16:36:51 +09:00
Milan Burda
dac29f9949
refactor: type-safe module imports / requires ( #41192 )
2024-02-05 16:36:28 +09:00
Kilian Valkhof
3ec04fd449
docs: add note about fuses to our security documentation ( #41210 )
...
* Add note about fuses to our security documentation
Additionally, add the missing #18 to the ToC.
* lint issues for security.md
* Update docs/tutorial/security.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* move reference links to bottom of security.md
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-02-02 17:28:36 -06:00
Charles Kerr
2ebaebb603
refactor: replace use of deprecated base::JSONWriter::WriteJson() ( #41215 )
...
* refactor: use base::WriteJson() in ListValueToNSArray()
refactor: use base::WriteJson() in DictionaryValueToNSDictionary()
* refactor: use base::WriteJson() in Debugger::SendCommand()
* refactor: use base::WriteJson() in ScriptingExecuteScriptFunction::Run()
* refactor: use base::WriteJson() in HandleAccessibilityRequestCallback()
2024-02-02 12:25:58 -06:00
Sam Maddock
9bfa16ad7f
fix: typescript error for optional dependency ( #41202 )
2024-02-01 13:00:20 +09:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c )
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-01-31 17:04:13 -06:00
Sam Maddock
12870cafb7
fix: move nut-js to optional spec deps ( #41199 )
2024-02-01 07:35:09 +13:00
Shelley Vohr
e4d5dc138f
fix: select-usb-device should respect filters option ( #41166 )
...
fix: select-usb-device should respect filters option
2024-01-31 09:53:30 -05:00
Shelley Vohr
6df3443617
fix: validate printToPDF margins against pageSize ( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Sam Maddock
85bebfb180
test: draggable region allows moving window ( #41127 )
...
* chore: add nut.js
* test: dragging window updates position
* instantly move mouse position
* limit platforms to run drag tests on
* defer loading nut-js
2024-01-31 10:29:17 +01:00
Milan Burda
fb88375ab4
refactor: type-safe imports in lib/node/init.ts ( #41148 )
2024-01-31 08:38:56 +09:00
Charles Kerr
0e0a0bf724
fix: avoid potential CHECK() failure in DictionaryToRect() ( #41160 )
...
refactor: use gfx::Rect::Contains() instead of reinventing the wheel
perf: use base::Value::FindInt() to avoid redundant map lookups
2024-01-30 14:48:47 -06:00
Charles Kerr
08615b2d4e
refactor: simplify code by using base::Value::EnsureList() ( #41162 )
2024-01-30 14:48:09 -06:00
Shelley Vohr
90c7d6c823
fix: shouldPrintBackgrounds -> printBackground in webContents.printToPDF ( #41161 )
...
fix: shouldPrintBackgrounds -> printBackground
2024-01-30 14:47:55 -06:00
Shelley Vohr
6786fde576
docs: document printToPDF generateDocumentOutline option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Shelley Vohr
fc917985ae
fix: ensure WebContents before checking draggable region ( #41154 )
...
fix: ensure WebContents before checking draggable region
2024-01-30 11:53:19 +01:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
github-actions[bot]
4e19321ba8
build: update appveyor image to latest version ( #41134 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-29 14:12:59 -05:00
David Sanders
679a6589cd
chore: add extra links to issue template chooser ( #41135 )
2024-01-29 09:51:43 -05:00
Cheng Zhao
de76fc01ec
chore: fix outdated osk patch on main branch ( #41152 )
2024-01-29 15:35:33 +09:00
Cheng Zhao
2571396584
fix: update osk patch to fix more corner cases ( #41131 )
...
This is a follow up to https://github.com/electron/electron/pull/35921
that, it fixes more corner cases that on-screen-keyboard does not hide
for webviews.
This change has been applied in Teams for quite a while and should be
reliable enough to introduce to Electron.
2024-01-29 10:42:59 +09:00
Shelley Vohr
8104c7908a
fix: potential async_hooks crash in NotifyWindowRestore on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Cheng Zhao
db2bf1a0d1
fix: apply module search paths restriction on worker and child process ( #41118 )
2024-01-26 17:29:04 +09:00
electron-roller[bot]
6c9f9de40a
chore: bump chromium to 123.0.6264.0 (main) ( #41124 )
...
* chore: bump chromium in DEPS to 123.0.6264.0
* chore: update patches
* 5224145: Revert "Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'""
https://chromium-review.googlesource.com/c/chromium/src/+/5224145
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 18:57:47 -05:00
John Kleinschmidt
9e630eb66a
build: remove unneeded dlls in Windows zip ( #41120 )
...
* build: fixup zip manifest check on Windows
* build: remove unused dlls
2024-01-25 15:26:21 -05:00
electron-roller[bot]
1a0991a9b9
chore: bump chromium to 122.0.6261.6 (main) ( #40949 )
...
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* 5105227: [media_preview] Show requested device in permission bubble
https://chromium-review.googlesource.com/c/chromium/src/+/5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | https://chromium-review.googlesource.com/c/chromium/src/+/5190661
* 5206106: Make sure RenderFrameHosts are active when printing | https://chromium-review.googlesource.com/c/chromium/src/+/5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
https://chromium-review.googlesource.com/c/chromium/src/+/5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
https://chromium-review.googlesource.com/c/chromium/src/+/5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
https://chromium-review.googlesource.com/c/chromium/src/+/5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
https://chromium-review.googlesource.com/c/chromium/src/+/5171446
* 5213708: Move DownloadTargetInfo into components/download
https://chromium-review.googlesource.com/c/chromium/src/+/5213708
* extensions: Add a loader for Controlled Frame embedder scripts
https://chromium-review.googlesource.com/c/chromium/src/+/5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
https://chromium-review.googlesource.com/c/chromium/src/+/5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
https://chromium-review.googlesource.com/c/chromium/src/+/5170669
* 5178824: [Fullscreen] Record UKM data
https://chromium-review.googlesource.com/c/chromium/src/+/5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 12:46:30 -05:00
Charles Kerr
921da723b8
fix: dangling raw_ptr in OSRWHV destructor ( #41088 )
...
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`.
Since `delegated_frame_host_client_` was being destroyed first, that
pointer was dangling in the OSRWHV destructor.
Also, make these two unique_ptr fields `const` since they point to the
same objects for the lifespan of the OSRWHV.
2024-01-25 10:15:32 +09:00
Shelley Vohr
3e6a038af7
fix: draggable regions not working ( #41030 )
...
* fix: draggable regions not working
* fix: only support app regions for main frame
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-01-25 09:12:54 +09:00
Maikel Ortega Hernández
a05bfd332d
fix: on error, reset spawnedProcess ( #41033 )
...
reset spawnedProcess instance in case of error
2024-01-24 16:45:08 -06:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Cheng Zhao
d13a93fb61
chore: remove node patches by using the preload feature ( #41080 )
2024-01-24 09:54:32 -06:00
Cheng Zhao
031d636823
fix: only remove hijackable envs from foreign parent ( #41079 )
2024-01-24 09:51:27 -06:00
Max Schmitt
5ced88a90a
docs: update Playwright automated-testing guide ( #41081 )
2024-01-24 09:50:55 -06:00
Charles Kerr
1af9612edf
fix: ElectronBrowserContext::PartitionKey comparisons ( #41055 )
...
* fix: ElectronBrowserContext::PartitionKey comparisons
Use c++20 default comparisons to simplify + fix PartitionKey sorting:
- The equality operator is broken. `PartitionKey{"foo", false}` is both
equal, to and less than, `PartitionKey{"foo", true}`
- For some keys, the same session can be retrieved via both `fromPath()`
and `fromPartition()`. This use case was discussed and removed from
the original PR after code review said "always returning different
sessions feels lower maintenance." The current behavior is a bug that
comes from the comparison operators not checking the keys' types.
Xref: 3f1aea9af9 (r1099745359)
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed
* fixup! fix: ElectronBrowserContext::PartitionKey comparisons
2024-01-23 09:41:44 -06:00
Valerius Petrini
1300e83884
docs: fixed typos and grammatical errors ( #40966 )
...
* docs: fixed typos
* Update docs/tutorial/performance.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* Update performance.md
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-01-19 08:21:42 -06:00
Michaela Laurencin
03a3deca18
ci: add stale-exempt label to exempt issues from automation ( #41031 )
2024-01-18 16:57:49 -05:00
electron-roller[bot]
f4ee3c1b2a
chore: bump node to v20.11.0 (main) ( #40941 )
...
* chore: bump node in DEPS to v20.11.0
* module: bootstrap module loaders in shadow realm
https://github.com/nodejs/node/pull/48655
* src: add commit hash shorthand in zlib version
https://github.com/nodejs/node/pull/50158
* v8,tools: expose necessary V8 defines
https://github.com/nodejs/node/pull/50820
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* esm: fallback to readFileSync when source is nullish
https://github.com/nodejs/node/pull/50825
* vm: allow dynamic import with a referrer realm
https://github.com/nodejs/node/pull/50360
* test: skip test-diagnostics-channel-memory-leak.js
https://github.com/nodejs/node/pull/50327
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* lib: fix assert throwing different error messages in ESM and CJS
https://github.com/nodejs/node/pull/50634
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* deps: update base64 to 0.5.1
https://github.com/nodejs/node/pull/50629
* src: avoid silent coercion to signed/unsigned int
https://github.com/nodejs/node/pull/50663
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* chore: fix patch indices
* chore: update patches
* test: disable TLS cipher test
This can't be enabled owing to BoringSSL incompatibilities.
https://github.com/nodejs/node/pull/50186
* fix: check for Buffer and global definition in shadow realm
https://github.com/nodejs/node/pull/51239
* test: disable parallel/test-shadow-realm-custom-loader
Incompatible with our asar logic, resulting in the following failure:
> Failed to CompileAndCall electron script: electron/js2c/asar_bundle
* chore: remove deleted parallel/test-crypto-modp1-error test
* test: make test-node-output-v8-warning generic
https://github.com/nodejs/node/pull/50421
* chore: fixup ModuleWrap patch
* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream
* fix: sandbox is not enabled on arm
* chore: disable v8 sandbox on ia32/arm
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-18 16:16:45 -05:00
github-actions[bot]
6ea7da4b90
build: update appveyor image to latest version ( #40951 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-18 16:08:00 -05:00
Guo Hao (Andrew) Lay
135c542555
feat: Windows integrity check ( #40504 )
...
* Add Windows integrity check feature into Electron
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Add integrity checker header file to sources
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Moved integrity checker after checking command line args
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Revert previous Windows integrity check commits (2379a60 , 331cf3c , a3c47ec )
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Implement asar header integrity for Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Fix Archive::RelativePath() on Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Address comments.
* Address Windows integrity check PR comments.
* Update absl::optional to std::optional.
* Fix spelling.
---------
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
Co-authored-by: Weiyun Dai <weiyund@amazon.com >
Co-authored-by: Weiyun Dai <35878488+WeiyunD@users.noreply.github.com >
2024-01-19 09:00:49 +13:00
John Kleinschmidt
3dafb318a8
test: fixup assertNotWindows ( #41045 )
...
* chore: fixup assertNotWindows
* remove logging
2024-01-18 14:04:43 -05:00
Shelley Vohr
7e6fb97a2f
fix: crash when dialog.showMessageBoxSync with missing buttons ( #40996 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
* chore: feedback from review
2024-01-18 13:21:15 +01:00
Shelley Vohr
df7f07a8af
fix: modal rounding on nonmodal windows ( #41003 )
...
* fix: modal rounding on nonmodal windows
* chore: feedback from review
2024-01-18 09:59:54 +01:00
Tamás Zahola
f97d8719e6
fix: use HasStyleMask(NSWindowStyleMaskResizable) instead of IsResizable() for enabling/disabling window maximize button ( #40994 )
2024-01-17 18:23:41 +01:00
Charles Kerr
021592200e
refactor: remove deprecated ToInternalValue() ( #40980 )
...
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad()
* refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem()
* chore: rename temp variable to now_usec for clarity
2024-01-17 10:17:43 -05:00
Shelley Vohr
6803624576
fix: check for Node.js-created module when contextIsolation disabled ( #40993 )
2024-01-16 14:29:00 +01:00
Robo
4949c4c4e1
chore: fix building blink_tests target ( #40982 )
2024-01-16 12:24:14 +01:00
Shelley Vohr
61f619a5e6
ci: correctly export RBE_experimental_credentials_helper_args ( #40997 )
2024-01-15 19:48:10 +01:00
Charles Kerr
b3e01220cb
refactor: fix deprecated base::Base64Encode() API calls ( #40962 )
...
* refactor: replace deprecated Base64Encode() usage in IWC::NetworkResourceLoader::OnDataReceived()
* refactor: replace deprecated Base64Encode() usage EncodeToken(const base::UnguessableToken& token)
2024-01-15 11:01:35 +01:00
Charles Kerr
80b220d214
refactor: use base::NoDestructor instead of base::LazyInstance ( #40947 )
...
* refactor: use NoDestructor for g_io_thread_application_locale
* refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance()
* refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
* refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
* chore: remove unused #include
* fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
make sure instance is static
* chore: remove unused #include "base/lazy_instance.h"
2024-01-12 14:50:29 +01:00
Shelley Vohr
57b29903e3
build: log got error response bodies ( #40965 )
2024-01-12 14:37:39 +01:00
Samuel Attard
bbfe809d02
docs: add reclient docs, remove goma docs ( #40948 )
...
* docs: add reclient docs, remove goma docs
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-01-12 13:50:20 +13:00
Keeley Hammond
e83192adba
ci: revert CI git cache removal ( #40964 )
...
* Revert "ci: increase "gclient sync" output timeout (#40963 )"
This reverts commit be4eb4e8a7 .
* Revert "build: remove CI cache of git cache (#40953 )"
This reverts commit b39ebb8625 .
2024-01-11 13:51:19 -08:00
Keeley Hammond
be4eb4e8a7
ci: increase "gclient sync" output timeout ( #40963 )
...
ci: increase gclient output timeout
2024-01-11 11:56:22 -08:00
Samuel Attard
8b9eb518a9
build: fix windows remote exec of python actions ( #40958 )
2024-01-11 07:17:35 -08:00
Shelley Vohr
d5d162b622
fix: InAppPurchase pre-emptive deallocation ( #40938 )
...
* fix: InAppPurchase pre-emptive deallocation
* test: try re-enabling IAP tests
2024-01-11 13:32:29 +01:00
Samuel Attard
b39ebb8625
build: remove CI cache of git cache ( #40953 )
2024-01-11 23:29:49 +13:00
electron-roller[bot]
2e4e6f10de
chore: bump chromium to 122.0.6236.2 (main) ( #40871 )
...
* chore: bump chromium in DEPS to 122.0.6223.0
* 5129828: Removes special cases for selenium-atoms dependencies.
https://chromium-review.googlesource.com/c/chromium/src/+/5129828
* chore: fixup patch indices
* 5139789: Deduplicate BrowserContext's ResourceContext
https://chromium-review.googlesource.com/c/chromium/src/+/5139789
* 5148579: Simplify SelectFileDialog::Listener
https://chromium-review.googlesource.com/c/chromium/src/+/5148579
* 5134038: Code Health: Use string_view in base::i18n::BreakIterator::SetText
https://chromium-review.googlesource.com/c/chromium/src/+/5134038
* 5137427: Code Health: Use string_view in SpellCheck::SpellCheckWord
https://chromium-review.googlesource.com/c/chromium/src/+/5137427
* [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left
Notable things in this commit:
* refactors `__indirect_binary_left_foldable`, making it slightly
different (but equivalent) to _`indirect-binary-left-foldable`_, which
improves readability (a [patch to the Working Paper][patch] was made)
* omits `__cpo` namespace, since it is not required for implementing
niebloids (a cleanup should happen in 2024)
* puts tests ensuring invocable robustness and dangling correctness
inside the correctness testing to ensure that the algorithms' results
are still correct
[patch]: https://github.com/cplusplus/draft/pull/6734
* chore: bump chromium in DEPS to 122.0.6224.0
* 5154766: [Refresh 2023] [GTK] Fix gap above toolbar with fractional scaling
https://chromium-review.googlesource.com/c/chromium/src/+/5154766
* chore: fixup patch indices
* 5094458: Remove extra CGColorSpace parameters from skia and ui helpers
https://chromium-review.googlesource.com/c/chromium/src/+/5094458
* chore: bump chromium in DEPS to 122.0.6226.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6227.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6228.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6230.0
* chore: bump chromium in DEPS to 122.0.6232.0
* chore: bump chromium in DEPS to 122.0.6234.0
* chore: bump chromium in DEPS to 122.0.6236.2
* chore: update patches
* fix: remove --disable-color-correct-renderering
Per https://electronhq.slack.com/archives/CB6CG54DB/p1698444047862459 it is not used any more and was never documented.
* chore: add WEB_PRINTING to content permission converter
Unused in non-cros so no need to document
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5136178
* chore: Views is now vec<raw_ptr> instead of raw<T*>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5140028
* spec: add Iterator to global intrinsics
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-01-11 19:33:40 +13:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Charles Kerr
fac964ac0d
refactor: migrate deprecated LazyInstance code to NoDestructor ( #40927 )
...
* refactor: do not use deprecated NoDestructor in javascript_environment.cc
* refactor: do not use deprecated NoDestructor in window_list.cc
2024-01-10 14:01:49 -06:00
David Sanders
c2c64d27fd
ci: fix missing inputs for release project board automation ( #40726 )
2024-01-10 13:25:11 +01:00
Samuel Attard
d5c658545a
chore: fix content tracing flake ( #40939 )
...
* chore: fix contentTracing test
* cry
2024-01-11 01:13:36 +13:00
Samuel Attard
ebf9a49fba
build: use container runner for arm tests ( #40875 )
...
* build: use aks arm64 test runners
* build: better image
* build: even more stuff
* build: arm par
* build: use aks arm32
* build: arm32 par
* build: get test timings from abs paths
* build: avoid realpath, use echo
2024-01-10 13:12:19 +13:00
Samuel Attard
3afb012ad1
build: add infra for reclient support ( #40850 )
...
* chore: add patch to always set macos platform for x-build
* build: add infra for reclient support
* build: override reclient version
* build: use RBE in CI
* chore: hardcode reclient fix version
* build: lower process count on macOS
* build: use large macOS instance for testing-arm64
* Revert "build: use large macOS instance for testing-arm64"
This reverts commit 6844adfd00a5230e68234112dfd84caa50d3f621.
* build: login in via helper not writing file
* chore: update patches
* build: use recelint from DEPS
* build: fix windows reproxy cfg
* build: use reclient in appveyor
* build: update WOA job too
* build: force another build
* build: do not checkout reclient
2024-01-10 10:19:42 +13:00
Shelley Vohr
c184b93fc5
fix: crash using powerMonitor before ready event ( #40888 )
...
* fix: crash using powerMonitor before ready event
* refactor: continue using DBusBluezManagerWrapperLinux
2024-01-09 09:41:42 +01:00
Charles Kerr
7b4d490bfe
perf: use fixed-size arrays for the font cache ( #40898 )
...
refactor: use fixed-size arrays for the font cache
Since we know at compile time which [family x script] combos we want to
cache, we can hold the cache in fixed std::arrays instead of in nested
std::unordered_maps.
2024-01-08 10:31:02 +01:00
Calvin
37630a6128
fix: wide string concatenation ( #40892 )
...
* fix: wide string concatenation
* Use wstring_views to keep length in context
* forgot a space, oopsies
2024-01-07 22:02:20 -08:00
Shelley Vohr
3a22fd3216
docs: add missing vibrancy breaking change ( #40893 )
...
docs: add missing vibranch change
2024-01-07 13:56:52 -08:00
Charles Kerr
73e7125041
chore: do not inject DXVA_Decoding trace category ( #40891 )
...
This doesn't need to be injected. Looks like it was an accident in
60ca38fb for https://github.com/electron/electron/pull/38465 .
2024-01-05 17:54:41 -06:00
Tamás Zahola
cc1b64e01c
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable ( #40705 )
...
* fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable
* add test
* fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`
2024-01-05 12:15:35 -05:00
Charles Kerr
22970f573b
perf: use flat_set, flat_map for small, trivially-moved containers ( #40817 )
...
* refactor: use base::flat_map in ElectronMenuModel
* refactor: use base::flat_map in BuildSubmenuFromModel()
* refactor: use base::flat_map in GetDialogsMap()
* refactor: use base::flat_map in DesktopCapturer
* refactor: use base::flat_map, flat_set in ElectronBrowserClient
* refactor: use base::flat_map in ProxyingURLLoaderFactory
* refactor: use base::flat_map in MapToCommonId()
* refactor: use base::flat_map for g_map_id
* refactor: use base::flat_map for ViewsDelegate::AppbarAutohideEdgeMap
* refactor: use base::flat_map for App::app_metrics_
* refactor: use base::flat_map for PowerSaveBlocker::wake_lock_types_
* refactor: use base::flat_map for NativeImage::hicons_
* refactor: use base::flat_map for MenuViews::menu_runners_
* refactor: use base::flat_map for WebViewManager::web_contents_embedder_map_
* refactor: use base::flat_map for InspectableWebContents::extensions_api_
* refactor: use base::flat_set for libnotify GetServerCapabilities()
* refactor: use base::flat_set for InspectableWebContents::loaders_
* refactor: use base::flat_set for ElectronRendererClient::environments_
refactor: use base::flat_set for ElectronRendererClient::injected_frames_
* refactor: use base::flat_set for WebWorkerObserver::environments_
2024-01-05 12:18:31 +01:00
Brandon Fowler
5086071294
feat: add transparent webpreference to webview ( #40301 )
...
* feat: add transparent option to WebContents
* feat: add transparent attribute to webview
* test: add tests for webview transparent attribute
* docs: add transparent attribute to webview docs
* fix: run tests on macOS only
* refactor: remove unneeded html tag
* fix: only apply transparent option to guests
* refactor: correct comment
* refactor: use opaque instead
Retains current webview behaviour by default.
* fix: correct variable name to guest_opaque_
* refactor: use transparent webpreference
* docs: remove unused web preference
* fix: uncomment condition for transparency test
* docs: converted to list format and linked to MDN
* fix: make webviews transparent by default again
* fix: rebase error
---------
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-05 13:00:27 +09:00
Devraj Mehta
8c71e2adc9
feat: add net module to utility process ( #40017 )
...
* chore: initial prototype of net api from utility process
* chore: update url loader to work on both browser and utility processes
* chore: add net files to utility process bundle
* chore: re-add app ready check but only on main process
* chore: replace browser thread dcheck's with sequence checker
* refactor: move url loader from browser to common
* refactor: move net-client-request.ts from browser to common
* docs: add utility process to net api docs
* refactor: move net module app ready check to browser only
* refactor: switch import from main to common after moving to common
* test: add basic net module test for utility process
* refactor: switch browser pid with utility pid
* refactor: move electron_api_net from browser to common
* chore: add fetch to utility net module
* chore: add isOnline and online to utility net module
* refactor: move net spec helpers into helper file
* refactor: break apart net module tests
Adds two additional net module test files: `api-net-session-spec.ts` for
tests that depend on a session being available (aka depend on running on
the main process) and `api-net-custom-protocols-spec.ts` for custom
protocol tests. This enables running `api-net-spec.ts` in the utility
process.
* test: add utility process mocha runner to run net module tests
* docs: add utility process to net module classes
* refactor: update imports in lib/utility to use electron/utility
* chore: check browser context before using in main process
Since the browser context supplied to the SimpleURLLoaderWrapper can now
be null for use in the UtilityProcess, adding a null check for the main
process before use to get a more sensible error if something goes wrong.
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* chore: remove test debugging
* chore: remove unnecessary header include
* docs: add utility process net module limitations
* test: run net module tests in utility process individually
* refactor: clean up prior utility process net tests
* chore: add resolveHost to utility process net module
* chore: replace resolve host dcheck with sequence checker
* test: add net module tests for net.resolveHost
* docs: remove utility process limitation for resolveHost
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2024-01-04 16:20:37 -05:00
Charles Kerr
f229201f41
refactor: make NativeWindow getter methods const ( #40804 )
...
* refactor: make NativeWindow getter methods const
* fixup! refactor: make NativeWindow getter methods const
make GetZOrderLevel() const
* fixup! refactor: make NativeWindow getter methods const
fix oops
2024-01-04 09:51:59 -06:00
Mathew Bino
3a06047e61
docs: note accelerator case insensitivity ( #40783 )
...
* Fix PR#38673
As requested in PR#38673 , a line has been added that explicitly states that accelerators are case sensitive
* Update docs/api/accelerator.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update accelerator.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-01-04 10:06:12 -05:00
Jeremy Rose
84ba0c6c7d
fix: BrowserView and <webview> should be transparent by default ( #40866 )
2024-01-04 10:04:56 -05:00
Keeley Hammond
0672f59f26
chore: add disclaimer to release timeline ( #40717 )
...
* chore: add disclaimer to release timeline
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-01-04 10:01:40 -05:00
Cheng Zhao
dfce1a9eb4
fix: ignore all NODE_ envs from foreign parent in node process ( #40770 )
...
* fix: ignore all NODE_ envs from foreign parent
* fix: recognize ad-hoc signed binary
2024-01-04 16:34:08 +09:00
Shelley Vohr
baca2e302d
chore: drop ada ICU requirement for parsing hostnames ( #40860 )
2024-01-03 13:58:28 -05:00
electron-roller[bot]
8c89137ecd
chore: bump chromium to 122.0.6194.0 (main) ( #40750 )
...
* chore: bump chromium in DEPS to 122.0.6180.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532
minor manual changes to match upstream changes
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
* chore: update feat_add_onclose_to_messageport.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
no manual changes; patch applied with fuzz 1
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072
minor manual changes to match upstream changes
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481
no manual changes; patch applied with fuzz 2
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
* Remove performActionOnRemotePage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017
It appears it is not used by anything within Chromium or outside.
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872
The copy construtor is more expensive and has been removed upstream
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614
* chore: e patches all
* chore: bump chromium to 122.0.6181.0
* chore: e patches all
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
* chore: make lint happy
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
upstream reverted this change
* chore: bump chromium in DEPS to 122.0.6182.0
* chore: update patches
* chore: fix virtual function names that were renamed upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989
* chore: node script/gen-libc++-filenames.js
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
* chore: bump chromium in DEPS to 122.0.6184.0
* chore: bump chromium in DEPS to 122.0.6186.0
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619
minor manual changes to match upstream changes
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922
minor manual changes to match upstream changes
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595
no manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: bump chromium in DEPS to 122.0.6188.0
* chore: bump chromium in DEPS to 122.0.6190.0
* chore: bump chromium in DEPS to 122.0.6192.0
* chore: bump chromium in DEPS to 122.0.6194.0
* Remove an unnecessary DCHECK which causes Lacros to crash.
https://chromium-review.googlesource.com/c/chromium/src/+/5124880
* [FixIt Week] Add shared regular profile function that includes ash
https://chromium-review.googlesource.com/c/chromium/src/+/5100709
* Simplify the PrintManagerHost::ScriptedPrint() call
https://chromium-review.googlesource.com/c/chromium/src/+/5019703
* [local compile hints] Add tests
https://chromium-review.googlesource.com/c/chromium/src/+/5024173
* chore: update patches
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: node script/gen-libc++-filenames.js
* Remove //ui/ozone/buildflags.h
https://chromium-review.googlesource.com/c/chromium/src/+/5119048
* fixup! Remove //ui/ozone/buildflags.h
* fixup! Remove //ui/ozone/buildflags.h
* chore: update patches
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
* fixup! Remove //ui/ozone/buildflags.h
* Add permission policy verification in PermissionControllerImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5059112
* fix: ensure spellcheck interface is registered for frame
* [exceptions] Unify pending and scheduled exceptions
https://chromium-review.googlesource.com/c/v8/v8/+/5050065
* fix: dchecks in node.js tests
* fix: try adding termination check
* chore: document breaking iframe change
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-03 09:52:49 +01:00
Jeremy Rose
be4e4ff11b
fix: make grant_file_protocol_extra_privileges fuse also block CORS fetches ( #40801 )
2024-01-02 13:06:33 -08:00
Bruno Henrique da Silva
a208d45aca
fix: titlebar incorrectly displayed on frameless windows ( #40749 )
...
* fix: titlebar incorrectly displayed on frameless windows
* fix: enable transparency for Mica windows
* Refactor ShouldWindowContentsBeTransparent
---------
Co-authored-by: clavin <clavin@electronjs.org >
2024-01-02 13:59:47 -05:00
Charles Kerr
7995c56fb0
refactor: use a FixedFlatMap for v8 converting ui::MenuSourceType ( #40786 )
2023-12-20 17:44:17 -06:00
Nikhil Simon Toppo
ab2a4fd836
docs: corrected the ipcMain import path ( #40764 )
...
Update tutorial-3-preload.md
corrected the import path for ipcMain
2023-12-19 12:30:48 -06:00
Keeley Hammond
95d094d75b
fix: add partition alloc check for MacOS 13/14+ ( #40757 )
2023-12-14 13:47:31 -08:00
Jeremy Rose
ba97679901
ci: re-comment pdb.zip download in appveyor.yml ( #40758 )
2023-12-14 12:24:05 +01:00
Jeremy Rose
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
Tamás Zahola
a94fb2cb5d
fix: don't reject loadURL() promise from did-fail-load - use did-finish-load instead ( #40661 )
2023-12-12 11:45:14 -08:00
Kishanjay
80d85c0e8e
fix: incorrectly mapped toggleDevTools in custom menu fiddle ( #40703 )
2023-12-12 11:36:34 -08:00
Jeremy Rose
66b2f697ea
build: remove dcheck.patch ( #40744 )
...
chore: remove dcheck.patch
2023-12-12 12:01:02 +01:00
Robo
83f15bd957
chore: cleanup tests creating crashpad handler in the test runner process ( #40668 )
...
* chore: cleanup tests creating crashpad handler in the test runner process
* ci: logging
* ci: enable logging
* ci: more logging
* ci: run all tests
* ci: more logging
* ci: increase timeout
* Revert "ci: increase timeout"
This reverts commit 870f74455d .
* Revert "ci: more logging"
This reverts commit 46837f8b3a .
* Revert "ci: run all tests"
This reverts commit 6a7889ce67 .
* Revert "ci: more logging"
This reverts commit 351473ab43 .
* Revert "ci: enable logging"
This reverts commit 194109ed5a .
* Revert "ci: logging"
This reverts commit 9a3396fc7a .
* chore: disable flaky ia32 tests
2023-12-12 19:38:42 +09:00
Keeley Hammond
a6417cc265
build: remove font flooding in devtools patch ( #40746 )
2023-12-12 10:13:31 +01:00
electron-roller[bot]
08a51f3339
chore: bump chromium to 121.0.6159.0 (main) ( #40632 )
...
* chore: bump chromium in DEPS to 121.0.6154.0
* chore: bump chromium in DEPS to 121.0.6155.0
* fix patches
* chore: update patches
* patch out reference to GetOcclusionTracker
* un-flag PIPOcclusionTracker
* chore: bump chromium in DEPS to 121.0.6157.0
* fix conflicts
https://chromium-review.googlesource.com/c/chromium/src/+/5038807
* add PIP occlusion tracker sources to chromium_src
* 5037591: Replace feature_list's Initialize* methods with Init*.
https://chromium-review.googlesource.com/c/chromium/src/+/5037591
* 4811903: Move //content/browser/renderer_host/input/synthetic_gesture_controller to //content/common/input
https://chromium-review.googlesource.com/c/chromium/src/+/4811903
* 4917953: usb: Add usb-unrestricted to permission policy
https://chromium-review.googlesource.com/c/chromium/src/+/4917953
* 5072395: Remove unused `creation_context` parameter from blink/public APIs
https://chromium-review.googlesource.com/c/chromium/src/+/5072395
* 5052035: [X11] Change AtomCache from a singleton to owned by Connection
https://chromium-review.googlesource.com/c/chromium/src/+/5052035
* fix v8/.patches
* node script/gen-libc++-filenames.js
* 5035771: Remove the SetImage method of ImageButton
https://chromium-review.googlesource.com/c/chromium/src/+/5035771
* fixup! 5052035: [X11] Change AtomCache from a singleton to owned by Connection
* fixup! 5035771: Remove the SetImage method of ImageButton
* chore: bump chromium in DEPS to 121.0.6159.0
* 4505903: [Extensions] Add lastAccessed property to chrome.tabs.Tab
https://chromium-review.googlesource.com/c/chromium/src/+/4505903
* update patches
* don't duplicate tabs API types
this causes weird memory bugs if the two get out of sync
* fix UAF in TrayIconCocoa
not sure why this is popping up just now ... this has been broken for ages afaict
* Revert "don't duplicate tabs API types"
This reverts commit 80dff2efaa .
This is failing tests with extensions API schema check failures, so
revert for now. we'll fix it later.
* revert v8 change causing node crashes
* chore: reduce diffs in revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-12-11 14:58:26 -06:00
electron-roller[bot]
890a557eed
chore: bump node to v20.10.0 (main) ( #40675 )
...
* chore: bump node in DEPS to v20.10.0
* chore: update feat_initialize_asar_support.patch
no code changes; patch just needed an update due to nearby upstream changes
Xref: https://github.com/nodejs/node/pull/49986
* chore: update pass_all_globals_through_require.patch
no manual changes; patch applied with fuzz
Xref: https://github.com/nodejs/node/pull/49657
* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls
Xref: https://github.com/nodejs/node/pull/49912
no code changes; patch just needed an update due to nearby upstream changes
* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch
Xref: https://github.com/nodejs/node/pull/49986
minor manual changes needed to sync with upstream change
* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/50096
Xref: https://github.com/nodejs/node/pull/50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this
Xref: https://github.com/nodejs/node/pull/49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream
* fix: lazyload fs in esm loaders to apply asar patches
* https://github.com/nodejs/node/pull/50127
* https://github.com/nodejs/node/pull/50096
* esm: jsdoc for modules code
https://github.com/nodejs/node/pull/49523
* test: set test-cli-node-options as flaky
https://github.com/nodejs/node/pull/50296
* deps: update c-ares to 1.20.1
https://github.com/nodejs/node/pull/50082
* esm: bypass CommonJS loader under --default-type=module
https://github.com/nodejs/node/pull/49986
* deps: update uvwasi to 0.0.19
https://github.com/nodejs/node/pull/49908
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* crypto: account for disabled SharedArrayBuffer
https://github.com/nodejs/node/pull/50034
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* src: generate snapshot with --predictable
https://github.com/nodejs/node/pull/48749
* chore: fixup patch indices
* fs: throw errors from sync branches instead of separate implementations
https://github.com/nodejs/node/pull/49913
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* esm: detect ESM syntax in ambiguous JavaScrip
https://github.com/nodejs/node/pull/50096
* fixup! test: fix edge snapshot stack traces
* esm: unflag extensionless ES module JavaScript and Wasm in module scope
https://github.com/nodejs/node/pull/49974
* [tagged-ptr] Arrowify objects
https://chromium-review.googlesource.com/c/v8/v8/+/4705331
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-12-11 21:09:50 +01:00
Felipe C
5094cb4115
fix: wrong default port in docs ( #40665 )
...
fix: wrong default port
2023-12-11 11:43:06 -05:00
Yureka
2eb13d377e
docs: fix year typos in electron-timelines.md ( #40728 )
2023-12-07 19:14:54 -08:00
David Sanders
93fdc8d33c
ci: roll back the link release project board to repo automation ( #40716 )
...
* ci: roll back the link release project board to repo automation
* ci: add workflow_dispatch
2023-12-06 20:58:41 -08:00
Keeley Hammond
d6a80bad05
build: bump NMV to 121 ( #40707 )
2023-12-05 20:31:36 -08:00
Cheng Zhao
cb0da6ff34
fix: prevent node mode to be used as script runner by other apps ( #40579 )
2023-12-06 11:23:54 +09:00
Cheng Zhao
9aa73abe78
feat: enable code cache for custom protocols ( #40544 )
2023-12-06 11:22:41 +09:00
Jeremy Rose
85bc005cd6
refactor: move JS dialog handling to JS ( #40598 )
2023-12-05 17:36:23 -08:00
tr2-harada
ee8d97d7fe
build: update typescript-definitions to 8.15.2 ( #40670 )
...
* build: update typescript-definitions to 8.15.2
* chore: update yarn.lock
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-12-05 00:53:52 -08:00
Robo
3a510a26d0
chore: cleanup global reject handler leaking into tests ( #40689 )
2023-12-05 12:56:51 +09:00
Keeley Hammond
9afeaa3a4c
docs: add E28 support for ESM in tutorial.md ( #40690 )
...
docs: add E28 support for ESM in tutorial
2023-12-04 12:36:37 -08:00
Shelley Vohr
10a165a9ff
fix: webview zoom level persistence on navigation ( #40650 )
2023-12-04 10:39:20 -05:00
David Sanders
66b4b21646
ci: tweak new release board workflow ( #40680 )
...
* ci: tweak new release board workflow
* ci: fix workflow
2023-12-04 10:18:14 -05:00
Ryan Manuel
6f14dba7a0
fix: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium ( #40681 )
...
* chore: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium
* update patch message
2023-12-04 13:37:03 +09:00
Albert Xing
3609fc7402
fix: clean up devtools frontend_host on webcontents destroy ( #40666 )
...
* fix: clean up devtools frontend_host on destroy
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
* test: add a test for re-opening devtools
2023-12-01 11:37:52 -08:00
George Xu
344b7f0d06
docs: add dates for e29 ( #40622 )
...
* docs: add dates for e29
* update dates for e26 eol
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: update Jan to Dec
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-11-30 20:55:42 -08:00
Cheng Zhao
96f5f89f1b
chore: fix building content_browsertests ( #40652 )
2023-11-30 07:23:21 -08:00
Shelley Vohr
9c94fd7afb
chore: upgrade to Node.js v20 ( #40545 )
...
* chore: upgrade to Node.js v20
* src: allow embedders to override NODE_MODULE_VERSION
https://github.com/nodejs/node/pull/49279
* src: fix missing trailing ,
https://github.com/nodejs/node/pull/46909
* src,tools: initialize cppgc
https://github.com/nodejs/node/pull/45704
* tools: allow passing absolute path of config.gypi in js2c
https://github.com/nodejs/node/pull/49162
* tools: port js2c.py to C++
https://github.com/nodejs/node/pull/46997
* doc,lib: disambiguate the old term, NativeModule
https://github.com/nodejs/node/pull/45673
* chore: fixup Node.js BSSL tests
* https://github.com/nodejs/node/pull/49492
* https://github.com/nodejs/node/pull/44498
* deps: upgrade to libuv 1.45.0
https://github.com/nodejs/node/pull/48078
* deps: update V8 to 10.7
https://github.com/nodejs/node/pull/44741
* test: use gcUntil() in test-v8-serialize-leak
https://github.com/nodejs/node/pull/49168
* module: make CJS load from ESM loader
https://github.com/nodejs/node/pull/47999
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* chore: address changes to CJS/ESM loading
* module: make CJS load from ESM loader (https://github.com/nodejs/node/pull/47999 )
* lib: improve esm resolve performance (https://github.com/nodejs/node/pull/46652 )
* bootstrap: optimize modules loaded in the built-in snapshot
https://github.com/nodejs/node/pull/45849
* test: mark test-runner-output as flaky
https://github.com/nodejs/node/pull/49854
* lib: lazy-load deps in modules/run_main.js
https://github.com/nodejs/node/pull/45849
* url: use private properties for brand check
https://github.com/nodejs/node/pull/46904
* test: refactor `test-node-output-errors`
https://github.com/nodejs/node/pull/48992
* assert: deprecate callTracker
https://github.com/nodejs/node/pull/47740
* src: cast v8::Object::GetInternalField() return value to v8::Value
https://github.com/nodejs/node/pull/48943
* test: adapt test-v8-stats for V8 update
https://github.com/nodejs/node/pull/45230
* tls: ensure TLS Sockets are closed if the underlying wrap closes
https://github.com/nodejs/node/pull/49327
* test: deflake test-tls-socket-close
https://github.com/nodejs/node/pull/49575
* net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
https://github.com/nodejs/node/pull/49400
* net: use asserts in JS Socket Stream to catch races in future
https://github.com/nodejs/node/pull/49400
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* src: create BaseObject with node::Realm
https://github.com/nodejs/node/pull/44348
* src: implement DataQueue and non-memory resident Blob
https://github.com/nodejs/node/pull/45258
* sea: add support for V8 bytecode-only caching
https://github.com/nodejs/node/pull/48191
* chore: fixup patch indices
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* build: modify js2c.py into GN executable
* fix: (WIP) handle string replacement of fs -> original-fs
* [v20.x] backport vm-related memory fixes
https://github.com/nodejs/node/pull/49874
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* src: avoid copying string in fs_permission
https://github.com/nodejs/node/pull/47746
* look upon my works ye mighty
and dispair
* chore: patch cleanup
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* fix: missing include for NODE_EXTERN
* chore: fixup patch indices
* fix: fail properly when js2c fails in Node.js
* build: fix js2c root_gen_dir
* fix: lib/fs.js -> lib/original-fs.js
* build: fix original-fs file xforms
* fixup! module: make CJS load from ESM loader
* build: get rid of CppHeap for now
* build: add patch to prevent extra fs lookup on esm load
* build: greatly simplify js2c modifications
Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c
* chore: update to handle moved internal/modules/helpers file
* test: update @types/node test
* feat: enable preventing cppgc heap creation
* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler
* fix: no cppgc initialization in the renderer
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* test: disable single executable tests
* fix: nan tests failing on node headers missing file
* tls,http2: send fatal alert on ALPN mismatch
https://github.com/nodejs/node/pull/44031
* test: disable snapshot tests
* https://github.com/nodejs/node/pull/47887
* https://github.com/nodejs/node/pull/49684
* https://github.com/nodejs/node/pull/44193
* build: use deps/v8 for v8/tools
Node.js hard depends on these in their builtins
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* build: remove js2c //base dep
* build: use electron_js2c_toolchain to build node_js2c
* fix: don't create SafeSet outside packageResolve
Fixes failure in parallel/test-require-delete-array-iterator:
=== release test-require-delete-array-iterator ===
Path: parallel/test-require-delete-array-iterator
node:internal/per_context/primordials:426
constructor(i) { super(i); } // eslint-disable-line no-useless-constructor
^
TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
at new Set (<anonymous>)
at new SafeSet (node:internal/per_context/primordials:426:22)
* fix: failing crashReporter tests on Linux
These were failing because our change from node::InitializeNodeWithArgs to
node::InitializeOncePerProcess meant that we now inadvertently called
PlatformInit, which reset signal handling. This meant that our intentional
crash function ElectronBindings::Crash no longer worked and the renderer process
no longer crashed when process.crash() was called. We don't want to use Node.js'
default signal handling in the renderer process, so we disable it by passing
kNoDefaultSignalHandling to node::InitializeOncePerProcess.
* build: only create cppgc heap on non-32 bit platforms
* chore: clean up util:CompileAndCall
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* fix: use thread_local BuiltinLoader
* chore: fixup v8 patch indices
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-11-30 09:51:35 -05:00
Tamás Zahola
39ee94089a
fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive() ( #40546 )
...
* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()
* add test
2023-11-30 12:43:22 +01:00
Charles Kerr
b2fcc15ec7
build: fix release notes script bug that omitted edited release-clerk comments ( #40634 )
...
* build: fix release notes script bug that omitted edited release-clerk comments
add a warning when neither notes nor no-notes are found
* fixup! build: fix release notes script bug that omitted edited release-clerk comments
use console.warn() instead of console.log()
2023-11-30 12:41:48 +01:00
Jeremy Rose
763bc62c7f
chore: remove fix_add_check_for_sandbox_then_result.patch ( #40633 )
2023-11-29 10:30:21 -08:00
Cheng Zhao
abb71f5307
chore: make use of the v8_expose_public_symbols flag ( #40624 )
...
* chore: make use of the v8_expose_public_symbols flag
Use the newly added v8_expose_public_symbols flag to expose V8 symbols,
instead of relying on custom patches.
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-29 12:46:27 +09:00
David Sanders
c12ab7c941
ci: use pull_request_target for PR labeled workflows ( #40623 )
2023-11-29 08:33:07 +09:00
electron-roller[bot]
5c7579ab1c
chore: bump chromium to 121.0.6147.0 (main) ( #40523 )
...
* chore: bump chromium in DEPS to 121.0.6128.0
* build: update patches
* refactor: remove instrumentation from extensions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5002404
* refactor: modernization of tabs_api
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4997031
* fix: add RecordHover and RecordDrag handlers
* build: add missing pdf files
* chore: bump chromium in DEPS to 121.0.6129.0
* chore: bump chromium in DEPS to 121.0.6131.0
* chore: update patches
* refactor: remove will_cause_resize from ExitFullscreen
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
* chore: add missing std converter include
Before these were being inferred as std::string implicitly, not anymore
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5029573
* chore: Unwrap UserScriptList from unique_ptrs
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5005198
* refactor: add PDF internal id into PDF stream info
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4876972
* refactor: add metadata to view classes
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4994885
* chore: run lint --fix
* chore: update libc++ filenames
* chore: clean up menubar
* chore: update patches after main merge
* 5010979: Replace base::WStringPiece usage with std::wstring_view | https://chromium-review.googlesource.com/c/chromium/src/+/5010979
* chore: bump chromium in DEPS to 121.0.6142.0
* chore: update patches
* 4969574: Refactor NativeDesktopMediaList | https://chromium-review.googlesource.com/c/chromium/src/+/4969574
* 5031192: [blink] Create new blink test suite that doesn't create blink Isolate | https://chromium-review.googlesource.com/c/chromium/src/+/5031192
* chore: update v8/devtools patches
* 5040722: [base] Replace MakeFixedFlatTreeSorted with tag type overloads | https://chromium-review.googlesource.com/c/chromium/src/+/5040722
* 5026474: Add --generate-pdf-document-outline | https://chromium-review.googlesource.com/c/chromium/src/+/5026474
* 5024297: Change parameter of CheckMediaAccessPermission from GURL to URL::Origin | https://chromium-review.googlesource.com/c/chromium/src/+/5024297
* 5034217: [RWS] Remove CanonicalCookie::IsSameParty method | https://chromium-review.googlesource.com/c/chromium/src/+/5034217
* 5037192: Rewrite usage of RenderFrame::GetRoutingID | https://chromium-review.googlesource.com/c/chromium/src/+/5037192
* 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* chore: bump chromium in DEPS to 121.0.6143.0
* chore: bump chromium in DEPS to 121.0.6145.0
* chore: update chromium patches
* 5049986: Use std::unique_ptr for MenuItemView::submenu_ member. | https://chromium-review.googlesource.com/c/chromium/src/+/5049986
* 5041595: picture-in-picture: Add PictureInPictureOcclusionTracker | https://chromium-review.googlesource.com/c/chromium/src/+/5041595
* chore: update all patches
* chore: bump chromium in DEPS to 121.0.6147.0
* chore: update patches
* 5051069: Use base::FunctionRef for BrowserPluginGuestManager. | https://chromium-review.googlesource.com/c/chromium/src/+/5051069
* 5057330: [base] Remove base::Erase()/base::EraseIf() overloads for std::set | https://chromium-review.googlesource.com/c/chromium/src/+/5057330
* fixup! 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* 5017518: Remove PPAPI if NaCl is disabled | https://chromium-review.googlesource.com/c/chromium/src/+/5017518
* 5002232: [DevTools] Console Insights: move from build flag to Feature API | https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* 4970322: [X11] Move utils into x11::Connection | https://chromium-review.googlesource.com/c/chromium/src/+/4970322
* 5048950: Let MenuModelAdapter::CreateMenu return a std::unique_ptr<>. | https://chromium-review.googlesource.com/c/chromium/src/+/5048950
* chore: update libcxx filenames
* use Context::Scope in RunScriptsAtDocument{Start,End}
* 4775128: content: Reuse CC instance for main frame navigations
https://chromium-review.googlesource.com/c/chromium/src/+/4775128
* also wrap WebWorkerObserver::ContextWillDestroy with Context::Scope
* set LIBCPP_HARDENING_MODE
https://chromium-review.googlesource.com/c/chromium/src/+/5014271
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-11-28 13:40:12 -08:00
Felix Rieseberg
f0f027c06d
fix: Use activateIgnoringOtherApps for non-panels ( #40570 )
...
Use activateIgnoringOtherApps for non-panels
2023-11-27 12:58:46 -05:00
Cheng Zhao
58a21a3cd9
chore: allow passing more roots to lint.js ( #40571 )
2023-11-27 09:26:33 +09:00
Samuel Attard
79e714a825
chore: add patch upstream plan for resize patch ( #40596 )
2023-11-22 12:36:52 -08:00
Samuel Attard
44e055a788
build: specify explicit typeroots for ts builds ( #40588 )
...
Upstreaming of bf63336f60
2023-11-22 09:39:36 -08:00
Shelley Vohr
e78ce82641
fix: do not call after() async_hook for asyncId 0 ( #40574 )
...
fix: do not call after() async_hook for asyncId 0
2023-11-22 17:37:40 +01:00
Samuel Attard
1574cbf137
fix: restore performance of macOS window resizing ( #40577 )
2023-11-21 23:58:57 -08:00
Tomasz
3340bc1bf9
fix: maximized window bounds when toggle setResizable ( #40503 )
2023-11-22 15:21:18 +09:00
David Sanders
2029224a84
ci: trigger Slack workflow on backport requested ( #40487 )
2023-11-22 15:20:34 +09:00
clintharris
f3676ff975
docs: wording in IPC tutorial docs ( #40555 )
...
fix: wording in IPC tutorial docs
2023-11-22 15:19:54 +09:00
Alex Browne
0b5fceb50e
docs: update quick-start.md ( #40556 )
...
Updates the Quick Start guide to specify _where_ JavaScript code is supposed to be added. This is more descriptive than just "your file".
2023-11-22 15:19:39 +09:00
Samuel Attard
dbe170c665
build: simplify mas patches ( #36368 )
...
* build: simplify mas patches
* build: re-add configs
2023-11-21 10:53:21 -08:00
David Sanders
3d2a754531
chore: extend linting of code blocks in the docs ( #40245 )
...
* chore: extend linting of code blocks in the docs
* chore: combine lint:markdownlint and lint:markdown scripts
2023-11-21 16:50:08 +09:00
Samuel Attard
d6bb9b40b0
feat: add webUtils module with getPathForFile method ( #38776 )
...
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* chore: update patches
* fix: provide isolate to WebBlob::FromV8Value
* chore: add tests
* build: fix depshash mismatch on arm64 macOS
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-20 15:59:36 -08:00
Xie Jingyi
2c03b8fd6b
fix: ShowItemUsingFileManager should escape path in Linux ( #40527 )
2023-11-20 09:00:56 +09:00
Milan Burda
67894f1493
test: convert a few more specs to async/await ( #40313 )
2023-11-17 10:44:03 +01:00
Shelley Vohr
471449d9f6
feat: add/update missing Display properties ( #40497 )
2023-11-17 10:43:04 +01:00
Samuel Attard
dec96acf14
fix: add patch for simdutf base64 crash ( #40536 )
2023-11-15 20:11:08 -08:00
github-actions[bot]
d2b07a484d
build: update appveyor image to latest version e-121.0.6116.0 ( #40531 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-15 09:44:10 -08:00
Shelley Vohr
371bca69b6
refactor: use new extensions Messaging API IPC ( #40511 )
...
* refactor: use new extensions Messaging API IPC
Refs CRBUG:993189
Incorporates changes from:
* Bind ServiceWorker associated interfaces on Worker Thread (CL:4929154)
* [extensions] Move WakeEventPage to mojom::RendererHost (CL:4902564)
* [extensions] Convert Extension Messaging APIs over to mojo (CL:4947890)
* [extensions] Port GetMessageBundle over to mojom (CL:4956841)
* 5008635: [extensions] Bind the mojo interfaces to the frame instance
https://chromium-review.googlesource.com/c/chromium/src/+/5008635
2023-11-15 15:30:47 +01:00
Samuel Maddock
088affd4a4
fix: emit will-navigate for links in chrome: pages ( #40390 )
...
* fix: emit will-navigate for links in chrome: pages
* test: will-navigate emitted from chrome: pages
* Update shell/browser/electron_navigation_throttle.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-11-14 14:09:44 -08:00
electron-roller[bot]
0e4e9dc98c
chore: bump chromium to 121.0.6116.0 (main) ( #40490 )
...
* chore: bump chromium in DEPS to 121.0.6116.0
* chore: update patches
* Update webIDL to support close event.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4970653
* Remove uses of implicit conversion of ScopedTypeRef
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439
* Add GlobalRenderFrameHostToken
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5001743
* [DevTools] Console Insights: move from build flag to Feature API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* [Extensions] Use script serialization in scripting API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4968680
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4998265
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* chore: update libcxx files
* chore: address nan compilation error
* spec: use nan dependency from third_party
It is easier to get fixes for spec modules depending on nan
* ci: publish nan artifact for woa
* fix: bad patch update
* chore: update nan resolution
* Revert "chore: update nan resolution"
This reverts commit 786cdb858c .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-11-14 13:21:32 -08:00
David Sanders
b639fa4626
ci: close previous release project board after creating new one ( #40425 )
...
* ci: close previous release project board after creating new one
* ci: tweak release project board closure to major - 2
2023-11-13 10:37:26 -08:00
Shelley Vohr
7981d955b8
fix: chrome.action API registration ( #40500 )
2023-11-13 08:27:18 +01:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
Cheng Zhao
262723e394
build: fix building content_unittests ( #40491 )
...
chore: fix building content_unittests
2023-11-10 08:50:28 -08:00
github-actions[bot]
6697042c0a
build: update appveyor image to latest version ( #40453 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-09 16:58:46 -05:00
David Sanders
2677f36db1
docs: update references to Electron Packager ( #40480 )
2023-11-09 11:15:32 -08:00
Samuel Attard
d504d150ef
feat: add new fuse to treat file: identically to browsers ( #40372 )
2023-11-09 10:23:52 -08:00
Milan Burda
0f68d845f9
refactor: AutoUpdater for Windows using async/await ( #40289 )
2023-11-07 14:55:22 -08:00
Shelley Vohr
1ba535296e
docs: fix hid-device-{added|removed|revoked} event types ( #40462 )
...
docs: fix hid-device-{added|removed|revoked} types
2023-11-07 14:26:35 -08:00
electron-roller[bot]
e8d9294d9d
chore: bump chromium to 121.0.6110.0 (main) ( #40448 )
...
* chore: bump chromium in DEPS to 121.0.6106.0
* chore: bump chromium in DEPS to 121.0.6108.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6110.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-07 07:24:50 -05:00
Felix Rieseberg
b55d7f4a16
fix: Do not activate app when calling focus on inactive panel window ( #40307 )
...
* fix: Do not activate app when calling focus on inactive panel window
* Use activate
* Use "activate" for all windows
2023-11-06 13:38:12 -08:00
Shelley Vohr
7999ea39e2
feat: keyboard.lock() should use permissions helper ( #40369 )
...
feat: `keyboard.lock()` should use permissions helper
2023-11-06 11:54:31 -08:00
electron-roller[bot]
ee108903a0
chore: bump chromium to 121.0.6104.0 (main) ( #40418 )
...
* chore: bump chromium in DEPS to 121.0.6101.0
* chore: update patches
* Explictly use python3 to check patch diff
* chore: bump chromium in DEPS to 121.0.6102.0
* chore: update patches
* 4995136: [extensions] Enable Extension Mojo messaging
https://chromium-review.googlesource.com/c/chromium/src/+/4995136
* Bind the components interfaces to a RenderFrame
https://chromium-review.googlesource.com/c/chromium/src/+/4985961
Also:
3986427: Create RendererHost mojom interface for Extensions | https://chromium-review.googlesource.com/c/chromium/src/+/3986427
* 4997024: Enum modernisation for resources_private.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997024
* 4997025: Enum modernisation for scripting.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997025
* chore: bump chromium in DEPS to 121.0.6103.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6104.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-03 15:37:55 -04:00
Shelley Vohr
5b18d90597
fix: crash when unloading some WebViews ( #40400 )
2023-11-03 10:36:25 -04:00
github-actions[bot]
f501dabc80
build: update appveyor image to latest version, e-121.0.6100.0 ( #40428 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-02 14:56:36 -04:00
Shelley Vohr
719e52928e
build: remove patch for EOL MSVC version ( #40419 )
2023-11-02 09:17:30 -04:00
Brandon Fowler
089eb34e8d
docs: add bypassCustomProtocolHandlers to ses.fetch ( #40358 )
2023-11-01 20:27:23 -04:00
electron-roller[bot]
5200abe744
chore: bump chromium to 121.0.6100.0 (main) ( #40408 )
...
* chore: bump chromium in DEPS to 121.0.6100.0
* chore: update patches
* 4970322: [X11] Move utils into x11::Connection
https://chromium-review.googlesource.com/c/chromium/src/+/4970322
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 19:01:01 -04:00
Shelley Vohr
83f0d2645e
docs: document our Node.js versioning policy ( #40373 )
2023-11-01 18:21:16 -04:00
github-actions[bot]
878c6e3062
build: update appveyor image to latest version ( #40325 )
...
* build: update appveyor image to latest version
* chore: update version to e-120.0.6099.0
* chore: rename base image for bakes
---------
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 16:19:59 -04:00
Milan Burda
b163187235
docs: avoid leaking the IpcRendererEvent in contextBridge examples ( #40321 )
...
* docs: avoid leaking the `IpcRendererEvent` in `contextBridge` examples
* Update docs/fiddles/ipc/pattern-3/preload.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-11-01 13:46:25 -04:00
David Sanders
425efb5e47
chore: remove py2 compatibility code ( #40375 )
2023-11-01 10:20:32 -04:00
electron-roller[bot]
bc1ba1fe9d
chore: bump chromium to 120.0.6099.0 (main) ( #40316 )
...
* chore: bump chromium in DEPS to 120.0.6086.0
* chore: update patches
* chore: rename FrameSubscriber::OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4905819
just a simple renaming
* chore: rename ToJsTime() to .InMillisecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename ToDoubleT() to .InSecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename FromDoubleT() to .FromSecondsSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: bump chromium in DEPS to 120.0.6088.2
* chore: update patches
* chore: regen filenames.libcxx.gni
* chore: migrate from (removed upstream) inputFormType to formControlType
* chore: bump chromium in DEPS to 120.0.6089.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4828507
manually sync to upstream changes + reduce diff size
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6090.0
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 2 (4 lines)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944206
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4946653
do not patch WebContentsImpl::SetWindowShowState() any longer because it has been removed
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6091.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6093.0
* chore: bump chromium in DEPS to 120.0.6095.0
* chore: bump chromium in DEPS to 120.0.6096.0
* chore: bump chromium in DEPS to 120.0.6097.0
* chore: update patches
* chore: update patch after rebase
* 4961495: [document pip] Focus the window when opened manually
https://chromium-review.googlesource.com/c/chromium/src/+/4961495
* [Extensions UserScripts] Store extensions with user scripts in tracker
| https://chromium-review.googlesource.com/c/chromium/src/+/4950530
* chore: bump chromium in DEPS to 120.0.6099.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: remove trailing space
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 10:02:12 -04:00
Samuel Attard
83892ab995
refactor: ensure IpcRenderer is not bridgable ( #40330 )
...
* refactor: ensure IpcRenderer is not bridgable
* chore: add notes to breaking-changes
* spec: fix test that bridged ipcrenderer
2023-10-31 17:29:40 -04:00
John Kleinschmidt
39d36e4462
build: actually show github upload output if verbose is true. ( #40393 )
...
* build: actually show github upload output if verbose is true.
* chore: fixup lint
2023-10-31 17:05:16 -04:00
Ninglo
f526206095
feat: configure use remote checksums via rc ( #40253 )
...
* feat: support for configuring use_remote_checksums via .npmrc
* docs: support for configuring use_remote_checksums via .npmrc
---------
Co-authored-by: jiujianian <jiujianian@bytedance.com >
2023-10-31 16:51:59 -04:00
Devraj Mehta
29d7be1565
build: update @electron/docs-parser and @electron/typescript-definitions ( #40264 )
...
* feat: add utility process typescript namespace
Upgrades docs-parser and typescript-definitions to add new
'electron/utility' namespace added in:
- https://github.com/electron/docs-parser/pull/95
- https://github.com/electron/typescript-definitions/pull/246
- https://github.com/electron/typescript-definitions/pull/247
* build: update yarn.lock
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-31 16:36:41 -04:00
Samuel Attard
e1c413c845
build: update deps to fix yarn audit ( #40376 )
2023-10-31 11:05:12 -07:00
Shelley Vohr
fcdd5cba71
fix: navigator.keyboard.lock() fullscreen exit handling ( #40365 )
...
fix: navigator.keyboard.lock() fullscreen exit handling
2023-10-31 11:59:39 -04:00
Milan Burda
4b1c31e4db
fix: implement missing applicationSupportsSecureRestorableState ( #40296 )
2023-10-31 10:22:58 -04:00
Shelley Vohr
8210d0f90e
build: don't rename files in electron_node/deps/base64 ( #40368 )
...
build: don't rename files in electron_node/deps/base64
Refs https://github.com/electron/electron/pull/35999/files#r1018305596 .
Finally addresses an old TODO to use a separate build target for conflicting
filenames instead of renaming files in the source tree.
2023-10-31 09:27:31 -04:00
Milan Burda
dd68581d30
docs: add reference to app.getAppMetrics() in serviceName for utilityProcess ( #40338 )
2023-10-30 10:07:23 -04:00
Shelley Vohr
652f995128
refactor: remove DevTools legacy UI patching ( #40331 )
2023-10-26 14:36:04 -04:00
Milan Burda
30fbcfca7b
chore: remove deprecated gpu-process-crashed event ( #40255 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-26 14:05:40 -04:00
Shelley Vohr
3f92a98315
fix: prevent PopUpButtonHandler premature dealloc ( #40308 )
...
fix: prevent PopUpButtonHandler dealloc
2023-10-26 11:40:02 -04:00
Samuel Attard
621b3ba897
build: upload slow, more time good ( #40332 )
2023-10-25 12:18:19 -07:00
Milan Burda
f66d4c7ee0
fix: make sure classes in lib correctly implement Electron interfaces ( #40291 )
2023-10-25 14:02:15 -04:00
Shelley Vohr
514a9319b9
refactor: use non-deprecated NSKeyedArchiver APIs ( #40315 )
...
* refactor: use non-deprecated NSKeyedArchiver APIs
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-25 12:01:34 -04:00
electron-roller[bot]
be44a2c5b7
chore: bump chromium to 120.0.6078.0 (main) ( #40114 )
...
* chore: bump chromium in DEPS to 120.0.6049.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6050.0
* chore: update patches
* 4910494: Reland "[autopip] Show autopip UI for video pip"
https://chromium-review.googlesource.com/c/chromium/src/+/4910494
* 4812338: Move partition_alloc into a "partition_alloc" dir.
https://chromium-review.googlesource.com/c/chromium/src/+/4812338
* [Extensions Cleanup] Remove mojom ViewType::kExtensionDialog
https://chromium-review.googlesource.com/c/chromium/src/+/4909897
* 4894923: Force enable raw_ptrs pointer arithmetic check.
https://chromium-review.googlesource.com/c/chromium/src/+/4894923
* gin: Prevent wrappables from being constructed from author code.
https://chromium-review.googlesource.com/c/chromium/src/+/4905829
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6052.0
* chore: bump chromium in DEPS to 120.0.6054.0
* chore: bump chromium in DEPS to 120.0.6056.0
* chore: fix patches
* 4918545: Reland "[autopip] Add permissions embargo"
https://chromium-review.googlesource.com/c/chromium/src/+/4918545
* 4881761: UI bindings for visual logging with structured metrics.
https://chromium-review.googlesource.com/c/chromium/src/+/4881761
* chore: bump chromium in DEPS to 120.0.6058.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6060.0
* chore: bump chromium in DEPS to 120.0.6061.0
* chore: bump chromium in DEPS to 120.0.6062.0
* chore: gen libc++ filenames
* chore: update patches
* 4911894: Move //c/b/ui/views/eye_dropper to //components
https://chromium-review.googlesource.com/c/chromium/src/+/4911894
* chore: bump chromium in DEPS to 120.0.6064.0
* chore: bump chromium in DEPS to 120.0.6066.0
* chore: bump chromium in DEPS to 120.0.6068.0
* chore: bump chromium in DEPS to 120.0.6070.0
* chore: remove temp_prevent_unused_function_error.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4931270
* chore: add TransferDragSecurityInfo()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4928028
* mark TransferDragSecurityInfo() as NOTREACHED
A follow-up to previous commit. I think this is commit is correct (i.e.
that this function shouldn't get called) but am not positive, so I'm
including it in a standalone commit in case we need to revert.
* chore: update signature of OnPrivateNetworkAccessPermissionRequired()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4919478
Our impl is a no-op, so updating the signature is the only change.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6072.0
* chore: update patches
* chore: sync ParseMatchPattern() param order with upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944243
* chore: update fix_crash_loading_non-standard_schemes_in_iframes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4939602
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6073.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6074.0
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4908053
no manual changes; patch applied with fuzz 1
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4936315
minor manual sync to upstream code shear
* chore: rebuild patches
* chore: update ClearHttpAuthCache arguments
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4937937
adding ClearDataFilterPtr arg. Upstream added this arg, which is already
present in other NetworkContext methods. Our code uses `nullptr` there.
* chore: bump chromium in DEPS to 120.0.6076.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4865412
minor manual sync to upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4942936
minor manual sync to upstream code shear
* fix: move x11_util.h include to top of source file
This is a short-term fix to unblock the roll. I will follow up a better fix in a standalone PR.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6077.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6078.0
* chore: update patches
* refactor: add BrowserProcessImpl::os_crypt_async()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4455776
This is one to keep an eye on. This commit copies the upstream impl,
which appears to be an interim step with more upstream code changes
still forthcoming.
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1373092
* fixup! refactor: add BrowserProcessImpl::os_crypt_async()
chore: make 'gn check' happy
* chore: remove ensure_messageports_get_gced_when_not_referenced.patch
Xref: ensure_messageports_get_gced_when_not_referenced.patch
no longer needed because upstreamed
* chore: remove webrtc/pipewire_capturer_make_restore_tokens_re-usable_more_than_one_time.patch
Xref: https://webrtc-review.googlesource.com/c/src/+/322621
no longer needed because upstreamed
* chore: add //components/compose:buildflags dep
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4912601
needed by browser/ui/browser_dialogs.h
* chore: update filenames.libcxx.gni
node ./script/gen-libc++-filenames.js
* test: fix UI.InspectorView -> UI.InspectorView.instance()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-24 11:24:20 -04:00
Milan Burda
54ff706b71
test: add spec for app.getAppMetrics() for utility process ( #40306 )
2023-10-24 09:25:30 -04:00
Milan Burda
a867503af6
test: add spec for child-process-gone event for utility process ( #40281 )
2023-10-23 11:30:08 -04:00
Milan Burda
beb0cbc6d0
refactor: options parsing in WebContents.prototype.printToPDF() ( #40257 )
...
* refactor: options parsing in WebContents.prototype.printToPDF()
* tweak parsePageSize
2023-10-19 15:38:30 -04:00
Shelley Vohr
025af3500c
chore: Show FIDO devices in the chooser if allowed ( #40216 )
...
* chore: Show FIDO devices in the chooser if allowed
* chore: tweak HidChooserContext::IsFidoAllowedForOrigin
* chore: feedback from review
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 19:19:51 -04:00
Shelley Vohr
32a721fa2b
test: fix Node.js color edge snapshot stack traces ( #40250 )
2023-10-18 21:39:53 +02:00
Ali Yousefi
e254593616
docs: replace the example app using electron ( #37805 )
...
* replace the example app using electron
* Update README.md
Remove the trailing space to pass linter. Suggested by @jkleinsc. Thank you @jkleinsc for the suggestion.
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 10:56:17 -04:00
Samuel Attard
fd2861117e
fix: correctly track receiver for methods called via ctx bridge ( #39978 )
...
* fix: correctly track receiver for methods called via ctx bridge
* spec: test for correct contextBridge passage
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-18 10:21:42 -04:00
Shelley Vohr
5b105f911f
chore: implement no-op chrome.action extension APIs ( #40222 )
...
chore: implement no-op chrome.action extension APIs
2023-10-18 10:19:31 -04:00
John Kleinschmidt
29270f3df5
test: fixup node force colors test ( #40241 )
...
* test: fixup node force colors test
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-18 12:33:24 +02:00
Milan Burda
657e88b173
chore: remove deprecated crashed and renderer-process-crashed events ( #40115 )
2023-10-18 12:05:41 +02:00
David Sanders
09bab60a9e
docs: fix represented file fiddle ( #40233 )
2023-10-18 11:32:10 +02:00
Shelley Vohr
666907d50d
fix: Windows Toast notification dismissal from Action Center ( #40197 )
...
* fix: Windows Toast notification dismissal from Action Center
* docs: note Toast behavior in event
* chore: address feedback from review
2023-10-17 19:33:00 -04:00
Shelley Vohr
73a42d0b7b
refactor: partition HidDelegate observers by browser context ( #40215 )
2023-10-17 16:54:53 -04:00
Keeley Hammond
f65d1f3d55
build: re-enable partition alloc on mac ( #33981 )
2023-10-17 11:18:39 +09:00
Christian Bromann
ba4d6d08a7
docs: Update docs on testing Electron apps with WebdriverIO ( #40083 )
2023-10-16 12:23:44 -07:00
Samuel Attard
b6ec19a582
fix: support the throwIfNoEntry option to statSync and lstatSync in asar files ( #40221 )
2023-10-16 09:35:25 -07:00
Shelley Vohr
f7b1c75c72
feat: update app.{set|get}LoginItemSettings(settings) ( #37244 )
...
* feat: update app.{set|get}LoginItemSettings(settings)
* test: fixup and add tests
* docs: add type link
* chore: name -> serviceName
2023-10-16 12:25:11 -04:00
electron-roller[bot]
6d0d350e13
chore: bump node to v18.18.2 (main) ( #40205 )
...
* chore: bump node in DEPS to v18.18.2
* chore: update patches
* deps: update nghttp2 to 1.55.0
https://github.com/nodejs/node/pull/48746
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-16 17:13:35 +02:00
Shelley Vohr
f362e089b1
fix: incorrect wco bounds in macOS fullscreen ( #40179 )
2023-10-16 11:18:31 +02:00
Samuel Maddock
c9f6f15df6
refactor: use getter property for RFH ( #40200 )
2023-10-16 09:16:51 +09:00
Shelley Vohr
bbd2236bdd
fix: ensure MessagePorts get GCed when not referenced ( #40189 )
2023-10-13 22:09:28 +02:00
David Sanders
5d6023ae0d
docs: fix some string union typings ( #40180 )
2023-10-13 12:00:44 +02:00
Max Tower
dc4476d480
docs: rename renderer.d.ts in documentation ( #40137 )
...
Rename renderer.d.ts
This doesn't compile when the declaration name has the same root name as the TS file.
https://github.com/Microsoft/TypeScript/issues/7624#issuecomment-202501572
https://stackoverflow.com/questions/59728371/typescript-d-ts-file-not-recognized
2023-10-13 11:31:50 +02:00
David Sanders
ce4ae584e3
docs: update supported Linux versions ( #40177 )
2023-10-12 14:56:28 -04:00
Milan Burda
344f8fd384
chore: formally deprecate gpu-process-crashed event ( #40169 )
2023-10-12 14:53:52 -04:00
Shelley Vohr
592a30aa0b
build: remove native specs ( #40190 )
2023-10-12 14:51:59 -04:00
Athul Iddya
3c31246343
fix: store portal restore token under the right source ID ( #40098 )
...
XDG Desktop Portal provides restore tokens to restore a previously
selected PipeWire stream instead of prompting the user again. This
restore token is single use only and it has to be replaced when the
stream is completed/stopped.
BaseCapturerPipewire maintains two source IDs: one is initialized by
the constructor for new sources (source_id_) and another is for
capturing previously selected sources (selected_source_id_). The
restore token was always being stored under `source_id_`, even if the
capture was ongoing for `selected_source_id_`. This prevents a stream
from being restored more than once. Fix that by storing the restore
token under the selected source ID if it exists.
2023-10-12 13:17:27 +02:00
electron-roller[bot]
7ab2a82166
chore: bump node to v18.18.1 (main) ( #40174 )
...
* chore: bump node in DEPS to v18.18.1
* Revert "deps: upgrade to libuv 1.46.0"
https://github.com/nodejs/node/pull/50036
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-12 09:53:37 +02:00
Shelley Vohr
5c821d3379
fix: webContents.capturePage() for hidden windows on Windows/Linux ( #39730 )
2023-10-12 09:35:23 +02:00
Milan Burda
3e70692e4b
chore: formally deprecate crashed and renderer-process-crashed events ( #40089 )
2023-10-10 19:49:01 -04:00
Keeley Hammond
c892c61b90
docs: update dates for E28 ( #40154 )
...
* docs: update dates for E28
* docs: update node version
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-10 19:43:35 -04:00
Milan Burda
2c88626b51
chore: revert deprecate as an internal module ( #40146 )
...
Revert "chore: restore deprecate as an internal module (#40124 )"
This reverts commit 737e3de3fa .
2023-10-10 11:50:47 -04:00
Shelley Vohr
7e312c81ca
test: make capturePage color matching timeouts consistent ( #40158 )
2023-10-10 11:13:07 -04:00
Shelley Vohr
86df4db6f1
fix: crash when calling non-reentrant function in loadURL ( #40143 )
2023-10-10 12:46:04 +02:00
Milan Burda
563c370d51
refactor: use gin_helper::Dictionary::CreateEmpty() helper ( #40140 )
2023-10-10 12:45:44 +02:00
Jade Flute
47beca1d2a
docs: fix typo in session docs ( #40138 )
...
Fix typos for doc
Signed-off-by: zhangdiandian <1635468471@qq.com >
2023-10-10 12:43:18 +02:00
Tomasz
925e4f7d74
feat: Add 'mouse-enter' and 'mouse-leave' Tray events for Windows. ( #40072 )
2023-10-09 19:56:38 -04:00
John Kleinschmidt
a31deea1ba
ci: fixup diagnose_goma_log.py call ( #40131 )
2023-10-09 15:19:21 +02:00
Milan Burda
24bc0ee5c7
test: fix "crashed event does not crash main process when destroying WebContents in it" ( #40135 )
2023-10-09 09:56:48 +02:00
Cheng Zhao
f5c177698e
fix: remove EarlyMallocZoneRegistration call ( #40128 )
2023-10-09 09:43:51 +09:00
Milan Burda
737e3de3fa
chore: restore deprecate as an internal module ( #40124 )
...
* Revert "refactor: don't expose deprecate as an internal module (#35311 )"
This reverts commit 8424779906 .
* check crashed event warnings
2023-10-09 08:55:16 +09:00
David Sanders
8b8fbd0408
test: add back smoke test for removed API ( #40132 )
2023-10-09 08:46:56 +09:00
Milan Burda
6a99c7b840
refactor: eliminate duplicate code ( #40088 )
2023-10-09 08:43:50 +09:00
Keeley Hammond
cff50ac65a
fix: fix vibrancy applying without transparency on MacOS ( #40109 )
2023-10-06 11:57:26 -07:00
github-actions[bot]
a55c163db0
build: update appveyor image to latest version - e-119.0.6045.0 ( #40075 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-06 11:47:17 -04:00
Robo
fdf8b02e14
chore: cherry-pick c03569f from libuv ( #40101 )
...
Refs c03569f0df
2023-10-06 19:25:19 +09:00
Shelley Vohr
73553032ea
fix: toggling DevTools while minimized on Windows ( #40091 )
...
fix: toggling devtools while minimized on Windows
2023-10-05 20:26:31 -04:00
electron-roller[bot]
8f7a48879e
chore: bump chromium to 119.0.6045.0 (main) ( #40076 )
...
* chore: bump chromium in DEPS to 119.0.6045.0
* chore: update patches
* 4864948: Remove legacy-legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4864948
* 4907760: Remove ui/base/glib/glib_signal.h
https://chromium-review.googlesource.com/c/chromium/src/+/4907760
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-05 19:59:39 -04:00
Milan Burda
83a928f6e3
fix: crashed events deprecation ( #40090 )
2023-10-05 19:57:14 -04:00
Shelley Vohr
3392d9a2e7
fix: all children showing when showing child window ( #40062 )
2023-10-05 09:19:57 -04:00
David Sanders
5ad69df52e
build: update NMV to 119 ( #40081 )
2023-10-05 09:14:02 -04:00
Shelley Vohr
b3a1c6d13c
fix: error using webcrypto.subtle.importKey() ( #40070 )
...
fix: error using webcrypto.subtle.importKey()
2023-10-05 10:46:53 +02:00
Shelley Vohr
b0590b6ee8
fix: failing build with enable_electron_extensions=false ( #40032 )
...
* fix: ENABLE_EXTENSIONS -> ENABLE_ELECTRON_EXTENSIONS
* fix: extension guard fixes
* chore: fix linker errors
2023-10-04 10:40:01 +02:00
Shelley Vohr
713d8c4167
feat: add tabbingIdentifier property to BrowserWindow ( #39980 )
...
feat: add tabbingIdentifier property to BrowserWindow
2023-10-03 12:27:40 -07:00
Milan Burda
04b2ba84cd
refactor: replace remaining NULL with nullptr ( #40053 )
...
refactor: use nullptr everywhere
2023-10-03 12:26:35 -07:00
electron-roller[bot]
9d0e6d09f0
chore: bump chromium to 119.0.6043.0 (main) ( #40045 )
...
* chore: bump chromium in DEPS to 119.0.6036.0
* chore: bump chromium in DEPS to 119.0.6037.0
* chore: bump chromium in DEPS to 119.0.6039.0
* chore: bump chromium in DEPS to 119.0.6041.0
* chore: update chromium patches
* 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230
* 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325
* chore: update all patches
* chore: bump chromium in DEPS to 119.0.6043.0
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* 4837192: Plumb origin through for drags.
https://chromium-review.googlesource.com/c/chromium/src/+/4837192
* Prevent content analysis on web pages that don't accept drag and drop.
https://chromium-review.googlesource.com/c/chromium/src/+/4814086
* Make getting displayed notifications work with notification attribution.
https://chromium-review.googlesource.com/c/chromium/src/+/4738935
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* chore: remove Goma warning from mksnapshot_args
* 4776412: Remove Windows-specific wstring variants of StringPrintf() etc.
https://chromium-review.googlesource.com/c/chromium/src/+/4776412
* [dPWA] Prevent WebAppInstallInfo from being included on Android
https://chromium-review.googlesource.com/c/chromium/src/+/4886594
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-02 18:01:07 -04:00
github-actions[bot]
503ae86ab2
build: update appveyor image to latest version - e-119.0.6029.0 ( #40046 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-02 11:11:07 -04:00
Athul Iddya
37c79ea844
docs: add PipeWire integration instructions for snaps ( #40019 )
2023-10-02 12:19:23 +02:00
Shelley Vohr
93bcb30c3e
fix: BroadcastChannel initialization location ( #40049 )
...
fix: `BroadcastChannel` initialization location (#37421 )
* fix: BroadcastChannel initialization location
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-02 10:57:09 +02:00
Milan Burda
d301616f60
chore: remove deprecated app.runningUnderRosettaTranslation() ( #39956 )
2023-10-02 10:55:32 +02:00
Shelley Vohr
5643e86956
chore: update extensions url handling to match upstream ( #40038 )
...
- https://chromium-review.googlesource.com/c/chromium/src/+/4772028
- https://chromium-review.googlesource.com/c/chromium/src/+/4264656
- https://chromium-review.googlesource.com/c/chromium/src/+/4712150
2023-10-02 10:35:00 +02:00
Samuel Attard
371e83a8d2
fix: support esm entrypoint to utility process ( #40047 )
2023-09-29 14:38:37 -07:00
electron-roller[bot]
d6c8ff2e70
chore: bump chromium to 119.0.6029.0 (main) ( #39944 )
...
* chore: bump chromium in DEPS to 119.0.6021.0
* 4727729: Initial ScreenCaptureKit AudioInputStream implementation
https://chromium-review.googlesource.com/c/chromium/src/+/4727729
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6023.0
* 4875713: mac: Switch to Xcode 15.0 15A240d with macOS SDK 14.0 23A334
https://chromium-review.googlesource.com/c/chromium/src/+/4875713
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4877868: Remove all gitignore entries for submodules
https://chromium-review.googlesource.com/c/chromium/src/+/4877868
* 4824705: Set origin to commit for data: URLs
https://chromium-review.googlesource.com/c/chromium/src/+/4824705
* chore: fixup patch indices
* 4881382: Expose selection in WebFormControlElement as unsigned
https://chromium-review.googlesource.com/c/chromium/src/+/4881382
* 4874216: Portals: Cancel drag-drop in predecessor before activation
https://chromium-review.googlesource.com/c/chromium/src/+/4874216
* chore: bump chromium in DEPS to 119.0.6025.0
* chore: bump chromium in DEPS to 119.0.6027.0
* 4884489: Update gitignore to be explicit about directories
https://chromium-review.googlesource.com/c/chromium/src/+/4884489
* 4881091: Add debug info about owner document's origin when inheriting
https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6029.0
* chore: update patches
* 4881091: Add debug info about owner document's origin when inheriting
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4866732: Extract document.title for installable checks
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4866732
* chore: link to crbug in message port test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-28 22:26:41 -07:00
ILikeTeaALot
d002f16157
feat: systemPreferences.getColor should return RGBA instead of RGB ( #38960 )
...
* fix: return RGBA hex value from `SystemPreferences.getColor`
* docs: update docs to match changes of last commit
* fix: GetColor on windows now returns RGBA too
* fix: update tests for getColor RGBA on Windows
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-28 18:56:16 -04:00
Bruno Pitrus
dd7395ebed
chore: add missing include for std::variant ( #40007 )
2023-09-28 12:50:58 -04:00
Bruno Pitrus
e3e793d25b
chore: remove invalid constexpr qualification ( #40006 )
...
GetPathConstant calls base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::find(Key const&) const which is not constexpr.
GCC 12 and earlier raise a compile error on this.
2023-09-28 12:49:09 -04:00
dependabot[bot]
da92c9aa27
build(deps): bump get-func-name from 2.0.0 to 2.0.2 in /spec ( #40012 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 12:47:36 -04:00
David Sanders
02b58333dc
ci: update release project board workflows ( #40020 )
2023-09-28 11:27:02 -04:00
David Sanders
23cf9fa4e9
ci: update automation workflows ( #40021 )
2023-09-28 11:26:04 -04:00
Cheng Zhao
4cf6884dd4
fix: detect screen readers by testing their existences ( #39988 )
2023-09-28 11:17:42 -04:00
marekharanczyk
94585f5889
fix: propagate layout call to all children of InspectableWebContentsViewViews ( #39994 )
...
Propagate layout call to all children of InspectableWebContentsViewViews.
When BrowserView bounds are set from js, those might not trigger layout
immediately, sometimes propagating InvalidateLayout call to parent.
View is marked as needing layout, expecting to receive it from parent on
next layout call. The problem is that BrowserView's view is added as child
of InspectableWebContentsViews which does not call setBounds (which
would trigger layout) on all of it's children when doing it's layout,
so it skips propagating Layout call to its children BrowserViews views,
even though those were marked as needing layout.
Call base class View::Layout which will iterate over views' children
and call Layout on those that were marked as needing them.
Fixes #39993 .
2023-09-28 11:17:21 -04:00
John Kleinschmidt
43a646ed85
build: log uploads to GitHub ( #40034 )
2023-09-28 11:15:52 -04:00
dependabot[bot]
f628ce67dd
build(deps): bump get-func-name from 2.0.0 to 2.0.2 ( #40013 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 10:44:16 +02:00
Shelley Vohr
c8156c3c57
fix: failure on immutable webContents.print(options) ( #39985 )
...
fix: failure on immutable webContents.print(options)
2023-09-28 10:41:46 +02:00
Tomasz
689d1b76de
feat: add middle click event to tray ( #39926 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:21:15 -04:00
Robert Günzler
480f48b2fc
feat: enable dark mode on GTK UIs ( #38977 )
...
feat: port DarkModeManagerLinux
This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903
and replaces the previous workaround to detect dark mode on GTK.
Detect system dark theme preference via xdg settings portal:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings
Closes: https://github.com/electron/electron/issues/38961
Closes: https://github.com/electron/electron/issues/28838
Signed-off-by: Robert Günzler <r@gnzler.io >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:17:40 -04:00
Erick Zhao
a0ae691a9c
docs: document type-specific module aliases ( #39685 )
2023-09-27 11:07:04 -04:00
Bruno Henrique da Silva
f943b8c940
fix: set window contents as opaque to decrease DWM GPU usage ( #39895 )
...
* set window contents as opaque to decrease DWM GPU usage
* chore: add more context to ShouldWindowContentsBeTransparent
2023-09-27 10:42:46 -04:00
Shelley Vohr
b7c9c895b5
build: fix with enable_pdf_viewer = false ( #39990 )
...
build: fix with enable_pdf_viewer = false
2023-09-27 10:09:53 -04:00
Shelley Vohr
1ba321b733
fix: rounded corners on vibrant macOS modals ( #39979 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 15:12:37 +02:00
Cheng Zhao
ad57867594
fix: apply size constraints to NSWindow ( #39975 )
2023-09-27 11:11:24 +02:00
Cheng Zhao
e613595982
build: allow overriding electron version ( #39974 )
2023-09-27 14:49:10 +09:00
NoxFly
624ae024e2
docs: Quick Start | Electron Forge chapter requirements updated ( #39639 )
...
* Update quick-start.md
Added a note to a pre-require of Electron Forge.
Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild`
* Add two required steps for Electron Forge to build without errors
* Update docs/tutorial/quick-start.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-09-27 08:56:39 +09:00
michal-pichlinski-openfin
2190793fe6
fix: disable background throttling also in the viz::DisplayScheduler ( #38924 )
...
* fix: disable background throttling also in the `viz::DisplayScheduler`
`viz::DisplayScheduler` is responsible for drawing and swapping frames
in the `DisplayScheduler::DrawAndSwap` which is called from the
`DisplayScheduler::AttemptDrawAndSwap` if the `DisplayScheduler::ShouldDraw`
returns true. `ShouldDraw` depends on the `DisplayScheduler` visibility
and when it is not visible then it returns false.
In order to keep producing frames, disabling `backgroundThrottling`
should also prevent changing `DisplayScheduler` visibility to false.
`DisplayScheduler` lives in the `ui::Compositor` where every
`electron::NativewWindow` has its own `Compositor`. `electron::NativewWindow`
may be host of the multiple `electron::api::WebContents` instances which may
have different `WebPreferences` settings. Therefore if at least one
of the `WebContents` requires disabling throttling then all other `WebContents`
using the same window will have it disabled in the `ui::Compositor`.
BREAKING CHANGE:
`backgroundThrottling` set to false will disable frames throttling
in the `BrowserWindow` for all `WebContents` displayed by it.
Close: [#31016 ](https://github.com/electron/electron/issues/31016 )
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-26 16:00:46 -04:00
Milan Burda
fa215f1009
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md ( #39897 )
...
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md
2023-09-26 13:42:56 -04:00
John Kleinschmidt
943bfa89ce
test: fixup parallel/test-node-output-error test ( #39972 )
2023-09-25 16:23:05 -04:00
Milan Burda
d75a852743
refactor: use type enum in file stats for asar archive ( #39889 )
2023-09-25 13:17:24 +02:00
David Sanders
18f517d8a6
test: vendor node-is-valid-window ( #39965 )
2023-09-25 12:43:57 +02:00
Leon
fdf1ecec47
docs: correct v24 Alpha date ( #39963 )
2023-09-24 23:03:29 -07:00
John Kleinschmidt
beb52ce61c
build: update patch ( #39950 )
2023-09-22 10:33:29 -07:00
Erick Zhao
2085aae915
docs: esm tutorial ( #39722 )
...
* docs: esm tutorial
* Update esm.md
* Update docs/tutorial/esm.md
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
* table adjustment
* fix lint
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update esm.md
---------
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-22 09:49:16 -07:00
Fredy Whatley
7c2df8860b
docs: tiny update on example message-ports.md ( #39884 )
...
Update message-ports.md
fix multiplying object * a number. It would multiply number * number.
2023-09-21 11:46:23 -04:00
github-actions[bot]
56e45baeb8
build: update appveyor image to latest version - e-119.0.6019.2 ( #39924 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-21 09:49:04 -04:00
Robo
5f712fa325
chore: cherry-pick tls shutdown crash fix from upstream ( #39928 )
2023-09-21 09:47:31 -04:00
John Kleinschmidt
ba8915242a
ci: fix linux builds of forks ( #39933 )
2023-09-21 12:10:46 +02:00
Milan Burda
c9eb3deab5
chore: remove deprecated scroll-touch-{begin,end,edge} events ( #39814 )
...
* chore: remove deprecated `scroll-touch-{begin,end,edge}` events
* update spec/ts-smoke
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 17:41:29 -04:00
Valentin Hăloiu
58fd8825d2
fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var ( #39792 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 16:21:23 -04:00
Milan Burda
6a8b70639b
fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 ( #39920 )
...
fix: app.runningUnderARM64Translation() always returning true on ARM64
2023-09-20 16:15:19 -04:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:13:43 -04:00
electron-roller[bot]
28eda03aba
chore: bump chromium to 119.0.6019.2 (main) ( #39925 )
...
* chore: bump chromium in DEPS to 119.0.6018.4
* chore: update patches
* chore: bump chromium in DEPS to 119.0.6019.2
* chore: update patches
* 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4876292
* 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts
https://chromium-review.googlesource.com/c/chromium/src/+/4851616
* 4869393: [Extensions UserScripts] Add error messages for script matching errors
https://chromium-review.googlesource.com/c/chromium/src/+/4869393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:08:26 -04:00
George Xu
7685f27b31
feat: expose app accessibility transparency settings api ( #39631 )
...
* feat: expose app accessibility transparency settings api
* docs: fix typo
* chore: add doc
* change to property
* add as property instead of method
* chore: fix lint
* rename function name in header
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-20 12:48:02 -07:00
Shelley Vohr
463586a6c5
chore(deps): roll nan to pick up upstreams ( #39916 )
2023-09-20 15:37:10 +02:00
electron-roller[bot]
a39c0ee659
chore: bump chromium to 119.0.6017.0 (main) ( #39922 )
...
* chore: bump chromium in DEPS to 119.0.6017.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-20 11:30:38 +02:00
github-actions[bot]
0b0a8a5ef3
build: update appveyor image to latest version, e-119.0.6006.0 ( #39908 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-19 23:46:47 -07:00
electron-roller[bot]
986becdb4d
chore: bump chromium to 119.0.6016.0 (main) ( #39898 )
...
* chore: bump chromium in DEPS to 119.0.6016.0
* chore: update patches
* 4839124: Rename chrome/app/ branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/4839124
* 4846834: Clean up PrintRenderFrameHelper interaction with Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/4846834
* 4850759: Cache bounds of document pip windows
https://chromium-review.googlesource.com/c/chromium/src/+/4850759
* 4864669: Roll libc++ from 84fb809dd6da to 68a6f0b88287 (352 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4864669
* 4863987: Remove five gpu workarounds.
https://chromium-review.googlesource.com/c/chromium/src/+/4863987
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-19 19:34:56 +02:00
Samuel Attard
75ea294b6f
build: use afs on aks instead of circle cache ( #39881 )
...
* build: use afs on aks instead of circle cache
* build: do not use aks logic on linux hosts checking out for macOS
* build: fix gn-check could-be-aks
* build: sigh
* build: no ls mnt
* build: keep build alive while debugging
* build: make debuggable
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-19 03:12:14 -07:00
spencer17x
18717ee62d
docs: add a more detailed explanation to cookies.flushStore() ( #37572 )
...
* docs: cookies.flushStore()
* docs: modify cookies.flushStore()
* Update docs/api/cookies.md
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-18 16:51:46 -04:00
electron-roller[bot]
73e33bc876
chore: bump chromium to 119.0.6006.0 (main) ( #39774 )
...
* chore: bump chromium in DEPS to 119.0.5994.0
* chore: update patches
* Add some more debugging for navigation origin & process lock mismatch
https://chromium-review.googlesource.com/c/chromium/src/+/4829483
* chore: bump chromium in DEPS to 119.0.5996.2
* chore: bump chromium in DEPS to 119.0.5997.0
* chore: bump chromium in DEPS to 119.0.6000.0
* chore: bump chromium in DEPS to 119.0.6002.0
* 4781766: Port remaining control color ids to the color pipeline
https://chromium-review.googlesource.com/c/chromium/src/+/4781766
* 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/
https://chromium-review.googlesource.com/c/chromium/src/+/4846057
* chore: fixup patch indices
* 4848108: Pass v8::Isolate into FromV8Value calls on blink API
https://chromium-review.googlesource.com/c/chromium/src/+/4848108
* 4834471: Reland "[api] allow v8::Data as internal field"
https://chromium-review.googlesource.com/c/v8/v8/+/4834471
* 4808884: Major overhaul of ExceptionState in the v8 bindings
https://chromium-review.googlesource.com/c/chromium/src/+/4808884
* 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap
https://chromium-review.googlesource.com/c/v8/v8/+/4791643
* chore: bump chromium in DEPS to 119.0.6005.0
* 4776268: [v8][etw] Enables filtering of ETW tracing by URL
https://chromium-review.googlesource.com/c/chromium/src/+/4776268
* chore: fixup patch indices
* 4673258: WebSQL: Disable WebSQL by default
https://chromium-review.googlesource.com/c/chromium/src/+/4673258
* chore: bump chromium in DEPS to 119.0.6006.0
* chore: update patches
* 4854732: Reland^2 "[iterator-helpers] Unship due to incompat"
https://chromium-review.googlesource.com/c/v8/v8/+/4854732
* 4794133: [AWC] Add `display-state` CSS @media feature
https://chromium-review.googlesource.com/c/chromium/src/+/4794133
* fixup! Add some more debugging for navigation origin & process lock mismatch
* Revert "fixup! Add some more debugging for navigation origin & process lock mismatch"
This reverts commit 38fef075fc .
* 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks"
https://chromium-review.googlesource.com/c/chromium/src/+/4858437
* refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879 )
* chore: 4869108: handle absolute and relative gn imports in autoninja
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108
* chore: set GOMA_DIR for autoninja
* Revert "chore: 4869108: handle absolute and relative gn imports in autoninja"
This reverts commit d94c7720ba .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com >
2023-09-18 16:44:09 -04:00
John Kleinschmidt
c8544e25df
build: fixup autoninja ( #39896 )
...
chore: set GOMA_DIR for autoninja
(cherry picked from commit 94f24bde4d )
(cherry picked from commit 90c1f6e1cb8d22d94dd01791dc4b9c3e0a7e86fc)
2023-09-18 16:43:27 -04:00
Milan Burda
9c7086074e
docs: add missing ipcRenderer.off() / ipcRenderer.addListener() aliases ( #39816 )
...
* docs: add missing `ipcRenderer.off()` / `ipcRenderer.addListener()` aliases
* Update docs/api/ipc-renderer.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix ipcRenderer.removeListener
* update ts-smoke
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-19 01:58:20 +09:00
Milan Burda
d7e4bb6608
chore: remove no-op fullscreenWindowTitle option ( #39815 )
2023-09-19 01:55:47 +09:00
David Sanders
706653d5e4
ci: fix issue-commented workflow sytnax ( #39875 )
2023-09-17 19:23:59 -07:00
John Kleinschmidt
65952abc99
test: fixup node flakes ( #39871 )
...
chore: fixup node flakes
2023-09-15 03:43:13 -07:00
Athul Iddya
50ce02c312
fix: check PipeWire init before creating generic capturer ( #39846 )
...
Check if PipeWire can be initialized before creating generic capturer.
This harmonizes the conditions with the ones used in Linux
implementations of DesktopCapturer::CreateRawScreenCapturer and
DesktopCapturer::CreateRawWindowCapturer.
2023-09-14 15:50:20 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
David Sanders
d6c04a3787
ci: ignore actions taken by triage bot ( #39855 )
...
* ci: ignore actions taken by triage bot
* ci: don't remove blocked label on bot comment
2023-09-14 14:01:07 -04:00
Samuel Attard
2791474a01
build: run on circle hosts for forks ( #39858 )
2023-09-14 11:07:11 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
David Sanders
650ef9a51c
build: update @electron/lint-roller to 1.9.0 ( #39812 )
2023-09-12 12:38:31 +02:00
Charles Kerr
a1c44a18e2
fix: NodeService order-of-destruction issue ( #39783 )
...
* refactor: make ElectronRendererClient::node_bindings_ a const ptr
refactor: make ElectronRendererClient::electron_bindings_ a const ptr
* fix: order-of-destruction bug in NodeService
js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_
* chore: revert unintentional commit
2023-09-12 12:27:14 +02:00
Shelley Vohr
ec9c8476fe
fix: keyCodes being incorrectly converted in webContents.sendInputEvent() ( #39776 )
...
fix: sendInputEvent keyCodes being incorrectly converted
2023-09-12 11:28:45 +02:00
Samuel Attard
470a14d8d4
docs: add missing macOS tag
2023-09-11 14:07:25 -07:00
Samuel Attard
5bff0fe342
feat: add new ElectronSquirrelPreventDowngrades flag ( #38625 )
...
* sketch
* feat: add new ElectronSquirrelPreventDowngrades flag
* test: remove only
* chore: fix lint
2023-09-11 11:54:51 -07:00
Samuel Attard
16aec702b4
fix: ensure app load is limited to real asar files when appropriate ( #39788 )
2023-09-11 11:51:14 -07:00
Samuel Attard
ac040bf734
build: update @electron/typescript-definitions to fix titlebaroverlay ( #39799 )
...
build: update @electron/typescript-definitions to fix titlebarstyle
2023-09-11 11:36:36 -07:00
David Sanders
aceb432f45
chore: remove deprecated systemPreferences APIs ( #39696 )
2023-09-11 11:34:13 -04:00
Calvin
d182794179
fix: frameless mica/acrylic windows ( #39708 )
...
* fix: backgroundMaterial works with frameless
* TODO: fix frameless mica/acrylic windows
* update caption color appropriately
* set background color properly
* refactor translucency method
* actualization
2023-09-11 14:51:54 +02:00
Shelley Vohr
ab185c058f
fix: fullscreen crashing with no roundedCorners and no frame ( #39747 )
2023-09-11 09:38:10 +02:00
David Sanders
2324c4d8fd
ci: ignore blocked label removed on closed issues ( #39793 )
2023-09-11 09:33:39 +02:00
Charles Kerr
792037b338
fix: raw_ptr destruction order in NodeBindings ( #39762 )
2023-09-07 18:25:17 -05:00
Samuel Attard
0b44f433c8
fix: make titlebar opaque while fullscreen ( #39759 )
2023-09-07 15:55:17 -07:00
github-actions[bot]
5fa9dee68a
build: update appveyor image to latest version e-118.0.5993.0 ( #39765 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-07 09:40:42 -04:00
Shelley Vohr
75bad34131
fix: prevent errors when extensions listen for chrome.tabs events ( #39729 )
...
* fix: prevent errors when extensions listen for chrome.tabs events
* chore: mark events unsupported in Electron
2023-09-07 12:41:24 +02:00
Robo
0a064cece9
fix: devtools allow restoring saved dock state on Windows ( #39734 )
...
* fix: devtools allow restoring saved dock state on Windows
* chore: address feedback
2023-09-07 17:14:01 +09:00
Milan Burda
f6e8544ef6
refactor: use replaceAll() instead of replace() when appropriate ( #39721 )
...
refactor: use replaceAll() instead of replace() when appropriate
2023-09-07 15:50:14 +09:00
electron-roller[bot]
029127a8b6
chore: bump chromium to 118.0.5993.0 (main) ( #39745 )
...
* chore: bump chromium in DEPS to 118.0.5993.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-06 19:27:25 -04:00
Milan Burda
e71a56d11e
refactor: const Module = require('module') as NodeJS.ModuleInternal; ( #38757 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-09-06 18:04:25 -04:00
Samuel Attard
65901f4c6a
fix: restore flag that allowed websockets to not be backgrounded ( #39738 )
2023-09-06 11:23:17 -07:00
github-actions[bot]
feb804cea8
build: update appveyor image to latest version ( #39716 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-06 14:07:34 -04:00