Simen Bekkhus
8c63dd93a7
Remove false comment
2016-04-19 08:39:16 +02:00
Jordan Harband
e856d93ada
[deps] update eslint-plugin-react, eslint-plugin-import
2016-04-18 23:23:55 -07:00
Jordan Harband
a9db06e1dd
[eslint config] Add eslint-find-rules to prevent missing rules.
2016-04-17 13:09:21 -07:00
Jordan Harband
12d08b38dc
[eslint config] Add missing disabled rules.
2016-04-17 13:05:01 -07:00
Jordan Harband
e1cbcbecf6
[eslint config] [breaking] enable global-require rule
2016-04-17 13:03:16 -07:00
Jordan Harband
6efcda314d
[eslint config] [breaking] enable no-restricted-syntax rule.
...
Forbids “with”, “break”, “debugger”, “for..in”, and labels.
2016-04-17 12:58:55 -07:00
Jordan Harband
140ce8b56c
[eslint config] [breaking] disallow empty restructuring patterns
2016-04-17 12:52:23 -07:00
Jordan Harband
3efe10d42e
[eslint config] [breaking] disallow empty methods
2016-04-17 12:48:54 -07:00
Jordan Harband
c97bd772b4
[eslint config] [react] separate a11y rules to their own file
2016-04-17 13:22:41 -07:00
Jordan Harband
48ab6d6e76
[eslint config] [react] [semver-minor] enable jsx-indent rule
2016-04-17 13:19:40 -07:00
Jordan Harband
066c3b1a3c
[eslint config] [react] [semver-minor] enable jsx-equals-spacing rule
2016-04-17 13:18:39 -07:00
Jordan Harband
970848f1a2
[eslint config] [semver-minor] enforce spacing inside single-line blocks.
2016-04-17 12:45:37 -07:00
Jordan Harband
c86cfaa6f9
[eslint config] [semver-patch] Enable no-useless-concat rule which prefer-template already covers
2016-04-17 12:53:54 -07:00
Jordan Harband
f468a52d82
[eslint config] [tests] remove parallelshell
2016-04-17 13:15:13 -07:00
Jordan Harband
f268237c71
[eslint config] [react] [semver-minor] Add react/jsx-first-prop-new-line rule
2016-04-17 12:30:28 -07:00
Jordan Harband
4ab741190c
[eslint config] [react] update eslint-plugin-react
2016-04-17 12:28:18 -07:00
Jordan Harband
c29560441e
[eslint config] It doesn’t matter which react version we install since we’re just testing module resolution.
2016-04-16 11:53:21 -07:00
Jordan Harband
cbd2c38da8
[eslint config] [dev deps / peer deps] update eslint
2016-04-16 11:50:21 -07:00
Jordan Harband
81d01645c2
[eslint config] remove need for a local symlink.
2016-04-16 11:05:25 -07:00
Jordan Harband
fc1443b80f
[guide] add link on perf of array iteration methods
2016-04-16 09:54:28 -07:00
Jordan Harband
688ef3c2eb
[guide] remove AIIFE to avoid CallExpression quirk.
...
Fixes #828 .
2016-04-15 19:24:48 -07:00
Jordan Harband
56e6815a84
[guide] Attempt to clarify filename conventions
...
Fixes #817 .
2016-04-13 22:37:46 -07:00
Joe Lencioni
eb4f7cb3a8
Properly capitalize ECMAScript
2016-04-14 09:06:33 -07:00
Joe Lencioni
531950cc26
Add plugin requirements to config package readme
...
I missed these when I added some eslint-plugin-import rules.
2016-04-14 09:05:24 -07:00
Jordan Harband
92a66ccc7c
[guide] [breaking] Disallow leading underscores - there’s no such thing as “private properties”.
...
Per https://github.com/airbnb/javascript/issues/490#issuecomment-209126331
2016-04-12 15:27:09 -07:00
Jordan Harband
4af3f9755e
Merge pull request #825 from lencioni/eslint-plugin-import
...
[eslint config] [semver-minor] Enable import/no-unresolved and import/export rules
2016-04-13 17:55:14 -07:00
Joe Lencioni
0fe4f558a6
Enable import/no-unresolved and import/export rules
...
These come from eslint-plugin-import. We've been using these rules for a
while at Airbnb so it seems like a good time to include them in this
configuration. We've found the no-unresolved rule in particular to be
very helpful when working across a large codebase.
https://github.com/benmosher/eslint-plugin-import
Since the no-unresolved rule works on commonjs, I decided to include it
in the node configuration as well.
I think there are some more rules from this plugin that are worth
enabling, but this seems like a great place to start.
2016-04-13 17:13:00 -07:00
Joe Lencioni
662519efc0
Link to eslint.org instead of github where possible
...
In most cases we link to documentation on the eslint.org site instead of
on GitHub. I found a couple of stragglers and decided to make things a
little more consistent.
2016-04-13 14:24:53 -07:00
Jordan Harband
956f91527b
[eslint config] [semver-minor] enforce no-underscore-dangle
2016-04-12 15:32:11 -07:00
C. T. Lin
9060fba34a
Added eslint-plugin-jsx-a11y to install script
2016-04-12 13:38:25 +08:00
Jordan Harband
bcc5c5d8dd
[Tests] run subpackage tests at top level.
2016-04-11 15:30:48 -07:00
Jordan Harband
93b0a10eb7
[eslint config] v7.0.0
2016-04-11 15:24:22 -07:00
Jordan Harband
66ec951087
[eslint config] [peer deps] update eslint-plugin-jsx-a11y
2016-04-11 15:22:26 -07:00
Joe Lencioni
a929776d67
Improve guideline for image alt text
...
After digging into this rule a little more with @evcohen, we believe that
it is okay for images to have an empty string for alt text and have
updated the plugin to reflect that understanding. This commit bumps our
dependency on the rule to include this fix and updates our guideline to
match.
2016-04-08 18:42:51 -07:00
Brett Sanders
f5d6e9646c
[guide] Update eslint rule for keyword-spacing, small fix for consistency
2016-04-07 14:02:11 -07:00
Jordan Harband
7c0bb0a6de
[eslint config] [breaking] enable react/require-render-return
2016-04-06 22:57:44 -07:00
Jordan Harband
7b5731157f
[eslint config] [semver-minor] enable jsx-pascal-case rule.
2016-04-06 22:52:55 -07:00
Jordan Harband
6fd8fb60b3
[eslint config] [dev deps] update eslint, eslint-plugin-react
2016-04-06 22:51:47 -07:00
Jordan Harband
c5366984b3
Merge pull request #813 from lencioni/jsx-a11y
...
[eslint config] [react] [breaking] Add accessibility rules to the React style guide + `eslint-plugin-a11y`
2016-04-06 15:04:51 -07:00
Joe Lencioni
3f73e35b18
Use jsx fenced codeblocks for JSX code
...
GitHub knows how to do JSX syntax highlighting. Since we are using JSX
in this document, I figured we might as well tell GitHub to highlight
the syntax as JSX here. This will lead to a better reading experience.
2016-04-06 14:51:45 -07:00
Joe Lencioni
f697a15e50
Add note and rule about not using accessKey
...
Inconsistencies between keyboard shortcuts and keyboard commands used by
people using screenreaders and keyboards complicate accessibility.
2016-04-06 14:51:44 -07:00
Joe Lencioni
0c3b13fe93
Add note and rule about valid, non-abstract ARIA roles
...
This rule will help people use only valid roles, which might save people
from simple, accessibility-busting mistakes.
2016-04-06 14:51:44 -07:00
Joe Lencioni
f2aca29ed9
Add note and rule about redundant alt text
...
Screenreaders already announce `img` elements as images, so there is no
need to include this information in the alt text. This will give people
using assistive technologies a smoother experience.
2016-04-06 14:51:44 -07:00
Joe Lencioni
acbddc1083
Add note and rule about image alt text
...
We want our React apps to be accessible. One thing that developers can
do is properly use alt text on images. Thankfully, there is an ESLint
rule that will enforce these things for us.
2016-04-06 14:51:22 -07:00
Kevin Moot
6e770062bb
Adding The Nerdery to the "In the Wild" section
2016-04-04 19:07:35 -05:00
Peter Kuiper
a2bdbb83d1
Add KickorStick to 'In the Wild'
2016-04-04 14:20:17 +02:00
Amin
f21412cba9
Broken link to Classes and constructors
2016-04-04 11:39:47 +04:00
Nick
6671a55556
CHORE - Remove Trailing Spaces
2016-04-03 09:59:12 -04:00
Jordan Harband
76e1e4c1de
[eslint config] [breaking] Add no-dupe-class-members rule + section.
...
Closes #785 .
2016-04-02 18:08:27 -07:00
Jordan Harband
5b9f081d1d
[eslint config] [deps] update eslint, react
2016-04-02 17:46:24 -07:00
