github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
18,890 Commits 34 Branches 105 Tags
1e63a05d28fd7ebee2f962fc190d3e2af429dcb9
Commit Graph

18890 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ryan Bigg
1e63a05d28 Add "a" to make it better English 
[#3796 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-07 11:40:57 -02:00
Xavier Noria
db520042b3 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-06 23:16:13 +02:00
Thomas McDonald
3ca6988b78 Fixed typo in engine documentation 2010-10-06 22:11:03 +01:00
Hemant Kumar
2a04110f26 fix ruby 1.9 deadlock problem, fixes #5736 add connection pool tests 2010-10-06 14:45:56 -06:00
Rafael Mendonça França
a0552d653b Fixes typo 2010-10-06 12:55:16 -03:00
José Valim
d649bf158b Provide a cleaner syntax for paths configuration that does not rely on method_missing. 2010-10-06 17:20:15 +02:00
wycats
d40ca9cce2 Some initial docs 2010-10-06 03:06:12 -07:00
wycats
0904e82568 Delegate everything to the generator 2010-10-06 02:58:49 -07:00
wycats
848eb0d777 Revert "Clean up the builder abstraction in AppGenerator." 
The phrase "clean up" misrepresents the fact that this removes
a feature that ships with Rails 3.0.

This reverts commit 6774e12afa.
 2010-10-06 02:53:00 -07:00
José Valim
6774e12afa Clean up the builder abstraction in AppGenerator. 
This commit may be reverted once documentation and a proper way to handle actions are added.
 2010-10-06 11:13:57 +02:00
Aditya Sanghi
ae812e9fc9 adding test for namedspaced mailers 2010-10-06 19:45:13 +11:00
Aditya Sanghi
990719bb59 mailer comment should use namespace in comment 2010-10-06 19:45:13 +11:00
Erik Michaels-Ober
19a5f99685 Fix copy/paste bug 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-06 09:21:01 +02:00
Xavier Noria
3b7d48cc45 a couple of touches to the guides guidelines 2010-10-05 22:52:43 +02:00
Xavier Noria
da34ee423f aaaaannnddd, your beloved typo only spotted in the github colored diff no matter how many passes you did before pushing 2010-10-05 19:38:05 +02:00
Xavier Noria
360a878070 new guide: Ruby on Rails Guides Guidelines 2010-10-05 19:34:27 +02:00
José Valim
68d75c3365 Don't expect an AD::Response object back from the app. 2010-10-05 09:55:51 +02:00
José Valim
4a4ff148ff Use RbConfig instead of Config for 1.9.3 compatibility. 2010-10-05 09:48:32 +02:00
Aaron Patterson
e3acdcfbf3 refactoring to use fewer intermediate variables 2010-10-04 20:05:56 -07:00
Aaron Patterson
839e2f9664 cleaning up more crazy! 2010-10-04 20:00:55 -07:00
Aaron Patterson
714fea4540 deleting more crazy 2010-10-04 19:52:17 -07:00
Aaron Patterson
333a5659e8 dry up some crazy codes 2010-10-04 19:46:38 -07:00
Aaron Patterson
5769636663 fixing a few test warnings 2010-10-04 19:32:49 -07:00
Aaron Patterson
1217339616 only forwarding enough methods to work. People should grab the delegate tempfile if they really need to do hard work 2010-10-04 19:28:40 -07:00
Aaron Patterson
3370ad0b1e making sure respond_to? works properly 2010-10-04 17:11:50 -07:00
Aaron Patterson
8a97470210 raising an argument error if tempfile is not provided 2010-10-04 17:08:25 -07:00
Aaron Patterson
876acf001a if it walks like a duck and talks like a duck, it must be a duck 2010-10-04 16:57:11 -07:00
Aaron Patterson
2a3022db7f delegate to the @tempfile instance variable 2010-10-04 16:56:45 -07:00
Aaron Patterson
f9734f2b0f adding tests for uploaded file 2010-10-04 16:30:16 -07:00
Aaron Patterson
28bb1885f5 avoid method call to compact 2010-10-04 16:08:01 -07:00
Aaron Patterson
e7d860c6be create fewer objects, call fewer methods in extract_pg_identifier_from_name 2010-10-04 15:25:20 -07:00
Aaron Patterson
d8135eb452 * + flatten is not required in >= Ruby 1.8.7 2010-10-04 15:19:27 -07:00
José Valim
232e56ce87 No need to pass self as parameter here. 2010-10-04 22:32:29 +02:00
Ernie Miller
21cb1d40b9 Test to_model being called in ActiveModel::Naming helpers 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-04 21:26:42 +02:00
Ernie Miller
33aaa15f62 Convert to model before calling model_name on a record in ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-04 21:26:41 +02:00
John Firebaugh
b1047888fb render :text => proc { ... } is no longer supported. 2010-10-04 11:14:42 -07:00
John Firebaugh
6644675831 Template::Error is also used if rendering fails. 2010-10-04 11:12:57 -07:00
Aaron Patterson
b7c49cedba calling correct method on minitest for test name when teardown callback fails 2010-10-04 09:34:34 -07:00
Aaron Patterson
ccf228b027 [#5406 state:resolved] calling the correct method on minitest to obtain the test name 2010-10-04 09:33:35 -07:00
José Valim
848e48ec9c Link to rack from github for this while. 2010-10-04 18:08:03 +02:00
José Valim
0b51f3cc73 Ensure the proper content type is returned for static files. 2010-10-04 18:06:04 +02:00
José Valim
10d014acb8 Update to Thor 0.14.3. 2010-10-04 13:46:37 +02:00
José Valim
3986fcb935 Initialize sid should just skip instance variables. 2010-10-04 08:47:36 +02:00
Aaron Patterson
69a2c6b041 converting inject([]) to map 2010-10-03 16:42:08 -07:00
Aaron Patterson
365c93b7cd speed up duplicate migration detection 2010-10-03 16:39:48 -07:00
Aaron Patterson
40761c4bf3 reduce the number of calls to camelize 2010-10-03 16:36:43 -07:00
Aaron Patterson
e6583901e5 convertion MigrationProxy to a Struct, initialize instance variables 2010-10-03 16:32:27 -07:00
Aaron Patterson
341e71a1b9 dry up some migration logic 2010-10-03 16:23:07 -07:00
Aaron Patterson
8beda11fd3 no need to differentiate between nil and false in this case 2010-10-03 16:13:45 -07:00
Nicholas E. May (on Enterprise)
66559107e1 Merge branch 'master' of github.com:lifo/docrails 2010-10-03 18:06:22 -05:00