github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,025 Commits 34 Branches 105 Tags
5314abed182450dbdcc25ebe601a2bbdf4cb926f
Commit Graph

10025 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yehuda Katz + Carl Lerche
5314abed18 Keep ActionMailer using the old layouts code until it gets refactored. 2009-06-15 11:59:28 -07:00
Yehuda Katz + Carl Lerche
80d1e27788 Fix the fixture path 2009-06-15 11:50:11 -07:00
Yehuda Katz + Carl Lerche
a63caa4c0c Get tests to run (with failures) without old base around 2009-06-15 11:44:45 -07:00
Yehuda Katz + Carl Lerche
614374b3e5 Require missing file in AS 2009-06-15 11:31:52 -07:00
Yehuda Katz + Carl Lerche
64ae5b56ff Fix failing tests in new callbacks 2009-06-15 11:26:47 -07:00
Yehuda Katz + Carl Lerche
5a8a550a45 Finish making things pass with updated internal content_type semantics 2009-06-15 11:21:08 -07:00
Joshua Peek
c50b03b754 Add :concat option to asset tag helpers to force concatenation. 
This is useful for working around IE's stylesheet limit.

  stylesheet_link_tag :all, :concat => true
 2009-06-15 10:23:23 -05:00
Xavier Noria
b56169c262 moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests 
[#2798 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-13 15:01:14 -07:00
Luca Guidi
9eeb5fed2f Bytes calculation speed up 
[#2800 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-13 14:03:45 -07:00
Xavier Noria
d32965399c uses Object#metaclass and Object#class_eval in a few spots 
[#2797 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-12 16:14:06 -07:00
Adam Milligan
54a5446641 HasOneThroughAssociation still shouldn't derive from HasManyThroughAssociation. 
[#1642 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-12 13:52:51 -07:00
Emilio Tagua
8db190acba HasOneAssociation inherits AssociationProxy since it shares nothing with BelongsToAssociation. 
[#2796 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-12 13:45:25 -07:00
Joshua Peek
8f7c657f4b Move observing notify helper into AMo 2009-06-11 13:41:48 -05:00
Joshua Peek
c4e440b1d2 Fix observing AS dependencies 2009-06-11 13:21:56 -05:00
Joshua Peek
4d70359200 Integrate ActiveModel::Observing into ActiveRecord 2009-06-10 23:36:44 -05:00
Andrew Kaspick
59c83af18b allow absolute paths for the asset caches 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-11 16:33:32 +12:00
Yehuda Katz + Carl Lerche
47ff57f6d1 Document and clean up HideActions and Http 2009-06-10 15:27:53 -07:00
Yehuda Katz + Carl Lerche
82a10ce9f6 Removed unnecessary code 2009-06-10 14:43:43 -07:00
Yehuda Katz + Carl Lerche
fbb6b936e9 Document ActionController::Helpers 2009-06-10 14:28:58 -07:00
Yehuda Katz + Carl Lerche
316fab7de6 Cleaned up the #default_helper_module method to make better use of #helper instead of duplicating code. 2009-06-10 14:15:21 -07:00
Yehuda Katz + Carl Lerche
37be453a87 Adding "test" to the lib directory when running action pack tests on new base 2009-06-10 12:26:03 -07:00
Yehuda Katz + Carl Lerche
4fc0778123 Simplify helper use of ActiveSupport::Dependencies, and use super better for in #helpers 2009-06-10 12:15:30 -07:00
Michael Koziarski
c014c3e5c1 Whitelist the methods which are called by multiparameter attribute assignment. 
This prevents users from causing NoMethodErrors and the like by editing the parameter names, and closes a potential exploit of CVE-2009-1904.
 2009-06-10 12:12:21 +12:00
Yehuda Katz + Carl Lerche
b6fde6b480 Clean up AbstractController::Logger and write documentation 2009-06-09 17:03:02 -07:00
Yehuda Katz + Carl Lerche
f35f47b8c0 Cleaning up and documenting AbstractController::Layouts 2009-06-09 16:47:40 -07:00
Yehuda Katz + Carl Lerche
acb2447785 Write documentation for AbstractController::Helpers 2009-06-09 16:47:39 -07:00
Matt Jones
d7e0cb05cc Fix incorrect specification path in GemDependency#from_directory_name 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-10 09:57:58 +12:00
Brian Lopez
69bc2043f9 enable *real* IO parsing for the libxml, nokogiri and rexml backends [#2659 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-06-09 09:01:50 -05:00
Stephen Anderson
a94e7d7897 Sanitized the id generated by text_area_tag helper method. text_area_tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:36:45 +12:00
David Stevenson
a14df8c9b2 Made label target radio button tags with values. Radio button now respects inherited :index options when generating id. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:28:43 +12:00
Raimonds Simanovskis
63091cef2e disabled base_test.rb tests that were not Oracle compatible (TIME datatype is not supported on Oracle, UPDATE does not support ORDER BY) _before_type_cast on Oracle returns Time and not String added Oracle specific schema definition that was missing for test_default_values test 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:26:55 +12:00
Friedrich Göpel
1d57ccbc6f 1.9 compatibility - don't pass an array as the from address as this ends up generating invalid SMTP commands. 2009-06-09 20:22:20 +12:00
Eugene Pimenov
74c1249d07 PostgreSQL adapter should call thread safe quote_string function 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:12:01 +12:00
Michael Koziarski
99803b7cdb Pull autoload fix from 2-3-stable 2009-06-09 20:10:21 +12:00
Matt Jones
41a94048e5 Fix several issues with the 2.3.2 gem loader. 
Incorporates the following:

- migrates back small change to gems:build:force from bfc1609a50 to finish closing #2266.

- unrolls to_proc calls in gems.rake, to match the change in master.

- fixes #2722 by passing the options hash to dependencies during build. (includes a test)

- fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.

- fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.

- fixes #2678 by passing the options hash to dependencies during unpack.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 19:57:38 +12:00
nate
f68cc639f5 A test to show that http_authentication needs to fail authentication if the password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 19:47:53 +12:00
Yehuda Katz
114e25e735 Further cleanup of callbacks 2009-06-09 19:47:53 +12:00
Yehuda Katz
8cae3cd0cf More pruning of NewCallbacks 2009-06-09 19:47:53 +12:00
Jeremy Kemper
e9a6255938 Lazier Rakefile requires to avoid needing full rake gem on 1.9 2009-06-08 20:49:21 -07:00
Jeremy Kemper
23f3b567e2 Uses Hash#symbolize_keys 2009-06-08 19:37:52 -07:00
Jeremy Kemper
5b256ac369 Prefer JSON.encode(value) to value.to_json 2009-06-08 19:37:52 -07:00
Jeremy Kemper
14de1a9597 each yields per message not per attribute 2009-06-08 19:37:51 -07:00
Jeremy Kemper
e1f679a020 Simplify json decoder backend lazy load 2009-06-08 19:37:51 -07:00
Jeremy Kemper
6e73cf6bdf Fix AR json encoding 2009-06-08 19:37:51 -07:00
Jeremy Kemper
99cf77be27 Add #element and #collection to ModelName 2009-06-08 19:37:50 -07:00
Jeremy Kemper
d9f16fafec Update for Active Model yielding per error not per attribute 2009-06-08 19:37:50 -07:00
Joshua Peek
27766ccf3b Make use of AS::Concern in ActiveResource 2009-06-08 20:52:27 -05:00
Joshua Peek
0b694a4ff4 Setup ActiveResource autoloads 2009-06-08 20:48:14 -05:00
Joshua Peek
28f36279cd Properly require ActiveModel validation dependencies 2009-06-08 20:32:08 -05:00
Joshua Peek
01515f8ecd Fix activesupport path 2009-06-08 19:59:56 -05:00