github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
18,857 Commits 34 Branches 105 Tags
714fea4540c96f70d044e2bd1be92b504d1f8fa3
Commit Graph

18857 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
714fea4540 deleting more crazy 2010-10-04 19:52:17 -07:00
Aaron Patterson
333a5659e8 dry up some crazy codes 2010-10-04 19:46:38 -07:00
Aaron Patterson
5769636663 fixing a few test warnings 2010-10-04 19:32:49 -07:00
Aaron Patterson
1217339616 only forwarding enough methods to work. People should grab the delegate tempfile if they really need to do hard work 2010-10-04 19:28:40 -07:00
Aaron Patterson
3370ad0b1e making sure respond_to? works properly 2010-10-04 17:11:50 -07:00
Aaron Patterson
8a97470210 raising an argument error if tempfile is not provided 2010-10-04 17:08:25 -07:00
Aaron Patterson
876acf001a if it walks like a duck and talks like a duck, it must be a duck 2010-10-04 16:57:11 -07:00
Aaron Patterson
2a3022db7f delegate to the @tempfile instance variable 2010-10-04 16:56:45 -07:00
Aaron Patterson
f9734f2b0f adding tests for uploaded file 2010-10-04 16:30:16 -07:00
Aaron Patterson
28bb1885f5 avoid method call to compact 2010-10-04 16:08:01 -07:00
Aaron Patterson
e7d860c6be create fewer objects, call fewer methods in extract_pg_identifier_from_name 2010-10-04 15:25:20 -07:00
Aaron Patterson
d8135eb452 * + flatten is not required in >= Ruby 1.8.7 2010-10-04 15:19:27 -07:00
José Valim
232e56ce87 No need to pass self as parameter here. 2010-10-04 22:32:29 +02:00
Ernie Miller
21cb1d40b9 Test to_model being called in ActiveModel::Naming helpers 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-04 21:26:42 +02:00
Ernie Miller
33aaa15f62 Convert to model before calling model_name on a record in ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-04 21:26:41 +02:00
Aaron Patterson
b7c49cedba calling correct method on minitest for test name when teardown callback fails 2010-10-04 09:34:34 -07:00
Aaron Patterson
ccf228b027 [#5406 state:resolved] calling the correct method on minitest to obtain the test name 2010-10-04 09:33:35 -07:00
José Valim
848e48ec9c Link to rack from github for this while. 2010-10-04 18:08:03 +02:00
José Valim
0b51f3cc73 Ensure the proper content type is returned for static files. 2010-10-04 18:06:04 +02:00
José Valim
10d014acb8 Update to Thor 0.14.3. 2010-10-04 13:46:37 +02:00
José Valim
3986fcb935 Initialize sid should just skip instance variables. 2010-10-04 08:47:36 +02:00
Aaron Patterson
69a2c6b041 converting inject([]) to map 2010-10-03 16:42:08 -07:00
Aaron Patterson
365c93b7cd speed up duplicate migration detection 2010-10-03 16:39:48 -07:00
Aaron Patterson
40761c4bf3 reduce the number of calls to camelize 2010-10-03 16:36:43 -07:00
Aaron Patterson
e6583901e5 convertion MigrationProxy to a Struct, initialize instance variables 2010-10-03 16:32:27 -07:00
Aaron Patterson
341e71a1b9 dry up some migration logic 2010-10-03 16:23:07 -07:00
Aaron Patterson
8beda11fd3 no need to differentiate between nil and false in this case 2010-10-03 16:13:45 -07:00
Aaron Patterson
a6c42c8267 two argument String#slice is faster than single argument, also avoid creating a Range object 2010-10-03 15:38:17 -07:00
Aaron Patterson
5154a464cc lengths will be nil or an array 2010-10-03 15:35:56 -07:00
Aaron Patterson
7836616a64 remove a few function calls 2010-10-03 15:18:32 -07:00
Aaron Patterson
bd78d24bd8 be kind to the garbage collector and reuse our visitor object 2010-10-03 14:40:06 -07:00
Aaron Patterson
83633b807a avoid creating objects when we can 2010-10-03 14:40:06 -07:00
Aaron Patterson
18a7b767e8 moving fake model to the correct file 2010-10-03 14:40:06 -07:00
Piotr Sarnacki
adfd43a4da Add documentation on app_generators 2010-10-03 23:32:03 +02:00
José Valim
5f292c9441 Merge branch 'racksession' 2010-10-03 21:48:32 +02:00
José Valim
653acac069 Solve some warnings and a failing test. 2010-10-03 21:45:30 +02:00
José Valim
74dd8a3681 Move ETag and ConditionalGet logic from AD::Response to the middleware stack. 2010-10-03 21:25:22 +02:00
José Valim
50215f9525 Rely on Rack::Session stores API for more compatibility across the Ruby world. 2010-10-03 21:24:22 +02:00
Santiago Pastorino
5836af8f8b PERF: more Hash + map changes 2010-10-03 16:33:46 -02:00
Santiago Pastorino
42fad8c82b PERF: more changes from inject({}) to Hash + map 2010-10-03 15:03:59 -02:00
Santiago Pastorino
4920312643 PERF: Don't create unnecessary objects 2010-10-03 14:58:23 -02:00
Santiago Pastorino
10249d7b77 PERF: change inject({}) with Hash + map 2010-10-03 14:52:46 -02:00
Santiago Pastorino
c28bebef13 PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is faster than var.sub('@', '') 2010-10-03 13:34:34 -02:00
David Chelimsky
f656796d05 Rename _assigns to view_assigns in AV::TC 
- also add tests
- also deprecate _assigns

[#5751 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-03 13:30:31 -02:00
José Valim
49cc01002e Be more explicit about what is deprecated. 2010-10-02 09:40:54 -07:00
José Valim
04cbabb0a0 Deprecate generators in Railties. You should use app_generators instead. 2010-10-02 18:38:23 +02:00
José Valim
757bbd540c :'' is not valid ruby. 2010-10-02 18:30:38 +02:00
Aditya Sanghi
297cf0b266 added test for form_for with search_field 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-02 17:48:12 +02:00
Aditya Sanghi
8d1df887d3 Fixing search_field to remove object attribute from options hash [#5730 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-02 17:48:11 +02:00
José Valim
7b0c592e38 reload_routes! is part of the public API and should not be removed. 2010-10-02 17:45:26 +02:00