github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 21:25:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,646 Commits 34 Branches 105 Tags
dbb0abfb7e9eb9a63b721a38625e3eff66ced49d
Commit Graph

7646 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Joshua Peek
dbb0abfb7e More integration test coverage 2008-08-17 19:18:18 -05:00
Joshua Peek
f245658495 Use Response status accessor instead of the Status header 2008-08-17 19:13:49 -05:00
Joshua Peek
b8e930aa01 Merge RackProcess#normalize_headers logic into AbstractResponse#prepare! 2008-08-17 19:09:38 -05:00
Joshua Peek
894f9ccc53 Use RackRequest as a mock instead of StubCGI into RequestTest 2008-08-17 19:04:01 -05:00
Tarmo Tänav
96607996ea Test for eager loading of STI subclasses from htm associations 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-16 22:26:11 +01:00
Nathan Witmer
8cfdcdb35d Updated has_and_belongs_to_many association to fix :finder_sql interpolation. [#848 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-16 22:23:48 +01:00
Tarmo Tänav
2b69a636c4 Fixed STI type condition for eager loading of associations 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-16 20:41:19 +01:00
Ryan Bates
8f4d3957a6 Don't raise exception when comparing ActiveRecord::Reflection. [#842 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-16 20:21:36 +01:00
Tarmo Tänav
b3c9d53b34 Use type_condition method for hmt STI condition 2008-08-15 15:57:33 -07:00
Tarmo Tänav
e3523f1d33 Fixed validates_uniqueness_of with decimal columns 
Only use special case-sensitive comparison operators for text columns in
validates_uniqueness_of as mysql can fail at decimal comparisons with
the BINARY operator.
 2008-08-15 15:44:11 -07:00
David Heinemeier Hansson
aad7cac6ad Fixed problems with the logger used if the logging string included %'s [#840 state:resolved] (Jamis Buck) 2008-08-15 09:27:07 -05:00
Jeremy Kemper
8aad8cb390 Set cache control to require revalidation if cache freshness response headers are set. Don't set Content-Length header if 304 status. 2008-08-14 21:45:14 -07:00
Jeremy Kemper
f1f4e84a7e Fix asset file paths with dangling queries in mtime check 2008-08-14 12:28:02 -07:00
Joshua Peek
8cb14ee120 Ensure results returned by a memoized method are immutable 2008-08-13 21:30:46 -05:00
Joshua Peek
b8b30985d5 Marshal FileStore values 2008-08-13 20:57:26 -05:00
Jeremy Kemper
c7e09a8fb2 TestRequest#recycle! uses unmemoize_all to reset cached request method, accepts, etc. 2008-08-13 17:26:27 -07:00
Jeremy Kemper
3fc9a67c04 memoize_ and unmemoize_all 2008-08-13 17:26:27 -07:00
S. Brent Faulkner
3284fbb866 Use current umask when testing the expected file mode [#823 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-08-13 19:19:00 -05:00
Joshua Peek
3b9324e62f Fix rendering partials at the top level [#795 state:resolved] 2008-08-13 19:15:35 -05:00
Joshua Peek
04248c6208 Ensure templates are rendered if all the parts are already processed 2008-08-13 19:04:56 -05:00
Josh Susser
2561be005b Refactor Filter predicate methods to use inheritance. [#815 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-13 21:48:37 +01:00
Eloy Duran
1ee9e3fa5c Fix ActiveRecord::NamedScope::Scope#respond_to? [#818 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-08-13 13:04:42 +01:00
Jeffrey Hardy
282b420213 Account for the possibility of a nil options argument to CompressedMemCacheStore#read/#write 2008-08-13 04:19:31 -07:00
Tarmo Tänav
a5aad2e81f Fixed Time/Date object serialization 
Time/Date objects used to be converted to_s instead of to_uaml
which made them unserializable.
 2008-08-12 20:29:07 -07:00
Jeremy Kemper
1b127fcdea Set asset-cached file ctime and mtime to the max mtime of the combined files. Allows for consistent ETag generation without having a shared filesystem. 2008-08-12 20:18:03 -07:00
Jeremy Kemper
45b79d933c Merge branch 'conditional-get' 2008-08-12 17:03:17 -07:00
Jeremy Kemper
08b0cf07db Update changelog for conditional GET utility methods 2008-08-12 17:03:06 -07:00
Tom Lea
992fda16ed Serialized attributes will now always be saved even with partial_updates turned on. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#788 state:committed]
 2008-08-12 18:15:50 +02:00
Trevor Turk
81c12d1f63 move logging of protected attribute removal into log_protected_attribute_removal method 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#804 status:committed]
 2008-08-12 09:52:06 +02:00
Michalis Polakis
c7375d74d9 Alias subquery used in calculations, to provide better compatibility with databases such as MonetDB 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
Signed-off-by: Tom Ward <tom@popdog.net>
[#796 state:committed]
 2008-08-11 16:48:45 +02:00
Matthew Rudy Jacobs
eb4668b26a rake db:fixtures:load and db:fixtures:identify now accept a FIXTURES_PATH option eg. "rake db:fixtures:load FIXTURES_PATH=spec/fixtures" 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#792 state:committed]
 2008-08-09 18:36:40 +02:00
Stefan Kaes
b2630502a0 Fixed autolink regexp compatibility for ruby 1.9 [#783 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-08-09 10:48:56 -05:00
Cameron Yule
2faf35cea9 Added tests for partial collection counters [#766 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-08-09 10:48:56 -05:00
miloops
ea0d036e31 mail_to should use decodeURIcomponent instead of unescape to be utf friendly. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 15:31:02 +02:00
Ernie Miller
7f6e7ba1f7 Fixed AssociationCollection#<< resulting in unexpected values in @target when :uniq => true 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 15:19:08 +02:00
Jeremy Kemper
ba2d61dd81 Update tests for request memoization 2008-08-08 02:31:12 -07:00
Jeremy Kemper
c24a7cdd23 Don't shadow host method 2008-08-08 02:29:37 -07:00
Daniel Rodríguez Troitiño
06e4eb49ea Added file name information for errors and exceptions in script/runnner 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 10:48:52 +02:00
James Rosen
14cf9a8991 dryed up resources; fixed small formatting issue in resources rdoc 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 10:47:26 +02:00
Ryan Bates
1db7c9cf4a fixing "test_any_should_not_load_results" so it doesn't depend on latest version of Mocha 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 10:33:29 +02:00
Jeremy Kemper
b7529ed1cc Simplifying usage of ETags and Last-Modified and conditional GET requests 2008-08-07 23:43:12 -07:00
Jeremy Kemper
e43d1c226d Inherit these from AbstractRequest instead 2008-08-07 23:34:36 -07:00
Jeremy Kemper
6c70c02c83 Freeze memoized results when instance is frozen instead of immediately so you can memoize mutable objects 2008-08-07 23:31:43 -07:00
Jeremy Kemper
a8057669ff Fixed memoize with punctuation and freezing memoized methods with arguments 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-08-07 14:55:14 -05:00
Clemens Kofler
105093f907 Refactor DateHelper to use DateTimeSelector presenter pattern 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-08-07 13:13:47 -05:00
Joshua Peek
be0d235a3b Optimize memoized method if there are no arguments 2008-08-06 20:21:15 -05:00
Joshua Peek
b2504f8ba0 Tidy up ActionMailer rendering logic to take advantage of view path cache instead of using file system lookups 2008-08-06 20:11:21 -05:00
Jeremy Kemper
ed8a882e47 JRuby: improve constantize performance. [#410 state:resolved] 2008-08-06 17:31:57 -07:00
Joshua Peek
f5bcbde1e3 Make sure ActionView is loaded inorder to build view paths 2008-08-06 17:40:03 -05:00
Joshua Peek
c6b7d0f344 Ensure file atomic write uses the cache directory as its tmp folder 2008-08-06 17:25:32 -05:00