github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-05 03:35:14 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,252 Commits 34 Branches 105 Tags
e4c047e4891c446024e35548e872704d132ad2f7
Commit Graph

1252 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-01 13:39:58 +00:00
Leon Breedt
46e68538c0 fix scaffolding template paths (Pathname does weird things on Win32) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-31 02:50:02 +00:00
Jamis Buck
19da52d69d Ignore Iconv::IllegalSequence errors when converting text #1341 [lon@speedymac.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 23:09:50 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:20:37 +00:00
Jamis Buck
b6c13f2d70 Don't die when an attempt to delete a cache fails 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:05:52 +00:00
Jamis Buck
359caef33c A very thorough refactoring, resulting in new mail property setters and support for attachments and multipart messages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1359 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-29 16:36:22 +00:00
David Heinemeier Hansson
79d9794f09 Updated unit test style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720 Test for no layout on nothing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
bdd16a75e6 render :nothing shouldnt cause layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:57:51 +00:00
David Heinemeier Hansson
060ecf1a24 Set redirected_to proper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:52:54 +00:00
David Heinemeier Hansson
2f7c5f84e4 Cure some ills discovered with the refactoring 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 11:07:09 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
3022ee84cc Added note of limitation for #1279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:23:35 +00:00
David Heinemeier Hansson
a1e9ceebd5 Added Errors#add_on_blank which works like Errors#add_on_empty, but uses Object#blank? instead. CHANGED: validates_presence_of now uses Errors#add_on_blank, which will make " " fail the validation where it didnt before #1309. Added that " " is now also blank? (using strip if available) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:12:36 +00:00
David Heinemeier Hansson
7159402c6d Fixed use of an integer as return code for renders, so render_text "hello world", 404 now works #1327 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 17:50:57 +00:00
David Heinemeier Hansson
194fc9de5d Slight change to allow custom date/time conversions #1326 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 14:57:23 +00:00
David Heinemeier Hansson
52ecf9a318 Remove unneeded file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 13:21:55 +00:00
David Heinemeier Hansson
48bb9bb0ad Missing file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 13:21:29 +00:00
David Heinemeier Hansson
ca873648ea Added graceful exit from pressing CTRL-C during the run of the rails command #1150 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 11:05:18 +00:00
David Heinemeier Hansson
10eb22cdce Added the :if option to all validations that can either use a block or a method pointer to determine whether the validation should be run or not. #1324 [Duane Johnson/jhosteny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 10:57:18 +00:00
David Heinemeier Hansson
2bccdba9d1 Made the console and profiler work with the default 1.8.2 profiler #1325 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 10:49:15 +00:00
David Heinemeier Hansson
997eb90c90 Made the post_format work with content-type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1337 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 18:39:40 +00:00
David Heinemeier Hansson
24b13acd42 Made the post_format work with content-type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1336 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 18:32:04 +00:00
David Heinemeier Hansson
8cc64e77cf Needed for test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 07:06:36 +00:00
David Heinemeier Hansson
9bf38dec69 Include flash in the list of attributes with accessors in the view 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 07:04:51 +00:00
Leon Breedt
92b925b1c5 memo to self: add :rest dispatching mode, and vanilla XML message support 
a.l.a Backpack API...its so Web 2.0 :)


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1333 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 01:36:02 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
4a7225a1bd Fixed Dependencies so all modules are able to load missing constants #1173 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:17:08 +00:00
David Heinemeier Hansson
71b6f76543 Fixed the Inflector to underscore strings containing numbers, so Area51Controller becomes area51_controller #1176 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:15:30 +00:00
David Heinemeier Hansson
6375569484 Fixed that HashWithIndifferentAccess stringified all keys including symbols, ints, objects, and arrays #1162 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:13:30 +00:00
David Heinemeier Hansson
7160ab1c18 Fixed escaping of :method option in remote_form_tag #1218 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:08:16 +00:00
David Heinemeier Hansson
c8b4cf65df Speed up timestamping a tad #1227 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:05:12 +00:00
David Heinemeier Hansson
977671c226 Optimize ActionCacheFilter by using url_for less #1230 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:59:43 +00:00
David Heinemeier Hansson
caf6ff6a2f Cache relative_url_root and optimize path #1232 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:55:50 +00:00
David Heinemeier Hansson
3a057ea4ac Faster action_exempted? #1231 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:54:16 +00:00
David Heinemeier Hansson
45ee71af3c Added Serbia and Montenegro to the country_select #1239 [todd@robotcoop.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:30:53 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
473e5bde74 Fixed that compute_public_path should recognize external URLs, so image_tag("http://www.example.com/images/icon.gif") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751 Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
f9103e1fe2 Fixed Time#last_year to go back in time, not forward #1278 [fabien@odilat.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:36:25 +00:00
David Heinemeier Hansson
26022d8d2a Ajax docing #1282 [Dee.Zsombor@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:29:20 +00:00
David Heinemeier Hansson
496ee0cd1b Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
47dcc5ffc6 Fixed use of construct_finder_sql when using :join #1288 [dwlt@dwlt.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:23:28 +00:00
David Heinemeier Hansson
9b1fefbf54 Fixed doc #1291 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:14:35 +00:00