Commit Graph

19041 Commits

Author SHA1 Message Date
Santiago Pastorino
ea7db8ebc1 number_to_phone always return safe 2010-10-17 20:42:13 -02:00
Michael Koziarski
2f9e880431 Rejig the html5 data helper code
Avoid allocating an array each pass through and support String subclasses like SafeBuffers
2010-10-18 11:18:43 +13:00
Stephen Celis
5e79094fc1 HTML5 data attribute helpers [#5825 state:resolved]. 2010-10-18 11:18:42 +13:00
Santiago Pastorino
67df21f895 No need for parenthesis here 2010-10-17 12:34:51 -02:00
Neeraj Singh
f527f9097b no need to check for nil
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-17 12:26:47 -02:00
Neeraj Singh
ea14396c45 replace if ! with unless
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-17 12:26:32 -02:00
Santiago Pastorino
b44e2abd9f Bump bundler up to 1.0.3 2010-10-16 14:36:25 -02:00
Santiago Pastorino
6c8ea83385 extract formats_regexp as a method 2010-10-16 14:12:41 -02:00
Santiago Pastorino
15d3c77bc2 There's no need now to expose lookup_context as an external API 2010-10-16 13:42:19 -02:00
Santiago Pastorino
0d00d65ad2 Delegate freeze_formats to lookup_context 2010-10-16 13:39:11 -02:00
Jeff Kreeftmeijer
b454bb0a98 Remove the :vew attr_reader from ActionView::AbstractRenderer [#5819 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-16 13:02:14 -02:00
Santiago Pastorino
66f805a969 JQuery updated to 1.4.3
Check out http://blog.jquery.com/2010/10/16/jquery-143-released/ for
information on what's new.
2010-10-16 12:30:34 -02:00
Rob Zolkos & Xavier Noria
bc1bcddede implements weeks_ago and prev_week for Date/DateTime/Time [#5122 state:committed] 2010-10-16 02:23:23 +02:00
Santiago Pastorino
4bfe30ca2f delete from :number until the end 2010-10-15 21:09:32 -02:00
Aaron Patterson
dc76e3c38f should sort these ids before asserting they are equal! 2010-10-15 15:47:09 -07:00
Aaron Patterson
552636c652 testing that symbols work as sql literals 2010-10-15 15:46:13 -07:00
Aaron Patterson
1dd266741e fixing an error in the rdoc 2010-10-15 10:43:53 -07:00
Aaron Patterson
eaa7605e2f Revert "refactor delete a little"
This reverts commit f3f34bce8f.
2010-10-15 10:23:05 -07:00
Piotr Sarnacki
b0157f8d04 Removed duplicated method find_root_with_flag
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-15 13:17:36 -02:00
Xavier Noria
21ff8849bb in regexps, the dot in a character class is not a metacharacter 2010-10-15 16:31:00 +02:00
André Camargo
c42ea2172e Fix for ActionView::Template#refresh in rails 3.1.0.beta
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-15 08:39:10 +02:00
Carl Lerche
69789c3b29 #transaction on the instance level should take options as well 2010-10-14 21:27:40 -07:00
Michael Koziarski
9ebe582830 Revert 0c0b0aa0f2 which introduced a security vulnerability.
This addresses  CVE-2010-3933

Conflicts:

	activerecord/lib/active_record/nested_attributes.rb
2010-10-15 10:27:33 +13:00
Xavier Noria
13f7f89bda Merge branch 'master' of git://github.com/lifo/docrails 2010-10-14 23:15:23 +02:00
José Valim
01ab6f961b Remove :cache => true on lookup templates initialization. 2010-10-14 09:47:49 +02:00
José Valim
aa508c9baf SReorganize autoloads slightly and move two files to lib/action_view root. 2010-10-14 09:32:53 +02:00
José Valim
37d78028b2 render :once should consider the current controller prefix. 2010-10-14 09:27:18 +02:00
José Valim
c7aea81a39 Comment internal railties tasks. 2010-10-14 08:37:03 +02:00
Piotr Sarnacki
11558a11fe Use railtie_name to correctly get name from plugins 2010-10-14 07:46:12 +02:00
Piotr Sarnacki
72545da091 Remove task for creating symlinks for railties 2010-10-14 07:46:12 +02:00
Piotr Sarnacki
a2c52f1004 Update documentation for new tasks 2010-10-14 07:46:12 +02:00
Piotr Sarnacki
43215de208 Add task foo:install (where foo is plugin) as a shortcutinstall:migrations and foo:install:assets 2010-10-14 07:46:12 +02:00
Piotr Sarnacki
959f8576f2 Added foo:install:assets task that copies assets from plugins public directory to application's public directory
This is the most simple and naive approach: just copy every files from engine to app.
The only exception is when file has changed, in that case developer will be
asked if he wants to rename the field.

There is no need to make this task more sophisticated as 3.1 will be shipped
with better assets handling and it will be the default way to handle things.
2010-10-14 07:46:12 +02:00
Piotr Sarnacki
f07cbec865 Do not treat information about skipped migrations as WARNINGs but as a NOTEs, also puts to stdin 2010-10-14 07:46:12 +02:00
Aaron Patterson
ab1a661533 Revert "speeding up flattened version of OrderedHash.[]"
This reverts commit 9c53e82d66.
2010-10-13 21:06:07 -07:00
Aaron Patterson
9c53e82d66 speeding up flattened version of OrderedHash.[] 2010-10-13 21:04:42 -07:00
Aaron Patterson
f3f34bce8f refactor delete a little 2010-10-13 20:51:51 -07:00
Aaron Patterson
86b02e7bb1 use unless instead of if ! 2010-10-13 20:44:26 -07:00
Aaron Patterson
676a00163d clear any stale connections before messing with threaded tests 2010-10-13 16:58:03 -07:00
Ryan Bigg and Xavier Noria
cfb1ba023b Use <em> rather than underscores to fix display issue with 4.1.1.1 in the asssociation basics guide 2010-10-14 08:12:25 +11:00
Ugis Ozols
a37e1a6a69 Removed miscelenous letters. 2010-10-13 23:31:37 +03:00
Carl Lerche
91ba75806f Update the ActiveRecord tests to not set unused options
This makes a test fail, but it is revealing a bug in Arel master.
2010-10-13 12:32:52 -07:00
Rafael Mendonça França
aec5ef243a Remove doc for debugging callbacks. Methods don't exist in Rails master 2010-10-13 15:59:57 -03:00
Carl Lerche
0b6af35ef0 Update the PostgreSQL adapter documentation 2010-10-13 11:49:32 -07:00
Carl Lerche
941844cbe5 rb_thread_select should always be used in DB drivers when available. 2010-10-13 11:40:47 -07:00
Jon Leighton
1ddbb216ea Delete unused methods in JoinAssociation 2010-10-13 08:24:19 -07:00
Jon Leighton
19304a9758 Renaming and formatting changes in JoinDependency 2010-10-13 08:24:19 -07:00
Jon Leighton
7dcb633427 Refactor JoinDependency and friends so that a JoinAssociation can produce an arbitrary number of joins, which will be needed in order to support nested through associations. 2010-10-13 08:24:19 -07:00
Jon Leighton
076b75bf98 Add some tests for functionality in JoinAssociation which already exists but was previously untested 2010-10-13 08:24:19 -07:00
Aaron Patterson
603406dc53 stop using deprecated arel API 2010-10-12 14:33:16 -07:00