github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-27 07:48:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix some tabbing issue in IE forms. align the sr dropdown properly in IE

Browse Source
This commit is contained in:
spez
2009-06-22 15:50:25 -07:00
parent 1ee32eeed3
commit d964c2fa7e
4 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
r2/r2/public/static/css/reddit.css
View File

@@ -2036,6 +2036,7 @@ ul#image-preview-list .description pre {
border: 1px solid gray;
background: white;
display: none;
left: 0;
}
#sr-drop-down table {

3
r2/r2/public/static/js/reddit.js
View File

@@ -639,6 +639,9 @@ function update_dropdown(sr_names) {
drop_down.append(new_row);
});
var height = $("#sr-autocomplete").outerHeight();
drop_down.css('top', height);
drop_down.show();
}

20
r2/r2/templates/newlink.html
View File

@@ -47,8 +47,8 @@ ${thing.formtabs_menu.render()}
<div class="spacer">
<%utils:round_field title="${_('title')}" id="title-field">
<textarea name="title" rows="2" cols="1" wrap="hard">${thing.title}</textarea>
${error_field("NO_TEXT", "title", "span")}
${error_field("TOO_LONG", "title", "span")}
${error_field("NO_TEXT", "title", "div")}
${error_field("TOO_LONG", "title", "div")}
</%utils:round_field>
</div>
@@ -56,11 +56,11 @@ ${thing.formtabs_menu.render()}
<%utils:round_field title="${_('url')}" id="url-field">
<input name="kind" value="link" type="hidden"/>
<input id="url" name="url" type="text" value="${thing.url}"/>
${error_field("NO_URL", "url", "span")}
${error_field("BAD_URL", "url", "span")}
${error_field("ALREADY_SUB", "url", "span")}
${error_field("NO_URL", "url", "div")}
${error_field("BAD_URL", "url", "div")}
${error_field("ALREADY_SUB", "url", "div")}
<div>
<button type="button" onclick="fetch_title()">${_("suggest title")}</button>
<button type="button" tabindex="100" onclick="fetch_title()">${_("suggest title")}</button>
<span class="title-status"></span>
</div>
</%utils:round_field>
@@ -92,15 +92,15 @@ ${thing.formtabs_menu.render()}
<script type="text/javascript">
reddit.sr_cache = ${unsafe(thing.sr_searches)};
</script>
${error_field("SUBREDDIT_NOEXIST", "sr", "span")}
${error_field("SUBREDDIT_REQUIRED", "sr", "span")}
${error_field("SUBREDDIT_NOEXIST", "sr", "div")}
${error_field("SUBREDDIT_REQUIRED", "sr", "div")}
<div id="suggested-reddits">
<span class="">${_("popular choices")}&#32;</span>
<ul>
%for name in thing.subreddits:
<li>
<a href="#" onclick="set_sr_name(this); return false">${name}</a>&#32;
<a href="#" tabindex="100" onclick="set_sr_name(this); return false">${name}</a>&#32;
</li>
%endfor
</ul>
@@ -115,7 +115,7 @@ ${thing.formtabs_menu.render()}
</div>
<div class="spacer">
<button class="btn" name="submit" value="form" type="submit" tabindex=1>${_("submit")}</button>
<button class="btn" name="submit" value="form" type="submit">${_("submit")}</button>
<span class="status"></span>
${error_field("RATELIMIT", "ratelimit")}
</div>

2
r2/r2/templates/printable.html
View File

@@ -314,7 +314,7 @@ thing id-${what._fullname}
css_class, alt_css_class = alt_css_class, css_class
%>
<span class="${class_name} toggle" style="${style}">
<a class="option active ${css_class}" href="#"
<a class="option active ${css_class}" href="#" tabindex="100"
%if login_required and not c.user_is_loggedin:
onclick="return showcover('', '${callback}_' + $(this).thing_id());"
%else: