Commit Graph

3457 Commits

Author SHA1 Message Date
bsimpson63
1fa8115963 Delete PromoteLinkFormCpm. 2013-09-18 17:55:10 -04:00
bsimpson63
e8c6862936 Separate templates for creating and editing promoted links. 2013-09-18 17:55:01 -04:00
bsimpson63
8b81270380 Remove unused arguments from PromoteLinkform. 2013-09-18 17:54:55 -04:00
bsimpson63
972f922ba3 Move bid logic out of template. 2013-09-18 17:54:48 -04:00
bsimpson63
015ffe5d83 Break up monolithic promotelinkform into functions. 2013-09-18 17:54:42 -04:00
bsimpson63
6df2fc3b63 Typo in promoted link thumbnail display. 2013-09-18 17:54:35 -04:00
bsimpson63
87bee2cc9d Delete unsupported maximum_clicks and maximum_views options. 2013-09-18 17:54:29 -04:00
bsimpson63
8e8883b440 Whitespace cleanup in promotelinkform.html. 2013-09-18 17:54:13 -04:00
shlurbee
f0c080a46f Fix secondary sort in recommendations 2013-09-18 10:35:20 -07:00
David Ehrmann
4023a719a8 Update /ad_inq for the self-serve CPM rollout.
- Remove link to theoatmeal's explanation of the self-serve ad system
- Update the copy in the "control your budget" section of ad_inq
2013-09-18 10:34:53 -07:00
Brian Simpson
8a7e8d224d ModAction: Read from ModActionBySRActionMod. 2013-09-18 08:57:06 -04:00
Andre D
544e4994a5 ModAction: Add a migrate script. 2013-09-18 08:56:55 -04:00
Andre D
88906eff2f ModAction: Add a view of Action and Mod. 2013-09-18 08:55:52 -04:00
Brian Simpson
23bee034ff ModAction: TTL of 120 days. 2013-09-18 08:54:51 -04:00
Brian Simpson
4fe0e158ed Delete old roadblocks. 2013-09-18 08:53:25 -04:00
Brian Simpson
67c71b0870 Read roadblocks from Cassandra. 2013-09-18 08:53:25 -04:00
Brian Simpson
201d0d05a9 Migrate roadblocks to Cassandra. 2013-09-18 08:53:25 -04:00
Brian Simpson
e9008e3ad1 Cassandra view class for roadblocks. 2013-09-18 08:53:25 -04:00
Brian Simpson
d7213ee9b4 Get more roadblocks. 2013-09-18 08:53:25 -04:00
Neil Williams
ae534d7f31 Proxy the new stylesheet properties to DefaultSR. 2013-09-17 16:13:37 -07:00
Max Goodman
2a9b140cc7 Add util for generating client side S3 HTTPs URLs. 2013-09-17 16:13:37 -07:00
Max Goodman
f851b366d1 listing chooser: Clean up all localStorage collapsed settings. 2013-09-17 16:13:37 -07:00
shlurbee
46b36dbc2b Add subreddit suggestions UI to multi page.
When user edits a multi, a box below the edit control shows a list of
subreddits recommended based on the items already in the multi. A "more
suggestions" link pages through the list, showing a list of subreddit
discovery links after all suggestions have been dismissed.
2013-09-17 16:07:26 -07:00
shlurbee
2083e88100 Enable fetching recommendations for multiple srs at once.
This change allows you to pass a list of srid36s and get back recommendations
for all of them at once, which is useful for multireddit suggestions.

A function that accepted a single subreddit id as an argument and memoized the
results was removed and its functionality replaced by sgm caching, which sets
multiple items in memcache at once.

A source prefix is added to the row key so multiple sets of recs can be stored
in the same column family.

Adult items are filtered unless one of the original subreddits was over_18.

Recommendations for a set of subreddits are merged and sorted by the number of
items matched. (User feedback showed that people perceive recommendations as
incorrect if they don't match the "theme" of a large multi, and recs that
match several srs in the multi instead of just one are more likely to fit the
theme, so we show those first.)
2013-09-17 16:07:23 -07:00
Neil Williams
c0d63cf803 Start writing HTTPS-friendly subreddit stylesheets.
This does several things to subreddit stylesheets:
- stores them on the thumbs buckets rather than the main static bucket.
  (this was not desirable before on reddit.com due to CDN configuration)
- enforces a new restriction of custom (%%style%%) images only in
  stylesheets to make secure urls easier to resolve. existing subreddits
  are grandfathered in for now.
- writes, if possible as above, a second stylesheet that references
  subreddit images over https.

At some point in the future, the thumbs buckets should be directly accessible
on HTTPS via the same URLs which would remove the need for the second
stylesheet to be created and uploaded. The custom image rules and other changes
would still be good.
2013-09-17 13:39:17 -07:00
Neil Williams
5705be4b63 /stylesheet.css: Don't attempt to redirect to None.
Caused when a subreddit has a static stylesheet, but not a secure static
stylesheet and /r/whatever/stylesheet.css is accessed over HTTPS.
2013-09-17 13:39:17 -07:00
Neil Williams
4281b967c4 subreddit images: Make image preview in editor HTTPS friendly. 2013-09-17 11:43:57 -07:00
Neil Williams
48b4784490 subreddit images: Remove some cruft left over from the old system.
All images in the new system are guaranteed to be proper URLs by the
migration and way the new system works.
2013-09-17 11:43:57 -07:00
Neil Williams
c48b9d4871 Prepare for new subreddit stylesheet system.
This adds the necessary URL-generation stuff so that subreddits cut over
to the new stylesheet system will be rendered properly.
2013-09-17 11:43:57 -07:00
Max Goodman
1e61c874c2 Report JS errors during base initialization. 2013-09-16 17:15:35 -07:00
Max Goodman
641ef7ccf9 safeGet/safeSet: Don't bother if store.js is disabled.
For IE with localStorage disabled, store.js can raise exceptions if you
attempt to use it when it is "disabled" (cannot select a backend).
2013-09-16 17:15:35 -07:00
Max Goodman
2b245079d2 Add missing error status code to VPrintable. 2013-09-16 17:15:35 -07:00
Max Goodman
b89faa152b Catch and log errors setting local storage values. 2013-09-16 17:15:35 -07:00
Max Goodman
22a5328422 Web frontend logging. 2013-09-16 17:15:35 -07:00
Max Goodman
8a0b7b1a7b Generalize strict validation error abort method. 2013-09-16 17:15:35 -07:00
Max Goodman
244592e47a Add 429 status code to VRatelimit. 2013-09-16 17:15:35 -07:00
Max Goodman
e933ab305b Add param documentation for VPrintable. 2013-09-16 17:15:35 -07:00
Chad Birch
74ab8cd613 Gold partner codes: track time of claim 2013-09-16 18:10:32 -06:00
Scott Johnson
32e181387b Add 'allowfullscreen' attribute to expando media embeds. 2013-09-16 11:16:31 -07:00
David Hu
c866ee9f01 admintools: add missing stub for bans_for_domain_parts 2013-09-13 15:36:02 -07:00
Ricky Ramirez
c46309c338 sanitize_url: Convert unicode domain names to ascii.
Previously, unicode domain names were only checked for validity, and the
coversion was dropped. This can cause problems down the line where we expect
URL's to be ascii.
2013-09-12 15:28:06 -07:00
Neil Williams
b87d87f9a5 Determine c.secure status based on X-Forwarded-Proto header.
Previously, c.secure status was determined based on the domain used.
This allows for the status to vary independently of domain for greater
flexibility.

Note: it is critical that the load balancer strips any X-Forwarded-Proto
headers that may've been sent by the client.
2013-09-12 13:35:17 -07:00
Max Goodman
552e9828ab Make request.fullurl reflect the c.secure url_scheme change. 2013-09-12 13:35:15 -07:00
Max Goodman
01582db9e6 Move CHEATER error into a flag. 2013-09-10 13:55:35 -07:00
Max Goodman
f32c951cf2 Remove obsolete .wired views. 2013-09-10 13:55:27 -07:00
Max Goodman
24eb06ab07 See you later RewriteMiddleware.
This appears to only have been be used for obsolete .js URL forms of
widgets.
2013-09-10 13:55:27 -07:00
Max Goodman
226245797a Collect simple vote count stats. 2013-09-10 13:55:27 -07:00
Ricky Ramirez
fcb49ce518 health: Use one second for the timeouts. 2013-09-10 13:55:27 -07:00
Neil Williams
006add6a65 Make scraper_q start fetching secure media objects.
These are media objects that can be embedded safely in an HTTPS page.
Only a handful of services support this through embedly right now, and
that list is hardcoded until embedly's service API is updated.
2013-09-09 15:44:24 -07:00
Ricky Ramirez
eb6369f72c Add health check for caches. 2013-09-09 11:35:10 -07:00