github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-29 08:48:18 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,280 Commits 1 Branch 0 Tags
4df1ae542e026ab64bc054c8ebed6e27da1d269c
Commit Graph

3280 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Goodman
4df1ae542e Add multireddit subreddits to the submit page. 2013-07-24 16:53:59 -07:00
Max Goodman
7dd403178b Remove obsoleted g.default_sr special case. 2013-07-24 16:53:58 -07:00
Max Goodman
242e13df58 Factor out global state from NewLink view. 2013-07-24 16:53:58 -07:00
Max Goodman
294e5412b9 Whitespace. 2013-07-24 16:53:58 -07:00
Max Goodman
659cecec97 Simplify and consolidate subreddit selector view code. 2013-07-24 16:53:58 -07:00
Max Goodman
22aba6cd14 Validate multireddit subreddit data properly. 
Fixes spurious "name" properties being stored in sr_props data and
consolidates batched subreddit checking logic.
 2013-07-24 16:53:58 -07:00
Max Goodman
ccf50bad1b VSubredditName -> VAvailableSubredditName 
yessssssssss
 2013-07-24 16:53:58 -07:00
Max Goodman
1cd4cc9179 JSON validation: let's get serious. 2013-07-24 16:53:58 -07:00
bsimpson63
36b7679d7c del_srs: sr_props is a dict of sr_id: dict. 2013-07-24 16:53:58 -07:00
Brian Simpson
5ae42365af Accept data parameter for multi sr data PUTs. 2013-07-24 16:53:58 -07:00
Max Goodman
df03e621c0 Don't base copy/rename API URLs on the "from" multi path. 
Since "copy" and "rename" are operations rather than resources
underneath the multi, let's put them in the root of the API namespace.
 2013-07-24 16:53:58 -07:00
Max Goodman
e816a28493 Add REST API for descriptions; copy API call; cleanup. 
This adds a bona fide special copy operation to simplify API use and
handle copying sub-documents like descriptions.
 2013-07-24 16:53:58 -07:00
Max Goodman
2d5c409d6c Add status code to VOneOf validator error. 2013-07-24 16:53:58 -07:00
Max Goodman
e0ac203cec Add VValidatedJSON validator for checking schema'd json data. 2013-07-24 16:53:58 -07:00
Max Goodman
483b868aaa Be strict about validation errors having status codes. 
Hoping to avoid a silent non-handling of an error causing a security
issue someday.
 2013-07-24 16:53:58 -07:00
Max Goodman
23a4cdc965 Add auto description attribution to copied multireddits. 2013-07-24 16:53:58 -07:00
Max Goodman
fb57f0789d Basic markdown descriptions for multireddits. 2013-07-24 16:53:58 -07:00
Max Goodman
a559fb7c0f Fix case sensitivity in "hot/top/new" tab menu highlighting. 2013-07-24 16:53:58 -07:00
Max Goodman
44349ec2f2 Add missing loading indicator throbbers. 2013-07-24 16:53:57 -07:00
Max Goodman
91e4c6742d Multi renaming. 
Adds an api call for renaming a multi while preserving metadata.
Abstracts MultiCreateForm to handle renaming.
 2013-07-24 16:53:57 -07:00
Max Goodman
90c38d9902 Always override validator param docs with specific instance docs. 2013-07-24 16:53:57 -07:00
Max Goodman
869885b2db Only spawn MultiCreateForm once for the copy expando. 2013-07-24 16:53:57 -07:00
Max Goodman
2ed755e8c5 Fix duplicate bubble race condition when hiding. 
While a bubble is animating the hide, it's possible to show another
bubble within a bubble group. Then, when the hide animation completes,
`hideNow` would be called, clobbering the group state set by the newly
shown bubble.
 2013-07-24 16:53:57 -07:00
Max Goodman
4ab51600ef Only create multi categorize bubble for subscribe buttons upon hover. 
This prevents creating a ton of bubble views on pages with lots of
subscribe buttons like /reddits/mine.
 2013-07-24 16:53:57 -07:00
Max Goodman
47711af358 Ratelimit multi subscribe bubble render calls. 
Since a single render call renders all items, we only need to call this
once, after all items have been added.
 2013-07-24 16:53:57 -07:00
Max Goodman
14b62169a5 Force parsed subreddit name to be a string. 2013-07-24 16:53:57 -07:00
Max Goodman
90bec0324a Use canonical username casing when generating multi URLs. 2013-07-24 16:53:57 -07:00
Max Goodman
51e7c0abbc Handle multi paths from route URLs case insensitively. 
This fixes multi lookups for users with capital letters in their name.
 2013-07-24 16:53:57 -07:00
Max Goodman
71cadef1bf Add title attribute to categorize bubble '>' multi links. 2013-07-24 16:53:57 -07:00
Max Goodman
d96416a3d2 Change template param names to lowercase_underscore style. 
Just for aesthetics.
 2013-07-24 16:53:57 -07:00
Max Goodman
54a9f3bf4f Add subreddit count to multi sidebar. 2013-07-24 16:53:57 -07:00
Max Goodman
7132efa249 Ensure that promoted link trackers are fetched in bare page loads. 2013-07-24 16:53:57 -07:00
Max Goodman
b073d7cef7 Replace the entire .content div when loading bare content. 
After I moved the ?bare param handling into Reddit, listing choosers
started getting included in bare page renders. This change moves the
related code into Reddit where we can more easily separate it out for
bare page purposes, and out of the .content div.

My fault for mixing metaphors here in the first place -- view
organization doesn't belong in controller code, and the listing chooser
doesn't belong in the same compartment as main page content.
 2013-07-24 16:53:57 -07:00
Max Goodman
fbaa4ad90f Whitespace. Getting peppy. 2013-07-24 16:53:57 -07:00
Max Goodman
8f693004fd Don't animate the listing chooser until the page has loaded. 
This should fix the collapse animation playing upon first load.
 2013-07-24 16:53:57 -07:00
Max Goodman
7f03388a54 Accept multi names 2 characters long. 2013-07-24 16:53:57 -07:00
Max Goodman
e937eef00d Use cursor pointer for right sidebar textual buttons. 2013-07-24 16:53:57 -07:00
Max Goodman
733fc4e9cf Space details sidebar privacy radios from actions slightly more. 2013-07-24 16:53:57 -07:00
Max Goodman
a619f35185 Animate left sidebar collapse/expand. 2013-07-24 16:53:56 -07:00
Max Goodman
4004441ba4 Widen and darken listing choooser grippy. 2013-07-24 16:53:56 -07:00
Max Goodman
ac1b29eb5c Generalize bare rendering into Reddit page class. 
This fixes some controllers (spam listings) not handling bare requests.
 2013-07-24 16:53:56 -07:00
Max Goodman
7b4134db37 Fix escaped entities in create multi invalid character errors. 2013-07-24 16:53:56 -07:00
Max Goodman
91fed180be When copying multis, pre-fill and select the name. 2013-07-24 16:53:56 -07:00
Max Goodman
b7a094e66a Work around silly LESS transparent color issue until ours is upgraded. 2013-07-24 16:53:56 -07:00
Max Goodman
ac88d48cad Remove preference to disable listing chooser. 2013-07-24 16:53:56 -07:00
Max Goodman
fe799f350a Minor listing chooser collapse styling tweaks. 2013-07-24 16:53:56 -07:00
Max Goodman
60c0fe5b7c Quick'n'dirty listing chooser bar collapsing. 2013-07-24 16:53:56 -07:00
Max Goodman
7511f9d29a Improve sidebar subreddit list sorting behavior. 
It turns out Backbone fires the 'sort' event after adding new models to a
collection. This allows us to reorder the views in the DOM in one batch
rather than having to insert elements into specific offsets in the DOM,
which breaks when 'add' events are out of order from the collection.
 2013-07-24 16:53:56 -07:00
Max Goodman
57acac7ab0 Fix multi details sidebar collection initial fetch and render. 
The switch from collection reset -> set caused the change handler in
MultiDetails to immediately fire off a refreshListing.

This change causes the collection contents to be loaded before the
instantiation of the view (due to preload), and makes the view handle
initial rendering of the collection contents in its constructor.
 2013-07-24 16:53:56 -07:00
Max Goodman
eeb1d6f2ea TooManySubredditsException -> TooManySubredditsError. 2013-07-24 16:53:56 -07:00