github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-29 00:38:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,352 Commits 1 Branch 0 Tags
c053d82883ec8e02e12e5fe16a5a82ae09e8acbf
Commit Graph

2352 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Logan Hanks
c053d82883 Parse dsn param to get key for pg stats. 2012-12-17 13:27:15 -08:00
Pavel
46070df795 Remove outline added to vote arrows by accessibility patch. 2012-12-17 12:56:54 -08:00
Neil Williams
2ddfab7e69 Accessibility: Make vote arrows into buttons. 
This adds three attributes to vote arrows:

* role="button" is part of ARIA and tells user agents that even though
  the vote arrow is a div, it's actually meant to be a button.
* aria-label, another part of ARIA, this tells user agents what to
  call the newly buttonized.
* tabindex, this makes the buttons able to receive keyboard focus so you
  tab through the document.
 2012-12-17 12:23:25 -08:00
Neil Williams
25b5683222 Accessibility: Remove meaningless alt text. 
It just gets in the way of screen readers.
 2012-12-17 12:23:25 -08:00
Neil Williams
2beabad0cc Accessibility: Add ARIA landmarks. 
These are the modern equivalent of the "jump to content" link.
 2012-12-17 12:23:25 -08:00
Neil Williams
11bda59611 Set PostgreSQL application_name metadata. 
This should allow us to collect more information on where lingering
transactions come from.

Note: this uses an undocumented feature of psycopg2 connection strings
to get around a limitation in the version of psycopg2 we're on. This is
resolved as of v2.4.3 of psycopg2.

http://archives.postgresql.org/psycopg/2011-11/msg00020.php
 2012-12-17 12:23:25 -08:00
Neil Williams
102ef36b8b Entity-escape error response payload JSON. 
This fixes a minor self-XSS in the Wiki editor for config/stylesheet and
should protect us against similar issues happening again in the future.

Thanks to @nealpoole for the disclosure.
 2012-12-17 11:30:41 -08:00
Neil Williams
a74f609eee /comments/gilded: Set c.profilepage = True for "in subreddit" etc. 2012-12-14 15:33:28 -08:00
Logan Hanks
9379b08c9a Change CommentTree CF's key from a tuple of bigints to a tuple of longs. 2012-12-14 13:05:47 -08:00
Neil Williams
e028c35676 Add a new listing of gilded comments. 2012-12-14 12:52:36 -08:00
Neil Williams
c91374acc4 db_manager: Don't try writing to slaves for rels. 2012-12-14 12:52:36 -08:00
Neil Williams
eebb529e2c db_manager: PEP-8 Cleanups. 2012-12-14 12:52:36 -08:00
Neil Williams
2ef7985618 Revert "queries: Move /r/all/comments to new query cache (try 3)." 
This reverts commit 13497f6f08.
 2012-12-14 12:52:35 -08:00
Neil Williams
d6924c8bcc rss: Don't render invalid thumbnails for built-in sprited thumbs. 2012-12-14 11:57:47 -08:00
Neil Williams
06742f69b7 rss: Add atom:link rel="self" to RSS feeds. 
This is recommended by the W3C RSS feed validator:

http://validator.w3.org/feed/docs/warning/MissingAtomSelfLink.html
 2012-12-14 11:57:41 -08:00
Max Goodman
8ba1ef41d6 Update ToC styling to match new wrapper class. 2012-12-13 13:22:14 -08:00
Max Goodman
974d18479c Add "get" method to LiveConfig. 2012-12-13 13:22:14 -08:00
Max Goodman
b7e3727cde Add placeholder element and styling for ad frames. 2012-12-13 13:22:14 -08:00
Max Goodman
8b77613309 Parameterize the Ads template. 2012-12-13 13:22:14 -08:00
Keith Mitchell
78888f1373 Fix GET_subreddits_by_topic 2012-12-12 13:45:08 -08:00
Keith Mitchell
590eb25c0c Add simple date drop down to search 2012-12-12 13:45:04 -08:00
Andre D
a225d34a6f wiki: Move space replace into normalize. 2012-12-12 13:33:20 -08:00
Andre D
2bda185248 wiki: Clarify permissions language. 2012-12-12 13:33:20 -08:00
Andre D
bb5ef967fb wiki: Editing a wiki page requires it to exist. 2012-12-12 13:33:20 -08:00
Andre D
0a03256226 wiki: Ensure to normalize page name on create check. 2012-12-12 13:33:20 -08:00
Andre D
d332dc4410 wiki: Explicit check for a banned user. 2012-12-12 13:33:20 -08:00
Andre D
9417f111af wiki: Ensure you cannot create an empty page. 2012-12-12 13:33:20 -08:00
Andre D
ff3632482f wiki: Ensure people who are added to approved wiki may edit. 2012-12-12 13:33:20 -08:00
Max Goodman
a2c5f143e1 wiki: Fix ToC styling for nested <ul>s. 2012-12-11 14:42:48 -08:00
Max Goodman
cde3b679eb Revert "Add maxlength attribute to submit form title field." 
This reverts commit 72b81791ca637ecb8073fa577d88033e154a7a56.
 2012-12-11 14:42:48 -08:00
Neil Williams
0776e39668 Move "close window" button to top of in-page popups. 
As requested by the vertical-space challenged users of the world.

Also moves the title to the left because it looks better and because the
floated close link was making it off-center.
 2012-12-10 11:30:46 -08:00
Neil Williams
f01095c5a3 cssfilter: Don't strip_www from absolute URLs. 
This was preventing using images from www.redditstatic.com.
 2012-12-10 11:30:46 -08:00
Keith Mitchell
21fdf7e0ab Fix canonical_email for addresses with utf-8 2012-12-10 11:30:46 -08:00
Max Goodman
099b6afa6f Whisper sweet nothings to the goldmembers. 2012-12-07 15:53:11 -08:00
Max Goodman
4024dd5e8a Markdownify goldvertisements. 2012-12-07 15:53:11 -08:00
Neil Williams
91a34e53d1 Execute new_vote on comments as well. 
This fixes user page top comments of all time listings not being
updated.
 2012-12-07 14:09:24 -08:00
Jason Harvey
8b4b3961d9 Rework queries and add sanity checks. 2012-12-07 14:09:24 -08:00
Neil Williams
cf2d5625ef CommentPane: try to avoid building comment tree if possible. 2012-12-07 11:01:33 -08:00
Neil Williams
d0babbd109 Remove CommentParticipationByAccount. 
It was a bad idea. I miscalculated which aspect of CommentPane was
taking the try_cache time.
 2012-12-07 11:01:33 -08:00
Andre D
7850a4b25a wiki: Fix deleted account leak. 2012-12-06 14:56:41 -08:00
Andre D
d20ec78d4e wiki: Remove show_reason_field 2012-12-06 14:56:41 -08:00
Andre D
d2cbe50398 wiki: JS cleanup 2012-12-06 14:56:41 -08:00
Andre D
21197a8a30 wiki: JS semicolon 2012-12-06 14:56:41 -08:00
Andre D
389fcd040b wiki: PAGE_NAME_MOVED -> PAGE_NAME_NORMALIZED 2012-12-06 14:56:41 -08:00
Andre D
468fb13b68 wiki: Get author accounts with data 2012-12-06 14:56:41 -08:00
Andre D
2ce84edb73 wiki: Move serializeForm into utils 2012-12-06 14:56:41 -08:00
Andre D
6136908b3d wiki: js cleanup 2012-12-06 14:56:41 -08:00
Andre D
bd054a34a4 wiki: Replace error_on_different with error_on_name_normalized 2012-12-06 14:56:41 -08:00
Andre D
2fc82aaef2 wiki: Switch items() to itervalues() 2012-12-06 14:56:41 -08:00
Andre D
b3c3b399f5 wiki: Drop parentheses around 'page' 2012-12-06 14:56:41 -08:00