Commit Graph

2495 Commits

Author SHA1 Message Date
Neil Williams
c1251f32bc Revert "Temporarily use "[deleted]" in JSON for deleted usernames." 2013-01-28 09:47:31 -08:00
Andre D
e3612b3d12 Wiki: Fix unicode encoding issue 2013-01-28 09:47:31 -08:00
Andre D
a9a2463336 Wiki: Replace TOC with a python generated one
- Replaces terrible anchor links with header content based ones
- Fixes quirks with oddly ordered headers
- Fixes html in headers appearing as text in TOC
2013-01-28 09:47:31 -08:00
Andre D
660f834263 filters: Allow id as an attribute 2013-01-28 09:47:31 -08:00
Andre D
20d1f9fe9e filters: Allow a links to have rel as soup replaces nofollow with them. 2013-01-28 09:47:31 -08:00
Andre D
826c00fee5 wiki: Validate wiki markdown with the wiki md processor. 2013-01-28 09:47:30 -08:00
Roger Ostrander
2ab402c41d Domainban: Use Zookeeper as a backend 2013-01-25 12:35:08 -08:00
Chad Birch
903a9e7736 Move negative karma to bottom of per-subreddit karma list 2013-01-24 12:00:59 -08:00
Neil Williams
7e715b1197 cookies: Don't encrypt the unlogged-user _options cookie.
This cookie is part of the CDN cache key. Since the encrypted blob uses
a random salt, this essentially makes requests with the cookie
unchacheable. The cookie does not contain any sensitive data (just a
list of languages and a boolean True/False). Decrypting and normalizing
the order of params means that the cache key will be more useful. We
also get a fair reduction in size of the cookie.
2013-01-24 10:39:34 -08:00
Neil Williams
77ee82cf9c cookies: Gracefully handle invalid encrypted blobs in _options.
This fixes a TypeError from b64decode when the input is bad. This patch
is needed to gracefully survive new-style cookies during the rollout
period.
2013-01-24 10:39:34 -08:00
Neil Williams
d14c00c1d9 cookies: Make over18 cookie not IP-hashed.
The over18 cookie's IP hashing behavior is of dubious use and is not at
all compatible with efficient CDN caching.
2013-01-24 10:39:34 -08:00
Neil Williams
f7f94d5cd7 Remove /validuser endpoint now that the Trac wiki is gone. 2013-01-24 10:39:34 -08:00
Neil Williams
2a2ee845da Limit concurrency for /api/morechildren.
The frontend limits you anyway, so this is only being abused by
userscripts, extensions, and API clients. This should prevent individual
users from taking up a bunch of apps with slow morechildren requests.
2013-01-23 11:35:22 -08:00
Jason Harvey
eeb32ec12a Prevent _banned users from resetting their password. 2013-01-22 16:48:57 -08:00
Ricky Ramirez
53d358bc61 routing/wiki: PEP8 cleanups. 2013-01-22 16:48:57 -08:00
Ricky Ramirez
808b2a4648 wiki: Redirect /help urls to /wiki. 2013-01-22 16:46:22 -08:00
Max Goodman
98d0ca5e7a Move announcement_message to ZooKeeper. 2013-01-22 16:33:35 -08:00
Max Goodman
ab47d07220 Fix button backgrounds in .compact.
Thanks to Scott Vivian <scott.vivian@gmail.com>.
2013-01-22 16:33:35 -08:00
Logan Hanks
598980269b Add OAuth support to many types of listings. 2013-01-22 15:18:03 -08:00
Logan Hanks
2d2df8dfab Add documentation and OAuth scope to GET_stylesheet. 2013-01-22 15:18:03 -08:00
Neil Williams
681b6b003e cookies: Add stats tracking of the various cookie types we get.
This should help us see how much our upcoming cookie changes have an
effect.
2013-01-22 14:52:32 -08:00
Neil Williams
04e902b2f2 "suggest title": Respect encoding of response from target URL. 2013-01-22 14:52:31 -08:00
Neil Williams
afeabf204f Move consumer count info to individual files.
This is more easily composable among multiple puppet recipes etc.
2013-01-22 14:52:31 -08:00
Andre D
d374e0e26c DefaultSR: Fix is_wikibanned using base.is_banned 2013-01-22 12:11:34 -08:00
Andre D
db857a5066 DefaultSR: Implement is_wikicontributor 2013-01-22 12:11:34 -08:00
Andre D
42366728e4 subreddit: Expose sr images to DefaultSR 2013-01-22 12:11:34 -08:00
Ricky Ramirez
edb32f1cc1 hourly traffic: Use instance parameter for timeslice.
Upstart only allows one job/instance combo to run at once. Must parametrize
the upstart job so that multiple jobs won't run into each other.
2013-01-22 13:58:20 -05:00
bsimpson63
9f0e8c65e9 Hourly traffic: fix quotes. 2013-01-22 13:58:20 -05:00
bsimpson63
a70a6eac62 Process traffic logs on Amazon EMR. 2013-01-22 13:58:19 -05:00
bsimpson63
7b28d3c3e8 Configurable timeout for memoize lock
The function being memoized might take longer to return than the
previously unconfigurable default timeout.
2013-01-22 13:55:28 -05:00
Neil Williams
148fddf18d upstart: Add a job to run on boot. 2013-01-22 10:31:42 -08:00
Neil Williams
3cd57248aa promoted links: Don't check link freshness in keep_items.
This makes it so that we no longer hide promoted links if the user has
voted on them. This has been causing too much confusion.
2013-01-22 10:31:42 -08:00
Keith Mitchell
347f872e5d Fix market totals on /promoted/graph 2013-01-17 12:18:39 -08:00
Ricky Ramirez
7611e76a3c POST_compose: Limit message subjects to 100 characters. 2013-01-17 12:18:32 -08:00
Max Goodman
fcedf701ee Make API banned_by / approved_by mutually exclusive.
This also fixes an API bug where banned_by was always true if you don't
have moderator permission for a thing.
2013-01-16 15:59:26 -08:00
Max Goodman
0a0d3fe1c6 Include domain in buttonlite submission link. 2013-01-16 12:12:44 -08:00
Neil Williams
ce6450841e setup.py: Update snudown link to new GitHub download URL. 2013-01-16 10:20:50 -08:00
Bryce Boe
32359ee6b7 Indicate failure when no moderator invite is found. 2013-01-15 14:30:16 -08:00
Neil Williams
ad06201f57 traffic: Separate apart weeks in day-interval tables.
This should help to make week-by-week trends a little clearer and also
make it easier to see what day of the week a day was.
2013-01-15 14:30:16 -08:00
Neil Williams
7564f3a475 traffic: Add explanation of which timezone the data is in. 2013-01-15 14:30:16 -08:00
Neil Williams
a5c6333046 traffic: Generalize max-row highlighter and use on all columns. 2013-01-15 14:30:16 -08:00
Neil Williams
74e7d5d725 Move render info blurb out of redditfooter to avoid caches.
RedditFooter is a CachedTemplate and so the blurb which is supposed to
be unique to each request is being rendercached.
2013-01-15 14:30:16 -08:00
Neil Williams
2c09a35627 Don't write the pagecached content twice. 2013-01-14 16:23:41 -08:00
Neil Williams
f9ee3c6a22 Fix use of StackedObjectProxy pylons.response in debug error pages.
This caused some debug page static files to generate an error.
2013-01-14 15:32:38 -08:00
Neil Williams
4a04c18842 ErrorController: Fix bad failien URL on handle_awful_failure case. 2013-01-14 15:32:38 -08:00
Neil Williams
a2e2e46312 ErrorController: Don't ever return a body in 204/304 responses.
This should fix an issue where we return a JSON body for 304 responses
to API requests which is invalid according to the HTTP spec and appears
to be causing bad data to get cached in the CDN.
2013-01-14 15:32:38 -08:00
Neil Williams
e1482553ca embed/wired/widget: Add callback validation à la JSONP. 2013-01-14 15:32:38 -08:00
Neil Williams
116e9939aa Get rid of awkward and underused utils.to_js.
Buttonlite didn't really do anything with this function since it
disabled callback *and* escape.

The response wrapper fixes a bug where the callback is a unicode object
and since the content object is UTF-8 encoded things go south ("'ascii'
codec can't decode byte ...").

This also removes a few scattered imports of the function that were
unused.
2013-01-14 15:32:38 -08:00
Jason Harvey
048b6700ba Add timestamp to debuginfo footer text. 2013-01-14 15:32:38 -08:00
Neil Williams
f5cc13db2a Use profile page mode for all /comments/gilded listings. 2013-01-14 11:33:56 -08:00