fix: revert showProgress and dead code cleanups per code review

Restore showProgress signature and return/e dead code to keep
the diff minimal per cpsievert's feedback.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
E Nelson
2026-04-24 11:34:28 -04:00
parent 9366f5d72b
commit 2483746d5f
5 changed files with 18 additions and 9 deletions

View File

@@ -3023,8 +3023,10 @@
}
// Progress shouldn't be shown on the download button
// (progress will be shown as a page level pulse instead)
showProgress() {
showProgress(el, show3) {
return;
el;
show3;
}
};
(0, import_jquery25.default)(document).on(
@@ -3040,6 +3042,8 @@
evt.name = el.id;
evt.href = el.href;
(0, import_jquery25.default)(document).trigger(evt);
return;
e4;
}
);

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@@ -22,8 +22,10 @@ class DownloadLinkOutputBinding extends OutputBinding {
}
// Progress shouldn't be shown on the download button
// (progress will be shown as a page level pulse instead)
showProgress(): void {
showProgress(el: HTMLElement, show: boolean): void {
return;
el; // eslint-disable-line @typescript-eslint/no-unused-expressions
show; // eslint-disable-line @typescript-eslint/no-unused-expressions
}
}
@@ -51,6 +53,9 @@ $(document).on(
evt.name = el.id;
evt.href = el.href;
$(document).trigger(evt);
return;
e; // eslint-disable-line @typescript-eslint/no-unused-expressions
},
);