Joe Cheng
3450a037a9
Further simplification and more tests for req()
2015-12-17 11:29:54 -08:00
Joe Cheng
f57626d256
req() simplification
2015-12-17 11:16:09 -08:00
Joe Cheng
c1c3fa4d3a
Fix a couple of req edge cases
2015-12-17 11:13:33 -08:00
Joe Cheng
300433f7de
req() now short-circuits on falsy values
2015-12-17 10:53:13 -08:00
Joe Cheng
eee6f4ed81
Add req function for validating required inputs/values
2015-12-16 10:04:05 -08:00
Joe Cheng
3a0ce86f51
Remove unnecessary check (feedback from @wch)
2015-12-15 15:36:43 -08:00
Joe Cheng
6041b8cbb2
Roxygenize
2015-12-14 18:00:29 -08:00
Joe Cheng
3ba8fcb7b8
Merge pull request #1036 from rstudio/joe/bugfix/validation-error-behavior
...
Fix validation error handling
2015-12-14 17:16:04 -08:00
Joe Cheng
f74d9c93a2
Merge pull request #1035 from rstudio/joe/bugfix/multiline-label
...
Fix warnings when renderXXX is called with explicit namespace
2015-12-14 17:15:50 -08:00
Joe Cheng
739c162281
Fix warnings when renderXXX is called with explicit namespace
...
Calling shiny::renderText(...) instead of renderText(...) would
cause warnings.
2015-12-14 17:11:40 -08:00
Joe Cheng
a2700c900d
Fix validation error handling
...
Validation errors were behaving too much like real errors: they were
being printed with stack traces, and passed to the options(shiny.error)
function. Also, if a reactive() cached a validation error, on future
calls the error would be re-raised (which is correct) without the
custom class names attached (which is not).
2015-12-14 16:31:57 -08:00
Winston Chang
01bbee59eb
Merge pull request #1023 from yihui/bugfix/1018
...
Fixes #1018 : make sure the selected value is always returned from sever-side selectize
2015-12-10 13:44:24 -06:00
Yihui Xie
6056c35de3
add a news item, and run grunt
2015-12-09 11:56:13 -06:00
Yihui Xie
4202991ca5
Fixes #1018 : make sure the selected value is always returned from server-side selectize
2015-12-09 11:52:50 -06:00
Joe Cheng
788931c7c7
Merge pull request #1027 from yihui/yihui/srcfilecopy
...
Check R version at runtime (#968 )
2015-12-09 09:48:59 -08:00
Yihui Xie
b2d0505c7c
Check R version at runtime ( #968 )
2015-12-08 20:33:52 -06:00
Winston Chang
8b710d651f
Merge pull request #1026 from rstudio/joe/bugfix/hidden-slider-update
...
Fix #1010 : updateSliderInput doesn't update hidden sliders
2015-12-08 19:50:12 -06:00
Joe Cheng
93697bb01d
Merge pull request #1025 from yihui/bugfix/source-utf8
...
Fixes #1003 : correctly parse source code that can be represented with native encoding
2015-12-08 15:51:51 -08:00
Joe Cheng
89cd58e4f8
Fix #1010 : updateSliderInput doesn't update hidden sliders
2015-12-08 11:13:18 -08:00
Yihui Xie
a622f029a0
Fixes #1003 : when the source code can be represented via the native encoding on Windows, rewrite the code to a temporary file with the native encoding and parse it
2015-12-07 16:28:45 -06:00
Winston Chang
97afb52904
Re-document with Roxygen2 5.0.1
2015-12-02 15:43:25 -06:00
Joe Cheng
02ea31be08
Fix #1020 : Graphics are cut off
2015-12-01 13:47:26 -08:00
Joe Cheng
b5e49a6619
Fix bugs reported by @daattali
...
- reactive srcrefToLabel call fails if code is pasted in at RStudio console
- Stack trace fails when promise (!?) is in call stack
2015-11-24 11:55:08 -08:00
Joe Cheng
179c931f85
Bump version
2015-11-23 10:58:30 -08:00
Joe Cheng
4d3fa2c8ac
Merge pull request #1011 from rstudio/joe/feature/better-errors
...
Better errors
2015-11-20 12:56:24 -08:00
Joe Cheng
8e4f7387d0
Better stack traces for observeEvent and eventReactive
2015-11-16 13:10:53 -08:00
Joe Cheng
feb630b2c5
Catch errors when trying to print stack trace
...
No known errors will occur when printing the stack trace, but since
this is fairly complicated code executing when an error has already
happened, better to be on the defensive.
2015-11-16 13:08:34 -08:00
Joe Cheng
948dfbb56b
More tests
2015-11-16 12:50:20 -08:00
Joe Cheng
5c3ac75b34
Errors in ui function should get stack traces
2015-11-16 12:46:22 -08:00
Joe Cheng
adc5c8e37a
Normalize shiny dir in smoketest stack traces
2015-11-16 12:45:59 -08:00
Joe Cheng
52d594c143
Quick and dirty smoke test infrastructure
2015-11-16 12:29:02 -08:00
Joe Cheng
1018b0d966
Errors in ui.R, server.R, server func, etc. all get stack traces
2015-11-16 10:48:16 -08:00
Joe Cheng
0ce153d788
Doc updates
...
Code had to be rearranged to make the functions show up in the
help docs in the right order
2015-11-14 00:26:23 -08:00
Joe Cheng
ff9756c739
Add more exports, tests
2015-11-14 00:17:19 -08:00
Joe Cheng
b3dd7e5397
Remove support for shiny.observer.error option
...
It is dangerous to set this on a per-process basis. If we even
still want the ability to have observer errors not kill the
session (debatable) we should do so by having an option on the
session object that is set when the shiny server function runs.
Not only does this remove support for the option, but now we
will refuse to connect and will abort the session if the option
is set to a non-NULL value. This is to prevent apps from moving
forward with the assumption that their option will work, when
it really won't. (I doubt anyone is using it anyway, it's so
obscure...)
2015-11-13 18:13:14 -08:00
Joe Cheng
6ac0a80896
Update NEWS with stack trace announcement
2015-11-13 17:58:18 -08:00
Joe Cheng
93f774c7e7
Add exports/docs
2015-11-13 17:52:26 -08:00
Joe Cheng
661c08549d
Automatically wrap installExprFunction with function labels
...
This lowers the burden on renderXXX functions having nice stack traces
2015-11-13 16:43:15 -08:00
Joe Cheng
c8acc44012
Add comments to stacktraceon/off directives indicating their partners
2015-11-13 16:25:22 -08:00
Joe Cheng
aabf00659e
Random improvements to stack traces
...
- More selective removal of frames at end of call stack
- Add withLogErrors, printError, stripStackTrace convenience funcs
- Properly capture/log errors for various levels of unhandled errors
- Unhide stacks for flush/flushed/sessionended callbacks
2015-11-13 16:03:18 -08:00
Joe Cheng
a9bc41492c
Collapse stack trace to eliminate irrelevant bits
2015-11-13 12:36:55 -08:00
Winston Chang
12b0484e9a
Merge pull request #875 from wch/rendertable-args
...
Separate xtable from print.xtable args. Closes #761
2015-11-13 11:48:41 -06:00
Joe Cheng
d3605dbcb3
Collapse parts of the stack
2015-11-12 16:40:56 -08:00
Joe Cheng
d9a016f94c
Move error-handling logic into conditions.R
2015-11-11 16:20:26 -08:00
Joe Cheng
a13657ac23
Work properly with non-call sys.call() objects
2015-11-11 15:54:03 -08:00
Joe Cheng
d6c95a9e89
wip
2015-11-11 12:14:42 -08:00
Winston Chang
825e9e04c1
Get xtable args using formals()
2015-11-05 13:04:43 -06:00
Winston Chang
c596e44c5a
Separate xtable from print.xtable args. Closes #761
2015-11-05 13:01:01 -06:00
Winston Chang
66be9004fe
Move renderTable to separate file
2015-11-05 12:59:04 -06:00
Winston Chang
119ebb0f07
Merge pull request #1005 from rstudio/joe/bootstrap-3.3.5
...
Upgrade bootstrap to 3.3.5
2015-11-05 12:43:34 -06:00
