* Use `fontawesome::fa_i()` for FA <i> tags
* Remove fontawesome vendor files
* Add fontawesome pkg to Imports & Remotes
* Remove FontAwesome `person()` entry
* Remove Font Awesome license info
* Delete font-awesome.R
* Update 'Collate' field (removes 'font-awesome.R')
* Delete updateFontAwesome.R
* Prefer use of `fontawesome::fa()`
* Improve function documentation
* Update help file using roxygen
* Modify icon name
* Update icon name in example
* Modify icon name in example
* Update help files
* Update bootstrap.R
* Update icon.Rd
* Update bootstrap.R
* Revert `showcaseCodeTabs()` to use FA v4 name
* Revert icon name in example (back to FA v4)
* Remove `call. = FALSE` in `stop()`
* Remove `fontawesome` from Remotes
* Add min version req for the fontawesome pkg
* Increase minimum version requirement for fontawesome
* Update roxygen docs for `icon()`
* Document (GitHub Actions)
* Update icon.Rd
* Generate early return <i> tag for tabsetPanel logic
* Close#3384 and #3383: simplify and correct icon() logic
* Install htmltools PR for now
* Document (GitHub Actions)
* Avoid using tag attribs to hold non-attribute values
* Better legacy support
* No need to call prepTabIcon() twice
* code review
* Fix glyphicon class creation
* update news
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: rich-iannone <rich-iannone@users.noreply.github.com>
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Follow up to #3315: reduce complexity and 'black-boxed' nature of tab panel logic
* asTags(selected = FALSE) is now root()
* tagAddRenderHook
* Add bslib to remotes
* Document (GitHub Actions)
* root() was recently changed to allTags()
* code review
* tagQuery() doesn't necessarily preserve order of attributes
* place href attribute before data attributes
* add nav-item/nav-link to BS4+ dropdowns
* Make sure .nav-item is removed in .dropdown-menu
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
* Allow trailing commas in more places
I grepped for list(...) and replaced with rlang::list2(...). This also enables !!! which is generally not important for Shiny because it automatically splices lists/tagLists, but I doubt it will affect any existing code.
* update news; no need to rlang::
* missed one
* Update NEWS.md
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
* 'Native' Bootstrap 4 tabset panel support
* downgrade error to warning; improve the messaging
* Make tab anchor selectors more a bit more sensible and consistent across versions
* More of the same
* fix silly bug
* Be more careful about unpacking a .nav-item into a .dropdown-item
* Keep refactoring R logic to make it cleaner and easier to reuse elsewhere
* Go back to the purely class based CSS selectors for BS4 tab input
* Keep supporting off-label behavior of shiny.tag getting transformed into 'empty' nav/tab
* Add header and footer args to tabsetPanel()/navlistPanel() since there is precedence in navbarPage() and mention them in the warning
* Drop NULLs instead of creating an empty nav from them, closes#1928
* Remove tabPanelMenu() alias
* Add a card argument for wrapping content in a card
* Throw an error if card=T is used outside of a BS4+ context
* No more tabPanelMenu() alias
* Document (GitHub Actions)
* Port JS changes to TypeScript
* Allow liTag to be assigned a new value
* abort() is no longer being used
* Add some unit tests
* Document the new card argument
* Get tests passing on older R versions
* Get tests passing on older R versions
* Get tests passing on older R versions
* Skip snapshots on R < 3.6
* require dev version of htmltools
* remove card argument (at least for now)
* Document (GitHub Actions)
* Update tests/testthat/test-tabPanel.R
Co-authored-by: Winston Chang <winston@stdout.org>
* Have processDeps() call renderTags() on tagFunction() objects
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
Co-authored-by: Winston Chang <winston@stdout.org>
