github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-26 23:39:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,736 Commits 1 Branch 0 Tags
2f5d8cd4faf5cf601a2ac6607a57b4e2d2ed2da8
Commit Graph

3736 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Neil Williams
2f5d8cd4fa Add a middleware to sanitize response splitting attempts. 
Thanks to Jordan Milne (/u/largenocream) for reporting this and
joyent/node@3c293ba272 for inspiration for
this solution.
 2013-11-07 13:04:09 -08:00
Andre D
909ce5fefb submit_text: Solve race condition issues by aborting old requests. 2013-11-06 13:03:35 -08:00
Roger Ostrander
533d3765d7 Subreddit Creation: Display defaults for spam 2013-11-06 13:03:35 -08:00
Brian Simpson
969ee4cc46 Only run analytics stuff in an organic listing. 
Prevents counting impressions and clicks on pages where the ad is being
managed.
 2013-11-06 13:03:35 -08:00
Brian Simpson
98e874a97d Show self-serve advertising button on traffic pages. 2013-11-06 13:03:34 -08:00
Chad Birch
c47a6ad28e Yesterday's gold goal: tiny alignment tweaks 2013-11-06 13:03:34 -08:00
Chad Birch
bbda62606e Daily gold goal: add countdown to end time 2013-11-06 13:03:34 -08:00
Chad Birch
3458468355 Gold: move about/partners to plugin 2013-11-06 13:03:34 -08:00
Chad Birch
c4d053b802 Gold pages: update buy gold link 2013-11-06 12:50:45 -08:00
Max Goodman
dcf6281afb spotlight: Advance to next item if an ad fails to load. 2013-11-06 12:50:45 -08:00
Max Goodman
4eb7d56ed0 spotlight: Increase promo timeout to 1s. 
500s isn't seeming to cut it... :(
 2013-11-06 12:50:45 -08:00
Brian Simpson
142b80e806 Clean up logging in promote. 2013-11-06 12:50:45 -08:00
Brian Simpson
a7aceacf80 Record promote status changes in PromotionLog. 2013-11-06 12:50:45 -08:00
Max Goodman
8ac9ddc837 compact: Add cake icon CSS sprite. 2013-11-06 12:50:45 -08:00
Max Goodman
bbe3f1283c Increase specificity of compressed links midcol sizing. 
To match/override the new rules in linklisting.html.
 2013-11-06 12:50:45 -08:00
Max Goodman
a4ff508ba5 Increase rank/midcol width selector specificity. 
This style was applying to comments, making their voting arrows wider
than necessary. Comments don't actually need to be lined up anyway.
 2013-11-06 12:50:45 -08:00
Max Goodman
b919760015 Hide link rank number on comments and profile pages. 2013-11-06 12:50:45 -08:00
Jason Harvey
eab526c060 Track subdomains in GA. 2013-11-06 12:50:45 -08:00
Brian Simpson
2a41ff7e3a Remove Google Checkout from gold payment options. 2013-11-06 14:15:52 -05:00
Neil Williams
817f8d66c2 Add hooks into comment/vote endpoints. 
This stuff is needed for the server naming subreddit overrides.

Would love to see it replaced with custom Thing subclasses in the
future.
 2013-11-05 14:35:53 -08:00
Brian Simpson
633ed54a2d Campaign 'override' attribute can't be boolean. 2013-11-01 13:58:04 -04:00
Chad Birch
30663ba798 Listings: use default limit if no pref_numsites 
Currently if the user's pref_numsites value is None (very old accounts
that have not changed their preferences), listing pages return all
items, and any hot listings with a sticky crash. This uses the default
page size if the user has not set their own default.
 2013-11-01 10:03:09 -06:00
Chad Birch
4c775ff2d1 Deleted link author: add right margin 2013-11-01 10:03:00 -06:00
Chad Birch
95ab8367a7 Gold goal popup: add yesterday's progress 2013-11-01 10:02:55 -06:00
Roger Ostrander
3cfa44b29e Vote details: refactor out decoding 2013-10-31 11:54:08 -07:00
Brian Simpson
64b1749625 get_promo_traffic: Handle case with clicks but no imps. 2013-10-31 11:09:31 -04:00
Brian Simpson
736008f269 Delete sr_discovery_links. 2013-10-31 11:09:22 -04:00
Brian Simpson
c4e1678bba Update make_spotlight docstring. 2013-10-31 11:09:22 -04:00
Brian Simpson
11cdea4c97 Set default bid when creating new campaign. 2013-10-31 11:09:22 -04:00
Brian Simpson
a35a4d1a1d Remove input names from promotelinkform so they aren't POSTed. 2013-10-31 11:09:22 -04:00
Brian Simpson
ff1eb45b6a Add priorities to PromoCampaign. 2013-10-31 11:09:16 -04:00
Max Goodman
261bc5825c Clean up unused gold partners string. 2013-10-30 16:13:50 -07:00
Max Goodman
4e93247f9a Listing suggestions: don't suggest the multi you are on currently. 2013-10-30 16:13:50 -07:00
Max Goodman
7fd33a2a97 Reserve space for the spotlight box on /r/all to reduce flicker. 2013-10-30 16:13:50 -07:00
Max Goodman
f1e9c1d1a3 spotlight: Only display loading placeholder on the front page. 
Subreddit listings often don't have targeted ads, so the previous
default behavior of reserving space usually caused flicker.
 2013-10-30 16:13:50 -07:00
Max Goodman
1d44701a0e Remove obsolete .cname body class. 2013-10-30 16:13:50 -07:00
Max Goodman
81f7912186 Fix mutation of parent extra_page_classes in BrowseController. 
This caused the controller to eventually accumulate both the .top-page
and .controversial-page classes for every request since the parent
class's structure was being mutated.
 2013-10-30 16:13:50 -07:00
Neil Williams
e0ef19433d Pull debug footer out into its own template. 
This allows plugins to override it.
 2013-10-29 12:43:55 -07:00
Max Goodman
c0a5264023 Add hook for triggering actions upon distinguish. 2013-10-28 14:43:38 -07:00
Brian Simpson
2af8fe6703 promote: create Decimal from string not float. 
Creating a Decimal from a float results in precision loss.
 2013-10-28 11:51:27 -04:00
Brian Simpson
38c8faf140 Don't memoize campaign_history. 
campaign_history is used to look up traffic for links in batch
and the return can be too large for memoize. The query is fast and
only used by admins so not memoizing it shouldn't be a problem.
 2013-10-28 11:51:27 -04:00
Brian Simpson
1e29502b9b Fix typo in refund emailer. 2013-10-28 11:51:21 -04:00
Max Goodman
2a94a7e7d8 Hide focus outline browser styles on link titles. 
Now that link titles have tabindex, several browsers outline them when
focused. Let's override that behavior so that they act the way they did
before the tabindexes.
 2013-10-25 16:29:29 -07:00
Neil Williams
5154319f90 Add "clicked" back to JSON for clients relying on it. 2013-10-25 16:29:29 -07:00
Josh Wardle
a2b7967133 Feedback page update 2013-10-24 16:03:36 -07:00
Neil Williams
db119b9197 POST_store_visits: Add VModhash requirement. 2013-10-24 16:03:35 -07:00
Ricky Ramirez
30c1df3a8f Add anchor-top-left class for idn-help bubble. 2013-10-24 16:03:34 -07:00
Ricky Ramirez
9ea230760b Show IDN on domain listings when appropriate. 2013-10-24 16:03:33 -07:00
Ricky Ramirez
727fe14c2e r.ui.Bubble: Don't position a Bubble off screen. 2013-10-24 16:02:17 -07:00
Ricky Ramirez
ebe1f7a9fa Remove obsolete selfserviceoatmeal.html 2013-10-24 16:02:17 -07:00