The `include_spirv` macros was set to accept literals only.
Unfortunately, this means that other macros, such as `concat` and `env`
aren't accepted, making it unusable with build script-compiled shaders.
This change allows those macros to be used to load the SpirV at the
expense of a potentially less helpful error message as the `literal`
requirement is differed to the `include_bytes` invocation.
390: Example feature matrix r=cwfitzgerald a=kvark
This PR introduces a feature matrix to show what feature can be found in which example. I expect we'll be linking to it a lot :)
It also renames the `describe` example so that we can distinguish easily between ones that are framework-based and standalone ones (starting with "hello").
Concerns:
- the star may be a bit too bleak... I haven't found a better one that would be short to type (choosing a long one means editing is uncomfortable).
- sometimes hard to figure out what deserves a feature in the table and what not... still a win to have at least something here
- we need to do something with `capture`, see #387, but I haven't figured out what exactly
also r? @rukai
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
380: Documentation Pass r=kvark a=cwfitzgerald
The wgpu-rs component of https://github.com/gfx-rs/wgpu/pull/728.
Closes#378.
Notable changes not mentioned in wgpu PR:
- Reexported the wgt-local types whenever we have a type definition. These are reexported as `ThingBase`. This is unfortunately the only way to actually get their documentation to show up, aliases have no way of "inheriting" the documentation.
- Added wgpu logo to docs!
- Hid vertex_format_size macro.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
377: Update with minBufferBindingSize r=cwfitzgerald a=kvark
Depends on https://github.com/gfx-rs/wgpu/pull/726
Also reverts #373 : buffer bindings now have to include at least one element of an unsized struct portion, so they can't be zero-sized.
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
375: Add water example. r=kvark,cwfitzgerald a=OptimisticPeach
Solves #329, water example requested by @kvark.
I tuned it to my personal preference of visuals, however it might be different for you.
Note: I used https://github.com/ashima/webgl-noise for 3D open simplex noise.
I've commented to explain what most of the things in the rust side of the example mean. However, I'm not 100% sure I did the best job at giving a brief overview, and wouldn't mind someone making sure my terminology/definitions are correct.
Thanks!
Patrik
Co-authored-by: OptimisticPeach <patrikbuhring@yahoo.com>
369: Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING r=kvark a=cwfitzgerald
This implements https://github.com/gfx-rs/wgpu/pull/715 in wgpu-rs. I haven't changed the example, as I want to actually think up a better example to use and didn't want that to block this. It will change in the future however.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
370: API update for RODS2 r=cwfitzgerald a=kvark
Reflects upstream changes in https://github.com/gfx-rs/wgpu/pull/716
I'm not too happy about the API just yet, has another idea that I'm going to discuss with the group on Monday, hopefully. But we need to get going and not block other wgpu-rs changes, so this should land in some way.
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
360: Implement TEXTURE_BINDING_ARRAY extension r=kvark a=cwfitzgerald
This extends https://github.com/gfx-rs/wgpu/pull/711 into wgpu-rs.
Notable changes:
- Added an example showing off both this extension and the future descriptor indexing extension.
- Changed the framework so there is a static function showing what extensions you need. This is provided by the trait,, which defaults to no extensions, so existing examples and new ones don't have to care about extensions.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
356: Add generic ranges to buffer mapping api and make it safe. r=kvark a=lachlansneff
[Rendered](https://charted.space/notes/wgpu-rs/wgpu/struct.Buffer.html)
The safety issues with the current api (being able to unmap while still holding a slice to mapped data) are fixed by having `get_mapped_range` and `get_mapped_range_mut` return `BufferView` and `BufferViewMut`, which notify the buffer that those ranges are no longer being used when they're dropped. `Buffer.unmap` asserts that the list of mapped ranges is empty, therefore it is safe.
Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
350: Implement Extensions Interface r=kvark a=cwfitzgerald
This implements https://github.com/gfx-rs/wgpu/pull/703 in wgpu-rs. Notable changes include the removal of the anisotropic field from the examples, in favor of the now mandatory `..Default::default()` syntax.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
353: Properly honor `mapped_at_creation` in `Device::create_buffer` r=cwfitzgerald a=kyren
The returned `Buffer` should immediately be mappable. Fixes#351
Co-authored-by: kyren <kerriganw@gmail.com>
348: Add aribitrary texture size handling to the capture example r=me a=rukai
* User can specify width + height via arguments.
* Defaults to (100, 200) when no arguments. Odd values chosen to make it more likely to pick up issues when testing.
* Converts from bgra as I believe that is the most commonly supported format for swapchains?
Co-authored-by: Rukai <rubickent@gmail.com>
346: Add Makefile for shader compilation r=kvark a=HanKruiger
I couldn't find clear instructions on how to compile the shaders in the examples, and had to do some digging. So I added instructions to the README to hopefully save other people's time.
Sidenote: When I compile the shaders as they are now (with my instructions), I end up with different `.spv` shaders with (seemingly) equivalent behaviour. I expect this is due to a different version/environment of `glslang` (see below) but it could be a mistake on my part.
```
> glslangValidator --version
Glslang Version: 8.13.3743
ESSL Version: OpenGL ES GLSL 3.20 glslang Khronos. 13.3743
GLSL Version: 4.60 glslang Khronos. 13.3743
SPIR-V Version 0x00010500, Revision 3
GLSL.std.450 Version 100, Revision 1
Khronos Tool ID 8
SPIR-V Generator Version 8
GL_KHR_vulkan_glsl version 100
ARB_GL_gl_spirv version 100
```
Cheers!
Co-authored-by: Han Kruiger <HanKruiger@users.noreply.github.com>
Add example shader compilation instructions
Arbitrary depth directory wildcard like globs aren't a thing in make wildcards.
Add phony targets as prerequisites of .PHONY
345: Rustify the example's use of Extensions and SamplerDescriptor r=kvark a=cwfitzgerald
Implements https://github.com/gfx-rs/wgpu/pull/696.
This didn't change any content from #338, just interface, but I tested a couple examples and it seems to work okay.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
344: Use the new map-async r=kvark a=kvark
Depends on https://github.com/gfx-rs/wgpu/pull/675
It changes the API of mapping and removes `create_buffer_mapped`.
The new functionality is not implemented in Gecko yet, so this breaks the web target, for now.
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
338: Add Extension/Limit Interface r=kvark a=cwfitzgerald
Follow up to https://github.com/gfx-rs/wgpu/pull/690.
This forwards the extension/limit access interface into wgpu-rs.
It appears that the web-sys doesn't actually implement any of the methods we need, so I had them return the defaults. `Device::limits` exists, but it returns `Object` not `GpuLimits`, so doesn't appear usable.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
