Karan
07af5f91c8
chore(license): Change license from GPL-3 to MIT ( #4339 )
...
* Change license from GPL-3 to MIT
Updated the project license from GPL-3 to MIT in DESCRIPTION, LICENSE, LICENSE.md, README.md, and package.json. Added LICENSE.md with the MIT license text and updated .Rbuildignore to exclude LICENSE.md from builds.
* `npm run build` (GitHub Actions)
* Update LICENSE and add LICENSE.note
Replaced the LICENSE file content with a summary including year and copyright holder. Moved detailed third-party license information to a new LICENSE.note file.
* Remove R check log file
Deleted the ..Rcheck/00check.log file, likely to clean up generated or temporary files from the repository.
2025-12-16 17:51:22 -06:00
Barret Schloerke
fda6a9fede
chore(assets): Update asset versions ( #4337 )
2025-12-11 11:56:42 -05:00
Barret Schloerke
d2245a2e34
Increment version number to 1.12.1.9000
2025-12-09 16:29:27 -05:00
Barret Schloerke
a12a8130b8
v1.12.1 ( #4329 )
2025-12-09 16:26:52 -05:00
Barret Schloerke
b436d2a96d
Clarify OTel collection level usage in docs ( #4335 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2025-12-08 15:31:57 -05:00
Barret Schloerke
05b0f270c4
fix(otel): ExtendedTask's otel enabled status set during init ( #4334 )
2025-12-08 14:55:59 -05:00
Barret Schloerke
f24f71e4e0
feat(otel): Add withOtelCollect() and localOtelCollect() ( #4333 )
2025-12-08 14:30:40 -05:00
Barret Schloerke
63a00f775f
fix(otel): Duplicate otel code attribute keys using both deprecated and preferred names ( #4325 )
2025-12-03 16:37:20 -05:00
Barret Schloerke
5a946caf35
Skip timer tests on CRAN and fix empty vector comparison ( #4327 )
2025-12-03 16:29:17 -05:00
Barret Schloerke
16c016a171
Increment version number to 1.12.0.9000
2025-12-03 15:50:36 -05:00
Barret Schloerke
284af65534
Update .Rbuildignore
2025-12-03 15:50:27 -05:00
Barret Schloerke
b5da7868fa
v1.12.0 ( #4312 )
2025-12-03 15:48:49 -05:00
ismirsehregal
c8a41aa834
Update dateYMD ( #4318 )
...
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2025-12-01 10:25:28 -05:00
Copilot
390f6d3b95
chore(otel): Rename shiny.otel.bind to shiny.otel.collect ( #4321 )
...
Co-authored-by: Barret Schloerke <barret@posit.co >
2025-11-25 16:36:56 -05:00
Barret Schloerke
9a2140cd19
chore(test): Fix stacks test with R 4.5.2 ( #4322 )
2025-11-25 16:31:53 -05:00
Barret Schloerke
e3cf4fb089
refactor(otel): Cache tracer and logger on init and on demand ( #4315 )
...
Co-authored-by: Charlie Gao <53399081+shikokuchuo@users.noreply.github.com >
2025-11-11 08:44:57 -05:00
Barret Schloerke
472a1cdba1
refactor(otel): Refactor internal method names ( #4313 )
2025-11-06 11:20:37 -05:00
Barret Schloerke
b56c275364
feat(otel): Enhanced OpenTelemetry support ( #4300 )
2025-10-28 14:01:50 -04:00
Garrick Aden-Buie
592e825a0f
feat: Replace client-side markdown rendering with server-side in showcase mode ( #4306 )
...
* feat: Replace client-side markdown rendering with server-side in showcase mode
* `devtools::document()` (GitHub Actions)
* chore: callout rendering differences may happen
2025-10-22 09:34:20 -04:00
Barret Schloerke
50a140c580
ci(test): Disable installation of Cairo for unit tests ( #4301 )
2025-10-15 16:24:22 -04:00
Barret Schloerke
48d255a235
feat: Add {otel} support ( #4269 )
2025-10-14 15:40:36 -04:00
Barret Schloerke
a01fcc5194
chore(check): Fix minor check warnings ( #4299 )
2025-10-10 16:30:47 -04:00
Winston Chang
b6e9e9d216
Update package.json for publishing ( #4284 )
...
* Update package.json for publishing
* Use custom readme file for npm
* Update repository URLs
* Script cleanup
* Use name @posit/shiny
2025-09-09 16:37:06 -05:00
Barret Schloerke
5ddb99a5b4
update docs ( #4285 )
2025-09-05 13:52:30 -04:00
Carson Sievert
f981ed6363
feat: add shinyRemoveButton selectize.js option (for py-shiny) ( #4276 )
...
* fix: supply and retain default selectize.js plugins (for py-shiny)
* `npm run build` (GitHub Actions)
* Move more in a 'remove_button' attribute direction
* `npm run build` (GitHub Actions)
* Move to a JSON-only approach
* `npm run build` (GitHub Actions)
* Drop sticky update logic by always sending 'missing' value and resolving client-side
* Cleanup
* Don't mutate options; better typing pattern
* `npm run build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-08-28 15:49:25 -05:00
Carson Sievert
6d6b0ea6f9
fix: add CSS workaround to hide all but the first selectize remove button ( #4275 )
...
* fix: add CSS workaround to hide all but the first selectize remove button
* Update news
* Apply suggestions from code review
2025-08-21 16:48:34 -05:00
Barret Schloerke
0e355ed25c
preemptively run revdepcheck. 5 failures.
2025-08-18 09:10:19 -04:00
Barret Schloerke
80a9ff470c
fix(scss): Remove updated scss files and restore R sass compilation ( #4272 )
...
* Revert changes in 8861645d99 from #4252
We compile from R sass. So we should be partial to R's compiler, no the latest in npm
* Restore original compile script (with message) that built using R-sass, not npm
* Add step in build command to update the sass output
* run new command
2025-08-14 16:03:48 -04:00
Barret Schloerke
ead0abcd62
bug(check): Update .Rbuildignore with new and removed files ( #4270 )
2025-08-04 23:17:45 -04:00
Barret Schloerke
7dcb54bc7e
build(js): Migrate from yarn to npm ( #4252 )
2025-08-04 16:07:39 -04:00
Colin Gillespie
ae82850e1f
docs: Update R supported versions ( #4256 )
2025-08-04 10:37:48 -04:00
Daniel Chen
0610d756a8
docs: update srcts/readme.md to shiny 1.11.1 ( #4259 )
2025-08-04 09:50:06 -04:00
Carson Sievert
6325067130
Update DESCRIPTION ( #4255 )
...
* Change maintainer to Carson
* Add Garrick
* Add Posit ROR link
* `usethis::use_tidy_description()` (GitHub Actions)
* `devtools::document()` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-07-22 13:19:24 -05:00
Carson Sievert
1a4e52dc73
Run routine ( #4257 )
...
* Touch news
* `usethis::use_tidy_description()` (GitHub Actions)
* Revert "Touch news"
This reverts commit 854e7e10ae .
* `usethis::use_tidy_description()` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-07-22 12:38:23 -05:00
Winston Chang
08383ad8b9
Update srcts/README with info about window.Shiny ( #4198 )
2025-07-18 17:22:52 -05:00
Carson Sievert
ecf6bfe9a7
Put actionButton()s icon and label into containers ( #4249 )
...
* Put action icon and label into containers
* Update snaps
* More robust test
* Don't include container if icon/label isn't specified
* `yarn build` (GitHub Actions)
* Send HTML string/deps on update; update news
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-07-14 16:22:03 -05:00
Carson Sievert
f7528568e5
Increment version number to 1.11.1.9000 ( #4253 )
...
* Increment version number to 1.11.1.9000
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-07-07 22:02:14 -07:00
Carson Sievert
51f653b66f
v1.11.1 release candidate ( #4245 )
...
* v1.11.1 release candidate
* `yarn build` (GitHub Actions)
* Revert actionButton()/actionLink() implementation to v1.11.0's behavior (re-introducing #4239 )
* Minimal fix to address the regression in #4239
Ideally we'd fix this issue, and also get updateActionButton() working with HTML labels, but thanks to today's release of kinesis (which snapshots all of actionButton()s markup), and CRAN dragging their feet to accept our original submission (which was fine, by the way), we can't have nice things
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-07-07 21:53:08 -07:00
Carson Sievert
460a93a5fd
Revert the addition of spacing between icon and label in actionButton() ( #4248 )
...
* Revert the addition of spacing between icon and label in actionButton()
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-27 10:58:17 -05:00
Carson Sievert
3ea4c8eb1d
Restrict icon/label separator spacing to actionButton() ( #4247 )
...
* Follow up to #4242 : Restrict icon/label separator spacing to actionButton()
* `yarn build` (GitHub Actions)
* Add spacing only when both icon and label are truthy
* Update snapshot
* `yarn build` (GitHub Actions)
* Slightly more readable JS
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-26 19:12:13 -05:00
Carson Sievert
f237de559d
Fix front-end action button label updating logic ( #4242 )
...
* Close #4239 : fix front-end action button label updating logic (follow up to #3996 )
* Update news
* Use a separator instead of putting markup in attributes
* `yarn build` (GitHub Actions)
* Address feedback
* Cleanup
* Refactor into a single method to split icon/label
* `yarn build` (GitHub Actions)
* Better naming
* Add some padding to the separator
* Add some unit tests for R logic
* Update NEWS.md
* Update NEWS.md
* Update NEWS.md
* Update NEWS.md
* Increase backcompat (keep same R structure when no icon is provided)
* Refine comment
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-26 16:32:17 -05:00
Carson
8c7abbac44
Update news
2025-06-26 13:56:35 -05:00
Carson Sievert
1710316142
Properly handle undefined value for input subscribe callback ( #4243 )
...
* Close #4240 : properly handle undefined value for input subscribe callback
* Refactor normalization into a function
2025-06-26 09:36:09 -05:00
Carson Sievert
2d856f4f09
Start new version ( #4241 )
...
* Start new version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-25 17:05:03 -05:00
Carson Sievert
ab219e3408
v1.11.0 release candidate ( #4232 )
2025-06-25 16:28:51 -05:00
Carson Sievert
673be3dd77
Follow up to #3996 : fix front-end checkbox label updating logic ( #4238 )
...
* Follow up to #3996 : fix front-end checkbox label updating logic
* More descriptive name
2025-06-20 15:15:30 -05:00
Carson Sievert
b25e6feabb
feat(InputBinding): subscribe callback now supports event priority ( #4211 )
...
* feat(InputBinding): subscribe callback now supports event priority
* Update NEWS.md
* Update srcts/src/shiny/bind.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* `yarn build` (GitHub Actions)
* Simpler and more consistent typing
* Support a suitable object as input
* Provide a type for the callback itself, not just the valueit's given
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-19 10:27:45 -05:00
Carson Sievert
e6b22d86b6
Follow up to #3996 when label is unspecified (i.e., NULL), don't include it in the message ( #4237 )
2025-06-19 09:48:44 -05:00
Carson Sievert
9c5196ee63
Run routine ( #4234 )
...
* Run routine
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Update NEWS.md
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-06-16 12:52:48 -05:00
Hedley
9b53251b09
chore: #4175 update jquery-ui to 1.14.1 ( #4205 )
...
* chore: #4175 update jquery-ui to 1.14.1
* Update to latest types
---------
Co-authored-by: Carson <cpsievert1@gmail.com >
2025-06-16 12:42:07 -05:00
David Macro
942bdd8c40
Update jQuery to 3.7.1 ( #3969 )
...
* Update jquery
* Upgrade to latest types
* Update news
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2025-06-16 11:46:17 -05:00
edemain03
d762865753
Fix 404 in example 08_html (shiny.min.css) ( #4221 )
...
* fix(examples-shiny): use shiny.min.css in 08_html to avoid 404 (#4220 )
* Update NEWS.md
* Minimize all the files
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2025-06-16 11:20:00 -05:00
Carson Sievert
992b967095
Follow up to #3870 : fix location of news item ( #4233 )
2025-06-16 11:12:58 -05:00
Stuart Russell
9a39cea0cc
Bugfix for error found in tests ( #3870 )
...
* Bugfix for error found when calling shiny::shinyAppTemplate without library(shiny)
* Update news
* Update NEWS.md
---------
Co-authored-by: Carson <cpsievert1@gmail.com >
2025-06-16 11:05:43 -05:00
John Coene
db9f210257
Allow update input labels with HTML ( #3996 )
...
* fix: allow update input labels with HTML fixes #3995
* refactor: use processDeps and renderContent
* fix: formatting on lists
* fix: put spaces between infix
* chore: generated files
* fix: update input tests
* revert: generated javascript and sourcemaps
* fix: empty label check
* Remove package-lock
* Undo unintended change when merging
* Update news
* Simplify
---------
Co-authored-by: Carson <cpsievert1@gmail.com >
2025-06-16 11:01:44 -05:00
Charlie Gao
e8b7c08a19
Adds mirai to documentation ( #4230 )
...
* Update docs to mention mirai
* Update example to use mirai
* Fix other roxygen2 render
2025-06-16 09:42:21 -05:00
Michael Chirico
b596245571
family->given for R Core authorship ( #4222 )
2025-06-12 16:23:57 -05:00
Carson Sievert
57bb3a12d3
fix(renderPlot): get interactive plotting working with ggplot2 v4.0 ( #4228 )
...
* fix(renderPlot): get interactive plotting working with ggplot2 v4.0
* Update NEWS.md
2025-06-12 16:23:38 -05:00
Winston Chang
219fbc6819
Update NEWS
2025-06-09 17:22:20 -05:00
Teun van den Brand
a660093fa5
Compatibility with ggplot2 4.0.0 ( #4226 )
...
* add S7 class method
* Update tests/testthat/test-plot-coordmap.R
---------
Co-authored-by: Winston Chang <winston@stdout.org >
2025-06-09 17:20:43 -05:00
Garrick Aden-Buie
eac0eea886
fix: Wrap extended task invocation in promise_resolve() ( #4225 )
...
* fix: Wrap extended task invocation in `promise_resolve()`
* refactor: cleanup error handling and promise chain
* chore: add news entry
2025-05-30 08:44:31 -04:00
Charlie Gao
6df0bb9423
Fix performance regression related to limiting deep call stack growth ( #4214 )
...
* Use less expensive version of getCallNames() just for hashing
* Update R/conditions.R
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2025-05-23 18:56:00 +01:00
Barret Schloerke
159e771ac7
Relax test as we've already confirmed throttle is updating. Only required final value expectation ( #4218 )
2025-05-23 13:43:03 -04:00
Carson Sievert
ca41c0831b
feat!(submitButton): don't treat any HTML type='submit' button/input like a submitButton() ( #4209 )
...
* feat!(submitButton): don't treat any HTML type='submit' button/input like a submitButton()
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Update NEWS.md
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Barret Schloerke <barret@rstudio.com >
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2025-05-01 12:37:21 -05:00
Carson Sievert
316c3c8409
feat(textAreaInput): Add an autoresize option ( #4210 )
...
* feat(textAreaInput): Add an autoresize option
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Update NEWS.md
* Fix broken CSS selector.
Rules aren't being applied correctly in PyShiny either...
* Put shiny input class on container (to mirror what PyShiny does)
* Refactor autoresize logic
* Reduce diff size
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2025-04-30 18:34:04 -05:00
Garrick Aden-Buie
f79a22b987
feat: Fully reload ui/server when autoreload occurs ( #4184 )
...
* feat: Fully reload ui/server when autoreload occurs
* chore: remove stray empty line
* chore: clean up function names and add comments
* docs: Add news item
* feat: Use {watcher} for autoreload file watching (#4185 )
* feat: Use {watcher}
* chore: shikokuchuo/watcher@dev
* chore: watcher is on CRAN now
* chore: Undo air format changes
* feat: Use `shiny.autoreload.interval` for watcher latency
* chore: Simply track last time auto-reload changed
* docs: rewrite options docs for clarity
* chore: code style
* docs: global.R changes are not applied
* feat(ui/server): Autoreload also reloads global and R support files
* chore: remove outdated comment
* chore: safer comparisons
* chore: Restore legacy autoreload watcher if {watcher} not installed
* rename: autoload_r_support_if_needed()
* chore: use `rlang::is_false()`
* chore: use_build_ignore("_dev")
2025-04-24 13:53:40 -04:00
Garrick Aden-Buie
83219e3551
fix: Improve jquery node detection ( #4203 )
2025-03-25 21:26:27 -04:00
Garrick Aden-Buie
f55c26af4a
docs: Link to outputOptions() from render functions ( #4196 )
...
* docs(downloadHandler): Link to `outputOptions()`
* docs: include `outputOptions()` in other render functions
2025-03-03 11:11:11 -05:00
Garrick Aden-Buie
9fbb2c5829
docs: Rewrite news for #4183 ( #4195 )
2025-02-28 08:06:54 -05:00
Winston Chang
531f31b66f
textInput(), textAreaInput(), numericInput(), passwordInput(): allow updating value on blur (#4183 )
...
* textInput: Add updateOn parameter and allow setting debounce delay
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Update news
* Remove debounce parameter
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Add updateOn parameter to numericInput, passwordInput
* Add updateOn to textAreaInput()
* `devtools::document()` (GitHub Actions)
* feat: Ignore change events unless from server messages when `updateOn="blur"`
* refactor: `updateOn="change"` instead of `"input"`
* feat: Update inputs on Enter or Cmd/Ctrl+Enter (textarea)
* chore: Document `...` and ensure they are empty
* chore: Use `rlang::arg_match()`
* chore: code style (air format)
* fix: textAreaInput, not inputTextArea
* docs(NEWS): Minor edit
* chore: If element has focus, ignore change event
---------
Co-authored-by: wch <wch@users.noreply.github.com >
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2025-02-26 12:45:26 -05:00
Winston Chang
58e152154a
Stop using Babel; compile JS to ES2020 ( #4066 )
...
Co-authored-by: wch <wch@users.noreply.github.com >
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
Co-authored-by: Barret Schloerke <barret@posit.co >
2025-02-03 12:37:19 -05:00
Garrick Aden-Buie
55b37fdeb3
fix(insertTab): Render inserted nav html only once ( #4179 )
...
* fix: Fix checking if `scope` is a jquery element
Fixes rstudio/bslib#1159
* refactor: Don't check binding validity if `scope` isn't an element
* fix(insertTab): Render inserted nav html only once
* chore: Don't need to delay binding
* fix: Bind all after inserting nav controls
Output bindings require outputs to be attached to the DOM.
* chore: align comment
* chore: Add news item
2025-01-27 17:15:27 -05:00
Garrick Aden-Buie
b8a5aef53a
feat: De-duplicate client console messages ( #4177 )
...
* feat: De-duplicate client console messages
* refactor(ShinyErrorConsole): Add `appendConsoleMessage()` static method
* fix: Make `appendConsoleMessage()` an instance method
* rename: `createClientMessageElement()`
* docs: add news item
2025-01-27 16:57:10 -05:00
Carson Sievert
d764ea9b4e
Busy indicator improvements ( #4172 )
...
* Make sure spinner is visible when htmlwidget errors are visible
* Give recalculating outputs a min-height large enough to show the spinner
* tableOutput() now gets the spinner treatment
* yarn run bundle_extras
* Forward visibility hidden for all recalculating widgets, not just those with a error message (otherwise spinner won't be visible after a req())
* Update news
2025-01-22 14:14:20 -06:00
olivroy
8ad779f949
Various test lints ( #4171 )
...
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2025-01-21 15:08:00 -05:00
olivroy
7642fc84b7
Replace crayon by cli + address some TODOs to add some color ( #4170 )
...
* Replace crayon by cli + address some TODOs to add some color
* docs: add news
---------
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2025-01-21 11:00:51 -05:00
Garrick Aden-Buie
0952f3e0a7
ci: update for 2025 ( #4178 )
...
* ci: update for 2025
* chore: RStudio --> Posit
---------
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
2025-01-14 13:26:41 -05:00
Garrick Aden-Buie
13ca8dfc57
fix: Schedule .modal("hide") for transitioning modals ( #4173 )
...
* fix: Schedule modal removal for transitioning modals
* refactor: Simplify and both call and schedule modal hiding at same time
* Increment version number to 1.10.0.9000
* docs: Add NEWS entry
2024-12-31 16:27:25 -05:00
Garrick Aden-Buie
79f42f5846
v1.10.0 ( #4166 )
...
* Increment version number to 1.10.0
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* chore: urlchecker::url_update()
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/insertUI.html > to <https://shiny.posit.co/r/reference/shiny/latest/insertui.html > in NEWS.md
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/modalDialog.html > to <https://shiny.posit.co/r/reference/shiny/latest/modaldialog.html > in NEWS.md
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/Progress.html > to <https://shiny.posit.co/r/reference/shiny/latest/progress.html > in NEWS.md
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/renderTable.html > to <https://shiny.posit.co/r/reference/shiny/latest/rendertable.html > in NEWS.md
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/showNotification.html > to <https://shiny.posit.co/r/reference/shiny/latest/shownotification.html > in NEWS.md
✔ Updated: <https://shiny.rstudio.com/reference/shiny/latest/withProgress.html > to <https://shiny.posit.co/r/reference/shiny/latest/withprogress.html > in NEWS.md
* chore: revdepcheck
* chore: polish NEWS
* chore: update CRAN comments
* Polish NEWS
---------
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
Co-authored-by: Carson <cpsievert1@gmail.com >
2024-12-16 09:30:53 -06:00
Joe Cheng
9a35b01e23
Fix observeEvent stack trace stripping ( #4163 )
...
* Fix observeEvent stack trace stripping
* Add unit test
* Add deep stack version of unit test
2024-12-09 20:50:53 -08:00
Joe Cheng
5bf0701939
Plot outputs incorrectly sized inside scaled outputs ( #4139 )
...
* Fix #4135 : Plot outputs incorrectly sized inside scaled outputs
CSS zoom property affects el.getBoundingClientRect() but not
el.offsetWidth/Height. When reporting sizes of outputs from
client to server, we need to back out the CSS zoom because
those sizes are used as CSS width/height, which will be
affected by zoom.
(Note that something similar happens with CSS transforms but
we don't have a good way to deal with them)
* Squelch TS error
* `yarn build` (GitHub Actions)
* Add TODO
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
* Rebuild JS
---------
Co-authored-by: jcheng5 <jcheng5@users.noreply.github.com >
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-12-08 01:25:32 -08:00
Garrick Aden-Buie
e5083f4938
feat: Avoid throwing errors for shared input/output IDs ( #4101 )
...
* refactor: Factor out message display from error handler
* feat: Add custom event for sending a client message
* feat: Report binding validity problem via event instead of throwing error
* feat: Don't need to hide shared input/output message
Now that it's not an error, it's safe to report
* refactor: Move `inDevMode()` logic into error console
* refactor: Rename `.error` --> `.event`
* feat: wrap client error message
It's otherwise hard to tell that the error is scrollable
Plus the scrolling is over the whole message rather than the part that overflows
* feat: always send client console messages to browser console as well
* chore: throw if `shiny:client-message` receives an event that isn't CustomEvent
* feat: Handle status in `showShinyClientMessage()`
* Renamed `showMessageInClientConsole()` to `showShinyClientMessage()` to improve clarity
* Added `status` argument to `showShinyClientMessage()` to allow for different message types
* refactor: Don't throw errors for duplicate IDs
Brings dev mode in line with current "prod" behavior,
where errors aren't thrown for duplciates. In both cases
we still get console or client messages.
* refactor: Clean up `status` inside `checkValidity()`
* refactor: Have `checkValidity()` handle emitting the client console event
2024-12-06 16:00:19 -05:00
Garrick Aden-Buie
ce6a562a3c
chore: routine ( #4161 )
2024-12-06 15:16:29 -05:00
Dan Gealow
b6bcfc8683
Work around a selectize bug (re-fixes #3966 ) ( #4142 )
...
* Work around a selectize bug (re-fixes #3966 )
---------
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-12-06 15:03:59 -05:00
Dean Attali
d37beeece7
ExtendedTask: add example to docs ( #4087 )
...
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-12-06 14:24:01 -05:00
Joe Cheng
79ee25620f
Limit deep stack growth ( #4156 )
...
* Limit deep stack growth
* Improvements to deep stack trace culling
- Keep around the first deep stack trace; it may have useful
information. (We may want to change this in the future to
keep the first two stack traces, or even make it an option)
- Print out an indicator that we've elided stack traces, and
how many
* Add comments
* Add NEWS item
* Add test for unlimited deep stacks
* Code review feedback
* Code review feedback
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Use head() over indexing
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Improve unit test robustness
* Remove vector indices from snapshot
* Make stack trace stripping work across deep stacks
* Pass tests
* Try passing tests again
* Rename keep_head to retain_first_n
* Remove misleading variable assignment
* Add more comments, refine dropTrivialTestFrames
* Don't call stripStackTraces if we're not stripping
* Use deep stack deduplication instead of elision
This hopefully will avoid any potential ..stacktraceon../off..
scoring issues, and will be more useful for users. The downside
is that it's still possible to have uselessly large deep stack
traces, but at least that will only happen now if you have
manually written gigantic async/promise chains by hand or maybe
did some clever metaprogramming. The coro case should be fine.
* Add coro-based unit test
* Use rlang::hash, it's much faster
* typo
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Remove unnecessary logic
* Simplify/robustify reactlog version checking test
* Warn only once on call stack digest cache miss
* Super conservatively wrap appendCallStackWithDupe in try/catch
* Use more specific attribute name
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Remove excessively cautious try/catch
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-12-06 10:17:05 -08:00
Joe Cheng
82c678a1eb
Update NEWS.md for stack trace domain explosion
2024-12-03 13:37:58 -08:00
Joe Cheng
458924569a
Stack trace domain explosion ( #4155 )
...
* Avoid way too many promise domains being activated
Using `captureStackTraces` in wrapForContext is a bad idea, it
piles on a new domain every time a handler is bound.
* Use captureStackTraces, it means the same thing
* Update promises version requirement
* Add test for stack trace growth
* Simplify stack trace snapshot tests
The `category` column isn't a good candidate for snapshot
testing, as its contents vary depending on how the package
was loaded/installed. During devtools::test() or similar,
shiny package code shows up as 'user'. But during CI, it
doesn't show up as anything.
2024-12-03 13:23:50 -08:00
Garrick Aden-Buie
501b012b2b
chore: Remove zipfs from recommended vscode extensions ( #4151 )
2024-11-07 10:52:10 -05:00
Garrick Aden-Buie
ee1aac847a
docs(runExample): display.mode follows DESCRIPTION ( #4152 )
...
Fixes #4077
The argument documentation wasn't updated to reflect that `runExample()` can run more than just Shiny's examples
2024-11-07 10:51:27 -05:00
bart1
7785a76a67
Closing bracket missing ( #4150 )
...
* type
* typo
2024-11-01 09:05:20 -05:00
Adam Foryś
79af1d6c92
Fix url bookmarking with possibility to modify excludes ( #3762 )
...
* Fix url bookmarking with possibility to modify excludes
* Update NEWS.md
2024-10-28 09:36:42 -05:00
Yihui Xie
a145add5d4
Use double-tilde for strikethrough in Markdown tests ( #4144 )
...
* Use double-tilde for strikethrough in Markdown tests
The current dev version of commonmark has disabled single tilde for strikethrough: https://github.com/r-lib/commonmark/pull/33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).
* Skip tests if commonmark is outdated
* Revert "Skip tests if commonmark is outdated"
This reverts commit 97bee20863 .
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-10-15 11:21:53 -05:00
Dan Gealow
abf71389be
Fix sporadic dates ( #3664 ) ( #3665 )
...
* Remove dateInput and dateRangeInput handlers for keyup and input events
This prevents spurious updates while typing, but still sends when enter is pressed, focus is lost, or the GUI is clicked (due to the remaining `changeDate` and `change` handlers).
* chore: small edits to comments and NEWS item
---------
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-09-30 17:26:43 -04:00
Garrick Aden-Buie
2e2114f99d
fix(busy): Show pulse if only UI are recalculating ( #4137 )
...
* fix(busy): Show pulse if only UI are recalculating
Because UI elements don't get spinners
2024-09-30 13:55:47 -04:00
Garrick Aden-Buie
09d415502f
docs(NEWS): Fix name of sliderInput() function ( #4136 )
2024-09-27 11:14:40 -04:00
Garrick Aden-Buie
c489fef4ff
fix(input_slider): Make sure last used handle is always above others ( #4131 )
2024-09-27 10:09:43 -04:00
Garrick Aden-Buie
9d12b0fca7
fix(conditionalPanel): Coerce condition result to boolean ( #4127 )
...
Co-authored-by: Kamil Zyla <kamil@appsilon.com >
2024-09-27 09:38:15 -04:00
Garrick Aden-Buie
cc9b9d4e6a
feat(pulse): Tweak pulse animation and height ( #4122 )
2024-09-27 09:31:44 -04:00
Joe Cheng
34f9e4484d
Merge pull request #4134 from rstudio/test/fix-reactivity-timing
...
fix: Timing of throttle/debounce reactivity test
2024-09-25 15:51:29 -07:00
Garrick Aden-Buie
03a3f8f886
test(reactivity): Consolidate identical tests into for loop
2024-09-25 10:09:17 -04:00
Garrick Aden-Buie
b900db0c74
test: Update the other test
2024-09-24 22:05:52 -04:00
Garrick Aden-Buie
5fb3ebc2d9
ci: run tests again
2024-09-24 22:00:19 -04:00
Garrick Aden-Buie
fbc6b2df57
chore: take out debugging code
2024-09-24 21:32:27 -04:00
Garrick Aden-Buie
6208225354
fix: Tweak updates to avoid overlapping events
2024-09-24 21:22:40 -04:00
Garrick Aden-Buie
e22b693418
chore: show value in debug too
2024-09-24 21:01:29 -04:00
Garrick Aden-Buie
c7ca49c634
debug: Add debugging messages for debounce/throttle test
2024-09-24 20:44:31 -04:00
Carson Sievert
d84aa94762
Start new version ( #4113 )
...
* Start new version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-08-01 10:28:25 -05:00
Carson Sievert
89e2c18531
v1.9.1 release candidate ( #4112 )
...
* v1.9.1 release candidate
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-08-01 09:42:31 -05:00
Joe Cheng
43d36c08dc
Remove double-scaling in coordmap.getPanelCss() ( #4111 )
...
Fixes #4110
2024-07-31 11:31:31 -05:00
Carson Sievert
4bc330e5dd
Start new version ( #4108 )
...
* Start new version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-07-29 17:21:35 -05:00
Carson Sievert
56ab530d87
v1.9.0 release candidate ( #4105 )
...
* Start v1.9.0 release candidate
* Check-in revdep results
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* `yarn build` (GitHub Actions)
* ran revdepcheck on cloud. 2 errors reported. Both seem like false positives
* Fix R CMD check note about Rd links targets missing package anchors
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Barret Schloerke <barret@posit.co >
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2024-07-29 17:10:38 -05:00
Garrick Aden-Buie
599209a036
chore: make pulse and spinner opt-in (for now) ( #4107 )
...
* chore: make pulse and spinner opt-in (for now)
* Reword busy indication NEWS section
---------
Co-authored-by: Carson <cpsievert1@gmail.com >
2024-07-29 11:21:28 -05:00
Joe Cheng
15b5fa6c01
Click handler on scaled image getting clipped ( #4094 )
...
* Fix #3234 : Click handler on scaled image getting clipped
There were two related problems here, both happening in the same scenario:
when an imageOutput with click handlers is showing an image at less than
its natural size (e.g. a 1000x1000 px .png file, being displayed in the
web page at 500x500 due to max-width or for whatever other reason), any
click where the image coordinate (1000x1000) exceeds the display size
(500x500).
In the example above, a user clicks at 300x300 in the 500x500 displayed
image. We call 300x300 the "CSS coordinates". This gets scaled up into
the position in the PNG's own coordinate system, "image coordinates":
in this case, 600x600. Since the 600x600 image coordinate is greater
than the 500x500 CSS coordinate limit, the following issues were
triggered.
1. When imageOutput(click=clickOpts(clip=TRUE)) (the default), these
clicks weren't registering at all. There was code that detected
clicks that were inside the imageOutput but outside the actual image,
but this code didn't take scaling into account.
2. Even with clip=FALSE, the click would be triggered BUT the `x` and `y`
values on the click event were incorrect--they would max out at the
CSS coordinate limit. This because plot and image output divide the
world into "panels" and clicks snap to the nearest panel. In the case
of image outputs, the server doesn't provide any panels, so the
client makes one big panel that covers the whole image--but that code
was erroneously using CSS sizes, not image sizes.
* Update NEWS
2024-07-26 11:09:39 -05:00
Carson Sievert
3f4676d9a6
Enable busy indicators by default, add ability to disable/customize fade ( #4104 )
...
* Follow up to #4040 : enable busy indicators by default
* Make our spinner invisible when wrapped inside a shinycssloaders::withSpinner() container
* Add the ability to disable/customize recalculating opacity (i.e., fade)
* Fix bug with fade not being applied correctly when the output container has no children
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Update NEWS.md
* Follow up to b7e7af: need to also rest opacity for :empty case (for initial calculation)
* Rd docs fixes/improvements
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-07-24 12:57:42 -05:00
Winston Chang
bb89cf9235
Add Shiny.initializedPromise ( #4063 )
...
* Convert Shiny from interface to class
* Remove unused global Shiny type
* Add prettier plugin for organizing imports
* Disable eslint indentation rule
* Simplify types
* Add Shiny.connectedPromise and Shiny.sessionInitPromise
* Fix typing issue
* Move prettier plugin to devDependencies
* Rename Shiny class to ShinyClass, and export type
* Remove global Shiny type; use internal imports
* Small code cleanup
* Move initShiny() function into ShinyClass
* Rebuild type files
* Raise error if window.Shiny already exists
* Rename promises
* Add InitStatusPromise class
* `yarn build` (GitHub Actions)
* Update news
* Remove isConnected
* Update yarn.lock
* Rename isInitialized to initializedPromise
* Rebuild shiny.js
* `yarn build` (GitHub Actions)
* Update NEWS
---------
Co-authored-by: wch <wch@users.noreply.github.com >
2024-07-23 22:11:20 -05:00
Randy Zwitch
25c40967da
Update issue template to use new forum.posit.co URL ( #4038 )
...
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-07-23 14:59:17 -04:00
Barret Schloerke
068b232e75
feat(reactlog): Add reactlogAddMark() ( #4103 )
2024-07-22 11:29:02 -04:00
Garrick Aden-Buie
0b7fda707e
chore: Enable return of dependency CSS as Sass files ( #4044 )
...
* chore: Enable return of dependency CSS as Sass files
Makes it possible to extract the Sass files prior to compilation for the following CSS:
* shiny
* selectize
* ionrangeslider
* daterange picker
* refactor: Take a more functional approach
* fix: missing selectizeDir
* rename: __SassLayer --> __Sass
2024-06-13 16:08:54 -04:00
Carson Sievert
9fd4ba199e
Close #4080 : Require bslib 0.6 or higher ( #4085 )
2024-06-03 09:39:29 -05:00
Dean Attali
43e40c7969
news: fix function name typo ( #4076 )
2024-06-03 09:13:42 -05:00
Winston Chang
248f19333c
Bump cachem dependency. Closes #4032
2024-05-31 21:01:05 -05:00
Garrick Aden-Buie
306c4f847b
feat(options): shiny.client_devmode ( #4073 )
2024-05-30 17:19:41 -04:00
Carson Sievert
e689cdc522
Close #4068 : take opacity from last frame of animation ( #4069 )
2024-05-28 10:33:20 -05:00
Winston Chang
3e0efd8484
Update formatting settings ( #4065 )
...
* Format JSON files on save
* Add prettier plugin for organizing imports
* Reorganize imports
* Fix 'routine' build issues
* `yarn build` (GitHub Actions)
---------
Co-authored-by: wch <wch@users.noreply.github.com >
2024-05-24 09:37:28 -05:00
Carson Sievert
4a8400d2a5
Delay longer before dimming opacity when spinners are active ( #4062 )
...
* make sure to delay and transition the change in opacity when busy indicators are active
* better approach
* Fix
* Delay a touch longer
2024-05-23 11:52:02 -05:00
Carson Sievert
e432bb0592
Hide the busy pulse when disconnected ( #4061 )
2024-05-22 12:41:59 -05:00
Carson Sievert
d002734afe
Follow up to #4057 : remove unused JS files ( #4060 )
2024-05-21 15:21:27 -05:00
Carson Sievert
54e7377f24
Fade in spinner opacity after initial delay ( #4058 )
...
* Fade in spinner opacity after initial delay
* Slightly quicker fade in
2024-05-21 15:06:30 -05:00
Carson Sievert
a49d24108f
Close #4056 : Gut busy indicator logic to pulse up until 1st idle ( #4057 )
2024-05-20 17:57:19 -05:00
Garrick Aden-Buie
733a4e8983
fix(pulse): Remove radius from pulse ( #4053 )
2024-05-15 15:30:18 -04:00
Garrick Aden-Buie
6309a6fca3
tests(busyIndicatorOptions): set seed in the test without a helper ( #4052 )
2024-05-10 17:23:54 -04:00
Carson Sievert
3d66940402
Add busy indication ( #4040 )
...
* First pass at a proper state machine for managing output progress state
* `yarn build` (GitHub Actions)
* Add useBusyIndicators(), spinnerOptions(), and pulseOptions()
* Bring in new spinner defaults
* Use an actual div instead of a pseudo-element since chromium can't be trusted to show them when animated
* Revert "Use an actual div instead of a pseudo-element since chromium can't be trusted to show them when animated"
This reverts commit 6167c1dfd7 .
* Embed animation inside svg (to avoid Chromium bug). Consolidate options into a singular busyIndicatorOptions()
* Add to pkgdown reference
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Bump version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Apply suggestions from code review
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
* Update snapshots
* `devtools::document()` (GitHub Actions)
* Address feedback
* Bring in more spinner type options
* fix use of fs
* Code review
* `devtools::document()` (GitHub Actions)
* Sync package version (GitHub Actions)
* Update snapshots
* Fix comments
* Make snapshot consistent cross-platform
* Fix namespace issue
* Reduce specificity of position relative
* Skip snapshot on windows; update news
* Whoops
* Scope spinner customizations to parent element by default
* Update snapshots
* Reorder spinner types
* Set a private random seed in tests
* Better id naming
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-05-10 14:58:43 -05:00
Carson Sievert
2872c87e32
Allow for progress binding to move from Idle to Invalidated status ( #4047 )
...
* Close #4046 : Allow for progress binding to move from Idle to Invalidated status
* `yarn build` (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-05-07 17:46:46 -05:00
Carson Sievert
ecb591f2e1
Disable downloadLink()/downloadButton() until their href is ready ( #4041 )
...
* Close #3606 : disable downloadLink()/downloadButton() until their href has been populated
* Update news
2024-05-06 09:36:59 -05:00
Carson Sievert
8e37d45948
Improve/fix output progress reporting ( #4039 )
...
* First pass at a proper state machine for managing output progress state
* `yarn build` (GitHub Actions)
* Improved naming
* Include ascii version of diagram (as well as the source file
* Update srcts/src/shiny/outputProgress.ts
Co-authored-by: Joe Cheng <joe@rstudio.com >
* `yarn build` (GitHub Actions)
* Only call showProgress for outputs that have actually changed their recalculating status
* Add some more commentary
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Joe Cheng <joe@rstudio.com >
2024-05-02 18:01:29 -05:00
Winston Chang
c11f120bb9
Change eslint-disable comments to eslint-disable-next-line ( #4037 )
...
* Change eslint-disable comments to eslint-disable-next-line
* Allow floating promise
* `yarn build` (GitHub Actions)
---------
Co-authored-by: wch <wch@users.noreply.github.com >
2024-04-30 13:19:48 -05:00
Winston Chang
950c63049b
Check that $socket exists before sending message ( #4035 )
...
* Check that socket exists before sending message
* `yarn build` (GitHub Actions)
---------
Co-authored-by: wch <wch@users.noreply.github.com >
2024-04-26 15:21:35 -05:00
Carson Sievert
3edf9bfad8
Fix opacity dimming on recalculating uiOutput() ( #4028 )
...
* Close #4027 : Fix opacity dimming on recalculating uiOutput(). Also, only apply display:content when there are child elements
* Update inst/www/shared/shiny_scss/shiny.bootstrap5.scss
* Add news item
2024-04-10 13:16:41 -05:00
Carson Sievert
420a2c054c
Start new version ( #4023 )
...
* Start new version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-04-03 10:03:31 -05:00
Carson Sievert
5e566a057d
Start v1.8.1.1 release candidate ( #4020 )
...
* Start v1.8.1.1 release candidate
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Remove alpha from npm version
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-04-03 09:26:01 -05:00
Carson Sievert
edd1db78e3
Warn instead of error when duplicate binding IDs are found in non-devmode ( #4019 )
...
* Close #4016 . Warn instead of error when duplicate binding IDs are found in non-devmode
* Get rid of unreachable ShinyClientError()
* `yarn build` (GitHub Actions)
* Update srcts/src/shiny/bind.ts
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
* `yarn build` (GitHub Actions)
* Move logic to where error gets thrown not constructed
* `yarn build` (GitHub Actions)
* Update NEWS
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-03-29 13:51:46 -05:00
Joe Cheng
47526a769a
ExtendedTask should not be cloneable ( #4015 )
2024-03-27 19:06:21 -05:00
Carson Sievert
0474eeeead
Start new version ( #4014 )
...
* Start new version
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-03-27 10:10:45 -05:00
Carson Sievert
e8cdc78f0f
v1.8.1 release candidate ( #4008 )
...
* Start v1.8.1 release candidate
* Update urls and yarn build
* Sync package version (GitHub Actions)
* Check-in revdep results
* Groom news
---------
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2024-03-27 10:01:08 -05:00
Carson Sievert
7742b652ba
Fix and simplify reactlog's version check approach. ( #4012 )
...
* Close #4011 . Fix and simplify reactlog's version check approach.
* Better variable name
* Use test_path() for consistent path location
* Just use packageDescription()
* Update tests/testthat/test-reactlog.R
* Update tests/testthat/test-reactlog.R
* Update DESCRIPTION
2024-03-22 17:39:52 -05:00
Carson Sievert
7ed68ed927
Revert changes to shinyDeprecated() & update renderDataTables() tests to always use shiny's datatables implementation ( #4010 )
...
* Revert "feat: Deprecate with warnings, expect `renderDataTable()` to be deprecated (#4007 )"
This reverts commit a8c6065b9f .
* Use shiny's datatables implementation when testing
2024-03-22 17:35:15 -05:00
Garrick Aden-Buie
ac06350e08
chore: restyle new examples-shiny apps ( #4004 )
...
* chore: restyle examples-shiny
* chore: restore select newlines
* More consistent approach to whitespace
---------
Co-authored-by: Carson <cpsievert1@gmail.com >
2024-03-21 17:43:30 -05:00
Garrick Aden-Buie
43698f0860
feat: Run examples from any package ( #4005 )
...
* chore: `inst/shiny` -> `inst/examples-shiny`
* feat(runExamples): Find examples in any package
* refactor: code style
* refactor: small code style changes
* docs: fix runApp typo
* chore: include package name in valid examples message
* chore(runExample): check that `package` is installed
* chore: use braced package name
* Update news
---------
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-03-21 12:07:57 -05:00
avoidaway
c73e1a21b8
chore: remove repetitive words ( #3999 )
...
Signed-off-by: avoidaway <cmoman@126.com >
2024-03-21 11:30:24 -05:00
Garrick Aden-Buie
d855468398
chore: inst/shiny -> inst/examples-shiny ( #4003 )
2024-03-21 10:58:50 -05:00
Garrick Aden-Buie
b8efd88448
docs(MockShinySession): document unhandled error param ( #4006 )
2024-03-21 10:58:27 -05:00
Garrick Aden-Buie
a8c6065b9f
feat: Deprecate with warnings, expect renderDataTable() to be deprecated ( #4007 )
...
* feat: Deprecate with a warning
Use `rlang::warn()` instead of `rlang::inform()` and use the lifecycle warning class so that lifecycle infrastructure works
* tests: expect that renderDataTable is deprecated
* tests: invert warning and error expectation
2024-03-21 10:57:50 -05:00
Carson Sievert
12a8b228d9
Follow up to #3998 : correct version requirement in message. ( #4002 )
2024-03-21 09:12:01 -05:00
Sara Altman
47fb562151
Update examples to use bslib ( #3963 )
...
* update 01_hello
* Updates 06_tabsets example to use bslib
* Pre-emptively adds legacy versions of all of the original examples
* Switches tabset example to use navset_card_underline()
* Updates example 2
* Updates 03_reactivity
* Updates 04_mpg
* Updates 05_sliders
* Updates 07_widgets
* Deletes 08_html_legacy. Original example does not need updated.
* Updates 09_upload
* Updates 10_download
* Updates 11_timer
* Keep inst/example unchanged; add new examples under inst/shiny and update runExamples() to use that directory by default
* Update news
* Fix some code formatting issues
* Update NEWS.md
* Don't default to showcase mode
---------
Co-authored-by: Garrett Grolemund <grolemund@gmail.com >
Co-authored-by: Carson <cpsievert1@gmail.com >
2024-03-20 16:04:58 -05:00
Carson Sievert
f0059b71e5
Use bs-danger instead of bs-danger-text-emphasis for text color on error messages ( #4001 )
2024-03-20 12:18:05 -05:00
Carson Sievert
89aaa977e8
Update datatables.js from 1.10.5 to 1.10.22 and deprecate renderDataTable()/dataTableOutput() ( #3998 )
...
* Update datatables.js from 1.10.5 to 1.10.22. Deprecate renderDataTable()/DTOutput()
* Update news; go back to old types version
* Clean up
* Update NEWS.md
* Update NEWS.md
2024-03-19 14:50:15 -05:00
Kirill Müller
ae308e03ad
Avoid R package warning in loadSupport() if autoload is disabled ( #3513 )
...
* Avoid bogus warning
* refactor: source globals first, then deal with helpers
* refactor: Factor out `warn_if_app_dir_is_package()` for readability
* chore: simplify diff
* docs(news): Add news item
* Hint to help file in message.
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
---------
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-03-15 15:50:35 -05:00
Garrick Aden-Buie
c1a1542cfe
fix(updateSelectizeInput): Clear current value before update if selected and sever = TRUE ( #3967 )
...
* fix(updateSelectizeInput): Clear current value before update if `selected` and `server = TRUE`
Fixes #3966
* chore: yarn build
* `yarn build` (GitHub Actions)
* docs(news): Add news item
* chore: Add comments for future selves
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* `yarn build` (GitHub Actions)
---------
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2024-03-14 09:56:06 -05:00
Garrick Aden-Buie
3c4a908773
feat: Add onUnhandledError() ( #3993 )
...
* feat: Add `onUnhandledError()`
* docs(NEWS): Update previous news item
* docs(onUnhandledError): Add example
* docs(MockShinySession): Fix unhandledErrorCallbacks private field docs
* feat: Handle non-fatal unhandled errors, too
* docs(onUnhandledError): Add more detailed documentation
* `devtools::document()` (GitHub Actions)
* docs: Small edits
2024-03-14 10:21:59 -04:00
Garrick Aden-Buie
e2b7f91138
feat: Add shiny.error.unhandled error handler ( #3989 )
...
* feat(shiny.error.unhandled): Allow users to provide an unhandled error handler
* Extract `shinyUserErrorUnhandled()` to use in MockSession too
* tests(shiny.error.unhandled): Test that unhandled errors are handled safely
* docs: Clarify that session still ends with an unhandled error
* docs: Add news item
2024-03-08 13:36:36 -06:00
Garrick Aden-Buie
c73978cdd5
docs: update roxygen2 ( #3988 )
...
* fix: `@docType "package"` is deprecated
* fix: S3 methods need `@export` or `@exportS3method` tag.
* chore: devtools::document()
2024-03-08 09:15:37 -06:00
Andreas Deininger
6760c31818
Documentation: fixing typos ( #3932 )
...
* Documentation: fixing typos
* Commit changes after generation of package docs
2024-02-02 16:53:48 -06:00
olivroy
781ceaaa5c
Remove ellipsis dependency ( #3959 )
...
* Remove ellipsis dependency
* Use the above `@importfrom rlang`
* move usethis namespace
2024-02-02 16:52:39 -06:00
Fenno Vermeij
fff283648b
fix(downloadButton): Return tag directly ( #2672 )
...
* Fix `downloadButton()` not rendering in rmarkdown documents
---------
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
2024-01-30 17:31:40 -05:00
Winston Chang
f71f1256b8
Fix duplicate ID check logic ( #3978 )
...
* Fix duplicate ID logic
* Build shiny.js
2024-01-24 14:42:20 -06:00
Nick Strayer
f26b1335d8
Dev mode aware client and duplicate input/output ID handling updates ( #3956 )
...
* Add field with devmode status to the initial config object sent over on connection
* Add indicator of "devmode" status to the client via an injected script tag on load. This is modeled after what is done for showcase mode.
* Add logic to flag all duplicated IDs when in devmode
* Only show error console in devmode.
* Remove left-over devmode status in code
* `yarn build` (GitHub Actions)
* Build shiny.js
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
---------
Co-authored-by: nstrayer <nstrayer@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@posit.co >
Co-authored-by: wch <wch@users.noreply.github.com >
2024-01-24 12:37:27 -06:00
Nick Strayer
370ba1f288
Make error console sizing constant across base and bslib apps ( #3947 )
...
* Add more encapsulated sizes using css variables instead of `rem` units so console is consistantly sized across apps that set the body font size.
* `yarn build` (GitHub Actions)
* `yarn build` (GitHub Actions)
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
---------
Co-authored-by: nstrayer <nstrayer@users.noreply.github.com >
Co-authored-by: jcheng5 <jcheng5@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@posit.co >
Co-authored-by: wch <wch@users.noreply.github.com >
2024-01-22 14:17:10 -06:00
Joe Cheng
54988c17c8
Merge pull request #3958 from rstudio/extended-task
...
Add ExtendedTask R6 class
2024-01-11 09:11:58 -08:00
Joe Cheng
65fe23fa02
Don't take reactive dependency on rv_status() during invoke
2024-01-11 08:59:46 -08:00
Joe Cheng
b22b06e3d2
Add NEWS
2024-01-10 19:00:11 -08:00
Joe Cheng
3677f4e1c6
Add unit tests for maskReactiveContext
2024-01-10 19:00:11 -08:00
Joe Cheng
d6eb0493b3
Code review feedback
2024-01-10 19:00:11 -08:00
Joe Cheng
4e13cdb365
Realized we no longer care about the bslib version
...
Now that bind_task_to_button is gone to bslib, there's no specific
code in Shiny that cares about task buttons
2024-01-10 19:00:11 -08:00
Joe Cheng
4e3710cdaa
Use correct remote
2024-01-10 19:00:11 -08:00
Joe Cheng
5feedaf4c8
Add Remotes for bslib
2024-01-10 19:00:11 -08:00
Joe Cheng
ce29695e44
Remove bind_button_to_task (moved to bslib::bind_task_button)
2024-01-10 19:00:11 -08:00
Joe Cheng
f0f06a2c34
Update bind_button_to_task to use newest task button API
2024-01-10 19:00:11 -08:00
Joe Cheng
860a3fef86
Rebuild
2024-01-10 19:00:11 -08:00
Joe Cheng
6afadade5d
Add bind_button_to_task feature
2024-01-10 19:00:11 -08:00
jcheng5
c1bda7fb7b
yarn build (GitHub Actions)
2024-01-10 19:00:11 -08:00
jcheng5
509c165ee8
devtools::document() (GitHub Actions)
2024-01-10 19:00:11 -08:00
Joe Cheng
54e0ef7598
Add ExtendedTask to pkgdown.yml
2024-01-10 19:00:11 -08:00
Joe Cheng
03f2d5f014
Add ExtendedTask R6 class
2024-01-10 19:00:11 -08:00
Garrick Aden-Buie
122c1e74cd
refactor: pass-through containers in BS5 only ( #3960 )
2023-12-20 19:15:09 -05:00
Garrick Aden-Buie
d29f4cdf21
fix(ui-containers): Use display: contents ( #3957 )
2023-12-19 22:27:50 -05:00
Joe Cheng
300fb217d1
Merge pull request #3954 from rstudio/persistent-progress
...
Allow outputs to stay in progress mode after flush
2023-12-12 12:23:25 -08:00
Joe Cheng
33dc41c4bd
Add disabled argument to actionButton and updateActionButton
2023-12-11 17:04:09 -08:00
Joe Cheng
4b6e257dfc
Don't add progressKeys more than once
...
Doesn't matter much but this is closer to the old behavior
2023-12-07 09:22:01 -08:00
Joe Cheng
1f23f37f89
Allow outputs to stay in progress mode after flush
...
Adds a req(FALSE, cancelOutput="progress") which behaves similarly to
cancelOutput=TRUE, but also keeps the output in .recalculating state
even across flush cycles. This is called "persistent progress" and an
output can leave this state when it is invalidated again and doesn't
call req(FALSE, cancelOutput="progress") during that flush cycle.
This will be useful for implementing long-running tasks that don't
hold up the flush cycle, leaving sessions responsive to do other
tasks.
2023-12-06 09:30:58 -08:00
Garrick Aden-Buie
59b1c46485
fix: Allow bindInputs() to no-op when attempting to bind currently bound inputs ( #3946 )
...
* fix: Do not re-bind previously bound inputs
* refactor: Add binding to the registry after binding happens
* fix: Spelling of `bindingsRegistry`
* chore: yarn build
* `yarn build` (GitHub Actions)
* fix: spelling
* feat: isRegistered can check if bound to input or output
* fix: Do not throw for shared input/output IDs
`input$caption` and `output$caption` may not be the best idea for several reasons, but it was previously allowed
Fixes #3943
* fix: check element directly to know whether it a bound input
* chore: yarn build
* fix: test `.shiny-bound-input` instead of data prop
* refactor: Remove `bindingsRegistry.isRegistered()` method
* refactor: Use a map for duplicateIds again
* refactor: Add `BindingTypes` type and use `bindingType` everywhere
* refactor: More concise duplicateIds typing
Co-authored-by: Nick Strayer <nick.strayer@rstudio.com >
* refactor: count by forEach + incrementing
Co-authored-by: Nick Strayer <nick.strayer@rstudio.com >
* `yarn build` (GitHub Actions)
* thanks, vscode
* docs: rewrite checkValidity() jsdoc to capture current state of things
* chore: yarn build
* docs: slight rewording
---------
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
Co-authored-by: Nick Strayer <nick.strayer@rstudio.com >
2023-11-30 15:46:28 -06:00
Garrick Aden-Buie
01705c1299
fix(shiny.scss): Constrain notification panel to max-width: 100% ( #3949 )
2023-11-30 16:11:22 -05:00
Carson Sievert
18955a2abf
Update tabPanel() snapshot tests in anticipation of bslib release ( #3936 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-11-29 15:38:48 -06:00
Nick Strayer
dbbe7f9679
Client error console and duplicate input/output binding errors ( #3931 )
...
Co-authored-by: nstrayer <nstrayer@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2023-11-27 12:34:13 -06:00
Carson Sievert
61a51a869f
Run yarn build ( #3942 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-11-20 13:32:32 -06:00
Carson
298822fc44
Start new version
2023-11-20 12:57:08 -06:00
Carson Sievert
283c71e772
v1.8.0 release candidate ( #3928 )
2023-11-20 12:55:11 -06:00
Carson Sievert
b1297395a9
Don't treat input/output as draggable inside of absolutePanel(draggable = T) ( #3937 )
2023-11-01 10:42:19 -05:00
Carson Sievert
b850cd2509
Change selectize.js selectOnTab option back to false ( #3935 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-31 16:45:35 -05:00
Carson Sievert
56878ebbaa
Revert Shiny.renderContent() back to sync instead of async ( #3929 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-30 12:59:22 -05:00
Winston Chang
6a09fda08e
Allow InputBinding.receiveMessage to be async ( #3930 )
...
Co-authored-by: wch <wch@users.noreply.github.com >
2023-10-30 11:26:04 -05:00
Carson Sievert
77bc4e9ec7
Update selectInput's binding to use selectize.js' getValue() method when relevant ( #3926 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-26 18:21:40 -05:00
Carson Sievert
a1b9fda809
Prevent .selectize() updates from destroying .data() and event listeners ( #3923 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-26 17:42:06 -05:00
Garrick Aden-Buie
97a12ec601
fix(shiny.scss): Ensure $body-emphasis-color is defined for all BS5 ( #3924 )
2023-10-26 14:36:49 -05:00
Winston Chang
81bdde64c4
Convert bindAll to an async function ( #3904 )
...
Co-authored-by: Carson <cpsievert1@gmail.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-24 16:01:47 -05:00
Garrick Aden-Buie
c4ef42337b
feat: Improve notification styles ( #3913 )
...
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
Co-authored-by: Carson <cpsievert1@gmail.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-20 10:55:23 -05:00
Carson Sievert
ce78d0dcf1
Fix selectize event namespacing issues ( #3919 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-10-20 10:21:29 -05:00
Carson Sievert
7069064dd6
Add non-minified selectize.js source; and respect shiny.minified option ( #3918 )
2023-10-19 18:38:30 -05:00
Carson Sievert
a0a83d5fe3
Merge pull request #3914 from rstudio/chore/shiny-sass-bs-3-4-5
2023-10-19 16:40:59 -05:00
Garrick Aden-Buie
8fbc4ad4c1
Merged origin/main into chore/shiny-sass-bs-3-4-5
2023-10-19 17:31:30 -04:00
Garrick Aden-Buie
5346a00373
docs: Add news item
2023-10-19 17:30:59 -04:00
Garrick Aden-Buie
2dc69aea37
chore(shiny-sass): Remove comments
2023-10-19 17:27:08 -04:00
Joe Cheng
be6f6716bf
Merge pull request #3915 from rstudio/autoreload-indication
...
Soften visually jarring greyout when autoreloading
2023-10-18 12:23:47 -07:00
Joe Cheng
7f59f93692
Only show the lighter curtain if autoreload is on
...
I added this cause I'm slightly worried about other server environments
sending the same 1012 close code.
2023-10-16 17:58:02 -07:00
Joe Cheng
798b336df6
Make autoreload survive laptop suspend
...
Also simplify the implementation for softening the grey curtain when
autoreload is in progress (only applies to Shiny for Python)
2023-10-16 17:39:55 -07:00
Joe Cheng
bef6b4bfd9
Soften visually jarring greyout when autoreloading
...
This change detects when Shiny is autoreloading, and instead of
showing the typical disconnection treatment (dark grey), it
initially shows nothing and then quickly fades to very light
grey.
The goal is for instant autoreloads to feel seamless, but longer
autoreloads to make it clear when the autoreload has completed,
and still not feel as jarring as a full disconnect.
2023-10-16 17:39:55 -07:00
Carson Sievert
80ab088e2d
Merge pull request #3910 from rstudio/rc-v1.7.5.1
2023-10-16 12:22:58 -05:00
Carson
481a692b07
Merge branch 'main' into rc-v1.7.5.1
2023-10-16 10:01:18 -05:00
Garrick Aden-Buie
8ae936ba01
feat(shiny-scss): Create variable defaults specific to the Bootstrap version
2023-10-11 11:59:08 -04:00
Garrick Aden-Buie
6dc377842f
Revert shiny bootstrap sass back to pre-BS 5.3
...
Reverts back to commit f540679513
2023-10-11 11:06:11 -04:00
Carson
837307fe8c
Remove alpha from the npm version
2023-10-06 09:52:39 -05:00
Carson
dfe359c1b6
shiny v1.7.5.1
2023-10-05 18:42:03 -05:00
Carson Sievert
b8923e9497
Address r-devel's change in is.atomic(NULL) behavior ( #3908 )
2023-10-03 10:54:55 -05:00
Winston Chang
9ebcbf8a2d
wrapFunctionLabel: handle case when name is >10000 bytes (#3903 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2023-09-27 10:38:28 -05:00
Carson Sievert
a6fc6bf8cb
Update to the development version of selectize.js ( #3897 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-09-14 19:02:31 -05:00
Carson Sievert
eddc3047d4
Fix regression in updateSelectizeInput() ( #3890 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-09-08 16:48:48 -05:00
Carson Sievert
6db17d4f67
Ensure Sass variables are defined for Bootstrap 3 Sass ( #3892 )
2023-09-08 10:39:25 -05:00
Winston Chang
d21f9493fb
Update fileInput help page ( #3886 )
...
Co-authored-by: wch <wch@users.noreply.github.com >
2023-09-01 15:27:28 -05:00
Carson Sievert
e87f942e89
Update Shiny's CSS to respect BS5's dark color mode ( #3882 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-08-28 15:11:01 -05:00
Carson Sievert
1eb9ed7345
Upgrade to selectize.js 0.15.2 ( #3875 )
...
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-08-28 14:59:43 -05:00
Carson Sievert
9d923d079a
fileInput()'s button shouldn't have top-right or bottom-right border-radius (#3879 )
2023-08-24 09:07:11 -05:00
Carson Sievert
b054e45402
Update staticimports ( #3872 )
2023-08-15 11:40:19 -05:00
Carson Sievert
8b1d30aefe
use_dev_version() (#3871 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-08-14 12:53:12 -05:00
Carson
ab87a0708d
use_dev_version()
2023-08-14 09:56:22 -05:00
Carson Sievert
0b97ee1ecc
1.7.5 release candidate ( #3867 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-08-14 09:49:46 -05:00
Garrick Aden-Buie
68546c319e
Increase touch target area of slider input ( #3859 )
2023-08-07 15:14:35 -04:00
Garrick Aden-Buie
69188fef22
chore(desc): Add GitHub repo to URL ( #3864 )
2023-08-03 13:20:33 -04:00
Garrick Aden-Buie
6be6dfbfeb
Finer-grained control over shiny-provided input bindings ( #3861 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: Joe Cheng <joe@rstudio.com >
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
2023-07-31 10:41:27 -05:00
Garrick Aden-Buie
6fc06281bd
docs(navbarPage): Be less specific about collapsible breakpoint ( #3853 )
2023-07-07 10:42:39 -04:00
Barret Schloerke
f724128d41
Merge pull request #3850 from rstudio/rc-v1.7.4.1
2023-07-07 09:56:25 -04:00
Barret Schloerke
518ef0f9f8
Merge branch 'main' into rc-v1.7.4.1
...
* main: (55 commits)
Catch errors receiving individual input messages (#3843 )
Clarify what's ignored by ignoreNULL (#3827 )
Remove tests/testthat/apps/ (#3841 )
Correctly set width on `textarea` input element (#3838 )
Update selectize.js documentation URLs (#3836 )
test(json digits): Try unsetting option in test to get default behavior (#3837 )
Rebuild docs
Update README.md
fix typo in the docs for bindCache (#3825 )
Allow for `shiny:::toJSON()` to respect if `digits` has class `AsIs` to represent `use_signif=` (#3819 )
More complete `downloadButton()` example
Rename actionQueue to taskQueue, add more context to the NEWS item (#3801 )
Remove unneeded packages from package.json
Rebuild docs
Rebuild shiny.js
Update @types/node
Rebuild yarn.lock
Fix brush resetting behavior. Closes #3785
Bump fastmap dependency to 1.1.1
Sync package version (GitHub Actions)
...
2023-07-07 09:39:01 -04:00
Winston Chang
f5b395485e
shiny v1.7.4.1
...
Remove use of as.numeric_version()
Closes #3849
2023-07-07 09:33:14 -04:00
Garrick Aden-Buie
31aca7aa70
Catch errors receiving individual input messages ( #3843 )
2023-06-30 17:10:17 -04:00
Garrick Aden-Buie
b38a630224
Clarify what's ignored by ignoreNULL ( #3827 )
...
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
2023-06-30 10:44:43 -04:00
Winston Chang
1b7709411b
Remove tests/testthat/apps/ ( #3841 )
2023-06-16 16:55:14 -05:00
Garrick Aden-Buie
2b48aa0d91
Correctly set width on textarea input element ( #3838 )
...
Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com >
2023-06-12 15:57:49 -04:00
Viviane Girardin
6fdf23752e
Update selectize.js documentation URLs ( #3836 )
...
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2023-06-09 15:43:21 -05:00
Barret Schloerke
8542f5d017
test(json digits): Try unsetting option in test to get default behavior ( #3837 )
2023-06-09 15:30:02 -05:00
Winston Chang
e7b830755a
Rebuild docs
2023-06-01 15:44:18 -05:00
Gordon Shotwell
23c7b0683a
Update README.md
...
Add Discord link
2023-06-01 15:43:20 -05:00
Tom Jemmett
5805895581
fix typo in the docs for bindCache ( #3825 )
2023-05-23 08:52:42 -05:00
Barret Schloerke
90539bff25
Allow for shiny:::toJSON() to respect if digits has class AsIs to represent use_signif= ( #3819 )
2023-05-16 16:14:03 -04:00
Winston Chang
62bb21d5b6
Merge pull request #3804 from rstudio/docs/ex-download-button
2023-04-14 15:48:19 -05:00
Garrick Aden-Buie
4f85268d44
More complete downloadButton() example
2023-04-13 09:04:40 -04:00
Carson Sievert
611e517bb8
Rename actionQueue to taskQueue, add more context to the NEWS item ( #3801 )
2023-03-31 14:38:28 -05:00
Winston Chang
4d05a568c1
Remove unneeded packages from package.json
2023-03-06 17:01:43 -06:00
Winston Chang
1330325519
Rebuild docs
2023-03-01 21:38:10 -06:00
Winston Chang
92d850efa6
Rebuild shiny.js
2023-03-01 21:26:59 -06:00
Winston Chang
7bf56125eb
Update @types/node
2023-03-01 21:26:59 -06:00
Winston Chang
69f861cc8a
Rebuild yarn.lock
2023-03-01 21:20:56 -06:00
Winston Chang
a94be7b128
Fix brush resetting behavior. Closes #3785
2023-03-01 20:58:26 -06:00
Winston Chang
703766fb2e
Merge pull request #3782 from rstudio/plot-interact-init
2023-02-24 16:59:42 -06:00
Winston Chang
8e73749e21
Bump fastmap dependency to 1.1.1
2023-02-24 10:30:07 -06:00
wch
dc8ffa115b
Sync package version (GitHub Actions)
2023-02-23 20:32:23 +00:00
Winston Chang
a0385da0d7
Rebuild shiny.js
2023-02-23 14:18:21 -06:00
Winston Chang
a6b7dee4cd
Send initial values for plot interaction
2023-02-23 14:14:01 -06:00
Winston Chang
f9ff5c2637
Bump version to 1.7.4.9002
2023-01-25 11:19:40 -06:00
Winston Chang
6a1fbc57f4
Clarify comments
2023-01-25 11:18:20 -06:00
Winston Chang
38337a926f
Ensure that reactiveValues keys and values are sorted ( #3774 )
2023-01-25 11:10:05 -06:00
Winston Chang
bf6b87886c
Merge pull request #3775 from rstudio/map-loadtime
2023-01-24 13:55:37 -06:00
Winston Chang
33e6b0a305
Add on_load function for registering expressions to run on load
2023-01-23 17:25:26 -06:00
Winston Chang
cb5eac052f
Initialize Map objects at load time instead of build time
2023-01-23 16:26:44 -06:00
Winston Chang
39fee3782f
Merge pull request #3772 from rstudio/fix-slider-stoppropagation
2023-01-23 10:59:47 -06:00
Winston Chang
654f30a312
Udpate NEWS
2023-01-20 17:04:21 -06:00
Winston Chang
a763da2b94
Fix stopPropagation error in ion.rangeSlider
2023-01-20 17:00:12 -06:00
Jon Calder
0c177d30dc
Fix two typos in insertUI() docs ( #3712 )
...
* Fix two typos in insertUI() docs
* document()
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2023-01-13 11:41:44 -06:00
gsmolinski
20f8a181d4
Change size 'xl' of modalDialog to 'l' if Bootstrap 3 ( #3593 )
...
* closes issue #3631 - documenting that 'xl' modal dialog will be changed to 'm' in Bootstrap 3
* Update R/modal.R
adds note about how to switch to Bootstrap 4+ with bslib
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* add note about how to use Bootstrap 4+ with bslib to get 'xl' modal dialog
* Update NEWS.md
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2023-01-12 11:41:49 -06:00
Carson Sievert
eebcf70bb9
Add snapshot test for #3519 ( #3520 )
...
* Add snapshot test for https://github.com/rstudio/shiny/issues/3519 which was fixed via https://github.com/rstudio/bslib/pull/372
* sync package version (GitHub Actions)
* yarn build (GitHub Actions)
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2023-01-12 10:38:06 -06:00
Winston Chang
e7d62f55ca
Merge pull request #3666 from rstudio/async-load-script-2
2023-01-06 13:47:52 -08:00
Winston Chang
3a4e5f3982
Rebuild JS and CSS
2023-01-06 15:40:58 -06:00
Winston Chang
3381c3a6b9
Bump version to 1.7.4.9001
2023-01-06 15:39:42 -06:00
Winston Chang
e42c920587
Merge branch 'main' into async-load-script-2
2023-01-06 15:39:19 -06:00
Winston Chang
4635665394
Build shiny.js
2022-12-22 11:53:29 -06:00
Winston Chang
08ff066fa3
Append script elements one at a time
2022-12-22 11:53:13 -06:00
Winston Chang
816072fc29
Use Promise.allSettled
2022-12-21 16:40:45 -06:00
Carson Sievert
5eb442aa03
Make ?shiny-package topic internal in pkgdown ( #3758 )
...
* Make ?shiny-package help page internal
Otherwise, pkgdown wants it to appear in the reference, which we probably don't want
* Revert "Make ?shiny-package help page internal"
This reverts commit 4ab4cb0e46 .
* Use pkgdown's to drop the shiny-package contents (only in the pkgdown reference)
* Avoid 'incomplete final line' warning when reading pkgdown.yml
2022-12-16 10:05:12 -06:00
Carson Sievert
c32db50585
Run yarn build ( #3757 )
...
* Run yarn build
* `devtools::document()` (GitHub Actions)
* Sync package version (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2022-12-15 11:37:11 -06:00
Carson Sievert
1d9dde52df
Start new version ( #3756 )
2022-12-15 11:16:28 -06:00
Carson Sievert
6176f03ad0
v1.7.4 release candidate ( #3749 )
...
* Start release candidate
* Get rid of warnings about qplot() usage in tests
* Clean up news
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Remote remotes (htmltools is now in CRAN)
* Change header syntax in NEWS.md (to match what usethis does)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2022-12-15 11:12:19 -06:00
Winston Chang
0fc1be52eb
Render deps before modal or notification element is created
2022-12-13 17:21:59 -06:00
Carson Sievert
f12334e839
Properly check for NaN values upon resizing a brushable image. ( #3754 )
...
Regression introduced by https://github.com/rstudio/shiny/pull/3644/files#diff-9aad79e444091956075dc1e1dc5ab9202b5e998f5d441e69f040319b6c00d100L228-L230
JS error discovered by 104-plot-interaction-select (with showcase mode)
2022-12-08 14:32:27 -06:00
Winston Chang
ffb6736f11
Don't add "use strict" to external libraries ( #3746 )
...
* Add missing var in loop
* `yarn build` (GitHub Actions)
Co-authored-by: wch <wch@users.noreply.github.com >
2022-12-06 14:17:36 -06:00
Winston Chang
f084d3a34f
Merge pull request #3747 from rstudio/eslint-newline-after-var
...
Remove eslint `newline-after-var rule`
2022-12-06 13:07:43 -06:00
Winston Chang
0fe7cad876
Remove eslint newline-after-var rule
2022-12-05 16:34:23 -06:00
Carson Sievert
ecff638920
Don't supply width/height to the device if they aren't defined ( #3740 )
...
* Close #1409 : don't supply width/height to the device if they aren't defined
* Update news
* Update unit tests to reflect that plotPNG()/startPNG() now handles NULL dimensions
* Add a note about NULL dimensions on plotPNG() help page
* Update news
2022-12-02 20:27:07 -06:00
Winston Chang
db2ad780c0
Don't ignore errors when loading or executing a script
2022-12-01 17:16:59 -06:00
Winston Chang
5cd848bd28
Await running each action in actionQueue
2022-12-01 17:01:00 -06:00
Carson Sievert
ed6022e3f2
Have renderPlot() error early if height/width of a plot aren't yet defined ( #3739 )
...
* Close #3704 . Close #3735 . Close #1409 . Throw informative error in renderPlot() early if height/width of a plot aren't yet defined
* `devtools::document()` (GitHub Actions)
* Add unit tests
* Use consistent filename; add intentional failure (to get artifact uploads)
* Make output id argument name more unique
* Update news
* plotPNG() test isn't worth it
* Don't try to provide a suggestion on how to fix the issue (it's no worse than what we currently have, and we probably should be defaulting to an 'arbitrary' size anyway
* update news
* minimize diff
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2022-11-22 17:23:19 -06:00
Winston Chang
a063540407
Build shiny.js
2022-11-01 21:30:29 -05:00
Winston Chang
aa932532f3
Add sync and async versions of renderContent, renderHtml, renderDependencies
2022-11-01 21:30:15 -05:00
Winston Chang
8160f8c726
Add .d.ts files
2022-10-31 16:51:13 -05:00
Winston Chang
af900d1037
Use actionQueue
2022-10-31 16:51:13 -05:00
Winston Chang
49320e6edd
Make HtmlOutputBinding.renderValue an async function
2022-10-31 16:51:13 -05:00
Winston Chang
4308887296
Fix types for message.multiple
2022-10-31 16:51:13 -05:00
Winston Chang
dffd8bc7fd
Commit .d.ts files
2022-10-31 16:51:13 -05:00
Winston Chang
554f835293
Make sure not to send input values during dispatchMessage
2022-10-31 16:51:13 -05:00
Winston Chang
50e7b6768d
Use async queue to handle incoming messages
2022-10-31 16:51:13 -05:00
Winston Chang
db222af7e0
Make sure dynamic scripts run in order
2022-10-31 16:51:13 -05:00
Winston Chang
5b688707b7
Add await for renderContent() calls
2022-10-31 16:51:13 -05:00
Winston Chang
8dfd8f5b33
Convert renderDependency() to async
2022-10-31 16:51:13 -05:00
Carson Sievert
20cc8e26b5
Use getBoundingClientRect() over offsetHeight/offsetWidth to get more precise sizing ( #3720 )
...
* Use getBoundingClientRect() over offsetHeight/offsetWidth to get more precise sizing
* Update news
2022-10-28 15:55:24 -05:00
Carson Sievert
e48e9c6904
Add fill arguments to plotOutput(), imageOutput(), and uiOutput() ( #3715 )
...
* Add fill arguments to plotOutput(), imageOutput(), and uiOutput()
* Update news
* Code review
* `devtools::document()` (GitHub Actions)
* `yarn build` (GitHub Actions)
* Sync package version (GitHub Actions)
* Update news
* Update to use bindFillRole()
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2022-10-26 11:52:26 -05:00
Joe Cheng
87c673f283
Bump version to v1.7.3.9000
2022-10-25 18:01:14 -07:00
Joe Cheng
dfaefa8905
Merge tag 'v1.7.3'
2022-10-25 17:59:18 -07:00
Joe Cheng
cd4f406234
Squelch R CMD check message
...
"Package has help file(s) containing install/render-stage \Sexpr{} expressions but no prebuilt PDF manual."
2022-10-24 18:37:15 -07:00
Joe Cheng
190b542613
Use v1.7.3 instead
...
Something in our yarn build toolchain doesn't like version numbers
with 4 segments
2022-10-24 16:54:54 -07:00
Joe Cheng
73e48ab5f4
Remove Remotes, add NEWS item
2022-10-24 16:22:42 -07:00
Barret Schloerke
62a95b9ce2
Reverting selectize logic change from #3644 ( #3716 )
2022-10-24 12:18:00 -04:00
Barret Schloerke
999eb1de3c
Add fontawesome remote
2022-10-21 15:47:39 -04:00
Barret Schloerke
55985740de
Skip template tests even if shinytest2 is available. Install shinytest2 from CRAN
...
We will bring these tests back after this release.
We will move shinytest2 to suggests after this release
2022-10-21 15:30:00 -04:00
Barret Schloerke
e82b71da65
Update template code to work with latest shinytest2
2022-10-21 14:54:05 -04:00
Joe Cheng
9ce1e6c549
Fix unit test to be compatible with fontawesome 0.4.0
2022-10-21 11:05:04 -07:00
Winston Chang
cda59da698
Remove types-jquery.patch ( #3710 )
...
Co-authored-by: wch <wch@users.noreply.github.com >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2022-10-05 10:50:19 -04:00
Winston Chang
51da80d381
Merge pull request #3709 from rstudio/blob
2022-10-03 12:36:29 -05:00
wch
412606c594
yarn build (GitHub Actions)
2022-10-03 17:26:14 +00:00
Winston Chang
da2df5ac58
Use correct type for messages
2022-10-03 12:20:59 -05:00
Winston Chang
98f17e0cd2
Disable eslint rules only within scope
2022-10-03 11:41:28 -05:00
Winston Chang
9b2c04f298
Remove redundant setting
2022-09-30 19:57:03 -05:00
Winston Chang
ed4a97154d
Remove makeBlob
...
Blob has long been available on all major browsers, so makeBlob is no longer needed.
2022-09-30 16:29:38 -05:00
Winston Chang
9dcd62f944
Update eslint
2022-09-30 16:17:19 -05:00
Winston Chang
213c645524
Upgrade esbuild and typescript
2022-09-30 15:59:24 -05:00
Winston Chang
f1c0ac2b30
Upgrade to yarn 3.2.3
2022-09-30 15:57:51 -05:00
Barret Schloerke
16c6d55f60
Enable TypeScript strict mode ( #3644 )
2022-09-29 16:03:05 -04:00
Hedley
6e40a3dd39
Update jQuery-UI to 1.13.2 ( #3697 )
2022-09-21 10:34:51 -04:00
Joe Cheng
04ad1453c1
Merge pull request #3694 from rstudio/rook-doc-link
...
Add link to Rook spec from docs
2022-09-07 17:38:36 -07:00
jcheng5
80eeff68ab
Sync package version (GitHub Actions)
2022-09-07 14:27:51 -07:00
jcheng5
6128a3ab65
yarn build (GitHub Actions)
2022-09-07 20:43:50 +00:00
Joe Cheng
5f25537079
Add link to Rook spec from docs
2022-09-07 13:37:37 -07:00
Winston Chang
c21ba0baca
Bump version to 1.7.2.9000
2022-07-19 09:18:16 -05:00
Winston Chang
ebf786c2eb
Merge tag 'v1.7.2'
...
Shiny 1.7.2 on CRAN
2022-07-19 09:16:45 -05:00
wch
b39ffafea9
devtools::document() (GitHub Actions)
2022-07-19 00:16:11 +00:00
Winston Chang
4441945a68
Use inherits() instead of if(class(x)==y)
2022-07-18 19:11:24 -05:00
Winston Chang
cd95e058e6
Remove URL because CRAN doesn't like it
2022-07-18 19:11:24 -05:00
Winston Chang
a0144d77ef
Remove broken link
2022-07-18 19:11:24 -05:00
Carson
64cec08a74
Check in most recent revdep results
2022-07-08 11:53:50 -05:00
Winston Chang
7a77b55e6a
Merge branch 'main' into rc-v1.7.2
2022-07-05 20:08:10 -05:00
Winston Chang
54e5a6b43c
Merge branch 'dvg-p4-fix-throttle'
2022-07-05 20:03:22 -05:00
Winston Chang
9653cc2893
Rebuild shiny.js
2022-07-05 20:01:22 -05:00
Winston Chang
47dc5b4116
Code and comment cleanup
2022-07-05 19:37:44 -05:00
dvg-p4
9db9ef527a
Fixed check for isPending and rebuilt javascript
2022-07-04 10:21:22 -04:00
dvg-p4
9285a1f7fc
Update srcts/src/time/throttle.ts
...
Based on suggestion
Co-authored-by: Winston Chang <winston@stdout.org >
2022-07-01 19:02:26 -04:00
dvg-p4
d22eb1524a
Updated NEWS.md
2022-07-01 17:15:09 -04:00
dvg-p4
5e3971c776
Fixed major bug in throttle.ts
2022-07-01 16:58:41 -04:00
Carson
dbe4896102
Merge branch 'main' into rc-v1.7.2
2022-06-27 12:12:55 -05:00
Joe Cheng
ff5ef52dd5
Fix #3250 ( #3602 )
...
* Fix #3250
pruneStackTrace was interacting badly with dplyr errors. I'm still
not sure what causes these new cases, but the new behavior seems to
be much better, with no downside that I can think of.
* Fix existing unit tests
* Update news
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2022-06-27 12:05:28 -05:00
Joe Cheng
634b1c7c3c
Don't kill the session when a debounced/throttled reactive expr errors ( #3624 )
...
* Don't kill the session when a debounced/throttled reactive expr errors
Fixes #3581
* Update NEWS with PR number
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2022-06-27 10:57:10 -05:00
Carson
1c9f8940a9
Merge branch 'main' into rc-v1.7.2
2022-06-24 17:53:49 -05:00
Carson Sievert
d4527cdc28
Use ragg::agg_png over Cairo::CairoPNG if available ( #3654 )
...
* Close #3626 : use ragg::agg_png over Cairo::CairoPNG if available
* Update documentation
2022-06-24 17:50:58 -05:00
cpsievert
514206850a
Sync package version (GitHub Actions)
2022-06-14 15:43:58 +00:00
cpsievert
809bc8c6de
yarn build (GitHub Actions)
2022-06-14 15:42:16 +00:00
cpsievert
0d720616f3
devtools::document() (GitHub Actions)
2022-06-14 15:39:35 +00:00
Carson
0c325d422f
Groom NEWS.md
2022-06-14 10:35:36 -05:00
Carson
d368aa72c3
Update URLs
2022-06-14 10:35:36 -05:00
Carson
27e1348dcb
Start v1.7.2 release candidate
2022-06-14 10:35:36 -05:00
Carson Sievert
474f14003b
Follow up to #3385 : warn instead of message; update unit tests to reflect some parameters can now succeed when others fail ( #3652 )
2022-06-14 10:34:20 -05:00
Carson Sievert
8a5da25545
Fix/update news ( #3651 )
2022-06-14 09:18:51 -05:00
Barret Schloerke
540d68ed9f
Update the _inputs_ and _values_ regular expr to support a trailing = ( #3648 )
2022-06-10 11:39:12 -04:00
Khaled Al-Shamaa
1ad49b153c
Enable fileInput to set the capture attribute ( #3481 )
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2022-06-10 10:30:34 -05:00
Winston Chang
15885cbb5f
Update NEWS
2022-06-10 10:07:00 -05:00
Dean Attali
b6979d135c
fix bookmarking bug #2297 : don't break all bookmarking system if some URL params don't parse correctly ( #3385 )
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2022-06-10 10:04:47 -05:00
Winston Chang
d4b19820a4
Update NEWS
2022-06-10 10:02:30 -05:00
Dieter Menne
8d529095a7
Corrected for stricter length checking in R 4.2.0 ( #3625 )
...
* Corrected for stricter length checking in R 4.2.0
* Update R/bootstrap-layout.R
Fine! I had thought of that case, but could not find that elegant solution
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2022-06-10 09:59:14 -05:00
Winston Chang
77f9052ab5
Make mathjax configurable ( #3650 )
...
Co-authored-by: Neutron3529 <qweytr_1@163.com >
Co-authored-by: Joe Cheng <joe@rstudio.com >
2022-06-10 09:57:02 -05:00
Ryan Barnard
9fcc1fe8ad
Fixed automatic guessing of Content-Type in downloadHandler ( #3393 )
...
* Set default downloadHandler contentType to NULL.
The change from %OR% to %||% broke automatic guessing of content type
since `NA %||% ...` evaluates to `NA`. Setting the default contentType
to NULL restores the previous behavior of automatically setting the
content type based on the file extension.
* Updated NEWS.md: downloadHandler contentType fix.
* Update NEWS.md
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2022-06-10 09:39:00 -05:00
Barret Schloerke
5d30b55372
Spelling defintion -> definition ( #3649 )
2022-06-09 16:52:27 -04:00
Carson Sievert
78d77ce373
insertUI() now supports execution of <script> ( #3630 )
2022-05-10 11:43:21 -05:00
Joe Cheng
2cae04186b
Merge pull request #3628 from rstudio/joe/feature/autoreload-custom-url
...
Add ability for autoreload ws to be at a custom URL
2022-05-04 16:35:39 -07:00
Joe Cheng
59bddea1e9
Use external, not internal, sourcemaps for extras
2022-05-04 16:23:48 -07:00
Joe Cheng
d6bd3d9f9b
Add ability for autoreload ws to be at a custom URL
2022-05-04 09:05:53 -07:00
Joe Cheng
8eb7b056f2
devmode should activate autoreload ( #3620 )
...
devmode should activate autoreload
It said it didn't, but until this commit, it appeared not to
2022-04-27 13:51:02 -07:00
Barret Schloerke
40ae9a903e
Spelling ( #3618 )
2022-04-23 12:25:11 -04:00
Barret Schloerke
5b6c80d4b2
Update shinyAppTemplate() content to use {shinytest2} ( #3599 )
2022-04-22 16:10:11 -04:00
Dean Attali
fd7518018c
Update internal docs: reexports.yml -> reexports.json ( #3522 )
2022-03-11 11:59:35 -05:00
Kathryn Doering
5c03326a8c
Use HEAD for ref instead of master in runGitHub() ( #3564 )
...
Co-authored-by: Kathryn Doering <kathryn.doering@noaa.gov >
2022-02-14 15:53:33 -05:00
Barret Schloerke
2c82ee0235
Bump dev version ( #3588 )
2022-02-14 15:24:47 -05:00
Barret Schloerke
ac84be956a
Opt-in to C collate order in test snapshots ( #3515 )
2022-02-14 14:12:25 -05:00
Winston Chang
0fb154cc1e
Trigger input event even when there is no input binding ( #3584 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2022-02-14 13:45:59 -05:00
Carson Sievert
837e8d33f6
Update stack trace test expectations ( #3550 )
2022-02-14 13:14:10 -05:00
Winston Chang
3365bfc395
Merge pull request #3583 from ismirsehregal/main
2022-02-09 17:27:18 -06:00
ismirsehregal
135fe21278
Update runapp.R
...
Fixed typo
2022-02-09 15:11:34 +01:00
Carson Sievert
fc7e237000
Pass args from knit_print.shiny.render.function() down to it's use of the knit_print() generic ( #3569 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Barret Schloerke <barret@rstudio.com >
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2022-01-11 12:21:18 -06:00
Winston Chang
de8134742d
Update NEWS
2022-01-11 10:41:19 -06:00
Winston Chang
f814034835
Merge pull request #3570 from romainfrancois/shinyActionButtonValue
2022-01-11 10:38:28 -06:00
Romain Francois
6d9fad29f3
put the extension class on the left.
...
from: https://github.com/tidyverse/dplyr/issues/6154
2022-01-11 12:49:48 +01:00
Lionel Henry
313ae9044d
Handle chained errors ( #3567 )
...
Closes tidyverse/dplyr#5552
Part of #3566
2022-01-10 18:33:14 -08:00
Barret Schloerke
9389160af0
Cache the reactlog version found. Remove mustWork argument to system_file(). ( #3554 )
2021-12-08 15:30:37 -05:00
Barret Schloerke
6a7ffeff68
master -> main; use shiny-workflows ( #3535 )
2021-11-19 17:50:57 -05:00
Winston Chang
bc6ff57cb7
Remove old unused JS files ( #3547 )
2021-11-17 22:01:19 -06:00
Carson Sievert
b52b9e4520
Some UI-related speed improvements ( #3541 )
2021-11-17 16:25:27 -06:00
Winston Chang
fb71ab6146
Editor configuration improvements
2021-11-16 15:38:21 -06:00
Carson Sievert
d8c7a634ff
Fix failing tabPanel() test broken by testthat 3.1.0 ( #3543 )
2021-11-05 16:45:16 -05:00
Winston Chang
396dd2632e
Merge pull request #3537 from rstudio/htmldep
2021-11-05 15:56:09 -05:00
Winston Chang
c11875a5f0
Fix appending to list
2021-11-05 15:52:14 -05:00
Winston Chang
2e599faf1f
Fix comment
2021-11-05 15:47:23 -05:00
Winston Chang
a5a8385420
Use all_files=FALSE for html dependencies
...
This commit sets all_files=FALSE for html dependencies in www/shared.
2021-11-04 11:24:46 -05:00
Winston Chang
33ed698e5b
Remove “file =“
2021-11-04 11:15:01 -05:00
Winston Chang
ed547fdf40
Rebuild JS files
2021-11-03 21:28:15 -05:00
Winston Chang
0b1c35c92b
Use .map() and .forEeach() instead of for loops
2021-11-03 21:28:11 -05:00
Winston Chang
d304bdf333
Rename HtmlDepSimplified to HtmlDepNormalized
2021-11-03 20:54:53 -05:00
Winston Chang
a9255e6b12
Extract jquery-ui dependency into function
2021-11-03 20:54:53 -05:00
Winston Chang
45429fb798
Streamline code for adding scripts and attachments
2021-11-03 13:56:37 -05:00
Winston Chang
1206d1d3ba
Use array of objects to represent meta tags
2021-11-03 13:56:37 -05:00
Winston Chang
af44a447a1
Fix type specification of HTML dependency meta values
2021-11-03 11:40:49 -05:00
Winston Chang
d7fb6d1793
Fixes for strict null checks
2021-11-03 11:40:49 -05:00
Winston Chang
cb0083adb2
Update VSCode editor settings
2021-11-03 11:40:49 -05:00
Winston Chang
77bae68f26
Update NEWS
2021-11-03 11:40:48 -05:00
Winston Chang
e9f8b4d552
Use htmlDependencies with ‘src=file’ for showcase mode
2021-11-03 11:39:28 -05:00
Winston Chang
aee6b74cfb
Minor cleanups
2021-11-03 11:39:28 -05:00
Winston Chang
29b6b03297
Extract restyle code into separate code path
2021-11-03 11:39:28 -05:00
Winston Chang
b5ebd8a645
Fix attachment handling and add more specific types
2021-11-03 11:39:28 -05:00
Winston Chang
356ba8c5a1
Add simplifyHtmlDependency() function
2021-11-03 11:39:28 -05:00
Winston Chang
5aa5cb1794
Make dep.src.href field optional
2021-11-03 11:39:28 -05:00
Winston Chang
09c609e417
Bump version to 1.7.1.9001
2021-11-03 11:39:28 -05:00
Winston Chang
10e7d11846
Allow array of attributes for stylesheets
2021-11-03 11:39:28 -05:00
Winston Chang
4e442312a7
Serve HTML dependencies from dynamic paths
2021-11-03 11:39:28 -05:00
Winston Chang
8ea97df3f2
Fix getid access of data-input-id attribute ( #3538 )
2021-11-03 11:38:54 -05:00
Winston Chang
a8c14dab96
Bump version to 1.7.1.9000
2021-10-04 11:09:26 -05:00
Winston Chang
00775b90e8
Bump version to 1.7.1
2021-09-30 14:48:12 -05:00
Winston Chang
c6ae4c0034
Update NEWS
2021-09-30 14:48:06 -05:00
Winston Chang
1efcaa0b5d
Use esbuild option preserveSymlinks
...
This allows the node_modules directory to be a symlink, without causing weird
build problems.
2021-09-30 14:44:17 -05:00
Carson Sievert
e6d94f6f66
Fix regression in repeated appendTab()s when navbarMenu() is present ( #3518 )
2021-09-30 14:43:09 -05:00
Barret Schloerke
5a8a02626c
add news item for #3512
2021-09-28 18:00:36 -04:00
Hadley Wickham
c23293750d
Re-arrange conditions for testthat 1.0.0 compatibility ( #3512 )
2021-09-28 17:51:45 -04:00
Winston Chang
9de74048a2
Bump version to 1.7.0.9000
2021-09-28 16:39:35 -05:00
wch
0fc861afb4
yarn build (GitHub Actions)
2021-09-10 20:05:12 +00:00
wch
2300dae10b
sync package version (GitHub Actions)
2021-09-10 20:02:58 +00:00
wch
dfbb98abfd
Document (GitHub Actions)
2021-09-10 20:02:19 +00:00
Winston Chang
9670839235
Fix example parse errors
2021-09-10 14:55:53 -05:00
Winston Chang
1e2326c2b6
Update reexports
2021-09-10 14:46:30 -05:00
Carson
6f46b847e2
Address check NOTE: Undeclared package ‘htmlwidgets’ in Rd xrefs
2021-09-07 15:10:52 -05:00
Carson
8c44559a1f
Fix DT Rd link
2021-09-07 14:48:34 -05:00
Carson
d245a972ee
simplify gha
2021-09-07 14:23:22 -05:00
Carson
c153d0591f
bump version
2021-09-07 14:14:50 -05:00
Barret Schloerke
2ce18ef324
Update GHA workflows to use latest versions ( #3492 )
2021-08-24 14:59:52 -04:00
Barret Schloerke
2792d65e40
Fix link to DT::renderDataTable() ( #3490 )
2021-08-20 09:14:57 -05:00
Barret Schloerke
7b00f605aa
Remove rlang remote ( #3487 )
2021-08-19 18:07:23 -04:00
Barret Schloerke
4cb3f05e8e
Adjust app port tests to use random port values ( #3488 )
2021-08-19 18:06:43 -04:00
Winston Chang
8e40c815eb
Merge pull request #3485 from rstudio/wch-fix-checkbox-radio
2021-08-13 13:56:35 -05:00
Winston Chang
6dfd8bc0ff
Only ignore node_modules at top level
2021-08-13 13:50:54 -05:00
wch
2ef397f024
yarn build (GitHub Actions)
2021-08-13 18:08:05 +00:00
wch
94749f6114
yarn lint (GitHub Actions)
2021-08-13 18:08:05 +00:00
Winston Chang
4a39588d00
Update NEWS
2021-08-13 13:00:57 -05:00
Winston Chang
f5d5832149
Fix invisible checkboxes and radio buttons in RStudio on Mac
2021-08-13 12:58:12 -05:00
Barret Schloerke
68deab9b0e
Remove console.log("Shiny version: ", Shiny.version) statement ( #3480 )
2021-08-05 18:16:39 -04:00
Winston Chang
96efac2bd7
Merge pull request #3478 from rstudio/install_expr_news_entry
2021-08-05 10:17:50 -05:00
Barret Schloerke
a67059f9f9
update news
2021-08-04 15:31:56 -04:00
Barret Schloerke
cdc51c09c7
Add test for inject()ed quosures when extracting the cacheHint ( #3476 )
2021-08-04 13:35:50 -04:00
Barret Schloerke
a6f02cf214
Fix bash logic in action step ( #3474 )
2021-08-02 22:35:11 -04:00
Barret Schloerke
7600770a6e
Fix Rituals workflow validating commits have not been made ( #3473 )
2021-08-02 22:19:31 -04:00
Barret Schloerke
1b3ed88bd1
exprToFunction() and installExprFunction() support quosures (#3472 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: Joe Cheng <joe@rstudio.com >
2021-08-02 22:09:19 -04:00
Barret Schloerke
f01dc9f0fb
Move user documentation up to the top of Readme ( #3464 )
2021-08-02 22:06:09 -04:00
Barret Schloerke
9a65890e92
Update esbuild-plugin-sass to latest version ( #3463 )
2021-08-02 21:41:02 -04:00
Carson Sievert
ffef0c2eb1
Interpret NULL discrete limits as NA, fixes #2666 ( #2668 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-07-27 14:02:58 -05:00
Barret Schloerke
8b74338b0f
Add sustainEnvAndQuoted(). Remove getQuosure() ( #3468 )
...
Documentation to come in a later PR
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2021-07-26 17:54:37 -04:00
Winston Chang
ed3c676548
Merge pull request #3466 from rstudio/wch-exprfunction-fix
2021-07-16 16:14:38 -05:00
Winston Chang
30c0a2bd29
Update NEWS
2021-07-16 15:17:37 -05:00
Winston Chang
997e5e5ce5
Fix handling of getQuosure3(expr, env, quoted=TRUE)
2021-07-16 15:14:28 -05:00
Winston Chang
aba6b2e4db
Fix NEWS entry
2021-07-15 17:52:59 -05:00
Winston Chang
3f48e3b0af
Merge pull request #3462 from rstudio/wch-exprfunction-quosures
2021-07-15 17:51:22 -05:00
Winston Chang
b4879a342c
Update NEWS
2021-07-15 17:50:40 -05:00
Winston Chang
5070146061
Fix example
2021-07-15 17:21:15 -05:00
Winston Chang
d28c3e15ad
Update pkgdown.yml
2021-07-15 17:14:47 -05:00
Winston Chang
4b496be520
Update documentation
2021-07-15 17:11:36 -05:00
Winston Chang
979288a590
Add quosure tests for custom render functions
2021-07-14 16:31:23 -05:00
Winston Chang
9365d4f3c4
Update comment
2021-07-14 16:30:53 -05:00
Winston Chang
e1daf8aae7
Export getQuosure() and add internal getQuosure3()
2021-07-09 17:36:46 -05:00
Winston Chang
8a57dbf608
Rename get_quosure to getQuosure
2021-07-06 12:36:45 -05:00
Winston Chang
ac9b76c651
Modify exprToFunction to accept quosures
2021-07-02 15:45:10 -05:00
Winston Chang
139526ef2d
Move expression/quosure functions to utils-lang.R
2021-07-02 14:25:46 -05:00
Winston Chang
d1e7e6c63a
Add note about R version support
2021-07-02 14:04:35 -05:00
Winston Chang
29b574bf94
Merge pull request #3456 from heds1/update-rejected-ports
2021-07-01 16:34:25 -05:00
Barret Schloerke
7e4248bbca
TypeScript: Globally declare Shiny variable, window.Shiny variable, and Shiny type ( #3457 )
2021-07-01 14:51:16 -04:00
heds1
fee267dc2e
docs: update runapp port parameter docs, and add three more tcp ports to be blocked
2021-07-01 21:40:59 +12:00
Carson Sievert
9864130435
Use random inline styles to ensure transitionend fires everytime ( #3452 )
...
* Follow up to #3333 : use random inline styles to ensure transitionend fires everytime
* yarn lint (GitHub Actions)
* Add missing '#'
* yarn lint (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-30 15:26:49 -05:00
Carson Sievert
c9770cbd03
Close #3443 : Fix sliderInput()'s grid tick positioning without Bootstrap ( #3444 )
2021-06-29 15:56:47 -05:00
Carson Sievert
ed6a40ba41
Close #3446 : get removeModel() working with Bootstrap 4 ( #3447 )
2021-06-29 15:54:48 -05:00
Carson
3c22cdf90c
roxygenize
2021-06-29 15:11:39 -05:00
Marcus Spittler
e55749b897
Update utils.R example to validate() ( #2809 )
...
Added an empty option to `choices` in `selectizeInput` in order to make the second `need` statement in `validate` meaningful. Otherwise the second `need` ("Please choose a state") is never displayed.
2021-06-29 15:10:42 -05:00
Carson Sievert
88cd87a5f7
Revert "Set selectize dropdownParent to "body" to prevent clipping" ( #3450 )
...
This reverts commit ce90d5cd0a .
2021-06-29 12:22:33 -05:00
Barret Schloerke
244fdc72bc
Leverage more eslint rules ( #3439 )
2021-06-22 21:20:54 -04:00
Barret Schloerke
b9d163a71d
TypeScript other distributed JS/CSS files ( #3436 )
2021-06-18 10:18:51 -04:00
Barret Schloerke
61ee467dee
Replace dev versions with -alpha versions for JS code ( #3435 )
2021-06-17 16:02:39 -04:00
Carson Sievert
7c0829d553
Change from .nav-item to .dropdown-item when inserting inside .dropdown-menu ( #3434 )
...
* Change from .nav-item to .dropdown-item when inserting inside .dropdown-menu
* Update srcts/src/shiny/shinyapp.ts
* Update srcts/src/shiny/shinyapp.ts
* yarn lint (GitHub Actions)
* yarn build (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-16 17:44:03 -05:00
Carson Sievert
68eb4c6965
update news for breaking insertTab() change ( #3433 )
2021-06-16 16:41:07 -05:00
Barret Schloerke
6d4015f61b
./package.json updates to make TS Types package cleaner to install (#3430 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2021-06-16 16:08:50 -04:00
Barret Schloerke
d89513b7e0
Match casing for plot alt text "Plot object" ( #3432 )
...
* Match spelling for Plot Object phrase
From #3398
* Document (GitHub Actions)
* Consistent casing for `"Plot object"` for plot alt text
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2021-06-16 15:08:13 -05:00
Carson Sievert
a159594a45
insertTab(position = "after") by default ( #3431 )
...
* Follow up to #3404 : change insertTab()'s default position so that default behavior doesn't change
* Update news
* Document (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-16 15:01:36 -05:00
Carson Sievert
78c62ad819
Various cleanup ( #3428 )
...
* Follow up to #3366 : don't change sliderInput()'s default accent color
* Update news
* nav_append not tab_append 🤦
* bslib no longer tries to mark a non-tabPanel as active
2021-06-15 16:45:23 -05:00
Barret Schloerke
b3247d5a3b
Move ./srcts configs to top level to support types installation from GitHub ( #3425 )
2021-06-15 14:18:53 -04:00
Winston Chang
91f920e14c
Merge pull request #3413 from rstudio/feature/selectize-dropdown-parent-body
...
Set selectize dropdownParent to "body" to prevent clipping
2021-06-15 11:50:37 -05:00
Carson Sievert
bcb7cde44b
insertTab() now handles position correctly when target is NULL ( #3404 )
...
* Close #3403 : insertTab() now handles position correctly when target is NULL
* Have insertTab()'s target default to NULL
* yarn tsc (GitHub Actions)
* yarn build (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-14 15:51:38 -05:00
Carson Sievert
052c9458b7
yarn add node-gyp; yarn build ( #3424 )
2021-06-14 15:51:03 -05:00
Barret Schloerke
3fe8c27d21
Export TypeScript type definitions to local folder ( #3418 )
2021-06-14 14:25:05 -04:00
Barret Schloerke
1dd256b210
TypeScript: Remove any types / improve type definitions ( #3414 )
2021-06-14 14:22:39 -04:00
Carson Sievert
dc9c6ae769
Better color constrasting in sliderInput() ( #3366 )
...
* Better color constrasting in sliderInput()
Closes https://github.com/rstudio/bslib/issues/228
* Update build script; recompile
* bslib tabsets now include data-bs-toggle
2021-06-14 12:48:57 -05:00
Carson Sievert
2cdafed2e0
Use ggplot2::get_alt_text() if available to provide better default alt text ( #3398 )
...
* Close #3397 : Use ggplot2::get_alt_text() if available to provide more informative default alt text for ggplots in renderPlot()
* Update R/render-plot.R
Co-authored-by: Winston Chang <winston@stdout.org >
* better Rd docs
* make logic more self-contained
* Add news
Co-authored-by: Winston Chang <winston@stdout.org >
2021-06-14 10:22:07 -05:00
JJ Allaire
ce90d5cd0a
Set selectize dropdownParent to "body" to prevent clipping
...
To prevent clipping of the selectize drop-down we set the dropdownParent to "body". This might be necessary if e.g. overflow-x: scroll is set on it's container, which forces overflow-y to 'auto' (as per https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-y ).
See option docs here: https://github.com/selectize/selectize.js/blob/master/docs/usage.md
Additional discussion of usage here: https://github.com/selectize/selectize.js/issues/192
2021-06-09 19:41:10 -04:00
Barret Schloerke
b4caa9137d
Distribute TypeScript code into separate files ( #3317 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2021-06-09 14:54:47 -04:00
Carson Sievert
dcca77c936
Fix tab input value updating for BS4 dropdowns ( #3412 )
...
* Fix tab input value updating for BS4 dropdowns
* Add comments
* yarn build (GitHub Actions)
* Better comment
* yarn lint (GitHub Actions)
* yarn build (GitHub Actions)
Co-authored-by: Barret Schloerke <barret@rstudio.com >
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-02 15:55:32 -05:00
Carson Sievert
871b1baacc
Follow up to #3410 : bump version and update news ( #3411 )
2021-06-02 13:03:09 -05:00
Carson Sievert
4deb699066
Bootstrap 5 support ( #3410 )
...
* Bootstrap 5 support for modals & showcase mode
* selectizeInput() BS5 compatibility
* Both BS4 and 5 define window.bootstrap
* Document (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-06-02 12:36:04 -05:00
Carson Sievert
ccc8e053c6
Use bslib's new nav() api to implement tabPanel() and friends ( #3388 )
...
* Use bslib's new nav() api to implement tabPanel() and friends
* bslib won't be re-exporting prepend/append tab since they've been superceded by insertTab()
* Update DESCRIPTION
* Use the new bslib::page_navbar()
* Leverage bslib::page_navbar()'s more intelligent title->windowTitle handling
Closes #2310
* fix name change
* Make sure navbarPage() isn't browsable by default
2021-06-02 12:10:41 -05:00
Barret Schloerke
6405056c92
Install Cairo macOS devel brew dependency ( #3408 )
2021-05-26 17:06:27 -04:00
Barret Schloerke
9f9304fdc5
Remove Font Awesome 5 message about the level-up icon ( #3407 )
2021-05-26 16:31:15 -04:00
Carson Sievert
3d3b05c7a5
Correctly render script tags defined as list() objects ( #3395 )
...
* Close #3345 : correctly render script tags defined as list() objects
* implement boolean attrs; use vanilla JS
* Update news
* avoid toggleAttribute
* yarn lint (GitHub Actions)
* code review
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-05-20 17:44:34 -05:00
Carson Sievert
543a6b5836
Fix CRAN note ( #3394 )
...
* Follow up to #3392 : update tabPanel() baselines
* Fix check NOTE
* Revert "Follow up to #3392 : update tabPanel() baselines"
This reverts commit c97022c386 .
Issue will be fixed in htmltools
2021-05-20 13:58:16 -05:00
Carson Sievert
b0de68919a
tagify() dynamic UI before attempting to write the tags ( #3392 )
...
* Close #3391 : properly tagify() dynamic UI before attempting to write the tags
* Document (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-05-18 12:28:17 -05:00
Richard Iannone
d65ad5ea90
Modify icon() function to call fontawesome::fa_i() for equivalent functionality ( #3302 )
...
* Use `fontawesome::fa_i()` for FA <i> tags
* Remove fontawesome vendor files
* Add fontawesome pkg to Imports & Remotes
* Remove FontAwesome `person()` entry
* Remove Font Awesome license info
* Delete font-awesome.R
* Update 'Collate' field (removes 'font-awesome.R')
* Delete updateFontAwesome.R
* Prefer use of `fontawesome::fa()`
* Improve function documentation
* Update help file using roxygen
* Modify icon name
* Update icon name in example
* Modify icon name in example
* Update help files
* Update bootstrap.R
* Update icon.Rd
* Update bootstrap.R
* Revert `showcaseCodeTabs()` to use FA v4 name
* Revert icon name in example (back to FA v4)
* Remove `call. = FALSE` in `stop()`
* Remove `fontawesome` from Remotes
* Add min version req for the fontawesome pkg
* Increase minimum version requirement for fontawesome
* Update roxygen docs for `icon()`
* Document (GitHub Actions)
* Update icon.Rd
* Generate early return <i> tag for tabsetPanel logic
* Close #3384 and #3383 : simplify and correct icon() logic
* Install htmltools PR for now
* Document (GitHub Actions)
* Avoid using tag attribs to hold non-attribute values
* Better legacy support
* No need to call prepTabIcon() twice
* code review
* Fix glyphicon class creation
* update news
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: rich-iannone <rich-iannone@users.noreply.github.com >
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-05-12 14:26:09 -05:00
Carson Sievert
383fa6c0e0
Follow up to #3372 : fix oversight in refactor ( #3387 )
2021-05-10 09:58:30 -05:00
Barret Schloerke
8d40b3af70
Revert "Do not double pull within rituals"
...
This reverts commit 9c80d7a4ec .
2021-05-10 10:49:54 -04:00
Barret Schloerke
9c80d7a4ec
Do not double pull within rituals
2021-05-07 15:15:41 -04:00
Winston Chang
2360bde13e
Remove deprecated code and parameters ( #3137 )
...
* Remove deprecated reactive* functions
* Remove deprecated code
* Update NEWS
* Remove extractStackTrace and formatStackTrace
* remove responsive from bootstrapPage() wrappers
* Move extractStackTrace() to tests so they pass
* Don't force suggested pkgs in devel on GHA
Co-authored-by: Carson <cpsievert1@gmail.com >
2021-05-06 09:46:30 -05:00
Winston Chang
d25ae099d4
Merge pull request #3333 from rstudio/reportCssOnLoad
2021-05-05 18:12:17 -05:00
Winston Chang
2d492886e4
Prettify TS
2021-05-05 18:04:35 -05:00
Winston Chang
33741436c7
Merge remote-tracking branch 'origin/master' into reportCssOnLoad
2021-05-05 18:03:41 -05:00
Winston Chang
318cc7fcaf
Rebuild JS files
2021-05-05 18:02:32 -05:00
Winston Chang
bebcf0b196
Add important flag
2021-05-05 18:02:32 -05:00
Winston Chang
f2be2e4eb1
Update comments
2021-05-05 17:48:39 -05:00
Winston Chang
a2ea017046
Add sendImageSize2
2021-05-05 17:40:46 -05:00
Winston Chang
fc338c8958
Use removeSheet()
2021-05-05 16:17:34 -05:00
Winston Chang
bbb27f1224
Make more CSS properties !important
2021-05-05 15:56:50 -05:00
Winston Chang
d2fbdb6c48
Add note about synchronous behavior in IE
2021-05-05 15:56:29 -05:00
Winston Chang
38c70842d9
Rebuild JS files
2021-05-05 15:18:01 -05:00
Winston Chang
0e22c4c591
Simplify IE CSS handling
2021-05-05 14:53:12 -05:00
Winston Chang
70e0eede16
New strategy for sending information when CSS loads
2021-05-05 14:50:39 -05:00
Barret Schloerke
4858a379e7
Make sure dev version of rlang is available ( #3382 )
2021-05-05 15:01:47 -04:00
Carson Sievert
3e33755a9e
Reduce complexity and 'black-boxed' nature of tab panel logic ( #3372 )
...
* Follow up to #3315 : reduce complexity and 'black-boxed' nature of tab panel logic
* asTags(selected = FALSE) is now root()
* tagAddRenderHook
* Add bslib to remotes
* Document (GitHub Actions)
* root() was recently changed to allTags()
* code review
* tagQuery() doesn't necessarily preserve order of attributes
* place href attribute before data attributes
* add nav-item/nav-link to BS4+ dropdowns
* Make sure .nav-item is removed in .dropdown-menu
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-05-05 10:05:24 -05:00
Carson Sievert
f2ad004f33
Install dev version of rlang ( #3379 )
...
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2021-05-05 10:44:19 -04:00
Carson
16e0d9e355
Comment about the hoisting
2021-05-04 14:33:54 -05:00
Carson
d430b80191
Use sendImageSize instead of Shiny.bindAll to resend CSS info
2021-05-04 14:19:40 -05:00
Carson
2ffa8707ea
Merge branch 'master' into reportCssOnLoad
2021-05-04 12:13:37 -05:00
Carson
cbd06cbd8e
Merge branch 'master' into reportCssOnLoad
2021-05-04 12:11:56 -05:00
Carson Sievert
d3aa1acfbf
Use tab instead of tooltip constructor to check Bootstrap version ( #3377 )
...
Closes https://github.com/rstudio/shinycoreci-apps/issues/138
2021-05-04 08:15:27 -05:00
Winston Chang
c2232ae07a
Merge pull request #3373 from rstudio/nested-quo-to-func
2021-04-27 12:38:33 -05:00
Winston Chang
cf0a865d6f
Remove ... args from function
2021-04-27 12:29:34 -05:00
Carson
4942b3e6ad
Add news item
2021-04-22 16:49:40 -05:00
Joe Cheng
f374a1512a
Fix rlang::inject with render functions
...
Render functions use quoToFunction() to convert quosures to
functions; quoToFunction() was using new_function, which leads
to non-tidy evaluation, so nested quosures are not evaluated.
See https://github.com/rstudio/shiny/pull/3361#issuecomment-820672180
2021-04-22 11:57:24 -07:00
Barret Schloerke
1558c848f4
Export register_devmode_option() ( #3364 )
2021-04-20 17:33:58 -04:00
Barret Schloerke
4a2bb8fc43
Add ORCID info ( #3363 )
2021-04-09 16:35:49 -04:00
Barret Schloerke
fad21af146
Make external libs builder leveraging esbuild ( #3357 )
2021-04-07 16:06:05 -04:00
Winston Chang
850a628978
Fix variable name
2021-04-06 12:52:14 -05:00
Winston Chang
4d2311841d
Merge pull request #3334 from rstudio/boostrapPageJQuery
...
bootstrapPage() now includes jQuery so static rendering works as expected
2021-04-06 12:10:12 -05:00
Winston Chang
5c4175cd5f
Merge pull request #3353 from rstudio/wch-fix-tab-title
2021-04-02 14:51:44 -05:00
Winston Chang
2931e40c7b
Update
2021-04-02 14:50:36 -05:00
Winston Chang
6a6eae1ce1
Update R/bootstrap.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2021-04-02 14:49:37 -05:00
Winston Chang
210642e96c
Update R/bootstrap.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2021-04-02 14:49:26 -05:00
Winston Chang
c97fad30ef
Fix html tags in tab titles
2021-04-02 13:27:22 -05:00
Carson Sievert
268c9afec3
Close #3299 : bootstrapLib() should always call setCurrentTheme() when shiny is running ( #3300 )
2021-03-26 15:12:54 -05:00
Carson Sievert
5c919ae565
Make ensureTabsetHasVisibleTab() is aware of BS4+ markup ( #3349 )
...
* Close https://github.com/rstudio/shinycoreci-apps/issues/126 : Make ensureTabsetHasVisibleTab() aware of BS4+ markup
* yarn build (GitHub Actions)
* Update srcts/src/main.ts
* yarn lint (GitHub Actions)
* yarn build (GitHub Actions)
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
2021-03-26 15:11:48 -05:00
Hadley Wickham
e29d92c5ff
Allow trailing commas in more places ( #3328 )
...
* Allow trailing commas in more places
I grepped for list(...) and replaced with rlang::list2(...). This also enables !!! which is generally not important for Shiny because it automatically splices lists/tagLists, but I doubt it will affect any existing code.
* update news; no need to rlang::
* missed one
* Update NEWS.md
Co-authored-by: Hadley Wickham <h.wickham@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2021-03-23 14:24:21 -05:00
Carson
0a331e3366
update news
2021-03-22 16:00:39 -05:00
Carson Sievert
32d0e146ad
Various improvements to tab panels ( #3315 )
...
* 'Native' Bootstrap 4 tabset panel support
* downgrade error to warning; improve the messaging
* Make tab anchor selectors more a bit more sensible and consistent across versions
* More of the same
* fix silly bug
* Be more careful about unpacking a .nav-item into a .dropdown-item
* Keep refactoring R logic to make it cleaner and easier to reuse elsewhere
* Go back to the purely class based CSS selectors for BS4 tab input
* Keep supporting off-label behavior of shiny.tag getting transformed into 'empty' nav/tab
* Add header and footer args to tabsetPanel()/navlistPanel() since there is precedence in navbarPage() and mention them in the warning
* Drop NULLs instead of creating an empty nav from them, closes #1928
* Remove tabPanelMenu() alias
* Add a card argument for wrapping content in a card
* Throw an error if card=T is used outside of a BS4+ context
* No more tabPanelMenu() alias
* Document (GitHub Actions)
* Port JS changes to TypeScript
* Allow liTag to be assigned a new value
* abort() is no longer being used
* Add some unit tests
* Document the new card argument
* Get tests passing on older R versions
* Get tests passing on older R versions
* Get tests passing on older R versions
* Skip snapshots on R < 3.6
* require dev version of htmltools
* remove card argument (at least for now)
* Document (GitHub Actions)
* Update tests/testthat/test-tabPanel.R
Co-authored-by: Winston Chang <winston@stdout.org >
* Have processDeps() call renderTags() on tagFunction() objects
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2021-03-22 12:37:57 -05:00
Carson
c94f411fc6
Specify both href and file
2021-03-12 17:17:01 -06:00
Carson
22d408aa7b
Close #3316 : bootstrapPage() now includes jQuery so static rendering works as expected
2021-03-12 16:50:24 -06:00
Carson
a44fdc1b11
remove logs
2021-03-11 17:01:25 -06:00
Carson
50ca830ec6
Poll every 0.1sec for 10secs
2021-03-11 16:57:20 -06:00
Carson
e643cd3824
request on next tick
2021-03-11 12:37:41 -06:00
Carson
2660a50d31
try using requestAnimationFrame
2021-03-11 11:46:17 -06:00
Carson
927912efe3
Try sending multiple times
2021-03-11 11:13:51 -06:00
Carson
9b49a24e74
Try not debouncing
2021-03-11 11:03:28 -06:00
Carson
0824b22532
Add debug statements
2021-03-11 10:49:16 -06:00
Carson
000feead00
When refreshing a stylesheet, schedule a report CSS values once the sheet is loaded
2021-03-11 09:50:49 -06:00
Winston Chang
d582e53f73
Merge pull request #3311 from rstudio/update-jquery-3.6.0
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2021-03-03 09:47:47 -06:00
Barret Schloerke
52ad7d12cb
jquery@3.6.0 is available. @types/jquery@3.6.0 is not ready yet.
2021-03-03 10:42:15 -05:00
Barret Schloerke
10810308f0
Install jquery and @types/jquery in ./srcts
2021-03-03 10:37:57 -05:00
Carson Sievert
4ce1058448
Remove old @param theme roxygen documentation and rely in @inheritParams bootstrapPage ( #3312 )
2021-03-02 16:34:35 -06:00
Winston Chang
0db06df77f
Automatically record jQuery version
2021-03-02 13:56:14 -06:00
Winston Chang
fdca53d4d2
Update to jQuery 3.6.0
2021-03-02 13:40:33 -06:00
Barret Schloerke
8395598328
🤦
2021-02-25 15:56:43 -05:00
Barret Schloerke
1b8635db32
Initialize TypeScript ( #3296 )
2021-02-25 15:44:11 -05:00
Winston Chang
60db1e02b0
Merge pull request #3269 from rstudio/read-output
...
Tweak errors when reading from outputs
2021-02-12 15:31:45 -06:00
Winston Chang
a86e9c3609
Merge pull request #3287 from rstudio/validate-req-truthy
...
Tweaks to validate(), req(), and isTruthy() docs
2021-02-12 15:09:01 -06:00
Winston Chang
6d77b22f97
Add isTruthy to pkgdown
2021-02-12 14:59:15 -06:00
Winston Chang
e1b3756166
Merge pull request #3272 from rstudio/slider-dep
...
Remove deprecated arguments to sliderInput
2021-02-12 14:35:51 -06:00
Winston Chang
edf354f416
Merge pull request #3288 from rstudio/update-fa
2021-02-10 12:06:43 -06:00
Winston Chang
954a979a83
Add note about auto-generated code
2021-02-10 12:00:59 -06:00
Winston Chang
fe9a87fb06
Update NEWS
2021-02-10 09:58:44 -06:00
Winston Chang
1842a15f74
Update to Font-Awesome 5.15.2
2021-02-10 09:57:16 -06:00
Winston Chang
a568238472
Update font-awesome update script
2021-02-10 09:56:45 -06:00
Hadley Wickham
fa200022c5
Tweaks to validate(), req(), and isTruthy() docs
...
* Use more markdown/roxygen2 tags
* Pull isTruthy out into own file
* Rewrite validate for clarity
2021-02-09 17:37:36 -06:00
Winston Chang
a6347341e3
Merge pull request #3176 from rstudio/wch-faststack
2021-02-09 14:56:13 -06:00
Winston Chang
c41481e488
Merge pull request #3285 from rstudio/dotloop-bug
...
Fix logic bug in dotloop()
2021-02-09 14:51:19 -06:00
Winston Chang
767abc3c0c
Create restoreCtxStack in .onLoad()
2021-02-09 14:46:28 -06:00
Hadley Wickham
e005c24fbf
Fix logic bug in dotloop()
...
Ensures that req() works without error
2021-02-09 13:56:09 -06:00
Winston Chang
8580f544fc
Update NEWS
2021-02-09 11:57:25 -06:00
Winston Chang
2daa8ec944
Replace queues with fastqueue
2021-02-09 11:57:25 -06:00
Winston Chang
2b92014ea5
Use fastmap::faststack() and remove Stack
2021-02-09 11:57:19 -06:00
Winston Chang
f540679513
Merge pull request #2954 from rstudio/remove-test-context
...
Remove context() calls from example app
2021-02-09 11:54:22 -06:00
Shinya Uryu
d165cc6e8e
Typo ( #3283 )
2021-02-05 08:43:13 -06:00
Winston Chang
c1878fe54f
Merge pull request #3278 from rstudio/wch-fix-test
2021-02-02 11:01:07 -06:00
Winston Chang
f05948629e
Adjust test time
2021-02-01 21:10:52 -06:00
Winston Chang
3e37dab4a1
De-functionize tests
2021-02-01 19:02:18 -06:00
Winston Chang
6584e1f960
Recommend using bindEvent() ( #3277 )
2021-02-01 18:11:30 -06:00
Hadley Wickham
64c5a67a0e
Use testthat 3e ( #3274 )
2021-01-29 10:34:14 -06:00
Barret Schloerke
aea4e560ea
Display devmode in docs ( #3275 )
2021-01-29 11:32:34 -05:00
Winston Chang
12554a0004
Add info about render functions with bindCache
2021-01-29 09:53:58 -06:00
Barret Schloerke
83336ef9a5
Update bootstrap-accessibility plugin ( #3259 )
...
* Copy from installed bslib location, no relative file path
* Adopt the fix from https://github.com/rstudio/bslib/pull/241
Co-authored-by: Carson <cpsievert1@gmail.com >
2021-01-27 09:39:10 -06:00
Hadley Wickham
08ab21b50e
Remove deprecated arguments to sliderInput
2021-01-27 08:42:28 -06:00
Hadley Wickham
5628346ae1
Tweak errors when reading from outputs
2021-01-26 13:00:18 -06:00
Winston Chang
b165127d20
Merge pull request #3268 from rstudio/dt-docs
2021-01-26 12:49:23 -06:00
Hadley Wickham
905e2238d4
Drop tableOutput from ref index
2021-01-26 12:47:30 -06:00
Hadley Wickham
47bb1f657c
Doc fixes
2021-01-26 12:47:30 -06:00
Hadley Wickham
c917d18d67
Improve table output docs
...
* Combine render + output functions in one file
* Put more info in the description
* Mild polishing of param docs
2021-01-26 12:47:30 -06:00
Winston Chang
93568cd53f
Merge pull request #3264 from rstudio/wch-rm-digest
2021-01-26 10:22:35 -06:00
Winston Chang
6af06559f4
Update NEWS
2021-01-26 09:36:30 -06:00
Winston Chang
43239a0485
Use rlang::hash instead of digest
2021-01-26 09:36:30 -06:00
Winston Chang
e05f4097d6
Merge pull request #3267 from rstudio/slider-docs
2021-01-26 09:35:37 -06:00
hadley
35e62eaee9
yarn build (GitHub Actions)
2021-01-26 13:52:12 +00:00
Hadley Wickham
858c2e66e6
Clarify supported types in sliderRange()
2021-01-26 07:35:36 -06:00
Winston Chang
0d156171d4
Bump version to 1.6.0.9000
2021-01-25 15:56:38 -06:00
Winston Chang
b57cb6c8e1
Fix URLs
2021-01-19 11:15:00 -06:00
Carson
5ddff1bd37
Merge branch 'master' into rc-v1.6.0
2021-01-15 14:46:44 -06:00
Carson Sievert
036f923e05
Run accessiblity plugin JS when DOM is loaded (via defer attribute) a… ( #3256 )
...
* Use bslib's patched version of bootstrap-accessibility plugin (see https://github.com/rstudio/bslib/pull/224 )
* Use new minified file
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2021-01-15 14:43:00 -06:00
Carson Sievert
130f4764a7
Documentation improvements for v1.6 ( #3255 )
2021-01-14 10:35:00 -06:00
Carson
c4b5e5f8a2
Merge branch 'master' into rc-v1.6.0
2021-01-13 14:23:56 -06:00
Barret Schloerke
ecb21df941
Use url checker ( #3249 )
...
* Update rituals.yaml
* update docs links
* Fix 404 link
* http://fontawesome.io to https://fontawesome.com
* Update links (GitHub Actions)
* Update NEWS.md
* Only check urls in rc branches
* missing paren
Co-authored-by: schloerke <schloerke@users.noreply.github.com >
2021-01-13 14:18:12 -06:00
Barret Schloerke
71d11ec103
Merge branch 'master' into rc-v1.6.0
...
* master:
Reduce promises version to 1.1.0 and safeguard visibility test (#3252 )
2021-01-12 13:31:09 -05:00
Barret Schloerke
213f0d3a93
Reduce promises version to 1.1.0 and safeguard visibility test ( #3252 )
2021-01-12 12:29:18 -06:00
Carson
8948eca0f3
Use checkJsCurrent.sh to rebuild JS
2021-01-08 14:37:39 -06:00
Carson
aa0c841aff
Close #3244 : sliderInput()'s handles are now always round
2021-01-08 14:22:14 -06:00
Carson
a8449382f0
Start shiny v1.6 release candidate
2021-01-05 13:52:16 -06:00
Carson Sievert
5b27d9258e
Don't change the return value of bootstrapPage() if bslib isn't relevant ( #3236 )
...
* Close #3235 : Don't change the return value of bootstrapPage() if bslib isn't relevant
Also, improved error message if theme is a character vector with 2 or more elements
* yarn build (GitHub Actions)
* bump version
* yarn build (GitHub Actions)
* Don't add an additional level to the returned tree structure
* More straightforward use of do.call()
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2021-01-05 13:21:38 -06:00
Winston Chang
2590cf3895
Drop GHA pr-commands and add GHA Rituals. Use pak to install ( #3230 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2020-12-28 13:28:38 -05:00
Nick Strayer
a9f7068b2f
bindCache() docs typos ( #3232 )
...
* vert -> very
* cachem::cache_mem() uses max_size argument to set size.
* Rebuilt docs after cache typo fixes
* Rerender docs with new roxygen version
* Installed cairo and rebuilt docs
2020-12-23 17:14:57 -06:00
Carson Sievert
1f9e4929a6
Follow up to #3228 . shinyAppDir() now throws a classed condition when appDir is not a directory ( #3229 )
2020-12-23 10:20:48 -06:00
Carson Sievert
d56afca33e
shinyAppDir() now throws an exception with a special class if no app.R/server.R file is found. ( #3228 )
...
shinytest:::is_app() can make use of this for better error reporting
2020-12-22 10:41:55 -06:00
Carson Sievert
8fa023b4ec
Closes #223 : Add selectize patch file to capture changes from #3217 ( #3227 )
2020-12-21 11:06:35 -06:00
Winston Chang
d9f73c4c6d
Merge pull request #3212 from rstudio/wch-fix-selectize-enter
2020-12-21 10:42:55 -06:00
Winston Chang
68cf1c5410
Check for empty list
2020-12-21 10:40:24 -06:00
Winston Chang
a70220c6c4
Rebuild JS file
2020-12-19 23:02:20 -06:00
Winston Chang
99207d1d8f
Simplify handling of empty options
2020-12-19 23:02:20 -06:00
Winston Chang
0baf2ecd70
Apply patches
2020-12-19 23:02:20 -06:00
Winston Chang
2c6f830223
Add patch for not triggering click on selectize
2020-12-19 23:02:20 -06:00
Winston Chang
98eb1b596d
Update selectize-plugin-a11y comments
2020-12-19 23:02:20 -06:00
Winston Chang
145d222653
Add webdriver to remotes
2020-12-19 22:57:46 -06:00
Winston Chang
67e54572a8
Rebuild JS files
2020-12-19 22:52:01 -06:00
Winston Chang
3cc9b33a8d
yarn upgrade
2020-12-19 22:51:24 -06:00
Barret Schloerke
12bc94fbc0
bump dev version to 1.5.0.9006 ( #3221 )
2020-12-19 16:32:22 -06:00
Winston Chang
b2379bfa5b
Cache packages on Windows
2020-12-19 13:41:06 -06:00
Barret Schloerke
f4fc13fc2f
Add devmode() features ( #3174 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-18 14:31:31 -05:00
Nick Strayer
95081c43a7
Make sure setCurrentTheme() doesn't try and change bootstrap versions ( #3210 )
...
* Added check to make sure setCurrentTheme() doesn't try and change bootstrap version
* Update R/shiny.R
Style improvements via Carson
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Update error message to be more specific
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Make it clearer where the new bs_theme() call should be made.
* Add a check to make sure setCurrentTheme() receive a bs_theme() object
Co-authored-by: Nick Strayer <nick.strayer@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-12-18 13:28:16 -06:00
Winston Chang
bb3b3d5a47
Use rlang from CRAN
2020-12-18 12:39:29 -06:00
Carson Sievert
f635f98ccb
Put pre-Chromium Edge in the same category as IE ( #3220 )
...
* Put pre-Chromium Edge in the same category as IE, closes #3219
* code review
2020-12-18 12:08:50 -06:00
Carson Sievert
eef44295db
Close #3215 , selectize's active item fg color now uses bslib's color-contrast() for more generalized contrasting ( #3217 )
2020-12-18 12:01:44 -06:00
Barret Schloerke
5e1afc61c1
Update private$currentThemeDependency label to be Theme Counter ( #3206 )
...
* Update `private$currentThemeDependency` label to be `Theme Iteration`
* Update R/shiny.R
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-16 15:31:50 -06:00
Carson Sievert
8edcbb3dc1
Revert "Make .shiny-text-output more aware of Bootstrap's pre styles ( #3203 )" ( #3209 )
...
This reverts commit 4eeb4a12a7 .
This change was superfluous given that bslib's bs3compat CSS will provide <pre> styles and reduces the risk of overriding user rules targetting .shiny-text-output (https://github.com/rstudio/shinycoreci-apps/issues/95 )
2020-12-16 13:41:01 -06:00
Malcolm Barrett
dca3722cb8
fix typo in docs ( #3204 )
...
Co-authored-by: runner <runner@Mac-1607960235106.local >
2020-12-16 13:37:16 -06:00
Stéphane Guillou
7eb0e93731
typos in documentation ( #3205 )
...
Co-authored-by: runner <runner@Mac-1607961254343.local >
2020-12-16 13:36:32 -06:00
Carson Sievert
6034c3ff7a
Resend CSS styles when relevant element(s) mutate. ( #3198 )
2020-12-16 11:59:37 -06:00
Carson Sievert
4eeb4a12a7
Make .shiny-text-output more aware of Bootstrap's pre styles ( #3203 )
2020-12-11 18:55:27 -06:00
Winston Chang
6daa689888
Merge pull request #3201 from rstudio/wch-fix-datepicker
2020-12-11 15:51:46 -06:00
Winston Chang
cded44b40a
Update NEWS
2020-12-11 15:51:08 -06:00
Winston Chang
290c9f6b20
Rebuild JS files
2020-12-11 15:51:08 -06:00
Winston Chang
be3d712fdf
Set min/max date before setting value. Closes #3197
2020-12-11 15:51:08 -06:00
Winston Chang
f5666bcba1
Respect shiny.minified for bootstrap-datepicker.js
2020-12-11 10:02:01 -06:00
Winston Chang
f3c89bed01
Merge pull request #3199 from rstudio/fix-session-validate
...
Co-authored-by: Carson <cpsievert1@gmail.com >
2020-12-10 18:06:12 -06:00
Carson
9b0f170730
Skip POSIXlt slider tests on R3.6 and below
2020-12-10 15:24:07 -06:00
Winston Chang
74350cd443
Update NEWS
2020-12-10 12:28:46 -06:00
Winston Chang
61aa7bb3b0
validate_session_object: Also work with modules
2020-12-10 12:25:30 -06:00
Winston Chang
82fdbeda49
Fix test
2020-12-10 12:25:12 -06:00
Winston Chang
196b220faf
All session parameters from the update* functions now default to getDefaultReactiveDomain() ( #3195 )
...
Co-authored-by: colin <colin@thinkr.fr >
2020-12-08 12:18:37 -06:00
Hadley Wickham
f41c484913
Respect reactiveConsole() in new errors ( #3193 )
2020-12-08 12:17:43 -06:00
Carson Sievert
a1a20b3f4b
Add NEWS notes for #3042 and #3038 ( #3191 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-08 10:59:23 -06:00
Winston Chang
bbf9bee28e
Add a warning message when value < min | value > max in sliderInput ( #3194 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: colin <colin@thinkr.fr >
Co-authored-by: Colin Fay <contact@colinfay.me >
2020-12-08 10:55:18 -06:00
Winston Chang
24a1ef9594
Clear selected date if not within min/max range ( #3188 )
2020-12-07 09:13:48 -06:00
Carson Sievert
c5adef0a05
Add 'auto' brush fill and stroke ( #2864 )
...
* Add 'auto' brush fill and stroke
* getStyle() from utils
* Update getThematicOption()
* Use getThematicOption() helper in startPNG(), too
2020-12-04 16:49:08 -06:00
Carson Sievert
508c197446
getCurrentOutputInfo() bugfix ( #3189 )
2020-12-04 16:38:48 -06:00
Carson Sievert
473ec834fe
radioButtons() and checkboxGroup() accessibility ( #3187 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: JooYoung Seo <sjysky@gmail.com >
2020-12-04 15:53:53 -06:00
Carson Sievert
66968904bf
Cleaner logic for conditional CSS styles ( #2671 )
...
* Cleaner logic for conditional CSS styles
It's really only plotOutput() that behaves differently;
previously it was not possible to specify a NULL width
or height and not get broken styles
* require dev version of htmltools
Co-authored-by: Joe Cheng <joe@rstudio.com >
2020-12-04 15:52:50 -06:00
Hadley Wickham
f169792e59
Experiment with error message ( #3007 )
2020-12-04 14:20:30 -06:00
Winston Chang
39a23af138
Merge pull request #3038 from rstudio/carson/bugfix/dateInput
2020-12-04 13:36:38 -06:00
Winston Chang
d8715819dc
Build JS files
2020-12-04 13:27:51 -06:00
Carson
12444807e8
Better setting of bootstrap-datepicker start/end dates, closes #2703
2020-12-04 13:27:13 -06:00
Winston Chang
92077d47a1
Merge pull request #3042 from rstudio/carson/feature/aria-live
2020-12-04 13:08:03 -06:00
Winston Chang
4f54276e1b
yarn build
2020-12-04 13:07:38 -06:00
Carson
ac30848019
Also default to aria-live='polite' when input bindings are about to receiveMessage
2020-12-04 13:07:11 -06:00
Carson
921650f53b
When binding shiny outputs, have the 'aria-live' attribute default to 'polite', closes #2987
2020-12-04 13:07:11 -06:00
Winston Chang
72d81e8a85
Add label to private$currentThemeDependency
2020-12-04 12:32:55 -06:00
Carson Sievert
5c5974106d
Properly attach jqueryui dependency when drag_drop plugin is used ( #3185 )
...
* Properly attach jqueryui dependency when drag_drop plugin is used, closes #3183
* write a unit test
2020-12-04 10:52:26 -06:00
Winston Chang
c2cbd3a127
Create session$currentThemeDependency only when needed ( #3182 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-12-04 09:47:18 -06:00
Winston Chang
8e5aedec00
Do correct assignment of resizeObserverCreated ( #3177 )
2020-12-04 08:58:52 -06:00
Winston Chang
13965acb37
getCurrentOutputInfo(): only create reactives when needed ( #3180 )
2020-12-03 17:16:33 -06:00
Winston Chang
8a99b9d401
Add label to reactive
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-12-03 17:09:30 -06:00
Carson Sievert
f739a1d476
Set resolve = FALSE when getting thematic's bg option ( #3178 )
2020-12-03 17:02:12 -06:00
Winston Chang
87dd00be13
getCurrentOutputInfo(): only create reactives when needed
2020-12-03 16:15:04 -06:00
Winston Chang
8cd393597a
Remove old note about Bootstrap 3
2020-12-03 09:09:27 -06:00
Winston Chang
b7366ef672
Remove outdated comments
2020-12-02 20:56:33 -06:00
Winston Chang
3d6329dee8
Add cacheWriteHook and cacheReadHook ( #3173 )
2020-12-02 16:17:08 -06:00
Winston Chang
2171420e0c
Fix NA check
2020-12-02 16:03:07 -06:00
Winston Chang
e44a9b1ded
Replace %OR% with %||% from rlang ( #3172 )
2020-12-02 12:14:07 -06:00
Winston Chang
bde5a88295
Fix test
2020-12-01 13:18:59 -06:00
Carson Sievert
11babd5567
Improve color contrasting in date and slider input ( #3167 )
...
* leverage bslib's color-contrast() in sliderInput()'s Sass and reduce number of git patches
* Use color-contrast() instead of color-yiq() in Bootstrap Datepicker
2020-11-25 11:39:00 -06:00
Carson Sievert
4c35d483bc
Wait longer to disable old stylesheets ( #3168 )
2020-11-25 11:13:18 -06:00
Carson Sievert
d049558728
shinyAppTemplate()'s shinytest tests should be calling expect_pass() ( #2943 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-11-24 14:34:45 -06:00
Carson Sievert
8eed42387c
Make sure dateInput() warns on empty string ( #3165 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-11-24 10:34:39 -06:00
Winston Chang
5b3366f35a
Replace renderCachedPlot() code with bindCache() ( #3163 )
2020-11-23 14:34:52 -06:00
Winston Chang
fea7397c3b
Merge pull request #3160 from rstudio/wch-bindevent-reactlog
2020-11-23 11:05:25 -06:00
runner
4a33582482
Document
2020-11-23 14:49:22 +00:00
Winston Chang
1bad0553b7
Fix labels for eventReactive
2020-11-20 15:46:18 -06:00
Winston Chang
ac0b723bb0
bindEvent(): alter observers in place and fix labels
2020-11-20 14:51:35 -06:00
Winston Chang
39454a6c09
Use enquos0, inject, and zap_srcref from rlang ( #3157 )
2020-11-20 11:07:06 -06:00
Winston Chang
569157aded
Add reactive session$getCurrentTheme() ( #3116 )
...
Co-authored-by: Carson <cpsievert1@gmail.com >
2020-11-20 10:54:51 -06:00
Carson Sievert
d2d7770c76
require newest bslib version, follow up to #3155 ( #3159 )
2020-11-20 10:01:59 -06:00
Carson Sievert
5da846f1ce
Always ship selectize HTML dependencies with name='selectize', closes #3125 ( #3155 )
2020-11-20 09:46:08 -06:00
Winston Chang
713c9ec923
Add render function quosure tests
2020-11-20 09:38:16 -06:00
Winston Chang
b3369616d2
bindCache: accept cache arg when used with renderPlot
2020-11-19 15:14:10 -06:00
Winston Chang
082b8ef080
bindCache: add documentation about renderPlot
2020-11-19 15:13:39 -06:00
Hadley Wickham
0fb9226a9b
Minor bindCache doc tweaks ( #3156 )
2020-11-19 15:04:26 -06:00
Winston Chang
bb55f45d94
More bindCache documentation edits
2020-11-18 13:21:03 -06:00
Winston Chang
5b12980b7a
Update bindEvent documentation
2020-11-18 12:39:20 -06:00
Winston Chang
493ef59dda
Update bindCache documentation
2020-11-18 12:37:06 -06:00
Barret Schloerke
b42d835cbf
Test visibility with latest promises ( #3151 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-11-18 11:36:28 -06:00
Winston Chang
d1d177f80f
Merge pull request #3149 from rstudio/wch-plot-cache
2020-11-17 21:57:46 -06:00
Winston Chang
433e5814ed
Add note about cleanup
2020-11-16 14:09:11 -06:00
Winston Chang
2bf9f42b49
Better cacheHint for renderPlot
2020-11-16 13:47:46 -06:00
Winston Chang
65efb573bd
Hoist attributes when wrapping render functions
2020-11-16 13:12:27 -06:00
Winston Chang
26a701215d
Cleaner way to pass in fitDims to renderPlot function
2020-11-16 12:08:22 -06:00
Winston Chang
3be7a20f40
Use enquos0
2020-11-16 11:00:27 -06:00
Winston Chang
6f8092f5a4
bindCache.shiny.renderPlot: Draw plot at size specified by sizePolicy()
2020-11-16 11:00:27 -06:00
Winston Chang
652fcfe799
First implementation of bindCache() for renderPlot()
2020-11-16 10:59:25 -06:00
Winston Chang
d7d03ee6a8
Convert ... to quosures
2020-11-16 10:59:25 -06:00
Winston Chang
dc6335ed4d
Round pixelratio to two decimals ( #3147 )
2020-11-16 10:06:38 -06:00
Winston Chang
b421f6bd7f
Destroy correct object. Closes #3145
2020-11-13 19:30:13 -06:00
Winston Chang
d4358e0793
Fix renderCachedPlot expression handling
2020-11-13 17:53:55 -06:00
Winston Chang
a8dfa0771f
Merge pull request #3144 from rstudio/wch-non-quosure
2020-11-13 17:08:41 -06:00
Winston Chang
6df3ce4b19
Rename blast() to inject()
2020-11-13 15:13:33 -06:00
Winston Chang
8f40f8cab8
Add additional quosure tests
2020-11-13 15:11:18 -06:00
Winston Chang
0d5a2cee58
Use brackets
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-11-13 15:04:11 -06:00
Winston Chang
8db4f41fa9
Update bindCache documentation
2020-11-13 15:03:17 -06:00
Winston Chang
b85b03583b
Add cache hint tests
2020-11-13 14:56:25 -06:00
Winston Chang
28e18fe87b
Update examples
2020-11-13 13:45:48 -06:00
Dean Attali
2c1961acd7
added ... support to icon(); fixes #3140 ( #3143 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-11-13 13:25:03 -06:00
Winston Chang
04386f1a5e
reactivePoll: store environment
2020-11-13 13:11:35 -06:00
Winston Chang
9c915e52ca
Add get_quosure function
2020-11-12 23:45:23 -06:00
Winston Chang
6b6ab48377
Don't unwrap quosures for key or event expressions
2020-11-12 22:16:00 -06:00
Winston Chang
bf36d07670
Add tests for quosures in reactive() and observe()
2020-11-12 18:17:02 -06:00
Winston Chang
7166192143
Bump rlang version dependency
2020-11-12 17:57:04 -06:00
Winston Chang
509f0790db
Reactive functions don't unwrap quosures automatically
2020-11-12 17:10:49 -06:00
Winston Chang
67a776a39a
Don’t automatically unwrap quosures
2020-11-12 16:57:05 -06:00
Winston Chang
d3701df4e6
Safer method for remove_source
2020-11-12 16:57:05 -06:00
Carson Sievert
0195e34a7b
pre.shiny-text-output shouldn't set border-radius by default ( #3142 )
2020-11-12 15:31:04 -06:00
Winston Chang
0aa49c8a93
Rebuild shiny.js
2020-11-10 14:16:43 -06:00
Winston Chang
437de58922
Remove source refs for nested functions
2020-11-09 16:23:28 -06:00
Winston Chang
fc76cf21fb
Merge pull request #3127 from rstudio/with-cache-event
2020-11-09 13:31:08 -06:00
Winston Chang
23d1b25c46
Bump version to 1.5.0.9005
2020-11-09 13:16:02 -06:00
Winston Chang
8bfb59875f
Temporarily disable deprecatedEnvQuotedMessage
2020-11-09 13:10:51 -06:00
Winston Chang
36e866743d
Documentation fixes
2020-11-09 11:00:13 -06:00
Winston Chang
d35c6e35ce
Use is_false function
2020-11-09 10:55:17 -06:00
Winston Chang
e9afd8c99e
bindCache documentation updates
2020-11-09 10:52:19 -06:00
Winston Chang
43b7c41c4f
Rename withCache and withEvent to bindCache and bindEvent
2020-11-08 21:47:11 -06:00
Winston Chang
921f60475e
Update withEvent help
2020-11-06 15:33:01 -06:00
Winston Chang
58433cda01
Add tests for ignoreNULL
2020-11-06 14:20:20 -06:00
Winston Chang
ed5eca5496
withEvent: invoke render function with ...
2020-11-06 14:19:59 -06:00
Winston Chang
eff4a1f23e
Add cache hint to reactive expressions
2020-11-06 12:41:57 -06:00
Carson Sievert
9f72b15fcf
Resend CSS info (via bindAll) when a restyle (i.e., setCurrentTheme()) happens, closes #3119 ( #3134 )
2020-11-05 18:03:21 -06:00
Winston Chang
8069ff2b05
Fixes for tests
2020-11-05 17:02:56 -06:00
Winston Chang
10deddf2f0
Export quoToFunction
2020-11-05 16:57:35 -06:00
Winston Chang
3ad1c4076d
Make renderCachedPlot accept quosures
2020-11-05 16:37:48 -06:00
Winston Chang
943f31e117
Fix cacheHint=FALSE
2020-11-05 16:37:18 -06:00
Winston Chang
c43bc195e7
Use cacheHint
2020-11-05 14:25:19 -06:00
Winston Chang
92b1e8f256
Fixes for withCache and render functions
2020-11-05 09:20:23 -06:00
Winston Chang
985970d320
Include user expression in cache key for render functions
2020-11-04 18:07:26 -06:00
Winston Chang
5eabaa5207
Allow render functions to accept quosures
2020-11-04 18:07:08 -06:00
Carson Sievert
7f60ecc725
Have slider's fg/bg defaults fallback to body colors if input colors are transparent, closes #3130 ( #3131 )
...
* Have slider's fg/bg defaults fallback to body colors if input colors are transparent, closes #3130
* Add comment
* Rename
2020-11-04 17:59:02 -06:00
Winston Chang
7c635e1283
Remove unused function
2020-11-04 12:53:50 -06:00
Carson Sievert
4727a7adf4
rename bootstraplib package to bslib ( #3132 )
2020-11-04 11:50:55 -06:00
Winston Chang
8940f14dde
Fixes for R CMD check
2020-11-03 14:59:08 -06:00
Winston Chang
2fd0ce1a09
Add withEvent observer tests
2020-11-03 13:35:08 -06:00
Winston Chang
638bcc0f85
Mark some render functions as uncacheable
2020-11-03 13:12:23 -06:00
Winston Chang
d411da3114
Fix variable names
2020-11-03 13:04:11 -06:00
Winston Chang
0acae46835
Document withCache
2020-11-03 13:04:10 -06:00
Winston Chang
61cc61d9aa
Add methods for withEvent and withCache
2020-11-03 13:03:35 -06:00
Winston Chang
194320d163
Remove cachedReactive()
2020-11-03 13:03:33 -06:00
Winston Chang
902bfb8628
Convert observeEvent and eventReactive to use withEvent
2020-11-03 13:02:57 -06:00
Winston Chang
b25d72f698
Streamline reactive() and observe()
2020-11-03 13:02:57 -06:00
Winston Chang
a4d8f541dd
Fix test
2020-11-03 13:02:57 -06:00
Winston Chang
6aaf2ff4d5
Add withEvent.Observer
2020-11-03 13:02:57 -06:00
Winston Chang
b0f77d6591
Store original function as attribute on wrapper
2020-11-03 13:02:57 -06:00
Winston Chang
f2885dafd2
Add functions for extracting parts out of reactive expressions
2020-11-03 13:02:57 -06:00
Winston Chang
b0725e0153
Add withCache and withEvent functions
2020-11-03 13:02:49 -06:00
Winston Chang
4ce62034ce
Convert reactive() and observe() to accept quosures
2020-11-03 13:01:27 -06:00
Winston Chang
7d4c0ad611
Remove extra argument
2020-11-03 13:01:17 -06:00
Winston Chang
d189cd9f23
Use cache objects from cachem package ( #3118 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-11-03 12:01:17 -06:00
Winston Chang
f61ba70bb9
Merge pull request #3094 from rstudio/reactive-cached
2020-10-29 11:26:26 -05:00
Winston Chang
6e48692637
More code review changes
2020-10-29 11:13:22 -05:00
Winston Chang
f7b1bc0e5c
Move key after ...
2020-10-29 10:19:16 -05:00
Winston Chang
a213d6f7e1
Increase size of diskCache
2020-10-29 10:16:07 -05:00
Winston Chang
a7d793ecf9
Code review feedback
2020-10-29 10:13:39 -05:00
Winston Chang
5d25481f66
Add remove_srcref for R<3.6
2020-10-29 10:13:10 -05:00
Winston Chang
77a8a783de
cachedReactive: add tests for quosures
2020-10-28 20:11:03 -05:00
Winston Chang
0492eb7958
Update cachedReactive docs about cache collisions
2020-10-28 19:28:06 -05:00
Winston Chang
d37feea299
Rename args for cachedReactive
2020-10-28 19:16:12 -05:00
Winston Chang
ffb9ad2094
Merge pull request #3113 from rstudio/wch-fix-options-modules
2020-10-28 15:22:02 -05:00
Winston Chang
1e63dfc4c5
Bump recursion depth to 20
2020-10-28 15:15:12 -05:00
Winston Chang
051cc51d4b
Handle shinyOptions in nested modules
2020-10-28 13:58:17 -05:00
Carson Sievert
56dd92fee8
Register all theme dependencies to be processes since _new_ HTML dependencies may be added to the theme object ( #3115 )
2020-10-28 13:58:07 -05:00
Winston Chang
51b835b57f
Merge pull request #3114 from rstudio/wch-warn-package
2020-10-27 21:19:40 -05:00
Winston Chang
ccd7342986
Check for NAMESPACE file
2020-10-27 15:33:23 -05:00
Winston Chang
82decaa070
Fix use of shinyOptions in modules
2020-10-27 15:15:23 -05:00
Winston Chang
d1e808d090
Update NEWS
2020-10-27 15:12:27 -05:00
Winston Chang
7aad389338
Warn when running app in a R package directory
2020-10-27 15:12:24 -05:00
Winston Chang
7e07c460de
Rebuild shiny.min.css
2020-10-27 14:07:24 -05:00
Carson Sievert
81a8ec3ce1
pre.shiny-text-output should have a border-radius set by default ( #3111 )
2020-10-23 13:20:25 -05:00
Carson Sievert
800f0a216d
Get session$setCurrentTheme() working on IE11 & improve timing of disabling old stylesheets ( #3097 )
...
* disable stylesheet on next tick to avoid FOUC
* fix regex matching logic
* Avoid regex and remove stylesheet's ownerNode after disabling
* Use inline <style> as opposed to <link> tags when restyling for IE11 compatibility
* Be more careful to avoid possibility of removal modifying styleSheets
* Use inline <style> for IE; otherwise update the <link>
* Update srcjs/output_binding_html.js
Co-authored-by: Winston Chang <winston@stdout.org >
* Update browser.js to correctly detect IE11
* remove redundant if statements
Co-authored-by: Winston Chang <winston@stdout.org >
2020-10-23 11:06:42 -05:00
Winston Chang
dade7dc069
Increase default memory and disk cache size
2020-10-23 00:38:20 -05:00
Winston Chang
b271d0a9a2
Add valueExpr to cache key
2020-10-23 00:36:18 -05:00
Winston Chang
5daa0bc38e
Handle future objects
2020-10-22 20:06:03 -05:00
Winston Chang
22665dc9b4
cachedReactive: add label arg
2020-10-22 16:00:41 -05:00
Winston Chang
a99f11fb10
Extract reactive label code into exprToLabel()
2020-10-22 15:58:50 -05:00
Winston Chang
81824575e6
Use consistent interface for preserving visibility
2020-10-22 00:01:32 -05:00
Winston Chang
f6d010056a
Skip visibility tests with old versions of rlang
2020-10-21 23:50:24 -05:00
Winston Chang
ffd20bcc6e
hybrid_chain: preserve visibility
2020-10-21 23:50:24 -05:00
Winston Chang
55eaaa869d
Cache errors and visibility
2020-10-21 18:22:33 -05:00
Winston Chang
c2e66ca474
Split setVisible into two functions
2020-10-21 14:57:02 -05:00
Winston Chang
62b848c2e2
Throw error if no cache object
2020-10-21 14:55:48 -05:00
Winston Chang
dbb657bd91
Merge pull request #3091 from rstudio/carson/feature/border-radius
2020-10-21 09:30:50 -05:00
Winston Chang
de871b79b0
Use ellipsis to check for empty args
2020-10-20 21:19:14 -05:00
Winston Chang
146a6d459d
Rebuild docs
2020-10-20 21:18:58 -05:00
Winston Chang
9fb1dd18a7
Mention quosures
2020-10-20 21:11:04 -05:00
Winston Chang
9ae894d9e3
Use spookyhash
2020-10-20 21:08:27 -05:00
Winston Chang
56e0fbdb05
Update tests for cachedReactive
2020-10-20 21:04:40 -05:00
Winston Chang
e6325629a9
Add eventExpr to cachedReactive()
2020-10-20 21:04:03 -05:00
Carson
9a3329acc7
yarn build
2020-10-20 18:13:55 -05:00
Carson
75ab225d84
Make sure shiny.scss can be compiled without Bootstrap
2020-10-20 18:09:41 -05:00
Carson
883668ac93
Use Bootstrap's border-radius mixin (mainly so BS4's enable-rounded works as expected)
2020-10-20 18:06:56 -05:00
Winston Chang
c5f2dece49
Specify UTF-8 encoding for error page
...
This supersedes PR #3039
2020-10-20 14:35:04 -05:00
Winston Chang
b55bc5318e
Add cachedReactive example with actionButton
2020-10-16 15:59:40 -05:00
Winston Chang
a39450c2b2
Add tests for cachedReactive error handling
2020-10-16 15:26:58 -05:00
Winston Chang
b784068701
More documentation for cachedReactive
2020-10-15 18:58:41 -05:00
Winston Chang
bac4e68b89
Add support for async in cachedReactives
2020-10-15 17:19:34 -05:00
Winston Chang
20e95a4cab
Add tests for cachedReactive
2020-10-15 17:19:34 -05:00
Winston Chang
96da457db3
Add cachedReactive
2020-10-15 17:19:34 -05:00
Winston Chang
37b8715cff
Move resolve_cache_object out of renderCachedPlot
2020-10-15 17:19:34 -05:00
Barret Schloerke
7aa3a243ba
Make template test less brittle and failures more verbose ( #3096 )
...
Also updated a pkgdown check
2020-10-15 11:32:50 -04:00
Winston Chang
f2b549f9cd
Merge pull request #3095 from rstudio/get_option_null
2020-10-14 15:55:46 -05:00
Barret Schloerke
bc58dba0ad
Add list default to getShinyOption("themeDependencyFuncs") call
...
Does NOT work on R <= v3.6.3
```r
x <- NULL
x[[length(x) + 1]] <- identity
```
2020-10-14 16:24:22 -04:00
Barret Schloerke
8ef9be5290
Explicitly state the default value in getShinyOption(x, default) calls
2020-10-14 16:23:07 -04:00
Winston Chang
d95560db09
Merge pull request #3085 from rstudio/carson/feature/restyle
2020-10-14 10:17:51 -05:00
Winston Chang
98f64df738
Dependency fixes
2020-10-14 10:06:42 -05:00
Winston Chang
8634e372da
bs_dependency_dynamic -> bs_dependency_defer
2020-10-14 09:42:16 -05:00
Winston Chang
cbda7633e0
Update MockShinySession
2020-10-13 16:00:15 -05:00
Winston Chang
8f00cf50ca
Fix typo
2020-10-13 15:57:52 -05:00
Winston Chang
acca28075b
Merge branch 'master' into carson/feature/restyle
...
Also rebuild shiny.js
2020-10-13 15:56:53 -05:00
Winston Chang
9a563463dd
Add namespacing for bs_dependency()
2020-10-13 15:32:00 -05:00
Winston Chang
1ede94b09e
Remove registerThemeDependency from pkgdown
2020-10-13 15:30:56 -05:00
Winston Chang
7f41a54c4e
Move bootstraplib to Imports
2020-10-13 14:49:51 -05:00
Winston Chang
6cfab79ce9
Make setCurrentTheme() a ShinySession method
2020-10-13 14:47:40 -05:00
Carson Sievert
f33b3c7eef
Update R/bootstrap.R
2020-10-13 14:15:12 -05:00
Carson
93d78ae2b0
prevent caching on restyle and account for fact that href may include hostname
2020-10-13 12:37:02 -05:00
Winston Chang
c498b02289
textAreaInput() doesn't work as expected for relative width (#2049 )
...
Squashed commit of the following:
commit a823dd5d7da6fafba69f783e112d71d9dcd09c5f
Author: Winston Chang <winston@stdout.org >
Date: Mon Oct 12 12:59:41 2020 -0500
Remove trailing whitespace
commit ae55b519fb0f7d97f559e2f487063366926aa41d
Author: Winston Chang <winston@stdout.org >
Date: Mon Oct 12 12:52:04 2020 -0500
Move NEWS item to correct location
commit aa89abc247be1bf5cdf093ff7fe7c51711821438
Merge: ee98773f a1ff7652
Author: Winston Chang <winston@stdout.org >
Date: Mon Oct 12 12:47:21 2020 -0500
Merge branch 'master' into shrektan-textarea-style
commit ee98773f1d
Author: shrektan <shrektan@126.com >
Date: Sat Aug 24 10:35:23 2019 +0800
correct the NEWS entry
commit b468d8f013
Author: shrektan <shrektan@126.com >
Date: Sat Aug 24 10:32:52 2019 +0800
the width of textarea should be specified in the parent div.
commit 5abdcf9260
Merge: 03079f0a b07e553b
Author: shrektan <shrektan@126.com >
Date: Sat Aug 24 09:54:27 2019 +0800
resolve conflicts
Merge remote-tracking branch 'origin/master' into textarea-style
# Conflicts:
# R/input-textarea.R
commit 03079f0a14
Author: shrektan <shrektan@126.com >
Date: Mon May 7 16:08:05 2018 +0800
Fixed a bug that `textAreaInput()` doesn't work as expected for relative `width`.
2020-10-12 13:01:44 -05:00
Winston Chang
30b62e6f18
Update bootstrap dependency code
2020-10-09 17:57:50 -05:00
Barret Schloerke
ec18ef651b
Add missing space for html lang ( #3093 )
...
Followup from https://github.com/rstudio/shiny/pull/3087
2020-10-08 11:02:55 -04:00
Joe Cheng
aad23686fa
Bump version number
2020-10-07 16:43:28 -07:00
Joe Cheng
1c85ecd7c0
Bump development version
2020-10-07 16:20:32 -07:00
Winston Chang
a1ff765235
Merge pull request #3055 from rstudio/joe/bugfix/freeze-invalidation
2020-10-07 17:36:16 -05:00
Hadley Wickham
a30ba9226d
Implement reactiveConsole() ( #3092 )
...
* Implement reactiveConsole(). Fixes #2518
* Also includes makeReactiveBinding tweaks
* use `reactiveConsole()` to provide a nicer example
* simplified the implementation using `reactiveVal()`
* remove from documentation indexes since you probably don't want to be promoting this function
2020-10-07 15:37:14 -05:00
Joe Cheng
980a1e53a7
tabsetPanel binding: unconditionally trigger change on receiveMessage
...
This brings it into line with all of the other input bindings.
The only exception is sliderInput, which has a more complicated
codepath that goes out of its way to force the slider, for its
own reasons; I didn't change the slider for fear of breaking
something, and it also doesn't exhibit the problem I'm here to
fix (next paragraph).
The goal is to ensure that if forgetLastInput is called on an
input, and then that input receives a message (updateXXXInput)
to update its value, BUT the new value is the SAME as its
existing value, that the input binding still acts like something
changed. This is because we need the id/value to go through
the InputSender code path, and alert the server if a previously
frozen input is now thawed.
2020-10-06 14:30:21 -07:00
Joe Cheng
00092cd2a8
NEWS
2020-10-06 14:29:29 -07:00
Joe Cheng
53ddb54936
Forgot to actually force invalidation for freezeReactiveValue(input)
2020-10-06 14:28:50 -07:00
Joe Cheng
ea1e307a51
Preserve existing (CRAN) behavior of freezeReactiveVal/freezeReactiveValues(non-input), but warn
...
We don't think anyone is using the freeze functions in the ways
that we are deprecating, if so they should contact us via the
link provided.
If it turns out nobody complains, we can remove the problematic
functions. If people complain, then we'll find out what they're
using them for and we can fix them properly.
2020-10-06 14:28:49 -07:00
Joe Cheng
17bc1e2e06
Force invalidation on freeze
2020-10-06 14:28:49 -07:00
Joe Cheng
ed8f3b730b
Address ("fix" is too strong a word) #1791 , #2946 : freeze/thaw
...
1. freezeReactiveValue(input, "x") is called, inside a renderUI
or in an observer that then calls updateXXXInput
2. Some reactive output tries to access input$x, this takes a
reactive dependency but throws a (silent) error
3. When the flush cycle ends, it automatically thaws
What's *supposed* to happen next is the client receives the new
UI or updateXXXInput message, which causes input$x to change,
which causes the reactive output to invalidate and re-run, this
time without input$x being frozen.
This works, except when the renderUI or updateXXXInput just so
happens to set input$x to the same value it already is. In this
case, the client would detect the duplicate value and not send
it to the server. Therefore, the reactive output would not be
invalidated, and effectively be "stalled" until the next time it
is invalidated for some other reason.
With this change, freezeReactiveValue(input, "x") has a new side
effect, which is telling the client that the very next update to
input$x should not undergo duplicate checking.
2020-10-06 14:28:49 -07:00
Carson
0e109d5237
shiny.css should also be using bs_runtime_dependencies()
2020-10-05 16:21:14 -05:00
Winston Chang
f672226a3d
Merge pull request #3087 from rstudio/jooyoungseo-lang-a11y
2020-10-05 15:42:26 -05:00
Carson
481dccd085
Don't export setCurrentTheme() (just provide it as a public session method)
2020-10-05 15:21:59 -05:00
Barret Schloerke
9612f1c3c8
Use a for loop over an lapply to get better error reporting
2020-10-05 15:56:27 -04:00
Barret Schloerke
9e1e5f61a3
Use inline template logic
2020-10-05 15:48:51 -04:00
Barret Schloerke
99a566f473
Tell htmltools that the template is a complete template
2020-10-05 15:17:27 -04:00
Barret Schloerke
1012307467
Make sure lang is set in helper method
2020-10-05 15:16:57 -04:00
Barret Schloerke
b729f45eaf
Add missing assignment from merge w/ master
2020-10-05 14:36:11 -04:00
Barret Schloerke
cab799e6ee
Add missing close bracket
2020-10-05 14:34:51 -04:00
Carson
a06322d155
No need to capture options since the options are set at render-time
2020-10-05 13:23:59 -05:00
Barret Schloerke
d836cb2a2c
Use helper function to cleanly create <html> start tag given the lang val
2020-10-05 12:14:05 -04:00
Barret Schloerke
2249c7a28a
Use @inheritParams bootstrapPage to inherit lang definition
2020-10-05 11:58:21 -04:00
Barret Schloerke
0d0422c0a7
Use lang <- getLang(ui) and ui <- setLang(ui, lang) methods
2020-10-05 11:57:17 -04:00
Barret Schloerke
5ea556ee77
Fix docs bug
2020-10-05 11:50:16 -04:00
Barret Schloerke
a34496663b
Merge branch 'lang-a11y' of https://github.com/jooyoungseo/shiny into jooyoungseo-lang-a11y
2020-10-05 11:48:00 -04:00
Carson
abeaa71d8d
wip generalized real-time theming via setCurrentTheme()
2020-10-02 17:32:57 -05:00
Carson
281a427718
Allow Shiny.renderDependencies() to re-render stylesheets, if requested
...
Also, make getCurrentTheme() aware of the reactive theme set by bootstraplib::bs_themer()
2020-10-02 11:13:19 -05:00
Carson Sievert
03ab966cdc
Make shiny.css bootstraplib aware; use jquerylib ( #3060 )
...
* Sassify shiny.css (& make it themable); gut json2 dependency (was there for IE8 support)
* Always serve a compressed bundle; remove shiny.css
* Use getCurrentTheme() and make sure shinyDependencies is a function
* Make sure we have sass/rprojroot before running checkBuilt.sh
* Need repos set
* Compare against bleeding edge of sass
* Perform built check with testthat (copying the approach taken for pkgdown checks)
* Update tests/testthat/test-built-files.R
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-10-02 10:59:59 -05:00
Winston Chang
3dcb810346
Merge pull request #3083 from rstudio/is-bs-theme
2020-10-01 14:17:18 -05:00
Carson
d6eef8b3e1
Add getCurrentTheme to pkgdown
2020-10-01 13:47:59 -05:00
Carson
a770f1cbf2
yarn build
2020-10-01 13:40:50 -05:00
Carson
a5687df9b4
make sure is_bs_theme() is available
2020-10-01 13:33:49 -05:00
Carson Sievert
202881cbbd
Localized bootstraplib themes ( #3062 )
...
* Get rid of the bootstraplib option and simply use bootstraplib when a theme is active
* Restore previous bootstraplib theme when exiting a file/dir based runApp
* wip use latest htmltools+bootstraplib to sketch out local theme API
* Don't do anything with bootstraplib's global state and make sure bs_theme is an expected value
* typo
* better docs
* bugfix
* Use the new, more general, tagFunction() instead
* Set the theme object as a part of the page layout (instead of in shinyApp())
* rollback the structural changes to selectizeIt() to avoid breaking code that makes assumptions about the return value of selectInput()
* set shinyOption() in bootstrapLib(), not bootstrapPage()
* Add a helper for checking whether theme is a bs_theme
* Make theme a required arg in bootstrapSass
* Have bootstrapLib() call shinyOption() at render-time, and document why it works
* Have bootstrapPage() always place bootstrapLib(theme) at the top of the tagList()
* Only set shinyOption() when an application is running at render-time (otherwise; throw a warning)
* code review
* Export a new getCurrentTheme() for Shiny developers to access the theme's Sass code
* bump version
2020-10-01 13:19:18 -05:00
Winston Chang
24ac3b9d8b
Reogranize shinyOptions documentation
2020-09-30 15:55:27 -05:00
Winston Chang
47c1fb88b9
Merge pull request #3080 from rstudio/wch-shinyoptions-session
2020-09-29 10:54:14 -05:00
Winston Chang
170b143b17
Document cache option, remove bootstraplib
2020-09-29 10:44:49 -05:00
Winston Chang
3854b49c35
Document shiny.autoload.r option
2020-09-29 10:37:08 -05:00
Winston Chang
bae4f604b5
Update NEWS
2020-09-29 10:34:43 -05:00
Winston Chang
36f32e14d3
Add shinyOptions scoping tests
2020-09-28 19:15:20 -05:00
Winston Chang
9e521e6927
Add missing paren
2020-09-28 17:44:05 -05:00
Winston Chang
4176f541fc
Add test for captureAppOptions()
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-09-28 17:40:34 -05:00
Winston Chang
18f2afbf85
Fix missing itemize
2020-09-28 16:34:16 -05:00
Winston Chang
f9a94d9758
Merge pull request #3075 from rstudio/wch-rm-ie-upload
2020-09-28 16:03:51 -05:00
Winston Chang
d1e672e3e3
Remove $saveFileUrl method
2020-09-28 16:03:19 -05:00
Winston Chang
202b924e63
Separate docs for options and shinyOptions
2020-09-28 10:43:08 -05:00
Winston Chang
4c3342aa99
Get rid of .globals$testMode
2020-09-25 14:44:59 -05:00
Winston Chang
b1e5dd1d1d
Remove .globals
2020-09-25 14:16:10 -05:00
Winston Chang
d43ebfbdb9
Remove withLocalOptions
2020-09-25 14:15:34 -05:00
Winston Chang
cfadd8307b
Copy app and session-level shinyOptions at instantiation time
2020-09-25 14:06:36 -05:00
Winston Chang
fa6cf9832d
Add session-level shinyOptions
2020-09-24 20:55:17 -05:00
Winston Chang
0075b0da33
Annotate runApp and use initCurrentAppState()
2020-09-24 20:35:03 -05:00
Winston Chang
59c6367cb5
Use getCurrentAppState() for shinyOptions instead of .global$options
2020-09-24 20:33:35 -05:00
Winston Chang
194323a9ee
Removed useless option setting
...
This option is immediately cleared by the next line of code.
2020-09-24 19:52:10 -05:00
Winston Chang
1ca437e4ee
Add tests for captureAppOptions
2020-09-24 19:48:10 -05:00
Winston Chang
77e43b9f50
Rename consumeAppOptions to captureAppOptions and provide example
2020-09-24 19:47:48 -05:00
Winston Chang
a23f4b0224
Merge pull request #3078 from rstudio/wch-rename1
2020-09-24 19:03:23 -05:00
Winston Chang
0541c90980
Re-document
2020-09-24 14:53:38 -05:00
Winston Chang
b73a263de8
Rename server-orig.R back to server.R
2020-09-24 14:47:01 -05:00
Winston Chang
d7ffee68cf
Merge branch 'wch-rename' into wch-rename1
2020-09-24 14:46:30 -05:00
Winston Chang
89cd42b904
Create server-resource-paths.R from server.R
2020-09-24 14:45:37 -05:00
Winston Chang
404185eb8c
Merge branch 'wch-rename' into wch-rename1
2020-09-24 14:44:47 -05:00
Winston Chang
8c29a81b12
Create runapp.R from server.R
2020-09-24 14:43:46 -05:00
Winston Chang
9b42c6c379
Merge branch 'wch-rename' into wch-rename1
2020-09-24 14:42:48 -05:00
Winston Chang
03c2dd9e4b
Rename server.R server-orig.R
2020-09-24 14:40:09 -05:00
Winston Chang
d8274c3d8c
Create viewer.R from server.R
2020-09-24 14:37:25 -05:00
Winston Chang
85b5fb090f
Add back shinyapp.R
2020-09-24 14:32:20 -05:00
Winston Chang
2adef311ed
Merge branch 'wch-rename-fix' into main
2020-09-24 14:31:17 -05:00
Winston Chang
7050d0b8ad
Remove shinyapp.R
2020-09-24 14:30:42 -05:00
Winston Chang
8358144a4f
Rename file
2020-09-24 14:28:15 -05:00
Winston Chang
44e083e0a9
Re-document
2020-09-24 12:58:06 -05:00
Winston Chang
a5418cf6ee
Rename app.R to shinyapp.R
2020-09-24 12:57:27 -05:00
Winston Chang
c74630d6eb
Split knitr.R from app.R
2020-09-24 12:55:53 -05:00
Winston Chang
157d4ac9a9
Split knitr.R from app.R
2020-09-24 12:48:32 -05:00
Winston Chang
8228613c01
Create knitr.R from app.R
2020-09-24 12:47:21 -05:00
Winston Chang
b907e17b70
Rebuild shiny.js
2020-09-24 10:49:13 -05:00
Winston Chang
aa7000427c
Update NEWS
2020-09-24 10:48:57 -05:00
Winston Chang
8562c90454
Remove allowDataUriScheme because it is no longer needed
2020-09-24 10:47:27 -05:00
Winston Chang
5a9a04cd72
Remove IE8 and IE9 file upload support
2020-09-24 10:47:27 -05:00
Winston Chang
6b32611356
Rebuild shiny.js
2020-09-24 10:41:01 -05:00
colin
770ebc394f
updateRadioButton with character(0) ( #3043 )
...
Squashed commit of the following:
commit a095d75b67a0bad439e8d6c495ef81af25c0b1a9
Author: Winston Chang <winston@stdout.org >
Date: Thu Sep 24 10:30:47 2020 -0500
Update NEWS
commit 715a10ebd63c34eb2f464a7388e0b89b994bee0f
Author: Winston Chang <winston@stdout.org >
Date: Thu Sep 24 10:24:24 2020 -0500
Update docs for radioButtons about having none selected
commit eff9036884693002a84f84df16cf699be2358c1c
Author: Winston Chang <winston@stdout.org >
Date: Thu Sep 24 10:15:59 2020 -0500
Cleaner check for no selected radioButtons
commit 1666baa746f4dea986be4929720de2a5653acbb6
Merge: c0d35e84 b04ba393
Author: Winston Chang <winston@stdout.org >
Date: Thu Sep 24 10:02:16 2020 -0500
Merge branch '2688' of https://github.com/ColinFay/shiny into ColinFay-2688
commit b04ba393b8
Author: colin <colin@thinkr.fr >
Date: Thu Sep 24 08:37:58 2020 +0200
changed the test structure
commit 866a86946a
Author: colin <colin@thinkr.fr >
Date: Sun Sep 13 20:50:44 2020 +0200
restore old `$escape` behavior
commit d45af353fd
Author: colin <colin@thinkr.fr >
Date: Fri Sep 11 08:54:25 2020 +0200
added trailing ; and space before {
commit 5e95ee03a1
Author: colin <colin@thinkr.fr >
Date: Thu Sep 10 21:55:02 2020 +0200
return early if the value is undefined in setValue of radio
commit 24ac6ec624
Author: colin <colin@thinkr.fr >
Date: Thu Sep 10 21:53:41 2020 +0200
Testing that the type of val is a string, instead of relying on the length
commit 18ec3b8540
Author: colin <colin@thinkr.fr >
Date: Wed Sep 9 22:08:45 2020 +0200
Radio buttons can now be reset with character(0), and their value is set to NULL
Close #2688 and close #2266
commit d7f66165d0
Author: colin <colin@thinkr.fr >
Date: Wed Sep 9 22:08:06 2020 +0200
Correct bug when $escape received an empty value
2020-09-24 10:38:12 -05:00
Joe Cheng
c0d35e84b1
Allow setting the state of RestoreContext ( #3053 )
...
* Allow setting the state of RestoreContext
This setter only sets public fields, but it's still necessary because
the RestoreInputSet R6 class is not exported.
(I needed this functionality for shinytableau config dialogs to do a
bookmark-like restore, but not at all based on querystring)
* Use list instead of values to prevent accidental mutation
See discussion here:
https://github.com/rstudio/shiny/pull/3053#discussion_r488948453
* Rebuild JS for new version number
2020-09-21 13:27:59 -07:00
Andrew Baxter
5e74478864
Remove test for date object length>1 ( Closes #2936 ) ( #3061 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-09-16 17:11:06 -05:00
Winston Chang
46852e2051
Include sources in source maps
...
Uglify changed the option to include sources; this fix reinstates them.
2020-09-15 15:48:55 -05:00
Winston Chang
b9dded0bef
Rebuild JS assets
2020-09-15 15:37:03 -05:00
Winston Chang
6d05f403a5
yarn upgrade
2020-09-15 15:34:47 -05:00
Winston Chang
8368634f85
Merge pull request #2959 from rstudio/joe/feature/select-choices-warning
2020-09-15 15:21:58 -05:00
Winston Chang
8d57d909b4
Merge branch 'master' into joe/feature/select-choices-warning
2020-09-15 15:21:45 -05:00
Winston Chang
9b7855d597
Add more authors
2020-09-15 15:13:42 -05:00
Winston Chang
6a5e1b9998
Add Barret to Authors
2020-09-15 13:15:04 -05:00
Carson Sievert
af6e558699
Make sure we only include one version of Bootstrap ( #3048 )
...
* Make sure we only include one version of Bootstrap and throw a warning if both bootstraplib and theme file is provided
* code review
2020-09-11 17:52:08 -05:00
Carson Sievert
26d4dddffd
Remove modalButton() from pkgdown reference (it's not included on modalDialog()) ( #3046 )
2020-09-11 15:04:53 -05:00
Hadley Wickham
e2765b4881
Document modalButton with modalDialog ( #2907 )
2020-09-11 08:49:21 -05:00
Hadley Wickham
9796b25f33
Combine point events into one doc file ( #2906 )
2020-09-10 17:47:45 -05:00
Carson Sievert
01b8d3a314
More themable dateInput()/dateRangeInput() ( #2964 )
...
* upgrade bootstrap-datepicker from 1.6.4 to 1.9.0; setup infrastructure for bootstraplib theming
Note also that the 000 patch is no longer relevant as 1.9.0 includes the same fix https://github.com/uxsolutions/bootstrap-datepicker/pull/2009
* Patch sass code for BS4 support and more general color contrasting
* Wrap sass compilation into reusable function
* remove check warning
* Have bootstrapPage() use bootstraplib
* yarn build
* Use new output_template()
* Deprecate bootstrapLib() in favor of bootstraplib::bootstrap()
* Require bootstraplib 0.1.0.9001
* Sync up DESCRIPTION
* document
* rollback changes to pkgdown
2020-09-09 15:20:59 -05:00
Carson Sievert
50c48de0de
More themable selectInput() ( #2950 )
...
* Add option to use bootstraplib and have selectInput() theming variables
* Use getShinyOption()
* Have useBsTheme() error out with informative messages if a theme isn't active
* Better Sass variables defaults that account for both bootswatch themes and bs_theme_base_colors()
* Add Carson as an author
* Provide better BS3/BS4 selectize sass variable defaults as a patch to the source files
* tidy up tools script
* add sass to suggests
* yarn install && yarn build
* Wrap sass compilation into reusable function
* Bring -color-item closer to -color-input
* Leverage the new sass::output_file()
* naming change
* Sync up with other PRs
* Sync up DESCRIPTION
* Forgot to update CSS output file logic
* document
2020-09-09 15:02:05 -05:00
Carson Sievert
bfc90da054
More themable sliderInput() ( #2958 )
...
* More themable sliderInput()
* Slider's accent color default should derive from primary theme color
* Remove custom theming args (skin, accentColor, sassVars) but still support theming via bootstraplib
* Wrap sass compilation into reusable function
* remove check warning
* Make font-family configurable; auto-contrast fromto handle text color; increase color contrasting (for accessbility)
* Sync up with other PRs
* Sync up DESCRIPTION
* Forgot to update CSS output file logic
* document
* code review
2020-09-09 14:38:10 -05:00
JooYoung Seo
9d8d6fd6b1
Resolve NEWS conflict
2020-09-09 15:17:25 -04:00
Winston Chang
43344d9a78
Merge pull request #3009 from jooyoungseo/landmark-a11y
...
Added a11y semantic landmarks for main and sidebar panels
2020-09-09 13:33:04 -05:00
Winston Chang
01a593c857
Rebuild docs
2020-09-09 13:14:39 -05:00
Winston Chang
1b2dd11a4c
Merge pull request #2944 from daattali/patch-2
2020-09-09 13:12:36 -05:00
Winston Chang
d90a2c4801
Add links to functions
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-09-09 13:12:04 -05:00
Winston Chang
f065c21ee6
Merge pull request #2945 from daattali/patch-3
...
Documentation: say that withProgress returns the value of its express…
2020-09-09 13:11:20 -05:00
Winston Chang
d0324bd497
Merge pull request #3027 from ColinFay/issue-3024
2020-09-09 13:10:31 -05:00
Hadley Wickham
e57fba07db
Allow passing server function directory to testServer() ( #2965 )
2020-09-03 17:01:02 -05:00
Winston Chang
5cb279cf4e
Merge pull request #3035 from rstudio/wch-cache-log
...
Make sure cache logging appends to file
2020-09-02 10:46:45 -05:00
Winston Chang
4f728b0387
Merge pull request #3034 from rstudio/wch-disk-cache-logic
2020-09-02 10:46:33 -05:00
Winston Chang
927ae08a47
Remove unneeded paste0
2020-09-02 10:42:57 -05:00
JooYoung Seo
a28dc47e30
Added es5-shim removal in NEWS.md ( #3032 )
2020-09-01 21:01:41 -04:00
Winston Chang
b43ee13dd8
Make sure cache logging appends to file
2020-09-01 19:30:42 -05:00
Winston Chang
ad5ad5a675
Update NEWS
2020-09-01 19:20:47 -05:00
Winston Chang
198f7d171e
Fix DiskCache pruning logic when max_n and max_size are used. Closes #3033
2020-09-01 19:19:55 -05:00
JooYoung Seo
549425cb81
Merge master branch
2020-08-31 19:12:26 -04:00
JooYoung Seo
6023165268
Merge master branch
2020-08-31 19:02:41 -04:00
Carson Sievert
2a7273c254
Merge pull request #3030 from rstudio/plot-arg-order
...
Move `alt` parameter after `...`
2020-08-31 17:23:04 -05:00
Winston Chang
8640934410
Move alt parameter after ...
2020-08-31 16:28:43 -05:00
Winston Chang
20bc4e7caa
Merge pull request #3006 from jooyoungseo/alttext
2020-08-31 15:49:24 -05:00
Barret Schloerke
9f83058b78
Do not record the reactlog when enabling shinytest ( #3025 )
2020-08-31 10:39:14 -04:00
colin
ffedf29db4
Other Rds generated by running devtools::document() on the package
2020-08-29 22:27:49 +02:00
colin
00219d342a
All update*Input docs now inheritsParams from their standard counterpart
...
Will close #3024
2020-08-29 22:26:10 +02:00
Winston Chang
753400144d
Update diskCache docs and rebuild
2020-08-28 08:58:30 -05:00
Winston Chang
854a732f47
Update NEWS
2020-08-28 08:57:38 -05:00
Winston Chang
03eaf07526
Merge pull request #3016 from aalucaci/issue-2984
...
Issue 2984
2020-08-28 08:56:16 -05:00
Carson Sievert
d04c12d8cb
Merge pull request #3023 from rstudio/carson/bugfix/downloadButton
...
Change the evaluation rules for the icon promise in downloadButton()
2020-08-27 13:36:44 -05:00
Carson Sievert
afddd3543e
Apply suggestions from code review
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-08-27 13:35:06 -05:00
Carson
d9459a855d
Allow icon arg to reference other downloadButton args
2020-08-27 11:12:09 -05:00
Carson
efbcfca126
Change the evaluation rules for the icon promise in downloadButton(), fixes #3022
2020-08-27 11:07:09 -05:00
Angela Lucaci-Timoce
916675a9bd
renderCachedPlot: improved documentation
2020-08-26 21:03:00 +02:00
Colin Fay
7b43617954
downloadButton() icon can now be changed via the icon parameter (#3010 )
2020-08-25 15:17:49 -05:00
Winston Chang
09b89bccfd
Fix NEWS entry
2020-08-25 13:14:58 -05:00
Winston Chang
1190ee07a9
Remove unused cacheContext class
2020-08-25 13:12:01 -05:00
Barret Schloerke
c4dcf405bb
Fix reactiveValuesToList reactlog label ( #3017 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-08-25 11:49:22 -04:00
JooYoung Seo
c844ea6f07
Added missing alt arg
2020-08-20 10:51:32 -04:00
JooYoung Seo
19704c151a
White space formatting to match the lines together
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-08-20 10:00:43 -04:00
JooYoung Seo
1281ba18cd
Cleaned code
2020-08-19 17:17:40 -04:00
JooYoung Seo
f1f2fae420
Update R/shinyui.R
...
Used attr instead of attributes()
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-19 15:43:46 -04:00
JooYoung Seo
5809070b05
Used isTRUE inverse instead of isFALSE
2020-08-19 15:23:36 -04:00
JooYoung Seo
2c492540ce
Merged master
2020-08-19 15:04:02 -04:00
JooYoung Seo
61556b505d
Used attribute instead of option
2020-08-19 15:02:01 -04:00
Winston Chang
d6a4bc87e8
Fix whitespace
2020-08-19 11:48:35 -05:00
JooYoung Seo
e49f4696e6
Updated NEWS.md
2020-08-19 10:50:23 -04:00
JooYoung Seo
4219f50141
Added a11y semantic landmarks for main and sidebar panels
2020-08-19 10:43:55 -04:00
JooYoung Seo
19da003291
Redocumented for alt param
2020-08-18 17:19:45 -04:00
JooYoung Seo
f0765e3d6a
Updated alt param description
2020-08-18 17:05:47 -04:00
JooYoung Seo
8dac345512
Updated NEWS.md
2020-08-18 16:44:43 -04:00
JooYoung Seo
ce101843f0
Made alt param reactive
2020-08-18 15:43:04 -04:00
JooYoung Seo
d56dc3a237
Update R/render-cached-plot.R
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-08-18 14:25:16 -04:00
JooYoung Seo
28cffb2e25
Update R/render-plot.R
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-08-18 14:24:08 -04:00
JooYoung Seo
d2d169fea3
Update R/render-plot.R
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-08-18 14:23:17 -04:00
JooYoung Seo
a5eb1b15d2
Added alt param
2020-08-16 16:11:18 -04:00
JooYoung Seo
23dbb0b41c
Unified eol in Gruntfile.js for all the platforms ( #3001 )
...
* Unified eol char for all the platforms
* Reran yarn build after merging master
2020-08-13 16:54:44 -04:00
Winston Chang
c72ae68de5
Merge pull request #2993 from jooyoungseo/selectize-a11y
2020-08-13 13:56:39 -05:00
JooYoung Seo
7c1f87aed3
Rebuilt via WSL
2020-08-12 19:20:42 -04:00
JooYoung Seo
6ec0ac1651
Reran yarn after updating grunt
2020-08-12 16:34:08 -04:00
JooYoung Seo
9dc84e5c2b
Merge branch 'master' into selectize-a11y
2020-08-12 15:24:29 -04:00
JooYoung Seo
1e17b55f49
Got rid of es5 info and corrected selectize version
2020-08-12 15:24:18 -04:00
JooYoung Seo
6a4c8556a3
Merge branch 'master' into lang-a11y
2020-08-12 15:07:46 -04:00
JooYoung Seo
488f1c8b83
Made sure lang length to be 1
2020-08-12 15:07:23 -04:00
JooYoung Seo
e2537d8e93
Used withr for applying datepicker patches
2020-08-12 12:56:13 -04:00
JooYoung Seo
6d35cb6c77
yarn grunt instead of yarn build
2020-08-07 11:20:27 -04:00
Carson Sievert
8ce7f64679
Merge pull request #2995 from jooyoungseo/IonRangeSlider-updateScript
...
Tweaked updateIonRangeSlider.R
2020-08-07 09:40:42 -05:00
JooYoung Seo
5cd6250f05
Updated NEWS.md
2020-08-06 17:17:08 -04:00
JooYoung Seo
4872cd91a5
Reran yarn build
2020-08-06 17:00:54 -04:00
JooYoung Seo
08e84e2ca0
Tweaked updateSelectize.R
2020-08-06 16:22:47 -04:00
JooYoung Seo
40889c9637
Used withr when applying patches and doing yarn build
2020-08-06 16:12:11 -04:00
JooYoung Seo
010ba6f214
Update tools/updateIonRangeSlider.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-06 15:12:26 -04:00
JooYoung Seo
2f8dc860ff
Update tools/updateIonRangeSlider.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-06 15:11:55 -04:00
JooYoung Seo
88f61f0d45
Update tools/updateIonRangeSlider.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-06 15:11:37 -04:00
JooYoung Seo
16a5aa7489
Update tools/updateIonRangeSlider.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-06 15:11:19 -04:00
JooYoung Seo
89fd2b2ed3
Tweaked updateIonRangeSlider.R
2020-08-06 13:14:11 -04:00
JooYoung Seo
a16769061e
Removed es5 shim
2020-08-05 20:31:33 -04:00
JooYoung Seo
3be76145b7
Updated grunt file to minify selectize-plugin-a11y
2020-08-05 20:23:23 -04:00
JooYoung Seo
e9d27fa632
Update tools/updateSelectize.R
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-08-05 17:36:16 -04:00
JooYoung Seo
be706e4bb7
Added updating scripts and LICENSE info
2020-08-05 17:15:02 -04:00
JooYoung Seo
b87c4d5623
Appended a11y plugin to options
2020-08-05 11:33:58 -04:00
JooYoung Seo
03a260f26a
Defaulting a11y plugins
2020-08-04 22:32:11 -04:00
JooYoung Seo
ae3e007a5f
Updated selectize-plugin-a11y
2020-08-04 16:58:23 -04:00
JooYoung Seo
cfbf76d898
Added selectize-plugin-a11y
2020-08-04 14:45:34 -04:00
Carson Sievert
0b82b121cb
Merge pull request #2978 from jooyoungseo/dateInput-a11y
...
* Fixed #2951 : Added labels and title for dateInput and dateRangeInput
2020-08-03 09:48:46 -05:00
JooYoung Seo
643ebb4946
Merge branch 'master' of https://github.com/rstudio/shiny into dateInput-a11y
2020-07-31 17:12:40 -04:00
Carson
8693eed3ec
use expect_equal() instead of grepl() in expectation
2020-07-31 15:05:05 -05:00
Winston Chang
766b910150
Add info about calling registerInputHandler from .onLoad
2020-07-28 13:58:36 -05:00
Winston Chang
545843ffe6
Fix pkgdown.yml
2020-07-28 12:59:39 -05:00
Winston Chang
39e7b23d5b
Merge pull request #2934 from hadley/render-text-print
2020-07-28 11:15:15 -05:00
Hadley Wickham
9d0db6f74c
Remove renderPrint from pkgdown index
2020-07-27 15:37:39 -05:00
Winston Chang
78fb25329c
NEWS edits
2020-07-27 14:39:37 -05:00
Winston Chang
7db6a7b57a
Update NEWS
2020-07-27 14:38:00 -05:00
Winston Chang
76f70179c0
Merge pull request #2982 from ColinFay/patch-2
2020-07-27 14:36:50 -05:00
Winston Chang
d6aecfe9ae
Update NEWS
2020-07-27 14:28:13 -05:00
Winston Chang
1354d3dec1
Merge pull request #2981 from ColinFay/patch-1
2020-07-27 14:26:36 -05:00
colin
955ae817d8
switched from * to + in the regex that checks resource path
2020-07-27 21:20:03 +02:00
colin
aee9589c1a
Simple regex in addResourcePath
2020-07-25 22:42:09 +02:00
colin
48ac0f55c3
check that the prefix is not only made of dots
2020-07-25 22:38:41 +02:00
colin
831c0a340c
redoc the runExample()
2020-07-24 11:46:54 +02:00
Colin Fay
210d297d18
Update server.R
2020-07-24 11:08:28 +02:00
Colin Fay
afbcf9039e
Allow to pass resource path that starts with .
...
This will close #2980
2020-07-24 09:33:52 +02:00
JooYoung Seo
e8eadc1a09
Updated test
2020-07-23 11:11:02 -04:00
JooYoung Seo
f234b7015c
Date format instead of format
2020-07-22 16:49:22 -04:00
JooYoung Seo
8de38b3415
Updated NEWS.md
2020-07-22 13:22:45 -04:00
JooYoung Seo
0f132fc180
* Fixed #2951 : Added labels and title for dateInput and dateRangeInput
2020-07-22 13:10:45 -04:00
Hadley Wickham
e597c24f35
Merged upstream/master into hadley-render-text-print
2020-07-19 12:59:01 -05:00
Joe Cheng
1d7a913d29
Add tests
2020-07-17 09:56:33 -07:00
Joe Cheng
f89131205d
Warn on 1000+ choices for selectInput/selectizeInput
2020-07-17 09:56:05 -07:00
Winston Chang
abc6a98d0f
Merge pull request #2974 from jooyoungseo/news-patch
2020-07-16 18:10:59 -05:00
JooYoung Seo
9415e79ff3
Merge branch 'master' of https://github.com/rstudio/shiny into news-patch
2020-07-16 16:47:56 -04:00
JooYoung Seo
6269022536
Followed convention for NEWS.md
2020-07-16 16:47:43 -04:00
Joe Cheng
6ad2125ee7
Calling runApp("app.R") ignored options passed into shinyApp() ( #2969 )
...
* Calling `runApp("app.R")` ignored options passed into `shinyApp()`
Fixes #1942 .
This was caused by shinyAppDir_appR (which was called by shinyAppDir
and shinyAppFile, which were called when runApp() was used with either
no args or a path) dropping shinyApp() options on the floor.
Fixing this was not as simple as not dropping those options. Before
this commit, the app.R file was not invoked until after the host and
port options (possibly others) were already finalized. This commit
changes the effective sequence of events during startup.
- Calling shinyAppFile() or shinyAppDir() that points to a single-file
app, now causes the app.R file to be sourced immediately; previously,
sourcing would happen only at onStart(). (Honestly, the new behavior
seems less surprising anyway.)
- The support files (R/*.R) for app.R were sourced during onStart. I've
moved this so that the support files are sourced right before app.R
is, and re-sourced every time app.R reloads.
* Code review feedback
* Code review feedback: improve test
* Roxygenize
2020-07-16 13:46:32 -07:00
JooYoung Seo
f5d7523a4f
Merge pull request #2937 from jooyoungseo/fileInput-a11y
...
Improved fileInput keyboard accessibility
2020-07-16 16:16:55 -04:00
JooYoung Seo
ce31b9af7e
Removed an issue URL from NEWS.md
2020-07-16 16:13:21 -04:00
JooYoung Seo
fc5d980a52
Resolved NEWS.md conflict
2020-07-16 15:43:35 -04:00
JooYoung Seo
9ea726732a
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-16 15:40:10 -04:00
JooYoung Seo
db5f9cca73
Added Bootstrap accessibility plugin ( #2911 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-07-16 14:26:11 -05:00
JooYoung Seo
06fb4f6972
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-16 15:25:28 -04:00
Winston Chang
f045f9cf1b
Merge pull request #2970 from rstudio/joe/feature/ui-http-response-2
2020-07-16 14:11:37 -05:00
Winston Chang
1752f57c7d
Remove html5shiv and respond.js
2020-07-16 13:56:00 -05:00
Joe Cheng
7eb4bc15b8
Use soft breaks in NEWS
2020-07-16 10:09:43 -07:00
Joe Cheng
707b5ea851
Avoid spurious use of connections
2020-07-16 10:08:51 -07:00
Joe Cheng
fe9f679051
on.exit(add = TRUE)
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-07-16 10:03:43 -07:00
Joe Cheng
368a49be36
Add PR number to NEWS
2020-07-15 15:53:34 -07:00
Joe Cheng
80f0c5f5d7
Allow function-based UI to respond to non-GET requests
2020-07-15 15:51:36 -07:00
Joe Cheng
a5a7224228
Allow function-based UI to return a complete HTTP response
...
This allows the UI handler to have total control over the response,
including status code (for redirects) or content type (for serving
up files).
2020-07-15 14:36:54 -07:00
JooYoung Seo
d616cf045b
Resolved NEWS.md
2020-07-15 11:17:52 -04:00
JooYoung Seo
8186ae060d
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-15 11:12:04 -04:00
Carson Sievert
c46e80c711
Merge pull request #2941 from rstudio/showtext-fix
...
Include the pixelratio when setting showtext dpi
2020-07-14 13:53:22 -05:00
Carson
0735ebd7a8
update news
2020-07-14 13:52:18 -05:00
Carson
391bbaa73b
Do the same when replaying plot
2020-07-14 13:45:34 -05:00
Carson
fed96c0e45
Include the pixelratio when setting showtext dpi
2020-07-14 13:45:34 -05:00
JooYoung Seo
f97f89a371
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-10 13:32:21 -04:00
Winston Chang
6352a5322b
Rebuild documentation
2020-07-10 11:01:51 -05:00
JooYoung Seo
3473427484
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-10 11:30:59 -04:00
Winston Chang
d6c1733f0c
Merge pull request #2917 from jooyoungseo/icon-a11y
2020-07-10 10:27:50 -05:00
JooYoung Seo
d641ac197b
Merged recent shiny release
2020-07-10 11:16:10 -04:00
JooYoung Seo
6a0e41b05e
Updated test-bootstrap.R
2020-07-10 11:09:44 -04:00
Winston Chang
e21a9a095e
Merge pull request #2961 from rstudio/joe/misc/yarn-upgrade
2020-07-08 12:32:39 -05:00
Joe Cheng
56e1a0b939
Further dep upgrades
2020-07-03 09:23:52 -07:00
Joe Cheng
f9f9127a64
Build JS
2020-07-03 09:21:23 -07:00
Joe Cheng
e0628c4ae3
Upgrade build tools; fix Gruntfile.js for Windows
2020-07-03 09:17:37 -07:00
JooYoung Seo
43be342dea
Merge branch 'master' of https://github.com/rstudio/shiny
2020-07-02 12:05:27 -04:00
Winston Chang
9cc7419700
Clarify how testServer expression is evaluated
2020-07-01 15:16:46 -05:00
Winston Chang
f559caf4d0
Bump version to 1.5.0.9000
2020-07-01 15:16:46 -05:00
Winston Chang
42af54ca04
Remove context() calls from example app
2020-06-30 13:27:08 -05:00
Dean Attali
9f55cd46d8
Documentation: say that withProgress returns the value of its expression. I didn't know if it does or doesn't and had to test it out, it should be explicit
2020-06-27 13:24:37 -04:00
Dean Attali
5956f6b123
Small documentation addition in withProgress (I did not re-compile roxygen)
2020-06-27 13:18:43 -04:00
JooYoung Seo
41e42b8a53
Improved fileInput keyboard accessibility
2020-06-24 13:28:02 -04:00
JooYoung Seo
f6f5fbd6fb
Merge branch 'master' of https://github.com/rstudio/shiny
2020-06-24 13:09:11 -04:00
Hadley Wickham
c7618e3991
Combine documentation of renderPrint() and renderText()
...
Since they're so closely related, and it makes it easier to see how they differ.
2020-06-23 08:13:55 -05:00
Winston Chang
da6df5da9e
Rebuild docs with dev version of roxygen
...
This is to work around errors in R CMD check with R-devel:
Non-file package-anchored link(s) in documentation object
2020-06-19 12:15:55 -05:00
Winston Chang
480cc79de4
Merge branch 'master' into rc-v1.5.0
2020-06-19 11:45:14 -05:00
Barret Schloerke
231c13d9a5
run revdep. updates redep_cran notes
2020-06-19 11:09:15 -04:00
Winston Chang
000406ec0b
Remove Remotes field
2020-06-18 15:14:11 -05:00
Winston Chang
44e0a8bcb2
Remove links from NEWS.md
...
The links can cause R CMD check --as-cran to fail, because of rate-limiting by GitHub.
2020-06-18 14:29:35 -05:00
Winston Chang
d2e88c7a2f
Refer to shinytest migration function
2020-06-17 10:46:36 -05:00
JooYoung Seo
638cddcd5e
Merge branch 'master' of https://github.com/rstudio/shiny
2020-06-11 16:33:21 -04:00
JooYoung Seo
a3924f4ab1
Updated aria code and NEWS.md
2020-06-11 16:23:57 -04:00
JooYoung Seo
5798c396ec
Fixed an incorrect line in tools/README.md for IonRangeSlider
2020-06-11 15:07:43 -05:00
JooYoung Seo
b1983f0a83
Fixed an incorrect line in tools/README.md for IonRangeSlider
2020-06-11 15:51:31 -04:00
JooYoung Seo
aca9f562e1
Provided auto-label for icon() instead of aria-hidden
2020-06-11 11:51:31 -04:00
JooYoung Seo
8c6a830521
Updated NEWS.md
2020-06-09 15:48:38 -04:00
JooYoung Seo
9142cf19c0
Fixed lang attribute in templates
2020-06-09 14:55:45 -04:00
JooYoung Seo
887b7fb34a
Fixed app.r for NULL value of lang argument
2020-06-09 14:29:15 -04:00
JooYoung Seo
1392547783
Redocumentation
2020-06-09 14:20:36 -04:00
JooYoung Seo
735b9b8c7a
Updated related scripts, templates, and NEWS.md
2020-06-09 14:19:53 -04:00
JooYoung Seo
cba974ec34
Documentation
2020-06-08 20:10:17 -04:00
JooYoung Seo
421d588a2f
Fixed lang attribute in template
2020-06-08 20:09:29 -04:00
JooYoung Seo
8b848277d2
Added lang ShinyOption
2020-06-08 20:08:23 -04:00
JooYoung Seo
8ae19c7243
Added lang attribute to the default template
2020-06-08 16:29:10 -04:00
Winston Chang
1e5051ef79
Merge pull request #2918 from ginberg/master
...
replace devtools by remotes
2020-06-05 09:42:53 -05:00
ginberg
d293dbc10f
replace devtools by remotes
2020-06-05 15:26:07 +02:00
JooYoung Seo
703f481a9a
Improved accessibility for icon()
2020-06-04 16:45:04 -04:00
Winston Chang
68f0c12cab
Merge pull request #2902 from rstudio/alan-newsmd
2020-05-20 17:39:33 -05:00
Alan Dipert
8c7598f45d
Drop testModule() from NEWS.md, fixes #2901
2020-05-20 22:33:02 +00:00
Barret Schloerke
192c4f239e
bump version to 1.5.0. Build JS
2020-05-18 16:38:55 -05:00
Carson Sievert
64e09315fc
Merge pull request #2900 from rstudio/jquery-3.5.1
...
Bump jQuery 3.5.0 to 3.5.1
2020-05-18 16:38:22 -05:00
Carson
db0c4155b8
news update
2020-05-18 16:28:36 -05:00
Carson
f971bfd80a
Finish updating to jQuery 3.5.1, add a tools script, add documentation to tools/README.md
2020-05-18 16:25:40 -05:00
Carson
948244b45c
Revert "Fixes #2896 by avoiding fatal JS exception in some collapsible navbar scenarios by patching a BS3 bug introduced https://github.com/twbs/bootstrap/pull/16011 "
...
This reverts commit 4ba02c97a7 .
2020-05-18 15:47:01 -05:00
Carson
c7fecbed7a
bump jQuery 3.5.0 -> 3.5.1
2020-05-18 15:46:10 -05:00
Carson Sievert
f22cae98ef
Merge pull request #2897 from rstudio/fix-collapsible-navbar
...
Fix collapsible navbar
2020-05-15 14:02:13 -05:00
Carson
4ba02c97a7
Fixes #2896 by avoiding fatal JS exception in some collapsible navbar scenarios by patching a BS3 bug introduced https://github.com/twbs/bootstrap/pull/16011
2020-05-15 12:38:24 -05:00
Winston Chang
0581dc7763
Remove old manual test app. Closes #2892
2020-05-12 16:30:24 -05:00
Winston Chang
77261d4872
Merge pull request #2891 from rstudio/wch-update-fontawesome
2020-05-12 16:26:10 -05:00
Winston Chang
cfd14ef169
Update NEWS
2020-05-12 16:25:12 -05:00
Winston Chang
c7cc76b044
Update tools/README.md
...
Co-authored-by: Barret Schloerke <barret@rstudio.com >
2020-05-12 16:16:57 -05:00
Winston Chang
44e1096753
Update README
2020-05-12 16:12:47 -05:00
Winston Chang
dc1c48ad4e
Rebuild docs
2020-05-12 16:12:02 -05:00
Winston Chang
d9d29220cc
Update NEWS
2020-05-12 16:04:05 -05:00
Winston Chang
6f744ef311
Update Font-Awesome to 5.13.0
2020-05-12 16:04:05 -05:00
Winston Chang
f7071f2231
Add updateFontAwesome script
2020-05-12 16:04:05 -05:00
Alan Dipert
ef75c9a35f
Move callModule() to separate .Rd; add various links to docs ( #2889 )
...
* Move callModule() to separate .Rd; add various links to docs
* Remove callModule param from moduleServer docs
* document
* Update R/modules.R
* Rebuild docs
* Add callModule to pkgdown
Co-authored-by: Winston Chang <winston@stdout.org >
2020-05-12 12:46:41 -07:00
Winston Chang
4ca3c6c96a
Clearer language for shinyAppTemplate prompt
2020-05-12 11:33:17 -05:00
Joe Cheng
82e98410ed
isTempPath is now isTemp, simplified semantics ( #2886 )
...
* isTempPath is now isTemp, simplified semantics
- Now requires both the path and temp dir to exist
- isTemp(tempdir()) is now false
- Doesn't matter if it's files or directories
* Fix tests under R 3.4 and earlier
* fix comment
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-05-11 20:05:12 -07:00
Winston Chang
dcd92f03db
Merge pull request #2867 from rstudio/alan-mocksession-methods
2020-05-11 21:33:54 -05:00
Alan Dipert
ba6c747e55
Merge remote-tracking branch 'origin/master' into alan-mocksession-methods
2020-05-11 21:47:06 +00:00
Alan Dipert
b53b766ee5
Add reactive/promise test
2020-05-11 21:30:12 +00:00
Barret Schloerke
cd737fccb5
Run pre-revdepcheck for v1.5.0. Found 2 errors. Made 2 PRs ( #2885 )
2020-05-11 17:06:06 -04:00
Alan Dipert
7fb3acea96
get() => !!as.symbol()
2020-05-11 21:00:50 +00:00
Alan Dipert
867052f974
Fix new CMD check note
2020-05-11 20:49:36 +00:00
Alan Dipert
038e010819
testServer() doc update
2020-05-11 20:34:40 +00:00
Alan Dipert
7f5e42fdd5
Fix pkgdown test
2020-05-11 19:46:11 +00:00
Alan Dipert
2fe9b3dcbe
Fix tempdir()-related problem
2020-05-11 18:55:28 +00:00
Winston Chang
89dbfcecbf
Ensure file encoding is specified for sort_c
2020-05-11 13:42:10 -05:00
Alan Dipert
f4bda6b91f
Ensure temp files passed to downloadHandler() content functions are deleted on session close
2020-05-11 18:28:39 +00:00
Alan Dipert
dba72ac8a7
Call session ended callbacks, fix related existing/broken test
2020-05-11 18:20:37 +00:00
Barret Schloerke
aedbfb11af
Use GitHub Actions ( #2876 )
2020-05-11 14:18:10 -04:00
Winston Chang
43fd380e25
Merge pull request #2881 from rstudio/joe/feature/better-delete-file
2020-05-11 13:09:51 -05:00
Joe Cheng
2872100ff0
Code review feedback
2020-05-11 11:06:51 -07:00
Alan Dipert
afe81048c9
Pass namespaced names to renderFile()
2020-05-11 17:51:35 +00:00
Alan Dipert
9d44857d77
get_mocked_publics() cleanup
2020-05-11 17:49:10 +00:00
Alan Dipert
4a7d186f27
renderCachedPlot() support, minor reorg and misc. fixes
2020-05-08 23:02:06 +00:00
Joe Cheng
5b1fd12edd
Unit tests
2020-05-08 14:28:46 -07:00
Joe Cheng
8309a2aed9
Safer default file deletion behavior for renderImage
2020-05-08 14:18:57 -07:00
Alan Dipert
e15d6a2239
sp
2020-05-08 19:56:52 +00:00
Alan Dipert
abf04ac96f
roxygenation
2020-05-08 19:50:04 +00:00
Carson Sievert
8ec6275f9a
Merge pull request #2879 from rstudio/revert-renderedFamily
...
remove renderedFamily info field
2020-05-08 14:44:05 -05:00
Carson
3e2bfb20f5
remove renderedFamily info field
...
Because no information is better than wrong information
https://bugzilla.mozilla.org/show_bug.cgi?id=1252821
2020-05-08 13:36:05 -05:00
Winston Chang
ee13087d57
Merge pull request #2878 from rstudio/revert-ragg
2020-05-08 13:29:43 -05:00
Alan Dipert
f2fd7de9db
roxygenation
2020-05-08 18:28:41 +00:00
Carson
dcfd7e05ce
shiny.useragg should default to FALSE
2020-05-08 13:27:54 -05:00
Winston Chang
e47b69c33a
Merge pull request #2874 from rstudio/wch-app-template-tweaks
2020-05-08 10:58:55 -05:00
Winston Chang
383f78c8ca
Fix link
2020-05-08 10:58:19 -05:00
Alan Dipert
54042d5150
export MockShinySession; document
2020-05-07 23:02:00 +00:00
Alan Dipert
90e6ffc928
<<- to <-
2020-05-07 22:57:09 +00:00
Alan Dipert
be65f49bbd
sapply => names() <- + lapply
2020-05-07 22:43:47 +00:00
Alan Dipert
d81b8ff98f
ensyms => list
2020-05-07 22:42:20 +00:00
Alan Dipert
9b5201e33c
Return invisible in noop functions
2020-05-07 22:38:01 +00:00
Alan Dipert
588c1b91b9
Test reactive() + downloadHandler
2020-05-07 22:30:45 +00:00
Alan Dipert
eb63734792
getCurrentOutputInfo() works, and tests
2020-05-07 21:36:42 +00:00
Alan Dipert
22cc585180
downloadHandler() test
2020-05-07 21:14:27 +00:00
Alan Dipert
bd1631a649
downloadHandler() test
2020-05-07 21:12:46 +00:00
Alan Dipert
e12bde6cdb
getCurrentOutputInfo()
2020-05-07 20:23:38 +00:00
Alan Dipert
7763ceefc0
Update private$downloads docs
2020-05-07 18:55:45 +00:00
Alan Dipert
05a7d998b9
registerDownload() and private$renderFile
2020-05-07 18:53:07 +00:00
Carson Sievert
4b676ac327
Merge pull request #2873 from rstudio/output-info-docs
...
Document the return value of getCurrentOutputInfo()
2020-05-07 12:14:58 -05:00
Carson
6ad1322734
Output context isn't well-defined
2020-05-07 12:08:32 -05:00
Alan Dipert
03248735ac
Un-noop a couple things we need to implement
2020-05-07 16:36:31 +00:00
Winston Chang
8e5651490c
Merge pull request #2851 from rstudio/tabsetPanelBody_value_check
2020-05-07 11:17:21 -05:00
Barret Schloerke
0d7aa2a101
undo id parameter for example
2020-05-07 12:14:16 -04:00
Winston Chang
83669ced3d
App template tweaks
2020-05-07 10:52:16 -05:00
Winston Chang
2a33d23165
Make runnable example for downloadButton
2020-05-07 10:51:24 -05:00
Alan Dipert
b7ae915784
Remove unnecessary constructor
2020-05-07 15:37:24 +00:00
Winston Chang
9fcfa25460
Merge pull request #2872 from rstudio/wch-sort-c
2020-05-07 10:26:28 -05:00
Carson
946eae00bd
roxygen
2020-05-07 10:21:17 -05:00
Carson
e8ef33c9a1
Explain the return value of getCurrentOutputInfo()
2020-05-07 10:18:32 -05:00
Barret Schloerke
8c8654f2d8
feedback from @wch. Keep 'value' arg, drop 'id'
2020-05-07 10:55:12 -04:00
Winston Chang
4b744791f2
Add sort_c function for sorting in C locale
2020-05-07 09:47:02 -05:00
Barret Schloerke
5327cb33f9
Merge branch 'master' into tabsetPanelBody_value_check
...
* master:
Remove trailing comma and extra return statement
Remove check note about function not found
2020-05-07 10:44:02 -04:00
Barret Schloerke
d9ddc6fd90
Merge pull request #2871 from rstudio/schloerke-patch-2
2020-05-07 10:43:17 -04:00
Barret Schloerke
a94c2cfa1e
Merge pull request #2870 from rstudio/schloerke-patch-1
2020-05-07 10:35:07 -04:00
Barret Schloerke
614bc6b480
Remove trailing comma and extra return statement
2020-05-07 10:34:09 -04:00
Barret Schloerke
47585174d8
Remove check note about function not found
2020-05-07 10:32:36 -04:00
Barret Schloerke
5dd11bcc9b
Merge branch 'master' into tabsetPanelBody_value_check
...
* master: (63 commits)
Use getStyle() to support old browsers
safe-guard against NA values
make shiny.useragg an unofficial option that takes priority over quartz
smaller bump in version
update news and add to comment
Wrap styles in reactive() so that calling getCurrentOutputInfo() doesn't always invalidate
Use is_available() more widely and remove unneeded complexity in check_suggested()
comments
generalize internal is_installed and use it in startPNG()
Remove reference to helper-load.R that's no longer there
Minor updates to shinyAppTemplate docs
code review with Winston
default to FALSE for now
let showtext know about the resolution
Pass check
Rollback the custom device arg (may come later) in favor of a shiny.useragg option
Auto values aren't resolved until plot time, so if we see one, resolve it
change device bg default only if the thematic option is set
somehow messed up rebase
missed passing device in renderCachedPlot()
...
2020-05-07 10:22:59 -04:00
Alan Dipert
160d2123b2
roxygen tweaks
2020-05-07 05:42:53 +00:00
Alan Dipert
ca55ed3a21
Down to 1 missing method and 1 missing field
2020-05-06 22:58:07 +00:00
Alan Dipert
34fe820a26
Fix ls() usage, revert MockShinySession roxygen tags
2020-05-06 22:18:56 +00:00
Winston Chang
c7a4d23662
Merge pull request #2740 from rstudio/joe/feature/bs4-compat-plot-colors
2020-05-06 15:51:11 -05:00
Alan Dipert
432a7120f2
Clarify test logic; better output
2020-05-06 20:44:18 +00:00
Alan Dipert
7e8b5d28f7
fix tests
2020-05-06 20:18:24 +00:00
Carson
079871df38
Use getStyle() to support old browsers
2020-05-06 15:17:06 -05:00
Carson
c95d3ef07d
safe-guard against NA values
2020-05-06 15:16:22 -05:00
Carson
acad455ccb
make shiny.useragg an unofficial option that takes priority over quartz
2020-05-06 15:10:42 -05:00
Alan Dipert
fcc7df32ad
Add instance methods in the constructor
2020-05-06 19:09:49 +00:00
Carson
c7f0484c37
smaller bump in version
2020-05-06 13:24:57 -05:00
Carson
3dac31a771
update news and add to comment
2020-05-06 13:21:17 -05:00
Alan Dipert
16357963d5
Add more noops and errors
2020-05-05 23:05:24 +00:00
Alan Dipert
7d7492b9aa
roxygen flailing
2020-05-05 21:51:04 +00:00
Carson
26dff7e00e
Wrap styles in reactive() so that calling getCurrentOutputInfo() doesn't always invalidate
2020-05-05 15:30:04 -05:00
Carson
cf410e310f
Use is_available() more widely and remove unneeded complexity in check_suggested()
2020-05-05 13:30:01 -05:00
Carson
5d4855f86c
comments
2020-05-05 12:26:58 -05:00
Carson
6d7e2b8a06
generalize internal is_installed and use it in startPNG()
2020-05-05 12:26:44 -05:00
Barret Schloerke
d37be0d059
Update tests/testthat/test-tabPanel.R
...
Co-authored-by: Hadley Wickham <h.wickham@gmail.com >
2020-05-05 12:39:02 -04:00
Barret Schloerke
d419ec5776
Update tests/testthat/test-tabPanel.R
...
Co-authored-by: Hadley Wickham <h.wickham@gmail.com >
2020-05-05 12:38:57 -04:00
Alan Dipert
c01f100858
WIP noop refactor party; collation brokn
2020-05-05 03:46:25 +00:00
Winston Chang
d8e380b53f
Merge pull request #2860 from mine-cetinkaya-rundel/app-template-edits
2020-05-04 17:27:05 -05:00
Alan Dipert
6881c39c8d
Use noop()
2020-05-04 20:19:00 +00:00
Mine Çetinkaya-Rundel
e7fa540403
Remove reference to helper-load.R that's no longer there
2020-05-02 11:20:44 +01:00
Mine Çetinkaya-Rundel
e92ba27893
Minor updates to shinyAppTemplate docs
...
More detail on how shinyAppTemplate choices + streamline shinytest/testthat listing
2020-05-02 11:05:50 +01:00
Carson
210792397d
code review with Winston
2020-05-01 16:20:15 -05:00
Alan Dipert
91385967c1
A good test of real/mock session difference
2020-05-01 21:01:01 +00:00
Alan Dipert
0c8d27964b
add mock method notify func
2020-05-01 20:01:24 +00:00
Alan Dipert
ed4fcb71f1
testServer(): Users can now pass in their own session
2020-05-01 15:03:50 +00:00
Carson
0738f6a2d6
default to FALSE for now
2020-04-30 18:14:20 -05:00
Carson
1e2a874067
let showtext know about the resolution
2020-04-30 17:50:19 -05:00
Carson
9d2f8cbd8a
Pass check
2020-04-30 17:50:19 -05:00
Carson
dd1c653365
Rollback the custom device arg (may come later) in favor of a shiny.useragg option
2020-04-30 17:50:19 -05:00
Carson
1a0a53a26f
Auto values aren't resolved until plot time, so if we see one, resolve it
2020-04-30 17:50:19 -05:00
Carson
97ea4e2a26
change device bg default only if the thematic option is set
2020-04-30 17:50:19 -05:00
Carson
b408d9348d
somehow messed up rebase
2020-04-30 17:50:19 -05:00
Carson
44cfde7a0c
missed passing device in renderCachedPlot()
2020-04-30 17:50:19 -05:00
Carson
db3d7ee436
bump version
2020-04-30 17:50:19 -05:00
Carson
a05f713e26
code review with Barret
2020-04-30 17:50:19 -05:00
Carson
dfb492493c
Provide a device argument to renderPlot() and plotPNG()
2020-04-30 17:50:19 -05:00
Carson
7ddf4169b8
no need to call thematic
2020-04-30 17:50:19 -05:00
Carson
89d6a3d91a
User-supplied bg to renderPlot should take 1st priority
2020-04-30 17:50:19 -05:00
Carson
16196eeaaa
ragg will take priority over Cairo
2020-04-30 17:50:19 -05:00
Carson
393d4163c8
Auto-theming interface will come from thematic
2020-04-30 17:50:19 -05:00
Carson
5855aa2689
First pass at an auto-theming interface
2020-04-30 17:50:19 -05:00
Carson
4e59f55f11
wip font support
2020-04-30 17:50:19 -05:00
Carson
b269487a47
port auto-theming logic to new thematic package
2020-04-30 17:50:19 -05:00
Carson
dce4028786
sequential colorscale now mixes fg/bg with accent (for the endpoints)
2020-04-30 17:50:19 -05:00
Carson
819ad4c770
newpage should always come before ggplot_build
2020-04-30 17:50:19 -05:00
Carson
b10b6d4833
default to bg='white', not transparent
2020-04-30 17:50:19 -05:00
Carson
a3d224beaf
suggest scales; other R CMD check things
2020-04-30 17:50:19 -05:00
Carson
164ad8c521
Add autoThemeOptions() to pkgdown
2020-04-30 17:50:19 -05:00
Carson
4c8ec8befe
allow autoTheme options to be reactive
2020-04-30 17:50:19 -05:00
Carson
0692334a27
cleanup
2020-04-30 17:50:19 -05:00
Carson
be912cf2ce
Set default scales via plot_env for old ggplot2 and options for new ggplot2
2020-04-30 17:50:19 -05:00
Carson
f942c088ec
mix colors using scales::colour_ramp
2020-04-30 17:50:19 -05:00
Carson
330da2dcbb
code review feedback; introduce autoThemeOptions()
2020-04-30 17:50:19 -05:00
Joe Cheng
afad0395ff
Use htmltools::parseCssColors
2020-04-30 17:50:19 -05:00
Carson
ecd72f1bc0
Add sequential colorscale for ggplot2 based on the accent color
...
Also, some R CMD check fixes and other cleanup
2020-04-30 17:50:19 -05:00
Carson
867daeead7
Add accent (link) color and qualitative color palettes
...
Also, improved approach to adjusting various defaults based on fg/bg/accent
2020-04-30 17:50:19 -05:00
Carson
a20c3a397e
make sure ggplot_apply_auto_colors always returns a built plot
2020-04-30 17:50:19 -05:00
Carson
a1a22e811f
Report font-family and colors in getCurrentOutputInfo() if .shiny-report-theme class is present
...
Also, rename autocolors to autotheme as we'd like to support fonts and possibly more in the future
Also, wrap ggplot2 default overriding and building logic into one function, so plotly can use it in a self-contained fashion
2020-04-30 17:50:19 -05:00
Joe Cheng
3fbbabd68a
Better autocolors for bars and other geoms that don't have colour; lighter lattice defaults
2020-04-30 17:50:19 -05:00
Joe Cheng
47c1202535
Tweak ggplot2 colors to look closer to defaults
2020-04-30 17:50:19 -05:00
Joe Cheng
83a5feaaa8
More autocolor fixes
...
- Don't set graphical params if fg/bg are not set
- Make maybe_set_palette return the old palette
2020-04-30 17:50:19 -05:00
Joe Cheng
6e767fc71d
More robust un-setting of autocolor params
...
Before this commit, any error would cause the params not to be restored.
If the error was in the initial parameter setting itself (as can occur
with lattice_set_params() at the moment), then not even the graphics
device would be restored, meaning that stopping the app and attempting
to plot would result in graphics being sent to a temp file somewhere
instead of the default graphics device.
2020-04-30 17:50:19 -05:00
Joe Cheng
303f264326
Implement plot.autocolors for cached plots
2020-04-30 17:50:19 -05:00
Carson
f73671845c
Add support for lattice and better default palette() for col scaling
2020-04-30 17:50:19 -05:00
Carson
82c04caf3a
facet strips shouldn't have stroke and fill should be a semi-lighten fg color
2020-04-30 17:50:19 -05:00
Carson
d8080d1336
only assign default for aes that are relevant and non-transparent
2020-04-30 17:50:19 -05:00
Carson
fc09d1c09a
Support a named vector as an override to computed colors
2020-04-30 17:50:19 -05:00
Carson
65a47c01ec
grep for hex codes properly and return exit length 0 character string if input is length 0
2020-04-30 17:50:19 -05:00
Carson
e9f2e0d7d7
wip
2020-04-30 17:50:19 -05:00
Winston Chang
ddcb31897d
Merge pull request #2858 from rstudio/currentOutputInfo
2020-04-30 17:05:13 -05:00
Carson
eecdc0e24c
update news
2020-04-30 14:56:14 -05:00
Carson
f642bcc954
Have getCurrentOutputInfo() return NULL instead of error if called in a non-reactive context (extension of #2707 )
2020-04-30 14:54:09 -05:00
Carson Sievert
7dedac5880
Merge pull request #2857 from rstudio/jquery-3.5
...
Bump to jQuery 3.5.0
2020-04-30 14:47:22 -05:00
Carson
ee5362f81a
news
2020-04-30 14:37:10 -05:00
Carson
1475137d4d
yarn build
2020-04-30 14:27:10 -05:00
Carson
8ba028ebbb
Use native String.trim() method since $.trim() is now deprecated
2020-04-30 10:35:14 -05:00
Carson
7cd385e8c2
Bump jquery 3.x to 3.5.0, closes #2856
2020-04-30 10:06:21 -05:00
Alan Dipert
41694b3666
testServer(): Properly capture module return values
2020-04-29 22:13:00 +00:00
Winston Chang
25314f370e
Merge pull request #2852 from rstudio/remove_test
2020-04-28 11:14:06 -05:00
Barret Schloerke
664b88c1bc
remove duplicate param docs
2020-04-28 11:06:45 -04:00
Barret Schloerke
d6adffa273
testServer does not return results. Do not test for it.
2020-04-28 10:58:44 -04:00
Barret Schloerke
5bd039a335
use 'id' instead of 'value' for tabPanel/tabPanelBody
2020-04-28 10:55:53 -04:00
Barret Schloerke
0782cc3c21
code feedback for tabPanelBody
2020-04-27 16:57:26 -04:00
Barret Schloerke
c73628cca1
Move 'value' to first arg position for tabPanelBody. 'value' is now required. Add tests
2020-04-27 16:10:36 -04:00
Winston Chang
8ffc5aa20c
Merge pull request #2849 from daattali/patch-1
2020-04-27 13:50:31 -05:00
Winston Chang
89c2f09864
Clearer wording for dryrun option
2020-04-27 13:21:02 -05:00
Dean Attali
ee3115653c
typo in NEWS
2020-04-25 01:15:25 -04:00
Winston Chang
48115fc150
Merge pull request #2842 from rstudio/missing_monitorHandle
2020-04-24 15:34:01 -05:00
Winston Chang
d804a363ae
Merge pull request #2837 from rstudio/testServer_args
2020-04-24 15:33:49 -05:00
Barret Schloerke
867c084990
check if function, not if not null
2020-04-24 16:30:21 -04:00
Barret Schloerke
8ffbfca97b
do not call monitorHandle unless it is set
2020-04-24 15:51:23 -04:00
Barret Schloerke
ca9a72d25c
testServer should return invisible()
2020-04-24 10:06:35 -04:00
Barret Schloerke
acdbe8ef5e
use list instead of rlang::list2
2020-04-23 17:47:52 -04:00
Alan Dipert
5cc3a5b71c
Dynamic dots for MockShinySession$setInputs() ( #2838 )
...
* MockShinySession: add $click()
* Fix return value of MockShinySession$click()
* session$click() test w/ observeEvent
* session$click() test w/ observeEvent
* $click() examples
* $click, $setInputs: add \\dontrun
* $setInputs(): make dots dynamic
* document
* rm $click()
2020-04-23 16:36:27 -05:00
Winston Chang
bd587fd21b
Fix pkgdown.yml
2020-04-23 16:36:01 -05:00
Barret Schloerke
0f580ff23d
remove '../' from loadSupport calls as they will be found automatically now
2020-04-23 14:55:21 -04:00
Winston Chang
b0b105babc
Merge pull request #2836 from hadley/interactive-helper-docs
...
Combine docs for nearPoints() and brushedPoints()
2020-04-23 13:46:03 -05:00
Hadley Wickham
3b0cc5f3a8
Rebuild docs
2020-04-23 13:37:26 -05:00
Barret Schloerke
e50981ccc0
replace ... with args in testServer
2020-04-23 14:19:03 -04:00
Winston Chang
24f3c20f26
Merge pull request #2814 from rstudio/hidden_tabset
...
Add `type = "hidden"` to `tabsetPanel`
2020-04-23 12:46:15 -05:00
Hadley Wickham
ca5d71a491
Combine docs for nearPoints() and brushedPoints()
...
* Mouse -> pointer
* Simplify panelvar docs
* Add new ggplot2 and brushing sections
2020-04-23 08:49:24 -05:00
Winston Chang
a022a2b4a4
Merge pull request #2766 from rstudio/joe/feature/autoreload-error
...
Support shiny.autoreload even when there are errors
2020-04-22 16:10:38 -05:00
Winston Chang
0cb618b9b1
Merge pull request #2834 from hadley/output-args
...
Remove deprecated arguments from plotOutput/imageOuput
2020-04-22 09:39:22 -05:00
Winston Chang
1f4927683e
Merge pull request #2829 from rstudio/wch-migrate-shinytest
...
Add migrateLegacyShinytest function
2020-04-22 09:21:46 -05:00
Winston Chang
7c74399a5d
Documentation edits
2020-04-22 09:18:06 -05:00
Winston Chang
52903b6ecd
Do not flush when setting a returned value for a mock shiny ses… ( #2832 )
...
Do not flush when setting a returned value for a mock shiny session
2020-04-22 09:09:42 -05:00
Alan Dipert
a43244916b
loadSupport(): fix global.R support, run global.R in appropriat… ( #2831 )
...
* loadSupport(): fix global.R support, run global.R in appropriate dir
* loadSupport(): Use withr::with_dir, fix global.R-related tests
* shiny.autoload.r: Ensure dir set to appDir before sourcing R/ files
* Use file.path.ci() to ensure case-insensitive filesystem compat in loadSupport() and findEnclosingApp()
* loadSupport(): Ensure proper source order of R/ files
* loadSupport(): Clarify test
2020-04-22 08:54:06 -05:00
Hadley Wickham
35be892e69
Remove deprecated arguments from plotOutput/imageOuput
...
These were deprecated in 0.11.1, which was released on 2015-02-11, i.e. >5 years ago.
2020-04-22 08:45:40 -05:00
Barret Schloerke
536e8ffb28
Do not set a returned value for an app
...
An app never has access to the returned value of a server function. This DOES makes sense for modules, but not shiny apps.
2020-04-21 16:57:56 -04:00
Barret Schloerke
0241f07105
Do not flush when setting the returned value in a mocked shiny session
...
This requires $flushReact() to be called when wanting to access reactive values that do not require inputs to be set
2020-04-21 16:57:15 -04:00
Winston Chang
3570af90ab
Update test for new function name
2020-04-17 17:32:45 -05:00
Winston Chang
fa3fa9e2ef
Add migrateLegacyShinytest function
2020-04-17 17:28:03 -05:00
Winston Chang
83e2bb028f
Small fixes
2020-04-17 17:27:37 -05:00
Alan Dipert
f50b7c4301
testServer() and loadSupport(): if app is a path, and not an ap… ( #2823 )
...
* Improve makeMask comment
* Added skeleton function and example
* Refinements to app template
* Template update
* Rename tests/shinytests/ to tests/shinytest/
* App template updates
* mask creation: clean up, document, and align with rlang::new_data_mask()
* Revert minor in mock session
* Document/fix mock session $setEnv() and $setReturned() behavior
* document
* simplify buildMask()
* minor
* simplify buildMask()
* simplify buildMask()
* add 12_counter test app to exercise runTests + testServer
* Add appobj test
* WIP loadSuppor for apps passed to testServer
* Revert "WIP loadSuppor for apps passed to testServer"
This reverts commit 2d519aca15 .
* Found and fixed app obj lifecycle methods that testServer was not exercising when applicable
* Rename 12_counter to 12_template
* Rename utils.R to sort.R
* Updates from code review
* Move 12_template to app_template dir
* Add informative comments
* Simplify mask building, default app to "." in testServer()
* testServer(): Error when arguments provided to a server function
* Fix tests; don't default autoload to FALSE if not found
* Use withr::with_options in one particularly confusing shiny.autoload.r-related test
* testServer(): if app is a path, and not an app, walk up dirs until an app is found
* Fix tests on Windows - rprojroot uses winslash='/'
* testServer(): raise findEnclosingApp() call
* Add library(shiny) to top of test app
* document
* Use require(shiny) in testServer() it works without library(shiny)
* Revert "testServer(): raise findEnclosingApp() call"
This reverts commit 5801dee2a4 .
* document
* loadSupport(): appDir now defaults to . and findEnclosingApp() occurs
* loadSupport() and testServer(): default app/appDir to NULL
* Remove sketchy test involving detach()
* Move findEnclosingApp() to utils.R
* Dropped rprojroot dep and moved findEnclosingApp() to utils
* Better error message
* findEnclosingApp(): Fix case when root is an app
Co-authored-by: trestletech <jeff.allen@trestletechnology.net >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-04-17 16:04:40 -05:00
Winston Chang
41c9a0c395
shinyAppTemplate tweaks ( #2828 )
...
* shinyAppTemplate: Add dryrun option and print out changes
* Code cleanup
* Add shinytest version check
* Move is_template logic into function
* Use dirExists function
* Use version check compatible with dev version
* Small fixes
* More refactoring
* Fix message about shinytest
* Documentation formatting fixes
2020-04-17 15:53:51 -05:00
Barret Schloerke
12401b6588
Merge pull request #2826 from rstudio/barret_runTests2
...
Update runTests() add print method
2020-04-17 13:50:21 -04:00
Barret Schloerke
8edf8905a5
Merge pull request #2827 from rstudio/drop_serverR
...
Drop server.R template file
2020-04-17 13:37:26 -04:00
Barret Schloerke
d5cb8d187c
code feedback
2020-04-17 13:24:00 -04:00
Barret Schloerke
328a066f0f
merge news items
2020-04-17 11:08:37 -04:00
Barret Schloerke
42d314d592
safeguard testing by checking for some suggested packages
2020-04-17 11:02:19 -04:00
Barret Schloerke
d89d546e53
make sure shinytest is installed from github. Needs latest version
2020-04-17 10:40:20 -04:00
Barret Schloerke
1a558143c7
add comments
2020-04-17 10:39:45 -04:00
Barret Schloerke
ad7ffa2245
use mkdir_p to always create directories
2020-04-17 10:09:16 -04:00
Barret Schloerke
717ac420d9
fix test
2020-04-17 09:59:34 -04:00
Barret Schloerke
abff323eb6
display the test folder name when it fails
2020-04-17 09:50:54 -04:00
Barret Schloerke
03bc1ccd4a
remove autoload.r test, as that code path doesn't exist anymore
2020-04-17 09:50:47 -04:00
Barret Schloerke
da408eeaff
removed dplyr
2020-04-17 09:50:45 -04:00
Barret Schloerke
a2ba9bb26a
Test module app 107_scatterplot. Use pretty paths when printing the runTests output
2020-04-17 09:50:42 -04:00
Barret Schloerke
16c41ed046
Document
2020-04-17 09:50:39 -04:00
Barret Schloerke
aeb3c9f094
Test many combinations of shinyAppTempalte combos. Do not full matrix as shinytest is slow to execute
2020-04-17 09:50:37 -04:00
Barret Schloerke
2562cc8220
shiny.autoload.r is not required for runTests anymore
2020-04-17 09:50:29 -04:00
Barret Schloerke
0647cd85e9
If no module is used with shinytest, do not test the module
2020-04-17 09:49:52 -04:00
Barret Schloerke
d57e7389d2
feedback - remove all non-module/server test files in the testthat dir if the R folder is not used
2020-04-17 09:49:50 -04:00
Barret Schloerke
3cb3316a95
Copy all files, but if they are glue files... use the template
2020-04-17 09:49:47 -04:00
Barret Schloerke
8ba03e1205
Have output$sequence test be conditional on if the r dir is used
2020-04-17 09:49:45 -04:00
Barret Schloerke
6a69d3c07b
feedback - no expr =
2020-04-17 09:49:42 -04:00
Barret Schloerke
c054b8c9ab
feedback - drop adhoc
2020-04-17 09:49:39 -04:00
Barret Schloerke
db6f7cceea
feedback - Do not require req(input$size)
2020-04-17 09:49:37 -04:00
Barret Schloerke
0898ee1fba
Remove runTests output
2020-04-17 09:49:27 -04:00
Barret Schloerke
6366c0a684
Add full template + runTests test
2020-04-17 09:48:01 -04:00
Barret Schloerke
f56eb42c90
use adhoc.R in stead of server.R in shinyAppTemplate
2020-04-17 09:48:01 -04:00
Barret Schloerke
6f3f21921e
No longer need helper-support. testthat.R should do this before running
2020-04-17 09:47:56 -04:00
Barret Schloerke
b8c016c3e9
print the app folder name (if available), not just the test file name
2020-04-16 19:13:51 -04:00
Barret Schloerke
e5d3b1c1d5
Code feedback. snake case legacy_shinytest fn. add comments / change error
2020-04-16 19:13:51 -04:00
Barret Schloerke
fe140b6319
Update tests with the design that shinytest legacy can not be called. Add assert=FALSE where appropriate
2020-04-16 19:13:48 -04:00
Barret Schloerke
4e1e0aad8a
Update to use withr / loadSupport
2020-04-16 19:13:03 -04:00
Barret Schloerke
84a5515a3d
Throw error on legacy shinytest testing instead of allowing the legacy test structure
2020-04-16 19:13:03 -04:00
Barret Schloerke
0d5073f8ff
Commit revert
2020-04-16 19:13:03 -04:00
Barret Schloerke
05a4a101db
Update app to be consistent. Add testthat contexts
2020-04-16 19:13:03 -04:00
Barret Schloerke
848f18be2b
Add contexts and pass all tests
2020-04-16 19:13:03 -04:00
Barret Schloerke
21c9079087
Update failure name
2020-04-16 19:13:03 -04:00
Barret Schloerke
2935192eec
Enable broken adhoc test
2020-04-16 19:13:03 -04:00
Barret Schloerke
f896db033f
Rename output
2020-04-16 19:13:03 -04:00
Barret Schloerke
b197afe1a0
Edit docs
2020-04-16 19:13:03 -04:00
Barret Schloerke
dd07f7f580
Document
2020-04-16 19:13:03 -04:00
Barret Schloerke
8376f9093b
white space and small comments
2020-04-16 19:13:03 -04:00
Barret Schloerke
38b8ed7bf9
Add an environment argument to runTests
2020-04-16 19:13:03 -04:00
Barret Schloerke
aa74ea0d0a
Remove code specifically looking for shinytest only files. This is not necessary as it will still work in the current setup.
2020-04-16 19:13:03 -04:00
Barret Schloerke
e5d3f62043
add another testing app that has a module that returns a reactive value
2020-04-16 19:13:03 -04:00
Barret Schloerke
d2d0e70678
Each testing environment must require their own loadSupport call if necessary
2020-04-16 19:13:03 -04:00
Barret Schloerke
aceb7d0467
Add assert logic
2020-04-16 19:13:03 -04:00
Barret Schloerke
c7ac1fa630
add print method
2020-04-16 19:13:03 -04:00
Barret Schloerke
5855a5b26c
Reprint error
2020-04-16 19:13:03 -04:00
Barret Schloerke
0301af62b8
Add todo
2020-04-16 19:13:03 -04:00
Barret Schloerke
32e9757bf7
pass tests
2020-04-16 19:12:59 -04:00
Barret Schloerke
d2b883c4b5
Merge error / result column as pass can be used to determine what the value is
2020-04-16 19:06:45 -04:00
Alan Dipert
816f40a2d5
Consolidate testServer() fixes and enhancements ( #2815 )
...
* Improve makeMask comment
* Added skeleton function and example
* Refinements to app template
* Template update
* Rename tests/shinytests/ to tests/shinytest/
* App template updates
* mask creation: clean up, document, and align with rlang::new_data_mask()
* Revert minor in mock session
* Document/fix mock session $setEnv() and $setReturned() behavior
* document
* simplify buildMask()
* minor
* simplify buildMask()
* simplify buildMask()
* add 12_counter test app to exercise runTests + testServer
* Add appobj test
* WIP loadSuppor for apps passed to testServer
* Revert "WIP loadSuppor for apps passed to testServer"
This reverts commit 2d519aca15 .
* Found and fixed app obj lifecycle methods that testServer was not exercising when applicable
* Rename 12_counter to 12_template
* Rename utils.R to sort.R
* Updates from code review
* Move 12_template to app_template dir
* Add informative comments
* Simplify mask building, default app to "." in testServer()
* testServer(): Error when arguments provided to a server function
* Fix tests; don't default autoload to FALSE if not found
* Use withr::with_options in one particularly confusing shiny.autoload.r-related test
Co-authored-by: trestletech <jeff.allen@trestletechnology.net >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-04-16 10:26:55 -05:00
Carson Sievert
7e7f38005a
Merge pull request #2820 from rstudio/with-path
...
New path tag causes scoping issue in showcase mode
2020-04-14 13:47:13 -05:00
Barret Schloerke
fb834f7207
roxygen sorted the reexports
2020-04-14 14:30:42 -04:00
Winston Chang
5a3e5296d0
Fix typo
2020-04-14 12:51:20 -05:00
Winston Chang
a0e8d8f2d8
Update NEWS
2020-04-14 11:25:42 -05:00
Carson
9c6dfff531
document
2020-04-14 10:55:05 -05:00
Carson
84d9580bae
New path tag causes scoping issue in showcase mode
2020-04-14 10:42:10 -05:00
Jeff Allen
8d6de642ea
[WIP] Add skeleton function and example ( #2704 )
...
* Added skeleton function and example
* Refinements to app template
* Template update
* Rename tests/shinytests/ to tests/shinytest/
* App template updates
* Rename 12_counter to 12_template
* Rename utils.R to sort.R
* Updates from code review
* Move 12_template to app_template dir
* Add informative comments
* Add shinyAppTemplate to pkgdown.yml
* Fixes for LaTeX docs
Co-authored-by: Winston Chang <winston@stdout.org >
2020-04-14 09:45:10 -05:00
Winston Chang
b20b812cfe
Merge pull request #2819 from hadley/opts-id
...
Don't set default id in clickOpts() and friends
2020-04-14 09:04:50 -05:00
Hadley Wickham
9b23ff6a19
Don't set default id in clickOpts() and friends
...
This was especially confusing given that each function tests that the id is not NULL.
2020-04-14 08:31:27 -05:00
Winston Chang
cc5278a117
Don't print loading R/ dir messages ( #2817 )
...
* Don't print loading R/ dir messages
* Remove obsolete tests
2020-04-13 18:10:32 -05:00
Barret Schloerke
ca6459afe4
add !important attr to .nav-hidden css class
2020-04-09 15:29:01 -04:00
Barret Schloerke
f8477f007d
use a list. Use @cpsievert 's wording suggestion.
2020-04-09 15:26:08 -04:00
Barret Schloerke
82d1ad278c
merge master
2020-04-09 12:43:55 -04:00
Barret Schloerke
761fb608d3
Add updateActionLink ( #2811 )
...
* Add updateActionLink function and example
* document
* add news item
2020-04-09 12:27:45 -04:00
Barret Schloerke
af328eee90
add news items. Add tabPanelBody() function. Document
2020-04-09 11:47:25 -04:00
Barret Schloerke
0fde11ae72
document
2020-04-09 10:44:07 -04:00
Barret Schloerke
73919b1943
add type = 'hidden' for tabsetPanel to hide the tab headers
2020-04-09 10:43:47 -04:00
Winston Chang
1433439215
Merge pull request #2737 from rstudio/inline-markdown
...
Add shiny::markdown() for inline Markdown
2020-04-08 11:28:27 -05:00
Alan Dipert
4c8dc09f67
NEWS.md
2020-04-08 16:15:22 +00:00
Alan Dipert
80b43942b0
Bump glue dep
2020-04-08 16:14:01 +00:00
Winston Chang
b709b53b6a
Merge pull request #2807 from rstudio/serverModule-testModule
...
moduleServer/testServer overhaul
2020-04-08 10:58:03 -05:00
Alan Dipert
f4e3e5b618
server => module
2020-04-08 05:06:30 +00:00
Alan Dipert
bac7299359
Remove strings from expect_error
2020-04-08 04:57:14 +00:00
Alan Dipert
fc6f535edd
Clarify testServer lexenv assertions
2020-04-08 04:54:32 +00:00
Alan Dipert
7e2ffab62c
Use base versions of a couple rlang::env_* functions
2020-04-08 04:44:25 +00:00
Alan Dipert
214d721380
Move session$env sanity check out of makeMask and into testServer
2020-04-08 04:41:51 +00:00
Alan Dipert
2f8227e652
Un-inline assignment
2020-04-08 04:36:00 +00:00
Alan Dipert
c0c02d290f
Remove unused variable
2020-04-08 04:35:40 +00:00
Alan Dipert
bc2aa71888
Use vapply in mapNames()
2020-04-08 04:27:40 +00:00
Alan Dipert
7f187d1553
Add markdown() NEWS item
2020-04-08 03:04:46 +00:00
Alan Dipert
81b1f4fdc1
Inline markdown tests, add to docs
2020-04-07 22:48:04 +00:00
Alan Dipert
15f088f10a
Merge remote-tracking branch 'origin/master' into inline-markdown
2020-04-07 20:47:11 +00:00
Alan Dipert
286f12522b
document
2020-04-07 18:40:40 +00:00
Alan Dipert
9d8a6d0142
Document new R6 methods
2020-04-07 18:40:34 +00:00
Alan Dipert
a2dd97cc74
Merge remote-tracking branch 'origin/master' into serverModule-testModule
2020-04-06 23:13:33 +00:00
Alan Dipert
1d9a6ea3c0
getEnv() => env, docs
2020-04-06 23:11:51 +00:00
Alan Dipert
3ca8b1017b
Tests pass \o/
2020-04-06 22:36:09 +00:00
Winston Chang
ecd7c76aee
Merge pull request #2764 from rstudio/runTests-aggregate
...
Tweak runTests() output format
2020-04-06 15:59:06 -05:00
Alan Dipert
70edcd62b9
Getting there
2020-04-03 23:04:50 +00:00
Alan Dipert
90f531888c
fix one failing test
2020-04-03 22:06:14 +00:00
Alan Dipert
953de733e7
nested module tests pass now, many others fail %-)
2020-04-02 23:26:02 +00:00
Alan Dipert
e0ed443319
WIP mock session scoped proxy
2020-04-02 21:33:57 +00:00
Alan Dipert
1487720fd8
WIP more markdown() tests
2020-04-01 21:38:39 +00:00
Alan Dipert
828567e0ce
Add failing proxy-related and ns() related tests
2020-04-01 21:31:39 +00:00
Alan Dipert
78da4c7fce
Merge remote-tracking branch 'origin/master' into serverModule-testModule
2020-04-01 07:26:43 +00:00
Alan Dipert
7f80bfd2cb
document
2020-04-01 07:01:57 +00:00
Alan Dipert
7e3deb5e3f
document
2020-04-01 06:55:44 +00:00
Alan Dipert
5475ec4f0c
document
2020-04-01 06:48:34 +00:00
Alan Dipert
58b4585b57
Doc and test updates
2020-04-01 06:45:18 +00:00
Alan Dipert
cf9ab1c47b
appobj coercion works
2020-03-31 21:36:20 +00:00
Alan Dipert
65233cdd5c
First passing app dir test for testServer overhaul
2020-03-31 06:33:01 +00:00
Alan Dipert
9d13cb644d
test-module.R => test-server.R
2020-03-31 05:36:03 +00:00
Alan Dipert
dd9e0343e8
More test progress
2020-03-31 05:29:42 +00:00
Alan Dipert
bb4aaa2a78
Bring back scope tests
2020-03-31 05:02:31 +00:00
Alan Dipert
0023418b94
More test reorg
2020-03-30 22:55:27 +00:00
Alan Dipert
ec2c9ecea0
Split up and rename various tests
2020-03-27 22:43:29 +00:00
Barret Schloerke
59759398a6
Update actionButton example ( #2806 )
...
* Update actionButton example
* Fix link name in example
2020-03-27 17:00:56 -04:00
Alan Dipert
c4852cb451
Desired environment semantics are working
2020-03-25 22:40:08 +00:00
Winston Chang
99880d6e8a
Merge pull request #2796 from rstudio/actionButton_class
...
Add css class examples for actionButton and actionLink
2020-03-24 09:52:23 -05:00
Alan Dipert
b005799d92
Add back many working/converted tests
2020-03-23 23:01:53 +00:00
Barret Schloerke
72f86dac27
Update Node.js build scripts ( #2800 )
...
* automatic formatting
* Update to the latest & greatest
* `./tools` `yarn build`
* Remove `newer` from grunt as it causes more problems than it solves. yarn build
2020-03-20 15:59:10 -04:00
Barret Schloerke
83628facb3
Use roxygen2 reexport setup for htmltools and fastmap ( #2795 )
...
* Remove all hard copied man files
* Move fastmap reexports into ./R/rexport-fastmap.R
* Update htmltools man script to look for the latest tag and make a reexports file
* document
* Update htmltools reexports to listen to ./inst/_htmltools_reexports.json file. Fix pkgdown failure.
* Allow for any package reexports. Currently fastmap and htmltools
* remove progress dependency
* add back skip on cran for pkgdown
* Test pkgdown only if called using devtools::test or within CI
* Removed outdated import docs file. Moved pkgdown and reexports files into ./tools/documentation. Updated travis file.
* add local test for pkgdown
* updated comments and added a debug comment
* print the repo url and close it
* print the downloaded repo tag info
* use gh package and make sure it's installed
* add PAT to travis and remove username from gh::gh call
* skip pkgdown test on cran and add comments
2020-03-20 14:25:18 -04:00
Alan Dipert
f6e171823a
Merge remote-tracking branch 'origin/master' into serverModule-testModule
2020-03-19 20:48:07 +00:00
Barret Schloerke
9b743a319f
Add ./revdep folder output and script ( #2790 )
...
* Revdep check. 719 - CRAN, 117 - BioConductor; 0 new problems; 3 failed to check
* fix last few install failures. 836 pass. 0 untested. 0 failures.
* add revdep script
2020-03-19 11:43:37 -05:00
Barret Schloerke
eedf2a6cc8
add examples for actionButton and actionLink which adds extra css classes
2020-03-17 14:21:20 -04:00
Winston Chang
e1e738f772
Change indenting of module examples
2020-03-17 13:01:50 -05:00
Winston Chang
182ff3df88
Merge tag 'v1.4.0.2'
...
Shiny 1.4.0.2 on CRAN
2020-03-16 12:34:10 -05:00
Barret Schloerke
23fde95f9e
Add class 'function' to reactive and reactiveVal objects ( #2793 )
...
* add the class 'function' to a reactive object
* add the class 'function' to a reactiveVal object
* add test to make sure the reactive and reactiveVal objects are functions
* Add news item
2020-03-16 10:42:28 -04:00
Barret Schloerke
78f9132eb3
Fix Travis checks ( #2791 )
...
* make sure the server is only run if the example is interactive
* get travis to pass for now
* Update modules.R
* Add S3 class to MockShinySession
* un-skip test
* Update roxygen level
Co-authored-by: Alan Dipert <alan@dipert.org >
2020-03-12 17:42:38 -04:00
Winston Chang
84b7211588
Bump version to 1.4.0.2
2020-03-12 15:42:26 -05:00
Winston Chang
2793e15c26
Add link
2020-03-12 15:41:21 -05:00
Winston Chang
36bd76607a
Skip debounce/throttle tests on CRAN
2020-03-12 15:41:16 -05:00
Barret Schloerke
e17f416bb0
Update roxygen level
2020-03-12 16:30:18 -04:00
Barret Schloerke
a577b1e22e
un-skip test
2020-03-12 16:20:13 -04:00
Alan Dipert
2d324c77c1
Add S3 class to MockShinySession
2020-03-12 13:18:23 -07:00
Alan Dipert
88374eca74
Update modules.R
2020-03-12 13:16:55 -07:00
Barret Schloerke
386135788b
get travis to pass for now
2020-03-12 16:12:05 -04:00
Barret Schloerke
a943d955dd
make sure the server is only run if the example is interactive
2020-03-12 15:58:46 -04:00
Winston Chang
15476ac32e
Merge pull request #2789 from rstudio/skip-tests-timing
...
Skip debounce/throttle tests on CRAN
2020-03-12 11:16:20 -05:00
Winston Chang
17fb5b9eae
Add link
2020-03-12 10:00:36 -05:00
Winston Chang
fd27a0dfa2
Skip debounce/throttle tests on CRAN
2020-03-12 09:46:18 -05:00
Winston Chang
5ffe69ec6c
Merge tag 'v1.4.0.1'
2020-03-12 09:21:07 -05:00
Carson
f5723b2a4d
revert man/ changes to reflect CRAN version of htmltools
2020-03-11 12:04:58 -05:00
Alan Dipert
9e959a88f1
tests
2020-03-05 18:02:26 +00:00
Alan Dipert
09abac41c5
minor reformat
2020-03-05 17:03:15 +00:00
Alan Dipert
1dbf013c1b
markdown(): Improve docs; add .noWS; class result as html
2020-03-05 16:57:43 +00:00
Alan Dipert
a637d5b126
Merge remote-tracking branch 'origin/master' into inline-markdown
2020-03-04 21:25:57 +00:00
Alan Dipert
d409183751
Merge remote-tracking branch 'origin/master' into runTests-aggregate
2020-03-04 21:03:50 +00:00
Alan Dipert
e8feef1ce0
Address feedback
2020-03-04 21:03:04 +00:00
Winston Chang
01491cc696
Merge pull request #2772 from rstudio/test-nest-testModule-testServer
...
Small changes to testModule()/testServer() semantics
2020-03-04 14:58:30 -06:00
Alan Dipert
568a3f28cf
Change test to not be locale-dependent
2020-03-04 20:48:21 +00:00
Winston Chang
02219df480
Merge pull request #2773 from rstudio/wch-module
...
Add moduleServer function
2020-03-04 09:24:58 -06:00
Winston Chang
e006ca51ee
Add NEWS item
2020-03-04 09:23:27 -06:00
Winston Chang
86f651f3ec
Add moduleServer function
2020-03-04 09:23:27 -06:00
Carson
212b33a0ce
bump version
2020-03-03 18:50:41 -06:00
Carson
6b7a121161
yarn build
2020-03-03 18:50:34 -06:00
Carson Sievert
c89da718b1
Merge pull request #2777 from rstudio/fix-docs
...
Run tools/updateHtmltools.R
2020-03-03 18:40:27 -06:00
Carson
eef3ae8387
update news and update htmltools docs
2020-03-03 16:45:57 -06:00
Alan Dipert
0975a61725
Add test to mitigate shadow with unquote
2020-03-03 22:32:59 +00:00
Winston Chang
0c53d54347
Merge pull request #2776 from rstudio/grid-r-devel
...
Patches for grid 4.0
2020-03-03 16:12:39 -06:00
Carson
cbbb04cf69
yarn build
2020-03-03 15:52:25 -06:00
Carson
120baf0a6e
review feedback
2020-03-03 15:34:32 -06:00
Carson
685dc7cc3a
Updates for new grid in r-devel
2020-03-03 15:30:12 -06:00
Alan Dipert
2fbb2ac77b
Merge remote-tracking branch 'origin/master' into test-nest-testModule-testServer
2020-03-03 19:25:49 +00:00
Alan Dipert
2832db7aba
New session$env test
2020-03-03 19:25:14 +00:00
Alan Dipert
18f2471d7c
Fix some roxygen errors
2020-03-03 19:08:49 +00:00
Alan Dipert
ea28f5a61b
Minor changes and tests
2020-03-03 18:58:42 +00:00
Winston Chang
fe9cc6038e
Merge pull request #2774 from rstudio/no-slack-notifications
...
Remove slack notifications
2020-03-03 12:09:39 -06:00
Barret Schloerke
5ed335c499
Remove slack notifications
2020-03-03 12:42:48 -05:00
Alan Dipert
fd04b97496
Fix global reference test inside testServer
2020-03-02 17:56:47 +00:00
Alan Dipert
4c9d281b59
Subtle change to .testModule() semantics
2020-02-28 22:49:37 +00:00
Joe Cheng
a26d66b424
Respect shiny.autoreload option being set in app.R or global.R
2020-02-25 20:11:54 -08:00
Alan Dipert
cfb683419f
Remove Rd
2020-02-25 20:30:34 +00:00
Alan Dipert
97887bdf02
Add noRd to private function
2020-02-25 20:30:07 +00:00
Alan Dipert
38ea693e73
NEWS.md updates
2020-02-25 18:13:49 +00:00
Alan Dipert
582a0ea6a5
Remove redundant new test
2020-02-25 17:21:19 +00:00
Alan Dipert
71b9f0907e
Merge remote-tracking branch 'origin/master' into runTests-aggregate
2020-02-25 16:39:54 +00:00
Alan Dipert
82b82b714d
Fix some roxygen errors
2020-02-25 16:27:01 +00:00
Alan Dipert
6356228053
Normalize runTests() output, improve documentation of returned dataframe
2020-02-25 00:08:51 +00:00
Alan Dipert
18fd677550
Pass existing runTests() tests
2020-02-24 22:48:08 +00:00
Alan Dipert
d9698df721
More progress on runTests() format
2020-02-24 22:14:24 +00:00
Joe Cheng
63839fe045
Support shiny.autoreload even when there are errors
2020-02-22 12:22:59 -08:00
Joe Cheng
2ee06a7cbf
Revert "Support shiny.autoreload even when there are errors"
...
This reverts commit cf2ba90b1d .
2020-02-22 12:21:58 -08:00
Joe Cheng
cf2ba90b1d
Support shiny.autoreload even when there are errors
2020-02-22 12:20:12 -08:00
Alan Dipert
8124b2143b
revert names in app1 tests
2020-02-21 23:57:52 +00:00
Alan Dipert
5361573051
Add working runTests test
2020-02-21 23:35:19 +00:00
Alan Dipert
1d377c868d
runTests() output
2020-02-21 22:17:34 +00:00
Alan Dipert
b0a855a326
Make improvements suggested by @schloerke
2020-02-19 20:39:28 +00:00
Alan Dipert
fa35f29596
add_result() for test run
2020-02-19 06:55:32 +00:00
Alan Dipert
f429d23b6e
add_result() for test run
2020-02-19 06:54:46 +00:00
Alan Dipert
eeeb903b70
add_result() for test run
2020-02-19 06:54:11 +00:00
Alan Dipert
78f12c4a75
Type stability changes to shinytestrun object
2020-02-19 06:50:58 +00:00
Barret Schloerke
c69f34d1e2
update js files (version bump)
2020-02-18 13:47:02 -05:00
Barret Schloerke
ccfcc5d8b4
add news item
2020-02-18 13:47:02 -05:00
Barret Schloerke
210c248264
bump version
2020-02-18 13:47:02 -05:00
Barret Schloerke
e3258657d0
Invoke onSessionEnded callbacks with self reactive domain
2020-02-18 13:47:02 -05:00
Barret Schloerke
dbc518bf53
Fix broken timer tests and check htmltools docs ( #2758 )
...
* Adjust time so that it's in seconds and use expect_true to use regular R dispatch
* Execute './tools/updateHtmltoolsMan.R'
* add check for htmltools docs being up to date
2020-02-14 11:36:51 -05:00
Winston Chang
cdbdb4510e
Fix NEWS item
2020-01-16 11:43:51 -06:00
Joe Cheng
e7ec5e5ba4
Merge pull request #2689 from rstudio/joe/feature/bs4-compat
...
bs4 compatibility
2020-01-13 11:59:15 -08:00
Carson
03d8a7f296
document with modern roxygen
2020-01-13 13:28:54 -06:00
Carson
480035c065
undo unnecessary diff; yarn build
2020-01-13 13:04:44 -06:00
Winston Chang
b32c18cf72
Merge pull request #2722 from rstudio/appveyor-cache
...
Bust appveyor cache every time the DESCRIPTION file updates
2020-01-08 14:27:58 -06:00
Barret Schloerke
337a6b276a
Add more comments about why we are busting the appveyor cache
2020-01-08 14:57:06 -05:00
Barret Schloerke
06cf1f9477
Add comment about why we are busting the cache
2020-01-08 14:55:12 -05:00
Winston Chang
190cfd2b7a
Merge pull request #2721 from rstudio/yarn-frozen-lockfile
...
Use a frozen lock file within CI
2020-01-08 13:21:47 -06:00
Joe Cheng
63035b4d66
No need for bg-danger, progress-bar-danger is now in bs3compat
2020-01-07 13:55:46 -08:00
Joe Cheng
6a11c8fcb1
Remove .col-form-label
...
I must've copied this from a bs4 example without understanding
what it's for; it's intended for horizontal form labels, which
we don't do
2020-01-07 13:55:23 -08:00
Joe Cheng
33ffb006e3
Get rid of striped progress bar style
...
The bs4 striped progress bar directives have changed,
but also the stripes look pretty dated at this point
2020-01-07 13:55:23 -08:00
Joe Cheng
162e7f63a9
Remove branch from htmltools remote
2020-01-07 13:54:55 -08:00
Joe Cheng
bb581eeec4
Remove btn-outline-secondary
...
We're handling btn-default in bs3compat
2020-01-07 13:54:55 -08:00
Joe Cheng
272c555bc5
Remove unnecessary bs4 compat shims from showcase
2020-01-07 13:54:55 -08:00
Joe Cheng
fb64caab23
Remove unnecessary bs4 classes
...
Since these classes were added, we've decided to handle more of this
kind of thing in the bootscss package, so bs3 markup can work without
modification in many cases.
2020-01-07 13:54:55 -08:00
Carson
6f2a74a46d
requires htmltools >= 0.4.0.9001
2020-01-07 13:54:41 -08:00
Carson
ec65a74492
Need to de-active any nav tab, not just navs in a dropdown
2020-01-07 13:53:57 -08:00
Carson
ba791c42fa
showcase compatibility
2020-01-07 13:53:39 -08:00
Carson
5896667c36
For some reason event.relatedTarget isn't populated when the previously active item is a dropdown item
2020-01-07 13:53:39 -08:00
Carson
003c949d38
Compatibility for checkboxes will happen via bs4 shims
2020-01-07 13:53:21 -08:00
Carson
d31394254c
progress-bar-striped needs to appear on the actual progress bar (not it's container)
2020-01-07 13:53:21 -08:00
Carson
1a497e246c
progress-bar-danger class has been replaced by bg-danger
2020-01-07 13:53:06 -08:00
Carson
d24276aa54
btn-outline-secondary is visually closer to btn-default (compared to btn-secondary)
2020-01-07 13:52:49 -08:00
Carson
6ed21a3e6b
dateRangeInput() should use input-group-sm, not input-sm or form-control-sm
...
The former is supported in both bs3 and bs4 and ensures consistent small sizing of the input groups
2020-01-07 13:52:49 -08:00
Carson
8066f9ce96
remove debugger; more detailed comment
2020-01-07 13:52:49 -08:00
Carson
a0276ec1ce
wip bs4 compat work
2020-01-07 13:52:33 -08:00
Joe Cheng
2ab925a24c
wip2
2020-01-07 13:52:33 -08:00
Joe Cheng
78fbad7d8d
wip1
2020-01-07 13:52:13 -08:00
Alan Dipert
6652ae3042
markdown(): improve docs, simplify call to markdown_html(), default to extensions = TRUE
2020-01-06 22:43:04 +00:00
Alan Dipert
aa12ab7d76
Add shiny::markdown() for inline Markdown
2020-01-04 00:02:30 +00:00
Winston Chang
89be4bdce9
Merge pull request #2728 from rstudio/wch-fix-timer
...
Timer functions always use ms
2019-12-19 13:12:35 -06:00
Winston Chang
d09a064471
Use test_path
2019-12-13 15:45:17 -06:00
Alan Dipert
2b18ca5a6c
.testModule(): remove args parameter fixes #2709 ( #2713 )
...
* .testModule(): Don't ignore args parameter, fixes #2709
* .testModule(): eliminate args, rely on dynamic dots
* Expand testModule() dots support, add dynamic dots test
* More ... tests
* testModule(): document dynamic dots
* Tighten up ... docs
* document
* testModule(): sundry improvements to docs and tests
2019-12-13 15:38:45 -06:00
Winston Chang
6bc2f18bbf
Timer functions always use ms, and better names. Closes #2725
2019-12-13 15:30:47 -06:00
Alan Dipert
fbb892d84e
Add MockShinySession$makeScope() ( #2714 )
...
* Add MockShinySession$makeScope(), fixes #2712
* Port some relevant ShinySession$defineOutput() behavior to MockShinySession$defineOutput()
* Add nested module test
* Add test for defineOutput() type check
* minor test improvement
* testModule(): improve inner module test, pass reactive to inner
2019-12-12 16:49:18 -06:00
Barret Schloerke
4efb7c20e4
add install cmd
2019-12-10 12:36:23 -05:00
Barret Schloerke
4beb1f07a6
Bust appveyor cache every time the DESCRIPTION file updates
2019-12-09 15:27:17 -05:00
Barret Schloerke
45e640e5f9
Use a frozen lock file within CI
...
https://yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-frozen-lockfile
> Don’t generate a yarn.lock lockfile and fail if an update is needed.
2019-12-09 15:07:12 -05:00
Barret Schloerke
e84beffee3
Merge pull request #2717 from akgold/label-file-observer
...
Add label to file reload observer
2019-12-06 14:42:08 -05:00
Winston Chang
e07c7483a7
Merge pull request #2719 from rstudio/wch-fix-odd-chars
...
Use as.raw instead of charToRaw
2019-12-04 12:31:57 -06:00
Winston Chang
34ec7bf5eb
Use as.raw instead of charToRaw
...
When the package is built, the string with odd characters is marked with the
encoding of the build system. When the build system uses the C locale and the
running system uses a UTF-8 locale (like en_US.UTF-8), this results in a warning
when this function is first accessed. Using as.raw() lets us avoid using a
string altogether.
2019-12-04 10:47:21 -06:00
Barret Schloerke
01b20a4829
display auto reload base directory for reactlog label
2019-12-03 15:16:18 -05:00
Winston Chang
45ea898da4
Rebuild docs with roxygen2 7.0.2
2019-12-03 12:28:06 -06:00
Alex Gold
fd34c5070f
Add label to file reload observer
2019-12-02 10:03:11 -05:00
Winston Chang
6c409d96c1
Bump node version on Travis
2019-11-22 14:09:58 -06:00
Winston Chang
0cbe4bb3d4
Rebuild docs with roxygen2 7.0.1
2019-11-22 13:07:44 -06:00
Winston Chang
d04a990235
Merge pull request #2707 from rstudio/wch-outputinfo-null
...
getCurrentOutputInfo(): return NULL if not in an output
2019-11-22 12:38:05 -06:00
Winston Chang
4747c87632
Rebuild shiny.js
2019-11-21 16:31:51 -06:00
Winston Chang
f57452c7bf
Update docs
2019-11-21 16:30:38 -06:00
Winston Chang
9a8e2eb675
getCurrentOutputInfo(): return NULL if not in an output
2019-11-21 16:16:52 -06:00
Winston Chang
8ef7f3cbe2
Merge pull request #2701 from rstudio/wch-update-roxygen
...
Update roxygen2 to 7.0.0
2019-11-13 15:01:29 -06:00
Winston Chang
de30a65f01
Update documentation of Progress and MockShinySesssion
2019-11-13 15:01:01 -06:00
Winston Chang
0bcf613195
Update to roxygen2 7.0.0
2019-11-13 12:10:57 -06:00
Winston Chang
89fd9004d0
Merge pull request #2585 from rstudio/jeff/feature/test
...
Add a test runner
2019-11-13 11:53:00 -06:00
trestletech
b2be108db1
Add a message to clarify what app is being tested, support setting progress on mock session.
2019-11-13 11:43:50 -06:00
trestletech
6102c44b70
Attempt to pin roxygen2
2019-11-07 13:26:15 -06:00
trestletech
327cdc8e41
Don't use GH deps for appveyor
...
see 89feba870d .
2019-11-07 12:51:03 -06:00
trestletech
0bc3613989
PR feedback
2019-11-06 15:58:30 -06:00
Jeff Allen
30cea871f9
Expand testServer/Module docs ( #2694 )
...
* Merge and expand testmodule/server docs
* Alos->also
2019-11-06 20:29:44 +00:00
trestletech
5f332fe4db
Set working dir in testServer so the app runs in the proper dir.
2019-11-01 16:52:43 -05:00
trestletech
7ee7f2716b
Load shiny and inherit from global env. Non-error are no NA and errors are passed through.
2019-11-01 16:40:45 -05:00
trestletech
5e8c39cb1e
Add entry in pkgdown
2019-11-01 11:26:23 -05:00
trestletech
ee355200b3
Rename testApp -> runTests
2019-11-01 11:25:47 -05:00
trestletech
986fbe2254
Merge remote-tracking branch 'origin/master' into jeff/feature/test
2019-11-01 11:23:24 -05:00
Jeff Allen
32f93a2be1
Integration Testing Docs ( #2691 )
...
* Update roxygen and regenerate.
Mostly just whitespace changes and `code` -> `verb`.
* R6 documentation for MockShinySession
* Install roxygen from GH
* % are now auto-escaped
(We still need to go find the rest)
* Fixed the ramining \% in roxygen
Found looking for ^#'.*\\% in all R files, so I believe this is all of them.
* Regenerate docs
* Decreate indent in roxygen so paragraphs don't get interpreted as code blocks.
https://github.com/r-lib/roxygen2/issues/948#issuecomment-546386172
* Namespace
* Add MockShinySession reference to pkgdown.
* Clean up test warnings
* Export session
2019-11-01 02:33:58 +00:00
Winston Chang
ab79065c13
Merge pull request #2690 from rstudio/wch-date-color
...
Datepicker: make disabled months and years lighter gray
2019-10-31 12:16:18 -05:00
Winston Chang
77171b7894
Make cursor indicate when dates are not selectable
2019-10-31 12:09:18 -05:00
Winston Chang
cce8ddb84f
Update NEWS
2019-10-30 16:05:55 -05:00
Winston Chang
648b7e5911
Datepicker: make disabled months and years lighter gray
2019-10-30 16:01:29 -05:00
Jeff Allen
67a66fdc93
Merge pull request #2682 from rstudio/jeff/int-test
...
Introduce integration testing framework
2019-10-30 18:36:44 +00:00
trestletech
5fbaa26d05
Remove vignette.
2019-10-30 11:29:58 -04:00
trestletech
1f4a3c4fd2
Regenerate docs
2019-10-28 23:14:25 -04:00
trestletech
959dc7ffd4
PR feedback
2019-10-28 22:57:30 -04:00
trestletech
0e34221cac
How do I still get paid to do this?
2019-10-25 16:54:10 -05:00
trestletech
0cad13b3a3
Placeholder docs for MockShinySession
...
(More to come in subsequent PR)
2019-10-25 16:47:10 -05:00
trestletech
0776f71ca3
Export session
2019-10-25 16:27:45 -05:00
trestletech
5a74e369ce
Implement missing test.
2019-10-25 16:23:16 -05:00
trestletech
799c5ac662
Clean up test warnings
2019-10-25 16:20:33 -05:00
Jeff Allen
1080cf0ef4
Merge pull request #2686 from rstudio/jeff/autoload
...
Message when autoloading R/ files
2019-10-25 20:16:42 +00:00
trestletech
867d49e3fb
Pin to the beginning of the file path.
2019-10-25 15:02:39 -05:00
trestletech
c7be406099
Change URL
2019-10-25 14:21:32 -05:00
trestletech
37257e77ce
Disable autoloading with a R/_disable_autoload.R file.
2019-10-25 14:14:46 -05:00
trestletech
270d9ff0fc
Add message about loading R/
2019-10-25 14:02:50 -05:00
trestletech
34b48598d9
Merge remote-tracking branch 'origin/master' into jeff/int-test
2019-10-25 11:23:15 -05:00
trestletech
5105ecb148
Cleaning up the vignette
2019-10-24 14:46:54 -05:00
trestletech
f47b151458
Test improvements for Windows and make CHECK pass.
2019-10-24 11:50:07 -05:00
Jeff Allen
d3f15a58fc
Merge pull request #2675 from rstudio/jeff/mock-session
...
Introduce a MockShinySession object
2019-10-24 15:21:30 +00:00
trestletech
42f6adb7fa
Handle Joe's feedback.
2019-10-24 10:20:54 -05:00
trestletech
263f8a8e7d
Introduce integration testing functionality
2019-10-24 10:07:23 -05:00
trestletech
3a42d30cfd
Simplify run_now()
2019-10-24 09:53:37 -05:00
trestletech
9275217a5a
Refine which methods merit warnings
2019-10-22 15:43:26 -05:00
trestletech
1fed19ad68
Export flushReact method
2019-10-22 09:59:20 -05:00
trestletech
6a8a78abd1
Bring in promise helpers and test for getOutput auto-flushing
2019-10-22 09:47:09 -05:00
trestletech
de69f51084
Rename parameter, destroy old outputs
2019-10-22 09:43:37 -05:00
Winston Chang
c81a3f39fd
Update NEWS
2019-10-21 16:57:01 -05:00
Winston Chang
6fcb925e34
Merge pull request #2652 from ahmohamed/master
...
Fix debounce() behavior when r() throws an error
2019-10-21 16:54:59 -05:00
Winston Chang
8823b7280a
Merge branch 'master' into hadley-text-doc
2019-10-21 16:45:53 -05:00
Winston Chang
ebadad97a8
Merge pull request #2612 from hadley/file-type
...
Improve inputFile() accept documentation
2019-10-21 16:43:01 -05:00
Winston Chang
a095c39626
Merge pull request #2616 from hadley/bookmarking-docs
...
Tweak shinyApp docs about bookmarking
2019-10-21 16:42:07 -05:00
Winston Chang
fb9bcb44c3
Merge branch 'insert-remove-ui' of https://github.com/hadley/shiny into hadley-insert-remove-ui
2019-10-21 16:40:06 -05:00
trestletech
38f593450a
PR feedback
2019-10-21 15:35:05 -05:00
trestletech
6d44f2c5cb
Align default parameter values with real session
2019-10-21 15:32:37 -05:00
trestletech
d1786a64c4
Try to fix failing Windows test
...
Perhaps Sys.time isn't high enough resolution there?
2019-10-18 15:33:07 -05:00
trestletech
616ae99c0b
Include equality in scheduling comparisons
...
In real life, the odds that a Sys.time() call is going to hit this equality branch is pretty small as the clock is so precise. However, for testing it's nice to be able to say "this should fire in 10ms, now elapse 10ms" and then confirm that it fired. Without this, you have to pad your delays in order to see the event trigger.
2019-10-18 15:22:03 -05:00
trestletech
4d2ff80788
Introduce MockShinySession
2019-10-18 15:20:44 -05:00
Jeff Allen
005295fd4c
Merge pull request #2665 from rstudio/jeff/session-timers
...
Best-effort task scheduling through the session
2019-10-18 20:12:22 +00:00
trestletech
d6b46f8243
Bring back the good parts of a003
2019-10-18 13:58:42 -05:00
trestletech
bac35e8f1b
Revert "PR feedback. Broke tests because of dependency on session, though, so might revert."
...
This reverts commit a003c4da85 .
2019-10-18 13:50:30 -05:00
trestletech
a003c4da85
PR feedback. Broke tests because of dependency on session, though, so might revert.
2019-10-17 14:01:58 -05:00
trestletech
0ae8e4fe8a
Consolidate to two Timer classes and simplify conditionals
2019-10-16 14:49:01 -05:00
trestletech
d3667dfc77
Attempt to get the current time from the session, if available.
2019-10-15 15:32:59 -05:00
trestletech
54c5467dc6
Unrelated: fix autoload tests.
2019-10-15 15:02:16 -05:00
trestletech
d01f0300a5
Add mock timer class
2019-10-15 14:59:36 -05:00
trestletech
bff207008f
Best-effort task scheduling through the session
...
Currently a no-op change, as the session just passes through to the global scheduleTask implementation. But this allows us to mock the method for testing.
2019-10-15 14:24:10 -05:00
trestletech
ed739f95ff
Revert "Best-effort task scheduling through the session"
...
This reverts commit bb4de1336c .
2019-10-15 14:22:31 -05:00
trestletech
bb4de1336c
Best-effort task scheduling through the session
...
Currently a no-op change, as the session just passes through to the global scheduleTask implementation. But this allows us to mock the method for testing.
2019-10-15 14:21:44 -05:00
Winston Chang
f7205558d2
Make shiny.autoload.r default to TRUE ( #2659 )
...
* Make shiny.autoload.r default to TRUE
* Update comments
2019-10-15 12:24:39 -05:00
Winston Chang
1318544ecf
Update NEWS
2019-10-11 14:58:17 -05:00
Winston Chang
a81c161434
Merge pull request #2658 from rstudio/fix-data-table
...
Preserve matrix dimensions in dataTablesJSON
2019-10-11 14:56:21 -05:00
Winston Chang
73acdc755f
Merge pull request #2650 from rstudio/wch-travis-r-versions
...
Run Travis checks on more R versions
2019-10-10 10:18:21 -05:00
Winston Chang
dd84ea8fda
Merge branch 'master' into wch-travis-r-versions
2019-10-10 10:17:33 -05:00
Winston Chang
a2a4e40821
Bump version to 1.4.0.9000
2019-10-10 10:06:12 -05:00
Winston Chang
509f54d68c
Merge tag 'v1.4.0'
...
shiny 1.4.0 on CRAN
2019-10-10 10:04:03 -05:00
Winston Chang
27ce460ea4
Preserve matrix dimensions in dataTablesJSON. Fixes #2653
2019-10-08 16:04:03 -05:00
Alan Dipert
116794ad77
Use pkgdown for reference page generation ( #2651 )
...
* Add _pkgdown.yml, remove inst/staticdocs/index.r
* Update pkgdown.yml
* Fix pkgdown (nee staticdocs) test so that it fails as it should
* Fix pkgdown test by adding shinyServer and shinyUI to list of intentionally unindexed functions
* Remove old staticdocs test
* Fix "Boilerplate" section of reference docs
* Fix CMD CHECK
* Fix typo
* Use file-based test in get_exported()
* Skip pkgdown check on CRAN
* Fix typo in pkgdown test
2019-10-07 15:18:26 -05:00
Winston Chang
89feba870d
Don't use dependency release candidates in Travis
2019-10-07 14:51:36 -05:00
Winston Chang
2a980601c0
Use absolute URL for CONTRIBUTING.md
2019-10-07 12:26:37 -05:00
Winston Chang
e1fd8ae910
Fix CONTRIBUTING.md link
2019-10-07 12:24:54 -05:00
Joe Cheng
9cb415008c
Update link
2019-10-04 16:16:32 -07:00
Ahmed Mohamed
26ba9bf94a
Fix debounce() behavior when r() throws an error
2019-10-04 11:58:22 +10:00
Winston Chang
fb091ca195
Restructure NEWS
2019-10-02 15:26:14 -05:00
Winston Chang
99a7dca3ce
Relax test so it passes on R 3.3 and below
2019-09-30 16:28:38 -05:00
Winston Chang
a1a03d94be
Run Travis on more R versions
2019-09-30 16:05:31 -05:00
trestletech
85a2d41a72
Merge remote-tracking branch 'origin/master' into jeff/feature/test
2019-09-30 09:55:11 -05:00
Jeff Allen
89bd7e9011
Merge pull request #2647 from rstudio/jeff/cla
...
Update contributing instructions for cla-assistant.
2019-09-30 14:48:38 +00:00
trestletech
ececdf42a7
Update contributing instructions for cla-assistant.
2019-09-30 09:46:57 -05:00
Jeff Allen
2cf03de8b8
Don't notify slack on success
2019-09-27 18:07:08 +00:00
Winston Chang
c8daa1730b
Merge pull request #2643 from rstudio/wch-fix-stack-tests
...
Disable stack tests on CRAN
2019-09-26 16:59:58 -05:00
Winston Chang
d195b595dd
Disable call stack tests on CRAN
2019-09-26 16:23:52 -05:00
Barret Schloerke
ff3f7adff2
Merge pull request #2637 from rstudio/rc-barret-utils-packageVersion
...
Namespace packageVersion
2019-09-24 18:13:24 -04:00
Barret Schloerke
37781a9df7
namespace packageVersion
2019-09-24 17:36:45 -04:00
Joe Cheng
ca1c60e00e
Merge pull request #2632 from rstudio/carson/jquery-legacy
...
Opt-in to jQuery 1.12.1
2019-09-20 17:52:37 -07:00
Carson
649f382291
Library updates -> Potentially breaking changes
2019-09-20 15:43:38 -05:00
Carson
103a35c81b
review feedback
2019-09-20 15:43:38 -05:00
Carson
5af341bfdb
document
2019-09-20 15:43:38 -05:00
Carson
7c7110cd83
Do nothing if the package isn't installed or meets the version requirement
2019-09-20 15:43:38 -05:00
Carson
c4ea489bff
news feedback
2019-09-20 15:43:38 -05:00
Carson
60b3b6ff03
jquery legacy is 1.12.4, not 1.12.1
2019-09-20 15:43:38 -05:00
Carson
1510dca065
update news
2019-09-20 15:43:38 -05:00
Carson
2c49375928
Provide an option, shiny.jquery.version, to opt-in into jQuery 1.12.1
2019-09-20 15:43:38 -05:00
Carson
f9fc22c48b
Emit an upgrade message if an old version htmlwidgets is installed
2019-09-20 15:43:38 -05:00
Alan Dipert
8d14e7ab04
Merge pull request #2625 from rstudio/fix-selectize-update
...
Fix updateSelectizeInput(), fixes #2624
2019-09-20 12:35:47 -07:00
Alan Dipert
8f2a28a1f2
Fix #2624 by aligning select* input handling of groups with that of updateSelect*
2019-09-19 20:16:36 +00:00
Carson Sievert
e8fb1faec0
Merge pull request #2623 from rstudio/carson/rc-ci
...
Fix travis build for 1.4.0
2019-09-18 13:51:46 -05:00
Carson
0e4874c412
have appveyor run github versions as well
2019-09-18 13:36:22 -05:00
Carson
933630af28
Update stack call test expectation in light of https://github.com/rstudio/promises/commit/9ebad6#diff-1220ed154f06164c0a2d6cc053c1f3c1R134
2019-09-18 13:28:32 -05:00
Carson
ff87098102
Temporarily install rc branches to get Travis passing
2019-09-18 12:58:23 -05:00
Winston Chang
6513a86bbd
Merge pull request #2621 from rstudio/carson/bugfix/avoid-offsetX
...
Use pageX/pageY instead of offsetX/offsetY
2019-09-18 12:42:58 -05:00
Carson
97e296c5d5
Use pageX/pageY instead of offsetX/offsetY to determine if a second click is too far away before triggering a double-click event. Closes #2620
2019-09-17 17:49:20 -05:00
Winston Chang
9f87adf4e8
Merge pull request #2619 from rstudio/wch/eslint-rules
...
Better checking for implicit globals in JS
2019-09-17 15:18:05 -05:00
Joe Cheng
6470b3f08c
Fix 062-submitbutton-demo
...
1) In srcjs/input_rate.js line 284, the global variable `name` was
being written to.
2) In a couple of other places in that file, the global variable
`name` was being read instead of `nameType`--the result of an
incomplete refactor.
Also added an eslint rule to prevent this and other globals from
being read implicitly.
2019-09-17 12:55:47 -07:00
Joe Cheng
d1ba84525e
Update version number inserted by Grunt
2019-09-17 12:41:02 -07:00
Winston Chang
05ad66c464
Better checking for implicit globals
2019-09-17 14:09:11 -05:00
Winston Chang
c41d38bf61
Document insertUI() and removeUI() together
...
Since they share so many arguments. I also updated the style of the roxygen comments.
2019-09-17 07:55:53 -05:00
Hadley Wickham
b155e8480b
Update docs
2019-09-16 12:30:50 -05:00
Hadley Wickham
e94f687573
Tweak shinyApp docs about bookmarking
2019-09-16 08:00:14 -05:00
Hadley Wickham
5883082d01
Improve inputFile() accept documentation
...
* accept should be a vector of "unique file type identifiers" not a vector of mime types (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Unique_file_type_specifiers )
* I updated the example to use req() and to validate the uploaded extension; this is good practice since not all browsers will enforce `accept`
2019-09-15 09:07:16 -05:00
Hadley Wickham
75b53ffda1
Combine documentation for textOutput() and verbatimTextOutput()
...
And generally polish docs
2019-09-14 09:10:59 -05:00
Joe Cheng
a8057b96f3
Update version dependencies
2019-09-13 13:45:45 -07:00
Joe Cheng
a89e809498
Bump version to 1.4.0
2019-09-13 13:01:25 -07:00
Winston Chang
02f7a4fdc9
Rebuild documentation
2019-09-12 18:40:35 -05:00
Carson Sievert
7c7c22a597
Document default values of shiny's options ( #2597 )
...
* Document default values of shiny's options, closes #2558
* A more general description of shiny.port's default
2019-09-12 18:31:07 -05:00
Winston Chang
860fa525a2
Merge pull request #2605 from hadley/notification-id
...
Clarify use of id argument
2019-09-12 18:20:17 -05:00
Carson Sievert
9f0e38a28a
Merge pull request #2601 from rstudio/layoutFamily
...
Layout Rd family
2019-09-12 13:09:00 -07:00
Jeff Allen
f834b7befb
Define what all input functions yield for server ( #2600 )
...
* adding section to roxygen docs for server value of input funcs
* add more server values to roxygen docs
* add more server values
* update more server values in documentation
* Address PR feedback
I reflowed the comments to have a max width of 80 on some files, so there were a flurry of line changes, but the only substantive changes were around Joe's comments.
* Update R/input-slider.R
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com >
* Apply suggestions from code review
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
* PR feedback, regenerate docs.
* PR Feedback
* Eliminate extra newline
* passwordInput()'s server value
* varSelectInput()'s server value
* document
2019-09-12 20:02:44 +00:00
Winston Chang
7f3a45fb5b
Merge pull request #2560 from rstudio/barret-reactlog-keybindings
...
Use ctrl/cmd + shift + f3 to mark reactlog and Return a 501 error code if reactlog disabled
2019-09-12 10:29:57 -05:00
Barret Schloerke
b0953e810b
merge master
2019-09-12 10:26:38 -04:00
Hadley Wickham
52a86012e5
Update R/notifications.R
...
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
2019-09-12 09:09:09 -05:00
Hadley Wickham
2a06fe6baf
Clarify use of id argument
2019-09-12 08:28:27 -05:00
Carson
6e688d2175
add fillPage() to the family as well
2019-09-11 16:30:25 -05:00
Carson
b610fd1f56
Hadley's feedback
2019-09-11 16:29:48 -05:00
Carson
a4730096f4
code review
2019-09-11 15:23:41 -05:00
leslie-huang
6a02439944
add @ family to all layout functions
2019-09-11 15:15:38 -05:00
Carson Sievert
b889b0d2b0
Merge pull request #2582 from rstudio/barret_showcase_hidden_wide
...
Fix showcase bug where hidden by default on wide window
2019-09-11 10:59:18 -07:00
Carson
ba5733e4a4
add news item
2019-09-11 12:34:20 -05:00
Carson Sievert
2e0221ecfd
Merge pull request #2592 from rstudio/set-min-max
...
Exit early if date parsing fails
2019-09-09 13:55:08 -07:00
Carson
aeded79544
yarn build
2019-09-09 15:43:41 -05:00
Carson
c0a7958e77
update news
2019-09-09 15:18:41 -05:00
Carson
431b194ec2
Exit early if date parsing fails in _setMin() and _setMax(), closes #2591
2019-09-09 13:48:18 -05:00
Joe Cheng
29d24d7e08
Merge pull request #2586 from rstudio/resourcePathChangesOption
...
Suppress resource path changes by default
2019-09-06 13:20:35 -07:00
Winston Chang
3b04c642ae
Bump httpuv version dependency
2019-09-06 11:47:58 -05:00
Winston Chang
609fc5b0c0
Fix typo
2019-09-06 11:46:58 -05:00
Winston Chang
2a8c79b577
Merge pull request #2588 from rstudio/wch-slider-phantom
...
Add try-catch to ion.rangeSlider
2019-09-06 10:52:25 -05:00
Winston Chang
043316e40f
Clarify comments
2019-09-06 10:52:08 -05:00
Joe Cheng
c9d8b987d4
Merge pull request #2522 from rstudio/wch-fix-reactivepoll-leak
...
Fix reactivePoll leak
2019-09-05 16:44:57 -07:00
Joe Cheng
33c5a5c665
Fix unit test
2019-09-05 16:12:07 -07:00
Winston Chang
29c90ba163
Code review fixes
2019-09-05 16:12:07 -07:00
Winston Chang
8c19450b10
Use safer method to remove observer
2019-09-05 16:11:47 -07:00
Winston Chang
89c97458c4
Update NEWS
2019-09-05 16:11:47 -07:00
Winston Chang
02be516902
Use safer finalizer for reactivePoll
2019-09-05 16:11:47 -07:00
Winston Chang
47ada300ea
Fix reactivePoll leak
2019-09-05 16:11:19 -07:00
Carson
6f9c621774
Always suppress for now
2019-09-05 17:22:56 -05:00
trestletech
324d9195c3
Merge remote-tracking branch 'origin/wch-slider-phantom' into jeff/feature/test
2019-09-05 16:51:49 -05:00
Winston Chang
0310fe3b68
Automate patches for ion.rangeSlider
2019-09-05 16:00:56 -05:00
Winston Chang
7144a6e4b7
In ion.rangeSlider, wrap removeProp() in try-catch. Closes #2587
2019-09-05 15:53:37 -05:00
Carson
1c8071a96f
Add shiny.resourcePathChanges option to get more information about resource path changes for a given prefix.
...
Closes #2584
2019-09-05 13:44:21 -05:00
trestletech
4ad115e024
Load the helpers before the tests -- into an ancestor environment of the tests'.
2019-09-05 09:46:34 -05:00
trestletech
f11d754cfe
Add a filter to test
2019-09-05 09:45:06 -05:00
trestletech
65019ce96f
Add namespace rewire option.
...
Return the right structure from shinytest tests and add unit tests.
2019-09-05 09:44:56 -05:00
trestletech
90e8fb2a57
Adding a test runner
2019-09-05 09:44:40 -05:00
Carson Sievert
ff5377da9e
Merge pull request #2583 from rstudio/carson_resource_warning
...
Fix spacing in warning for resource paths conflicting with www/ subdirs
2019-09-04 11:27:09 -07:00
Carson
7aee84eb05
Fix spacing in warning for resource paths conflicting with www/ subdirs
2019-09-04 11:52:31 -05:00
Barret Schloerke
c0a7a6d0d6
don't hide the current element, instead make sure new element is hidden before fading in
2019-09-04 12:44:08 -04:00
Barret Schloerke
29c48471f2
hide the prior element, not the new element
2019-09-04 12:24:49 -04:00
Barret Schloerke
229e56464b
if no code tab exists, do not attempt to highlight it
2019-09-04 12:24:20 -04:00
Joe Cheng
769c32fd38
Merge pull request #2580 from hadley/shinyApp-docs
...
shinyApp() documentation improvements.
2019-09-04 08:12:17 -07:00
Joe Cheng
d05b89cfb3
Merge pull request #2581 from hadley/shinyApp-args
...
Clarify required argumented to shinyApp()
2019-09-04 08:08:44 -07:00
Hadley Wickham
f1f18a2334
Clarify required argumented to shinyApp()
...
This does technically change the interface as `shinyApp(server = function(input, output) ...))` would have previously worked, but it didn't generate a useful app.
Fixes #2462
2019-09-04 09:57:19 -05:00
Hadley Wickham
afc556f801
More details about server argument
...
Fixes #2508
2019-09-04 09:46:57 -05:00
Hadley Wickham
7f240839fc
Document shiny.appobj in own file
...
Fixes #2458
2019-09-04 09:44:48 -05:00
Joe Cheng
8d0a6274cb
Merge pull request #2579 from rstudio/wch-fix-sleep
...
Remove Sys.sleep in runApp()
2019-09-03 14:11:29 -07:00
Winston Chang
91cab10ff8
Remove Sys.sleep in runApp()
2019-09-03 15:09:51 -05:00
Joe Cheng
5828ea7426
Merge pull request #2577 from hadley/print-methods
...
Implement two missing print methods
2019-09-03 08:14:51 -07:00
Joe Cheng
80ba147168
Merge pull request #2566 from rstudio/fix-statichandler-backslash
...
Disallow backslash in staticHandler paths
2019-09-03 07:50:35 -07:00
Joe Cheng
f85479ba11
Merge pull request #2570 from rstudio/joe/misc/update-node-deps
...
Upgrade yarn dependencies
2019-09-03 07:49:51 -07:00
Joe Cheng
a23c5f151f
Merge pull request #2569 from hadley/pageWithSidebar
...
Soft-deprecate pageWithSidebar() and headerPanel()
2019-09-03 07:49:29 -07:00
Joe Cheng
cab3601474
Merge pull request #2568 from hadley/doc-combine
...
Document all sidebar UI components together
2019-09-03 07:48:44 -07:00
Joe Cheng
cf330fcd58
Merge pull request #2575 from hadley/options-docs
...
Combine shinyOptions and shiny-options
2019-09-03 07:47:32 -07:00
Hadley Wickham
eb0162dccf
Add basic print method for shiny.render.function
...
So at least the user isn't exposed to a bunch on internals
2019-09-03 09:17:02 -05:00
Hadley Wickham
a415aed7e6
Implement print.reactivevalues
2019-09-03 09:13:43 -05:00
Hadley Wickham
9f6014dc0b
Remove from index
2019-09-02 09:14:20 -05:00
Hadley Wickham
21b0d38b57
Minor formatting tweaks
2019-09-02 09:14:15 -05:00
Hadley Wickham
1ec7f22b5f
Alphabetise options
2019-09-02 09:03:46 -05:00
Hadley Wickham
346c5e4a4c
Merge shinyOptions and shiny-options
...
Including an alias so that ?"shiny-options" will continue to work.
Fixes #2544
2019-09-02 08:59:58 -05:00
Joe Cheng
c9a0f0a713
Merge pull request #2567 from hadley/reactive-plot-size-docs
...
Clarify the three inputs to width/height
2019-08-29 16:24:46 -07:00
Joe Cheng
8bbc38dc8a
Upgrade yarn dependencies
...
This prevents GitHub from complaining about a security vulnerability
in es-lint.
2019-08-29 12:27:29 -07:00
Hadley Wickham
96494a22f9
Soft-deprecate pageWithSidebar() and headerPanel()
...
Fixes #2452
2019-08-29 08:27:36 -05:00
Hadley Wickham
0813789e2a
Cross-link tabPanel() to navbarPage()
2019-08-29 08:15:19 -05:00
Hadley Wickham
98ca820ab1
Document sidebarPanel() and mainPanel() with sidebarLayout()
2019-08-29 08:09:22 -05:00
Hadley Wickham
81ca9d9f29
Co-locate all sidebarLayout() functions
2019-08-29 08:00:40 -05:00
Hadley Wickham
16fe0019f9
Clarify the three inputs to width/height
2019-08-29 07:30:09 -05:00
Barret Schloerke
5fa650ab75
Merge pull request #2559 from rstudio/barret-trim-showcase-info
...
Reduce the information sent to shiny showcase
2019-08-28 17:27:16 -04:00
Winston Chang
564c2a0f16
Disallow backslash in staicHandler paths
2019-08-28 15:42:09 -05:00
Barret Schloerke
1685e1c310
Merge branch 'master' into barret-reactlog-keybindings
...
* master: (22 commits)
Fix upper-case test
autload
- update NEWS - only source global in server.R mode - only use intermediary environment if opted-in to autoloading.
Only use loadSupport if opted-in to autload.r
Fix default param
Make loading helpers opt-in.
Clarify docs
Update to new signature in test.
Move global.R sourcing into an exported load function
Only load top-level R files in R/
Require capitalized R/ dir.
Correct mistake around app.R in global
Add news
Fix options test
Test ui/server/app/global sourcing.
Revert "DI the source function for testing."
DI the source function for testing.
Load helpers into isolated environment
Fix expectations.
Add dynamically-generated case-sensitive test.
...
2019-08-28 12:26:39 -04:00
Barret Schloerke
332f5a1266
add js for opening broken reactlog routes
2019-08-28 12:24:17 -04:00
Jeff Allen
99ac85f06a
Merge pull request #2547 from rstudio/jeff/feature/helpers
...
Automatically load 'helpers' in R/ directory at runtime
2019-08-28 16:19:07 +00:00
trestletech
fc30ad0935
Fix upper-case test
2019-08-28 11:05:04 -05:00
trestletech
aadf2eb609
Merge remote-tracking branch 'origin/master' into jeff/feature/helpers
2019-08-28 10:29:32 -05:00
trestletech
68f778e423
autload
2019-08-28 10:26:31 -05:00
trestletech
0066cff652
- update NEWS
...
- only source global in server.R mode
- only use intermediary environment if opted-in to autoloading.
2019-08-28 10:20:42 -05:00
trestletech
f872a0c80a
Only use loadSupport if opted-in to autload.r
2019-08-28 10:15:11 -05:00
Barret Schloerke
68d67a8194
Update NEWS.md
2019-08-27 17:51:10 -04:00
Barret Schloerke
756ac1514c
Use ctrl/cmd + shift + f3 to mark reactlog; return a 501 error code for reactlog paths when reactlog is disabled
...
Open a new webpage even if only marking a time.
2019-08-27 17:50:46 -04:00
Barret Schloerke
d9478142b1
Merge pull request #2561 from rstudio/barret-fix-master
...
Fix master docs
2019-08-27 17:38:27 -04:00
Winston Chang
5eced59961
Rebuild JS files
2019-08-27 16:31:29 -05:00
Winston Chang
3e1862cd51
Merge pull request #2526 from rstudio/setDateBounds
...
Set min/max date after date value when they land on the same day
2019-08-27 16:30:49 -05:00
Barret Schloerke
7271609850
ignore any node_modules-like named folder
2019-08-27 17:24:25 -04:00
Barret Schloerke
f24337bb3b
add messages in htmltools script to notify about version number
2019-08-27 17:14:51 -04:00
trestletech
6167247ea2
Fix default param
2019-08-27 15:59:27 -05:00
Barret Schloerke
0332e52501
remove unneeded method roxygen tag
2019-08-27 16:50:33 -04:00
trestletech
0c23f78ab7
Make loading helpers opt-in.
2019-08-27 15:29:58 -05:00
Barret Schloerke
7624449644
add import htmltools statement
2019-08-27 16:17:20 -04:00
Barret Schloerke
97309e8c4c
execute tools/updateHtmltoolsMan.R
2019-08-27 14:44:39 -04:00
Barret Schloerke
a1e78214db
Create updateHtmltoolsMan.R
2019-08-27 14:34:33 -04:00
Barret Schloerke
1a57b3296b
use htmltools remote
2019-08-27 14:32:25 -04:00
trestletech
7c10fc3514
Merge remote-tracking branch 'origin/master' into jeff/feature/helpers
2019-08-27 12:54:06 -05:00
Jeff Allen
494ef42aa8
Clarify docs
2019-08-27 17:46:17 +00:00
Carson
8a54d216c6
better news description
2019-08-27 10:47:10 -05:00
Carson
896a20d76d
set start/end date after setting date if they land on the same day, closes #2335
2019-08-27 10:30:38 -05:00
Barret Schloerke
a26510b02f
copy in latest man files from htmltools
...
* fix staticdocs test
* remove hasTagAttributes and getTagAttributes from man file
2019-08-26 15:30:27 -04:00
Barret Schloerke
1465f1d237
add roxygen tag to enforce s3 method for checking
2019-08-26 15:27:36 -04:00
Joe Cheng
21b18d107a
Merge pull request #2166 from rstudio/unexport-knit-print
...
Un-export knit_print methods from htmltools
2019-08-26 14:29:16 -04:00
Joe Cheng
cc2173c587
Merge pull request #2555 from rstudio/wch-fix-invalidatelater-leak
...
Fix invalidateLater memory leak
2019-08-26 13:51:34 -04:00
Winston Chang
71fe821ae9
Update NEWS
2019-08-26 11:28:45 -05:00
Winston Chang
3ffab69ad6
Register shiny's knit_print methods on load
2019-08-26 11:28:19 -05:00
Winston Chang
58a662bd35
Merge branch 'master' into unexport-knit-print
2019-08-26 11:04:40 -05:00
Barret Schloerke
eb55c256c7
only send requried information across wire to browser for showcase mode
2019-08-26 10:52:27 -04:00
Winston Chang
b07e553b9e
Merge pull request #2557 from rstudio/barret-upgrade-bootstrap-jqui
...
Upgrade Bootstrap (v3.4.1) and jQuery (v3.4.1)
2019-08-23 12:19:16 -05:00
Winston Chang
2d61709de3
Update reactiveValuesToList documentation
2019-08-23 11:48:29 -05:00
Barret Schloerke
1352e1d92d
move news item to library updates and state 'resolved'
2019-08-23 12:47:40 -04:00
Barret Schloerke
b595c3b902
update htmldeps versions for jquery and bootstrap
2019-08-23 12:47:20 -04:00
Barret Schloerke
76efb01c4c
add news item about upgrading bootstrap and jquery versions
2019-08-23 11:06:09 -04:00
Winston Chang
0078945b79
Fix link
2019-08-23 10:00:55 -05:00
Barret Schloerke
70d8ef0b8e
update license info for bootstrap and jquery
2019-08-23 11:00:06 -04:00
Barret Schloerke
9a1f7cba68
change jquery v1.12.4 -> v3.4.1
2019-08-23 10:37:21 -04:00
Barret Schloerke
39e14acffe
change bootstrap v3.3.7 -> v3.4.1
2019-08-23 10:36:16 -04:00
Alan Dipert
a6149390a0
Fix selectInput/selectizeInput handling character(1) options ( #2540 )
...
* selectInput/selectizeInput: Fix handling of character(1) choices
* Re-document
* Add .github to .Rbuildignore
* Expand comment, don't import stats
* Add test for 013-selectize regression
* Expand comment
* Split listify into series of passes
* Thouroughly overhaul and comment choicesWithNames()
* No recursion
* Comment new "flat" choice processing machinery
* Remove unneccesary test of choice tree with depth > 2
* Test for choices idiomatically
* Tweak comment for asCharacter
* Comment odd test, add a new test for single-item list
* Handle empty non-lists correctly, add test
* Add test ensuring empty lists come back named
* Add comment/assertion stipulating processGroupedChoices() takes only lists
2019-08-22 21:23:38 -05:00
Carson Sievert
33cdc75810
Throw an informative warning if a subdirectory of www clashes with another static path ( #2434 )
...
* Throw an informative warning if a subdirectory of www clashes with another static path, fixes #2433
* check all pairwise combinations of resource mappings
* Check for www subdir conflicts at startApp() time
* fix warning message
* review feedback; update news
2019-08-22 16:58:41 -05:00
Winston Chang
13f229089d
Merge pull request #2459 from rstudio/resources
...
Introduce removeResourcePath()
2019-08-22 16:13:13 -05:00
Winston Chang
2dbb0fca85
Merge branch 'master' into resources
2019-08-22 16:12:58 -05:00
Winston Chang
c7a8a4e30f
Update NEWS
2019-08-22 16:05:08 -05:00
Winston Chang
dc6f1a0c10
Fixes for R CMD check
2019-08-22 15:21:04 -05:00
Winston Chang
178872d651
Update fastmap version dependency
2019-08-20 13:23:55 -05:00
Barret Schloerke
e3c15493a2
Merge pull request #2545 from rstudio/barret-bug-dynamic-tab
...
Fix selected dynamic tab in deployed environments
2019-08-19 14:35:31 -04:00
Barret Schloerke
3f22e5da2d
add news item
2019-08-19 14:24:42 -04:00
Winston Chang
39ee4513c6
Fix invalidateLater memory leak. Closes #2267
2019-08-19 12:21:12 -05:00
Barret Schloerke
598898f0a1
use boostrap url stripper regex to remove url before looking for relative tag location
2019-08-15 11:29:50 -04:00
trestletech
052e783638
Update to new signature in test.
2019-08-14 14:35:19 -05:00
trestletech
d2deda238a
Move global.R sourcing into an exported load function
2019-08-14 14:25:05 -05:00
trestletech
7317a8304f
Only load top-level R files in R/
...
Ignores nested directories to better follow R package conventions. We want to align well so that this structure is portable to golem.
2019-08-12 15:03:50 -05:00
trestletech
5ea9d70fb4
Require capitalized R/ dir.
2019-08-12 14:59:16 -05:00
Jeff Allen
a73e0998bc
Correct mistake around app.R in global
2019-08-09 16:22:03 +00:00
trestletech
51befe3e27
Add news
...
and other minor changes from self-review
2019-08-08 15:55:08 -05:00
trestletech
37569a291b
Fix options test
2019-08-08 14:48:19 -05:00
trestletech
7fe973145d
Test ui/server/app/global sourcing.
2019-08-08 11:44:01 -05:00
trestletech
da3fc276fd
Revert "DI the source function for testing."
...
This reverts commit c2dfea18c4 .
2019-08-08 09:35:07 -05:00
trestletech
4c0af8b1c0
Revert "Break master 😈 "
...
This reverts commit f65f7b2f1b .
2019-08-07 15:42:38 -05:00
trestletech
f65f7b2f1b
Break master 😈
...
This reverts commit 545b6c1247 .
2019-08-07 15:29:50 -05:00
trestletech
33c86ed6a7
Encrypt with --org
...
https://github.com/travis-ci/travis-ci/issues/7837
2019-08-07 14:55:44 -05:00
trestletech
545b6c1247
Revert "Break master 😈 "
...
This reverts commit 1b0e37f371 .
2019-08-07 14:09:05 -05:00
trestletech
1b0e37f371
Break master 😈
2019-08-07 14:06:55 -05:00
trestletech
97e00721e9
Add Travis Slack notifications on fail
2019-08-07 13:46:19 -05:00
Barret Schloerke
3c43301edb
remove print statement
2019-08-07 12:45:20 -04:00
Barret Schloerke
51cbb67a96
use new RegExp
2019-08-07 12:21:38 -04:00
Barret Schloerke
2e2bd80416
remove leading url when removing relative url
2019-08-07 11:06:03 -04:00
Barret Schloerke
86389ff7a3
add print to debug appendTab
2019-08-07 10:44:59 -04:00
trestletech
c2dfea18c4
DI the source function for testing.
2019-08-06 14:08:25 -05:00
trestletech
4be6bbc681
Load helpers into isolated environment
...
And scaffold out the tests.
2019-08-06 10:49:38 -05:00
trestletech
cfc0ff9cc7
Fix expectations.
2019-08-06 09:10:18 -05:00
trestletech
b4c6ba6962
Add dynamically-generated case-sensitive test.
2019-08-06 09:05:02 -05:00
trestletech
dc3ed2f79b
Support case-agnostic r/ dir loading
2019-08-05 17:33:07 -05:00
trestletech
5d95c7a9cb
Load helpers in R/ on app startup
...
No support yet for case-sensitive file systems when loading the dir.
2019-08-05 17:25:14 -05:00
Alan Dipert
6821ca6238
Merge pull request #2543 from rstudio/buildignore-github
...
Add .github to .Rbuildignore
2019-08-05 14:32:20 -07:00
Alan Dipert
167dc0a259
Add .github to .Rbuildignore
2019-08-05 20:45:27 +00:00
Winston Chang
fa9fa68693
Re-document
2019-08-05 15:22:12 -05:00
Winston Chang
353615da89
Remove fastmap from Remotes because it is on CRAN
2019-07-29 11:01:01 -05:00
Winston Chang
51de558675
Rebuild JS objects
2019-07-26 10:41:21 -05:00
Winston Chang
174fc1dda1
Update JS build dependencies
2019-07-26 10:41:07 -05:00
Carson Sievert
7caeb60c47
add some historical context in the comment
2019-07-15 16:53:51 -05:00
Carson Sievert
e3aba1b5ff
Introduce removeResourcePath() & throw message if the local path of a resource path has changed
2019-07-15 16:53:51 -05:00
Alan Dipert
1a8b36f06d
selectInput: improve factor handling ( #2524 )
...
* selectInput: handle factor choices, fixes #2515
* Handle complex vectors
* Improve tests
* New item
* Update selectInput() docs to mention factors
* Un-S3-ify listify
* Bracketify the if/else
* Moar Brackets
* Fix travis: we hope
* Use existing asNamedVector function
* Better implementation of asNamedVector
* Clarify comments
2019-07-15 14:51:13 -05:00
Winston Chang
250303790c
Bump version to 1.3.2.9001
2019-07-09 13:56:39 -05:00
Winston Chang
e20544659a
Merge pull request #2523 from rstudio/joe/feature/readable-outputs
...
Support reading of Shiny outputs
2019-07-09 12:19:54 -05:00
Joe Cheng
ad7692ed34
output$xxx should return the actual func passed in
...
...not the frankenstein one we create to clean up the stack trace
2019-07-06 13:20:44 -07:00
Joe Cheng
f9144a4be3
Make output reading compatible with modules
2019-07-05 19:22:41 -07:00
Winston Chang
0fc3b90efb
tham -> than
2019-07-03 20:52:15 -05:00
Winston Chang
25ccc8a77a
Merge pull request #2484 from rstudio/weakref
...
Use weakrefs for reactive value to reactive expression dependencies
2019-07-03 20:49:33 -05:00
Winston Chang
da18390f3e
Import and re-export fastmap::key_missing ( #2517 )
...
* Import and re-export fastmap::key_missing
* Fix for staticdocs index
2019-07-03 15:45:42 -05:00
Winston Chang
b392bf8298
Update rlang dependency info
2019-07-03 15:37:16 -05:00
Joe Cheng
73c42ebeaf
Merge pull request #2516 from rstudio/fix-shinyapp-doc
...
Remove outdated information for shinyApp()
2019-07-03 10:41:28 -07:00
Winston Chang
eb45f7fcba
Remove outdated information for shinyApp()
2019-06-28 22:31:29 -05:00
Jeff Allen
5fdca29448
Clarify interaction between width/height and CSS/templates ( #2504 )
...
* Clarify interaction between width/height and CSS/templates
* Reword given that height is less likely to be specified in CSS.
2019-06-25 10:56:57 -05:00
Jeff Allen
048c4006e4
en dashes -> em dashes ( #2513 )
2019-06-25 10:46:52 -05:00
Jeff Allen
6d10a2dafb
Merge pull request #2510 from rstudio/jeff-md
...
Convert docs to MD
2019-06-25 13:53:07 +00:00
trestletech
d6c421f8de
Fix more hyperlinks
2019-06-20 12:03:56 -05:00
trestletech
ac4adcc62c
Fix shinyOptions hyperlinking
2019-06-20 11:51:45 -05:00
trestletech
bc8465d284
Commit generated MD with new links, not manually reviewed.
2019-06-19 15:50:47 -05:00
trestletech
7fc497eeb8
Auto-generated link conversation, not manually reviewed.
2019-06-19 15:46:13 -05:00
trestletech
633817e3d5
Manually escape another % that wasn't getting rendered properly.
2019-06-19 15:43:16 -05:00
trestletech
09dee9670a
Manually escape one % sign that wasn't getting escaped?
2019-06-19 15:42:24 -05:00
trestletech
631debbec4
Restore one \code{} block that contains inner backticks
2019-06-19 15:38:47 -05:00
trestletech
4e57bc2161
Fix syntax error with double-backticks.
2019-06-19 15:32:01 -05:00
trestletech
a111e36867
Accept harmless RD changes.
2019-06-19 15:30:55 -05:00
trestletech
152bd5841c
Accept whitespace-only RD changes.
2019-06-19 15:29:54 -05:00
trestletech
ecefdcd951
Convert R to MD
...
Used roxygen2md::roxygen2md(scope="simple")
Not manually reviewed.
2019-06-19 15:28:03 -05:00
trestletech
a976cfa98d
Remove escaping for % in preparation for MD conversion
...
Obtained by running `sed -i "" -E "s/^(.*)\\\%(.*)$/\1%\2/g" *` in the R
directory on a Mac.
2019-06-19 15:13:25 -05:00
trestletech
df70d7708d
Result of running roxygen2md(scope = "none")
...
Enables markdown. Only observed one non-whitespace difference on a line
that had used backticks previously which were previously not being
parsed as a code block.
-explicitly using the `title` parameter of the top-level page function.
+explicitly using the \code{title} parameter of the top-level page function.
2019-06-19 14:47:04 -05:00
Jeff Allen
c558d95e3b
Merge pull request #2507 from rstudio/jeff-ci-docs
...
Test for Roxygen doc & JS changes in Travis
2019-06-19 19:24:11 +00:00
trestletech
3bd4825d4b
Write errors to stderr.
2019-06-19 11:34:59 -05:00
trestletech
67cdcedd4e
Better bash
2019-06-19 11:04:39 -05:00
trestletech
384116a76f
Specify node version
2019-06-19 10:22:55 -05:00
trestletech
12e91ae643
Script to check for JS.
2019-06-19 10:09:21 -05:00
trestletech
7c56d277da
Try matrix build for Roxygen check.
2019-06-18 20:20:25 -05:00
trestletech
579a4592b8
Test for Roxygen doc changes in Travis
...
I'd prefer to do the doc check prior to the package check so that we can
fail fast in light of trivial errors, but I worry about the side-effects
of installing devtools and roxygen2 on our tests, so I'm punting those
tasks until after our CMD check.
It may be possible to parallelize this work adjacent to our package
check (and only do it on one version of R rather than all three), but I
haven't explored that yet.
Failures in the `after_script`s don't fail the build, surprisingly. The
`|| travis_terminate 1` accomplishes that. `travis_terminate` taken
from
https://github.com/travis-ci/travis-ci/issues/1574#issuecomment-164094347
`git clean` incantations found in
https://issues.jenkins-ci.org/browse/JENKINS-31924
2019-06-18 16:48:22 -05:00
Jeff Allen
9dad5e6362
Define optgroup when using ( #2502 )
2019-06-18 16:06:29 -05:00
Jeff Allen
f51b5421f2
Add sep argument to renderText ( #2497 )
...
* Add sep argument to renderText
Closes #2469
* Add link to PR
* Regenerate docs
2019-06-14 16:26:28 -05:00
Winston Chang
387907ea32
Upgrade JS build dependencies
2019-06-14 16:18:53 -05:00
trestletech
b5ca1d48e0
Add link to renderCachedPlot.
...
Closes #2476
2019-06-14 14:22:49 -05:00
trestletech
396f170738
Bundle deprecated reactive functions into a single file.
2019-06-14 14:20:31 -05:00
Jeff Allen
5514039d42
M0ar README words
...
Give a bit more detail about validating install, and avoid calling things easy.
2019-06-14 14:18:44 -05:00
Winston Chang
c90c4f3673
Suppress stack traces in tests
2019-06-14 10:59:45 -05:00
Winston Chang
41758858cf
Fix react logging for reactiveValues
2019-06-14 10:58:50 -05:00
Joe Cheng
3ff507e6b8
Merge pull request #2493 from rstudio/jeff-internal-docs
...
Mark deprecated functions as internal
2019-06-13 14:34:03 -07:00
trestletech
5199371025
Mark deprecated functions as internal.
...
This prevents them from being listed in the documentation index. Closes #2482 .
2019-06-13 15:47:20 -05:00
Winston Chang
26ad773f77
Switch from fastmap to rlang for weakref functions
2019-06-13 14:52:14 -05:00
Winston Chang
9e133e0ecc
More memory leak tests
2019-06-11 20:21:16 -05:00
Winston Chang
c4e7099229
Reactive expressions keep reference to context
2019-06-11 19:19:52 -05:00
Winston Chang
56062628f2
Use Dependents in ReactiveValues
2019-06-11 19:19:31 -05:00
Winston Chang
48a3a1dabb
Use weak references for dependents of reactive values
2019-06-10 20:43:28 -05:00
Winston Chang
ca3c2b3e26
Use weak references for reactive contexts
2019-06-06 13:35:56 -05:00
Winston Chang
d35c5c8320
Merge pull request #2479 from rstudio/wch-consistent-reactive-order
...
Ensure that observers fire in consistent order
2019-06-06 13:22:05 -05:00
Winston Chang
749a582296
Update NEWS
2019-06-04 16:12:12 -05:00
Winston Chang
6310406430
Add tests for observer order
2019-06-04 16:07:04 -05:00
Winston Chang
d26d339f97
Ensure that dependents are sorted
2019-06-04 14:02:36 -05:00
Winston Chang
17afce6fa1
Merge pull request #2429 from rstudio/wch-fastmap
...
Use fastmap as backing store for Map class
2019-05-31 15:39:34 -05:00
Joe Cheng
d3aa601798
Make Shiny outputs (optionally) readable
2019-05-31 09:25:27 -07:00
Winston Chang
8f24d667d6
Unquote key
2019-05-30 15:12:15 -05:00
Winston Chang
5cd4588ef2
Use grep(value=TRUE)
2019-05-30 14:38:05 -05:00
Winston Chang
b0a1821d95
Rebuild shiny.js
2019-05-30 14:32:52 -05:00
Winston Chang
6b835f70e6
Merge pull request #2460 from rstudio/wch-disable-plot-drag
...
Disable dragging of plots with any interactions enabled
2019-05-30 14:32:00 -05:00
Winston Chang
308bc76ac6
Disable dragging of plots with any interactions. Closes #1393 , #2223
2019-05-29 15:16:11 -05:00
Winston Chang
fd843509a1
Fix NEWS formatting
2019-05-29 11:59:13 -05:00
Winston Chang
7691cfdadb
Merge pull request #2446 from nteetor/master
...
New target for `shiny:inputchanged` event
2019-05-29 11:57:55 -05:00
nteetor
1aa9368e54
Update inputchanged news item with pr number, move to improvements
2019-05-23 20:11:44 -04:00
nteetor
180e852fee
Trigger shiny:inputchanged event on related input element ( #2442 )
2019-05-22 20:01:33 -04:00
Alan Dipert
547edd7e32
Fix feature request template
2019-05-21 11:14:02 -07:00
Winston Chang
0b46c63c31
Fix testthat version number
2019-05-16 16:43:01 -05:00
Carson Sievert
9b69ce1988
yarn build
2019-05-14 16:44:33 -05:00
Carson Sievert
57cc44f662
Coordmap info should retain discrete limits ( #2410 )
...
* ggplot2 input brushes should retain discrete range mapping, and be imposed in brushedPoints(), closes #1433
* simplify logic and reduce required storage
* get nearPoints() working as well, cleanup
* only remember scale range if ggplot is facet with a free discrete axis
* Use the scale limits (before the range) since the former is specified, that's what is actually shown on the plot
also, introduce within_brush() helper to consistently handle missing values produced by asNumber()
* also use scale limits in older versions of ggplot2
* DRY
* discrete_mapping -> discrete_limits; better comments
* update test expectation
* a couple unit tests
* update comment to reflect new coordmap data structure
* use unlink() not rm()
* add some tests for specifying scale limits and labels
* Use get_limits() if available
* update news
* better name and comment for new asNumber() argument
2019-05-14 16:34:00 -05:00
Carson Sievert
4eaa9c7ea9
Don't match text inputs with a trailing '-selectized' in their id, fixes #2396 ( #2418 )
...
* Don't match text inputs with a trailing '-selectized' in their id, fixes #2396
* update news
* parentheses
2019-05-14 16:26:32 -05:00
Winston Chang
0b6cdcc826
fastmap moved to r-lib
2019-05-14 11:46:57 -05:00
Winston Chang
7bc0a0ca39
Fix tests that assumed names in a specific order
2019-05-14 10:41:06 -05:00
Winston Chang
1ef2074a10
Fastmap objects can now be saved and loaded
2019-05-14 10:36:37 -05:00
Winston Chang
0747b2a72a
fastmap: exists() was renamed to has()
2019-05-14 10:35:50 -05:00
Alan Dipert
64b3095f2c
Removed redundant section of issue template
2019-05-10 10:07:30 -07:00
Winston Chang
ab82af122f
Merge pull request #2436 from rstudio/alan/issue-templates
...
Add issue templates
2019-05-10 12:05:35 -05:00
Alan Dipert
54fccf2e7c
Incorporate feedback from @wch
2019-05-10 10:01:03 -07:00
Alan Dipert
05e953db3a
Improve bug report template
2019-05-10 08:28:05 -07:00
Alan Dipert
f726835850
Add issue templates
2019-05-09 23:04:19 -07:00
Winston Chang
38d2809131
Convert MemoryCache to use fastmap
2019-05-09 10:20:33 -05:00
Winston Chang
d7718991a6
Import fastmap::fastmap
2019-05-09 10:20:33 -05:00
Winston Chang
32c2bff6eb
Convert ReactiveValues$.metadata to use Map
2019-05-09 10:20:33 -05:00
Winston Chang
555ede03ed
Convert ReactiveValues$.values to use Map
2019-05-08 20:33:52 -05:00
Winston Chang
2a6f218700
Convert ReactiveValues$.dependents to use Map
2019-05-08 20:33:52 -05:00
Winston Chang
b087c19b52
Use fastmap as backing store for Map class
2019-05-08 20:33:52 -05:00
Carson Sievert
6fed1c60ac
update news (should've been done in #2404 )
2019-05-08 16:36:46 -05:00
Carson Sievert
b10f2a5291
yarn build
2019-05-08 16:30:59 -05:00
Winston Chang
a4a49a354e
Merge pull request #2404 from rstudio/inputRateName
...
Fix issue with input rate policies
2019-05-08 16:24:02 -05:00
Carson Sievert
ead23528ca
doSetInput calls setInput (duh) so should have name and type
2019-05-08 16:19:21 -05:00
Carson Sievert
b8644949cc
camelCase for consistency; clarify comment
2019-05-08 16:19:13 -05:00
Carson Sievert
b88e3a64f2
comment on the difference between name_type and name
2019-05-08 16:19:07 -05:00
Carson Sievert
2871b423fd
rename name arg to name_type where relevant in input decorators...
...
this will help to highlight when you should call a method with just the input name instead of both the name and the type
2019-05-08 16:19:02 -05:00
Carson Sievert
562fafbc39
pass inputName to immediateCall() and normalCall()
2019-05-08 16:18:55 -05:00
Carson Sievert
191e0874f8
type is only relevant for public methods setInput() and setRatePolicy()
...
change the name of these arguments to reflect this (name_type)
2019-05-08 16:18:47 -05:00
Carson Sievert
fa5ff7bfa5
Consistently ignore input type in all InputRateDecorator methods
2019-05-08 16:18:39 -05:00
Carson Sievert
82e80ccdeb
InputRateDecorator's setInput method needs to strip of the input's ttype before looking up the input's rate policy, closes #2387
2019-05-08 16:18:19 -05:00
Carson Sievert
ff84cf5a18
update news ( #2428 )
2019-05-08 16:08:20 -05:00
Winston Chang
44843a7768
Merge pull request #2406 from rstudio/null-label
...
Input label updating
2019-05-08 15:52:09 -05:00
Carson Sievert
68eeb338da
Have input labels always include 'control-label' class
2019-05-08 15:15:09 -05:00
Carson Sievert
ea54c17902
merge with master
2019-05-08 15:10:22 -05:00
Barret Schloerke
d5ad7eed40
Merge pull request #2424 from rstudio/joe/bugfix/reactive-value-not-changing
...
Fix rstudio/reactlog#36 : Changes to reactive values not displaying accurately
2019-05-08 12:01:08 -04:00
Joe Cheng
c2430cd3f4
Update NEWS
2019-05-07 09:33:59 -07:00
Joe Cheng
8a0731493f
Fix rstudio/reactlog#36 : Changes to reactive values not displaying accurately
2019-05-07 09:30:59 -07:00
Carson Sievert
07e2b80b5d
merge with master; fix NEWS conflicts
2019-05-03 17:21:06 -05:00
Carson Sievert
1311e1fca2
have class come before the for attribute
2019-05-03 17:16:17 -05:00
Winston Chang
e6c2133520
Merge pull request #2416 from rstudio/updateSliderInput
...
getSliderType() should be able to handle NULL min/max/value, fixes #2250
2019-05-03 16:54:57 -05:00
Carson Sievert
3d6f734ff2
update comment
2019-05-03 15:58:45 -05:00
Carson Sievert
e0eaa58779
update news
2019-05-03 15:57:55 -05:00
Carson Sievert
ced6622b25
Have getSliderType() return '' early if min, max, and value are NULL
2019-05-03 15:54:48 -05:00
Carson Sievert
2d2cf96f5e
missed input_binding_slider.js
2019-05-03 15:48:47 -05:00
Carson Sievert
370f1b51ee
Inputs now always supply a <label> tag with a special CSS class for hiding NULL labels
...
This helps to simplify the updating logic on the client
2019-05-03 15:38:57 -05:00
Winston Chang
67d3a504ae
Merge pull request #2403 from rstudio/dateFormat
...
Consistent approach to coercing and formatting date strings
2019-05-03 10:58:06 -05:00
Carson Sievert
34ee48ef93
update news
2019-05-02 10:46:08 -05:00
Carson Sievert
c61a585e79
getSliderType() should be able to handle NULL min/max/value, fixes #2250
2019-05-01 19:41:26 -05:00
Carson Sievert
09388c9f07
Apply label updating logic all relevant input labels
2019-05-01 18:55:36 -05:00
Carson Sievert
b1bc78dad3
fix news link
2019-05-01 11:19:40 -05:00
Carson Sievert
a5a0f23c3a
Use jQuery's text() method for proper escaping when inserting data.label string
2019-04-30 17:33:26 -05:00
Carson Sievert
4c50c064d3
make return value of dateYMD() slightly more clear
2019-04-30 17:08:13 -05:00
Carson Sievert
a63f271300
update news
2019-04-30 17:00:34 -05:00
Carson Sievert
08b22ff550
update NEWS
2019-04-30 17:00:34 -05:00
Carson Sievert
b04133bf65
Include argName with warning when length > 1
2019-04-30 17:00:34 -05:00
Carson Sievert
3602358d2c
fix typo in warning message
2019-04-30 17:00:34 -05:00
Carson Sievert
67b0416eba
Throw informative warning if date coercion fails and original input
2019-04-30 17:00:34 -05:00
Carson Sievert
f8d69ecb1f
Consistent approach to coercing and formatting date strings, closes #2402
2019-04-30 17:00:34 -05:00
Carson Sievert
5e8bc204c1
make sure to remove label tag from DOM if label is updated to NULL
2019-04-26 19:08:15 -05:00
Carson Sievert
938332d646
Have textInput()'s receiveMessage method insert a label tag if one is needed, closes #868
2019-04-26 16:56:53 -05:00
Winston Chang
386078d441
Merge tag 'v1.3.2'
2019-04-23 14:07:37 -05:00
Winston Chang
4d778faaf4
Bump version to 1.3.2
2019-04-18 11:51:16 -05:00
Winston Chang
3055cf5602
Update NEWS
2019-04-18 11:49:09 -05:00
Joe Cheng
36373ba28b
Merge pull request #2386 from rstudio/joe/bugfix/subapp-routing
...
Fix #2385 : R Markdown documents containing subapps not rendering properly
2019-04-18 08:49:56 -07:00
Joe Cheng
1415b57181
Add sys.www.root to createAppHandlers, so that subapps can access /shared/*
2019-04-16 18:40:29 -07:00
Joe Cheng
65d4a4e906
Add comments
2019-04-16 18:12:09 -07:00
Joe Cheng
0abe221227
Use v1.3.1.9000
2019-04-14 17:21:26 -07:00
Joe Cheng
1b8d822226
Fix #2385 : R Markdown documents containing subapps not rendering properly
2019-04-14 17:19:17 -07:00
Winston Chang
bc8fbd60d7
Bump version to 1.3.1.9000
2019-04-12 11:13:32 -05:00
Winston Chang
4c332eac9a
Merge tag 'v1.3.1'
...
Shiny 1.3.1 on CRAN
2019-04-12 11:12:59 -05:00
Joe Cheng
f5392d77dc
Merge pull request #2382 from rstudio/fix-index-html
...
Fix serving of www/index.html
2019-04-11 11:43:44 -07:00
Winston Chang
1e88990a0b
Fix serving of www/index.html. Closes #2380
2019-04-11 11:57:48 -05:00
Joe Cheng
de4c7567d0
Manually bump the version numbers in shiny.js and shiny.min.js
...
Normally this would be where we grunt, but for this hotfix we
need to avoid the changes that went in at the end of 1.3.0 that
were accidentally left out of the built JS.
2019-04-10 11:42:42 -07:00
Joe Cheng
aff33dd023
Bump version to 1.3.1
2019-04-10 11:35:05 -07:00
Barret Schloerke
a287ebe324
Minimize str usage in rlog$valueStr ( #2377 )
...
* return early if loggin is disabled
* do not allow str to recurse
* add news item for #2377
* change " " to " "
* Not a "world-ending performance issue"
2019-04-10 11:27:29 -07:00
Winston Chang
583a8d1001
Merge pull request #2353 from rstudio/fix-verbatim-text-wrap
...
Don't wrap text in verbatimTextOuput in Safari
2019-04-08 16:20:18 -05:00
Winston Chang
36a808add0
Update NEWS
2019-04-08 13:22:57 -05:00
Winston Chang
f651d4a274
Don't wrap text in verbatimTextOuput in Safari. Closes #2233
2019-04-08 13:20:20 -05:00
Winston Chang
f6e8e645f2
Bump version to 1.3.0.9000
2019-04-08 13:19:57 -05:00
Winston Chang
b4d2f88b74
Merge tag 'v1.3.0'
...
Shiny v1.3.0 on CRAN
2019-04-08 12:01:05 -05:00
Winston Chang
c524a736bd
Re-document
2019-03-29 17:25:14 -05:00
Winston Chang
cdf3bf18f0
Fix broken URL
2019-03-29 16:55:41 -05:00
Winston Chang
b21bdacb4f
Remove reactlog from Remotes
2019-03-27 13:42:25 -05:00
Winston Chang
92019b5ba3
Merge pull request #2361 from rstudio/fix-svg-foreignobject
...
Fix #2348 , #2329 , #1817 : bugs triggered by networkD3 sankey plot
2019-03-27 13:40:15 -05:00
Alan Dipert
908d635063
Fix #2349 , #2329 , #1817 : bugs triggered by networkD3 sankey plot
...
* All of these were caused by the presence of multiple body tags on the
page, which happened because networkD3's sankey plot generates SVGs
containing body tags via SVG's foreignObject tag
* In various places, the 'body' jQuery selector string is used under the
assumption there is only one 'body' tag on the page. The presence of
multiple 'body' tags breaks reliant code in strange ways.
* The fix was to use document.body or 'body:first' instead of 'body'.
2019-03-27 11:36:19 -07:00
Alan Dipert
20329feb7f
Improve bootstrap-datepicker update tools, add docs
2019-03-26 20:33:42 -07:00
Alan Dipert
4cd92a1cd9
Add 'Fix datepicker DST bug' as patch
...
- Original commit: 0683b79
2019-03-26 20:33:32 -07:00
Alan Dipert
8ca3397c5d
Improve bootstrap-datepicker update script
2019-03-26 20:33:20 -07:00
Alan Dipert
05cd79481e
Re-import bootstrap-datepicker 1.6.4
2019-03-26 17:34:47 -07:00
Winston Chang
c0f1905785
Remove httpuv and reactlog from remotes
2019-03-26 15:18:00 -05:00
Alan Dipert
9afc06028d
Restore intuitive bookmarking behavior ( #2360 )
...
* Adding flushPending() to ShinySession's flushOutput() restores intuitive bookmarking behavior
* Check that restoreContext is present
* Update NEWS
2019-03-26 15:08:34 -05:00
Barret Schloerke
7b6cc50238
Merge branch 'master' into rc-v1.3.0
...
* master:
fix shortString is NA or NULL logic
add coverage for situation where label might be na or NULL
increase default length of label to 250chars from 100chars
make sure labels are short for reactlog
2019-03-01 15:45:19 -05:00
Barret Schloerke
722b1d0258
Merge pull request #2345 from rstudio/short_reactlog_labels
...
Shorter reactlog labels
2019-03-01 14:43:59 -06:00
Barret Schloerke
93d3b78ac1
fix shortString is NA or NULL logic
2019-03-01 15:22:40 -05:00
Barret Schloerke
69e82f6e0e
add coverage for situation where label might be na or NULL
2019-03-01 14:57:05 -05:00
Barret Schloerke
1f83a6db7b
increase default length of label to 250chars from 100chars
2019-03-01 14:34:21 -05:00
Barret Schloerke
8f37951e14
make sure labels are short for reactlog
2019-03-01 14:30:23 -05:00
Joe Cheng
e1f4d43926
Merge pull request #2342 from rstudio/reactlog-cran
...
Reactlog github location removed
2019-02-27 10:31:08 -08:00
Joe Cheng
eb6139276f
Merge pull request #2343 from rstudio/fix-resource-path
...
addResourcePath: create staticPath object immediately. Fixes #2339
2019-02-27 10:27:09 -08:00
Winston Chang
f18c426151
addResourcePath: create staticPath object immediately. Fixes #2339
2019-02-27 11:12:55 -06:00
Barret Schloerke
e46debb6d1
remove github location for reactlog and clean up flow of check_suggested
2019-02-27 09:19:46 -05:00
Barret Schloerke
d8b8739cb8
use httpuv rc-v1.5.0 branch
2019-02-26 16:57:28 -05:00
Barret Schloerke
9fd8eefa59
Merge branch 'master' into rc-v1.3.0
...
* master:
Make sure the is.na() check in %AND% looks for length-1 input
2019-02-26 16:21:24 -05:00
Barret Schloerke
fd2af06a53
run grunt
2019-02-26 16:21:01 -05:00
Barret Schloerke
48f945ba7f
use reactlog rc-1.0.0 branch
2019-02-26 16:19:24 -05:00
Barret Schloerke
6d59f88a76
bump news and description versions to 1.3.0
2019-02-26 16:19:07 -05:00
Joe Cheng
8b94d4626d
Merge pull request #2338 from rstudio/fix-and
...
Make sure the is.na() check in %AND% looks for length-1 input
2019-02-26 13:11:39 -08:00
Winston Chang
d7d8e78e42
Make sure the is.na() check in %AND% looks for length-1 input
...
This is to avoid errors with R CMD check on R-devel like this:
https://travis-ci.org/rstudio/shiny/jobs/498880293
2019-02-26 14:32:41 -06:00
Joe Cheng
9755f86f53
Merge pull request #2327 from rstudio/staticpath-exclude
...
Exclude "session" from static path serving
2019-02-26 12:17:30 -08:00
Winston Chang
599a3ee82f
Simplify session placement
2019-02-26 13:02:23 -06:00
Winston Chang
c790346490
Merge pull request #2284 from chasemc/patch-1
...
Fix typo
2019-02-21 14:04:40 -06:00
Joe Cheng
68cf3a9111
Merge pull request #2311 from rstudio/bookmark-dot
...
Bookmarking: restore inputs that have a leading dot
2019-02-21 11:56:40 -08:00
Barret Schloerke
59221dfcf2
bump dev version of reactlog. remove reactlog::reactlog_add_shiny_resource_paths()
2019-02-15 15:52:05 -06:00
Winston Chang
020413a206
Always exclude /session from static paths
2019-02-15 15:08:26 -06:00
Winston Chang
a343e9ebdf
Use excludeStaticPath() function
2019-02-14 21:15:20 -06:00
Winston Chang
c304efee36
Exclude "session" from static path serving. Fixes #2325
2019-02-12 20:28:47 -06:00
Winston Chang
95173f676d
Merge pull request #2319 from rstudio/joe/misc/constant-time-check
...
Add constant time check for shared secret
2019-02-11 15:22:54 -06:00
Joe Cheng
87d1db1f2b
Fix test
2019-02-11 10:02:40 -08:00
Barret Schloerke
d445f384c7
Merge pull request #2315 from rstudio/reactlogShow
...
Add methods: reactlog, reactlogShow, and reactlogReset. Deprecate showReactLog
2019-02-07 15:05:05 -06:00
Joe Cheng
59dd4b0721
Code review feedback
...
- Rename sharedSecret variables to checkSharedSecret
- Don't perform the digest::digest(). This just means the timing could
give away the length of the secret, but that's OK, there's enough
entropy in the secret even if you know its length.
2019-02-05 14:33:04 -08:00
Joe Cheng
d73c91d4a7
Add unit tests for shared secret check
2019-02-04 14:19:02 -08:00
Joe Cheng
665a66522e
Add constant time check for shared secret
2019-02-04 13:19:47 -08:00
Barret Schloerke
ba1efa65fa
update man file name to reactlog from showReactLog in inst/staticdocs/index.r
2019-02-01 16:29:03 -05:00
Barret Schloerke
64a74692b9
document time for reactlogShow
2019-02-01 16:05:33 -05:00
Barret Schloerke
46cd285dd0
update docs by removing showReactLog/reactlogShow (to reactlog) as much as possible
2019-01-30 16:01:22 -05:00
Barret Schloerke
bcac115c3d
Add methods: reactlog, reactlogShow, and reactlogReset. Depricate showReactLog
...
Update links to help file to not use `showReactLog`, but `reactlogShow`
Use updated reactlog pkg function api of reactlog_*. This may fail right now, but rerun travis when the reactlog code is merged into master.
2019-01-30 12:20:22 -05:00
Winston Chang
77ddb2c8c2
Bookmarking: restore inputs that have a leading dot. Fixes #2308
2019-01-23 12:05:24 -06:00
Barret Schloerke
8ae31eb998
Merge pull request #2107 from schloerke/barret/reactlog
...
Upgraded reactlog logging and support for shinyreactlog rendering
2019-01-11 13:19:14 -05:00
Barret Schloerke
7551a6ae1d
add stats:: to setNames function calls
...
helps pass R CMD check
2019-01-11 13:04:39 -05:00
Barret Schloerke
93be659b1b
merge Remotes
2019-01-11 12:45:59 -05:00
Barret Schloerke
3327878fc2
merged from master
2019-01-11 12:33:31 -05:00
Winston Chang
0b25c7f3c1
Merge pull request #2280 from rstudio/static-file
...
Use httpuv static file serving
2019-01-11 10:56:52 -06:00
Barret Schloerke
b606ba4dd7
added news item for reactlog
2019-01-11 09:43:25 -05:00
Chase Clark
0269bc810c
Fix typo
...
"...use the JavaScript library selectize.js (https://github.com/selectize/selectize.js ) ~~ to~~ instead of the basic select..."
2018-12-17 12:59:57 -06:00
Barret Schloerke
f2775f2c1d
update rLog$msg output tests
2018-12-14 16:18:20 -05:00
Barret Schloerke
f06274aec6
fixed bad argument placement
2018-12-14 16:01:25 -05:00
Barret Schloerke
dfa686a3e0
always display the first n chars in a rLog$valueChange or rLog$define
...
capture the value in a try statement of capture.output of str
2018-12-14 15:51:31 -05:00
Barret Schloerke
fe679b5de5
add reactId to rLog$invalidateLater
2018-12-14 15:49:45 -05:00
Barret Schloerke
aa1eb0410c
add force option to retrieving reactive info
2018-12-14 14:10:34 -05:00
Barret Schloerke
1b06bab7ee
add define observer to rLog
2018-12-14 12:05:37 -05:00
Barret Schloerke
0f13056aa2
fix rLog$reset to work as an installed package. added a dummy context reactId (different from noReactId)
2018-12-14 12:05:22 -05:00
Barret Schloerke
beecf60db7
use rLog$reset() instead of initializeReactlog() due to changing global binding error
2018-12-13 17:04:12 -05:00
Barret Schloerke
160a2013bc
fix broken test
2018-12-13 16:52:44 -05:00
Barret Schloerke
b8c636e87e
move the actual setting of the reactiveValues key higher in set command for accurate logging
2018-12-13 16:52:35 -05:00
Barret Schloerke
add40e5926
when calling rlog$define, set a value
2018-12-13 16:51:32 -05:00
Barret Schloerke
960e7f3b24
fix .globals binding issue
2018-12-13 16:50:13 -05:00
Barret Schloerke
3e749f36e8
turn off logging of value in console
2018-12-13 16:50:03 -05:00
Barret Schloerke
8198d99309
add rlog$invalidateLater(runningCtxId, millis, domain)
2018-12-13 14:49:27 -05:00
Barret Schloerke
81de1c8ed4
remove setLabel from ReactiveValues
2018-12-13 14:42:25 -05:00
Barret Schloerke
3eb55e9d9b
update reactiveValues set comments
2018-12-13 14:34:58 -05:00
Barret Schloerke
6b6ac86aea
async start stop rLog should use domain = self
2018-12-13 14:33:29 -05:00
Barret Schloerke
1b45e70cbb
use rLog$noReactId constant
2018-12-13 14:32:40 -05:00
Barret Schloerke
929f7ec235
document
2018-12-13 13:26:49 -05:00
Barret Schloerke
cf28d7e470
init testing for msg logging
2018-12-13 13:26:42 -05:00
Barret Schloerke
b0a00108f3
log, action, then perform invalidate action
2018-12-13 13:26:26 -05:00
Barret Schloerke
01151fc7f8
dummy context should be created every time. allow for id to be passed in
2018-12-13 13:26:12 -05:00
Barret Schloerke
bf8dbc38c7
add a noReactId label and init rLog method
2018-12-13 13:25:53 -05:00
Barret Schloerke
ae0d4d9353
add a default reactId for contexts for clearer msg logs and rLogs
2018-12-13 10:48:32 -05:00
Barret Schloerke
43ec4ae238
add helper functions for msg logger.
2018-12-13 10:48:02 -05:00
Barret Schloerke
c568a8cabe
when updating a value for reactVal or a reactValues key, the context should not be recorded
2018-12-13 10:46:12 -05:00
Barret Schloerke
423bdd8b6b
read reactlog version from description file
2018-12-12 11:27:17 -05:00
Barret Schloerke
1e19ff65e6
fix bad comma usage
2018-12-12 11:04:36 -05:00
Barret Schloerke
a9cf632f53
markTime -> userMark; queueEmpty -> idle
2018-12-12 10:58:28 -05:00
Barret Schloerke
fddf94a341
this check is already covered
2018-12-11 17:23:22 -05:00
Barret Schloerke
203168d261
dec/increment with integers
2018-12-11 17:23:13 -05:00
Barret Schloerke
0e3c3536f8
no need to store messages
2018-12-11 17:22:59 -05:00
Barret Schloerke
45b2b7e24f
use curly brackets for all function defs
2018-12-11 17:22:33 -05:00
Barret Schloerke
88f177b065
use class brackets for R6 def
2018-12-11 17:22:09 -05:00
Barret Schloerke
ea7a8dd3ad
consistent naming
2018-12-11 17:14:30 -05:00
Barret Schloerke
dda8f92494
remove writeReactLog
2018-12-11 17:13:09 -05:00
Barret Schloerke
26211802cd
spelling and comments
2018-12-11 17:12:59 -05:00
Barret Schloerke
b4bef0d32c
use reactlog::reactlog_add_shiny_resource_paths
2018-12-11 17:12:38 -05:00
Winston Chang
a8bf203067
Grunt
2018-12-10 14:34:27 -06:00
Winston Chang
624dd2e99d
Bump version to 1.2.0.9001
2018-12-10 14:19:48 -06:00
Barret Schloerke
26a136a6e8
check_suggested now takes a github location and a source install script
2018-12-04 14:38:14 -05:00
Winston Chang
2d57ffa546
Update NEWS
2018-12-03 12:13:54 -06:00
Winston Chang
428b81a6d9
Use httpuv master branch
2018-12-03 12:10:04 -06:00
Barret Schloerke
f24c12fdfb
shinyreactlog -> reactlog
2018-11-30 16:02:00 -05:00
Barret Schloerke
9a345d191b
merge in master
2018-11-27 10:33:11 -05:00
Winston Chang
fec706d134
Add headers for static serving
2018-11-20 12:25:46 -06:00
Winston Chang
c338448997
Use shiny-shared-secret validation for static files
2018-11-20 12:25:46 -06:00
Winston Chang
956c1cb1a7
Use setStaticPath instead of setStaticPaths
2018-11-20 12:25:46 -06:00
Winston Chang
8831b4da9e
Use static serving for app's own assets
2018-11-20 12:25:46 -06:00
Winston Chang
f8bd60dcd7
Use httpuv static serving
2018-11-20 12:25:46 -06:00
Winston Chang
6a373b585c
Merge pull request #2248 from rstudio/fix-selectize-label
...
Make updateSelectizeInput() work with labels again
2018-11-15 17:04:16 -06:00
Winston Chang
54480e2510
Merge branch 'master' into fix-selectize-label
2018-11-15 17:03:58 -06:00
Joe Cheng
83f73603db
Merge pull request #2257 from colearendt/fix-htmltools-dep
...
fix dependency version since htmltools 0.3.6 is used
2018-11-15 14:39:37 -08:00
Joe Cheng
2b10f192ba
Merge pull request #2261 from rstudio/joe/bugfix/async-rendercachedplot
...
Fix #2247 : Async cached plots raise "Error in !: invalid argument type" error
2018-11-15 14:39:07 -08:00
Winston Chang
775d5289cb
Grunt
2018-11-15 15:23:35 -06:00
Winston Chang
e6c66352a7
Update NEWS
2018-11-15 15:23:35 -06:00
Winston Chang
77afd73ee1
Use new selectize suffix. Fixes #2245
2018-11-15 15:23:35 -06:00
Winston Chang
5ac96a40aa
Remove QuitChildProcessesOnExit: Default option
2018-11-15 15:10:54 -06:00
Winston Chang
2fea0e2598
Don't byte-compile when doing local install in RStudio
2018-11-15 15:08:49 -06:00
Joe Cheng
2b64949cbe
Fix #2247 : Async cached plots raise "Error in !: invalid argument type" error
2018-11-14 16:45:40 -08:00
Cole Arendt
918d57f25e
fix dependency version since htmltools 0.3.6 is used
2018-11-11 15:04:44 -05:00
Joe Cheng
5e2b40d3a9
Bump version for development
2018-11-02 13:11:04 -07:00
Joe Cheng
979ef4bd43
Merge remote-tracking branch 'origin/v1.2-rc'
2018-11-02 13:10:48 -07:00
Winston Chang
914baf594b
Merge pull request #2241 from rstudio/joe/bugfix/icon-examples
...
Remove icon examples
2018-11-01 20:41:58 -05:00
Joe Cheng
02b0802886
Add note about FontAwesome path change
2018-11-01 15:08:59 -07:00
Joe Cheng
0725239397
Remove icon examples
...
These cause browser windows to pop up during R CMD check, which is
against CRAN policy. @wch will merge a PR that has other examples
once we release v1.2.
2018-11-01 14:56:15 -07:00
Joe Cheng
d72e8a06a7
Fix error in global reactiveTimer
...
When reactiveTimer is created without a default reactive domain
(i.e. outside of a session, i.e. global) there's no session to
call cycleStartAction on. Instead, invalidation should proceed
right away.
Fixes #2228
2018-10-29 11:43:03 -05:00
Joe Cheng
cf79fec720
Merge pull request #2226 from rstudio/joe/bugfix/cycle-queue-stall-2
...
Fix input event queue stall
2018-10-25 15:19:23 -07:00
Joe Cheng
31dda45d1c
Update NEWS
2018-10-25 12:13:37 -07:00
Joe Cheng
9836b72661
Fix #2225 : Input event queue can stall in apps that use async
2018-10-25 12:12:21 -07:00
Winston Chang
6ede0194c6
Update license information in README
2018-10-25 12:15:57 -05:00
Winston Chang
5ec38581ca
Add support for Font-Awesome 5 brands ( #2221 )
...
* Add support for Font-Awesome 5 brands
* Fix glyphicon support
2018-10-24 16:13:36 -05:00
Winston Chang
2629e59ace
Re-document
2018-10-18 22:52:43 -05:00
Alan Dipert
f3eb770e20
Add to fontawesome news entry ( #2214 )
...
* Add FontAwesome upgrade information to NEWS.md
* Update NEWS.md
* Update NEWS.md
2018-10-18 11:57:29 -05:00
Winston Chang
0683b79fac
Fix datepicker DST bug ( #2212 )
...
* Fix datepicker DST bug. Closes #2204
This fix is borrowed from:
13885397de (diff-dd513a8bab7ad1033c8784c4a1b9ce15)
* Update NEWS.md
2018-10-17 15:01:39 -05:00
Alan Dipert
fcd09e2bae
Simplify DnD for fileInputs, fix #2142 (Firefox 57+)
...
- Simplified dragHover "plugin" by counting children instead of storing them.
Counting children fixes Firefox 57+ bug (to be found or filed) that causes
text object of input element to produce drag events
- Removed multimethod since it's no longer used anywhere
- Firefox 57+ appears not to trigger a change event when the `files` field is modified,
which prevented uploads from occuring. This commit triggers a change event manually
and doesn't impact the functioning of other browsers.
2018-10-08 21:24:18 -07:00
Joe Cheng
b25cb0f2d5
Merge pull request #2200 from rstudio/joe/bugfix/brush-webkit
...
Fix brushes not being properly cleared
2018-09-27 14:23:27 -07:00
Barret Schloerke
0704aec01b
Follow js event namespacing conventions and only possibly init brush once ( #2202 )
...
* underscore the shiny_image_interaction namespace
* namespace dragstart
* use `one` instead of `on`
* compile
2018-09-27 16:24:53 -04:00
Barret Schloerke
d38b939c63
use naturalHeight and naturalWidth for default dim values. Followup comments from winston ( #2201 )
2018-09-27 16:16:11 -04:00
Joe Cheng
112466de1e
Fix brushes not being properly cleared
...
Actually three separate issues addressed. Fixes #2197 .
- brush.importOldBrush() was not being called anymore, due to it being
registered as a load handler after the image was already loaded (this
was a very recent regression, less than 24 hours old).
- Each time the brush changes, the plot is redrawn twice. This was
because importing the old brush introduced floating point errors that
led to a slightly different new brush being created.
- Sometimes the image's load event wasn't firing at all. This is due to
behavior in WebKit where assigning an image's src to its existing
value is a no-op.
2018-09-26 22:57:16 -07:00
Barret Schloerke
1d0edd2ad0
Initialize brush dims for renderImage objects ( #2198 )
...
* wait for image to be loaded in browser before initializing handlers
reverts similar behavior in 3354a47e8a
* default the height and width to the image clientHeight and clientWidth
* use raw image clientWidth and clientHeight instead of container clientWidth and clientHeight
prevents being able to brush on non image areas
2018-09-26 13:29:42 -04:00
Joe Cheng
37736119be
Merge pull request #2195 from rstudio/joe/bugfix/selectize-choices-data-frame
...
Fix custom selectize rendering
2018-09-25 14:23:29 -07:00
Joe Cheng
c5df150acb
Improve robustness of optgroup construction
...
Instead of providing alternate defaults for optgroupField,
optgroupLabelField, and optgroupValueField, respect the
selectize instance's settings for those fields.
2018-09-25 14:13:39 -07:00
Joe Cheng
49a346334b
Fix custom selectize rendering
...
Fixes #2192 . Two problems here:
1. It's not documented but apparently we supported data frames for
choices in updateSelectInput/updateSelectizeInput (it doesn't
appear to work correctly for selectInput/selectizeInput though).
This was used in 023-optgroup-server as well as by the user who
reported #2172 .
2. The example in 023-optgroup-server was also counting on the
default value of optgroupLabelField, which (starting post-Shiny
v1.1) was being set to a new default of "group". That now won't
happen unless optgroupField is also blank. I'm less confident
about the ramifications of this change. The selectize docs with
the relevant bits are here:
https://github.com/selectize/selectize.js/blob/master/docs/usage.md#data_searching
2018-09-25 13:23:35 -07:00
Joe Cheng
e7c4656e8f
Fix selectize bug where value is set merely on query results ( #2193 )
...
This bug is new since v1.1. When results are returned from selectize's
server-side endpoint, iff no results have been selected before, then
the control should be set to either its specified initial value (the
one specified in selectInput/selectizeInput) or, if none was provided
AND the selectize control is multiple=FALSE, then select the first
entry automatically.
That's the desired behavior; the bug was that last part, "select the
first entry automatically", was happening whether results had already
been selected before or not. This was causing merely typing in the
control to cause the value to be changed.
Fixes #2191
2018-09-25 12:21:16 -07:00
Joe Cheng
85bed0582a
Rebuild JS (to update version number)
2018-09-19 09:51:36 -07:00
Joe Cheng
b9e6f867c6
Bump version
2018-09-19 09:47:41 -07:00
Joe Cheng
a5b80168bd
Refactor v1.2 news
2018-09-19 09:47:35 -07:00
Alan Dipert
3cea5fb2d0
Upgrade FontAwesome to 5.3.1 ( #2186 )
...
* Upgrade FontAwesome to 5.3.1
- Upgrades FontAwesome to a new major (breaking) version, but
is backwards compatible because we include the v4-shims CSS that maps
old names to new.
- This is a step toward full V5 adoption that doesn't require us to
come up with a plan for deprecating V4 icon names.
- Details: https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4
- Related to #2156 and #1966
* Improvements to icon
- Clarify in docs that fontawesome V5 icons accessible with V4-style names
- Make icons browseable: icon('address-book') will now open the Viewer
pane of RStudio IDE so that icons can be experimented with more easily.
* Update LICENSE with CC for FontAwesome .svgs
* Update NEWS
2018-09-18 13:30:14 -07:00
Joe Cheng
c89d782048
Merge pull request #2187 from rstudio/joe/bugfix/selectize-nonempty
...
Fix spurious duplicate values being sent by selectInput
2018-09-18 13:27:55 -07:00
Barret Schloerke
1fd4179e07
News item for #2180 ( #2189 )
...
* news item for #2180
* fix news item
2018-09-18 14:58:57 -04:00
Joe Cheng
3b62400298
Code review feedback--use an arrow function instead of aliasing this
2018-09-18 10:52:50 -07:00
Joe Cheng
ba0fe938a1
Merge pull request #2188 from rstudio/jcheng5-patch-1
...
Remove unneeded Remotes
2018-09-18 10:33:47 -07:00
Joe Cheng
d4560171a8
Remove unneeded Remotes
2018-09-18 09:59:40 -07:00
Barret Schloerke
9963ba6cf5
merge master
2018-09-18 12:26:57 -04:00
Barret Schloerke
f5a23826c8
add domain to reactlog for context exit ( #2180 )
...
* add domain to reactlog for context exit
* use if statement vs %OR% when using envs
* Simplify graphExitContext domain argument
2018-09-18 12:23:01 -04:00
Barret Schloerke
21ff005c1a
remove display param from MessageLogger
2018-09-18 10:59:31 -04:00
Barret Schloerke
206b9135f1
if reactlog console option is set, display, or display is display is true
2018-09-18 10:24:48 -04:00
Barret Schloerke
5449de1a67
use shinyreactlog pkg directly
2018-09-18 10:24:17 -04:00
Barret Schloerke
47c61756e6
log create context with srcref and srcfile
2018-09-18 10:24:01 -04:00
Joe Cheng
ef63679ff0
Update NEWS
2018-09-17 16:13:32 -07:00
Joe Cheng
ef7e1c385a
Fix spurious duplicate values being sent by selectInput
2018-09-17 16:12:15 -07:00
Barret Schloerke
3a0a6cdbbb
Add css and image locations to plot click and brush events ( #2183 )
2018-09-17 15:25:34 -04:00
Joe Cheng
340df3e956
Merge pull request #2174 from AliciaSchep/master
...
Add informative errors when xvar or yvar not in data for brushedPoints
2018-09-17 11:33:16 -07:00
AliciaSchep
eeb264da8e
add var name to error msg
2018-09-17 09:45:40 -07:00
AliciaSchep
00f08b8ec6
revert two previous commits
2018-09-17 09:41:04 -07:00
AliciaSchep
67ae2a39ba
update documentation to reflect new options for xvar and yvar
2018-09-16 23:07:08 -07:00
AliciaSchep
72dda25835
evaluate xvar and yvar for nearPoints and brushedPoints
2018-09-16 22:45:53 -07:00
Alan Dipert
8c9ce1994a
Merge pull request #2028 from rstudio/joe/misc/selectize-upgrade
...
Upgrade Selectize to 0.12.4
2018-09-14 14:42:28 -07:00
Alan Dipert
606b05fdaf
Merge remote-tracking branch 'origin' into joe/misc/selectize-upgrade
2018-09-14 14:40:54 -07:00
Alan Dipert
420ba9549f
Merge pull request #2047 from rstudio/joe/bugfix/post-message
...
Fix #2033 : Rstudio Viewer window not closed on shiny::stopApp()
2018-09-14 14:26:58 -07:00
Alan Dipert
51fbb5cfac
Update NEWS
2018-09-14 14:25:43 -07:00
Alan Dipert
ca2c2b60f2
Grunt
2018-09-14 14:25:09 -07:00
Alan Dipert
d6064636d4
Merge pull request #2182 from rstudio/joe/misc/fontawesome-4-note
...
Add note that Font Awesome support is for 4.7.0
2018-09-14 13:52:30 -07:00
Joe Cheng
9646c9b0a0
Add note that Font Awesome support is for 4.7.0
2018-09-12 08:57:53 -07:00
Barret Schloerke
f28900f8ca
merged master
2018-09-10 12:50:42 -04:00
Barret Schloerke
e0c15c42d7
do not depend on null reactid values
2018-09-05 10:40:45 -04:00
AliciaSchep
7177618c25
add informative errors when xvar or yvar not in data for nearPoints and brushedPoints
2018-09-04 20:51:51 -07:00
Winston Chang
3bdd4af75c
Merge pull request #2168 from rstudio/create-scope-dir
...
Check for existence of bookmark scope directory before creating
2018-08-24 13:43:15 -05:00
Winston Chang
98d4b5e487
Check for existence of bookmark scope directory before creating
2018-08-24 12:43:45 -05:00
Joe Cheng
8b5639bfdb
Tweaks to NEWS
2018-08-24 10:41:08 -07:00
Joe Cheng
1c70b8b1bf
Merge pull request #2147 from nathancday/master
...
Fixes #174 , allowing specific days of the week to be disabled.
2018-08-24 10:39:12 -07:00
Joe Cheng
b5a7e03879
Merge branch 'master' into master
2018-08-24 10:38:44 -07:00
Winston Chang
a6dade846e
Un-export knit_print methods from htmltools
2018-08-23 15:51:53 -05:00
Winston Chang
32913f9d95
Merge pull request #2160 from rstudio/digest-xxhash
...
Use xxhash64 instead of sha256 for hash algorithm
2018-08-17 11:59:47 -05:00
Winston Chang
cbabf9a2a3
Use xxhash64 instead of sha256 for hash algorithm
2018-08-16 15:54:54 -05:00
Winston Chang
03e92c3336
Update NEWS
2018-08-10 21:18:05 -05:00
Winston Chang
997c39fdc0
Merge pull request #2125 from rstudio/plot-interact-scaled
...
Fix plot interaction for scaled plots
2018-08-10 21:13:16 -05:00
Winston Chang
bba2d1ee18
Grunt
2018-08-10 19:42:11 -05:00
Winston Chang
a60301810f
Update coordmap tests
2018-08-10 19:42:11 -05:00
Winston Chang
6b261f76b1
Bump version and update NEWS
2018-08-07 15:25:31 -05:00
Winston Chang
3db5f21d90
Update data structure comment
2018-08-07 15:11:43 -05:00
Winston Chang
121bfcb984
Import old brush after image has loaded
2018-08-07 15:11:43 -05:00
Winston Chang
265de66946
Make sure not to have multiple reset event handlers
2018-08-07 14:51:23 -05:00
Winston Chang
79c5c9f95e
Add isnan() function for IE
2018-08-07 14:51:23 -05:00
Winston Chang
3354a47e8a
Add width/height to coordmap instead of using naturalWidth/Height
...
This eliminates the need to use an on load callback.
2018-08-07 14:51:23 -05:00
Winston Chang
a1e1416d7a
More consistent use of img to css conversion functions
2018-08-07 10:48:42 -05:00
Winston Chang
24b7a9907f
renderCachedPlot: add note about interactive plots to help page
2018-08-07 10:48:42 -05:00
Nate
214abd0cd4
moved new dateInput arguments to last and added formatting conditional if datesdisabled is Date object
2018-08-07 10:16:48 -04:00
Joe Cheng
0bb53e8ca5
Inputs in renderUI/uiOutput don't work with bookmarks ( #2139 )
...
* hasCurrentRestoreContext returns FALSE from server side
Fixes #2138 .
* Add NEWS item for renderUI bookmarking fix
2018-08-06 15:04:16 -07:00
Winston Chang
ec12caaeba
Include x and y pixelratio in coordinfo
2018-08-06 12:51:08 -05:00
Winston Chang
5bbf2aa57a
Use canonical CSS property name
...
Firefox doesn't support shorthand properties like "border-left", but instead
requires "border-left-width".
2018-08-06 12:51:08 -05:00
Winston Chang
84ad9997da
Reposition div when resized (without new image)
2018-08-06 12:51:08 -05:00
Winston Chang
9f6ce87443
Remove redundant isEquivalent function
2018-08-06 12:51:08 -05:00
Winston Chang
1ff6c382bf
Remove unnecessary ggplot2 workaround
2018-08-06 12:51:07 -05:00
Winston Chang
c366c10ae1
Initialize coordmap only after image loads
2018-08-06 12:51:07 -05:00
Winston Chang
950df1e25c
Add support for scaled images and brushing
2018-08-06 12:51:07 -05:00
Winston Chang
909bfa8c14
Allow plot interaction to handle scaled images
2018-08-06 12:51:07 -05:00
Winston Chang
598b48d078
DiskCache: use mtime instead of atime, check for time resolution ( #2146 )
...
* DiskCache: check for atime support while running
* Use mtime instead of atime
* Remove mtime resolution checks
2018-08-06 10:50:05 -07:00
Nate
4c7b7f236a
added datesdisabled parameter to dateInput() allows disabling of specific yyyy-mm-dd format strings
2018-08-04 19:04:40 -04:00
Nate
896c5b41cb
Fixes #174 , allowing specific days of the week to be disabled.
2018-08-04 15:47:13 -04:00
Winston Chang
205c35d5e5
Re-document with roxygen2 6.1.0
2018-08-03 17:50:47 -05:00
Winston Chang
bf0dd7d725
Merge pull request #1997 from rstudio/plot-cache
...
Add renderCachedPlot()
2018-08-03 13:30:13 -05:00
Winston Chang
ba2b811172
Fix argument name in documentation
2018-07-31 15:06:59 -05:00
Winston Chang
be347c3ed4
Don't cache plotResult
2018-07-31 12:07:21 -05:00
Joe Cheng
c01abdb6a9
Merge branch 'master' into plot-cache
2018-07-26 15:52:11 -07:00
Winston Chang
95a5a965a5
Documentation fixes
2018-07-20 16:12:21 -05:00
Winston Chang
fc2849a8ff
Remove env and quoted arguments
2018-07-20 16:10:15 -05:00
Winston Chang
fcc900f3e0
Simplify resize logic
2018-07-20 14:48:57 -05:00
Winston Chang
9d0bcd5637
Add shiny-scalable class
2018-07-20 14:44:21 -05:00
Winston Chang
6ebbad5273
Safer file removal order
2018-07-19 23:20:51 -05:00
Winston Chang
930459899a
Small logic cleanup
2018-07-19 23:20:40 -05:00
Winston Chang
fe730e2d76
Make session cache public, so that user can set it
2018-07-19 21:57:32 -05:00
Winston Chang
e58b2e9a47
Fix app- and session-level cache initialization
2018-07-19 21:57:07 -05:00
Winston Chang
719dbab0c2
DiskCache: make destroy_on_finalize default to FALSE
2018-07-19 14:35:59 -05:00
Winston Chang
86ea023e2e
Update caches from code review feedback
2018-07-19 14:33:53 -05:00
Winston Chang
bc0fb3f44c
Restructure drawReactive/renderFunc code
2018-07-18 14:52:39 -05:00
Winston Chang
6d37f6b4dd
Set max-width and max-height to 100% for cached plots
2018-07-12 10:55:26 -05:00
Winston Chang
958ab85297
Add exec_missing parameter
2018-07-12 10:55:26 -05:00
Barret Schloerke
facef1d23c
do not set shiny.reactlog option by default
2018-07-09 22:23:28 -04:00
Barret Schloerke
cdb446375c
turn all active isLogging bindings into functions
2018-07-09 22:22:49 -04:00
Barret Schloerke
6f7b2887aa
fix parameters for shinyreactlog (session_token)
2018-07-06 11:58:37 -04:00
Barret Schloerke
bc8ae063dd
add new option for shinyreactlog messages in the console
2018-07-06 11:58:16 -04:00
Winston Chang
a23f973433
Suppress console logging for renderCachedPlot
2018-07-02 17:04:44 -05:00
Winston Chang
c124256bad
Improved logging for DiskCache and MemoryCache
2018-07-02 17:04:28 -05:00
Winston Chang
f1b035bcca
Update renderCachedPlot documentation and examples
2018-07-02 15:27:51 -05:00
Joe Cheng
81cc7c591e
Merge pull request #2080 from schloerke/barret-freeze-thaw
...
freeze/thaw reactiveValues with namespace support
2018-06-29 15:58:52 -07:00
Winston Chang
a0ca560c3b
Doc entries
2018-06-29 13:24:01 -05:00
Winston Chang
d1f20a9c73
Add 'missing' parameter to get()
2018-06-29 13:23:47 -05:00
Barret Schloerke
013059c5b9
merged in master
2018-06-29 11:35:20 -04:00
Winston Chang
fe6ad235ac
Add sentinel value cache miss
2018-06-28 23:58:55 -05:00
Winston Chang
67af26ffe6
When MemoryCache is used, we can cache the displayList
2018-06-26 23:11:25 -05:00
Winston Chang
0fce9de04f
Change default DiskCache size
2018-06-26 22:59:32 -05:00
Winston Chang
a8b8df21d6
DiskCache: make default finalizer behavior conditional on whether a temp directory is used
2018-06-26 22:57:35 -05:00
Winston Chang
ab2e304f02
DiskCache: Add info about sharing across processes
2018-06-26 22:56:59 -05:00
Winston Chang
574f2c53d4
DiskCache: Make destroy() work robustly with multiple processes
2018-06-26 22:26:27 -05:00
Winston Chang
bc85d812d2
DiskCache: Avoid errors from a race condition
2018-06-26 16:38:43 -05:00
Winston Chang
364990a29f
Fix .rds directory search pattern
2018-06-26 16:37:58 -05:00
Winston Chang
9ac9e36873
DiskCache: Check if cache has been destroyed by someone else
2018-06-26 15:48:08 -05:00
Winston Chang
6745e09688
Add support for promisey cache key
2018-06-25 21:13:55 -05:00
Winston Chang
e758927c84
DiskCache: Add warning when caching reference objects
2018-06-25 15:53:47 -05:00
Winston Chang
90fbf7d50f
Add comment about pruning
2018-06-25 15:34:43 -05:00
Winston Chang
75f1ee0082
Prune after setting value
2018-06-25 15:30:30 -05:00
Winston Chang
750aaf451a
NEWS edits
2018-06-25 14:11:42 -05:00
Winston Chang
b44bfe9109
Grunt
2018-06-25 14:10:22 -05:00
Winston Chang
aa392f8563
Merge pull request #2102 from tmastny/selectize-remote
...
Resolves #1933 : Serve-side selectize extended to all inputs
2018-06-25 14:07:56 -05:00
Winston Chang
ac7228f6c4
Merge branch 'master' into selectize-remote
2018-06-25 14:07:20 -05:00
Winston Chang
dcb12addaa
Merge pull request #2108 from tmastny/par-oma
...
Resolves #1935 : Fix coordinate outputs when modifying outer margins
2018-06-25 14:05:39 -05:00
Winston Chang
ad398b5f8a
Merge branch 'master' into par-oma
2018-06-25 14:05:30 -05:00
Timothy Mastny
803cb4806e
add new item
2018-06-25 14:04:31 -05:00
Timothy Mastny
1a468bbb61
add news items
2018-06-25 14:02:18 -05:00
Winston Chang
c332c051f3
Merge pull request #2099 from tmastny/slider-type
...
Fix #2019 : `updateSliderInput` changes formatting
2018-06-25 14:00:18 -05:00
Timothy Mastny
db48befcb7
removed TODO comments
2018-06-25 13:51:24 -05:00
Winston Chang
b02edb05ac
DiskCache: Use temp file when setting value
2018-06-25 11:56:01 -05:00
Winston Chang
d7009fd1c8
DiskCache: Don't call exists() before reading file
2018-06-25 11:55:29 -05:00
Winston Chang
ce3755676c
Fix files that were split
2018-06-25 10:45:12 -05:00
Winston Chang
db3c1b728d
Merge branches 'plot-cache-split-1' and 'plot-cache-split-2' into plot-cache
2018-06-25 10:42:52 -05:00
Winston Chang
1761de4740
Rename cache.R cache-context.R
2018-06-25 10:42:49 -05:00
Winston Chang
09d496925b
Rename cache.R cache-memory.R
2018-06-25 10:41:49 -05:00
Winston Chang
3af5327f1c
Rename cache.R cache-disk.R
2018-06-25 10:41:04 -05:00
Winston Chang
06cb14d7ec
Rename $has method to $exists
2018-06-22 23:27:49 -05:00
Winston Chang
7be1a9d7fa
Add memoryCache and make it the default
2018-06-22 23:08:39 -05:00
Winston Chang
95243fb35c
DiskCache: Add LRU eviction policy
2018-06-22 22:44:27 -05:00
Winston Chang
26438a3979
DiskCache cleanup
2018-06-22 19:32:29 -05:00
Winston Chang
28db097a71
Use promise domain for currentOutputName
2018-06-22 19:31:20 -05:00
Winston Chang
76fdd8ae04
Make renderCachedPlot work with async
2018-06-22 16:47:55 -05:00
Barret Schloerke
003dc39d76
add shinyreactlog as remote
2018-06-22 10:49:57 -04:00
Timothy Mastny
3a73bfb142
changed output coordinate system to "ndc" to account for margin changes
2018-06-21 17:48:16 -05:00
Timothy Mastny
a24bdabf08
Updates to Winston's feedback: removed for ... of iteration that is not supported in IE.
2018-06-21 16:17:42 -05:00
Winston Chang
8815f293a2
Update R version check information
2018-06-21 15:55:35 -05:00
Barret Schloerke
0b04c28011
move renderReactLog calculation above addResourcePath
2018-06-21 16:54:23 -04:00
Winston Chang
9af2775539
Fix absolutePath to correctly handle absolute paths
2018-06-21 15:48:54 -05:00
Winston Chang
ae5deae6e9
Use output name in cache key
2018-06-21 14:55:30 -05:00
Winston Chang
61c2126498
Add diskCache function, and app- and session-level caches
2018-06-21 14:44:09 -05:00
Timothy Mastny
881fe0cfce
explicitly set number to null instead of implicitly for better documentation
2018-06-21 14:30:15 -05:00
Timothy Mastny
a999bf389c
update NEWS.md
2018-06-21 14:30:15 -05:00
Timothy Mastny
ff3b97b630
refactored data type checking for consistency
2018-06-21 14:30:15 -05:00
Timothy Mastny
639b520d39
updateInputSlider can now change from date to date-time formatting. fixes #2019
2018-06-21 14:30:15 -05:00
Barret Schloerke
31854ad9e8
add reactlog resource path when calling for reactlog
2018-06-21 15:24:17 -04:00
Barret Schloerke
4304e92f0d
use self$ for all fn calls within rLog to avoid any conflicts
2018-06-21 15:23:33 -04:00
Barret Schloerke
44736cefbf
allow for null context id in dependents
2018-06-21 15:22:46 -04:00
Barret Schloerke
a807449f28
remove old temp files
2018-06-21 15:22:16 -04:00
Timothy Mastny
19dc29ea17
changes as per Winston's feedback; additional comments, and edge cases, and removed unnecessary JS.
2018-06-21 12:47:14 -05:00
Barret Schloerke
ae9d38b59c
remove old .graph methods and use shinyreactlog pkg for rendering
2018-06-21 10:31:12 -04:00
Timothy Mastny
97bebae8d7
fixed default selection for multiple-select
2018-06-20 15:41:35 -05:00
Timothy Mastny
cf534ce6da
remove "thiz"s and replace with explicit "selectize"
2018-06-20 15:41:35 -05:00
Timothy Mastny
f25f691a55
fix selectize for default selected value NULL
2018-06-20 15:41:35 -05:00
Timothy Mastny
cbebf8be7b
improve performance of R input processing
2018-06-20 15:41:35 -05:00
Timothy Mastny
165ce26b2f
Fixes #1933 . Fixed JSON encoding of input data, and added more optgroup controls on JS-side
2018-06-20 15:41:35 -05:00
Barret Schloerke
05e50c1b98
use original yarn lock file
2018-06-20 15:54:07 -04:00
Barret Schloerke
e11004da7b
remove _ignore folder
2018-06-20 15:51:17 -04:00
Barret Schloerke
97ee7b5d96
clean up tools readme to use yarn over global grunt-cli install
2018-06-20 15:47:16 -04:00
Barret Schloerke
6c6e2573aa
remove a LOT of files in favor of github.com/schloerke/shinyreactlog
...
still need hooks to shinyreactlog pkg
2018-06-20 15:34:22 -04:00
Barret Schloerke
8992827f21
merged master
2018-06-20 14:11:22 -04:00
Winston Chang
572c863bff
Merge pull request #2106 from schloerke/js_patch
...
compile with grunt to get version in js code (v1.1.0.9000)
2018-06-20 12:47:43 -05:00
Barret Schloerke
d3c85d67b8
gruntfile should run 'default' task to make sure everything is built like normal
2018-06-20 13:31:10 -04:00
Barret Schloerke
ff3434f77e
add a R test to make sure shiny.js {{ VERSION }} was replaced
2018-06-20 12:53:07 -04:00
Barret Schloerke
762528c044
add a grunt test to make sure {{ VERSION }} was replaced
2018-06-20 12:52:46 -04:00
Barret Schloerke
1891af0d4a
compile with grunt
2018-06-20 11:39:12 -04:00
Winston Chang
583ad036f7
Streamline renderCachedPlot API
2018-06-19 16:00:49 -05:00
Barret Schloerke
893b9c1b38
merged master -> barret/reactlog
2018-06-19 09:24:39 -04:00
Winston Chang
ac92bf98d4
WIP
2018-06-18 16:25:36 -05:00
Winston Chang
fd90ff7ff7
Use DiskCache class
2018-06-18 16:25:36 -05:00
Winston Chang
d06dbbe5db
Change cacheResetEventExpr to cacheResetExpr
2018-06-18 16:25:36 -05:00
Winston Chang
bffc4995d7
Rename normalizePath2 to absolutePath
2018-06-18 16:25:36 -05:00
Winston Chang
4b8b406bed
Add sizeGrowthRatio function
2018-06-18 16:25:36 -05:00
Winston Chang
5641153272
renderCachedPlot: pass ... args
2018-06-18 16:25:36 -05:00
Winston Chang
08c6c7781f
Rename cacheClearExpr to cacheResetEventExpr
2018-06-18 16:25:36 -05:00
Winston Chang
ad2ad391a7
Isolate user code
2018-06-18 16:25:36 -05:00
Winston Chang
caac88be0d
Don't re-run user code when only dimensions change
2018-06-18 16:25:36 -05:00
Winston Chang
10660aa373
Rename cacheInvalidationExpr to cacheClearExpr
2018-06-18 16:25:36 -05:00
Winston Chang
cfaf97aee4
Add entries to staticdocs
2018-06-18 16:25:36 -05:00
Winston Chang
55f14576f0
Remove createCachedPlot function
2018-06-18 16:25:36 -05:00
Winston Chang
4dca94ac99
Code reorganization
2018-06-18 16:25:36 -05:00
Winston Chang
14779d3d27
Only invalidate plot when fitted dimensions change
2018-06-18 16:25:36 -05:00
Winston Chang
66d1e710b5
Allow renderCachedPlot to take a directory for scope
2018-06-18 16:25:36 -05:00
Winston Chang
12ae3c17e9
Allow onStop to take a NULL session
2018-06-18 16:25:35 -05:00
Winston Chang
36e4da0709
Add app/session scoping for renderCachedPlot
2018-06-18 16:25:35 -05:00
Winston Chang
91631cb081
Note bug fix in R
2018-06-18 16:25:35 -05:00
Winston Chang
224f082e1f
Implement cache invalidation
2018-06-18 16:25:35 -05:00
Winston Chang
76b239a6ea
Convert renderCachedPlot to take expr and cacheKeyExpr
2018-06-18 16:25:35 -05:00
Winston Chang
cb476b510d
Initial implementation of renderCachedPlot
2018-06-18 16:25:35 -05:00
Winston Chang
334f233968
Move plot caching code into separate file
2018-06-18 16:25:35 -05:00
Winston Chang
e1f21250b9
Rename plotCache to createCachedPlot
2018-06-18 16:25:35 -05:00
Winston Chang
8d087e4f20
Get output info and auto-size plot cache images
2018-06-18 16:25:35 -05:00
Winston Chang
9e35e8c947
Allow user code to pass width/height/pixelratio
2018-06-18 16:25:35 -05:00
Winston Chang
f98faef024
Document cache scoping and minor code cleanup
2018-06-18 16:25:35 -05:00
Winston Chang
0f9346ead5
Add different scoping levels for plotCache
2018-06-18 16:25:35 -05:00
Winston Chang
fc8118c694
First implementation of plotCache
2018-06-18 16:25:35 -05:00
Barret Schloerke
6f8166ca0f
add todo
2018-06-14 16:06:12 -05:00
Joe Cheng
026b7278c1
Merge pull request #2091 from schloerke/barret-varSelectInput
...
Variable Select Input
2018-06-14 09:39:09 -05:00
Barret Schloerke
375a7e7e5c
respect existing class values and add tests
2018-06-11 10:31:49 -05:00
Barret Schloerke
64db035d77
simplify colors
...
no active green or grey. input invalidate should be grey
2018-06-08 15:38:03 -04:00
Barret Schloerke
cb051e4254
less case "STRING" and more case OBJ.VALUE
2018-06-08 15:20:51 -04:00
Barret Schloerke
20e9c2901d
reduced hoverStatusOnNodeIds arg requirements and internals
2018-06-08 15:17:33 -04:00
Barret Schloerke
ce4b391495
add more flow classes and remove $FlowExpectError
2018-06-08 15:16:43 -04:00
Barret Schloerke
7d932f5b18
fix searching on nodes
2018-06-08 11:43:37 -04:00
Barret Schloerke
56c8c08e08
move mapValues to a util file
2018-06-08 11:42:37 -04:00
Barret Schloerke
13ef25c0b5
bump flow threshold to 95 percent
2018-06-08 11:41:10 -04:00
Barret Schloerke
7a1aecb1a4
varSelectInput doc tweaks
2018-06-08 10:59:45 -04:00
Barret Schloerke
b3690e8680
add bullets in details for output return value (update corresponding example)
2018-06-08 10:51:37 -04:00
Barret Schloerke
97d490cfb4
remove rogue staticdocs fn
2018-06-07 16:52:35 -04:00
Barret Schloerke
2081dda6fc
merged master -> varSelectInput
2018-06-07 16:46:31 -04:00
Barret Schloerke
ea912fc50c
staticdocs for varSelectInput
2018-06-07 16:43:20 -04:00
Barret Schloerke
b655fdf68f
added news for varSelectInput
2018-06-07 16:43:05 -04:00
Barret Schloerke
4749f46a4f
add shiny.symbol and shiny.symbolList tests
2018-06-07 16:10:47 -04:00
Barret Schloerke
f95bb9c82d
compile and document
2018-06-07 16:10:24 -04:00
Barret Schloerke
6529529cdb
add new input 'varSelectInput()' and input binding 'shiny.symbol' and 'shiny.symbolList'
2018-06-07 16:10:01 -04:00
Tim Mastny
3a2a3f21d4
Improve optgroup documentation per #1864 ( #2084 )
...
* improves optgroup documentation per #1864
* change PR number in NEWS.md
* change addresses to addressed
2018-06-07 12:09:45 -05:00
Tim Mastny
631bc1c481
Addresses #2042 : lighten dates outside of range for datepicker ( #2087 )
...
* dehighlight dates outside of range for datepicker
* override color in shiny.css instead of package css
* refactored css styling to use specific references instead of !important
2018-06-07 11:57:27 -05:00
Barret Schloerke
6abfa5bf80
default log with marks
2018-06-06 16:14:54 -04:00
Barret Schloerke
20ae8e4f8b
fix eslint and prettier clashes
2018-06-06 16:14:51 -04:00
Barret Schloerke
f595c5d504
first pass at a user time mark
2018-06-06 16:14:47 -04:00
Barret Schloerke
972779253c
update enter exit to not be off by one
2018-06-06 16:14:42 -04:00
Barret Schloerke
9179a241e9
first pass at reactlog mark
2018-06-06 16:14:31 -04:00
Barret Schloerke
85e7e89ad9
fix babel options bug in grunt config
2018-06-06 16:14:26 -04:00
Barret Schloerke
9f5bc00c89
add simpler lint then watch script
2018-05-31 14:00:55 -04:00
Barret Schloerke
0ab842e3c5
add cranwhales log
2018-05-31 14:00:32 -04:00
Barret Schloerke
3a0a3e49dc
use log states from dictionary, rather than copies
2018-05-31 13:58:45 -04:00
Barret Schloerke
438b1c043e
set app data as log
2018-05-31 13:57:56 -04:00
Barret Schloerke
6d13b65e7c
export rlog object not as default
2018-05-31 13:57:27 -04:00
Barret Schloerke
423d41ee0e
fix console bug
2018-05-31 13:55:59 -04:00
Barret Schloerke
1b61d9bc51
first pass at freeze/thaw in rlog
2018-05-31 13:55:32 -04:00
Barret Schloerke
bf0c3d42db
copy all rlog files to the temp directory
2018-05-31 13:53:58 -04:00
Barret Schloerke
5394a68314
attempt to load rlog_data as a trycatch to work with showReactLog()
2018-05-31 13:53:46 -04:00
Barret Schloerke
597af36759
added news item
2018-05-31 10:31:35 -04:00
Barret Schloerke
691062f687
white space
2018-05-31 10:30:19 -04:00
Barret Schloerke
6651c4ea48
when freezing a reactivevalues key, use the name space similar to $.reactivevalues
2018-05-31 10:23:30 -04:00
Barret Schloerke
116559e5a0
use utils namespace
2018-05-31 10:21:55 -04:00
Barret Schloerke
7818e8ed64
white space
2018-05-31 10:21:42 -04:00
Barret Schloerke
b0063399bb
fix freeze/thaw rlog'ing
2018-05-30 14:14:57 -04:00
Barret Schloerke
724c6b7656
Merge branch 'master' into barret/reactlog
...
* master:
runApp: add support for IPv6 addresses
Bump version to *.9000. Back to work!
Bump version to 1.1.0
Bump httpuv version and add NEWS note
Fix #2061 : Tests failing on Windows due to rounding errors
Take dependency on later >=0.7.2
2018-05-29 18:26:24 -04:00
Barret Schloerke
0530cbcd0f
make sure log works with an empty log
2018-05-29 18:22:26 -04:00
Barret Schloerke
6e2bba1513
up the flow type percentage
2018-05-29 18:16:40 -04:00
Barret Schloerke
89ac5d7c42
ignore yarn error
2018-05-29 18:16:08 -04:00
Barret Schloerke
dd68722b66
first pass at cyto flow types
2018-05-29 12:01:36 -04:00
Barret Schloerke
933d5db2ab
flow more files
2018-05-29 09:59:19 -04:00
Barret Schloerke
0386ed6409
add index file for updateGraph to gather all exports for easy import
2018-05-29 09:34:06 -04:00
Barret Schloerke
d3c14bf416
first pass at flowtype
2018-05-29 09:33:02 -04:00
Barret Schloerke
2a224ce9fb
add babel plugin transform class properties within yarn
2018-05-29 09:32:53 -04:00
Barret Schloerke
78322525b7
add flow, flow scripts and update grunt-babel
2018-05-29 09:25:39 -04:00
Barret Schloerke
5b7c9c205e
remove rlog grunt tasks in favor of config files
2018-05-29 09:24:44 -04:00
Barret Schloerke
07ac70a460
add lodash flow types
2018-05-29 09:23:30 -04:00
Barret Schloerke
3629f806a2
add jquery flow types
2018-05-29 09:23:21 -04:00
Barret Schloerke
72fc43c738
add a flow config
...
only for rlog src
make all lints warnings
any suppress comment starts with "\\ $Flow"
and if strict (currently none) do recommended strict things
2018-05-29 09:23:06 -04:00
Winston Chang
2880391620
runApp: add support for IPv6 addresses
2018-05-25 16:19:51 -04:00
Barret Schloerke
df38f0be3f
clean up lint config
2018-05-23 17:02:26 -04:00
Barret Schloerke
808684c2a8
remove unused dep and script
2018-05-23 17:00:57 -04:00
Barret Schloerke
69ed3a7751
working graph with es6 modules
2018-05-23 16:40:24 -04:00
Barret Schloerke
68556caa9a
first pass at distributed files. graph loads, not all perfect
2018-05-23 12:02:59 -04:00
Barret Schloerke
bb8ea8053b
prettier and build script updates
2018-05-22 11:44:49 -04:00
Barret Schloerke
6f01e6edf1
first pass at sep classes
2018-05-22 10:38:10 -04:00
Barret Schloerke
66a74d16ff
lints
2018-05-22 10:01:07 -04:00
Barret Schloerke
0e525f5aeb
add Console module
2018-05-22 09:59:52 -04:00
Joe Cheng
f742605a1b
Bump version to *.9000. Back to work!
2018-05-17 17:20:17 -07:00
Barret Schloerke
86007c466d
copy in react_graph into index.js to start pruning into multiple files
2018-05-17 16:56:21 -04:00
Barret Schloerke
7b39b79183
added prettier config for rlog
2018-05-17 16:42:02 -04:00
Barret Schloerke
7f453aa6f6
add local rlog .eslintrc.js
2018-05-17 16:38:59 -04:00
Barret Schloerke
f36052ffeb
add test files
2018-05-17 16:38:34 -04:00
Barret Schloerke
d35db11f43
add gitignore in rlog
2018-05-17 16:19:20 -04:00
Barret Schloerke
173e5d3f97
prettier and lints
2018-05-17 16:18:05 -04:00
Barret Schloerke
bcebf737c3
move node_modules and grunt file to root dir
2018-05-17 16:13:13 -04:00
Winston Chang
2afff67e89
Bump version to 1.1.0
2018-05-16 15:18:59 -07:00
Winston Chang
fe7bd53250
Bump httpuv version and add NEWS note
2018-05-16 15:18:59 -07:00
Joe Cheng
6df3509869
Merge pull request #2062 from rstudio/joe/bugfix/windows-rounding
...
Fix #2061 : Tests failing on Windows due to rounding errors
2018-05-16 15:17:04 -07:00
Joe Cheng
062dc771aa
Fix #2061 : Tests failing on Windows due to rounding errors
2018-05-16 14:44:34 -07:00
Barret Schloerke
5280b72b85
add different log files for rlog to check
2018-05-15 12:21:29 -04:00
Barret Schloerke
a4dfe7138e
search regex implemented to update filtered data on getGraph.atStep(k)
2018-05-14 16:01:04 -04:00
Barret Schloerke
b9960bad1a
next, prev, next cycle, prev cycle implemented within new search
2018-05-14 15:34:35 -04:00
Barret Schloerke
e1d7805396
massive sweep on how filtering and hovering is done. Commiting. regex filter is unfinished
2018-05-11 14:59:50 -04:00
Barret Schloerke
ce6f993f0e
add filter by name
2018-05-10 10:54:14 -04:00
Barret Schloerke
aa1d94e6c9
first pass double click filter
2018-05-09 10:42:45 -04:00
Barret Schloerke
00a6092836
remove TODO
2018-05-09 10:41:45 -04:00
Barret Schloerke
f6372faa23
for future... make animation a setting
2018-05-04 11:10:01 -04:00
Barret Schloerke
1a5e266d26
Drastically improve performance by not re-rendering the layout on a layout that isn't changing
2018-05-04 11:02:33 -04:00
Barret Schloerke
2e4a107201
fix hover and sticky hover to be stable throughout transitions
...
all items use `hoverKey`. edges are supplying their ghostKey so that all edges share the same hoverKey. if A --> B then all edges from A to B will behave the same way.
2018-05-04 11:01:31 -04:00
Joe Cheng
d4688db31c
Update NEWS
2018-05-03 14:08:52 -07:00
Joe Cheng
c49a289619
Fix #2033 : Rstudio Viewer window not closed on shiny::stopApp()
2018-05-03 14:06:34 -07:00
Barret Schloerke
2559496ded
first pass at hover highlight. need to move to graph data object and not cyto object
2018-05-03 13:27:20 -04:00
Barret Schloerke
d3aa82fc5d
clean up graph addEntry wrapper
2018-05-03 13:26:53 -04:00
Barret Schloerke
704605918d
update layout options
2018-05-03 13:26:35 -04:00
Barret Schloerke
7e8116888b
add alt shift arrows navigation and prev / next step calculations
2018-05-03 13:25:25 -04:00
Barret Schloerke
e0f4bbd20d
skip adding entries if the reactId is rNoCtx
2018-05-02 15:12:21 -04:00
Barret Schloerke
5ae2d5a24b
Allow for isolate calls to have no context and input name changes to have no context
2018-05-02 15:11:58 -04:00
Barret Schloerke
8648737a7a
fix missing period bug
2018-05-02 15:11:19 -04:00
Barret Schloerke
6e090d5112
active enter and value change now pulse and use ActiveStateStatus helper
2018-05-02 11:25:08 -04:00
Barret Schloerke
2207e561f2
fix progress bar tick leaking right bug
2018-05-02 11:24:33 -04:00
Barret Schloerke
b9cd5b572b
first pass at ActiveStateStatus class with invalidate
2018-05-02 11:04:30 -04:00
Barret Schloerke
344c6f3ee7
use graph style and do not animate graph style
2018-05-02 11:03:52 -04:00
Barret Schloerke
f6f2c0ed56
first pass at cacheing graphs. wait for now
2018-05-02 11:01:01 -04:00
Barret Schloerke
ec7a66a966
make edges shades of grey
2018-05-02 11:00:34 -04:00
Barret Schloerke
23ca428a01
add cycle markers in the timeline
2018-05-02 10:58:47 -04:00
Barret Schloerke
eb9f251e34
add nav buttons
2018-05-02 10:58:15 -04:00
Joe Cheng
9c3a0c86ca
Take dependency on later >=0.7.2
2018-05-01 20:37:25 -05:00
Barret Schloerke
394d875eb4
valuechange addressed when an isolateInvalidateEnd is called
...
invalidate end also sets color to a 'done' grey
2018-05-01 14:12:02 -04:00
Barret Schloerke
4cc6403867
do not double log observable set invalidation
2018-05-01 14:09:09 -04:00
Barret Schloerke
9d5fa773f3
add classes and colors for different states of a graph
...
* reactive key value change until invalidate end has finished
* latest enter is darker green than others
* mousedown added to timeline click
* mousedown and mouse movement added to timeline
2018-05-01 10:08:37 -04:00
Barret Schloerke
075ca49a1f
log that invalidation has occured when an input value changes a key
2018-05-01 10:06:13 -04:00
Barret Schloerke
9564f1d871
invalidate rlog namesDeps on value change
2018-05-01 10:05:36 -04:00
Barret Schloerke
cf546a47b6
on rlog object definition, do not trigger a value change
2018-05-01 10:05:23 -04:00
Barret Schloerke
d3a4f35170
merge master --> reactlog
2018-04-30 11:25:03 -04:00
Barret Schloerke
f450aea449
allow for skipping to next cycle by holding altKey and arrow L/R
2018-04-30 11:21:15 -04:00
Barret Schloerke
aed308b259
styles added to animation in cyto nodes
2018-04-30 11:20:45 -04:00
Barret Schloerke
714dffc943
set up ghost edge and use classes in cyto graph
2018-04-30 11:04:13 -04:00
Barret Schloerke
f8a173efbd
first pass at cytoscape.js graph
2018-04-30 10:06:59 -04:00
Barret Schloerke
70e7822dd1
be clear in action name provided in log and give dependsOnRemove a ctxId
2018-04-30 10:06:40 -04:00
Winston Chang
01b24e984c
Merge pull request #2038 from rstudio/joe/bugfix/cycle-start-bugs
...
Fix #2037 : With enableBookmarking="url", clientData is not available …
2018-04-25 13:34:34 -05:00
Joe Cheng
9dd4302fe9
Fix #2037 : With enableBookmarking="url", clientData is not available when observers are first run
...
Also fixed reactiveTimer firing even while async tasks are active
2018-04-25 10:54:00 -07:00
Winston Chang
c2f03aa833
Merge pull request #2036 from rstudio/joe/misc/renderui-experimental
...
Remove "experimental feature" tag from renderUI
2018-04-24 12:42:04 -05:00
Barbara Borges Ribeiro
2260459422
brought observeEvent/eventReactive documentation up to date
2018-04-24 17:44:54 +01:00
Barret Schloerke
452631550a
single quotes to double quotes
2018-04-24 11:34:12 -04:00
Barret Schloerke
a14266b452
add freeze and thaw to logger
2018-04-24 11:34:00 -04:00
Winston Chang
e838cc3fe9
Re-document
2018-04-24 10:24:52 -05:00
Winston Chang
74457b95e9
NEWS edits
2018-04-24 10:17:03 -05:00
Barret Schloerke
ceb19c7573
use an rLog object to do all logging
2018-04-24 10:49:16 -04:00
Joe Cheng
d5754515a6
Remove "experimental feature" tag from renderUI
2018-04-23 17:05:08 -07:00
Joe Cheng
4ed13c04f5
Merge pull request #2032 from rstudio/fix-flushed-callbacks
...
Set default reactive domain when executing flushedCallbacks. Fixes #1975
2018-04-21 10:02:10 -07:00
Winston Chang
5a5294cc44
Set default reactive domain when executing flushedCallbacks. Fixes #1975
2018-04-21 11:46:50 -05:00
Joe Cheng
3a5d48ae7c
Remove outdated Remotes
...
Live code review by @wch
2018-04-19 14:59:10 -07:00
Joe Cheng
6b605804d2
Upgrade Selectize to 0.12.4
2018-04-19 14:19:12 -07:00
Joe Cheng
ffe883ab72
Merge pull request #2022 from rstudio/joe/bugfix/timer-leak
...
Fix #2021 : Memory leak with reactiveTimer and invalidateLater
2018-04-19 14:16:35 -07:00
Joe Cheng
31c4e0fdfe
Add test to demonstrate vectorized unscheduling
2018-04-19 12:52:30 -07:00
Joe Cheng
66f970e0bd
Merge pull request #2026 from rstudio/fix-ggplot2
...
Fix plot coordmap for devel version of ggplot2. Closes #2016
2018-04-19 12:46:38 -07:00
Winston Chang
07b223dcb0
Fix plot coordmap for devel version of ggplot2. Closes #2016
2018-04-19 11:40:26 -05:00
Joe Cheng
f1e27b6ffb
Fix #1922 : Warning: partial match of 'y' to 'yintercept'
2018-04-19 10:00:24 -05:00
Joe Cheng
389463aea5
Merge branch 'joe/feature/undedupe-inputs'
2018-04-18 19:33:37 -07:00
Joe Cheng
b11ab9a31c
Update NEWS
2018-04-18 12:53:31 -07:00
Joe Cheng
5fe85b07b7
Merge remote-tracking branch 'andrewsali/master'
2018-04-18 12:52:40 -07:00
Joe Cheng
3c7b1e7d21
Update NEWS
2018-04-18 12:32:16 -07:00
Joe Cheng
c556cf1e69
Fix #2021 : Memory leak with reactiveTimer and invalidateLater
2018-04-18 12:30:14 -07:00
Joe Cheng
722e5fb5f7
Modify internal JS to use Shiny.setInputValue, {priority: "event"}
2018-04-18 12:05:18 -07:00
Joe Cheng
e90cc591b7
Update NEWS
2018-04-18 11:57:55 -07:00
Barret Schloerke
7336d327b3
first pass at adding domain to all rlog functions
2018-04-18 11:49:11 -04:00
Joe Cheng
c555725201
Change {immediate: ...} to {priority: "deferred|immediate|event"}
...
This was the product of a long discussion between @wch, @alandipert, @bborgesr
and myself. The conflation of immediate (no throttle/debounce) and non-dedupe
in a single "immediate" flag was deemed unacceptable, because UI controls often
want immediacy but also dedupe. Introducing a second "dedupe" flag would work
but {immediate: false, dedupe: false} doesn't make much sense, and dedupe not
only implies that InputNoResendDecorator should behave differently but also
InputBatchSender (i.e. no deduplication AND no coalescing).
We decided to remove the "immediate" boolean option and replace it with a
string option that would have three possibilities at this time. The only con
to this approach is if anyone is calling onInputChange with immediate:true
today, and I can't imagine anyone is. The immediate flag only has any effect
if the input id that's being set has been put in debounce/throttle mode, and
I don't even think that is documented today, and I'm not even sure it's
possible to do it from custom JS (that's not part of a custom input binding).
2018-04-17 16:39:05 -07:00
Barret Schloerke
c9c5225a6a
add rlogAsyncStart and rlogAsyncStop
2018-04-17 10:58:20 -04:00
Barret Schloerke
e1060bf537
isolate calls should be handled differently than regular rlog calls
2018-04-17 10:10:01 -04:00
Barret Schloerke
392e42a55d
clean up when reactivevalues are defined and updated in rlog
2018-04-17 10:09:34 -04:00
Barret Schloerke
b974e41148
add test app for rlog
2018-04-17 10:09:00 -04:00
Barret Schloerke
aa3e2a0b64
ctxId's are now upgraded to start with 'ctx' in logging
2018-04-17 09:47:26 -04:00
Barret Schloerke
3df89dd9a3
local logging done with ". " for spacing
2018-04-17 09:46:54 -04:00
Joe Cheng
cef1f3c7ee
withReactiveDomain now acts as a promise domain
...
Without this change, async handlers won't return any
value for getDefaultReactiveDomain().
library(shiny)
library(promises)
ui <- fluidPage(
p("This app tests if async handlers have reactive domains. You'll get a yes/no answer below."),
h3(
"Does it work?",
textOutput("answer", inline = TRUE)
)
)
server <- function(input, output, session) {
output$answer <- renderText({
promise_resolve(TRUE) %...>% {
if (!is.null(getDefaultReactiveDomain()))
"Yes!"
else
"No :("
}
})
}
shinyApp(ui, server)
2018-04-16 20:51:46 -05:00
Joe Cheng
e5d1fa1ea4
Fix #2008 : Allow eventReactive and observeEvent eventExprs to be async ( #2014 )
...
* Fix #2008 : Allow eventReactive and observeEvent eventExprs to be async
This makes it possible to monitor e.g. async reactives.
In the process of fixing this, also discovered that observers don't
filter out shiny.silent.error (i.e. req(FALSE)) when they come back
from async operations. For example, this will kill the current
Shiny session instead of being ignored:
observe({
promise_resolve(TRUE) %...>%
{req(FALSE)}
})
This issue is also fixed in this commit.
* Enable deep stack trace by default, now that it's fast
2018-04-16 20:50:28 -05:00
Joe Cheng
3ccf2937b4
Fix #928 : allow inputs to trigger reactive flow even if the value of input hasn't changed
...
We already had an `immediate` input option, which was used to override client side rate
limiting mechanisms (debounce/throttle). This commit extends the semantics of that option
to also mean that duplicate values should not be ignored on the client side.
Previous to this commit, circumventing the client side dedupe logic was not enough. The
server side ReactiveValues object was also subject to deduping. With this commit, the
low-level ReactiveValues class's constructor now has a `dedupe` option, which defaults
to TRUE; the ReactiveValues used for a session's input has it turned to FALSE. I figure
if I had to work this hard to get the client to stop sending duplicates, and the input
values are only expected to ever be updated by the client, then there's really no reason
for server side deduping to be performed for this particular ReactiveValues object.
It would make sense as a future feature to also make deduping optional for user-created
reactiveValues and reactiveVal objects.
2018-04-16 18:37:47 -07:00
Joe Cheng
b7b696630f
Fix #2003 : Long stack traces are truncated
2018-04-16 17:16:12 -05:00
Joe Cheng
84aba546bc
Fix #2000 : Implicit calls to xxxOutput not working inside modules ( #2010 )
...
* Fix #2000 : Implicit calls to xxxOutput not working inside modules
* Add comment, update NEWS
* Credits in NEWS
2018-04-16 16:57:13 -05:00
Barret Schloerke
6ef751422a
first pass at reformatting rlog
2018-04-16 13:37:50 -04:00
Barret Schloerke
05d49ee45e
use MessageLogger for node information cache
2018-04-16 09:47:58 -04:00
Barret Schloerke
3e4783c454
remove dot syntax
2018-04-16 09:33:09 -04:00
Barret Schloerke
ce93201843
make the rlog messages a r6 object
2018-04-16 09:28:54 -04:00
Barret Schloerke
f9fc3a46b5
change all nodeId to reactId
2018-04-16 09:17:04 -04:00
Barret Schloerke
0467d6666a
merge master -> barret/reactlog
2018-04-13 11:26:34 -04:00
Barret Schloerke
1f26b076a3
first pass gantt chart... brings up future thoughts
...
could add a gantt chart at bottom of react-graph for the current execution session. Would be interesting to have a full gantt of the current execution 'cycle' with a bar indicating where we are in time to give context to the current graph layout. the gantt coult reset at each 'cycle' as the context is reset as well
2018-04-13 11:22:23 -04:00
Barret Schloerke
7944f21925
break apart the large react-graph.html file
2018-04-13 10:20:08 -04:00
Barret Schloerke
e91eda8eca
add npm scripts to build, clean, and watch the js
2018-04-13 10:19:10 -04:00
Barret Schloerke
d8ac84a5da
add rLogValueChange (no start/end, just change)
2018-04-13 10:18:11 -04:00
Barret Schloerke
3098a02b72
first pass at making rlog. need javascript to recognize new log format
2018-04-13 10:07:03 -04:00
Winston Chang
741236df56
Merge pull request #2011 from rstudio/joe/feature/output-null
...
Fix #1989 : Allow outputs to be removed by assigning NULL to them
2018-04-12 16:29:48 -05:00
Winston Chang
e3584f0a61
Merge pull request #2013 from rstudio/joe/bugfix/render-plot-args
...
renderPlot's ... args were being dropped
2018-04-12 16:27:46 -05:00
Joe Cheng
432482c5a7
renderPlot's ... args were being dropped
2018-04-12 11:57:32 -07:00
Joe Cheng
323ad46bba
Implement #1989 : Allow outputs to be removed by assigning NULL to them
2018-04-11 18:40:32 -07:00
Alan Dipert
ace0fe1802
Merge pull request #2005 from rstudio/alan/bugfix/dndfix
...
Fix dragging and dropping in the presence of jQuery 3.0
2018-04-11 11:53:42 -07:00
Alan Dipert
36f244fece
Merge branch 'master' into alan/bugfix/dndfix
2018-04-11 11:52:23 -07:00
Joe Cheng
99e5ef99ec
Move some bullets around
2018-04-10 10:08:15 -07:00
Alan Dipert
d6d3ed5bbc
NEWS
2018-04-10 08:40:40 -07:00
Alan Dipert
49d09ecf30
Grunt
2018-04-10 08:30:46 -07:00
Alan Dipert
c529a03096
DnD: Fix in the presence of jQuery 3.0 (removed .size())
2018-04-10 08:29:03 -07:00
Andras Sali
101d9aa0fa
Move trigger after value change
2018-04-07 16:51:03 +02:00
Andras Sali
b4864e1180
Trigger shiny:value even if same data is received. Fixes #1978
2018-04-07 16:46:34 +02:00
Winston Chang
cba7304ab9
Merge pull request #1996 from rstudio/fix-selectize
...
fix selectize capitalization (regression introduced by #1861 )
2018-04-05 11:58:20 -05:00
Barbara Borges Ribeiro
2d058b0519
move attribute setting to after choices is reassigned (this was getting lost after the changes in #1861 ).
2018-04-04 19:55:15 +01:00
Barbara Borges Ribeiro
eed9231884
fix selectize capitalization (regression introduced by #1861 )
2018-04-04 14:00:44 +01:00
Joe Cheng
5c84eaf2a5
Merge pull request #1990 from rstudio/joe/feature/better-stacks
...
Better stack traces
2018-03-27 19:31:51 -07:00
Joe Cheng
2ef7226be0
Use seq_along instead of 1:length(x)
...
It behaves when length(x) == 0
2018-03-27 18:30:24 -07:00
Joe Cheng
e5d1c61cdf
Merge branch 'master' into joe/feature/better-stacks
2018-03-27 18:04:05 -07:00
Joe Cheng
e635055ab8
Update NEWS
2018-03-27 18:02:41 -07:00
Joe Cheng
d8d4e3b262
Don't error when entire stack trace is stripped/pruned
2018-03-27 16:35:45 -07:00
Joe Cheng
8f29543479
Use qualified name for utils::tail (R CMD check NOTE)
2018-03-27 16:19:28 -07:00
Joe Cheng
c11a8ea24b
Fix tests
2018-03-27 15:35:29 -07:00
Joe Cheng
86646d7faa
Make srcref offsetting optional
2018-03-27 15:35:06 -07:00
Joe Cheng
6e44915e08
Merge pull request #1984 from rstudio/joe/feature/faster-deep-stacks
...
Lazily format stack traces
2018-03-27 10:31:00 -07:00
Joe Cheng
f8b99cf4e9
Add deprecation docs
2018-03-26 11:38:12 -07:00
Joe Cheng
0e7d6ff192
Refactoring and deprecation in conditions.R
...
- Refactor printError so a working printStackTrace falls out
- Deprecate extractStackTrace and formatStackTrace, see if anyone uses them
2018-03-26 11:35:50 -07:00
Barbara Borges Ribeiro
66501dac97
Add new autoclose = TRUE param to dateInput() and dateRangeInput ( #1987 )
...
* Add new `autoclose = TRUE` param to both dateInput() and dateRangeInput()
* added NEWS item
2018-03-23 09:40:19 -07:00
Joe Cheng
195907b2ec
printError implements lobstr::cst analysis and deep-stack-aware frame suppression
2018-03-22 12:22:46 -07:00
Joe Cheng
be11b44864
First steps to improved stack traces
...
- Adds functions we will need for tracking ..stacktraceon/off..
across deep stacks
- Adds functions we will need for pruning according to lobstr::cst
logic
These functions are not yet integrated, that will occur in a
separate commit.
2018-03-20 16:45:47 -07:00
Joe Cheng
bc7cd21c13
Update NEWS.md
2018-03-20 16:39:52 -07:00
Carson Sievert
0555cbdd28
relay offsetWidth/offsetHeight of htmlwidgets to clientData ( #1981 )
...
Addresses #1980
2018-03-20 16:37:43 -07:00
Joe Cheng
97498451bb
Lazily format stack traces
...
With deep stack traces enabled, whenever then() is called, we need
to grab the current stack, just in case a downstream callback throws
an error and we need to form a deep stack trace.
Previously, we were calling formatStackTrace at the time that we
grab the current stack (i.e. no error has happened yet) because I
wasn't sure whether holding a reference to sys.calls() for a long
time was a good idea from a garbage collection perspective; would it
prevent the stack frame environments from being collected? But the
answer is no, sys.calls() is just calls, which can be confirmed with
.Internal(inspect(sys.calls()).
By deferring the formatStackTrace call to when we actually need to
print the stack trace, we save ourselves a ton of work--it turns out
it's quite expensive to format the stack traces, much more expensive
than sys.calls() alone.
2018-03-20 12:35:17 -07:00
Joe Cheng
2e0d9b5475
Bump httpuv dependency version
2018-03-18 19:07:43 -07:00
Barbara Borges Ribeiro
62395f3103
Improve error handling when addResourcePath() fails (especially for runtime: shiny_prerendered documents) ( #1968 )
...
* A copy of yihui's PR for rmarkdown (https://github.com/rstudio/rmarkdown/pull/1171/ ) to avoid to error "Error in normalizePath: path[1]="": No such file or directory" when running any tutorial
* first try
* limited the scope of the `tryCatch` wrapper to the one important line that needed it; added news item
2018-03-16 15:36:12 -07:00
Winston Chang
6b31cd6aee
Merge pull request #1965 from rstudio/joe/bugfix/plot-dim-error
...
Fix #1964 : renderPlot cache breaks when width/height throw
2018-03-01 11:12:56 -06:00
Joe Cheng
e67a8ba369
Fix #1964 : renderPlot cache breaks when width/height throw
...
Fixed by moving the isolate(getDims()) call into the (effectively)
try/catch that does a non-isolated getDims() if an error occurs
2018-02-28 15:40:55 -08:00
Joe Cheng
133d301925
Merge pull request #1961 from rstudio/fix-date-sliders-bookmarking
...
Fix URL-encoded bookmarking with date/date-time sliders
2018-02-28 14:26:50 -08:00
Joe Cheng
17c40a5d1d
Merge pull request #1960 from rstudio/slider-formatting
...
Don't show commas after decimal mark in sliderInput
2018-02-28 13:01:20 -08:00
Winston Chang
042211e5f6
Grunt
2018-02-28 14:34:09 -06:00
Winston Chang
d12830d700
sliderInput: don't show commas after decimal
2018-02-28 14:33:42 -06:00
Winston Chang
b411c70280
Fix URL-encoded bookmarking with date/date-time sliders
2018-02-27 20:42:11 -06:00
Winston Chang
2bc22cc7d5
Merge pull request #1955 from rstudio/update-slider
...
Update ion.rangeSlider to 2.2.0
2018-02-27 13:21:09 -06:00
Joe Cheng
b4c189c89b
Merge pull request #1956 from rstudio/fix-slider-rounding
...
Avoid rounding errors in sliderInput
2018-02-27 10:55:11 -08:00
Winston Chang
fe3f351a2d
Avoid rounding errors from pretty(). Fixes #1006
2018-02-27 10:50:36 -06:00
Winston Chang
076be9cba7
Remove unused keyboard_step parameter
...
keyboard_step was removed in ion.rangeSlider 2.2.0.
2018-02-26 15:57:30 -06:00
Winston Chang
f28dcd85fb
Update to ion.rangeSlider 2.2.0
2018-02-26 15:57:30 -06:00
Joe Cheng
8e0f17c9d7
Merge pull request #1954 from rstudio/fix-bookmark-restore
...
Look for restore context associated with session
2018-02-26 09:25:33 -08:00
Winston Chang
d73817a0db
Look for restore context associated with session. Fixes #1948
2018-02-26 10:55:38 -06:00
Joe Cheng
11874db825
Remove background-thread branch from httpuv remote
2018-02-16 15:41:32 -08:00
Joe Cheng
5d5a43ce90
Merge pull request #1932 from rstudio/async
...
Async
2018-02-16 07:41:36 -08:00
Winston Chang
75e548caab
For installation of Rtools on Appveyor
2018-02-16 09:15:40 -06:00
Joe Cheng
c901e7ba06
Update TODO-promises.md
2018-02-13 15:23:06 -08:00
Joe Cheng
b1dc3dfca1
Restore label to plotObj reactive
2018-02-09 11:12:46 -08:00
Joe Cheng
ce4ed20c69
Fix remaining failing tests
2018-02-09 11:12:46 -08:00
Joe Cheng
d44df7f860
Stack traces were being lost inside hybrid_chain
2018-02-09 11:12:46 -08:00
Joe Cheng
54353e0e1f
Fix coordmap unit tests
2018-02-09 11:12:46 -08:00
Joe Cheng
1c042b6efb
Add to .Rbuildignore
2018-02-09 11:12:46 -08:00
Joe Cheng
b8df1f29c4
Remove unused function
2018-02-09 11:12:46 -08:00
Joe Cheng
18252f5b03
Use later >= 0.7.1
2018-02-09 11:12:46 -08:00
Joe Cheng
881370f284
Remove extraneous comments
2018-02-09 11:12:46 -08:00
Joe Cheng
35d1747bc3
Don't allow invalidation from a child process
2018-02-09 11:12:46 -08:00
Joe Cheng
91ac89a54e
Update TODOs
2018-02-09 11:12:46 -08:00
Joe Cheng
3c694d9bd9
More robust process identification (thanks @HenrikBengtsson)
2018-02-09 11:12:46 -08:00
Joe Cheng
6a78e9df77
Detect (probably inadvertent) attempts to inherit reactive contexts across processes
...
Example (we want this to fail):
library(shiny)
library(future)
plan(multicore)
r <- reactiveVal(TRUE)
isolate({
f <- future({
r()
})
value(f)
})
2018-02-09 11:12:45 -08:00
Joe Cheng
078c6eb30a
Add TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
d35c6002a6
Respect pixelratio (retina) when redrawing cached images
2018-02-09 11:12:45 -08:00
Joe Cheng
f23fc3beaa
Plots were not respecting pixel ratio (retina)
2018-02-09 11:12:45 -08:00
Joe Cheng
5a352e5ace
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
27cae0065e
Fix bug where req(cancelOutput=TRUE) would leave things grey
...
This was introduced by some changes to shinyapp.js that were necessary
before async outputs and sync outputs were held/flushed together. Now
that async/sync outputs are held/flushed together, these changes are
not necessary and removing them fixes the problem.
The test app is in shiny-examples/205-async-req. I also moved a test
app from manualtests/async/download.R to shiny-examples/204-async-download.
2018-02-09 11:12:45 -08:00
Joe Cheng
50be2993fa
Add TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
d9ea15e9bc
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
03b1d45d7e
Make deep stack traces opt-in; fix imports
2018-02-09 11:12:45 -08:00
Joe Cheng
e48d6878c4
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
1a3b255848
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
f00aa94d7e
Suspend session during async download operation
2018-02-09 11:12:45 -08:00
Joe Cheng
f7980b19f4
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
6a1f9677a5
Support async downloadHandler content functions
...
If a downloadHandler content function returns a promise (or future)
then Shiny will wait for the promise to resolve before serving up
the file download.
2018-02-09 11:12:45 -08:00
Joe Cheng
e844bb36a5
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
ae364adfc2
wip2
2018-02-09 11:12:45 -08:00
Joe Cheng
c14a382b90
wip
2018-02-09 11:12:45 -08:00
Joe Cheng
da9c2beaaf
Update TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
a4a56476db
Update TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
39d3784b9b
async support for renderDataTable
2018-02-09 11:12:45 -08:00
Joe Cheng
7d29df58f1
Support same-tick execution for synchronous outputs
2018-02-09 11:12:45 -08:00
Joe Cheng
05aa413683
promises::finally() was missing namespace prefix
2018-02-09 11:12:45 -08:00
Joe Cheng
132f90f45b
Support promise domain wrapSync; fix renderPrint visibility
...
Also introduce promise_chain and hybrid_chain, for assembling chains of
operations without involving magrittr-style operators
2018-02-09 11:12:45 -08:00
Joe Cheng
4526fd1917
Update TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
2602dc15b0
Changes to flush cycle to support async
...
- Moved (in|de)crementBusyCount calls out of Context and into Observer
- decrementBusyCount is (effectively) deferred for async observers until
the async operation is complete
- invalidateLater didn't force(session), almost certainly was buggy
- invalidateLater, reactiveTimer, and manageInputs all now use a new
session$cycleStartAction, which delays their effect until observers
(including async ones) are done executing
2018-02-09 11:12:45 -08:00
Joe Cheng
2314f63424
Fix broken .shiny__stdout mechanism
2018-02-09 11:12:45 -08:00
Joe Cheng
c2410600ee
Refactor list of TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
f7e4702685
Restore writing of _n_flushReact and _x_flushReact to stdout
2018-02-09 11:12:45 -08:00
Joe Cheng
71682512c4
Refactor flush cycle
2018-02-09 11:12:45 -08:00
Joe Cheng
20b82fbf77
Cleanup R CMD check
2018-02-09 11:12:45 -08:00
Joe Cheng
631f09847d
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
671585f68a
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
5feed888bb
Add promises to remotes
2018-02-09 11:12:45 -08:00
Joe Cheng
47bef0f1b0
Remove extraneous debugging code
2018-02-09 11:12:45 -08:00
Joe Cheng
c1dc662a40
"promise" package was renamed to "promises"
2018-02-09 11:12:45 -08:00
Joe Cheng
16e1721fe8
Add TODO comment
2018-02-09 11:12:45 -08:00
Joe Cheng
f406e13600
Add TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
9063133a7b
Fix various rendering bugs
2018-02-09 11:12:45 -08:00
Joe Cheng
3fbb436187
Add call_async temporarily; this should probably live somewhere else
2018-02-09 11:12:45 -08:00
Joe Cheng
7c845d070b
Sync to changes in promise. run_now aggressively in serviceApp.
2018-02-09 11:12:45 -08:00
Joe Cheng
5e905aa73e
Implement execOnResize
2018-02-09 11:12:45 -08:00
Joe Cheng
e15654f265
Minor renderPlot cleanup
2018-02-09 11:12:45 -08:00
Joe Cheng
369c067efc
Update TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
c037e69793
Fix ggplot brushing
2018-02-09 11:12:45 -08:00
Joe Cheng
8c935ff44e
Use proper promise:: prefix
2018-02-09 11:12:45 -08:00
Joe Cheng
74bf8b0554
renderPlots works!!! Testing needed.
2018-02-09 11:12:45 -08:00
Joe Cheng
6345972efe
Adapt promise domains to handle multiple arguments
2018-02-09 11:11:35 -08:00
Joe Cheng
16242e87a1
Some steps toward renderPlot working. Move to promise package instead of system2.5.
2018-02-09 11:11:34 -08:00
Joe Cheng
8155320ba5
wip
2018-02-09 11:09:28 -08:00
Winston Chang
39a7f63972
Update NEWS
2018-01-29 13:45:23 -06:00
Dmitriy Selivanov
7b72209277
fixes #1859 ( #1861 )
...
* style & formatting. fixes #1859
* prepare `choices` in `updateSelectizeInput()` as per discussion in #1861
* remove duplicated block in selectizeJSON, simply `lab` assignement logic
2018-01-29 13:41:30 -06:00
Joe Cheng
cad20a0bfe
Merge pull request #1856 from rstudio/wch-do-call
...
Quote arguments to do.call() for nicer stack traces
2017-10-31 11:28:47 -07:00
Winston Chang
ba8d79f202
Fix version text substitution
2017-10-17 10:51:19 -05:00
Winston Chang
176fe699b9
Point to RStudio Community website instead of shiny-discuss
2017-09-27 15:54:05 -05:00
Winston Chang
213ee7be13
Quote arguments to do.call() for nicer stack traces. Closes #1851
2017-09-26 14:36:19 -05:00
Joe Cheng
48fd869c71
Merge pull request #1848 from rstudio/barbara/fix/icon
...
Revert back the relative position of the icon and title in tabPanel's and navbarMenu's
2017-09-12 07:34:31 -07:00
Barbara Borges Ribeiro
53e47484e2
reverted the relative positioning of the icon and the title text in navbarMenus and tabPanels back to what it was before Shiny 1.0.5 ( fixes #1840 )
2017-09-12 12:16:06 +01:00
Winston Chang
dc18b20e5a
Don't copy httpuv::decodeURIComponent at build time
2017-09-07 21:31:32 -05:00
Barbara Borges Ribeiro
b4c5debbdf
Merge pull request #1844 from rstudio/barbara/fix/reactlog
...
Changed script tags in reactlog from HTTP to HTTPS
2017-09-07 01:43:46 +01:00
Barbara Borges Ribeiro
771d3d52b9
Changed script tags in reactlog from HTTP to HTTPS in order to avoid mixed content blocking by most browsers (thanks @jekriske-lilly)
2017-09-07 01:34:17 +01:00
Joe Cheng
2a53ac093d
Merge pull request #1830 from rstudio/wch-compare-version
...
Add Shiny.compareVersion() function
2017-09-05 11:37:17 -07:00
Winston Chang
4fa2af72cc
Avoid port 6697. Closes #1784
2017-08-28 16:40:51 -05:00
Winston Chang
e512d3cd61
Grunt
2017-08-25 14:46:19 -05:00
Winston Chang
16b7ee3985
Add Shiny.compareVersion() function
2017-08-25 14:46:06 -05:00
Winston Chang
4f3d26c31b
Add Shiny.version to Javascript ( #1826 )
...
* Add Shiny.version to Javascript
* Grunt
2017-08-23 15:52:16 -05:00
Winston Chang
587bf94d69
Merge tag 'v1.0.5'
...
Shiny 1.0.5 on CRAN
2017-08-23 15:27:56 -05:00
Winston Chang
635ad77e0d
Bump version to 1.0.5
2017-08-23 13:11:59 -05:00
Winston Chang
33258da6c3
Bump version to 1.0.5.9000
2017-08-23 13:07:15 -05:00
Joe Cheng
c2b3c3379d
Fix #1824 : HEAD request on static files causes app to stop ( #1825 )
...
* Fix #1824 : HEAD request on static files causes app to stop
The problem was that for HEAD requests specifically, we implement
an explicit Content-Length header (normally we let httpuv figure
out the Content-Length based on the content, but for HEAD we don't
return any content but still want to include the Content-Length).
The Content-Length header was only implemented correctly for string
values, not for raw vectors or file-by-path. This change implements
the value correctly for all currently valid httpuv content.
* Update NEWS
* Code review feedback
2017-08-23 13:01:22 -05:00
Winston Chang
e30fac02ed
Add safe wrapper for fromJSON
2017-08-21 19:55:48 -05:00
Winston Chang
e74592a654
Escape a few more characters for conditionalPanel expressions
2017-08-21 14:25:20 -05:00
Joe Cheng
ebd47aa73b
Merge pull request #1820 from rstudio/wch-fix-conditionalpanel
...
Escape newline characters in conditionalPanel expression
2017-08-18 20:49:48 -04:00
Winston Chang
e2d19cbaba
Grunt
2017-08-18 17:24:06 -05:00
Winston Chang
1f864a846f
Escape newline chars in conditionalPanel expr. Fixes #1818
2017-08-18 17:24:06 -05:00
Winston Chang
fc32c2c944
Clarify that choices must be strings
2017-08-18 11:48:41 -05:00
Winston Chang
279e37f1cb
Bump version to 1.0.4.9000
2017-08-18 11:47:19 -05:00
Winston Chang
3f9176176e
Merge tag 'v1.0.4'
...
Shiny 1.0.4 on CRAN
2017-08-14 12:01:26 -05:00
Winston Chang
b3201ccafd
Add functions to news item
2017-08-10 14:29:06 -05:00
Winston Chang
2a01a620a9
Add NEWS summary
2017-08-10 12:03:22 -05:00
Winston Chang
6f43cf7b82
NEWS cleanup
2017-08-09 18:49:34 -05:00
Winston Chang
1c6250f9c2
Bump version to 1.0.4
2017-08-09 18:49:34 -05:00
Barbara Borges Ribeiro
650075a9ab
Fix appendTab for empty tabsetPanels ( #1813 )
...
* fix appendTab for empty tabsetPanels; use spread operator to avoid having to resort to apply; upgrade grunt.
* revert back to `Math.max.apply(null, existingTabIds) + 1;` there's no browser compatibility issues there
2017-08-09 18:45:25 -05:00
Winston Chang
668ee6f24a
Add references to issues
2017-08-08 11:16:57 -05:00
Alan Dipert
c456ec2c4c
drag/drop-able fileInputs ( #1782 )
...
* fileInput WIP: Show dropzones when file dragged over window
- Still need to validate dataTransfer contents
* WIP: Basic functionality working
* wip
* Grunt
* WIP state machine
* WIP generalize FSM to data+multimethod
* WIP multimethod
* WIP draghover
* wip multimethod
* WIP, such refactor
* WIP: rm multimethod
* WIP
* WIP resurrect multimethod
* WIP move draghover functions into input object
* WIP colors: use more muted, bootstrap-esque glows
* Grunt
* WIP: use whenAny, more descriptive args in default test/dispatch fns
* WIP more whenAny
* Grunt
* WIP dont use for...of, requires polyfill
* Grunt
* multimethod improvements, documentation. `equal` function.
* multimethod: simplified equal, removed need for forward decl. docs.
* dox
* multimethod improvements, docs
* minor
* IE 10+ drag/drop, first cut
* Grunt
* use functions not arrows for faux instance methods
* Grunt
* fix uploadDropped call
* Grunt
* cleanup drop handler, fix entry to invalid state via doc drop handler
* Grunt
* IE workaround #293932
* Grunt
* yeeeeeeeeeeessss IE WORKSSSSS
* Cleanup; support activeClass/overClass
* everything basically works everywhere \o/
* revert ability to specify classes, hardcode in JS
* MM fixes
* minor fixes
* Grunt
* DnD: Support dragging directly over zones
- Happens when source window occludes browser window
* woo
* Note Safari bug, use draghover for zones
* merge
* Grunt
* news
* include CSS
2017-08-08 11:12:21 -05:00
Joe Cheng
3b0c390a9e
Merge pull request #1794 from rstudio/barbara/tabs
...
Dynamic tabs
2017-08-04 11:31:50 -07:00
Barbara Borges Ribeiro
b02eb11345
do inputId <- session$ns(inputId) in user facing functions for module functionality (rather than overriding the same functions in makeScope)
2017-08-04 18:02:43 +01:00
Barbara Borges Ribeiro
ed3ba303bc
Joe's feedback
2017-08-04 17:56:58 +01:00
Barbara Borges Ribeiro
ee5da1410e
make hide and remove work well when we want to hide/remove a tab inside a navbarMenu (or the whole menu) and it is selected (before this commit, it wasn't navigating to the first tab like it is supposed to)
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
494627c6e1
make this PR work for modules
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
82ac112dec
added select argument to showTab function
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
40cfff33ff
for dynamic tabs, send message on session$onFlush (instead of session$onFlushed)
2017-08-04 15:10:08 +01:00
Joe Cheng
c1c5873912
Abandon nearest neighbor tab-showing logic. Just grab the first tab.
2017-08-04 15:10:08 +01:00
Joe Cheng
c090efd562
Fix bug where last tab being removed, didn't update tabset input value
2017-08-04 15:10:08 +01:00
Joe Cheng
91dbb0e77b
htmlDependencies are properly loaded with dynamic tabs
2017-08-04 15:10:08 +01:00
Joe Cheng
dde7b144f0
Add select=FALSE argument to insert/append/prependTab
2017-08-04 15:10:08 +01:00
Joe Cheng
f1873a014c
Make tab prepend/append just edge cases of insert
2017-08-04 15:10:08 +01:00
Joe Cheng
48b8923b67
Properly escape jQuery selector strings
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
6f9f3fea83
implement navigation after hiding/removing selected tab
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
10f3320165
more JS code refactoring; improved documentation
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
d57aa33b40
insertion fully implemented
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
0e7c78bae3
refactored code and made insertion of navbarMenus possible
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
e6602786ec
updated docs
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
31bbb3894c
remove extra line
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
8bbf576807
typo: tag -> tab (makes a big difference!)
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
1ecc9b9d0e
Fixed documentation problems and JS code logic
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
3adbebc3d9
document similar things together; add prependTab and appendTab
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
a4c086f51b
now working for navbarPage and navlistPanel
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
0ecdcec698
clean up JS code (1 line only)
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
ae7f026d46
added NEWS and fixed typo
2017-08-04 15:10:08 +01:00
Barbara Borges Ribeiro
2813e0b706
update examples
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
a409562d00
delete extra brackets
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
b6b6661ea1
implement showTab and removeTab
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
fb7b6f667c
implement removeTab
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
b94efe81e4
finish insertTab
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
72a1b3d2a0
add functions to index.r
2017-08-04 15:09:00 +01:00
Barbara Borges Ribeiro
20bff18bd4
changes
2017-08-04 15:09:00 +01:00
Winston Chang
ba5c5ef4fb
Move isRunning function to better location
2017-07-27 14:56:01 -05:00
Barbara Borges Ribeiro
aff3ac0bb3
Add onStop function ( #1770 )
...
* NEWS item
* added `onStop` arg to `shinyApp()` (and renamed our internal `onEnd` - which is what was calling `on.exit()` already - to `onStop` as well)
* added onStop() function
* add entry for documentation
* make it work for all possible app structures (interactive, saved as app.R, saved as ui.R and server.R)
* fix #1772 : make sure `onStart` works in all scenarios
* update NEWS
* improved wording
* more wording
* and more wording
* don't stop execution if a `onStop` callback function results in an error
* remove "(all sessions have been disconnected)" because it's misleading
* add @seealso documentation
* shamefully forgot to Cmd Shift D
* change code place
* Code review feedback
* onStop: use session argument instead of scope
2017-07-27 14:54:55 -05:00
Winston Chang
2c350daf01
Merge pull request #1802 from rstudio/bugfix/rstudio-debugger
...
work around RStudio debugger issue (closes #1474 )
2017-07-27 13:14:01 -05:00
Winston Chang
cb7627c736
Update NEWS and add comment
2017-07-27 13:13:31 -05:00
Kevin Ushey
f731a5cae4
work around RStudio debugger issue ( closes #1474 )
2017-07-27 10:37:56 -07:00
Winston Chang
07cb7c9305
Add 'setSerializer' function ( #1792 )
2017-07-18 17:01:06 -05:00
Winston Chang
86e9cc4896
Add preprocessor for fileInputs that strips local path ( #1789 )
...
* Add preprocessor for fileInputs that strips local path
* Update NEWS
* Rename snapshotPreprocess to snapshotPreprocessOutput
* Add snapshotPreprocessInput function
* Remove unnecessary NEWS item
* Update NEWS
* Add getSnapshotPreprocessInput
* Add staticdocs entry for snapshotPreprocessInput
* Add private methods to get snapshotPreprocess functions
* Bump version to 1.0.3.9002
2017-07-13 16:07:16 -05:00
Joe Cheng
12c9405257
Merge pull request #1790 from rstudio/wch-warn-level
...
Don't reduce warn level when running app
2017-07-12 22:41:21 -07:00
Winston Chang
4708b44c59
Don't reduce warn level when running app. Fixes #1680
2017-07-12 19:29:49 -05:00
Winston Chang
4cb428bb92
Add a function to test if an app is running ( #1785 )
...
Squashed commit of the following:
commit 8667bed8962069a5cab8691f981e2b7ba9d449c3
Author: Winston Chang <winston@stdout.org >
Date: Tue Jul 11 14:36:11 2017 -0500
Edits
commit c4e8549ca5
Author: Konrad Rudolph <konrad.rudolph@gmail.com >
Date: Fri Jul 7 17:57:33 2017 +0100
Describe changes
commit 7b05c2e60f
Author: Konrad Rudolph <konrad.rudolph@gmail.com >
Date: Fri Jul 7 17:54:40 2017 +0100
Add new function to doc index
commit eb93ebfad8
Author: Konrad Rudolph <konrad.rudolph@gmail.com >
Date: Fri Jul 7 17:54:30 2017 +0100
Add documentatio for new function
commit 1a6c8a4d72
Author: Konrad Rudolph <konrad.rudolph@gmail.com >
Date: Fri Jul 7 17:53:13 2017 +0100
Add a function to test whether the app is running
2017-07-11 14:36:59 -05:00
Mine Cetinkaya-Rundel
d7391b19bc
Convert examples to single file apps ( #1685 )
...
* - Convert all example apps to single file app.R file
- Make relevant updates to Readmes to match up with app.R structure
- Add color to plots (RStudio blue)
- In 04_mpg example: Show outliers by default, as opposed to hide, since this is more routine
- In 06_tabsets and 08_html examples: Don't name random data vector "data"
- Add extensive comments to app.R files and use consistent formatting of comments across examples
- In 09_upload example: Use req() to check for NULL entry
* add news entry summarizing changes
* use true RStudio blue, #75AADB
* Conver shinyApp calls at the end to drop argument name in examples 3-11, except for the custom HTML example. Kept them in for examples 1&2 for completeness in first exporuse to function.
* Pull news items that got added before this PR was merged
* Update comment for shinyApp function -- it creates an app object, doesn't run the app
2017-07-11 14:20:01 -05:00
Joe Cheng
db9e56d1ca
Merge pull request #1768 from rstudio/wch-fix-with-private-seed
...
Fix withPrivateSeed
2017-07-11 12:17:02 -07:00
Winston Chang
e527af10f4
New version of httpuv is on CRAN
2017-07-11 13:45:45 -05:00
Joe Cheng
74c7be0a6d
Merge pull request #1786 from rstudio/joe/bugfix/fileinput-content-type
...
Use a more suitable content type for file uploads
2017-07-10 15:39:13 -07:00
Joe Cheng
2d40e7b51a
Use a more suitable content type for file uploads
...
application/x-www-form-urlencoded;charset=UTF-8 is the default, which shinyapps.io
cares about for some reason and tries to parse the data as such. By setting the
content type to the more accurate application/octet-stream, no middleware should
be tempted to futz with the contents.
2017-07-10 15:33:42 -07:00
Winston Chang
ea407fb2ea
Don't include xtable comment in renderTable by default
2017-06-27 15:05:31 -05:00
Winston Chang
fca5b0529a
Remove reinitalizeSeed
...
This function is no longer needed because the minimum R vesion supported by Shiny is 3.0.2.
2017-06-27 10:30:50 -05:00
Winston Chang
65fd1dd2d8
Remove branch name for httpuv remote
2017-06-26 22:40:37 -05:00
Winston Chang
0a7ede3818
Add tests for random streams
2017-06-26 21:59:52 -05:00
Winston Chang
24e84f3866
Prevent private random stream from leaking out. Fixes #1763
2017-06-26 21:59:51 -05:00
Winston Chang
c1c8e46c09
Refactor withPrivateSeed
2017-06-26 21:59:51 -05:00
Winston Chang
8591e4f301
Add working app for conditionalPanel example
2017-06-23 10:14:32 -05:00
Alan Dipert
10db7ad89c
Support modules in conditionalPanel ( #1735 )
2017-06-23 10:12:15 -05:00
Joe Cheng
4ca4f442b9
Required R version is 3.0.2 due to sourcetools
2017-06-22 19:42:49 -05:00
Winston Chang
6d5ecbc9c4
Fix indentation
2017-06-22 13:18:05 -05:00
Winston Chang
ea685a5686
Don't send local package path to client when using htmlwidgets ( #1756 )
...
* Don't send local package path to client when using htmlwidgets. Fixes #1755
* Add scrubFile option
2017-06-22 13:16:19 -05:00
Winston Chang
376d3b6e91
Merge pull request #1760 from rstudio/wch-snapshot-preprocess
...
Add snapshotPreprocess function
2017-06-22 13:01:09 -05:00
Winston Chang
df7397af1f
Bump version
2017-06-21 14:27:03 -05:00
Winston Chang
9ba9345b04
Add snapshotPreprocess function
2017-06-21 14:27:03 -05:00
Barbara Borges Ribeiro
9fc5758ae0
Triggers a new shiny:outputinvalidated event ( #1758 )
...
* trigger a new `shiny:invalidated` event when an output gets invalidated, at the same time that the `recalculating` CSS class is added (fixes #1688 )
* add attribution to @andrewsali
* change event name from 'shiny:invalidated' to 'shiny:outputinvalidated'
* add binding and name to the new event 'shiny:outputinvalidated'
2017-06-21 12:28:51 -05:00
Winston Chang
25298a6182
In test mode, send message to client even when no outputs change ( #1747 )
...
* In test mode, send message to client even when no outputs change
* Update NEWS.md
2017-06-20 13:50:28 -05:00
Winston Chang
246da1bff6
Grunt
2017-06-16 13:48:38 -05:00
Carl Ganz
8b5d12b958
Add placeholder parameter to updateTextInput ( #1742 )
...
* add placeholder parameter
* add js placeholder code
* roxygenize
* grunt
* fix updateCheckBoxInput not to use placeholder
* simply roxygen
* add NEWS
* revert grunt
2017-06-15 22:00:39 -05:00
Alan Dipert
3817370d4e
fileInput JS: Allow uploading the same file. ( #1719 )
...
* tools README: notes about entr + grunt
* fileInput JS: Allow uploading the same file. Fixes #1508
* Grunt
* Added note to NEWS.
* tools README: add Linux section, fix formatting
2017-06-15 15:09:37 -05:00
Alan Dipert
c29846a9da
fileInput: Preserve extension of files uploaded from IE9 ( #1717 )
...
* fileInput: IE addendum to #1706
- Attempt to preserve the extension of files uploaded from IE9.
* maybeMoveIEUpload: Fix if spacing
2017-06-15 13:47:21 -05:00
Winston Chang
2158f906a7
Merge pull request #1736 from rstudio/wch-fix-unbind
...
Fix condition for calling exports.unbindAll()
2017-06-15 13:05:16 -05:00
Winston Chang
008dd280d6
Grunt
2017-06-08 17:03:21 -07:00
Winston Chang
fb99db011c
Fix condition for calling exports.unbindAll(). (Correction to #1449 )
2017-06-08 17:02:56 -07:00
Joe Cheng
c0fbd9cb3c
Merge pull request #1732 from rstudio/barbara/mods
...
Fixed #1546 : make it possible to write into a module's session$userData non-hackily
2017-06-07 22:45:47 -07:00
Barbara Borges Ribeiro
fb79b18002
More descriptive NEWS item and added an explanatory comment to the code
2017-06-07 13:28:51 -07:00
Barbara Borges Ribeiro
3841f22108
Fixed #1546 : make it possible (without any hacks) to write arbitrary data into a module's session$userData
2017-06-07 12:11:05 -07:00
Winston Chang
379d523ac5
Add better error messages for errors parsing and evaluating JS code ( #1727 )
...
* Add better error messages for errors parsing and evaluating JS code
* Grunt
2017-06-02 14:31:06 -05:00
Winston Chang
07ec7f8c13
Update Rproj for new version of RStudio IDE
2017-06-02 13:31:33 -05:00
Alan Dipert
d0f29cc7a2
fileInput: If possible, retain uploaded file extensions on the server. ( #1706 )
2017-05-26 11:16:02 -05:00
Joe Cheng
0e23a487f7
Merge pull request #1713 from rstudio/jjallaire-contributing-links
...
Update links in CONTRIBUTING.md
2017-05-23 14:05:43 -07:00
JJ Allaire
ac10f7c426
Update links in CONTRIBUTING.md
...
Update the links to contributor agreements to reflect new versions that use my current email rather than rstudio.org based one.
I've made the same change in the rstudio and rmarkdown repos, we should make it in other repos that have a contributor agreement as well.
2017-05-23 16:38:02 -04:00
Joe Cheng
852c00009e
Merge pull request #1712 from rstudio/wch-fix-reactiveval
...
Give each ReactiveVal separate dependents
2017-05-22 11:15:35 -07:00
Winston Chang
b365798e66
Add tests for ReactiveVal independence
2017-05-22 10:35:01 -05:00
Winston Chang
66a6097a49
Give each ReactiveVal separate dependents. Fixes #1710
2017-05-22 10:34:27 -05:00
Winston Chang
0e529d3d92
Fix partial arg match. Closes #1701
2017-05-10 10:08:05 -05:00
Winston Chang
06c75dd656
Bump version to 1.0.3.9000
2017-04-28 09:45:17 -05:00
Winston Chang
69c32d4d90
Bump version to 1.0.3
2017-04-25 15:33:10 -05:00
Winston Chang
36ffebd975
Workaround for NOTE about objects in yet-unreleased version of ggplot2
2017-04-25 15:33:10 -05:00
Winston Chang
deb56539fb
Better reactivePoll example. Closes #1678
2017-04-25 10:48:29 -05:00
Winston Chang
af8d099b9f
Don't call body(NULL). Fixes #1676
2017-04-24 13:42:22 -05:00
Winston Chang
eed869d321
Make fileInput progress bar change color on error ( #1673 )
...
* Make fileInput progress bar change color on error. Fixes #1672
* Grunt
* Update NEWS
2017-04-21 11:33:14 -05:00
Winston Chang
f8f2acf6c3
Bump version to 1.0.2.9000
2017-04-18 16:38:14 -05:00
Winston Chang
7be9f74827
Merge tag 'v1.0.2'
...
Shiny 1.0.2 on CRAN
2017-04-18 16:36:44 -05:00
Barbara Borges Ribeiro
ed77982330
Merge pull request #1670 from rstudio/joe/prebuilt
...
pre-built => prebuilt
2017-04-18 19:58:32 +01:00
Joe Cheng
e1b47eca90
pre-built => prebuilt
2017-04-18 11:09:45 -07:00
Winston Chang
bfa0b2d2bc
Bump version to 1.0.2 and update NEWS
2017-04-13 14:13:41 -05:00
Winston Chang
d67783edbd
Fix typo
2017-04-13 14:11:15 -05:00
Joe Cheng
77712b6664
Use RStudio replacement for deprecated MathJax CDN ( #1664 )
...
* Use RStudio replacement for deprecated MathJax CDN
* Add link to PR
2017-04-12 14:41:21 -05:00
Winston Chang
1633e7faa6
Fix Bootstrap URL. Closes #1662
2017-04-10 10:01:42 -05:00
Joe Cheng
2dc5ee5862
Merge pull request #1661 from rstudio/joe/bugfix/showcase-code-margin
...
Fix #1654 : Empty space below showcase code
2017-04-07 17:39:01 -07:00
Joe Cheng
bbaea23eea
Fix #1654 : Empty space below showcase code
2017-04-07 17:37:54 -07:00
Barbara Borges Ribeiro
d112ac7eef
fix documentation (worng/misleading code example)
2017-04-05 17:58:39 -05:00
Barbara Borges Ribeiro
cf21e987f2
Add shiny:sessionInit event ( #1568 )
...
* added a shiny:sessionInit JS event that is triggered at the end of the session's initialize method
* new entry
* update NEWS
* correct version number in NEWS.md
* fix typo
2017-04-05 10:50:42 -05:00
Barbara Borges Ribeiro
dae11765bc
allow the choices argument in checkboxGroupInput() to be NULL ( #1652 )
...
* allow the `choices` argument in `checkboxGroupInput()` to be `NULL` or `c()` to keep backward compatibility with Shiny < 1.0.1 (fixes #1649 )
* use vapply
* added one more test; reimplemented logic for checking if choice args are null
2017-04-05 10:12:44 -05:00
Barbara Borges Ribeiro
df30a3c7f4
PR: Add CC-BY-SA-4.0 license to showcase
2017-04-03 18:24:28 +01:00
Joe Cheng
aaa4600597
Bump version number to 1.0.1.9000
2017-04-03 10:22:08 -07:00
Joe Cheng
ba1730d26b
Add CC-BY-SA-4.0 license to showcase
2017-04-03 10:18:04 -07:00
Barbara Borges Ribeiro
d1b5c812f7
re-run grunt to update version number embedded in shiny.min.js
2017-03-31 16:49:11 +01:00
Barbara Borges Ribeiro
5bfe6d1c84
bump version numbers in DESCRIPTION and NEWS
2017-03-31 16:48:13 +01:00
Winston Chang
9804a794fd
Merge pull request #1641 from rstudio/fix-plot-rounding
...
Round brush coordinates
2017-03-31 10:46:44 -05:00
Winston Chang
0344645208
Grunt
2017-03-31 10:42:44 -05:00
Winston Chang
f56ad6e787
Update NEWS
2017-03-31 10:42:43 -05:00
Winston Chang
7492db592b
Round brush coordinates to 14 digits. Fixes #1634
2017-03-31 10:42:43 -05:00
Winston Chang
2e80ecf8a7
Rebuild ion.rangeSlider.min.js
2017-03-30 15:48:47 -05:00
Joe Cheng
6993551a44
Fix #1637 : Outputs stay faded on MS Edge ( #1640 )
2017-03-30 20:25:27 +01:00
Joe Cheng
9bff15adfe
Fix #1632 : Showcase mode comes up almost blank in IE9 & 11 ( #1633 )
...
If the width is made very wide in showcase mode with side-by-side
arrangement, the app shrinks to almost nothing. For some reason the
zoom CSS property (which we set using jQuery.animate) is set to
"1%" instead of "1".
Numbers and percentages are equally valid here, and the issue goes
away if we use percentage.
2017-03-29 10:16:17 -05:00
Winston Chang
0c24da2358
Stop propagation of mouse events on slider ( #1631 )
...
see (https://github.com/rstudio/shiny/issues/711 )
2017-03-28 20:38:46 +01:00
Barbara Borges Ribeiro
4ee4adb43d
doc changes
2017-03-27 21:12:46 +01:00
Joe Cheng
e33b028348
Merge pull request #1628 from rstudio/wch-rm-object-assign
...
Remove babel-polyfill
2017-03-27 13:07:47 -07:00
Winston Chang
384d9c1841
Grunt
2017-03-27 15:02:16 -05:00
Winston Chang
f78fcd6b5f
Remove need for babel-polyfill
2017-03-27 15:02:03 -05:00
Barbara Borges Ribeiro
711a72989b
Update NEWS.md
2017-03-27 17:53:59 +01:00
Barbara Borges Ribeiro
d62a2fc1d5
Allow arbitrary UI code in the choiceNames for radio buttons and checkbox group input ( #1521 )
2017-03-27 16:51:44 +01:00
Barbara Borges Ribeiro
f33f712a3a
fix typo
2017-03-27 10:00:47 +01:00
Joe Cheng
3315b3310b
Merge pull request #1614 from rstudio/joe/feature/reactiveVal
...
Add reactiveVal() for single reactive value
2017-03-24 13:08:47 -07:00
Joe Cheng
c7134b16ed
Add link to PR for reactiveVal feature
2017-03-24 13:08:09 -07:00
Winston Chang
f36f710661
Make sure reactiveTimer gets session at creation time. Fixes #1621
2017-03-24 13:47:25 -05:00
Joe Cheng
00ab8681c7
Merge pull request #1619 from rstudio/wch-fileinput
...
Make fileInput text customizable. Closes #1617
2017-03-23 17:16:32 -07:00
Winston Chang
4137bbac94
NEWS
2017-03-23 14:33:22 -05:00
Winston Chang
750b2ad599
Make fileInput text customizable. Closes #1617
2017-03-23 14:31:31 -05:00
Joe Cheng
511c833fbb
More code review feedback
2017-03-23 10:29:29 -07:00
Joe Cheng
29063a0c07
Code review feedback
2017-03-23 10:24:06 -07:00
Barbara Borges Ribeiro
67909b3557
updated tools/README.md ( #1616 )
2017-03-23 10:07:41 -05:00
Joe Cheng
102c12d36c
Add NEWS item
2017-03-22 16:12:07 -07:00
Joe Cheng
dc51651665
Add S3 generics for format/print; freezeReactiveVal
...
Also changed the classes of reactive expressions and reactiveVal
from "reactive" and "reactiveVal" to c("reactiveExpr", "reactive")
and c("reactiveVal", "reactive")
2017-03-22 11:29:22 -07:00
Joe Cheng
8b563d6d5f
Fix regex for old versions of R
2017-03-22 10:37:16 -07:00
Joe Cheng
eb8b88027e
Automatic labelling of reactiveVals
2017-03-22 09:47:08 -07:00
Joe Cheng
a5b7f307ed
Add reactiveVal() for single reactive value
2017-03-21 16:38:32 -07:00
Winston Chang
45fca425aa
Change NS() to return a vectorized function ( #1613 )
...
* Change NS() to return a vectorized function
* Update NEWS
* Use vectorized ns()
* Use correct separator
2017-03-21 15:57:38 -05:00
Winston Chang
a0bd9b5fd7
Redocument with Roxygen 6.0.1
2017-03-21 14:02:29 -05:00
Winston Chang
c12e24e3e3
Properly register bookmark excludes for modules. Fixes #1598 ( #1599 )
...
* Scopes: properly register bookmark excludes. Fixes #1598
* Update NEWS
2017-03-21 13:56:08 -05:00
Winston Chang
d147c5a153
Don't use data-drag-interval for non-range sliders. Fixes #1605 ( #1610 )
...
* Don't use data-drag-interval for non-range sliders. Fixes #1605
* Update NEWS
2017-03-16 15:49:46 -05:00
Winston Chang
7a833456d9
Use consistent value caching format
2017-03-10 12:03:24 -06:00
Winston Chang
306f33dfc4
Fix value access
2017-03-09 16:16:16 -06:00
Winston Chang
a2745a4060
Grunt
2017-03-03 15:28:47 -06:00
Winston Chang
46b68c7b2a
Bump version to 1.0.0.9001
2017-03-03 15:28:47 -06:00
Winston Chang
4264760113
Add binding and el fields to shiny:inputchanged event ( #1596 )
...
* Remove unused 'immediate' arguments
* Add opts argument to setInput methods
* Extract input values without opts
* Consistent interface for setting initial values
* Update NEWS
* Add binding and el when fileInputBinding triggers shiny:inputchanged
* Revert "Consistent interface for setting initial values"
This reverts commit 12c0b6e72a .
* Move InputDeferDecorater function
The new placement properly reflects the decorator stack
* Fix indentation
* bindInputs: make sure value is set immediately
* Only use opts where necessary in input decorators
* Properly send initial values
* Move initial value of .clientdata_allowDataUriScheme to better place
* Fix indentation
* Add InputValidateDecorator
* Better variable name
* Add function for default input options
* Simplify code
2017-03-03 15:27:32 -06:00
Winston Chang
42dedbbd9a
Simplify user value check
2017-03-02 13:30:47 -06:00
Winston Chang
ea99bfdb16
Update NEWS
2017-02-28 10:48:48 -06:00
Winston Chang
2ccb934338
Merge pull request #1592 from akersting/master
...
fix: dateRangeInput did not respect weekstart arg
2017-02-28 10:46:35 -06:00
Winston Chang
367027cfbc
Merge branch 'wch/redundant-setinput'
2017-02-28 09:23:17 -06:00
Winston Chang
c4ebd3b6d5
Merge pull request #1594 from rstudio/wch/fix-dynamic-input
...
Make sure input deduplication respects inputType. Closes #162
2017-02-28 09:19:41 -06:00
Winston Chang
5f8cd82a09
Update NEWS
2017-02-24 19:43:55 -06:00
Winston Chang
0ef15fa662
Remove redundant calls to setInput
2017-02-24 19:43:55 -06:00
Winston Chang
c05452af91
Update NEWS
2017-02-24 15:16:12 -06:00
Winston Chang
4c8bafcf9a
Make sure input deduplication respects inputType. Closes #162
2017-02-24 15:11:18 -06:00
Andreas Kersting
034f30a49a
fix: dateRangeInput did not respect weekstart arg
2017-02-23 07:38:10 +01:00
Winston Chang
0f13075e17
NEWS edits
2017-02-10 14:28:15 -06:00
Winston Chang
ad274a5981
Grunt
2017-02-10 14:26:48 -06:00
Winston Chang
fdbcbaec8a
Merge pull request #1579 from albertosantini/fix-1577
...
Improve escapeHTML
2017-02-10 14:26:22 -06:00
Alberto Santini
9c09072ee6
Update NEWS
2017-02-10 20:16:57 +01:00
Alberto Santini
0a4ca56da9
Improve escapeHTML
...
Replacing one char after another is not a best practice, due to the order dependency of replacing, xss risk and performance.
Fix #1577
2017-02-10 18:15:07 +01:00
Winston Chang
2b494398f2
Merge pull request #1578 from rstudio/wch/ggplot-api
...
Add plot interaction support for ggplot2 api
2017-02-10 10:56:59 -06:00
Winston Chang
95585c2264
Update NEWS
2017-02-10 10:42:27 -06:00
Winston Chang
92f9f0da9e
Restructure code for clarity
2017-02-09 11:23:13 -06:00
Winston Chang
fe943b5e95
Update plot interaction for ggplot2 > 2.2.1
2017-02-09 11:01:47 -06:00
Winston Chang
3479a4661a
Prepare code for ggplot2 api
2017-02-02 11:12:22 -06:00
Winston Chang
7ba438cf7c
Add entries to staticdocs index
2017-02-01 11:41:18 -06:00
Winston Chang
c761e9fba0
NEWS formatting fixes
2017-02-01 11:37:31 -06:00
Winston Chang
deae31ea4a
Merge pull request #1570 from rstudio/wch/simplify-fileupload
...
Remove shiny:fileuploaded JS event
2017-02-01 11:34:01 -06:00
Winston Chang
547355a163
Grunt
2017-02-01 11:29:21 -06:00
Winston Chang
9be4cb132c
NEWS
2017-02-01 11:29:21 -06:00
Winston Chang
3e25c9f3f4
Remove shiny:fileuploaded event
2017-02-01 11:17:08 -06:00
Barbara Borges Ribeiro
220c7e9139
decode URLs in staticHandler func - fixes #1565 (via #1566 )
2017-02-01 06:27:11 +00:00
Winston Chang
79a085a9be
Merge pull request #1547 from rstudio/wch/fix-progress
...
Fix progress bar
2017-01-31 20:38:38 -06:00
Winston Chang
b505c5a9d3
Grunt
2017-01-31 20:38:16 -06:00
Winston Chang
03ba660ea1
Update NEWS
2017-01-31 20:37:39 -06:00
Winston Chang
5aeb361f6d
Set starting value to NULL
2017-01-31 20:36:28 -06:00
Winston Chang
0e519a4e97
Progress: store value as raw value instead of normalized
2017-01-31 20:36:28 -06:00
Winston Chang
4feee00d34
NULL value no longer makes progress bar go to 100%. Closes #1472
...
This also removes the documentation which said that using NULL would cause the
progress bar to be hidden.
2017-01-31 20:36:28 -06:00
Winston Chang
ef5e4cdc0a
Merge pull request #1559 from rstudio/wch/download-event
...
Add shiny:filedownload Javascript event
2017-01-31 20:29:25 -06:00
Winston Chang
67c599f50b
Update NEWS
2017-01-31 20:27:20 -06:00
Winston Chang
5af9b61357
Grunt
2017-01-31 20:25:00 -06:00
Winston Chang
1d6771b4ed
Unexport markOutputAttrs and add snapshotExclude function
2017-01-31 20:24:52 -06:00
Winston Chang
c55dc0a58e
Add ability to exclude outputs from snapshots
2017-01-31 20:23:34 -06:00
Winston Chang
c525d55db8
Add shiny:filedownload JS event
2017-01-31 20:23:34 -06:00
Winston Chang
408f66ef80
Merge pull request #1541 from rstudio/wch/file-input-event
...
Make fileInput trigger shiny:inputchanged.
2017-01-31 16:29:44 -06:00
Winston Chang
7f73a047a4
Grunt
2017-01-31 16:27:50 -06:00
Winston Chang
015bc98d60
Trigger inputchanged event when fileupload is completed
2017-01-31 16:27:16 -06:00
Winston Chang
5cd9ba609a
Make fileInput trigger shiny:inputchanged. Closes #1511
2017-01-31 16:27:16 -06:00
Winston Chang
c8ed6544db
Fix documentation link. Closes #1567
2017-01-31 11:40:24 -06:00
Winston Chang
1162113d3b
Re-document
2017-01-30 13:47:20 -06:00
Winston Chang
1612503e7b
Update selectize URLs. Closes #1564
2017-01-30 13:46:12 -06:00
Joe Cheng
34ba85df3b
Merge pull request #1563 from rstudio/barbara/userInfo
...
Barbara/user info
2017-01-30 09:55:56 -08:00
Barbara Borges Ribeiro
8206e7d2a2
delete old message handler
2017-01-27 20:42:04 +00:00
Barbara Borges Ribeiro
3e29672c70
news item
2017-01-27 20:40:07 +00:00
Barbara Borges Ribeiro
f67aaafe4f
some adjustments after feedback
2017-01-27 20:39:18 +00:00
Barbara Borges Ribeiro
ed704afc07
remove console.log and re-grunt
2017-01-27 20:38:17 +00:00
Barbara Borges Ribeiro
bbbfacb4b2
grunt
2017-01-27 20:37:58 +00:00
Barbara Borges Ribeiro
cf16d2e52d
listify
2017-01-27 20:37:32 +00:00
Barbara Borges Ribeiro
6268e6e1c9
will be removed!! only for testing purposes
2017-01-27 20:36:37 +00:00
Barbara Borges Ribeiro
99b8e5b303
stuff
2017-01-27 20:36:37 +00:00
Winston Chang
73446af330
Convert tabs to spaces in examples
2017-01-26 15:06:15 -06:00
Barbara Borges Ribeiro
a0b917a207
support pushState for pseudo-nav
...
see the documentation for details (`?updateQueryString` and `?getQueryString`)
2017-01-25 23:45:26 +00:00
Winston Chang
53ec7edd06
Another typo
2017-01-17 12:02:39 -05:00
Winston Chang
ff804c0ff8
Typo
2017-01-17 12:01:51 -05:00
Winston Chang
9d69ff01b3
Update ion.rangeSlider to 2.1.6 ( #1540 )
...
* Update ion.rangeSlider to 2.1.6
* Simplify code when slider separator is ""
* Add links to NEWS
2017-01-17 12:00:47 -05:00
Winston Chang
61831f530f
Merge pull request #1525 from rstudio/wch/ggplot-coord-fixed
...
Add plot interaction support for coord_fixed
2017-01-16 13:01:01 -05:00
Winston Chang
6065db1d24
Update NEWS
2017-01-16 13:00:41 -05:00
Winston Chang
270b8415e8
Add plot interaction support for coord_fixed. Closes #1121
2017-01-16 12:58:58 -05:00
Winston Chang
1987331a70
Bump version to 1.0.0.9000
2017-01-16 12:55:36 -05:00
Winston Chang
ab85216b96
Merge tag 'v1.0.0'
2017-01-13 13:36:23 -05:00
Winston Chang
b5cb78c77e
Update URL
2017-01-10 10:13:06 -06:00
Winston Chang
e75c99672d
Update NEWS
2017-01-09 12:38:48 -06:00
Winston Chang
7faba72ebe
Fix URL
2017-01-09 12:38:48 -06:00
Winston Chang
cbe8fc1bdf
Bump version to 1.0.0
2017-01-09 12:38:48 -06:00
Winston Chang
f66a7660e2
Merge pull request #1529 from rstudio/feature/res-path-numeric-prefix
...
Relax naming requirements for addResourcePath
2017-01-09 12:28:07 -06:00
Winston Chang
5f3159a203
Add link to PR in NEWS
2017-01-09 12:25:32 -06:00
JJ Allaire
76aeda4436
refine regex
2017-01-09 12:32:12 -05:00
JJ Allaire
fa791cd28c
Relax naming requirements for addResourcePath()
...
First character no longer needs to be a letter. See https://github.com/rstudio/tutor/issues/4 for discussion.
2017-01-09 11:04:51 -05:00
Winston Chang
d836c68ee5
Grunt
2017-01-03 16:17:48 -06:00
Winston Chang
519d90f0a7
Update NEWS
2017-01-03 16:17:28 -06:00
Winston Chang
26400be6f7
Pressing Esc in a modal in a gadget only closes the modal. Closes #1453 ( #1523 )
2017-01-03 17:14:31 -05:00
Winston Chang
92ba7e9d54
Update yarn install instructions
2017-01-03 14:29:43 -06:00
Winston Chang
25eafe1e69
NEWS: more info on testing
2017-01-03 14:16:55 -06:00
Winston Chang
118a9ca861
Update NEWS
2017-01-03 12:54:06 -06:00
Winston Chang
174a1fe834
Update to font-awesome 4.7.0
2017-01-03 12:47:23 -06:00
Winston Chang
1e0f3f40a9
Replace structure(NULL) with structure(list())
...
In R-devel 71841, structure(NULL) was deprecated.
2016-12-28 16:43:29 -06:00
Barbara Borges Ribeiro
19623694f5
Added skipFirst arg to observeEvent ( #1494 )
...
* added skipFirs arg to observeEvent
* create getCurrentObserver() function
* better NEWS entry
* made code more consistent
* implemented `once` param to `observeEvent`; extensive documentation for `getCurrentObserver`
* implement dig param to `getCurrentObserver`
* fix bug that was causing unit tests to fail
* take two
* git commit
* removed function getCurrentObserver
* delete .globals$currentObserver variable
* update docs
* typo
* remove dupes in index.r (bah humbug)
* rerun devtools::document
2016-12-19 15:51:19 -08:00
Winston Chang
55a16043e1
Merge pull request #1510 from rstudio/joe/feature/debounce
...
Add reactive debounce and throttle functions
2016-12-16 11:10:02 -06:00
Winston Chang
29943b7edd
Merge pull request #1482 from rstudio/barbara/runapp
...
Fixes #1358 : more informative error message when calling runApp inside of an app's app.R
2016-12-16 10:15:35 -06:00
Joe Cheng
a1e2af9533
Add debounce/throttle tests, priority arg
2016-12-15 14:52:07 -08:00
Barbara Borges Ribeiro
c350e2a668
Fixes #1358 : more informative error message when calling runApp inside of an app's app.R (or inside ui.R or server.R).
2016-12-15 21:50:39 +00:00
Joe Cheng
e0868ba2ab
Fix #1013 : flushReact should be called after app loads ( #1503 )
...
* Fix #1013 : flushReact should be called after app loads
* Add link to pull request
2016-12-15 13:16:18 -06:00
Joe Cheng
bcefd1fbd8
Fix #117 : Reactive expressions hold on to memory for longer than necessary ( #1504 )
...
* Fix #117 : Reactive expressions hold on to memory for longer than necessary
* Fix broken link
* Add link to pull request
2016-12-15 13:15:00 -06:00
Joe Cheng
f5fbad0abf
Add link to pull request
2016-12-15 11:14:48 -08:00
Joe Cheng
95b1a197be
Remove unnecessary namespace
2016-12-15 11:11:29 -08:00
Joe Cheng
39169a36f5
Wording tweaks
2016-12-15 11:10:28 -08:00
Joe Cheng
3b1a409f07
Remove unnecessary link qualifier
2016-12-15 11:01:35 -08:00
Joe Cheng
accd70d4b4
Add session$userData feature ( #1513 )
...
* Add session$userData
* Tweak wording of NEWS
* Fix broken links
2016-12-15 12:50:20 -06:00
Winston Chang
3c7f4b760f
Merge pull request #1514 from rstudio/joe/bugfix/fix-broken-links
...
Fix unqualified links to other packages
2016-12-15 12:42:19 -06:00
Joe Cheng
f7d7ccfd2c
Fix unqualified links to other packages
...
R-devel warns on this now, causes Travis to fail
2016-12-15 10:35:46 -08:00
Joe Cheng
de98a03887
Add limitations section to debounce/throttle docs
2016-12-13 17:48:36 -08:00
Joe Cheng
0e11c240cb
Add magrittr as Suggests because of ?debounce example
2016-12-13 17:29:29 -08:00
Joe Cheng
c0a298e484
Add reactive debounce and throttle functions
2016-12-13 17:22:12 -08:00
Winston Chang
907b9a9862
Merge pull request #1480 from rstudio/barbara/verbatim
...
Closes #1357 : verbatimTextOutput should optionally be hidden if no content
2016-12-07 10:13:04 -06:00
Barbara Borges Ribeiro
8d70d91cf4
fix #1487 : better error handling for insertUI when selector does not match anything in DOM (do console log)
2016-12-07 05:10:43 +00:00
Barbara Borges Ribeiro
6fb86859ce
use past tense in all NEWS.md entries
2016-12-07 04:55:08 +00:00
Barbara Borges Ribeiro
fe733b319f
Fixes #969 : allow navbarPage's fluid param to control both containers
2016-12-07 00:22:33 +00:00
Barbara Borges Ribeiro
08b58f3055
allow navbarPage's fluid param to control both the content *and* the header containers
2016-12-07 00:21:49 +00:00
Barbara Borges Ribeiro
9f6659f526
added a new arg (placeholder = FALSE) to verbatimTextOutput() so that by default it doesn't show up when it is empty; improved the documentation example
2016-12-07 00:02:40 +00:00
Barbara Borges Ribeiro
d28397df93
Fix #1359 : shinyApp options argument ignored when passed to runApp ( #1483 )
2016-12-06 20:52:19 +00:00
Barbara Borges Ribeiro
2e1c37146b
Add ... arg to downloadButton (merge #1492 )
...
Add ... arg to downloadButton
2016-12-05 15:37:02 +00:00
Barbara Borges Ribeiro
903adc8f97
Added ability to pass arguments to the a tag function called inside downloadButton() and downloadLink(). Closes #986 .
2016-12-05 15:35:31 +00:00
Winston Chang
fc7f454382
Merge pull request #1449 from rstudio/barbara/bugfix/insert-ui
...
Fix #1438 : `unbindAll()` should not be called when inserting content with `insertUI()`
2016-12-01 15:45:23 -06:00
Winston Chang
ef35fc63a1
Grunt
2016-12-01 15:41:51 -06:00
Barbara Borges Ribeiro
52a193b183
unbindAll() should not be called when inserting content with insertUI()
2016-12-01 15:40:17 -06:00
Winston Chang
dad401a6ec
Merge pull request #1464 from rstudio/testmode-inject-js
...
Add support for injecting JS code when in test mode
2016-12-01 14:52:12 -06:00
Winston Chang
ec3f8118db
Grunt
2016-12-01 10:47:02 -06:00
Winston Chang
cfc0194c00
Sort input, output, export by name
2016-12-01 10:46:46 -06:00
Winston Chang
dd28f52301
Add sortByName function
2016-12-01 10:46:46 -06:00
Winston Chang
9dcbd532e6
Add getTestSnapshotBaseUrl function
2016-12-01 10:46:46 -06:00
Winston Chang
16b4a2cad2
Rename testEndpointUrl to testSnapshotUrl
2016-12-01 10:46:46 -06:00
Winston Chang
bd9d8a035a
Change arguments from plural to singular
2016-12-01 10:46:46 -06:00
Winston Chang
d55ffb0212
Change default snapshot format to JSON
2016-12-01 10:46:46 -06:00
Winston Chang
e76ddfd005
Emit message when running in test mode
2016-12-01 10:46:46 -06:00
Winston Chang
59145a3b40
Add testmode as an option to runApp
2016-12-01 10:46:46 -06:00
Winston Chang
c993f5343b
Bump version to 0.14.2.9001
2016-12-01 10:46:46 -06:00
Winston Chang
b62acec5ee
Use singular form of input, export, and output
2016-12-01 10:46:46 -06:00
Winston Chang
b34ab9cdd5
Add shiny:fileuploaded JS event
2016-12-01 10:46:46 -06:00
Winston Chang
e0a8ab852e
Update NEWS
2016-12-01 10:46:46 -06:00
Winston Chang
bd5ebd0e41
Remove token check
2016-12-01 10:46:46 -06:00
Winston Chang
661e21d25b
Safer method for injecting code in test mode
2016-12-01 10:46:46 -06:00
Winston Chang
dc69a2bc94
Make sure test values are named vectors
2016-12-01 10:46:46 -06:00
Winston Chang
e6fec6b27d
Rename variable
2016-12-01 10:46:46 -06:00
Winston Chang
27b92f9838
Add args to getTestEndpointUrl
2016-12-01 10:46:46 -06:00
Winston Chang
3446def4dd
Basic code injection support
2016-12-01 10:46:46 -06:00
Barbara Borges Ribeiro
2700206715
Improve documentation for submitButton and change 07_widgets example to use an action button ( #1475 )
...
* update 07_widgets example
* improved documentation for submitButton (including a warnign section and an full-app example)
* typo
* update documentation based on Winton's feedback
2016-11-28 13:19:40 -06:00
Winston Chang
fdfc6f70f3
Merge branch 'barbara/contributing'
2016-11-22 14:56:25 -06:00
Winston Chang
065c288edb
Edits to contribution guidelines
2016-11-22 14:56:12 -06:00
Barbara Borges Ribeiro
3121d2c23e
mention support for the optgroup tag in the documention for selectInput (specifically in the choices arg). Added example app too.
2016-11-22 11:28:35 -06:00
Barbara Borges Ribeiro
7cd3bb524c
add download attribute to the a tag that generates downloadButoon and downloadLink
2016-11-18 21:00:28 -08:00
Barbara Borges Ribeiro
6b8cc97779
drafted new contribution guidelines
2016-11-19 02:22:16 +00:00
Winston Chang
b7112a1edd
Add link to NEWS
2016-11-10 15:26:46 -06:00
Jonathan
28965b7356
Render HTML dependency <meta> tag contents correctly ( #1463 )
...
* render HTML dependency <meta> tag contents correctly
* use direct address rather than loop; update NEWS
2016-11-10 15:10:18 -06:00
Dean Attali
bd3aa28416
fix typo in dateInput documentation ( #1454 )
2016-11-02 09:53:40 -05:00
Winston Chang
9fed4ce24c
Bump version to 0.14.2.9000
2016-11-01 15:40:04 -05:00
Winston Chang
90383e30dd
Bump version to 0.14.2
2016-10-31 10:19:40 -05:00
Winston Chang
13f184e957
Remove NEWS entry for change that was reverted
2016-10-31 10:17:51 -05:00
Winston Chang
a7a2c6d7ff
Add list2env wrapper, for R <3.2.0 ( #1446 )
...
* Add list2env wrapper, for R <3.2.0
* Update NEWS
2016-10-28 13:56:52 -05:00
Winston Chang
d1bf39d0ac
Add exportTestValues function ( #1436 )
...
* Add onTestSnapshot function
* Add shiny.testing option
* Add entry to staticdocs index
* Bump version to 0.14.1.9002 and update NEWS
* Document params for onTestSnapshot
* Add session$enableTestEndpoint() method
* Un-export applyInputHandlers
* Grunt
* Provide inputs, outputs, and snapshot at test endpoint
* Remove non-working example
* Fix var name in documentation
* Rename shiny.testing to shiny.testmode
* Rename onTestSnapshot to exportTestValues and add example
* Add session$getTestEndpointUrl
* Grunt
* Add module support to exportTestValues
* Test endpoint allows specifying specific values
* session$getTestEndpointUrl: add arguments for choosing which values to return
2016-10-27 21:08:34 -05:00
Joe Cheng
7dff6b8415
Merge pull request #1387 from sipemu/master
...
options render for updateSelectizeInput did not worked in modules
2016-10-27 11:11:16 -07:00
Dean Attali
656e019829
allow overriding a JS custom message handler; fixes #1419 ( #1445 )
...
* allow overriding existing custom JS message handlers
* when a JS handler gets re-defined, only use the most recent one
* JS handler overwrite: changes re winston's comments
* overwrite JS handler: add NEWS item
* fix wrong URL in NEWS
2016-10-27 13:07:34 -05:00
Winston Chang
2133b0f498
Use === in Javascript
2016-10-26 21:01:36 -05:00
Winston Chang
bc4dcee2b1
allow shiny.trace option to specify which type of messages to relay; fixes #1422 ( #1428 )
...
Squashed commit of the following:
commit bdc4080032ff6b5b2de0f799aa307272f3905003
Author: Dean Attali <daattali@gmail.com >
Date: Mon Oct 17 18:18:03 2016 -0700
add PR link to news item
commit 22c695cde2b270ba8ec37d4862ad1f30de76ce68
Author: Dean Attali <daattali@gmail.com >
Date: Mon Oct 17 15:01:24 2016 -0700
update NEWS for #1422 fix
commit e669548c13f84f0929e4131c641a8333e08baa26
Author: Dean Attali <daattali@gmail.com >
Date: Sat Oct 15 12:45:49 2016 -0700
allow shiny.trace option to specify which type of messages to relay; fixes #1422
2016-10-26 12:24:00 -05:00
Winston Chang
0e8cf95739
Pass shinysession to applyInputHandlers
...
This fixes a problem where input handlers that require a session object
would throw errors.
2016-10-25 10:27:03 -05:00
Joe Cheng
e133290c57
Fix #1399 : Duplicate binding error with insertUI and nested uiOutput ( #1402 )
...
* Fix #1399 : Duplicate binding error with insertUI and nested uiOutput
* Update NEWS.md
2016-10-18 20:22:02 -05:00
shrektan
1429b0677e
fix a typo: option() -> options()
2016-10-18 14:56:38 -05:00
Barbara Borges Ribeiro
d03ee36647
Fixes #1427 : add event delegation so that modals do not close by mistake ( #1430 )
...
* Fixes #1427 : add event delegation so that modal does not close when an element inside it is triggered as hidden
* use `this === e.target` instead
* added NEWS item
* `e.target` must be equal to `$(#shiny-modal)`, not `this`
2016-10-18 14:54:27 -05:00
Winston Chang
6e5880c642
Bump version and update NEWS
2016-10-18 13:51:43 -05:00
Winston Chang
fa93cffafb
Add entry to staticdocs
2016-10-18 13:51:43 -05:00
Winston Chang
ce9af0fb57
Export function that applies input handlers
2016-10-18 13:51:43 -05:00
Winston Chang
95700d8d51
Fix dategrange comment
2016-10-17 13:37:25 -05:00
Winston Chang
fb15e98519
Merge pull request #1429 from rstudio/slider-setvalue
...
Make sliderInputBinding.setValue update value immediately
2016-10-17 12:29:14 -05:00
Winston Chang
3054cb7971
Update NEWS
2016-10-17 12:28:36 -05:00
Winston Chang
f84587cf5a
Grunt
2016-10-17 12:22:21 -05:00
Winston Chang
538f38f314
sliderInputBinding: setValue changes value immediately
2016-10-17 12:22:21 -05:00
Winston Chang
06578349c7
Document InputBinding.subscribe's callback argument
2016-10-17 12:18:12 -05:00
Winston Chang
a807476171
sliderInputBinding: rename 'updating' to 'immediate'
2016-10-17 12:13:15 -05:00
Winston Chang
7aacf9ca89
Use Yarn instead of npm ( #1416 )
2016-10-12 12:51:05 -05:00
Winston Chang
50dae5fb83
Remove unneeded npm package
2016-10-11 13:04:38 -05:00
Winston Chang
0853c425fe
Bump version to 0.14.1.9000 in DESCRIPTION
2016-10-11 12:59:06 -05:00
Barbara Borges Ribeiro
edcc676693
add "fade" arg to modalDialog() ( #1414 )
...
* add "fade" arg to modalDialog() that can be set to FALSE to remove default modal animation
* added documentation
* reflow comments
* news item
2016-10-10 15:03:25 -05:00
Winston Chang
c8a742a121
Bump version and update NEWS
2016-10-05 09:32:36 -05:00
Winston Chang
ee14a7e15f
Merge tag 'v0.14.1'
...
Shiny 0.14.1 on CRAN
2016-10-05 09:29:07 -05:00
Winston Chang
e1eaccf409
Fix tests for compiled code on R-devel. Closes #1404
2016-10-03 16:23:11 -05:00
Winston Chang
d2aae52868
Update NEWS
2016-09-30 15:39:31 -05:00
Winston Chang
9158fb4745
Bump version to 0.14.1
2016-09-30 15:39:31 -05:00
Winston Chang
0ff5ef5337
Remove file
2016-09-30 15:39:13 -05:00
Joe Cheng
1ace145f85
Merge pull request #1392 from rstudio/ggplot-fix
...
Add plot interaction support for ggplot>2.1.0
2016-09-30 12:40:30 -07:00
Winston Chang
565eb4b450
Merge pull request #1397 from rstudio/barbara/bugfix/radio
...
Maintain names of factors when updating radio buttons' choices
2016-09-29 14:18:24 -05:00
Barbara Borges Ribeiro
f39861c43f
more comments and NEWS
2016-09-29 19:48:56 +01:00
Barbara Borges Ribeiro
72838c248f
news entry
2016-09-29 19:16:46 +01:00
Barbara Borges Ribeiro
9be8765ccf
more tests
2016-09-29 19:14:18 +01:00
Barbara Borges Ribeiro
48732c4393
deleted commented out lines
2016-09-29 19:14:18 +01:00
Barbara Borges Ribeiro
5bf0b7c920
a better fix
2016-09-29 19:14:18 +01:00
Barbara Borges Ribeiro
51a4580d0f
maintain names of factors when updating radio buttons' choices
2016-09-29 19:14:18 +01:00
Winston Chang
266e611afa
Update NEWS
2016-09-27 23:07:23 -05:00
Winston Chang
22598b693c
Add more plot interaction tests
2016-09-27 23:07:23 -05:00
Winston Chang
008fe38f10
Add support for coord_flip
2016-09-27 23:07:17 -05:00
Winston Chang
24e8123240
Add plot interaction support for ggplot>2.1.0
2016-09-27 16:02:28 -05:00
Simon Müller
6054f03c0d
Update update-input.R
2016-09-21 22:53:41 +02:00
Winston Chang
476f6d83e2
Remove no-longer-necessary CSS class
2016-09-19 10:22:40 -05:00
Winston Chang
ec57109f39
Merge pull request #1374 from rstudio/datepicker-noconflict
...
Fix datepicker conflicts
2016-09-19 09:30:22 -05:00
Winston Chang
d73488f887
Grunt
2016-09-19 09:27:28 -05:00
Winston Chang
3201380c29
Set value after min in max when updating dates
2016-09-19 09:27:28 -05:00
Winston Chang
1f04b39ae3
Rename bootstrapDP to bsDatepicker
2016-09-16 23:39:26 -05:00
Winston Chang
9e2b47027c
Update NEWS
2016-09-16 23:39:26 -05:00
Winston Chang
662149a98a
Update to jQuery UI 1.12.1
2016-09-16 23:39:26 -05:00
Winston Chang
fafa31589d
Update NEWS
2016-09-16 23:39:26 -05:00
Winston Chang
43a5940b9e
Updates to dateRangeInputBinding for new datepicker API
2016-09-16 23:39:26 -05:00
Winston Chang
33908624fd
Fix off-by-one error for datepicker's setStartDate and setEndDate
2016-09-16 23:39:26 -05:00
Winston Chang
ffef8a341f
Add workaround for bootstrap datepicker bug with setStartDate and setEndDate
2016-09-16 23:39:26 -05:00
Winston Chang
a48c5df844
Don't try to set min/max date when undefined
2016-09-16 23:39:26 -05:00
Winston Chang
37b6a668ab
Fix off-by-one dates
2016-09-16 23:39:26 -05:00
Winston Chang
2a9a7cc897
Enable noconflict for Bootstrap Datepicker. Closes #1346
2016-09-16 23:39:26 -05:00
Winston Chang
c62e6b5734
Update to Bootstrap Datepicker 1.6.4. Closes #1218
2016-09-16 23:39:26 -05:00
Winston Chang
6ec1d0b935
grunt clean && grunt
2016-09-16 23:37:31 -05:00
Winston Chang
6c5769fdd8
Add missing files to Grunt clean
2016-09-16 23:36:57 -05:00
Winston Chang
09acc5920c
Allow using no separator for sliderInput numbers. Fixes #1369
2016-09-15 12:03:25 -05:00
Winston Chang
9613c58bf8
Merge pull request #1370 from rstudio/fix-bookmark-fileinput
...
Fix bookmark fileinput
2016-09-13 15:38:52 -05:00
Winston Chang
147f9ac64b
Remove sourcetools workaround for Travis
...
This is no longer necessary because the new version of sourcetools on CRAN
does not need C++11
2016-09-13 12:52:15 -05:00
Winston Chang
cc1e8961a1
Update NEWS
2016-09-13 11:24:42 -05:00
Winston Chang
3b1b2f401d
Use createUniqueId for consistency
2016-09-13 11:14:29 -05:00
Winston Chang
58a87b9b61
Copy restored file to temp directory
2016-09-13 11:13:21 -05:00
Winston Chang
f09475a6b5
Better check for unsafe paths in restored file inputs
2016-09-13 11:12:16 -05:00
Winston Chang
750422d858
Mark restored file inputs with correct serializer. Closes #1368
2016-09-13 10:49:08 -05:00
Winston Chang
03d911d335
Use cache for AppVeyor
2016-09-13 10:47:00 -05:00
Winston Chang
2747c11a46
Bump version to 0.14.0.9000
2016-09-13 10:46:15 -05:00
Winston Chang
5a9fe2637f
Update shiny.rstudio.com URLs in NEWS
2016-09-12 09:36:32 -05:00
Winston Chang
a5787f9988
Bump version to 0.14
2016-09-08 15:03:19 -05:00
Winston Chang
85e22bb515
Ignore revdep
2016-09-08 15:03:19 -05:00
Barbara Borges Ribeiro
5e1e90ad80
fix validation bug
2016-09-07 19:22:02 +01:00
Winston Chang
fe85421c7e
Fixes for R CMD check
2016-09-06 14:43:57 -05:00
Winston Chang
38af6ce279
Merge pull request #1362 from rstudio/barbara/update-old-release-news
...
Barbara/update old release news
2016-09-06 11:05:24 -05:00
Barbara Borges Ribeiro
fe92f16da4
updated 0.12 section
2016-09-05 20:55:38 +01:00
Barbara Borges Ribeiro
edc4b562f2
removed unnecessary line breaks now that we switched to .md
2016-09-05 20:42:20 +01:00
Barbara Borges Ribeiro
7b6a91064c
updated 0.11 section
2016-09-05 19:52:28 +01:00
Winston Chang
a32414c6fc
NEWS edits
2016-09-02 21:09:39 -05:00
Winston Chang
259b4e29de
NEWS improvements ( #1354 )
2016-09-02 16:28:08 -05:00
Winston Chang
e56f80b546
Check whether hosting environment supports bookmarking ( #1360 )
...
* Check whether hosting environment supports bookmarking
* Show notification on startup if hosting environment doesn't support saved-to-server bookmarking
2016-09-02 14:19:41 -07:00
Barbara Borges Ribeiro
1ff52c5290
Merge branch 'master' of https://github.com/rstudio/shiny
2016-09-02 00:42:26 +01:00
Barbara Borges Ribeiro
70bd249f43
make explicit link to external package
2016-09-02 00:42:14 +01:00
Winston Chang
f2f7e43579
Convert validate example to single-file app. Closes #1345 ( #1347 )
2016-09-01 13:08:03 -07:00
Winston Chang
c36d60fcd4
Fix reactive highlighting in showcase mode. Closes #1350 ( #1351 )
2016-09-01 13:07:39 -07:00
Barbara Borges Ribeiro
0950f307d1
Merge pull request #1344 from rstudio/joe/feature/root-scope
...
Let modules get at the root scope (undocumented for now)
2016-09-01 04:58:17 +01:00
Joe Cheng
a9b7e4a85e
Let modules get at the root scope (undocumented for now)
2016-08-31 14:44:45 -07:00
Winston Chang
912a886539
updateQueryString: add note about not working in IE9. Closes #1336 ( #1339 )
2016-08-31 12:17:49 -07:00
Winston Chang
f7484f49e5
Fix file uploads in IE9. Closes #1332 ( #1342 )
...
* Fix file uploads in IE9. Closes #1332
* Grunt
2016-08-31 12:17:24 -07:00
Joe Cheng
9f68be1925
Merge pull request #1341 from rstudio/ie9-fix-remove-modal
...
Fix modal removal for IE 9
2016-08-31 12:02:43 -07:00
Joe Cheng
ef298f8d7a
Merge pull request #1337 from rstudio/fix-replay-plot
...
Make sure displaylist is on for recording/replaying plots
2016-08-31 12:01:32 -07:00
Winston Chang
c038f0e6ee
Grunt
2016-08-31 11:36:16 -05:00
Winston Chang
3c53a93447
Wrap DOM object in jQuery. Fixes #1335
2016-08-31 11:35:48 -05:00
Winston Chang
7e86e65cce
Make sure displaylist is on for recording/replaying plots
2016-08-30 20:09:45 -05:00
Winston Chang
ad171d6cbb
Better checks in modal example
2016-08-30 17:02:07 -05:00
Joe Cheng
76ffc20836
Merge pull request #1329 from rstudio/progress-compatibility
...
Add old-style rendering option to progress bars
2016-08-30 14:50:32 -07:00
Winston Chang
c4cc5b6dfc
Fix renderPlot's execOnResize logic
...
This was found in #1331 , but the real problem with that issue is that
the mclust::mclust2Dplot function has changed since we wrote the example
app.
2016-08-30 16:37:50 -05:00
Winston Chang
878c9210d3
Add shinyOption for progress.style
2016-08-30 16:15:55 -05:00
Winston Chang
35c982b367
Grunt
2016-08-29 19:48:56 -05:00
Winston Chang
9c4ff080af
Update NEWS
2016-08-29 19:47:12 -05:00
Winston Chang
d32ca64a03
Add old-style rendering as an option for progress
2016-08-29 16:05:43 -05:00
Winston Chang
53b89390be
Rename shiny-progress CSS class to shiny-progress-notification
2016-08-29 15:19:45 -05:00
Winston Chang
a8e09d7fe6
Add sections to NEWS and add some new items
2016-08-26 12:26:30 -05:00
Winston Chang
0c7cf20e7e
Switch NEWS to Markdown
2016-08-26 11:43:38 -05:00
Winston Chang
6ebcee33c5
Add some issue numbers to NEWS
2016-08-26 11:39:20 -05:00
Winston Chang
c73544fb59
Fix misplaced NEWS items
2016-08-26 11:29:10 -05:00
Winston Chang
37c1f93bcb
Merge pull request #1320 from rstudio/joe/docs/sendBinaryMessage
...
NEWS, doc update for sendBinaryMessage
2016-08-25 20:25:51 -05:00
Joe Cheng
95aa2e10fc
NEWS, doc update for sendBinaryMessage
2016-08-25 15:48:53 -07:00
Joe Cheng
279e6e3925
Merge remote-tracking branch 'origin/daef/feature/binary-messages'
2016-08-25 13:08:29 -07:00
Joe Cheng
8a661d5ee4
Code review feedback
2016-08-25 13:04:58 -07:00
Joe Cheng
67fcb40455
Merge pull request #1313 from rstudio/bookmarking-arg
...
Add enableBookmarking argument to shinyApp()
2016-08-25 13:00:04 -07:00
Winston Chang
641524c80e
More docs for enableBookmarking
2016-08-24 17:00:59 -05:00
Winston Chang
55802354d4
Add enableBookmarking arg to shinyApp()
2016-08-24 14:47:56 -05:00
Winston Chang
75f4f5c0bd
Merge pull request #1317 from MangoTheCat/fix/updatedaterangeinteraction
...
Fix updateDateRangeInput interaction from #1299 & #1315
2016-08-24 13:43:55 -05:00
Gábor Csárdi
382e9dee55
Grunt
2016-08-23 22:52:41 +01:00
Gábor Csárdi
6861d4029e
Fix updateDateRangeInput interaction from #1299 & #1315
2016-08-23 22:51:18 +01:00
Joe Cheng
370ef16854
Slight tweaks
...
- Rename arguments to type/message
- Check tag length after converting to bytes
2016-08-23 14:08:04 -07:00
Gábor Csárdi
9dbe434792
Fix updateDateRangeInput when only one of start/end updated ( #1315 )
2016-08-23 16:07:53 -05:00
Joe Cheng
21a0e95623
Merge commit 'd1353e8eaebc3f878fe9074919948d662caf8a89'
2016-08-23 13:58:40 -07:00
Winston Chang
57c6307479
Merge pull request #1314 from rstudio/joe/bugfix/downloadhandler-no-data
...
Fix #1122 : Do something sensible when downloadHandler doesn't create a file
2016-08-23 15:50:39 -05:00
Winston Chang
01d8b1f468
Merge pull request #1299 from MangoTheCat/fix/resetdateinput
...
Allow updateDateInput to set input fields to empty
2016-08-23 15:48:25 -05:00
Joe Cheng
ef6b82a0a3
Fix #1122 : Do something sensible when downloadHandler doesn't create a
...
file
2016-08-23 13:48:24 -07:00
Gábor Csárdi
19b7d1a7c5
Rebuild minified files
2016-08-23 21:21:35 +01:00
Gábor Csárdi
097d901191
Updates can clear date and date range inputs
2016-08-23 21:21:10 +01:00
Winston Chang
a1b5846b29
Remove extra comma
2016-08-23 10:54:37 -05:00
Winston Chang
dbdb353e69
Add updateQueryString example
2016-08-23 10:30:12 -05:00
Winston Chang
4456eac1fd
Make staticdocs tests work in R CMD check
2016-08-22 21:04:19 -05:00
Winston Chang
ba3f8f432e
Update staticdocs index. Closes #1293
2016-08-22 20:38:16 -05:00
Winston Chang
bab539f52c
Make it possible to have multiple bookmark buttons ( #1310 )
2016-08-19 21:13:27 -07:00
Winston Chang
42dbb128be
Fix handling of NULLs in updateDateInput
2016-08-19 14:36:29 -05:00
Winston Chang
5e4a6cb15f
Fix priority of onRestore observer
2016-08-19 14:12:57 -05:00
Winston Chang
73e45ce911
Clarify observer priority documentation
2016-08-19 14:10:24 -05:00
Winston Chang
1e40043456
Add travis fix for R-devel (thanks to @jimhester)
2016-08-19 12:12:42 -05:00
Winston Chang
7f3b952ec7
Documentation updates
2016-08-19 11:53:31 -05:00
Winston Chang
82887dc1c1
Do Travis checks on multiple R versions
2016-08-19 10:16:54 -05:00
Winston Chang
71380ab37a
Replace stopWithCondition with reactiveStop
2016-08-18 16:54:42 -05:00
Winston Chang
5d00804758
Add size argument to modalDialog ( #1308 )
2016-08-18 14:43:57 -07:00
Winston Chang
84364c65b0
Bookmark/restore actionButtons ( #1304 )
2016-08-18 14:42:19 -07:00
Winston Chang
1b59b705ae
Fix bookmark URL when there are no input values. Fixes #1306
2016-08-17 14:00:14 -05:00
Winston Chang
bc90fe6f99
Don't error when creating tabsets without id
...
The bug was introduced by #1296 .
2016-08-16 20:02:33 -05:00
Winston Chang
c8d6a0833e
Merge pull request #1301 from daattali/patch-2
...
fix typo in NEWS
2016-08-16 13:57:28 -05:00
Winston Chang
d8fc7d27ec
Add Dismiss button to URL modal
2016-08-16 13:00:42 -05:00
Winston Chang
1e44b19ff0
Fix typo in bookmarkButton documentation
2016-08-16 12:28:37 -05:00
Winston Chang
cc8b2cd20e
Document that enableBookamrking can be called in onStart function
2016-08-16 12:22:19 -05:00
Dean Attali
057b1e294c
fix typo in NEWS
2016-08-13 01:54:43 -07:00
Winston Chang
0653e790c7
Merge pull request #1298 from rstudio/handle-malformed-dates
...
Don't crash on malformed date input values. Closes #803
2016-08-12 21:29:00 -05:00
Winston Chang
6d72bbcb76
Don't crash on malformed date input values. Closes #803
2016-08-12 21:28:43 -05:00
Winston Chang
59e6f08455
Merge branch 'textarea'
2016-08-12 21:26:55 -05:00
Winston Chang
8fdccf50a8
Update NEWS
2016-08-12 21:26:19 -05:00
Winston Chang
1c7e11c5d9
Textarea refinements
2016-08-12 21:26:18 -05:00
Winston Chang
1756fbbb23
Merge branch 'fix-update-date'
2016-08-12 21:23:42 -05:00
Winston Chang
7bb939ab7f
Restore bookmarked tabs. Fixes #1282 ( #1296 )
2016-08-12 18:53:44 -07:00
Nuno Agostinho
4fa0abbd5a
Add arguments height, rows and cols
2016-08-12 17:19:23 -05:00
Nuno Agostinho
1e5f0266ef
Fix missing parenthesis
2016-08-12 17:19:23 -05:00
Nuno Agostinho
3dee62105e
Fix value assignment of text area input
2016-08-12 17:19:23 -05:00
Nuno Agostinho
680b2323d5
Update documentation relative to textarea input
2016-08-12 17:19:23 -05:00
Nuno Agostinho
562b4dad4d
Add textarea input
2016-08-12 17:19:23 -05:00
Joe Cheng
079a82dfe4
executeElapsed gets stuck returning TRUE even when nothing was executed
...
Fixes #1278
2016-08-12 17:19:23 -05:00
Winston Chang
16f7eb43b0
Merge branch 'joe/bugfix/too-often-flush'
2016-08-12 15:24:25 -05:00
Winston Chang
4b0ed3f224
updateDateInput: better handling of malformed dates. Closes #1179
2016-08-12 14:43:44 -05:00
Winston Chang
1d453b694d
Add documentation about using selected=character(0). Closes #1182
2016-08-12 14:22:54 -05:00
Barbara Borges Ribeiro
751e8c189e
fixes #1093 ( #1291 )
...
* fixes #1093
* check if NULL
2016-08-11 14:29:24 -07:00
Winston Chang
183e9a3d0b
Bookmarking fixes ( #1281 )
...
* Rename invalidateReactiveValue to freezeReactiveValue
* Make onFlush and onFlushed use 'once' argument
* session$flushOutput: schedule another flush if needed
* Catch all errors before they propagate to websocket
* Restore original logic for progressKeys
2016-08-11 11:58:07 -07:00
Winston Chang
5f0f4dd485
Merge pull request #1285 from rstudio/joe/bugfix/update-radio-buttons-modules
...
Fix #1144 : RadioButtons and checkBoxGroup do not work in modules when they are updated
2016-08-11 13:17:15 -05:00
Barbara Borges Ribeiro
20f05662aa
fixes #1289
2016-08-11 15:57:31 +01:00
Joe Cheng
963471b43f
Fix #1144 : RadioButtons and checkBoxGroup do not work in modules when they are updated
...
The unqualified input ID was being used to generate name attributes
on radio and checkboxes.
2016-08-10 15:52:01 -07:00
Joe Cheng
fdb52e0243
executeElapsed gets stuck returning TRUE even when nothing was executed
...
Fixes #1278
2016-08-10 15:10:31 -07:00
Winston Chang
d1e4483f98
Upgrade to Font-Awesome 4.6.3. Closes #1274
2016-08-10 15:40:10 -05:00
Winston Chang
b194ada316
Upgrade to Bootstrap 3.3.7
2016-08-10 15:34:51 -05:00
Winston Chang
3a25a2dcbf
Upgrade to jQuery 1.12.4. Closes #1251
2016-08-10 15:24:08 -05:00
Barbara Borges Ribeiro
85e4497fbe
fixes #1270 ; improves docs; export isTruthy()
2016-08-10 20:45:40 +01:00
Barbara Borges Ribeiro
0bfa5e7ea6
allow sticky nodes in reactlog if users drags them ( #1283 )
2016-08-10 20:04:37 +01:00
Barbara Borges Ribeiro
013599890f
Solve updateSelectInput bug in IE 11.0 ( #1277 )
2016-08-09 19:08:30 +01:00
Winston Chang
519e552405
Unset shinyOptions when set to NULL
2016-08-08 13:03:07 -05:00
Winston Chang
32a4ec49f7
Bump version and update NEWS
2016-08-05 16:19:57 -05:00
Winston Chang
3223332906
Merge pull request #1209 from wch/bookmarkable-state
...
Bookmarkable state
2016-08-05 16:15:12 -05:00
Winston Chang
f78bd08440
Correctly handle bookmark options for global.R and app.R
2016-08-05 16:08:49 -05:00
Winston Chang
99b5f92d7a
Add showBookmarkUrlModal
2016-08-03 16:07:49 -05:00
Barbara Borges Ribeiro
1cc5e84104
Barbara/error handling/port as socket ( #1263 )
...
* catch if `port` is being used incorrectly (see issue #971 )
* better error msg
2016-08-03 15:50:30 -05:00
Winston Chang
8346f5ab08
Fix enableBookmarking references
2016-08-03 14:41:37 -05:00
Winston Chang
dc60a39ba9
Fix tests to be order-insensitive
2016-08-02 13:47:42 -05:00
Winston Chang
16f7872553
Grunt
2016-08-02 11:18:25 -05:00
Winston Chang
75e7c4b2ca
More informative error messages
2016-08-02 11:10:17 -05:00
Barbara Borges Ribeiro
c5d5ddd7d2
Merge pull request #1267 from rstudio/barbara/remove-example-extra-line
...
had forgotten to run devtools::document for #1266...
2016-08-02 04:16:22 +01:00
Barbara Borges Ribeiro
98a81e3708
had forgotten to run devtools::document
2016-08-02 04:13:35 +01:00
Barbara Borges Ribeiro
ecdbdb944a
Merge pull request #1266 from rstudio/barbara/remove-example-extra-line
...
Barbara/remove example extra line
2016-08-02 03:51:41 +01:00
Barbara Borges Ribeiro
8a2846461b
removed extra line at end of example section
2016-08-02 03:40:56 +01:00
Winston Chang
6bfb9a2f57
More details in enableBookmarking man page
2016-08-01 20:46:43 -05:00
Winston Chang
85dfb2d4eb
urlModal: always show Ctrl/Cmd-C copy message
2016-08-01 20:00:05 -05:00
Barbara Borges Ribeiro
8f1d0c2b8f
Barbara/appveyor ( #1265 )
2016-08-02 01:26:48 +01:00
Winston Chang
829494c03e
Make bookmark button work when there's a submitButton
2016-08-01 16:13:43 -05:00
Winston Chang
f89fade28d
Rename updateLocationBar to updateQueryString
2016-08-01 16:13:25 -05:00
Winston Chang
9081b1dadd
Simplify list2env
2016-08-01 14:22:23 -05:00
Winston Chang
84dac544af
Make sure state ID doesn't have invalid chars
2016-08-01 14:16:50 -05:00
Winston Chang
49f1ac333d
Always get appDir when shinyApp object is created
2016-08-01 14:01:16 -05:00
Winston Chang
a2b761094b
Fix bookmark values tests
2016-07-29 16:07:18 -05:00
Winston Chang
54bd3d480f
Fixes for R CMD check
2016-07-29 15:59:56 -05:00
Winston Chang
b281f8fa32
Merge branch 'master' into bookmarkable-state
2016-07-29 15:47:31 -05:00
Winston Chang
a3732f845e
Update bookmarking documentation
2016-07-27 16:17:21 -05:00
Winston Chang
38f6d0a020
When restoring modules, only provide state$dir if present
2016-07-26 16:24:36 -05:00
Winston Chang
a0e5da758a
Ensure that state$values can't be replaced
2016-07-26 16:24:02 -05:00
Winston Chang
dcbe10c1c7
Keep state$values as an environment for save and restore
2016-07-26 14:33:04 -05:00
Joe Cheng
1f823d2a1b
Fix #931 : Observer memory leak ( #1256 )
...
* Fix #931 : Observer memory leak
Observers were being prevented from being garbage collected by
their own onReactiveDomainEnded() event handlers. This commit
fixes that by making sure that those event handlers are only
registered when autoDestroy=TRUE, and that they are unregistered
both on destruction and when autoDestroy is changed.
* Remove extraneous self$ prefixes
* Add comment explaining autoDestroyHandle
2016-07-26 11:56:47 -07:00
Winston Chang
12d0a9e11a
For session_proxy, add [[ and disallow $<- and [[<- ( #1262 )
2016-07-26 11:21:38 -07:00
Winston Chang
326b294c83
Change progress indicators to use notification API ( #1160 )
2016-07-26 11:16:08 -07:00
Winston Chang
50f213ae71
Fixes for R CMD check
2016-07-26 10:32:13 -05:00
Winston Chang
91d4fd8849
Fix behavior when onBookmark() is called multiple times in a module
2016-07-25 22:29:55 -05:00
Winston Chang
3f1985a9dc
Allow modules to exclude their inputs
2016-07-25 22:10:38 -05:00
Winston Chang
573a71f09d
New version of reactiveValuesToList
2016-07-25 16:32:01 -05:00
Winston Chang
57900fa287
Move methods out of ShinySaveState
2016-07-25 16:31:47 -05:00
Winston Chang
fa721d9614
More informative comments
2016-07-25 16:31:47 -05:00
Winston Chang
e64bbacf68
Define filterNamespace and unNamespace locally
2016-07-25 16:31:47 -05:00
Winston Chang
6ee2edc757
Add namespace support to reactiveValuesToList
2016-07-25 13:58:21 -05:00
Winston Chang
9ec4faf0d0
Allow modules to call onBookmark, onRestore, onRestored
2016-07-25 10:52:41 -05:00
Winston Chang
5be3ba2ffa
Use Callbacks objects for bookmarking callbacks
2016-07-21 15:28:43 -05:00
Winston Chang
a5ee96656b
Add onFlush, onFlushed, and onSessionEnded functions
2016-07-21 14:33:43 -05:00
Winston Chang
2db71d0323
Re-document
2016-07-21 14:33:42 -05:00
Winston Chang
dcf321047f
When bookmarkStore="disable", don't restore
2016-07-21 13:55:45 -05:00
Winston Chang
4982110be9
configureBookmarking affect next shinyApp object creation
2016-07-21 12:49:36 -05:00
Winston Chang
28547e90d1
Fix memory leak ( #1254 )
...
* When observer is destroyed, invalidate context. Closes #1253
* Update NEWS
2016-07-20 21:01:29 -07:00
Joe Cheng
f70187597f
Merge pull request #1222 from rstudio/joe/bugfix/chrome-unsafe-ports
...
Don't use randomly-chosen port numbers that Chrome deems unsafe
2016-07-20 13:36:05 -07:00
Barbara Borges Ribeiro
333e454e78
Merge pull request #1252 from rstudio/barbara/bugfix/where
...
give `where` arg a default value ("replace")
2016-07-20 19:47:00 +01:00
Barbara Borges Ribeiro
61cfd11644
give where arg a default value ("replace")
2016-07-20 19:05:20 +01:00
Winston Chang
1c970c8176
Remove configureBookmarking; add onBookmark, onBookmarked, onRestore, onRestored
2016-07-19 14:31:57 -05:00
Winston Chang
1fea54ca5a
Merge pull request #1249 from daattali/patch-1
...
fix typo
2016-07-19 13:31:12 -05:00
Dean Attali
faccc42b22
fix typo
2016-07-17 02:42:41 -04:00
Winston Chang
460f4769a5
Add _inputs_ for url-encoded state
2016-07-12 12:30:37 -05:00
Winston Chang
f465643b75
Rename 'type' argument to 'store'
2016-07-11 23:00:19 -05:00
Winston Chang
a8afd71f96
Rename shiny_persist to shiny_bookmarks
2016-07-08 16:36:58 -05:00
Winston Chang
2274d60207
Change function(req) to function(request)
2016-07-08 16:23:52 -05:00
Winston Chang
57159bccfd
Show copy instructions in bookmark dialog
2016-07-08 16:22:09 -05:00
Winston Chang
2888124752
Capture and log errors in initializing RestoreContext
2016-07-08 15:22:58 -05:00
Winston Chang
408e751dcf
Capture and log errors in bookmarking/restoring
2016-07-08 15:22:21 -05:00
Winston Chang
af5dcc38a4
Add onRestored argument
2016-07-07 12:44:10 -05:00
Winston Chang
81434640d6
Use name 'bookmark' in more places
2016-07-07 12:04:53 -05:00
Barbara Borges Ribeiro
a45b58d956
Merge pull request #1239 from rstudio/joe/bugfix/insert-ui-initialize
...
Fix insertUI bug. Closes #1220 , #1231 , #1232
2016-07-06 22:04:00 +01:00
Barbara Borges Ribeiro
2c5e9a5e76
moved multiple to 4th argument
2016-07-06 21:44:52 +01:00
Barbara Borges Ribeiro
9fb847b179
Merge branch 'master' into joe/bugfix/insert-ui-initialize
2016-07-06 21:37:58 +01:00
Barbara Borges Ribeiro
b8341b2ba8
Merge pull request #1238 from rstudio/feature/pool-scheduler
...
Better pool support (minor change)
2016-07-06 21:35:21 +01:00
Barbara Borges Ribeiro
26d6e4da2c
allows callback to be garbage collected
2016-07-06 21:29:12 +01:00
Barbara Borges Ribeiro
b16ed602d5
rebased with master
...
Merge branch 'joe/bugfix/insert-ui-initialize' of https://github.com/rstudio/shiny into joe/bugfix/insert-ui-initialize
# Conflicts:
# inst/www/shared/shiny.js.map
# inst/www/shared/shiny.min.js
# inst/www/shared/shiny.min.js.map
2016-07-06 18:04:17 +01:00
Barbara Borges Ribeiro
24aab4d5d3
Merge branch 'master' of https://github.com/rstudio/shiny
2016-07-06 14:18:49 +01:00
Barbara Borges Ribeiro
2eb69d421a
fix to outputOptions
2016-07-06 14:18:38 +01:00
Winston Chang
cb52706f2f
Add bookmarking example with arbitrary values
2016-07-05 16:35:00 -05:00
Winston Chang
f44d232e8b
Add check that UI is a function when restoring state
2016-07-05 16:28:09 -05:00
Winston Chang
a0ac79b9dd
Documentation updates
2016-07-05 15:30:42 -05:00
Joe Cheng
177a2a8a1e
Input not being initialized with insertUI if beforeStart/afterEnd
2016-07-05 11:06:25 -07:00
Barbara Borges Ribeiro
8b21a87175
Update NEWS
2016-06-30 17:51:09 +01:00
Barbara Borges Ribeiro
6d2dd8e315
Merge pull request #1226 from rstudio/feature/pool-scheduler
...
Support pool package
2016-06-30 17:49:52 +01:00
Joe Cheng
8b3aff599b
Don't use randomly-chosen port numbers that Chrome deems unsafe
...
Still OK to use these ports if the user asks for them explicitly
2016-06-25 22:37:22 -07:00
Joe Cheng
deb9b74f27
Do equivalent of "mkdir -p" when making state dir
2016-06-25 14:25:22 -07:00
Winston Chang
591de3cbe8
Don't restore state if in a subapp
2016-06-20 16:00:25 -05:00
Winston Chang
f7151e2132
Change '_state_id' to '__state_id__'
2016-06-20 15:12:10 -05:00
Winston Chang
44521be6dd
Gracefully handle errors in restoring state
2016-06-20 12:54:04 -05:00
Winston Chang
30416cdbb5
Grunt
2016-06-16 12:44:28 -05:00
Winston Chang
d04da2d256
Add asList method
2016-06-16 12:44:09 -05:00
Winston Chang
231d8a1949
Move loading and decoding of query string into RestoreContext
2016-06-16 10:39:45 -05:00
Winston Chang
3207bec805
Add ShinyRestoreContext class
2016-06-15 15:08:33 -05:00
Winston Chang
425a71e382
Replace bookmarkConfig with bookmarkObserver
2016-06-15 14:55:29 -05:00
Winston Chang
daa12ab2ec
Revise how onSave is called; move persist() and encode() into ShinyState object
2016-06-15 14:55:06 -05:00
Joe Cheng
4c652389c5
Support pool package
2016-06-14 12:58:50 -07:00
Winston Chang
f69d88a656
Refinements to save button
2016-06-14 13:23:58 -05:00
Winston Chang
098cbc1456
Better splitting of state query string
2016-06-13 23:19:35 -05:00
Winston Chang
5f2da953a9
Add invalidateReactiveValue function
2016-06-13 22:12:28 -05:00
Winston Chang
638d999fcc
Replace updateQueryString with updateLocationBar
2016-06-13 16:47:24 -05:00
Winston Chang
fa80fd64da
Make 'restorable' opt-out instead of opt-in
2016-06-13 14:24:21 -05:00
Winston Chang
e4dad82dde
Rename 'save' to 'persist'
2016-06-13 12:38:43 -05:00
Winston Chang
d65ff924c8
Add bookmarkButton
2016-06-10 12:47:31 -05:00
Winston Chang
96e9661aaa
Fix reactive dependencies when restoring values
2016-06-10 10:55:18 -05:00
Winston Chang
8829d2ebd4
Properly mark actionButtons and passwordInputs as unserializable
2016-06-10 10:44:51 -05:00
Winston Chang
c019280d8a
Call onRestore only if it exists
2016-06-10 10:38:04 -05:00
Winston Chang
8d3e5fc160
Refinements
2016-06-10 10:11:55 -05:00
Winston Chang
d3f1312c0b
Remove 'enable' argument
2016-06-09 14:55:33 -05:00
Winston Chang
c58f48a1e4
Add support for bookmarking arbitrary values
2016-06-09 14:45:55 -05:00
Winston Chang
979e93509e
parseQueryString: ignore extra ampersands
2016-06-09 13:01:36 -05:00
Winston Chang
135c3709b4
Prepare things for separate values
2016-06-09 11:57:45 -05:00
Winston Chang
08400d3f18
Add configureBookmarking function
2016-06-08 12:56:03 -05:00
Winston Chang
bf52075d1b
Merge pull request #1197 from rstudio/joe/feature/resetBrush
...
Add ability to reset brush with session$resetBrush/Shiny.resetBrush
2016-06-03 13:04:01 -05:00
Winston Chang
56befda288
Remove outdated example
2016-06-03 12:48:34 -05:00
Winston Chang
3d68f1dc62
Remove bookmarkOutput; add saveStateModal and encodeStateModal
2016-06-03 12:48:33 -05:00
Winston Chang
970036ce1a
Remove clipboard.js
2016-06-03 12:48:33 -05:00
Winston Chang
62108f28f4
Fix argument defaults
2016-06-02 12:52:19 -05:00
Winston Chang
66bbb072c3
Remove createBookmark function
2016-06-02 12:48:17 -05:00
Winston Chang
6c52c26a62
Make names consistent
2016-06-02 11:47:56 -05:00
Winston Chang
d52943d1bf
Remove unused code path
2016-06-01 21:41:35 -05:00
Winston Chang
7cb1bbe3d6
Use new ID each time state is saved
2016-06-01 18:12:07 -05:00
Winston Chang
2548c46b8b
Check for '..' in restored file input path
2016-06-01 18:07:33 -05:00
Winston Chang
dd5118116b
Use wrapper functions for saving/restoring state
2016-06-01 17:10:56 -05:00
Winston Chang
77a9b66028
Merge pull request #1201 from rstudio/bugfix/avoid-radix-sort-overflow
...
avoid overflow in R 3.3.0 radix sort
2016-05-27 21:39:15 -05:00
Kevin Ushey
e813dab81c
avoid overflow in R 3.3.0 radix sort
2016-05-27 14:48:44 -07:00
Winston Chang
6696880178
Add ability to save and restore fileInputs. Also improve fileInput appearance
2016-05-27 14:42:00 -05:00
Winston Chang
8e5952d9ae
Add serializers
2016-05-26 12:43:01 -05:00
Joe Cheng
360c1d5953
Add ability to reset brush with session$resetBrush/Shiny.resetBrush
2016-05-25 15:37:27 -07:00
Winston Chang
a7aa6ced19
Save each state in a subdirectory
2016-05-20 14:52:52 -05:00
Winston Chang
97eea669d4
Better error handling when saving/restoring state
2016-05-20 14:17:23 -05:00
Winston Chang
c84777928e
Use same state ID throughout a session
2016-05-20 14:10:26 -05:00
Winston Chang
490064a953
Remove unneeded randomID function
2016-05-20 14:10:26 -05:00
Winston Chang
d5975195b3
Initial version of saving state
2016-05-20 14:10:26 -05:00
Winston Chang
9588c36abb
Merge branch 'joe/feature/insert-UI'
2016-05-18 15:53:50 -05:00
Barbara Borges Ribeiro
f9200ac135
small fixes; documentation; got rid of unnecassary things
2016-05-18 12:35:25 +01:00
Winston Chang
fffb9606ec
Merge pull request #1185 from rstudio/barbara/showcase-update
...
Barbara/showcase update
2016-05-16 10:04:24 -05:00
Winston Chang
781e15cb84
Restore values only if 'restorable' option is set
2016-05-13 21:06:06 -05:00
Winston Chang
9742001a71
Add shiny options
2016-05-13 20:37:58 -05:00
Barbara Borges Ribeiro
e92eee5ffc
removed constraint that forced elements inserted with insertUI to be wrapped in a div/span
2016-05-13 15:28:02 -05:00
Barbara Borges Ribeiro
293c1d471c
tiny fix
2016-05-13 14:34:07 -05:00
Barbara Borges Ribeiro
384240b6a4
added NEWS item for IncludeWWW
2016-05-13 14:26:45 -05:00
Winston Chang
6fd626a3ec
Disable seralizing of passwords and actionButtons
2016-05-12 17:03:25 -05:00
Winston Chang
bb4ce2f978
Don't clear bookmark DOM elements on error
2016-05-12 15:27:17 -05:00
Barbara Borges Ribeiro
2269e05058
code highliting; dropdown menu for the www files
2016-05-12 15:12:04 -05:00
Winston Chang
ca2a07b816
Add ability to invalidate a reactive value
2016-05-12 10:21:29 -05:00
Winston Chang
38c7bb35e0
Code cleanup
2016-05-12 10:06:44 -05:00
Winston Chang
4f6408f3e1
Add optional update button for bookmarkOutput
2016-05-12 10:06:44 -05:00
Winston Chang
7910d9fde4
Add argument to exclude values from bookmarking
2016-05-12 10:06:43 -05:00
Winston Chang
0258d7e24f
Make sure bookmark output is not a text input
2016-05-12 10:06:43 -05:00
Winston Chang
85556ed532
Don't error when no restore context available
2016-05-12 10:06:43 -05:00
Winston Chang
cecb04b097
Make restore context available from server code
2016-05-12 10:06:43 -05:00
Winston Chang
8a7c5c18d0
Add tooltip on copy
2016-05-12 10:06:43 -05:00
Winston Chang
14a1a3f574
Rename functions
2016-05-12 10:06:43 -05:00
Winston Chang
c19f2a7499
Add license info for clipboard.js
2016-05-12 10:05:37 -05:00
Winston Chang
df95be5455
Add bookmarkOutput
2016-05-12 10:05:37 -05:00
Winston Chang
00bef13f1c
Add ability for inputs to restore bookmarked values
2016-05-12 10:05:37 -05:00
Winston Chang
a6a35905a7
Clearer variable names
2016-05-12 10:05:37 -05:00
Winston Chang
93f28ef55c
Preserve type of bookmarked data
2016-05-12 10:05:36 -05:00
Joe Cheng
bbcb9573cd
Add example
2016-05-12 10:05:36 -05:00
Winston Chang
43cc6e19d4
Fixes
2016-05-12 10:05:36 -05:00
Joe Cheng
f4a44664c7
Bookmarkable state wip
2016-05-12 10:05:36 -05:00
Barbara Borges Ribeiro
dd7a3269ad
added wwwFiles boolean option to DESCRIPTION file
2016-05-07 17:21:59 +01:00
Winston Chang
157d1b20c5
Fixes for R CMD check
2016-05-06 15:14:09 -05:00
Winston Chang
85fe0c00c2
Fix tests
2016-05-06 15:10:45 -05:00
Winston Chang
91092b8a96
Fix function labels for profiling
2016-05-06 15:03:00 -05:00
Barbara Borges Ribeiro
1ed237cfcc
init commit
2016-05-05 16:11:43 +01:00
Barbara Borges Ribeiro
c7044498d5
added NEWS item for insertUI / removeUI
2016-05-05 14:17:45 +01:00
Joe Cheng
1d2a2fbcae
Merge remote-tracking branch 'origin/joe/feature/insert-UI'
2016-05-04 11:34:54 -07:00
Barbara Borges Ribeiro
9b015e8cae
documentation update
2016-05-03 13:57:10 +01:00
Barbara Borges Ribeiro
0a8c26fff4
call sendImageSize from unbindOutputs
2016-05-02 20:02:41 +01:00
Barbara Borges Ribeiro
506de72666
fixed typos; included argument defaults; removed 'shown', 'hidden' triggers following chat with Winston
2016-05-02 18:27:15 +01:00
Barbara Borges Ribeiro
a5b4156b56
moved insertAdjacentElement to the right place
2016-05-02 15:19:08 +01:00
Barbara Borges Ribeiro
da4b42cb1d
ran grunt
2016-05-02 14:50:46 +01:00
Barbara Borges Ribeiro
53790f8247
various updates
2016-05-02 14:48:05 +01:00
Barbara Borges Ribeiro
69780d4727
added sendImage and sendOUtputHIddenState
2016-04-29 06:33:06 +01:00
Barbara Borges Ribeiro
aa2b644684
updated documentation; added ... argument to onFlush() and onFlushed() in order to be able to pass in arguments to the func
2016-04-29 05:27:26 +01:00
Barbara Borges Ribeiro
a12e8875a6
changed everything from sendCustomMessage to session$sendMessage
2016-04-29 05:16:22 +01:00
Barbara Borges Ribeiro
9e91b265ce
sendInsertUI now uses sendMessage instead of sendCustomMessage
2016-04-29 04:46:09 +01:00
Barbara Borges Ribeiro
8c12e3ab90
added insertAdjacentElement for compatibility with Firefox
2016-04-28 12:03:15 +01:00
Winston Chang
7e303b4fc0
Merge pull request #1157 from rstudio/modal
...
Add modal dialogs
2016-04-27 15:30:02 -05:00
Winston Chang
40e0fcff30
Change modal example
2016-04-27 15:29:18 -05:00
Winston Chang
3c9e74b23e
Re-document
2016-04-26 15:30:03 -05:00
Barbara Borges Ribeiro
6b001eb7c3
updated insertUI; added removeUI
2016-04-25 23:03:18 +01:00
Winston Chang
f81621aa66
Merge pull request #1158 from rstudio/example-cleanup
...
Clean up examples
2016-04-22 13:05:36 -05:00
Winston Chang
08c7484087
Rename argument
2016-04-21 15:22:43 -05:00
Barbara Borges Ribeiro
a8c68f3e30
updated shiny-options text
2016-04-18 17:28:45 +01:00
Barbara Borges Ribeiro
0e6698d760
updated NEWS
2016-04-18 02:12:47 +01:00
Barbara Borges Ribeiro
f3d4f9ff23
Merge pull request #1156 from rstudio/barbara/error-hiding
...
Barbara/error hiding
2016-04-18 01:56:26 +01:00
Barbara Borges Ribeiro
d711f17081
changed sanitization default to FALSE (on local development)
2016-04-18 01:44:43 +01:00
Barbara Borges Ribeiro
d35eba45c5
tiny fix
2016-04-18 01:34:50 +01:00
Barbara Borges Ribeiro
cd53e79b19
removed classError argument to safeError function
2016-04-18 01:27:37 +01:00
Barbara Borges Ribeiro
3db7029534
Merge branch 'master' of https://github.com/rstudio/shiny
2016-04-15 16:50:19 +01:00
Barbara Borges Ribeiro
ad1e52bf19
got rid of warning that popped up when renderFunc took no arguments; there really isn't a good reason to require this (not at this point at least)
2016-04-15 16:49:52 +01:00
Barbara Borges Ribeiro
e08791a284
update to safeError
2016-04-14 18:20:49 +01:00
Barbara Borges Ribeiro
8d1deeb568
undo last commit to be able to merge automatically
2016-04-14 18:02:16 +01:00
Barbara Borges Ribeiro
375c7789a2
updated NEWS
2016-04-14 17:52:10 +01:00
Barbara Borges Ribeiro
ec8a81aedb
Merge pull request #1163 from bborgesr/barbara/fix-tabsetpanel
...
deprecated position arg to tabsetPanel; updated NEWS; cc @jcheng5 @wch
2016-04-14 17:49:51 +01:00
Barbara Borges Ribeiro
033d513aee
added version to shinyDeprecated call; updated NEWS
2016-04-14 17:43:24 +01:00
Barbara Borges Ribeiro
fb3e4e4881
Changed customStop to stop(safeError). Refactored some middleware.R code. Fixed downloadHandler's bug of not responding to safeError.
2016-04-14 17:31:34 +01:00
Joe Cheng
8a30c006e7
Prototype insertUI functionality
2016-04-13 16:12:30 -07:00
Barbara Borges Ribeiro
3f76679673
another update to NEWS
2016-04-07 22:22:51 +01:00
Barbara Borges Ribeiro
1cee5d4b41
deprecated position arg to tabsetPanel; updated NEWS
2016-04-07 22:15:15 +01:00
Barbara Borges Ribeiro
3107eec697
removed unnecessary line
2016-04-07 02:01:56 +01:00
Barbara Borges Ribeiro
477d46316e
updated customStop() documentation example to match Winston's pattern
2016-04-06 14:08:11 +01:00
Winston Chang
3133693a0e
Update NEWS
2016-04-05 20:58:48 -05:00
Winston Chang
bc7d701298
Make examples runnable with shinyApp()
2016-04-05 20:53:59 -05:00
Winston Chang
5d6d75b4f3
Remove shinyUI() and shinyServer() from examples
2016-04-05 15:23:23 -05:00
Winston Chang
73d48a7b37
Grunt
2016-04-05 13:19:27 -05:00
Winston Chang
ed7b9a9989
Modal dialog refinements
2016-04-05 13:18:57 -05:00
Winston Chang
e1a955752f
Add modal dialogs
2016-04-05 13:18:56 -05:00
Winston Chang
0bdc8f0b2b
Update package.json
2016-04-05 09:45:06 -05:00
Barbara Borges Ribeiro
a692b3ced8
implemented error hiding for ui.R and downloadHandler() cases
2016-04-05 15:28:05 +01:00
Winston Chang
2f5b93861d
Merge pull request #1152 from daattali/master
...
add placeholder option to passwordInput()
2016-04-04 11:23:44 -05:00
Joe Cheng
110183585c
Merge pull request #1143 from rstudio/joe/feature/output-arg-passthrough
...
Joe/feature/output arg passthrough
2016-04-03 08:10:44 -07:00
Barbara Borges Ribeiro
7eb29586a7
a few minor tweaks
2016-04-03 15:24:17 +01:00
Barbara Borges Ribeiro
401065a23e
a lot of not very productive experimentation
2016-04-03 15:00:59 +01:00
Dean Attali
4e5e0fb0ce
add placeholder option to passwordInput()
2016-04-02 18:44:10 -07:00
Barbara Borges Ribeiro
d41a06611e
fixed documentation
2016-04-01 23:57:20 +01:00
Barbara Borges Ribeiro
26c3c27726
a few tweaks to customStop()
2016-04-01 22:47:58 +01:00
Barbara Borges Ribeiro
19ab63e041
a little code refactoring and added a customStop() function
2016-04-01 02:45:41 +01:00
Barbara Borges Ribeiro
5dafdab3d7
made the tracker construct - now an R6 class - easier to understand (more obvious); fixed the shinysession and name issues related to the renderFunc's
2016-04-01 00:44:14 +01:00
Barbara Borges Ribeiro
afbb17d428
errors are now sanitized in the app by default (must use options(shiny.sanitize.errors = FALSE) to override this behavior)
2016-03-30 07:29:58 +01:00
Winston Chang
8a721fbd25
Bump version to 0.13.2.9001 and update NEWS
...
Shiny 0.13.2 was released from another branch so its changes to NEWS were
incorporated here
2016-03-29 22:46:46 -05:00
Winston Chang
5d91a409e7
Merge pull request #1150 from rstudio/navbarpage-selected
...
Allow setting selected item in navbarPage. Closes #970
2016-03-29 22:35:18 -05:00
Winston Chang
8470f7caf8
Allow setting selected item in navbarPage. Closes #970
2016-03-29 22:32:00 -05:00
Winston Chang
67e279928e
Merge pull request #1147 from rstudio/navbar-horizontal-divider
...
navbarMenu horizontal dividers
2016-03-29 22:13:24 -05:00
Winston Chang
77ac3a62b7
Check that tab arguments are unnamed
2016-03-29 12:56:43 -05:00
Winston Chang
12eaa3a162
Reconnection refinements
2016-03-29 12:41:46 -05:00
Joe Cheng
bbd5dd7b4f
Merge pull request #1132 from rstudio/joe/reactive-graph-data
...
Update reactive graph sample data to include time
2016-03-29 09:54:15 -07:00
Joe Cheng
38fcd6e267
Merge pull request #1074 from rstudio/reconnect
...
Reconnect
2016-03-29 09:53:20 -07:00
Winston Chang
fd7f683eaa
Remove bootstrapDependency function. Closes #1069
2016-03-29 11:12:05 -05:00
Winston Chang
e15f9acd91
Grunt
2016-03-28 21:30:27 -05:00
Winston Chang
7cb0882c73
Add "force" option to allowReconnect
2016-03-28 21:29:23 -05:00
Winston Chang
486d4d1c88
Add 'action' parameter to notifications
2016-03-28 15:15:07 -05:00
Winston Chang
ded8b13e96
Reconnect UI refinements
2016-03-28 14:42:44 -05:00
Barbara Borges Ribeiro
c7eb7ba861
passed error through if handler accepts it
2016-03-28 20:31:39 +01:00
Barbara Borges Ribeiro
4920bff8fd
tiny documentation update
2016-03-28 18:24:04 +01:00
Barbara Borges Ribeiro
d78edf5dda
removed func arg from render functions; fixed issue introduced by rebase a few commits ago
2016-03-28 18:19:37 +01:00
Winston Chang
7510c02d83
Update ion.RangeSlider to 2.1.2
2016-03-28 11:17:07 -05:00
Barbara Borges Ribeiro
2d7b729473
got rid of unnecessary lines
2016-03-28 15:46:55 +01:00
Barbara Borges Ribeiro
0495fe2d71
updated renderFunc's to include a shinysession arg
2016-03-28 15:31:33 +01:00
Barbara Borges Ribeiro
d7da5df734
updated integration etsts
2016-03-28 13:18:22 +01:00
Barbara Borges Ribeiro
4462b6bd39
changed a warning to an error, following the "fail fast" principle
2016-03-28 13:00:11 +01:00
Barbara Borges Ribeiro
80e1edeeb2
a better way to check which context the render function is being called from
2016-03-28 12:54:54 +01:00
Winston Chang
11af421f10
Use notification API for reconnection interface
2016-03-25 16:39:58 -05:00
Winston Chang
686ff235e7
New reconnect UI
2016-03-25 15:43:08 -05:00
Winston Chang
31f76a6d4d
Add back gray-out on disconnect
2016-03-25 15:40:46 -05:00
Winston Chang
50078078e0
Export show/hideReconnectDialog functions
2016-03-25 15:40:45 -05:00
Winston Chang
be85e1e2f7
Add onConnected and onDisconnected
2016-03-25 15:40:45 -05:00
Winston Chang
9ad1574292
Allow Shiny Server to properly override methods
2016-03-25 15:40:45 -05:00
Winston Chang
4b71825707
Increase reconnect delay time with subsequent attempts
2016-03-25 15:40:45 -05:00
Winston Chang
fb1fd88947
Tweaks to disconnection/reconnection UI
2016-03-25 15:40:45 -05:00
Winston Chang
dca527d8b6
Allow app to control reconnection behavior
2016-03-25 15:40:45 -05:00
Winston Chang
3452a445fe
Show box when trying to reconnect
2016-03-25 15:40:45 -05:00
Winston Chang
a06e9d2bef
Implement auto-reconnect
2016-03-25 15:39:31 -05:00
Winston Chang
7a3961a280
Add support for menu section headers
2016-03-25 09:29:42 -05:00
Winston Chang
54729d8fb4
Update NEWS
2016-03-24 20:11:44 -05:00
Winston Chang
c2e17ee182
Add support for horizontal dividers in navbarMenu
2016-03-24 20:11:07 -05:00
Barbara Borges Ribeiro
bc0064d4b9
harcoded colors used for the color-coding of the time labels (creditted colorbrewer)
2016-03-25 00:51:19 +00:00
Barbara Borges Ribeiro
03685dbb61
added check for valid arguments if passed via outputArgs
2016-03-25 00:22:48 +00:00
Barbara Borges Ribeiro
26fcba8ed5
really not a solution...
2016-03-24 22:42:57 +00:00
Barbara Borges Ribeiro
bc15b65538
added outputArgs to all other renderXXX functions following the pattern used for renderPlot
2016-03-24 22:42:57 +00:00
Joe Cheng
e9ab34a9c1
Provide xxxOutput args via renderXXX passthrough
...
This will allow you to customize outputs when used in an R Markdown
document
2016-03-24 22:21:48 +00:00
Winston Chang
0bf512ebdd
Grunt
2016-03-24 17:11:12 -05:00
Winston Chang
7646fbeaa0
Bump version to 0.13.1.9002
2016-03-24 17:11:02 -05:00
Winston Chang
84b4766013
Merge pull request #1141 from rstudio/notifications
...
Notification interface
2016-03-24 17:09:31 -05:00
Winston Chang
3a48734b2f
Re-document
2016-03-24 14:07:37 -05:00
Winston Chang
36ae332959
Remove some public methods for notifications
2016-03-24 14:01:28 -05:00
Winston Chang
3e0d8da9d6
Add exports.renderContent to modularize content rendering in JS
2016-03-23 15:46:44 -05:00
Winston Chang
2fcb4dbe50
Modularize dependency handling in R
2016-03-23 15:46:03 -05:00
Winston Chang
09c93bfb39
Escape ID
2016-03-23 14:34:20 -05:00
Winston Chang
34068b1598
Rename 'style' to 'type'
2016-03-23 14:34:20 -05:00
Barbara Borges Ribeiro
a67da1c99a
added color scale for time labels
2016-03-23 16:26:33 +00:00
Winston Chang
0d6754761d
Add style argument
2016-03-22 15:36:21 -05:00
Winston Chang
898f7b66cf
Rename argument from 'html' to 'ui'
2016-03-22 14:47:07 -05:00
Winston Chang
c18f3e86f0
Add note about IDs
2016-03-22 13:46:21 -05:00
Barbara Borges Ribeiro
de51922f10
Trigger
2016-03-22 17:02:38 +00:00
Winston Chang
be0cb18bfc
Merge pull request #1138 from rstudio/joe/bugfix/htmltemplate-doc-update
...
Update htmlTemplate docs for htmltools 0.3.5
2016-03-22 11:13:31 -05:00
Winston Chang
39fd1db3c0
Bump htmltools required version to 0.3.5
2016-03-22 11:07:15 -05:00
Winston Chang
b4565e7354
Fix coordmap tests
2016-03-22 11:05:59 -05:00
Winston Chang
e28cada4dd
Handle tag inputs and escape HTML text
2016-03-21 20:10:17 -05:00
Joe Cheng
6daac65968
Add missing entries to staticdocs index
2016-03-21 17:00:17 -07:00
Joe Cheng
1ecc49c450
Update htmlTemplate docs for htmltools 0.3.5
2016-03-21 16:53:46 -07:00
Barbara Borges Ribeiro
f96e7d9aaa
stored the timeElapsed float on the node instead of the fully formatted string; made sure we're not showing any time elapsed info while the node is active (it could be confusing)
2016-03-21 23:25:17 +00:00
Barbara Borges Ribeiro
c637bba867
changed time label color; updated default argument to renderReactLog
2016-03-21 22:19:45 +00:00
Barbara Borges Ribeiro
bdc6554ca8
added time argument
2016-03-21 21:53:34 +00:00
Winston Chang
ecb59e9c31
Add R notification functions
2016-03-21 16:47:55 -05:00
Winston Chang
1b39184e98
Add randomID function
2016-03-21 16:43:35 -05:00
Barbara Borges Ribeiro
2a35ba64f7
fixed y positioning
2016-03-21 21:15:32 +00:00
Barbara Borges Ribeiro
3a5123627d
updated multilineTextNode
2016-03-21 21:04:27 +00:00
Barbara Borges Ribeiro
a18eeecd59
separated text label and time label
2016-03-21 20:59:32 +00:00
Winston Chang
85e3f04738
Restyle notifications and add close button
2016-03-21 13:59:12 -05:00
Barbara Borges Ribeiro
cc59864377
experimenting
2016-03-21 18:49:47 +00:00
Barbara Borges Ribeiro
5b10cbf2e2
added 'time elapsed' to nodes' labels
2016-03-21 14:30:42 +00:00
Barbara Borges Ribeiro
fc6b83bb5d
Merge pull request #1136 from rstudio/barbara/renderTable-fixes
...
tiny update following the bigger renderTable() PR
2016-03-18 21:20:29 +00:00
Barbara Borges Ribeiro
bc509f55d9
added NEWS item documenting the change to renderTable() and fixed tiny bug (stop() message was spanning two lines with only one string)
2016-03-18 21:15:35 +00:00
Winston Chang
f81301ece6
Simplify notification API
2016-03-18 15:53:40 -05:00
Winston Chang
382e5c1f43
Rename Shiny.Notification to Shiny.notifications
2016-03-18 14:59:43 -05:00
Winston Chang
0243f74dcd
Add delay before removal
2016-03-18 14:45:21 -05:00
Winston Chang
58737ef454
Add notification JS API
2016-03-18 14:45:21 -05:00
Winston Chang
940cea82ca
Merge pull request #1133 from rstudio/es6
...
Add tooling for ES6
2016-03-18 14:44:53 -05:00
Winston Chang
5683e36733
Add estraverse-fb npm dependency
2016-03-18 14:42:03 -05:00
Winston Chang
f5137b7935
Grunt
2016-03-18 14:16:47 -05:00
Winston Chang
0c2af42c69
Make ESLint gave warnings instead of errors
2016-03-18 14:15:36 -05:00
Winston Chang
760dc5d0c6
Add babel polyfill
2016-03-18 14:15:36 -05:00
Winston Chang
5331aa08a7
Fixes for eslint
2016-03-18 14:15:36 -05:00
Winston Chang
375d7cc7b1
Update eslint rules
2016-03-18 14:15:36 -05:00
Winston Chang
a05f3dd640
Update npm packages
2016-03-18 14:15:36 -05:00
Winston Chang
b91c1b44ba
Switch from jshint to eslint
2016-03-18 14:15:36 -05:00
Winston Chang
6efb01a397
Use Babel for ES6->ES5 transpilation
2016-03-18 14:15:36 -05:00
Barbara Borges Ribeiro
1843eca6c0
Merge pull request #1134 from bborgesr/updateActionButton
...
Verify button icon format and created updateActionButton()
2016-03-18 19:01:50 +00:00
Barbara Borges Ribeiro
506e3e8a48
added another check in the JS to make sure that we're finding the correct icon
2016-03-18 18:55:38 +00:00
Barbara Borges Ribeiro
0e5a3cc5aa
throw error instead of warning in validateIcon(); updated documentation
2016-03-18 15:32:06 +00:00
Barbara Borges Ribeiro
d2dd76e13d
fixed typo
2016-03-17 21:36:51 +00:00
Barbara Borges Ribeiro
470b82fd64
compiled documentation
2016-03-17 21:20:42 +00:00
Barbara Borges Ribeiro
e04dd3a4b1
check icon validity more robustly; set icon=character(0) as the way to get rid of a previous icon; updated documentaion and NEWS
2016-03-17 21:15:49 +00:00
Barbara Borges Ribeiro
2d39e06c97
find i-tag elements with *any* class (to circumvent the issue of selecting italicized text)
2016-03-17 14:55:57 +00:00
Barbara Borges Ribeiro
e1fc74bdc1
updates to input_binding_actionbutton.js and got rid of isIcon function (substituted by simple check instead)
2016-03-17 14:47:48 +00:00
Barbara Borges Ribeiro
3ab5d7f861
verify that button icons are in the right format (not necessarily valid though) and added updateActionButton()
2016-03-15 22:19:21 +00:00
Winston Chang
d63dd6086a
Merge pull request #1129 from bborgesr/newRenderTable
...
Improved renderTable()
2016-03-15 12:43:02 -05:00
Barbara Borges Ribeiro
a8d9895a9b
updated documentation
2016-03-15 16:58:42 +00:00
Barbara Borges Ribeiro
f8a7257af3
improved defaultAlignment function and changed names of spacing value options
2016-03-15 16:47:35 +00:00
Barbara Borges Ribeiro
4703028988
actually with multiple tables, their ids would all be identical (bad), so switched back to using classes to gain specificity
2016-03-15 00:55:48 +00:00
Barbara Borges Ribeiro
87523cdbd5
created table id to add css specificity
2016-03-15 00:38:18 +00:00
Barbara Borges Ribeiro
d9567ed035
check valid spacing
2016-03-15 00:01:52 +00:00
Barbara Borges Ribeiro
0ab277662a
updated documentation
2016-03-14 23:00:15 +00:00
Barbara Borges Ribeiro
2eeb94e39c
changed bordered to spacing with four possible values, rather than only two
2016-03-14 22:48:55 +00:00
Joe Cheng
4b441d10b3
Update reactive graph sample data to include time
2016-03-14 15:37:53 -07:00
Barbara Borges Ribeiro
37a1d3d61e
improved defaultAlignment function
2016-03-14 20:24:41 +00:00
Barbara Borges Ribeiro
3839338c15
mostly spacing
2016-03-14 20:13:08 +00:00
Barbara Borges Ribeiro
bdee5790e6
added alignment default character ("?")
2016-03-14 18:39:51 +00:00
Barbara Borges Ribeiro
d0dab25dae
tried fix
2016-03-14 16:16:22 +00:00
Barbara Borges Ribeiro
b14b7b00c2
actually padding is necessary for headers too
2016-03-14 14:57:38 +00:00
Barbara Borges Ribeiro
248bfcccda
padding on all cells
2016-03-14 14:54:31 +00:00
Barbara Borges Ribeiro
9b5833205b
made the check for empty data frame more robust
2016-03-12 18:24:19 +00:00
Barbara Borges Ribeiro
07f8589090
coerce the input to a data frame (important if the input was a matrix for example, as some parts of the code might not apply)
2016-03-12 18:12:50 +00:00
Barbara Borges Ribeiro
f77f83dfeb
fixed a tiny bug introduced by the previous commit
2016-03-12 18:03:59 +00:00
Barbara Borges Ribeiro
e3d3d916ba
improved regex for substitution (less fragile, less hack-ish)
2016-03-12 17:59:45 +00:00
Barbara Borges Ribeiro
cccf219cd2
simplified alignment vector and got rid of an unnecessary variable
2016-03-12 17:55:05 +00:00
Barbara Borges Ribeiro
0896b2f7b8
initialize header_alignments in a clearer way
2016-03-12 17:36:01 +00:00
Barbara Borges Ribeiro
cc406262ac
added spaces after commas in a couple of places where they were missing
2016-03-12 17:23:43 +00:00
Barbara Borges Ribeiro
0f20063eb8
added "$" to regex to make sure we're subbing "</table>" only at the end of the input
2016-03-12 17:04:29 +00:00
Barbara Borges Ribeiro
5f32b165f2
updated createWrapper() per Joe's suggestion, added spaces between the "="
2016-03-12 16:46:59 +00:00
Winston Chang
3cadd1789b
Merge pull request #1130 from dmpe/master
...
update bootstrap to 3.3.6
2016-03-11 16:03:24 -06:00
dmpe
e486778b36
note to news file and upgrade number in R file
2016-03-11 19:21:25 +01:00
Barbara Borges Ribeiro
7fe6453bbb
vectorized form to add format args to classNames
2016-03-11 16:26:07 +00:00
Barbara Borges Ribeiro
9f88d2b6d6
made isNumber() 1000x more elegant
2016-03-11 16:19:29 +00:00
Barbara Borges Ribeiro
8f9d52699d
return NULL instead of the empty string if no data is provided
2016-03-11 16:00:00 +00:00
Barbara Borges Ribeiro
0a774a8c55
"the" changed to "of"
2016-03-11 15:52:05 +00:00
Barbara Borges Ribeiro
d4ced34a11
2nd update to width documentation (copied straight from plotOutput() )
2016-03-11 15:36:14 +00:00
Barbara Borges Ribeiro
85a762a0b9
updated width documentation
2016-03-11 15:34:34 +00:00
dmpe
b255fecc6e
update bootstrap to 3.3.6
...
see https://github.com/rstudio/shiny/issues/1056
2016-03-11 13:23:38 +01:00
Barbara Borges Ribeiro
734d2e2594
latex bug in documentation (but shouldn't this be allowed?)
2016-03-11 10:58:18 +00:00
Barbara Borges Ribeiro
2e292b4636
commenting and documenting
2016-03-11 10:44:02 +00:00
Barbara Borges Ribeiro
f0bc7356ac
made sure theader is only present the argument colnames is set to TRUE
2016-03-10 23:34:53 +00:00
Winston Chang
1bcb6ab931
Add note about grunt clean
2016-03-10 11:08:15 -06:00
Barbara Borges Ribeiro
ef65937662
replaced format argument with 4 flags (striped, bordered, hover, condensed) and made headers look like bootstrap's
2016-03-09 22:54:11 +00:00
Barbara Borges Ribeiro
3369b8b5b2
finally got headers to align nicely with columns
2016-03-09 01:44:23 +00:00
Winston Chang
28db561cd9
Bump version to 0.13.1.9001 and update NEWS
2016-03-08 17:03:55 -06:00
Winston Chang
0622326e1b
Merge pull request #1126 from rstudio/commas
...
Add code diagnostics for missing/extra commas, and for unmatched }, ), and ]
2016-03-08 17:01:36 -06:00
Winston Chang
c6e2593e4e
Streamline diagnoseCode
2016-03-08 16:54:28 -06:00
Barbara Borges Ribeiro
d0e3279a67
aesthethics
2016-03-08 17:00:42 +00:00
Winston Chang
aee5bda9ec
Add workaround for quartz res bug
...
The quartz device is hard-coded to use 72 ppi in some places, and this
causes problems with grid unit calculations when a value other than 72
is used.
2016-03-08 09:54:01 -06:00
Barbara Borges Ribeiro
979b4a8861
used row.names() function instead of rownames() to avoid naming conflicts
2016-03-07 12:56:00 +00:00
Barbara Borges Ribeiro
c10cd4b474
removed unnecessary css, and garbage collection for renderBootstrapTable
2016-03-07 12:33:43 +00:00
Barbara Borges Ribeiro
4aa1d19845
replaced renderTable with renderBootstrapTable (but kept name renderTable) and ensured backward compatibility
2016-03-07 12:29:43 +00:00
Barbara Borges Ribeiro
7ff51d89fc
check if rownames are numbers or strings
2016-03-07 12:21:39 +00:00
Winston Chang
ea9d94e42f
Add code diagnostics (missing/extra commas)
2016-03-04 15:11:34 -06:00
Barbara Borges Ribeiro
a9ba0fdb0b
added arguments, minimal functional code
2016-03-04 15:13:07 +00:00
Barbara Borges Ribeiro
af19c3331c
added more function arguments
2016-03-04 00:01:09 +00:00
Winston Chang
5e98b930ee
Move tests from inst/ to tests/
2016-03-03 15:00:51 -06:00
Barbara Borges Ribeiro
057d160392
changes to make function compatible with table demo app
2016-03-03 15:54:59 +00:00
Barbara Borges Ribeiro
6b2899c219
fixed small width bug
2016-03-02 15:22:16 +00:00
Barbara Borges Ribeiro
85290e687c
added customizable width
2016-03-02 15:05:50 +00:00
Barbara Borges Ribeiro
d778e81f42
aesthetic changes
2016-03-02 14:03:56 +00:00
Barbara Borges Ribeiro
2bfad21604
added renderBootstrapTable
2016-03-01 15:55:58 +00:00
Winston Chang
373e0d3a9f
Fix NEWS after weird merge
2016-02-22 11:37:30 -06:00
Joe Cheng
5e83403d0c
Update NEWS
2016-02-22 09:30:22 -08:00
Winston Chang
cbe76aab83
Merge pull request #1117 from rstudio/joe/feature/abort-output
...
Add ability to abort the processing of outputs
2016-02-22 11:20:17 -06:00
Joe Cheng
26de088520
s/abortOutput/cancelOutput/; add req option
2016-02-22 09:12:30 -08:00
Winston Chang
98430edb17
Merge branch 'replay-plot'
2016-02-19 13:57:38 -06:00
Winston Chang
48c6784e51
Change 'replay' option to 'execOnResize'
2016-02-19 13:52:36 -06:00
Winston Chang
dc0f5af3ef
Rename 'render' to 'plotObj'
2016-02-19 13:42:54 -06:00
Winston Chang
af85e6f2a6
Merge pull request #1116 from yihui/warn-non-UTF8
...
Closes #810 : check if the input file is encoded in UTF-8 and warn if not
2016-02-19 10:00:49 -06:00
Joe Cheng
4e91af4d64
Add ability to abort the processing of outputs
...
abortOutput() leaves the state of the output unchanged,
unlike req(), validate(), or stop().
2016-02-19 00:33:10 -08:00
Yihui Xie
faf87a5dee
Closes #810 : check if the input file is encoded in UTF-8 and warn if not
...
The validUTF8() function is still in R-devel, and they probably will never export it, so let's use iconv(x, from = 'UTF-8', to = 'UTF-8') to test if x is encoded in UTF-8
also closes #1113
2016-02-19 00:02:25 -06:00
Winston Chang
517c5d356f
Merge tag 'v0.13.1'
...
Manually bumped version to 0.13.1.9000.
2016-02-18 12:45:00 -06:00
Winston Chang
931be22247
Bump version to 0.13.1
2016-02-17 12:03:55 -06:00
Joe Cheng
8697360eb7
Really fix docs.
2016-02-17 11:46:02 -06:00
Joe Cheng
e3a867132a
Use parent.frame() instead of sys.parent()
2016-02-17 11:45:48 -06:00
Joe Cheng
c96debadc5
Fix docs/check
2016-02-17 11:45:16 -06:00
Joe Cheng
02520d4f54
Pass tests. reactive(function() { ... }) is NO LONGER supported.
2016-02-17 11:45:10 -06:00
Joe Cheng
5070b63d5b
Partial fix of debugger breakage
...
There are two problems I'm trying to solve here.
1) Somewhere along the way, exprToFunction gained a hardcoded
assumption that two stack frames up is a variable "expr",
meaning anything that called installExprFunction had to have
the first argument be exactly "expr". I think I got this
fixed, now the only assumption made by both installExprFunc
and exprToFunc is if they are called with quoted = FALSE,
then the caller is merely passing through code that originated
exactly one more level up the stack frame. If the code is
less than one level up, i.e. an end user is directly passing
code into installExprFunction or exprToFunction, then it won't
work; and if the code is more than one level up (someone is
passing code into function A which passes through to function
B which calls installExprFunction, with quoted = FALSE) then
it also won't work.
2) registerDebugHook calls were broken in various places by the
name/envir registered with the hook being different than the
name/envir through which the function was actually called.
This generally seems fixable by moving the registerDebugHook
call closer to the name/envir that will ultimately be called
(e.g. call registerDebugHook directly from wrapFunctionLabel).
There still seems to be a problem here in that breakpoints in
RStudio are hit but then the IDE automatically runs "n" multiple
times. Also the unit tests don't currently pass, I haven't
investigated that yet.
2016-02-17 11:45:01 -06:00
Joe Cheng
eaa722b10d
Fix flexCol on RStudio Desktop for Win/Linux
...
RStudio Desktop requires the older -webkit vendor-prefixed
flex box properties. I missed the one for flex-direction.
2016-02-17 11:32:47 -06:00
Winston Chang
1bc3c90286
Update NEWS
2016-02-16 14:07:49 -06:00
Winston Chang
afd00edee3
Add replay option
2016-02-16 14:07:49 -06:00
Winston Chang
b712398208
If plot code errors, re-execute on resize
2016-02-16 13:39:11 -06:00
Winston Chang
7586e91b4f
Fix coordmap tests
2016-02-15 16:01:34 -06:00
Winston Chang
9eba82c107
Fix vars
2016-02-15 16:01:15 -06:00
Winston Chang
ccdc219a09
More cleanup
2016-02-15 15:39:05 -06:00
Yihui Xie
60d01e76e9
Merge pull request #1109 from vnijs/master
...
Closes #692
2016-02-13 00:38:06 -06:00
mostly-harmless
b5cfd4152e
Fix for https://github.com/rstudio/shiny/issues/692
2016-02-12 22:15:34 -08:00
Winston Chang
32c4c8ae32
Code cleanup
2016-02-12 15:59:10 -06:00
Winston Chang
bd4c506d22
Implement replayPlot when width/height changes
2016-02-12 13:26:41 -06:00
Winston Chang
476dd7cd56
Collect needed data structures
2016-02-11 14:45:43 -06:00
Winston Chang
8176f84715
Restructure ggplot2 coordmap extraction
2016-02-11 14:25:20 -06:00
Winston Chang
6bd33721d8
Separate rendering code into a reactive
2016-02-11 12:27:16 -06:00
Winston Chang
c9d9671288
More restructuring
2016-02-11 12:25:38 -06:00
Winston Chang
2a821edf5f
Small restructure of renderPlot
2016-02-11 12:25:38 -06:00
Winston Chang
68b85bdc87
Merge branch 'fix-plot-flicker2'
2016-02-11 12:20:45 -06:00
Winston Chang
83cf5907c3
Merge pull request #1072 from rstudio/rm-do-call
...
Remove unneeded do.call
2016-02-11 10:24:47 -06:00
Winston Chang
c912b6547c
Merge pull request #1106 from yihui/travis-cache
...
Set sudo to false explicitly to enable caching
2016-02-11 10:23:08 -06:00
Yihui Xie
bf04b74f87
Set sudo to false explicitly to enable caching
2016-02-10 13:34:24 -06:00
Joe Cheng
9d1e008990
Merge pull request #1099 from rstudio/joe/bugfix/debug-fix
...
Partial fix of debugger breakage
2016-02-10 08:15:59 -08:00
Joe Cheng
d9e5285a3b
Really fix docs.
2016-02-09 16:29:15 -08:00
Joe Cheng
84937b7a0b
Use parent.frame() instead of sys.parent()
2016-02-09 16:29:15 -08:00
Joe Cheng
924b3e16cf
Fix docs/check
2016-02-09 16:29:15 -08:00
Joe Cheng
2a8cf01410
Pass tests. reactive(function() { ... }) is NO LONGER supported.
2016-02-09 16:29:14 -08:00
Joe Cheng
a3a5cfee6c
Partial fix of debugger breakage
...
There are two problems I'm trying to solve here.
1) Somewhere along the way, exprToFunction gained a hardcoded
assumption that two stack frames up is a variable "expr",
meaning anything that called installExprFunction had to have
the first argument be exactly "expr". I think I got this
fixed, now the only assumption made by both installExprFunc
and exprToFunc is if they are called with quoted = FALSE,
then the caller is merely passing through code that originated
exactly one more level up the stack frame. If the code is
less than one level up, i.e. an end user is directly passing
code into installExprFunction or exprToFunction, then it won't
work; and if the code is more than one level up (someone is
passing code into function A which passes through to function
B which calls installExprFunction, with quoted = FALSE) then
it also won't work.
2) registerDebugHook calls were broken in various places by the
name/envir registered with the hook being different than the
name/envir through which the function was actually called.
This generally seems fixable by moving the registerDebugHook
call closer to the name/envir that will ultimately be called
(e.g. call registerDebugHook directly from wrapFunctionLabel).
There still seems to be a problem here in that breakpoints in
RStudio are hit but then the IDE automatically runs "n" multiple
times. Also the unit tests don't currently pass, I haven't
investigated that yet.
2016-02-09 16:29:14 -08:00
Joe Cheng
2c04441591
Merge pull request #1105 from rstudio/travis-update
...
Take advantage of new travis features
2016-02-09 16:28:33 -08:00
Winston Chang
a4eab8e216
Grunt
2016-02-09 16:03:59 -06:00
Winston Chang
189f9589d4
Unset attributes in img that aren't present in new data
2016-02-09 16:02:39 -06:00
Hadley Wickham
880721e0d0
Take advantage of new travis features
...
This will cache package install between checks, which should make it run quite a bit faster - this is what @jimhester's has been working on
2016-02-09 14:02:33 -06:00
Winston Chang
6ab65e2031
Fix plot flickering on Safari and Firefox. Closes #776
...
Previously, a new img tag was added when a new plot was sent, but now it uses
the same img tag and changes the src attribute.
2016-02-09 11:08:25 -06:00
Winston Chang
e871934cfd
Fix package name for Travis
2016-02-06 14:46:51 -06:00
Winston Chang
686390c1f2
Merge pull request #1096 from yihui/bugfix/datatables-warning
...
Fixes #561 : make sure DataTables always gets a correct number of columns of data
2016-02-04 10:12:56 -06:00
Yihui Xie
a8b9fb1708
use the CRAN version of htmltools
2016-02-03 14:02:24 -06:00
Yihui Xie
55d3764169
Fixes #561 : should discard the query when the number of columns in the request is different with the number of columns of the actual data
2016-02-03 10:54:37 -06:00
Winston Chang
cb5bc3d631
Merge pull request #1088 from rstudio/joe/bugfix/flexcol
...
Fix flexCol on RStudio Desktop for Win/Linux
2016-01-20 12:12:51 -06:00
Joe Cheng
543e66eb00
Fix flexCol on RStudio Desktop for Win/Linux
...
RStudio Desktop requires the older -webkit vendor-prefixed
flex box properties. I missed the one for flex-direction.
2016-01-20 09:20:22 -08:00
Winston Chang
b658983fb8
Remove JavaScript events vignette
...
This vignette has been migrated to a Shiny Dev Center article.
2016-01-15 15:30:24 -06:00
Winston Chang
cfb3e42337
Merge pull request #1080 from rstudio/internal-messages
...
Don't use sendCustomMessage for messages internal to Shiny
2016-01-15 12:19:23 -06:00
Winston Chang
36815b5e43
Concat and minify shiny.js
2016-01-15 11:54:10 -06:00
Winston Chang
897e077aca
Convert internal use of sendCustomMessage to sendMessage
2016-01-15 11:53:51 -06:00
Winston Chang
f395960ffa
Add session$sendMessage wrapper function
2016-01-15 11:46:23 -06:00
Winston Chang
fb301717f5
Bump version to 0.13.0.9000
2016-01-14 10:49:08 -06:00
Winston Chang
46da93519f
Bump version to 0.13.0
2016-01-12 13:33:14 -06:00
Winston Chang
ce0f2c51a9
Use explicit namespaces
2016-01-12 13:33:14 -06:00
Winston Chang
04b4b8da4f
Use --run-donttest when checking package
2016-01-12 13:16:18 -06:00
Winston Chang
877d7451dd
Merge pull request #1073 from rstudio/joe/staticdocs-tweaks
...
Tweaks for improved staticdocs rendering
2016-01-12 13:00:07 -06:00
Joe Cheng
7e6a68a2b1
CRAN maintainers prefer \donttest over \dontrun
2016-01-12 10:10:16 -08:00
Joe Cheng
caca515ba0
Tweaks for improved staticdocs rendering
...
- \donttest -> \dontrun, otherwise staticdocs hangs
- Put NS before ns.sep so usage entries are in a better order
2016-01-11 12:20:19 -08:00
Winston Chang
d548b78dee
Remove unneeded do.call
...
It's OK to remove this do.call now that we are using R6 instead of Ref Classes.
2016-01-08 16:19:08 -06:00
Joe Cheng
f2410abc48
Merge remote-tracking branch 'origin/image-attr'
...
Conflicts:
inst/www/shared/shiny.js
inst/www/shared/shiny.js.map
inst/www/shared/shiny.min.js
inst/www/shared/shiny.min.js.map
2016-01-08 10:55:21 -08:00
Joe Cheng
483a7d34c5
Merge pull request #1071 from rstudio/fix-hidden-slider
...
Fix hidden slider
2016-01-08 10:53:00 -08:00
Winston Chang
e872411285
Build and minify shiny.js
2016-01-08 10:00:22 -06:00
Winston Chang
fc7e6bf542
Revert "Simpler fix for updating hidden sliders ( #1010 )"
...
This reverts commit 4e1caee7da .
See https://github.com/rstudio/shiny/issues/1010#issuecomment-169971201
2016-01-08 10:00:05 -06:00
Winston Chang
16d42b6421
Add bootstrapLib to staticdocs index
2016-01-07 13:51:56 -06:00
Winston Chang
2f25d25eec
Use setAttribute() function to set image attributes. Fixes #936
2016-01-06 15:03:18 -06:00
Winston Chang
be1081a4b9
Add note about printing ggplot2 graphics
2016-01-06 14:11:16 -06:00
Joe Cheng
1608b652d7
Fix unnecessary :::
2016-01-05 14:02:16 -08:00
Winston Chang
5dd19a878c
Bump version to 0.2.12.9009
2016-01-05 15:59:19 -06:00
Winston Chang
3314f4b5b8
Update NEWS
2016-01-05 15:59:11 -06:00
Winston Chang
5977e0fe89
Update NEWS
2016-01-05 15:30:59 -06:00
Winston Chang
f477dcba4a
Merge pull request #1068 from rstudio/template-bootstrap
...
Pull out bootstrapLib into separate function
2016-01-05 15:30:32 -06:00
Winston Chang
6c5f0c5379
Pull out bootstrapLib into separate function
2016-01-05 14:57:53 -06:00
Winston Chang
257eb1bed0
Merge pull request #1067 from rstudio/joe/bugfix/module-progress
...
Fix progress for Shiny modules
2016-01-05 11:59:18 -06:00
Joe Cheng
9c4d142c2d
Fix progress for Shiny modules
...
Too-specific class check was being used, interfered with the
"duck typed" session-like objects we use for modules.
2016-01-05 09:41:52 -08:00
Winston Chang
8e89a1f154
Add README file with info about jQuery UI
2016-01-05 11:03:34 -06:00
Winston Chang
b0952c0374
Use jQuery UI build without datepicker. Fixes #1042
2016-01-05 11:03:07 -06:00
Winston Chang
ac95dcb3f2
Fix head content location
2016-01-04 10:52:26 -06:00
Joe Cheng
ce4043f038
Update metadata
2015-12-31 11:07:35 -08:00
Joe Cheng
0d26857e31
Merge pull request #1031 from rstudio/template
...
Use templates from htmltools
2015-12-31 11:03:14 -08:00
Joe Cheng
85bea95f6b
Merge pull request #1029 from rstudio/joe/feature/knit_print.reactive
...
Add knit_print.reactive
2015-12-30 14:31:26 -08:00
Winston Chang
10a46c507f
Merge pull request #1059 from rstudio/joe/bugfix/gadgets
...
Fix stopApp bug, and fix flex box in RStudio
2015-12-30 09:38:24 -06:00
Joe Cheng
d35d76e1d0
Use flex box layout vendor prefixes
...
This fixes fillRow/fillCol for RStudio on Windows and Linux
2015-12-29 15:59:04 -08:00
Joe Cheng
aaa05b22df
Return stopApp value without visibility info
2015-12-29 15:57:23 -08:00
Winston Chang
c5fa30f0de
Make encoding tests work cleanly on different platforms
2015-12-29 15:41:49 -06:00
Joe Cheng
43fe1a9a0e
Merge pull request #1057 from rstudio/joe/feature/gadget-cancel
...
runGadget automatically handles cancel button
2015-12-28 14:18:17 -08:00
Joe Cheng
aa296fcb69
Don't show call when user cancels gadget
2015-12-28 13:56:01 -08:00
Joe Cheng
b9c7023489
Refactor server function arg matching
2015-12-28 12:43:06 -08:00
Joe Cheng
efcd286039
Code review feedback
2015-12-28 11:56:13 -08:00
Joe Cheng
98014f9495
Code review feedback
2015-12-28 11:53:52 -08:00
Joe Cheng
2702a18ea2
Add stopApp test
2015-12-28 11:18:15 -08:00
Joe Cheng
4a8da3e1e2
runGadget handles cancel automatically (by default)
2015-12-27 23:46:47 -08:00
Joe Cheng
cfe38c00f3
Proper visibility and error handling from stopApp
2015-12-27 23:35:09 -08:00
Joe Cheng
af0463ed46
Update metadata
2015-12-23 17:47:24 -08:00
Joe Cheng
c02f4691e0
Merge pull request #1054 from rstudio/joe/feature/runGadget
...
Migrate runGadget and viewer functions from shinygadgets
2015-12-23 17:45:12 -08:00
Joe Cheng
5d89393fff
Merge pull request #1039 from rstudio/joe/feature/fillPage
...
Add fillPage, flexRow, flexCol
2015-12-23 17:44:56 -08:00
Joe Cheng
e7ce28204b
Remove dependency on newer htmltools
...
The css function is in htmltools 0.2.11, which isn't on CRAN
yet. Due to a perfect storm of release scheduling we need to
get fillPage onto shiny master before we have a chance to
put htmltools on CRAN.
2015-12-23 17:32:46 -08:00
Joe Cheng
8fc4a75e8c
Specify remote repo for htmltools
...
Makes devtools install easier
2015-12-23 17:31:11 -08:00
Joe Cheng
26c89a09e8
Update staticdocs index
2015-12-23 17:31:11 -08:00
Joe Cheng
25a1493520
Add details to fillRow doc about containers
2015-12-23 17:31:10 -08:00
Joe Cheng
b18722f776
flex:none is more appropriate than flex:initial for weight=NA
2015-12-23 17:31:10 -08:00
Joe Cheng
3f3fd9ae21
Install htmltools from github until 0.2.11 goes to cran
2015-12-23 17:31:10 -08:00
Joe Cheng
94ea3c7dab
Require htmltools 0.2.11
2015-12-23 17:31:10 -08:00
Joe Cheng
6c2fea7926
Rename flexRow/flexCol to fillRow/fillCol, other tweaks
...
I decided against the name flexRow/flexCol as the "flex" prefix
is too general for these implementations, which are mostly just
useful for filling the space with the children. Flex box has a
lot more features than that, such as centering, wrapping,
justifying, etc., but I don't currently know how to design an
API that presents the full power of flex box without also
presenting the full complexity of it as well.
This commit also includes some tweaks to the impl of flexfill
to fix the behavior of children with 100% size along the main
axis, and also introduces support for NA flex values, which
sizes the flex item according to its contents.
2015-12-23 17:31:10 -08:00
Joe Cheng
e08fd47b0e
Add fillPage, flexRow, flexCol
2015-12-23 17:31:05 -08:00
Joe Cheng
0fd76e8768
Migrate runGadget and viewer functions from shinygadgets
2015-12-23 15:33:30 -08:00
Joe Cheng
72aaf3055a
Update NEWS
2015-12-23 11:46:03 -08:00
Winston Chang
94a943a68c
Merge pull request #1052 from rstudio/joe/font-awesome-4.5.0
...
Upgrade Font Awesome to 4.5.0
2015-12-23 13:08:27 -06:00
Joe Cheng
e867dcfdb1
Upgrade Font Awesome to 4.5.0
2015-12-23 11:03:33 -08:00
Joe Cheng
9a22a89b06
Add docs
2015-12-23 09:42:29 -08:00
Joe Cheng
791e8200bc
Install htmltools from github until 0.2.11 goes to cran
2015-12-22 14:06:51 -08:00
Joe Cheng
d96217d49a
Merge pull request #1049 from rstudio/joe/bugfix/http-iframe-stampede
...
Defer subapp iframe loading
2015-12-22 12:26:49 -08:00
Joe Cheng
6bfd65aa19
Guard against window.Shiny not being defined
2015-12-22 11:53:36 -08:00
Joe Cheng
2da9bc07ac
Defer subapp iframe loading until main app has loaded
...
Fixes #1047 defer loading of iframes
2015-12-22 11:14:12 -08:00
Joe Cheng
6d7a562b7a
Fix staticdocs
...
Without this fix, current version of staticdocs won't pull plotOutput
into the index page.
2015-12-21 11:57:01 -08:00
Joe Cheng
0aa1dfb8e1
Merge pull request #1032 from yihui/yihui/encoding-tests
...
Add some tests for character encodings
2015-12-17 13:36:26 -08:00
Winston Chang
e9e7dc298f
Merge pull request #1037 from rstudio/joe/feature/req
...
Add `req` function for validating required inputs/values
2015-12-17 14:39:40 -06:00
Joe Cheng
ed3b71e396
Remove unnecessary environment() call
2015-12-17 11:58:17 -08:00
Joe Cheng
3450a037a9
Further simplification and more tests for req()
2015-12-17 11:29:54 -08:00
Joe Cheng
f57626d256
req() simplification
2015-12-17 11:16:09 -08:00
Joe Cheng
c1c3fa4d3a
Fix a couple of req edge cases
2015-12-17 11:13:33 -08:00
Joe Cheng
300433f7de
req() now short-circuits on falsy values
2015-12-17 10:53:13 -08:00
Joe Cheng
eee6f4ed81
Add req function for validating required inputs/values
2015-12-16 10:04:05 -08:00
Joe Cheng
2eb29bd8aa
Merge pull request #1034 from rstudio/fix-hidden-slider
...
Simpler fix for updating hidden sliders (#1010 )
2015-12-15 15:57:11 -08:00
Joe Cheng
3a0ce86f51
Remove unnecessary check (feedback from @wch)
2015-12-15 15:36:43 -08:00
Joe Cheng
6041b8cbb2
Roxygenize
2015-12-14 18:00:29 -08:00
Joe Cheng
3ba8fcb7b8
Merge pull request #1036 from rstudio/joe/bugfix/validation-error-behavior
...
Fix validation error handling
2015-12-14 17:16:04 -08:00
Joe Cheng
f74d9c93a2
Merge pull request #1035 from rstudio/joe/bugfix/multiline-label
...
Fix warnings when renderXXX is called with explicit namespace
2015-12-14 17:15:50 -08:00
Joe Cheng
739c162281
Fix warnings when renderXXX is called with explicit namespace
...
Calling shiny::renderText(...) instead of renderText(...) would
cause warnings.
2015-12-14 17:11:40 -08:00
Joe Cheng
a2700c900d
Fix validation error handling
...
Validation errors were behaving too much like real errors: they were
being printed with stack traces, and passed to the options(shiny.error)
function. Also, if a reactive() cached a validation error, on future
calls the error would be re-raised (which is correct) without the
custom class names attached (which is not).
2015-12-14 16:31:57 -08:00
Winston Chang
4e1caee7da
Simpler fix for updating hidden sliders ( #1010 )
...
This also reverts the previous fix, #1026
2015-12-10 15:49:23 -06:00
Yihui Xie
76a54249bb
Add some tests for character encodings
2015-12-10 15:23:31 -06:00
Winston Chang
0e894cb043
Use templates from htmltools
2015-12-10 15:11:03 -06:00
Winston Chang
01bbee59eb
Merge pull request #1023 from yihui/bugfix/1018
...
Fixes #1018 : make sure the selected value is always returned from sever-side selectize
2015-12-10 13:44:24 -06:00
Joe Cheng
26a0c3520c
Add knit_print.reactive
...
Allows us to drop reactive expressions right into Rmd docs
with runtime:shiny and have them stay up-to-date.
2015-12-09 16:34:55 -08:00
Yihui Xie
6056c35de3
add a news item, and run grunt
2015-12-09 11:56:13 -06:00
Yihui Xie
4202991ca5
Fixes #1018 : make sure the selected value is always returned from server-side selectize
2015-12-09 11:52:50 -06:00
Joe Cheng
788931c7c7
Merge pull request #1027 from yihui/yihui/srcfilecopy
...
Check R version at runtime (#968 )
2015-12-09 09:48:59 -08:00
Yihui Xie
b2d0505c7c
Check R version at runtime ( #968 )
2015-12-08 20:33:52 -06:00
Winston Chang
8b710d651f
Merge pull request #1026 from rstudio/joe/bugfix/hidden-slider-update
...
Fix #1010 : updateSliderInput doesn't update hidden sliders
2015-12-08 19:50:12 -06:00
Joe Cheng
93697bb01d
Merge pull request #1025 from yihui/bugfix/source-utf8
...
Fixes #1003 : correctly parse source code that can be represented with native encoding
2015-12-08 15:51:51 -08:00
Joe Cheng
89cd58e4f8
Fix #1010 : updateSliderInput doesn't update hidden sliders
2015-12-08 11:13:18 -08:00
Yihui Xie
a622f029a0
Fixes #1003 : when the source code can be represented via the native encoding on Windows, rewrite the code to a temporary file with the native encoding and parse it
2015-12-07 16:28:45 -06:00
Winston Chang
97afb52904
Re-document with Roxygen2 5.0.1
2015-12-02 15:43:25 -06:00
Joe Cheng
02ea31be08
Fix #1020 : Graphics are cut off
2015-12-01 13:47:26 -08:00
david.zotloeterer
d1353e8eae
fixed custom message obj
2015-12-01 13:36:32 +01:00
david.zotloeterer
935a76d16b
cleanup
2015-12-01 13:29:41 +01:00
david.zotloeterer
db4c41f420
grunted
2015-12-01 12:59:48 +01:00
david.zotloeterer
62f5af8e0b
fixed typo
2015-12-01 12:42:05 +01:00
david.zotloeterer
ff9aefb649
more tagging
2015-12-01 12:39:41 +01:00
david.zotloeterer
2b10d03e1f
added binary tags
2015-12-01 12:11:44 +01:00
david.zotloeterer
a27efbd937
added binary messages, yes, ws can do dat!
2015-12-01 12:03:07 +01:00
Joe Cheng
b5e49a6619
Fix bugs reported by @daattali
...
- reactive srcrefToLabel call fails if code is pasted in at RStudio console
- Stack trace fails when promise (!?) is in call stack
2015-11-24 11:55:08 -08:00
Joe Cheng
179c931f85
Bump version
2015-11-23 10:58:30 -08:00
Joe Cheng
4d3fa2c8ac
Merge pull request #1011 from rstudio/joe/feature/better-errors
...
Better errors
2015-11-20 12:56:24 -08:00
Joe Cheng
8e4f7387d0
Better stack traces for observeEvent and eventReactive
2015-11-16 13:10:53 -08:00
Joe Cheng
feb630b2c5
Catch errors when trying to print stack trace
...
No known errors will occur when printing the stack trace, but since
this is fairly complicated code executing when an error has already
happened, better to be on the defensive.
2015-11-16 13:08:34 -08:00
Joe Cheng
948dfbb56b
More tests
2015-11-16 12:50:20 -08:00
Joe Cheng
5c3ac75b34
Errors in ui function should get stack traces
2015-11-16 12:46:22 -08:00
Joe Cheng
adc5c8e37a
Normalize shiny dir in smoketest stack traces
2015-11-16 12:45:59 -08:00
Joe Cheng
52d594c143
Quick and dirty smoke test infrastructure
2015-11-16 12:29:02 -08:00
Joe Cheng
1018b0d966
Errors in ui.R, server.R, server func, etc. all get stack traces
2015-11-16 10:48:16 -08:00
Joe Cheng
0ce153d788
Doc updates
...
Code had to be rearranged to make the functions show up in the
help docs in the right order
2015-11-14 00:26:23 -08:00
Joe Cheng
ff9756c739
Add more exports, tests
2015-11-14 00:17:19 -08:00
Joe Cheng
b3dd7e5397
Remove support for shiny.observer.error option
...
It is dangerous to set this on a per-process basis. If we even
still want the ability to have observer errors not kill the
session (debatable) we should do so by having an option on the
session object that is set when the shiny server function runs.
Not only does this remove support for the option, but now we
will refuse to connect and will abort the session if the option
is set to a non-NULL value. This is to prevent apps from moving
forward with the assumption that their option will work, when
it really won't. (I doubt anyone is using it anyway, it's so
obscure...)
2015-11-13 18:13:14 -08:00
Joe Cheng
6ac0a80896
Update NEWS with stack trace announcement
2015-11-13 17:58:18 -08:00
Joe Cheng
93f774c7e7
Add exports/docs
2015-11-13 17:52:26 -08:00
Joe Cheng
661c08549d
Automatically wrap installExprFunction with function labels
...
This lowers the burden on renderXXX functions having nice stack traces
2015-11-13 16:43:15 -08:00
Joe Cheng
c8acc44012
Add comments to stacktraceon/off directives indicating their partners
2015-11-13 16:25:22 -08:00
Joe Cheng
aabf00659e
Random improvements to stack traces
...
- More selective removal of frames at end of call stack
- Add withLogErrors, printError, stripStackTrace convenience funcs
- Properly capture/log errors for various levels of unhandled errors
- Unhide stacks for flush/flushed/sessionended callbacks
2015-11-13 16:03:18 -08:00
Joe Cheng
a9bc41492c
Collapse stack trace to eliminate irrelevant bits
2015-11-13 12:36:55 -08:00
Winston Chang
12b0484e9a
Merge pull request #875 from wch/rendertable-args
...
Separate xtable from print.xtable args. Closes #761
2015-11-13 11:48:41 -06:00
Joe Cheng
d3605dbcb3
Collapse parts of the stack
2015-11-12 16:40:56 -08:00
Joe Cheng
d9a016f94c
Move error-handling logic into conditions.R
2015-11-11 16:20:26 -08:00
Joe Cheng
a13657ac23
Work properly with non-call sys.call() objects
2015-11-11 15:54:03 -08:00
Joe Cheng
d6c95a9e89
wip
2015-11-11 12:14:42 -08:00
Winston Chang
825e9e04c1
Get xtable args using formals()
2015-11-05 13:04:43 -06:00
Winston Chang
c596e44c5a
Separate xtable from print.xtable args. Closes #761
2015-11-05 13:01:01 -06:00
Winston Chang
66be9004fe
Move renderTable to separate file
2015-11-05 12:59:04 -06:00
Winston Chang
119ebb0f07
Merge pull request #1005 from rstudio/joe/bootstrap-3.3.5
...
Upgrade bootstrap to 3.3.5
2015-11-05 12:43:34 -06:00
Joe Cheng
d509fcac29
Merge pull request #1004 from rstudio/joe/feature/autoreload
...
Implement autoreload
2015-11-05 10:43:13 -08:00
Joe Cheng
c79e933586
Merge pull request #1002 from rstudio/joe/bugfix/nested-scopes
...
Fix nested scopes
2015-11-05 10:32:23 -08:00
Joe Cheng
3c3cfc02a0
Merge pull request #997 from wch/download-fix
...
Update download to work correctly with R 3.2.2 on Mac. Fixes #996
2015-11-05 10:27:51 -08:00
Joe Cheng
e32de7b940
Update bootstrap htmlDependency version
2015-11-05 07:38:00 -08:00
Joe Cheng
d7b1759afb
Upgrade bootstrap to 3.3.5
2015-11-04 22:56:31 -08:00
Joe Cheng
e391c1fda3
Implement autoreload
2015-11-04 13:44:38 -08:00
Joe Cheng
46d8d3b469
Fix nested scopes
...
The session$makeScope function was not correctly taking the session's
own namespace into account (i.e. all makeScope() method calls were
being performed against the root session).
2015-11-03 12:33:39 -08:00
Joe Cheng
9fde7509fa
Merge pull request #1000 from rstudio/joe/feature/invalidatelater-default-session
...
Don't require session to be explicitly passed to invalidateLater
2015-11-02 16:21:43 -08:00
Joe Cheng
a767a61f43
Don't require session to be explicitly passed to invalidateLater
...
These functions were created before getDefaultReactiveDomain()
existed, so the only way to get ahold of the current session was
if the caller explicitly passed it.
This is slightly backwards incompatible, in that existing calls
to invalidateLater() that don't pass a session argument will
behave slightly differently (bound to the current session instead
of to no session), but those calls would have triggered a warning
for all but the very earliest versions of Shiny.
2015-11-02 14:19:29 -08:00
Joe Cheng
ad28e03536
Merge pull request #999 from yihui/bugfix/ie9-upload
...
Fixes #990 : revert to checking if FileList is supported by the browser
2015-11-02 11:13:57 -08:00
Yihui Xie
5f9e9c2e03
grunt
2015-11-02 12:21:56 -06:00
Yihui Xie
2be6d7a65c
Fixes #990 : revert to checking if FileList is supported by the browser, instead of checking IE8 literally (partially reverted a41e1dafc2)
2015-11-02 12:21:30 -06:00
Winston Chang
712c4cb985
Update download to work correctly with R 3.2.2 on Mac. Fixes #996
2015-10-30 12:08:48 -05:00
Winston Chang
7948a0a4fa
Merge pull request #993 from rstudio/joe/feature/reactlog-labels
...
Cleaner reactlog labels for reactives and outputs
2015-10-30 11:57:57 -05:00
Joe Cheng
ce9e95f256
Fix parseQueryString example (thanks Chris Beeley)
2015-10-29 16:15:47 -07:00
Joe Cheng
7ed5ca94a2
reactlog label code review feedback
...
- Don't clobber explicitly-provided label
- Let `reactives$x1 <- reactive(...)` work
2015-10-29 10:27:06 -07:00
Winston Chang
e635589c52
Merge pull request #992 from rstudio/joe/feature/reactlog-time
...
Add timing data to reactlog entries
2015-10-29 10:06:08 -05:00
Joe Cheng
490721437f
Merge pull request #994 from RCura/patch-1
...
Correct a regression within modules
2015-10-28 18:23:36 -07:00
Robin Cura
7e25a1566f
Correct a regression within modules
...
Commit 07f2792cf9 introduced an error, replacing `e$parent = parentSession` with `e$parent <= parentSession`, while it should have been `e$parent <- parentSession`
2015-10-29 02:03:12 +01:00
Joe Cheng
c08b3b0c30
Update metadata
2015-10-28 15:30:07 -07:00
Joe Cheng
f1de132a2a
Merge pull request #988 from rstudio/joe/feature/namespaces
...
Shiny modules
2015-10-28 15:22:57 -07:00
Joe Cheng
c440c60bdf
Cleaner reactlog labels for reactives and outputs
...
Instead of showing the code, try to just show the name
of the reactive/output. Uses a fairly flaky algorithm
for determining the name of the reactive; will only
work in cases where the definition of the reactive
begins with "foo <- reactive({".
2015-10-28 14:37:00 -07:00
Joe Cheng
c367176a17
Add timing data to reactlog entries
2015-10-28 13:49:39 -07:00
Joe Cheng
3d13c39a4c
Also override registerDataObj (essential for data table, DT, and selectize server mode)
2015-10-27 16:33:46 -07:00
Joe Cheng
07f2792cf9
Change evil = to righteous <-
2015-10-27 15:01:44 -07:00
Joe Cheng
303fce5f15
Merge pull request #983 from wch/clear-checkbox
...
updateCheckboxGroup: allow clearing all choices. Fixes #981
2015-10-27 15:00:20 -07:00
Joe Cheng
46c8bfdd34
Merge pull request #979 from wch/profiling-enhancements
...
Enhancements to help profiling
2015-10-27 14:59:59 -07:00
Winston Chang
c36a22ad5e
Add information about clearing choices
2015-10-23 16:04:17 -05:00
Winston Chang
49eba95a9c
Simplify function naming
2015-10-23 15:48:33 -05:00
Winston Chang
2dacc6ce40
Use cleaner method for generating function
2015-10-23 15:44:24 -05:00
Winston Chang
5ccf02f5c3
Merge pull request #984 from rstudio/update-jquery
...
Update to jQuery 1.11.3 and jQuery UI 1.11.4
2015-10-23 15:08:27 -05:00
Joe Cheng
86c67de8ff
Add session$ns(); some light refactoring; add tests; fix staticdocs
2015-10-20 23:49:24 -07:00
Joe Cheng
dac7eb5997
Simplify modules, by removing moduleUI and path arguments
2015-10-20 15:12:11 -07:00
Winston Chang
fd725552a5
Update to jQuery UI 1.11.4
2015-10-19 13:44:23 -05:00
Winston Chang
1e1a897970
Update to jQuery 1.11.3
2015-10-19 13:31:44 -05:00
Joe Cheng
59a643c006
Update metadata
2015-10-16 10:24:05 -07:00
Joe Cheng
1a492208e6
Merge pull request #982 from rstudio/feature/single-file-runapp
...
Let runApp accept single .R file parameters
2015-10-16 10:16:29 -07:00
Winston Chang
bc0a19f55d
updateCheckboxGroup: allow clearing all choices. Fixes #981
2015-10-16 11:44:09 -05:00
Jonathan McPherson
85e2e00bc4
let runApp accept single .R file parameters
2015-10-16 09:22:44 -07:00
Joe Cheng
93dd8bbf28
Merge pull request #980 from rstudio/joe/bugfix/select-value-escaping
...
Fix improperly escaped quote chars in select choices
2015-10-15 12:56:54 -07:00
Joe Cheng
2f15a219df
Fix improperly escaped quote chars in select choices
2015-10-15 12:49:50 -07:00
Yihui Xie
4fc73b1344
A news item for #968
2015-10-15 13:45:00 -05:00
Joe Cheng
48b56ba08d
Merge pull request #968 from yihui/bugfix/961-unicode
...
A more fundamental fix to the Unicode issue
2015-10-15 11:17:45 -07:00
Joe Cheng
94ca733c7c
Merge pull request #967 from rstudio/joe/bugfix/placeholder
...
Add placeholder parameter to textInput
2015-10-15 11:15:10 -07:00
Winston Chang
4af2436a0e
Rename 'func' to more descriptive name
2015-10-14 16:40:33 -05:00
Winston Chang
20c2bb9d50
Simplify try(tryCatch()) to just tryCatch()
...
This also has the benefit of printing a more helpful error message at
the console. It now indicates which output an error occurred in.
2015-10-14 16:40:33 -05:00
Winston Chang
33bac0db3c
Add function relabeler and relabel outputs
2015-10-14 16:40:33 -05:00
Winston Chang
8893db9098
Update NEWS
2015-10-12 22:39:51 -05:00
Winston Chang
c46658a5c8
Correctly handle unit and unit.list objects. Closes #962
2015-10-12 22:31:32 -05:00
Joe Cheng
5f651aed3e
LICENSE typo
2015-10-12 12:32:00 -04:00
Joe Cheng
534bc9c6e2
Pass tests
2015-10-05 15:15:54 -04:00
Joe Cheng
bb09885237
Add callModule/moduleUI functions; scope sendInputMessage
2015-10-05 14:56:01 -04:00
Joe Cheng
3ff6aaa6db
Add namespacing functionality
...
- Need to carefully review ShinySession, think about
each and every public method and whether it should
be passthrough or do something different for a
namespaced session.
- It would be nice if we do the namespace splitting
at the server.R level and actually have numerous
reactivevalues objects for inputs, one for each
namespace. This will make the reactive hooks for
names() and reactiveValuesToList() correct, as
right now they will oversubscribe if you're in a
namespaced session. Also it would prevent outer
sessions from seeing the values of their child
namespaces. (Though is that good or bad...?)
2015-10-02 12:51:18 -07:00
Joe Cheng
fa7c034d16
Merge pull request #955 from rstudio/joe/feature/reactlog-bysession
...
Fix couple of issues with reactlog
2015-09-24 09:54:35 -07:00
Joe Cheng
ca870ccd75
Merge pull request #966 from rstudio/joe/bugfix/showcase-highlighting
...
Fix highlighting of reactives in showcase mode
2015-09-24 09:54:01 -07:00
Yihui Xie
89fe2ff217
a more fundamental fix of the Unicode issue
...
for R <= 3.2.2, Unicode chars don't work for shiny mainly because we want to
preserve the source reference, and unfortunately srcfilecopy() fails because of
the bug https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=16264
here I use lines = '' to get around the bug, and assign the source lines to
the srcfile object later, so there is no grep("\n", multibyte_chars) occuring
I also replaced source() with a custom version, which is much simpler and works
better with Unicode chars
2015-09-23 23:00:20 -05:00
Joe Cheng
6c6775376e
Add placeholder parameter to textInput
2015-09-23 18:28:08 -07:00
Yihui Xie
bd3b3881d8
after reading a file as UTF-8, try to convert it to native encoding on Windows only if the conversion is not lossy
2015-09-23 18:33:01 -05:00
Yihui Xie
078189599c
the check is.na(iconv(x, 'UTF-8')) does not really make sense
...
e.g. iconv('\u2264', 'UTF-8') converts the smaller than or equal sign to an
equal sign in the English (US) locale, which is lossy
we just assume the input is UTF-8 instead, and do not fall back to native
encoding any more
2015-09-23 18:31:16 -05:00
Yihui Xie
9afcd2a411
don't declare encoding on the anonymouse file connection
...
otherwise writeLines(useBytes = TRUE) may not work (#961 )
2015-09-22 01:11:38 -05:00
Yihui Xie
0afd1649c1
textConnection() can be lossy; use an anonymous file connection instead to preserve UTF-8 characters
2015-09-22 01:11:37 -05:00
Yihui Xie
0947a63103
make sure writeLines() does not convert text to native encoding
2015-09-22 01:11:32 -05:00
Yihui Xie
79223bddc5
make sure the UI HTML is rendered into a connection with UTF-8 encoding
2015-09-21 22:25:12 -05:00
Yihui Xie
1871dd6b71
convert the result of readLines() to UTF-8 using enc2utf8() instead, since enc2native() can be lossy
2015-09-21 21:49:12 -05:00
Yihui Xie
4adc3088d1
fixes #961 : the JSON string from jsonlite::toJSON() is always encoded in UTF-8, so there is no need to re-encode it
...
actually re-encoding the string with native encoding can be lossy (some UTF-8 characters may not be representable in the native encoding)
2015-09-21 21:46:11 -05:00
Yihui Xie
79dd7e1bf5
shiny requires R >= 3.0.0
2015-09-21 21:44:03 -05:00
Joe Cheng
6718d377bb
Fix and enhance reactlog
...
* Reactlog shortcut was broken due to reactlog.js not being included in
the gruntfile
* Reactlog has always shown every reactive event since the beginning of
the process (or at least since options(shiny.reactlog=TRUE)). This
commit makes it so Ctrl+F3 invocation only shows reactives that either
belong to no session (e.g. observers and reactives declared at the top
of server.R), or belong to this session.
2015-09-13 02:46:52 -07:00
Joe Cheng
d4e3329d7a
Fix highlighting of reactives in showcase mode
...
This has been broken since we switched to jsonlite. Reactives
don't highlight because their srcref is in an S3(?) class that
jsonlite doesn't recognize, whereas RJSONIO would treat it as
a numeric vector.
2015-09-12 20:20:13 -07:00
Joe Cheng
99295f0983
Bump version, update NEWS
2015-09-09 22:13:45 -07:00
Winston Chang
3606c36cb9
Merge pull request #950 from rstudio/joe/feature/grunt-clean
...
Add 'grunt clean' to delete shiny build artifacts
2015-09-09 15:49:02 -05:00
Winston Chang
3d5c184acc
Merge pull request #949 from rstudio/joe/feature/shared-brush-id
...
Allow shared brush IDs
2015-09-09 15:48:43 -05:00
Joe Cheng
9e03b17498
Add 'grunt clean' to delete shiny build artifacts
2015-09-09 12:19:43 -07:00
Joe Cheng
129714b044
Allow shared brush IDs
2015-09-09 12:12:47 -07:00
Joe Cheng
67823556d2
Merge pull request #939 from yihui/bugfix/selectize-selected
...
Fixes #929 : defer setValue() for selectize until the options have been loaded from server
2015-09-09 12:10:03 -07:00
Yihui Xie
273e71e3c4
run grunt
2015-09-09 13:38:51 -05:00
Yihui Xie
076ac26929
call setValue() only once
...
otherwise every time an Ajax response is returned (e.g. during searching), the value is set to data.value
2015-09-09 13:29:37 -05:00
Yihui Xie
5a022b0a2c
upgrade selectize.js from 0.11.2 to 0.12.1 to fix the ordering issue in #929
...
also fixes #865
2015-09-09 13:29:37 -05:00
Yihui Xie
9ab493a81f
make sure mop is numeric
...
it is funny that head(1:11,'100') produces a bunch of NA's, but head(1:11,'12') does not
2015-09-09 13:29:37 -05:00
Yihui Xie
dfc1f32595
Fixes #929 : defer setValue() for selectize until the options have been loaded from server
...
Previously I was using a hack to set the selected value of selectize, i.e. add the selected option(s) to selectize via addOptions() (because the selected option(s) may not have existed); this hack can be removed and we can set the value in the `success` callback of the Ajax request, by which time the options will be available
2015-09-09 13:29:37 -05:00
Joe Cheng
e6fd30fb78
Merge pull request #935 from yihui/doc/events-vignette
...
Add a package vignette for the JS events
2015-09-09 10:33:52 -07:00
Joe Cheng
c8d338912a
Merge pull request #918 from rstudio/joe/bugfix/binding-getid
...
Fix #676 : getId(el) not being used in output binding
2015-09-09 10:33:45 -07:00
Winston Chang
d9d9e0b33f
Add info about printing ggplot objects
2015-09-08 15:07:40 -05:00
Yihui Xie
1da7b83956
Bump version
2015-09-04 20:54:30 -05:00
Yihui Xie
29c545d2e3
Bump fontawesome version after #932
2015-09-04 20:53:54 -05:00
Joe Cheng
431b345c82
Fix #676 : getId(el) not being used in output binding
2015-09-04 15:14:04 -07:00
Joe Cheng
8773b1b38f
Merge pull request #946 from yihui/bugfix/recalculating
...
Typo: name -> message.name
2015-09-04 14:53:43 -07:00
Yihui Xie
52efb3dc16
Typo: name -> message.name
2015-09-04 15:43:21 -05:00
Yihui Xie
9ccd179b04
document the rest of events: shiny:conditional, shiny:visualchange, shiny:recalculating, shiny:recalculated
2015-09-04 15:09:34 -05:00
Joe Cheng
a8b35c49a7
Merge pull request #932 from dselivanov/master
...
Bump fontawesome version to 4.4.0, fixes #913
2015-09-04 12:15:31 -07:00
Peter K. Shultz
4e027f1a45
Update README.md
...
Add missing period.
2015-09-04 12:13:28 -07:00
Joe Cheng
119182454b
Merge pull request #943 from yihui/feature/events-more
...
Events shiny:visualchange, shiny:conditional, and shiny:recalculating
2015-09-04 11:34:48 -07:00
Yihui Xie
04e10a4f0d
Run grunt
2015-09-02 12:30:22 -05:00
Yihui Xie
4e5c5f9c5b
Move the shiny:conditional event to the top of $updateConditionals()
2015-09-02 12:29:37 -05:00
Yihui Xie
1ee2a25eca
Trigger the recalculating event on null when the binding does not exist
2015-09-02 12:29:01 -05:00
Yihui Xie
838e132515
Trigger shiny:visualchange in doSendOutputHiddenState() as well. Added a 'visible' property to the event object.
2015-08-31 17:07:11 -05:00
Yihui Xie
da76a843ee
DO not assume '# + message.name' is the element id. Find the element through this.$bindings[name].el instead.
2015-08-31 17:02:14 -05:00
Yihui Xie
b0676b8b31
Trigger shiny:recalculated after the calculation is done
2015-08-31 16:38:46 -05:00
Yihui Xie
83c3656d29
Events shiny:visualchange, shiny:conditional, and shiny:recalculating
2015-08-31 15:58:05 -05:00
Yihui Xie
5ddd6cc94e
add a summary section to the events vignette
2015-08-27 23:21:36 -05:00
Yihui Xie
90419765af
Merge pull request #938 from yihui/bugfix/933
...
Fixes #933 : make sure type is of length one
2015-08-26 11:27:05 -05:00
Yihui Xie
acad9354a6
Fixes #933 : make sure type is of length one
2015-08-26 10:48:38 -05:00
Yihui Xie
9105dd7b04
Add a package vignette for the JS events
2015-08-24 15:25:58 -05:00
Joe Cheng
71adee1f38
Merge pull request #930 from yihui/feature/events
...
More JS events
2015-08-24 12:50:10 -07:00
Yihui Xie
3cbe3831ec
Run grunt
2015-08-21 16:19:02 -05:00
Yihui Xie
619aa4f05a
Events shiny:busy and shiny:idle
...
Keep track of the number of observer callbacks during addPendingFlush() and executeFlushCallbacks(). Send a custom message when the number is 0.
2015-08-21 16:12:45 -05:00
Yihui Xie
4df37d6f3e
The shiny:updateinput event for inputs
2015-08-21 16:10:01 -05:00
Yihui Xie
58f8b482f5
The message object may be exactly false (or a falsy value), in which case shiny will fail to send the message to the handler. Use .hasOwnProperty() instead.
2015-08-21 16:09:25 -05:00
Yihui Xie
168f5e32af
The shiny:message event
2015-08-21 16:08:16 -05:00
Yihui Xie
06bf28f10c
Events shiny:value and shiny:error for outputs
2015-08-21 16:07:33 -05:00
Yihui Xie
620fdc0d9f
The shiny:inputchanged event
2015-08-21 16:06:56 -05:00
Yihui Xie
bdac0e2456
Events shiny:bound and shiny:unbound for inputs and outputs
2015-08-21 16:06:00 -05:00
Dmitry Selivanov
60a57a0a40
Bump fontawesome version to 4.4.0, fixes #913
2015-08-20 12:34:52 +03:00
Yihui Xie
a242ae3849
Merge pull request #920 from yihui/yihui/selectize-dragdrop
...
fixes #902 : add jQueryUI dependency when the drag_drop plugin is used in selectize
2015-08-06 21:46:30 -05:00
Yihui Xie
ced4060b5c
fixes #902 : add jQueryUI dependency when the drag_drop plugin is used in selectize
2015-08-06 16:59:51 -05:00
Winston Chang
0b3eb7a237
Merge tag 'v0.12.2'
...
Shiny 0.12.2
2015-08-05 15:08:21 -05:00