Keeley Hammond
a0e026826c
chore: cherry-pick 1 changes from 1-M137 ( #47355 )
...
* chore: [34-x-y] cherry-pick 1 changes from 1-M137
* 7bc0a67ebfbf from v8
* add patch
---------
Co-authored-by: George Xu <george.xu@slack-corp.com >
2025-06-04 10:17:07 +02:00
trop[bot]
0f92715ddb
ci: add a problem matcher for ESLint output ( #47307 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-02 13:48:23 -04:00
trop[bot]
6099f936a6
fix: Squirrel.Mac crash when zip extraction fails ( #47301 )
...
* fix: Squirrel.Mac crash when zip extraction process fails to launch
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: add end-to-end test
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-30 10:46:33 -04:00
trop[bot]
8da3fcb446
build: migrate to new chromium git auth ( #47252 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-28 10:46:23 +02:00
David Sanders
e9af966b31
chore: update @electron/lint-roller to 3.1.1 ( #47274 )
2025-05-27 16:58:45 -04:00
trop[bot]
6c7b375d79
build: update build tools ( #47281 )
...
* build: update build tools
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: fix core.fscache
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix core.preloadindex
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-27 16:05:41 -04:00
trop[bot]
e7b07b43fd
build: fix depot tool pathing on Windows ( #47194 ) ( #47234 )
...
build: properly set depot_tools pathing for Windows
(cherry picked from commit b2d0074cc6 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-22 13:47:13 -07:00
trop[bot]
a463e05870
ci: add problem matcher for patch conflict output ( #47222 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-22 11:54:13 -07:00
trop[bot]
64bf795d84
ci: add problem matcher for clang output ( #47219 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-22 11:53:26 -07:00
Keeley Hammond
05a6ebd6be
chore: cherry-pick 1 changes from 0-M136 ( #47070 )
...
* chore: [34-x-y] cherry-pick 1 changes from 0-M136
* 22ac8acf3508 from v8
* chore: update patches
2025-05-21 10:32:18 +02:00
Keeley Hammond
a6d4fc4044
chore: cherry-pick 2 changes from 2-M136 ( #47176 )
...
* chore: [34-x-y] cherry-pick 2 changes from 2-M136
* 295a4a1b14b8 from chromium
* c3568ceda9d8 from chromium
* chore: update patches
2025-05-21 10:27:08 +02:00
trop[bot]
781a0ab416
build: update_depot_tools on initial install ( #47168 )
...
this ensures that python is setup for proper use from depot_tools
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-20 14:13:20 -04:00
trop[bot]
9baf3745e6
build: update hasher return value ( #47013 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-05-09 12:52:15 -04:00
trop[bot]
e17d5bb9e0
test: enable hasShadow tests on Linux ( #47002 )
...
refactor: enable hasShadow tests on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-05-08 09:54:30 -05:00
trop[bot]
1754f01df1
build: move release script to new hasher function ( #46995 )
...
build: move to new hasher function
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-05-08 11:09:38 +02:00
David Sanders
7d9c576765
test: refactor deprecate-helpers.ts to warning-helpers.ts ( #46867 )
...
Add a generic expectWarningMessages and start checking warning names
2025-05-01 10:56:40 -04:00
trop[bot]
0c892fcf78
fix: enable some tests that were accidentally disabled ( #46846 )
...
* fix: tests that were not run in api-app-spec due to nested it()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: tests that were not run in api-browser-window-spec due to nested it()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: annotate disabled test
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-05-01 10:53:52 -04:00
trop[bot]
a95d9a406f
fix: Linux visibleOnAllWorkspaces property ( #46862 )
...
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
* chore: disable visibleOnAllWorkspaces test on Linux
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: NativeWindowViews::IsVisibleOnAllWorkspaces
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* test: enable visibleOnAllWorkspaces tests on Linux
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-30 12:31:45 -04:00
electron-roller[bot]
e9a88d481e
chore: bump node to v20.19.1 (34-x-y) ( #46739 )
...
chore: bump node in DEPS to v20.19.1
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-04-30 12:31:18 -04:00
trop[bot]
200a6ff5c6
fix: run visibleOnAllWorkspaces tests on the right platforms ( #46832 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: nested it() calls in visibleOnAllWorkspaces specs
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: make the process.platform test simpler
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: disable visibleOnAllWorkspaces test on Linux
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-28 16:44:52 -05:00
trop[bot]
a2f277257c
fix: enable autoHideMenuBar tests on Linux and Windows ( #46831 )
...
* fix: enable autoHideMenuBar tests
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* docs: mark autoHideMenuBar as supported on Linux, Windows
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-28 16:55:16 -04:00
trop[bot]
0ab9d0529c
fix: build error with enable_electron_extensions=false ( #46841 )
...
Fix build error with enable_electron_extensions=false
In file included from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.h:13,
from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr.h:50,
from ../../base/memory/raw_ptr.h:11,
from ../../base/memory/weak_ptr.h:82,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:14,
from ../../electron/shell/browser/usb/electron_usb_delegate.cc:5:
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:279:3: warning: multi-line comment [-Wcomment]
279 | // \
| ^
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:281:3: warning: multi-line comment [-Wcomment]
281 | // \
| ^
In file included from /usr/include/c++/14/memory:78,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:8:
/usr/include/c++/14/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = device::mojom::UsbDeviceInfo]’:
/usr/include/c++/14/bits/unique_ptr.h:399:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = device::mojom::UsbDeviceInfo; _Dp = std::default_delete<device::mojom::UsbDeviceInfo>]’
399 | get_deleter()(std::move(__ptr));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../../mojo/public/cpp/bindings/struct_ptr.h:48:3: required from ‘constexpr void std::destroy_at(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
48 | ~StructPtr() = default;
| ^
/usr/include/c++/14/bits/stl_construct.h:149:22: required from ‘constexpr void std::_Destroy(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
149 | std::destroy_at(__pointer);
| ~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:163:19: required from ‘static constexpr void std::_Destroy_aux<<anonymous> >::__destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; bool <anonymous> = false]’
163 | std::_Destroy(std::__addressof(*__first));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:193:44: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*]’
193 | return std::_Destroy_aux<false>::__destroy(__first, __last);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/alloc_traits.h:981:20: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator, allocator<_T2>&) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
981 | std::_Destroy(__first, __last);
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_vector.h:735:15: required from ‘constexpr std::vector<_Tp, _Alloc>::~vector() [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>; _Alloc = std::allocator<mojo::StructPtr<device::mojom::UsbDeviceInfo> >]’
735 | std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
736 | _M_get_Tp_allocator());
| ~~~~~~~~~~~~~~~~~~~~~~
../../electron/shell/browser/usb/electron_usb_delegate.cc:231:74: required from here
231 | std::move(callback).Run(std::vector<device::mojom::UsbDeviceInfoPtr>());
| ^
/usr/include/c++/14/bits/unique_ptr.h:91:23: error: invalid application of ‘sizeof’ to incomplete type ‘device::mojom::UsbDeviceInfo’
91 | static_assert(sizeof(_Tp)>0,
| ^~~~~~~~~~~
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bruno Pitrus <brunopitrus@hotmail.com >
2025-04-28 16:54:46 -04:00
trop[bot]
ee6f690122
refactor: use absl::InlinedVector in ToV8(ElectronPermissionManager) ( #46802 )
...
perf: use a stack-allocated string_view array in ToV8(USBProtectedClasses)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-25 18:19:19 -05:00
trop[bot]
dff23bd8b5
refactor: remove public method BrowserWindow::GetWeakPtr() ( #46798 )
...
refactor: remove public method electron::api::BrowserWindow::GetWeakPtr()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-25 18:10:33 -05:00
trop[bot]
6cc69e4239
fix: bluetooth crash in select-bluetooth-device event ( #46783 )
...
fix: bluetooth crash on bluetooth off
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-25 15:01:19 -05:00
trop[bot]
2574ceb720
fix: set XDG_CURRENT_DESKTOP env var back to original value before invoking xdg utils ( #46791 )
...
fix: set `XDG_CURRENT_DESKTOP` env var back to original value before invoking xdg utils (#45310 )
* Fix XDG_CURRENT_DESKTOP before invoking XDGUtil
* apply suggestion
* use existing XDG_CURRENT_DESKTOP const
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Evan Simkowitz <esimkowitz@users.noreply.github.com >
2025-04-25 15:00:24 -05:00
trop[bot]
3b94ccc253
fix: missing HandleScope in RemoveFromParentChildWindows ( #46775 )
...
fix: missing HandleScope in RemoveFromParentChildWindows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-25 11:29:44 -04:00
trop[bot]
75598194a7
fix: crash when renderer process crashes while webview is reloading ( #46770 )
...
WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
and triggers a fatal NOTREACHED.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com >
2025-04-25 13:13:17 +02:00
Keeley Hammond
0f8a2a9a8c
chore: cherry-pick 0333ecde9142 from chromium ( #46728 )
...
* chore: cherry-pick 0333ecde9142 from chromium
* chore: update patches
2025-04-22 19:27:29 -05:00
trop[bot]
a0c4972300
build: don't kill ssh sessions on checkout failure ( #46719 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-22 16:49:35 -04:00
trop[bot]
d3c5991e6e
fix: file dialog filters not working correctly ( #46720 )
...
fix: fix file dialog filters not working correctly
If someone sets an `All filter` with `*` at the start of the filters all upcoming filters will be shifted and thus labels won't fit to the extensions they actually filter.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kolja Lampe <razzeee@gmail.com >
2025-04-22 16:48:54 -04:00
trop[bot]
139677d058
fix: stop menu minimization if set false ( #46716 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
2025-04-22 09:44:55 -05:00
trop[bot]
6ceb0a76d4
docs: cleanup docs/tutorial/custom-window-styles.md ( #46712 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2025-04-22 10:32:51 +02:00
trop[bot]
26affd6c3e
fix: crash on reconversion with google IME and editcontext on macOS ( #46701 )
...
* fix: crash on reconversion with google IME and editcontext on macOS
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update .patches
* chore: update patch
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-04-22 14:29:01 +09:00
trop[bot]
fa7caa9c21
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver() ( #46686 )
...
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-19 15:13:52 -05:00
trop[bot]
b543cea4e8
fix: do not run microtasks in V8Serializer in browser process ( #46683 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2025-04-19 12:19:09 -05:00
trop[bot]
92990c0857
refactor: remove WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK ( #46678 )
...
refactor: remove electron::WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK
This was added in 344aba0 . In the time when this PR initially went up and
when 344aba0 landed, upstream added blink::PermissionTypes::KEYBOARD_LOCK.
Our duplicate copy can be removed.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-18 19:09:52 -05:00
trop[bot]
eecf0a7e99
fix: window border on Gnome Wayland ( #46643 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-15 16:05:49 -04:00
trop[bot]
469f18a3bb
docs: webContents.opener can be null ( #46640 )
...
docs: webContents.opener can be null
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Filip Mösner <filip.mosner@firma.seznam.cz >
2025-04-15 15:48:12 +02:00
trop[bot]
2b2e22e475
build: roll build-images ( #46633 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-15 10:44:20 +02:00
trop[bot]
eb66d94f2d
refactor: use default printing path when no user options ( #46618 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-12 18:50:25 -05:00
trop[bot]
9576986df0
build: ignore files in .git when running markdownlint-cli2 ( #46610 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-04-11 11:21:23 +02:00
trop[bot]
56df3b010e
fix: crash on parent window close and focur/blur ( #46582 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-10 11:18:42 +02:00
trop[bot]
4e93d53942
fix: NativeWindow.window_id() returns same value for all windows ( #46588 )
...
fix: NativeWindow.window_id() returns same value for all windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-09 13:48:55 -05:00
trop[bot]
d0594707de
refactor: use v8::True(isolate) and v8::False(isolate) ( #46569 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-08 17:12:25 -05:00
trop[bot]
23fd0e6e0b
refactor: remove unnecessary const_cast ( #46566 )
...
refactor: remove unnecessary const_cast
unnecessary since July 2019 in 50b9c70
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-08 15:38:40 -05:00
trop[bot]
babc9e9d68
refactor: simplify some BaseWindow JS getters ( #46563 )
...
* refactor: return a std::array<int 2> from BaseWindow::GetMaximumSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: return a std::array<int 2> from BaseWindow::GetMinimumSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: return a std::array<int 2> from BaseWindow::GetPosition()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: return a std::array<int 2> from BaseWindow::GetSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: return a std::array<int 2> from BaseWindow::GetContentSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: extract helper method ToArray(const gfx::Size)
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: #include correctness
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-08 13:44:18 -05:00
trop[bot]
f57240f36a
refactor: make api::View methods const, private ( #46553 )
...
* refactor: make api::View::GetBounds() const
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make api::View::OnViewBoundsChanged() private
refactor: make api::View::OnViewIsDeleting() private
refactor: make api::View::OnChildViewRemoved() private
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make ChildPair private
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-08 08:52:50 -05:00
trop[bot]
89325becfb
refactor: make TrackableObjectBase::weak_map_id_ const ( #46555 )
...
refactor: make TrackableObjectBase::weak_map_id_ const
simplify declaration and initialization
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-08 07:21:50 -05:00
Charles Kerr
555965fe3c
perf: improve temporaries in WebWorkerObserver::WorkerScriptReadyForEvaluation() (34-x-y backport) ( #46549 )
...
perf: improve temporaries in `WebWorkerObserver::WorkerScriptReadyForEvaluation()` (#46347 )
refactor: small refactor to WebWorkerObserver::WorkerScriptReadyForEvaluation()
- replace a std::vector<std::string> local with a compile-time array
of std::string_view
- remove .c_str() pessimization when making v8 Strings from string_views
2025-04-07 17:12:12 -05:00
Charles Kerr
7672c78231
perf: avoid redundant map lookups in GlobalShortcut (34-x-y backport) ( #46547 )
...
perf: avoid redundant map lookups in `GlobalShortcut::OnKeyPressed()` (#46229 )
2025-04-07 16:28:23 -04:00
Charles Kerr
c413523434
perf: avoid redundant call to virtual methods GetProcess() and GetID() (34-x-y backport) ( #46548 )
...
perf: avoid redundant call to virtual methods GetProcess() and GetID() (#46409 )
2025-04-07 16:24:13 -04:00
trop[bot]
5155fe0070
refactor: use base::flat_set in WebContents::DidUpdateFaviconUrl() ( #46532 )
...
* refactor: add gin::Converter<std::span>::ToV8()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* feat: add ToV8(const base::flat_set<T>&)
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use a flat_set in WebContents::TitleWasSet()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: add gin::Converter<std::array>::ToV8()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-07 16:36:27 +02:00
trop[bot]
178878c62f
docs: note that titleBarOverlay.symbolColor is supported on Linux ( #46534 )
...
docs: note that titleBarOverlay.symbolColor is supported on Linux
this is supported via OpaqueFrameView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-07 14:12:16 +02:00
trop[bot]
1b0333a574
revert: allow NSMenuItems to be disabled ( #46522 )
...
Revert "fix: allow NSMenuItems to be disabled (#46307 )"
This reverts commit ac616ef41d .
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hailey <hschauman@slack-corp.com >
2025-04-07 10:15:31 +02:00
trop[bot]
a4b87a9828
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal() ( #46525 )
...
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal()
Why waste time make lot call when few call do trick?
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-06 23:44:40 -05:00
trop[bot]
69d875ef63
refactor: remove unused electron::api::App::FileIconCallback ( #46512 )
...
refactor: remove electron::api::App::FileIconCallback
last use removed in 2018 by 3f15f516
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-05 18:10:02 -05:00
trop[bot]
be93b19141
refactor: instantiate navigation_entries local variable on the stack ( #46506 )
...
* refactor: instantiate navigation_entries on the stack instead of the heap
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: reserve the full size of navigation_entries
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use emplace_back to simplify the code a little
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-05 10:44:59 -05:00
trop[bot]
8c9c5eb6ea
fix: destroy parent port backend when JS env exits ( #46494 )
...
* fix: destroy parent port backend when JS env exits
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: close parent port before destroying
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-04 13:26:47 -05:00
Shelley Vohr
4306ade3a3
fix: context menu runs action under cursor when opened ( #46436 )
2025-04-03 23:33:50 -05:00
trop[bot]
ecb4c91979
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged() ( #46480 )
...
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-03 20:30:39 -05:00
trop[bot]
6075ea8482
perf: prefer absl::flat_hash_set over std::set when sorted order is not needed ( #46439 )
...
* perf: use an absl::flat_hash_set for UsbChooserContext::ephemeral_devices_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use an absl::flat_hash_set for GlobalMenuBarRegistrarX11::live_windows_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use an absl::flat_hash_set for NativeWindowViews::forwarding_windows_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::guest_host_views_
perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::proxy_views_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use an absl::flat_hash_set for NativeWindow::injected_frames_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use an absl::flat_hash_set for NativeWindow::background_throttling_sources_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-03 20:29:14 -05:00
trop[bot]
36958573c1
fix: NativeWindowViews::GetRestoredState() can return wrong state when maximized ( #46462 )
...
fix: NativeWindowViews::GetRestoredState() returning wrong state
Introduced by the af58931 Chromium 131.0.6744.0 roll, specifically
https://github.com/electron/electron/pull/43948/commits/9840662#diff-f9d7ef7
98406626
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-03 19:23:46 -05:00
trop[bot]
a39951f2c2
fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 ( #46472 )
...
* fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8
Co-authored-by: Yang Liu <ouyangliu.leo@gmail.com >
* fix: use CleanedUpAtExit to control the lifetime of GPUInfoManager
Co-authored-by: Yang Liu <ouyangliu.leo@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Yang Liu <ouyangliu.leo@gmail.com >
2025-04-03 18:40:28 -05:00
Charles Kerr
f22e5c5257
fix: ensure maximize is emitted when reduce motion is enabled on macOS (34-x-y) ( #46467 )
...
* fix: ensure maximize is emitted when reduce motion is enabled on macOS (#46459 )
* fix: ensure maximize is emitted when reduce motion is enabled on macOS
* empty commit
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2025-04-03 15:19:50 -05:00
trop[bot]
f41b4e3a81
perf: cache the return value of IsX11() ( #46426 )
...
* perf: cache the return value of IsX11()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: mark as nodiscard for those who call, but mark as maybe_unused for Windows
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-01 17:55:09 -05:00
trop[bot]
4a55ffe1d8
build: make it clearer when cookie auth runs ( #46421 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-01 18:32:42 -04:00
trop[bot]
2b94469560
perf: avoid redundant map lookup in UsbChooserContext::OnDeviceRemoved() ( #46420 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-01 16:04:40 -05:00
trop[bot]
ab71a179ec
perf: have ErrorThrower lazily lookup the current isolate ( #46416 )
...
perf: have ErrorThrower lazy-lookup the current isolate
ErrorThrower's default constructor is marked as "should rarely if ever
be used" because it's expensive to call.
Unfortunately, nearly every instance of ErrorThrower comes as an argument
in gin_helper's JS-->C++ function marshalling where a thrower is
default-constructed and then populated in gin_helper::GetNextArgument()
with an assignment operator to a temporary ErrorThrower constructed
with the gin::Arguments' isolate.
tldr: most of the time we use the slow constructor first, then throw
that work away unused by overwriting with a fast-constructed one.
This refactor avoids that cost by deferring the expensive work to
`ErrorThrower::isolate()`, where it happens only as a fallback iff
isolate_ hasn't been set.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-01 15:29:42 -05:00
trop[bot]
dc5091680c
fix: leaked gfx::Canvas in AutofillPopupView::OnPaint() ( #46411 )
...
* perf: avoid redundant call to popup_bounds_in_view()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use a std::optional<> for paint_canvas local
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: fix leaked gfx::Canvas in AutofillPopupView::OnPaint()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove redundant get() call when testing smart pointer for nonempty
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unnecessary draw_canvas variable
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: rename bitmap to offscreen_bitmap for symmetry
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: avoid another redundant call to popup_bounds_in_view()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-01 15:29:30 -05:00
electron-roller[bot]
8bfd7f05ac
chore: bump node to v20.19.0 (34-x-y) ( #46037 )
...
* chore: bump node in DEPS to v20.19.0
* deps, src: simplifying base64 encoding
https://github.com/nodejs/node/pull/52714
* module: simplify --inspect-brk handling
https://github.com/nodejs/node/pull/55679
* test: make test-crypto-hash compatible with OpenSSL > 3.4.0
https://github.com/nodejs/node/pull/56160
* module: refactor ESM loader for adding future synchronous hooks
https://github.com/nodejs/node/pull/54769
* module: detect ESM syntax by trying to recompile as SourceTextModule
https://github.com/nodejs/node/pull/52413
* worker: add postMessageToThread
https://github.com/nodejs/node/pull/53682
* backport unflagging of require(esm) to v20
https://github.com/nodejs/node/pull/56927
* module: detect ESM syntax by trying to recompile as SourceTextModule
https://github.com/nodejs/node/pull/52413
* chore: fixup patch indices
* chore: handle filename.json changes
- https://github.com/nodejs/node/pull/51711
- https://github.com/nodejs/node/pull/53573
* src: refactor embedded entrypoint loading
https://github.com/nodejs/node/pull/53573
* lib: allow CJS source map cache to be reclaimed
https://github.com/nodejs/node/pull/51711
* test: make eval snapshot tests more flexible
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-01 20:51:57 +02:00
trop[bot]
b241c0d98a
fix: UtilityProcess.fork crash before app ready ( #46405 )
...
fix: UtilityProcess.fork crash before app ready
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-01 09:32:22 -05:00
trop[bot]
75f5c91ad4
perf: avoid unnecessary vector copy in GetMimeTypeToExtensionIdMap() ( #46397 )
...
* perf: avoid making an unnecessary copy of the vector
MimeTypesHandler::GetMIMETypeAllowlist() returns a const&, so we can
iterate that directly instead of making a temporary copy of it.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: move the call to ExtensionRegistry::Get() outside of the loop
Also, keep the previous behavior of not calling it at all if there
aren't any whitelisted extensions.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: avoid redundant map lookup
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: const correctness
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: cleanup
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-01 08:55:26 -05:00
trop[bot]
b1a378ba26
refactor: use v8::String::Empty() when creating empty strings ( #46370 )
...
refactor: use v8::String::Empty() when creating empty strings
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-31 09:26:46 -05:00
trop[bot]
ab1d266535
perf: prefer absl::flat_hash_set over std::unordered_set ( #46376 )
...
* perf: use absl::flat_hash_set in SpellCheckClient::SpellCheckText()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use absl::flat_hash_set in MessagePort::DisentanglePorts()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-31 10:39:42 +02:00
trop[bot]
b4540e013d
perf: avoid double map lookup in HidChooserContext::DeviceRemoved() ( #46360 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-29 08:12:22 -05:00
trop[bot]
b4568e63aa
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance() ( #46357 )
...
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-29 08:12:11 -05:00
trop[bot]
db034229c4
perf: avoid a double-map lookup in NotificationPresenter::RemoveNotification() ( #46355 )
...
perf: avoid a double-map lokup in NotificationPresenter::RemoveNotification()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-29 08:10:06 -05:00
trop[bot]
6f58c2ab8e
perf: avoid redundant map lookups in GetStorageMask() ( #46344 )
...
* perf: avoid a redundant map lookuop in GetStorageMask()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: avoid a redundant map lookup in GetDataTypeMask()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-28 10:58:11 -05:00
trop[bot]
d046aacb00
fix: allow NSMenuItems to be disabled ( #46340 )
...
* fix: disable NSMenu autoenable feature to allow disabling of NSMenuItems
Co-authored-by: Hailey Schauman <hschauman@slack-corp.com >
* style: fix linter issues and update comments
Co-authored-by: Hailey Schauman <hschauman@slack-corp.com >
* chore: remove unneeded comment
Co-authored-by: Hailey <hschauman@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hailey Schauman <hschauman@slack-corp.com >
2025-03-28 00:04:07 -05:00
trop[bot]
0410455878
build: validate Chromium cookie authentication ( #46325 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-27 17:45:41 -07:00
trop[bot]
ef8c4f283d
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() ( #46330 )
...
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-27 19:21:04 -05:00
Robo
9e2af54b40
fix: emit context-menu event in Windows draggable regions ( #46328 )
...
fix: emit `context-menu` event in Windows draggable regions (#46032 )
fix: emit context-menu event in Windows draggable regions
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-27 18:14:55 -05:00
trop[bot]
d7fabf348f
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges() ( #46332 )
...
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-27 18:10:57 -05:00
trop[bot]
e87dc57071
build: roll build-images SHAs ( #46318 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-27 17:32:44 +01:00
Pedro Pontes
cd7644ff00
chore: cherry-pick 1 changes from 3-M134 ( #46304 )
...
* chore: [34-x-y] cherry-pick 1 changes from 3-M134
* b8f80176b163 from chromium
* chore: update patches
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-03-27 10:56:37 +01:00
trop[bot]
8d77d66e5a
fix: set userAgent on navigationHistory.restore() ( #46298 )
...
fix: set userAgent on navigationHistory restore
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-26 19:53:18 -05:00
trop[bot]
3d51ce2ca5
perf: avoid std::map temporaries in WebContents::DevToolsRequestFileSystems() ( #46310 )
...
* perf: move the GetDevToolsWebContents() call outside of the loop
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: remove std::map temporary in WebContents::DevToolsRequestFileSystems()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused GetAddedFileSystemPaths()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: remove std::vector temporary in WebContents::DevToolsRequestFileSystems()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-26 19:25:34 -05:00
trop[bot]
5daff5468b
perf: avoid redundant map lookup in AddComponentResourceEntries() ( #46289 )
...
* perf: avoid double map lookup in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: move the path key when calling try_emplace()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-26 19:11:09 -05:00
trop[bot]
09a9b419b8
perf: avoid redundant map lookup in WebContents::DevToolsIndexPath() ( #46297 )
...
perf: avoid double map lookup in WebContents::DevToolsIndexPath()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-26 18:34:26 -05:00
Shelley Vohr
9049d01bd6
fix: build failure when printing is disabled ( #46286 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-26 09:46:58 -05:00
trop[bot]
42c8938c9a
perf: avoid redundant map lookup in WebFrameMain constructor ( #46277 )
...
perf: avoid double map lookup in WebFrameMain constructor
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-25 22:00:40 -04:00
trop[bot]
b5f8c7554a
perf: avoid std::map temporaries in IsDevToolsFileSystemAdded() ( #46266 )
...
* refactor: extract-method GetAddedFileSystems()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use GetAddedFileSystems() in GetAddedFileSystemPaths()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use GetAddedFileSystems() in IsDevToolsFileSystemAdded()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-25 23:40:42 +01:00
trop[bot]
0b34f5b45e
build: fixup windows source cache for release ( #46269 )
...
* build: fixup ffmpeg gn gen
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: add build-tools depot_tools to PATH
There are some cases where it is still expected that depot_tools be in the path
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* put back regular gn gen for ffmpeg
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: add retry to moving source cache
This resolves the error: `Move-Item : The process cannot access the file because it is being used by another process.`
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-03-25 16:34:00 -05:00
trop[bot]
2b7f32428f
fix: webContents.printToPDF() with cross-process subframes ( #46258 )
...
fix: webContents.printToPDF() with cross-process subframes
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-25 13:09:38 -05:00
trop[bot]
2d7cfd3de2
perf: don't wait for thumbnails if they were not requested on macOS ( #46250 )
...
When using the SCK thumbnail capturer, the first refresh has the list of
sources, and the second refresh has the thumbnails. If thumbnails are
not needed, only wait for the first refresh.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com >
2025-03-25 16:44:25 +01:00
trop[bot]
06c84f35bd
fix: oob string read when parsing node_options ( #46246 )
...
* fix: oob string read when parsing node_options
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: re-enable test
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: missing linux server env for tests
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-03-25 08:14:59 -05:00
Robo
cfb7237c6c
fix: system-context-menu should only fire in draggable regions (34-x-y) ( #46175 )
2025-03-25 12:20:57 +01:00
trop[bot]
fa4462341a
fix: NODE_OPTIONS parsing for child processes on macOS ( #46242 )
...
* fix: NODE_OPTIONS parsing for child processes on macOS
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: temporarily disable test
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: apply review feedback
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix build
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-03-25 19:32:04 +09:00
trop[bot]
19069ead12
feat: add ffmpeg.dll to delay load configuration ( #46174 )
...
feat: set ffmpeg.dll as a delay-loaded DLL
Updated the /DELAYLOAD linker config in BUILD.gn to set ffmpeg.dll
as a delay-loaded DLL. This reduces startup overhead and prevents unnecessary
loading when ffmpeg-related functionality is not used (e.g., the browser process
was unnecessarily loading it).
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Zonglong Liu <83216456+mai-121@users.noreply.github.com >
2025-03-24 23:15:05 -05:00
trop[bot]
6da5666aa5
build: fixup release builds ( #46232 )
...
* build: fixup release builds
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: fixup windows source cache for release
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-03-24 17:19:28 -04:00
trop[bot]
fcdf08ce75
fix: Wayland resizing border ( #46223 )
...
* fix: Wayland resizing border
Closes https://github.com/electron/electron/issues/44543
Refs CL:5180720
Fixes an issue where the resizing border didn't work as expected on Wayland windows.
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: border insets when fullscreen
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-24 10:54:32 -05:00
trop[bot]
fe9e90af7b
refactor: remove unused weak_factory_ in electron_management_api_delegate.cc ( #46219 )
...
refactor: remove unused weak_factory_
Appears to have been added in 3745b76da but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-24 15:03:08 +01:00
trop[bot]
ef9cd3464d
build: Use windows src cache ( #46187 )
...
build: use source cache on windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-03-24 09:33:37 -04:00
trop[bot]
51f771224a
refactor: remove unused method ProxyingWebSocket::web_request_api() ( #46216 )
...
Appears to have been added in c608d6d7 but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-24 08:21:59 -05:00
trop[bot]
23d574152e
refactor: remove unused method ElectronBrowserContext::GetWeakPtr() ( #46197 )
...
* refactor: use forward declaration of MediaDeviceIDSalt in electron_browser_context.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused #include from browser_context.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused ElectronBrowserContext::GetWeakPtr()
last use removed in Aug 2020 by bac2f46
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-22 14:22:19 -05:00
trop[bot]
4bee1eaded
refactor: use = default to define trivial destructors ( #46192 )
...
refactor: use '= default' to define trivial destructors
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-22 10:14:28 -05:00
Pedro Pontes
88f4deb3a3
chore: restore forced LF for patch files with exception ( #45902 )
...
chore: restore forced LF for patch files and add exception
2025-03-21 14:11:36 -04:00
trop[bot]
165ea64314
build: fail for out of date patches on forks ( #46125 )
...
* build: fail for out of date patches on forks
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-03-21 19:04:34 +01:00
trop[bot]
8961eb074b
build: move set chromium cookie before build tools step ( #46096 )
...
build: move set cookie before build tools
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
2025-03-21 12:43:59 -04:00
trop[bot]
b194cb1486
refactor: reduce coupling in electron::api::Protocol ( #46181 )
...
* refactor: decouple api::Protocol from ElectronBrowserContext
now they do not know about each other
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make electron::api::ProtocolError private
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused isolate arg in Protocol constructor
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use =default for trivial destructor
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-21 11:09:19 -05:00
trop[bot]
470a82869c
refactor: use GetDefaultStoragePartition() instead of GetStoragePartition(nullptr) ( #46082 )
...
refactor: use GetDefaultStoragePartition()
Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr)
- It improves code uniformity, since we use get-default everywhere else
- It's more readable
- It's marginally faster, since GetStoragePartition() has more steps
Added in 49b0a1bf4a
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-20 23:06:39 -05:00
Charles Kerr
a19f617ab0
refactor: make URLPipeLoader private (34-x-y) ( #46168 )
...
refactor: make URLPipeLoader private
Move the URLPipeLoader class into an anonymous namespace in
electron_url_loader_factory.cc. Manual backport of 1b5db99 .
2025-03-20 21:02:00 -05:00
trop[bot]
f008b0d0b2
fix: APNS token ids are lowercase ASCII ( #46150 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-20 16:52:03 -05:00
trop[bot]
ce2f471e9d
refactor: Add ElectronBrowserContext::BrowserContexts() ( #46159 )
...
* refactor: add ElectronBrowserContext::BrowserContexts()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronBrowserMainParts::PostMainMessageLoopRun()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::IsValidContext()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::BroadcastEventToRenderers()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move PartitionKey, BrowserContextMap private
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: add ElectronBrowserContext::IsValidContext()
decouple ElectronExtensionsBrowserClient from the internals of ElectronBrowserContext
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-20 16:51:28 -05:00
trop[bot]
5cda3d226c
refactor: use base::NumberToString() ( #46152 )
...
base::NumberToString() is slightly more efficient than
absl::StrFormat("%u").
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-20 13:47:41 -05:00
Charles Kerr
30358180c7
refactor: remove unused system header includes (34-x-y) ( #46135 )
...
refactor: remove unused system header includes (#46015 )
* chore: remove unused #include <string>
* chore: remove unused #include <optional>
* chore: remove unused #include <vector>
* chore: remove unused #include <string_view>
* chore: remove unused #include <memory>
* chore: remove unused #include <utility>
* chore: remove unused #include <tuple>
* chore: remove unused #include <unordered_set>
* chore: remove unused #include <functional>
* chore: iwyu <set>
* chore: iwyu <map>
2025-03-20 07:57:29 +01:00
Charles Kerr
e151aae7a3
refactor: add ElectronBrowserContext::GetDefaultBrowserContext() (34-x-y) ( #46136 )
...
refactor: add `ElectronBrowserContext::GetDefaultBrowserContext()` (#46065 )
* refactor: add ElectronBrowserContext::DestroyAllContexts()
Simpler semantics than previous implementation; also hides the
"default context must be destroyed last" implementation detail.
* refactor: add ElectronBrowserContext::GetDefaultBrowserContext()
clearer semantics than everyone calling From("", false)
2025-03-19 17:25:35 -05:00
trop[bot]
bc9b5af26e
build: fix compound bash conditional in patchup ( #46057 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-17 12:48:42 +01:00
trop[bot]
952b9c0b46
fix: warning in file picker UI ( #46076 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-16 23:28:30 -05:00
trop[bot]
5705ce1d6e
fix: take Snapped status into account when showing a window ( #46039 )
...
* fix: take Snapped status into account when showing a window
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! fix: take Snapped status into account when showing a window
fix: bad trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-16 11:15:55 +01:00
trop[bot]
c8ac7b0efd
perf: avoid redundant map lookup in ElectronBrowserContext::From() ( #46060 )
...
perf: avoid redundant map lookup in ElectronBrowserContext::FromPath()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-15 13:46:49 -05:00
trop[bot]
dbeed26c0d
fix: ElectronBrowserContext raw_ptr bug + remove dead code ( #46054 )
...
refactor: remove unused ElectronBrowserContext::extension_system()
Last use removed on Jul 21, 2020 by 2fb14f5 in PR #24575
This fixes a raw_ptr warning by letting us remove the raw_ptr field
`ElectronBrowserContext::extension_system_`.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-15 11:39:19 -05:00
trop[bot]
99e589c2cf
fix: prevent title change for within page navigation ( #46034 )
...
* fix: prevent title change for on page navigation
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
* add back and forward testing
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
* update Chromium comment
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
* remove errant script tag
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
2025-03-14 09:53:52 -05:00
trop[bot]
3782fe51ff
fix: don't crash Web Workers on unhandled rejections ( #46019 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-14 09:58:37 +01:00
trop[bot]
be7b06108e
refactor: make a variadic gin_helper::internal::InvokeFactory() ( #46029 )
...
refactor: make a variadic gin_helper::internal::InvokeFactory()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-13 23:41:02 -05:00
Pedro Pontes
6b956d036d
chore: cherry-pick 1 changes from 3-M133 ( #46008 )
...
chore: [34-x-y] cherry-pick 1 changes from 3-M133
* 91343bb45c78 from v8
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-13 16:27:22 -05:00
Pedro Pontes
370ffe0df5
chore: cherry-pick 3 changes from 0-M134 ( #46009 )
2025-03-13 11:31:56 -05:00
Pedro Pontes
14456ecfbc
chore: cherry-pick 1 changes from 1-M134 ( #46011 )
...
chore: [34-x-y] cherry-pick 1 changes from 1-M134
* 2b4812d502b2 from v8
2025-03-13 10:19:23 -05:00
trop[bot]
974c8f5150
refactor: use private inheritance from mojo::MessageReceiver ( #45994 )
...
* refactor: make UtilityProcessWrapper inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make ParentPort inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make MessagePort inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-12 22:49:24 -05:00
trop[bot]
ac5b5995e8
build: roll sysroots to pick up glibc fix ( #45982 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-12 09:26:33 +01:00
trop[bot]
5ccd41cf5c
test: fix timing issue in utilityProcess test fixtures ( #45976 )
...
* fix: potential timing issue in utilityProcess test
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: potential timing issue in utilityProcess esm test
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-11 17:31:16 -04:00
Michaela Laurencin
060cfb94e9
fix: cherry-pick 3a72ebf7ec6f0 from chromium ( #45966 )
...
* fix: backport chromium revert 6262017
* add reasoning for patch
2025-03-11 10:09:32 -05:00
trop[bot]
587e115527
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call ( #45959 )
...
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call
This appears to be a copy-paste error introduced in 465dee2c
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-10 14:50:37 -05:00
trop[bot]
a56b2acadd
fix: race condition in utilityProcess tests ( #45954 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-10 14:49:21 -05:00
trop[bot]
58479848b2
refactor: eliminate duplicate code in spec/api-process-spec.ts ( #45949 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2025-03-10 11:39:12 -05:00
trop[bot]
ba2cad1670
perf: prefer base::SplitStringPiece() over base::SplitString() ( #45948 )
...
* perf: use base::SplitStringPiece() in SetNodeOptions()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::SplitStringPiece() in StringToAccelerator()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: StringToAccelerator() now takes a std::string_view
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-10 09:50:03 -05:00
Samuel Attard
f98501308a
chore: cherry-pick 521faebc8a7c from chromium ( #45944 )
2025-03-09 17:01:50 -07:00
Samuel Attard
1d9f1a4cd4
chore: cherry-pick 9dacf5694dfd from chromium ( #45939 )
...
* chore: cherry-pick 9dacf5694dfd from chromium
* chore: update patch for <=34
2025-03-09 17:01:20 -07:00
trop[bot]
7d01169091
fix: resolve font list in default prefernce values ( #45917 )
...
* fix: resolve font list in default prefernce values
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix unsafe buffer usage
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* docs: add code comment
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-03-07 16:01:49 +01:00
trop[bot]
ad496c9958
fix: setContentProtection(true) after hide on Windows ( #45890 )
...
fix: content protection after hide on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5789117
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-05 10:48:03 -05:00
trop[bot]
b04c4505c4
fix: correct electron gin embedder indices ( #45880 )
...
fix: correct gin embedder indices.
Move electron extra embedders to the end of the enum so they do not
interfere with chromium embedders indices.
Also use kEmbedderBlinkTag directly in its index calculation without
adding extra indices from other tags.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Marek Haranczyk <marek@openfin.co >
2025-03-04 12:43:48 +01:00
Shelley Vohr
c3fd3afa24
build: define NOMINMAX in common.gypi ( #45870 )
...
build: define NOMINMAX in common.gypi
https://github.com/nodejs/node/pull/52794
2025-03-03 19:48:37 +01:00
trop[bot]
4516469312
fix: context-menu event emitted in draggable regions ( #45840 )
...
* fix: context-menu event emitted in draggable regions
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: only trigger on mouse release
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-28 11:20:42 +01:00
Charles Kerr
b4bb928224
refactor: use C++20's contains() method ( #45814 )
...
refactor: use C++20's contains() method (#45742 )
* chore: use std::map<>::contains() instead of count() or find()
* chore: use std::map<>::contains() instead of base::Contains()
2025-02-27 10:38:30 +01:00
trop[bot]
4ed1ac6ab0
refactor: simplify Invoker::IsOK() ( #45819 )
...
* refactor: simplify Invoker::IsOK()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: might as well make it [[nodiscard]] as well
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-27 00:46:14 -06:00
Pedro Pontes
289a1861fc
chore: cherry-pick 1 changes from 0-M133 ( #45704 )
...
chore: [34-x-y] cherry-pick 3 changes from 0-M133
* 51cd241b7b13 from chromium
* 1c7ff4d5477f from v8
* 8834c16acfcc from v8
* ee9db7d1348f from skia
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-26 15:48:57 +01:00
trop[bot]
b19995e623
refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) ( #45807 )
...
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-25 22:52:04 -06:00
electron-roller[bot]
47ab952bb1
chore: bump chromium to 132.0.6834.210 (34-x-y) ( #45805 )
...
chore: bump chromium in DEPS to 132.0.6834.210
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-25 22:23:02 -05:00
trop[bot]
0c73c66438
refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor ( #45794 )
...
refactor: remove unused isolate arg from GlobalShortcut constructor
has not been used since f1a0d5e811 (#22755 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-24 22:15:49 -06:00
trop[bot]
289168a1ad
fix: drag and drop icons on Windows ( #45778 )
...
* fix: drag and drop icons on Windows
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: fix patch merge conflict
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-24 21:02:09 -06:00
trop[bot]
9f27479a11
refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc ( #45782 )
...
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-24 14:42:50 -06:00
trop[bot]
01b8069ada
docs: clarify navigationhistory offsets ( #45765 )
...
* docs: clarify navigationhistory offsets
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
* "relative offset"
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
2025-02-21 18:13:29 -06:00
trop[bot]
31a95f7857
refactor: use base's map utills in WebFrameMain ( #45759 )
...
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameTreeNodeId()
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameToken()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-21 18:04:06 -06:00
trop[bot]
70b354643e
fix: crash on getUserMedia with invalid chromeMediaSourceId ( #45756 )
...
* fix: crash on getUserMedia with invalid chromeMediaSourceId
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: add a test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-21 22:18:59 +01:00
trop[bot]
4fdfc66706
refactor: use base::as_byte_span() in EncodeToken(). ( #45750 )
...
This matches the change in upstream's serial_chooser_context.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/5247305
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-21 10:56:27 -06:00
trop[bot]
9d7c3a65fe
build: skip chromium git cookie on forks ( #45736 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-02-21 11:53:00 -05:00
trop[bot]
66d1227cc4
refactor: use base::as_bytes() in WriteAsciiChunk() ( #45749 )
...
refactor: use base::as_bytes() in WriteAsciiChunk()
this avoids a reinterpret_cast and a static_cast
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-21 10:40:00 -06:00
trop[bot]
ccb7fc05b3
refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected ( #45744 )
...
* refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected
https://chromium-review.googlesource.com/c/chromium/src/+/5737296
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: review feedback
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-21 10:30:44 -06:00
trop[bot]
d507cf63d1
feat: allow setting roundedCorners on Windows ( #45739 )
...
* feat: allow setting roundedCorners on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update docs/api/structures/base-window-options.md
Co-authored-by: Will Anderson <will@itsananderson.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-21 10:15:14 -06:00
trop[bot]
95bce0bce1
refactor: use base::as_string_view() ( #45746 )
...
Use `base::as_string_view()` as a safer alternative to `reinterpret_cast`
in a couple of places.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5472408
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-21 10:14:12 -06:00
trop[bot]
727e218c47
fix: possible timing issue in utility-process spec ( #45728 )
...
This fixture has been calling process.exit() immediately after writing
to stdout and stderr, which the Node.js docs say is risky behavior:
> Calling process.exit() will force the process to exit as quickly as
> possible even if there are still asynchronous operations pending that
> have not yet completed fully, including I/O operations to
> process.stdout and process.stderr.
This fixture's been around for years without problems (AFAIK).
The writes are very small ('hello\n' and 'world') and finish quickly.
But recently I've been testing on a very slow CI machine. There, I see
this spec flaking when it expects stderr to be 'world' but it gets ''.
This PR changes the fixture to wait for stdout & stderr to flush
before calling process.exit().
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-20 08:54:45 +01:00
trop[bot]
16cb1e46c8
refactor: track downloads by guid ( #45717 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-20 08:17:21 +01:00
trop[bot]
435facd8e4
fix: extension web workers net request failing ( #45710 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2025-02-19 23:00:08 -05:00
trop[bot]
75ce54614e
fix: osr stutter fix backport for electron. ( #45659 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com >
2025-02-19 14:43:07 -06:00
electron-roller[bot]
de958d0dab
chore: bump chromium to 132.0.6834.209 (34-x-y) ( #45695 )
...
chore: bump chromium in DEPS to 132.0.6834.209
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-19 15:19:51 -05:00
Sam Maddock
0af85fc5f0
fix: dangling speculative frames ( #45687 )
...
fix: dangling speculative frames (#45609 )
* fix: dangling speculative frames
* harden lifecycle state checks
* feedback
* add const
2025-02-19 15:19:19 -05:00
John Kleinschmidt
f927d1dd92
build: remove appveyor bake ( #45683 )
...
build: remove appveyor bake (#45073 )
2025-02-19 12:09:55 +01:00
trop[bot]
f2ec3763c2
fix: osr crash on window close ( #45629 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-18 16:19:48 -05:00
trop[bot]
c8c5f9c986
fix: win.closeFilePreview recreates panel when called twice ( #45662 )
...
* fix: close quick look during tests on macOS
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* use longer delay 🤷
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* fix: sharedPreviewPanel being recreated on close
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* test: ensure preview panel gets closed
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-02-18 10:01:53 +01:00
trop[bot]
c1c9c1d001
build: run source cache clean daily ( #45654 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-18 09:59:42 +01:00
Robo
3b89a5e183
fix: support for v8.setHeapSnapshotNearHeapLimit api ( #45644 )
...
* fix: support for v8.setHeapSnapshotNearHeapLimit api
* chore: fix lint
2025-02-17 15:48:02 +01:00
trop[bot]
e2042de483
fix: asan build on macOS ( #45567 )
...
* fix: asan build on macOS
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix build
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-02-17 11:14:38 +01:00
trop[bot]
dd5def7f46
build: make sure chromium cookie is set everywhere ( #45634 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-14 16:02:11 -05:00
trop[bot]
6210a9e82c
fix: pointer lock permission after focus loss and regain ( #45627 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-14 12:58:49 -05:00
Charles Kerr
eb7216be1c
refactor: use node::tracing::Agent() directly (34-x-y) ( #45620 )
...
* refactor: use node::tracing::Agent()
* chore: e patches all
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-14 10:18:24 +01:00
trop[bot]
32830de5b6
chore: change node test timeout from 20m to 30m ( #45624 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-14 10:17:54 +01:00
Charles Kerr
a9f3754d22
docs: fix powerMonitor event types (34-x-y) ( #45615 )
...
docs: fix powerMonitor event types (#45518 )
* fix: powerMonitor event types
* fix: thermal-state-change missing Returns
Co-authored-by: Sam Maddock <samuelmaddock@electronjs.org >
2025-02-13 17:25:36 -05:00
electron-roller[bot]
eb7a5c2548
chore: bump node to v20.18.3 (34-x-y) ( #45575 )
...
* chore: bump node in DEPS to v20.18.3
* src: fix outdated js2c.cc references
https://github.com/nodejs/node/pull/56133
* lib: remove startsWith/endsWith primordials for char checks
https://github.com/nodejs/node/pull/55407
* test,crypto: make crypto tests work with BoringSSL
https://github.com/nodejs/node/pull/55491
* fix: potential WIN32_LEAN_AND_MEAN redefinition
https://github.com/c-ares/c-ares/pull/869
* chore: fixup patch indices
* deps: update c-ares to v1.34.1
https://github.com/nodejs/node/pull/55369
* chore: fix bssl test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-13 19:26:54 +01:00
electron-roller[bot]
cb1c7b447b
chore: bump chromium to 132.0.6834.207 (34-x-y) ( #45605 )
...
chore: bump chromium in DEPS to 132.0.6834.207
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-13 11:04:24 -05:00
Shelley Vohr
d33905c5d9
fix: cppgc crashes on Linux with 16KiB pages ( #45571 )
2025-02-13 10:12:17 +01:00
trop[bot]
ddc7afd3f0
feat: Restore webContents navigation history and page state ( #45584 )
...
* feat: Working navigationHistory.restore with just title/url
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* feat: Restore page state, too
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* chore: Docs, lint, tests
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Implement feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* More magic
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Make _awaitNextLoad truly private
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Implement API group feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* One more round of feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2025-02-12 21:29:32 +01:00
trop[bot]
d04491dff0
build: set chromium cookie on depot tools requests ( #45600 )
...
* build: set chromium cookie on depot tools requests
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: correct secrets syntax
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: handle windows cmd
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-02-12 10:37:33 -08:00
trop[bot]
88286e8f16
build: bump actions/cache past deprecated version ( #45203 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-02-12 10:07:01 +01:00
trop[bot]
a6eb660a3d
build: make gen-libc++-filenames.js produce the same results on Windows ( #45577 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <will@itsananderson.com >
2025-02-11 11:08:35 -05:00
electron-roller[bot]
bb6d76a07a
chore: bump node to v20.18.2 (34-x-y) ( #45300 )
...
chore: bump node in DEPS to v20.18.2
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-11 11:39:09 +01:00
trop[bot]
27349fc233
fix: fix mksnapshot gen/v8 path ( #45544 )
...
* fix: fix mksnapshot gen/v8 path
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: use 7z compression
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: unzip mksnapshot on Windows and update zip
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: escape backslashes
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: try another attempt
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: remove rmdir for now
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-11 10:02:45 +01:00
trop[bot]
c1a9e79d08
fix: window maximizing with Mica ( #45526 )
...
* fix: window maximizing with Mica
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Fix rounded corners after restore
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-10 15:36:51 -05:00
Keeley Hammond
b3bb3c5be0
chore: clean up web secure context patch ( #45528 )
...
chore: clean up patch application
2025-02-09 21:36:25 +01:00
trop[bot]
882bcb9435
build: make sure there is at least 35GB free for source cache ( #45515 )
...
build: make sure there is at least 35GB free for cache
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-09 21:35:54 +01:00
electron-roller[bot]
d2fce89969
chore: bump chromium to 132.0.6834.196 (34-x-y) ( #45516 )
...
chore: bump chromium in DEPS to 132.0.6834.196
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-07 13:59:02 -05:00
trop[bot]
78adaed2c6
refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor ( #45505 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2025-02-07 10:03:21 +01:00
trop[bot]
bba618f4d3
fix: RenderFrameHost nullptr dereference ( #45510 )
...
* fix: add nullptr tests before using render_frame_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: extract-method HasRenderFrame()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-02-07 10:02:55 +01:00
Samuel Attard
b83b8ef851
chore: cherry-pick dd8e2822e507 from chromium ( #45497 )
2025-02-06 14:42:57 -08:00
trop[bot]
e4df33053c
test: dump Electron process PID to path if environment variable set ( #45492 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-06 12:09:19 -06:00
Shelley Vohr
dc149e6d3f
build: remove outdated Node.js serdes patch ( #45431 )
2025-02-06 10:38:04 +01:00
trop[bot]
c1918f96cb
feat: view.getVisible() ( #45410 )
...
* feat: view.getVisible()
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* test: visible apis
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* docs: clarify getVisible
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-02-05 14:35:12 -05:00
Robo
9fe5f566a4
feat: route deprecated sync clipboard read through permission checks ( #45472 )
...
feat: route deprecated sync clipboard read through permission checks (#45377 )
2025-02-05 14:10:18 -05:00
trop[bot]
3053e33739
fix: WCO not working with some window configurations ( #45478 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-05 14:09:46 -05:00
electron-roller[bot]
d857946d6e
chore: bump chromium to 132.0.6834.194 (34-x-y) ( #45480 )
...
chore: bump chromium in DEPS to 132.0.6834.194
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-05 14:08:35 -05:00
trop[bot]
082d43e022
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist ( #45469 )
...
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2025-02-05 10:50:50 +01:00
Keeley Hammond
18ee5c25c6
build: migrate Windows release builds to GHA ( #45466 )
...
* build: migrate Windows release builds to GHA (#45137 )
* build: migrate release builds to GHA
* build: alter CI jobs release script
* build: remove generate-sas-token (#45347 )
* build: use windows builders for win-publish (#45340 )
* build: add win toolchain for release builds (#45380 )
* build: add win toolchain for release builds
* build: fix installed_software.json script
* chore: run pwsh script within src
* build: fixup uploader arch
2025-02-04 13:57:30 -08:00
trop[bot]
69333ae82f
build: always use python3 in script/lib/get-version.js ( #45441 )
...
build: always use python3 in script/lib/get-version.js
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-04 19:35:28 +01:00
trop[bot]
614c987401
docs: document deletion of databases directory ( #45449 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-02-04 08:28:27 -06:00
trop[bot]
2ce5fdbec8
docs: mention C++20 requirement in breaking changes document ( #45446 )
...
* docs: mention C++20 requirement in breaking changes document
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: fix linter issue
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-02-03 16:29:16 -05:00
trop[bot]
54e5f1d8b2
fix: default path not working on KDE Linux ( #45419 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-03 22:01:23 +01:00
trop[bot]
5ccd987f61
fix: incorrect WCO tooltip in RTL ( #45426 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-03 14:02:23 +01:00
electron-roller[bot]
754ac14e78
chore: bump chromium to 132.0.6834.161 (34-x-y) ( #45391 )
...
chore: bump chromium in DEPS to 132.0.6834.161
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-01-31 12:22:14 -05:00
trop[bot]
608d89e447
fix: multiple directory selection on Linux ( #45395 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-31 11:28:28 -05:00
trop[bot]
45f633e0f9
build: fix slack-github-action for backports ( #45404 )
...
build: fix slack-github-action for backports
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-31 09:53:31 -05:00
trop[bot]
505e02284b
build: fixup concurrent builds on protected branches ( #45385 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-01-30 10:36:17 +01:00
trop[bot]
1472c5b090
docs: reference security guide in ipcRenderer.on docs ( #45372 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-01-29 15:44:30 -05:00
trop[bot]
61cddcaf76
fix: crash in gin::wrappable::secondweakcallback ( #45376 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-01-29 12:10:57 -08:00
electron-roller[bot]
0fed0b74e0
chore: bump chromium to 132.0.6834.159 (34-x-y) ( #45313 )
...
* chore: bump chromium in DEPS to 132.0.6834.110
* chore: bump chromium in DEPS to 132.0.6834.159
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-01-29 19:55:29 +01:00
trop[bot]
af9ea0b422
fix: crash parsing CLSID in shell.readShortcutLink() ( #45350 )
...
* fix: crash parsing CLSID in shell.readShortcutLink
Co-authored-by: David Lönnhager <david.l@mullvad.net >
* fix: ignore clsid if it could not be set
Co-authored-by: David Lönnhager <david.l@mullvad.net >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Lönnhager <david.l@mullvad.net >
2025-01-29 17:29:07 +01:00
trop[bot]
a41a0b1c1d
build: use Python311 exe ( #45362 )
...
build: yse Python311 exe
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-01-28 20:43:29 -08:00
trop[bot]
600551766d
docs: fix broken code in drag and drop example ( #45337 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-01-27 13:06:04 -05:00
trop[bot]
c538aa8e6c
docs: Add note about directly exposing Electron APIs in preload ( #45323 )
...
* docs: Add note about directly exposing Electron APIs in preload
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Implement feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2025-01-23 16:29:22 -08:00
trop[bot]
2d6dd64a5e
fix: potential crash in chrome.tabs.update() ( #45304 )
...
fix: potential crash in chrome.tabs.update()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-23 12:08:40 +01:00
Shelley Vohr
bb616ba5ca
fix: page scaling in silent mode printing ( #45283 )
...
* fix: page scaling in silent mode printing
* fix: FTBFS in print_renderer_frame_helper.cc
* chore: e patches all
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-01-22 13:18:36 -05:00
trop[bot]
4a1c029f94
refactor: in StopTracing(), use string literals instead of optional<string> ( #45291 )
...
refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>
We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-01-22 09:43:19 -06:00
trop[bot]
a1816f3587
docs: add DocCardList component for index doc ( #45295 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
2025-01-22 10:53:17 +01:00
trop[bot]
db84f39e5e
refactor: simplify ParseUserScript() ( #45289 )
...
refactor: simplify ParseUserScript()
local variable user_script no longer needed after #43205
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-01-22 10:11:19 +01:00
trop[bot]
7ecb8ad7a5
chore: align clipboard blink::web_pref::WebPreferences with upstream ( #45279 )
...
chore: align clipboard blink::web_pref::WebPreferences with upstream
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-21 09:38:52 -08:00
trop[bot]
973c344f1b
fix: getAsFileSystemHandle failure when drag-dropping two directories ( #45258 )
...
fix: drag-dropping two directories
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-20 14:39:09 -06:00
trop[bot]
01c5db032a
build: fix clang-format duplicate message ( #45264 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-20 11:07:39 -06:00
trop[bot]
2c22507dfb
fix: two possible FSA crashes ( #45260 )
...
* 5786874: Change Observer: Fix crash when navigating to new page
https://chromium-review.googlesource.com/c/chromium/src/+/5786874
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* 5794141: Change Observer: Fix Get*PermissionGrant crash
https://chromium-review.googlesource.com/c/chromium/src/+/5794141
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-20 10:36:09 -06:00
trop[bot]
41c1161dd9
fix: session.clearData avoidClosingConnections default to false ( #45208 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2025-01-17 10:36:43 +01:00
Anny Yang
b36aaf36e7
docs: remove quickstart ( #45227 )
2025-01-17 10:36:15 +01:00
Erick Zhao
5728e6dc81
docs: Why Electron? ( #45211 )
...
docs: Why Electron? (#45191 )
* docs: Why Electron?
* Apply suggestions from code review
* Update docs/why-electron.md
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2025-01-16 14:37:45 -08:00
Keeley Hammond
c86896312f
docs: correct breaking changes versions ( #45189 )
...
docs: correct breaking changes versions (#45173 )
2025-01-13 14:45:57 -08:00
trop[bot]
b9b6aebe32
docs: update timelines for E35 ( #45174 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
2025-01-11 18:07:02 -08:00
trop[bot]
6bc6d10308
perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set ( #45163 )
...
* perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove unused #include
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-01-09 09:22:51 -06:00
electron-roller[bot]
1323e223a4
chore: bump chromium to 132.0.6834.83 (34-x-y) ( #45164 )
...
chore: bump chromium in DEPS to 132.0.6834.83
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-01-09 09:21:56 -06:00
trop[bot]
bc00450a31
refactor: remove redundant CreateExtensionsClient() ( #45155 )
...
* refactor: have CreateExtensionsClient return a unique_ptr, not a raw pointer
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove CreateExtensionsClient()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-01-08 16:04:52 -06:00
trop[bot]
1ecc57465d
test: reenable disabled GHA windows tests ( #45075 )
...
* test: renable GHA on Windows disabled tests
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* test: close edge after shell.openExternal
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* test: close edge sync after shell.openExternal
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-01-06 12:49:16 -05:00
q234rty
0b12d0e6c5
chore: cherry-pick 3dc17c46 from chromium ( #45127 )
2025-01-06 12:48:36 -05:00
electron-roller[bot]
68a410de9b
chore: bump chromium to 132.0.6834.57 (34-x-y) ( #45066 )
...
chore: bump chromium in DEPS to 132.0.6834.57
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-12-23 15:32:12 +09:00
trop[bot]
314bc3e1a1
fix: better prompt not supported message in window-setup.ts ( #45045 )
...
Update window-setup.ts
The message should simply read "is not supported" or, alternatively, "is not, and will not, be supported", but not "is and will not be supported".
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Quinn <qdirks@gmail.com >
2024-12-17 12:42:15 +01:00
trop[bot]
33065a8654
docs: remove extra " ( #45041 )
...
remove extra "
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kavindu Udara <karunasinghesampath38@gmail.com >
2024-12-16 13:43:10 -05:00
trop[bot]
52484b0ccd
fix: chrome.i18n unavailable in extension service workers ( #45036 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <samuelmaddock@electronjs.org >
2024-12-16 13:14:32 -05:00
John Kleinschmidt
b5ed025267
build: use github actions for windows ( #45011 )
...
* build: use github actions for windows (#44136 )
* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094
and https://chromium-review.googlesource.com/c/chromium/src/+/5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37 .
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d6 )
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a180658376 .
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f538 .
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129 .
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffe .
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01 .
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049 .
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7 .
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839 .
* Revert "remove debugging"
This reverts commit f18dd8b1a5 .
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f .
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd4322 .
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1 .
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d .
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
(cherry picked from commit be1a3dce83 )
* chore: update build tools to correct sha
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-12-15 22:54:56 -08:00
trop[bot]
bcbd3063a3
fix: custom spell-checker stuck in infinite loop ( #45020 )
...
`ReadUnicodeCharacter` updates index to the last character read, and not after it. We need to manually increment it to move to the next character.
It also doesn't validate that the index is valid, so we need to check that index is within bounds.
Refs: #44336
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jesper Ek <deadbeef84@gmail.com >
2024-12-13 17:26:44 -08:00
Keeley Hammond
686bc86042
chore: cherry-pick 1282289030ab from chromium ( #45023 )
2024-12-13 17:26:01 -08:00
trop[bot]
fd117af7ce
fix: add missing index arg in navigationHistory.canGoToOffset ( #45008 )
...
fix: add missing arg
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
2024-12-12 16:21:36 -05:00
electron-roller[bot]
40dd1b76bc
chore: bump chromium to 132.0.6834.46 (34-x-y) ( #45005 )
...
chore: bump chromium in DEPS to 132.0.6834.46
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-12-12 10:49:55 -05:00
trop[bot]
521835d70b
fix: context-menu emitted twice ( #44997 )
...
* fix: context-menu emitted twice
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* refactor: simplify disabling draggable regions
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* cleanup
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-12-11 13:24:32 -05:00
trop[bot]
cfe549c739
fix: build failure when PDF viewer is disabled ( #44964 )
...
* fix: unused variable warning when the PDF viewer is disabled
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: unused function error when PDF viewer is disabled
error: unused function ParseManifest [-Werror,-Wunused-function]
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-06 17:28:55 -06:00
trop[bot]
2d45b7df34
fix: context-menu event with BaseWindows ( #44952 )
...
fix: context-menu event with BaseWindows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-12-04 16:03:02 -08:00
trop[bot]
9a7848ced1
feat: Add shared dictionary management APIs ( #44950 )
...
* Add bare-bones GetSharedDictionaryUsageInfo
* Add GetSharedDictionaryInfo()
* Improve API, use isolation keys
* Add documentation
* Update docs/api/session.md
* Update shell/browser/api/electron_api_session.cc
* Add tests
* Implement feedback <3
* Improve tests
* chore: lint
* docs: add note about clearing cache in ses.clearData
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-12-04 13:35:08 -08:00
electron-roller[bot]
c54f1f98fe
chore: bump chromium to 132.0.6834.32 (34-x-y) ( #44949 )
...
chore: bump chromium in DEPS to 132.0.6834.32
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-12-04 14:02:31 -05:00
trop[bot]
a7066af0f9
fix: modernize-use-equals-default warnings ( #44944 )
...
fix: use '= default' to define a trivial destructor [modernize-use-equals-default]
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-03 21:19:32 -06:00
trop[bot]
7f6594654c
docs: fix grammar in app.relaunch docs ( #44942 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-03 10:12:47 -08:00
trop[bot]
f383391c0e
feat: WebFrameMain.collectJavaScriptCallStack() ( #44938 )
...
* feat: WebFrameMain.unresponsiveDocumentJSCallStack
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* Revert "feat: WebFrameMain.unresponsiveDocumentJSCallStack"
This reverts commit e0612bc1a00a5282cba5df97da3c9c90e96ef244.
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* feat: frame.collectJavaScriptCallStack()
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* feat: frame.collectJavaScriptCallStack()
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* Update web-frame-main.md
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-12-03 09:55:52 -08:00
trop[bot]
ed0946c880
chore: remove unused registry arg from GetPrivilegeRequiredByUrl() ( #44931 )
...
this has never been used; introduced by 91071570
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-02 15:37:21 -06:00
trop[bot]
d1eee44b19
docs: clarify what session.clearData() with data type 'cache' deletes ( #44930 )
...
* docs: clarify what session.clearData() with data type 'cache' deletes
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: include `shadercache`, too
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-02 14:03:12 -05:00
trop[bot]
498a7d82cc
chore: remove unused arg from BaseWindow::GetBackgroundColor() ( #44924 )
...
chore: remove unused gin_helper::Arguments* arg from BaseWindow::GetBackgroundColor()
looks like this was added in db79734b but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-02 13:58:52 -05:00
trop[bot]
dc53f6e73b
docs: clarify session.clearData() can delete more types than listed ( #44927 )
...
docs: warn that session.clearData() might delete more than expected
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-02 13:51:00 -05:00
trop[bot]
fa98b4d542
fix: don't use deprecated ui::MouseEvent constructor ( #44919 )
...
* refactor: do not use deprecated gfx::Point constructor for MouseEvent
Deprecated in https://chromium-review.googlesource.com/c/1444251
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use WebInputEvent::GetTypeAsUiEventType() instead of rolling our own
Added in https://chromium-review.googlesource.com/c/chromium/src/+/2180291
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-02 13:30:50 -05:00
trop[bot]
1c2015ed1f
chore: remove unused isolate argument from Cookies constructor ( #44923 )
...
* chore: remove unused isolate argument from Cookies constructor
unused since the ginify cookies refactor in Mar 2020, commit 22202255
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: constructor only takes one arg now, so mark it explicit
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-02 13:25:44 -05:00
trop[bot]
d0668e6a3a
fix: remove unused id argument from TranslateToStock() ( #44912 )
...
unused since fb537d91fc
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-02 08:36:48 -06:00
trop[bot]
d7284f0262
docs: specify default value for respondToAuthRequestsFromMainProcess ( #44901 )
...
docs: specify default value for respondToAuthRequestsFromMainProcess
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-01 07:13:39 -06:00
trop[bot]
b33ea0d72d
docs: fix a syntax issue in document breaking changes ( #44905 )
...
fix: syntax issue in docs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: illusory-dream <37270118+illusory-dream@users.noreply.github.com >
2024-12-01 07:12:11 -06:00
trop[bot]
c63613f290
refactor: return-braced-init-list pt 2 of 2 ( #44891 )
...
* refactor: more return-braced-init-list, this time for v8 and gin objects
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-30 16:47:30 -06:00
trop[bot]
dc0c6c6f3f
refactor: reduce scope of relauncher's internal constants ( #44892 )
...
* refactor: make kRelauncherArgSeparator private to relauncher.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make kRelauncherTypeArg private to relauncher.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused type relauncher::CharType
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move private constants into standalone private namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: move kWaitEventName into the only function that uses it
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-30 16:46:45 -06:00
trop[bot]
a92b3944a1
fix: misc-use-internal-linkage warnings ( #44872 )
...
* refactor: fix misc-use-internal-linkage warnings:
move impl functions into anonymous namespace so that they're not visible
to other compilation units
2024-11-27 12:35:37 -06:00
trop[bot]
5ca3f950e9
refactor: use base::Extend in AddAdditionalSchemes() ( #44866 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-27 10:09:55 -06:00
trop[bot]
99f2bab4a4
refactor: fix modernize-return-braced-init-list warnings ( #44856 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-26 22:18:13 -06:00
trop[bot]
c0d1c3481a
fix: modernize-use-nodiscard clang-tidy warnings ( #44833 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-25 13:55:56 -05:00
trop[bot]
5a0e1ccf73
fix: modernize-avoid-c-arrays ( #44834 )
...
use string_view for constants used in methods that take string_view args
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-25 13:55:19 -05:00
trop[bot]
d8a7c57506
fix: modernize-use-using clang-tidy warnings ( #44835 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-25 13:53:59 -05:00
trop[bot]
a30cf5b551
docs: correct stable release dates for v34.0.0 ( #44829 )
...
* docs: correct stable release dates for v34.0.0
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com >
* docs: correct stable release dates for v34.0.0
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com >
2024-11-25 11:04:30 -05:00
trop[bot]
6208b61a38
refactor: remove unnecessary constructor code ( #44827 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-24 12:15:04 -06:00
trop[bot]
73243cb9c4
fix: remove unused local variables ( #44823 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de5
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: only declare program_name local variable if used
We declared it everywhere but only used it on Windows
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove unused local non-trivial variable path from UnregisterXWindow
it became unused in 2020 by 72a08926
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-24 08:54:56 -06:00
trop[bot]
5670b17b40
docs: update new GitHub issue link ( #44811 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-11-22 16:50:54 -06:00
trop[bot]
103a7c1838
fix: crash calling shell.readShortcutLink ( #44804 )
...
* fix: crash calling shell.readShortcutLink
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update .patches after trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-22 11:00:12 -06:00
trop[bot]
cfdf7992d3
build: remove duplicate line in gn file ( #44792 )
...
style: remove duplicate line in gn file
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <15865969+cucbin@users.noreply.github.com >
2024-11-22 15:36:23 +01:00
trop[bot]
7d260a1305
fix: big endian bug in V8 serialization ( #44797 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-22 15:35:55 +01:00
trop[bot]
d2bafe870e
fix: ensure context-menu emitted for draggable regions ( #44799 )
...
* fix: ensure context-menu emitted for draggable regions
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: address suggestions from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-22 09:28:12 -05:00
electron-roller[bot]
bbdce52b12
chore: bump node to v20.18.1 (34-x-y) ( #44782 )
...
* chore: bump node in DEPS to v20.18.1
* chore: update patches
* lib: remove lib/internal/idna.js
https://github.com/nodejs/node/pull/55050
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-22 10:21:55 +01:00
electron-roller[bot]
b72b661f3c
chore: bump chromium to 132.0.6834.15 (34-x-y) ( #44783 )
...
* chore: bump chromium in DEPS to 132.0.6834.15
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-21 16:56:48 -05:00
trop[bot]
b6f97b7952
fix: windows save dialog extension bug ( #44770 )
...
* fix: windows save dialog extension bug
* refactor: simplify firstSpec extraction
* refactor: split when necessary
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: nilaoda <nilaoda@live.com >
2024-11-21 22:36:31 +01:00
trop[bot]
787d4c3859
fix: clang-tidy performance-inefficient-vector-operation warnings ( #44775 )
...
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-21 14:30:45 -05:00
trop[bot]
19e6ca921f
docs: sync 34.0.0 release date to Chromium 132 release date ( #44788 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-21 11:32:56 -06:00
trop[bot]
14c705349e
fix: performance-no-automatic-move clang-tidy warnings ( #44773 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-21 15:29:52 +01:00
trop[bot]
8c7a253d6a
test: run script to help target discovery and reduce flakes ( #44762 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-20 15:50:33 -08:00
trop[bot]
bf110c9467
chore: fix textured window conditional on macOS ( #44768 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-20 14:56:38 -05:00
trop[bot]
aaa5ec8dfa
fix: tooltips in WCO caption buttons ( #44759 )
...
fix: tooltips in WCO capton buttons
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-20 15:34:58 +01:00
trop[bot]
9dc7ac48fe
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44740 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
2024-11-19 19:31:10 -06:00
trop[bot]
b78e06974e
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h ( #44735 )
...
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-19 16:01:35 -06:00
trop[bot]
39e50be043
fix: utility process exit code for graceful termination (reland) ( #44733 )
...
* chore: reland "fix: utility process exit code for graceful termination"
This reverts commit 1cae73ba09 .
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: exit code on posix when killed via api
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix code style
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-11-19 22:09:53 +01:00
trop[bot]
d477926b5d
fix: destroy url loader wrapper when JS env exits ( #44731 )
...
* fix: destroy url loader wrapper when JS env exits
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: double free of JSChunkedDataPipeGetter
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: crash on process exit after stream completes
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-11-19 20:48:43 +01:00
trop[bot]
ca8e1e4af6
fix: improve single-pixel resize handling on Windows ( #44722 )
...
* fix: improve single-pixel resize handling
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update spec/api-browser-window-spec.ts
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update shell/browser/native_window_views.cc
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-19 10:53:04 -05:00
trop[bot]
3764c4d0b3
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44711 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
Co-authored-by: Will Anderson <will@itsananderson.com >
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
Co-authored-by: Will Anderson <will@itsananderson.com >
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
Co-authored-by: Will Anderson <will@itsananderson.com >
* fix: clear all listeners before running ipcMain removeAllListeners tests
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <will@itsananderson.com >
2024-11-19 09:47:45 +01:00
trop[bot]
d5ece2a033
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44709 )
...
Fixes #44450
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-11-18 17:51:10 -06:00
trop[bot]
5fc13009cb
fix: utilityProcess pid should be undefined after exit ( #44695 )
...
fix: utilityProcess pid should be undefined after exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-18 14:44:14 +01:00
electron-roller[bot]
9bd442fb62
chore: bump chromium to 132.0.6834.6 (34-x-y) ( #44587 )
...
* chore: bump chromium in DEPS to 132.0.6822.0
* chore: bump chromium in DEPS to 132.0.6824.1
* chore: bump chromium in DEPS to 132.0.6826.1
* chore: bump chromium in DEPS to 132.0.6827.1
* chore: bump chromium in DEPS to 132.0.6828.1
* chore: bump chromium in DEPS to 132.0.6830.1
* chore: bump chromium in DEPS to 132.0.6832.0
* chore: bump chromium in DEPS to 132.0.6834.1
* chore: bump chromium in DEPS to 132.0.6834.6
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-16 16:16:10 -05:00
trop[bot]
71d57a7cb2
chore: update extensions features ( #44683 )
...
* chore: update extensions features
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
* restore header
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2024-11-15 13:16:19 -05:00
trop[bot]
2ee65f9c10
fix: revert required portal version for file chooser dialogs ( #44681 )
...
* feat: add support for configuring xdg portal version at runtime
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* doc: update command-line-switches.md
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Robo <hop2deep@gmail.com >
* doc: required portal version for defaultPath support
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Robo <hop2deep@gmail.com >
* doc: update more occurrances
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: remove warning from save dialogs
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-11-15 11:30:06 -05:00
trop[bot]
900400e442
fix: WebContentsView removal should compare directly ( #44670 )
...
* fix: WebContentsView removal should compare directly
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup view comparision
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: use erase_if
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Apply review suggestions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-15 13:09:34 +01:00
trop[bot]
500d453a63
chore: bump chromium to 132.0.6834.0 (34-x-y) ( #44666 )
...
* chore: bump chromium in DEPS to 132.0.6827.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6828.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6830.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6832.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6834.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update chromium patches
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 5977022: Apply os setting of overlay scrollbar to web instances | https://chromium-review.googlesource.com/c/chromium/src/+/5977022
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 5991440: Cleanup //ui/compositor from LaCros support code. | https://chromium-review.googlesource.com/c/chromium/src/+/5991440
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* chore: update all patches
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 6000058: Add base_subdirs to file_chooser.mojom NativeFileInfo | https://chromium-review.googlesource.com/c/chromium/src/+/6000058
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 6009949: Rename NOTREACHED_NORETURN() uses to NOTREACHED() | https://chromium-review.googlesource.com/c/chromium/src/+/6009949
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 5966419: [freezing] Expose frozen state to extensions (3/3 - add frozen to chrome.tabs.Tab).
https://chromium-review.googlesource.com/c/chromium/src/+/5966419
Also https://chromium-review.googlesource.com/c/chromium/src/+/6006424
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-14 20:56:18 -05:00
Keeley Hammond
7d835b7670
refactor: unfilter unresponsive events ( #44669 )
...
refactor: unfilter unresponsive events (#44629 )
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4 .
* fix: emit unresponsive if close not prevented
---------
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-11-14 16:59:10 -08:00
trop[bot]
eb712a65af
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44658 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove some unused imports
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: E711 warning 'Comparison to should be '
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-14 09:04:22 -05:00
trop[bot]
5b3a1a7195
fix: WCO buttons hidden on Linux in fullscreen ( #44641 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-13 15:54:53 -05:00
trop[bot]
da390c193b
fix: add theme data source for devtools. ( #44636 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bill Shen <shenyb32768@gmail.com >
2024-11-13 15:06:21 +01:00
trop[bot]
ac1165d778
test: exercise fuller globalShortcut matrix ( #44627 )
...
test: test fuller globalShortcut matrix
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-13 10:48:30 +01:00
trop[bot]
802741b8b0
fix: segfault when moving WebContentsView between BrowserWindows ( #44612 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-11 22:09:09 -05:00
trop[bot]
d983cadf64
build: update appveyor image to latest version ( #44608 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-11 18:45:14 -05:00
trop[bot]
e7eb572c21
chore: bump chromium to 132.0.6826.0 (34-x-y) ( #44603 )
...
* chore: bump chromium in DEPS to 132.0.6821.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6822.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: bump chromium in DEPS to 132.0.6824.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5998172: Migrate remaining NOTREACHED()s in chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5998172
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5872484: Pass along accelerators for menu items coming from DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/5872484
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5872913: Enable `raw_span` clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fixup! picture-in-picture import
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5912245: [video pip] Add progress bar to 2024 UI | https://chromium-review.googlesource.com/c/chromium/src/+/5912245
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fixup! 5872913: Enable raw_span clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-11-09 08:08:26 -06:00
trop[bot]
0f7538c434
chore: remove revert_mojo_force_blink_headers_to_only_be_included_in_blink.patch ( #44593 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-07 19:39:25 -05:00
trop[bot]
ac94585998
build: update appveyor image to latest version ( #44588 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-06 16:36:49 -05:00
trop[bot]
e925444071
chore: bump chromium to 132.0.6820.0 (34-x-y) ( #44585 )
...
* chore: bump chromium in DEPS to 132.0.6817.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update chromium patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5979290: Temoporarily disable crel on arm. | https://chromium-review.googlesource.com/c/chromium/src/+/5979290
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5981701: Include callback.h instead of callback_forward.h | https://chromium-review.googlesource.com/c/chromium/src/+/5981701
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5964918: [v8 code cache] Add a wpt_internal test demonstrating the code cache 304 problem | https://chromium-review.googlesource.com/c/chromium/src/+/5964918
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5969697: Add NetworkTrafficAnnotationTag to PreconnectManager | https://chromium-review.googlesource.com/c/chromium/src/+/5969697
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: update remaining patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: bump chromium in DEPS to 132.0.6818.0
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 5983492: MPArch GuestView: Have executeScript target correct frame | https://chromium-review.googlesource.com/c/chromium/src/+/5983492
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: bump chromium in DEPS to 132.0.6820.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 5989717: Revert "win: Remove special check for 10.0.22621.2428 Win SDK version" | https://chromium-review.googlesource.com/c/chromium/src/+/5989717
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* 5968218: Send PDF Searchifier running state to browser to show UX elements. | https://chromium-review.googlesource.com/c/chromium/src/+/5968218
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
* build: also update the MSVS_HASH for WOA
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-11-06 12:00:35 -05:00
trop[bot]
66bf0732dc
chore: remove executable flag from docs/api/app.md file permissions ( #44580 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-05 12:12:40 -05:00
trop[bot]
5a09ca8d1e
docs: clarify that sessions use cache by default ( #44576 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-11-05 10:39:58 -06:00
trop[bot]
9c7b9580bc
test: fixup flaky session tests ( #44564 )
...
test: fixup broken tests in 32-x-y (#44389 )
* test: fixup broken tests in 32-x-y
* test: fixup additional failing test
(cherry picked from commit c61bb1654e )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 18:33:17 -06:00
trop[bot]
6ef5640d33
fix: remove use of banned std::to_string() ( #44562 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-04 18:00:52 -06:00
trop[bot]
ab619ff231
docs: capitalize POSIX and Windows correctly ( #44559 )
...
* docs: capitalize POSIX correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* docs: capitalize Windows correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-04 16:43:05 -05:00
trop[bot]
5885a52d17
chore: remove use of banned absl::optional ( #44550 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-04 16:40:56 -05:00
trop[bot]
3f3874cb18
build: add new status to verify if all the required gha jobs have run ( #44554 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 16:40:39 -05:00
trop[bot]
c0b914f6a6
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #44552 )
...
refactor: replace base::StringPrintf() calls with absl::StFormat()
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-04 13:12:50 -08:00
electron-roller[bot]
460fc9b452
chore: bump chromium to 132.0.6807.0 (34-x-y) ( #44361 )
...
* chore: bump chromium in DEPS to 132.0.6791.1
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5804481
* chore: bump chromium in DEPS to 132.0.6793.1
* chore: bump chromium in DEPS to 132.0.6794.0
* chore: bump chromium in DEPS to 132.0.6797.0
* 5952404: Clean up //ui/base/resource from Lacros code.
https://chromium-review.googlesource.com/c/chromium/src/+/5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
https://chromium-review.googlesource.com/c/chromium/src/+/5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
https://chromium-review.googlesource.com/c/chromium/src/+/5943708
* 5937004: Remove components/services/language_detection
https://chromium-review.googlesource.com/c/chromium/src/+/5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
https://chromium-review.googlesource.com/c/chromium/src/+/5920322
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* chore: bump chromium in DEPS to 132.0.6805.1
* chore: bump chromium in DEPS to 132.0.6807.0
* chore: bump chromium in DEPS to 132.0.6809.1
* chore: bump chromium in DEPS to 132.0.6811.1
* chore: bump chromium in DEPS to 132.0.6813.1
* chore: bump chromium in DEPS to 132.0.6815.1
* chore: bump chromium in DEPS to 132.0.6817.1
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
https://chromium-review.googlesource.com/c/chromium/src/+/5947724
(cherry picked from commit 0fdf6c6e51 )
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
https://chromium-review.googlesource.com/c/chromium/src/+/5948024
(cherry picked from commit f6662c3b6d )
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/5945209
(cherry picked from commit 55b75a1456 )
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5942398
(cherry picked from commit d664ce2434 )
* chore: fixup patch indices
(cherry picked from commit 657cd6ee34 )
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5963016
(cherry picked from commit 69505baee6 )
* chore: fixup patch indices
(cherry picked from commit c79c2c8734 )
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5924816
(cherry picked from commit dbcc24fe26 )
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
(cherry picked from commit f396860717 )
* 5829616: MPArch based GuestViews basic implementation
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5829616
(cherry picked from commit b95772daa3 )
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5953710
(cherry picked from commit 11edc865b5 )
* chore: fixup patch indices
(cherry picked from commit 7be81bdd02 )
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | https://chromium-review.googlesource.com/c/chromium/src/+/5938657
(cherry picked from commit 48c5efd0b0 )
* chore: bump chromium in DEPS to 132.0.6807.0
(cherry picked from commit f41da7b5a3 )
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5868889
(cherry picked from commit 4e389ef21a )
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5956408
(cherry picked from commit a4b8e46b34 )
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962696
(cherry picked from commit f0228c286f )
* chore: update patches
(cherry picked from commit 3a3c527a1d )
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973073
(cherry picked from commit c571e561e0 )
* chore: update filenames.libcxx.gni
(cherry picked from commit 7677e9bfc6 )
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
(cherry picked from commit e8dd8215cf )
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 14:47:15 -05:00
trop[bot]
7e608f2993
build: remove unused lint package ( #44534 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-11-04 10:23:28 -05:00
trop[bot]
434363de26
docs: fix apostrophe typo "Electrons" -> "Electron's" ( #44537 )
...
s/Electrons/Electron's/
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-03 09:33:10 -06:00
trop[bot]
81fed15dcc
refactor: remove unused C string ToV8() gin converter ( #44524 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-02 10:34:17 -05:00
trop[bot]
fe27901d31
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter ( #44517 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-11-01 16:56:23 -05:00
trop[bot]
5498eaa29d
docs: add custom titlebar example ( #44506 )
...
* docs: add custom titlebar example
* docs: add links and other small edits
* docs: add panel window docs
* docs: remove panel example
* docs: specify expected emphasis style
* docs: responding to feedback
* docs: fix section names in links
* docs: rework baseWindow note
* docs: making window customization its own section
* responding to feedback
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org >
2024-11-01 12:47:51 -05:00
trop[bot]
39d29a1d2e
build: handle out of disk space on source cache ( #44494 )
...
* build: handle out of disk space on source cache
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: add cron job to free up source cache disk space
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-31 20:27:05 -04:00
trop[bot]
517fc64eae
perf: remove isolate scope from DidProcessTask() ( #44471 )
...
* Revert "docs: fix `win.getContentView(`) return type (#44464 )"
This reverts commit b11c6cf9bf .
* perf: remove isolate scope from DidProcessTask()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2024-10-31 20:21:07 -04:00
trop[bot]
8f857284a4
fix: EventSource undefined in Renderer/Worker ( #44495 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-31 17:16:56 -05:00
trop[bot]
5d5c18b7a6
fix: update shell.openExternal to correctly focus on external window ( #44469 )
...
* Revert "docs: fix `win.getContentView(`) return type (#44464 )"
This reverts commit b11c6cf9bf .
* fix: Use openURL:configuration:completionHandler instead of openUrl
Co-authored-by: alice <alice@makenotion.com >
* test: add a test
Co-authored-by: alice <alice@makenotion.com >
* fix: add dispatch_async to replace GetUIThreadTaskRunner
Co-authored-by: alice <alice@makenotion.com >
* refactor: remove unused import
Co-authored-by: alice <alice@makenotion.com >
* fix: update to use BindPostTaskToCurrentDefault
Co-authored-by: alice <alice@makenotion.com >
* test: add regression test for window focus
Co-authored-by: alice <alice@makenotion.com >
* refactor: update to explicit task runner
Co-authored-by: alice <alice@makenotion.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
2024-10-31 12:05:44 +01:00
trop[bot]
13dacf6a32
docs: fix win.setContentView() arg type ( #44481 )
...
fix: setContentView type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-30 16:26:12 -04:00
trop[bot]
b11c6cf9bf
docs: fix win.getContentView() return type ( #44464 )
...
docs: fix win.getContentView() return type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-29 17:00:13 -04:00
trop[bot]
758c5a25f8
build: fix python util verbose mode logic ( #44453 )
...
build: fix verbose mode logic
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-29 18:10:43 +01:00
trop[bot]
a280a592ec
build: improve gen-libc++-filenames output ( #44443 )
...
build: improve gen-libc++-filenames output
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-29 13:22:10 +01:00
trop[bot]
2d59db7aaf
fix: keep gdk_pixbuf a dynamic dependency ( #44438 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-10-29 00:32:45 -05:00
trop[bot]
c3321715e3
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals ( #44428 )
...
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: string length is known when calling NewFromUtf8(), so use it
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-28 13:03:22 -04:00
trop[bot]
ed3cbb12e3
fix: crash on netlog connection error ( #44418 )
...
* fix: crash on netlog connection error
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* refactor: remove default PromiseBase constructor
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d .
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
* remove dcheck
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-10-28 12:56:59 +01:00
trop[bot]
6012b50d89
test: deflake flaky tests on linux ( #44401 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-25 11:32:00 -04:00
John Kleinschmidt
aa565a7281
build: update linux container ( #44394 )
...
build: update linux container (#44392 )
(cherry picked from commit a0f51d816e )
2024-10-25 09:27:51 -04:00
trop[bot]
e21d7a1010
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44382 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use base::HexEncode() instead of rolling our own
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-23 20:44:41 -05:00
trop[bot]
1d0cd8bf59
test: fixup flaky tests ( #44379 )
...
* test: fixup flaky test
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* test: disable flaky protocol speed test on macOS
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* test: fixup flaky test in api-browser-window-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-23 17:16:38 -04:00
trop[bot]
b9b982cd7d
docs: clarify utilityProcess child.pid value ( #44363 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-22 19:22:02 +02:00
trop[bot]
633cec167e
fix: crash when generating shortcut text for super accelerator ( #44346 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-22 19:21:40 +02:00
trop[bot]
f003c1ea6a
build: update appveyor image to latest version ( #44362 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-10-22 12:37:46 -04:00
trop[bot]
7973861ffc
fix: software compositing infinite loop ( #44350 )
...
* fix: software compositing infinite loop
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-10-21 20:44:56 -04:00
trop[bot]
98930bb2b6
build: fixup reclient use for prod builds ( #44345 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-21 17:15:13 -04:00
electron-roller[bot]
d0f8a31a4c
chore: bump chromium to 132.0.6789.1 (34-x-y) ( #44328 )
...
* chore: bump chromium to 132.0.6787.0 (main) (#44329 )
* chore: bump chromium in DEPS to 132.0.6785.0
* chore: bump chromium in DEPS to 132.0.6787.0
* 5837702: mac fullscreen: always show traffic lights
https://chromium-review.googlesource.com/c/chromium/src/+/5837702
* 5892572: Move SimpleMenuModel out of ui/base
https://chromium-review.googlesource.com/c/chromium/src/+/5892572
* 5938185: Remove lacros code from //ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/5938185
* chore: fixup patch indices
* 5939514: Wire up the preference of overlay scrollbars to the ChromeOS settings
https://chromium-review.googlesource.com/c/chromium/src/+/5939514
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: bump chromium to 132.0.6788.0 (main) (#44331 )
chore: bump chromium in DEPS to 132.0.6788.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6789.1
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-21 10:50:20 -04:00
trop[bot]
e21c3cb801
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44322 )
...
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com >
2024-10-18 16:19:27 -04:00
trop[bot]
b6ce8d02ce
build: update appveyor image to latest version ( #44317 )
...
* build: update appveyor image to latest version
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 14:00:16 -04:00
trop[bot]
bc8e80a1f5
chore: bump chromium to 132.0.6783.0 (34-x-y) ( #44319 )
...
* chore: bump chromium in DEPS to 132.0.6782.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 132.0.6783.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 13:59:02 -04:00
trop[bot]
e76a504d10
fix: Linux crash after webContents.print() with no parent window ( #44284 )
...
fix: Linux crash after print with no parent window
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-18 10:40:46 -04:00
trop[bot]
82a1cc5f0f
chore: bump chromium to 132.0.6781.0 (34-x-y) ( #44308 )
...
* chore: bump chromium in DEPS to 132.0.6781.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 5933789: [MappableSI] Remove kill-switch from RenderableGpuMemoryBufferVideoFramePool.
https://chromium-review.googlesource.com/c/chromium/src/+/5933789
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 5938992: Reland: Remove `force_guest_profile` param from context getters.
https://chromium-review.googlesource.com/c/chromium/src/+/5938992
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 5928743: spanification: Add WTF::String::FromUTF8(span<>) overloads
https://chromium-review.googlesource.com/c/chromium/src/+/5928743
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 5898835: Update windows SDK version to 10.0.26100.1742
https://chromium-review.googlesource.com/c/chromium/src/+/5898835
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 15:42:18 +02:00
trop[bot]
3e3a6fb211
chore: fixup reclient read only access on forks ( #44303 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-17 13:36:13 -04:00
electron-roller[bot]
34a6cd2bd8
chore: bump chromium to 132.0.6779.0 (34-x-y) ( #44272 )
...
* chore: bump chromium in DEPS to 131.0.6778.4
* chore: bump chromium to 131.0.6778.0 (main) (#44251 )
* chore: bump chromium in DEPS to 131.0.6778.0
* 5803393: [UI] Add alias for mojo version of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5803393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
(cherry picked from commit ef84f13650 )
* chore: bump chromium in DEPS to 132.0.6779.0
(cherry picked from commit 77f17523f2 )
* chore: update patches
(cherry picked from commit fed9888232 )
* 5904951: controlledframe: Disable File System Access for <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5904951
(cherry picked from commit 289a2fb86a )
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-16 21:41:53 -04:00
trop[bot]
8689cf2b3f
build: remove dead code in prepare release script ( #44286 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-10-16 17:37:11 -04:00
trop[bot]
71e00fdbcf
fix: ensure utilityProcess only emits one 'exit' event ( #44265 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-16 16:34:09 -04:00
trop[bot]
92ed2a898d
fix: trace-startup crashing child process on macOS ( #44275 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-10-16 16:33:45 -04:00
trop[bot]
4241045017
fix: use proper PDF save approach ( #44279 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-16 13:52:17 -04:00
trop[bot]
354d6155d8
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44259 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-15 23:31:35 -05:00
electron-roller[bot]
36b7cf341e
chore: bump chromium to 131.0.6776.0 (main) ( #44137 )
...
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs 4017a6c8b4
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
https://github.com/nodejs/node/pull/54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092fc51 .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-15 11:51:11 -04:00
Niklas Wenzel
72802c374b
docs: add section on resource management to base-window.md ( #43610 )
2024-10-15 11:49:54 -04:00
David Sanders
d3e368003b
ci: use env variable in branch created workflow ( #44240 )
2024-10-15 11:16:04 -04:00
dependabot[bot]
0064b23440
build(deps): bump github/codeql-action from 3.26.12 to 3.26.13 ( #44239 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.12 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c36620d31a...f779452ac5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 10:51:34 +02:00
Shelley Vohr
1cab6bde94
build: update devcontainer sha ( #44229 )
2024-10-15 10:35:43 +02:00
George Xu
9ecb848c67
docs: update timelines for E34 ( #44210 )
...
update dates for e34
2024-10-14 10:52:18 -04:00
John Kleinschmidt
48156aee06
test: run visibility-state-spec.ts first ( #44206 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2024-10-14 09:40:22 -04:00
Charles Kerr
566c72cd46
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44211 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
* refactor: restore node buffer span util
* refactor: remove redundant span wrapper
2024-10-14 10:46:24 +02:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:33:53 -04:00
Charles Kerr
527efc01a4
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44185 )
2024-10-11 14:29:00 -05:00
dependabot[bot]
6c1b377192
build(deps): bump actions/checkout from 4.1.7 to 4.2.1 ( #44140 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...eef61447b9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 12:28:45 -05:00
dependabot[bot]
13b39e0eeb
build(deps): bump github/codeql-action from 3.26.8 to 3.26.12 ( #44139 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.8 to 3.26.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](294a9d9291...c36620d31a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:32:17 +02:00
Samuel Attard
7402648ee3
build: update ts defs and docs parser ( #43985 )
...
* build: update ts defs and docs parser
* build: update dig
2024-10-11 10:44:18 -04:00
Niklas Wenzel
5400c04e43
docs: clarify interplay between utility process events ( #44015 )
2024-10-11 10:25:25 -04:00
Robo
dd5b36f557
fix: clang variable configuration in generated node headers ( #44189 )
...
* fix: clang variable configuration in generated node headers
* chore: restore value in common.gypi
2024-10-11 10:22:56 -04:00
John Kleinschmidt
8201623d92
test: fix visibility-state-spec.ts flaky test ( #44037 )
...
* test: refactor visibility-state-spec
* ci: shard tests
* test: update split-tests for use on Windows
* test: run visibility-state-spec.ts first
2024-10-11 10:00:22 -04:00
John Kleinschmidt
d93285dde1
ci: don't call datadog test logging on forks ( #44181 )
2024-10-11 12:08:51 +02:00
Charles Kerr
3d2f68a9df
refactor: spanify image utils ( #44127 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
* feat: add Node-buffer-to-base-span helper function
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
* refactor: use base::as_byte_span()
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
* chore: add // SAFETY comment for Node-buffer-to-span func
* chore: add // SAFETY comment for NSData-to-span func
2024-10-10 09:34:55 -04:00
Michaela Laurencin
d51ef7d794
build: update NMV to 132 ( #44135 )
...
Node PR: https://github.com/nodejs/node/pull/55306
Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34
Please merge this PR before branching 34-x-y
2024-10-09 11:55:59 -07:00
Charles Kerr
78fa477726
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44133 )
2024-10-09 13:02:00 -05:00
Charles Kerr
dbbdf55493
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44134 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
2024-10-09 12:18:19 -05:00
Charles Kerr
b5227b4a17
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 )
...
fixup e8948397 really fix the warning this time
2024-10-09 09:12:48 -05:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
John Kleinschmidt
ebeae6f301
ci: only upload to datadog when running tests ( #44152 )
2024-10-08 15:07:17 -04:00
Charles Kerr
4cf69f396f
fix: context shear in cli_remove_deprecated_v8_flag.patch ( #44148 )
...
fix: patch shear in cli_remove_deprecated_v8_flag.patch
2024-10-08 07:54:33 -07:00
electron-roller[bot]
bcbc8d3bb2
chore: bump chromium to 131.0.6762.0 (main) ( #44117 )
...
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-10-07 18:06:47 -05:00
John Kleinschmidt
aa40e817c8
ci: add datadog test logging ( #44094 )
2024-10-07 18:51:23 -04:00
electron-roller[bot]
b95ee8964c
chore: bump node to v20.18.0 (main) ( #44119 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-07 18:51:08 -04:00
electron-roller[bot]
ab1488a1be
chore: bump chromium to 131.0.6754.0 (main) ( #44110 )
...
* chore: bump chromium in DEPS to 131.0.6754.0
* chore: update gin_enable_disable_v8_platform.patch
fix minor context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5901115
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-03 13:35:03 -04:00
Samuel Attard
122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
Charles Kerr
684e345f68
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44068 )
...
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
2024-10-02 16:44:28 -04:00
Charles Kerr
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
Keeley Hammond
93dd9fc17b
build: use node 20.17 on Windows ( #44065 )
...
* build: rebake image
* build: use e-131.0.6734.0-node-20.17-0
* build: bump msvs version to 2022
2024-10-02 20:12:41 +02:00
electron-roller[bot]
59a43ef2e3
chore: bump chromium to 131.0.6752.0 (main) ( #44093 )
...
* chore: bump chromium in DEPS to 131.0.6752.0
* chore: update refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
adjust to upstream #include shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5872830
* chore: e patches all
* Remove the <selectlist> prototype implementation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5855076
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 08:35:18 -07:00
electron-roller[bot]
5a97ee26ff
chore: bump chromium to 131.0.6751.0 (main) ( #44087 )
...
chore: bump chromium in DEPS to 131.0.6751.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:30:40 -05:00
Samuel Attard
5b34138db8
build: fix relative file read during npm publish ( #44088 )
2024-10-01 17:09:57 -07:00
electron-roller[bot]
1fc2064f6a
chore: bump chromium to 131.0.6750.0 (main) ( #44066 )
...
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-01 19:34:32 -04:00
Samuel Attard
f4ffd018e6
build: cleanup release scripts, separate cli entrypoints from logic ( #44058 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 13:51:40 -07:00
Charles Kerr
15c8759ee0
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() ( #44053 )
2024-10-01 10:06:02 -07:00
Charles Kerr
06bce8166b
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44055 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
2024-10-01 10:05:46 -07:00
Charles Kerr
6f88f0c795
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44067 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-01 10:04:57 -07:00
Samuel Attard
f828c1da09
build: remove github actions dependabot on release branches ( #44054 )
2024-10-01 08:50:42 -07:00
Samuel Attard
47cf1e3acd
build: use ts-node to spawn the version-bumper ( #44057 )
...
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-09-30 21:19:59 -07:00
Samuel Attard
61565465fd
build: convert all release scripts to typescript ( #44035 )
...
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
2024-09-30 17:55:27 -07:00
Keeley Hammond
7ebc427bf5
build: update appveyor to node 20.17 ( #44026 )
...
* build: update appveyor to node 20.17
* build: bake new images with npm dir
* build: use e-131.0.6734.0-node-20.17-1
2024-09-30 16:14:46 -04:00
electron-roller[bot]
5d9800e176
chore: bump chromium to 131.0.6748.0 (main) ( #44027 )
...
* chore: bump chromium in DEPS to 131.0.6748.0
* chore: gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 13:32:50 -04:00
Charles Kerr
1d4b86cb3e
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44024 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
2024-09-30 11:01:24 -05:00
Charles Kerr
77f7ba96ca
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44014 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: remove logging
* fix: unconditionally write
* chore: naming
* chore: add code comments
* chore: more code comments
* chore: remove unrelated changes
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: naming
* refactor: naming
* refactor: naming
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
2024-09-30 15:09:36 +02:00
electron-roller[bot]
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 14:54:44 +02:00
Charles Kerr
eb40d2cbfa
fix: FTBFS when building with enable_plugins = false ( #44003 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
2024-09-29 17:10:34 -05:00
John Kleinschmidt
27d2a8f9e2
ci: write test logging to console on Windows ( #43990 )
...
test: write logging to console on Windows
2024-09-27 15:17:32 -04:00
Shelley Vohr
d4e4cdee6c
fix: remove resize listener when BrowserWindow closed ( #43972 )
2024-09-27 10:34:00 -04:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-27 10:17:06 +09:00
Charles Kerr
8397fef3ef
chore: remove unused nogncheck includes ( #43964 )
2024-09-26 17:09:42 -05:00
Charles Kerr
852f9ff329
perf: build g_dgettext domain name at compile time ( #43960 )
...
perf: build GettextPackage name at compile time
2024-09-26 13:10:30 -04:00
Charles Kerr
a974b74e82
fix: replace deprecated libnotify API calls ( #43962 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 11:21:45 -05:00
Shelley Vohr
da6ab92353
fix: ensure correct WebContents when checking PDFReadyToPrint ( #43943 )
...
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
2024-09-26 10:54:13 -04:00
Charles Kerr
ddd45db6ca
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43956 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
2024-09-26 08:32:43 -05:00
John Kleinschmidt
40cae71df8
test: re-enable tests that were disabled in chromium rolls ( #43968 )
...
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
2024-09-26 08:53:27 -04:00
electron-appveyor-updater[bot]
b60013fcf1
build: update appveyor image to latest version ( #43971 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-26 13:10:34 +02:00
Samuel Attard
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
Fedor Indutny
15db63e26d
fix: SCContentSharingPicker crash in iframes ( #43905 )
...
When running `getDisplayMedia` from an `iframe` and then destroying that
`iframe`, the destrutcor for ScreenCaptureKitDeviceMac gets run, but it
doesn't clean up the observers for the shared macOS picker.
In this change we remove the observer on cleanup and fix the associated
crash:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x12c024123a0> was mutated while being enumerated.'
0 CoreFoundation 0x000000018eda0ec0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018e886cd8 objc_exception_throw + 88
2 CoreFoundation 0x000000018ee47f80 -[__NSSingleObjectEnumerator init] + 0
3 ScreenCaptureKit 0x000000022971f3e0 -[SCContentSharingPicker contentPickerDidSelectFilter:forStream:] + 436
4 ReplayKit 0x00000001d7b879d8 -[RPScreenRecorder contentPickerDidSelectFilter:forStream:] + 84
5 ReplayKit 0x00000001d7b95ce0 -[RPDaemonProxy contentPickerDidSelectFilter:forStream:] + 224
6 CoreFoundation 0x000000018ed0e8b4 __invoking___ + 148
7 CoreFoundation 0x000000018ed0e72c -[NSInvocation invoke] + 428
8 ReplayKit 0x00000001d7b91678 -[RPDaemonProxy connection:handleInvocation:isReply:] + 316
9 Foundation 0x0000000190899f64 -[NSXPCConnection _decodeAndInvokeMessageWithEvent:reply:flags:] + 1108
10 Foundation 0x000000019089b7d0 message_handler_message + 88
11 Foundation 0x000000018feb0160 message_handler + 152
12 libxpc.dylib 0x000000018e954460 _xpc_connection_call_event_handler + 144
13 libxpc.dylib 0x000000018e952bb4 _xpc_connection_mach_event + 1120
14 libdispatch.dylib 0x000000018ea94718 _dispatch_client_callout4 + 20
15 libdispatch.dylib 0x000000018eab0c00 _dispatch_mach_msg_invoke + 464
16 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
17 libdispatch.dylib 0x000000018eab1954 _dispatch_mach_invoke + 456
18 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
19 libdispatch.dylib 0x000000018ea9c79c _dispatch_lane_invoke + 432
20 libdispatch.dylib 0x000000018eaa77e8 _dispatch_root_queue_drain_deferred_wlh + 288
21 libdispatch.dylib 0x000000018eaa7034 _dispatch_workloop_worker_thread + 540
22 libsystem_pthread.dylib 0x000000018ec433d8 _pthread_wqthread + 288
23 libsystem_pthread.dylib 0x000000018ec420f0 start_wqthread + 8
2024-09-25 16:43:23 -07:00
dependabot[bot]
ff36ff84b7
build(deps-dev): bump eslint-plugin-promise from 4.3.1 to 7.1.0 ( #43935 )
...
Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise ) from 4.3.1 to 7.1.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-promise/releases )
- [Changelog](https://github.com/eslint-community/eslint-plugin-promise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint-community/eslint-plugin-promise/compare/v4.3.1...v7.1.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-promise
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 16:49:03 -05:00
dependabot[bot]
846b31b77d
build(deps-dev): bump @types/chai-as-promised from 7.1.3 to 8.0.1 ( #43936 )
...
Bumps [@types/chai-as-promised](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai-as-promised ) from 7.1.3 to 8.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai-as-promised )
---
updated-dependencies:
- dependency-name: "@types/chai-as-promised"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 09:06:26 -05:00
John Beutner
c8895d0547
fix: close all open sheets before closing window on macOS ( #43706 )
2024-09-25 13:23:49 +02:00
Charles Kerr
1d3b1284c4
test: ensure sender-pid hint is set in Linux notifications ( #43928 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
2024-09-25 13:20:36 +02:00
electron-roller[bot]
30fbeec036
chore: bump chromium to 131.0.6734.0 (main) ( #43769 )
...
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119 : Declutter: Allow opening to a specific feature
https://chromium-review.googlesource.com/c/chromium/src/+/5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
https://chromium-review.googlesource.com/c/chromium/src/+/5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-09-25 06:19:39 -05:00
Charles Kerr
af54c5a4b6
test: add tests dbus notification images ( #43938 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
2024-09-25 13:17:27 +02:00
Shelley Vohr
bcf4095ace
fix: crash when focusing WebView webContents ( #43921 )
...
fix: crash when focusing WebView
2024-09-24 18:19:04 -05:00
Charles Kerr
500d4f0d05
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43896 )
2024-09-24 15:41:24 -05:00
CezaryKulakowski
e64a66bfd3
fix: detach native view when its removed from parent on macOS ( #43627 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
2024-09-24 15:28:36 +02:00
dependabot[bot]
7222a9fe1f
build(deps-dev): bump null-loader from 4.0.0 to 4.0.1 ( #43904 )
...
Bumps [null-loader](https://github.com/webpack-contrib/null-loader ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/webpack-contrib/null-loader/releases )
- [Changelog](https://github.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/null-loader/compare/v4.0.0...v4.0.1 )
---
updated-dependencies:
- dependency-name: null-loader
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 10:13:43 +02:00
dependabot[bot]
65e3c336e0
build(deps-dev): bump eslint from 8.41.0 to 8.57.1 ( #43903 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.41.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.41.0...v8.57.1 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:31:47 -07:00
Charles Kerr
79627deea3
refactor: add SerialChooserController::web_contents_ ( #43823 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
2024-09-23 22:38:13 -07:00
Charles Kerr
9598d88b7c
refactor: remove C-style void arg type for no-arg functions ( #43884 )
...
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-23 22:37:32 -07:00
Charles Kerr
01330805cb
refactor: prefer member initializers in asar structs ( #43883 )
...
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
2024-09-23 22:37:18 -07:00
Charles Kerr
33d7c9ac3e
refactor: hide printing impl details in api::WebContents ( #43893 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
* refactor: remove unused #include
2024-09-23 22:36:55 -07:00
Keeley Hammond
a3af8ea768
build: use Node 20 in Appveyor images ( #43897 )
...
* build: update Appveyor to Node 20
* build: update appveyor images
* chore: return bake script to original form
2024-09-23 16:58:46 -07:00
dependabot[bot]
82879d1f43
build(deps-dev): bump webpack-cli from 4.10.0 to 5.1.4 ( #43880 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.10.0 to 5.1.4.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.10.0...webpack-cli@5.1.4 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 18:21:43 -05:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Alice Zhao
ceea1225a2
docs: navigation history example ( #42980 )
...
* docs: add fiddle example
* docs: add tutorial guide
* refactor: PR review comments
* refactor: add eof
* refactor: render navigation history and make demo better.
* refactor: fix broken links
* refactor: add eof newline
* docs: review feedback :)
* chore: lint add space around list
* doc: transformURL
2024-09-23 10:18:26 -07:00
Samuel Attard
517d04de16
build: add support for fetching github token from sudowoodo ( #43808 )
...
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 09:39:54 -07:00
dependabot[bot]
f0afcaa777
build(deps-dev): bump @types/w3c-web-serial from 1.0.3 to 1.0.7 ( #43879 )
...
Bumps [@types/w3c-web-serial](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/w3c-web-serial ) from 1.0.3 to 1.0.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/w3c-web-serial )
---
updated-dependencies:
- dependency-name: "@types/w3c-web-serial"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 08:07:53 -05:00
Samuel Attard
be68d4f336
build: update-check-skip on dependabot backport PRs ( #43874 )
2024-09-23 11:08:03 +02:00
dependabot[bot]
0fb50c408b
build(deps): bump github/codeql-action from 3.26.7 to 3.26.8 ( #43826 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8214744c54...294a9d9291 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 11:04:21 +02:00
dependabot[bot]
1b52f005ee
build(deps): bump actions/setup-node from 4.0.3 to 4.0.4 ( #43825 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1e60f620b9...0a44ba7841 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-22 23:40:30 -07:00
Samuel Attard
da449b00dd
build: stop dependabot doing things ( #43871 )
2024-09-22 23:10:23 -07:00
Samuel Attard
8be458d1a2
build: enable dependabot on supported branches ( #43755 )
2024-09-22 22:57:23 -07:00
Charles Kerr
e894839709
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43803 )
2024-09-21 17:21:02 -05:00
Shelley Vohr
f89bd745d5
fix: createWindow shouldn't load URL for webContents ( #43775 )
...
* fix: createWindow shouldn't load URL for webContents
* chore: add non about blank test
2024-09-20 09:56:03 +02:00
Charles Kerr
bcb7362ab9
docs: document Windows pitfall when updating patches ( #43787 )
2024-09-19 23:35:21 -05:00
Charles Kerr
53e89b565d
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43795 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
* chore: add a DCHECK to confirm the BigBuffer is full
2024-09-19 23:10:35 -05:00
Fedor Indutny
6aa6bada79
fix: third time screen sharing on macOS ( #43767 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com >
2024-09-19 18:28:28 -07:00
Charles Kerr
d100921289
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43794 )
2024-09-19 19:02:49 -05:00
BILL SHEN
855f219301
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43773 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
2024-09-19 13:01:36 +02:00
dependabot[bot]
0ac8ff6439
build(deps): bump path-to-regexp from 1.8.0 to 1.9.0 in /spec in the npm_and_yarn group across 1 directory ( #43753 )
...
build(deps): bump path-to-regexp
Bumps the npm_and_yarn group with 1 update in the /spec directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp ).
Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 10:34:06 +02:00
Charles Kerr
5904d31264
perf: hold V8FunctionInvoker args in a std::array ( #43752 )
...
perf: hold V8FunctionInvoker args in a std::array
2024-09-18 16:23:29 -05:00
Samuel Attard
8cff5a7d20
build: let darwin/mas run concurrently ( #43788 )
2024-09-18 13:54:58 -07:00
Charles Kerr
d897359b82
perf: hold Emit() arg arrays in a std::array ( #43750 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
2024-09-18 09:40:14 -05:00
electron-appveyor-updater[bot]
02fd8bbcc1
build: update appveyor image to latest version ( #43772 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-18 09:39:49 -05:00
electron-roller[bot]
4bcbc955dd
chore: bump chromium to 130.0.6695.0 (main) ( #43454 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2024-09-17 18:12:11 -07:00
Samuel Attard
de33cc68f6
build: split darwin/mas macOS publish jobs ( #43754 )
2024-09-17 15:32:47 -07:00
Samuel Attard
f987f8ad83
build: improve logging on http errors during release process (again, but more) ( #43758 )
2024-09-17 15:01:02 -07:00
Samuel Attard
cf4ab2186c
build: improve logging on http errors during release process (again) ( #43757 )
2024-09-17 14:49:59 -07:00
Samuel Attard
10ba87a85e
build: improve logging on http errors during release process ( #43756 )
2024-09-17 14:30:51 -07:00
Charles Kerr
233724fe00
chore: iwyu mojom-forward header files ( #43741 )
...
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-17 12:58:56 -07:00
dependabot[bot]
4dc923a327
build(deps): bump the npm_and_yarn group across 2 directories with 5 updates ( #43681 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [send](https://github.com/pillarjs/send ).
Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0 )
Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases )
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/body-parser/compare/1.20.2...1.20.3 )
Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10 )
Updates `serve-static` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/expressjs/serve-static/releases )
- [Changelog](https://github.com/expressjs/serve-static/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/serve-static/compare/v1.15.0...1.16.0 )
Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases )
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md )
- [Commits](https://github.com/pillarjs/send/compare/0.16.2...0.19.0 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: body-parser
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: serve-static
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: send
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-17 11:27:32 -04:00
Charles Kerr
5a76655fb8
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43729 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
2024-09-17 09:00:52 -05:00
Shelley Vohr
aa719a4066
fix: resizing border on Linux WCO caption buttons ( #43724 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
2024-09-17 11:56:43 +02:00
Samuel Attard
c1c8fbfd9a
build: make is_mas_build a generated header instead of config ( #43737 )
2024-09-17 01:38:56 -07:00
dependabot[bot]
b83810982e
build(deps): bump github/codeql-action from 3.26.6 to 3.26.7 ( #43738 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.6 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4dd16135b6...8214744c54 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-16 23:09:24 -05:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
05dfd14913
refactor: add EmitWarning(v8::Isolate*) helper ( #43722 )
...
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-16 15:53:04 -05:00
John Kleinschmidt
7d4f202c1c
ci: move Archaeologist to GHA ( #43701 )
...
* chore: move Archaeologist to GHA
* chore: test archaelogist changes
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a .
* chore: properly name steps in archaeologist-dig
2024-09-16 15:58:51 -04:00
Niklas Wenzel
f84ffc8fc8
fix: prevent loading spinner when launching utility process on Windows ( #43657 )
...
fix: prevent spinning cursor when launching utility process on Windows
2024-09-16 14:20:42 -04:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Charles Kerr
1c3a5ba5d1
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43690 )
...
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-12 15:44:14 -05:00
Piotr Płaczek
29c2744e57
feat: hide menu bar on windows fullscreen ( #43402 )
...
* feat: hide menu bar on windows fullscreen
* test: state prior to html fullscreen transition
* refactor: restore `#ifdef` for readability
Reference: https://github.com/electron/electron/pull/43402#discussion_r1729356262
* docs: menu bar behavior changed
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-12 20:13:04 +02:00
Charles Kerr
3dd7e46291
refactor: avoid minor code repetition in native_image.cc ( #43689 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
2024-09-12 10:56:15 -05:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Shelley Vohr
3c8321a987
fix: EyeDropper working in devtools ( #43685 )
2024-09-12 15:40:56 +02:00
Shelley Vohr
74b54278bf
fix: native View wrapper crash missing when adding child view ( #43638 )
...
fix: native View wrapper crash missing when adding child view
2024-09-12 10:01:05 +02:00
Shelley Vohr
dea6a4e5fb
fix: ensure SetPluginCanSave updated in PDFs ( #43667 )
...
fix: ensure SetPluginCanSave updated in PDFs
2024-09-11 09:25:05 -04:00
Shelley Vohr
90fbf30491
build: compile Node.js with C++20 support ( #43555 )
...
* build: compile with C++20 support
* build: update build-image-sha for gcc 10
2024-09-11 09:01:46 -04:00
dependabot[bot]
5580349c3a
build(deps-dev): bump webpack from 5.76.0 to 5.94.0 in the npm_and_yarn group across 1 directory ( #43659 )
...
build(deps-dev): bump webpack
Bumps the npm_and_yarn group with 1 update in the / directory: [webpack](https://github.com/webpack/webpack ).
Updates `webpack` from 5.76.0 to 5.94.0
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.0...v5.94.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 09:56:03 +02:00
Keeley Hammond
309d5dade3
feat: add support for system picker in setDisplayMediaRequestHandler ( #43581 )
...
* tmp
* feat: add support for system picker in setDisplayMediaRequestHandler
* oops
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* stuff
* well...
* seems legit
* chore: update patch to handle screenCapturer
* feat: modify API to use useSystemPicker
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
* fix: don't use native picker with legacy media selection
* chore: code review, boolean set & docs update
* fix: add cancelCallback
* docs: clarify session & desktopCapturer docs
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-09-10 16:05:57 -07:00
Charles Kerr
a3df950281
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() ( #43642 )
2024-09-10 15:05:05 -05:00
Milan Burda
0cc60500ed
fix: restore Chromium default Content-Disposition header parsing ( #43611 )
...
* fix: restore Chromium default Content-Disposition header parsing
* Update api-web-request-spec.ts
2024-09-10 15:32:30 +02:00
Charles Kerr
f1019c2c4a
fix: -Wunsafe-buffer-usage warnings in asar file IO ( #43624 )
...
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()
* fix: -Wunsafe-buffer-usage warnings in Archive::Init()
2024-09-09 16:34:42 -04:00
Charles Kerr
5718ea4e1e
fix: out-of-scope Local handle in node::CallbackScope ( #43622 )
...
refactor: use an EscapableHandleScope
2024-09-09 12:14:40 -05:00
Charles Kerr
2844e346b9
refactor: use std::optional in MicrotasksScope ( #43621 )
...
avoid an unnecessary heap allocation/free
2024-09-09 12:51:42 -04:00
Zorro Liu
e2fe8f50e2
fix: update BrowserView#lastWindowSize after window resize ( #43463 )
...
fix: update BrowserView#lastWindowSize after window resize (#43462 )
2024-09-09 14:22:30 +02:00
Charles Kerr
8c5e7bbf6b
fix: UvHandle move semantics ( #43615 )
...
reassign the uv_handle_t of the source
2024-09-09 14:13:39 +02:00
dependabot[bot]
0d4d752c1b
build(deps): bump the npm_and_yarn group across 2 directories with 3 updates ( #43511 )
...
* build(deps): bump the npm_and_yarn group across 2 directories with 3 updates
Bumps the npm_and_yarn group with 1 update in the / directory: [braces](https://github.com/micromatch/braces ).
Bumps the npm_and_yarn group with 3 updates in the /spec directory: [braces](https://github.com/micromatch/braces ), [pdfjs-dist](https://github.com/mozilla/pdf.js ) and [ws](https://github.com/websockets/ws ).
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `pdfjs-dist` from 2.16.105 to 4.2.67
- [Release notes](https://github.com/mozilla/pdf.js/releases )
- [Commits](https://github.com/mozilla/pdf.js/compare/v2.16.105...v4.2.67 )
Updates `ws` from 7.5.9 to 7.5.10
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.5.9...7.5.10 )
---
updated-dependencies:
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: pdfjs-dist
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: ws
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: update api-web-contents-spec to us newer version of pdfjs-dist
* test: create fixture to read PDF files for verification
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-09 11:49:43 +02:00
Charles Kerr
0568686340
perf: avoid redundant Promise.GetContext calls ( #43609 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
2024-09-07 23:39:42 -05:00
Charles Kerr
44a4328ea8
refactor: take a uint8_t span in ValidateIntegrityOrDie() ( #43592 )
...
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
2024-09-06 20:22:44 -05:00
Charles Kerr
18b1b33adc
refactor: NativeWindow::Create() returns a unique_ptr ( #43576 )
...
refactor: NativeWindow::Create() returns a unique_ptr
2024-09-06 12:59:32 -04:00
Charles Kerr
fe0d4274e2
fix: confirm a v8::Value is a v8::Object before casting it ( #43575 )
...
fix: confirm a v8::Value is a v8::Object before casting it
2024-09-06 11:20:04 -05:00
Charles Kerr
cc5aa65cb4
fix: delete UvTaskRunner's timers only after they're closed ( #43561 )
...
* fix: free UvTaskRunner timers only after they are closed
* refactor: UvTaskRunner now holds UvHandles
2024-09-06 07:16:56 -05:00
Shelley Vohr
25f4691e78
fix: ensure version of xdg-dialog-portal with defaultPath support ( #43570 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
Closes https://github.com/electron/electron/issues/43310
2024-09-06 11:12:16 +02:00
Charles Kerr
3fde574db1
fix: -Wunsafe-buffer-usage warnings in url-loader ( #43564 )
...
Use v8::ArrayBufferView::CopyContents() instead of doing the pointer
math + memcpy() ourselves. This not only solves the buffer warnings,
but may also avoid some additional overhead:
> Copy the contents of the ArrayBufferView's buffer to an
> embedder defined memory without additional overhead that
> calling ArrayBufferView::Buffer might incur.
2024-09-05 20:22:03 -05:00
Shelley Vohr
eff862b083
build: use proper targets for building ( #43550 )
2024-09-05 17:03:07 -04:00
Kilian Valkhof
32d5f9e3ef
docs: explain ipcRenderer behavior in context-bridge.md ( #43455 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev >
* Update context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Erik Moura <erikian@erikian.dev >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-09-05 16:48:22 -04:00
Orko Garai
69df09dc90
fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland ( #43480 )
...
* fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland
Ensure apps are launched with the activation token received from
xdg_activation_v1 protocol.
* add focus_launched_process option
2024-09-05 13:07:10 -05:00
dependabot[bot]
6aae1264dd
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43530 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 11:26:17 -05:00
dependabot[bot]
4b5a831979
build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 ( #43528 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.6 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](834a144ee9...50769540e7 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 12:04:52 +02:00
David Sanders
2c3840af76
ci: remove blocked/need-info label on user comment ( #43562 )
2024-09-05 10:12:02 +02:00
John Kleinschmidt
73d480d401
build: fix telemetry error when using autoninja ( #43563 )
2024-09-05 10:08:27 +02:00
Charles Kerr
2d868ecb8d
perf: use v8::Local<v8::Object> as the key in ObjectCache ( #43519 )
...
* perf: use v8::Object* as direct keys instead of using hash + a linked list
* refactor: use v8::Local<v8::Object> as the key
2024-09-04 22:53:06 -05:00
Charles Kerr
0467790aee
chore: migrate to v8::Object::SetPrototypeV2() ( #43535 )
...
chore: migrate to v8::Object::SetPrototypeV2().
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5600627
[api] Mark v8::Object::GetPrototype() for deprecation
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 20:30:54 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final ( #43527 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-04 18:40:02 -05:00
Keeley Hammond
94f2722fa3
build: don't run symbol generation on PS ( #43554 )
...
fix: don't run symbol generation on PS
2024-09-04 17:18:57 +01:00
Charles Kerr
054cbcd6eb
fix: don't use deprecate-soon class v8::String::Value ( #43518 )
...
* fix: remove use of deprecated v8::String::Value
Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.
The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().
Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk
v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)
History on why we used it:
80c1a9739d
f49ed30f72
* Update shell/common/gin_converters/file_path_converter.h
Co-authored-by: Robo <hop2deep@gmail.com >
* fixup! Update shell/common/gin_converters/file_path_converter.h
do not return success for all non-Null non-Strings
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2024-09-04 08:56:14 -05:00
dependabot[bot]
4c83016cf3
build(deps): bump github/codeql-action from 3.26.3 to 3.26.6 ( #43529 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.3 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](883d8588e5...4dd16135b6 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-04 09:35:09 -04:00
Orko Garai
53dcda1fe9
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app ( #43481 )
...
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
2024-09-04 12:54:00 +02:00
George Xu
635d421123
fix: systemMediaPermissionDenied should not check camera perms when the request is asking for screen share ( #43517 )
...
* fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera
* Revert "fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera"
This reverts commit e9cc672165 .
* should only do these checks for audio or video, but not screenshare
* no service
* oops
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 09:56:26 +01:00
Charles Kerr
b42c0ae00d
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() ( #43477 )
...
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()
* chore: improve code comments for CheckCommandLineArguments()
* chore: reduce diffs from main
* refactor: CheckCommandLineArguments takes a StringVector arg
Fixes another buffer warning!
2024-09-03 21:51:39 -04:00
John Kleinschmidt
90ba2df4fa
build: free up macos disk space as soon as possible ( #43533 )
...
* chore: free up macos disk space as soon as possible
* build: free up disk space on gn check too
2024-09-03 21:32:05 -04:00
John Kleinschmidt
c41a28d7c8
chore: speed up cache only reclient for fork PRs ( #43497 )
2024-08-29 13:51:06 -04:00
Robo
41b8fdca5c
fix: devtools dock state with WCO on linux ( #43490 )
2024-08-29 09:17:00 +09:00
electron-roller[bot]
38512efd25
chore: bump node to v20.17.0 (main) ( #43428 )
...
* chore: bump node in DEPS to v20.17.0
* module: disallow CJS <-> ESM edges in a cycle from require(esm)
https://github.com/nodejs/node/pull/52264
* src: expose LookupAndCompile with parameters
https://github.com/nodejs/node/pull/53886
* src: fix -Wshadow warning
https://github.com/nodejs/node/pull/53885
* lib: convert WeakMaps in cjs loader with symbol properties
https://github.com/nodejs/node/pull/52095
* src: reduce unnecessary serialization of CLI options in C++
https://github.com/nodejs/node/pull/52451
* build: ensure v8_pointer_compression_sandbox is enabled on 64bit
https://github.com/nodejs/node/pull/53884
* lib: improve error message when index not found on cjs
https://github.com/nodejs/node/pull/53859
* src,lib: expose getCategoryEnabledBuffer to use on node.http
https://github.com/nodejs/node/pull/53602
* deps: update c-ares to v1.32.2
https://github.com/nodejs/node/pull/53865
* chore: fixup patch indices
* deps: update V8 to 12.2
https://github.com/nodejs/node/pull/51362
* stream: Expose DuplexPair API
https://github.com/nodejs/node/pull/34111
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-26 15:09:33 -04:00
Charles Kerr
7cea992926
refactor: simplify KeyWeakMap impl ( #43461 )
2024-08-26 13:19:05 -05:00
Charles Kerr
2390706030
refactor: prefer std::ranges over begin() and end() ( #43464 )
2024-08-26 10:58:32 -04:00
David Sanders
56829f75c1
chore: cleanup include groupings ( #43478 )
2024-08-26 10:44:20 -04:00
Charles Kerr
5994b34a5d
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha ( #43448 )
...
added in Aug 2021 (41646d11 , #29600 ) but never used
2024-08-23 20:59:41 -05:00
electron-appveyor-updater[bot]
e6555ac5e1
build: update appveyor image to latest version ( #43451 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-23 18:36:32 -04:00
Charles Kerr
5a1eeea102
perf: prefer GURL string_view getters ( #43443 )
...
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()
* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()
* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()
* refactor: add std::less<> to HandlersMap
This lets us search it using string_view keys
* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view
* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()
* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view
* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
2024-08-23 17:15:45 -05:00
Charles Kerr
7f34b0e6f5
chore: remove unused method asar::ClearArchives() ( #43442 )
...
chore: remove unused asar::ClearArchives()
last use removed in Jun 2021 (b1d1ac65 , #29293 )
2024-08-23 14:53:01 -05:00
John Kleinschmidt
c1eee18e41
test: add -pdf-ready-to-print event to WebContents for testing ( #43436 )
2024-08-23 12:34:26 -05:00
Charles Kerr
9ce0ca74c3
build: remove fix_disable_scope_reuse_associated_dchecks.patch ( #43441 )
...
chore: remove fix_disable_scope_reuse_associated_dchecks.patch
2024-08-23 11:04:20 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43430 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
2024-08-23 11:02:43 -04:00
Shelley Vohr
6e4d90fcdb
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43431 )
...
* fix: ensure bounds stability in OnWidgetBoundsChanged
* Update shell/browser/native_window_views.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-23 11:02:05 -04:00
Erick Zhao
fd8d9f06fd
chore: mention signed commit requirement ( #43406 )
...
chore: mentioned signed commit requirement
2024-08-23 15:52:33 +02:00
Alexander Cyon
ca0837c852
chore: fix typos in 'shell/' folder. ( #43373 )
2024-08-22 19:48:32 -05:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering ( #42953 )
...
* feat: GPU shared texture offscreen rendering
* docs: clarify texture infos that passed by the paint event.
* feat: make gpu osr spec test optional
* fix: osr image compare
* fix: remove duplicate test
* fix: update patch file
* fix: code review
* feat: expose more metadata
* feat: use better switch design
* feat: add warning when user forget to release the texture.
* fix: typo
* chore: update patch
* fix: update patch
* fix: update patch description
* fix: update docs
* fix: apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: apply suggested fixes
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-22 19:23:13 -05:00
electron-roller[bot]
b481966f02
chore: bump chromium to 130.0.6672.0 (main) ( #43445 )
...
chore: bump chromium in DEPS to 130.0.6672.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-22 18:27:25 -05:00
electron-roller[bot]
baf0182a42
chore: bump chromium to 130.0.6671.0 (main) ( #43429 )
...
* chore: bump chromium in DEPS to 130.0.6671.0
* 5802591: [Partitioned Popins] (6) Add permissions policy for popin
https://chromium-review.googlesource.com/c/chromium/src/+/5802591
* 5794132: [video pip] Move back to tab button to the header
https://chromium-review.googlesource.com/c/chromium/src/+/5794132
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-22 13:16:40 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Shelley Vohr
7391db93e2
build: roll sysroots ( #43261 )
2024-08-22 16:22:12 +02:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors ( #43366 )
...
chore: fix typos in 'docs/' folder.
2024-08-22 15:44:55 +02:00
Alexander Cyon
ae0c8881c3
chore: fix typos in 'spec/' folder (and one in 'lib/' folder) ( #43374 )
2024-08-22 15:44:15 +02:00
Shelley Vohr
4ae43dcb3b
fix: touch bar functionality on BaseWindow ( #43353 )
...
* fix: touch bar functionality on BaseWindow
* test: add test for BaseWindow.setTouchBar
2024-08-22 12:48:25 +02:00
electron-appveyor-updater[bot]
46bed807ca
build: update appveyor image to latest version ( #43369 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-22 10:12:57 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification ( #43377 )
...
* docs: clarify icon value in Notification
* Update docs/api/notification.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-08-21 19:38:06 -05:00
Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace ( #43372 )
2024-08-21 15:26:06 -05:00
electron-roller[bot]
f366caac84
chore: bump chromium to 130.0.6669.0 (main) ( #43397 )
...
* chore: bump chromium in DEPS to 130.0.6669.0
* 5789734: Consolidate all the accessibility scale factor utility code into one file
https://chromium-review.googlesource.com/c/chromium/src/+/5789734
* 5798543: [autofill] Don't emit autofill audit reports if inspector not connected
https://chromium-review.googlesource.com/c/chromium/src/+/5798543
* 5797073: [wasm] Spill all loop inputs before entering loop
https://chromium-review.googlesource.com/c/v8/v8/+/5797073
* chore: fixup patch indices
* 5795224: Version 13.0.0
https://chromium-review.googlesource.com/c/v8/v8/+/5795224
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-21 12:34:18 -04:00
David Sanders
4874233aae
chore: set wg-infra as CODEOWNER for GHA build configs ( #43223 )
...
* chore: set wg-releases as CODEOWNER for GHA build configs
* chore: change to wg-infra
2024-08-21 10:49:22 +02:00
David Sanders
b7af0537c8
docs: update timelines for E33 ( #43389 )
2024-08-20 15:47:32 -07:00
Keeley Hammond
7da9c0b2f7
docs: update window customization tutorial ( #43388 )
2024-08-20 15:29:01 -07:00
Shelley Vohr
46af43db49
chore: cherry-pick 9797576 from v8 ( #43376 )
2024-08-20 16:49:02 -04:00
Charles Kerr
93a6f3e607
refactor: NodeBindings::Create() returns a unique_ptr ( #43361 )
...
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
2024-08-20 15:34:59 -04:00
Charles Kerr
a2de94dda1
chore: remove unused ConvertableToTraceFormatWrapper ( #43356 )
...
* chore: remove unused ConvertableToTraceFormatWrapper
Last use removed in Apr 2024 (39bf441b , #41880 )
* fixup! chore: remove unused ConvertableToTraceFormatWrapper
remove now-unused trace_event.h header, too
2024-08-20 15:21:43 -04:00
electron-roller[bot]
2cc14c6e8f
chore: bump chromium to 129.0.6668.0 (main) ( #43368 )
...
* chore: bump chromium in DEPS to 129.0.6668.0
* 5787687: [Extensions] Remove EventRouterForwarder from BrowserProcess
https://chromium-review.googlesource.com/c/chromium/src/+/5787687
* 5788808: Resolve Blob URL's origin using info from browser process
https://chromium-review.googlesource.com/c/chromium/src/+/5788808
* chore: fixup patch indices
* 5786747: Remove "int WriteFile"
https://chromium-review.googlesource.com/c/chromium/src/+/5786747
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-20 16:54:27 +02:00
dependabot[bot]
945aabfaee
build(deps): bump github/codeql-action from 3.26.0 to 3.26.3 ( #43365 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.0 to 3.26.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](eb055d739a...883d8588e5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-20 13:11:50 +02:00
Charles Kerr
3186c2f0ef
refactor: remove unused SetWMSpecState ( #43347 )
...
last use removed in Aug 2022 by 53cd2315 #35179
2024-08-19 17:15:19 -04:00
Charles Kerr
44e4e4521c
chore: remove unused method Erase() ( #43348 )
...
Last use removed in Mar 2018 by 4b39d17e
2024-08-19 17:14:57 -04:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
electron-roller[bot]
4c3014944c
chore: bump chromium to 129.0.6664.0 (main) ( #43329 )
...
* chore: bump chromium in DEPS to 129.0.6657.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6658.0
* chore: update patches
* 5743786: [ServiceWorker] Populate service worker start token to WorkerId.
https://chromium-review.googlesource.com/c/chromium/src/+/5743786
* 5784424: [Extensions] Move ownership of Dispatcher to ExtensionsRendererClient
https://chromium-review.googlesource.com/c/chromium/src/+/5784424
* chore: bump chromium in DEPS to 129.0.6659.0
* chore: bump chromium in DEPS to 129.0.6660.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6662.0
* chore: bump chromium in DEPS to 129.0.6664.0
* 5789627: [Partitioned Popins] (3) `popin` feature triggers third-party storage partitioning
https://chromium-review.googlesource.com/c/chromium/src/+/5789627
* 5791367: Remove some chrome:: namespace from chrome/browser/app_mode/*
https://chromium-review.googlesource.com/c/chromium/src/+/5791367
* 5791522: [SCK] Skip redundant getShareableContentWithCompletionHandler
https://chromium-review.googlesource.com/c/chromium/src/+/5791522
* 5761330: Send refresh rate prefs b/w RefreshRateController and DisplayPrivate
https://chromium-review.googlesource.com/c/chromium/src/+/5761330
* chore: fixup patch indices
* 5793591: Remove unused GetHeader overload
https://chromium-review.googlesource.com/c/chromium/src/+/5793591
* 5787624: [Extensions] Simplify ExtensionsRendererClient::RenderThreadStarted()
https://chromium-review.googlesource.com/c/chromium/src/+/5787624
* 5721709: Fix Incorrect last_accessed_time Tracking for Tabs
https://chromium-review.googlesource.com/c/chromium/src/+/5721709
* 5789215: [Extensions] Add a //chrome/common/extensions build target
https://chromium-review.googlesource.com/c/chromium/src/+/5789215
* Roll V8 from 48f669a0758c to eee3eb91d01c
48f669a075..eee3eb91d0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-19 14:52:53 -04:00
Shelley Vohr
cc16de7032
fix: printing occasionally showing failed when cancelled ( #43337 )
...
Closes https://github.com/electron/electron/issues/36084
2024-08-19 14:25:14 -04:00
Piotr Płaczek
4d51edc504
docs: api history ( #42982 )
...
* feat(api-history): api history schema
Reference: f36e0a8483/text/0004-api-history-schema.md
* feat(api-history): add `lint:api-history` to `package.json`
* docs(api-history): add api history to `styleguide.md`
* docs(api-history): `win.flashFrame(flag)`
* docs(api-history): `new WebContentsView([options])`
* docs(api-history): non-navigation APIs on `WebContents`
* docs(api-history): `nativeImage.toDataURL`
* docs(api-history): `window.flashFrame(bool)`
* docs(api-history): `browser-view.md`
* docs(api-history): `ipcRenderer`
* docs(api-history): `protocol.*Protocol`
* revert: `new WebContentsView([options])`
This reverts commit 0a11efcf57 .
* Apply suggestions from code review
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix(api-history): remove incorrect `pr-url`
Reference: https://github.com/electron/electron/pull/42982/files#r1692532877
* docs(api-history): schema word choice
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Reference: 0b1b6a7cc0
* docs(api-history): nicer format example in `styleguide.md`
Reference: https://github.com/electron/electron/pull/42982#discussion_r1692539906
* docs(api-history): Always use double quotes for descriptions
* docs(api-history): `styleguide.md` improvements
* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`
* docs(api-history): `styleguide.md` placement
* docs(api-history): add migration guide
* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`
Reference: 7b03c0703d (r1703444772)
* docs(api-history): move migration guide
Reference: https://github.com/electron/electron/pull/42982#discussion_r1703441001
* docs(api-history): update `breaking-changer-header`
Reference: https://github.com/electron/electron/pull/43217
* docs(api-history): deprecate `browser-view.md`
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-08-19 11:17:10 -07:00
Calvin
8474bbe689
build: update NMV to 130 for Electron 33 ( #43325 )
2024-08-19 12:47:40 -04:00
Shelley Vohr
3f71ed7355
build: fix valid versions in issue version parsing ( #43346 )
2024-08-19 11:04:30 +02:00
Shelley Vohr
d7689bb9b5
docs: expand dialog window to BaseWindow ( #43334 )
...
docs: expand dialog window to BaseWindow
2024-08-16 10:49:10 -04:00
Shelley Vohr
b497700e36
test: fixup Node.js snapshot tests to run correctly ( #43332 )
2024-08-16 11:17:42 +02:00
electron-appveyor-updater[bot]
1c991ff765
build: update appveyor image to latest version ( #43331 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-15 16:09:47 -04:00
Shelley Vohr
4801a54d08
refactor: migrate deprecated platform_util_mac calls ( #43161 )
...
refactor: migrate deprecated platform_util_mac calls
2024-08-15 10:53:38 -04:00
electron-roller[bot]
a7c52f1fb2
chore: bump chromium to 129.0.6656.0 (main) ( #43323 )
...
* chore: bump chromium in DEPS to 129.0.6656.0
* chore: update patches
* 5750664: Introduce Signin.NumberOfActiveAccounts.* metrics
https://chromium-review.googlesource.com/c/chromium/src/+/5750664
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-14 16:47:37 -04:00
Shelley Vohr
286384258b
fix: blank page when printing pdf ( #43309 )
2024-08-14 15:47:47 -04:00
Shelley Vohr
f6bae51025
build: remove upstreamed DraggableRegions patch ( #43311 )
...
build: remove upstreamed patch
2024-08-14 10:11:02 -04:00
electron-appveyor-updater[bot]
ffcbc32031
build: update appveyor image to latest version ( #43318 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-14 10:10:33 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
David Sanders
62406708cd
docs: fix formatting in fuses tutorial ( #43303 )
2024-08-13 15:27:44 -04:00
electron-roller[bot]
d004329f6f
chore: bump chromium to 129.0.6654.0 (main) ( #43312 )
...
* chore: bump chromium in DEPS to 129.0.6654.0
* chore: update patches
* 5766075: Chromium UI for integration with the MacOS SCContentSharingPicker
https://chromium-review.googlesource.com/c/chromium/src/+/5766075
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-13 15:04:43 -04:00
electron-appveyor-updater[bot]
275b6a13b7
build: update appveyor image to latest version ( #43308 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-13 11:25:05 -04:00
dependabot[bot]
a9e56f2c36
build(deps): bump dsanders11/github-app-commit-action from 1.4.0 to 1.5.0 ( #43305 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](48d2ff8c1a...43de6da2f4 )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-13 15:13:55 +02:00
electron-roller[bot]
bc2628ad7e
chore: bump chromium to 129.0.6652.0 (main) ( #43298 )
...
* chore: bump chromium in DEPS to 129.0.6652.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-12 13:47:27 -04:00
Charles Kerr
bba31189a0
feat: accept-encoding zstd ( #43150 )
...
* fix: accept-encoding zstd
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
* chore: make lint happy
---------
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-08-12 10:00:04 -04:00
electron-appveyor-updater[bot]
0f55b45282
build: update appveyor image to latest version ( #43268 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-12 09:32:52 -04:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
electron-roller[bot]
c9b7806418
chore: bump chromium to 129.0.6650.0 (main) ( #43266 )
...
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b6 ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-12 10:28:33 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d3 .
2024-08-12 09:56:51 +02:00
Charles Kerr
bff298987f
chore: remove unused Notification fields icon_path_, has_icon_ ( #43286 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584 )
Last use of `has_icon_` was removed on May 30, 2017 (5048425e )
2024-08-12 09:55:54 +02:00
Shelley Vohr
6d13c503c5
refactor: update chrome.scripting extensions api impls ( #43205 )
2024-08-11 21:31:37 +02:00
Charles Kerr
7721fdf886
chore: remove unused method ElectronDesktopWindowTreeHostLinux::UpdateClientDecorationHints() ( #43283 )
...
Xref: dff980c9c2
Removed in #41868
2024-08-10 18:55:10 -05:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Charles Kerr
c4dfff9844
fix: accidental handle copying in a range loop ( #43260 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
2024-08-09 13:38:03 -05:00
Shelley Vohr
346244ef9e
build: add nacl back to buildtools gitignore ( #43238 )
2024-08-09 19:09:01 +02:00
dependabot[bot]
4edc7a4372
build(deps): bump actions/upload-artifact from 4.3.4 to 4.3.6 ( #43245 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.4 to 4.3.6.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](0b2256b8c0...834a144ee9 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-09 10:43:51 +02:00
Shelley Vohr
f49f6ff68b
fix: check screen capture permissions in desktopCapturer ( #43080 )
...
fix: check screen capture permissions in desktopCapturer
2024-08-09 10:08:49 +02:00
Shelley Vohr
0718c2b9ee
fix: system-context-menu with frameless BrowserWindows ( #43243 )
2024-08-09 10:08:01 +02:00
electron-roller[bot]
1a6563fb66
chore: bump chromium to 129.0.6644.0 (main) ( #43224 )
...
* chore: bump chromium in DEPS to 129.0.6640.0
* chore: update patches
* Reland "DEPS: update ninja to 1.12.1"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5645474
* chore: bump chromium in DEPS to 129.0.6642.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6644.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-08 17:16:59 -05:00
electron-appveyor-updater[bot]
11fdc6f78e
build: update appveyor image to latest version ( #43237 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-08 16:10:16 +02:00
dependabot[bot]
0fcc18359f
build(deps): bump github/codeql-action from 3.25.15 to 3.26.0 ( #43246 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.15 to 3.26.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](afb54ba388...eb055d739a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-08 16:09:14 +02:00
Shelley Vohr
70dda694e2
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43206 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
2024-08-07 14:51:38 +02:00
David Sanders
aa19087bed
ci: set labels on Dependabot PRs for GitHub Actions deps ( #43222 )
2024-08-07 11:57:40 +02:00
Felix Rieseberg
3fabf7837e
docs: Document ideal iconPath size ( #43149 )
2024-08-07 11:43:05 +02:00
dependabot[bot]
8d5ad8afe1
build(deps): bump mikefarah/yq from 4.44.2 to 4.44.3 ( #43220 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.2 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](f15500b20a...bbdd97482f )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-07 10:02:31 +02:00
Shelley Vohr
45891aa75b
build: fix patchup logic only running on one platform ( #43139 )
2024-08-07 10:01:59 +02:00
Charles Kerr
6293bbced0
perf: avoid redundant calls to GetView() ( #43216 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
Piotr Płaczek
f42331f277
docs: add missing deprecations to breaking-changes.md ( #43217 )
...
* docs: deprecate `BrowserView`
Reference: https://github.com/electron/electron/pull/35658
* docs: deprecate `webContents.goToIndex(index)`
Reference: https://github.com/electron/electron/pull/41752/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6R1165-R1167
* docs: deprecate some protocol methods
Reference: https://github.com/electron/electron/pull/36674/files#diff-74861ecada868821b139e79f244ea32b840a93f60de572d585117a0ff8d165c8R380
2024-08-06 09:07:36 -07:00
electron-roller[bot]
29fd2d343b
chore: bump chromium to 129.0.6638.0 (main) ( #43207 )
...
* chore: bump chromium in DEPS to 129.0.6638.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-06 17:43:48 +09:00
electron-appveyor-updater[bot]
c70f86fe03
build: update appveyor image to latest version ( #43204 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-05 16:41:40 -04:00
Samuel Attard
701a09d44f
build: use smaller instances for gn-check ( #43187 )
2024-08-05 15:42:41 -04:00
John Kleinschmidt
a4dcb0fb32
build: fixup patches in main ( #43218 )
...
chore: fixup patches in main
2024-08-05 13:51:17 -04:00
David Sanders
acd39bd077
ci: auto label bug issues with platform ( #43198 )
2024-08-05 09:52:49 -04:00
Charles Kerr
3d766e9ccb
perf: don't build unused vectors in HidChooserContext ( #43192 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
* refactor: use structured bindings for readability
2024-08-05 15:31:58 +02:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
Shelley Vohr
e64302cc91
refactor: simplify window moveAbove/moveTop impl on macOS ( #43157 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
2024-08-05 09:57:16 +02:00
Shelley Vohr
2a613cabaa
refactor: migrate electron_login_helper to non-deprecated API ( #43182 )
...
refactor: migrate electron_login_helper to non-deprecated API
2024-08-05 09:56:18 +02:00
Shelley Vohr
78995b956e
fix: potential draggable regions crash in DevTools ( #43179 )
2024-08-05 09:56:08 +02:00
electron-roller[bot]
f508f6b6b5
chore: bump chromium to 129.0.6636.0 (main) ( #43194 )
...
* chore: bump chromium in DEPS to 129.0.6636.0
* chore: e patches all
to make GH actions happy
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 11:36:40 -05:00
electron-roller[bot]
20e77afe0f
chore: bump chromium to 129.0.6634.0 (main) ( #43189 )
...
* chore: bump chromium in DEPS to 129.0.6634.0
* chore: update chore_add_electron_deps_to_gitignores.patch
no manual changes. patch applied with fuzz 1.
* chore: e patches all
* chore: update call to gfx::Image::CreateFrom1xPNGBytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597
The call now takes a base::span
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 07:31:31 -05:00
Charles Kerr
5a809a6694
refactor: prefer std::ranges over base::ranges ( #43172 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5668999
Xref: https://groups.google.com/a/chromium.org/g/cxx/c/ZnIbkfJ0Glw
2024-08-02 21:21:59 -05:00
Charles Kerr
305b28e9c7
chore: bump chromium to 129.0.6632.0 ( #43184 )
...
* chore: bump chromium in DEPS to 129.0.6632.0
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5755242
* chore: e patches all
2024-08-02 13:58:13 -05:00
Charles Kerr
5b18cc46bc
chore: bump chromium to 129.0.6630.0 (main) ( #43087 )
...
* chore: bump chromium in DEPS to 129.0.6623.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654
* chore: update fix_disable_scope_reuse_associated_dchecks.patch
We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076
* chore: e patches all
* Bump the Chrome macOS deployment target to 11.0
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361
BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0
* src: stop using deprecated fields of `v8::FastApiCallbackOptions`
Xref: d0000b118d
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741336
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199
* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch
chore: re-disable DCHECKs
yep, it is still needed
* refactor use non-deprecated variant of openApplicationAtURL
old version is deprecated now in macOS 11
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl
* chore: bump chromium in DEPS to 129.0.6626.0
* chore: e patches all
* chore: disable NSUserNotification deprecation errors
* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors
Xref: https://github.com/electron/electron/issues/43125
* chore: disable deprecation errors in platform_util_mac.mm
* chore: disable launchApplication deprecation errors
* chore: bump chromium in DEPS to 129.0.6630.0
* chore: update refactor_expose_file_system_access_blocklist.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444
* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch
no manual changes. patch applied with fuzz 1 (offset -5 lines)
* chore: e patches all
* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 09:02:11 -05:00
Tingsong (Terrence) Ou
7c79221a54
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc ( #43129 )
...
fixed electron-fiddle build and config links
2024-08-01 20:28:50 -05:00
Charles Kerr
e7ca92a574
chore: remove unused internal env.unSetVar() ( #43148 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260 , #25623 ) but never used
2024-08-01 18:41:41 -05:00
Shelley Vohr
3a07bd8821
fix: take bluetooth serial ports into account in serial.getPorts() ( #43101 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
* chore: remove port.path.LossyDisplayName()
2024-08-01 11:13:31 -05:00
dependabot[bot]
cc956420ef
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 ( #43094 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7ed )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:47:56 +02:00
cptpcrd
2337d8676d
fix: handle failing to enter fullscreen on macOS ( #43112 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
2024-08-01 12:13:13 +02:00
Charles Kerr
45e5ccc55e
chore: remove unused KeyWeakMap JS bindings ( #43111 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8 #25711 )
- Jun 2020 (e1e73fa5 #24115 )
- Jun 2020 (c0182bca #24116 ).
2024-07-31 16:37:04 -05:00
Charles Kerr
a68a33f036
docs: fix broken link in bug report template ( #43105 )
...
chore: fix broken link in bug report template
2024-07-31 11:45:07 -04:00
Shelley Vohr
791e6df82a
docs: update Node.js stable release policy ( #43100 )
...
* docs: update Node.js stable release policy
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-31 16:33:58 +02:00
dependabot[bot]
283810dbfc
build(deps): bump github/codeql-action from 3.25.13 to 3.25.15 ( #43095 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.13 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](2d790406f5...afb54ba388 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-31 10:00:39 +02:00
Shelley Vohr
ed3242adc1
fix: vibrant view is inserted into Views API hierarchy ( #43078 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-30 18:21:20 -05:00
John Kleinschmidt
87fb2ad70c
build: fixup ffmpeg release on x64 macOS ( #43093 )
...
chore: fixup arch on x64 macOS ffmpeg
2024-07-30 16:35:11 -04:00
Charles Kerr
1bcc566ad8
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43090 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a (#26659 )
2024-07-30 15:25:37 -05:00
electron-appveyor-updater[bot]
60bb4a2617
build: update appveyor image to latest version ( #43098 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-30 11:44:18 -04:00
Charles Kerr
47dde3b6e2
chore: remove unused class electron::ObjectLifeMonitor ( #43089 )
...
* chore: remove unused electron::ObjectLifeMonitor
The last users were removed in June 2020 e1e73fa5f (#24115 )
and May 2020 9d7ba982 (#23592 ).
* fixup! chore: remove unused electron::ObjectLifeMonitor
fix: oops
2024-07-30 08:25:28 -05:00
John Kleinschmidt
1a6e651844
test: fixup flaky visibility test ( #43064 )
2024-07-30 09:14:45 -04:00
Shelley Vohr
d09a2e513c
fix: showInactive window not showing ( #43079 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
2024-07-30 12:37:27 +02:00
Charles Kerr
7e9eb9e3f1
perf: avoid duplicate calculations in gin_helper::Dictionary getters ( #43073 )
...
* perf: cache the dictionary handle
* refactor: prefer result.IsJust() over !result.IsNothing()
for consistency
* refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust()
the inlined code is simpler
* refactor: simplify Get() impl
* refactor: add private helper Dictionary::MakeKey()
refactor: add private helper Dictionary::MakeHiddenKey()
2024-07-29 12:43:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
electron-roller[bot]
92496c1930
chore: bump chromium to 129.0.6616.0 (main) ( #43012 )
...
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076
* chore: export patches
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | https://chromium-review.googlesource.com/c/chromium/src/+/5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | https://chromium-review.googlesource.com/c/chromium/src/+/5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | https://chromium-review.googlesource.com/c/chromium/src/+/5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | https://chromium-review.googlesource.com/c/chromium/src/+/5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | https://chromium-review.googlesource.com/c/chromium/src/+/5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-29 09:37:35 -04:00
Alice Zhao
4286234721
fix: redirect webview navigation methods ( #42981 )
2024-07-29 13:00:51 +02:00
Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
2024-07-27 12:25:43 -05:00
Keeley Hammond
8db1563d73
fix: remove InspectableWebContentsViewMac ( #43033 )
...
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93d .
* build: fix gn check
* chore: implement setCornerRadii in inspectable_web_contents_view_mac
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: pass in cornerRadii value in setCornerRadii
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: forward declaration
* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-27 11:44:22 -05:00
electron-roller[bot]
b3d52c01e8
chore: bump node to v20.16.0 (main) ( #43029 )
...
* chore: bump node in DEPS to v20.16.0
* test: skip unstable shadow realm gc tests
https://github.com/nodejs/node/pull/52855
* test: extend env for `test-node-output-errors`
https://github.com/nodejs/node/pull/53535
* src: fix typo in env.cc
https://github.com/nodejs/node/pull/53418
* src: reset `process.versions` during pre-execution
https://github.com/nodejs/node/pull/53444
* chore: fixup patch indices
* src,permission: --allow-wasi & prevent WASI exec
https://github.com/nodejs/node/pull/53124
* tls: use SSL_get_peer_tmp_key
https://github.com/nodejs/node/pull/53366
* deps: update c-ares to 1.29.0
https://github.com/nodejs/node/pull/53155
* src: account for OpenSSL unexpected version
* crypto: fix propagation of "memory limit exceeded"
https://github.com/nodejs/node/pull/53300
* process: add process.getBuiltinModule(id)
https://github.com/nodejs/node/pull/52762
* windows 32bit: config change callback needs to be stdcall
8f265c9d51
* fix: building with UNICODE
https://github.com/c-ares/c-ares/pull/802
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-07-26 12:52:05 -04:00
BILL SHEN
77ba40bc01
chore: avoid crash while notification removal ( #43040 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
* fix notification removal crash due to the nullptr presenter
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-07-26 15:34:40 +02:00
Keeley Hammond
2fd04a78a1
fix: revert BrowserWindow unresponsive handling refactor ( #43034 )
...
* Revert "refactor: JSify BrowserWindow unresponsive handling (#37902 )"
This reverts commit 67ba30402b .
* chore: remove BrowserWindow::SetTitleBarOverlay
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-25 13:02:02 -07:00
electron-appveyor-updater[bot]
0886d2f50f
build: update appveyor image to latest version ( #43021 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-25 15:21:02 -04:00
Charles Kerr
660872c048
refactor: move safe_storage functions into anonymous namespace ( #43032 )
2024-07-25 13:18:13 -05:00
Shelley Vohr
976f5d1b75
fix: File System API permissions should reset on WebContents destruction ( #43009 )
...
fix: active File System API permissions should reset on WebContents destruction
2024-07-25 09:53:30 -04:00
Charles Kerr
aa23198ad8
chore: remove more unused #include calls ( #43000 )
...
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b (##41610)
* chore: iwyu electron/fuses.h
* chore: iwyu media/base/video_frame.h
* chore: iwyu base/functional/callback.h
* chore: iwyu base/task/cancelable_task_tracker.h
* chore: iwyu shell/browser/draggable_region_provider.h
* chore: iwyu shell/browser/ui/inspectable_web_contents_view.h
* chore: iwyu ui/aura/window.h
* chore: iwyu ui/base/win/shell.h
* chore: iwyu ui/display/win/screen_win.h
* chore: iwyu ui/gfx/geometry/insets.h
* chore: iwyu ui/display/display.h
* chore: iwyu ui/gfx/geometry/skia_conversions.h
* chore: iwyu ui/gfx/geometry/rect_conversions.h
* chore: iwyu ui/gfx/geometry/point.h
* chore: iwyu ui/gfx/scoped_canvas.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu ui/accessibility/ax_node_data.h
* chore: iwyu ui/views/animation/ink_drop_highlight.h
* chore: iwyu ui/gfx/font_list.h
* chore: iwyu ui/linux/nav_button_provider.h
* chore: iwyu shell/browser/ui/views/frameless_view.h
* chore: iwyu services/metrics/public/cpp/ukm_source_id.h
* chore: iwyu net/http/http_util.h
* chore: iwyu net/base/mime_util.h
* chore: iwyu content/public/common/content_client.h
* chore: iwyu <list>
* chore: iwyu <optional>
* chore: iwyu <memory>
* chore: iwyu base/files/file_path.h
* chore: iwyu ui/base/cursor/cursor.h
* chore: iwyu build/build_config.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/hid/hid_chooser_context.h
* chore: iwyu shell/common/platform_util.h
* chore: iwyu base/task/single_thread_task_runner.h
* chore: iwyu content/browser/renderer_host/render_widget_host_impl.h
* chore: iwyu content/public/browser/render_widget_host.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu content/public/browser/web_contents_observer.h
* chore: iwyu content/public/browser/render_frame_host.h
* chore: iwyu content/public/browser/media_stream_request.h
* chore: iwyu chrome/common/chrome_paths.h
* chore: iwyu chrome/browser/icon_manager.h
* chore: iwyu printing/print_settings.h
* chore: iwyu renderer/pepper_helper.h
* chore: iwyu shell/browser/api/process_metric.h
* chore: iwyu shell/browser/electron_browser_client.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu shell/browser/api/electron_api_session.h
* chore: iwyu shell/browser/api/electron_api_app.h
* chore: iwyu shell/browser/ui/views/client_frame_view_linux.h
* chore: iwyu shell/browser/native_window_views.h
* chore: iwyu base/win/windows_version.h
* chore: iwyu shell/common/electron_paths.h
* chore: iwyu content/public/common/content_switches.h
* chore: iwyu third_party/skia/include/core/SkRRect.h
* chore: iwyu third_party/skia/include/core/SkBitmap.h
* chore: iwyu third_party/skia
* chore: iwyu shell/browser/osr/osr_host_display_client.h
* chore: iwyu shell/browser/login_handler.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu shell/browser/event_emitter_mixin.h
* fix: mac
* fix: mac
* chore: iwyu base/nix/xdg_util.h
* fix: win
* fix: win
* fix: win
* fix: win
2024-07-25 11:25:45 +02:00
Shelley Vohr
cfdcf48e1b
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43013 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
* test: oops fix showing
2024-07-25 11:17:37 +02:00
David Sanders
c2c079dc82
build: update docs-parser and typescript-definitions packages ( #43038 )
...
build: update docs-parser and typescript-definitions pacakges
2024-07-25 11:00:32 +02:00
David Sanders
f979d4c742
test: add test for nodeCliInspect fuse ( #43035 )
2024-07-25 11:00:02 +02:00
Charles Kerr
df524c6eca
chore: use v8::Local<>, not v8::Handle<> ( #43019 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
2024-07-24 18:24:07 -05:00
Shelley Vohr
5669a40d5c
feat: add transparency checking to nativeTheme ( #42862 )
...
* feat: add transparency checking to nativeTheme
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870
* chore: deprecate previous function
* chore: fix lint
2024-07-24 14:38:22 +02:00
Shelley Vohr
9fc760bc4c
docs: note macOS fullscreen events in fullscreen query ( #42997 )
...
docs: note macOS fullscreen events in fs query
2024-07-23 16:40:59 -04:00
electron-roller[bot]
3e22f992b0
chore: bump chromium to 128.0.6611.0 (main) ( #42779 )
...
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-23 08:59:44 -07:00
dependabot[bot]
364631ee0b
build(deps): bump github/codeql-action from 3.25.12 to 3.25.13 ( #42999 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.12 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4fa2a79536...2d790406f5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 12:38:02 +02:00
Shelley Vohr
3c9d4452c6
docs: improve desktop capture example ( #42957 )
2024-07-23 11:55:23 +02:00
dependabot[bot]
daa8244cdf
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42998 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.3...0b2256b8c012f0828dc542b3febcab082c67f72b )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 10:18:36 +02:00
Shelley Vohr
8454f4e49f
feat: emit an event when accessing restricted path in File System Access API ( #42561 )
...
* fix: show a dialog when accessing restricted path in File System Access API
* fix: allow overriding initial blocked paths
* docs: fix doc
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: change block to deny for consistency
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-22 12:18:15 +02:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
David Sanders
296a558c32
build: update @electron/lint-roller to 2.3.0 ( #42950 )
2024-07-22 10:45:49 +02:00
Charles Kerr
780677e00f
chore: remove unused BaseWindow::GetWeakPtr() ( #42973 )
...
last caller removed in 67ba3040 (#37902 )
2024-07-22 10:44:34 +02:00
Charles Kerr
8c8a7709e6
chore: remove unused WrappableBase::AfterInit() ( #42974 )
...
last caller removed in 6159066c (#22916 )
2024-07-22 10:44:21 +02:00
Charles Kerr
c72a714dd5
refactor: remove WindowListObserver::OnWindowAdded() ( #42979 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
2024-07-22 10:44:08 +02:00
Charles Kerr
7a101a1c4b
refactor: remove unused web contents preferences methods ( #42947 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c
* chore: remove unused WebContentsPreferences::GetSafeDialogsMessage()
caller removed in 85bc005c
* refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath>
* refactor: make WebContentsPreferences::last_preference() const
2024-07-19 12:26:57 -05:00
Charles Kerr
5b7ed6097e
chore: remove unused typedef CreateDownloadPathCallback ( #42949 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
2024-07-19 11:49:58 -05:00
Charles Kerr
32a74b0942
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42956 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
2024-07-19 11:48:52 -05:00
Charles Kerr
5773a2dce6
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42933 )
2024-07-17 23:30:09 -05:00
Charles Kerr
bc345db351
fix: dangling raw_ptr<views::View> in api::View ( #42929 )
2024-07-17 21:31:48 -05:00
David Sanders
ce45450c28
ci: refactor non-maintainer lockfile change check to request changes ( #42855 )
2024-07-17 12:28:08 -07:00
arno renevier
81bdba67ec
feat: Implement password delegate for NSS ( #41205 )
...
* feat: Implement password delegate for NSS (#41188 )
Introduce an app event client-certificate-request-password. It allows
the user to display a UI to prompt for the password.
An alternative would have been to implement a class similar to
CryptoModulePasswordDialogView, to provide the UI. This might have been
simpler for the user, comparing to letting them implement the UI. But it
seems like electron does not have an i18n framework, so it's not
possible to provide a locale aware UI.
* fix lint:markdown error
* address review comments
* use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler
* use properties on the Event object instead of positional parameters
* remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_)
* address review comments second round
- backslash escape parametrized TypeScript
- rename hostName param to hostname
- use base::ScopedAllowBaseSyncPrimitivesForTesting
- and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate
* Update docs/api/app.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/app.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Arno Renevier <arnaud@switchboard.app >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-17 09:48:03 -04:00
dependabot[bot]
c210ae9b33
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #42831 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:41 +02:00
dependabot[bot]
734ba50ee1
build(deps): bump amannn/action-semantic-pull-request from 5.5.2 to 5.5.3 ( #42834 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.2 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](cfb60706e1...0723387faa )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:33 +02:00
wujinli
9023707b9b
fix: crash with creating OffScreenWebContentsView ( #42920 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
2024-07-17 13:09:32 +02:00
dependabot[bot]
2875fab452
build(deps): bump actions/setup-node from 4.0.2 to 4.0.3 ( #42917 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...1e60f620b9 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 11:36:52 +02:00
Shelley Vohr
fd907bc0a3
fix: getUserMedia needs macOS system permissions check ( #42899 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
2024-07-17 11:30:05 +02:00
Sam Maddock
c7709747d0
ci: upload test artifacts ( #42925 )
...
* Upload test-artifacts directory
* Rename test artifacts directory to avoid conflicts
* Update .gitignore
* Upload test artifacts
* Update .gitignore
* Update move-artifacts.sh
* Update artifacts.ts
* Update pipeline-segment-electron-test.yml
* Make output less noisy
* reduce artifact image size
2024-07-16 22:56:56 -07:00
Sam Maddock
778d3098a0
feat: customize border radius of Views ( #42320 )
...
* feat: add View#setBorderRadius
test: initial setBorderRadius tests
fix: robustly set border radius
chore: add PAUSE_CAPTURE_TESTS for easier screencap dev
feat: add view border radius support
test: view border radius
refactor: cleanup view code
* maybe delay capture to fix tests?
* refactor: retry screen captures in an attempt to fix flakiness
* refactor: ScreenCapture constructor no longer async
* increase screen capture timeout, feels a little short
* refactor: move rounded rect util into chromium_src
* skip some capture tests on mas
2024-07-16 20:16:25 -04:00
Shelley Vohr
cbd11bb605
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42824 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
2024-07-16 20:11:49 +02:00
Calvin
81351dd1a9
build: fix clang format location helper (again) ( #42911 )
2024-07-16 11:21:18 -04:00
dependabot[bot]
f575e52586
build(deps): bump github/codeql-action from 3.25.11 to 3.25.12 ( #42916 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.11 to 3.25.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b611370bb5...4fa2a79536 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-16 11:25:42 +02:00
Theo Gravity
bab3fcc9ab
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42805 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
2024-07-15 19:32:44 -04:00
David Sanders
0fddfd1b28
ci: auto comment on new issues for unsupported majors ( #42856 )
2024-07-15 15:25:47 -04:00
Keeley Hammond
c006e129b3
build: remove CircleCI ( #42844 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
2024-07-15 14:26:41 -04:00
reito
f173a0637a
chore: fix npm run lint not working on Windows ( #42281 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-07-15 18:08:33 +02:00
Shelley Vohr
ae1a684d10
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42851 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
2024-07-15 10:41:38 -04:00
Robo
1e1dc22e16
fix: crash when resolving proxy due to network service restart ( #42878 )
2024-07-15 17:46:24 +09:00
Shelley Vohr
bbd7f4a5ad
fix: File System Access API should remember last picked directory ( #42850 )
2024-07-14 18:43:37 +02:00
Calvin
493bc3ac9d
fix: desktopCapturer and screen display ids should match ( #42883 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
* simplify wide-to-utf8 conversion
* remove unnecessary include
2024-07-14 09:51:57 +02:00
John Kleinschmidt
3a6a201534
build: fixup GHA running on fork PRs ( #42880 )
...
* chore: update build-tools for GHA
* chore: don't rely on environment variables for source cache location
2024-07-13 13:38:03 -04:00
Samuel Attard
53d7cca7a2
build: use new arc runner names ( #42881 )
2024-07-12 22:22:49 -07:00
David Sanders
7dd6d7697d
chore: allow multiple OS selection on bug reports ( #42854 )
2024-07-11 13:23:43 -07:00
John Kleinschmidt
514e9bbb04
build: update build-tools for GHA ( #42870 )
...
chore: update build-tools for GHA
2024-07-11 16:18:26 -04:00
Shelley Vohr
dab006b1cf
ci: fix Nan test failure on Linux ( #42863 )
...
ci: Nan test failure on Linux
2024-07-11 10:47:02 -04:00
Shelley Vohr
4e10eeb87e
fix: desktopCapturer and screen source ids should match screen ids ( #42781 )
...
* fix: desktopCapturer screen source ids should match screen ids
* test: add a regression test
2024-07-10 16:32:29 -07:00
Shelley Vohr
fa6ce4f0f8
fix: High Contrast mode not working on Windows ( #42853 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
2024-07-10 15:14:02 -07:00
Charles Kerr
f9d94211bb
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener ( #42806 )
...
All the listener functions are empty stubs (and have been since d4e3c39 )
so it doesn't seem like we need a listener?
SpeechRecognitionManagerDelegate declares this method:
> // Checks whether the delegate is interested (returning a non nullptr
> // ptr) or not (returning nullptr) in receiving a copy of all sessions
> // events. This is called on the IO thread.
> virtual SpeechRecognitionEventListener* GetEventListener() = 0;
This PR has ElectronSpeechRecognitionManagerDelegate stop subclassing
from the Listener and changes GetEventListener() to return nullptr.
2024-07-10 15:32:50 +02:00
electron-roller[bot]
48fc352bcf
chore: bump node to v20.15.1 (main) ( #42841 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-10 14:52:06 +02:00
John Kleinschmidt
1a9f99b3ed
chore: speed up azcopy on src cache ( #42742 )
2024-07-09 16:20:18 -04:00
dependabot[bot]
34e7648478
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11 ( #42832 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](23acc5c183...b611370bb5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:27:37 +02:00
dependabot[bot]
c2ea3881fc
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42833 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:25:07 +02:00
David Sanders
170b72ccfa
ci: fix CircleCI config ( #42829 )
...
* ci: fix CircleCI config
* ci: fix syntax error
2024-07-08 21:38:05 -04:00
Shelley Vohr
e54ffdf7ed
build: clean up BoringSSL patch ( #42730 )
2024-07-08 16:35:54 -04:00
Charles Kerr
e9db02948e
fix: multiple move() calls on the same unique_ptr ( #42788 )
2024-07-08 11:04:35 -04:00
Charles Kerr
27e3273f0a
refactor: minor electron browser context cleanup ( #42789 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
* refactor: remove unused forward declarations of v8 classes
* chore: forward declare gin::Arguments
* refactor: use unique_ptr operator bool
2024-07-08 16:49:41 +02:00
electron-appveyor-updater[bot]
e99e554655
build: update appveyor image to latest version ( #42771 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-08 12:56:52 +02:00
Charles Kerr
5ff91159cd
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42785 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
2024-07-08 12:56:03 +02:00
Charles Kerr
e89da2bad2
fix: dangling raw_ptr<Session> in UserDataLink ( #42786 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
* chore: make linter happy
2024-07-08 12:55:48 +02:00
Shelley Vohr
cb2e7f130b
fix: potentially closed webContents in BrowserView ( #42633 )
2024-07-08 12:13:53 +02:00
Shelley Vohr
2f4a46f47a
fix: video and audio capture should be separate ( #42775 )
2024-07-08 10:11:40 +02:00
Shelley Vohr
ac074a5548
refactor: run Windows SelectFileDialog out of process ( #42758 )
...
* refactor: run Windows SelectFileDialog out of process
* fix: add missing IS_WIN guard
* refactor: use upstream SelectFileDialogFactory
* fix: build chrome/services/util_win/public/mojom target
2024-07-05 11:36:44 +02:00
electron-roller[bot]
19e030a6e8
chore: bump chromium to 128.0.6573.0 (main) ( #42766 )
...
* chore: bump chromium in DEPS to 128.0.6573.0
* chore: update patches
* 5665092: Remove default arguments on virtual functions in WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/5665092
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-05 09:51:21 +02:00
Shelley Vohr
5bff883c40
chore: clean up outdated goma references ( #42762 )
2024-07-05 09:44:34 +02:00
Shelley Vohr
25eb1bd4b2
build: remove all publish & build on macOS ( #42763 )
2024-07-03 15:17:17 -04:00
electron-roller[bot]
07e6b34a07
chore: bump chromium to 128.0.6571.0 (main) ( #42749 )
...
* chore: bump chromium in DEPS to 128.0.6571.0
* 5636652: [4/n] Introduce RenderInputRouterClient and move InputRouterClient implementation to RenderInputRouter.
https://chromium-review.googlesource.com/c/chromium/src/+/5636652
* 5655811: Revert "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"""
https://chromium-review.googlesource.com/c/chromium/src/+/5655811
* 5581006: [tracing] Forward startup tracing config as shmem
https://chromium-review.googlesource.com/c/chromium/src/+/5581006
* chore: fixup patch indices
* 5608450: [Views AX] Move Image Auto Captioning strings to ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5608450
* 5648900: [Extensions] Move ExtensionAPIEnabledForServiceWorkerScript()
https://chromium-review.googlesource.com/c/chromium/src/+/5648900
* 5651681: Remove Web Speech API profanity masking
https://chromium-review.googlesource.com/c/chromium/src/+/5651681
* 5651361: `content::RenderFrame::GetBrowserInterfaceBroker`: return a const-ref.
https://chromium-review.googlesource.com/c/chromium/src/+/5651361
* 5604943: Start capture of toolbar after gesture end events are received
https://chromium-review.googlesource.com/c/chromium/src/+/5604943
* 5624392: [BRP] Enforce raw_ptr/ref in Renderer code
https://chromium-review.googlesource.com/c/chromium/src/+/5624392
* 5659259: Portals: Remove WebContentsView::TransferDragSecurityInfo
https://chromium-review.googlesource.com/c/chromium/src/+/5659259
* 5230721: Move ComposeStatus to components/compose
https://chromium-review.googlesource.com/c/chromium/src/+/5230721
* 5647894: [api] Cleanup usages of v8::ReturnValue<void>::Set[NonEmpty](..)
https://chromium-review.googlesource.com/c/v8/v8/+/5647894
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-03 11:15:35 -04:00
Charles Kerr
cf5fb4505e
refactor: make session::browser_context_ a const raw_ref ( #42728 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-02 17:53:36 -04:00
Erick Zhao
0a8eae9019
docs(autoUpdater): document static storage strategy ( #42690 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
2024-07-02 19:06:38 +02:00
Erick Zhao
6cca75ac76
docs(autoUpdater): signing is only a pre-req on macOS ( #42709 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
2024-07-02 19:06:25 +02:00
electron-appveyor-updater[bot]
67d7944271
build: update appveyor image to latest version ( #42748 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-02 10:38:43 -04:00
Shelley Vohr
1729a9868c
fix: use BlockedRequest struct to handle webRequest data ( #42647 )
...
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.
This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33d .
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-02 09:51:33 +02:00
Anny Yang
14303a0a71
docs: grammar fix in isBeingCaptured docs ( #42692 )
2024-07-01 15:01:27 -04:00
Chris Stringer
2b5342cb49
docs - Update net.md ( #42691 )
...
Update net.md
Changes heading level for net.resolveHost() entry to H3
2024-07-01 14:45:49 -04:00
Alice Zhao
e9a93a8c5c
fix: setTopBrowserView focus issue with reordering ( #42653 )
...
* fix: reorder top browser view instead of adding/removing
* fix: update browserViews order
* test: add a test for setTopBrowserView
2024-07-01 11:36:04 +02:00
Keeley Hammond
efff369639
build: remove MacOS x64 from CircleCI ( #42718 )
2024-07-01 11:34:37 +02:00
Keeley Hammond
3ac57e17d5
build: fix clang format/lint ( #42715 )
...
* build: fix clang format path
* fix: use gclient sync instead of gclient runhooks
Refs https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5659261
* fix: use gclient sync instead of gclient runhooks in GHA
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-06-28 13:30:07 -07:00
Shelley Vohr
398dde9dfb
build: use inputs for target_arch in build ( #42684 )
2024-06-27 08:11:10 -07:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
David Sanders
1d4b00692d
build: bump version in .nvmrc to 20 ( #42668 )
2024-06-27 13:46:11 +02:00
electron-roller[bot]
ec24b51808
chore: bump node to v20.15.0 (main) ( #42616 )
...
* chore: bump node in DEPS to v20.15.0
* doc: Add OpenSSL errors to API docs
https://github.com/nodejs/node/pull/34213
* test: crypto-rsa-dsa testing for dynamic openssl
https://github.com/nodejs/node/pull/52781
* src: allow preventing debug signal handler start
https://github.com/nodejs/node/pull/46681
* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler
https://github.com/nodejs/node/pull/52766
* chore: fixup indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-27 13:34:39 +02:00
Shelley Vohr
c628de52d9
fix: defaultPath should apply on all dialog types in Linux Portal ( #42655 )
...
fix: defaultPath should apply on all dialog types in Linux Portal dialogs
2024-06-27 11:07:26 +02:00
Shelley Vohr
2b31d8459d
fix: param passed to showSaveDialogSync on Linux ( #42652 )
...
fix: pass correct param to sync functions on Linux
2024-06-27 10:23:18 +02:00
Keeley Hammond
912706b23a
build: strip linux release binaries ( #42675 )
2024-06-26 17:41:36 -07:00
Samuel Attard
b31acfb706
docs: clarify security semantics of safeStorage ( #42666 )
...
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-06-26 13:24:06 -07:00
Shelley Vohr
607b9b8f11
build: clean up upload-index-json error handling ( #42657 )
2024-06-26 09:25:58 -07:00
Keeley Hammond
a8baa6f1ad
build: remove CircleCI from release pipeline ( #42651 )
...
* build: remove CircleCI from release pipeline
* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
2024-06-25 14:25:04 -07:00
Shelley Vohr
3534923bd2
build: account for subjectAndDescription null in patch linting ( #42636 )
...
fix: account for subjectAndDescription null in patch linting
2024-06-24 22:32:43 -07:00
Keeley Hammond
66b8b79229
build: turn on GitHub Actions by default for all branches and pull requests ( #42623 )
...
* build: turn GitHub Actions on by default for push and pull_request
* build: try env var build-image-sha
* build: use ternery for input vs default
* build: pain
* build: modify setup to cascade build-image-sha
* build: move outputs into setup step
* build: add SAS key generation on re-run
* build: only build on push, not pull_request
* build: only build on push for main & release branches, build on PR for everything else
* build: rebase with main, handle asan build
* build: add exit 1, sha value
2024-06-24 12:06:13 +02:00
Corbin Crutchley
243be0a638
docs: fix typo in ASAR integrity docs ( #42538 )
...
Fix typo in ASAR integrity docs
2024-06-22 20:26:23 +02:00
Charles Kerr
24d6c28b5a
chore: remove walkdir dev dependency ( #42591 )
2024-06-21 10:31:10 -04:00
George Xu
ba8ad4716b
feat: expose system preferences to utility process ( #42203 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
2024-06-20 11:15:57 -04:00
Shelley Vohr
37608933ae
fix: fetch-dependent interfaces in Web Workers ( #42579 )
2024-06-20 11:01:50 -04:00
Keeley Hammond
edb939ae80
build: Add ASan Linux build to Actions build/test ( #42545 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-20 12:11:53 +02:00
Milan Burda
003c32331d
chore: add/fix interface comments for sections of methods ( #42566 )
2024-06-20 10:49:07 +02:00
Shelley Vohr
18abeb3add
build: re-enable self-cert codesigning on x64 macOS ( #42576 )
...
build: re-enable self-cert codesigning
2024-06-19 10:28:07 -04:00
Charles Kerr
dad6e130f5
build: remove fs-extra devdep ( #42533 )
...
* build: remove fs-extra dependency from script/gen-filenames.ts
* build: remove fs-extra dependency from script/spec-runner.js
* build: remove fs-extra dependency from script/gn-asar.js
* build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts
* build: remove fs-extra dependency from spec/api-safe-storage-spec.ts
* build: remove fs-extra dependency from spec/lib/codesign-helpers.ts
* build: remove fs-extra dependency from spec/api-app-spec.ts
* build: remove fs-extra dependency from spec/esm-spec.ts
* build: remove fs-extra dependency from spec/lib/fs-helpers.ts
* build: remove fs-extra dependency from spec/lib/api-shell-spec.ts
* build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* build: remove fs-extra dependency from spec/asar-integrity-spec.ts
* build: remove fs-extra dependency from spec/node-spec.ts
* build: remove fs-extra devdiv
* fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* fix: use force: true when removing directories
* chore: reduce diffs to main
2024-06-19 10:10:16 -04:00
Shelley Vohr
8e8ea3ee8b
fix: MessagePort closing unexpectedly with non-cloneable objects ( #42535 )
...
* fix: MessagePort closing unexpectedly with non-cloneable objects
* fix: handle serialization failure in parentPort
2024-06-19 11:27:07 +02:00
Keeley Hammond
6d2c72b14e
build: correct GCLIENT_EXTRA_ARGS in linux-publish ( #42575 )
2024-06-18 21:54:20 -07:00
Charles Kerr
980e884fa5
build: remove klaw dependency ( #42529 )
...
* refactor: remove klaw dependency
Node 20 added recursive readdir() so klaw is not needed
* fixup! refactor: remove klaw dependency
findMatchingFiles returns a Promise<string[]>
2024-06-18 18:54:26 -04:00
Keeley Hammond
71338140a4
build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release ( #42571 )
...
* build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release
* build: move to GN_EXTRA_ARGS, remove GN_BUILDFLAG_ARGS
2024-06-18 14:03:53 -07:00
David Sanders
2e4857fbcb
ci: auto close non-maintainer PRs that touch lockfiles ( #42534 )
2024-06-18 15:30:08 -04:00
Robo
29b8fbf419
chore: cherry-pick f8010390 from chromium ( #42559 )
2024-06-19 01:28:51 +09:00
dependabot[bot]
540a42fb96
build(deps): bump github/codeql-action from 3.25.7 to 3.25.10 ( #42540 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.7 to 3.25.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f079b84933...23acc5c183 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-18 12:14:56 +02:00
dependabot[bot]
b8512a0cd9
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #42539 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a5ac7e51b4...692973e3d9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-18 12:14:15 +02:00
Shelley Vohr
86cf60c3f1
chore: improve error message on failed SMApp register/unregister ( #42526 )
2024-06-18 10:51:37 +02:00
Samuel Attard
e217b063a5
build: fix nan/node tests on GHA ( #42548 )
2024-06-18 10:49:39 +02:00
John Kleinschmidt
ae88e64c88
test: use longer timeout on contentTracing tests on WOA ( #42537 )
2024-06-18 10:37:18 +02:00
David Sanders
6d4c2057e4
docs: add backticks around example URL ( #42536 )
2024-06-17 16:35:26 -07:00
dependabot[bot]
db9742a1ff
build(deps): bump mikefarah/yq from 4.44.1 to 4.44.2 ( #42541 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.1 to 4.44.2.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](557dcb87b8...f15500b20a )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-17 16:34:32 -07:00
Samuel Attard
a0a13ad623
build: fix macOS tests on GHA ( #42524 )
...
* build: use --frozen-lockfile
* build: don't include src/electron in src artifacts
* Use mac intel runner for mac-x64 tests
* test: debug mac tests not exiting
* skip navigator.serial tests on GHA
* TCC magic
* Fix release notes tests needing ELECTRON_GITHUB_TOKEN
* Add Azure env vars to gn check pipeline segment
* use RO token for tests
* temporarily disable codesign tests
* test: disable LoginItemSettings on x64 macOS
* test: bump up time on protocol test for slower machines
* fixup: use RO token for tests
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-17 16:33:44 -07:00
Shelley Vohr
b35adaee2d
build: fix clang format location helper ( #42527 )
2024-06-17 19:47:59 +02:00
Shelley Vohr
1a4d58a9fb
build: run GN Check everywhere ( #42515 )
...
* build: run GN Check everywhere
* build: remove gn check matrix
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-06-17 08:58:29 -07:00
Samuel Attard
2b259bd69e
build: de-dupe load build tools into composite action ( #42518 )
2024-06-17 11:26:18 +02:00
Samuel Attard
a371c2cd54
build: fix GHA arm tests ( #42514 )
2024-06-16 10:59:51 -07:00
Shelley Vohr
6bf83b389b
build: add GN check step ( #42508 )
...
* build: add GN check step
* Remove extra loggin
* Fix BUILD_TOOLS_SHA
* Fix concurrency group naming
2024-06-14 15:29:11 -05:00
Samuel Attard
2c985366c8
build: fix dubious ownership error in version bumper spec ( #42509 )
2024-06-14 13:47:58 -05:00
Keeley Hammond
429d50bb18
build: add production-release environment to publish jobs ( #42483 )
...
* build: move publish workflows to use production environment
* build: pass in target_cpu to GN_EXTRA_ARGS on Linux
2024-06-14 11:14:38 -05:00
Keeley Hammond
5b98be3ccb
build: add docs-only path gating to GHA ( #42499 )
...
* build: add docs only workflow
* build: add path filtering action
* build: add actions/checkout
* build: explicitly set shell to bash -_-
* build: why regex when you could do something much dumber
* build: correct conditionals
* test: (do not merge) add base for testing
* test: remove git base (used for testing)
2024-06-14 11:08:41 -05:00
John Kleinschmidt
5397560ab3
build: adjust concurrency for release branches ( #42507 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-14 11:08:21 -05:00
Samuel Attard
c2c3673e8a
build: fix linux tests ( #42496 )
...
* build: use runuser for electron spec runner
* chown
* run tests in priv
* fixed
* build: setup testing on arm for GHA
* no build-tools for test
* start xvfb for the right user
* no more gn-build-type
* debug env
* ue xvfb-run
* use 8 core for node tests
* build: do test sharding on linux
* fix: disable hung node test
* build: index splits are hard
* build: use --init to reap children
* allow write junit
* use custom xvfb wrapper
* pipefail
* dont kill xvfb, its already dead
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-14 10:57:28 -05:00
Shelley Vohr
c1094013eb
build: allow running only mac, lint, or linux ( #42504 )
...
build: allow running only mac or linux
2024-06-14 10:08:04 -05:00
Keeley Hammond
8650682c5b
build: revert removal of CIPD patch from depot tools ( #42500 )
...
Revert "build: remove the CIPD patch from depot tools (#42484 )"
This reverts commit a0a8bd2222 .
2024-06-14 09:11:30 -05:00
Shelley Vohr
422511753f
build: use BUILD_TYPE from env ( #42498 )
...
build: use BUILD_TYPE from env
2024-06-14 06:47:18 -05:00
Samuel Attard
9f862af743
build: add lint GHA job ( #42494 )
2024-06-13 22:14:49 -05:00
John Kleinschmidt
16b2a09787
build: only load SDK for mac builds ( #42485 )
2024-06-13 17:49:38 -05:00
Keeley Hammond
ad8e89de01
build: fix v8 toolchain for macOS x64 ( #42492 )
...
build: do better
2024-06-13 17:14:57 -05:00
Samuel Attard
b7aad14e8d
build: run gha on tag not branch ( #42490 )
2024-06-13 17:14:45 -05:00
Keeley Hammond
c41ded2e89
build: remove gclient-extra-args from publish jobs ( #42491 )
...
build: remove gclient-extra-args from publish ymls
2024-06-13 17:11:47 -05:00
Keeley Hammond
4701795dc0
build: fix datetime module for Linux Publish ( #42489 )
2024-06-13 16:36:45 -05:00
Samuel Attard
cfdc623c4d
build: pin and dedupe build image sha ( #42488 )
2024-06-13 16:35:47 -05:00
Keeley Hammond
9e066e7b74
build: add v8_toolchain to darwin/x64 ( #42487 )
...
build: add v8_toolchain to darwin/x64
2024-06-13 16:35:20 -05:00
Shelley Vohr
9fe1b05025
build: upload separate artifact for src files ( #42486 )
2024-06-13 16:35:13 -05:00
Keeley Hammond
a0a8bd2222
build: remove the CIPD patch from depot tools ( #42484 )
...
* build: try to remove the CIPD patch from depot tools
* build: remove cipd patch from GHA
2024-06-13 16:06:16 -05:00
Samuel Attard
b92a4023c1
build: unify pipelines ( #42482 )
2024-06-13 16:02:38 -05:00
Tomáš Hübelbauer
15c404a3c8
docs: fix the Apple HIG link for Dock context menu ( #42450 )
...
Fix the Apple human interface guidelines link for Dock context menu
The link seems to have changed. This is the up to date link.
2024-06-13 15:24:05 -05:00
Shelley Vohr
0affad3be6
build: add several missing test steps for GHA ( #42479 )
2024-06-13 14:26:20 -05:00
Shelley Vohr
30885e5f9f
build: add Linux GHA test step ( #42460 )
...
* build: add Linux GHA test step
* Switch to medium AKS runners
* Add missing BUILD_TYPE to restore-artifact
* Fix untar to current dir
* Remove known hosts logic
* Add missing Node.js headers step
* Fix for active SSH sessions
* Fix storing artifacts
* Build on x64 for test
2024-06-13 14:14:33 -05:00
Keeley Hammond
75d0e725be
build: fix conditional for sas token ( #42481 )
2024-06-13 09:43:06 -05:00
Keeley Hammond
42266546eb
build: move hunspell generation to Linux ( #42480 )
2024-06-13 09:37:36 -05:00
Samuel Attard
f72096194f
build: reuse checkout steps across mac and linux ( #42475 )
2024-06-13 09:09:35 -05:00
Samuel Attard
1e219e457b
build: generate deps hash quietly ( #42476 )
2024-06-13 01:43:33 -05:00
Keeley Hammond
a4f201a5f3
build: add needed steps/tweaks to Linux publish job ( #42477 )
...
* build: add libcxx to Linux publish
* build: temp change ref to branch
* build: remove hunspell dictionaries
* build: modify release build script for linux
* build: switch back to main
2024-06-12 23:13:17 -05:00
Shelley Vohr
5abefc5dc3
build: use GN_EXTRA_ARGS on macOS ( #42473 )
...
* build: use GN_EXTRA_ARGS on macOS
* Switch back to main
2024-06-12 22:12:30 -05:00
Keeley Hammond
9d6c894e89
build: save/restore cache on Linux builds ( #42472 )
...
* build: update checkout and cache restore for Linux
* build: clean up variables
* build: temporarily set ref to branch
* build: actually check if cache exists or not and correctly store it
* build: correct cache paths
* build: restore electron_node/deps/v8
* build: restore sha to @main, not branch
* build: remove cache_key and use $DEPSHASH
* build: remove sas, backup_cache logic
* build: revert openssl deletion
2024-06-12 17:41:07 -05:00
Samuel Attard
08bd588e71
build: use dynamic RO sas token provided by sas-sidecar ( #42470 )
2024-06-12 16:04:28 -05:00
Shelley Vohr
2afe657873
build: cleanup to macos pipeline ( #42445 )
...
* build: cleanup to macos pipeline
* Fix generated artifact key finding
* Fix cache restore key
* Switch ref to main
* Use artifacts for build artifact persisting
* Fix TARGET_ARCH env var in test
* Remove npm install
2024-06-12 14:58:47 -05:00
Mark Lee
1d2f2eb113
docs(web-embeds): replace BrowserView ref with WebContentsView ( #42416 )
2024-06-12 14:55:06 -05:00
Keeley Hammond
f6a9c55907
build: remove unneeded installs/secrets ( #42467 )
...
build: remove unneeded azure installs/secrets
2024-06-12 14:53:18 -05:00
Keeley Hammond
1cb63b4d77
build: use the linux aks for macos checkout/cache ( #42447 )
...
* build: use the linux aks for checkout/cache
* build: use latest container sha
* build: persist the AKS cache (first try)
* build (do not merge): use current branch for workflows
* build: do not check for existing cache
* build: try to move src into /var/portal
* build: add AZURE_AKS_CACHE_SHARE_NAME & AZURE_AKS_CACHE_STORAGE_ACCOUNT
* build: add volumes: /mnt/cross-instance-cache
* build: temporarily skip cache exists checks
* build: reset to aks-linux-large, upload/download tar
* build: pass detailed credentials into download
* build: be better
* build: add skip if cache exists, declare env vars earlier
* build: add quotes
* build: change to connection-string
* build: remove connection string
* build: migrate to azcopy
* build: lol
* build: revert ref to @main
2024-06-12 14:21:19 -05:00
Shelley Vohr
ffe1d70f1d
build: add Linux GHA build step ( #42432 )
...
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-06-12 14:16:49 -05:00
Erick Zhao
83748bd181
docs: clean up MAS submission guide ( #42368 )
...
* docs: clean up MAS submission guide
* add info from osx-sign wiki
2024-06-12 12:58:21 -05:00
voidfill
7a6a2a51e0
docs: fix info admonitions in security.md ( #42451 )
2024-06-12 11:38:21 -05:00
Shelley Vohr
6caf9f06f3
fix: don't observe WebUSB for in-memory partitions ( #42443 )
2024-06-12 10:59:04 -05:00
Shelley Vohr
4aa9070e6c
fix: missing fetch-dependent interfaces in Node.js ( #42419 )
...
fix: missing fetch-dependent interfaces in Node.js
2024-06-11 16:59:53 -05:00
George Xu
ea219dd702
docs: update timelines for E32 ( #42431 )
...
docs: update timelines for e32
2024-06-11 16:36:36 -05:00
Keeley Hammond
eacdf56e0b
build: build ffmpeg on MAS publish ( #42448 )
2024-06-11 14:43:11 -05:00
Charles Kerr
89ce1cbd39
build: add an option to skip the install-sysroot hooks ( #42436 )
2024-06-11 10:08:07 -05:00
rcombs
d8e4579e3c
feat: add cumulativeCPUUsage to AppMetrics and CPUUsage ( #41819 )
...
This allows apps to measure their CPU usage over any given period
without worrying about other calls affecting the output,
as they would with `percentCPUUsage`.
2024-06-11 09:38:03 -05:00
Shelley Vohr
f35a755086
fix: bad js-flags shouldn't crash the app ( #42414 )
...
* fix: bad js-flags shouldn't crash the app
* Update shell/browser/javascript_environment.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2024-06-11 08:32:16 -05:00
Charles Kerr
f2481ed44f
refactor: move impl classes into unnamed namespaces ( #42390 )
...
* refactor: move ReplyChannel into an anonymous namespace
* refactor: move ChunkedDataPipeReadableStream into an anonymous namespace
* refactor: move linux helpers into an anonymous namespace
* refactor: move linux helpers into an anonymous namespace
2024-06-10 17:00:20 -05:00
Keeley Hammond
c4abaec56a
build: fix upload script defaults ( #42430 )
2024-06-10 16:58:29 -05:00
Shelley Vohr
92de23bb3c
build: initial Linux pipeline checkout ( #42429 )
...
* build: create config for GHA build linux
* build: restructure linux pipeline files
* build (do not merge): don't run CircleCI or Appveyor
* build: run on push
* build: add checkout step
* build: fix .yml syntax
* Remove Azure CLI install
* Revert "build (do not merge): don't run CircleCI or Appveyor"
This reverts commit eb55e317bc .
* build: change pipeline SHA to main
* chore: update patches
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-10 14:39:34 -05:00
Shelley Vohr
ff4494c18f
build: allow kicking build with workflow_dispatch ( #42420 )
...
* build: allow kicking build with workflow_dispatch
* build: ensure macOS build works
* fix: no upload in build
* build: add target_cpu to MAS config
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-06-10 11:55:16 -05:00
electron-appveyor-updater[bot]
839ba30009
build: update appveyor image to latest version ( #42418 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-06-10 11:46:44 -05:00
Shelley Vohr
92db4f0b8a
build: fix generate_gn_filenames_json.py ( #42389 )
...
build: fix generate_gn_filenames_json.py
2024-06-10 10:34:36 -05:00
David Sanders
c6845b0afc
chore: update @electron/lint-roller to 2.2.0 ( #42412 )
2024-06-10 10:14:03 -05:00
Shelley Vohr
035b10daf9
fix: multiple selection in //shell_dialogs Portal/KDE implementations ( #42308 )
...
* fix: multiple selection in //shell_dialogs portal implementation
* fix: allow multiple directory selection in KDE implementation
2024-06-10 09:43:16 -05:00
Shelley Vohr
91205540c4
fix: restore wasOpenedAtLogin functionality ( #42411 )
...
fix: restore opened at login functionality
2024-06-10 09:39:56 -05:00
electron-roller[bot]
c3b4cd987c
chore: bump chromium to 127.0.6521.0 (main) ( #42118 )
...
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
https://chromium-review.googlesource.com/c/chromium/src/+/5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5545807: Migrate most remaining NOTREACHED()
https://chromium-review.googlesource.com/c/chromium/src/+/5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147
* chore: add kPip to enumeration as a no-op
https://chromium-review.googlesource.com/c/chromium/src/+/5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251
* Require client for InitParams to always specify an ownership mode.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2 , was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ | https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
https://chromium-review.googlesource.com/c/chromium/src/+/5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
https://chromium-review.googlesource.com/c/chromium/src/+/5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
https://chromium-review.googlesource.com/c/chromium/src/+/5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | https://chromium-review.googlesource.com/c/v8/v8/+/5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/5539852
* 5573603: Modularize //chrome/browser/themes
https://chromium-review.googlesource.com/c/chromium/src/+/5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-06-07 17:18:35 -04:00
Shelley Vohr
84e15e2d04
build: Azure CLI install step not needed ( #42410 )
2024-06-07 10:05:15 -07:00
Shelley Vohr
25ed286706
fix: loginService -> loginItemService ( #42380 )
...
fix: loginService -> loginItemService
2024-06-07 11:49:00 +02:00
Shelley Vohr
d97dcf388a
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var ( #42402 )
...
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var
2024-06-07 11:46:30 +02:00
Shelley Vohr
54c315c9b0
refactor: improve cookie failure rejection messages ( #42362 )
2024-06-07 10:06:37 +02:00
Shelley Vohr
7f3dc7d4ce
fix: utilityProcess exit codes ( #42297 )
2024-06-07 10:06:00 +02:00
Shelley Vohr
1c6d7d7ece
build: fix depot_tools patch ( #42388 )
...
build: fix depot_tools patch
2024-06-06 22:49:59 +02:00
Keeley Hammond
6ccb9861f6
build: increase fetch-deps ( #42387 )
...
* build: use fetch-depth: 0 and fetch-tags
* debug: readd tmate SSH debugging
* build: run SSH by default, remove debug conditional
* build: remove redundent fetch-tags
* build: pin tmate to SHA
* build: remove tmate action
2024-06-06 12:09:50 -07:00
Shelley Vohr
ec4461d1f2
fix: iframe.contentWindow.document.fonts resolution ( #42366 )
...
fix: iframe.contentWindow.document.fonts resolution
2024-06-06 15:06:28 +02:00
Keeley Hammond
c9349a2590
build: [GHA] cross-compile x64 MacOS jobs on arm64 ( #42370 )
...
* build: split x64 mas/darwin to run concurrently
* Retry src cache download on failure
* build: gate FFMpeg, etc, to release & darwin
* build: cross-compile x64 on arm hardware
* chore (do not merge): comment out CircleCI config
* build: fix FFMpeg conditional but harder
* build: add fetch-deps to checkout
* build: correctly add target_arch to MAS configs
* build: correct target arch
* build: consolidate darwin/mas back into single runner per arch
* build: re-enable CircleCI
* Add missing ELECTRON_OUT_DIR for upload
* Add missing ELECTRON_GITHUB_TOKEN to secrets
* build: (do not merge) run only darwin
* build: remove seperate upload step
* build: re-enable mas, remove upload seperate job
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-05 23:06:25 -07:00
Charles Kerr
791907f0f3
refactor: move WebFrameRenderer into an anonymous namespace ( #42369 )
2024-06-05 18:31:52 -05:00
Keeley Hammond
7569d90f59
build: bump NMV to 128 for Electron 32 ( #42311 )
2024-06-05 12:55:45 -04:00
Alice Zhao
406f644d26
feat: duplicate navigation related APIs to contents.navigationHistory ( #41752 )
...
* refactor: move navigation related api to navigationHistory
* docs: add deprecation messages to old web content methods
* fix: add deprecation warnings to webcontents
* fix: add deprecation warnings and make existing naviagation apis internal
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* docs: fix links
* docs: add breaking change to 31
* docs: move breaking change to 32
* chore: re-run pipeline
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2024-06-05 09:34:47 -07:00
Anny Yang
5fb117a7d7
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42353 )
...
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
2024-06-05 09:58:38 +02:00
Shelley Vohr
39c984e23a
fix: WebUSB should not crash when using in-memory partitions ( #42347 )
2024-06-04 15:24:08 +02:00
dependabot[bot]
b74d3e14b0
build(deps): bump github/codeql-action from 3.25.6 to 3.25.7 ( #42354 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.6 to 3.25.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9fdb3e4972...f079b84933 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:12:16 +02:00
dependabot[bot]
01bf60bf66
build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.3 ( #42355 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...65462800fd760344b1a7b4382951275a0abb4808 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:56 +02:00
dependabot[bot]
1c36b8b390
build(deps): bump actions/checkout from 4.1.1 to 4.1.6 ( #42356 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...a5ac7e51b41094c92402da3b24376905380afc29 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:46 +02:00
Keeley Hammond
5f8a490a00
build: add release config/dsymutil fix, test-releases for GHA ( #42350 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
* build: use GN_CONFIG
* remove: hardcode release gn config
* Fix GN args import for release
* Use BUILD_TOOLS_SHA when cloning build-tools in test
* build: create test release in prepare-release
* build: fix GN_CONFIG for mas builds
* Fix dsymutil arch resetting
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-03 11:43:54 -07:00
Keeley Hammond
361b37592a
build: add GitHub Actions publishing pipeline for macOS ( #42236 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
2024-05-31 10:58:39 -07:00
electron-roller[bot]
4436ce53bc
chore: bump node to v20.14.0 (main) ( #42329 )
...
* chore: bump node in DEPS to v20.14.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-31 18:06:36 +02:00
Shelley Vohr
9f88820be9
fix: dialogs should work with BaseWindows internally ( #42315 )
2024-05-31 12:04:22 +02:00
Krzysztof Halwa
85df2a86dd
feat: Allow WebContentsView to accept webContents object. ( #42086 )
...
feat: Allow WebContentsView to accept webContents object
2024-05-30 12:45:35 -07:00
Keeley Hammond
d92a80dfe3
chore: cherry-pick 22db6918bac9 from chromium ( #42304 )
...
* chore: cherry-pick 22db6918bac9 from chromium
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-30 10:08:12 +02:00
Michaela Laurencin
5715cc0921
build: update NMV to 125 ( #42312 )
2024-05-29 13:03:23 -07:00
Charles Kerr
ae0c55c0b1
refactor: inherit Observer classes privately, pt. 2 ( #42237 )
...
* refactor: use private inheritance in PushNotifications
* refactor: use private inheritance in electron::api::App
* refactor: use private inheritance in electron::api::BrowserWindow
* refactor: use private inheritance in electron::api::NativeTheme
* refactor: use private inheritance in electron::api::Tray
* refactor: use private inheritance in electron::api::Session
* refactor: use private inheritance in electron::api::WebContents
* refactor: use private inheritance in electron::api::DownloadItem
* refactor: use private inheritance in electron::api::MenuBar
* refactor: use private inheritance in ClearDataOperation
* refactor: use private inheritance in electron::api::Screen
* refactor: use private inheritance in electron::ElectronDesktopWindowTreeHostLinux
* refactor: use private inheritance in SpellCheckerHolder
* refactor: use private inheritance in electron::api::PowerMonitor
* refactor: use private inheritance in electron::api::BaseWindow
* refactor: use private inheritance in electron::api::AutoUpdater
* refactor: use private inheritance in electron::api::Menu
* refactor: use private inheritance in electron::api::NativeWindowViews
* refactor: use private inheritance in electron::ElectronBrowserClient
* refactor: use private inheritance in electron::AutofillPopupView
* refactor: use private inheritance in GtkMessageBox
* refactor: use private inheritance in electron::OffScreenRenderWidgetHostView
* refactor: use private inheritance in electron::InspectableWebContents
* refactor: use private inheritance in electron::ElectronUsbDelegate
* refactor: use private inheritance in electron::LoginHandler
* refactor: use private inheritance in WebFrameRenderer
* refactor: use private inheritance in electron::ElectronSerialDelegate
* refactor: use private inheritance in electron::ClientFrameViewLinux
* refactor: use private inheritance in electron::ElectronHidDelegate
* refactor: use private inheritance in IPCRenderer
* refactor: use private inheritance in electron::WinCaptionButtonContainer
* refactor: use private inheritance in electron::ElectronApiIPCHandlerImpl
* refactor: use private inheritance in electron::api::ServiceWorkerContext
* refactor: use private inheritance in ui::FileSelectHelper
* refactor: use private inheritance in electron::api::WebContentsView
* refactor: use private inheritance in electron::api::SimpleURLLoaderWrapper
* refactor: use private inheritance in electron::api::InAppPurchase
* refactor: use private inheritance in electron::api::Debugger
* refactor: use private inheritance in electron::ElectronWebContentsUtilityHandlerImpl
* refactor: use private inheritance in electron::OffScreenWebContentsView
2024-05-29 13:07:02 -05:00
IsmaelMartinez
705d92c5f6
docs: fix broken notification-spec markdown link ( #42243 )
...
* docs: fix broken notification-spec markdown link
* docs: update notification-spec linkt to point to freedesktop
2024-05-29 14:41:17 +02:00
Samuel Attard
22ba8b6f01
fix: restore original BrowserWindow.show() behavior ( #42300 )
2024-05-28 23:31:11 -07:00
Erick Zhao
09fb892c6e
docs: ensure all links are on a single line ( #42235 )
2024-05-28 11:15:18 -07:00
Charles Kerr
bb4374ee2c
fix: potential null dereference in normalizeSpawnArguments() patch ( #42260 )
...
fix: potential null deref in normalizeSpawnArguments() patch
Use upstream's practice of using `env = options.env || process.env`.
Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD
and CRASHPAD_HANDLER_PID to options.env.
2024-05-27 10:41:42 +02:00
Evo
6423968dc5
fix: fixed the type of WebviewTag.webpreferences ( #42275 )
...
fix: fixed the type of WebviewTag.webpreferences
2024-05-25 22:06:06 -07:00
BILL SHEN
3ffa35dc8d
fix: calculate a hash for the Tag property of ToastNotification. ( #42239 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
* fix: calculate a hash for the Tag property of ToastNotification.
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-05-24 21:20:59 +02:00
Keeley Hammond
7ec813732a
chore: cherry-pick 3e037e195e50 from v8 ( #42253 )
2024-05-23 07:20:13 -07:00
dependabot[bot]
0285ff0c0f
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #42230 )
...
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:23 +02:00
dependabot[bot]
f6bdbd6000
build(deps): bump github/codeql-action from 3.25.5 to 3.25.6 ( #42229 )
...
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:12 +02:00
Charles Kerr
752efddf89
refactor: prefer to inherit observer classes privately ( #41360 )
...
* refactor: use private inheritance in CookieChangeNotifier
* refactor: use private inheritance in WebViewGuestDelegate
* refactor: use private inheritance in UsbChooserController
* refactor: use private inheritance in DesktopCapturer
* refactor: use private inheritance in Browser
* refactor: use private inheritance in WebContentsZoomController
* refactor: use private inheritance in FrameSubscriber
* refactor: use private inheritance in AutofillAgent
* refactor: use private inheritance in HidChooserController
* refactor: use private inheritance in PepperHelper
* refactor: use private inheritance in AutofillPopup
* refactor: use private inheritance in SerialChooserController
* refactor: use private inheritance in MediaCaptureDevicesDispatcher
* refactor: use private inheritance in electron::api::View
* refactor: use private inheritance in AutofillDriverFactory
* refactor: use private inheritance in GPUInfoManager
* refactor: use private inheritance in SavePageHandler
* refactor: use private inheritance in GlobalShortcut
* refactor: use private inheritance in ElectronRenderFrameObserver
2024-05-21 14:21:31 -05:00
dependabot[bot]
23a5d8b64a
build(deps): bump mikefarah/yq from 4.43.1 to 4.44.1 ( #42228 )
...
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 20:41:47 -07:00
Samuel Attard
2e778a98b9
fix: ensure showInactive actually shows ( #42226 )
2024-05-20 14:12:05 -07:00
Erick Zhao
b8381b7d93
docs: fix broken anchors ( #42213 )
2024-05-17 09:46:18 +02:00
Shelley Vohr
af9a59cc40
build: cancel in-progress runs on new commits ( #42193 )
2024-05-15 23:45:54 +02:00
Charles Kerr
c67744a127
refactor: use raw_ref in RootView ( #42114 )
...
* refactor: make RootView::window_ a const raw_ref
The Chromium C++ style guide says "prefer const raw_ref<T> whenever
the held pointer will never be null," so let's do that.
* refactor: make RootView::main_view_ a const raw_ref
> The Chromium C++ style guide says "prefer const raw_ref<T> whenever
> the held pointer will never be null," so let's do that.
* refactor: aggregate RootView::last_focused_view_tracker_
RootView already owns it, so aggregate it
2024-05-15 14:45:47 -04:00
David Sanders
0b62abf244
chore: use markdownlint-cli2 directly for linting Markdown ( #42192 )
2024-05-15 14:44:46 -04:00
Jeremy Rose
19dc276878
feat: remove File.path ( #42053 )
2024-05-15 11:07:23 -07:00
Shelley Vohr
a54afabe04
fix: win.center() on Windows ( #42195 )
...
fix: win.center() on Windows
2024-05-15 10:36:24 -07:00
Piotr Płaczek
125bd6aa2b
docs: troubleshooting advice for rbe auth 'token not valid' error ( #42027 )
2024-05-15 10:35:32 -07:00
Keeley Hammond
7f8fabbe7b
chore: remove focus ring patch ( #42183 )
2024-05-14 15:57:00 -07:00
Samuel Attard
435003566d
fix: restore non-panel focus behavior ( #42180 )
2024-05-14 15:52:08 -07:00
Keeley Hammond
d7099b0ad4
chore: cherry-pick b3c01ac1e60a from v8 ( #42172 )
...
* chore: cherry-pick b3c01ac1e60a from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 18:02:24 -04:00
Fedor Indutny
f2af35182c
fix: fix cast in ElectronDesktopWindowTreeHostLinux ( #42179 )
...
Fix cast in ElectronDesktopWindowTreeHostLinux
The frame view of the widget is an `ClientFrameViewLinux` instance only
when both `frame` and `client_frame` booleans are set to `true`.
Otherwise it is an instance of a different class and thus casting to
`ClientFrameViewLinux` is incorrect and leads to crashes.
Fix : #41839
2024-05-14 14:26:39 -07:00
Shelley Vohr
d0cb298f95
fix: webContents.navigationHistory should be enumerable ( #42139 )
...
fix: webContents.navigationHistory should be enumerable
2024-05-14 16:47:47 -04:00
David Sanders
1ef5406c8c
chore: enable no autolink markdownlint rule ( #42127 )
2024-05-14 16:32:52 -04:00
dependabot[bot]
4e70213037
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.4.0 ( #42161 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...48d2ff8c1a )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:53:15 -04:00
dependabot[bot]
45cc31fd2f
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 ( #42160 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.3 to 3.25.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d39d31e687...b7cec75265 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:52:54 -04:00
dependabot[bot]
03e259dc25
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 ( #42159 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](0864cf1902...dc50aa9510 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:51:35 +02:00
dependabot[bot]
e4d89ba2b4
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5.5.2 ( #42158 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.4.0 to 5.5.2.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](e9fabac35e...cfb60706e1 )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:50:36 +02:00
John Kleinschmidt
44ebc1b1c2
chore: update patches after #42126 was merged ( #42153 )
2024-05-13 15:46:59 -07:00
electron-appveyor-updater[bot]
4c27b0c282
build: update appveyor image to latest version ( #42135 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-05-13 16:58:15 -04:00
Samuel Attard
e19754d7fd
test: add tests for electron fuses ( #42129 )
...
* spec: add tests for electron fuses
* spec: fix tests for windows
* spec: handle weird crash codes on win32
* spec: disable fuse tests on arm64 windows
2024-05-13 10:48:26 -07:00
Keeley Hammond
c56e1dffb0
fix: partially revert invalidate focus ring ( #42126 )
2024-05-13 11:02:59 -05:00
electron-roller[bot]
653d0f009e
chore: bump node to v20.13.1 (main) ( #42088 )
...
* chore: bump node in DEPS to v20.13.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
https://github.com/nodejs/node/pull/52217
* test: skip test for dynamically linked OpenSSL
https://github.com/nodejs/node/pull/52542
* lib, url: add a `windows` option to path parsing
https://github.com/nodejs/node/pull/52509
* src: use dedicated routine to compile function for builtin CJS loader
https://github.com/nodejs/node/pull/52016
* test: mark test as flaky
https://github.com/nodejs/node/pull/52671
* build,tools: add test-ubsan ci
https://github.com/nodejs/node/pull/46297
* src: preload function for Environment
https://github.com/nodejs/node/pull/51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
https://github.com/nodejs/node/pull/52285
* chore: handle updated filenames
- https://github.com/nodejs/node/pull/51999
- https://github.com/nodejs/node/pull/51927
* chore: bump node in DEPS to v20.13.1
* events: extract addAbortListener for safe internal use
https://github.com/nodejs/node/pull/52081
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* fs: add stacktrace to fs/promises
https://github.com/nodejs/node/pull/49849
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 11:43:14 -04:00
Charles Kerr
10fd0ba655
refactor: use base::Value::Take*() ( #41169 )
...
* perf: avoid temporary strings in Converter<net::HttpRequestHeaders>::FromV8()
* perf: take strings instead of copying them in ToResponseHead()
* refactor: prefer base::Value::Take*() where appropriate
As per the base::Value docs: "prefer over `std::move(value.Get...())`
so clang-tidy can warn about potential use-after-move mistakes."
2024-05-13 15:58:52 +02:00
David Sanders
88f28a302f
docs: improve protocol.handle file examples ( #42111 )
...
* docs: improve protocol.handle file examples
* chore: fix lint
2024-05-13 11:49:18 +02:00
Richard Torres
8d4467bdc4
docs: fixing typo in dark mode fiddle and doc ( #42112 )
2024-05-13 10:50:55 +02:00
David Sanders
188196e78c
ci: auto label bug issues with version label ( #42044 )
2024-05-13 10:49:23 +02:00
Shelley Vohr
c765d57265
fix: BrowserView autoresizing conversion error ( #42056 )
2024-05-13 10:27:01 +02:00
Samuel Attard
3ea3b0e8e1
fix: ensure originalFs.promises.cp works ( #42132 )
2024-05-12 21:03:00 -07:00
Keeley Hammond
96dda274e9
chore: cherry-pick f320600cd1f4 from v8 ( #42120 )
2024-05-11 14:17:02 -07:00
electron-roller[bot]
9b0409f7c9
chore: bump chromium to 126.0.6445.0 (main) ( #41868 )
...
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-10 11:21:10 -04:00
dependabot[bot]
0725f5c5cf
build(deps): bump mikefarah/yq from 4.40.7 to 4.43.1 ( #42074 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.43.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...c35ec752e3 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-10 11:33:15 +02:00
David Sanders
c00eb5d491
chore: update @electron/lint-roller to 2.1.0 ( #42078 )
2024-05-10 11:00:15 +02:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
Charles Kerr
e2acdffe58
perf: avoid protocol registry redundant lookup ( #41991 )
...
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource()
* refactor: remove unused ProtocolRegistry::IsProtocolRegistered()
refactor: remove unused ProtocolRegistry::IsProtocolIntercepted()
* refactor: remove unused ProtocolRegistry::handlers()
* refactor: rename ProtocolRegistry::FindIntercepted()
refactor: rename ProtocolRegistry::FindRegistered()
similar semantics to base::Value::Find*()
* chore: follow Google C++ brace style
chore: use same variable names as in main
2024-05-09 09:53:09 -04:00
Shelley Vohr
865b0499bb
refactor: use //ui/shell_dialogs on Linux ( #42045 )
...
* refactor: use //ui/shell_dialogs on Linux
* fix: add proper filtering
* fix: add support for missing dialog features to //shell_dialogs
* fix: parent_window could be null
* chore: cleanup patch
* fix: use a OnceCallback in the sync implementation
* chore: remove stray debuglog
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use settings struct
* fix: show hidden file property checking
* chore: changes from review
* fix: multi selection for dialogs
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-05-09 09:51:42 -04:00
Shelley Vohr
6675f3ae65
fix: CHECK when adding view as its own child ( #42067 )
2024-05-09 09:47:47 -04:00
Shelley Vohr
731bc7a334
fix: BrowserWindow.center() should center relative to screen ( #42048 )
2024-05-08 15:42:20 -07:00
dependabot[bot]
793276ac87
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 ( #42076 )
2024-05-08 13:36:33 +02:00
Peter Xu
0128a072d6
docs: make corrections for BrowserViews since it is deprecated ( #42030 )
2024-05-08 11:21:26 +02:00
dependabot[bot]
a059dd7b69
build(deps): bump github/codeql-action from 3.24.0 to 3.25.3 ( #42073 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.25.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...d39d31e687 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-08 10:43:29 +02:00
dependabot[bot]
53a4484372
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #42075 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-08 10:42:32 +02:00
Christian Clauss
8cfc4b9d50
ci: keep GitHub Actions up to date with GitHub's Dependabot ( #42042 )
...
* Keep GitHub Actions up to date with GitHub's Dependabot
Fixes software supply chain safety warnings like at the bottom right of
https://github.com/electron/electron/actions/runs/8619491231
* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot )
* [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem )
* Apply suggestion from code review
* chore: fully remove groups
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-05-07 19:25:46 -04:00
Erick Zhao
c3c4173377
docs: update formatting for mdx3 compatibility ( #42052 )
...
docs: update formatting for mdx3 compat
2024-05-07 19:20:47 -04:00
cptpcrd
d5c8f2d6d9
fix: avoid crash after upgrade on Linux ( #41046 )
2024-05-07 16:04:50 +02:00
Piotr Płaczek
5b60698dea
docs: fix lint command ( #42028 )
2024-05-04 15:48:08 +02:00
Charles Kerr
05631ec445
chore: disable tests that require nut.js ( #42006 )
...
* chore: disable tests that require nut.js
* fixup! chore: disable tests that require nut.js
2024-04-30 21:13:38 -04:00
John Kleinschmidt
36310b8729
chore: fixup gn check when enable_pdf_viewer is false ( #41990 )
2024-04-30 20:32:11 -04:00
Shelley Vohr
f5fb44eaf8
fix: requestFullscreen from WebContentsView ( #41966 )
...
fix: requestFullscreen from WebContentsView
2024-04-29 19:09:29 -04:00
Shelley Vohr
441dbda833
fix: recentDocuments on macOS not working ( #41978 )
2024-04-29 19:07:14 -04:00
Michaela Laurencin
ef097b77ad
chore: fix notes stack updates ( #41600 )
...
* chore: fix removeSupercededStackUpdates for generating notes
* add early stop for less than
* Update script/release/notes/notes.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* clean up comparison functionality
* add tests
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-04-29 11:41:54 -04:00
Shelley Vohr
5310b79ffb
fix: setTitleBarOverlay should be implemented on BaseWindow ( #41960 )
...
fix: setTitleBarOverlay should be implemented on BaseWindow
2024-04-29 11:28:24 -04:00
Shelley Vohr
b95d0f7623
build: use env var for build-tools pinning ( #41969 )
2024-04-29 10:07:42 -04:00
Shelley Vohr
b41da150ca
build: add GitHub Actions testing pipeline for macOS ( #41812 )
...
* build: test the Mac runner space
* build: baby steps, super basic checkout
* chore: simplify depot-tools
* build: try a sync
* build: fix path
* build: pass different URL for sync
* build: gclient sync with --verbose
* debug: add logging for mtime cache
* build: add psuedocode for Azure workflow, add workflow_dispatch
* build: enable ssh access to runners
* build: test azure upload without full sync
* build: full sync and cache upload test
* build (WIP): mock out download logic
* build: remove sync, try disk space prune
* build: lets try it again, lads
* ci: add cache downloading wip
* fix: correct json parsing
* chore: use depshash and fix output syntax
* chore: rework depshash state and delete more
* refactor: split checkout to Linux runner
* fix: depot_tools get on Linux
* fix: add infra/3pp/tools/swift-format handling
* chore: move to patch file in build as well
* chore: misc cleanup of env steps
* chore: add fix sync step
* build: use tar file, strip .git dirs
* build: set GIT_CACHE_PATH outside of src
* ci: fix cache prefix, add check for ssh debug
* fix: fix tar pack/unpack
* build: add reclient support & ninja build step
* chore: clean up reclient round 1
* fix: grab ELECTRON_RBE_JWT from secrets
* chore: run tmate if debug logging enabled
* chore: move ulimit setting
* fix: missing GN gen env vars
* fix: workaround packed-refs issue
* chore: fixup PATH usage
* chore: remove GIT_CACHE env var
* fix: call pack refs manually
* fix: add RBE_experimental_credentials_helper_args
* chore: whoops we need electron_node/deps/v8 actually
* fix: we need electron_node/deps/openssl too
* build: load build-tools & xcode
* build: add dist, chromedriver & mksnapshot
* build: add test job, download artifacts
* Cache non-generated build artifacts
* chore: set download path explicitly
* chore: load-xcode is called by e build
* Add codesigning certificate step
* Add Test Step
* Try without codesigning just to get tests running
* Add depot_tools to PATH in test
* Persist src/buildtools/mac
* chore: use script/yarn test directly
* Build Node.js Headers for caching
* Add initial matrix for mas build
* Fix GN_EXTRA_ARGS generation syntax
* Fix BUILD_TYPE interpolation
* Use matrix in test correctly
* feat: add publish config, alter release-build script
* build: force trigger the first workflow
* build: oops
* Ensure env vars escaped
* Move GN_EXTRA_ARGS to gn gen step
* chore: rename yml to match convention
* ci: fix helperPath calls in action configs
* chore: try setting directly
* fix: switch to mas config
* chore: Testing -> Default
* Re-enable darwin build
* Use mas JSON config
* refactor: extract artifact logic to bash scripts
* refactor: build MAS after darwin
* chore: move to script/actions
* chore: use Node.js 20.11.x
* Don't fail-fast in tests
* build: tweak release script
* build: remove macos-publish.yml
* build: change action to trigger on publish workflow dispatch
* chore: remove SSH debugging using action-tmate
* build: do not disable CircleCI config
* chore: switch away from cURL for AzureCLI
* chore: move evm.mas.json to .github/workflows/config
* chore: remove publish logic from initial build flow
* build: add patchup check for non-release builds
* build: pin build-tools to sha 2bb63e2
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-04-24 10:29:19 -07:00
Charles Kerr
b684a98267
refactor: replace base::EndsWith() with std::ends_with() ( #41937 )
2024-04-23 21:13:59 -05:00
South Drifted
7621e7cff7
docs: Windows typo in Tutorial document ( #41896 )
...
Update tutorial-6-publishing-updating.md
2024-04-23 13:14:26 -04:00
Shelley Vohr
d8f8560b1c
refactor: address changes and fix errors in chrome://accessibility ( #41911 )
...
refactor: address changes and fix errors in chrome://accessibility
2024-04-23 11:30:47 -04:00
Kilian Valkhof
1cf194faae
docs: correct the return value for canceled showSaveDialog ( #41926 )
2024-04-23 11:29:14 -04:00
Shelley Vohr
a0fee8f47a
build: fixup codespaces on-create ( #41428 )
2024-04-22 20:26:11 -04:00
Jeremy Rose
4e8c28fdf0
fix: data corruption in protocol.handle ( #41894 )
2024-04-22 13:40:01 -07:00
tuanzijiang
46adb0a3a9
fix: offscreen rendering does not paint after gpu process crashed ( #41904 )
...
Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com >
2024-04-22 09:50:55 -04:00
Shelley Vohr
a8db7fe2ef
build: use latest devcontainer buildimage with codespaces ( #41916 )
2024-04-22 09:48:30 -04:00
Charles Kerr
0346e0a8bf
refactor: use std::erase() ( #41881 )
...
* refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences()
* refactor: use std::erase() in WindowList::RemoveWindow()
* refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed()
* refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit()
* refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission()
* refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList()
* refactor: move DoesDeviceMatch() out of class into anonymous namespace
2024-04-19 10:55:59 -05:00
Shelley Vohr
39bf441b3b
build: enable Perfetto in Chromium ( #41880 )
...
* build: enable perfetto in Chromium
* refactor: delete TracingControllerImpl
* fix: TraceObject isn't present when v8_use_perfetto is true
* fix: update lib/internal/http for perfetto
* chore: remove stray log
2024-04-19 11:07:36 -04:00
Samuel Attard
46ef7ef8fb
build: update typescript-definitions to 8.15.6 ( #41900 )
2024-04-19 10:29:45 -04:00
JakobDev
07a68c2bf8
fix: don't check for Desktop Environment in unity_service.cc ( #41211 )
...
Don't check for Desktop Environment in unity_service.cc
2024-04-19 09:58:32 -04:00
Jeremy Rose
ed9fec7da4
fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer ( #41875 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
* also fix shell.openExternal
2024-04-19 09:43:01 -04:00
Shelley Vohr
c4aeb17245
fix: EINVAL when spawning cmd files on Windows ( #41893 )
...
fix: EINVAL when spawning on Windows
2024-04-19 09:27:58 -04:00
Jeremy Rose
67ba30402b
refactor: JSify BrowserWindow unresponsive handling ( #37902 )
2024-04-18 13:14:07 -07:00
Charles Kerr
b683754c16
chore: remove unused hash function ( #41876 )
...
Unused since e1e73fa #24115
2024-04-17 19:04:06 -05:00
nashaofu
0222686e9a
docs: update build docs,support Powershell on Windows ( #41567 )
...
* docs: update build docs,support Powershell on Windows
* chore: fix capitalization
2024-04-17 18:46:52 -04:00
James Yuzawa
bf754a3cae
fix: make window.flashFrame(bool) flash continuously on macOS ( #41391 )
...
fix: window.flashFrame to flash continuously on mac
This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest ) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest ) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos ).
2024-04-17 12:42:34 -04:00
electron-roller[bot]
7120c58297
chore: bump node to v20.12.2 (main) ( #41710 )
...
* chore: bump node in DEPS to v20.12.0
* chore: update build_add_gn_build_files.patch
* chore: update patches
* chore: bump node in DEPS to v20.12.1
* chore: update patches
* build: encode non-ASCII Latin1 characters as one byte in JS2C
https://github.com/nodejs/node/pull/51605
* crypto: use EVP_MD_fetch and cache EVP_MD for hashes
https://github.com/nodejs/node/pull/51034
* chore: update filenames.json
* chore: bump node in DEPS to v20.12.2
* chore: update patches
* src: support configurable snapshot
https://github.com/nodejs/node/pull/50453
* test: remove test-domain-error-types flaky designation
https://github.com/nodejs/node/pull/51717
* src: avoid draining platform tasks at FreeEnvironment
https://github.com/nodejs/node/pull/51290
* chore: fix accidentally deleted v8 dep
* lib: define FormData and fetch etc. in the built-in snapshot
https://github.com/nodejs/node/pull/51598
* chore: rebase on main
* chore: remove stray log
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Cheng <zcbenz@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-04-17 12:39:13 -04:00
Shelley Vohr
b118c70f77
refactor: fold silent print into settings ( #41873 )
...
* refactor: fold silent print into settings
* chore: feedback
2024-04-17 12:04:47 -04:00
electron-appveyor-updater[bot]
cdafe09ffb
build: update appveyor image to latest version ( #41871 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-04-17 10:51:13 -04:00
Charles Kerr
b428315c6d
perf: remove unnecessary .c_str() calls ( #41869 )
...
* perf: remove unnecessary c_str() call when invoking promise.RejectWithErrorMessage()
RejectWithErrorMessage() takes a std::string_view
* perf: remove unnecessary c_str() call when invoking Environment::SetVar()
the val arg to Environment::SetVar() takes a const std::string&
* refactor: use string_view variant of base::UTF8ToWide()
* perf: remove unnecessary c_str() call when instantiating a ScopedHString
ScopedHString has always taken a StringPiece
* refactor: use simpler invocation of base::make_span()
* perf: remove unnecessary c_str() call when calling base::CommandLine::HasSwitch()
HasSwitch() already takes a string_piece
* perf: remove unnecessary c_str() call when calling net::HttpResponseHeaders::AddHeader()
AddHeader() already takes a StringPiece arg
* perf: omit unnecessary str -> wstr -> str conversion in DesktopCapturer::UpdateSourcesList()
this conversion was made redundant by c670e38
2024-04-16 19:48:54 -04:00
electron-roller[bot]
c670e38b4b
chore: bump chromium to 125.0.6412.0 (main) ( #41610 )
...
* chore: bump chromium in DEPS to 124.0.6361.0
* chore: bump chromium in DEPS to 124.0.6363.0
* chore: update patches
Manually apply printing.patch w/no code changes due to upstream shear.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5349263
* chore: bump chromium in DEPS to 124.0.6365.0
* chore: bump chromium in DEPS to 124.0.6367.0
* update patches
* 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple
https://chromium-review.googlesource.com/c/chromium/src/+/5371735
* missed a MAS bit
* chore: update windows toolchain
5350823: New toolchain for Windows 11 10.0.22621.2428 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/5350823
* chore: bump chromium in DEPS to 125.0.6368.0
* fix patches
* chore: update patches
* 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2)
https://chromium-review.googlesource.com/c/chromium/src/+/5232401
* revert https://chromium-review.googlesource.com/c/chromium/src/+/5380898
* chore: bump chromium in DEPS to 125.0.6370.0
* build: use updated windows toolchain
* fix patches
* chore: update patches
* more pdf_util to components
* 5372414: [Extensions] Remove DispatcherDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5372414
* fix accessibility_ui patch
* chore: bump chromium in DEPS to 125.0.6372.0
* chore: bump chromium in DEPS to 125.0.6374.0
* chore: bump chromium in DEPS to 125.0.6376.0
* chore: bump chromium in DEPS to 125.0.6378.0
* chore: bump chromium in DEPS to 125.0.6379.3
* chore: update patches (+ MAS patch changes)
* chore: update patches
* 5381159: Cleanup media::KeySystemSupportObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5381159
* 5382233: Reland "Web `Speech to Text` with SODA backend"
https://chromium-review.googlesource.com/c/chromium/src/+/5382233
* chore: update `exclusive_access` patch
- 5367497: Add a metric for the website state when Fullscreen API is requested
- https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: add build dependency
5367497: Add a metric for the website state when Fullscreen API is requested
https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: bump chromium in DEPS to 125.0.6382.0
* chore: update libcxx filenames
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6384.0
* chore: remove old patch
* 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files
https://chromium-review.googlesource.com/c/chromium/src/+/5394039
* fix: remove deprecated errno constants in node/libuv
* 5362194: Return expected from ProcessMetrics CPU methods
https://chromium-review.googlesource.com/c/chromium/src/+/5362194
* 5383927: Add new Pickle factory functions with explicit ownership
https://chromium-review.googlesource.com/c/chromium/src/+/5383927
* 5373340: Simplify app-region/Draggable Region implementation
https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* 5386875: Cleanup printing preferences files
https://chromium-review.googlesource.com/c/chromium/src/+/5386875
* chore: update libc++ filenames
* fix: add enterprise buildflags dep
* chore: bump chromium in DEPS to 125.0.6386.0
* chore: add build dep
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6388.0
* chore: bump chromium in DEPS to 125.0.6390.0
* chore: update patches
* 4918014: preloading: Add NewTabPagePageLoadMetricsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/4918014
* 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API
https://chromium-review.googlesource.com/c/chromium/src/+/5401234
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* fixup! 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* fixup! chore: add build dep
* chore: remove dead code & dead patch
Was dealing with https://chromium-review.googlesource.com/c/chromium/src/+/5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514 ).
The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay!
* chore: bump chromium in DEPS to 125.0.6392.0
* chore: bump chromium in DEPS to 125.0.6393.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6394.0
* chore: bump chromium in DEPS to 125.0.6396.0
* chore: bump chromium in DEPS to 125.0.6397.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5100842
No code changes, but had to apply patch manually due to upstream code shear
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 2
* chore: silence "space before tab in indent" git rebase-apply warning
* chore: e patches all
* build: update all.gn to avoid FTBFS when disabling raw_ptr
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5371737
* Rename PdfService Mojo interface to PdfHost
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5411957
* chore: bump chromium in DEPS to 125.0.6398.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6400.0
* chore: update patches
* [media] Remove unused `GetSupportedKeySystems` from MediaClient
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5420247
* chore: update JSInjection::New call to match upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5403967
[Extensions] Wire up the renderer for multiple user script worlds
* 5362362: Derive display ID from monitor adapter ID instead of szDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/5362362
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* chore: add v8-sandbox.h to electron-node
* chore: update patches
* chore: update patches
* fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files
* chore: bump chromium in DEPS to 125.0.6412.0
* chore: update patches
* chore: node script/gen-libc++-filenames.js
* [FPF] Create Fingerprinting Protection ruleset service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5420158
* Add ExclusiveAccessPermissionManager
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5273787
* Preserve the PNG colorspace when decoding into a SkBitmap.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5421254
* chore: iwyu
* fix: abstract-socket compilation
* ci: bump container for node 20 support
* fixup! abstract-socket compilation
* fix: compiling nan specs
* chore: revert winreg version bump
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient
test suite. Should be revisited separately.
* ci: set node 20 for darwin x64 tests
* fix: broken patch export
* chore: cleanup mas_avoid_private_macos_api_usage.patch.patch
Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-04-15 18:10:32 -04:00
lauren n. liberda
6aa9a003c8
fix: stop using std::vector<const uint8_t> in ProcessingSingleton ( #41832 )
2024-04-15 10:32:48 -07:00
Shelley Vohr
2a6ad42113
chore: delete unused PrintPreviewMessageHandler ( #41841 )
2024-04-15 11:34:56 -04:00
lauren n. liberda
d80c5f8377
build: redundant regex character class in generate-config-gypi.py ( #41858 )
...
fix: redundant regex character class in generate-config-gypi.py
'\w' already includes '_'. solves a SyntaxWarning on python 3.12.
2024-04-15 11:33:55 -04:00
Erick Zhao
755f7d5ed0
docs: clarify before ready usage ( #41849 )
2024-04-15 10:38:58 -04:00
Cedrik Ewers
734395bea9
docs: use "id" instead of "label" for positions ( #41843 )
...
Co-authored-by: Cedrik Ewers <C.Ewers@beckhoff.com >
2024-04-14 17:10:09 -07:00
dependabot[bot]
75dae2e004
build(deps): bump tar from 6.1.13 to 6.2.1 in the npm_and_yarn group across 1 directory ( #41842 )
...
build(deps): bump tar in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [tar](https://github.com/isaacs/node-tar ).
Updates `tar` from 6.1.13 to 6.2.1
- [Release notes](https://github.com/isaacs/node-tar/releases )
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.13...v6.2.1 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-12 13:28:37 -07:00
Robo
b446ce7f22
fix: package <__assertion_handler> as part of libcxx headers ( #41830 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5208502
2024-04-12 23:50:03 +09:00
Mitchell Cohen
05fba85aa3
fix: do not activate app when showing a panel on Mac ( #41750 )
...
* fix: do not activate app when showing or focusing a panel on Mac
* restored panel activation test
2024-04-12 14:27:59 +02:00
Shelley Vohr
db11090e58
fix: silent printing default dpi on Windows ( #41811 )
2024-04-11 19:56:39 -04:00
Calvin
df22e62bf4
docs: update release timeline ( #41825 )
2024-04-11 19:37:47 -04:00
Erick Zhao
f8c832d80d
docs: update ASAR integrity tutorial ( #41828 )
...
* docs: document windows asar integrity
* docs: update ASAR integrity tutorial
* fix lint
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-04-11 13:41:58 -07:00
Shelley Vohr
344aba0838
feat: implement File System API support ( #41419 )
2024-04-10 22:06:47 +02:00
RoboSchmied
41ba963392
fix: typos in comment section of in_app_purchase.mm ( #41788 )
...
fix 2 typo
Signed-off-by: Michael Seibt <github@roboschmie.de >
2024-04-10 11:54:56 -04:00
Shelley Vohr
43a9f70d19
feat: support NODE_EXTRA_CA_CERTS ( #41689 )
...
* feat: support NODE_EXTRA_CA_CERTS
* chore: allow disabling NODE_EXTRA_CA_CERTS
* chore: call base::Environment::UnSetVar
* docs: link to fuses from env vars
* chore: update patch to match upstream
* docs: note enabled by default
* Update environment-variables.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-10 10:30:35 -04:00
Kaitlin Newson
0a7df0ef3d
docs: typo fix ( #41787 )
...
Typo fix
2024-04-10 10:25:13 +02:00
Shelley Vohr
38ef9a7690
refactor: move PDF viewer to OOPIF ( #41728 )
...
https://issues.chromium.org/issues/40268279
2024-04-09 19:59:48 -04:00
Shelley Vohr
ba3b647fd7
fix: WCO maximize button visibility when non-maximizable ( #41793 )
...
fix: WCO button visibility when non-maximizable
2024-04-09 13:14:29 +02:00
Jeremy Rose
76f7bbb0a8
fix: move BrowserWindow's WebContentsView to be a child of rootview ( #41256 )
2024-04-08 10:30:23 -07:00
Bruno Pitrus
22c149812c
build: add missing header for content::SyntheticGestureTarget ( #41789 )
...
IWYU: add missing header for `content::SyntheticGestureTarget`
GNU libstdc++ does not allow using std::unique_ptr on incomplete types,
leading to a compile error.
2024-04-08 18:17:00 +02:00
David Sanders
42164d7081
build: add Markdown lint check for unescaped angle brackets ( #41753 )
2024-04-04 14:50:35 -04:00
Calvin
3eb94b72ba
feat: Options parameter for Session.clearData API ( #41355 )
...
* feat: Options parameter for `Session.clearData` API
* Consolidate & curate data type categories
* Update docs for better typing
* off-by-one typo
* refactor to use `std::shared_ptr` instead of `base::RefCounted`
* fix compile errors
* std::enable_shared_from_this didn't work 🤷
* Refine docs with defaults
2024-04-01 12:09:01 -04:00
Keeley Hammond
752f2eb124
build: add GH Actions to release-build script ( #41639 )
...
* build: add GH Actions to release-build script
* Update script/release/ci-release-build.js
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-01 10:02:26 -04:00
Shelley Vohr
beafbfd511
build: combine ImportModuleDynamically patches ( #41712 )
...
build: combine ImportModuleDynamically patches
2024-03-29 13:34:56 +01:00
dependabot[bot]
d54645e554
build(deps-dev): bump express from 4.18.2 to 4.19.2 ( #41716 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 16:12:14 -07:00
Shelley Vohr
0bf53a3876
fix: Storage.{get|set|clear}Cookies via CDP not working ( #41718 )
2024-03-28 16:09:27 -07:00
Shelley Vohr
62d4b21819
test: disable flaky <webview>.capturePage() specs ( #41713 )
...
test: disable flaky <webview>.capturePage() specs
2024-03-28 22:37:14 +01:00
Shelley Vohr
61457c9498
feat(serial): allow Bluetooth ports to be requested by service class ID ( #41638 )
...
* feat(serial): allow Bluetooth ports to be requested by service class ID
* fix: bluetooth dependency
2024-03-28 18:23:13 +01:00
Jeremy Rose
c6102b9278
docs: add missing headers option to ClientRequest options ( #41723 )
2024-03-28 09:38:16 -07:00
daihere1993
72c2b9e862
fix: recognize 'undefined' header value in ClientRequest ( #41615 )
...
Co-authored-by: zowu <luke.wu@nokia-sbell.com >
2024-03-27 16:46:07 -07:00
Shelley Vohr
08241669bc
test: add tests for Storage Access API ( #41698 )
2024-03-27 19:52:24 +01:00
Samuel Attard
6e36153799
build: fix potential source of errors in issue workflow ( #41715 )
2024-03-27 09:50:55 -07:00
taoky
4f76fff978
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41691 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
2024-03-27 10:53:23 +01:00
Alice Zhao
c82ec0c72b
test: remove hardcoded url ( #41706 )
2024-03-27 10:53:02 +01:00
Alice Zhao
c57ce31e84
test: fix flaky tests in webContents.navigationHistory ( #41705 )
...
test: fix flaky tests by replacing real urls with data urls
2024-03-27 13:49:11 +09:00
Shelley Vohr
32b44aa5c8
fix: crash on extension unload when script validation finishes ( #41686 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5225796
2024-03-26 14:32:06 +01:00
Shelley Vohr
7032c0d03c
test: add test and api_feature definition for chrome.scripting.globalParams ( #41685 )
...
chore: add test and api_feature for chrome.scripting.globalParams
2024-03-26 12:33:47 +01:00
Erick Zhao
b9c4b27781
docs: backslash escape parametrized TypeScript types ( #41575 )
...
* docs: backslash escape parametrized TypeScript types
* missing instances
2024-03-25 11:19:44 +01:00
Shelley Vohr
8c427253b3
refactor: update gin_helper/function_template ( #41534 )
...
* refactor: update gin_helper/function_template
* fix: crash in Node.js Worker threads
2024-03-25 10:01:54 +01:00
Shelley Vohr
ed28ead8ac
fix: WTF-8 decoding issue in node:fs ( #41673 )
...
fix: WTF-8 decoding issue in node:fs
2024-03-24 20:39:37 +01:00
Piotr Płaczek
90a7e5acae
fix: normalize path before calling showItemInFolder and openPath ( #41642 )
...
* fix: normalize path before calling ShowItemInFolder
* fix: normalize path before calling OpenPath
2024-03-22 10:28:44 -04:00
Shelley Vohr
707b9a58cc
fix: app.setLoginItemSettings error getting swallowed by gin conversion ( #41647 )
...
* fix: errors getting swallowed by gin conversion
* fix: Windows build
* test: re-enable disabled test
2024-03-22 09:00:21 -04:00
Shelley Vohr
a32705fd30
test: add test for setJumpList arguments ( #41650 )
...
test: add test for setJumpList arguments
2024-03-21 19:01:54 -04:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41577 )
2024-03-21 14:59:23 -07:00
John Kleinschmidt
1036d824fe
ci: use CircleCI hosted macOS arm64 runners for testing ( #41649 )
2024-03-21 14:07:18 -04:00
Kenneth Gerald Hamilton
587b66acc1
docs: nodejs trademark policy link broken ( #41558 )
...
* Fix broken Trademark Policy link
* add durable link
Per codebyter: https://github.com/electron/electron/pull/41558#discussion_r1522938560
2024-03-21 10:25:35 -04:00
Shelley Vohr
040acaaf30
fix: support withFileTypes in fs.{readdir|readdirSync} ( #41627 )
...
fix: support withFileTypes in fs.{readdir|readdirSync}
2024-03-21 10:22:40 -04:00
David Sanders
dd3fd78e63
ci: automatically add the 'has-repro-gist' label ( #41646 )
...
ci: automatically add the 'has-gist-repro' label
2024-03-21 10:22:14 -04:00
Charles Kerr
61ddb1aa07
chore: bump pylint to 2.17 ( #41576 )
...
* build: bump pylint to 2.17
Xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345
* fix pylint consider-using-f-string warnings pt 1: use flynt for automated fixes
* fix pylint consider-using-f-string warnings pt 2: manual fixes
* fix pylint consider-using-with warnings
* fix pylint line-too-long warnings
* fix pylint unspecified-encoding warnings
* fix py lint consider-using-generator warning
* fixup! fix pylint unspecified-encoding warnings
* fix pylint line-too-long warnings
2024-03-21 09:48:23 -04:00
David Sanders
00da7279cb
ci: set issue status to triaged on status/{confirmed,reviewed} label ( #41645 )
2024-03-21 09:43:40 -04:00
electron-appveyor-updater[bot]
7609156ae1
build: update appveyor image to latest version ( #41617 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-20 11:50:10 -04:00
Shelley Vohr
66dec24e32
fix: serial-port-added should respect filters ( #41621 )
...
fix: serial-port-added should respect filters
2024-03-20 10:18:41 -04:00
Shelley Vohr
433d6c33d8
fix: missing badge text on Windows ( #41618 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5053607
2024-03-19 12:50:30 +01:00
Shelley Vohr
b02918883f
fix: support recursive readdir in Asar files ( #41582 )
2024-03-19 11:10:14 +01:00
Shelley Vohr
1cd7419718
build: work around ScreenCaptureKit bad feature flag parsing in Chromium ( #41622 )
2024-03-19 10:49:41 +01:00
Shelley Vohr
daecbb90fe
test: modify remote specs to allow skip or only ( #41620 )
2024-03-19 10:49:24 +01:00
electron-roller[bot]
193e162ec6
chore: bump chromium to 124.0.6359.0 (main) ( #41584 )
...
* chore: bump chromium in DEPS to 124.0.6355.0
* 5341411: view-transition: Ensure resources are cleaned up in all cases.
https://chromium-review.googlesource.com/c/chromium/src/+/5341411
* chore: fixup patch indices
* 5354013: Return nullopt on error from ProcessMetrics CPU measurements
https://chromium-review.googlesource.com/c/chromium/src/+/5354013
* chore: bump chromium in DEPS to 124.0.6357.0
* chore: update patches
* 5368769: Reland "[mojo] Use large worker for mojom_parser action"
https://chromium-review.googlesource.com/c/chromium/src/+/5368769
* 5336171: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5336171
* 5367334: [FS Shortcut] Refactor ExclusiveAccessManager
https://chromium-review.googlesource.com/c/chromium/src/+/5367334
* 5354161: Rename GeolocationManager to GeolocationSystemPermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5354161
* fixup: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
* chore: bump chromium in DEPS to 124.0.6359.0
* chore: update patches
* 5371370: [Extensions] Move core NativeHandler registration
https://chromium-review.googlesource.com/c/chromium/src/+/5371370
* 5370702: [Extensions] Introduce ShellExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5370702
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-15 14:03:42 -04:00
Fedor Indutny
3759e59bbd
fix: asan build on macos ( #41587 )
2024-03-15 13:06:43 +09:00
electron-appveyor-updater[bot]
41b2102d10
build: update appveyor image to latest version ( #41591 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-14 13:03:13 -04:00
Shelley Vohr
1bfd3e0631
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain ( #41538 )
...
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-14 09:50:52 +01:00
electron-appveyor-updater[bot]
122a2fd177
build: update appveyor image to latest version ( #41579 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-13 13:15:29 -04:00
Shelley Vohr
1840d7b7ee
fix: improve caption button appearance on Windows 11 ( #41561 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4428171
2024-03-13 10:58:48 -04:00
Shelley Vohr
6cb84ddbfb
test: disable transparency tests on macOS arm64 ( #41580 )
2024-03-13 15:05:10 +01:00
David Sanders
02020fbb63
build: update @electron/lint-roller to 1.11.1 ( #41522 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-13 11:14:10 +01:00
electron-roller[bot]
26752d3a06
chore: bump chromium to 124.0.6353.0 (main) ( #41566 )
...
* chore: bump chromium in DEPS to 124.0.6353.0
* chore: update patches
* 5365462: Add missing perfetto::Flow and TRACE_EVENT includes
https://chromium-review.googlesource.com/c/chromium/src/+/5365462
* 5356336: Ensure destruction of mojo channel when destructing KeySystemsImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5356336
* 5332839: [Extensions] Register NativeHandlers with the RendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5332839
* 5148827: Add permission types for keyboard lock and pointer lock [1/N]
https://chromium-review.googlesource.com/c/chromium/src/+/5148827
* 5358818: Revert "[object] Fast path for adding props with existing transition"
https://chromium-review.googlesource.com/c/v8/v8/+/5358818
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-13 09:44:49 +01:00
Shelley Vohr
80f34ecd2c
test: re-enable app.getGPUInfo() specs on Linux ( #41568 )
...
test: re-enable getGPUInfo() specs on Linux
2024-03-12 12:39:29 -04:00
Erick Zhao
2f133f5e28
docs: nativeImage api cleanup ( #41519 )
...
* docs: `nativeImage` api cleanup
* Update docs/api/native-image.md
* Update native-image.md
* Update docs/api/native-image.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Update link to app icon
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
2024-03-12 12:33:56 -04:00
electron-roller[bot]
150c2bcef9
chore: bump chromium to 124.0.6351.0 (main) ( #41514 )
...
* chore: bump chromium in DEPS to 124.0.6339.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6341.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6343.0
* chore: bump chromium in DEPS to 124.0.6345.0
* chore: update patches
* build: temporarily patch out usage of reclient inputs cfg
* chore: implement missing OnPortConnectedStateChanged
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5039155
* fix: move NativeHandlers in extensions to new RendererAPIProvider
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5332839
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5334058
* chore: add missing websocket method
* refactor: use std::erase instead of base::Erase
Ref: https://issues.chromium.org/issues/40256229
* build: fix reclient inputs processor bug (workaround)
* fix: delay extensions::Dispatcher construction
* chore: bump chromium in DEPS to 124.0.6347.0
* chore: bump chromium in DEPS to 124.0.6349.0
* 5326217: [ViewsAX] Remove WebAXPlatformTreeManagerDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5326217
* 5347916: Get origin from parent for process-isolated srcdoc.
https://chromium-review.googlesource.com/c/chromium/src/+/5347916
* chore: patches fixup
* 4866222: [api] Deprecate vector<v8::Local>, part 1
https://chromium-review.googlesource.com/c/v8/v8/+/4866222
* 5337304: Remove DXDiag telemetry code.
https://chromium-review.googlesource.com/c/chromium/src/+/5337304
* 5328275: Implement watermark routing to the BrowserView
https://chromium-review.googlesource.com/c/chromium/src/+/5328275
* [libc++] Rename __fwd/hash.h to __fwd/functional.h and add reference_wrapper
* chore: bump chromium in DEPS to 124.0.6351.0
* chore: update patches
* 5342763: [object] Fast path for adding props with existing transition
https://chromium-review.googlesource.com/c/v8/v8/+/5342763
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-12 10:15:41 +01:00
Shelley Vohr
1252f92431
chore: remove 8088 from codespaces port forwarding ( #41557 )
2024-03-10 18:18:56 +01:00
electron-appveyor-updater[bot]
c0f9d0eeed
build: update appveyor image to latest version ( #41523 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-08 14:32:08 -05:00
Felix Rieseberg
4ec4efd3e5
docs: Update code signing documentation ( #41535 )
2024-03-08 10:02:39 -08:00
John Kleinschmidt
fb1b5ca4ce
test: disable CapturableScreen tests on Windows x64 ( #41543 )
...
* test: disable CapturableScreen tests on Windows x64
* test: disable js-execute-iframe" case should not crash on win 32-bit
2024-03-07 19:17:39 -05:00
Shelley Vohr
f826506218
fix: chrome://process-internals failing to load ( #41476 )
...
fix: chrome://process-internals failing to load
2024-03-07 15:31:16 +01:00
Shelley Vohr
62331f5ac1
chore: add missing gin::Wrappable GetTypeName overrides ( #41512 )
...
chore: add missing gin::Wrappable GetTypeName overrides
2024-03-06 12:45:28 +01:00
Shelley Vohr
a7d664e3a3
fix: user-did-{resign|become}-active events on macOS ( #41506 )
...
fix: user-did-{resign|become}-active events on macOS
2024-03-06 12:43:39 +01:00
Shelley Vohr
62a897b75b
chore: fix fs overrides for asar ( #41507 )
...
fix: fs overrides for asar
2024-03-06 10:39:30 +01:00
Shelley Vohr
cc7e80c4e3
docs: correct release timeline inaccuracy ( #41510 )
...
docs: correct timeline inaccuracy
2024-03-05 10:49:21 -08:00
electron-roller[bot]
9f673c859d
chore: bump chromium to 124.0.6331.0 (main) ( #41474 )
...
* chore: bump chromium in DEPS to 124.0.6329.0
* chore: update patches
* 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5321532: [//ui] Remove ContextFactory::SharedMainThreadContextProvider() | https://chromium-review.googlesource.com/c/chromium/src/+/5321532
* fixup! 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5319141: [OOPIF PDF] Create PdfNavigationThrottle for main frame navigations | https://chromium-review.googlesource.com/c/chromium/src/+/5319141
* test: disable webview.capturePage test for mac arm64
* chore: bump chromium in DEPS to 124.0.6337.0
* chore: update patches
* build: roll back DEPS to 124.0.6331.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-03-05 11:47:48 -05:00
Jeremy Rose
e67ab9a93d
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #41326 )
2024-03-04 09:32:40 -08:00
Cheng Zhao
814ba71dc1
chore: update src_preload_function_for_environment.patch ( #41500 )
2024-03-04 13:11:14 +01:00
David Sanders
cc9e21c260
build: update appveyor image to latest version ( #41483 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-01 15:54:10 -05:00
David Sanders
9565b7de74
chore: set wg-releases as CODEOWNER for AppVeyor configs ( #41485 )
2024-03-01 15:53:30 -05:00
Shelley Vohr
d5912fd05a
fix: webContents.print options should be optional ( #41467 )
2024-02-29 10:19:44 -05:00
Krzysztof Halwa
a0dad83ded
feat: Allow creation of new window to be customizable. ( #41432 )
2024-02-29 10:15:01 -05:00
electron-roller[bot]
04df5ce492
chore: bump chromium to 124.0.6323.0 (main) ( #41412 )
...
* chore: bump chromium in DEPS to 124.0.6315.0
* chore: update patches
* 5279678: Stream AIDA responses
https://chromium-review.googlesource.com/c/chromium/src/+/5279678
* 5276439: Remove non_network_url_loader_factory_remotes_
https://chromium-review.googlesource.com/c/chromium/src/+/5276439
* 5310165: Add DevTools API to show search results
https://chromium-review.googlesource.com/c/chromium/src/+/5310165
* chore: bump chromium in DEPS to 124.0.6317.0
* chore: update patches
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
https://chromium-review.googlesource.com/c/chromium/src/+/5314269
* browser: Make cmd line non-const in process singleton callback
https://chromium-review.googlesource.com/c/chromium/src/+/5311256
* chore: bump chromium in DEPS to 124.0.6319.0
* chore: bump chromium in DEPS to 124.0.6321.0
* chore: bump chromium in DEPS to 124.0.6323.0
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
https://chromium-review.googlesource.com/c/chromium/src/+/5318335
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
https://chromium-review.googlesource.com/c/chromium/src/+/5318051
* chore: fixup patch indices
* 4946553: Delegate HID permission to Chrome App in webview
https://chromium-review.googlesource.com/c/chromium/src/+/4946553
* 5310001: DevTools UI binding for reporting client events to AIDA
https://chromium-review.googlesource.com/c/chromium/src/+/5310001
* [libc++] Refactor the predicate taking variant of `__cxx_atomic_wait`
* chore: fix browser_view patch harder
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
https://chromium-review.googlesource.com/c/chromium/src/+/5293937
* fix: filter {video|audio} devices by eligible device id
* 5267921: enable speak content under the pointer on PWA and WV2
https://chromium-review.googlesource.com/c/chromium/src/+/5267921
* 5310195: heap: Remove Blink's GCTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/5310195
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-29 10:31:13 +01:00
David Sanders
13e601e35c
ci: verified commits for appveyor update PR ( #41470 )
2024-02-28 21:36:56 -08:00
Calvin
a6133e85d1
test: disable flaky macOS panel test & refactor screen capture testing ( #41441 )
...
* Disable flaky test
* Add helper for storing test artifacts
* Refactor screen capture tests
We have a pattern for inspecting a screen capture, so this refactor codifies that pattern into a helper. This gives us shorter test code, consistency (previously, the display in test code and the display captured could theoretically be different), and better debugging/observability on failure.
2024-02-28 12:54:20 +09:00
John Kleinschmidt
267c0796dd
ci: add logging to uploading to GitHub releases ( #41453 )
2024-02-27 19:55:08 -05:00
Shelley Vohr
b468b5e6e8
build: print error and retry on symstore fail ( #41452 )
2024-02-27 15:40:42 -08:00
Shelley Vohr
d89ad1106f
chore: add engflow-reclient-configs to gitignore ( #41447 )
2024-02-27 15:39:41 -08:00
Milan Burda
3885011220
chore: remove deprecated inputFieldType ( #41239 )
...
chore: remove deprecated inputFieldType
2024-02-26 07:47:16 -05:00
Milan Burda
3394ee71f0
chore: fix import from patches.py in script/lib/git.py ( #41430 )
2024-02-26 11:36:30 +09:00
Calvin
12d7a8ff66
feat: Session#clearData API ( #40983 )
...
* WIP: Session.clearBrowsingData API
* impl API method
* clean up
* tidy types and comments
* add docs
* add barebones test
* forgot a `#` :(
* tidy: address review comments
* use format macro for cross-platform build
* add another test
* amend docs to disambiguate
* Rename to `clearData`
2024-02-26 09:39:17 +09:00
Shelley Vohr
e95673b052
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} ( #41400 )
...
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
2024-02-23 10:35:20 +01:00
Robo
26131b23b8
feat: add support for configuring system network context proxies ( #41335 )
...
* feat: add support for configuring system network context proxies
* chore: add specs
* chore: fix lint
* fix: address review feedback
2024-02-22 12:08:25 -05:00
Shelley Vohr
136762b45f
build: don't modify deps/v8/tools paths ( #41386 )
...
build: don't modify deps/v8/tools paths
2024-02-22 11:35:06 -05:00
github-actions[bot]
d73a937375
build: update appveyor image to latest version-e-123.0.6312.5 ( #41408 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-22 11:10:52 -05:00
Samuel Attard
ddd93529d5
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher ( #41397 )
...
This fixes a nasty warning / permission dialog that pops up to end-users
when consuming legacy APIs. Chrome has flipped these flags via field trials
as have other Electron apps. It should just be the default.
2024-02-21 12:59:49 -08:00
electron-roller[bot]
e72f4f7f26
chore: bump chromium to 123.0.6312.5 (main) ( #41337 )
...
* chore: bump chromium in DEPS to 123.0.6300.2
* chore: bump chromium in DEPS to 123.0.6301.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6302.0
* chore: bump chromium in DEPS to 123.0.6304.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6306.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6308.0
* chore: update patches
* Refactor //components/pdf/common constants
https://chromium-review.googlesource.com/c/chromium/src/+/5292816
* Rename URLLoaderFactoryParams::is_corb_enabled to is_orb_enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5277040
* Add placeholder of speaker-selection permission.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5278243
* Move kPdfMimeType to //components/pdf/common/constants.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293155
* chore: gen-libc++-filenames.js
* Make GetClassName non virtual
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293075
Refs https://issues.chromium.org/issues/324596267
* chore: bump chromium in DEPS to 123.0.6310.0
* chore: update filenames.libcxx.gni
* 5282732: Compute input region using correct pixel size.
https://chromium-review.googlesource.com/c/chromium/src/+/5282732
* fixup: Make GetClassName non virtual
* chore: bump chromium in DEPS to 123.0.6312.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6312.5
* fixup: Make GetClassName non virtual
* docs: document speaker-selection
https://chromium-review.googlesource.com/c/chromium/src/+/5278243
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-02-21 15:27:05 -05:00
Keeley Hammond
f350cce64f
docs: update breaking changes language ( #41387 )
2024-02-21 11:25:53 -08:00
Keeley Hammond
94e643ab33
build: bump NMV to 123 for Electron 30 ( #41370 )
2024-02-21 10:02:36 -08:00
electron-roller[bot]
e87746ff0f
chore: bump node to v20.11.1 (main) ( #41353 )
...
* chore: bump node in DEPS to v20.11.1
* chore: update patches
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-21 12:49:20 -05:00
Keeley Hammond
136d7e7e6a
fix: check for draggable regions outside of main frame ( #41377 )
2024-02-20 19:10:43 -08:00
Charles Kerr
7cd23a4900
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient() ( #41347 )
...
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient()
- (perf) GetBlinkPreferences() returns a const&, so we can use that
reference instead of making a temporary copy
- (perf) Don't create url object unless it's needed.
- (refactor) Move is_main_world() and is_isolated_world() from the
header into an anonymous namespace in the .cc file so they can
be inlined and made constexpr
2024-02-20 13:29:11 +01:00
Keeley Hammond
995f3dc120
fix: revert to legacyMainResolve in JavaScript for asar compatibility ( #41367 )
2024-02-18 23:21:13 -08:00
Keeley Hammond
d0b4489b7d
ci: fix helperPath calls in ci configs ( #41363 )
...
* ci: fix helperPath calls in ci configs
Co-authored-by: codebytere <codebytere@electronjs.org >
* ci: fix helperPaths harder
---------
Co-authored-by: codebytere <codebytere@electronjs.org >
2024-02-17 15:04:36 -08:00
Michaela Laurencin
ca0920872d
chore: update breaking-changes.md to reflect WebContentsView revert ( #41361 )
2024-02-17 09:20:53 -08:00
Henrik Gaßmann
80906c0adb
fix: properly stream uploadData in protocol.handle() ( #41052 )
...
* refactor(protocol): extract file stream factory
Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
* fix: properly flatten streams in `protocol.handle()`
Refs: electron/electron#39658
* fix: `protocol.handle()` filter null origin header
Refs: electron/electron#40754
* fix: remove obsolete TODO comment
Refs: electron/electron#38929
* fix: forward `Blob` parts in `protocol.handle()`
Refs: electron/electron#40826
* fix: explicitly error out on unknown chunk parts
2024-02-16 14:29:29 -05:00
Shelley Vohr
d4413a8e53
chore: remove unused anonymous namespace methods ( #41333 )
2024-02-16 10:31:34 -06:00
Calvin
0356812026
docs: update release schedule for E30 ( #41339 )
2024-02-15 12:38:07 -08:00
github-actions[bot]
6acacf061c
build: update appveyor image to latest version - e-123.0.6296.0. ( #41350 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-15 14:56:41 -05:00
Samuel Attard
7d6a754d47
fix: skip the first two invalid updates when SCK is enabled ( #41340 )
2024-02-14 11:56:29 -08:00
electron-roller[bot]
0dad99561b
chore: bump chromium to 123.0.6296.0 (main) ( #41204 )
...
* chore: bump chromium in DEPS to 123.0.6273.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6274.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6276.0
* chore: update patches
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* chore: bump chromium in DEPS to 123.0.6278.0
* chore: bump chromium in DEPS to 123.0.6280.0
* chore: update patches
* chore: use net::CanonicalCookie::SecureAttribute()
renamed from IsSecure()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
* refactor: handle multiple requested device ids
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5132210
* refactor: trigger View layouts async with View::InvalidateLayout()
Upstream has introduced a PassKey to restrict who can call Layout()
directly. I've opted for calling `InvalidateLayout()` which is the
approach that upstream recommends.
If for some reason this approach doesn't work for us, we could use
`DeprecatedLayoutImmediately()` as a stopgap.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Xref: https://chromium.googlesource.com/chromium/src/+/main/ui/views/view.h#809
Xref: https://chromium.googlesource.com/chromium/src/+/main/docs/ui/learn/bestpractices/layout.md?pli=1#don_t-invoke-layout_directly
* chore: bump chromium in DEPS to 123.0.6282.0
* chore: bump chromium in DEPS to 123.0.6284.0
* chore: update patches
* refactor: remove use of blink::MainThreadIsolate() pt 1/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 2/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 3/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* chore: update enum name to ui::AXMode::kPDFPrinting
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5270301
* chore: rebuild filenames.libcxx.gni
* chore: sync with upstream rename of PortProvider.TaskForHandle()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5259103
* chore: bump chromium in DEPS to 123.0.6286.0
* chore: bump chromium in DEPS to 123.0.6288.0
* WebPreferences: Initialize in declaration.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5277099
* chore: update webview_fullscreen.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5053508
Simple update to fix patch shear
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5254861
Simple update to fix patch shear
* chore: add IWC::Delegate::RecordResize() stub to fix FTBFS
https://chromium-review.googlesource.com/c/chromium/src/+/5268963
* chore: add FormControlType::kButtonPopover to the FormControlType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
* chore: e patches all
* chore: node script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 123.0.6290.0
* chore: bump chromium in DEPS to 123.0.6291.0
* chore: bump chromium in DEPS to 123.0.6292.0
* chore: bump chromium in DEPS to 123.0.6294.0
* chore: update fix_aspect_ratio_with_max_size.patch
Xref: fix_aspect_ratio_with_max_size.patch
note: simple absl::optional -> std::optional conversion
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5272337
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; just adjusting line patch offsets
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5258688
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5281322
* chore: update fix_select_The_first_menu_item_when_opened_via_keyboard.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5279376
note: simple absl::optional -> std::optional conversion
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5268792
* chore: script/export_all_patches.py
* chore: bump chromium in DEPS to 123.0.6296.0
* chore: update patches
* fixup! chore: update feat_allow_code_cache_in_custom_schemes.patch
* fix: restore MessagePort close event
* spec: fix CORB testing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5231506
* fix: use sync layout when content view changes
* fixup! chore: update feat_configure_launch_options_for_service_process.patch
* Add remote-cocoa support for context menus.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5259806
* Rename //net/base/mac directory to //net/base/apple (1/n)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5211389
* fixup! Add remote-cocoa support for context menus.
* [Clipboard] Don't add meta charset tag for async write() method on Mac.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5187335
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-02-14 12:33:32 -05:00
David Sanders
7e241eef7c
ci: update GitHub actions workflow dependencies ( #41321 )
2024-02-14 11:13:03 +01:00
Mikhail Leliakin
79147e4dd8
fix: Ignore -webkit-app-region: drag; when window is in full screen mode. ( #41307 )
...
Co-authored-by: Mikhail Leliakin <lelyakin.aus@gmail.com >
2024-02-14 11:12:41 +01:00
Samuel Attard
32920af4b7
fix: add capability to use ScreenCaptureKit for thumbnail generation ( #41328 )
...
This aligns us with Chromiums flags / capabilities in regards to using SCK for
everything. Currently on 14.4 Electron apps will pop warnings for usage of
deprecated APIs. With this change and a few "enable-features" toggles.
`--enable-features="ScreenCaptureKitMac,ScreenCaptureKitStreamPickerSonoma,ThumbnailCapturerMac:capture_mode/sc_screenshot_manager"`
As Chromium enables these by default Electron will inherit those changes, apps wishing to skip ahead can apply these flags early.
2024-02-13 20:46:51 -08:00
Shelley Vohr
0218af9af0
fix: work around unarchivedObjectOfClass requiring secureCoding ( #41319 )
2024-02-13 19:08:03 -08:00
Charles Kerr
6a616ab70c
feat: allow custom refs for patch import & export ( #41306 )
...
* feat: allow custom refs for patch import & export
feat: add Patch-Dir metainfo, a sibling to Patch-Filename
* chore: copyediting
* refactor: minor copyediting
2024-02-12 10:05:53 -06:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54 .
2024-02-12 09:35:34 +01:00
Shelley Vohr
4ded4d16a8
fix: destroy NodeService message pipe last ( #41277 )
...
refactor: destroy NodeService message pipe last
2024-02-09 22:44:35 +01:00
Shelley Vohr
c894645ac6
fix: crash on macOS non-programmatic close ( #41264 )
2024-02-09 22:44:24 +01:00
Charles Kerr
9655ae7d6a
fix: GetCursorScreenpoint() sometimes wrongly returns (0,0) ( #41275 )
2024-02-09 09:44:46 -06:00
Charles Kerr
cee51785e1
refactor: inline simple getters, pt . 2 ( #41254 )
...
* refactor: inline AutofillPopup::line_count()
refactor: inline AutofillPopup::value_at()
refactor: inline AutofillPopup::label_at()
* refactor: inline NativeWindow::aspect_ratio()
refactor: inline NativeWindow::aspect_ratio_extra_size()
* refactor: inline BrowserProcessImpl::linux_storage_backend()
* refactor: inline ElectronMenuModel::sharing_item()
* refactor: inline Browser::badge_count()
* refactor: inline WebContents::is_guest()
refactor: inline InspectableWebContents::is_guest()
* refactor: inline InspectableWebContents::dev_tool_bounds()
* refactor: inline WebContents::type()
2024-02-09 10:29:14 +01:00
Charles Kerr
b253d52faf
build: export matching patches ( #41174 )
...
* build: make patches/config.json an array of objects
This file was previously an object of patch_dir keys to repo values;
Now is an array of objects containing `patch_dir` and `repo` properties.
This makes other per-target properties (e.g. `grep`) possible.
* build: include Note metadata when exporting patches
* build: support keyword filtering in export_patches()
* build: add optional `--grep` arg to git-export-patches script
* build: update export_all_patches to understand new config file
* fixup! build: update export_all_patches to understand new config file
chore: make lint happy
* fixup! build: make patches/config.json an array of objects
chore: fix oops
* refactor: remove support for the old file format
There is more code using config.json than I thought, so the
effort-to-reward of supporting the old format is not worth it.
* build: update apply_all_patches to understand new config file
* build: update lint.js to understand new config file
* build: update patches-mtime-cache.py to understand new config file
* fixup! build: update apply_all_patches to understand new config file
fix: oops
* fixup! build: update apply_all_patches to understand new config file
fix minor syntax wart
* fixup! build: support keyword filtering in export_patches()
refactor: use idiomatic python
* refactor: warn if config.json has an invalid repo
2024-02-08 13:47:59 -05:00
github-actions[bot]
4d060afc98
build: update appveyor image to latest version ( #41206 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-08 15:01:05 +01:00
Shelley Vohr
8eb580e79a
docs: note EXIF data unsupported in nativeImage ( #41261 )
...
* docs: note EXIF data unsupported in nativeImage
* Update docs/api/native-image.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 14:59:46 +01:00
Bogdan Cerovac
42087e306c
fix: add language to html in quick-start.md ( #41225 )
...
Add language to html in quick-start.md
We must define language in HTML for different reasons (accessibility++)
2024-02-08 10:27:50 +09:00
Milan Burda
2ea569e0d2
docs: fix docs/api/base-window.md ( #41240 )
...
* docs: fix docs/api/base-window.md
* Update docs/api/base-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 10:13:48 +09:00
Felix Rieseberg
4367c5ad9e
docs: Properly document runAsNode utility process option ( #41255 )
...
* docs: Properly document runAsNode utility process option
* Update docs/api/utility-process.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-02-06 15:54:36 -08:00
Cheng Zhao
92c5ff30a7
build: add flag for setting vendor version ( #41247 )
2024-02-06 14:23:17 -08:00
Charles Kerr
5686f88bd2
refactor: KeyWeakMap cleanup ( #41242 )
...
* refactor: make KeyWeakMap::KeyObject private
* perf: avoid redundant map lookup
* refactor: remove unused KeyWeakMap::Has()
* refactor: make KeyWeakMap dtor nonvirtual
no inheritance used, so no need for virtual dtor?
* chore: fix KeyWeakMap code comment
* refactor: use if statement in KeyWeakMap::Get()
* refactor: use better variable names in KeyWeakMap::Values()
2024-02-06 09:18:05 -06:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded() ( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Charles Kerr
08236f7a9e
refactor: remove deprecated BrowserContext::ResourceContext ( #41221 )
...
* refactor: remove ResourceContext* arg from GetNSSCertDatabaseForResourceContext()
* refactor: remove ResourceContext* arg from CertificateManagerModel::GetCertDBOnIOThread()
* refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
* refactor: remove unused forward declarations
* refactor: rename method to GetNSSCertDatabase()
* fixup! refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
chore: remove unneeded line
2024-02-05 18:12:34 -06:00
Shelley Vohr
5dfa9e3317
fix: original-fs import replacement ( #41209 )
...
fix: original-fs import replacement
2024-02-05 09:51:04 +01:00
wujinli
fb888a6989
fix: crash problem with message_port close event ( #41201 )
...
When worker_thread shutdown, it will destory context and close
message_port. In this case, it should not dispatch close event.
Because it forbid script running during NotifyContextDestroyed in
ContextLifecycleNotifier.
Now chromium has implemented close_event and will not crash,
so we remove the patch with #22532 and add one test.
2024-02-05 16:38:30 +09:00
marekharanczyk
398ca2a019
fix: make sure invalid URL loads promises are fulfilled. ( #41194 )
...
* fix: make sure invalid URL loads promisses are fulfilled.
* fixup! fix: make sure invalid URL loads promisses are fulfilled.
2024-02-05 16:36:51 +09:00
Milan Burda
dac29f9949
refactor: type-safe module imports / requires ( #41192 )
2024-02-05 16:36:28 +09:00
Kilian Valkhof
3ec04fd449
docs: add note about fuses to our security documentation ( #41210 )
...
* Add note about fuses to our security documentation
Additionally, add the missing #18 to the ToC.
* lint issues for security.md
* Update docs/tutorial/security.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* move reference links to bottom of security.md
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-02-02 17:28:36 -06:00
Charles Kerr
2ebaebb603
refactor: replace use of deprecated base::JSONWriter::WriteJson() ( #41215 )
...
* refactor: use base::WriteJson() in ListValueToNSArray()
refactor: use base::WriteJson() in DictionaryValueToNSDictionary()
* refactor: use base::WriteJson() in Debugger::SendCommand()
* refactor: use base::WriteJson() in ScriptingExecuteScriptFunction::Run()
* refactor: use base::WriteJson() in HandleAccessibilityRequestCallback()
2024-02-02 12:25:58 -06:00
Sam Maddock
9bfa16ad7f
fix: typescript error for optional dependency ( #41202 )
2024-02-01 13:00:20 +09:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c )
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-01-31 17:04:13 -06:00
Sam Maddock
12870cafb7
fix: move nut-js to optional spec deps ( #41199 )
2024-02-01 07:35:09 +13:00
Shelley Vohr
e4d5dc138f
fix: select-usb-device should respect filters option ( #41166 )
...
fix: select-usb-device should respect filters option
2024-01-31 09:53:30 -05:00
Shelley Vohr
6df3443617
fix: validate printToPDF margins against pageSize ( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Sam Maddock
85bebfb180
test: draggable region allows moving window ( #41127 )
...
* chore: add nut.js
* test: dragging window updates position
* instantly move mouse position
* limit platforms to run drag tests on
* defer loading nut-js
2024-01-31 10:29:17 +01:00
Milan Burda
fb88375ab4
refactor: type-safe imports in lib/node/init.ts ( #41148 )
2024-01-31 08:38:56 +09:00
Charles Kerr
0e0a0bf724
fix: avoid potential CHECK() failure in DictionaryToRect() ( #41160 )
...
refactor: use gfx::Rect::Contains() instead of reinventing the wheel
perf: use base::Value::FindInt() to avoid redundant map lookups
2024-01-30 14:48:47 -06:00
Charles Kerr
08615b2d4e
refactor: simplify code by using base::Value::EnsureList() ( #41162 )
2024-01-30 14:48:09 -06:00
Shelley Vohr
90c7d6c823
fix: shouldPrintBackgrounds -> printBackground in webContents.printToPDF ( #41161 )
...
fix: shouldPrintBackgrounds -> printBackground
2024-01-30 14:47:55 -06:00
Shelley Vohr
6786fde576
docs: document printToPDF generateDocumentOutline option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Shelley Vohr
fc917985ae
fix: ensure WebContents before checking draggable region ( #41154 )
...
fix: ensure WebContents before checking draggable region
2024-01-30 11:53:19 +01:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
github-actions[bot]
4e19321ba8
build: update appveyor image to latest version ( #41134 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-29 14:12:59 -05:00
David Sanders
679a6589cd
chore: add extra links to issue template chooser ( #41135 )
2024-01-29 09:51:43 -05:00
Cheng Zhao
de76fc01ec
chore: fix outdated osk patch on main branch ( #41152 )
2024-01-29 15:35:33 +09:00
Cheng Zhao
2571396584
fix: update osk patch to fix more corner cases ( #41131 )
...
This is a follow up to https://github.com/electron/electron/pull/35921
that, it fixes more corner cases that on-screen-keyboard does not hide
for webviews.
This change has been applied in Teams for quite a while and should be
reliable enough to introduce to Electron.
2024-01-29 10:42:59 +09:00
Shelley Vohr
8104c7908a
fix: potential async_hooks crash in NotifyWindowRestore on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Cheng Zhao
db2bf1a0d1
fix: apply module search paths restriction on worker and child process ( #41118 )
2024-01-26 17:29:04 +09:00
electron-roller[bot]
6c9f9de40a
chore: bump chromium to 123.0.6264.0 (main) ( #41124 )
...
* chore: bump chromium in DEPS to 123.0.6264.0
* chore: update patches
* 5224145: Revert "Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'""
https://chromium-review.googlesource.com/c/chromium/src/+/5224145
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 18:57:47 -05:00
John Kleinschmidt
9e630eb66a
build: remove unneeded dlls in Windows zip ( #41120 )
...
* build: fixup zip manifest check on Windows
* build: remove unused dlls
2024-01-25 15:26:21 -05:00
electron-roller[bot]
1a0991a9b9
chore: bump chromium to 122.0.6261.6 (main) ( #40949 )
...
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* 5105227: [media_preview] Show requested device in permission bubble
https://chromium-review.googlesource.com/c/chromium/src/+/5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | https://chromium-review.googlesource.com/c/chromium/src/+/5190661
* 5206106: Make sure RenderFrameHosts are active when printing | https://chromium-review.googlesource.com/c/chromium/src/+/5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
https://chromium-review.googlesource.com/c/chromium/src/+/5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
https://chromium-review.googlesource.com/c/chromium/src/+/5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
https://chromium-review.googlesource.com/c/chromium/src/+/5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
https://chromium-review.googlesource.com/c/chromium/src/+/5171446
* 5213708: Move DownloadTargetInfo into components/download
https://chromium-review.googlesource.com/c/chromium/src/+/5213708
* extensions: Add a loader for Controlled Frame embedder scripts
https://chromium-review.googlesource.com/c/chromium/src/+/5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
https://chromium-review.googlesource.com/c/chromium/src/+/5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
https://chromium-review.googlesource.com/c/chromium/src/+/5170669
* 5178824: [Fullscreen] Record UKM data
https://chromium-review.googlesource.com/c/chromium/src/+/5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 12:46:30 -05:00
Charles Kerr
921da723b8
fix: dangling raw_ptr in OSRWHV destructor ( #41088 )
...
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`.
Since `delegated_frame_host_client_` was being destroyed first, that
pointer was dangling in the OSRWHV destructor.
Also, make these two unique_ptr fields `const` since they point to the
same objects for the lifespan of the OSRWHV.
2024-01-25 10:15:32 +09:00
Shelley Vohr
3e6a038af7
fix: draggable regions not working ( #41030 )
...
* fix: draggable regions not working
* fix: only support app regions for main frame
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-01-25 09:12:54 +09:00
Maikel Ortega Hernández
a05bfd332d
fix: on error, reset spawnedProcess ( #41033 )
...
reset spawnedProcess instance in case of error
2024-01-24 16:45:08 -06:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Cheng Zhao
d13a93fb61
chore: remove node patches by using the preload feature ( #41080 )
2024-01-24 09:54:32 -06:00
Cheng Zhao
031d636823
fix: only remove hijackable envs from foreign parent ( #41079 )
2024-01-24 09:51:27 -06:00
Max Schmitt
5ced88a90a
docs: update Playwright automated-testing guide ( #41081 )
2024-01-24 09:50:55 -06:00
Charles Kerr
1af9612edf
fix: ElectronBrowserContext::PartitionKey comparisons ( #41055 )
...
* fix: ElectronBrowserContext::PartitionKey comparisons
Use c++20 default comparisons to simplify + fix PartitionKey sorting:
- The equality operator is broken. `PartitionKey{"foo", false}` is both
equal, to and less than, `PartitionKey{"foo", true}`
- For some keys, the same session can be retrieved via both `fromPath()`
and `fromPartition()`. This use case was discussed and removed from
the original PR after code review said "always returning different
sessions feels lower maintenance." The current behavior is a bug that
comes from the comparison operators not checking the keys' types.
Xref: 3f1aea9af9 (r1099745359)
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed
* fixup! fix: ElectronBrowserContext::PartitionKey comparisons
2024-01-23 09:41:44 -06:00
Valerius Petrini
1300e83884
docs: fixed typos and grammatical errors ( #40966 )
...
* docs: fixed typos
* Update docs/tutorial/performance.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* Update performance.md
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-01-19 08:21:42 -06:00
Michaela Laurencin
03a3deca18
ci: add stale-exempt label to exempt issues from automation ( #41031 )
2024-01-18 16:57:49 -05:00
electron-roller[bot]
f4ee3c1b2a
chore: bump node to v20.11.0 (main) ( #40941 )
...
* chore: bump node in DEPS to v20.11.0
* module: bootstrap module loaders in shadow realm
https://github.com/nodejs/node/pull/48655
* src: add commit hash shorthand in zlib version
https://github.com/nodejs/node/pull/50158
* v8,tools: expose necessary V8 defines
https://github.com/nodejs/node/pull/50820
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* esm: fallback to readFileSync when source is nullish
https://github.com/nodejs/node/pull/50825
* vm: allow dynamic import with a referrer realm
https://github.com/nodejs/node/pull/50360
* test: skip test-diagnostics-channel-memory-leak.js
https://github.com/nodejs/node/pull/50327
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* lib: fix assert throwing different error messages in ESM and CJS
https://github.com/nodejs/node/pull/50634
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* deps: update base64 to 0.5.1
https://github.com/nodejs/node/pull/50629
* src: avoid silent coercion to signed/unsigned int
https://github.com/nodejs/node/pull/50663
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* chore: fix patch indices
* chore: update patches
* test: disable TLS cipher test
This can't be enabled owing to BoringSSL incompatibilities.
https://github.com/nodejs/node/pull/50186
* fix: check for Buffer and global definition in shadow realm
https://github.com/nodejs/node/pull/51239
* test: disable parallel/test-shadow-realm-custom-loader
Incompatible with our asar logic, resulting in the following failure:
> Failed to CompileAndCall electron script: electron/js2c/asar_bundle
* chore: remove deleted parallel/test-crypto-modp1-error test
* test: make test-node-output-v8-warning generic
https://github.com/nodejs/node/pull/50421
* chore: fixup ModuleWrap patch
* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream
* fix: sandbox is not enabled on arm
* chore: disable v8 sandbox on ia32/arm
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-18 16:16:45 -05:00
github-actions[bot]
6ea7da4b90
build: update appveyor image to latest version ( #40951 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-18 16:08:00 -05:00
Guo Hao (Andrew) Lay
135c542555
feat: Windows integrity check ( #40504 )
...
* Add Windows integrity check feature into Electron
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Add integrity checker header file to sources
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Moved integrity checker after checking command line args
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Revert previous Windows integrity check commits (2379a60 , 331cf3c , a3c47ec )
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Implement asar header integrity for Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Fix Archive::RelativePath() on Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Address comments.
* Address Windows integrity check PR comments.
* Update absl::optional to std::optional.
* Fix spelling.
---------
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
Co-authored-by: Weiyun Dai <weiyund@amazon.com >
Co-authored-by: Weiyun Dai <35878488+WeiyunD@users.noreply.github.com >
2024-01-19 09:00:49 +13:00
John Kleinschmidt
3dafb318a8
test: fixup assertNotWindows ( #41045 )
...
* chore: fixup assertNotWindows
* remove logging
2024-01-18 14:04:43 -05:00
Shelley Vohr
7e6fb97a2f
fix: crash when dialog.showMessageBoxSync with missing buttons ( #40996 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
* chore: feedback from review
2024-01-18 13:21:15 +01:00
Shelley Vohr
df7f07a8af
fix: modal rounding on nonmodal windows ( #41003 )
...
* fix: modal rounding on nonmodal windows
* chore: feedback from review
2024-01-18 09:59:54 +01:00
Tamás Zahola
f97d8719e6
fix: use HasStyleMask(NSWindowStyleMaskResizable) instead of IsResizable() for enabling/disabling window maximize button ( #40994 )
2024-01-17 18:23:41 +01:00
Charles Kerr
021592200e
refactor: remove deprecated ToInternalValue() ( #40980 )
...
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad()
* refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem()
* chore: rename temp variable to now_usec for clarity
2024-01-17 10:17:43 -05:00
Shelley Vohr
6803624576
fix: check for Node.js-created module when contextIsolation disabled ( #40993 )
2024-01-16 14:29:00 +01:00
Robo
4949c4c4e1
chore: fix building blink_tests target ( #40982 )
2024-01-16 12:24:14 +01:00
Shelley Vohr
61f619a5e6
ci: correctly export RBE_experimental_credentials_helper_args ( #40997 )
2024-01-15 19:48:10 +01:00
Charles Kerr
b3e01220cb
refactor: fix deprecated base::Base64Encode() API calls ( #40962 )
...
* refactor: replace deprecated Base64Encode() usage in IWC::NetworkResourceLoader::OnDataReceived()
* refactor: replace deprecated Base64Encode() usage EncodeToken(const base::UnguessableToken& token)
2024-01-15 11:01:35 +01:00
Charles Kerr
80b220d214
refactor: use base::NoDestructor instead of base::LazyInstance ( #40947 )
...
* refactor: use NoDestructor for g_io_thread_application_locale
* refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance()
* refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
* refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
* chore: remove unused #include
* fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
make sure instance is static
* chore: remove unused #include "base/lazy_instance.h"
2024-01-12 14:50:29 +01:00
Shelley Vohr
57b29903e3
build: log got error response bodies ( #40965 )
2024-01-12 14:37:39 +01:00
Samuel Attard
bbfe809d02
docs: add reclient docs, remove goma docs ( #40948 )
...
* docs: add reclient docs, remove goma docs
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-01-12 13:50:20 +13:00
Keeley Hammond
e83192adba
ci: revert CI git cache removal ( #40964 )
...
* Revert "ci: increase "gclient sync" output timeout (#40963 )"
This reverts commit be4eb4e8a7 .
* Revert "build: remove CI cache of git cache (#40953 )"
This reverts commit b39ebb8625 .
2024-01-11 13:51:19 -08:00
Keeley Hammond
be4eb4e8a7
ci: increase "gclient sync" output timeout ( #40963 )
...
ci: increase gclient output timeout
2024-01-11 11:56:22 -08:00
Samuel Attard
8b9eb518a9
build: fix windows remote exec of python actions ( #40958 )
2024-01-11 07:17:35 -08:00
Shelley Vohr
d5d162b622
fix: InAppPurchase pre-emptive deallocation ( #40938 )
...
* fix: InAppPurchase pre-emptive deallocation
* test: try re-enabling IAP tests
2024-01-11 13:32:29 +01:00
Samuel Attard
b39ebb8625
build: remove CI cache of git cache ( #40953 )
2024-01-11 23:29:49 +13:00
electron-roller[bot]
2e4e6f10de
chore: bump chromium to 122.0.6236.2 (main) ( #40871 )
...
* chore: bump chromium in DEPS to 122.0.6223.0
* 5129828: Removes special cases for selenium-atoms dependencies.
https://chromium-review.googlesource.com/c/chromium/src/+/5129828
* chore: fixup patch indices
* 5139789: Deduplicate BrowserContext's ResourceContext
https://chromium-review.googlesource.com/c/chromium/src/+/5139789
* 5148579: Simplify SelectFileDialog::Listener
https://chromium-review.googlesource.com/c/chromium/src/+/5148579
* 5134038: Code Health: Use string_view in base::i18n::BreakIterator::SetText
https://chromium-review.googlesource.com/c/chromium/src/+/5134038
* 5137427: Code Health: Use string_view in SpellCheck::SpellCheckWord
https://chromium-review.googlesource.com/c/chromium/src/+/5137427
* [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left
Notable things in this commit:
* refactors `__indirect_binary_left_foldable`, making it slightly
different (but equivalent) to _`indirect-binary-left-foldable`_, which
improves readability (a [patch to the Working Paper][patch] was made)
* omits `__cpo` namespace, since it is not required for implementing
niebloids (a cleanup should happen in 2024)
* puts tests ensuring invocable robustness and dangling correctness
inside the correctness testing to ensure that the algorithms' results
are still correct
[patch]: https://github.com/cplusplus/draft/pull/6734
* chore: bump chromium in DEPS to 122.0.6224.0
* 5154766: [Refresh 2023] [GTK] Fix gap above toolbar with fractional scaling
https://chromium-review.googlesource.com/c/chromium/src/+/5154766
* chore: fixup patch indices
* 5094458: Remove extra CGColorSpace parameters from skia and ui helpers
https://chromium-review.googlesource.com/c/chromium/src/+/5094458
* chore: bump chromium in DEPS to 122.0.6226.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6227.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6228.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6230.0
* chore: bump chromium in DEPS to 122.0.6232.0
* chore: bump chromium in DEPS to 122.0.6234.0
* chore: bump chromium in DEPS to 122.0.6236.2
* chore: update patches
* fix: remove --disable-color-correct-renderering
Per https://electronhq.slack.com/archives/CB6CG54DB/p1698444047862459 it is not used any more and was never documented.
* chore: add WEB_PRINTING to content permission converter
Unused in non-cros so no need to document
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5136178
* chore: Views is now vec<raw_ptr> instead of raw<T*>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5140028
* spec: add Iterator to global intrinsics
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-01-11 19:33:40 +13:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Charles Kerr
fac964ac0d
refactor: migrate deprecated LazyInstance code to NoDestructor ( #40927 )
...
* refactor: do not use deprecated NoDestructor in javascript_environment.cc
* refactor: do not use deprecated NoDestructor in window_list.cc
2024-01-10 14:01:49 -06:00
David Sanders
c2c64d27fd
ci: fix missing inputs for release project board automation ( #40726 )
2024-01-10 13:25:11 +01:00
Samuel Attard
d5c658545a
chore: fix content tracing flake ( #40939 )
...
* chore: fix contentTracing test
* cry
2024-01-11 01:13:36 +13:00
Samuel Attard
ebf9a49fba
build: use container runner for arm tests ( #40875 )
...
* build: use aks arm64 test runners
* build: better image
* build: even more stuff
* build: arm par
* build: use aks arm32
* build: arm32 par
* build: get test timings from abs paths
* build: avoid realpath, use echo
2024-01-10 13:12:19 +13:00
Samuel Attard
3afb012ad1
build: add infra for reclient support ( #40850 )
...
* chore: add patch to always set macos platform for x-build
* build: add infra for reclient support
* build: override reclient version
* build: use RBE in CI
* chore: hardcode reclient fix version
* build: lower process count on macOS
* build: use large macOS instance for testing-arm64
* Revert "build: use large macOS instance for testing-arm64"
This reverts commit 6844adfd00a5230e68234112dfd84caa50d3f621.
* build: login in via helper not writing file
* chore: update patches
* build: use recelint from DEPS
* build: fix windows reproxy cfg
* build: use reclient in appveyor
* build: update WOA job too
* build: force another build
* build: do not checkout reclient
2024-01-10 10:19:42 +13:00
Shelley Vohr
c184b93fc5
fix: crash using powerMonitor before ready event ( #40888 )
...
* fix: crash using powerMonitor before ready event
* refactor: continue using DBusBluezManagerWrapperLinux
2024-01-09 09:41:42 +01:00
Charles Kerr
7b4d490bfe
perf: use fixed-size arrays for the font cache ( #40898 )
...
refactor: use fixed-size arrays for the font cache
Since we know at compile time which [family x script] combos we want to
cache, we can hold the cache in fixed std::arrays instead of in nested
std::unordered_maps.
2024-01-08 10:31:02 +01:00
Calvin
37630a6128
fix: wide string concatenation ( #40892 )
...
* fix: wide string concatenation
* Use wstring_views to keep length in context
* forgot a space, oopsies
2024-01-07 22:02:20 -08:00
Shelley Vohr
3a22fd3216
docs: add missing vibrancy breaking change ( #40893 )
...
docs: add missing vibranch change
2024-01-07 13:56:52 -08:00
Charles Kerr
73e7125041
chore: do not inject DXVA_Decoding trace category ( #40891 )
...
This doesn't need to be injected. Looks like it was an accident in
60ca38fb for https://github.com/electron/electron/pull/38465 .
2024-01-05 17:54:41 -06:00
Tamás Zahola
cc1b64e01c
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable ( #40705 )
...
* fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable
* add test
* fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`
2024-01-05 12:15:35 -05:00
Charles Kerr
22970f573b
perf: use flat_set, flat_map for small, trivially-moved containers ( #40817 )
...
* refactor: use base::flat_map in ElectronMenuModel
* refactor: use base::flat_map in BuildSubmenuFromModel()
* refactor: use base::flat_map in GetDialogsMap()
* refactor: use base::flat_map in DesktopCapturer
* refactor: use base::flat_map, flat_set in ElectronBrowserClient
* refactor: use base::flat_map in ProxyingURLLoaderFactory
* refactor: use base::flat_map in MapToCommonId()
* refactor: use base::flat_map for g_map_id
* refactor: use base::flat_map for ViewsDelegate::AppbarAutohideEdgeMap
* refactor: use base::flat_map for App::app_metrics_
* refactor: use base::flat_map for PowerSaveBlocker::wake_lock_types_
* refactor: use base::flat_map for NativeImage::hicons_
* refactor: use base::flat_map for MenuViews::menu_runners_
* refactor: use base::flat_map for WebViewManager::web_contents_embedder_map_
* refactor: use base::flat_map for InspectableWebContents::extensions_api_
* refactor: use base::flat_set for libnotify GetServerCapabilities()
* refactor: use base::flat_set for InspectableWebContents::loaders_
* refactor: use base::flat_set for ElectronRendererClient::environments_
refactor: use base::flat_set for ElectronRendererClient::injected_frames_
* refactor: use base::flat_set for WebWorkerObserver::environments_
2024-01-05 12:18:31 +01:00
Brandon Fowler
5086071294
feat: add transparent webpreference to webview ( #40301 )
...
* feat: add transparent option to WebContents
* feat: add transparent attribute to webview
* test: add tests for webview transparent attribute
* docs: add transparent attribute to webview docs
* fix: run tests on macOS only
* refactor: remove unneeded html tag
* fix: only apply transparent option to guests
* refactor: correct comment
* refactor: use opaque instead
Retains current webview behaviour by default.
* fix: correct variable name to guest_opaque_
* refactor: use transparent webpreference
* docs: remove unused web preference
* fix: uncomment condition for transparency test
* docs: converted to list format and linked to MDN
* fix: make webviews transparent by default again
* fix: rebase error
---------
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-05 13:00:27 +09:00
Devraj Mehta
8c71e2adc9
feat: add net module to utility process ( #40017 )
...
* chore: initial prototype of net api from utility process
* chore: update url loader to work on both browser and utility processes
* chore: add net files to utility process bundle
* chore: re-add app ready check but only on main process
* chore: replace browser thread dcheck's with sequence checker
* refactor: move url loader from browser to common
* refactor: move net-client-request.ts from browser to common
* docs: add utility process to net api docs
* refactor: move net module app ready check to browser only
* refactor: switch import from main to common after moving to common
* test: add basic net module test for utility process
* refactor: switch browser pid with utility pid
* refactor: move electron_api_net from browser to common
* chore: add fetch to utility net module
* chore: add isOnline and online to utility net module
* refactor: move net spec helpers into helper file
* refactor: break apart net module tests
Adds two additional net module test files: `api-net-session-spec.ts` for
tests that depend on a session being available (aka depend on running on
the main process) and `api-net-custom-protocols-spec.ts` for custom
protocol tests. This enables running `api-net-spec.ts` in the utility
process.
* test: add utility process mocha runner to run net module tests
* docs: add utility process to net module classes
* refactor: update imports in lib/utility to use electron/utility
* chore: check browser context before using in main process
Since the browser context supplied to the SimpleURLLoaderWrapper can now
be null for use in the UtilityProcess, adding a null check for the main
process before use to get a more sensible error if something goes wrong.
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* chore: remove test debugging
* chore: remove unnecessary header include
* docs: add utility process net module limitations
* test: run net module tests in utility process individually
* refactor: clean up prior utility process net tests
* chore: add resolveHost to utility process net module
* chore: replace resolve host dcheck with sequence checker
* test: add net module tests for net.resolveHost
* docs: remove utility process limitation for resolveHost
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2024-01-04 16:20:37 -05:00
Charles Kerr
f229201f41
refactor: make NativeWindow getter methods const ( #40804 )
...
* refactor: make NativeWindow getter methods const
* fixup! refactor: make NativeWindow getter methods const
make GetZOrderLevel() const
* fixup! refactor: make NativeWindow getter methods const
fix oops
2024-01-04 09:51:59 -06:00
Mathew Bino
3a06047e61
docs: note accelerator case insensitivity ( #40783 )
...
* Fix PR#38673
As requested in PR#38673 , a line has been added that explicitly states that accelerators are case sensitive
* Update docs/api/accelerator.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update accelerator.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-01-04 10:06:12 -05:00
Jeremy Rose
84ba0c6c7d
fix: BrowserView and <webview> should be transparent by default ( #40866 )
2024-01-04 10:04:56 -05:00
Keeley Hammond
0672f59f26
chore: add disclaimer to release timeline ( #40717 )
...
* chore: add disclaimer to release timeline
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-01-04 10:01:40 -05:00
Cheng Zhao
dfce1a9eb4
fix: ignore all NODE_ envs from foreign parent in node process ( #40770 )
...
* fix: ignore all NODE_ envs from foreign parent
* fix: recognize ad-hoc signed binary
2024-01-04 16:34:08 +09:00
Shelley Vohr
baca2e302d
chore: drop ada ICU requirement for parsing hostnames ( #40860 )
2024-01-03 13:58:28 -05:00
electron-roller[bot]
8c89137ecd
chore: bump chromium to 122.0.6194.0 (main) ( #40750 )
...
* chore: bump chromium in DEPS to 122.0.6180.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532
minor manual changes to match upstream changes
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
* chore: update feat_add_onclose_to_messageport.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
no manual changes; patch applied with fuzz 1
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072
minor manual changes to match upstream changes
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481
no manual changes; patch applied with fuzz 2
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
* Remove performActionOnRemotePage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017
It appears it is not used by anything within Chromium or outside.
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872
The copy construtor is more expensive and has been removed upstream
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614
* chore: e patches all
* chore: bump chromium to 122.0.6181.0
* chore: e patches all
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
* chore: make lint happy
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
upstream reverted this change
* chore: bump chromium in DEPS to 122.0.6182.0
* chore: update patches
* chore: fix virtual function names that were renamed upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989
* chore: node script/gen-libc++-filenames.js
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
* chore: bump chromium in DEPS to 122.0.6184.0
* chore: bump chromium in DEPS to 122.0.6186.0
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619
minor manual changes to match upstream changes
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922
minor manual changes to match upstream changes
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595
no manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: bump chromium in DEPS to 122.0.6188.0
* chore: bump chromium in DEPS to 122.0.6190.0
* chore: bump chromium in DEPS to 122.0.6192.0
* chore: bump chromium in DEPS to 122.0.6194.0
* Remove an unnecessary DCHECK which causes Lacros to crash.
https://chromium-review.googlesource.com/c/chromium/src/+/5124880
* [FixIt Week] Add shared regular profile function that includes ash
https://chromium-review.googlesource.com/c/chromium/src/+/5100709
* Simplify the PrintManagerHost::ScriptedPrint() call
https://chromium-review.googlesource.com/c/chromium/src/+/5019703
* [local compile hints] Add tests
https://chromium-review.googlesource.com/c/chromium/src/+/5024173
* chore: update patches
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: node script/gen-libc++-filenames.js
* Remove //ui/ozone/buildflags.h
https://chromium-review.googlesource.com/c/chromium/src/+/5119048
* fixup! Remove //ui/ozone/buildflags.h
* fixup! Remove //ui/ozone/buildflags.h
* chore: update patches
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
* fixup! Remove //ui/ozone/buildflags.h
* Add permission policy verification in PermissionControllerImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5059112
* fix: ensure spellcheck interface is registered for frame
* [exceptions] Unify pending and scheduled exceptions
https://chromium-review.googlesource.com/c/v8/v8/+/5050065
* fix: dchecks in node.js tests
* fix: try adding termination check
* chore: document breaking iframe change
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-03 09:52:49 +01:00
Jeremy Rose
be4e4ff11b
fix: make grant_file_protocol_extra_privileges fuse also block CORS fetches ( #40801 )
2024-01-02 13:06:33 -08:00
Bruno Henrique da Silva
a208d45aca
fix: titlebar incorrectly displayed on frameless windows ( #40749 )
...
* fix: titlebar incorrectly displayed on frameless windows
* fix: enable transparency for Mica windows
* Refactor ShouldWindowContentsBeTransparent
---------
Co-authored-by: clavin <clavin@electronjs.org >
2024-01-02 13:59:47 -05:00
Charles Kerr
7995c56fb0
refactor: use a FixedFlatMap for v8 converting ui::MenuSourceType ( #40786 )
2023-12-20 17:44:17 -06:00
Nikhil Simon Toppo
ab2a4fd836
docs: corrected the ipcMain import path ( #40764 )
...
Update tutorial-3-preload.md
corrected the import path for ipcMain
2023-12-19 12:30:48 -06:00
Keeley Hammond
95d094d75b
fix: add partition alloc check for MacOS 13/14+ ( #40757 )
2023-12-14 13:47:31 -08:00
Jeremy Rose
ba97679901
ci: re-comment pdb.zip download in appveyor.yml ( #40758 )
2023-12-14 12:24:05 +01:00
Jeremy Rose
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
Tamás Zahola
a94fb2cb5d
fix: don't reject loadURL() promise from did-fail-load - use did-finish-load instead ( #40661 )
2023-12-12 11:45:14 -08:00
Kishanjay
80d85c0e8e
fix: incorrectly mapped toggleDevTools in custom menu fiddle ( #40703 )
2023-12-12 11:36:34 -08:00
Jeremy Rose
66b2f697ea
build: remove dcheck.patch ( #40744 )
...
chore: remove dcheck.patch
2023-12-12 12:01:02 +01:00
Robo
83f15bd957
chore: cleanup tests creating crashpad handler in the test runner process ( #40668 )
...
* chore: cleanup tests creating crashpad handler in the test runner process
* ci: logging
* ci: enable logging
* ci: more logging
* ci: run all tests
* ci: more logging
* ci: increase timeout
* Revert "ci: increase timeout"
This reverts commit 870f74455d .
* Revert "ci: more logging"
This reverts commit 46837f8b3a .
* Revert "ci: run all tests"
This reverts commit 6a7889ce67 .
* Revert "ci: more logging"
This reverts commit 351473ab43 .
* Revert "ci: enable logging"
This reverts commit 194109ed5a .
* Revert "ci: logging"
This reverts commit 9a3396fc7a .
* chore: disable flaky ia32 tests
2023-12-12 19:38:42 +09:00
Keeley Hammond
a6417cc265
build: remove font flooding in devtools patch ( #40746 )
2023-12-12 10:13:31 +01:00
electron-roller[bot]
08a51f3339
chore: bump chromium to 121.0.6159.0 (main) ( #40632 )
...
* chore: bump chromium in DEPS to 121.0.6154.0
* chore: bump chromium in DEPS to 121.0.6155.0
* fix patches
* chore: update patches
* patch out reference to GetOcclusionTracker
* un-flag PIPOcclusionTracker
* chore: bump chromium in DEPS to 121.0.6157.0
* fix conflicts
https://chromium-review.googlesource.com/c/chromium/src/+/5038807
* add PIP occlusion tracker sources to chromium_src
* 5037591: Replace feature_list's Initialize* methods with Init*.
https://chromium-review.googlesource.com/c/chromium/src/+/5037591
* 4811903: Move //content/browser/renderer_host/input/synthetic_gesture_controller to //content/common/input
https://chromium-review.googlesource.com/c/chromium/src/+/4811903
* 4917953: usb: Add usb-unrestricted to permission policy
https://chromium-review.googlesource.com/c/chromium/src/+/4917953
* 5072395: Remove unused `creation_context` parameter from blink/public APIs
https://chromium-review.googlesource.com/c/chromium/src/+/5072395
* 5052035: [X11] Change AtomCache from a singleton to owned by Connection
https://chromium-review.googlesource.com/c/chromium/src/+/5052035
* fix v8/.patches
* node script/gen-libc++-filenames.js
* 5035771: Remove the SetImage method of ImageButton
https://chromium-review.googlesource.com/c/chromium/src/+/5035771
* fixup! 5052035: [X11] Change AtomCache from a singleton to owned by Connection
* fixup! 5035771: Remove the SetImage method of ImageButton
* chore: bump chromium in DEPS to 121.0.6159.0
* 4505903: [Extensions] Add lastAccessed property to chrome.tabs.Tab
https://chromium-review.googlesource.com/c/chromium/src/+/4505903
* update patches
* don't duplicate tabs API types
this causes weird memory bugs if the two get out of sync
* fix UAF in TrayIconCocoa
not sure why this is popping up just now ... this has been broken for ages afaict
* Revert "don't duplicate tabs API types"
This reverts commit 80dff2efaa .
This is failing tests with extensions API schema check failures, so
revert for now. we'll fix it later.
* revert v8 change causing node crashes
* chore: reduce diffs in revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-12-11 14:58:26 -06:00
electron-roller[bot]
890a557eed
chore: bump node to v20.10.0 (main) ( #40675 )
...
* chore: bump node in DEPS to v20.10.0
* chore: update feat_initialize_asar_support.patch
no code changes; patch just needed an update due to nearby upstream changes
Xref: https://github.com/nodejs/node/pull/49986
* chore: update pass_all_globals_through_require.patch
no manual changes; patch applied with fuzz
Xref: https://github.com/nodejs/node/pull/49657
* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls
Xref: https://github.com/nodejs/node/pull/49912
no code changes; patch just needed an update due to nearby upstream changes
* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch
Xref: https://github.com/nodejs/node/pull/49986
minor manual changes needed to sync with upstream change
* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/50096
Xref: https://github.com/nodejs/node/pull/50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this
Xref: https://github.com/nodejs/node/pull/49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream
* fix: lazyload fs in esm loaders to apply asar patches
* https://github.com/nodejs/node/pull/50127
* https://github.com/nodejs/node/pull/50096
* esm: jsdoc for modules code
https://github.com/nodejs/node/pull/49523
* test: set test-cli-node-options as flaky
https://github.com/nodejs/node/pull/50296
* deps: update c-ares to 1.20.1
https://github.com/nodejs/node/pull/50082
* esm: bypass CommonJS loader under --default-type=module
https://github.com/nodejs/node/pull/49986
* deps: update uvwasi to 0.0.19
https://github.com/nodejs/node/pull/49908
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* crypto: account for disabled SharedArrayBuffer
https://github.com/nodejs/node/pull/50034
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* src: generate snapshot with --predictable
https://github.com/nodejs/node/pull/48749
* chore: fixup patch indices
* fs: throw errors from sync branches instead of separate implementations
https://github.com/nodejs/node/pull/49913
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* esm: detect ESM syntax in ambiguous JavaScrip
https://github.com/nodejs/node/pull/50096
* fixup! test: fix edge snapshot stack traces
* esm: unflag extensionless ES module JavaScript and Wasm in module scope
https://github.com/nodejs/node/pull/49974
* [tagged-ptr] Arrowify objects
https://chromium-review.googlesource.com/c/v8/v8/+/4705331
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-12-11 21:09:50 +01:00
Felipe C
5094cb4115
fix: wrong default port in docs ( #40665 )
...
fix: wrong default port
2023-12-11 11:43:06 -05:00
Yureka
2eb13d377e
docs: fix year typos in electron-timelines.md ( #40728 )
2023-12-07 19:14:54 -08:00
David Sanders
93fdc8d33c
ci: roll back the link release project board to repo automation ( #40716 )
...
* ci: roll back the link release project board to repo automation
* ci: add workflow_dispatch
2023-12-06 20:58:41 -08:00
Keeley Hammond
d6a80bad05
build: bump NMV to 121 ( #40707 )
2023-12-05 20:31:36 -08:00
Cheng Zhao
cb0da6ff34
fix: prevent node mode to be used as script runner by other apps ( #40579 )
2023-12-06 11:23:54 +09:00
Cheng Zhao
9aa73abe78
feat: enable code cache for custom protocols ( #40544 )
2023-12-06 11:22:41 +09:00
Jeremy Rose
85bc005cd6
refactor: move JS dialog handling to JS ( #40598 )
2023-12-05 17:36:23 -08:00
tr2-harada
ee8d97d7fe
build: update typescript-definitions to 8.15.2 ( #40670 )
...
* build: update typescript-definitions to 8.15.2
* chore: update yarn.lock
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-12-05 00:53:52 -08:00
Robo
3a510a26d0
chore: cleanup global reject handler leaking into tests ( #40689 )
2023-12-05 12:56:51 +09:00
Keeley Hammond
9afeaa3a4c
docs: add E28 support for ESM in tutorial.md ( #40690 )
...
docs: add E28 support for ESM in tutorial
2023-12-04 12:36:37 -08:00
Shelley Vohr
10a165a9ff
fix: webview zoom level persistence on navigation ( #40650 )
2023-12-04 10:39:20 -05:00
David Sanders
66b4b21646
ci: tweak new release board workflow ( #40680 )
...
* ci: tweak new release board workflow
* ci: fix workflow
2023-12-04 10:18:14 -05:00
Ryan Manuel
6f14dba7a0
fix: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium ( #40681 )
...
* chore: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium
* update patch message
2023-12-04 13:37:03 +09:00
Albert Xing
3609fc7402
fix: clean up devtools frontend_host on webcontents destroy ( #40666 )
...
* fix: clean up devtools frontend_host on destroy
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
* test: add a test for re-opening devtools
2023-12-01 11:37:52 -08:00
George Xu
344b7f0d06
docs: add dates for e29 ( #40622 )
...
* docs: add dates for e29
* update dates for e26 eol
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: update Jan to Dec
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-11-30 20:55:42 -08:00
Cheng Zhao
96f5f89f1b
chore: fix building content_browsertests ( #40652 )
2023-11-30 07:23:21 -08:00
Shelley Vohr
9c94fd7afb
chore: upgrade to Node.js v20 ( #40545 )
...
* chore: upgrade to Node.js v20
* src: allow embedders to override NODE_MODULE_VERSION
https://github.com/nodejs/node/pull/49279
* src: fix missing trailing ,
https://github.com/nodejs/node/pull/46909
* src,tools: initialize cppgc
https://github.com/nodejs/node/pull/45704
* tools: allow passing absolute path of config.gypi in js2c
https://github.com/nodejs/node/pull/49162
* tools: port js2c.py to C++
https://github.com/nodejs/node/pull/46997
* doc,lib: disambiguate the old term, NativeModule
https://github.com/nodejs/node/pull/45673
* chore: fixup Node.js BSSL tests
* https://github.com/nodejs/node/pull/49492
* https://github.com/nodejs/node/pull/44498
* deps: upgrade to libuv 1.45.0
https://github.com/nodejs/node/pull/48078
* deps: update V8 to 10.7
https://github.com/nodejs/node/pull/44741
* test: use gcUntil() in test-v8-serialize-leak
https://github.com/nodejs/node/pull/49168
* module: make CJS load from ESM loader
https://github.com/nodejs/node/pull/47999
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* chore: address changes to CJS/ESM loading
* module: make CJS load from ESM loader (https://github.com/nodejs/node/pull/47999 )
* lib: improve esm resolve performance (https://github.com/nodejs/node/pull/46652 )
* bootstrap: optimize modules loaded in the built-in snapshot
https://github.com/nodejs/node/pull/45849
* test: mark test-runner-output as flaky
https://github.com/nodejs/node/pull/49854
* lib: lazy-load deps in modules/run_main.js
https://github.com/nodejs/node/pull/45849
* url: use private properties for brand check
https://github.com/nodejs/node/pull/46904
* test: refactor `test-node-output-errors`
https://github.com/nodejs/node/pull/48992
* assert: deprecate callTracker
https://github.com/nodejs/node/pull/47740
* src: cast v8::Object::GetInternalField() return value to v8::Value
https://github.com/nodejs/node/pull/48943
* test: adapt test-v8-stats for V8 update
https://github.com/nodejs/node/pull/45230
* tls: ensure TLS Sockets are closed if the underlying wrap closes
https://github.com/nodejs/node/pull/49327
* test: deflake test-tls-socket-close
https://github.com/nodejs/node/pull/49575
* net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
https://github.com/nodejs/node/pull/49400
* net: use asserts in JS Socket Stream to catch races in future
https://github.com/nodejs/node/pull/49400
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* src: create BaseObject with node::Realm
https://github.com/nodejs/node/pull/44348
* src: implement DataQueue and non-memory resident Blob
https://github.com/nodejs/node/pull/45258
* sea: add support for V8 bytecode-only caching
https://github.com/nodejs/node/pull/48191
* chore: fixup patch indices
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* build: modify js2c.py into GN executable
* fix: (WIP) handle string replacement of fs -> original-fs
* [v20.x] backport vm-related memory fixes
https://github.com/nodejs/node/pull/49874
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* src: avoid copying string in fs_permission
https://github.com/nodejs/node/pull/47746
* look upon my works ye mighty
and dispair
* chore: patch cleanup
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* fix: missing include for NODE_EXTERN
* chore: fixup patch indices
* fix: fail properly when js2c fails in Node.js
* build: fix js2c root_gen_dir
* fix: lib/fs.js -> lib/original-fs.js
* build: fix original-fs file xforms
* fixup! module: make CJS load from ESM loader
* build: get rid of CppHeap for now
* build: add patch to prevent extra fs lookup on esm load
* build: greatly simplify js2c modifications
Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c
* chore: update to handle moved internal/modules/helpers file
* test: update @types/node test
* feat: enable preventing cppgc heap creation
* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler
* fix: no cppgc initialization in the renderer
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* test: disable single executable tests
* fix: nan tests failing on node headers missing file
* tls,http2: send fatal alert on ALPN mismatch
https://github.com/nodejs/node/pull/44031
* test: disable snapshot tests
* https://github.com/nodejs/node/pull/47887
* https://github.com/nodejs/node/pull/49684
* https://github.com/nodejs/node/pull/44193
* build: use deps/v8 for v8/tools
Node.js hard depends on these in their builtins
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* build: remove js2c //base dep
* build: use electron_js2c_toolchain to build node_js2c
* fix: don't create SafeSet outside packageResolve
Fixes failure in parallel/test-require-delete-array-iterator:
=== release test-require-delete-array-iterator ===
Path: parallel/test-require-delete-array-iterator
node:internal/per_context/primordials:426
constructor(i) { super(i); } // eslint-disable-line no-useless-constructor
^
TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
at new Set (<anonymous>)
at new SafeSet (node:internal/per_context/primordials:426:22)
* fix: failing crashReporter tests on Linux
These were failing because our change from node::InitializeNodeWithArgs to
node::InitializeOncePerProcess meant that we now inadvertently called
PlatformInit, which reset signal handling. This meant that our intentional
crash function ElectronBindings::Crash no longer worked and the renderer process
no longer crashed when process.crash() was called. We don't want to use Node.js'
default signal handling in the renderer process, so we disable it by passing
kNoDefaultSignalHandling to node::InitializeOncePerProcess.
* build: only create cppgc heap on non-32 bit platforms
* chore: clean up util:CompileAndCall
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* fix: use thread_local BuiltinLoader
* chore: fixup v8 patch indices
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-11-30 09:51:35 -05:00
Tamás Zahola
39ee94089a
fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive() ( #40546 )
...
* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()
* add test
2023-11-30 12:43:22 +01:00
Charles Kerr
b2fcc15ec7
build: fix release notes script bug that omitted edited release-clerk comments ( #40634 )
...
* build: fix release notes script bug that omitted edited release-clerk comments
add a warning when neither notes nor no-notes are found
* fixup! build: fix release notes script bug that omitted edited release-clerk comments
use console.warn() instead of console.log()
2023-11-30 12:41:48 +01:00
Jeremy Rose
763bc62c7f
chore: remove fix_add_check_for_sandbox_then_result.patch ( #40633 )
2023-11-29 10:30:21 -08:00
Cheng Zhao
abb71f5307
chore: make use of the v8_expose_public_symbols flag ( #40624 )
...
* chore: make use of the v8_expose_public_symbols flag
Use the newly added v8_expose_public_symbols flag to expose V8 symbols,
instead of relying on custom patches.
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-29 12:46:27 +09:00
David Sanders
c12ab7c941
ci: use pull_request_target for PR labeled workflows ( #40623 )
2023-11-29 08:33:07 +09:00
electron-roller[bot]
5c7579ab1c
chore: bump chromium to 121.0.6147.0 (main) ( #40523 )
...
* chore: bump chromium in DEPS to 121.0.6128.0
* build: update patches
* refactor: remove instrumentation from extensions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5002404
* refactor: modernization of tabs_api
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4997031
* fix: add RecordHover and RecordDrag handlers
* build: add missing pdf files
* chore: bump chromium in DEPS to 121.0.6129.0
* chore: bump chromium in DEPS to 121.0.6131.0
* chore: update patches
* refactor: remove will_cause_resize from ExitFullscreen
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
* chore: add missing std converter include
Before these were being inferred as std::string implicitly, not anymore
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5029573
* chore: Unwrap UserScriptList from unique_ptrs
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5005198
* refactor: add PDF internal id into PDF stream info
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4876972
* refactor: add metadata to view classes
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4994885
* chore: run lint --fix
* chore: update libc++ filenames
* chore: clean up menubar
* chore: update patches after main merge
* 5010979: Replace base::WStringPiece usage with std::wstring_view | https://chromium-review.googlesource.com/c/chromium/src/+/5010979
* chore: bump chromium in DEPS to 121.0.6142.0
* chore: update patches
* 4969574: Refactor NativeDesktopMediaList | https://chromium-review.googlesource.com/c/chromium/src/+/4969574
* 5031192: [blink] Create new blink test suite that doesn't create blink Isolate | https://chromium-review.googlesource.com/c/chromium/src/+/5031192
* chore: update v8/devtools patches
* 5040722: [base] Replace MakeFixedFlatTreeSorted with tag type overloads | https://chromium-review.googlesource.com/c/chromium/src/+/5040722
* 5026474: Add --generate-pdf-document-outline | https://chromium-review.googlesource.com/c/chromium/src/+/5026474
* 5024297: Change parameter of CheckMediaAccessPermission from GURL to URL::Origin | https://chromium-review.googlesource.com/c/chromium/src/+/5024297
* 5034217: [RWS] Remove CanonicalCookie::IsSameParty method | https://chromium-review.googlesource.com/c/chromium/src/+/5034217
* 5037192: Rewrite usage of RenderFrame::GetRoutingID | https://chromium-review.googlesource.com/c/chromium/src/+/5037192
* 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* chore: bump chromium in DEPS to 121.0.6143.0
* chore: bump chromium in DEPS to 121.0.6145.0
* chore: update chromium patches
* 5049986: Use std::unique_ptr for MenuItemView::submenu_ member. | https://chromium-review.googlesource.com/c/chromium/src/+/5049986
* 5041595: picture-in-picture: Add PictureInPictureOcclusionTracker | https://chromium-review.googlesource.com/c/chromium/src/+/5041595
* chore: update all patches
* chore: bump chromium in DEPS to 121.0.6147.0
* chore: update patches
* 5051069: Use base::FunctionRef for BrowserPluginGuestManager. | https://chromium-review.googlesource.com/c/chromium/src/+/5051069
* 5057330: [base] Remove base::Erase()/base::EraseIf() overloads for std::set | https://chromium-review.googlesource.com/c/chromium/src/+/5057330
* fixup! 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* 5017518: Remove PPAPI if NaCl is disabled | https://chromium-review.googlesource.com/c/chromium/src/+/5017518
* 5002232: [DevTools] Console Insights: move from build flag to Feature API | https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* 4970322: [X11] Move utils into x11::Connection | https://chromium-review.googlesource.com/c/chromium/src/+/4970322
* 5048950: Let MenuModelAdapter::CreateMenu return a std::unique_ptr<>. | https://chromium-review.googlesource.com/c/chromium/src/+/5048950
* chore: update libcxx filenames
* use Context::Scope in RunScriptsAtDocument{Start,End}
* 4775128: content: Reuse CC instance for main frame navigations
https://chromium-review.googlesource.com/c/chromium/src/+/4775128
* also wrap WebWorkerObserver::ContextWillDestroy with Context::Scope
* set LIBCPP_HARDENING_MODE
https://chromium-review.googlesource.com/c/chromium/src/+/5014271
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-11-28 13:40:12 -08:00
Felix Rieseberg
f0f027c06d
fix: Use activateIgnoringOtherApps for non-panels ( #40570 )
...
Use activateIgnoringOtherApps for non-panels
2023-11-27 12:58:46 -05:00
Cheng Zhao
58a21a3cd9
chore: allow passing more roots to lint.js ( #40571 )
2023-11-27 09:26:33 +09:00
Samuel Attard
79e714a825
chore: add patch upstream plan for resize patch ( #40596 )
2023-11-22 12:36:52 -08:00
Samuel Attard
44e055a788
build: specify explicit typeroots for ts builds ( #40588 )
...
Upstreaming of bf63336f60
2023-11-22 09:39:36 -08:00
Shelley Vohr
e78ce82641
fix: do not call after() async_hook for asyncId 0 ( #40574 )
...
fix: do not call after() async_hook for asyncId 0
2023-11-22 17:37:40 +01:00
Samuel Attard
1574cbf137
fix: restore performance of macOS window resizing ( #40577 )
2023-11-21 23:58:57 -08:00
Tomasz
3340bc1bf9
fix: maximized window bounds when toggle setResizable ( #40503 )
2023-11-22 15:21:18 +09:00
David Sanders
2029224a84
ci: trigger Slack workflow on backport requested ( #40487 )
2023-11-22 15:20:34 +09:00
clintharris
f3676ff975
docs: wording in IPC tutorial docs ( #40555 )
...
fix: wording in IPC tutorial docs
2023-11-22 15:19:54 +09:00
Alex Browne
0b5fceb50e
docs: update quick-start.md ( #40556 )
...
Updates the Quick Start guide to specify _where_ JavaScript code is supposed to be added. This is more descriptive than just "your file".
2023-11-22 15:19:39 +09:00
Samuel Attard
dbe170c665
build: simplify mas patches ( #36368 )
...
* build: simplify mas patches
* build: re-add configs
2023-11-21 10:53:21 -08:00
David Sanders
3d2a754531
chore: extend linting of code blocks in the docs ( #40245 )
...
* chore: extend linting of code blocks in the docs
* chore: combine lint:markdownlint and lint:markdown scripts
2023-11-21 16:50:08 +09:00
Samuel Attard
d6bb9b40b0
feat: add webUtils module with getPathForFile method ( #38776 )
...
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* chore: update patches
* fix: provide isolate to WebBlob::FromV8Value
* chore: add tests
* build: fix depshash mismatch on arm64 macOS
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-20 15:59:36 -08:00
Xie Jingyi
2c03b8fd6b
fix: ShowItemUsingFileManager should escape path in Linux ( #40527 )
2023-11-20 09:00:56 +09:00
Milan Burda
67894f1493
test: convert a few more specs to async/await ( #40313 )
2023-11-17 10:44:03 +01:00
Shelley Vohr
471449d9f6
feat: add/update missing Display properties ( #40497 )
2023-11-17 10:43:04 +01:00
Samuel Attard
dec96acf14
fix: add patch for simdutf base64 crash ( #40536 )
2023-11-15 20:11:08 -08:00
github-actions[bot]
d2b07a484d
build: update appveyor image to latest version e-121.0.6116.0 ( #40531 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-15 09:44:10 -08:00
Shelley Vohr
371bca69b6
refactor: use new extensions Messaging API IPC ( #40511 )
...
* refactor: use new extensions Messaging API IPC
Refs CRBUG:993189
Incorporates changes from:
* Bind ServiceWorker associated interfaces on Worker Thread (CL:4929154)
* [extensions] Move WakeEventPage to mojom::RendererHost (CL:4902564)
* [extensions] Convert Extension Messaging APIs over to mojo (CL:4947890)
* [extensions] Port GetMessageBundle over to mojom (CL:4956841)
* 5008635: [extensions] Bind the mojo interfaces to the frame instance
https://chromium-review.googlesource.com/c/chromium/src/+/5008635
2023-11-15 15:30:47 +01:00
Samuel Maddock
088affd4a4
fix: emit will-navigate for links in chrome: pages ( #40390 )
...
* fix: emit will-navigate for links in chrome: pages
* test: will-navigate emitted from chrome: pages
* Update shell/browser/electron_navigation_throttle.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-11-14 14:09:44 -08:00
electron-roller[bot]
0e4e9dc98c
chore: bump chromium to 121.0.6116.0 (main) ( #40490 )
...
* chore: bump chromium in DEPS to 121.0.6116.0
* chore: update patches
* Update webIDL to support close event.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4970653
* Remove uses of implicit conversion of ScopedTypeRef
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439
* Add GlobalRenderFrameHostToken
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5001743
* [DevTools] Console Insights: move from build flag to Feature API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* [Extensions] Use script serialization in scripting API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4968680
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4998265
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* chore: update libcxx files
* chore: address nan compilation error
* spec: use nan dependency from third_party
It is easier to get fixes for spec modules depending on nan
* ci: publish nan artifact for woa
* fix: bad patch update
* chore: update nan resolution
* Revert "chore: update nan resolution"
This reverts commit 786cdb858c .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-11-14 13:21:32 -08:00
David Sanders
b639fa4626
ci: close previous release project board after creating new one ( #40425 )
...
* ci: close previous release project board after creating new one
* ci: tweak release project board closure to major - 2
2023-11-13 10:37:26 -08:00
Shelley Vohr
7981d955b8
fix: chrome.action API registration ( #40500 )
2023-11-13 08:27:18 +01:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
Cheng Zhao
262723e394
build: fix building content_unittests ( #40491 )
...
chore: fix building content_unittests
2023-11-10 08:50:28 -08:00
github-actions[bot]
6697042c0a
build: update appveyor image to latest version ( #40453 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-09 16:58:46 -05:00
David Sanders
2677f36db1
docs: update references to Electron Packager ( #40480 )
2023-11-09 11:15:32 -08:00
Samuel Attard
d504d150ef
feat: add new fuse to treat file: identically to browsers ( #40372 )
2023-11-09 10:23:52 -08:00
Milan Burda
0f68d845f9
refactor: AutoUpdater for Windows using async/await ( #40289 )
2023-11-07 14:55:22 -08:00
Shelley Vohr
1ba535296e
docs: fix hid-device-{added|removed|revoked} event types ( #40462 )
...
docs: fix hid-device-{added|removed|revoked} types
2023-11-07 14:26:35 -08:00
electron-roller[bot]
e8d9294d9d
chore: bump chromium to 121.0.6110.0 (main) ( #40448 )
...
* chore: bump chromium in DEPS to 121.0.6106.0
* chore: bump chromium in DEPS to 121.0.6108.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6110.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-07 07:24:50 -05:00
Felix Rieseberg
b55d7f4a16
fix: Do not activate app when calling focus on inactive panel window ( #40307 )
...
* fix: Do not activate app when calling focus on inactive panel window
* Use activate
* Use "activate" for all windows
2023-11-06 13:38:12 -08:00
Shelley Vohr
7999ea39e2
feat: keyboard.lock() should use permissions helper ( #40369 )
...
feat: `keyboard.lock()` should use permissions helper
2023-11-06 11:54:31 -08:00
electron-roller[bot]
ee108903a0
chore: bump chromium to 121.0.6104.0 (main) ( #40418 )
...
* chore: bump chromium in DEPS to 121.0.6101.0
* chore: update patches
* Explictly use python3 to check patch diff
* chore: bump chromium in DEPS to 121.0.6102.0
* chore: update patches
* 4995136: [extensions] Enable Extension Mojo messaging
https://chromium-review.googlesource.com/c/chromium/src/+/4995136
* Bind the components interfaces to a RenderFrame
https://chromium-review.googlesource.com/c/chromium/src/+/4985961
Also:
3986427: Create RendererHost mojom interface for Extensions | https://chromium-review.googlesource.com/c/chromium/src/+/3986427
* 4997024: Enum modernisation for resources_private.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997024
* 4997025: Enum modernisation for scripting.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997025
* chore: bump chromium in DEPS to 121.0.6103.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6104.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-03 15:37:55 -04:00
Shelley Vohr
5b18d90597
fix: crash when unloading some WebViews ( #40400 )
2023-11-03 10:36:25 -04:00
github-actions[bot]
f501dabc80
build: update appveyor image to latest version, e-121.0.6100.0 ( #40428 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-02 14:56:36 -04:00
Shelley Vohr
719e52928e
build: remove patch for EOL MSVC version ( #40419 )
2023-11-02 09:17:30 -04:00
Brandon Fowler
089eb34e8d
docs: add bypassCustomProtocolHandlers to ses.fetch ( #40358 )
2023-11-01 20:27:23 -04:00
electron-roller[bot]
5200abe744
chore: bump chromium to 121.0.6100.0 (main) ( #40408 )
...
* chore: bump chromium in DEPS to 121.0.6100.0
* chore: update patches
* 4970322: [X11] Move utils into x11::Connection
https://chromium-review.googlesource.com/c/chromium/src/+/4970322
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 19:01:01 -04:00
Shelley Vohr
83f0d2645e
docs: document our Node.js versioning policy ( #40373 )
2023-11-01 18:21:16 -04:00
github-actions[bot]
878c6e3062
build: update appveyor image to latest version ( #40325 )
...
* build: update appveyor image to latest version
* chore: update version to e-120.0.6099.0
* chore: rename base image for bakes
---------
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 16:19:59 -04:00
Milan Burda
b163187235
docs: avoid leaking the IpcRendererEvent in contextBridge examples ( #40321 )
...
* docs: avoid leaking the `IpcRendererEvent` in `contextBridge` examples
* Update docs/fiddles/ipc/pattern-3/preload.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-11-01 13:46:25 -04:00
David Sanders
425efb5e47
chore: remove py2 compatibility code ( #40375 )
2023-11-01 10:20:32 -04:00
electron-roller[bot]
bc1ba1fe9d
chore: bump chromium to 120.0.6099.0 (main) ( #40316 )
...
* chore: bump chromium in DEPS to 120.0.6086.0
* chore: update patches
* chore: rename FrameSubscriber::OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4905819
just a simple renaming
* chore: rename ToJsTime() to .InMillisecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename ToDoubleT() to .InSecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename FromDoubleT() to .FromSecondsSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: bump chromium in DEPS to 120.0.6088.2
* chore: update patches
* chore: regen filenames.libcxx.gni
* chore: migrate from (removed upstream) inputFormType to formControlType
* chore: bump chromium in DEPS to 120.0.6089.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4828507
manually sync to upstream changes + reduce diff size
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6090.0
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 2 (4 lines)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944206
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4946653
do not patch WebContentsImpl::SetWindowShowState() any longer because it has been removed
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6091.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6093.0
* chore: bump chromium in DEPS to 120.0.6095.0
* chore: bump chromium in DEPS to 120.0.6096.0
* chore: bump chromium in DEPS to 120.0.6097.0
* chore: update patches
* chore: update patch after rebase
* 4961495: [document pip] Focus the window when opened manually
https://chromium-review.googlesource.com/c/chromium/src/+/4961495
* [Extensions UserScripts] Store extensions with user scripts in tracker
| https://chromium-review.googlesource.com/c/chromium/src/+/4950530
* chore: bump chromium in DEPS to 120.0.6099.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: remove trailing space
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 10:02:12 -04:00
Samuel Attard
83892ab995
refactor: ensure IpcRenderer is not bridgable ( #40330 )
...
* refactor: ensure IpcRenderer is not bridgable
* chore: add notes to breaking-changes
* spec: fix test that bridged ipcrenderer
2023-10-31 17:29:40 -04:00
John Kleinschmidt
39d36e4462
build: actually show github upload output if verbose is true. ( #40393 )
...
* build: actually show github upload output if verbose is true.
* chore: fixup lint
2023-10-31 17:05:16 -04:00
Ninglo
f526206095
feat: configure use remote checksums via rc ( #40253 )
...
* feat: support for configuring use_remote_checksums via .npmrc
* docs: support for configuring use_remote_checksums via .npmrc
---------
Co-authored-by: jiujianian <jiujianian@bytedance.com >
2023-10-31 16:51:59 -04:00
Devraj Mehta
29d7be1565
build: update @electron/docs-parser and @electron/typescript-definitions ( #40264 )
...
* feat: add utility process typescript namespace
Upgrades docs-parser and typescript-definitions to add new
'electron/utility' namespace added in:
- https://github.com/electron/docs-parser/pull/95
- https://github.com/electron/typescript-definitions/pull/246
- https://github.com/electron/typescript-definitions/pull/247
* build: update yarn.lock
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-31 16:36:41 -04:00
Samuel Attard
e1c413c845
build: update deps to fix yarn audit ( #40376 )
2023-10-31 11:05:12 -07:00
Shelley Vohr
fcdd5cba71
fix: navigator.keyboard.lock() fullscreen exit handling ( #40365 )
...
fix: navigator.keyboard.lock() fullscreen exit handling
2023-10-31 11:59:39 -04:00
Milan Burda
4b1c31e4db
fix: implement missing applicationSupportsSecureRestorableState ( #40296 )
2023-10-31 10:22:58 -04:00
Shelley Vohr
8210d0f90e
build: don't rename files in electron_node/deps/base64 ( #40368 )
...
build: don't rename files in electron_node/deps/base64
Refs https://github.com/electron/electron/pull/35999/files#r1018305596 .
Finally addresses an old TODO to use a separate build target for conflicting
filenames instead of renaming files in the source tree.
2023-10-31 09:27:31 -04:00
Milan Burda
dd68581d30
docs: add reference to app.getAppMetrics() in serviceName for utilityProcess ( #40338 )
2023-10-30 10:07:23 -04:00
Shelley Vohr
652f995128
refactor: remove DevTools legacy UI patching ( #40331 )
2023-10-26 14:36:04 -04:00
Milan Burda
30fbcfca7b
chore: remove deprecated gpu-process-crashed event ( #40255 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-26 14:05:40 -04:00
Shelley Vohr
3f92a98315
fix: prevent PopUpButtonHandler premature dealloc ( #40308 )
...
fix: prevent PopUpButtonHandler dealloc
2023-10-26 11:40:02 -04:00
Samuel Attard
621b3ba897
build: upload slow, more time good ( #40332 )
2023-10-25 12:18:19 -07:00
Milan Burda
f66d4c7ee0
fix: make sure classes in lib correctly implement Electron interfaces ( #40291 )
2023-10-25 14:02:15 -04:00
Shelley Vohr
514a9319b9
refactor: use non-deprecated NSKeyedArchiver APIs ( #40315 )
...
* refactor: use non-deprecated NSKeyedArchiver APIs
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-25 12:01:34 -04:00
electron-roller[bot]
be44a2c5b7
chore: bump chromium to 120.0.6078.0 (main) ( #40114 )
...
* chore: bump chromium in DEPS to 120.0.6049.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6050.0
* chore: update patches
* 4910494: Reland "[autopip] Show autopip UI for video pip"
https://chromium-review.googlesource.com/c/chromium/src/+/4910494
* 4812338: Move partition_alloc into a "partition_alloc" dir.
https://chromium-review.googlesource.com/c/chromium/src/+/4812338
* [Extensions Cleanup] Remove mojom ViewType::kExtensionDialog
https://chromium-review.googlesource.com/c/chromium/src/+/4909897
* 4894923: Force enable raw_ptrs pointer arithmetic check.
https://chromium-review.googlesource.com/c/chromium/src/+/4894923
* gin: Prevent wrappables from being constructed from author code.
https://chromium-review.googlesource.com/c/chromium/src/+/4905829
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6052.0
* chore: bump chromium in DEPS to 120.0.6054.0
* chore: bump chromium in DEPS to 120.0.6056.0
* chore: fix patches
* 4918545: Reland "[autopip] Add permissions embargo"
https://chromium-review.googlesource.com/c/chromium/src/+/4918545
* 4881761: UI bindings for visual logging with structured metrics.
https://chromium-review.googlesource.com/c/chromium/src/+/4881761
* chore: bump chromium in DEPS to 120.0.6058.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6060.0
* chore: bump chromium in DEPS to 120.0.6061.0
* chore: bump chromium in DEPS to 120.0.6062.0
* chore: gen libc++ filenames
* chore: update patches
* 4911894: Move //c/b/ui/views/eye_dropper to //components
https://chromium-review.googlesource.com/c/chromium/src/+/4911894
* chore: bump chromium in DEPS to 120.0.6064.0
* chore: bump chromium in DEPS to 120.0.6066.0
* chore: bump chromium in DEPS to 120.0.6068.0
* chore: bump chromium in DEPS to 120.0.6070.0
* chore: remove temp_prevent_unused_function_error.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4931270
* chore: add TransferDragSecurityInfo()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4928028
* mark TransferDragSecurityInfo() as NOTREACHED
A follow-up to previous commit. I think this is commit is correct (i.e.
that this function shouldn't get called) but am not positive, so I'm
including it in a standalone commit in case we need to revert.
* chore: update signature of OnPrivateNetworkAccessPermissionRequired()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4919478
Our impl is a no-op, so updating the signature is the only change.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6072.0
* chore: update patches
* chore: sync ParseMatchPattern() param order with upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944243
* chore: update fix_crash_loading_non-standard_schemes_in_iframes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4939602
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6073.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6074.0
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4908053
no manual changes; patch applied with fuzz 1
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4936315
minor manual sync to upstream code shear
* chore: rebuild patches
* chore: update ClearHttpAuthCache arguments
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4937937
adding ClearDataFilterPtr arg. Upstream added this arg, which is already
present in other NetworkContext methods. Our code uses `nullptr` there.
* chore: bump chromium in DEPS to 120.0.6076.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4865412
minor manual sync to upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4942936
minor manual sync to upstream code shear
* fix: move x11_util.h include to top of source file
This is a short-term fix to unblock the roll. I will follow up a better fix in a standalone PR.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6077.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6078.0
* chore: update patches
* refactor: add BrowserProcessImpl::os_crypt_async()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4455776
This is one to keep an eye on. This commit copies the upstream impl,
which appears to be an interim step with more upstream code changes
still forthcoming.
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1373092
* fixup! refactor: add BrowserProcessImpl::os_crypt_async()
chore: make 'gn check' happy
* chore: remove ensure_messageports_get_gced_when_not_referenced.patch
Xref: ensure_messageports_get_gced_when_not_referenced.patch
no longer needed because upstreamed
* chore: remove webrtc/pipewire_capturer_make_restore_tokens_re-usable_more_than_one_time.patch
Xref: https://webrtc-review.googlesource.com/c/src/+/322621
no longer needed because upstreamed
* chore: add //components/compose:buildflags dep
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4912601
needed by browser/ui/browser_dialogs.h
* chore: update filenames.libcxx.gni
node ./script/gen-libc++-filenames.js
* test: fix UI.InspectorView -> UI.InspectorView.instance()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-24 11:24:20 -04:00
Milan Burda
54ff706b71
test: add spec for app.getAppMetrics() for utility process ( #40306 )
2023-10-24 09:25:30 -04:00
Milan Burda
a867503af6
test: add spec for child-process-gone event for utility process ( #40281 )
2023-10-23 11:30:08 -04:00
Milan Burda
beb0cbc6d0
refactor: options parsing in WebContents.prototype.printToPDF() ( #40257 )
...
* refactor: options parsing in WebContents.prototype.printToPDF()
* tweak parsePageSize
2023-10-19 15:38:30 -04:00
Shelley Vohr
025af3500c
chore: Show FIDO devices in the chooser if allowed ( #40216 )
...
* chore: Show FIDO devices in the chooser if allowed
* chore: tweak HidChooserContext::IsFidoAllowedForOrigin
* chore: feedback from review
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 19:19:51 -04:00
Shelley Vohr
32a721fa2b
test: fix Node.js color edge snapshot stack traces ( #40250 )
2023-10-18 21:39:53 +02:00
Ali Yousefi
e254593616
docs: replace the example app using electron ( #37805 )
...
* replace the example app using electron
* Update README.md
Remove the trailing space to pass linter. Suggested by @jkleinsc. Thank you @jkleinsc for the suggestion.
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 10:56:17 -04:00
Samuel Attard
fd2861117e
fix: correctly track receiver for methods called via ctx bridge ( #39978 )
...
* fix: correctly track receiver for methods called via ctx bridge
* spec: test for correct contextBridge passage
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-18 10:21:42 -04:00
Shelley Vohr
5b105f911f
chore: implement no-op chrome.action extension APIs ( #40222 )
...
chore: implement no-op chrome.action extension APIs
2023-10-18 10:19:31 -04:00
John Kleinschmidt
29270f3df5
test: fixup node force colors test ( #40241 )
...
* test: fixup node force colors test
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-18 12:33:24 +02:00
Milan Burda
657e88b173
chore: remove deprecated crashed and renderer-process-crashed events ( #40115 )
2023-10-18 12:05:41 +02:00
David Sanders
09bab60a9e
docs: fix represented file fiddle ( #40233 )
2023-10-18 11:32:10 +02:00
Shelley Vohr
666907d50d
fix: Windows Toast notification dismissal from Action Center ( #40197 )
...
* fix: Windows Toast notification dismissal from Action Center
* docs: note Toast behavior in event
* chore: address feedback from review
2023-10-17 19:33:00 -04:00
Shelley Vohr
73a42d0b7b
refactor: partition HidDelegate observers by browser context ( #40215 )
2023-10-17 16:54:53 -04:00
Keeley Hammond
f65d1f3d55
build: re-enable partition alloc on mac ( #33981 )
2023-10-17 11:18:39 +09:00
Christian Bromann
ba4d6d08a7
docs: Update docs on testing Electron apps with WebdriverIO ( #40083 )
2023-10-16 12:23:44 -07:00
Samuel Attard
b6ec19a582
fix: support the throwIfNoEntry option to statSync and lstatSync in asar files ( #40221 )
2023-10-16 09:35:25 -07:00
Shelley Vohr
f7b1c75c72
feat: update app.{set|get}LoginItemSettings(settings) ( #37244 )
...
* feat: update app.{set|get}LoginItemSettings(settings)
* test: fixup and add tests
* docs: add type link
* chore: name -> serviceName
2023-10-16 12:25:11 -04:00
electron-roller[bot]
6d0d350e13
chore: bump node to v18.18.2 (main) ( #40205 )
...
* chore: bump node in DEPS to v18.18.2
* chore: update patches
* deps: update nghttp2 to 1.55.0
https://github.com/nodejs/node/pull/48746
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-16 17:13:35 +02:00
Shelley Vohr
f362e089b1
fix: incorrect wco bounds in macOS fullscreen ( #40179 )
2023-10-16 11:18:31 +02:00
Samuel Maddock
c9f6f15df6
refactor: use getter property for RFH ( #40200 )
2023-10-16 09:16:51 +09:00
Shelley Vohr
bbd2236bdd
fix: ensure MessagePorts get GCed when not referenced ( #40189 )
2023-10-13 22:09:28 +02:00
David Sanders
5d6023ae0d
docs: fix some string union typings ( #40180 )
2023-10-13 12:00:44 +02:00
Max Tower
dc4476d480
docs: rename renderer.d.ts in documentation ( #40137 )
...
Rename renderer.d.ts
This doesn't compile when the declaration name has the same root name as the TS file.
https://github.com/Microsoft/TypeScript/issues/7624#issuecomment-202501572
https://stackoverflow.com/questions/59728371/typescript-d-ts-file-not-recognized
2023-10-13 11:31:50 +02:00
David Sanders
ce4ae584e3
docs: update supported Linux versions ( #40177 )
2023-10-12 14:56:28 -04:00
Milan Burda
344f8fd384
chore: formally deprecate gpu-process-crashed event ( #40169 )
2023-10-12 14:53:52 -04:00
Shelley Vohr
592a30aa0b
build: remove native specs ( #40190 )
2023-10-12 14:51:59 -04:00
Athul Iddya
3c31246343
fix: store portal restore token under the right source ID ( #40098 )
...
XDG Desktop Portal provides restore tokens to restore a previously
selected PipeWire stream instead of prompting the user again. This
restore token is single use only and it has to be replaced when the
stream is completed/stopped.
BaseCapturerPipewire maintains two source IDs: one is initialized by
the constructor for new sources (source_id_) and another is for
capturing previously selected sources (selected_source_id_). The
restore token was always being stored under `source_id_`, even if the
capture was ongoing for `selected_source_id_`. This prevents a stream
from being restored more than once. Fix that by storing the restore
token under the selected source ID if it exists.
2023-10-12 13:17:27 +02:00
electron-roller[bot]
7ab2a82166
chore: bump node to v18.18.1 (main) ( #40174 )
...
* chore: bump node in DEPS to v18.18.1
* Revert "deps: upgrade to libuv 1.46.0"
https://github.com/nodejs/node/pull/50036
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-12 09:53:37 +02:00
Shelley Vohr
5c821d3379
fix: webContents.capturePage() for hidden windows on Windows/Linux ( #39730 )
2023-10-12 09:35:23 +02:00
Milan Burda
3e70692e4b
chore: formally deprecate crashed and renderer-process-crashed events ( #40089 )
2023-10-10 19:49:01 -04:00
Keeley Hammond
c892c61b90
docs: update dates for E28 ( #40154 )
...
* docs: update dates for E28
* docs: update node version
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-10 19:43:35 -04:00
Milan Burda
2c88626b51
chore: revert deprecate as an internal module ( #40146 )
...
Revert "chore: restore deprecate as an internal module (#40124 )"
This reverts commit 737e3de3fa .
2023-10-10 11:50:47 -04:00
Shelley Vohr
7e312c81ca
test: make capturePage color matching timeouts consistent ( #40158 )
2023-10-10 11:13:07 -04:00
Shelley Vohr
86df4db6f1
fix: crash when calling non-reentrant function in loadURL ( #40143 )
2023-10-10 12:46:04 +02:00
Milan Burda
563c370d51
refactor: use gin_helper::Dictionary::CreateEmpty() helper ( #40140 )
2023-10-10 12:45:44 +02:00
Jade Flute
47beca1d2a
docs: fix typo in session docs ( #40138 )
...
Fix typos for doc
Signed-off-by: zhangdiandian <1635468471@qq.com >
2023-10-10 12:43:18 +02:00
Tomasz
925e4f7d74
feat: Add 'mouse-enter' and 'mouse-leave' Tray events for Windows. ( #40072 )
2023-10-09 19:56:38 -04:00
John Kleinschmidt
a31deea1ba
ci: fixup diagnose_goma_log.py call ( #40131 )
2023-10-09 15:19:21 +02:00
Milan Burda
24bc0ee5c7
test: fix "crashed event does not crash main process when destroying WebContents in it" ( #40135 )
2023-10-09 09:56:48 +02:00
Cheng Zhao
f5c177698e
fix: remove EarlyMallocZoneRegistration call ( #40128 )
2023-10-09 09:43:51 +09:00
Milan Burda
737e3de3fa
chore: restore deprecate as an internal module ( #40124 )
...
* Revert "refactor: don't expose deprecate as an internal module (#35311 )"
This reverts commit 8424779906 .
* check crashed event warnings
2023-10-09 08:55:16 +09:00
David Sanders
8b8fbd0408
test: add back smoke test for removed API ( #40132 )
2023-10-09 08:46:56 +09:00
Milan Burda
6a99c7b840
refactor: eliminate duplicate code ( #40088 )
2023-10-09 08:43:50 +09:00
Keeley Hammond
cff50ac65a
fix: fix vibrancy applying without transparency on MacOS ( #40109 )
2023-10-06 11:57:26 -07:00
github-actions[bot]
a55c163db0
build: update appveyor image to latest version - e-119.0.6045.0 ( #40075 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-06 11:47:17 -04:00
Robo
fdf8b02e14
chore: cherry-pick c03569f from libuv ( #40101 )
...
Refs c03569f0df
2023-10-06 19:25:19 +09:00
Shelley Vohr
73553032ea
fix: toggling DevTools while minimized on Windows ( #40091 )
...
fix: toggling devtools while minimized on Windows
2023-10-05 20:26:31 -04:00
electron-roller[bot]
8f7a48879e
chore: bump chromium to 119.0.6045.0 (main) ( #40076 )
...
* chore: bump chromium in DEPS to 119.0.6045.0
* chore: update patches
* 4864948: Remove legacy-legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4864948
* 4907760: Remove ui/base/glib/glib_signal.h
https://chromium-review.googlesource.com/c/chromium/src/+/4907760
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-05 19:59:39 -04:00
Milan Burda
83a928f6e3
fix: crashed events deprecation ( #40090 )
2023-10-05 19:57:14 -04:00
Shelley Vohr
3392d9a2e7
fix: all children showing when showing child window ( #40062 )
2023-10-05 09:19:57 -04:00
David Sanders
5ad69df52e
build: update NMV to 119 ( #40081 )
2023-10-05 09:14:02 -04:00
Shelley Vohr
b3a1c6d13c
fix: error using webcrypto.subtle.importKey() ( #40070 )
...
fix: error using webcrypto.subtle.importKey()
2023-10-05 10:46:53 +02:00
Shelley Vohr
b0590b6ee8
fix: failing build with enable_electron_extensions=false ( #40032 )
...
* fix: ENABLE_EXTENSIONS -> ENABLE_ELECTRON_EXTENSIONS
* fix: extension guard fixes
* chore: fix linker errors
2023-10-04 10:40:01 +02:00
Shelley Vohr
713d8c4167
feat: add tabbingIdentifier property to BrowserWindow ( #39980 )
...
feat: add tabbingIdentifier property to BrowserWindow
2023-10-03 12:27:40 -07:00
Milan Burda
04b2ba84cd
refactor: replace remaining NULL with nullptr ( #40053 )
...
refactor: use nullptr everywhere
2023-10-03 12:26:35 -07:00
electron-roller[bot]
9d0e6d09f0
chore: bump chromium to 119.0.6043.0 (main) ( #40045 )
...
* chore: bump chromium in DEPS to 119.0.6036.0
* chore: bump chromium in DEPS to 119.0.6037.0
* chore: bump chromium in DEPS to 119.0.6039.0
* chore: bump chromium in DEPS to 119.0.6041.0
* chore: update chromium patches
* 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230
* 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325
* chore: update all patches
* chore: bump chromium in DEPS to 119.0.6043.0
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* 4837192: Plumb origin through for drags.
https://chromium-review.googlesource.com/c/chromium/src/+/4837192
* Prevent content analysis on web pages that don't accept drag and drop.
https://chromium-review.googlesource.com/c/chromium/src/+/4814086
* Make getting displayed notifications work with notification attribution.
https://chromium-review.googlesource.com/c/chromium/src/+/4738935
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* chore: remove Goma warning from mksnapshot_args
* 4776412: Remove Windows-specific wstring variants of StringPrintf() etc.
https://chromium-review.googlesource.com/c/chromium/src/+/4776412
* [dPWA] Prevent WebAppInstallInfo from being included on Android
https://chromium-review.googlesource.com/c/chromium/src/+/4886594
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-02 18:01:07 -04:00
github-actions[bot]
503ae86ab2
build: update appveyor image to latest version - e-119.0.6029.0 ( #40046 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-02 11:11:07 -04:00
Athul Iddya
37c79ea844
docs: add PipeWire integration instructions for snaps ( #40019 )
2023-10-02 12:19:23 +02:00
Shelley Vohr
93bcb30c3e
fix: BroadcastChannel initialization location ( #40049 )
...
fix: `BroadcastChannel` initialization location (#37421 )
* fix: BroadcastChannel initialization location
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-02 10:57:09 +02:00
Milan Burda
d301616f60
chore: remove deprecated app.runningUnderRosettaTranslation() ( #39956 )
2023-10-02 10:55:32 +02:00
Shelley Vohr
5643e86956
chore: update extensions url handling to match upstream ( #40038 )
...
- https://chromium-review.googlesource.com/c/chromium/src/+/4772028
- https://chromium-review.googlesource.com/c/chromium/src/+/4264656
- https://chromium-review.googlesource.com/c/chromium/src/+/4712150
2023-10-02 10:35:00 +02:00
Samuel Attard
371e83a8d2
fix: support esm entrypoint to utility process ( #40047 )
2023-09-29 14:38:37 -07:00
electron-roller[bot]
d6c8ff2e70
chore: bump chromium to 119.0.6029.0 (main) ( #39944 )
...
* chore: bump chromium in DEPS to 119.0.6021.0
* 4727729: Initial ScreenCaptureKit AudioInputStream implementation
https://chromium-review.googlesource.com/c/chromium/src/+/4727729
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6023.0
* 4875713: mac: Switch to Xcode 15.0 15A240d with macOS SDK 14.0 23A334
https://chromium-review.googlesource.com/c/chromium/src/+/4875713
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4877868: Remove all gitignore entries for submodules
https://chromium-review.googlesource.com/c/chromium/src/+/4877868
* 4824705: Set origin to commit for data: URLs
https://chromium-review.googlesource.com/c/chromium/src/+/4824705
* chore: fixup patch indices
* 4881382: Expose selection in WebFormControlElement as unsigned
https://chromium-review.googlesource.com/c/chromium/src/+/4881382
* 4874216: Portals: Cancel drag-drop in predecessor before activation
https://chromium-review.googlesource.com/c/chromium/src/+/4874216
* chore: bump chromium in DEPS to 119.0.6025.0
* chore: bump chromium in DEPS to 119.0.6027.0
* 4884489: Update gitignore to be explicit about directories
https://chromium-review.googlesource.com/c/chromium/src/+/4884489
* 4881091: Add debug info about owner document's origin when inheriting
https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6029.0
* chore: update patches
* 4881091: Add debug info about owner document's origin when inheriting
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4866732: Extract document.title for installable checks
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4866732
* chore: link to crbug in message port test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-28 22:26:41 -07:00
ILikeTeaALot
d002f16157
feat: systemPreferences.getColor should return RGBA instead of RGB ( #38960 )
...
* fix: return RGBA hex value from `SystemPreferences.getColor`
* docs: update docs to match changes of last commit
* fix: GetColor on windows now returns RGBA too
* fix: update tests for getColor RGBA on Windows
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-28 18:56:16 -04:00
Bruno Pitrus
dd7395ebed
chore: add missing include for std::variant ( #40007 )
2023-09-28 12:50:58 -04:00
Bruno Pitrus
e3e793d25b
chore: remove invalid constexpr qualification ( #40006 )
...
GetPathConstant calls base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::find(Key const&) const which is not constexpr.
GCC 12 and earlier raise a compile error on this.
2023-09-28 12:49:09 -04:00
dependabot[bot]
da92c9aa27
build(deps): bump get-func-name from 2.0.0 to 2.0.2 in /spec ( #40012 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 12:47:36 -04:00
David Sanders
02b58333dc
ci: update release project board workflows ( #40020 )
2023-09-28 11:27:02 -04:00
David Sanders
23cf9fa4e9
ci: update automation workflows ( #40021 )
2023-09-28 11:26:04 -04:00
Cheng Zhao
4cf6884dd4
fix: detect screen readers by testing their existences ( #39988 )
2023-09-28 11:17:42 -04:00
marekharanczyk
94585f5889
fix: propagate layout call to all children of InspectableWebContentsViewViews ( #39994 )
...
Propagate layout call to all children of InspectableWebContentsViewViews.
When BrowserView bounds are set from js, those might not trigger layout
immediately, sometimes propagating InvalidateLayout call to parent.
View is marked as needing layout, expecting to receive it from parent on
next layout call. The problem is that BrowserView's view is added as child
of InspectableWebContentsViews which does not call setBounds (which
would trigger layout) on all of it's children when doing it's layout,
so it skips propagating Layout call to its children BrowserViews views,
even though those were marked as needing layout.
Call base class View::Layout which will iterate over views' children
and call Layout on those that were marked as needing them.
Fixes #39993 .
2023-09-28 11:17:21 -04:00
John Kleinschmidt
43a646ed85
build: log uploads to GitHub ( #40034 )
2023-09-28 11:15:52 -04:00
dependabot[bot]
f628ce67dd
build(deps): bump get-func-name from 2.0.0 to 2.0.2 ( #40013 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 10:44:16 +02:00
Shelley Vohr
c8156c3c57
fix: failure on immutable webContents.print(options) ( #39985 )
...
fix: failure on immutable webContents.print(options)
2023-09-28 10:41:46 +02:00
Tomasz
689d1b76de
feat: add middle click event to tray ( #39926 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:21:15 -04:00
Robert Günzler
480f48b2fc
feat: enable dark mode on GTK UIs ( #38977 )
...
feat: port DarkModeManagerLinux
This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903
and replaces the previous workaround to detect dark mode on GTK.
Detect system dark theme preference via xdg settings portal:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings
Closes: https://github.com/electron/electron/issues/38961
Closes: https://github.com/electron/electron/issues/28838
Signed-off-by: Robert Günzler <r@gnzler.io >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:17:40 -04:00
Erick Zhao
a0ae691a9c
docs: document type-specific module aliases ( #39685 )
2023-09-27 11:07:04 -04:00
Bruno Henrique da Silva
f943b8c940
fix: set window contents as opaque to decrease DWM GPU usage ( #39895 )
...
* set window contents as opaque to decrease DWM GPU usage
* chore: add more context to ShouldWindowContentsBeTransparent
2023-09-27 10:42:46 -04:00
Shelley Vohr
b7c9c895b5
build: fix with enable_pdf_viewer = false ( #39990 )
...
build: fix with enable_pdf_viewer = false
2023-09-27 10:09:53 -04:00
Shelley Vohr
1ba321b733
fix: rounded corners on vibrant macOS modals ( #39979 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 15:12:37 +02:00
Cheng Zhao
ad57867594
fix: apply size constraints to NSWindow ( #39975 )
2023-09-27 11:11:24 +02:00
Cheng Zhao
e613595982
build: allow overriding electron version ( #39974 )
2023-09-27 14:49:10 +09:00
NoxFly
624ae024e2
docs: Quick Start | Electron Forge chapter requirements updated ( #39639 )
...
* Update quick-start.md
Added a note to a pre-require of Electron Forge.
Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild`
* Add two required steps for Electron Forge to build without errors
* Update docs/tutorial/quick-start.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-09-27 08:56:39 +09:00
michal-pichlinski-openfin
2190793fe6
fix: disable background throttling also in the viz::DisplayScheduler ( #38924 )
...
* fix: disable background throttling also in the `viz::DisplayScheduler`
`viz::DisplayScheduler` is responsible for drawing and swapping frames
in the `DisplayScheduler::DrawAndSwap` which is called from the
`DisplayScheduler::AttemptDrawAndSwap` if the `DisplayScheduler::ShouldDraw`
returns true. `ShouldDraw` depends on the `DisplayScheduler` visibility
and when it is not visible then it returns false.
In order to keep producing frames, disabling `backgroundThrottling`
should also prevent changing `DisplayScheduler` visibility to false.
`DisplayScheduler` lives in the `ui::Compositor` where every
`electron::NativewWindow` has its own `Compositor`. `electron::NativewWindow`
may be host of the multiple `electron::api::WebContents` instances which may
have different `WebPreferences` settings. Therefore if at least one
of the `WebContents` requires disabling throttling then all other `WebContents`
using the same window will have it disabled in the `ui::Compositor`.
BREAKING CHANGE:
`backgroundThrottling` set to false will disable frames throttling
in the `BrowserWindow` for all `WebContents` displayed by it.
Close: [#31016 ](https://github.com/electron/electron/issues/31016 )
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-26 16:00:46 -04:00
Milan Burda
fa215f1009
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md ( #39897 )
...
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md
2023-09-26 13:42:56 -04:00
John Kleinschmidt
943bfa89ce
test: fixup parallel/test-node-output-error test ( #39972 )
2023-09-25 16:23:05 -04:00
Milan Burda
d75a852743
refactor: use type enum in file stats for asar archive ( #39889 )
2023-09-25 13:17:24 +02:00
David Sanders
18f517d8a6
test: vendor node-is-valid-window ( #39965 )
2023-09-25 12:43:57 +02:00
Leon
fdf1ecec47
docs: correct v24 Alpha date ( #39963 )
2023-09-24 23:03:29 -07:00
John Kleinschmidt
beb52ce61c
build: update patch ( #39950 )
2023-09-22 10:33:29 -07:00
Erick Zhao
2085aae915
docs: esm tutorial ( #39722 )
...
* docs: esm tutorial
* Update esm.md
* Update docs/tutorial/esm.md
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
* table adjustment
* fix lint
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update esm.md
---------
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-22 09:49:16 -07:00
Fredy Whatley
7c2df8860b
docs: tiny update on example message-ports.md ( #39884 )
...
Update message-ports.md
fix multiplying object * a number. It would multiply number * number.
2023-09-21 11:46:23 -04:00
github-actions[bot]
56e45baeb8
build: update appveyor image to latest version - e-119.0.6019.2 ( #39924 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-21 09:49:04 -04:00
Robo
5f712fa325
chore: cherry-pick tls shutdown crash fix from upstream ( #39928 )
2023-09-21 09:47:31 -04:00
John Kleinschmidt
ba8915242a
ci: fix linux builds of forks ( #39933 )
2023-09-21 12:10:46 +02:00
Milan Burda
c9eb3deab5
chore: remove deprecated scroll-touch-{begin,end,edge} events ( #39814 )
...
* chore: remove deprecated `scroll-touch-{begin,end,edge}` events
* update spec/ts-smoke
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 17:41:29 -04:00
Valentin Hăloiu
58fd8825d2
fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var ( #39792 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 16:21:23 -04:00
Milan Burda
6a8b70639b
fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 ( #39920 )
...
fix: app.runningUnderARM64Translation() always returning true on ARM64
2023-09-20 16:15:19 -04:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:13:43 -04:00
electron-roller[bot]
28eda03aba
chore: bump chromium to 119.0.6019.2 (main) ( #39925 )
...
* chore: bump chromium in DEPS to 119.0.6018.4
* chore: update patches
* chore: bump chromium in DEPS to 119.0.6019.2
* chore: update patches
* 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4876292
* 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts
https://chromium-review.googlesource.com/c/chromium/src/+/4851616
* 4869393: [Extensions UserScripts] Add error messages for script matching errors
https://chromium-review.googlesource.com/c/chromium/src/+/4869393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:08:26 -04:00
George Xu
7685f27b31
feat: expose app accessibility transparency settings api ( #39631 )
...
* feat: expose app accessibility transparency settings api
* docs: fix typo
* chore: add doc
* change to property
* add as property instead of method
* chore: fix lint
* rename function name in header
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-20 12:48:02 -07:00
Shelley Vohr
463586a6c5
chore(deps): roll nan to pick up upstreams ( #39916 )
2023-09-20 15:37:10 +02:00
electron-roller[bot]
a39c0ee659
chore: bump chromium to 119.0.6017.0 (main) ( #39922 )
...
* chore: bump chromium in DEPS to 119.0.6017.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-20 11:30:38 +02:00
github-actions[bot]
0b0a8a5ef3
build: update appveyor image to latest version, e-119.0.6006.0 ( #39908 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-19 23:46:47 -07:00
electron-roller[bot]
986becdb4d
chore: bump chromium to 119.0.6016.0 (main) ( #39898 )
...
* chore: bump chromium in DEPS to 119.0.6016.0
* chore: update patches
* 4839124: Rename chrome/app/ branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/4839124
* 4846834: Clean up PrintRenderFrameHelper interaction with Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/4846834
* 4850759: Cache bounds of document pip windows
https://chromium-review.googlesource.com/c/chromium/src/+/4850759
* 4864669: Roll libc++ from 84fb809dd6da to 68a6f0b88287 (352 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4864669
* 4863987: Remove five gpu workarounds.
https://chromium-review.googlesource.com/c/chromium/src/+/4863987
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-19 19:34:56 +02:00
Samuel Attard
75ea294b6f
build: use afs on aks instead of circle cache ( #39881 )
...
* build: use afs on aks instead of circle cache
* build: do not use aks logic on linux hosts checking out for macOS
* build: fix gn-check could-be-aks
* build: sigh
* build: no ls mnt
* build: keep build alive while debugging
* build: make debuggable
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-19 03:12:14 -07:00
spencer17x
18717ee62d
docs: add a more detailed explanation to cookies.flushStore() ( #37572 )
...
* docs: cookies.flushStore()
* docs: modify cookies.flushStore()
* Update docs/api/cookies.md
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-18 16:51:46 -04:00
electron-roller[bot]
73e33bc876
chore: bump chromium to 119.0.6006.0 (main) ( #39774 )
...
* chore: bump chromium in DEPS to 119.0.5994.0
* chore: update patches
* Add some more debugging for navigation origin & process lock mismatch
https://chromium-review.googlesource.com/c/chromium/src/+/4829483
* chore: bump chromium in DEPS to 119.0.5996.2
* chore: bump chromium in DEPS to 119.0.5997.0
* chore: bump chromium in DEPS to 119.0.6000.0
* chore: bump chromium in DEPS to 119.0.6002.0
* 4781766: Port remaining control color ids to the color pipeline
https://chromium-review.googlesource.com/c/chromium/src/+/4781766
* 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/
https://chromium-review.googlesource.com/c/chromium/src/+/4846057
* chore: fixup patch indices
* 4848108: Pass v8::Isolate into FromV8Value calls on blink API
https://chromium-review.googlesource.com/c/chromium/src/+/4848108
* 4834471: Reland "[api] allow v8::Data as internal field"
https://chromium-review.googlesource.com/c/v8/v8/+/4834471
* 4808884: Major overhaul of ExceptionState in the v8 bindings
https://chromium-review.googlesource.com/c/chromium/src/+/4808884
* 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap
https://chromium-review.googlesource.com/c/v8/v8/+/4791643
* chore: bump chromium in DEPS to 119.0.6005.0
* 4776268: [v8][etw] Enables filtering of ETW tracing by URL
https://chromium-review.googlesource.com/c/chromium/src/+/4776268
* chore: fixup patch indices
* 4673258: WebSQL: Disable WebSQL by default
https://chromium-review.googlesource.com/c/chromium/src/+/4673258
* chore: bump chromium in DEPS to 119.0.6006.0
* chore: update patches
* 4854732: Reland^2 "[iterator-helpers] Unship due to incompat"
https://chromium-review.googlesource.com/c/v8/v8/+/4854732
* 4794133: [AWC] Add `display-state` CSS @media feature
https://chromium-review.googlesource.com/c/chromium/src/+/4794133
* fixup! Add some more debugging for navigation origin & process lock mismatch
* Revert "fixup! Add some more debugging for navigation origin & process lock mismatch"
This reverts commit 38fef075fc .
* 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks"
https://chromium-review.googlesource.com/c/chromium/src/+/4858437
* refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879 )
* chore: 4869108: handle absolute and relative gn imports in autoninja
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108
* chore: set GOMA_DIR for autoninja
* Revert "chore: 4869108: handle absolute and relative gn imports in autoninja"
This reverts commit d94c7720ba .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com >
2023-09-18 16:44:09 -04:00
John Kleinschmidt
c8544e25df
build: fixup autoninja ( #39896 )
...
chore: set GOMA_DIR for autoninja
(cherry picked from commit 94f24bde4d )
(cherry picked from commit 90c1f6e1cb8d22d94dd01791dc4b9c3e0a7e86fc)
2023-09-18 16:43:27 -04:00
Milan Burda
9c7086074e
docs: add missing ipcRenderer.off() / ipcRenderer.addListener() aliases ( #39816 )
...
* docs: add missing `ipcRenderer.off()` / `ipcRenderer.addListener()` aliases
* Update docs/api/ipc-renderer.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix ipcRenderer.removeListener
* update ts-smoke
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-19 01:58:20 +09:00
Milan Burda
d7e4bb6608
chore: remove no-op fullscreenWindowTitle option ( #39815 )
2023-09-19 01:55:47 +09:00
David Sanders
706653d5e4
ci: fix issue-commented workflow sytnax ( #39875 )
2023-09-17 19:23:59 -07:00
John Kleinschmidt
65952abc99
test: fixup node flakes ( #39871 )
...
chore: fixup node flakes
2023-09-15 03:43:13 -07:00
Athul Iddya
50ce02c312
fix: check PipeWire init before creating generic capturer ( #39846 )
...
Check if PipeWire can be initialized before creating generic capturer.
This harmonizes the conditions with the ones used in Linux
implementations of DesktopCapturer::CreateRawScreenCapturer and
DesktopCapturer::CreateRawWindowCapturer.
2023-09-14 15:50:20 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
David Sanders
d6c04a3787
ci: ignore actions taken by triage bot ( #39855 )
...
* ci: ignore actions taken by triage bot
* ci: don't remove blocked label on bot comment
2023-09-14 14:01:07 -04:00
Samuel Attard
2791474a01
build: run on circle hosts for forks ( #39858 )
2023-09-14 11:07:11 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
David Sanders
650ef9a51c
build: update @electron/lint-roller to 1.9.0 ( #39812 )
2023-09-12 12:38:31 +02:00
Charles Kerr
a1c44a18e2
fix: NodeService order-of-destruction issue ( #39783 )
...
* refactor: make ElectronRendererClient::node_bindings_ a const ptr
refactor: make ElectronRendererClient::electron_bindings_ a const ptr
* fix: order-of-destruction bug in NodeService
js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_
* chore: revert unintentional commit
2023-09-12 12:27:14 +02:00
Shelley Vohr
ec9c8476fe
fix: keyCodes being incorrectly converted in webContents.sendInputEvent() ( #39776 )
...
fix: sendInputEvent keyCodes being incorrectly converted
2023-09-12 11:28:45 +02:00
Samuel Attard
470a14d8d4
docs: add missing macOS tag
2023-09-11 14:07:25 -07:00
Samuel Attard
5bff0fe342
feat: add new ElectronSquirrelPreventDowngrades flag ( #38625 )
...
* sketch
* feat: add new ElectronSquirrelPreventDowngrades flag
* test: remove only
* chore: fix lint
2023-09-11 11:54:51 -07:00
Samuel Attard
16aec702b4
fix: ensure app load is limited to real asar files when appropriate ( #39788 )
2023-09-11 11:51:14 -07:00
Samuel Attard
ac040bf734
build: update @electron/typescript-definitions to fix titlebaroverlay ( #39799 )
...
build: update @electron/typescript-definitions to fix titlebarstyle
2023-09-11 11:36:36 -07:00
David Sanders
aceb432f45
chore: remove deprecated systemPreferences APIs ( #39696 )
2023-09-11 11:34:13 -04:00
Calvin
d182794179
fix: frameless mica/acrylic windows ( #39708 )
...
* fix: backgroundMaterial works with frameless
* TODO: fix frameless mica/acrylic windows
* update caption color appropriately
* set background color properly
* refactor translucency method
* actualization
2023-09-11 14:51:54 +02:00
Shelley Vohr
ab185c058f
fix: fullscreen crashing with no roundedCorners and no frame ( #39747 )
2023-09-11 09:38:10 +02:00
David Sanders
2324c4d8fd
ci: ignore blocked label removed on closed issues ( #39793 )
2023-09-11 09:33:39 +02:00
Charles Kerr
792037b338
fix: raw_ptr destruction order in NodeBindings ( #39762 )
2023-09-07 18:25:17 -05:00
Samuel Attard
0b44f433c8
fix: make titlebar opaque while fullscreen ( #39759 )
2023-09-07 15:55:17 -07:00
github-actions[bot]
5fa9dee68a
build: update appveyor image to latest version e-118.0.5993.0 ( #39765 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-07 09:40:42 -04:00
Shelley Vohr
75bad34131
fix: prevent errors when extensions listen for chrome.tabs events ( #39729 )
...
* fix: prevent errors when extensions listen for chrome.tabs events
* chore: mark events unsupported in Electron
2023-09-07 12:41:24 +02:00
Robo
0a064cece9
fix: devtools allow restoring saved dock state on Windows ( #39734 )
...
* fix: devtools allow restoring saved dock state on Windows
* chore: address feedback
2023-09-07 17:14:01 +09:00
Milan Burda
f6e8544ef6
refactor: use replaceAll() instead of replace() when appropriate ( #39721 )
...
refactor: use replaceAll() instead of replace() when appropriate
2023-09-07 15:50:14 +09:00
electron-roller[bot]
029127a8b6
chore: bump chromium to 118.0.5993.0 (main) ( #39745 )
...
* chore: bump chromium in DEPS to 118.0.5993.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-06 19:27:25 -04:00
Milan Burda
e71a56d11e
refactor: const Module = require('module') as NodeJS.ModuleInternal; ( #38757 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-09-06 18:04:25 -04:00
Samuel Attard
65901f4c6a
fix: restore flag that allowed websockets to not be backgrounded ( #39738 )
2023-09-06 11:23:17 -07:00
github-actions[bot]
feb804cea8
build: update appveyor image to latest version ( #39716 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-06 14:07:34 -04:00
Shelley Vohr
34b79c15c2
build: fix depot_tools patch application ( #39742 )
...
build: fix depot_tools patch application
2023-09-06 07:49:00 -04:00
electron-roller[bot]
d9ba26273a
chore: bump chromium to 118.0.5991.0 (main) ( #39714 )
...
* chore: bump chromium in DEPS to 118.0.5982.0
* chore: bump chromium in DEPS to 118.0.5983.0
* chore: bump chromium in DEPS to 118.0.5985.0
* chore: bump chromium in DEPS to 118.0.5987.0
* chore: update v8 patches
* chore: update chromium patches
* chore: update patches
* [PEPC] Add new structs to contain permission request data
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4756727
* Add ThumbnailCapturer interface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4812256
* Reland "[ChromeRefresh2023] Update document pip windows for Chrome Refresh"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4814275
* chore: bump chromium in DEPS to 118.0.5989.0
* chore: bump chromium in DEPS to 118.0.5991.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-05 21:17:56 -04:00
David Sanders
c96bb9958f
chore: remove deprecated webContents.getPrinters() ( #39663 )
2023-09-05 10:16:41 +02:00
Milan Burda
d76a35afe4
test: remove a few casts to any ( #39713 )
2023-09-05 11:22:41 +09:00
Milan Burda
c5b20eeb13
test: add missing tests to api-web-frame-spec.ts ( #39720 )
...
test: add missing tests to spec/api-web-frame-spec.ts
2023-09-05 11:20:58 +09:00
John Kleinschmidt
4cc0f6fb78
test: fix flaky content tracing test ( #39682 )
2023-09-04 14:08:26 +02:00
Milan Burda
f27b034045
test: convert a few more specs to async/await ( #39712 )
2023-09-04 12:33:29 +02:00
Shelley Vohr
54d8402a6c
fix: broken chrome.scripting compilation ( #39725 )
...
fix: broken chrome.scripting impl after roll
2023-09-04 16:03:10 +09:00
Samuel Attard
89659fa9c9
chore: fix broken patches on main ( #39715 )
2023-09-01 01:28:01 -07:00
electron-roller[bot]
89117fdd99
chore: bump chromium to 118.0.5975.0 (main) ( #39531 )
...
* chore: bump chromium in DEPS to 118.0.5951.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4727894
No logic changes, but patch needed to be manually re-applied due to upstream code shear
* chore: update port_autofill_colors_to_the_color_pipeline.patch
No manual changes; patch applied with fuzz
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5953.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5955.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5957.0
* chore: update patches
* chore: include path of native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
* chore: remove reference to eextensions/browser/notification-types.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4771627
* chore: update references to renamed upstream field NativeWebKeyboardEvent.skip_if_unhandled (formerly known as skip_in_browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
Need a second pair of eyes on this commit. In particular the reference in content_converter.cc, skipInBrowser, seems to not be set or documented anywhere? Is this unused/vestigal code?
* chore: sync signature of ElectronExtensionsBrowserClient::IsValidContext() to upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4784198
* chore: add auto_pip_setting_helper.[cc,h] to chromium_src build
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4688277
Exiting upstream code used by chromium_src now depends on this new upstream class
* chore: bump chromium in DEPS to 118.0.5959.0
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
manually adjust patch to minor upstream chagnes
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5961.0
* chore: bump chromium in DEPS to 118.0.5963.0
* chore: update patches
* 4780994: Rename various base files to "apple" since iOS uses them too
https://chromium-review.googlesource.com/c/chromium/src/+/4780994
* Many files moved from `mac` -> `apple`
This commit follows a handful of CLs that simply rename files/symbols to change `mac`
to `apple`
to signify their use across both macOS and iOS:
- 4784010: Move scoped_nsautorelease_pool to base/apple, leave a forwarding header
- 4790744: Move foundation_util to base/apple, leave a forwarding header
- 4790741: Move scoped_cftypreref to base/apple, leave a forwarding header
- 4787627: Move and rename macOS+iOS base/ files in PA to "apple"
- 4780399: Move OSStatus logging to base/apple
- 4787387: Remove forwarding headers
- 4781113: Rename message_pump_mac to "apple" because iOS uses it too
* fixup minor patch update error
A function param got dropped from this patch somewhere earlier
* chore: bump chromium in DEPS to 118.0.5965.2
* chore: update patches
* 4799213: Move ScopedTypeRef and ScopedCFTypeRef into base::apple::
https://chromium-review.googlesource.com/c/chromium/src/+/4799213
* Fix removed include to BrowserContext
In crrev.com/c/4767962 an include to BrowserContext was removed,
which was necessary for compilation. This broke only for us because
"chrome/browser/profiles/profile.h" includes that class, but we remove
all references to profiles.
* chore: bump chromium in DEPS to 118.0.5967.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5969.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5971.0
* chore: bump chromium in DEPS to 118.0.5973.0
* chore: update patches
* 4772121: [OOPIF PDF] Replace PDFWebContentsHelper with PDFDocumentHelper
https://chromium-review.googlesource.com/c/chromium/src/+/4772121
* 4811164: [Extensions] Do some cleanup in ChromeManagementAPIDelegate.
https://chromium-review.googlesource.com/c/chromium/src/+/4811164
* 4809488: Remove duplicate dnd functionality between Web and Renderer prefs
https://chromium-review.googlesource.com/c/chromium/src/+/4809488
Given that this is no longer an option of web preferences, we should
consider deprecating this option and then removing it.
* chore: bump chromium in DEPS to 118.0.5975.0
* chore: update patches
* fixup! chore: add auto_pip_settings_helper.{cc|h} to chromium_src build
* Reland "[windows] Remove RegKey::DeleteEmptyKey"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4813255
* Ensure StrCat means StrCat
Refs https://chromium-review.googlesource.com/c/chromium/src/+/1117180
* fixup! Remove RegKey::DeleteEmptyKey
* Consistently reject large p and large q in DH
Refs https://boringssl-review.googlesource.com/c/boringssl/+/62226
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-09-01 15:54:59 +09:00
Milan Burda
0b0707145b
refactor: replace .forEach() with for-of ( #39691 )
...
* refactor: replace `.forEach()` with `for-of`
* refactor docs/fiddles/features/web-hid/renderer.js
2023-08-31 23:36:43 +09:00
David Sanders
7858921a1f
docs: fix return typing of ses.getExtension ( #39697 )
2023-08-30 18:10:32 -07:00
Samuel Attard
ac031bf8de
feat: I guess it's esm ( #37535 )
...
* fix: allow ESM loads from within ASAR files
* fix: ensure that ESM entry points finish loading before app ready
* fix: allow loading ESM entrypoints via default_app
* fix: allow ESM loading for renderer preloads
* docs: document current known limitations of esm
* chore: add patches to support blending esm handlers
* refactor: use SetDefersLoading instead of JoinAppCode in renderers
Blink has it's own event loop so pumping the uv loop in the renderer is not enough, luckily in blink we can suspend the loading of the frame while we do additional work.
* chore: add patch to expose SetDefersLoading
* fix: use fileURLToPath instead of pathname
* chore: update per PR feedback
* fix: fs.exists/existsSync should never throw
* fix: convert path to file url before importing
* fix: oops
* fix: oops
* Update docs/tutorial/esm-limitations.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* windows...
* windows...
* chore: update patches
* spec: fix tests and document empty body edge case
* Apply suggestions from code review
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* spec: add tests for esm
* spec: windows
* chore: update per PR feedback
* chore: update patches
* Update shell/common/node_bindings.h
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: update patches
* rebase
* use cjs loader by default for preload scripts
* chore: fix lint
* chore: update patches
* chore: update patches
* chore: fix patches
* build: debug depshash
* ?
* Revert "build: debug depshash"
This reverts commit 0de82523fb .
* chore: allow electron as builtin protocol in esm loader
* Revert "Revert "build: debug depshash""
This reverts commit ff86b1243c .
* chore: fix esm doc
* chore: update node patches
---------
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
2023-08-30 17:38:07 -07:00
Erick Zhao
b8ac798344
docs: use node: imports for node core modules ( #39681 )
...
docs: use `node:` imports for node builtin modules
2023-08-30 11:55:23 -04:00
David Sanders
2182202e8e
ci: use new GitHub App for issue triage related actions ( #39635 )
2023-08-30 11:09:33 -04:00
Milan Burda
e66c1f6c56
refactor: generate 'chrome:// pages' specs to remove duplicate code ( #39684 )
2023-08-30 11:07:41 -04:00
Milan Burda
9280b79112
docs: enable contextIsolation in fiddles ( #39613 )
2023-08-29 15:52:16 -04:00
Milan Burda
2e79f34c84
docs: fix the minimum supported macOS version to Catalina ( #39667 )
...
docs: update the minimum supported macOS version to Catalina
2023-08-29 09:01:11 +09:00
Tomasz
f30fbebb98
fix: promise resolved to early when browser initiated in-page navigation v2 ( #39597 )
2023-08-28 12:37:28 -04:00
Shelley Vohr
f0ad357af2
feat: support chrome.scripting extension APIs ( #39395 )
...
feat: support chrome.scripting extension APIs
2023-08-28 10:39:28 -04:00
Milan Burda
5078cae861
chore: remove deprecated ipcRenderer.sendTo() ( #39087 )
...
chore: remove deprecated ipcRenderer.sendTo()
2023-08-28 10:29:27 -04:00
Robo
b5997a012d
chore: enable v8_enable_private_mapping_fork_optimization by default ( #39253 )
...
* chore: enable v8_enable_private_mapping_fork_optimization by default
* chore: cherry-pick 292a4a6 from v8
2023-08-28 10:16:20 -04:00
Shelley Vohr
f369b144d6
feat: add more extensions manifest key options ( #39599 )
...
feat: add more manifest key options
2023-08-28 10:02:22 -04:00
Milan Burda
f2f83a73fc
docs: use electron/main & electron/renderer imports in fiddles ( #39666 )
2023-08-28 20:23:10 +09:00
Shelley Vohr
d42a94ddde
fix: webview exiting fullscreen presentation mode ( #39616 )
2023-08-25 14:11:58 -04:00
David Sanders
3bdc7ce64a
ci: don't mark status/confirmed labeled issues as stale ( #39659 )
2023-08-25 14:09:28 -04:00
David Sanders
48e14bc54e
ci: fix deprecation review automation for PRs ( #39649 )
2023-08-25 14:09:12 -04:00
John Kleinschmidt
83760bd5c6
ci: explicitly use python3 to start goma ( #39650 )
...
* ci: explicitly use python3 to start goma
* ci: explicitly use python3 for goma
2023-08-24 21:43:24 -04:00
wanted002
e14964ccd0
feat: add setter and getter apis to specify udp port range for webrtc ( #39046 )
...
* feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042)
* lint error fix for PR#39046
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview
* fix lint error
* fix lint errors in file api-web-contents-spec.ts
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc
* fix lint error
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter
2023-08-24 17:21:22 -04:00
Athul Iddya
33000c4b42
feat: enable WaylandWindowDecorations by default ( #39582 )
2023-08-24 17:02:05 -04:00
Shelley Vohr
33e66b5cd0
fix: ensure windows respect fullscreenability with different resizability values ( #39620 )
...
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen
* test: add an extra resize test
2023-08-24 16:54:08 -04:00
Shelley Vohr
2affecd4dd
feat: allow generating accessible pdf with printToPDF ( #39563 )
...
* feat: allow generating accessible pdf with printToPDF
* docs: mark generateTaggedPDF experimental
2023-08-24 11:01:59 -04:00
Erick Zhao
381c955bca
docs: mention alternative tooling ( #39337 )
...
* docs: mention alternative tooling
* Update forge-overview.md
* Update forge-overview.md
2023-08-24 12:03:30 +02:00
Charles Kerr
35969939a1
refactor: node::Environment self-cleanup ( #39604 )
...
* chore: savepoint
* chore: turn raw_ptr tests back off
2023-08-23 09:56:16 -04:00
Shelley Vohr
a8999bc529
fix: ensure BrowserView bounds are always relative to window ( #39605 )
...
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
Shelley Vohr
522bba3dc6
chore: cleanup arc migration helpers ( #39606 )
2023-08-23 09:54:21 -04:00
Shelley Vohr
ddc7e3ebb3
fix: assert module in the renderer process ( #39540 )
2023-08-23 11:38:47 +02:00
Bruno Henrique da Silva
2481f94b4e
fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack ( #39074 )
...
return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack
2023-08-23 10:49:24 +02:00
Shelley Vohr
e1d63794e5
fix: chrome.tabs 'url' and 'title' are privileged information ( #39595 )
...
fix: tabs url and title are privileged information
2023-08-22 14:56:58 +02:00
Cheng Zhao
bfa58df7c9
chore: move node headers generation to electron ( #39589 )
2023-08-22 11:13:49 +02:00
Milan Burda
c1898c39bf
chore: remove obsolete "simple" object annotations for the remote module ( #39486 )
2023-08-22 13:43:30 +09:00
Milan Burda
3102a257af
feat: expose dummy module.exports to the sandboxed preload scripts ( #39484 )
2023-08-22 13:43:08 +09:00
Milan Burda
90865fa97d
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition() ( #39479 )
...
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
2023-08-21 15:58:09 +02:00
Charles Kerr
3a91d1f1e1
fix: dangling raw_ptr in ElectronBrowserMainParts dtor ( #39539 )
...
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor
* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor
Browser::WhenReady() holds a reference to JsEnv isolate so must come after
2023-08-21 10:29:25 +02:00
Milan Burda
09190085c0
refactor: add gin_helper::Dictionary::CreateEmpty() helper ( #39547 )
2023-08-21 10:43:41 +09:00
tr2-harada
9937a2bbe8
fix: explorer restart does not recreated thumbnail toolbar buttons ( #39551 )
...
fix: explorer restart does not recreated thumbnail toolbar buttons.
2023-08-21 09:43:49 +09:00
Shelley Vohr
95bf9d8adb
fix: chrome://gpu failing to load ( #39556 )
...
fix: chrome://gpu failing to load
2023-08-21 09:41:00 +09:00
Athul Iddya
c75e193a3e
fix: use tiled edges to calculate frame inset sizes in Linux ( #39523 )
...
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
2023-08-17 14:26:49 -04:00
Shelley Vohr
0621f39296
test: enable parallel/test-debugger-random-port-with-inspect-port ( #39533 )
...
test: enable parallel/test-debugger-random-port-with-inspect-port
2023-08-17 12:16:14 -04:00
Shelley Vohr
aeb89b143b
chore: cleanup asar initialization logic ( #39532 )
2023-08-17 16:42:53 +02:00
Charles Kerr
213388cd87
refactor: prefer Sorted variant of MakeFixedFlatSet() ( #39537 )
...
perf: prefer Sorted variant of MakeFixedFlatSet()
https://chromium-review.googlesource.com/c/chromium/src/+/4660000
says that the sorted version is simpler at compile time because it
can skip MakeFixedFlatSet()'s compile-time dynamic sorting.
2023-08-17 08:58:04 -05:00
David Sanders
8374b9c2ad
ci: add prev-major variable to release board templating ( #39454 )
2023-08-17 14:24:57 +02:00
Shelley Vohr
00746e662b
feat: allow headers to be sent with webContents.downloadURL() ( #39455 )
...
feat: allow headers to be sent with webContents.downloadURL()
2023-08-17 14:17:55 +02:00
Shelley Vohr
31dfde7fa6
docs: note macOS bounds Tray offset ( #39512 )
...
* docs: note macOS bounds Tray offset
* Update docs/api/browser-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-08-17 11:02:03 +02:00
Charles Kerr
dd8df3b0c4
fix: destruction order of js env fields ( #39521 )
...
isolate_ depends on isolate_holder_ and so must be destroyed first.
2023-08-16 23:06:24 -05:00
Milan Burda
b04ce6a5c8
docs: add missing webview render-process-gone event ( #39494 )
...
docs: add mising webview 'render-process-gone' event
2023-08-17 08:52:15 +09:00
Keeley Hammond
fce9ed65d6
build: update NMV to 118 ( #39538 )
2023-08-16 11:46:16 -07:00
github-actions[bot]
a4a3ba9341
build: update appveyor image to latest version - e-118.0.5949.0. ( #39524 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-16 14:06:19 -04:00
John Kleinschmidt
9d6d606192
build: fixup libcxx zip ( #39536 )
2023-08-16 14:05:39 -04:00
Shelley Vohr
1eb398b328
fix: crash when calling BrowserWindow.moveTop() on modal children ( #39499 )
...
fix: crash when calling moveTop() on modal children
2023-08-16 13:28:29 +02:00
Sergei Chestakov
f7a7085019
docs: fix typo in open-url API docs ( #39513 )
...
* Fix typo in open-url API docs
* Update app.md
2023-08-16 12:26:02 +02:00
electron-roller[bot]
0c45d160d6
chore: bump chromium to 118.0.5949.0 (main) ( #39505 )
...
* chore: bump chromium in DEPS to 118.0.5949.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4705386
no manual code changes; existing patch applied with fuzz
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4779059
no manual code changes; existing patch applied with fuzz
* chore: add OffScreenRenderWidgetHostView::InvalidateLocalSurfaceIdAndAllocationGroup()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4563504
Add an impl for a new pure virtual method that was added upstream.
Local impl inspired by upstream implementations in same CL
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-08-15 15:44:24 -04:00
Shelley Vohr
22429e2112
refactor: clean up Node.js cli arg parsing ( #39465 )
...
* refactor: clean up Node.js arg parsing
* chore: feedback from review
2023-08-15 14:49:21 -04:00
David Sanders
1d20ec5b99
ci: fix @electron/github-app-auth CLI usage ( #39507 )
2023-08-15 11:41:29 -07:00
Michaela Laurencin
22c359ac4f
docs: update timelines for E27 ( #39493 )
2023-08-15 12:57:48 -05:00
electron-roller[bot]
c3036d4557
chore: bump chromium to 117.0.5938.0 (main) ( #39375 )
...
* chore: bump chromium in DEPS to 117.0.5929.0
* chore: bump chromium in DEPS to 117.0.5931.0
* chore: bump chromium in DEPS to 117.0.5932.0
* chore: update patches
* 4728317: Prevent PrintRenderFrameHelper from printing when already printing
| https://chromium-review.googlesource.com/c/chromium/src/+/4728317
* 4739501: Use base::SequenceBound to manage SerialPortManagerImpl |
https://chromium-review.googlesource.com/c/chromium/src/+/4739501
* 4702051: Allow overriding source in install-sysroot.py | https://chromium-review.googlesource.com/c/chromium/src/+/4702051
* chore: update filenames.libcxx.gni
* 4727002: Rename "enable_arc2" to "enable_arc" |
https://chromium-review.googlesource.com/c/chromium/src/+/4727002
* chore: bump chromium in DEPS to 117.0.5934.0
* 4736873: Rename ColorSpaces methods on display::Display | https://chromium-review.googlesource.com/c/chromium/src/+/4736873
* 4727203: Replace bool with an enum in as suggested in DevtoolsManagerDelegate. | https://chromium-review.googlesource.com/c/chromium/src/+/4727203
* 4744479: [DevTools] Add 'generateTaggedPDF' option to DevTools Page.printToPDF | https://chromium-review.googlesource.com/c/chromium/src/+/4744479
* 4735893: Don't share WebUSB permissions with webviews | https://chromium-review.googlesource.com/c/chromium/src/+/4735893
* revert: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 117.0.5936.0
* chore: update patches
* 4746465: SAA: Query for embargoed StorageAccess permissions | https://chromium-review.googlesource.com/c/chromium/src/+/4746465
* 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
* chore: bump chromium in DEPS to 117.0.5938.0
* chore: bump chromium in DEPS to 118.0.5939.0
* chore: update patches
* Send line bounds through CursorAnchorInfo on requestCursorUpdate
https://chromium-review.googlesource.com/c/chromium/src/+/4394588
* Fixup lint for Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src
* 4700305: [mac] Fix override of CHILD_PROCESS_EXE
https://chromium-review.googlesource.com/c/chromium/src/+/4700305
Needed because of 4729689: Reland "Remove redundant existence check in PathService" | https://chromium-review.googlesource.com/c/chromium/src/+/4729689
* 4753759: More consistent icon handling for menus.
https://chromium-review.googlesource.com/c/chromium/src/+/4753759
* chore: bump chromium in DEPS to 118.0.5941.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5938.0
* test: update nan-spec-runner cflags
* build: fix isystem include path in nan-spec-runner
* fixup! 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
fix a few more instances of the old path
libc++.a and libc++abi.a are still in buildtools/
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-15 10:49:41 -05:00
Robo
bee5d94886
feat: support dns-result-order Node.js cli flag ( #39376 )
...
* feat: support dns-result-order Node.js cli flag
* chore: update docs
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* chore: remove patch
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-08-15 12:19:45 +02:00
electron-roller[bot]
ef5d5f888d
chore: bump node to v18.17.1 (main) ( #39457 )
...
* chore: bump node in DEPS to v18.17.1
* chore: update patches
* policy: disable process.binding() when enabled
d4570fae35
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-08-15 10:06:55 +02:00
wgsheng
127584dc37
feat: add a 'title' parameter to openDevTools() ( #39047 )
...
* [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar
* all titles->title
* add GetDevToolsTitle(),update docs
* fix:lint error
* fix:lint error
* add setDevToolTitle
* lint errror
* lint errror
* ling errror (.md)
* build error
* build error in mac
* build error
* build error
* change docs
* std::string->std::u16string
* lint error
* build error
* build error
2023-08-15 14:32:53 +09:00
Shelley Vohr
8e3dcc8b17
refactor: update WebContentsZoomController ( #39428 )
...
refactor: update WebContentsZoomController
2023-08-15 10:33:30 +09:00
David Sanders
5d11c30720
ci: improve blocked/need-repro workflow ( #39451 )
...
* ci: improve blocked/need-repro workflow
* ci: let maintainer comments suppress bot comment
* ci: ensure failures bubble up
2023-08-15 10:32:38 +09:00
David Sanders
813853297d
ci: automation for deprecation project board ( #39477 )
2023-08-15 10:28:42 +09:00
David Sanders
dbff7bb531
ci: automation for issue triage board ( #39464 )
2023-08-15 10:28:17 +09:00
David Sanders
effafdf498
test: use as const to remove some usages of as any ( #39475 )
2023-08-15 10:24:32 +09:00
Shelley Vohr
9eeef55469
test: resolve failing Node.js line number failure ( #39490 )
2023-08-14 13:08:55 -04:00
David Sanders
1b3e4dae8d
chore: document deprecated systemPreferences APIs ( #39343 )
...
* chore: document deprecated systemPreferences APIs
* chore: forgot systemPreferences.appLevelAppearance
* test: expect deprecation messages
2023-08-14 11:34:04 +02:00
Milan Burda
d5f31c2208
docs: remove duplicate fiddles (part #2 ) ( #39474 )
...
docs: remove duplicate fiddles
2023-08-14 10:44:07 +02:00
David Sanders
d166182865
chore: remove deprecated systemPreferences color scheme events ( #39341 )
2023-08-14 10:37:18 +02:00
Cheng Zhao
cf658b700d
fix: use nested run loop in clipboard.readImage ( #39466 )
2023-08-14 10:35:37 +02:00
Milan Burda
08bbff5361
docs: handle opening links in the default browser in main.js (part #2 ) ( #39473 )
...
docs: handle opening links in the default browser in main.js
2023-08-14 10:04:29 +02:00
Shelley Vohr
117d5310f5
revert: promise resolved too early when browser initiates in-page navigation ( #39481 )
...
This reverts commit a0effaf9b8 .
2023-08-14 13:13:15 +09:00
John Kleinschmidt
f16dffccd0
ci: fixup known hosts for linux publish ( #39437 )
...
* ci: fixup known hosts for linux publish
* build: use 2023 known hosts
* build: use rebuilt docker image
* Revert "build: use rebuilt docker image"
This reverts commit f9506a9cc0 .
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-08-10 12:40:58 -04:00
Milan Burda
255064659f
docs: update external links ( #39421 )
2023-08-10 11:55:52 +02:00
David Sanders
11600c5f96
chore: document deprecated webContents.getPrinters API ( #39356 )
...
* chore: document deprecated webContents.getPrinters API
* chore: remove duplicate deprecation warning
2023-08-10 11:50:30 +02:00
Milan Burda
1ce2fdd63d
docs: fix take-screenshot fiddle to use desktopCapturer in main.js ( #39420 )
2023-08-10 10:53:23 +02:00
Milan Burda
c4d417b6f6
docs: remove duplicate fiddles ( #39419 )
2023-08-10 10:52:52 +02:00
Milan Burda
0f49868234
chore: deprecate senderId and senderIsMainFrame ( #39381 )
2023-08-09 10:38:48 -04:00
Shelley Vohr
70508b5273
chore: update _api_features manifest requirements ( #39412 )
...
chore: update api_resources manifest requirements
2023-08-09 10:38:13 -04:00
Tomasz
a0effaf9b8
fix: promise resolved to early when browser initiated in-page navigation ( #39260 )
2023-08-09 16:06:39 +02:00
Shelley Vohr
d9329042e2
feat: add support for chrome.tabs.query ( #39330 )
...
* feat: add support for tabs.query
* fix: scope to webContents in current session
* test: add test for session behavior
2023-08-09 14:47:19 +02:00
David Sanders
0425454687
test: helper to expect deprecation warnings ( #39405 )
2023-08-09 11:01:52 +02:00
Samuel Attard
d24d8f1f78
fix: avoid package.json check on built-in modules ( #39418 )
2023-08-09 00:32:00 -07:00
electron-roller[bot]
ab08803959
chore: bump node to v18.17.0 (main) ( #39154 )
...
* chore: bump node in DEPS to v18.17.0
* chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch
Xref: https://github.com/nodejs/node/pull/46930
manually sync patch to minor upstream code shear
* chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch
Xref: https://github.com/nodejs/node/pull/48248
manually sync patch to minor upstream code shear
* chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/47824
chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it
* chore: update api_pass_oomdetails_to_oomerrorcallback.patch
Xref: https://github.com/nodejs/node/pull/47695
manually sync patch to minor upstream code shear
* chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch
Xref: https://github.com/nodejs/node/pull/46979 (upstreamed patch)
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related)
* chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch
Xref: https://github.com/nodejs/node/pull/47274
manually sync patch to minor upstream code shear
some tests moved from sequential to parallel
* chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch
Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch
Xref: https://github.com/nodejs/node/pull/47339
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: rebuild filenames.json
several files removed/added/changed upstream
* chore: update build_add_gn_build_files.patch
upstream dep histogram 0.11.7 moved its include path from src/ to include/
Xref: https://github.com/nodejs/node/pull/47742
* chore: update fix_crypto_tests_to_run_with_bssl.patch
Xref: https://github.com/nodejs/node/pull/47160
BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of
BIO_s_mem()), so use BIO_s_mem() instead.
Related discussion of secure heap support in BoringSSL:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: ftbfs in node dep ada
* fix: ftbfs in node dep uvwasi
* chore: rebuild patches
* chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch
Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`.
BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead.
Upstream Node.js change that prompted this:
https://github.com/nodejs/node/pull/47160
Related discussion of BoringSSL support of secure heap:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: work around Node 18 isURL() regression
* chore: sort script/node-disabled-tests.json alphabetically
* test: add parallel/test-snapshot-argv1 to disabled list
test: add parallel/test-snapshot-namespaced-builtin to disabled list
We don't support that type of snapshotting at the moment.
* chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error
fails upstream in v18.x on my box as well
* ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
* fixup! fix: work around Node 18 isURL() regression
fix: infinite loop regression
* fixup! fix: work around Node 18 isURL() regression
* chore: patch fixtures/errors/force_colors.snapshot
The line numbers in the stacktrace from our v8 build don't match what
Node's tests are expecting, so update the stacktrace to match our build.
The specific numbers probably aren't t needed for the force_colors test,
which is trying to see whether or not the lines are greyed out. One option
is to upstream a test change to stop hardcoding the stacktrace.
* fixup! fix: work around Node 18 isURL() regression
fix; pull in upstream bugfix
* fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js
* chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-08 17:52:51 -05:00
Shelley Vohr
5e59ddca1a
chore: update chrome.runtime.getPlatformInfo impl ( #39392 )
...
chore: update chrome.runtime.getPlatformInfo impl
2023-08-08 22:29:03 +02:00
Shelley Vohr
1b3c63145c
chore: remove i18n JSON spec ( #39391 )
2023-08-08 14:02:16 -04:00
Samuel Attard
814735cb72
build: use aks backed runners for linux builds ( #39403 )
...
* build: test aks runner
* build: stress test
* build: use super-large nodes for publish jobs
* build: try using aks for everything...
* build: shared host not great
* build: clean up
* build: apparently tests dont run in kube infra?
* build: do not change test size
2023-08-08 09:56:41 -07:00
David Sanders
dcf1c65426
chore: fix ipcRenderer.sendTo deprecation warning ( #39342 )
2023-08-08 13:49:56 +02:00
Milan Burda
24c9cbcc0a
docs: handle opening links in the default browser in main.js ( #39379 )
...
docs: handle opening links in the default browser in the main process
2023-08-08 12:35:59 +02:00
Robo
eecfaec8c9
fix: crash when closing active macOS native tab ( #39394 )
...
fix: crash when closing current active macOS native tab
2023-08-08 17:45:03 +09:00
Shelley Vohr
8f4f82618c
fix: removeBrowserView draggable region removal ( #39387 )
...
fix: removeBrowserView draggable region removal
Closes https://github.com/electron/electron/issues/39377 .
2023-08-08 10:23:14 +02:00
github-actions[bot]
1548a2f9fb
build: update appveyor image to e-117.0.5921.0 ( #39390 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-07 13:08:53 -07:00
Milan Burda
3d45429667
refactor: use for-of instead of for simple array iteration ( #39338 )
2023-08-07 11:30:15 +02:00
Shelley Vohr
67523a47b4
fix: chrome.tabs.update return value ( #39365 )
...
fix: chrome.tabs.update return value
2023-08-07 10:03:45 +02:00
David Sanders
330c775252
docs: fix description of pageRanges ( #39378 )
...
Co-authored-by: Alain BUFERNE <albu.consult@gmail.com >
2023-08-07 09:56:36 +02:00
Shelley Vohr
dc707ee938
fix: macOS tray button selection with VoiceOver ( #39352 )
2023-08-07 09:52:18 +02:00
John Kleinschmidt
1eb6e45a36
ci: fix hang when validating AppVeyor artifacts ( #39362 )
2023-08-07 09:51:53 +02:00
Shelley Vohr
2e0517c0ad
feat: allow more Node.js cli flags in main process ( #39344 )
...
* feat: allow more Node.js cli flags in main process
* docs: update cli switch documentation
2023-08-04 19:59:40 +09:00
electron-roller[bot]
c5b9f766f3
chore: bump chromium to 117.0.5923.0 (main) ( #39304 )
...
* chore: bump chromium in DEPS to 117.0.5921.0
* chore: update chromium patches
* 4721409: Remove redundant ARC configuration in /components | https://chromium-review.googlesource.com/c/chromium/src/+/4721409
* 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* 4022621: Re-register status item when owner of status watcher is changed | https://chromium-review.googlesource.com/c/chromium/src/+/4022621
* chore: update V8/boringssl patches
* fixup! 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* chore: bump chromium in DEPS to 117.0.5923.0
* build [debug]: remove assert
4722125: Update enterprise content analysis buildflags usage | https://chromium-review.googlesource.com/c/chromium/src/+/4722125
* chore: manually rollback to 117.0.5921.0
* build [arc]: ARC conversion in auto_updater
* build [arc]: ARC conversion in browser/api
* build [arc]: ARC conversion in notifications/mac
* build [arc]: ARC conversion in in_app_purchase
* build [arc]: ARC conversion in browser/ui
* build [arc]: ARC conversion in ui/cocoa
* build [arc]: ARC conversion in shell/common
* build [arc]: ARC conversion in OSR
* build [arc]: ARC conversion in login_helper
* build [arc]: ARC conversion in app_mas
* build [arc]: fix up ARC syntax (thanks @codebytere!)
* 4726946: [Extensions] Work around dangling BrowserContext pointer. | https://chromium-review.googlesource.com/c/chromium/src/+/4726946
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-08-04 10:47:29 +02:00
Shelley Vohr
6d0e8044eb
fix: update chrome.tabs for Manifest v3 ( #39317 )
2023-08-03 18:34:02 +02:00
Shelley Vohr
f8b05bc127
feat: support minimum_chrome_version manifest key ( #39256 )
...
feat: support minimum_chrome_version extension key
2023-08-03 11:38:31 -04:00
David Sanders
e6931a788f
docs: clean up removed systemPreferences methods ( #39334 )
2023-08-03 14:40:29 +02:00
Robo
e96b1613a4
fix: destroy message port backend when JS env exits ( #39335 )
2023-08-03 14:30:19 +02:00
Milan Burda
fe93f69e5a
refactor: use Set instead of Array when appropriate ( #39324 )
2023-08-03 14:29:57 +02:00
Milan Burda
c5e50e4882
refactor: use more appropriate array methods ( #39321 )
2023-08-02 19:43:45 +02:00
Shelley Vohr
7686d1c379
docs: correct powerSaveBlocker.stop(id) return type ( #39320 )
...
doc: correct powerSaveBlocker.stop return type
2023-08-02 11:39:40 +02:00
Shelley Vohr
303b707fbf
fix: update chrome.i18n for Manifest v3 ( #39291 )
...
fix: update chrome.i18n for Manifest v3
2023-08-02 11:02:16 +02:00
github-actions[bot]
aaae2abf20
build: update appveyor image to latest version e-117.0.5911.0. ( #39318 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-02 10:23:21 +02:00
David Sanders
0eef6c67d1
docs: fix return type for ipcMain handle functions ( #39237 )
2023-08-01 10:02:20 +02:00
Shelley Vohr
1f19a74417
fix: potential crash calling tray.popUpContextMenu() ( #39231 )
...
fix: potential crash calling tray.popUpContextMenu
2023-08-01 15:07:30 +09:00
Shelley Vohr
c8f7a0e052
fix: Chrome Extensions service worker host registration ( #39290 )
2023-08-01 15:04:38 +09:00
David Sanders
b2c62d6ad1
fix: initial dark mode title bar on Windows 10 ( #39287 )
2023-07-31 22:02:23 -07:00
electron-roller[bot]
cfc0826b65
chore: bump chromium to 117.0.5913.0 (main) ( #39172 )
...
* chore: bump chromium in DEPS to 117.0.5899.0
* 4686653: webui: Filter out non-chrome scheme URLs in WebUIConfigMap
https://chromium-review.googlesource.com/c/chromium/src/+/4686653
* 4696355: Remove deprecated version of base::CommandLine::CopySwitchesFrom()
https://chromium-review.googlesource.com/c/chromium/src/+/4696355
* chore: fixup patch indices
* 4603888: Reland "Enable raw_ref check on linux"
https://chromium-review.googlesource.com/c/chromium/src/+/4603888
* chore: bump chromium in DEPS to 117.0.5901.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5903.0
* chore: bump chromium in DEPS to 117.0.5903.2
* chore: bump chromium in DEPS to 117.0.5905.0
* 4706792: Printing: Add debug code for a DispatchBeforePrintEvent() failure
https://chromium-review.googlesource.com/c/chromium/src/+/4706792
* 4704786: Refactor libunwind build rules/flags
https://chromium-review.googlesource.com/c/chromium/src/+/4704786
* 4701710: [Linux Ui] Set toolkit dark preference based on FDO dark preference
https://chromium-review.googlesource.com/c/chromium/src/+/4701710
* chore: fixup patch indices
* chore: bump chromium in DEPS to 117.0.5907.0
* chore: bump chromium in DEPS to 117.0.5909.2
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5911.0
* chore: update patches
* chore: build-what-we-include
* fix: set allowFileAccess on devtools extensions correctly
Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725
* 4670615: Reland "[iterator-helpers] Shipping iterator helpers"
https://chromium-review.googlesource.com/c/v8/v8/+/4670615
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-07-31 10:47:32 -07:00
Shelley Vohr
8e5bb4949b
fix: skip artifact validation for doc-only PRs ( #39296 )
2023-07-31 09:59:51 -04:00
Milan Burda
724f90a2a7
refactor: throw errors directly in async functions ( #39233 )
2023-07-31 10:39:37 +02:00
David Sanders
68701c4c3c
chore: update @electron/lint-roller and improve doc type checks ( #39262 )
2023-07-31 10:39:01 +02:00
hunter
2b283724ce
docs: fix some string union type ( #39258 )
...
* docs: fix some string union types
Improve Type Union Typings in the Docs
* test: add smoke tests
* test: update `ses.clearStorageData` test case
* test: update `ses.clearStorageData` test case
---------
Co-authored-by: mhli <mhli@hillinsight.com >
2023-07-31 10:32:59 +02:00
Shelley Vohr
6df392162f
fix: pageVisibility state when backgroundThrottling disabled ( #39223 )
...
fix: pageVisibility state when backgroundThrottling disabled
2023-07-28 10:48:25 +02:00
Milan Burda
c9bae5da8e
refactor: use optional catch binding ( #39232 )
2023-07-27 10:53:45 -04:00
Samuel Attard
8dea783805
fix: do not resolve electron entrypoints on disk ( #39247 )
2023-07-26 22:10:58 -07:00
Shelley Vohr
695fcf3cb2
fix: reparenting after BrowserWindow.destroy() ( #39062 )
...
fix: reparenting after BrowserWindow.destroy()
2023-07-26 16:47:32 +02:00
Athul Iddya
fa5b1be6f3
fix: delete desktop capturers when they're not needed ( #39194 )
...
* fix: delete desktop capturers when they're not needed
Delete desktop capturer objects by resetting the DesktopMediaList
objects that own them after the sources have been collected. Capturers
that are not delegated are already being reset via a patch on
NativeDesktopMediaList. That is not safe for delegated capturers as
thumbnail generation depends on user events. Deleting the
DesktopMediaList operation is safe for all capturers and releases OS
capture resources as soon as possible.
* fix: add a patch to clean up PipeWire resources
Adding a patch to workaround a Chromium issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1467060
The patch can be removed when the issue is resolved.
2023-07-26 10:40:19 +02:00
Shelley Vohr
38c3d8df29
fix: traffic lights not working when child windows are restored via parent window ( #39225 )
2023-07-26 10:10:34 +02:00
Shelley Vohr
12548294c0
fix: resizable: false should disable fullscreen button at start ( #39086 )
...
fix: resizable should disable fullscreen button at start
2023-07-25 12:18:36 -04:00
Milan Burda
455f57322f
refactor: use TypeError instead of generic Error when appropriate ( #39209 )
...
refactor: use TypeError instead of generic Error when appropriate
2023-07-25 12:08:46 -04:00
George Xu
77cc1d6ffa
chore: add dependencies upgrade policy to readme ( #39163 )
...
* chore: add dependencies upgrade policy to readme
as per wg-releases july 19 meeting
https://docs.google.com/document/d/1XWdD4uAu9m8Gcpiw1j5fLwwZ_hU4rce9JyTpuKU6uM8/edit?pli=1
* Update CONTRIBUTING.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-07-25 11:58:16 +02:00
John Kleinschmidt
e543126957
ci: fail appveyor build if artifacts are missing ( #39210 )
2023-07-24 16:38:34 -04:00
Shelley Vohr
1231f0a734
docs: document idleDetector permissions ( #39180 )
...
doc: document idleDetector permissions
2023-07-24 14:57:41 -04:00
github-actions[bot]
cd408a826c
build: update appveyor image to latest version - e-117.0.5897.0 ( #38970 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-07-24 12:44:27 -04:00
Milan Burda
3df6d337f3
feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo() ( #38868 )
...
* feat: add isMainFrame to events emitted via ipcRenderer.sendTo()
* chore: rename isMainFrame to senderIsMainFrame
2023-07-24 14:27:30 +02:00
Michaela Laurencin
09e6e4b9a7
docs: update window-open.md to include target ( #39162 )
...
Update window-open.md to include target
2023-07-24 12:33:41 +02:00
David Sanders
2caf08059e
docs: update @electron/fuses code examples ( #39175 )
2023-07-24 12:33:26 +02:00
David Sanders
1ca3a7d3c9
docs: fill in Node.js version for v25 release ( #39187 )
2023-07-24 12:33:10 +02:00
Milan Burda
2c52eb7e1c
refactor: replace .indexOf() with .includes() ( #39195 )
2023-07-24 12:32:54 +02:00
Athul Iddya
9cd5de7588
fix: use generic capturer to list both screens and windows when possible ( #39111 )
...
Screensharing with PipeWire via XDG Desktop Portal requires explicit
user permission via permission dialogs. Chromium has separate tabs for
screens and windows and thus its portal implementation requests
permissions separately for each. However, the screencast portal has no
such limitation and supports both screens and windows in a single
request.
WebRTC now supports this type of capture in a new method called
called `CreateGenericCapturer`. The `desktopCapturer` implementation has
been modified to use it. Additionally, Chromium has been patched to use
same generic capturer to ensure that the source IDs remain valid for
`getUserMedia`.
2023-07-21 16:03:01 -07:00
David Sanders
a83f9c06d7
docs: update binding linking example in creating API doc ( #39177 )
2023-07-21 14:33:39 -07:00
David Sanders
b66449add5
ci: don't set column for draft issues on new project board ( #39178 )
2023-07-21 14:33:14 -07:00
Milan Burda
ada8eb33b2
feat: deprecate ipcRenderer.sendTo() ( #39091 )
...
* feat: deprecate ipcRenderer.sendTo()
* docs: add _Deprecated_ to ipcRenderer.sendTo()
2023-07-21 11:16:44 +02:00
David Sanders
3a5e2dd90c
docs: remove redundant IPC event sections ( #39133 )
...
* docs: use correct names for IPC events
* docs: remove redundant IPC event sections
2023-07-20 11:43:08 -07:00
Shelley Vohr
6688b0f31a
build: fix Appveyor test workflow checkout ( #39137 )
...
* build: fix Appveyor test workflow checkout
* fix: +refs/pull/num/merge -> +refs/pull/num/head
* chore: add to appveyor-woa as well
2023-07-20 11:19:57 +02:00
David Sanders
565705bd1d
docs: fix casing of _Deprecated_ ( #39152 )
2023-07-20 11:16:20 +02:00
electron-roller[bot]
e02cf8674d
chore: bump chromium to 117.0.5897.0 (main) ( #39147 )
...
* chore: bump chromium in DEPS to 117.0.5896.0
* chore: update patches
* 4622260: [Service Workers] Allow fetches from workers to use auto-picked certs
https://chromium-review.googlesource.com/c/chromium/src/+/4622260
* chore: bump chromium in DEPS to 117.0.5897.0
* 4665672: [ProfileSelections] Transition extension keyed factories to use Profile Selections
https://chromium-review.googlesource.com/c/chromium/src/+/4665672
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-20 09:36:59 +02:00
dependabot[bot]
3e7c904f02
build(deps): bump word-wrap from 1.2.3 to 1.2.4 ( #39148 )
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-19 19:24:26 +02:00
Charles Kerr
f2b32af1f6
perf: small perf changes in HidChooserController ( #39057 )
...
* perf: avoid string temporary in HidChooserController::PhysicalDeviceIdFromDeviceInfo()
return a const ref instead of a new string
* perf: avoid second map lookup in HidChooserController::AddDeviceInfo()
2023-07-19 16:54:30 +02:00
Cheng Zhao
cc39ddb728
test: add some environment variables for controlling tests ( #39149 )
...
chore: add some environment variables for controlling tests
2023-07-19 16:54:08 +02:00
electron-roller[bot]
bbdd037219
chore: bump chromium to 117.0.5892.0 (main) ( #39118 )
...
* chore: bump chromium in DEPS to 117.0.5892.0
* 4670267: Don't send javascript: or empty URLs to browser in CreateNewWindow.
https://chromium-review.googlesource.com/c/chromium/src/+/4670267
* 4662090: Add metrics for WebGPU support
https://chromium-review.googlesource.com/c/chromium/src/+/4662090
* 4672599: Use set_defaults for mac_app_bundle
https://chromium-review.googlesource.com/c/chromium/src/+/4672599
* 4663771: usb: Add connection count tracking methods for UsbDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/4663771
* 4664578: Remove unused parameter from ExtensionsGuestViewManagerDelegate ctor
https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* 4622253: usb: Create classes for usb system tray icon
https://chromium-review.googlesource.com/c/chromium/src/+/4622253
* 4678263: Remove ARC support from scoped_nsobject
https://chromium-review.googlesource.com/c/chromium/src/+/4678263
* chore: follow-up ARC changes and missing guard corrections
* chore: don't mark 0-param ctor explicit
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* chore: fixup patch indices
* 4670865: Merge ObjectProxy::CallMethodAndBlock{,WithErrorDetails}.
https://chromium-review.googlesource.com/c/chromium/src/+/4670865
* chore: follow-up ARC changes and missing guard corrections
* fixup: retain ElectronApplicationDelegate
* fix: correct rustc binary
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-19 00:26:27 +02:00
Shelley Vohr
ee4460ac68
build: correct codespaces devcontainer extensions settings ( #39123 )
2023-07-19 00:20:11 +02:00
Shelley Vohr
00d96970cb
build: fixup Codespaces build-tools setup ( #39138 )
...
* build: fixup Codespaces build-tools setup
* oops evm.testing1.json -> evm.testing.json
2023-07-18 22:58:26 +02:00
Keeley Hammond
139774ce48
docs: update stable dates ( #39128 )
2023-07-18 09:30:04 -07:00
Milan Burda
47951cc95b
refactor: use Date.now() instead of +new Date() ( #38901 )
...
refactor: use Date.now()
2023-07-18 10:58:02 +02:00
Shelley Vohr
8874306dc0
fix: window.open causing occasional Node.js crashes ( #38754 )
...
* fix: window.open causing occasional Node.js crashes
* chore: always free isolate data
* chore: clear pending ticks in worker thread
* fix: UAF crash when creating WebWorkerObserver
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-07-18 10:41:50 +02:00
ZWJKFLC
4ab0a5ade4
docs: fix a capitalization problem in messagePort tutorial ( #39083 )
...
fix a capitalization problem
For a rookie, this little mistake took a long time to find out.
2023-07-17 10:41:46 -07:00
Milan Burda
626f46f75a
refactor: use node scheme imports in docs/fiddles ( #39110 )
2023-07-17 10:30:53 +02:00
electron-roller[bot]
9645f7f6d8
chore: bump chromium to 117.0.5884.1 (main) ( #38969 )
...
* chore: bump chromium in DEPS to 117.0.5866.0
* chore: bump chromium in DEPS to 117.0.5868.0
* chore: update mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Minor manual patch syncing due to upstream code shear
* chore: update mas_disable_remote_layer.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4647191
Manually sync patch to minor upstream code shear
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641746
No manual changes; patch applied with fuzz
* chore: update mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Manually sync base/process/launch_mac.cc to minor upstream shear
Manually sync base/mac/foundation_util.mm to upstream changes:
_CFIsObjC use has been removed upstream, so we no longer need
to remove it 🎉
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658496
Manually sync patch to minor upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4625254
Manually sync patch to minor upstream code shear
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Xref: services/network/public/cpp/resource_request.cc
No manual changes; patch applied with fuzz
* chore: update add_electron_deps_to_license_credits_file.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634961
No manual changes; patch applied with fuzz
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4648411
No manual changes; patch applied with fuzz
* chore: update patches
* fixup! chore: update add_electron_deps_to_license_credits_file.patch
chore: license files must be an array
* chore: bump chromium in DEPS to 117.0.5870.0
* chore: update patches
* chore: run ./script/gen-libc++-filenames.js
* chore: update json_parse_errors_made_user-friendly.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4652014
v8 error message changed upstream; update Node test to match it
* chore: bump chromium in DEPS to 117.0.5872.0
* chore: update patches
* chore: explicitly cast x11::Window to unsigned int
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661049
This is an `enum class Window : uint32_t` defined in ui/gfx/x/xproto.h.
Previous versions of clang let this implicit cast happen,
but it generates a warning in the new clang roll.
* chore: remove unused #include
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4650453
header was removed upstream, so FTBFS unless removed here
* chore: add include guard patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4628373
h/t @jkleinsc
* chore: bump chromium in DEPS to 117.0.5874.0
* chore: update render_widget_host_view_mac.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661244
Manually sync patch to minor upstream code
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to upstream code shear
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to minor upstream code shear
* chore: update GetInitiatorProcessId()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641991
trivial upstream naming change: s/ProcessID/ProcessId/
* chore: sync to upstream SetInputRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4665245
Simple upstream chang: SetInputRegion() used to take a gfx::Rect* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<gfx::Rect> w/the same meaning.
* chore: sync to upstream SetOpaqueRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4656738
Simple upstream chang: SetOpaqueRegion() used to take a vector<Rect>* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<std::vector<gfx::Rect>> w/the same meaning.
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5876.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658375
We no longer need to patch out a field that's now removed upstream.
RenderWidgetHostNSViewBridgeOwner.remote_accessibility_element_
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658680
Manually sync patch to upstream code shear (ARC adoption).
* chore: update patches
* fix: -Werror,-Wshadow error in Node.js
* chore: bump chromium in DEPS to 117.0.5878.0
* chore: bump chromium in DEPS to 117.0.5880.0
* chore: bump chromium in DEPS to 117.0.5880.4
* chore: update patches
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
* WIP: 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* chore: update printing patch after rebase
* chore: bump chromium in DEPS to 117.0.5882.0
* Revert "WIP: 4658680: Convert /content/browser to use ARC"
This reverts commit c8559ea448 .
* Revert "4669995: Remove CFToNSCast and NSToCFCast"
This reverts commit 38e145f33d .
* chore: bump chromium in DEPS to 117.0.5874.0
* 4661244: Convert /content/browser/renderer_host to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4661244
* 4653209: Convert /ui/views:views to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4653209
* chore: fixup mas_disable_remote_accessibility.patch
* chore: fixup render_widget_host_view_mac.patch
* chore: update to newer clang
* chore: bump chromium in DEPS to 117.0.5884.1
(cherry picked from commit a3879acfde8f3d962d58d6ad0632164ccb88ee63)
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
(cherry picked from commit 38e145f33d )
(cherry picked from commit b1224ab7e00aedbd0e5dc78ebb3c6162573b28c4)
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
(cherry picked from commit 77039a323b9ebb3e8edb3a92a3b94a8d7d026a32)
* Rename and cleanup ExtensionsBrowserClient functions
| https://chromium-review.googlesource.com/c/chromium/src/+/4665670
(cherry picked from commit 677a2e646a8d82da60dc252b08b320c3ddff6be6)
* chore: bump chromium in DEPS to 117.0.5886.0
* chore: update patches
* Revert "chore: update patches"
This reverts commit db9294f944 .
* Revert "chore: bump chromium in DEPS to 117.0.5886.0"
This reverts commit a7de0276e6 .
* build: use built toolchains instead of locally installed VSCode
* fixup: build: use built toolchains instead of locally installed VSCode
* chore: add missing mojo dep
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-16 16:14:43 +02:00
Shelley Vohr
f61425efdb
fix: clipboard.readImage() should be synchronous ( #39069 )
...
* feat: clipboard.readImage returns a Promise
* chore: update breaking changes doc
* fix: make function synchronous
* Update docs/api/native-image.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-07-13 16:59:14 -04:00
Robo
34e7c3696a
feat: expose safestorage backend information on linux ( #38873 )
...
* feat: expose safestorage backend information on linux
* Remove gnome-keyring
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704
2023-07-13 11:14:33 +02:00
Charles Kerr
dc671804da
perf: avoid redundant lookup in BluetoothChooser::AddOrUpdateDevice() ( #39059 )
...
perf: avoid redundant map lookup in BluetoothChooser::AddOrUpdateDevice()
2023-07-13 10:16:25 +02:00
Milan Burda
b14b876d50
docs: fix fiddles ( #39060 )
...
* refactor: replace Array.prototype.forEach.call with plain for-of
* fix: add missing contextIsolation: false
* fix: open links in default browser
2023-07-13 10:10:37 +02:00
Charles Kerr
a8622aed7b
perf: avoid redundant map lookup in NativeImage::GetHICON() ( #39058 )
...
perf: avoid double map lookup in NativeImage::GetHICON()
2023-07-13 15:37:43 +09:00
Shelley Vohr
da3475998f
fix: BrowserWindow.moveAbove() not working for child windows ( #39034 )
...
fix: BrowserWindow.moveAbove() not working for child windows
2023-07-12 17:42:24 +02:00
Alka Vats
9d1a16b2e6
docs: updated the markup tag i with the em ( #39041 )
2023-07-12 15:52:10 +02:00
Shelley Vohr
b142fce229
fix: protocol.handle not intercepting file protocol ( #39048 )
...
fix: protocol.handle not intercepting file protocol
2023-07-12 11:42:49 +02:00
Mikhail Leliakin
f959fb0c96
feat: browserWindow.getBrowserViews() to return sorted by z-index array ( #38943 )
2023-07-11 11:01:30 +02:00
Athul Iddya
905e41bbdd
fix: use StartUpdating method for PipeWire capturer ( #38833 )
...
* fix: use StartUpdating method for PipeWire capturer
Fixed a crash related to PipeWire capturer by adapting to Chromium's
interface changes. Chromium expects a call to
`NativeDesktopMediaList::StartUpdating` with an implementation of
`DesktopMediaListObserver` for delegated capturers like PipeWire. This
interface allows listening to user permission events and listing
sources only after the user has made a choice on the permission dialog.
The interface has been implemented by an inner class to allow listening
to screen and window capture permissions concurrently using two
instances of the class. A patch that was resetting the capturer on the
first refresh has been changed to exclude PipeWire. PipeWire capturer
object will follow the lifecycle of `NativeDesktopMediaList`, as is the
case in Chromium.
Fixes #37463
* fix: wait for thumbnails from PipeWire when necessary
The PipeWire stream starts after the dialog is dismissed. If the sources
are listed immediately afterwards, the thumbnail may not have been
generated by that time. Explicitly wait for both thumbnail generation
and a selection on the source dialog before listing sources.
2023-07-11 10:21:11 +02:00
Athul Iddya
3e3152008f
fix: remove types from GTK CSS selectors ( #39003 )
...
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.
Fixes #38786
Co-authored-by: Athul Iddya <athul@iddya.com >
2023-07-10 22:52:12 +02:00
Anton Gilgur
f3f3f53904
docs: add link to Travis CI headless page ( #38990 )
...
docs(headless): link to Travis CI docs
- Travis has a specific page in its docs all about headless, with several different methods of using `xvfb`
- c.f. https://docs.travis-ci.com/user/gui-and-headless-browsers/
2023-07-10 16:45:18 -04:00
Shelley Vohr
117a700724
fix: printing optional access crash on Windows ( #38976 )
2023-07-10 09:26:29 -04:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
Mikhail Leliakin
56b5c00312
feat: add BrowserWindow.showAllTabs() for macOS ( #38965 )
2023-07-10 10:43:37 +02:00
John Kleinschmidt
040e9a027a
build: disable unneeded depot_tools update on Windows CI ( #39011 )
...
build: disable unneeded depot_tools update
2023-07-06 16:13:20 -04:00
Shelley Vohr
a97028bacf
fix: Notification 'Show' button visible when no actions exist ( #38997 )
2023-07-06 15:50:08 -04:00
Shelley Vohr
cc7d724a3b
fix: menu border being created properly on Windows 11 ( #38998 )
...
* fix: menu border being created properly on Windows 11
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-07-06 15:46:12 +02:00
Shelley Vohr
c7a64ab994
fix: webview crash when removing in close event ( #38996 )
2023-07-06 10:20:34 +02:00
Shelley Vohr
5a77c75753
revert: compensate for title bar height when setting bounds on BrowserView ( #38981 )
...
This reverts commit 75f9573e53 .
2023-07-06 09:50:08 +02:00
Varun Sood
ec4c9024b9
docs: Improved the Documentation on BrowserWindow type attribute ( #38666 )
...
* docs: Documentation changes
* made the required changes in the docs
* made the toolbar type text correction
2023-07-05 16:26:39 -04:00
Cheng Zhao
3fa15ebb7e
fix: use Chromium's way to compute min/max sizes ( #38974 )
2023-07-05 11:02:05 -04:00
David Sanders
52fe76ca28
ci: automate release board creation ( #38629 )
...
* ci: refactor determining major branch
* ci: automate release board creation
2023-07-03 10:34:57 +02:00
Sergei Chestakov
e991c1868e
docs: fix misleading code sample for handling deeplinks on Linux ( #38862 )
...
Fix misleading docs for handling deeplinks in Linux
2023-07-03 10:30:45 +02:00
electron-roller[bot]
ccd4531bfb
chore: bump chromium to 117.0.5852.0 (main) ( #38891 )
...
* chore: bump chromium in DEPS to 117.0.5846.0
* chore: update patches
* 4628901: Bump the macOS deployment target to 10.15
https://chromium-review.googlesource.com/c/chromium/src/+/4628901
* 4593350: [Private Network Access] Trigger Permission Prompt
https://chromium-review.googlesource.com/c/chromium/src/+/4593350
* 4631011: Remove unlaunched "InstallReplacementAndroidApp" Platform App APIs
https://chromium-review.googlesource.com/c/chromium/src/+/4631011
* chore: disable API deprecation warnings in NSKeyedArchiver
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 117.0.5848.2
* chore: update feat_add_set_theme_source_to_allow_apps_to.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629743
No manual changes; patch succeeded with fuzz
* chore: update process_singleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4605398
Trivial manual patch adjustments to account for code shear.
* chore: remove electron::BrowserContext::GetMediaDeviceIDSalt()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4608130
upstream tldr:
- content::BrowserContext::GetMediaDeviceIDSalt()
- content::ContentBrowserClient::ArePersistentMediaDeviceIDsAllowed()
+ content::ContentBrowserClient::GetMediaDeviceIDSalt()
This commit leaves ElectronBrowserContext::GetMediaDeviceIDSalt() in
place (now non-virtual, non-override). It is now called by the new
function ElectronBrowserClient::GetMediaDeviceIDSalt().
As a followup, we might want to consider using the new upstream
media_device_salt::MediaDeviceSaltService and removing our
electron::MediaDeviceIDSalt code. CC @MarshallOfSound for 2nd
opinion since he has done the most work on MediaDeviceIDSalt and
may have more context.
* chore: fix iwyu breakage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629624
electron_browser_main_parts.cc uses ui::ColorProviderManager but didn't
include it. Things worked anyway because we got it indirectly from
content/public/browser/web_contents.h until 4629624.
* chore: remove call to base::mac::IsAtLeastOS10_14
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in IAP
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in electron_application_delegate
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove broken-before-macOS-10.15 patch in mas_avoid_usage_of_private_macos_apis.patch
Upstream has bumped minimum to macOS 10.15
* chore: remove @available(macOS 10.14) check
Upstream minimum requirement for macOS is now 10.15
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5850.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5852.0
* chore: update patches
* Move two params from NetworkContextParams to NetworkContextFilePaths.
https://chromium-review.googlesource.com/c/chromium/src/+/4615930
* WebUSB: Add exclusionFilters to USBRequestDeviceOptions
https://chromium-review.googlesource.com/c/chromium/src/+/4614682
* Convert /chrome/browser/ui to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4615920
* fixup! Bump the macOS deployment target to 10.15
* fixup! Bump the macOS deployment target to 10.15
* chore: update libcxx files
* win: Remove 10Glass from Windows10Glass function and var names
https://chromium-review.googlesource.com/c/chromium/src/+/4641314
* chore: revert 392e5f43 from chromium
* Add an ExecutionContext to ScriptState
https://chromium-review.googlesource.com/c/chromium/src/+/4609446
* fixup! Add an ExecutionContext to ScriptState
* chore: fix header
* Revert "chore: revert 392e5f43 from chromium"
This reverts commit b7f782943e4ce83cae8cd35780d8d3618cf0772c.
* fix: return correct min/max sizes in WinFrameView
* fixup! Revert chore: revert 392e5f43 from chromium
* fixup! Add an ExecutionContext to ScriptState
* Revert "fixup! Revert chore: revert 392e5f43 from chromium"
This reverts commit 7e2c7281abfc4f309255339fdba073d90a9ae3eb.
* Revert "fix: return correct min/max sizes in WinFrameView"
This reverts commit 3f418b1ab5155686730e087ae6cabe4a21b4bb61.
* Revert "Revert "chore: revert 392e5f43 from chromium""
This reverts commit 56296d8b7c434147e032e3c3b08c0e371b6c27ba.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2023-07-01 16:22:55 -04:00
Samuel Attard
499d893040
feat: add support for keyboard initialized menu popup ( #38903 )
...
* feat: add support for keyboard initialized menu popup
* Update docs/api/menu.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: add patch to chromium for keyboard accessibility menu behavior
* refactor: s/initiatedByKeyboard/sourceType
* fix: ignore initial mouse event to retain keyboard initiated focus
* Update docs/api/menu.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2023-06-29 15:54:06 -07:00
Milan Burda
607e71d563
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() ( #38929 )
2023-06-27 16:57:33 -04:00
Cheng Zhao
09669f9d21
fix: child window may have opener removed ( #38910 )
2023-06-26 17:04:54 -04:00
github-actions[bot]
ff6d0df2d5
build: update appveyor image to latest version e-116.0.5845.0 ( #38913 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-26 15:57:10 -04:00
Milan Burda
81a454d148
chore: re-enable node/no-deprecated-api linting ( #38899 )
...
* chore: re-enable node/no-deprecated-api linting
* chore: re-enable no-global-assign linting
2023-06-26 13:51:59 -04:00
Charles Kerr
acba6d79fb
docs: document e27 breaking change of dropping macOS 10.13, 10.14 ( #38917 )
...
docs: document e27 breaking change of dropping macOS 10.13, 10.14 support
2023-06-26 13:29:00 -04:00
electron-roller[bot]
327af3b03c
chore: bump node to v18.16.1 (main) ( #38869 )
...
* chore: bump node in DEPS to v18.16.1
* chore: update patches
* deps: update c-ares to 1.19.1
https://github.com/nodejs/node/pull/48115
* chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
* chore: disable x509 bssl test
new test added in bf3e2c892
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix related -Werror,-Wunused-function FTBFS
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix another related -Werror,-Wunused-function FTBFS
* fixup! chore: disable x509 bssl test
fix yet another -Werror,-Wunused-function FTBFS
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-26 12:03:30 -04:00
Milan Burda
ef6569b7d3
chore: cleanup unusued variables + enable linting ( #38898 )
2023-06-26 02:51:54 -07:00
dependabot[bot]
e900f6ecc3
build(deps-dev): bump semver from 5.7.0 to 7.5.2 ( #38916 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.0 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.0...v7.5.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-23 13:17:43 -07:00
Milan Burda
9226cc662b
refactor: use types for once() return values in spec ( #38872 )
2023-06-22 14:38:52 -04:00
Milan Burda
abec9ead06
refactor: use node scheme imports in scripts ( #38846 )
...
* refactor: use node scheme imports in script
* refactor: use node scheme imports in build
2023-06-22 16:21:42 +02:00
Charles Kerr
395b608dd5
refactor: more constexpr lookup tables ( #38886 )
...
* refactor: use constexpr lookup table in electron_api_web_contents.cc
* refactor: make KeyboardCodeFromStr() private
it is only used as a helper to KeyboardCodeFromStr()
* chore: savepoint
* chore: make lint happy
* fixup! refactor: make KeyboardCodeFromStr() private
* refactor: use constexpr lookup table in electron_url_loader_factory
* refactor: use constexpr lookup table in electron_api_tray
* refactor: use constexpr lookup table in web_contents_preferences.cc
* refactor: use constexpr lookup table in content_converter
2023-06-22 14:33:44 +02:00
electron-roller[bot]
1eb19f3078
chore: bump chromium to 116.0.5845.0 (main) ( #38827 )
...
* chore: bump chromium in DEPS to 116.0.5835.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5837.0
* chore: bump chromium in DEPS to 116.0.5839.0
* chore: bump chromium in DEPS to 116.0.5841.0
* chore: bump chromium in DEPS to 116.0.5843.0
* Update patches
CLs that affected printing.patch:
- 4616791: Refactor PrintViewManagerBase::PrintNow()
https://chromium-review.googlesource.com/c/chromium/src/+/4616791
- 4602776: Make PrintNodeUnderContextMenu operation go through PrintViewManager
https://chromium-review.googlesource.com/c/chromium/src/+/4602776
* 4506614: geolocation: Add LocationProvider::FillDiagnostics
https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* chore: bump chromium in DEPS to 116.0.5845.0
* chore: update patches
* fixup! 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* 4609704: Remove gnome-keyring
https://chromium-review.googlesource.com/c/chromium/src/+/4609704
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2023-06-22 10:51:15 +02:00
Shelley Vohr
a00a25376d
fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents ( #38842 )
...
fix: crash calling removeBrowserView() with destroyed webContents
https://github.com/electron/electron/issues/37642
2023-06-21 15:20:54 -04:00
Michaela Laurencin
ce6fe040fe
fix: set minimize visibility true with enable ( #38860 )
2023-06-21 14:58:33 -04:00
Shelley Vohr
e73edb5481
feat: allow headers to be sent with session.downloadURL() ( #38785 )
2023-06-21 15:31:28 +02:00
Milan Burda
74d73166d9
chore: remove deleted guest-window-proxy.ts from CODEOWNERS ( #38848 )
...
chore: remove deleted /lib/browser/guest-window-proxy.ts from CODEOWNERS
2023-06-20 17:19:33 -04:00
Milan Burda
6bd02bf181
refactor: use node scheme imports in default_app ( #38847 )
2023-06-20 17:17:03 -04:00
github-actions[bot]
a595044989
build: update appveyor image to latest version - e-116.0.5833.0. ( #38803 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-20 14:15:00 -04:00
Shelley Vohr
f6bbc34658
fix: set supported scale factors on startup ( #38836 )
2023-06-20 12:24:03 -04:00
Milan Burda
2b3902e526
refactor: use content::GlobalRenderFrameHostId ( #38843 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-20 15:32:31 +02:00
Milan Burda
93024be3b2
build: rename spec/.eslintrc -> spec/.eslintrc.json ( #38838 )
...
chore: rename spec/.eslintrc -> spec/.eslintrc.json
2023-06-19 14:19:11 +02:00
Shelley Vohr
b693f88491
fix: crash on nativeTheme change during context menu close ( #38824 )
2023-06-19 11:26:54 +02:00
Charles Kerr
97132ece33
refactor: use constexpr lookup tables in gin helper ( #38818 )
...
* feat: add gin_helper::FromV8WithLookup()
feat: add gin_helper::FromV8WithLowerLookup()
* refactor: use constexpr lookup table in gin Converters
2023-06-19 10:33:09 +02:00
Charles Kerr
41ab5f327f
refactor: remove unused InspectableWebContentsView::GetWebView() ( #38799 )
2023-06-16 00:44:19 -05:00
electron-roller[bot]
7219142a54
chore: bump chromium to 116.0.5833.0 (main) ( #38809 )
...
* chore: bump chromium in DEPS to 116.0.5833.0
* chore: update patches
* 4530656: Add DeviceLoginScreenWebHidAllowDevicesForUrls policy
https://chromium-review.googlesource.com/c/chromium/src/+/4530656
* Split CertDatabase notifications between trust changes and client cert changes
https://chromium-review.googlesource.com/c/chromium/src/+/4596317
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-15 16:37:01 -04:00
Shelley Vohr
46fb0d8f5f
fix: webContents.print({ silent: true }) not working correctly ( #38741 )
...
fix: webContents.print({ silent: true }) not working correctly
2023-06-15 10:46:38 -04:00
Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-15 10:42:27 -04:00
Charles Kerr
bf1ba4a857
refactor: constexpr lookup tables ( #38771 )
...
* refactor: use a constexpr lookup table in GetPathConstant()
* refactor: use a constexpr lookup table in SystemPreferences::GetColor()
* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
2023-06-14 17:00:46 -04:00
electron-roller[bot]
bb4e9b27b5
chore: bump chromium to 116.0.5831.0 (main) ( #38784 )
...
* chore: bump chromium in DEPS to 116.0.5831.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-14 16:59:54 -04:00
github-actions[bot]
30579859c4
build: update appveyor image to latest version - e-116.0.5829.0 ( #38779 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-14 15:35:25 -04:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
Shelley Vohr
f7c0a29d89
build: update to latest TypeScript ( #38763 )
2023-06-14 11:06:46 -07:00
Shelley Vohr
10852b3fd5
fix: preferCSSPageSize error type ( #38761 )
...
fix: preferCSSPageSize error type
2023-06-14 10:49:00 -04:00
Milan Burda
dc2e822dc7
fix: asar integration for require('node:child_process') ( #38742 )
2023-06-14 18:03:53 +09:00
Samuel Attard
46458ab517
build: update typescript-generator and docs-parser ( #38747 )
...
* build: update typescript-generator and docs-parser
* again...
* build: handle more specific pageSize types
2023-06-13 16:22:53 -07:00
Keeley Hammond
9aefe5db33
build: move chrome_lib_arc to chromium_src/BUILD.gn ( #38764 )
2023-06-13 16:23:11 -04:00
Charles Kerr
167c2b250e
refactor: use compile-time cli arg sets. ( #38748 )
...
We're currently building these on the heap with `std::set<std::string>`
but this can be a very small compile-time container instead.
Marking as 'refactor' rather than 'perf' since this isn't called often,
but moving from heap to compile-time is good and using this container
makes the code more readable.
2023-06-13 14:37:59 -05:00
Milan Burda
1621fcf5d3
docs: add missing isSameDocument property to will-frame-navigate event details ( #37940 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 15:15:20 -04:00
github-actions[bot]
18d484f39c
build: update appveyor image to latest version e-116.0.5815.0. ( #38739 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-13 14:56:43 -04:00
Milan Burda
e37111edcc
build: remove enable_osr build flag ( #38703 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 14:48:53 -04:00
electron-roller[bot]
80a3ba5c68
chore: bump chromium to 116.0.5829.0 (main) ( #38726 )
...
* chore: bump chromium in DEPS to 116.0.5823.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5825.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5827.0
* chore: update patches
* 4568811: Integrate Search Prefetch with Extensions.
https://chromium-review.googlesource.com/c/chromium/src/+/4568811
* 4567511: [DevTools] Add recordCountHistogram API.
https://chromium-review.googlesource.com/c/chromium/src/+/4567511
* 4507692: Delete base/guid.h
https://chromium-review.googlesource.com/c/chromium/src/+/4507692
* 4589551: Convert some of /base to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4589551
Also:
4601769: Convert immersive mode controllers to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4601769
* [viz] Convert MaybeSizeInBytes() to take in SharedImageFormat
https://chromium-review.googlesource.com/c/chromium/src/+/4594677
* 4564108: [BRP] Enable check_raw_ptr_fields for Mac
https://chromium-review.googlesource.com/c/chromium/src/+/4564108
* chore: bump chromium in DEPS to 116.0.5828.0
* chore: bump chromium in DEPS to 116.0.5829.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-13 14:45:48 -04:00
Shelley Vohr
678d1aa37d
docs: clarify supported accelerator punctuation ( #38740 )
...
doc: clarify supported accelerator punctuation
2023-06-13 12:42:55 +02:00
David Sanders
f5869b6fb9
chore: change remaining usages of process.mainModule ( #38705 )
2023-06-12 09:55:36 +02:00
Charles Kerr
ab49e98401
perf: prefer base::StringPiece over std::string for build-time strings ( #38717 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
2023-06-12 09:55:22 +02:00
Shelley Vohr
fa6d14c22d
fix: webContents.print() cancellation callback ( #38709 )
...
fix: webContents.print() cancellation callback
2023-06-12 09:42:18 +02:00
Milan Burda
5d123765d9
feat: support node: prefixed requires in sandboxed renderer preloads ( #38567 )
...
feat: support node: prefixed requires in sandboxed renderer preloads
2023-06-10 14:36:16 -04:00
electron-roller[bot]
fd5e6fbc14
chore: bump chromium to 116.0.5817.0 (main) ( #38465 )
...
* chore: bump chromium in DEPS to 116.0.5793.3
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5795.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5797.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5799.0
* 4522192: [serial] Allow Bluetooth ports to be requested by service class ID. | https://chromium-review.googlesource.com/c/chromium/src/+/4522192
* 4545385: Create base::apple::Owned[frameworktype], use it for gfx::NativeEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4545385
* chore: bump chromium in DEPS to 116.0.5801.0
* chore: update patches
* 4562796: Use base::apple::Owned[frameworktype] for ui::PlatformEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4562796
* 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
* chore: bump chromium in DEPS to 116.0.5803.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5805.2
* chore: update patches
* 4547630: Move content/public/common/network_service_util.h to c/p/browser/ | https://chromium-review.googlesource.com/c/chromium/src/+/4547630
* 4510075: Adding extensions to network response experiment | https://chromium-review.googlesource.com/c/chromium/src/+/4510075
* 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: bump chromium in DEPS to 116.0.5807.0
* chore: update patches
* 4533536: [Privacy Hub] Geolocation manager used directly | https://chromium-review.googlesource.com/c/chromium/src/+/4533536
* chore: patch out ARC support from /chrome/browser
4571955: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4571955
* chore: bump chromium in DEPS to 116.0.5809.2
* chore: bump chromium in DEPS to 116.0.5811.0
* chore: update patches
* 4573627: Adopt base::NoDestructor for KeyedService factories | https://chromium-review.googlesource.com/c/chromium/src/+/4573627
* 4576878: Reland "Shared Storage: Add mojo method for observing response headers" | https://chromium-review.googlesource.com/c/chromium/src/+/4576878
* chore: bump chromium in DEPS to 116.0.5813.0
* chore: update patches
* fixup! 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: fix up lint
* test: (debug) use Promise.all in asan tests
* chore: manually roll DEPS to 116.0.5815.0
* chore: update patches
* 4585150: Convert /printing to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4585150
* test: (asan) extend timeout, clean up debugging
* chore: remove ARC chromium patch
* chore: update patches after main sync
* 4546398: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* build: add chrome_lib_arc for chromium_src/BUILD.gn sources
* fixup! 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-06-09 16:08:36 -07:00
Charles Kerr
a3448376a1
refactor: api web contents ownership ( #38695 )
...
* refactor: aggregate api::WebContents::exclusive_access_manager_ directly
* refactor: make WebContents::devtools_file_system_indexer_ scoped_refptr const
* refactor: make WebContents::file_task_runner_ scoped_refptr const
* refactor: make WebContents::print_task_runner_ scoped_refptr const
2023-06-09 15:28:11 -05:00
Shelley Vohr
c0d9764de9
fix: webContents.print parameter validation error ( #38614 )
2023-06-09 21:41:01 +02:00
Samuel Maddock
e8fd5fd3a8
fix: WCO transparent background ( #38693 )
...
* fix: WCO transparency
* doc: wco color transparency
* fix: transparent buttons when calling setTitleBarOverlay
2023-06-09 09:57:57 -07:00
Charles Kerr
d95ae19edf
refactor: add SessionPreferences::CreateForBrowserContext() ( #38656 )
...
Copy the NativeWindowRelay::CreateForWebContents() idiom
to simplify SessionPreferences's constructor and lifecycle.
2023-06-09 11:20:43 -05:00
Samuel Attard
12b85a77a8
build: upload node checksums before validating them ( #38710 )
2023-06-09 02:30:26 -07:00
Samuel Attard
38dc43f649
build: actually use m1.large for publish job ( #38706 )
2023-06-08 23:56:26 -07:00
Samuel Attard
43f5cf1eae
build: update sentry cli for m1 support ( #38704 )
2023-06-08 16:31:15 -07:00
David Sanders
2a81b2aea3
build: move uploadIndexJson to just before publishRelease ( #38659 )
...
* build: move uploadIndexJson to just before publishRelease
* chore: move uploadNodeShasums as well
2023-06-08 16:41:23 -04:00
Milan Burda
05d39d8313
build: remove enable_run_as_node build flag ( #38413 )
...
* feat: remove enable_run_as_node flag
* drop features.isRunAsNodeEnabled()
* use IsEnvSet() helper in electron_main_linux.cc
* cleanup [[maybe_unused]]
---------
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-08 16:40:08 -04:00
John Kleinschmidt
806f00285c
build: ensure correct dsymutil is downloaded for macOS ( #38692 )
2023-06-08 13:39:13 -07:00
Cheng Zhao
534bf77d9b
chore: modify patches so we can build other chromium targets ( #38637 )
...
chore: tune patches so we can build other chromium targets
2023-06-08 13:30:36 -04:00
Charles Kerr
9d8da7839e
fix: dangling pointer warning when updating menus ( #38643 )
2023-06-08 09:29:32 -05:00
Charles Kerr
95d6a932ca
build: use upstream's presubmit cpplint filters. ( #38638 )
2023-06-08 09:25:56 -05:00
David Sanders
4956bcc6bd
ci: remove release dependencies workflow ( #38646 )
2023-06-08 12:33:35 +02:00
wgsheng
c8bdd014c8
fix: menu bar visibility when exiting full screen ( #38599 )
2023-06-08 12:19:34 +02:00
Shelley Vohr
5ee890fb6f
fix: reparenting UAF crash on macOS ( #38603 )
2023-06-08 12:18:37 +02:00
Shelley Vohr
9a9d8ae5ea
refactor: add ARC scaffolding for macOS ( #38621 )
2023-06-08 10:26:33 +02:00
Milan Burda
0294debc31
build: remove enable_picture_in_picture build flag ( #38620 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-07 23:56:31 -07:00
Shelley Vohr
933544d449
chore: clean up ElectronPermissionManager ( #38636 )
...
chore: clean up ElectronPermissionManager
2023-06-07 23:55:36 -07:00
David Sanders
bbfba4fc24
build: fix semver/none label on appveyor update PR ( #38647 )
2023-06-07 23:52:05 -07:00
Dani Haro
be45614f6f
docs: indicate app.setBadgeCount() needs notifications permission to work ( #38648 )
...
docs: match docs for `app.badgeCount` and `app.setBadgeCount()`
2023-06-07 23:51:49 -07:00
Erick Zhao
1f08e46bca
docs: use local img for contents.adjustSelection api ( #38655 )
...
* docs: use local img for contents.adjustSelection api
* fixup
2023-06-07 23:49:19 -07:00
David Sanders
714402b08e
build: improve error output in release.js ( #38658 )
2023-06-07 16:49:12 -07:00
Samuel Attard
08ab45535d
build: use m1 hosts to build apple silicon binaries ( #38258 )
...
* build: try m1 speed test
* yolo?
* build: fix gn binary on m1
* build: remove arm64 snapshot logic
* build: strip x64 on arm64 hosts...
* if is fi
* build: no more GENERATE_CROSS_ARCH_SNAPSHOT
* build: chromedriver inline on arm64 darwin
* build: no copy chromedriver
* build: use m1 for publish
* medium?
2023-06-07 16:34:02 -07:00
Charles Kerr
69790f4b2a
refactor: remove unused OffScreenRenderWidgetHostView fields ( #38623 )
2023-06-07 16:28:35 -05:00
Shelley Vohr
c5972ba43c
fix: bad error passing webContents.print(null) ( #38612 )
...
fix: bad error passing webContents.print(null)
2023-06-07 19:18:26 +02:00
Shelley Vohr
86824c070e
fix: validate response in protocol.handle() ( #38587 )
...
fix: validate response in protocol.handle()
2023-06-07 09:29:04 +02:00
Charles Kerr
5931f69f18
fix: sync api::Screen wrapper method sigs to upstream ( #38597 )
...
refactor: sync api::Screen getter sigs to upstream
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(),
and GetDisplayNearestPoint() methods are all const, so make our wrappers
const too.
ui::Display GetAllDisplays() returns a const reference, so make our
wrapper return a const reference too. This avoids creating a new
std::vector<display::Display> each time it's called.
2023-06-07 09:28:50 +02:00
John Kleinschmidt
80246cf97f
docs: removed outdated Appveyor doc ( #38622 )
2023-06-06 15:38:07 -07:00
zeeker999
28332c94bf
feat: Allow customizing the default math font ( #38514 )
2023-06-06 17:26:32 -04:00
Charles Kerr
5c1321b20a
refactor: remove redundant resizing strategy equality check ( #38596 )
...
* refactor: remove redundant resizing strategy equality check
Upstream already checks this.
2023-06-06 14:03:39 -05:00
Shelley Vohr
7982c6cee2
build: remove V8 patch for ArrayBuffer DCHECK ( #38591 )
2023-06-06 10:21:58 +02:00
Shelley Vohr
b2059f288a
fix: account for BrowserView bounds in setting autofill popup bounds ( #38489 )
2023-06-06 10:21:42 +02:00
Milan Burda
bb2ba35b51
refactor: use process_util.h helpers ( #38574 )
...
refactor: use process_util.h helpers
2023-06-06 17:19:13 +09:00
Shelley Vohr
8d689c565a
fix: file selection when disallowed on macOS ( #38557 )
2023-06-05 14:08:10 +02:00
David Sanders
905aad9cb6
chore: type check JS in docs ( #38423 )
...
* build(deps): update @electron/lint-roller
* chore: type check JS in docs
* docs: add @ts-check and @ts-expect-error to code blocks
* chore: fix type check errors in docs
* chore: add ts-type to blocks
2023-06-05 16:26:26 +09:00
David Sanders
4c89061e0e
docs: fix SerialPort typing ( #38544 )
2023-06-05 15:58:30 +09:00
Milan Burda
8fdd7de3d2
docs: clarify which electron modules are exposed in sandboxed renderers ( #38568 )
2023-06-05 15:57:15 +09:00
Charles Kerr
83d023747c
refactor: use direct aggregation in NativeWindowViews ( #38559 )
...
* refactor: in NativeWindowViews, aggregate root_view_ directly
* refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly
* refactor: make NativeWindowClientView::window_ a raw_ref
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields
Prefer const raw_ref<T> whenever the held pointer will never be null
* chore: make lint happy
2023-06-05 14:37:46 +09:00
Charles Kerr
05db963f87
chore: remove unused electron::api::View code ( #38561 )
...
chore: remove unused electron::api::View methods
Remove code that was added in 2c8dc9e but never used.
2023-06-03 10:40:44 -05:00
Charles Kerr
f247ca3f62
perf: avoid unnecessary base value clone ( #38537 )
2023-06-02 08:38:29 -05:00
Shelley Vohr
d818f35ad4
build: fix doc-only early exit on Appveyor ( #38547 )
2023-06-01 10:40:35 -04:00
Sergey
9ffffdb6ef
docs: fix performance tutorial ( #38469 )
...
* docs: fixed "Analyze runtime performance" link
* docs: added missing list item
2023-05-31 15:56:06 -04:00
Charles Kerr
c14f7b7d0b
refactor: remove unused switches ( #38497 )
...
* refactor: remove unused declaration of electron::kSHA1Certificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MajorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MinorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kCertificateError
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificateDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription
usage removed in 497f5a1
* refactor: remove electron::options::kPreloadScripts
removed in bad8d5e0
* refactor: remove electron::options::kImageAnimationPolicy
removed in 385d0f5
2023-05-31 15:55:21 -04:00
David Sanders
74b8133a93
ci: set description for release labels ( #38528 )
2023-05-31 15:49:16 -04:00
Shelley Vohr
57147d1b8d
fix: navigator.connection not working as intended ( #38491 )
...
* fix: navigator.connection not working as intended
* chore: make network quality methods private
2023-05-31 11:06:25 -04:00
Milan Burda
67f273a6d6
docs: add <webview> new-window event removal to breaking-changes.md ( #36985 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-31 10:47:08 -04:00
Shelley Vohr
b454f8c7c1
build: combine and elaborate on exposed BoringSSL ciphers ( #38506 )
...
build: combine and elaborate on exposed BoringSSL ciphers
2023-05-31 10:30:04 -04:00
Shelley Vohr
663497dc6b
chore: make contentTracing.stopRecording() failure clearer ( #38488 )
...
chore: make contentTracing.stopRecording() failure clearer
2023-05-31 09:54:41 -04:00
Shelley Vohr
115d37477e
build: shrink unnecessary test changes in patch revert ( #38505 )
...
build: shrink unneccesary test changes in patch revert
2023-05-31 09:52:13 -04:00
Matt Henkes
2c742cfadb
chore: cherry-pick 0e1cc35 from v8 ( #38490 )
2023-05-31 11:58:48 +02:00
Shelley Vohr
40e724e5dd
fix: DCHECK minimizing parent window with non-modal child ( #38460 )
2023-05-31 11:57:44 +02:00
github-actions[bot]
13f9e2db40
build: update appveyor image to latest version ( #38449 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-30 21:13:33 -04:00
Shelley Vohr
a769b48164
ci: clean up docs only change logic ( #38456 )
2023-05-30 12:38:41 -04:00
John Kleinschmidt
b4ec363b3d
feat: add USB protected classes handler ( #38263 )
...
* feat: add USB protected classes handler
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs
* chore: apply review suggestions
* update doc per suggestion
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-05-30 12:35:25 -04:00
Milan Burda
71fb19ea14
chore: upgrade to eslint v8 ( #38472 )
...
chore: upgrade to eslint@8
2023-05-30 13:10:22 +02:00
Milan Burda
a6f7c7690d
refactor: use literals instead of new RegExp() where possible ( #38458 )
2023-05-30 10:53:11 +02:00
Charles Kerr
0203bd3305
refactor: prefer base::Contains() over find() + end() ( #38443 )
...
* refactor: use base::Contains() in KeyWeakMap::Has()
* refactor: use base::Contains() in WebRequest::RequestFilter::MatchesType()
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in DeepFreeze()
* refactor: use base::Contains() in Clipboard::Read()
* Revert "refactor: use base::Contains() in BaseWindow::AddBrowserView()"
This reverts commit 60152359d3978451ebdd7c8eed602c2fb8a9cafa.
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in IsDevToolsFileSystemAdded()
* refactor: use base::Contains() in MessagePort::DisentanglePorts()
* refactor: use base::Contains() in PowerSaveBlocker::IsStarted()
* refactor: use base::Contains() in SpellCheckClient::OnSpellCheckDone()
* refactor: use base::Contains() in ShowTaskDialogWstr()
* refactor: use base::Contains() in PrintViewManagerElectron::ScriptedPrint()
* refactor: use base::Contains() in PrintViewManagerElectron::DidGetPrintedPagesCount()
* refactor: use base::Contains() in NativeWindow::AddDraggableRegionProvider()
* refactor: use base::Contains() in ElectronBindings::ActivateUVLoop()
* refactor: use base::Contains() in NativeWindowViews::IsVisibleOnAllWorkspaces()
* refactor: use base::Contains() in HidChooserController::OnDeviceAdded()
* refactor: use base::Contains() in ElectronSandboxedRendererClient::WillReleaseScriptContext()
* refactor: use base::Contains() in ElectronRendererClient::WillDestroyWorkerContextOnWorkerThread()
* refactor: use base::Contains() in GlobalShortcut::OnKeyPressed()
2023-05-30 10:28:43 +02:00
Shelley Vohr
9640ac441d
build: make ReactiveObjC/Mantle deps format consistent ( #38450 )
2023-05-29 10:44:21 +02:00
Shelley Vohr
b233d0805a
chore: process.mainModule -> require.main ( #38452 )
...
chore: process.mainModule -> require.main
2023-05-29 10:44:09 +02:00
Shelley Vohr
56138d879e
fix: Windows FrameView always appearing inactive ( #38468 )
2023-05-28 18:39:13 -04:00
electron-roller[bot]
ddcec84ace
chore: bump chromium to 116.0.5791.0 (main) ( #38448 )
...
* chore: bump chromium in DEPS to 116.0.5791.0
* 4504298: Relax checks in BlobDataBuilder::AppendBlob.
https://chromium-review.googlesource.com/c/chromium/src/+/4504298
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-25 16:10:08 +02:00
Milan Burda
185180a8e2
refactor: tweak bindings in typings/internal-ambient.d.ts for readability ( #38411 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-25 14:53:23 +02:00
Milan Burda
470b1d9e9d
refactor: split clipboard module implementation for browser / renderer ( #38429 )
2023-05-25 20:36:12 +09:00
Charles Kerr
a20896f519
refactor: remove InspectableWebContents::GetAll() ( #38442 )
...
It is unused and also keeps a persistent std::list<>, so remove it.
2023-05-25 17:23:19 +09:00
electron-roller[bot]
64045fd058
chore: bump chromium to 115.0.5790.0 (main) ( #38418 )
...
* chore: bump chromium in DEPS to 115.0.5789.0
* 4550346: Revert "Convert /chrome/browser to use ARC"
https://chromium-review.googlesource.com/c/chromium/src/+/4550346
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5790.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-25 09:54:26 +02:00
David Sanders
294f196907
build: upgrade @electron/github-app-auth to 2.0.0 ( #38435 )
2023-05-25 09:54:09 +02:00
Milan Burda
82af000a37
chore: cleanup eslint suppressions ( #38417 )
...
* chore: cleanup eslint suppressions
* address feedback
* revert script/lib/azput.js
* revert spec/fixtures/apps/remote-control/main.js
* address feedback
* revert typings/internal-ambient.d.ts
2023-05-25 10:09:17 +09:00
github-actions[bot]
1c075e5ea0
chore: update appveyor image to latest version ( #38426 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-24 17:03:14 -04:00
Shelley Vohr
ec85be3fb0
docs: ensure app.md examples are runnable ( #38416 )
...
docs: ensure app.md examples are runnable
2023-05-24 16:41:29 -04:00
Milan Burda
06cc9caeaa
build: remove enable_desktop_capturer flag ( #38412 )
...
feat: remove enable_desktop_capturer flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 15:32:31 -04:00
Milan Burda
13fae292a7
build: remove unused enable_color_chooser build flag ( #38419 )
...
chore: remove unused enable_color_chooser build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 21:24:42 +02:00
Alexey Kuzmin
c4c17d7534
build: fix build with "enable_pdf_viewer=false" ( #38421 )
...
* build: fix build with "enable_pdf_viewer=false"
* fixup! build: fix build with "enable_pdf_viewer=false"
2023-05-24 14:37:07 -04:00
Milan Burda
a043a60b89
refactor: cleanup global variable declarations ( #38410 )
...
refactor: eliminate duplicate isolatedApi typing
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:01:07 +02:00
Milan Burda
2f8e68f8b3
chore: remove ViewsDelegate::IsWindowInMetro() override ( #38409 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:00:52 +02:00
Shelley Vohr
16cd486356
fix: MediaDevices missing DisplayMediaInformation ( #38390 )
...
fix: MediaDevices missing DisplayMediaInformation
2023-05-24 11:17:08 -04:00
David Sanders
f07b040cb9
build: update yarn.lock ( #38422 )
2023-05-24 10:19:47 +02:00
Milan Burda
b6ef4a3929
build: remove unused enable_tts build flag ( #38420 )
...
chore: remove unused enable_tts build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 10:18:43 +02:00
Cheng Zhao
dec9a1d9db
chore: remove dead draggable region code ( #38404 )
2023-05-24 10:03:07 +02:00
Charles Kerr
b6c80ba646
fix: dangling_raw_ptr warning in electron_api_web_contents ( #38403 )
...
fix: dangling_raw_ptr warning in electron_api_web_contents
2023-05-23 21:52:07 -04:00
Charles Kerr
30e992dec4
chore: bump chromium to 115.0.5786.0 (main) ( #38301 )
...
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609a ),
but upstream has removed this API.
CC @codebytere
* fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch
* chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
https://chromium-review.googlesource.com/c/chromium/src/+/4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
https://chromium-review.googlesource.com/c/chromium/src/+/4521894
* 4525355: Move backup_util and bundle_locations to base/apple
https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
https://chromium-review.googlesource.com/c/chromium/src/+/4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
https://chromium-review.googlesource.com/c/chromium/src/+/4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
https://chromium-review.googlesource.com/c/v8/v8/+/4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-23 21:58:58 +02:00
Kilian Valkhof
e7b8bb4766
docs: disablewebsecurity on webview-tag can not be changed for an active session ( #38373 )
...
disablewebsecurity on webview-tag can not be changed for an active session
2023-05-22 16:29:41 +02:00
Shelley Vohr
aebcd3a8c4
build: try removing V8 symbol export patch for Windows ( #38391 )
2023-05-22 15:10:29 +02:00
Bruno Pitrus
395abf5620
fix: linker error missing uv__strtok ( #38382 )
...
fix: linker error missing uv__strtok
This symbol is referenced inside what seems to be dead code
in `uv__search_path` in third_party/electron_node/deps/uv/src/unix/core.c
When compiling in LTO mode, the reference is removed,
but not during a non-LTO build.
2023-05-22 13:00:45 +02:00
Keeley Hammond
508d7c1353
docs: update timelines for E26 ( #38378 )
...
docs: update E26 timeline, add E22 support note
2023-05-19 12:05:45 -07:00
Shelley Vohr
826c29abcc
build: use @octokit/request v6.2.4 ( #38346 )
2023-05-18 15:37:58 -07:00
Milan Burda
2acb97aa85
chore: eliminate a few uses of base::AdaptCallbackForRepeating() ( #38293 )
2023-05-18 17:01:44 -04:00
Shelley Vohr
642950a00e
build: try removing V8 DCHECK patch ( #38341 )
2023-05-18 20:53:15 +02:00
Shelley Vohr
b35ec4a23c
build: modify gclient.py with unified patch ( #38351 )
...
* build: modify gclient.py with unified patch
* ci: ensure depot_tools does not update
* ci: move auto-update disable outside if
2023-05-17 14:54:26 -04:00
David Sanders
e138f5f915
docs: fix typing of message box type value ( #38336 )
...
* docs: fix typing of dialog type value
* test: add smoke tests
* test: update test
2023-05-17 10:33:30 -07:00
David Sanders
a22635bd9f
docs: update example to use app.whenReady() ( #38337 )
...
* docs: update example to use app.whenReady()
* docs: retain async
2023-05-17 10:32:59 -07:00
Shelley Vohr
683235daf0
build: combine V8 BUILD.gn patches ( #38342 )
...
* build: combine V8 BUILD.gn patches
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-17 13:17:52 +02:00
Shelley Vohr
32d8f84cad
fix: getNormalBounds() for transparent windows on Windows ( #38218 )
2023-05-17 13:11:43 +02:00
Shelley Vohr
ad07712561
fix: win.isMaximized() for transparent windows on Windows ( #38234 )
2023-05-17 10:17:08 +02:00
Shelley Vohr
9902e01d2c
build: remove CppHeapCreateParams patch ( #38321 )
...
build: remove CppHeapCreateParams patch
2023-05-17 09:52:29 +02:00
Shelley Vohr
e08c583dea
build: remove V8 ARM undefined symbol patch ( #38316 )
2023-05-17 09:52:10 +02:00
Samuel Attard
2a16c73834
chore: cherry-pick e6e23ba00379 from chromium ( #38323 )
...
* chore: cherry-pick e6e23ba00379 from chromium
* make it work
2023-05-16 15:21:22 -07:00
David Sanders
c7ca29e80f
chore: add smoke test for devtools-open-url ( #38302 )
2023-05-16 16:42:24 -04:00
Calvin
fa81f77f40
test: re-enable tests that aren't broken & remove old test ( #38251 )
2023-05-16 14:30:25 +02:00
Shelley Vohr
c05051e307
chore: remove obsoleted DecrementCapturerCount patch ( #38294 )
...
chore: remove obsoleted DecrementCapturerCount patch
2023-05-16 14:29:01 +02:00
Shelley Vohr
8b63a3fc8a
build: bump brew cache to v6 ( #38312 )
2023-05-16 12:38:30 +02:00
Shelley Vohr
e83197669c
fix: unify BrowserWindow.isVisible() logic cross-platform ( #38242 )
2023-05-16 11:46:45 +02:00
Shelley Vohr
9bd9d312f8
fix: enable BrowserWindow.id access post-destruction ( #38241 )
...
fix: enable BrowserWindow id access post-destruction
2023-05-16 09:29:00 +02:00
Shelley Vohr
042663e190
fix: isMaximized after minimize/fullscreen on macOS ( #38291 )
...
fix: isMaximized after isMinimized on macOS
2023-05-16 09:26:41 +02:00
Shelley Vohr
e19500fa03
feat: support Mica/Acrylic on Windows ( #38163 )
...
* feat: support Mica/Acrylic on Windows
* chore: feedback from review
2023-05-15 16:31:57 -04:00
Shelley Vohr
c2d7164021
chore: remove unnecessary spellchecker revert patch ( #38248 )
2023-05-15 16:17:00 -04:00
Shelley Vohr
a1b2dae68e
build: add labels to appveyor update PR ( #38292 )
2023-05-15 16:52:25 +02:00
David Sanders
c591ecf518
test: prewarm Node headers cache if specifying Electron version ( #38287 )
2023-05-15 02:10:22 -07:00
Samuel Attard
d1c5e623fa
build: drop python2 from CI ( #38259 )
...
* build: drop python2 from CI
* python3
* python3 uses linux not linux2
2023-05-15 02:06:12 -07:00
github-actions[bot]
9ac4787325
build: update appveyor image to latest version ( #38257 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-15 10:53:38 +02:00
Cesar Kohl
6645f49a9d
chore: variable name should comply with naming convention ( #38249 )
2023-05-15 10:30:22 +02:00
Shelley Vohr
e7fc1a422d
feat: add missing 'cursor-changed' type values ( #38210 )
2023-05-15 10:27:09 +02:00
David Sanders
eeb1e7d499
chore: fix lint:js-in-markdown script ( #38260 )
2023-05-15 09:58:35 +02:00
Milan Burda
0149ae72e6
refactor: use standard naming for enum class values ( #38232 )
2023-05-12 15:24:01 +02:00
Milan Burda
88a9962e22
refactor: convert HashAlgorithm to enum class ( #38233 )
2023-05-12 15:23:42 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Keeley Hammond
141175c723
build: disable v8 builtins pgo ( #38252 )
2023-05-10 20:53:18 -07:00
Keeley Hammond
95cd84f140
build: fix octokit resolution with patch-package ( #38250 )
2023-05-10 20:52:59 -07:00
electron-roller[bot]
894e056e6b
chore: bump chromium to 115.0.5760.0 (main) ( #38033 )
...
* chore: bump chromium in DEPS to 114.0.5721.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5723.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5725.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5727.0
* chore: bump chromium in DEPS to 114.0.5729.0
* chore: bump chromium in DEPS to 114.0.5731.0
* chore: update patches
* 4450570: Clean up content shell
https://chromium-review.googlesource.com/c/chromium/src/+/4450570
* 4262527: geolocation: Introduce mojom::GeopositionResult
https://chromium-review.googlesource.com/c/chromium/src/+/4262527
* 4450327 : Android/Nav: Stop taking content timeout timer from old host.
https://chromium-review.googlesource.com/c/chromium/src/+/4450327
Also, see:
4451366: Reland "Prerender: Fix prerender new content timeout start timing"
https://chromium-review.googlesource.com/c/chromium/src/+/4451366
* chore: bump chromium in DEPS to 114.0.5733.2
* chore: update patches
* chore: bump CircleCI xcode version
this will hopefully get us the necessary macOS sdk 13.3 on CI.
* chore: bump chromium in DEPS to 114.0.5735.0
* chore: update patches
* test: fix geolocation test
* chore: bump chromium in DEPS to 115.0.5736.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5738.0
* chore: update patches
* fix: remove profiles from spellcheck service
* chore: update libc++ filenames
* chore: bump chromium in DEPS to 115.0.5740.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5742.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5744.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5746.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 115.0.5748.0
* chore: update patches
* build: update libcxx filenames
* chore: bump chromium in DEPS to 115.0.5750.0
* chore: bump chromium in DEPS to 115.0.5752.2
* chore: bump chromium in DEPS to 115.0.5754.0
* chore: bump chromium in DEPS to 115.0.5756.0
* chore: bump chromium in DEPS to 115.0.5758.0
* chore: update patches
* chore: update patch after rebase
* 4500969: Delete content/dev_ui_content_resources.grd file.
https://chromium-review.googlesource.com/c/chromium/src/+/4500969
* Use base.Value.Dict in OmahaAttributesHandler related code
https://chromium-review.googlesource.com/c/chromium/src/+/4506402
* chore: bump chromium in DEPS to 115.0.5760.0
* chore: update patches
* chore: fixup line endings
* 4336172: Include client-drawn window decorations in aspect ratio. |
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4336172
(cherry picked from commit 27c2f6c43e )
* spec: fix race condition in alwaysOnTop test
(cherry picked from commit 2ec5213fa0 )
* build: use xcode 14.2 not 14.3
(cherry picked from commit b7c62351a7 )
* build: use macOS 12 to run tests
The new macOS 13 VMs appear to have different screen / display behavior
(cherry picked from commit 14dc1dbc24 )
* Remove always-true flag --harmony-sharedarraybuffer
https://chromium-review.googlesource.com/c/v8/v8/+/4429630
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2023-05-10 10:47:48 -04:00
Shelley Vohr
2806feede2
docs: fix devtools-open-url ts definition ( #38231 )
...
docs: fix devtools-open-url ts definition
2023-05-10 11:25:50 +02:00
Shelley Vohr
13e309e1fb
fix: only exit fullscreen conditionally with setKiosk ( #38219 )
...
fix: only exit fullscreen conditionally with setKiosk
2023-05-09 12:28:37 -04:00
Shelley Vohr
f432245456
fix: handle AXManualAccessibility attribute cross-protocol ( #38142 )
...
* fix: handle AXManualAccessibility attribute cross-protocol
* Update shell/browser/mac/electron_application.mm
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2023-05-09 11:13:14 +02:00
Shelley Vohr
0212c264ca
build: fix CRLF endings in messages.json ( #38212 )
2023-05-08 14:51:24 -04:00
David Sanders
9ccf2275d2
chore: migrate to @electron/lint-roller for Markdown linting ( #38191 )
2023-05-08 12:50:42 +02:00
David Sanders
911900eae9
build: add pretest script to create TS definitions ( #38201 )
2023-05-08 11:30:06 +02:00
David Sanders
7a03509b71
ci: automate release label tasks ( #38181 )
2023-05-08 10:39:28 +02:00
Shelley Vohr
a6c9aefb4a
chore: fix TrustedTypes policy in chrome://accessibility ( #38179 )
...
chore: fix TrustedTypes policy in chrome://accessibility
2023-05-08 10:39:04 +02:00
Calvin
13be6dc8b4
test: enable CircleCI's "re-run failed tests only" feature ( #38178 )
...
* test: enable CircleCI rerun failed *tests* only
* .
* .
* console.log never fails 🤷
* normalize the filtered paths
circleci gives us a list of absolute paths here
* remove test output check
sometimes rerunning only failed tests results in some runners having
no tests to run, and thus no output
* keep relative paths the same
* error for when no tests match
* cleanup
* .
2023-05-08 17:14:59 +09:00
David Sanders
3a7cfe300a
ci: do conditional in blocked/need-repro workflows at job level ( #38186 )
2023-05-08 17:07:04 +09:00
Adam Stone-Lord
88710612a3
docs: update dead link to Apple Human Interface notification guidelines ( #38187 )
2023-05-08 17:05:50 +09:00
Calvin
58d49927a3
test: disable flaky asar worker test on ASan build ( #38193 )
2023-05-08 17:03:30 +09:00
Shelley Vohr
534e90c2a6
build: force LF checkout of more files ( #38194 )
2023-05-08 17:02:42 +09:00
Shelley Vohr
35a03a6bc1
refactor: remove IPC from mouse_util ( #38183 )
2023-05-08 09:50:30 +02:00
David Sanders
a7adbae543
docs: fix typing of session.setDevicePermissionHandler ( #38188 )
2023-05-08 09:46:35 +02:00
Shelley Vohr
f8d534f33e
chore: stop using a RenderWidgetHost observer in FileSelectHelper ( #38168 )
...
chore: stop using a RenderWidgetHost observer in FileSelectHelper
2023-05-04 21:43:29 +02:00
David Sanders
ec75172d68
ci: update CircleCI CLI install URL ( #38176 )
2023-05-04 10:40:01 -04:00
Shelley Vohr
bb490161fb
fix: printing crash when settings invalid ( #38165 )
2023-05-04 09:10:54 -04:00
Alexey Kuzmin
bc957e3945
test: use await to call "closeWindow" ( #38166 )
...
* test: wait for an async "closeWindow" call
* fixup! test: wait for an async "closeWindow" call
2023-05-04 07:14:46 +09:00
Shelley Vohr
ee1e6aab3e
chore: implement WebContentsDelegate::GetFullscreenState ( #38141 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4255184
2023-05-03 15:55:47 +02:00
Russell Carpenella
7f5364f98d
docs: moves icpMain.handle call in tutorial part 3 ( #38138 )
2023-05-03 14:52:02 +02:00
Shelley Vohr
a8c0ed890f
feat: surface more webContents text selection commands ( #37978 )
...
* feat: surface more text selection commands
* refactor: use options argument
* docs: correct for review
2023-05-02 21:14:29 -04:00
David Sanders
a26343f3e0
fix: falsy transparent shouldn't affect webContents background ( #36914 )
2023-05-02 14:44:34 -07:00
Shelley Vohr
d95f9d2c63
chore: add OCR scaffolding to PDF Viewer ( #38127 )
2023-05-02 10:27:32 +02:00
Fedor Indutny
c548f8f59e
feat: net.resolveHost ( #37853 )
2023-05-02 09:53:00 +02:00
Milan Burda
7c482518bf
chore: add missing content::WebContentsDelegate section ( #38133 )
2023-05-01 09:23:47 -04:00
Shelley Vohr
a2d35e9cf5
test: re-enable extensions test with http server ( #38129 )
2023-04-28 01:20:46 +02:00
Shelley Vohr
ba8887f586
feat: emit context-menu event from extensions ( #38029 )
...
feat: emit context-menu event from extensions
2023-04-27 12:54:51 +02:00
Shelley Vohr
f35b9b3f06
fix: AXManualAccessibility showing failure ( #38102 )
...
fix: AXManualAccessibility showing failure
2023-04-26 19:41:56 +02:00
Bruno Pitrus
a0a44f07dd
chore: correct extra qualification causing build error with GCC ( #37548 )
...
* chore: correct extra qualification causing build error with GCC
* fixup for lint
* chore: fix lint
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-26 10:40:02 -04:00
David Sanders
08593fd2bd
chore: fix clang-tidy warnings ( #38079 )
...
* chore: fix clang-tidy warnings
* refactor: avoid need for NOLINTNEXTLINE
2023-04-26 10:09:54 -04:00
Shelley Vohr
fe5cdd39d6
test: re-enable passing Node.js tests ( #38116 )
2023-04-26 12:08:50 +02:00
Shelley Vohr
05faabe9e8
test: re-enable multi-window fullscreen test ( #38119 )
2023-04-26 10:13:36 +02:00
Shelley Vohr
9d525f9861
test: formally mark some Node.js tests as flaky ( #38117 )
2023-04-26 10:11:14 +02:00
Milan Burda
e823869bb0
docs: add separate linkable browser-window-options.md and web-preferences.md ( #34633 )
2023-04-25 15:16:11 +02:00
Shelley Vohr
f4b7e59b2d
fix: crash on missing RenderWidgetHostView ( #38100 )
...
chore: fix crash on missing RenderWidgetHostView
2023-04-25 11:30:16 +02:00
Francis Chartrand
a0a1a3645b
docs: fix start highlight tutorial-2-first-app.md ( #38069 )
...
doc: fix start highlight tutorial-2-first-app.md
2023-04-25 11:19:14 +02:00
David Sanders
9b41ab1e53
chore: always lint JS in docs/fiddles ( #38025 )
2023-04-24 10:35:14 -04:00
Black-Hole️
141f65b291
fix: webContents return type incorrect ( #38026 )
...
* fix: webContents type incorrect
* fix: ci failed
* fix: ci failed 2
2023-04-24 10:28:21 -04:00
Quang Lam
b626be5e33
docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings ( #38035 )
...
* Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings
* Add webContents
2023-04-23 22:16:38 +02:00
Milan Burda
964934c161
fix: defaults broken in shell.openExternal() options ( #38038 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-04-21 13:13:59 -04:00
github-actions[bot]
f727da4a74
ci: update appveyor image to latest version ( #38015 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-21 10:37:02 -04:00
Jason Etcovitch
cf4c46c8e0
build: fix Codespaces prebuilds with missing comma ( #38052 )
...
Add missing comma
2023-04-20 15:41:54 -07:00
Robo
0240f6664e
fix: crash in utilityProcess when generating code from strings ( #38014 )
2023-04-20 09:27:02 +09:00
Shelley Vohr
f12e12b341
chore: remove --no-harmony-atomics related code ( #38030 )
...
chore: remove --no-harmony-atomics related code
2023-04-19 10:29:18 -04:00
Shelley Vohr
7e715b66ae
test: re-enable reporting specs ( #35936 )
2023-04-19 14:24:38 +02:00
Jeremy Rose
ba835ddac1
feat: add thermal states to powerMonitor ( #37935 )
...
* feat: add thermal states to powerMonitor
* update docs
2023-04-19 11:46:55 +02:00
electron-roller[bot]
b2411e05a8
chore: bump chromium to 114.0.5719.0 (main) ( #38017 )
...
* chore: bump chromium in DEPS to 114.0.5719.0
* chore: update patches
* revert eb07a797cc
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-18 14:23:22 -07:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) ( #37973 )
...
* chore: bump node in DEPS to v18.16.0
* build,test: add proper support for IBM i
https://github.com/nodejs/node/pull/46739
* lib: enforce use of trailing commas
https://github.com/nodejs/node/pull/46881
* src: add initial support for single executable applications
https://github.com/nodejs/node/pull/45038
* lib: do not crash using workers with disabled shared array buffers
https://github.com/nodejs/node/pull/41023
* src: remove shadowed variable in OptionsParser::Parse
https://github.com/nodejs/node/pull/46672
* src: allow embedder control of code generation policy
https://github.com/nodejs/node/pull/46368
* src: allow optional Isolate termination in node::Stop()
https://github.com/nodejs/node/pull/46583
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* chore: fixup patch indices
* chore: sync filenames.json
* fix: add simdutf dep to src/inspector BUILD.gn
- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472
* deps: replace url parser with Ada
https://github.com/nodejs/node/pull/46410
* tls: support automatic DHE
https://github.com/nodejs/node/pull/46978
* fixup! src: add initial support for single executable applications
* http: unify header treatment
https://github.com/nodejs/node/pull/46528
* fix: libc++ buffer overflow in string_view ctor
https://github.com/nodejs/node/pull/46410
* test: include strace openat test
https://github.com/nodejs/node/pull/46150
* fixup! fixup! src: add initial support for single executable applications
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-18 22:23:11 +02:00
Samuel Attard
941153be32
build: bump dependencies to clean yarn audit ( #37998 )
...
* build: bump dependencies to clean yarn audit
* build: add url
2023-04-18 16:54:16 +02:00
Shelley Vohr
32afdda9ee
feat: add did-resign-active event on app ( #37933 )
...
feat: add did-resign-active event on app
2023-04-18 16:53:39 +02:00
github-actions[bot]
f4b172b9ec
ci: update appveyor image to latest version ( #37817 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-17 20:04:12 -04:00
electron-roller[bot]
7a6af1a529
chore: bump chromium to 114.0.5715.0 (main) ( #37976 )
...
* chore: bump chromium in DEPS to 114.0.5712.0
* chore: update patches
* 4401084: Remove extensions::InfoMap which is no longer needed. | https://chromium-review.googlesource.com/c/chromium/src/+/4401084
* 4415646: Add more details to print settings error log | https://chromium-review.googlesource.com/c/chromium/src/+/4415646
* chore: bump chromium in DEPS to 114.0.5714.0
* chore: update patches
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 114.0.5715.0
* chore: update patches
* fix extensions test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-17 14:40:26 -07:00
Alexey Kuzmin
1ffe7ee76b
build: fix building with no PDF support ( #38003 )
2023-04-17 11:02:43 -04:00
Shelley Vohr
c857c9b7e2
docs: add note to win.setFullScreen(flag) ( #37921 )
...
docs: add note to win.setFullScreen(flag)
2023-04-17 10:45:40 +02:00
Shelley Vohr
f0e1848a5e
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator& ( #37948 )
...
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator&
2023-04-16 17:08:37 -07:00
David Sanders
d1cddf2517
docs: update github.com links ( #37958 )
2023-04-15 21:20:59 -07:00
David Sanders
c7ea887227
chore: drop patch for fixed Linux menus issue in Views ( #37984 )
2023-04-15 21:20:34 -07:00
Shelley Vohr
fa3379a5d5
chore: fix lint ( #37971 )
2023-04-13 15:54:41 +02:00
Calvin
cdace75389
chore: disable flaky node test ( #37900 )
2023-04-13 13:27:45 +02:00
David Sanders
e84bcb39e7
fix: defaultFontFamily in webPreferences ( #37863 )
...
* fix: defaultFontFamily in webPreferences
* chore: check if default_font_family_ is empty
2023-04-13 11:30:25 +02:00
Shelley Vohr
fceeb64e7c
fix: swipe event emission on macOS ( #37946 )
2023-04-13 11:28:22 +02:00
Zenkie Bear
f03315ad4d
docs: Fix the syntax error for code fragment ( #37939 )
...
By using `app.on('ready').then(xxx)`, application will throw a TypeError
2023-04-13 10:00:27 +02:00
Michaela Laurencin
6f2ab392ab
docs: update 22-x-y EOL dates ( #37955 )
...
To account for https://www.electronjs.org/blog/electron-22-0#windows-7881-support-update
Not sure if it is worth adding as a historical change though
2023-04-12 18:10:47 -07:00
electron-roller[bot]
33a625d0ee
chore: bump chromium to 114.0.5710.0 (main) ( #37950 )
...
* chore: bump chromium in DEPS to 114.0.5710.0
* chore: update patches
* 4411421: [json-schema-compiler] Support separating numbers in enum entries |
https://chromium-review.googlesource.com/c/chromium/src/+/4411421
* 4400251: Remove MayBlock and TaskShutdownBehavior from BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4400251
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-04-12 18:10:31 -07:00
David Sanders
2ad1324b9d
ci: only remove blocked/need-repro on comment ( #37879 )
2023-04-12 16:33:59 -07:00
Jeremy Rose
fef1b04238
feat: remove on(ready) requirement from powerMonitor ( #37937 )
2023-04-12 15:37:52 -07:00
electron-roller[bot]
908bef7ca9
chore: bump chromium to 114.0.5708.0 (main) ( #37834 )
...
* chore: bump chromium in DEPS to 114.0.5696.0
* chore: update patches
* chore: revert clang revert
(cherry picked from commit 4c3ffa8001b5fdbfc99374bf77895d8d8e35ee31)
* test: remove unneeded test for title on ses.setCertificateVerifyProc
This test is unnecessary because all that really needs to be verified is that the request was rejected.
* chore: Revert "Reland "[BRP] Enable clang plugin check for Linux""
* chore: bump chromium in DEPS to 114.0.5697.0
* chore: bump chromium in DEPS to 114.0.5698.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5700.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5702.0
* chore: bump chromium in DEPS to 114.0.5704.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5705.0
* 4368281: Add bottom-up CertVerifier change observer flow. |
https://chromium-review.googlesource.com/c/chromium/src/+/4368281
* 4402277: Enable check_raw_ptr_fields for Linux |
https://chromium-review.googlesource.com/c/chromium/src/+/4402277
* 4389621: [ChromeAppsDeprecation] Remove deprecated chrome apps from AppService |
https://chromium-review.googlesource.com/c/chromium/src/+/4389621
* 4402191: Allow default initializing BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4402191
* chore: bump chromium in DEPS to 114.0.5708.0
* chore: remove incorrectly re-added clang patch
* chore: update patches (clean sync)
* ci: use newer clang for 32-bit Linux ARM
Fixes crash on compiling skia/skia/SkPatchUtils.cpp
* build: generate new libcxx filenames
* 4409898: Update paper printable area in UpdatePrintSettings |
https://chromium-review.googlesource.com/c/chromium/src/+/4409898
* chore: update sysroots.json
Sysroot CL: https://chromium-review.googlesource.com/c/chromium/src/+/4383374
Chromium CL: 4246577: media/gpu: Add CQP AV1 VA-API video encoder | https://chromium-review.googlesource.com/c/chromium/src/+/4246577
* 4336198: [task] Move source location and use it in v8 platform | https://chromium-review.googlesource.com/c/v8/v8/+/4336198
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-04-12 07:37:48 -04:00
Darshan Sen
c326b0068e
fix: recommended node-gyp version in node.h error ( #37829 )
...
fix: recommended node-gyp version in node.h error
In
https://github.com/electron/electron/blob/main/docs/tutorial/using-native-node-modules.md#using-npm ,
we recommend setting the `npm_config_disturl` variable but doing that
does not work on node-gyp v8.4.0 because after
https://github.com/nodejs/node-gyp/pull/2497
landed, the dist URL was read only from `gyp.opts['dist-url']`. The fix
for reading the value from `npm_config_disturl` by parsing
`gyp.opts.disturl` was landed in
https://github.com/nodejs/node-gyp/pull/2547 and that change was
released in node-gyp v9.0.0, so this change updates the error macro to
recommend node-gyp v9.0.0 as the minimum required version.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2023-04-11 13:26:26 +02:00
Samuel Attard
c01dff8d89
fix: exceptions during function/promise result conversions live in calling world ( #37904 )
2023-04-11 11:57:48 +02:00
Shelley Vohr
c65632d404
fix: broken buttons in PDF viewer ( #37856 )
2023-04-11 15:30:36 +09:00
David Sanders
adb1172066
chore: use nested namespaces ( #37855 )
2023-04-11 15:30:25 +09:00
David Sanders
e929b2140d
chore: change some for loops to range-based ( #37857 )
2023-04-11 15:27:07 +09:00
David Sanders
82442239bc
chore: use emplace when possible ( #37877 )
2023-04-11 15:21:03 +09:00
David Sanders
3c0c4d5c27
fix: menus on Linux after window modification ( #37798 )
...
* fix: menus on Linux after window modification
* test: don't run on CI
2023-04-11 15:17:45 +09:00
Samuel Attard
6958668448
fix: exceptions in nested conversions live in the target world ( #37895 )
2023-04-10 14:58:27 -07:00
Keeley Hammond
1e206deec3
docs: update E24/E25 breaking changes ( #37878 )
2023-04-06 21:23:29 -07:00
Mikael Finstad
e8c87859c4
fix: showAboutPanel also on linux ( #37828 )
...
showAboutPanel also on linux
2023-04-06 14:50:24 -04:00
Keeley Hammond
83e186fdbc
docs: update 21-x-y EOL dates ( #37841 )
...
* docs: update 21-x-y EOL dates
* doc: update node versions
2023-04-06 14:04:15 -04:00
David Sanders
9563b5f98b
test: support 'latest'/'latest@X' Electron version strings ( #37840 )
2023-04-06 14:03:14 -04:00
Shelley Vohr
251e567eff
fix: don't emit did-fail-load for MediaDocuments ( #37824 )
...
* fix: don't emit did-fail-load for MediaDocuments
* spec: add test
2023-04-06 10:23:34 +02:00
Fedor Indutny
6bfef67aae
feat: session.resolveHost ( #37690 )
...
* feat: session.resolveHost
Expose Chromium's host resolution API through the Session object.
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* address feedback
* fix tests
* address feedback
* Add options
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Update shell/browser/net/resolve_host_function.cc
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* lint
* return object
* add missing file
* fix crash
* handle scope
* links
---------
Co-authored-by: Fedor Indutny <indutny@signal.org >
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2023-04-05 10:06:14 -04:00
David Sanders
db27b9f433
chore: initial linting fixes for JS in docs/fiddles ( #37689 )
2023-04-05 09:42:20 -04:00
Shelley Vohr
be32740991
docs: fix app.getPreferredSystemLanguages() return type ( #37821 )
...
docs: fix app.getPreferredSystemLanguages() return type
2023-04-05 09:31:53 -04:00
Calvin
b8a21dbcd7
test: migrate to helpers & disabled tests list ( #37513 )
...
* test: migrate to helpers & disabled tests list
* can't disable a test suite
* correct condition
* address review comments
2023-04-04 09:48:51 -04:00
electron-roller[bot]
58f3c0ee37
chore: bump chromium to 114.0.5694.0 (main) ( #37820 )
...
* chore: bump chromium in DEPS to 114.0.5694.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-04 15:42:56 +02:00
Shelley Vohr
3f42040a1b
fix: Fn+F fullscreen transitioning on macOS ( #37803 )
2023-04-04 15:16:59 +02:00
Jeremy Rose
e9d5c3517c
fix: apply csp correctly when contextIsolation: false ( #37756 )
...
* fix: apply csp correctly when contextIsolation: false
* better comments
2023-04-04 17:31:49 +09:00
Shelley Vohr
91f62ae73f
refactor: only override V8Platform::CreateJob ( #37800 )
...
refactor: only override V8Platform::CreateJob
2023-04-04 10:28:28 +02:00
David Sanders
4c8583c365
test: remove workaround for fixed Menu.closePopup issue ( #37802 )
2023-04-04 10:27:51 +02:00
Shelley Vohr
0b4ef2b1e5
chore: combine parallel/test-v8-stats v8 patches ( #37801 )
...
* chore: combine parallel/test-v8-stats v8 patches
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-04 10:19:45 +02:00
electron-roller[bot]
4ba5723aed
chore: bump chromium to 114.0.5692.0 (main) ( #37806 )
...
* chore: bump chromium in DEPS to 114.0.5692.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-03 15:45:36 -07:00
Keeley Hammond
652d603e69
build: bump nmv to 116 (Electron 25) ( #37797 )
...
build: bump nmv to 116 (e25)
2023-04-03 15:26:31 -07:00
Jeremy Rose
f40bd2da23
fix: record helper error messages in electron_main_mac ( #37807 )
2023-04-03 13:14:19 -07:00
electron-roller[bot]
e31f101712
chore: bump chromium to 114.0.5690.0 (main) ( #37780 )
...
* chore: bump chromium in DEPS to 114.0.5686.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5688.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5690.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-03 18:56:57 +02:00
David Sanders
4415b7638a
chore: enforce consistent Markdown style for strong and emphasis ( #37787 )
2023-04-03 13:20:10 +02:00
github-actions[bot]
f7c6545eab
build: update appveyor image to latest version ( #37773 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-02 21:08:27 -07:00
Shelley Vohr
ef657bdc9d
chore: remove wasm CompileJSToWasmWrapperJob patch ( #37782 )
...
chore: remove wasm CompileJSToWasmWrapperJob patch
2023-04-01 08:47:54 -04:00
David Sanders
6012172187
fix: set background color for menu bar on Windows ( #37766 )
2023-03-31 18:06:09 +02:00
Samuel Attard
a75b892e90
build: remove request dependency ( #37747 )
...
* build: remove request dependency
* oops
2023-03-31 12:20:25 +02:00
Shelley Vohr
7c4f4c537e
build: fix build-tools schema in config ( #37765 )
2023-03-31 12:20:02 +02:00
Erick Zhao
4ca6fb3c4e
docs: update references to @electron/rebuild ( #37757 )
2023-03-31 11:36:59 +02:00
electron-roller[bot]
3fa03977c7
chore: bump chromium to 114.0.5684.0 (main) ( #37701 )
...
* chore: bump chromium in DEPS to 113.0.5672.0
* chore: bump chromium in DEPS to 114.0.5673.0
* chore: bump chromium in DEPS to 114.0.5675.0
* chore: update patches
* 4223697: [json-schema-compiler] T::Populate with base::Value::Dict
https://chromium-review.googlesource.com/c/chromium/src/+/4223697
* chore: update filenames.libcxx.gni
* 4290476: Report an explicit pause reason when stopping after taking a step.
https://chromium-review.googlesource.com/c/v8/v8/+/4290476
* chore: bump chromium in DEPS to 114.0.5682.0
* 4373699: [SystemProfileSelectionDefaultNone] Enable feature by default
https://chromium-review.googlesource.com/c/chromium/src/+/4373699
* chore: update patches
* Revert AsyncCompileJSToWasmWrapperJob simplification
https://chromium-review.googlesource.com/c/v8/v8/+/4347597/11
* 4365718: Reland "Reland "Reland "[Tracing] Use Perfetto client library for tracing on Linux"""
https://chromium-review.googlesource.com/c/chromium/src/+/4365718
* chore: bump chromium in DEPS to 114.0.5684.0
* chore: update patches
* 4335544: [handles] Refactor classes for abstract handles
https://chromium-review.googlesource.com/c/v8/v8/+/4335544
* update patch description to include tracking issue
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-03-30 22:03:58 -04:00
David Sanders
75919e28b8
docs: add links to IPC event structures ( #37760 )
2023-03-30 10:13:21 -07:00
Jeremy Rose
ac58607605
docs: remove save-to-disk disposition ( #37758 )
2023-03-30 10:07:54 -07:00
David Sanders
835ace243c
ci: don't use pull_request_target with semantic PR title check ( #37745 )
2023-03-29 14:28:52 -07:00
John Kleinschmidt
8f3ef39f1e
chore: update line endings on HTML files ( #37755 )
2023-03-29 15:02:13 -04:00
David Sanders
48e13fde80
docs: update docs.microsoft.com links to learn.microsoft.com ( #37707 )
2023-03-29 12:16:44 +02:00
David Sanders
bb6648b79e
chore: force LF endings for .html files in .gitattributes ( #37704 )
2023-03-28 11:17:16 -04:00
Will Anderson
2b9dae4b06
feat: add will-frame-navigate event ( #34418 )
...
* feat: add will-navigate-in-frame event to webContents
* docs: add documentation for webview will-frame-navigate event
* feat: Eliminate isInPlace argument from will-frame-navigate event
* fix: Fire will-frame-navigate before will-navigate
* feat: send will-frame-navigate with a WebFrameMain in the event details
* docs: Update WebContents docs for new API signature
* feat: Add custom event forwarding for <webview> will-frame-navigate
* fix: wrap WebFrameMain so it can be sent as an event
* test: update webContents and <webview> tests to match new signatures
* chore: undo unnecessary change
* fix: don't switch will-navigate to use EmitNavigationEventDetails
* test: clean up will-navigate and will-frame-navigate tests for <webview>
* chore: apply lint fixes
* chore: move GetRenderFrameHost helper into anonymous namespace
* docs: auto-generate WillFrameNavigateDetails rather than defining it manually
* test: Update <webview> tests to actually pass under new spec runner
* docs: Add section explaining relationship between various nav events
* test: Add some tests to ensure navigation event order doesn't silently change
* test: Always monitor all nav events to ensure unexpected ones don't fire
* test: Add test to verify in-page navigation event order
* feat: Change to new style where extra params are exposed as event props
* fix: Remove unused EmitNavigationEventDetails
* fix: Update tests to use new async helpers
* docs: Rename and reorder sections documenting navigation events
---------
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-03-28 10:55:41 -04:00
Mikołaj Sawicki
2e1f803f37
docs: updated package.json content and electron version in build first app guide ( #37554 )
...
* Docs: updated package.json content and electron version in build first app guide
* docs: removed caret from electron version
2023-03-28 10:53:20 -04:00
Shelley Vohr
4c6092e151
fix: draggable regions shouldn't capture clicks on frames windows ( #37594 )
2023-03-28 10:52:28 -04:00
github-actions[bot]
b72f81ab5b
ci: fixup update appveyor image workflow ( #37684 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-27 20:57:27 -04:00
Shelley Vohr
97b19a7946
chore: generator objects can't be sent over the context bridge ( #37593 )
...
* chore: generator objects can't be sent over the context bridge
* Trigger Build
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-27 20:36:55 -04:00
Shelley Vohr
b27e4cae21
fix: crash in MessagePortMain with some postMessage params ( #37585 )
...
* fix: crash in MessagePortMain postMessage
* Update shell/browser/api/message_port.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-03-27 13:56:55 -04:00
Peter Xu
1e106c8aa4
docs: fixup incorrect value for disabling sandbox ( #37711 )
2023-03-27 13:27:55 -04:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
John Kleinschmidt
6a6908c4c8
fix: allow cancelling of bluetooth requests ( #37601 )
...
* fix: allow cancelling of bluetooth requests
allows cancelling of bluetooth requests when no devices present
* docs: update docs to reflect how bluetooth works.
2023-03-27 09:31:15 -04:00
electron-roller[bot]
42e7cd9b3f
chore: bump chromium to 113.0.5670.0 (main) ( #37675 )
...
* chore: bump chromium in DEPS to 113.0.5670.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-23 17:15:56 -04:00
John Kleinschmidt
8cf03f5661
ci: fixup gn check to actually run gn check ( #37676 )
2023-03-23 15:02:08 -04:00
electron-roller[bot]
916861036d
chore: bump chromium to 113.0.5668.0 (main) ( #37646 )
...
* chore: bump chromium in DEPS to 113.0.5668.0
* chore: update patches
* chore: fixup for lint
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-22 20:09:13 -04:00
Erick Zhao
52481bc923
docs: update notifications tutorial ( #37602 )
...
* docs: update notifications tutorial
* delete unused assets
2023-03-21 21:40:43 -04:00
electron-roller[bot]
5023b49713
chore: bump chromium to 113.0.5666.0 (main) ( #37634 )
...
* chore: bump chromium in DEPS to 113.0.5666.0
* chore: update patches
* Make Clear-Site-Data: "cookies" respect third-party cookie blocking
https://chromium-review.googlesource.com/c/chromium/src/+/4346675
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-21 21:19:23 -04:00
Erick Zhao
2ac9ff1f20
docs: change MSDN links to new Microsoft docs ( #37603 )
2023-03-21 11:39:19 -04:00
electron-roller[bot]
46d3c4e04f
chore: bump chromium to 113.0.5664.0 (main) ( #37620 )
...
* chore: bump chromium in DEPS to 113.0.5664.0
* chore: update patches
* [Code Health] Migrate to WebUIDataSource::CreateAndAdd(), part 8
https://chromium-review.googlesource.com/c/chromium/src/+/4121701
Needed because of 4349773: Get rid of WebUIDataSource::Create() and WebUIDataSource::Add() | https://chromium-review.googlesource.com/c/chromium/src/+/4349773 landing
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-20 21:37:21 -04:00
John Kleinschmidt
0f77fec9d9
ci: make sure that strip_binary.gni is properly preserved ( #37626 )
2023-03-20 20:06:27 -04:00
dependabot[bot]
94f701edb8
build(deps-dev): bump webpack from 5.73.0 to 5.76.0 ( #37583 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.73.0 to 5.76.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.73.0...v5.76.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-20 13:33:08 -04:00
Charles Kerr
caa5989eed
fix: avoid deprecated value apis ( #37590 )
...
* fix: use base::Value::Dict:::Remove() instead of RemoveKe()
the latter is deprecated.
* fix: use base::Value::Dict::FindString() instead of base::Value::FindStringKey()
The latter is deprecated.
* chore: make lint happy
2023-03-20 10:38:45 -04:00
George Joseph
e0c348a2f8
feat: Allow usage of an absolute path for partitions used in a session ( #37604 )
...
* Allow an absolute path to be used for creating sessions
Allows an absolute path to be used for creating sessions
by adding the session.fromPath() API.
* Fixup! Clarify that an emptry string is not permitted as a parameter to fromPath()
2023-03-20 10:34:49 -04:00
Shelley Vohr
eb613ef3d4
fix: invoke app.dock.{hide|show} instead of duplicating logic ( #37599 )
...
fix: invoke app.dock.{hide|show} instead of duplicating logic
2023-03-20 10:30:49 -04:00
Milan Burda
7ed3c7a359
chore: remove unnecessary casting to base::Value ( #37591 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-03-20 10:26:42 -04:00
David Sanders
64b39dce14
docs: update broken links ( #37610 )
2023-03-20 10:25:54 -04:00
electron-roller[bot]
5261e08d0c
chore: bump chromium to 113.0.5660.0 (main) ( #37612 )
...
* chore: bump chromium in DEPS to 113.0.5657.0
* chore: bump chromium in DEPS to 113.0.5660.0
* chore: update patches
printing.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4347664
https://chromium-review.googlesource.com/c/chromium/src/+/4347664
https://chromium-review.googlesource.com/c/chromium/src/+/4338810
https://chromium-review.googlesource.com/c/chromium/src/+/4339496
mas_disable_remote_layer.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4334544
https://chromium-review.googlesource.com/c/chromium/src/+/4335299
* Add API to verify `TOP_LEVEL_STORAGE_ACCESS` permission status
https://chromium-review.googlesource.com/c/chromium/src/+/4306712
* Move os_crypt into a sync/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/4336304
* chore: generate libc++ headers
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-20 07:06:57 -04:00
John Kleinschmidt
9611b641c9
chore: Use thread_local: base/threading/ ( #37600 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4335524
2023-03-17 09:27:41 -04:00
Erick Zhao
095f9067a7
docs: delete synopsis.md ( #37580 )
...
* docs: delete synopsis.md
* remove code references to doc
2023-03-16 17:05:15 -07:00
Shelley Vohr
b8f970c1c7
fix: properly bubble up cookie creation failure message ( #37586 )
2023-03-16 13:48:14 +01:00
electron-roller[bot]
48d0b09ad9
chore: bump chromium to 113.0.5653.0 (main) ( #37587 )
...
* chore: bump chromium in DEPS to 113.0.5653.0
* chore: update patches
* [Extensions c2s] Move HasActiveTabAndCanAccess() to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/4305558
* [Privacy Hub] Respecting ChromeOS geoloc setting
https://chromium-review.googlesource.com/c/chromium/src/+/4171824
* Add runtime DLLs to win_clang_x64 when needed
https://chromium-review.googlesource.com/c/chromium/src/+/4336228
* chore: fix lint
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-16 19:03:53 +09:00
John Kleinschmidt
c5fc5efc00
chore: update filenames.libcxx.gni ( #37588 )
2023-03-15 15:41:32 -04:00
Milan Burda
6dc46e5bcf
refactor: replace deprecated base::Value::Set<Type>Key usage ( #37570 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-03-15 09:07:51 -04:00
electron-roller[bot]
061e2e5e73
chore: bump chromium to 113.0.5651.0 (main) ( #37553 )
...
* chore: bump chromium in DEPS to 113.0.5645.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4300129
Fix simple code shear
* chore: update patches/chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297496
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4327491
patch-fuzz update; no manual changes
* chore: remove patches/chromium/fix_x11_window_restore_minimized_maximized_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4252946
Upstreamed by zcbenz, so local patch is no longer needed
* chore: update chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019
Remove cookie parameter from PrintViewManagerBase::UpdatePrintSettings()
* chore: remove NOTIMPLEMENTED BrowserProcessImpl::GetBreadcrumbPersistentStorageManager()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4247145
method removed upstream, so we do not need to add a stub for it in the subclass
* chore: remove PrintViewManagerElectron::UpdatePrintSettings()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019
Previously, our implementation checked to see if we recognized the
cookie param that was passed in. If so, we reported a bad message.
Otherwise, we passed it up to the base class' UpdatePrintSettings().
CL4313019 removed the cookie param, so checking for a bad cookie
param is no longer necessary / no longer possible. Since the only
remaining task was to pass the work up to the base class, this commit
removes the subclass implmentation entirely.
* chore: update patches
* chore: bump chromium in DEPS to 113.0.5647.0
* chore: bump chromium in DEPS to 113.0.5649.2
* chore: bump chromium in DEPS to 113.0.5651.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-15 18:20:32 +09:00
Jeremy Spiegel
bf1cc1aeb2
fix: don't set delegate for QLPreviewPanel ( #37530 )
...
fix: don't set delegate for QLPreviewPanel
2023-03-14 14:41:34 +01:00
Shelley Vohr
e480cb7103
docs: clarify open-url not preventable ( #37564 )
...
docs: clarify open-url not preventable
2023-03-14 14:17:28 +01:00
github-actions[bot]
3b69a542fb
build: update appveyor image to latest version ( #37561 )
...
* build: update appveyor image to latest version
* build: update appveyor-woa.yml with latest image
* build: modify action to update both appveyor & appveyor-woa
---------
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-03-13 19:44:27 -04:00
Yureka
82456c6915
refactor: DEPS: remove squirrel.mac from recursedeps ( #37496 )
...
DEPS: remove squirrel.mac from recursedeps
squirrel.mac repository does not contain a gclient DEPS file, so recursing into it is useless
2023-03-13 22:16:23 +01:00
John Kleinschmidt
e58f0411d9
chore: fixup filenames.libcxx.gni ( #37567 )
2023-03-13 13:55:25 -04:00
electron-roller[bot]
e61728beb9
chore: bump node to v18.15.0 (main) ( #37532 )
...
* chore: bump node in DEPS to v18.15.0
* chore: update patches
* chore: update node filenames patch
* chore: re-enable parallel/test-intl
* chore: disable parallel/test-webcrypto-wrap-unwrap
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-03-13 09:51:03 -04:00
electron-roller[bot]
feaf18e371
chore: bump chromium to 113.0.5636.0 (main) ( #37130 )
...
* chore: bump chromium in DEPS to 112.0.5576.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4211172
* 4191759: Reuse PrintBackend process from query for printing
https://chromium-review.googlesource.com/c/chromium/src/+/4191759
* 4189718: Revert "[code health] Remove NotificationService use by SpellcheckService"
https://chromium-review.googlesource.com/c/chromium/src/+/4189718
* 4216074: web_contents_delegate: remove content::
https://chromium-review.googlesource.com/c/chromium/src/+/4216074
* 4192284: ios: Add feature flag for PartitionAlloc.
https://chromium-review.googlesource.com/c/chromium/src/+/4192284
* chore: bump chromium in DEPS to 112.0.5578.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4211172
* 4067682: Define ThirdPartyCookiesUserBypass runtime feature and plumb it through to URLRequest.cookie_setting_overrides.
https://chromium-review.googlesource.com/c/chromium/src/+/4067682
* chore: fixup patch indices
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: fixup patch indices
* chore: bump chromium in DEPS to 112.0.5579.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5581.0
* chore: update patches
* refactor: use modern base values in tracing
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4210912
* refactor: remove GetFontLookupTableCacheDir
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4191820
* refactor: base value type DICTIONARY replaced with DICT
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4198081
* chore: add stub impls for WCO routing
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4182690
* refactor: rename latency metrics
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4048262
* refactor: add sanitized context to clipboard write
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4178264
* refactor: s/Rect/WindowFeatures
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4167001
* refacotr: switch mojom::NetworkHintsHandler to use SchemeHostPair instead of URL
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4185417
* chore: remove dead DecodeToken code
* refactor: refactoring geolocation manager
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4161603
* chore: iwyu net/cert/cert_verify_result.h
* build: use xcode 14
* chore: bump chromium in DEPS to 112.0.5583.0
* chore: update patches
* chore: fixup mas patches
* refactor: base::span explicit conversion checks
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4219636
* chore: bump chromium in DEPS to 112.0.5591.0
* chore: bump chromium in DEPS to 112.0.5593.0
* chore: bump chromium in DEPS to 112.0.5594.3
* chore: bump chromium in DEPS to 112.0.5597.0
* chore: update chromium patches
* 4242507: Move most of GetChromeKeySystems() into components/cdm
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4242507
It seems as though the bug this patch was trying to resolve is now fixed.
* chore: update v8 patches
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* 4247938: Bump min required GTK version to 3.20
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4247938
* 4173660: Remove unused argument in BeforeUnloadCompleted
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4173660
* 4226656: Add response url to SimpleURLLoader::OnRedirectCallback
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4226656
* fixup!: 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManager Host.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* chore: bump chromium in DEPS to 112.0.5599.0
* chore: update patches
* 4251237: [StorageKey Cleanup] (2) Rename CreateFirstParty constructors
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4251237
* 4256866: [Extensions] Replace GetHooksForAPI with a RegisterHooksDelegate
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4256866
* chore: bump chromium in DEPS to 112.0.5601.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5603.0
* chore: bump chromium in DEPS to 112.0.5605.0
* chore: bump chromium in DEPS to 112.0.5607.0
* update patches
* fix mas patch
* chore: bump chromium in DEPS to 112.0.5609.0
* chore: update patches
* build: update appveyor image
4072083: New toolchain for Windows 11 10.0.22621.755 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/4072083
* chore: bump chromium in DEPS to 112.0.5611.0
* fix patches
* chore: update patches
* 4261434: Remove browser_watcher (1/3): Move ExitCodeWatcher to chrome/app
https://chromium-review.googlesource.com/c/chromium/src/+/4261434
* 4258446: Move network::mojom::ClearDataFilter to its own mojom file
https://chromium-review.googlesource.com/c/chromium/src/+/4258446
* 4128591: Enable large pdbs by default
https://chromium-review.googlesource.com/c/chromium/src/+/4128591
* move dbgcore/dbghelp to extensions_to_skip
* chore: bump chromium in DEPS to 113.0.5624.0
* chore: bump chromium in DEPS to 113.0.5626.0
* chore: bump chromium in DEPS to 113.0.5628.2
* chore: bump chromium in DEPS to 113.0.5630.0
* chore: bump chromium in DEPS to 113.0.5632.0
* chore: bump chromium in DEPS to 113.0.5634.0
* chore: bump chromium in DEPS to 113.0.5636.0
* 4255184: Permit popups from fullscreen-within-tab openers
https://chromium-review.googlesource.com/c/chromium/src/+/4255184
* 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
https://chromium-review.googlesource.com/c/chromium/src/+/4297715
* 4301154: Remove GLContextCGL and cleanup relevant code
https://chromium-review.googlesource.com/c/chromium/src/+/4301154
* 4278389: CDP: fix Page.addScriptToEvaluateOnNewDocument in iframes
https://chromium-review.googlesource.com/c/chromium/src/+/4278389
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* 4291989: Refactor logic determining untrusted mojo invitation flag.
https://chromium-review.googlesource.com/c/chromium/src/+/4291989
* 4110189: Add Select option to content touch selection menu.
https://chromium-review.googlesource.com/c/chromium/src/+/4110189
* 4309923: [Extensions] Add a unit test for API permissions having features
https://chromium-review.googlesource.com/c/chromium/src/+/4309923
* 4282657: Revert "[headless] Route stdio to parent console on Windows."
https://chromium-review.googlesource.com/c/chromium/src/+/4282657
* 4306685: [v8] Improve V8 flag configuration to avoid errors
https://chromium-review.googlesource.com/c/chromium/src/+/4306685
* 4295455: Add fallback Linux UI for when GTK 3.20 isn't available
https://chromium-review.googlesource.com/c/chromium/src/+/4295455
* 4289774: Remove feature for shared sandbox policies
https://chromium-review.googlesource.com/c/chromium/src/+/4289774
* 4292705: Rename WebSwapCGLLayer to ANGLESwapCGLLayer outside WebKit.
https://chromium-review.googlesource.com/c/angle/angle/+/4292705
* chore: fixup patch indices
* fixup! 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
* 4289789: Remove base::JSONReader::ReadDeprecated
https://chromium-review.googlesource.com/c/chromium/src/+/4289789
* 4281521: Remove `base::Value::FindKey()`
https://chromium-review.googlesource.com/c/chromium/src/+/4281521
* 4276761: Update NAK constructor and GetIsCrossSite
https://chromium-review.googlesource.com/c/chromium/src/+/4276761
* 4288119: Let GetUpload work with UploadInfo pointers
https://chromium-review.googlesource.com/c/chromium/src/+/4288119
* 4285322: content: Move WebExposedIsolationLevel to its own public header
https://chromium-review.googlesource.com/c/chromium/src/+/4285322
* 4251818: [Extensions] Make ExtensionSet moveable.
https://chromium-review.googlesource.com/c/chromium/src/+/4251818
* 4299554: [json-schema-compiler] Refactor to Params::Create (14/74)
https://chromium-review.googlesource.com/c/chromium/src/+/4299554
* chore: update printing patch indices
* chore: update chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4295455
Our patch changes the signature of `LinuxUiTheme::GetWindowFrameProvider()`.
Upstream 4295455 added a new subclass (FallbackLinuxUi) so sync its version
of GetWindowFrameProvider() to match our changes.
* chore: disable node test parallel/test-intl
Disabling the test because upstream is still working on this feature.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1414292
When upstream churn is done we should re-enable this test and update
it as necessary.
* win7dep: Remove ResolveCoreWinRTStringDelayload
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4277708
Upstream has removed this since Win7 support is deprecated.
This updates our `language_util_win.cc` file using the same
approach that 4277708 uses for `base/win/win_util.cc`.
* fix: remove use of ResolveCoreWinRTDelayload()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297979
A followup to prev commit, which removed ResolveCoreWinRTStringDelayload().
This PR follows the 4297979 approach of simply removing the calls, e.g.
https://chromium-review.googlesource.com/c/chromium/src/+/4297979/4/chrome/browser/device_reauth/win/authenticator_win.cc
* fix: add d3dcompiler_47 to the zip manifest
Xref: https://chromium-review.googlesource.com/c/angle/angle/+/4285717
Xref (24-x-y): 0fb1def32b
* This clang roll breaks Linux arm 32-bit
Xref (24-x-y): 1229114494
Xref (chromium): https://crbug.com/1410101
* fix: WebUSB on ARM64 macs (#37441 )
* chore: update patches
* chore: fix macOS CI build.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4278307
That whole dir was previously being removed to save space since we don't
use it. We still don't use anything in the file, but gn needs it to exist.
* fixup! chore: fix macOS CI build.
chore: mkdir --parents does not exist on BSD; use mkdir -p
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4273450
Upstream added a new block of code using NSAccessibilityRemoteUIElement,
so stub it out with `#if !IS_MAS_BUILD()` same as we do everwhere else.
* chore: address code review nit :)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-10 10:07:42 -06:00
Shelley Vohr
8ee58e18fd
refactor: createThumbnailFromPath takes size not maxSize ( #37362 )
...
refactor: createThumbnailFromPath takes size not maxSize
2023-03-08 21:48:29 -05:00
Erick Zhao
f33bf2a271
docs: remove outdated ipc example ( #37523 )
2023-03-08 21:41:26 -05:00
Keeley Hammond
77bd80dfb2
fix: fallback to X11 capturer if pipewire fails on Wayland ( #37511 )
...
* fix: fallback to x11 desktop capturer on Wayland
* fix: sanitize window/screen capturer inputs
* chore: clean up patch description
2023-03-07 13:59:06 -08:00
John Kleinschmidt
0d3aee26b9
docs: fixup WebUSB fiddle ( #37455 )
...
docs: fixup webusb fiddle
2023-03-07 21:36:31 +01:00
John Kleinschmidt
efde7a140b
fix: WebUSB on ARM64 macs ( #37441 )
2023-03-07 12:40:40 -05:00
Jeremy Rose
4e85bb921b
docs: remove misleading info from will-finish-launching docs ( #37514 )
2023-03-06 16:24:52 -08:00
Shelley Vohr
512e56baf7
feat: expose audio-state-changed on webContents ( #37366 )
...
feat: expose audio-state-changed on webContents
2023-03-06 17:00:24 +01:00
Calvin
c8f715f9a1
fix: Showing the about panel is async on all platforms ( #37440 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
* what if the about dialog was not blocking
* add this test back in
* document synchronicity
* github editor is a fan of spaces
2023-03-06 09:46:35 -05:00
Shelley Vohr
829fb4f586
fix: don't double-log unhandled rejections ( #37464 )
2023-03-06 11:04:43 +01:00
Shelley Vohr
17ccb3c6ec
refactor: leverage Skia helpers for NSColor ANSI logic ( #37452 )
2023-03-03 09:42:50 +01:00
Jeremy Rose
6bd9ee6988
feat: net.fetch() supports custom protocols ( #36606 )
2023-03-02 15:47:45 -08:00
Jeremy Rose
76c825d619
fix: draggable regions on MAS ( #37466 )
2023-03-02 11:21:51 -08:00
Kevin Law
692876c737
docs(clipboard): fix an issue of demo code ( #37438 )
...
doc(clipboard): fix an issue of demo code
2023-03-02 12:24:59 +01:00
Jeremy Rose
c3f06ef037
fix: DCHECK in MessageSync in rare cases ( #37439 )
2023-03-02 10:03:52 +01:00
Shelley Vohr
9b20b3a722
chore: improve contents.takeHeapSnapshot error messages ( #37434 )
...
* chore: improve contents.takeHeapSnapshot error messages
* fix wstring conversion issue
2023-03-01 10:50:36 -05:00
Shelley Vohr
8f2917db01
fix: min/max width/height enforcement when aspectRatio is set ( #37306 )
...
fix: min/max width/height with aspect ratio
2023-03-01 10:50:14 -05:00
Theo Gravity
49df19214e
feat: add enableLocalEcho flag to setDisplayMediaRequestHandler() callback ( #37315 )
2023-03-01 11:37:19 +01:00
Shelley Vohr
5e25d23794
fix: handle closing webContents in BrowserViews ( #37420 )
...
* fix: handle closing webContents in BrowserViews
* test: add window.close() test
2023-03-01 11:35:06 +01:00
Shelley Vohr
8fb0f43030
fix: Notification with reply obscuring first action on macOS ( #37381 )
...
fix: Notification with reply obscuring first action
2023-03-01 09:46:56 +01:00
Calvin
1f390119fe
test: add disabled tests list ( #37334 )
2023-02-28 17:27:54 -05:00
Shelley Vohr
87f2a1d572
fix: BroadcastChannel initialization location ( #37421 )
...
* fix: BroadcastChannel initialization location
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-28 17:26:37 -05:00
Calvin
2e03bdb9b6
fix: about panel crash ( #37373 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
2023-02-28 17:26:00 -05:00
Jeremy Rose
3a5ae28c95
feat: expose initiator in navigation events ( #37085 )
2023-02-28 11:08:22 -08:00
Milan Burda
ed7b5c44a2
feat: add types to webRequest filter ( #30914 )
2023-02-27 11:16:59 -08:00
Milan Burda
edf887bdc5
refactor: use _loadURL(url, options ?? {}); ( #37337 )
2023-02-27 10:05:58 +01:00
David Sanders
1ff7f098f1
chore: set wg-releases as owner of /docs/breaking-changes.md ( #37405 )
2023-02-24 11:34:23 -08:00
David Sanders
fb100e8f49
chore: remove dead config code for trop ( #37406 )
2023-02-24 11:11:04 -08:00
Jeremy Rose
3384908da1
docs: document change in draggable region behavior on macOS ( #37396 )
2023-02-24 11:10:27 -08:00
John Kleinschmidt
73bd9a3155
ci: rename Electron build step to include type of build being built ( #37371 )
...
ci: rename Electron build step to describe what is being built
2023-02-23 21:13:54 -05:00
Jeremy Rose
e27905c765
fix: allow contextmenu event in draggable regions ( #37386 )
2023-02-23 16:05:30 -08:00
Jeremy Rose
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise ( #37374 )
2023-02-23 15:53:53 -08:00
electron-roller[bot]
46c8b9c728
chore: bump node to v18.14.2 (main) ( #37380 )
...
* chore: bump node in DEPS to v18.14.2
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-22 19:17:03 +01:00
Shelley Vohr
6395898a79
refactor: use associated v8::Context for event setup ( #37355 )
...
refactor: use associated v8::Context for event setup
2023-02-22 10:03:46 +01:00
Shelley Vohr
32c60b29bb
fix: html fullscreen when window not fullscreenable ( #37348 )
2023-02-21 12:11:34 +01:00
Black-Hole
868676aa5c
feat: add httpOnly cookies.get filter ( #37255 )
...
feat: add httpOnly cookies filter
2023-02-21 11:44:35 +01:00
Shelley Vohr
85cf56d80b
fix: guard more private API usage on MAS builds ( #37309 )
2023-02-21 11:44:18 +01:00
Cheng Zhao
a92fd2aa05
fix: restoring X11 window should not remove previous maximize state ( #37346 )
2023-02-21 09:49:02 +01:00
Shelley Vohr
ee966ad6ec
build: remove unused python code ( #37351 )
2023-02-21 09:48:52 +01:00
Jeremy Rose
872d1fe05a
feat: implement net.fetch ( #36733 )
2023-02-20 12:57:38 -08:00
electron-roller[bot]
63f94f2359
chore: bump node to v18.14.1 (main) ( #37332 )
...
* chore: bump node in DEPS to v18.14.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-20 09:22:08 -08:00
Mikael Finstad
67a6fbf265
docs: fixed a typo in process.defaultApp doc ( #37342 )
...
docs: improve `defaultApp`
2023-02-20 13:06:19 +01:00
Milan Burda
f97d68c4bf
test: convert functions to async & eliminate duplicates ( #37316 )
...
test: convert functions to async
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-20 12:30:57 +01:00
Milan Burda
969665eaa2
test: type-safe import of menu-item-roles in api-menu-item-spec.ts ( #37320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-19 01:27:03 -08:00
Milan Burda
0d8dd61257
test: use expect(dir).to.be.an.instanceof(fs.Dirent); ( #37331 )
2023-02-19 01:25:40 -08:00
Milan Burda
cf10c19c33
test: cleanup let xyz = null as unknown as T; ( #37335 )
2023-02-19 01:24:24 -08:00
Milan Burda
fcfbcbc7e1
test: move desktopCapturer usage from renderer to main in ts-smoke ( #37321 )
2023-02-17 16:29:36 -06:00
Milan Burda
e34cc6f48c
test: enable linting of ts-smoke and fix all issues ( #37322 )
2023-02-17 12:56:09 -06:00
Milan Burda
ee87438d28
test: use async helpers to simplify tests ( #37314 )
...
test: use async helpers to simplify the tests
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-17 12:32:39 -06:00
Cheng Zhao
0de1012280
feat: add BrowserWindow.set/getWindowButtonPosition APIs ( #37094 )
2023-02-17 19:06:32 +09:00
Milan Burda
0a5e634736
test: rename & split internal module tests ( #37318 )
2023-02-17 10:14:40 +01:00
Alexey Kuzmin
73b7aac6a4
test: fix "crash cases" tests not failing properly ( #37304 )
...
* test: fix "crash cases" tests not failing properly
* fixup! test: fix "crash cases" tests not failing properly
2023-02-17 10:14:00 +01:00
Milan Burda
ea848bc1c5
test: use webContents.create() in type-safe way ( #37281 )
...
test: use (webContents as typeof ElectronInternal.WebContents).create()
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-16 15:41:41 +01:00
Shelley Vohr
a44e76fb70
build: strip warnings from stdout in get_release ( #37277 )
...
build: strip warnings from stdout in get_release
2023-02-16 15:20:19 +01:00
Shelley Vohr
3138acc377
chore: remove redundant Node.js patch ( #37279 )
...
* chore: fix patch for other patch
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-16 15:18:47 +01:00
Milan Burda
beed240454
test: use render-process-gone event in tests ( #37280 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-16 01:25:41 -08:00
Milan Burda
fdab0799fe
docs: only macOS 10.13+ is supported now ( #37286 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-15 16:29:02 -08:00
Keeley Hammond
17ea7f42fc
build: ignore makeLatest on pre-releases ( #37274 )
...
* build: ignore makeLatest on pre-releases
* chore: set makeLatest to false by default
Co-authored-by: Samuel Attard <sam@electronjs.org >
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2023-02-14 21:12:07 -08:00
Shelley Vohr
d0cf9c4b08
build: add missing is_verbose_mode import ( #37273 )
...
build: add missing is_verbose_mode import
2023-02-14 22:52:53 +01:00
Keeley Hammond
fe7c535a3f
chore: add logging for debugging release json ( #37270 )
...
* chore: add debug logging for JSON
* chore: better logging
2023-02-14 13:03:50 -08:00
Shelley Vohr
8eee4f2df1
fix: BrowserView crash when 'beforeunload' prevented ( #37205 )
...
fix: crash when beforeunload prevented
2023-02-14 18:40:37 +01:00
Keeley Hammond
4d6f230d21
build: re-bake node v18.12.1 image for asset upload ( #37254 )
...
* debug: peek node version
* build: force uninstall/reinstall 18.12.1
* build: update image, re-comment out deps
* build: remove nodejs-lts uninstall, node debug line
2023-02-14 07:44:39 -08:00
Shelley Vohr
889859df5b
feat: include all standard paper sizes for webContents.print() ( #37159 )
2023-02-14 11:44:34 +01:00
Andrew Ferreira
cb03c6516b
docs: add win.isFocusable() return type ( #37245 )
...
docs: fix `win.isFocusable()` return type
2023-02-14 10:01:22 +01:00
Shelley Vohr
2e8114aea3
refactor: simplify Node.js event loop with SpinEventLoop ( #34884 )
...
refactor: simplify Node.js event loop with SpinEventLoop
2023-02-14 09:54:09 +01:00
Milan Burda
a38b711fb1
feat: add logUsage to shell.openExternal() options ( #37139 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-14 17:53:18 +09:00
Keeley Hammond
3972073116
build: revert to e-110.0.5451.0 on Appveyor ( #37253 )
2023-02-13 18:13:34 -08:00
Keeley Hammond
8c986ff194
build: bake node v18.12.1 Appveyor image ( #37250 )
...
* chore: bake a new AppVeyor image
* build: use image e-111.0.5560.0-4
* build: remove nodejs-lts
* build: use new baked image
2023-02-13 14:03:12 -08:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
Black-Hole
8b3e498436
fix: cookies filter secure invalid ( #37203 )
2023-02-13 15:02:55 +01:00
Samuel Attard
cf80994729
build: set make_latest correctly on published releases ( #37233 )
2023-02-13 01:16:27 -08:00
Jeremy Rose
01f1522cbd
chore: change undocumented protocol.registerProtocol to detect body type ( #36595 )
...
* feat: add protocol.registerProtocol
* remove wip handleProtocol code
* lint
* Update shell/browser/net/electron_url_loader_factory.h
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
* fix
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2023-02-13 16:48:30 +09:00
David Sanders
a37f572388
chore: update links in comments ( #37197 )
2023-02-11 18:52:54 -08:00
Milan Burda
3180312595
chore: update https://cs.chromium.org/ links to https://source.chromium.org/ ( #37190 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-11 18:52:32 -08:00
John Kleinschmidt
ff60fe25c1
ci: update appveyor build agent ( #37211 )
...
ci update appveyor image
2023-02-11 13:28:28 -05:00
Shelley Vohr
12ed401ca2
chore: re-enable worker spec failures ( #37015 )
2023-02-09 18:18:35 +01:00
Milan Burda
e5e9186d61
docs: add missing clipboard-sanitized-write permission value to setPermissionRequestHandler() ( #37173 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-09 11:38:39 +01:00
Shelley Vohr
478ce96914
fix: avoid using v8 on Isolate termination ( #35766 )
...
* fix: avoid using v8 on Isolate termination
* chore: refactor for review
---------
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-02-09 09:48:49 +01:00
Jeremy Rose
8dc98aeeae
chore: remove load-url event ( #37174 )
2023-02-09 14:40:37 +09:00
Milan Burda
35a9e67dba
chore: rename built-in modules to bindings to match naming update in node ( #37182 )
2023-02-09 10:31:38 +09:00
Samuel Attard
8b380ee2f2
test: ensure fullscreen test is retryable ( #37179 )
...
spec: ensure fullscreen test is retryable
2023-02-08 12:40:24 -08:00
Shelley Vohr
a15c9d3058
test: Node.js hkdf tests work now ( #37180 )
2023-02-08 13:35:28 -05:00
David Sanders
22de86d5f4
docs: remove reference to electron/releases ( #37164 )
2023-02-08 15:27:09 +01:00
Samuel Attard
8783d03a59
test: mark some node specs as flaky ( #37181 )
2023-02-08 15:19:02 +01:00
Bruno Pitrus
df6f99aa72
fix: correct redefinition which is invalid C++ ( #36096 )
...
* fix: correct redefinition which is invalid C++
See https://stackoverflow.com/a/15538759 for an explanation of class scope.
GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE
* Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
---------
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2023-02-08 16:03:47 +09:00
Samuel Attard
00a542358d
build: only retry tests on CI ( #37167 )
2023-02-07 22:44:53 -08:00
Jeremy Rose
9a0a0a7a46
fix: type for received-apns-notification event ( #37177 )
2023-02-07 22:43:29 -08:00
Milan Burda
6a3cb34326
fix: expose native bindings by process type ( #35949 )
2023-02-07 20:22:18 -05:00
electron-roller[bot]
de607cbcde
chore: bump node to v18.14.0 (main) ( #37129 )
...
* chore: bump node in DEPS to v18.14.0
* src: add support for externally shared js builtins
https://github.com/nodejs/node/pull/44376
* test: fix test broken under --node-builtin-modules-path
https://github.com/nodejs/node/pull/45894
* build: add option to disable shared readonly heap
https://github.com/nodejs/node/pull/45887
* src: remove unnecessary semicolons
https://github.com/nodejs/node/pull/46171
* src: remove return after abort
https://github.com/nodejs/node/pull/46172
* chore: fixup patch indices
* test_runner: parse yaml
https://github.com/nodejs/node/pull/45815
* src: use simdutf for converting externalized builtins to UTF-16
https://github.com/nodejs/node/pull/46119
* src: rename internal module declaration as internal bindings
https://github.com/nodejs/node/pull/45551
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-02-07 15:51:07 -05:00
David Sanders
7abe38b46e
build: fix version check in release_dependency_versions.yml ( #37155 )
...
* build: fix version check in release_dependency_versions.yml
* chore: also mksnapshot
2023-02-07 11:38:50 -05:00
David Sanders
d17507e3f6
docs: use relative links within docs ( #37042 )
2023-02-07 19:28:24 +09:00
Keeley Hammond
9b2b3aa287
docs: update stable dates ( #37150 )
2023-02-06 13:42:58 -08:00
github-actions[bot]
b4acbbb1e9
build: update appveyor image to latest version ( #37151 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-02-06 13:42:32 -08:00
David Sanders
dc972b3919
chore: remove old script code for ATOM_SHELL_ ( #37140 )
...
The TODO is from 2016, seems like it's time
2023-02-06 13:07:45 -08:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
Milan Burda
8d382b9c60
chore: remove deprecated capturer count APIs ( #37075 )
...
chore: remove deprecated incrementCapturerCount() / decrementCapturerCount()
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-06 07:54:47 -08:00
Samuel Attard
7dcd97f864
fix: enable basic a11y when voice control is active ( #37122 )
...
c.f. https://chromium-review.googlesource.com/c/chromium/src/+/2680102
2023-02-06 20:32:21 +09:00
David Sanders
9ec13afeaf
docs: add missing ipcRenderer require to example code ( #37134 )
2023-02-06 14:40:16 +09:00
dependabot[bot]
9c0dcaf36b
build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 ( #37132 )
...
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases )
- [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: http-cache-semantics
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-04 13:50:33 -08:00
Samuel Attard
e60b0958e2
build: update spec dependencies to clean up yarn audit ( #37116 )
2023-02-03 13:17:05 -08:00
Shelley Vohr
0524b4e98a
build: allow workflow_dispatch on scheduled Actions ( #37128 )
2023-02-03 20:55:04 +01:00
electron-roller[bot]
d02c9f8bc6
chore: bump chromium to 111.0.5544.3 (main) ( #36820 )
...
* chore: bump chromium in DEPS to 111.0.5522.0
* chore: bump chromium in DEPS to 111.0.5524.0
* chore: bump chromium in DEPS to 111.0.5526.0
* chore: bump chromium in DEPS to 111.0.5528.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807
Fix simple code shear
* chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675
Fix simple code shear
* chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/disable_unload_metrics.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/preconnect_manager.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch
https://chromium-review.googlesource.com/c/v8/v8/+/3533019
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches
* chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765
Upstream added a new call to HeaderContext(), whose signature we have patched
* chore: bump chromium in DEPS to 111.0.5530.0
* chore: update patches
* Move ChildProcessHost* from content/common to content/browser
Xref: Move ChildProcessHost* from content/common to content/browser
* Remove RenderViewHostChanged
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[upstream removal of RenderViewHostChanged]
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[examples of upstream code adjusting to the change]
Upstream handles this change in roughly two approaches:
1. Move the code over to RenderFrameHostChanged(old_host, new_host)
but test for new_host->IsInPrimaryMainFrame() before acting
2. Migrate to the PrimaryPageChanged(page) API and use
page.GetMainDocument() to get the RenderFrameHost.
I've chosen 1. because electron_api_web_contents needed that pointer
to old_host to call RemoveInputEventListener(), but I may be missing
some context & would appreciate review on this commit.
* Make electron/shell/browser/relauncher_win.cc use <winternl.h>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135
Many internal Windows types are now available in winternl.h
so upstrem no longer defines the types themselves.
* Move ChildProcessHost* from content/common to content/browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795
* fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h>
winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace
* fixup! Move ChildProcessHost* from content/common to content/browser
chore: update #includes too
* chore: bump chromium in DEPS to 111.0.5532.0
* chore: sync patches/chromium/pepper_plugin_support.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/chromium/mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865
the content/common/pseudonymization_salt.cc patch is no longer needed
* chore: sync patches/chromium/mas_disable_remote_accessibility.patch
patch-fuzz update; no manual changes
* chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725
manually reync patch; no code changes
* chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230
patch-fuzz update; no manual changes
* chore: rebuild patches
* fixup! Remove RenderViewHostChanged
Use PrimaryPageChanged()
* chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991
This private, already-unused function showed up as a FTBFS because it
took a base::ListValue parameter and ListValue was removed upstream.
* task posting v3: remove includes of runner handles and IWYU task runners
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
* chore: lint
* chore: more lint
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
macOS, too
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
* chore: bump chromium in DEPS to 111.0.5534.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110
Sync to minor upstream changes. Add const correctness.
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787
patch-fuzz update; no manual changes
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5536.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
Sync with upstream code changes. Minor code golf for readability.
Note: upstream is laying groundwork for being able to work off of env vars
instead of switches. Doesn't affect us yet but worth being aware of.
> + // Environment variables could be supported in the future, but are not
> + // currently supported when launching with the zygote.
* chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836
patch-fuzz update; no manual changes
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
manual sync
* chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
https://chromium-review.googlesource.com/c/v8/v8/+/4147788
fuzz-patch
* chore: rebuild patches
* chore: bump chromium in DEPS to 111.0.5538.0
* chore: bump chromium in DEPS to 111.0.5540.0
* chore: update patches
* Remove sdk_forward_declarations
https://chromium-review.googlesource.com/c/chromium/src/+/4166680
* task posting v3: Remove task runner handles from codebase entirely
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928
* Cleanup child_process_launcher_helper*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* fix: utilityprocess spec on macOS
* fix: build on windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* chore: fix lint
* chore: bump chromium 111.0.5544.3
* chore: gen filenames.libcxx.gni
* Add check for Executable+Writable handles in renderer processes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416
* fixup! Add check for Executable+Writable handles in renderer processes.
* 4143761: [110] Disable SwiftShader for WebGL on M1 Macs.
https://chromium-review.googlesource.com/c/chromium/src/+/4143761
(cherry picked from commit 2f74db3c21 )
* chore: bump chromium to 111.0.5555.0
* 56085: Remove hmac.h include from ssl.h.
https://boringssl-review.googlesource.com/c/boringssl/+/56085
* 4167020: Remove forwarding headers
https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* chore: bump chromium to 111.0.5559.0
* 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura
https://chromium-review.googlesource.com/c/chromium/src/+/4181044
* 4189437: views: rename ink_drop_host_view to ink_drop_host
https://chromium-review.googlesource.com/c/chromium/src/+/4189437
* chore: bump chromium to 111.0.5560.0
* 4167016: win7dep: remove non aeroglass code
https://chromium-review.googlesource.com/c/chromium/src/+/4167016
* fixup after rebase: Remove forwarding header
s https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* 4125755: Reland "Reject getDisplayMedia calls without user activation"
https://chromium-review.googlesource.com/c/chromium/src/+/4125755
* test: add workaround
* chore: update patches
* fix: alter coreModuleRegExp to prevent arm crash
* Revert "fix: alter coreModuleRegExp to prevent arm crash"
This reverts commit 7e50630c98 .
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: review changes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-02-03 12:43:42 +01:00
Milan Burda
446c7809cc
refactor: process event emitting for sandboxed renderers ( #37109 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-03 11:59:57 +01:00
Samuel Attard
6e0d63c356
build: update mocha for retries and audit fix ( #37117 )
2023-02-02 17:40:30 -08:00
Samuel Attard
d069b8fc66
build: actually upload symbol zips ( #37124 )
2023-02-02 17:39:51 -08:00
Samuel Attard
1a6085e20e
docs: improve globalShortcut and hookWindowMessage types ( #37115 )
2023-02-02 12:31:28 -08:00
Shelley Vohr
33c32a798b
build: remove mips64el build config ( #37093 )
...
build: remove mips64el build config
2023-02-02 20:53:54 +09:00
David Sanders
23ae0dde17
docs: use automatic link syntax for symbol server link ( #37089 )
2023-02-02 19:16:41 +09:00
Milan Burda
ac266e2187
docs: remove invalid appcache value from storages in clearStorageData() ( #37095 )
2023-02-01 17:35:21 -08:00
Jeremy Rose
6aa7e27b39
fix: nodeIntegrationInWorker fails to boot in AudioWorklets ( #37041 )
2023-02-01 16:03:23 -08:00
Shelley Vohr
2dc76d0d80
build: fixup release_dependency_versions action ( #37036 )
2023-02-01 19:12:19 +01:00
Milan Burda
fd761ec8f7
chore: strip trailing whitespace ( #35969 )
2023-02-01 12:59:16 +01:00
Samuel Attard
dbdbb6fb3b
build: bump deps to clean up yarn audit ( #36535 )
...
build: update dependencies to clean up yarn audit
2023-01-31 13:58:39 -08:00
Shelley Vohr
26ee197fe5
chore: validate .mjs spec files in Node.js smoke tests ( #37073 )
...
chore: take mjs spec files in Node.js smoke tests
2023-01-31 12:36:27 -08:00
Shelley Vohr
730a07ad62
docs: note how to clear an aspect ratio ( #37074 )
2023-01-31 12:36:09 -08:00
David Sanders
01b4e3b521
ci: update actions/stale to v6.0.1 ( #37079 )
2023-01-31 12:30:40 -08:00
David Sanders
899881457b
docs: update modules list in docs/README.md ( #37080 )
2023-01-31 12:29:33 -08:00
John Kleinschmidt
9adbf49240
ci: fixup ninja for release ( #37083 )
2023-01-31 11:29:39 -05:00
Milan Burda
c6203d54d0
refactor: simplify script/lint.js ( #37077 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-31 14:33:50 +01:00
Shelley Vohr
23739c644b
fix: crash on WebWorkerObserver script execution ( #37050 )
...
fix: crash on WebWorkerObserver script execution
2023-01-31 12:29:29 +01:00
Shelley Vohr
ce35bda805
fix: crash on window.print() ( #37052 )
...
fix: crash on window.print()
2023-01-31 12:06:11 +01:00
John Kleinschmidt
fcc7a869f2
ci: ensure correct ninja is used ( #37069 )
2023-01-30 12:35:38 -05:00
Jeremy Rose
85f41d59ac
fix: ensure autofill popup view is > 1x1 in size ( #36121 )
...
* fix: ensure autofill popup view is > 1x1 in size
ref #26667
* Update shell/browser/ui/views/autofill_popup_view.cc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-27 10:50:19 +01:00
Shelley Vohr
0026fdb78a
fix: resizing borders in nondraggable regions ( #37016 )
...
* fix: resizing borders in nondraggable regions
* chore: remove frame handling from ShouldDescendIntoChildForEventHandling
2023-01-26 14:04:19 +01:00
Mikaël Barbero
1486cbdf64
feat: add support for unlocking with Apple Watch ( #36935 )
2023-01-26 13:05:42 +01:00
Cheng Zhao
c303135b02
fix: fallback to GtkStatusIcon when app indicator is not supported ( #36815 )
...
* chore: get ready for multi backend tray
* fix: fallback to GtkStatusIcon when app indicator is not supported
* chore: use smart pointers
2023-01-26 19:15:55 +09:00
Shelley Vohr
7d46d3ec9d
feat: emit devtools-open-url event for DevTools link selection ( #36774 )
...
* feat: emit event for DevTools link selection
* chore: devtools-open-in-new-tab -> devtools-open-url
2023-01-26 09:54:26 +01:00
Himanshu Patil
8d008c977d
docs: updated deep link docs ( #36952 )
...
* removed open-url listener from windows code
* updated deep-link fiddle
* fixed url hash to app.requestSingleInstanceLock
* code linted
* updated website url to relative file path
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-01-26 16:20:10 +09:00
Shelley Vohr
c6b9340b89
chore: fix memory leak in v8.serialize() ( #37021 )
...
chore: fix memory leak in v8.serialize()
2023-01-26 15:43:57 +09:00
Milan Burda
397aee7315
chore: update README.md ( #37002 )
...
Update README.md
2023-01-26 09:57:20 +09:00
Robo
a30a9c7c4f
chore: remove crashpad related sandbox policy ( #37013 )
2023-01-26 09:01:34 +09:00
kyrylo-hrechykhin
a59f11fdb1
feat: enable whole-program optimization native modules by default ( #36937 )
...
* feat: enable whole-program optimization
Enable whole-program optimization in electron native modules by default.
* pass --with-ltcg to configure.py instead of setting variable
* enable ltcg only on windows
Co-authored-by: Kyrylo Hrechykhin <khrechykhin@microsoft.com >
2023-01-25 13:06:05 -08:00
Samuel Attard
58beec1da2
fix: do not error on null exports in ESM loader ( #37009 )
2023-01-25 13:03:47 -08:00
Milan Burda
4bc6b15f53
refactor: move spec helpers to spec/lib ( #37010 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 13:01:25 -08:00
Milan Burda
355f322dbd
chore: remove unused fixture_support.md ( #37011 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 13:00:51 -08:00
Milan Burda
2f79444535
refactor: separate WEB_VIEW_ATTRIBUTES / WEB_VIEW_ERROR_MESSAGES ( #36972 )
2023-01-25 16:08:46 +01:00
Milan Burda
a9b6041d38
chore: remove unused files in spec/fixtures ( #37012 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 16:02:44 +01:00
Shelley Vohr
afca3ff965
chore: call ListenerDestroyed() in FileSelectHelper::RunFileChooserEnd() ( #37006 )
...
chore: call ListenerDestroyed() in FileSelectHelper::RunFileChooserEnd()
2023-01-25 15:51:01 +01:00
Shelley Vohr
86f99e9cf0
chore: cleanup ElectronContentClient::AddPlugins ( #37005 )
...
chore: cleanup ElectronContentClient::AddPlugins
2023-01-25 14:57:30 +01:00
David Sanders
ca3145a547
chore: use vscode-markdown-languageservice for link linting ( #36901 )
...
* chore: use vscode-markdown-languageservice for docs link linting
* docs: make links relative
2023-01-24 09:00:25 +01:00
Shelley Vohr
37f5881882
test: add a <datalist> spec for time type ( #36953 )
...
spec: add a datalist spec for time type
2023-01-23 11:21:28 -05:00
David Sanders
f20d0b4ecb
chore: clean up .keep files ( #36980 )
2023-01-23 09:57:00 +01:00
Robo
cdb65c15a8
fix: make plugin helper executable unconditional ( #36971 )
2023-01-21 09:42:45 +09:00
Shelley Vohr
c3f02d7df2
chore: cleanup autofill agent shutdown sequence ( #36954 )
2023-01-20 14:35:06 -08:00
David Sanders
3b018143b4
ci: don't run stale workflow jobs in parallel ( #36967 )
2023-01-20 13:02:50 -08:00
David Sanders
885c1878d4
test: fix nativeTheme test when system in dark mode ( #36943 )
2023-01-19 21:59:20 -05:00
GGIEnrike
5ce8dfdcb5
docs: Change factuality and word choice in app.runningUnderARM64Translation ( #36947 )
...
Change factuality and word choice.
Added "or WOW" to the phrase, "when they are running the x64 version under Rosetta", to reflect the use of a supported platform, Windows, as a possible scenario.
Changed the wording of that same sentence to make it appear clearer. "incorrectly" to "mistakenly" and moved this word to before the verb instead of the end of the sentence.
2023-01-19 15:00:06 -05:00
David Sanders
4e4ae9ff53
docs: update clipboard fiddles ( #36946 )
2023-01-19 14:59:35 -05:00
Shelley Vohr
55c818d0a8
fix: <datalist> dropdown positioning ( #36934 )
...
fix: datalist dropdown positioning
2023-01-19 19:44:23 +01:00
David Sanders
9630e26e6d
test: support running tests against Electron releases ( #36944 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-01-19 12:14:59 +01:00
David Sanders
b69236d177
test: fix test for USB device.forget() ( #36942 )
2023-01-18 16:30:01 -05:00
Shelley Vohr
b1548c2dbe
fix: webview background color on reload ( #36920 )
2023-01-18 14:46:47 +01:00
Shelley Vohr
1d98b27a66
chore: update node types version ( #36924 )
2023-01-18 14:46:27 +01:00
John Kleinschmidt
91ccf08853
ci: run WOA tests on AppVeyor ( #36925 )
2023-01-18 12:12:57 +01:00
Milan Burda
2c56a06ad3
feat: add label property to Display objects ( #36855 )
2023-01-18 15:44:40 +09:00
David Sanders
a7bc579220
ci: update pinned versions for security scorecard workflow ( #36910 )
2023-01-17 10:41:05 -08:00
David Sanders
e2b21d87d7
ci: update amannn/action-semantic-pull-request version ( #36902 )
2023-01-16 10:23:38 +01:00
David Sanders
d94f35a8f6
chore: disallow shortcut reference links in docs Markdown ( #36860 )
...
* chore: disallow shortcut reference links in docs Markdown
* docs: clean up shortcut-style links
2023-01-16 10:22:49 +01:00
Shelley Vohr
a9e7bb0027
fix: Cmd+Tab not working when exiting kiosk mode ( #36854 )
2023-01-16 10:06:43 +01:00
Keeley Hammond
ad1a09bb10
build: bump appveyor to e-111.0.5518.0 ( #36900 )
2023-01-12 17:54:06 -05:00
Shelley Vohr
c953109f01
build: remove older branch migration helpers ( #36888 )
...
* build: remove older branch migration helpers
* chore: fix typo
2023-01-12 12:05:26 -05:00
Shelley Vohr
3f764cbbd5
build: remove ScriptOrModule V8 flag ( #36887 )
...
build: remove ScriptOrModule V8 flag
2023-01-12 13:02:40 +01:00
Eugene Nesvetaev
ce56d614a3
chore: fix typo in promise rejection ( #36763 )
2023-01-12 12:32:56 +01:00
David Sanders
a9c03950c0
docs: cleanup reference links ( #36659 )
2023-01-11 22:16:34 -08:00
Robo
fefb22a83d
chore: enable microtask queue per window agent ( #36870 )
...
* chore: enable microtask queue per window agent
* chore: switch policies on context microtask queue
* fix: ensure node::Environment is valid
2023-01-12 01:59:32 +09:00
Robo
2a7d0a84c0
fix: missing libcxx headers ( #36863 )
...
* chore: add libcxx script to precommit hook
* chore: run gen-libc++-filename.js
2023-01-12 01:59:03 +09:00
Shelley Vohr
f31826f4a0
fix: getUserMedia duplicate permissions call ( #36787 )
...
* fix: getUserMedia duplicate permissions call
* test: add regression test
2023-01-11 11:55:31 +01:00
electron-roller[bot]
1d9a4ab02c
chore: bump node to v18.13.0 (main) ( #36818 )
...
* chore: bump node in DEPS to v18.13.0
* child_process: validate arguments for null bytes
https://github.com/nodejs/node/pull/44782
* bootstrap: merge main thread and worker thread initializations
https://github.com/nodejs/node/pull/44869
* module: ensure relative requires work from deleted directories
https://github.com/nodejs/node/pull/42384
* src: add support for externally shared js builtins
https://github.com/nodejs/node/issues/44000
* lib: disambiguate `native module` to `binding`
https://github.com/nodejs/node/pull/45673
* test: convert test-debugger-pid to async/await
https://github.com/nodejs/node/pull/45179
* deps: upgrade to libuv 1.44.2
https://github.com/nodejs/node/pull/42340
* src: fix cppgc incompatibility in v8
https://github.com/nodejs/node/pull/43521
* src: use qualified `std::move` call in node_http2
https://github.com/nodejs/node/pull/45555
* build: fix env.h for cpp20
https://github.com/nodejs/node/pull/45516
* test: remove experimental-wasm-threads flag
https://github.com/nodejs/node/pull/45074
* src: iwyu in cleanup_queue.cc
https://github.com/nodejs/node/pull/44983
* src: add missing include for `std::all_of`
https://github.com/nodejs/node/pull/45541
* deps: update ICU to 72.1
https://github.com/nodejs/node/pull/45068
* chore: fixup patch indices
* chore: remove errant semicolons
- https://github.com/nodejs/node/pull/44179
- https://github.com/nodejs/node/pull/44193
* src: add support for externally shared js builtins
https://github.com/nodejs/node/pull/44376
* chore: add missing GN filenames
* deps: update nghttp2 to 1.51.0
https://github.com/nodejs/node/pull/45537
* chore: disable more Node.js snapshot tests
The Snapshot feature is currently disabled
* chore: disable ICU timezone tests
Node.js uses a different version of ICU than Electron so they
will often be out of sync.
* chore: disable threadpool event tracing test
Event tracing is not enabled in embedded Node.js
* chore: fixup patch indices
* chore: comments from review
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-11 11:33:48 +01:00
Samuel Attard
b3d16e727c
build: migrate patch-up to use app creds ( #36817 )
2023-01-10 21:56:50 -08:00
Shelley Vohr
dfe501941c
build: update release deps workflow ( #36530 )
2023-01-10 12:46:30 +01:00
Shelley Vohr
414791232a
fix: RTL WindowButtonsProxy buttons ( #36839 )
...
* fix: RTL WindowButtonsProxy buttons
* chore: address review feedback
2023-01-10 12:19:00 +01:00
David Sanders
168726a052
fix: handle null/undefined options for fs.readdir ( #34764 )
2023-01-10 12:16:39 +01:00
Milan Burda
1c9e7687f9
docs: add missing window-management permission value to setPermissionRequestHandler() ( #36776 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-10 09:49:04 +01:00
Shelley Vohr
f56a26c4f7
build: fix broken stale issues workflow ( #36843 )
2023-01-09 19:16:58 +01:00
Shelley Vohr
1a9c338c92
chore: cleanup drag_util ( #36806 )
...
chore: cleanup drag_util
2023-01-09 10:00:47 +01:00
David Sanders
0d05273024
docs: fix link in breaking-changes.md ( #36793 )
2023-01-09 16:37:57 +09:00
electron-roller[bot]
90af7d7fe2
chore: bump chromium to 111.0.5518.0 (main) ( #36575 )
...
* chore: bump chromium in DEPS to 110.0.5461.0
* chore: update patches
* 3903024: hid: Add connection count tracking methods for HidDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/3903024
* 4076211: Turn FrameTreeNode::frame_tree into raw_ref.
https://chromium-review.googlesource.com/c/chromium/src/+/4076211
* chore: bump chromium in DEPS to 110.0.5463.0
* chore: bump chromium in DEPS to 110.0.5465.0
* fix patches
* 3835037: Add new slides media session actions to Picture-in-Picture window
https://chromium-review.googlesource.com/c/chromium/src/+/3835037
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5467.0
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5469.0
* chore: bump chromium in DEPS to 110.0.5471.0
* chore: bump chromium in DEPS to 110.0.5473.0
* chore: bump chromium in DEPS to 110.0.5475.0
* chore: update patches
* 4074449: Add gl::FrameData to software path
https://chromium-review.googlesource.com/c/chromium/src/+/4074449
* 4065264: [Extensions] Add a new side panel view type
https://chromium-review.googlesource.com/c/chromium/src/+/4065264
* 4060548: Remove base::Value::GetListDeprecated().
https://chromium-review.googlesource.com/c/chromium/src/+/4060548
* chore: add missing RefCountedMemory include
* 4081108: task posting v3: remove task_runner_util{.h,_unittest.cc}
https://chromium-review.googlesource.com/c/chromium/src/+/4081108
* 4072471: Rename Mixed Download Blocking to Insecure Download Blocking
https://chromium-review.googlesource.com/c/chromium/src/+/4072471
* 4025927: [Code Health] Migrate e/c/manifest.cc to base::Value::Dict interface
https://chromium-review.googlesource.com/c/chromium/src/+/4025927
* chore: fixup patch indices
* chore: bump chromium in DEPS to 110.0.5477.0
* chore: fixup preconnect_manager.patch
* chore: fixup patch indices
* fixup! 4074449: Add gl::FrameData to software path
* 4074449: Add gl::FrameData to software path
This commit also reformatted the two files in this patch. The only
change here is the addition of the |data| arg to |OnSwapBuffers|.
https://chromium-review.googlesource.com/c/chromium/src/+/4074449
* 4081108: task posting v3: remove task_runner_util{.h,_unittest.cc}
https://chromium-review.googlesource.com/c/chromium/src/+/4081108
* 4085814: [Test Automation] Move NativeWindowTracker to ui/views
https://chromium-review.googlesource.com/c/chromium/src/+/4085814
* 4032656: hid: Abstract HidSystemTrayIcon class for profiles' HID connections
https://chromium-review.googlesource.com/c/chromium/src/+/4032656
* chore: bump chromium in DEPS to 110.0.5479.0
* chore: fixup patches & simplify printing patch
To be specific, I replaced some combination of line removals &
commenting-out with `#if 0` blocks since they were already there for
android.
Should be functionally the same, just written differently for better
patch maintainability.
* chore: bump chromium in DEPS to 110.0.5481.0
* chore: update patch indicies
* 4098946: Migrate Extension::Create() argument to base::Value::Dict (part 4 of 4)
https://chromium-review.googlesource.com/c/chromium/src/+/4098946
* chore: bump chromium in DEPS to 111.0.5482.0
* chore: bump chromium in DEPS to 111.0.5484.0
* chore: bump chromium in DEPS to 111.0.5486.0
* chore: update patch indices
* 4112903: Reland "Move gl::FrameData to gfx::FrameData"
https://chromium-review.googlesource.com/c/chromium/src/+/4112903
* 4056216: Option to create a tab target with Target.createTarget in /json/new
https://chromium-review.googlesource.com/c/chromium/src/+/4056216
* chore: bump chromium in DEPS to 111.0.5488.0
* chore: bump chromium in DEPS to 111.0.5490.0
* chore: bump chromium in DEPS to 111.0.5492.0
* chore: bump chromium in DEPS to 111.0.5494.0
* chore: bump chromium in DEPS to 111.0.5496.0
* chore: bump chromium in DEPS to 111.0.5498.0
* chore: bump chromium in DEPS to 111.0.5500.0
* chore: bump chromium in DEPS to 111.0.5502.0
* chore: update patch indices
+ small update to printing.patch due to:
3653941: [printing] Extract settings logic from PrintJobWorker
https://chromium-review.googlesource.com/c/chromium/src/+/3653941
* 4113994: Cleanup: Rename webui_generated_resources_* to webui_resources_*.
https://chromium-review.googlesource.com/c/chromium/src/+/4113994
* 4112537: Remove DictionaryPrefUpdate.
https://chromium-review.googlesource.com/c/chromium/src/+/4112537
* 4072073: Remove //chrome/browser/ash dependency from pdf_extension_util.cc
https://chromium-review.googlesource.com/c/chromium/src/+/4072073
* 4055223: [Remove FileSystemConnector] Remove DownloadItemRerouteInfo
https://chromium-review.googlesource.com/c/chromium/src/+/4055223
* Migrate base::DictionaryValue to base::Value::Dict
This relates to multiple CLs cleaning up this class in this roll,
but the ones that are specifically relevant here:
4116096: [CodeHealth] Remove DictionaryValue::GetInteger
https://chromium-review.googlesource.com/c/chromium/src/+/4116096
4113764: [CodeHealth] Remove deprecated DictionaryValue::SetInteger()
https://chromium-review.googlesource.com/c/chromium/src/+/4113764
* 3653941: [printing] Extract settings logic from PrintJobWorker
https://chromium-review.googlesource.com/c/chromium/src/+/3653941
* chore: bump chromium in DEPS to 111.0.5504.0
* chore: update patches
* (WIP) 4003663: Enable Microtask queues per WindowAgent.
https://chromium-review.googlesource.com/c/chromium/src/+/4003663
* chore: bump chromium in DEPS to 111.0.5506.0
* chore: update patches
* fix: printing patch
It was complaining that this method isn't used on windows
* chore: bump chromium in DEPS to 111.0.5508.0
* chore: bump chromium in DEPS to 111.0.5510.0
* chore: bump chromium in DEPS to 111.0.5512.0
* chore: bump chromium in DEPS to 111.0.5514.0
* chore: bump chromium in DEPS to 111.0.5516.0
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5518.0
* chore: update patches
* 4027428: [rsafor] Move rsaFor requests to a separate permission
https://chromium-review.googlesource.com/c/chromium/src/+/4027428
* Revert "(WIP) 4003663: Enable Microtask queues per WindowAgent."
This reverts commit cc36d226e3f3fe5f4bea6538102d55ce3203190f.
* chore: disable Microtask queues per WindowAgent.
see https://chromium-review.googlesource.com/c/chromium/src/+/4003663
* chore: cleanup after rebase
* fixup: disable Microtask queues per WindowAgent.
* chore: cleanup password from keychain after test
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Calvin Watford <cwatford@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
2023-01-05 21:35:34 -05:00
Mikael Finstad
ba962c94cc
docs: Add note about argv getting modified ( #36735 )
...
Add note about argv getting modified
See https://github.com/electron/electron/issues/20322
2023-01-05 11:39:45 +01:00
Jeremy Rose
9b8b8f5880
fix: move report_raw_headers to TrustedParams ( #36725 )
...
* fix: move report_raw_headers to TrustedParams
* Update electron_api_url_loader.cc
* missed a copy constructor
2023-01-05 10:36:14 +01:00
Shelley Vohr
32288ac9c5
fix: focus rings with multiple buttons in showMessageBox ( #36772 )
...
fix: focus rings with multiple buttons in messageBox
2023-01-05 09:56:38 +01:00
Milan Burda
42cda4a893
fix: rename WebSwapCGLLayer to WebSwapCGLLayerChromium ( #35961 )
...
* fix: rename WebSwapCGLLayer to WebSwapCGLLayerChromium
* undo changes to patches/config.json
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-01-05 15:49:08 +09:00
David Sanders
700f43c90c
docs: cleanup some rogue backticks ( #36778 )
2023-01-04 14:52:46 +01:00
Marco Pelloni
6cb5f5a1eb
docs: update incorrect grammar ( #36780 )
...
#### Description of Change
The first sentence within the documentation "[Important: signing your code](https://www.electronjs.org/docs/latest/tutorial/tutorial-packaging#important-signing-your-code )" is grammatically incorrect.
> In order to distribute desktop applications to end users, we highly recommended for you to code sign your Electron app.
I've adjusted the copy to switch "highly recommended" to "highly recommend". I've also switched out "for you to code sign" for "that you code sign" for clarity.
> In order to distribute desktop applications to end users, we _highly recommend_ that you **code sign** your Electron app.
2023-01-04 14:52:29 +01:00
David Sanders
20cff64282
docs: update links ( #36657 )
2023-01-02 11:52:18 +01:00
David Sanders
20ac617c03
chore: update electron/clerk links in PR template ( #36658 )
2023-01-02 11:23:43 +01:00
Roger Zurawicki
28cfaccb1d
docs: update code highlights in tutorial ( #36691 )
...
docs: fix code highlighting in preload tutorial
The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
2023-01-02 11:14:34 +01:00
YongWoo Roh
c4a93390dd
docs: main.js file change was displayed incorrectly ( #36709 )
...
main.js file change was displayed incorrectly
The line in the main.js file change was displayed incorrectly, so it was corrected.
2023-01-02 11:04:41 +01:00
David Sanders
327abb4b52
docs: improve dark mode example fiddle ( #36596 )
2023-01-02 11:02:15 +01:00
George Xu
644243efd6
docs: update visual studio min version ( #36702 )
2022-12-22 11:48:48 -08:00
Jeremy Rose
8f23b1527b
fix: use chrome headers in net.request for everything except cookie ( #36666 )
2022-12-21 14:53:29 -08:00
MAPGarrett
8c837fda4f
docs: Fix incorrect highlight in an example snippet ( #36700 )
...
Fix incorrect highlight in an example snippet
At the moment, the "Communicating between processes" `main.js` snippet highlights the line containing `})` when the relevant line is `ipcMain.handle('ping', () => 'pong')`.
2022-12-20 10:06:25 -08:00
Milan Burda
5fd7a43970
test: replace (webContents as any).destroy() with webContents.destroy() ( #36653 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-14 16:07:38 -05:00
Jeremy Rose
fb461effae
chore: cherry-pick 32b7dc86a763 from v8 ( #36651 )
...
* chore: cherry-pick 32b7dc86a763 from v8
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-14 16:06:10 -05:00
Jeremy Rose
9e7fbc7021
fix: blend node and blink code generation policy when both are loaded ( #36567 )
2022-12-14 10:05:34 -08:00
Webster Xu
f72e6551f0
fix: use the process cache to reduce the memory for asar file ( #36600 )
...
* fix: use the process cache to reduce the memory for asar file
* Update shell/common/api/electron_api_asar.cc
Co-authored-by: webster.xu <webster.xu@ringcentral.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-12-14 12:37:28 -05:00
Robert Günzler
ab890fb8c3
fix: strip branded binaries ( #36641 )
...
When creating branded release builds and using scripts/strip-binaries.py
on Linux, the final artifacts end up unstripped due to the static set of
binaries considered for stripping.
With this patch the name of the electron binary is taken from the
BRANDING.json `project_name` key.
Signed-off-by: Robert Günzler <r@gnzler.io >
Signed-off-by: Robert Günzler <r@gnzler.io >
2022-12-13 17:01:20 -05:00
John Kleinschmidt
425f1ffa98
chore: update AppVeyor image to include latest Windows updates ( #36649 )
...
clenaup
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2022-12-13 14:28:09 -05:00
David Sanders
4d9c84d7c0
chore: update markdownlint ( #36540 )
2022-12-13 10:55:53 -08:00
Bruno Pitrus
1432f9bb65
chore: reland “fix ambiguous reference gcc compile error” ( #36544 )
...
This is a reland of #35714 . The broken code got reintroduced in #35310 due to a mismerge.
2022-12-13 10:55:08 -08:00
Michał Zarach
6a798b1c58
feat: added username to IAP purchaseProduct method ( #35902 )
2022-12-12 10:11:48 -08:00
Hugh Davey
4e66184287
docs: add mdn link to web-request-filter.md ( #36603 )
...
* Add MDN link to web-request-filter.md
When I was using the Electron docs I wanted to know how to use [webRequest.onBeforeSendHeaders](https://www.electronjs.org/docs/latest/api/web-request#webrequestonbeforesendheadersfilter-listener ) but I was unable to correctly guess the correct format for the `WebRequestFilter` URL strings, and there was no explanation in the Electron docs. Eventually I googled it and found the MDN article which helped me.
* Update docs/api/structures/web-request-filter.md
Co-authored-by: Black-Hole <158blackhole@gmail.com >
* Update docs/api/structures/web-request-filter.md
Co-authored-by: Black-Hole <158blackhole@gmail.com >
Co-authored-by: Black-Hole <158blackhole@gmail.com >
2022-12-08 17:11:42 -05:00
Jeremy Rose
99b0d63c84
ci(not-really): autoclose issues with blocked/need-repro and no response ( #36532 )
2022-12-05 20:53:07 -05:00
Samuel Attard
e1e66fc8ac
docs: link net.request options to ClientRequestConstructorOptions ( #36556 )
2022-12-05 15:17:37 -08:00
electron-roller[bot]
8acf6039e7
chore: bump chromium to 110.0.5451.0 (main) ( #36394 )
...
* chore: bump chromium in DEPS to 110.0.5425.0
* chore: bump chromium in DEPS to 110.0.5427.0
* chore: bump chromium in DEPS to 110.0.5429.0
* chore: bump chromium in DEPS to 110.0.5431.0
* chore: update patches/chromium/picture-in-picture.patch to fix upstream code shear
https://chromium-review.googlesource.com/c/chromium/src/+/4024078
* chore: sync patch w/upstream shear: remove_usage_of_incognito_apis_in_the_spellchecker.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3967854
* chore: sync patch w/upstream shear: feat_expose_raw_response_headers_from_urlloader.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3983373
* chore: sync patch w/upstream shear: chromium/custom_protocols_plzserviceworker.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3983373
* build: update references to core_api_provider; its location was moved upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4006696
* build: remove back_to_tab_image_button from our enable_picture_in_picture deps
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4024078
back_to_tab_image_button has been removed upstream
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5433.0
* chore: sync patch w/upstream shear: chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4006638
* chore: sync patch w/trivial upstream shear: chromium/process_singleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4031817
* refactor: remove kAutofillCenterAlignedSuggestions feature flag check.
This behavior had been an experiment behind a feature flag. The
experiment was a success so the feature was kept & the flag was removed.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3870616
moves from disabled-by-default to enabled-by-default
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4030556
removed the feature flag
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5435.0
* chore: update patches
* chore: sync code with upstream change: AXLMode method name
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3950054
* 3841761: Adapting code to support kSystemProfileSelectionDefaultNone experiment
https://chromium-review.googlesource.com/c/chromium/src/+/3841761
* chore: bump chromium in DEPS to 110.0.5437.0
* 4040140: Pip 2.0: Merge VideoOverlayWindowViews and OverlayWindowViews
https://chromium-review.googlesource.com/c/chromium/src/+/4040140
* 4045567: Fix a crash opening a popup from tab capture fullscreen
https://chromium-review.googlesource.com/c/chromium/src/+/4045567
* chore: fixup patch indices
* 4048263: Remove deprecated Value calls in frame_tracker_unittest.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/4048263
* 4004606: [intl] Migrate to ICU 72
https://chromium-review.googlesource.com/c/v8/v8/+/4004606
* chore: bump chromium in DEPS to 110.0.5439.0
* 3890670: Prerender: Add first implementation of prerender-in-new-tab mode
https://chromium-review.googlesource.com/c/chromium/src/+/3890670
* chore: fixup patch indices
* chore: bump chromium in DEPS to 110.0.5441.0
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5443.0
* 4035451: Remove remaining uses of ScopedNestableTaskAllower.
https://chromium-review.googlesource.com/c/chromium/src/+/4035451
* chore: bump chromium in DEPS to 110.0.5445.0
* chore: update patches
* fixup! 3890670: Prerender: Add first implementation of prerender-in-new-tab mode
* test: disable parallel/test-worker-init-failure
Refs https://chromium-review.googlesource.com/c/v8/v8/+/4017512
Refs https://github.com/nodejs/node-v8/issues/246
* chore: disable parallel/test-fetch
Test is flaky on Linux CI, but runs fine locally.
* chore: bump chromium in DEPS to 110.0.5451.0
* chore: update patches
* chore: cleanup patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-05 17:59:19 -05:00
StepSecurity Bot
2a26cef577
ci: pin action shas ( #36562 )
...
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
2022-12-05 12:11:10 -08:00
David Sanders
993d0337a7
docs: fix broken links ( #36519 )
...
* docs: fix broken links
* docs: change link to navigator.getUserMedia
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* docs: fix link in examples.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-12-05 13:18:57 -05:00
Shelley Vohr
b90a5baa6d
fix: new WebAssembly API support in Node.js ( #36420 )
2022-12-05 12:07:49 -05:00
Milan Burda
909ee0ed6b
refactor: make StatusIconType an enum class ( #36500 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-12-05 00:59:20 -08:00
John Kleinschmidt
79d2fc9c23
build: fixup mksnapshot args on linux ( #36531 )
2022-12-01 14:12:32 -05:00
Shelley Vohr
d092e6bda4
feat: expose window.invalidateShadow() ( #32452 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Darshan Sen <raisinten@gmail.com >
2022-12-01 10:24:44 -08:00
Keeley Hammond
35a7c07306
chore: update NMV for Electron 24 ( #36465 )
2022-11-30 22:10:36 -08:00
Milan Burda
eb291485bb
chore: drop support for Windows 7 / 8 / 8.1 ( #36427 )
...
* chore: drop support for Windows 7 & 8
* chore: remove disable-redraw-lock.patch
* chore: update patches
* Update docs/breaking-changes.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* fix breaking-changes.md
* chore: note last supported version
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: add link to deprecation policy
* Update docs/breaking-changes.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* update README.md
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-11-30 17:13:29 -08:00
Jeremy Rose
4ff0642af7
fix: treat maxWidth/Height<=0 as unlimited ( #36487 )
2022-11-30 17:02:22 -08:00
Jeremy Rose
835e248dff
docs: document outlivesOpener option in window open handler ( #36486 )
2022-11-30 15:20:19 -08:00
Jeremy Spiegel
665cf03f74
fix: handle Notification requireInteraction option ( #36477 )
2022-11-30 16:18:35 -05:00
Black-Hole
f527b8aa2a
refactor: improve accelerator check failed message ( #36476 )
2022-11-30 11:31:16 -08:00
Jeremy Rose
e3b7c3024f
docs: fix loadExtension example ( #36489 )
2022-11-30 11:29:02 -08:00
Keeley Hammond
9f007b9afb
chore: update NMV for Electron 23 ( #36464 )
2022-11-30 10:57:27 -08:00
George Xu
d5ce1387ce
docs: change pull request template to include mentions of templates and examples ( #36474 )
2022-11-29 22:22:09 -08:00
Michaela Laurencin
42ca25c338
docs: update E23 release dates ( #36475 )
2022-11-29 15:08:55 -08:00
Robo
2c723d7e84
fix: enable crashpad for ELECTRON_RUN_AS_NODE processes ( #36460 )
...
* wip: enable crashpad for node processes
fix: add PID testing method
wip: plumb fd into child_process in node
* node::ProcessInitializationFlags::kNoDefaultSignalHandling
* chore: clean up debug logging
* chore: gate platform includes
* test: clean up node process test
* fix: pass pid in node_main
* chore: cleanup impl
* chore: fixup patch method definition
* fix: expose bound methods to node_main
* fix: remove bound methods
* fix: crashpad connection for all ELECTRON_RUN_AS_NODE processes
* chore: fix typo
* chore: address review feedback
* chore: delay crashpad initialization
* chore: ensure options.env, code hygiene
* chore: add argv test, check for process.env over {}
* fix: fix test, return options.env immutability
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2022-11-29 10:33:54 -05:00
Cheng Zhao
16a7bd7102
fix: reimplement Tray with StatusIconLinuxDbus on Linux ( #36333 )
2022-11-28 11:36:25 -08:00
dependabot[bot]
bbb590b777
build(deps): bump minimatch from 3.0.4 to 3.0.8 ( #36418 )
...
Bumps [minimatch](https://github.com/isaacs/minimatch ) from 3.0.4 to 3.0.8.
- [Release notes](https://github.com/isaacs/minimatch/releases )
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.0.8 )
---
updated-dependencies:
- dependency-name: minimatch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-28 11:24:13 -08:00
Jeremy Rose
32583ac756
docs: add missing event-emitter link to utility-process docs ( #36428 )
...
add missing event-emitter link
2022-11-23 17:52:36 +09:00
John Kleinschmidt
679ce632a9
build: fixup appveyor image for release ( #36429 )
...
* build: make sure symstore is in the PATH when baking an image
* build: update to use fixed baked image
* cleanup sdk install
2022-11-22 16:57:49 -05:00
John Kleinschmidt
629c54ba36
feat: add support for WebUSB ( #36289 )
...
* feat: add support for WebUSB
* fixup for gn check
* fixup gn check on Windows
* Apply review feedback
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: address review feedback
* chore: removed unneeded code
* Migrate non-default ScopedObservation<> instantiations to ScopedObservationTraits<> in chrome/browser/
https://chromium-review.googlesource.com/c/chromium/src/+/4016595
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-11-22 16:50:32 -05:00
Samuel Attard
2751c2b07f
build: update devcontainer and use latest codespaces features ( #36422 )
...
* build: update devcontainer to latest build image
* build: add update-content-command
* build: set good vscode config
* build: be less noisy in update command
* build: only run sync in prebuild environment
* build: list env vars
* build: run sync always
2022-11-22 12:16:15 -08:00
electron-roller[bot]
c6d6af2551
chore: bump node to v18.12.1 (main) ( #36356 )
...
* chore: bump node in DEPS to v18.12.1
* chore: update patches
* chore: add missing <algorithm> include
* src: add detailed embedder process initialization AP
https://github.com/nodejs/node/pull/44121
* chore: update gn build files
* dns: support dns module in the snapshot
https://github.com/nodejs/node/pull/44633
https://github.com/electron/electron/issues/36118
* src: fix OOB reads in process.title getter
https://github.com/nodejs/node/pull/31633
* chore: fix incorrectly removed patch bit
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-11-21 10:55:01 -05:00
Keeley Hammond
b71cccb0d6
ci: bake appveyor images automatically, run sync on depshash change ( #35396 )
...
* chore: update yml formatting for parser
* ci: bake appveyor images automatically, run sync on depshash change
* chore: clean up .yml files
* chore: bump to e-110.0.5415.0
2022-11-21 10:24:26 -05:00
Samuel Attard
3a94634ae5
build: force ninja binary to the right arch after src cache restore ( #36401 )
2022-11-18 23:45:22 -08:00
hyrious
9c48992e21
chore: fix dangling promise in npm install ( #36379 )
...
* Fix dangling promise introduced in #33979
* fix reject in callback
* simplify code
Co-authored-by: Black-Hole <158blackhole@gmail.com >
Co-authored-by: Black-Hole <158blackhole@gmail.com >
2022-11-18 15:21:11 -08:00
John Kleinschmidt
7529ebfe0e
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args ( #36378 )
...
fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
2022-11-17 17:49:12 -05:00
dependabot[bot]
4f1f263a9a
build(deps): bump loader-utils from 1.4.1 to 1.4.2 in /spec ( #36375 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-17 17:48:48 -05:00
electron-roller[bot]
87c183df6a
chore: bump chromium to 110.0.5415.0 (main) ( #36186 )
...
* chore: bump chromium in DEPS to 109.0.5386.0
* chore: bump chromium in DEPS to 109.0.5388.0
* chore: bump chromium in DEPS to 109.0.5390.0
* chore: bump chromium in DEPS to 109.0.5392.0
* chore: bump chromium in DEPS to 109.0.5394.0
* chore: bump chromium in DEPS to 109.0.5396.0
* chore: bump chromium in DEPS to 109.0.5398.0
* chore: bump chromium in DEPS to 109.0.5400.0
* chore: update galactus
* chore: bump chromium in DEPS to 109.0.5402.0
* chore: bump chromium in DEPS to 109.0.5403.0
* chore: bump chromium in DEPS to 109.0.5406.0
* chore: update patches
* 4004247: Delete unused DocumentWebContentsDelegate
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4004247
* chore: bump chromium in DEPS to 109.0.5408.1
* chore: update patches
* 3949284: Support pkey debug mode without pkey 0 access
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3949284
* chore: bump chromium in DEPS to 109.0.5410.0
* chore: update patches
* 4000944: [Extensions] Create an API directory in //chrome/renderer/extensions
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4000944
* 3988524: Remove DocumentOverlayWindowViews | https://chromium-review.googlesource.com/c/chromium/src/+/3988524
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com >
* chore: bump chromium in DEPS to 109.0.5412.0
* chore: update patches
* 3984022: Add AddChildWindowToBrowser to DisplayClient mojo interface
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3984022
* 3957079: Delete the CryptoToken component extension and internal API
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3957079
* 4004421: Migreate ScopedAllowIO to ScopedAllowBlocking
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4004421
Co-authored-by: George Xu <georgexu99@users.noreply.github.com >
* chore: bump chromium in DEPS to 109.0.5414.0
* chore: update patches
* 4016180: Split PPAPI Mojo interfaces out of RenderFrameHostImpl.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4016180
* 3970838: [MPArch] Convert HostZoomMap and ZoomController off of RenderViewHost ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3970838
* 3997795: Don't add Chromium as a login item
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3997795
* 3993482: Remove RefCountedString::TakeString
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3993482
* 3990749: Allow forward-declared sources in base::ScopedObservation<>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3990749
* fixup! 3957079: Delete the CryptoToken component extension and internal API
* chore: bump chromium in DEPS to 110.0.5415.0
* 3883790: Move devtools_frame_token to the RenderFrameHost, to preserve RFH identity across MPArch activations.
https://chromium-review.googlesource.com/c/chromium/src/+/3883790
* 4022205: Move license tooling into //tools/licenses
https://chromium-review.googlesource.com/c/chromium/src/+/4022205
* chore: fixup patch indices
* fixup! 3957079: Delete the CryptoToken component extension and internal API
* 4008687: Finish ScopedAllowIO migration
https://chromium-review.googlesource.com/c/chromium/src/+/4008687
* 3991548: Move WindowButtonOrderObserver and WindowFrameAction to LinuxUi
https://chromium-review.googlesource.com/c/chromium/src/+/3991548
* fixup! 3984022: Add AddChildWindowToBrowser to DisplayClient mojo interface
* 4016595: Migrate non-default ScopedObservation<> instantiations to ScopedObservationTraits<> in chrome/browser/
https://chromium-review.googlesource.com/c/chromium/src/+/4016595
* 4000481: Rename :chromedriver to :chromedriver_server
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4000481
* 4008687: Finish ScopedAllowIO migration
https://chromium-review.googlesource.com/c/chromium/src/+/4008687
* 3988524: Remove DocumentOverlayWindowViews
https://chromium-review.googlesource.com/c/chromium/src/+/3988524
* fixup! 3997795: Don't add Chromium as a login item
* chore: fixup patches
* 3996872: Plumb input event task runner to EventFactoryEvdev
https://chromium-review.googlesource.com/c/chromium/src/+/3996872
* 4014994: Enable SiteIsolationForGuests by default.
https://chromium-review.googlesource.com/c/chromium/src/+/4014994
* chore: adopt new thread restrictions api for //electron (#36357 )
chore: add thread blocking api
* fixup! 4014994: Enable SiteIsolationForGuests by default.
* pull parent HWND for dialogs on ui thread
* chore: set parent_window in MessageBoxSettings
* chore: remove redundant patch
* chore: revert accidental deletion
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com >
Co-authored-by: George Xu <georgexu99@users.noreply.github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-17 14:59:23 -05:00
Step Security Bot
517225b99e
ci: add default action permissions ( #36363 )
...
* [StepSecurity] Apply security best practices
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
* Delete dependabot.yml
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-11-16 15:44:25 -05:00
Samuel Attard
bd345358f6
build: build mas and darwin simultaneously ( #36354 )
...
build: build mas on osx
2022-11-16 10:57:09 -08:00
Samuel Attard
9616dfb1f6
docs: update SECURITY.md with new GHSA reporting feature ( #36367 )
2022-11-15 20:02:01 -08:00
dependabot[bot]
41d393c076
build(deps): bump loader-utils from 1.4.1 to 1.4.2 ( #36365 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-15 17:31:16 -08:00
Samuel Attard
2cc24542f5
build: remove out cache ( #36355 )
2022-11-15 12:00:46 -05:00
Samuel Attard
d57d9f71df
build: make src cache smaller ( #36344 )
2022-11-15 00:30:07 -08:00
Tierney Cyren
f8aee0fbe7
docs: update README.md to use correct twitter handle ( #36345 )
...
doc: update README.md to use correct twitter handle
2022-11-14 22:23:37 -08:00
Step Security Bot
f9d1b9aded
ci: pin some more action versions ( #36343 )
...
* [StepSecurity] ci: Harden GitHub Actions
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
* Update electron_woa_testing.yml
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-11-14 18:39:13 -08:00
Jeremy Rose
9618a7227e
ci: pin amannn/action-semantic-pull-request ( #36341 )
2022-11-14 16:46:58 -08:00
Jeremy Rose
9f8308907b
ci: pin version of actions/checkout ( #36342 )
2022-11-14 16:46:45 -08:00
Joyce
05577d0903
chore: enable scorecard github action ( #35741 )
2022-11-14 16:22:10 -08:00
Samuel Attard
a9ef68f126
refactor: change defined(MAS_BUILD) to IS_MAS_BUILD() ( #36332 )
...
* refactor: change defined(MAS_BUILD) to IS_MAS_BUILD()
This is missing-definition safe and thus allows us to move the definition of this macro away from "all compilation targets" to "just the compilation targets that depend on this macro".
In turn this makes the rebuild time changing from mas <-> darwin only 80 seconds on my machine, instead of the 12-15 minutes it used to take. This will also allow us in the future to build both MAS and darwin on the same CI machine. Costing us ~2 minutes on one machine but saving us anywhere from 30 minutes to an hour of CI time on other parts of the matrix.
* build: always define IS_MAS_BUILD even on non-mac builds
* build: use extra_configs
2022-11-14 12:46:52 -08:00
Samuel Attard
d8bb172318
fix: abort ShipIt installation attempt at the final mile if the app is running ( #36130 )
...
* fix: abort ShipIt installation attempt at the final mile if the app is running
* chore: remove only
* Update patches/squirrel.mac/fix_abort_installation_attempt_at_the_final_mile_if_the_app_is.patch
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: update patches
* spec: make the ShipIt process lister helper more resilient
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-14 10:12:16 -08:00
Samuel Attard
654e571512
build: provide moduleVersion to docs-parser directly ( #36329 )
2022-11-14 10:04:36 -05:00
Erick Zhao
46a74d1086
docs: update tutorials for Forge 6 ( #36313 )
...
docs: update tutorial for Forge 6
2022-11-11 11:42:27 -08:00
Shelley Vohr
75d2caf451
chore: upgrade to Node.js v18 ( #35999 )
...
* chore: update to Node.js v18
* child_process: improve argument validation
https://github.com/nodejs/node/pull/41305
* bootstrap: support configure-time user-land snapshot
https://github.com/nodejs/node/pull/42466
* chore: update GN patch
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* src: use a typed array internally for process._exiting
https://github.com/nodejs/node/pull/43883
* chore: lib/internal/bootstrap -> lib/internal/process
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* chore: remove redudant browserGlobals patch
* chore: update BoringSSL patch
* src: allow embedder-provided PageAllocator in NodePlatform
https://github.com/nodejs/node/pull/38362
* chore: fixup Node.js crypto tests
- https://github.com/nodejs/node/pull/44171
- https://github.com/nodejs/node/pull/41600
* lib: add Promise methods to avoid-prototype-pollution lint rule
https://github.com/nodejs/node/pull/43849
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* src: add kNoBrowserGlobals flag for Environment
https://github.com/nodejs/node/pull/40532
* chore: consolidate asar initialization patches
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* deps: update V8 to 9.8
https://github.com/nodejs/node/pull/41610
* src,crypto: remove AllocatedBuffers from crypto_spkac
https://github.com/nodejs/node/pull/40752
* build: enable V8's shared read-only heap
https://github.com/nodejs/node/pull/42809
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
* chore: fixup ESM patch
* chore: fixup patch indices
* src: merge NativeModuleEnv into NativeModuleLoader
https://github.com/nodejs/node/pull/43824
* [API] Pass OOMDetails to OOMErrorCallback
https://chromium-review.googlesource.com/c/v8/v8/+/3647827
* src: iwyu in cleanup_queue.cc
* src: return Maybe from a couple of functions
https://github.com/nodejs/node/pull/39603
* src: clean up embedder API
https://github.com/nodejs/node/pull/35897
* src: refactor DH groups to delete crypto_groups.h
https://github.com/nodejs/node/pull/43896
* deps,src: use SIMD for normal base64 encoding
https://github.com/nodejs/node/pull/39775
* chore: remove deleted source file
* chore: update patches
* chore: remove deleted source file
* lib: add fetch
https://github.com/nodejs/node/pull/41749
* chore: remove nonexistent node specs
* test: split report OOM tests
https://github.com/nodejs/node/pull/44389
* src: trace fs async api
https://github.com/nodejs/node/pull/44057
* http: trace http request / response
https://github.com/nodejs/node/pull/44102
* test: split test-crypto-dh.js
https://github.com/nodejs/node/pull/40451
* crypto: introduce X509Certificate API
https://github.com/nodejs/node/pull/36804
* src: split property helpers from node::Environment
https://github.com/nodejs/node/pull/44056
* https://github.com/nodejs/node/pull/38905
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob
* lib,src: implement WebAssembly Web API
https://github.com/nodejs/node/pull/42701
* fixup! deps,src: use SIMD for normal base64 encoding
* fixup! src: refactor DH groups to delete crypto_groups.h
* chore: fixup base64 GN file
* fix: check that node::InitializeContext() returns true
* chore: delete _noBrowserGlobals usage
* chore: disable fetch in renderer procceses
* dns: default to verbatim=true in dns.lookup()
https://github.com/nodejs/node/pull/39987
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-10 22:31:20 +01:00
Shelley Vohr
1b1609aa0f
fix: app.dock.setIcon() crash before app ready ( #36279 )
...
fix: dock.setIcon() crash before app ready
2022-11-09 17:13:24 +01:00
Raymond Zhao
5fc3ed936e
feat: add app.getPreferredSystemLanguages() API ( #36035 )
...
* feat: add app.getSystemLanguage() API
* Change the API to getPreferredSystemLanguages
* Fix test
* Clarify docs and add Linux impl
* Remove USE_GLIB
* Don't add C to list
* Remove examples since there's a lot of edge cases
* Fix lint
* Add examples
* Fix compile error
* Apply PR feedback
* Update the example
2022-11-09 10:50:43 -05:00
dependabot[bot]
8f5959aad2
build(deps): bump loader-utils from 1.2.3 to 1.4.1 in /spec ( #36281 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.2.3 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-09 10:49:23 -05:00
Milan Burda
31a0bb7de2
chore: remove unsupported OS_FREEBSD flag check ( #36273 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-11-08 20:43:04 +01:00
dependabot[bot]
5c1186f624
build(deps): bump loader-utils from 1.2.3 to 1.4.1 ( #36276 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.2.3 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-08 11:27:59 +01:00
Jeremy Rose
184ac2b382
refactor: move draggable regions to WebContents ( #36230 )
2022-11-07 10:15:57 -08:00
John Kleinschmidt
2008c9a5d0
fix: arm linux glibc dependency ( #36247 )
2022-11-07 09:38:08 -05:00
David Sanders
0ba0df4523
docs: fix driverId -> deviceId typo ( #36246 )
2022-11-07 09:37:51 -05:00
Georgescu Gabriel
71b8804fd0
docs: Fixed outdated documentation (uploading to App Store) ( #35116 )
...
* Updated docs on uploading
- replaced mention of Application Loader with Apple Transporter, its replacement
- replaced mention of iTunes Connect with App Store Connect
- updated link for creating a record
* Update mac-app-store-submission-guide.md
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-11-01 17:07:50 -04:00
Brad Carter
15540975ff
feat: Add BrowserWindow option to hide window in Mission Control (macOS) ( #36092 )
...
* feat: Add BrowserWindow option to ignore Mission Control (macOS)
* There are many circumstances when app developers may want to hide their
windows from mission control. E.g., full screen overlays, small helper
windows, dialogs, etc.
* This PR adds the functionality, docs, and tests.
* chore:Rename variables
* Update shell/browser/native_window_mac.h
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-11-01 16:43:42 -04:00
Shelley Vohr
8b430c9d26
test: re-enable window.open referrer test ( #36155 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-11-01 11:11:11 -04:00
Milan Burda
2f2c43e5e5
build: fix building with enable_plugins = false ( #36193 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-10-31 16:18:15 -07:00
Shelley Vohr
169cf531ba
docs: add EOL dates to timeline doc ( #36187 )
2022-10-28 13:08:06 -07:00
Jeremy Rose
b9464d89b8
fix: remove undocumented feature and flaky test for webview resize event ( #36154 )
2022-10-27 16:44:53 -07:00
Keeley Hammond
67a0c702fa
build: prefix version in uploader script ( #36169 )
...
build: prefix v in uploader script
2022-10-27 12:02:18 -07:00
electron-roller[bot]
ea6f873f97
chore: bump chromium to 109.0.5382.0 (main) ( #36057 )
...
* chore: bump chromium in DEPS to 109.0.5364.0
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5366.0
* chore: update patches
* i3940364: Change PermissionType::WINDOW_PLACEMENT to WINDOW_MANAGEMENT
https://chromium-review.googlesource.com/c/chromium/src/+/3940364
* 3866812: Change content::PluginList to only run on the UI thread.
https://chromium-review.googlesource.com/c/chromium/src/+/3866812
* chore: bump chromium in DEPS to 109.0.5368.0
* [cleanup] Replace enable_basic_printing with enable_printing
https://chromium-review.googlesource.com/c/chromium/src/+/3957357
* chore: update patches
* 3956318: Desktop PWAs: Retire kWebAppWindowControlsOverlay flag
https://chromium-review.googlesource.com/c/chromium/src/+/3956318
* fixup! Change content::PluginList to only run on the UI thread.
(cherry picked from commit 7b5ec87d4f )
Co-Authored-By: Robo <hop2deep@gmail.com >
* chore: bump chromium in DEPS to 109.0.5370.0
* 3956299: Quota: Cleanup QuotaPermissionContext
https://chromium-review.googlesource.com/c/chromium/src/+/3956299
* chore: update patches
* 3803867: Add Mojo interface to parse XML for OOP printer capabilities
https://chromium-review.googlesource.com/c/chromium/src/+/3803867
* fixup: Add Mojo interface to parse XML for OOP printer capabilities
* chore: bump chromium in DEPS to 109.0.5372.0
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5374.0
* chore: bump chromium in DEPS to 109.0.5376.0
* chore: bump chromium in DEPS to 109.0.5378.0
* chore: update patches
* Quota: Cleanup kPersistent in BrowsingDataRemover
https://chromium-review.googlesource.com/c/chromium/src/+/3964859
* 3955976: serial: Create DOMException with V8ThrowDOMException
https://chromium-review.googlesource.com/c/chromium/src/+/3955976
* 3758405: Append trailer data to serialized messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3758405
* chore: revert clang roll
This patch reverts https://chromium-review.googlesource.com/c/chromium/src/+/3967491
because that roll breaks the WOA build: https://crbug.com/1377819
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5380.0
* chore: update patches
* 3859750: [linux/wayland] Added plumbing for the state of tiled edges.
https://chromium-review.googlesource.com/c/chromium/src/+/3859750
Also 3970920: [linux/wayland] Fixed the tiled edges for the GTK frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3970920
* chore: bump chromium in DEPS to 109.0.5382.0
* chore: update patches
* chore: revert Use accessibility.pkey when setting page access.
https://chromium-review.googlesource.com/c/chromium/src/+/3949281
breaks our Linux builds run under Docker.
This patch should be removed once
https://chromium-review.googlesource.com/c/chromium/src/+/3949284
is merged.
* 3976312: Roll clang llvmorg-16-init-8189-g97196a2d-2 : llvmorg-16-init-8697-g60809cd2-1
https://chromium-review.googlesource.com/c/chromium/src/+/3976312
* 3967841: [heap] Remove AllocationSpace::MAP_SPACE enum constant
https://chromium-review.googlesource.com/c/v8/v8/+/3967841
* 3956131: [cleanup] Remove flag for Wasm threads & atomics
https://chromium-review.googlesource.com/c/v8/v8/+/3956131
* chore: update docs for Quota: Cleanup kPersistent in BrowsingDataRemover
https://chromium-review.googlesource.com/c/chromium/src/+/3964859
* test: fixup HID test for ARM CI
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2022-10-27 12:37:04 -04:00
Jeremy Rose
07530f8e37
test: fix flake in will-navigate test ( #36153 )
2022-10-27 09:29:19 -04:00
Robo
260678bd0c
docs: add utility process info to tutorial docs ( #36074 )
2022-10-27 20:55:28 +09:00
Shane Gannon
02ad8fcd5f
docs: correcting main example in WebRequest documentation ( #36113 )
...
Correcting main example
The entry `*://electron.github.io` is invalid and produces an exception. i.e.
> UnhandledPromiseRejectionWarning: TypeError: Invalid url pattern *://electron.github.io: Empty path.
Setting a valid path to resolve this issue
2022-10-27 16:18:07 +09:00
daief
ff4816367e
refactor: handle uncaught promise error ( #35484 )
2022-10-27 16:16:26 +09:00
Samuel Attard
ff3289d260
build: use npm@7 for npm view command
2022-10-26 18:31:20 -07:00
Samuel Attard
99a34d5209
build: strip v in the getElectronVersion helper
2022-10-26 17:56:30 -07:00
Jeremy Rose
625b4619d6
fix: resolve loadURL properly for in-page navigations ( #36129 )
2022-10-26 13:57:39 -07:00
Jeremy Rose
a75e8e051e
docs: document that when invoke rejects, it gives a different Error ( #36127 )
2022-10-26 13:56:41 -07:00
Samuel Attard
09302a2fc6
build: use python3 for appveyor commands ( #36131 )
2022-10-25 16:39:21 -07:00
Samuel Attard
b13f776d1b
build: ensure get-version runs in the electron git checkout ( #36128 )
2022-10-25 11:27:10 -07:00
Samuel Attard
7ca2bb5f9c
build: determine electron version from tags not files ( #36106 )
...
* build: determine electron version from tags not files
* build: make electron_version dependent on packed-refs and git HEAD
* build: do not delete electron/.git
* build: do not revert a commit we didn't make
* build: gen version file instead of just writing it
* build: update cache and ninja targets
* build: copy resource.h to generated electron.rc
* build: electron_win32_resources should be public deps
* build: also copy the icon
2022-10-24 23:44:43 -07:00
flynow10
ad289d120f
docs: fixed MenuItem documentation to use the same formatting for all role options ( #36112 )
...
Fixed MenuItem documentation
Some of the items in the list of possible roles were formatted differently, which made it harder to read.
Sorry if this was intended, but I found it easier to read with them all formatted the same.
2022-10-24 14:51:50 -04:00
Sudowoodo Release Bot
85b193178f
Bump v23.0.0-nightly.20221024
2022-10-24 06:01:28 -07:00
Sudowoodo Release Bot
3aed596fba
Bump v23.0.0-nightly.20221021
2022-10-21 06:01:08 -07:00
Shelley Vohr
3e730ab016
test: exit properly when node-spec-runner validates specs ( #36091 )
...
test: exit properly when node spec runner validates specs
2022-10-21 11:13:59 +02:00
John Kleinschmidt
0158077bec
test: disable flaky linux arm/arm64 crash test case ( #36094 )
...
test: disable failing linux arm/arm64 crash test case
2022-10-20 18:06:06 -04:00
Shelley Vohr
7921fec761
refactor: enable OOPIF printing to PDF ( #36051 )
2022-10-20 14:30:40 -04:00
Sudowoodo Release Bot
289bdbe4bc
Bump v23.0.0-nightly.20221020
2022-10-20 06:03:15 -07:00
Robo
da0fd286b4
feat: UtilityProcess API ( #34980 )
...
* chore: initial scaffolding
* chore: implement interface and docs
* chore: address code style review
* fix: cleanup of utility process on shutdown
* chore: simplify NodeBindings::CreateEnvironment
* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
* chore: implement process.parentPort
* chore(posix): implement stdio pipe interface
* chore(win): implement stdio interface
* chore: reenable SetNodeOptions for utility process
* chore: add specs
* chore: fix lint
* fix: update kill API
* fix: update process.parentPort API
* fix: exit event
* docs: update exit event
* fix: tests on linux
* chore: expand on some comments
* fix: shutdown of pipe reader
Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.
* fix: remove exit code check for crash spec
* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
* chore: fix incorrect rebase
* fix: address review feedback
* chore: rename utility_process -> utility
* chore: update docs
* chore: cleanup c++ implemantation
* fix: leak in NodeServiceHost impl
* chore: minor cleanup
* chore: cleanup JS implementation
* chore: flip default stdio to inherit
* fix: some api improvements
* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support
* fix: add tests for cwd and env option
* chore: alt impl for reading stdio handles
* chore: support message queuing
* chore: fix lint
* chore: new UtilityProcess => utilityProcess.fork
* fix: support for uncaught exception exits
* chore: remove process.execArgv as default
* fix: windows build
* fix: style changes
* fix: docs and style changes
* chore: update patches
* spec: disable flaky test on win32 arm CI
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-19 22:49:49 -07:00
Samuel Attard
44c40efecf
refactor: migrate from asar to @electron/asar ( #36070 )
...
* refactor: migrate from asar to @electron/asar
* fix: update asar require calls
2022-10-19 13:39:31 -07:00
Sudowoodo Release Bot
8bd66026a8
Bump v23.0.0-nightly.20221019
2022-10-19 06:02:29 -07:00
Yusoo
dde513b0d3
fix: printToPDF default margins ( #36060 )
...
printToPDF default margins
The document printToPDF has a 1cm margin and this default value has been added in the code.
2022-10-19 10:16:28 +02:00
Shelley Vohr
a8d89b3d52
fix: headless job tracking in printToPDF ( #36046 )
2022-10-18 15:46:19 +02:00
Sudowoodo Release Bot
b13606e55d
Bump v23.0.0-nightly.20221018
2022-10-18 06:01:30 -07:00
Shelley Vohr
4310468513
feat: support serialPort.forget() ( #35310 )
...
feat: enable serialPort.revoke()
2022-10-18 11:22:32 +02:00
Daniel Kocielinski
23d4a252c6
chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView ( #35007 )
...
* hore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView
The draggable regions implementation is related to WebView, so
InspectableWebContentsView is a more appropriate place to put it there.
Also, this refactoring will allow the subsequent extension of the
WebContentsView API, which will eventually replace BrowserView API.
* fix: Lint error
* fix: Adjusted owner-window
2022-10-17 11:10:07 -04:00
electron-roller[bot]
f2c341b655
chore: bump chromium to 108.0.5355.0 (main) ( #35900 )
...
* chore: bump chromium in DEPS to 108.0.5339.0
* chore: bump chromium in DEPS to 108.0.5341.0
* chore: sync patch to unrelated upstream code shear
patches/chromium/network_service_allow_remote_certificate_verification_logic.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3927793
* chore: sync patch to unrelated upstream code shear
patches/chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3927793
* chore: sync patch to unrelated upstream code shear
patches/chromium/chore_add_electron_deps_to_gitignores.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3906023
* chore: refresh patches - `e patches all`
* chore: remove unused parameter from WillCreateURLLoaderRequestInterceptors
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3932218
* perf: avoid unique pointer round trip
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3913938
* refactor: Simplify entropy provider management.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3901211
* fixup! perf: avoid unique pointer round trip
* fixup! perf: avoid unique pointer round trip
* refactor: update typeof FileSelectHelper::select_file_dialog_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3930092
* fixup! fixup! perf: avoid unique pointer round trip
* chore: bump chromium in DEPS to 108.0.5343.0
* chore: update patches
* chore: bump chromium in DEPS to 108.0.5345.0
* chore: bump chromium in DEPS to 108.0.5347.0
* chore: bump chromium in DEPS to 108.0.5349.0
* chore: bump chromium in DEPS to 108.0.5351.0
* chore: bump chromium in DEPS to 108.0.5353.0
* chore: bump chromium in DEPS to 108.0.5355.0
* chore: update patches
* Refactor display::win::DisplayInfo to display::win::internal::DisplayInfo
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3929014
* Update proxy resolution to use NAK - Part 2
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3934016
* Disable PreconnectManager when the user disabled preloading.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3928470
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3937183
* chore: update patches
* chore: update sysroot
* linux: Remove breakpad integration
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3764621
* chore: update comments
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2022-10-17 10:22:24 -04:00
Sudowoodo Release Bot
bcafe8f654
Bump v23.0.0-nightly.20221017
2022-10-17 06:01:25 -07:00
David Sanders
d8d5d4a4a1
docs: update VS Code debugger types to remove "pwa-" prefix ( #36042 )
2022-10-17 13:35:36 +02:00
Piroro-hs
295c5331ee
fix: override app's desktop name and v8 flags in default-app ( #35997 )
2022-10-17 10:34:24 +02:00
John Kleinschmidt
76880be6d2
test: re-enable <webview> tag DOM events emits resize event ( #36026 )
2022-10-17 14:57:44 +09:00
Shelley Vohr
e660fdf776
chore: remove useless Node.js V8 patch ( #36013 )
2022-10-17 14:57:31 +09:00
Sudowoodo Release Bot
dd757f4e22
Bump v23.0.0-nightly.20221014
2022-10-14 06:01:11 -07:00
Jeremy Rose
dc5d27a73b
docs: fix erroneous removal warning for decrementCapturerCount ( #36016 )
2022-10-13 11:40:25 -04:00
Raymond Zhao
ce138fe969
fix: Windows 7 frame showing for frameless non-resizable windows ( #35365 )
2022-10-13 11:39:40 -04:00
Sudowoodo Release Bot
79454dc50d
Bump v23.0.0-nightly.20221013
2022-10-13 07:17:26 -07:00
Sudowoodo Release Bot
8f09d6b47e
Revert "Bump v23.0.0-nightly.20221013"
...
This reverts commit 294f27900c .
2022-10-13 07:14:49 -07:00
John Kleinschmidt
b307314401
test: re-enable power monitor tests on arm64 ( #36015 )
...
test: re-enable powermonitor on arm64
2022-10-13 10:09:09 -04:00
Sudowoodo Release Bot
294f27900c
Bump v23.0.0-nightly.20221013
2022-10-13 06:01:22 -07:00
Jeremy Rose
8a926ffde4
refactor: use views NonClientHitTest for draggable regions on mac ( #35603 )
...
* refactor: use views NonClientHitTest for draggable regions on mac
* iwyu
* add backport of 9bb5f0316
* chore: update patches
* remove some unneeded functions
* remove test for triggering when BW is focused
* chore: update patches
* simplify views/mac split now that the draggable logic is the same
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix build
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-10-12 12:05:45 -04:00
Shelley Vohr
7ce94eb0b4
fix: disable nodeIntegrationInWorker for certain Worker types ( #35919 )
...
fix: disable nodeIntegrationInWorker for certain Worker types
2022-10-12 10:36:24 -04:00
Milan Burda
1328d8d670
docs: use webContents.mainFrame.on() in MessagePort tutorial ( #35824 )
...
* docs: use webContents.mainFrame.on() in MessagePort tutorial
* Update docs/tutorial/message-ports.md
Co-authored-by: Samuel Maddock <smaddock@salesforce.com >
Co-authored-by: Samuel Maddock <smaddock@salesforce.com >
2022-10-12 10:27:58 -04:00
Shelley Vohr
76afd8c028
test: more robust PDF specs ( #35979 )
2022-10-12 10:15:49 -04:00
Milan Burda
eb97ce1931
build: fix building with enable_ppapi = false ( #35988 )
2022-10-12 10:04:30 -04:00
Sudowoodo Release Bot
b6eadf2414
Bump v23.0.0-nightly.20221012
2022-10-12 06:01:34 -07:00
Milan Burda
8212616c76
chore: remove WebKit leftovers after it was renamed to Blink ( #35966 )
2022-10-11 20:01:57 -04:00
Shelley Vohr
ee7cf5a6d4
fix: webContents.printToPDF option plumbing ( #35975 )
...
fix: contents.printToPDF option plumbing
2022-10-11 16:06:34 -07:00
John Kleinschmidt
0759f3320e
docs: remove references to Widevine ( #35980 )
2022-10-11 16:06:13 -07:00
kyrylo-hrechykhin
c2cb97ea29
fix: on-screen-keyboard hides on input blurred in webview ( #35921 )
...
Co-authored-by: Kyrylo Hrechykhin <khrechykhin@microsoft.com >
2022-10-11 13:21:41 -04:00
Shelley Vohr
e8ae0571b8
test: remove redundant color diffing dependency ( #33215 )
2022-10-11 13:11:58 -04:00
Shelley Vohr
b3fd5eb258
fix: drag and drop should copy on macOS ( #35963 )
2022-10-11 18:19:59 +02:00
Sudowoodo Release Bot
9006f0e0c5
Bump v23.0.0-nightly.20221011
2022-10-11 06:00:46 -07:00
Darshan Sen
7493062555
test: add tests for valid electron module names ( #35931 )
...
* test: add tests for valid electron module names
https://github.com/electron/electron/pull/35915 landed without any
tests, so this change adds some. This also documents why these
variations exist.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* fixup! doc: rephrase comment
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* fixup! test: remove "Uncaught Error:" from error regex
Signed-off-by: Darshan Sen <raisinten@gmail.com >
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-10-11 15:59:23 +09:00
Sudowoodo Release Bot
e02de74ff2
Bump v23.0.0-nightly.20221010
2022-10-10 14:35:21 -07:00
Shelley Vohr
ebb866e63d
fix: override content::ContentMainDelegate::CreateContentClient() ( #35932 )
2022-10-10 16:48:44 +02:00
Sudowoodo Release Bot
ef00a2a1da
Revert "Bump v23.0.0-nightly.20221010"
...
This reverts commit 6072c4c71b .
2022-10-10 07:35:18 -07:00
Sudowoodo Release Bot
6072c4c71b
Bump v23.0.0-nightly.20221010
2022-10-10 06:01:40 -07:00
Samuel Attard
1fe21ff712
fix: expose the built-in electron module via the ESM loader ( #35930 )
2022-10-10 03:02:30 -07:00
David Sanders
a072f06168
docs: remove pywin32 mention in Windows build instructions ( #35940 )
2022-10-10 03:01:11 -07:00
Milan Burda
8bfbb251cc
fix: add missing #include "base/cxx17_backports.h" ( #35945 )
2022-10-10 03:00:56 -07:00
Sudowoodo Release Bot
3f4c4a4470
Bump v23.0.0-nightly.20221007
2022-10-07 06:01:54 -07:00
Sudowoodo Release Bot
5c784c2b1b
Bump v23.0.0-nightly.20221006
2022-10-06 06:01:26 -07:00
Samuel Attard
e1494ddc47
chore: cherry-pick c83640db21b5 from chromium ( #35924 )
...
* chore: cherry-pick c83640db21b5 from chromium
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-06 04:27:28 -07:00
Samuel Attard
e31c96a564
fix: only override valid electron module names ( #35915 )
...
Fixes #33014
2022-10-06 19:14:03 +09:00
Shelley Vohr
faafcc7f87
refactor: eliminate DecrementCapturerCount patch ( #35710 )
2022-10-05 19:51:33 +02:00
Shelley Vohr
a6b6816bec
build: clean up patch linting errors ( #35917 )
2022-10-05 10:34:53 -07:00
Sudowoodo Release Bot
f916ce2c49
Bump v23.0.0-nightly.20221005
2022-10-05 06:01:06 -07:00
Keeley Hammond
6196393c94
docs: update supported Mac versions ( #35911 )
2022-10-04 21:25:03 -07:00
Shmuel Leider
ff0517be3e
docs: update bluetooth fiddle example event name to trigger correct event ( #35894 )
...
* Fix event type spelling for bluetooth fiddle example
* docs: Fix event type spelling for bluetooth documentation fiddle example
2022-10-04 15:31:02 -04:00
Sudowoodo Release Bot
d8e037e426
Bump v23.0.0-nightly.20221004
2022-10-04 12:30:32 -07:00
Keeley Hammond
3bd85c8dc2
chore: update libcxx filenames ( #35904 )
...
* chore: update libcxx filenames
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-04 15:29:24 -04:00
Sudowoodo Release Bot
e63d4a6321
Revert "Bump v23.0.0-nightly.20221004"
...
This reverts commit 256d4678bb .
2022-10-04 08:16:47 -07:00
Sudowoodo Release Bot
256d4678bb
Bump v23.0.0-nightly.20221004
2022-10-04 06:00:58 -07:00
Samuel Attard
2cda1443fc
fix: ensure mas builds of the same application can use safestorage ( #35864 )
...
feat: ensure mas builds of the same application can use safestorage
This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account.
Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.
We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.
Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app.
2022-10-03 23:36:17 -07:00
Samuel Attard
12eade752d
build: move from stale GH app to stale action ( #35845 )
...
* build: move from stale GH app to stale action
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-10-03 23:36:01 -07:00
Shelley Vohr
c76a931e20
fix: TryCatch scope in node_bindings ( #35850 )
...
fix: TryCatch scope in node_bindings
2022-10-03 23:35:20 -07:00
electron-roller[bot]
16f459228b
chore: bump chromium to 108.0.5329.0 (main) ( #35628 )
...
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-10-03 13:21:00 -07:00
Sudowoodo Release Bot
94955a7999
Bump v23.0.0-nightly.20221003
2022-10-03 06:01:17 -07:00
Sudowoodo Release Bot
29ca3d1467
Bump v23.0.0-nightly.20220930
2022-09-30 06:01:05 -07:00
Sudowoodo Release Bot
3f598ef1ed
Bump v23.0.0-nightly.20220929
2022-09-29 06:00:48 -07:00
Calvin
6a68afdb8a
docs: update breaking changes for v21 ( #35820 )
2022-09-28 09:47:25 -07:00
Sudowoodo Release Bot
fea844c3da
Bump v22.0.0-nightly.20220928
2022-09-28 06:01:05 -07:00
Jeremy Rose
f82a863f65
feat: replace scroll-touch* with generic input-event ( #35531 )
2022-09-27 12:47:46 -07:00
Shelley Vohr
dfb8a2d804
build: fix deps workflow tag comparison ( #35830 )
2022-09-27 12:24:11 -04:00
James Cash
998a0820d9
fix: set display_id in desktop capturer on Linux ( #33861 )
...
Previously, display_id was an empty string, pending Chrome support for
sharing individual screens. Now that this has been added, it is
desirable to have this property set correctly.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-27 11:40:44 -04:00
Sudowoodo Release Bot
621baa7bb7
Bump v22.0.0-nightly.20220927
2022-09-27 06:01:07 -07:00
Felix Rieseberg
74d59af3c5
fix: Handle an electron.d.ts file in a custom build ( #33979 )
...
* Handle an electron.d.ts file in a custom build
* Fix linter issues
Co-authored-by: Felix Rieseberg <felixr@stripe.com >
2022-09-26 14:39:26 -04:00
Samuel Maddock
c09c94fc98
feat: add WebContents.opener and webContents.fromFrame() ( #35140 )
...
* feat: add WebContents.opener
* feat: add webContents.fromFrame(frame)
* fix: unknown type name
* test: fix and add more fromFrame cases
* docs: clarified terminology
2022-09-26 12:37:08 -04:00
John Kleinschmidt
697a219bcb
feat: add support for Web Bluetooth pin pairing ( #35416 )
...
* feat: add bluetooth pairing handler
* Update docs/api/session.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update docs/api/session.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* docs: update based on review
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs per review
* chore: cleanup callback per review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2022-09-26 10:19:58 -04:00
Shelley Vohr
f8077cc004
build: fix major dependencies update workflow file ( #35811 )
2022-09-26 10:15:37 -04:00
Sudowoodo Release Bot
e0b4c485fe
Bump v22.0.0-nightly.20220926
2022-09-26 06:01:48 -07:00
David Sanders
a2ae308448
build: remove unused GitHub app config file ( #35797 )
2022-09-26 10:55:52 +02:00
Dominik Ilja
7d96321786
docs: minor grammar fixes in tutorial ( #35804 )
2022-09-26 10:53:08 +02:00
electron-roller[bot]
39d79c5c28
chore: bump node to v16.17.1 (main) ( #35800 )
...
* chore: bump node in DEPS to v16.17.1
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-09-26 10:12:52 +02:00
Milan Burda
f62aab76b3
fix: potential exception when calling webFrameMainBinding.fromIdOrNull() ( #35785 )
...
* fix: potential exception when calling webFrameMainBinding.fromIdOrNull()
* replace try/catch in getWebFrameForEvent
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-24 12:19:07 -07:00
Samuel Attard
324db14969
fix: set macOS crypto keychain name earlier ( #34683 )
...
* fix: set macOS crypto keychain name earlier
* spec: ensure arm64 mac tests are cleaned up
2022-09-23 12:32:10 -07:00
Raymond Zhao
8a0b4fa338
feat: add app.getSystemLocale() method ( #35697 )
...
* feat: add app.getSystemLocale() method
* Update shell/browser/electron_browser_main_parts.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Change methods to be const
* Apply PR feedback
* Fix mac compile
* Add missing scope
* Apply style changes
* Change note
* Add braces to get the comment indentation right
* Change to static
* Apply PR feedback
* Fix the documentation
* Remove extraneous file
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-09-23 11:50:46 -07:00
Keeley Hammond
626e248dea
chore: update NMV for Electron 22 ( #35772 )
2022-09-23 11:38:29 -07:00
Keeley Hammond
22d6102702
docs: update E22 release dates ( #35773 )
...
* doc: update E22 release dates
* chore: update 18.0.0 supported chart
2022-09-23 11:38:02 -07:00
Sudowoodo Release Bot
ad33a5f364
Bump v22.0.0-nightly.20220923
2022-09-23 06:02:20 -07:00
Cyril Chukwuebuka
d357218654
docs: changed event.data to data under the message.port in docs ( #35086 )
...
* docs: changed event.data to data under the message.port in docs
* docs: corrected BrowserWindow wrong usage and change window.messagePort to window.electronMessagePort
2022-09-23 01:07:53 -07:00
Samuel Attard
c69754b8e6
build: make patches owned by patch-owners (formed by upgrades + security) ( #35778 )
2022-09-22 14:15:40 -07:00
Aman Gupta
0df8878da4
docs: update the link for Introduction to Node.js ( #35761 )
...
Updated the link for Introduction to NodeJs
2022-09-22 09:46:11 -07:00
Sudowoodo Release Bot
4438731124
Bump v22.0.0-nightly.20220922
2022-09-22 06:01:15 -07:00
Shelley Vohr
eb3262cd87
fix: allow docking DevTools with WCO ( #35754 )
...
fix: allow for docking devtools with WCO
2022-09-22 10:44:27 +02:00
George Xu
4ffdd284c3
docs: add forge-overview.md ( #35473 )
...
* docs: move forge-specific docs to electronforge.io
* docs: add reference to forge icon tutorial
* docs: add references to forge-overview.md
* docs: add recommended
* docs: update forge-overview
* docs: apply code review comments
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-09-21 16:49:22 -04:00
Alexander Prinzhorn
9719cea250
docs: remove claim that HTTPS authenticates the remote server ( #35526 )
...
Update security.md
I don't think this is accurate. This is not a feature of HTTPS. This would require certificate pinning. It has been in the security docs since 2db125890c
Related
https://github.com/electron/electron/issues/3330
https://www.npmjs.com/package/electron-ssl-pinning
https://cheatsheetseries.owasp.org/cheatsheets/Pinning_Cheat_Sheet.html
2022-09-21 16:19:04 -04:00
Akshay Deo
dfc134de42
feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge ( #34974 )
...
* feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge
* Updates exposeInIslatedWorld worldId documentation
2022-09-21 13:17:10 -05:00
Sudowoodo Release Bot
8c3c0f0b50
Bump v22.0.0-nightly.20220921
2022-09-21 06:01:04 -07:00
xrkffgg
0783692809
ci: add blocked/needs-repro issues-helper ( #35605 )
2022-09-21 10:58:15 +02:00
matthewloft
4935fd2422
fix: WebAuthn Discoverable Credential (Resident Credential) ( #35374 )
...
* fix: WebAuthn Discoverable Credential (Resident Credential) #33353
Enables support for Webauthn discoverable credentials (aka resident
credentials). This allows users to authenticate without first having to
select or type a username.
To decide if discoverable credentials are supported, the class
'AuthenticatorCommon', in the chrome content code, indirectly calls the
method 'context::WebAuthenticationDelegate.SupportsResidentKeys(..)'.
The default implementation of this returns false, leaving it up to
specific implementations to override.
This change adds a new class 'ElectronWebAuthenticationDelegate' to
subclass 'WebAuthenticationDelegate' and override the behaviour of the
'SupportsResidentKeys' method to return true.
The implementation is copied from the Chrome browser equivalent
'ChromeWebAuthenticationDelegate', though the chrome class includes
other methods that don't seem to be required for this functionality.
The 'ElectronContentClient' class was also updated to store an instance
of 'ElectronWebAuthenticationDelegate', and to provide an accessor
method, GetWebAuthenticationDelegate().
* Remove redundant, commented-out code
* style: comment cleanup
* style: updated comments and formatting based on pull request review
* style: fix lint error on header guard clause
2022-09-20 15:47:42 -07:00
Milan Burda
99f4a42d41
chore: add missing .eslintrc.json files to limit imports properly ( #35719 )
2022-09-20 13:25:33 -05:00
Sebastian Vittersø
b1d7b30ca3
docs: fix wording mistake in security.md section 4 ( #35682 )
...
Update security.md
Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
2022-09-20 11:14:44 -04:00
Sudowoodo Release Bot
d71b5e53fd
Bump v22.0.0-nightly.20220920
2022-09-20 06:01:49 -07:00
Bruno Pitrus
6cc69122ce
chore: fix ambiguous reference gcc compile error ( #35714 )
2022-09-19 17:05:24 -05:00
Kishan Bagaria
76ce6d5fb4
fix: edge case in app.isInApplicationsFolder() ( #35636 )
...
* fix: edge case in IsInApplicationsFolder
* use realpath instead
* lint
* revert lowercasing
* optimize
* Update shell/browser/ui/cocoa/electron_bundle_mover.mm
* lint
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-19 14:19:49 -04:00
Sudowoodo Release Bot
01cf5c5f99
Bump v22.0.0-nightly.20220919
2022-09-19 07:46:33 -07:00
Sudowoodo Release Bot
80bcea7e55
Revert "Bump v22.0.0-nightly.20220919"
...
This reverts commit 9aed5bcac5 .
2022-09-19 07:45:31 -07:00
Sudowoodo Release Bot
9aed5bcac5
Bump v22.0.0-nightly.20220919
2022-09-19 06:01:44 -07:00
Jeremy Rose
eebf34cc6c
feat: add webContents.close() ( #35509 )
...
* feat: add webContents.close()
* update docs, add test for beforeunload override
* Update web-contents.md
2022-09-16 16:22:59 -07:00
Sudowoodo Release Bot
994834d25a
Bump v22.0.0-nightly.20220916
2022-09-16 06:01:11 -07:00
Milan Burda
7d3f22dd32
fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) ( #35702 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-15 22:33:01 -07:00
Jeremy Rose
fa3cd17475
docs: reverse support matrix order ( #35699 )
2022-09-15 15:53:26 -07:00
Erik Marks
ee8a27492f
build: update .nvmrc Node.js version from 14 to 16 ( #35676 )
...
Update `.nvmrc` Node.js version from 14 to 16
The `DEPS` file states that Electron is on Node.js ^16.x. I am guessing that the PR bumping to Node.js 16 overlooked the `.nvmrc` file, which is updated in this PR. If leaving the `.nvmrc` file on 14 was intentional, please disregard this PR.
2022-09-15 15:40:18 -07:00
Samuel Attard
bd6612273b
build: add stale configuration ( #35698 )
...
* build: add stale configuration
* Update .github/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update stale.yml
* Update .github/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-09-15 15:37:33 -07:00
Ryan Manuel
f25c87dc70
feat: allow custom v8 snapshots to be used in the main process and the default snapshot in the renderer process ( #35266 )
...
* Updates to allow for using a custom v8 snapshot file name
* Allow using a custom v8 snapshot file name
* Fix up patch due to merge
* Use fuse to set up custom v8 snapshot file in browser process
* Refactor to use delegate instead of command line parameter
* Refactoring
* Update due to merge
* PR comments
* Rename patch
* Rename patch
2022-09-15 13:21:16 -07:00
Milan Burda
5cf15cdab7
build: fix building with enable_basic_printing false ( #35687 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-15 19:29:10 +02:00
marekharanczyk
532162d2b5
fix: EventEmitter is missing properties in sandbox preload script. ( #35522 )
2022-09-15 09:33:08 -07:00
Sudowoodo Release Bot
30bdede09f
Bump v22.0.0-nightly.20220915
2022-09-15 06:02:38 -07:00
Shelley Vohr
38a7da692a
chore: make macOS spellchecker fns formal no-ops ( #35514 )
...
* chore: make macOS spellchecker fns formal no-ops
* docs: correct no-op note
* test: add no-op specs
2022-09-14 15:10:16 -07:00
Sudowoodo Release Bot
bf20aabb9e
Bump v22.0.0-nightly.20220914
2022-09-14 06:01:23 -07:00
Juan Cruz Viotti
3a3be23f0e
build: make check-symlinks.js aware of BRANDING.json changes ( #35579 )
...
Right now the `check-symlinks.js` assumes that the branding product name
is "Electron". If users change `BRANDING.json` on custom builds, the
script will fail.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2022-09-13 14:13:40 -07:00
Cheng Zhao
748c6af61e
docs: add back docs about asar archives ( #35563 )
2022-09-13 14:00:42 -07:00
Aryan Shridhar
f244e75927
docs: add IPC validation guideline link in checklist ( #35573 )
2022-09-13 13:56:41 -07:00
Shyamkumar Yadav
c847229a7e
docs: Markdown linting and typo ( #35568 )
...
* Fix reference definitions should be needed
* typo
* typo
* typo and style
* Fix reference definitions should be needed
* Fix typo
* restore to previous
2022-09-13 13:49:11 -07:00
Raymond Zhao
62502b8937
fix: allow maximizing when window enters tablet mode with WCO ( #35617 )
...
* fix: Backport CL 3753528 for WCO
* Update comment
* Update shell/browser/ui/views/win_caption_button_container.cc
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
2022-09-13 13:41:23 -07:00
Michaela Laurencin
12a7d7eea5
fix: remove extra dot in extension ( #35618 )
2022-09-13 11:47:04 -07:00
Jeremy Rose
9f97c3e50a
feat: expose content-bounds-updated event ( #35533 )
2022-09-13 10:49:34 -07:00
Leon Schwanitz
200153da8e
docs: fix typescript error in code samples ( #35641 )
...
Fixed typescript error
2022-09-13 09:38:06 -07:00
Sudowoodo Release Bot
71ba841f0a
Bump v22.0.0-nightly.20220913
2022-09-13 06:01:41 -07:00
Adrian Petrescu
ef463b39be
docs: Use inline image link in faq.md ( #35413 )
...
* Use absolute URL in faq.md image link
The relative link is rendered relative to the host domain, which works fine when viewing it on Github, but since you also use the same generated HTML in your doc site, the link is broken. See here: https://www.electronjs.org/docs/latest/faq#the-font-looks-blurry-what-is-this-and-what-can-i-do
Using an absolute URL here should fix the issue on the main site.
* Use inline image reference for subpixel rendering example
As suggested by @dsanders11
2022-09-12 16:09:12 -07:00
Benjamin Pasero
6ec4c7e563
docs: add performance advice to disable default menu creation ( #35525 )
2022-09-12 15:29:42 -07:00
Milan Burda
b3a744db8a
fix: potential "Object has been destroyed" error in BrowserWindow.getFocusedWindow ( #35520 )
2022-09-12 14:46:05 -07:00
Sudowoodo Release Bot
c14f52aeb7
Bump v22.0.0-nightly.20220912
2022-09-12 06:01:41 -07:00
Sudowoodo Release Bot
88dac9afc5
Bump v22.0.0-nightly.20220909
2022-09-09 06:00:50 -07:00
Jeremy Spiegel
730d9181b3
fix: ensure history navigations are sandboxed-iframe-aware ( #35420 )
2022-09-09 09:08:56 +09:00
electron-roller[bot]
b0036ea43a
chore: bump chromium to 107.0.5286.0 (main) ( #35590 )
...
* chore: bump chromium in DEPS to 107.0.5286.0
* 3866335: media: Rename KeySystemProperties to KeySystemInfo - file renaming
https://chromium-review.googlesource.com/c/chromium/src/+/3866335
* 3864686: [PA] Introduce *Scan buildflag
https://chromium-review.googlesource.com/c/chromium/src/+/3864686
* chore: fixup patch indices
* 3849359: Remove unused PrefValueStore::Delegate
https://chromium-review.googlesource.com/c/chromium/src/+/3849359
* 3873005: [CodeHealth] Modernising extensions Tab utils
https://chromium-review.googlesource.com/c/chromium/src/+/3873005
* 3846595: Auto-select PipeWire target once selection is made
https://chromium-review.googlesource.com/c/chromium/src/+/3846595
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
* fixup! Remove unused PrefValueStore::Delegate
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-09-08 16:23:08 -07:00
Jeremy Rose
a0dbae72c8
chore: remove UnresponsiveSuppressor altogether ( #35507 )
...
* chore: drop unresponsive suppressor for menu_mac
* also for views
* header
* chore: remove UnresponsiveSuppressor altogether
2022-09-08 15:49:33 -07:00
CanadaHonk
a0c20fef96
docs: fix misspelling in fuses ( #35609 )
2022-09-08 15:33:58 -07:00
Erick Zhao
34cb360730
docs: update sandbox renderer defaults for Electron 20 ( #35379 )
...
* docs: update E20 sandbox rendering defaults
* docs: update tutorial
* simplify paragraph
* dont mention context isolation
2022-09-08 13:21:50 -07:00
Raymond Zhao
4fb4167b8b
fix: Set background for WCO container ( #35569 )
...
* fix: Set background for WCO container
* Add background when invalidating as well
2022-09-08 22:11:51 +09:00
Sudowoodo Release Bot
17d5016163
Bump v22.0.0-nightly.20220908
2022-09-08 06:01:03 -07:00
Frank Pian
e3efa16415
fix: session.getBlobData never resolves with blob sizes > 65536 ( #35277 )
...
* fix: session.getBlobData never resolves with blob sizes > 65536 (#34398 )
* Add unit test case for session.getBlobData
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-07 17:47:06 -04:00
Kishan Bagaria
3a6d6ff008
docs: improve registerFileProtocol example ( #35580 )
...
* improve registerFileProtocol example
* link ProtocolResponse
* kick lint
2022-09-07 14:45:09 -04:00
John Kleinschmidt
ebd1c8358b
ci: make sure artifacts are saved for fork PRs ( #35593 )
2022-09-07 13:25:44 -04:00
Keeley Hammond
84c94c3ebb
chore: move dark mode activation to main_win.cc ( #35529 )
2022-09-07 09:39:35 -07:00
Samuel Attard
142eb89d5e
docs: add fuses and asar integrity docs ( #35528 )
2022-09-07 08:41:03 -07:00
Gregory R. Wroblewski
c16baa063a
docs: fix missing includes in code example ( #35479 )
2022-09-07 15:37:29 +02:00
dependabot[bot]
87145c393c
build(deps): bump ansi-regex from 4.1.0 to 4.1.1 ( #35541 )
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-07 15:34:15 +02:00
Jeremy Rose
7d89cb1bd4
chore: remove no-op force-paint for hidden windows ( #35532 )
...
* chore: remove no-op force-paint for hidden windows
* fix build
2022-09-07 11:48:59 +02:00
electron-roller[bot]
08ccc81574
chore: bump chromium to 107.0.5274.0 (main) ( #35375 )
...
* chore: bump chromium in DEPS to 106.0.5247.1
* chore: update can_create_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
* chore: update patches/chromium/printing.patch
Normal code shear.
* chore: update patches/chromium/add_contentgpuclient_precreatemessageloop_callback.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3764862
fix minor code shear that caused the patch to not apply
* chore: update patches/chromium/picture-in-picture.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3781646
Normal code shear.
* chore: update patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3792324
Normal code shear.
* chore: update patches/chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
Normal code shear.
* chore: update patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3798548
Normal code shear.
* chore: update patches/chromium/build_disable_print_content_analysis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3810473
Normal code shear.
* chore: short-circuit_permissions_checks_in_mediastreamdevicescontroller.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3807504
Normal code shear.
* chore: update patches
* chore: bump chromium in DEPS to 106.0.5249.0
* chore: bump chromium in DEPS to 107.0.5250.0
* chore: bump chromium in DEPS to 107.0.5252.0
* chore: bump chromium in DEPS to 107.0.5254.0
* chore: bump chromium in DEPS to 107.0.5256.1
* chore: update v8 patches
* chore: update chromium patches
* [CodeHealthRotation] base::Value::Dict (v2) migration for //c/b/ui/zoom
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3778239
* Add support for snapped window states for lacros
https://chromium-review.googlesource.com/c/chromium/src/+/3810538
* webui: Migrate /chrome/browser/ui/webui URLDataSources to GetMimeType(GURL)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774560
* Provide explicit template arguments to blink::AssociatedInterfaceRegistry::AddInterface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3773459
* Make WebScriptExecutionCallback base::OnceCallback
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/3676532
https://chromium-review.googlesource.com/c/chromium/src/+/3724623
https://chromium-review.googlesource.com/c/chromium/src/+/3675752
* Add implementation of reduce accept language service
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3687391
* Add PermissionResult in //content/public.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3807504
* [Extensions] Add new Webstore domain to extension URLs and clients
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3793043
* chore: update node patches
* chore: fix lint
* chore: update filenames.libcxx.gni
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* chore: bump chromium in DEPS to 107.0.5266.1
* chore: bump chromium in DEPS to 107.0.5268.0
* chore: bump chromium in DEPS to 107.0.5270.1
* chore: update patches
* 3848842: [DevTools] Added 'printing-in-progress' error code.
https://chromium-review.googlesource.com/c/chromium/src/+/38488
* 3855766: PA: Move the allocator shim files into partition_allocator/shim/ | https://chromium-review.googlesource.com/c/chromium/src/+/3855766
* Change gfx::Rect to blink::mojom::WindowFeatures in AddNewContents and some related functions.
https://chromium-review.googlesource.com/c/chromium/src/+/3835666
* Use base::FunctionRef for the various ForEachRenderFrameHost helpers.
https://chromium-review.googlesource.com/c/chromium/src/+/3767487
* [loader] Send cached metadata as part of OnReceiveResponse
https://chromium-review.googlesource.com/c/chromium/src/+/3811219
* 3832927: [json-schema-compiler] Support abs::optional<int>
https://chromium-review.googlesource.com/c/chromium/src/+/3832927
* Use unique_ptr for BrowserPluginGuestDelegate::CreateNewGuestWindow
https://chromium-review.googlesource.com/c/chromium/src/+/3847070
* 3847044: [Android] Dismiss select popup upon entering fullscreen
https://chromium-review.googlesource.com/c/chromium/src/+/3847044
* chore: update patches
* chore: add missing header
* Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3786946: cast pwrite64 arg to long to avoid compilation error on arm
https://chromium-review.googlesource.com/c/linux-syscall-support/+/3786946
* chore: update patches after rebase
* 3846114: float: Implement for lacros p2.
https://chromium-review.googlesource.com/c/chromium/src/+/3846114
* 3825237: Enable -Wunqualified-std-cast-call
https://chromium-review.googlesource.com/c/chromium/src/+/3825237
* chore: bump chromium in DEPS to 107.0.5272.0
* chore: update patches
* 3835746: Rename PepperPluginInfo to ContentPluginInfo
https://chromium-review.googlesource.com/c/chromium/src/+/3835746
* 3852542: Plumb drag-image rect from blink to browser to RenderWidgetHostImpl
https://chromium-review.googlesource.com/c/chromium/src/+/3852542
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
Also 3840687: [json-schema-compiler] Support abs::optional<double>
https://chromium-review.googlesource.com/c/chromium/src/+/3840687
* 3857319: Reland "Remove PrefService::Get"
https://chromium-review.googlesource.com/c/chromium/src/+/3857319
* 3854614: Rework LinuxUi ownership and creation
https://chromium-review.googlesource.com/c/chromium/src/+/3854614
* chore: bump chromium in DEPS to 107.0.5274.0
* 3866104: [DownloadBubble] Change download notifications in exclusive_access
https://chromium-review.googlesource.com/c/chromium/src/+/3866104
* chore: update patches
* chore: disable optimization guide for preconnect feature
* 3860569: Enable -Wshadow on Linux.
https://chromium-review.googlesource.com/c/chromium/src/+/3860569
* chore: update patches after rebase
* fixup: update to accomodate Wc++98-compat-extra-semi flag
* Revert "fixup! Make WebScriptExecutionCallback base::OnceCallback"
This reverts commit 0866fe8648671f04e4ea45ceed85db6e4a3b260b.
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* 3840937: [sandbox] Merge V8_SANDBOXED_POINTERS into V8_ENABLE_SANDBOX
https://chromium-review.googlesource.com/c/v8/v8/+/3840937
* fixup! chore: update can_create_window.patch
* chore: update patches
* 53946: Track SSL_ERROR_ZERO_RETURN explicitly.
https://boringssl-review.googlesource.com/c/boringssl/+/53946
* fixup: Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3805932: [headless] Added print compositor support for OOPIF printing.
https://chromium-review.googlesource.com/c/chromium/src/+/3805932
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-09-07 09:46:37 +02:00
Sudowoodo Release Bot
f53ca20d41
Bump v22.0.0-nightly.20220906
2022-09-06 07:21:50 -07:00
Sudowoodo Release Bot
e09a4a31ca
Revert "Bump v22.0.0-nightly.20220906"
...
This reverts commit bda094674f .
2022-09-06 06:55:15 -07:00
Sudowoodo Release Bot
bda094674f
Bump v22.0.0-nightly.20220906
2022-09-06 06:01:28 -07:00
Sudowoodo Release Bot
de206987fe
Bump v22.0.0-nightly.20220905
2022-09-05 06:01:13 -07:00
Shelley Vohr
2db0f7f8d4
fix: screen.getCursorScreenPoint() crash on Wayland ( #35503 )
...
fix: screen.getCursorScreenPoint() crash on Wayland
2022-09-05 10:10:50 +02:00
Sudowoodo Release Bot
98c0fa1c8b
Bump v22.0.0-nightly.20220902
2022-09-02 06:01:55 -07:00
Sudowoodo Release Bot
bfbe73396b
Bump v22.0.0-nightly.20220901
2022-09-01 06:00:49 -07:00
Jeremy Rose
6ad679f540
feat: webFrameMain.origin ( #35438 )
2022-08-31 17:40:57 -07:00
Jeremy Rose
a7248af79e
chore: remove unneeded SetBackgroundOpaque hack ( #35496 )
2022-08-31 17:40:26 -07:00
Jeremy Rose
f99122abfc
refactor: BrowserView is owned by a BaseWindow ( #35511 )
2022-08-31 17:40:02 -07:00
Jeremy Rose
9cdc8bf6ca
chore: drop unresponsive suppressor for menus ( #35498 )
2022-08-31 10:25:01 -07:00
Milan Burda
b7c5b48c38
test: move api-media-handler-spec from spec-main to spec ( #35518 )
2022-08-31 08:32:57 -07:00
Jeremy Rose
5fe1ac5c3d
refactor: simplify WebContents::Destroy ( #35510 )
2022-08-31 10:16:27 -05:00
Sudowoodo Release Bot
1830c0f6c3
Bump v22.0.0-nightly.20220831
2022-08-31 06:01:55 -07:00
Shelley Vohr
e0fb5cbe1f
fix: crash loading non-standard schemes in iframes ( #35485 )
2022-08-31 10:08:11 +02:00
Sudowoodo Release Bot
bfced8cbfe
Bump v22.0.0-nightly.20220830
2022-08-30 06:00:55 -07:00
Shelley Vohr
75f9573e53
fix: compensate for title bar height when setting bounds on BrowserView ( #34713 )
...
fix: compensate for title bar height when setting bounds
2022-08-29 17:53:03 +02:00
electron-roller[bot]
d0e220cbce
chore: bump node to v16.17.0 (main) ( #35350 )
...
* chore: bump node in DEPS to v16.17.0
* chore: fixup asar patch
* lib: use null-prototype objects for property descriptors
https://github.com/nodejs/node/pull/43270
* src: make SecureContext fields private
https://github.com/nodejs/node/pull/43173
* crypto: remove Node.js-specific webcrypto extensions
https://github.com/nodejs/node/pull/43310
* test: refactor to top-level await
https://github.com/nodejs/node/pull/43500
* deps: cherry-pick two libuv fixes
https://github.com/nodejs/node/pull/43950
* src: slim down env-inl.h
https://github.com/nodejs/node/pull/43745
* util: add AggregateError.prototype.errors to inspect output
https://github.com/nodejs/node/pull/43646
* esm: improve performance & tidy tests
https://github.com/nodejs/node/pull/43784
* src: NodeArrayBufferAllocator delegates to v8's allocator
https://github.com/nodejs/node/pull/43594
* chore: update patch indices
* chore: update filenames
* src: refactor IsSupportedAuthenticatedMode
https://github.com/nodejs/node/pull/42368
* src: add --openssl-legacy-provider option
https://github.com/nodejs/node/pull/40478
* lib,src: add source map support for global eval
https://github.com/nodejs/node/pull/43428
* trace_events: trace net connect event
https://github.com/nodejs/node/pull/43903
* deps: update ICU to 71.1
https://github.com/nodejs/node/pull/42655
This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
* lib: give names to promisified exists() and question()
https://github.com/nodejs/node/pull/43218
* crypto: add CFRG curves to Web Crypto API
https://github.com/nodejs/node/pull/42507
* src: fix memory leak for v8.serialize
https://github.com/nodejs/node/pull/42695
This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.
* buffer: fix atob input validation
https://github.com/nodejs/node/pull/42539
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-08-29 09:55:36 -04:00
Shelley Vohr
1847581848
fix: crash on WebWorker destruction ( #35422 )
2022-08-29 15:45:48 +02:00
Sudowoodo Release Bot
2f23bdb19e
Bump v22.0.0-nightly.20220829
2022-08-29 06:02:20 -07:00
Shelley Vohr
4744674e93
fix: crash when switching origins with emulation settings set ( #35466 )
2022-08-29 14:53:24 +02:00
Shelley Vohr
f6bbad287a
chore: use nghttp2's config.h on all platforms ( #35449 )
...
https://github.com/nodejs/node/pull/27283
2022-08-29 12:23:47 +02:00
Nik K
23264488c5
docs: update docs description to match sidebar ( #35144 )
...
Update introduction.md
2022-08-29 17:17:58 +09:00
Shelley Vohr
d829fb7ef2
chore: delete implicit fallthrough patch ( #35452 )
2022-08-26 13:21:33 +02:00
Samuel Attard
f65b05b8cc
fix: pass rfh instances through to the permission helper ( #35419 )
...
* fix: pass rfh instances through to the permission helper
* refactor: use WeakDocumentPtr instead of frame node id
* fix: handle missing initiator document
* fix: dispatch openExternal event for top level webview navs still
2022-08-26 12:31:33 +02:00
Shelley Vohr
8128fa6d85
build: fix missing patch config dir error ( #35451 )
2022-08-25 09:39:16 -07:00
Jeremy Rose
3eb593dfde
test: fix some broken globs for spec-main ( #35439 )
2022-08-25 09:36:08 -07:00
Sudowoodo Release Bot
3de7844212
Bump v22.0.0-nightly.20220825
2022-08-25 06:02:31 -07:00
Shelley Vohr
a3a9463024
fix: fullscreen crashing with roundedCorners: false ( #35421 )
2022-08-25 13:39:01 +02:00
Shelley Vohr
70d6cbfb44
chore: remove unused GuestViewContainer ( #35405 )
...
chore: remove unused GuestViewContainer
2022-08-25 15:56:47 +09:00
Shelley Vohr
22ff2b6b93
fix: Node.js atob input validation ( #35415 )
...
fix: Node.js atob input validation
2022-08-25 15:55:07 +09:00
Keeley Hammond
7e8607fd7a
ci: fix appveyor x64 tests ( #35406 )
...
* ci: fix appveyor x64 tests
* extract builtins-pgo to correct directory
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-08-25 10:11:44 +09:00
John Kleinschmidt
6f77e63804
ci: fixup doc-only-change on Windows ( #35431 )
2022-08-24 17:39:56 -04:00
John Kleinschmidt
07c3e62d68
build: fix export patches to work when source directory does not exist ( #35432 )
2022-08-24 17:37:11 -04:00
Sudowoodo Release Bot
e1459f4d50
Bump v22.0.0-nightly.20220824
2022-08-24 06:02:36 -07:00
Sudowoodo Release Bot
900ffede41
Bump v22.0.0-nightly.20220823
2022-08-23 06:01:36 -07:00
Michaela Laurencin
3ce35f224e
fix: add restore event for minimized maximization ( #35342 )
2022-08-23 10:32:42 +09:00
Raymond Zhao
0ff6508f5b
chore: apply chromium commit 30a32e6 ( #35370 )
...
chore: Apply Chromium commit 30a32e6
2022-08-23 10:31:23 +09:00
Robo
33325e3608
fix: undefined details.requestingUrl from session.setPermissionCheckHandler ( #35281 )
...
fix: undefined details.requestingUrl from setPermissionCheckHandler
2022-08-23 10:25:57 +09:00
Jeremy Rose
221bb51326
feat: session.setDisplayMediaRequestHandler ( #30702 )
2022-08-22 14:15:32 -07:00
Sudowoodo Release Bot
0c04be502c
Bump v22.0.0-nightly.20220822
2022-08-22 13:13:15 -07:00
Keeley Hammond
d6d86f8b16
build: update libcxx filenames ( #35397 )
...
* build: update libcxx filenames
* build: change upload_to_storage variable
2022-08-22 13:11:41 -07:00
Sudowoodo Release Bot
eca6029c0a
Revert "Bump v22.0.0-nightly.20220822"
...
This reverts commit fc2e6bd0ed .
2022-08-22 08:58:00 -07:00
Samuel Attard
9b2b1998b8
fix: ensure chrome colors are initialized ( #35034 )
...
* fix: ensure chrome colors are initialized
* build: fix linking on windows
* build: fix linking on windows
* build: add needed files to chromium_src/BUILD
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2022-08-22 16:38:45 +02:00
Sudowoodo Release Bot
fc2e6bd0ed
Bump v22.0.0-nightly.20220822
2022-08-22 06:02:41 -07:00
Robo
19baea4bc2
chore: update process singleton patch ( #35376 )
...
* chore: update process singleton patch
* fix: windows compilation error
* chore: remove outdated comment in patch
2022-08-20 07:45:58 +09:00
John Kleinschmidt
9b787d30f4
ci: use AppVeyor workflows ( #35377 )
...
* ci: use AppVeyor workflows
* fixup for skipping test on pr jobs
2022-08-19 13:10:16 -04:00
Sudowoodo Release Bot
748a739291
Revert "Bump v22.0.0-nightly.20220819"
...
This reverts commit b9bffb19ca .
2022-08-19 08:35:09 -07:00
Sudowoodo Release Bot
b9bffb19ca
Bump v22.0.0-nightly.20220819
2022-08-19 06:01:57 -07:00
Sudowoodo Release Bot
82f146e223
Revert "Bump v22.0.0-nightly.20220818"
...
This reverts commit 402553aeeb .
2022-08-18 08:56:57 -07:00
Sudowoodo Release Bot
402553aeeb
Bump v22.0.0-nightly.20220818
2022-08-18 06:01:56 -07:00
Jeremy Rose
1d6885c781
fix: don't bypass redirect checks ( #35357 )
2022-08-17 17:04:47 -07:00
electron-roller[bot]
97b353a30a
chore: bump chromium to 106.0.5216.0 (main) ( #34993 )
2022-08-17 11:35:53 -07:00
George Xu
e15e66f229
docs: add dependencies and troubleshooting section to build-instructions ( #35345 )
...
* docs: add dependencies and troubleshooting section to build-instructions
* docs: update certifi description
2022-08-17 10:54:49 -07:00
Sudowoodo Release Bot
532025c207
Bump v22.0.0-nightly.20220817
2022-08-17 06:05:24 -07:00
Robo
43182bf030
fix: promise support with webFrameMain.executeJavaScript ( #35292 )
...
* fix: promise support with webFrameMain.executeJavaScript
* chore: reject when result is an error
2022-08-17 13:08:13 +09:00
Bruno Pitrus
8e4a168a13
build: allow Linux distros to build against system shared libraries ( #34841 )
...
* build: allow Linux distros to build against system shared libraries
Add GN flags to build the embedded nodejs copy against system libraries
instead of vendored copies in `third_party/electron_node/deps`:
* cares
* llhttp
* nghttp2
* hdr_histogram
See also chromium's build/linux/unbundle/README for more
Electron-relevant information about vendored dependencies.
* Update patches/node/build_add_gn_build_files.patch
Co-authored-by: Darshan Sen <raisinten@gmail.com >
Co-authored-by: Darshan Sen <raisinten@gmail.com >
2022-08-16 22:50:15 -04:00
Raymond Zhao
947f1b0abf
fix: Frameless window shows frame while opening ( #35189 )
...
* fix: Frameless window shows frame while opening
* Clarify comments
* Inline setter
* Edit comment
2022-08-16 14:22:47 -07:00
Jeremy Rose
db7c92fd57
test: drop now-empty remote runner ( #35343 )
...
* test: drop the now-empty remote runner from CI
* move fixtures to spec-main
* remove remote runner
* fix stuff
* remove global-paths hack
* move ts-smoke to spec/
* fix test after merge
* rename spec-main to spec
* no need to ignore spec/node_modules twice
* simplify spec-runner a little
* no need to hash pj/yl twice
* undo lint change to verify-mksnapshot.py
* excessive ..
* update electron_woa_testing.yml
* don't search for test-results-remote.xml
it is never produced now
2022-08-16 15:23:13 -04:00
Sudowoodo Release Bot
e87c4015fe
Bump v22.0.0-nightly.20220816
2022-08-16 06:01:24 -07:00
Milan Burda
e85450b21a
fix: IPC emit order in -ipc-ports handler ( #35320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-08-16 11:21:56 +09:00
Shelley Vohr
672539187c
fix: serialPort.open() failing ( #35306 )
...
fix: serialPort.open() failing
2022-08-15 11:49:20 -04:00
Zuohui Yang
cbc1ee5775
fix: add uv_loop_close when object release to fix crash ( #35322 )
...
Co-authored-by: yangzuohui <yangzuohui@bytedance.com >
2022-08-15 10:40:52 -04:00
Sudowoodo Release Bot
9c2d89476c
Bump v22.0.0-nightly.20220815
2022-08-15 06:01:59 -07:00
Milan Burda
8424779906
refactor: don't expose deprecate as an internal module ( #35311 )
2022-08-15 17:09:33 +09:00
Jeremy Rose
81766707fc
test: migrate remaining webview specs to main ( #35213 )
...
* test: migrate remaining webview specs to main
* fix merge
* add dirty-chai
* retry capturePage()
* fix test
2022-08-15 17:06:02 +09:00
Rhitik Bhatt
4cb57ad1a0
docs: removes unused import in preload script ( #35324 )
...
* Remove unused import of path
This import gives out the error in the preload script:
Error: module not found: path
at preloadRequire
* Removes unused import in preload script
notes: Removes unused import which causes issue in preload script of drag and drop tutorial
* Remove import path as it is not used in the script
note: Removes import path as it is not used in the script
2022-08-15 15:23:59 +09:00
Charles Kerr
a8934d2302
docs: add Electron deps to license credits file ( #35283 )
...
* docs: add Electron deps to license credits file
* fixup! docs: add Electron deps to license credits file
remove nan; it is dev-only
2022-08-15 10:35:12 +09:00
Shelley Vohr
f1216ca593
refactor: simplify Browser::SetLoginItemSettings ( #35303 )
...
refactor: simplify Browser::SetLoginItemSettings
2022-08-15 09:44:23 +09:00
Sudowoodo Release Bot
ceabca850c
Bump v22.0.0-nightly.20220812
2022-08-12 06:01:44 -07:00
Keeley Hammond
81d95b53b3
build: bump @electron/get to 2.0.0, node to >= 12+ ( #35301 )
...
* infra: bump @electron/get to 2.0.0, node to >= 12+
* chore: empty commit to trigger CircleCI
2022-08-11 15:31:24 +02:00
Shelley Vohr
4d54cadb28
fix: WCO occlusion of DevTools ( #35209 )
2022-08-11 15:16:12 +02:00
Sudowoodo Release Bot
eab7ab2c47
Bump v22.0.0-nightly.20220811
2022-08-11 06:01:27 -07:00
Sudowoodo Release Bot
882cdb1f7a
Bump v22.0.0-nightly.20220810
2022-08-10 06:01:07 -07:00
Samuel Attard
1d95b98cc8
docs: fix getStoragePath return type ( #35288 )
...
Fixes #35255
2022-08-09 22:39:36 -07:00
Milan Burda
8646bf8d30
chore: remove deprecated 'new-window' event ( #34526 )
2022-08-09 17:57:05 -04:00
Trang Le
32fefb1f50
fix(docs): fix a typo in section on debugging with VSCode ( #35256 )
...
fix(docs): fix a typo
2022-08-09 15:01:38 -04:00
Sudowoodo Release Bot
6548808054
Bump v22.0.0-nightly.20220809
2022-08-09 06:01:28 -07:00
Jeremy Rose
faa2f7afa3
test: migrate asar specs to main runner ( #35230 )
...
* test: migrate node specs to main
* test: migrate asar specs to main runner
* fix execFile
2022-08-09 09:39:14 +02:00
Darshan Sen
f3dbdaaf33
build: fix error in the ts-compile-doc-change step ( #35258 )
...
build: fix error in the ts-compile-doc-change step
Fixes the following error: https://app.circleci.com/pipelines/github/electron/electron/56517/workflows/ea0f6548-e0ac-40c6-bacb-e24610cd6670/jobs/1287168?invite=true#step-103-29
```sh
$ webpack --config build/webpack/webpack.config.asar.js --output-filename=asar.js --output-path=./.tmp --env.mode=development
[webpack-cli] Error: Unknown option '--env.mode=development'
[webpack-cli] Run 'webpack --help' to see available commands and options
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
This probably started happening because of the recent webpack upgrade
in https://github.com/electron/electron/pull/34990 .
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-08-08 17:09:09 -04:00
Sudowoodo Release Bot
0400eb2e60
Bump v22.0.0-nightly.20220808
2022-08-08 06:02:50 -07:00
Aaron Meriwether
91f9436ad8
fix: app.relaunch loses args when execPath specified ( #35108 )
2022-08-08 10:12:06 +02:00
Milan Burda
34b985c556
refactor: use optional chaining / nullish coalescing operator ( #35217 )
2022-08-08 10:11:04 +02:00
John Kleinschmidt
76431ac1fa
test: temporarily disable tests on mas arm64 that are causing a crash ( #35226 )
...
* test: temporarily disable test on mas arm64 that is causing crash
* disable the right test
* chore: speculative fix for CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER crash
* enable all the tests
* Revert "chore: speculative fix for CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER crash"
This reverts commit b7c8ef364c .
* test: disable tests that crash on mas arm64
2022-08-06 19:02:04 -04:00
Shelley Vohr
a11cc3274f
build: fix webpack prod failure ( #35227 )
2022-08-05 09:21:00 -07:00
Sudowoodo Release Bot
a719568ac1
Revert "Bump v22.0.0-nightly.20220805"
...
This reverts commit fbcd8f8a6e .
2022-08-05 07:54:04 -07:00
Sudowoodo Release Bot
fbcd8f8a6e
Bump v22.0.0-nightly.20220805
2022-08-05 06:01:13 -07:00
Jeremy Rose
aaa60dc0bc
test: migrate remaining chromium specs to main ( #35216 )
2022-08-04 17:20:56 -07:00
Jeremy Rose
4cfdef0ffd
test: migrate node specs to main ( #35212 )
2022-08-04 17:20:17 -07:00
Erick Zhao
b9fea0d2d2
docs: remove reference to electron/i18n in README ( #35228 )
2022-08-04 15:18:06 -07:00
Sudowoodo Release Bot
1b2e5b4106
Revert "Bump v22.0.0-nightly.20220804"
...
This reverts commit 47a08f9570 .
2022-08-04 08:27:56 -07:00
Sudowoodo Release Bot
47a08f9570
Bump v22.0.0-nightly.20220804
2022-08-04 06:00:52 -07:00
Brad Carter
21117ea5b2
docs: update tray docs with info for mac menubar icons ( #35136 )
2022-08-04 11:24:32 +02:00
Jeremy Rose
6d859dcd7f
feat: add WebContents.ipc ( #34959 )
2022-08-03 16:55:12 -07:00
Jeremy Rose
bba22ae720
test: migrate <webview> tag event specs to main runner ( #35077 )
2022-08-03 12:03:44 -07:00
Jeremy Rose
d15348ecc2
test: migrate webview attribute specs to spec-main ( #35076 )
2022-08-03 09:59:00 -07:00
Shelley Vohr
3baf713648
build: upgrade webpack and related deps ( #34990 )
2022-08-03 10:42:50 -04:00
Sudowoodo Release Bot
2b96d06960
Revert "Bump v21.0.0-nightly.20220803"
...
This reverts commit 4e919c919c .
2022-08-03 07:36:56 -07:00
TAN
c47031a279
docs: Fix the URL bugs at tutorial-6-publishing-updating.md ( #35175 )
...
* Update tutorial-6-publishing-updating.md
The dot at the end of the URL will depend on the site that cannot open. Because it will open `https://update.electronjs.org./ ` which does not exist.
* docs: fix the URL problems at tutorial-6-publishing-updating.md
The dot at the end of the URL will depend on the site that cannot open. Because it will open `https://update.electronjs.org./ ` which does not exist.
* docs: fix the URL problems at tutorial-6-publishing-updating.md
* docs: fix the URL problems at tutorial-6-publishing-updating.md
2022-08-03 10:20:37 -04:00
Erick Zhao
74432a313c
docs: fix link in tutorial ( #35192 )
...
Relands https://github.com/electron/electronjs.org-new/pull/240 upstream
2022-08-03 10:12:06 -04:00
Sudowoodo Release Bot
4e919c919c
Bump v21.0.0-nightly.20220803
2022-08-03 06:01:39 -07:00
Maya Nedeljković Batić
fb39f241fb
docs: update categories to match sidebar ( #35196 )
...
This page describes each of the categories available in the sidebar, but some of the category titles didn't match.
2022-08-03 12:03:45 +02:00
Cheng Zhao
afa4f5052b
fix: consider dock space when showing menu ( #35194 )
2022-08-03 17:52:42 +09:00
msizanoen1
7b8fb2b074
fix: Wayland general CSD fixes ( #34955 )
...
* fix: broken wayland window decorations due to botched chromium update
The `GetTitlebarBounds().height()` is obviously intended to be placed in
the `top` parameter, which used to be the second one before upstream
removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter
for `gfx::Insets::TLBR`, which was intended to replace the removed
`Inset` function. However, whoever updated Chromium kept the parameter
unchanged, causing the title bar height to be passed to the `left`
parameter, causing the window title bar to be unclickable.
* fix: wayland window top bar buttons unclickable
Use NonClientFrameView::TargetForRect for the ClientFrameViewLinux
implementation because the default inherited from FramelessView blocks
any non-HTCLIENT events.
* fix: add maximized parameter to LinuxUI::GetWindowFrameProvider
* fix: pass frame_->IsMaximized() to GetWindowFrameProvider
This ensures that the toolkit renders the window decorations in maximized mode
while the window is maximized to ensure that there is no empty space around the window.
2022-08-03 17:51:52 +09:00
Cheng Zhao
4e8480b15b
chore: fix linking with component ffmpeg ( #35178 )
2022-08-03 16:51:30 +09:00
Keeley Hammond
3fe00d75e9
chore: update NMV for Electron 21 ( #35124 )
2022-08-02 12:57:42 -07:00
Jeremy Rose
3d4d1b33ba
fix: fail non-fatally when InitLogging fails ( #35138 )
2022-08-02 15:45:30 -04:00
Robo
53cd23159e
chore: remove unsupported skiptaskbar linux impl ( #35179 )
...
chore: unsupported skiptaskbar linux impl
2022-08-02 11:53:36 -07:00
Sudowoodo Release Bot
31be6ecf7b
Bump v21.0.0-nightly.20220802
2022-08-02 06:01:38 -07:00
Robo
e3893632e7
fix: touch events not recognized by WCO on windows ( #35117 )
2022-08-02 12:13:58 +09:00
Michaela Laurencin
0cdc946b27
fix: modify file extension generation on Windows ( #34723 )
...
* fix: modify file extension generation on Windows
* modify includes
* include vector in header
* add win build flags
* remove hardcoded strings
* Update shell/browser/electron_download_manager_delegate.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix string manipulation and function definitions
* Update electron_download_manager_delegate.h
* convert to std::string and modify for electron
* Update shell/browser/electron_download_manager_delegate.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* remove vector include and update conversion
* add vectr include for lint
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-08-02 09:40:17 +09:00
John Kleinschmidt
0d36c0cdc6
ci: turn off windows on arm test result comments ( #35142 )
2022-08-01 18:59:20 -04:00
Shelley Vohr
7588bb7425
fix: DCHECK entering fullscreen while loading url ( #35111 )
...
* fix: DCHECK entering fullscreen while loading url
* spec: fixup test
2022-08-01 16:52:58 -04:00
Keeley Hammond
6c17dd2296
fix: ensure native modules use the correct config ( #35159 )
...
* fix: ensure native modules are built with config.gypi
This works by patching node.h to check that two defines are set using the equivilant of an XNOR operation. One define "ELECTRON_ENSURE_CONFIG_GYPI" is set via common.gypi which is _already_ used to build native modules and has been since the dawn of time. Therefore this define will be set for all native module compilations targetting the Electron runtime. The second define "USING_ELECTRON_CONFIG_GYPI" is only defined when the gypi argument "using_electron_config_gypi" is set to 1 which is only done so via config.gypi. Only new enough versions of node-gyp correctly use the config.gypi file thus resulting in a compilation error on version of node-gyp that are too old.
* chore: fix lint
Co-authored-by: Samuel Attard <sattard@salesforce.com >
2022-08-01 07:52:26 -07:00
Sudowoodo Release Bot
29434ee7c6
Bump v21.0.0-nightly.20220801
2022-08-01 06:01:38 -07:00
Charles Kerr
b67c69d741
fix: remove skip-taskbar feature on Linux. ( #35123 )
2022-08-01 12:42:02 +02:00
Kilian Valkhof
00e9bf107a
docs: new main -> renderers messageChannel example ( #34978 )
...
* docs: new main -> renderers messageChannel example
* consistent use of your
* fix a typo
* linting
* markdown linting
* Update docs/tutorial/message-ports.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* update code example headings, reference contextIsolation example
* remove nodeIntegration: false from browserWindows
* rename "messagePort" to "electronMessagePort" for compatibility
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2022-07-29 09:47:43 -07:00
Shelley Vohr
9028bb79a8
fix: empty result of webContents.getUserAgent() ( #35069 )
...
fix: empty result of webContents.getUserAgent()
2022-07-29 11:09:47 -04:00
Sudowoodo Release Bot
8004cb8722
Bump v21.0.0-nightly.20220729
2022-07-29 06:00:43 -07:00
Sofia Nguy
7f757075bc
docs: update E21 release date ( #35122 )
...
* docs: update E21 release date
* chore: fix lint
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2022-07-28 21:54:48 -07:00
John Kleinschmidt
674596d11e
ci: switch to GHA for WOA ( #35109 )
...
* ci: switch to GHA for WOA
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-07-28 19:05:59 -04:00
Sudowoodo Release Bot
3c2ec2280e
Bump v21.0.0-nightly.20220728
2022-07-28 06:03:11 -07:00
Jeremy Rose
de1cec8693
test: migrate shell specs to main process ( #35058 )
2022-07-27 09:18:33 -07:00
Sudowoodo Release Bot
99c2706376
Bump v21.0.0-nightly.20220727
2022-07-27 06:01:22 -07:00
Stuart Schechter
63593ffb22
docs: don't wait for ready event to register open-url listener ( #35019 )
...
* Update app.md
Add warning about late registration of the open-url event.
* Update app.md
2022-07-27 14:00:35 +02:00
Samuel Attard
b0c6fb5152
chore: add electon deps to //src gitignore ( #35065 )
2022-07-27 13:15:34 +02:00
Jeremy Rose
77b4aab720
test: migrate the rest of the webFrame tests to main ( #35080 )
2022-07-27 11:10:14 +02:00
Jeremy Rose
7c2ed98214
test: migrate more chromium specs to main ( #35081 )
2022-07-27 11:10:04 +02:00
Charles Kerr
62001dc6cb
fix: crash on startup in X11 ( #35075 )
...
Fixes #34996 .
2022-07-27 13:44:44 +09:00
Keeley Hammond
ff804e3a74
fix: use win_clang_x64 binary for x86 extract symbols ( #35078 )
...
fix: use win_clang_x64 for x86 extract symbols
2022-07-27 13:33:07 +09:00
Ian German Mesner
9416091180
fix: allow setsize to be called within a move or resize for preventDefault ( #34843 )
...
fix : #34599 allow setsize to be called within a move or resize for preventDefault
2022-07-27 09:02:06 +09:00
Jeremy Rose
6d9e8b65bc
test: add process module tests for main process ( #35057 )
2022-07-26 15:42:50 -07:00
Shelley Vohr
b42fd1ddca
fix: handle WCO pressed state when going maximized -> minimized ( #35070 )
2022-07-26 13:30:15 -04:00
John Kleinschmidt
182ab9ad76
test: remove duplicate test that is causing hang in Windows ( #35071 )
2022-07-26 13:28:59 -04:00
Jeremy Rose
77e1a046ec
test: move chromium spec config to its own folder ( #35063 )
2022-07-26 09:37:11 -07:00
Devin Foley
0be73d18ef
fix: Make disable_color_correct_rendering patch work again ( #35050 )
...
Fix disable_color_correct_rendering patch.
2022-07-26 09:35:10 -07:00
Jeremy Rose
c842f63383
test: migrate process module specs to spec-main ( #35056 )
2022-07-26 09:31:26 -07:00
Sudowoodo Release Bot
6674082041
Bump v21.0.0-nightly.20220726
2022-07-26 06:01:07 -07:00
Jeremy Rose
cabfb8507d
test: remove references to robotjs ( #35064 )
2022-07-26 01:12:04 -07:00
Jeremy Rose
aa40652456
test: remove unused spec/expect-helpers ( #35055 )
2022-07-26 09:57:12 +02:00
Jeremy Rose
dd68fae081
test: migrate nativeImage specs to main ( #35062 )
...
* test: move nativeImage specs to main
* simplify test
2022-07-26 09:57:01 +02:00
Jeremy Rose
ad1bbc198b
test: migrate clipboard spec to spec-main ( #35059 )
2022-07-26 09:37:37 +02:00
electron-roller[bot]
2c51a81e85
chore: bump node to v16.16.0 (main) ( #34853 )
...
* chore: bump node in DEPS to v16.16.0
* chore: update patches
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-25 17:06:52 -04:00
John Kleinschmidt
648c9934c0
fix: properly fire serial-port-added and serial-port-removed events ( #34958 )
...
Based on 2309652: [webhid] Notify chooser context observers on shutdown | https://chromium-review.googlesource.com/c/chromium/src/+/2309652
2022-07-25 10:50:19 -04:00
Sudowoodo Release Bot
aeba6ca973
Bump v21.0.0-nightly.20220725
2022-07-25 06:01:47 -07:00
Mike Lee
49302e4a2f
docs: Add missing link to tutorial page ( #35035 )
...
Add missing link to tutorial page
2022-07-25 11:22:06 +02:00
Shelley Vohr
57c265198e
refactor: use Get/SetID from views:View in Button ( #35022 )
2022-07-25 09:46:14 +02:00
Keeley Hammond
08dd38d9be
docs: update build dependencies for Fedora ( #35024 )
2022-07-25 15:25:42 +09:00
Sudowoodo Release Bot
dd82a26e95
Bump v21.0.0-nightly.20220722
2022-07-22 06:01:06 -07:00
Jeremy Rose
3c63f075bd
chore: remove unused WebContents._sendToFrameInternal ( #35010 )
2022-07-21 10:25:54 -07:00
Sudowoodo Release Bot
fec4cca8d4
Bump v21.0.0-nightly.20220721
2022-07-21 06:01:19 -07:00
Shelley Vohr
1ed191114a
fix: clean up callback handling in webContents.print() ( #34894 )
...
* refactor: clean up callback handling in webContents.print()
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-21 12:46:15 +02:00
Milan Burda
d4e97483aa
refactor: only create webContents after 'will-attach-webview' ( #32941 )
2022-07-21 11:29:31 +02:00
dependabot[bot]
7ae3025fd5
build(deps): bump terser from 4.6.7 to 4.8.1 ( #34987 )
...
Bumps [terser](https://github.com/terser/terser ) from 4.6.7 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/commits )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-21 11:15:00 +02:00
Valentin Hăloiu
67eda4bcc8
fix: add support for --ozone-platform-hint flag on Linux ( #34937 )
2022-07-21 10:37:54 +02:00
Sudowoodo Release Bot
9f0e7126c4
Bump v21.0.0-nightly.20220720
2022-07-20 08:02:19 -07:00
Keeley Hammond
be7f90481d
build: update mediastreamdevicescontroller.patch ( #34995 )
2022-07-20 08:00:31 -07:00
Sudowoodo Release Bot
6dc1218c37
Revert "Bump v21.0.0-nightly.20220720"
...
This reverts commit cffcd0d47a .
2022-07-20 07:14:04 -07:00
Sudowoodo Release Bot
cffcd0d47a
Bump v21.0.0-nightly.20220720
2022-07-20 06:01:09 -07:00
electron-roller[bot]
9e0a3c44dd
chore: bump chromium to 105.0.5187.0 (main) ( #34921 )
...
* chore: bump chromium in DEPS to 105.0.5179.0
* chore: update patches
* 3758224: Reland^2 "[flags] Enable freezing of flags"
https://chromium-review.googlesource.com/c/v8/v8/+/3758224
* chore: bump chromium in DEPS to 105.0.5181.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5183.0
* chore: bump chromium in DEPS to 105.0.5185.0
* chore: bump chromium in DEPS to 105.0.5187.0
* chore: update patches
* 3723298: Pass RemoteFrame mojo channels through its creation messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3723298
* 3737382: [Code Heath] Replace base::{ListValue,DictionaryValue} in skia et al
https://chromium-review.googlesource.com/c/chromium/src/+/3737382
* Pass RemoteFrame mojo channels through its creation messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3723298
* Changed PrintRenderFrame.PrintWithParams mojo interface to use callback.
https://chromium-review.googlesource.com/c/chromium/src/+/3761203
* 3738183: [CSP] Add support for `DisableWasmEval`
https://chromium-review.googlesource.com/c/chromium/src/+/3738183
* 3740498: Move LinuxUI from //ui/views/linux_ui to //ui/linux
https://chromium-review.googlesource.com/c/chromium/src/+/3740498
* 3558277: Moves subsystem and semantics to enum class
https://chromium-review.googlesource.com/c/chromium/src/+/3558277
* chore: fix broken steps-electron-gn-check
* 3749583: [arm64] Fix undefined symbol linker error
https://chromium-review.googlesource.com/c/v8/v8/+/3749583
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-07-20 13:03:34 +02:00
Shelley Vohr
1b96a3aa1d
build: consolidate gn templates ( #34918 )
2022-07-20 11:14:54 +02:00
Jeremy Rose
3c7d446fad
refactor: unduplicate MediaStreamDevicesController ( #34895 )
...
* refactor: unduplicate MediaStreamDevicesController
* restore old logic for GUM_* request types
* lint
* gn format
* add test for unsupported getDisplayMedia
* simplify + comment
2022-07-20 17:09:14 +09:00
Alexander Petrov
60b6e74e3f
fix: merge crash annotations instead of overwriting ( #34795 )
...
ElectronCrashReporterClient::GetProcessSimpleAnnotations() merges
annotations provided as argument with global_annotations_,
preserving useful information.
2022-07-19 09:18:04 -07:00
Sudowoodo Release Bot
ba25714e16
Bump v21.0.0-nightly.20220719
2022-07-19 06:01:27 -07:00
Shelley Vohr
05d4966251
fix: delegate to PrintViewManagerBase on failed print ( #34893 )
...
fix: delegate to PrintViewManagerBase on failed print
2022-07-19 14:46:08 +02:00
Shelley Vohr
eb8c9452cb
fix: crash on BrowserWindow.setEnabled() ( #34904 )
...
fix: crash on BrowserWindow.setEnabled()
2022-07-19 12:31:49 +02:00
Shelley Vohr
38848c5bf7
test: optionally validate disabled Node.js specs ( #34899 )
2022-07-19 12:14:21 +02:00
Shelley Vohr
57b02e153d
fix: potential hang on print settings failure ( #34892 )
2022-07-19 11:45:10 +02:00
John Kleinschmidt
8a0df1f487
ci: wait longer for goma to be ready ( #34956 )
2022-07-19 10:20:16 +02:00
Sudowoodo Release Bot
c4cde78818
Bump v21.0.0-nightly.20220718
2022-07-18 06:01:46 -07:00
Samuel Attard
f1746c81c6
fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules ( #34932 )
...
This define is only needed when linking against Chromiums libc++ which we currently
do not ship / expose the symbols of. We probably should make those symbols visible and
actually ensure that electron-rebuild et. al link against our libc++ instead of the system libc++
but for now this fixes compilation issues on macOS where the default system clang links to the system libc++
which does not (obviously) use the Chromium ABI namespace.
For our nan tests which do link against Chromiums libc++ we define the ABI namespace in the spec runner.
2022-07-15 16:57:29 -07:00
Sudowoodo Release Bot
9d23a624c1
Bump v21.0.0-nightly.20220715
2022-07-15 15:12:54 -07:00
Keeley Hammond
574da5a9a1
chore: cherry-pick 5e227bebf193 from v8 ( #34931 )
...
* chore: cherry-pick 5e227bebf193 from v8
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-15 15:12:01 -07:00
Sudowoodo Release Bot
2afb284456
Revert "Bump v21.0.0-nightly.20220715"
...
This reverts commit 4bec26cd0c .
2022-07-15 07:32:25 -07:00
Sudowoodo Release Bot
4bec26cd0c
Bump v21.0.0-nightly.20220715
2022-07-15 06:01:14 -07:00
Sudowoodo Release Bot
0cb39b5bb5
Revert "Bump v21.0.0-nightly.20220714"
...
This reverts commit e9f42b4ad4 .
2022-07-14 08:12:33 -07:00
Sudowoodo Release Bot
e9f42b4ad4
Bump v21.0.0-nightly.20220714
2022-07-14 06:03:36 -07:00
Samuel Attard
9a5d759ea3
fix: ensure that v8 sandbox isnt enabled for arm ( #34914 )
2022-07-14 10:46:41 +02:00
electron-roller[bot]
d32e6cc252
chore: bump chromium to 105.0.5173.0 (main) ( #34770 )
...
* chore: bump chromium in DEPS to 105.0.5147.0
* chore: update chromium/can_create_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3642216
fix minor code shear in patch
* chore: update chromium/port_autofill_colors_to_the_color_pipeline.patch
Xref: chromium/port_autofill_colors_to_the_color_pipeline.patch
fix minor code shear in patch
* chore: remove chromium/posix_replace_doubleforkandexec_with_forkandspawn.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3727368
Removing upstreamed patch
* chore: update patches
* chore: update patches
* chore: add new enum kOffscreenDocument to switch statement
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3722498
* chore: add stub for new parent virtual method OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3717305
* chore: remove download_schedule arg from DownloadTargetCallback invocation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3711096
Clean up DownloadLater flags and prefs
* chore: add stub for new parent virtual method OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3717305
* chore: use base::List for extensions::Event
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3718366
Remove Event constructor overloads that take vector<base::Value>
* refactor: replace ClearStorageDataOptions.origin with .storage_key
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3702946
Refactor ClearData to take StorageKey
* chore: bump chromium in DEPS to 105.0.5149.0
* chore: update patches
* refactor: migrate InspectableWebContents to base::Value::List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3726326
Migrate DevToolsEmbedderMessageDispatcher to base::Value::List.
* refactor: update electron_api_clipboard_mac Clipboard::ReadFindText()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3721398
Mac: Remove unused FindPasteboard C++ interface
* chore: bump chromium in DEPS to 105.0.5151.0
* chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3714995
Move Cart DB proto to //components/commerce
* Revert "chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch"
This reverts commit f8de4605eb3d35152b186646fefd8e88d1df836b.
* chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3714995
Move Cart DB proto to //components/commerce
* chore: update patches
* chore: update ElectronAccessibilityUIMessageHandler to use base::Value::List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3733367
Convert /chrome/browser/accessibility away from WebUI::RegisterDeprecatedMessageCallback
* chore: bump chromium in DEPS to 105.0.5153.0
* chore: bump chromium in DEPS to 105.0.5155.0
* chore: bump chromium in DEPS to 105.0.5157.0
* chore: bump chromium in DEPS to 105.0.5159.0
* chore: update patches
* chore: update CL reference
* Replace ContentMainDelegate::InvokedIn with a variant
https://chromium-review.googlesource.com/c/chromium/src/+/3705957
* Switch devtools_frontend.mojom to mojom.DictValue.
https://chromium-review.googlesource.com/c/chromium/src/+/3726425
* webhid: Bind HID service with service workers
https://chromium-review.googlesource.com/c/chromium/src/+/3680562
* chore: fix lint
* Don't fire load-complete AX notification on macOS for unfocused windows
https://chromium-review.googlesource.com/c/chromium/src/+/3695403
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5165.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5167.0
* chore: bump chromium in DEPS to 105.0.5169.0
* chore: bump chromium in DEPS to 105.0.5171.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5173.0
* chore: update patches
* 3743346: Stop generating unsupported policies on macOS
https://chromium-review.googlesource.com/c/chromium/src/+/3743346
* 3727612: [Bluetooth][Win] Refactor pairing prompt code
https://chromium-review.googlesource.com/c/chromium/src/+/3727612
* 3737325: system-extensions: Move IsEnabled() out of SystemExtensionsProvider.
https://chromium-review.googlesource.com/c/chromium/src/+/3737325
* 3748635: Remove RenderView from the public API.
https://chromium-review.googlesource.com/c/chromium/src/+/3748635
* fixup: 3743346: Stop generating unsupported policies on macOS
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-07-13 17:26:16 -04:00
Gellert Hegyi
440c575aa6
fix: alwaysOnTop browser window option for X11 Linux ( #34766 )
...
fix: alwaysontop browser window option for x11
2022-07-13 11:59:57 -07:00
Sudowoodo Release Bot
46e5c537c8
Bump v21.0.0-nightly.20220713
2022-07-13 06:01:20 -07:00
Shelley Vohr
07d168343a
fix: enable deviceName validation on Linux ( #34872 )
2022-07-13 12:23:24 +02:00
Shelley Vohr
62aeb74d7c
fix: base::DictionaryValue usage in APNS notifs ( #34897 )
2022-07-13 12:22:17 +02:00
Joan Xie
afd08c9450
feat: Enable APNS registration + notification delivery in macOS apps ( #33574 )
2022-07-12 08:38:49 -07:00
Sudowoodo Release Bot
5314ae5342
Bump v21.0.0-nightly.20220712
2022-07-12 06:01:28 -07:00
Samuel Attard
511ff8bc8d
fix: ensure that requestMediaKeySystemAccess resolves ( #34886 )
...
When widevine was disabled at the build level we never dealt with the callback passed into GetSupportedKeySystems. This was ok until requests became marked pending in https://chromium-review.googlesource.com/c/chromium/src/+/3430502 until the callback was called. This resulted in a promise never resolving / rejecting and certain media websites (E.g. spotify) hanging on load waiting for a signal that would never arrive.
2022-07-12 00:48:51 -07:00
Shelley Vohr
95019f0454
fix: update Windows caption buttons to match Win11 style ( #34790 )
2022-07-12 09:13:40 +02:00
Jeremy Rose
4190ec2482
feat: sandbox preloads by default ( #32869 )
2022-07-11 16:28:09 -07:00
Valentin Hăloiu
f63bba8ce2
fix: set Wayland application ID ( #34855 )
...
* refactor: extract XDG app ID logic into a method
* fix: set application ID on Wayland
2022-07-11 11:26:18 -07:00
Sudowoodo Release Bot
8f3fb8db09
Bump v21.0.0-nightly.20220711
2022-07-11 06:01:12 -07:00
David Sanders
2b862c18ba
chore: improve run-clang-tidy.ts behavior when filenames < jobs ( #34736 )
2022-07-11 12:25:39 +02:00
Samuel Attard
fa8e4a7610
build: use third_party DEPOT_TOOLS when running lint scripts ( #34846 )
...
Some folks (especially build_tools users) do not have a version of depot_tools on their path
2022-07-11 12:25:17 +02:00
Shelley Vohr
2eb0e5dcab
fix: safer check for WCO button updates ( #34833 )
2022-07-11 11:45:01 +02:00
Samuel Attard
459404f536
build: run CI tests on Xcode 13.3.0 ( #34850 )
...
* build: test disabling security
* build: install python2 during tests
* build: do not install python2 on arm64 runners
* attempt 2
* build: only allow 13.3.0 xcode
2022-07-11 17:04:32 +09:00
Sudowoodo Release Bot
78848f8bfe
Bump v21.0.0-nightly.20220708
2022-07-08 06:01:44 -07:00
Samuel Attard
eba9d3fc79
fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules ( #34844 )
...
* fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules
* build: rely on config.gypi to enable pointer compression
2022-07-08 01:06:06 -07:00
Shelley Vohr
1941c88442
fix: setRepresentedFilename with non-default titlebarStyle ( #34834 )
...
fix: setRepresentedFilename with non-default titlebarStyle
2022-07-07 23:33:42 -07:00
Keeley Hammond
e83c3ec744
test: add first-party-set chromium tests ( #34827 )
...
test: add first-part-set chromium feature tests
2022-07-07 15:14:53 -04:00
Shelley Vohr
7ec88584b5
fix: WCO pressed background state updates ( #34771 )
2022-07-07 17:17:20 +02:00
Sudowoodo Release Bot
47d8d4cc5c
Bump v21.0.0-nightly.20220707
2022-07-07 06:01:40 -07:00
Sudowoodo Release Bot
f7428baace
Bump v21.0.0-nightly.20220706
2022-07-06 06:02:02 -07:00
Jeremy Rose
403bd39d05
chore: modernize base::Value useage in asar/archive ( #34796 )
2022-07-05 12:35:38 -04:00
David Sanders
c418275228
chore: update Discord invite links ( #34730 )
2022-07-05 11:55:15 -04:00
David Sanders
98cd16d336
chore: fix typos ( #34731 )
2022-07-05 11:49:56 -04:00
Jeremy Rose
e5db178ab6
feat: enable v8 sandboxed pointers ( #34724 )
...
* feat: enable v8 sandboxed pointers
* update breaking-changes.md
* update zero-fill patch
benchmarks showed the function call was slower
2022-07-05 11:28:22 -04:00
Jeremy Rose
0ee7f14190
chore: modernize Value usage in converters ( #34794 )
...
* chore: modernize Value usage in converters
* Date is parsed as an empty object now
2022-07-05 11:25:18 -04:00
Sudowoodo Release Bot
d28ed0da20
Bump v21.0.0-nightly.20220705
2022-07-05 06:01:17 -07:00
Sudowoodo Release Bot
1edf9d2ada
Bump v21.0.0-nightly.20220704
2022-07-04 06:02:50 -07:00
Sudowoodo Release Bot
d359736e65
Bump v21.0.0-nightly.20220701
2022-07-01 06:00:58 -07:00
Darshan Sen
c885f9063b
docs: document the removal of IA32 Linux support ( #34787 )
...
* docs: document the removal of IA32 Linux support
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
https://github.com/electron/electron/pull/33731 , had introduced the commit,
389ef0731e ,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.
Closes: https://github.com/electron/electron/issues/34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2022-06-30 09:23:03 -07:00
Sudowoodo Release Bot
c3920c5c02
Bump v21.0.0-nightly.20220630
2022-06-30 06:02:00 -07:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Jeremy Rose
0d4e417594
chore: modernize ListValue usage in permission manager ( #34662 )
2022-06-29 10:09:48 -07:00
Jeremy Rose
4ddd03b1b3
chore: modernize some devtools code using deprecated ListValue ( #34655 )
2022-06-29 09:39:48 -07:00
Shelley Vohr
7c12baccab
build: remove appveyor hook to defunct service ( #34789 )
2022-06-29 17:19:05 +02:00
Sudowoodo Release Bot
461561c19c
Bump v21.0.0-nightly.20220629
2022-06-29 06:01:40 -07:00
Josh Soref
1f814eacb2
build: fix release_dependency_versions workflow ( #34573 )
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2022-06-29 14:55:59 +02:00
Shelley Vohr
ad2b1fee59
fix: re-enable HKDF crypto functionality ( #34767 )
...
* fix: re-enable HKDF crypto functionality
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-06-29 14:53:57 +02:00
Shelley Vohr
35ff95d3c7
fix: <datalist> bounds vertical cutoff ( #34759 )
2022-06-29 10:14:03 +02:00
Sudowoodo Release Bot
6257e0c348
Bump v21.0.0-nightly.20220628
2022-06-28 20:28:29 -07:00
Keeley Hammond
3310e4039f
build: update makeRequest parameters ( #34782 )
2022-06-28 20:26:00 -07:00
Jeremy Rose
40fbc05bb2
chore: modernize base::Value usage in accessibility_ui ( #34666 )
2022-06-28 16:40:56 -07:00
Keeley Hammond
3458eac276
chore: update printing patch for main gclient sync ( #34777 )
...
chore: update printing patch
2022-06-28 16:40:23 -07:00
Samuel Attard
44b9ee51f4
fix: resolve symlinks when computing relative asar paths for integrity ( #34776 )
2022-06-28 16:02:00 -07:00
Jeremy Rose
07294cbf15
chore: modernize ListValue usage in gpu info ( #34663 )
2022-06-28 09:52:59 -07:00
Sudowoodo Release Bot
a4043237da
Revert "Bump v21.0.0-nightly.20220628"
...
This reverts commit f1087cc830 .
2022-06-28 07:40:00 -07:00
Micha Hanselmann
704b2199b3
build: fix building with enable_basic_printing false ( #34711 )
...
* build: fix building with enable_basic_printing false
* temp flags for ci builds
* fix other systems
* disable cups
* disable print preview
* revert changes
* merge with printing.patch
2022-06-28 16:34:00 +02:00
Sudowoodo Release Bot
f1087cc830
Bump v21.0.0-nightly.20220628
2022-06-28 07:07:08 -07:00
Sudowoodo Release Bot
d028044a24
Revert "Bump v21.0.0-nightly.20220628"
...
This reverts commit 9c311a2059 .
2022-06-28 07:05:52 -07:00
Sudowoodo Release Bot
9c311a2059
Bump v21.0.0-nightly.20220628
2022-06-28 06:01:35 -07:00
dependabot[bot]
47afaddaf5
build(deps-dev): bump got from 6.7.1 to 11.8.5 ( #34697 )
...
Bumps [got](https://github.com/sindresorhus/got ) from 6.7.1 to 11.8.5.
- [Release notes](https://github.com/sindresorhus/got/releases )
- [Commits](https://github.com/sindresorhus/got/compare/v6.7.1...v11.8.5 )
---
updated-dependencies:
- dependency-name: got
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-28 11:18:47 +02:00
David Sanders
59d3c12cae
chore: remove spurious trailing namespace comments ( #34732 )
2022-06-28 10:08:55 +02:00
electron-roller[bot]
e86d1cba75
chore: bump chromium to 105.0.5129.0 (main) ( #34403 )
...
* chore: bump chromium in DEPS to 104.0.5096.0
* 3651284: Use the entry settings object for window.open navigation
https://chromium-review.googlesource.com/c/chromium/src/+/3651284
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* 3642842: Window Placement: Prototype Fullscreen Capability Delegation - Part 2
https://chromium-review.googlesource.com/c/chromium/src/+/3642842
* 3652785: [sandbox] Enable sandboxed pointers on sanitizer builds
https://chromium-review.googlesource.com/c/v8/v8/+/3652785
* 3611967: webhid: Migrate HidDelegate to use BrowserContext and Origin
https://chromium-review.googlesource.com/c/chromium/src/+/3611967
* 3665762: Remove RenderFrameHost::IsRenderFrameCreated from //content/.
https://chromium-review.googlesource.com/c/chromium/src/+/3665762
* 3659375: Fold x509_util_ios and most of x509_util_mac into x509_util_apple
https://chromium-review.googlesource.com/c/chromium/src/+/3659375
* 3656234: [CodeHealth] Remove uses of base::ListValue::Append() (Final, take 2)
https://chromium-review.googlesource.com/c/chromium/src/+/3656234
* chore: update patch indices
* chore: fix lint
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* webhid: Migrate HidDelegate to use BrowserContext and Origin
This is a temporary fix for https://chromium-review.googlesource.com/c/chromium/src/+/3611967 to get the build compiling, but we need to either patch around https://chromium-review.googlesource.com/c/chromium/src/+/3611967 or move our device permissioning to BrowserContext
* chore: fix lint
* build: run electron/script/gen-libc++-filenames.js
fixes gn check
* chore: bump chromium in DEPS to 104.0.5098.0
* chore: disable flaking tests
* 3682394: Change pipes surrounding code references in comments to backticks
https://chromium-review.googlesource.com/c/chromium/src/+/3682394
* 3652749: Delete GLRenderer and related classes
https://chromium-review.googlesource.com/c/chromium/src/+/3652749
* chore: fixup patch indices
* 3671199: Remove ContentMainDelegate::PostFieldTrialInitialization
https://chromium-review.googlesource.com/c/chromium/src/+/3671199
* 3607963: hid: Do not exclude HID device with no collections
https://chromium-review.googlesource.com/c/chromium/src/+/3607963
* refactor: use ElectronBrowserContext instead of WebContents to persist devices
due to changes like https://chromium-review.googlesource.com/c/chromium/src/+/3611967 ,
we can no longer use WebContents to store device permissions so this commit
moves device permission storage to live in memory in ElectronBrowserContext
instead.
* 3557253: Deprecate some signature checks
https://chromium-review.googlesource.com/c/v8/v8/+/3557253
* chore: bump chromium in DEPS to 104.0.5100.0
* 3680781: Add policy for Renderer App Container.
https://chromium-review.googlesource.com/c/chromium/src/+/3680781
* chore: update patch indices
* 3675465: Update NetLog network service API to use mojom::DictionaryValue.
https://chromium-review.googlesource.com/c/chromium/src/+/3675465
* chore: bump chromium in DEPS to 104.0.5102.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5103.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5104.0
* chore: update patches
* fix: add patch for DCHECK in fullscreen test
* build: fix nan build
* build: make the nan spec runner work on macOS
* chore: bump chromium in DEPS to 104.0.5106.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5108.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5110.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5112.0
* chore: bump chromium in DEPS to 105.0.5113.0
* chore: bump chromium in DEPS to 105.0.5115.0
* chore: bump chromium in DEPS to 105.0.5117.0
* chore: update patches
* chore: update libcpp patch
* 3693745: Delete base::LowerCaseEqualsASCII()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3693745
* 3669226: Remove printing PostTask usage of IO thread
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3669226
* 3687395: Remove DictionaryValue::HasKey().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3687395
* 3691014: Prevent unsafe narrowing: ui/accessibility, part 2
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3691014
* 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560567
* 3684873: [Bluetooth][Win/Linux] Add bluetooth pair confirmation prompt
https://chromium-review.googlesource.com/c/chromium/src/+/3684873
* chore: bump chromium in DEPS to 105.0.5119.0
* chore: missing includes in desktop_notification_controller
* chore: update patches
* 3685951: Reland "Make sure screen object is created once in tests."
https://chromium-review.googlesource.com/c/chromium/src/+/3685951
* fixup: Reland "Make sure screen object is created once in tests."
* 3646014: [API] Deprecate LegacyOOMErrorCallback
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3646014
* chore: bump chromium in DEPS to 105.0.5121.0
* chore: update patches
* 3699085: [cleanup] update PrintBackend::EnumeratePrinters to use reference
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3699085
* chore: bump chromium in DEPS to 105.0.5123.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5125.0
* chore: update patches
* 3630082: [sandbox] Also enable the sandbox outside of Chromium builds
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3630082
* chore: bump chromium in DEPS to 105.0.5127.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5129.0
* chore: update patches
* 3703741: Remove WebContents::GetMainFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/3703741
* chore: update patches
* fixup! 3703741: Remove WebContents::GetMainFrame.
* fix lint
* more lint
* chore: document breaking change
* 3687671: [v8] Freeze flags after initialization
https://chromium-review.googlesource.com/c/chromium/src/+/3687671
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* use the v8 allocator for node serdes
* chore: update patches
* remove faulty non-v8-sandbox-compatible code
* make NodeArrayBufferAllocator use the v8 allocator under the hood
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* fix build on windows
* 3691954: [Reland][Extensions Bindings] Validate arguments sent to API events
https://chromium-review.googlesource.com/c/chromium/src/+/3691954
* chore: remove deprecated AccessorSignatures
https://github.com/nodejs/nan/pull/941
* Update patches/chromium/notification_provenance.patch
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* remove chore_expose_v8_initialization_isolate_callbacks.patch
* add link to nodejs/nan#941
* 52026: Do not allow md4 or md5 based signatures in X.509 certificates.
https://boringssl-review.googlesource.com/c/boringssl/+/52026
* chore: update patches
* disable nan buffer-test
* disable sandboxed pointers for now
* force sandboxed pointers off
* improve node allocation patch
* restore accidentally dropped node crypto test patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com >
2022-06-27 15:50:08 -05:00
Sudowoodo Release Bot
032e1d9bef
Bump v21.0.0-nightly.20220627
2022-06-27 06:02:43 -07:00
David Sanders
39840502be
docs: replace broken Windows taskbar images ( #34729 )
2022-06-27 14:14:01 +02:00
David Sanders
8238cca87b
test: use maximize event instead of resize event ( #34740 )
2022-06-27 10:29:55 +02:00
David Sanders
e2c58d164d
chore: replace Object.assign with object spread syntax ( #34739 )
2022-06-27 10:29:18 +02:00
Milan Burda
ba4893c248
refactor: load webFrame via process._linkedBinding in security-warnings.ts ( #34735 )
2022-06-27 10:28:35 +02:00
Sudowoodo Release Bot
c5b87e4919
Bump v21.0.0-nightly.20220624
2022-06-24 06:01:02 -07:00
Shelley Vohr
3b881e4a13
fix: WCO respects maximizable/closable/minimizable ( #34677 )
2022-06-23 13:08:32 -04:00
Sudowoodo Release Bot
106aa0e922
Bump v21.0.0-nightly.20220623
2022-06-23 06:00:50 -07:00
Jeremy Rose
11924bdbb2
chore: modernize ListValue usage in dict_util.mm and related files ( #34661 )
...
* chore: modernize ListValue usage in dict_util.mm and related files
* use base::Value::{Dict,List} instead of raw base::Value
* fix compile
* fix build
* fix build again
2022-06-23 15:28:41 +09:00
Jeremy Rose
cd19a741b1
chore: modernize base::Value usage in shell/renderer/printing ( #34682 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-06-22 10:37:58 -07:00
Jeremy Rose
5895296239
test: disable flaky transparent window test ( #34660 )
2022-06-22 10:37:32 -07:00
Sudowoodo Release Bot
e3243ad113
Bump v21.0.0-nightly.20220622
2022-06-22 06:00:53 -07:00
David Sanders
5fee5b0e22
chore: chunk filenames when linting C++ files ( #34237 )
...
* chore: chunk filenames when linting C++ files
* chore: refactor code for better readability
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: further tweak
* chore: limit all platforms to 4095 characters on command line
* chore: use python3
* Revert "chore: use python3"
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-06-22 19:23:11 +09:00
Milan Burda
f172136752
chore: remove undocumented page-title-set webview event ( #34533 )
2022-06-22 17:18:42 +09:00
Juan Cruz Viotti
218797eb61
fix: allow macOS debug builds to be built ( #34536 )
...
Extending the `testing` GN profile with the arguments documented to
allow breakpoint debugging
(https://www.electronjs.org/docs/latest/development/debugging#breakpoint-debugging )
doesn't quite work on macOS:
```sh
is_debug = true
symbol_level = 2
forbid_non_component_debug_builds = false
```
The build eventually fails on both Intel and Apple Silicon with the
following (summarized) error:
```sh
[S:41062 R:1 (41062:41247) (C/s:0.1 O/s:13.6)] SOLINK 'obj/electron/electron_framework_shared_library/Electron Framework' 'obj/electron/electron_framework_shared_library/Electron Framework.TOC'
FAILED: obj/electron/electron_framework_shared_library/Electron Framework obj/electron/electron_framework_shared_library/Electron Framework.TOC
...
Undefined symbols for architecture x86_64:
"platform_util::GetViewForWindow(gfx::NativeWindow)", referenced from:
BoundsOverlapWithAnyOpenPrompt(gfx::Rect const&, content::WebContents*) in libchrome.a(autofill_popup_view_utils.o)
"platform_util::GetParent(gfx::NativeView)", referenced from:
BoundsOverlapWithAnyOpenPrompt(gfx::Rect const&, content::WebContents*) in libchrome.a(autofill_popup_view_utils.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
...
```
This symbol is defined on a file that is not declared as a dependency of
`libchrome` on the GN definitions. Why the problem is not reproducible
on plain testing or release builds remains a mystery to me. I'm guessing
some non-debug path somewhere in the GN definitions does eventually
require that file.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2022-06-22 17:18:12 +09:00
Erick Zhao
e410109a3d
docs: expand tutorial ( #34604 )
...
* docs: base tutorial update
* more docs
* zzz
* remove unused images
2022-06-22 17:17:48 +09:00
Milan Burda
a5869fe997
refactor: use std::size(args) instead of hardcoded values ( #34651 )
2022-06-22 10:15:27 +02:00
Jeremy Rose
bf52318c76
fix: modernize ListValue in net converters ( #34657 )
2022-06-22 10:14:57 +02:00
Jeremy Rose
73c85410c5
chore: modernize ListValue code in session ( #34656 )
...
* chore: modernize ListValue code in session
* also in browser_context
2022-06-22 10:14:35 +02:00
Jeremy Rose
ad7aab8338
chore: modernize base::Value usage in WebRequest ( #34667 )
2022-06-22 10:11:27 +02:00
Sudowoodo Release Bot
140c8d0d0a
Bump v21.0.0-nightly.20220621
2022-06-21 09:07:50 -07:00
Keeley Hammond
34fc53e5e6
chore: Revert "build: build & release libcxx objects on darwin ( #34586 )" ( #34680 )
...
Revert "build: build & release libcxx objects on darwin (#34586 )"
This reverts commit 2bbbc66eb8 .
2022-06-21 09:06:50 -07:00
Sudowoodo Release Bot
528cbe8131
Revert "Bump v21.0.0-nightly.20220621"
...
This reverts commit 116c32a030 .
2022-06-21 08:27:51 -07:00
Sudowoodo Release Bot
116c32a030
Bump v21.0.0-nightly.20220621
2022-06-21 06:00:53 -07:00
Shelley Vohr
530a022b05
fix: window button visibility fullscreen interaction ( #34530 )
2022-06-21 16:35:53 +09:00
Milan Burda
f3f327823e
chore: move main process only accessible API bindings away from common ( #34634 )
2022-06-21 16:34:56 +09:00
Milan Burda
0f528c1e43
chore: let result: ReturnType<typeof this._callWindowOpenHandler>; ( #34628 )
2022-06-21 10:39:41 +09:00
Keeley Hammond
2bbbc66eb8
build: build & release libcxx objects on darwin ( #34586 )
...
* build: build & release libcxx objects on darwin
* Fix merge error
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-06-21 10:35:16 +09:00
Shelley Vohr
3cd5223134
build: mark existing Node.js flakes as dontcare ( #34644 )
2022-06-20 15:54:52 -04:00
Shelley Vohr
8e45f43f18
refactor: remove deprecated drag-and-drop code ( #34615 )
2022-06-20 15:17:53 +02:00
Sudowoodo Release Bot
d341610d64
Bump v21.0.0-nightly.20220620
2022-06-20 06:01:30 -07:00
Shelley Vohr
6e9466f96b
fix: overzealous media key listening on Windows ( #34594 )
2022-06-20 19:40:10 +09:00
Shelley Vohr
e2f42e5d99
chore: fix BrowserView painting when origin updated ( #34581 )
...
chore: fix View painting when origin updated
2022-06-20 13:31:53 +09:00
Darshan Sen
ec98e95b8a
fix: performance problem in crashReporter.start() on macOS ( #34609 )
...
fix: performance problem in crashReporter.start() on macOS
This change reduces the duration of crashReporter.start() on Intel macOS
from 622 milliseconds to 257 milliseconds!
Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
posix: Replace DoubleForkAndExec() with ForkAndSpawn()
The DoubleForkAndExec() function was taking over 622 milliseconds to run
on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
some custom traces and found that the fork() syscall is the bottleneck
here, i.e., the first fork() takes around 359 milliseconds and the
nested fork() takes around 263 milliseconds. Replacing the nested fork()
and exec() with posix_spawn() reduces the time consumption to 257
milliseconds!
See https://github.com/libuv/libuv/pull/3064 to know why fork() is so
slow on macOS and why posix_spawn() is a better replacement.
Another point to note is that even base::LaunchProcess() from Chromium
calls posix_spawnp() on macOS -
8f8d82dea0 :base/process/launch_mac.cc;l=295-296
Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
Reviewed-by: Mark Mentovai <mark@chromium.org >
Commit-Queue: Mark Mentovai <mark@chromium.org >
Fixes: https://github.com/electron/electron/issues/34321
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-06-20 13:31:29 +09:00
dependabot[bot]
bf4efb693b
build(deps): bump jpeg-js from 0.4.3 to 0.4.4 in /spec-main ( #34607 )
...
Bumps [jpeg-js](https://github.com/eugeneware/jpeg-js ) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/eugeneware/jpeg-js/releases )
- [Commits](https://github.com/eugeneware/jpeg-js/compare/v0.4.3...v0.4.4 )
---
updated-dependencies:
- dependency-name: jpeg-js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-20 09:57:25 +09:00
Raymond Zhao
999a225edb
refactor: use stubs for gdk-pixbuf dependency ( #34077 )
...
* refactor: use stubs for gdk-pixbuf dependency
* Adjust build file
* Add includes
* Merge gdk_pixbuf stubs into gtk stubs
* Split pixbuf sigs into own file again
* Add initialization check
* Apply PR feedback
2022-06-19 17:42:30 -07:00
Milan Burda
b3ec0a801a
chore: cleanup undocumented keys from webFrame.getWebPreference() ( #34588 )
2022-06-19 17:40:03 -07:00
Sudowoodo Release Bot
6f8bfdeb7a
Bump v21.0.0-nightly.20220617
2022-06-17 06:02:13 -07:00
Shelley Vohr
20538c4f34
fix: draggable regions updating on bounds change ( #34582 )
2022-06-17 12:01:38 +02:00
Sudowoodo Release Bot
d2e539c7d4
Bump v21.0.0-nightly.20220616
2022-06-16 06:00:48 -07:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2022-06-16 16:46:11 +09:00
Milan Burda
f418a49857
chore: warn when using the deprecated new-window event ( #34528 )
2022-06-15 18:17:42 -07:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Sudowoodo Release Bot
4ec95edf06
Bump v21.0.0-nightly.20220615
2022-06-15 06:01:24 -07:00
Michaela Laurencin
4c7c0b41c2
feat: add immersive dark mode on windows ( #33624 )
...
* feat: add immersive dark mode
* fix syntax and add header
* add me
* Update fuses.json5
* fix: redraw title bar on dark mode change
* chore: SetWindowTheme doesn't seem to be needed
* chore: separate out Win 10 dark mode implementation
* final touches
* final touches
* chore: limit Win 10 to >= 20H1 and drop fuse
* fix types
* fix lint
Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2022-06-14 12:27:28 -04:00
isailaandrei
21ef8501e7
feat: add panel support for BrowserWindow ( #34388 )
...
* feat: add NSPanel support for BrowserWindow
* change header guard to satisfy linter
* change panel wording in browser-window
* Revert "change panel wording in browser-window"
This reverts commit 6f3f80f94a .
* change wording in browser-window
* Update shell/browser/ui/cocoa/electron_native_widget_mac.mm
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Update shell/browser/ui/cocoa/electron_native_widget_mac.h
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Changed ScopedDisableResize class to allow for nesting
Co-authored-by: andreiisaila <andreiisaila@microsoft.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2022-06-14 12:24:52 -04:00
Shelley Vohr
bed38e0985
fix: crash when setWindowOpenHandler callback throws ( #34523 )
...
* fix: crash when setWindowOpenHandler throws
* refactor: throw as process uncaughtException event
2022-06-14 12:22:23 -04:00
Milan Burda
8de5cdb426
test: add missing page-title-updated event spec for webview ( #34529 )
2022-06-14 12:15:45 -04:00
Sudowoodo Release Bot
9707812d68
Bump v21.0.0-nightly.20220614
2022-06-14 06:02:37 -07:00
Milan Burda
16cd22ff6a
test: use webContents.setWindowOpenHandler() in specs ( #34514 )
...
* test: use webContents.setWindowOpenHandler() in specs
* test: use browser-window-created instead of new-window for visibility spec
2022-06-13 13:07:47 -04:00
Jeremy Rose
954fd72500
fix: make navigator.userAgentData non-empty ( #34481 )
2022-06-13 09:35:42 -07:00
Sudowoodo Release Bot
8157a01a42
Bump v21.0.0-nightly.20220613
2022-06-13 08:39:00 -07:00
Sudowoodo Release Bot
d565243f98
Revert "Bump v21.0.0-nightly.20220613"
...
This reverts commit 77dcf4a5e0 .
2022-06-13 08:37:46 -07:00
Sudowoodo Release Bot
77dcf4a5e0
Bump v21.0.0-nightly.20220613
2022-06-13 06:01:32 -07:00
Milan Burda
2a9b3cc9cd
chore: remove unused proxy-window-open.snapshot.txt ( #34501 )
...
chore: remove unused spec-main/fixtures/snapshots/proxy-window-open.snapshot.txt
2022-06-13 16:01:34 +09:00
Milan Burda
7ca3f55b10
refactor: move duplicate code to RendererClientBase::ShouldLoadPreload helper ( #34477 )
2022-06-13 15:58:27 +09:00
Shelley Vohr
e5543a2dd2
fix: all files selection logic on linux ( #34496 )
2022-06-13 15:57:03 +09:00
John Kleinschmidt
bd81ae08ac
fix: don't require glibc 2.29+ on linux arm64 builds ( #34491 )
...
* build: use sid sysroot for linux arm64
2022-06-10 14:15:52 -04:00
Sudowoodo Release Bot
57b863c213
Bump v21.0.0-nightly.20220610
2022-06-10 06:02:06 -07:00
Michaela Laurencin
52c0a4fafc
docs: add macOS height option info ( #34451 )
2022-06-09 15:17:27 -04:00
Sudowoodo Release Bot
1302ebf50e
Bump v21.0.0-nightly.20220609
2022-06-09 06:01:17 -07:00
Shelley Vohr
37d93b0482
fix: update normal bounds prior to minimizing ( #34473 )
2022-06-09 10:48:50 +02:00
Shelley Vohr
2fd0194e94
build: update clang-format script ( #34286 )
2022-06-08 21:26:41 +02:00
Sudowoodo Release Bot
6d50717eed
Bump v21.0.0-nightly.20220608
2022-06-08 06:00:42 -07:00
David Sanders
289128b96c
chore: use --root instead of --project_root for cpplint ( #34456 )
...
--root has been improved upstream in depot_tools to better handle Windows:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3648533
2022-06-08 10:29:39 +02:00
Shelley Vohr
16db5a112e
fix: html fullscreen transitions stacking ( #32905 )
...
* fix: html fullscreen transitions stacking
* spec: move webview test to spec-main
2022-06-07 12:59:50 -04:00