David Sanders
efb3fd98c6
build: lint commits on Chromium roller branches ( #49655 )
...
* build: lint commits on Chromium roller branches
Assisted-By: Claude Opus 4.5
* chore: add ability to skip linting CLs by adding #nolint
* chore: only exit with non-zero exit code in CI
2026-02-18 20:45:44 -08:00
Shelley Vohr
9ca9311b73
docs: note required windows in 'new-window-for-tab' event ( #49851 )
...
docs: note required windows in new-window-for-tab
2026-02-18 19:30:43 -08:00
Samuel Attard
8b05717661
docs: clarify ASAR integrity is supported in MAS builds ( #49852 )
...
* docs: clarify ASAR integrity is supported in MAS builds
Add a note to the ASAR integrity documentation explicitly stating
that this feature is fully supported and recommended in Mac App
Store builds. While MAS-installed apps have system-level protections,
ASAR integrity provides an additional security layer and is important
for MAS builds distributed outside the Mac App Store.
Slack thread: https://electronhq.slack.com/archives/CB6CG54DB/p1771449093872419?thread_ts=1771446183.473289&cid=CB6CG54DB
https://claude.ai/code/session_01A97nfiqHUVxLNaQyHVXS7j
* docs: clarify ASAR integrity support for MAS builds
Updates the ASAR integrity documentation to explicitly mention that
it is supported and recommended in Mac App Store builds. Clarifies
that while MAS-installed apps have system-level protections (Resources
folder owned by root), ASAR integrity is especially important when
distributing MAS builds through other channels like direct download,
since those installations won't have the read-only protections.
https://claude.ai/code/session_012mBNZQW34h91NRcdFaLxNh
---------
Co-authored-by: Claude <noreply@anthropic.com >
2026-02-18 14:14:00 -08:00
John Kleinschmidt
be45b5f8e7
ci: fixup build stats upload on Windows ( #49845 )
2026-02-18 15:00:30 -05:00
dependabot[bot]
87597a99de
build(deps-dev): bump webpack from 5.95.0 to 5.104.1 in the npm_and_yarn group across 1 directory ( #49779 )
...
build(deps-dev): bump webpack
Bumps the npm_and_yarn group with 1 update in the / directory: [webpack](https://github.com/webpack/webpack ).
Updates `webpack` from 5.95.0 to 5.104.1
- [Release notes](https://github.com/webpack/webpack/releases )
- [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack/compare/v5.95.0...v5.104.1 )
---
updated-dependencies:
- dependency-name: webpack
dependency-version: 5.104.1
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-18 14:22:25 -05:00
Shelley Vohr
3ed52a3ded
build: roll sysroots ( #49844 )
2026-02-18 13:24:29 -05:00
Shelley Vohr
dfdf04976e
fix: draggable region position with docked DevTools ( #49822 )
2026-02-18 11:49:18 -05:00
Shelley Vohr
f4ba25a3da
fix: frameless window resize in MAS builds ( #49780 )
2026-02-18 10:35:10 -05:00
Robo
05061544ab
feat: enable WASM trap handlers in all Node.js processes ( #48983 )
...
fix: enable WASM trap handlers in all Node.js processes
```
Original reason for revert:
Some apps started throwing exception on startup
https://github.com/electron/electron/issues/48956
```
We now move the trap handler registeration before
any user script execution. Add a fuse to support
disabling the feature is application needs to run
in memory constrained environments.
2026-02-18 12:08:03 +09:00
Sam Maddock
10566c2d5f
test: MAS for private API usage ( #49712 )
2026-02-17 15:29:21 -05:00
Mitchell Cohen
931c257de7
fix: accurate window sizing and support for content sizing on Linux/Wayland with CSD ( #49209 )
...
* fix window sizing and content sizing on Linux when CSD is in use
* fixed size constraints
* simplify min/max size calculation
* use base window size for min/max
* moved windows min/max size overrides
* remove unnecessary checks for client frame
* cleanup
2026-02-17 15:23:54 -05:00
Ronald Eddy Jr
459a88f788
docs: fix typos across tutorial documentation ( #49736 )
2026-02-17 14:47:45 -05:00
electron-roller[bot]
c98cf69f40
chore: bump chromium to 147.0.7687.0 (main) ( #49782 )
...
* chore: bump chromium in DEPS to 147.0.7683.0
* fix(patch): constant moved to header
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7536483
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* fix(patch): occlusion simplification upstream
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7563790
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: remove upstreamed patches
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: update patches (trivial only)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: bump chromium in DEPS to 147.0.7685.0
* fix(patch): V1 Keychain removal
Upstream deleted the V1 Keychain API. Removed V1 hunks and adapted
keychain_password_mac.mm to use KeychainV2 APIs.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7540447
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: update patches (trivial only)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* 7535923: Rename ozone buildflags
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7535923
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* 7528398: [LNA] Rename PNA-named files to LNA-named files
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7528398
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* 7534194: Convert some functions in ui::Clipboard to async
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7534194
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* 7544580: [DevTools] Add command to restart Chrome to DevTools UI bindings
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7544580
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: bump chromium in DEPS to 147.0.7687.0
* chore: update patches (trivial only)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
* chore: incorporate learnings into claude skill
I asked Claude to reflect on our upgrade session, consider what it learned and should know in the future, and to update its skill documents.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-17 14:25:21 -05:00
John Kleinschmidt
0da0c3a47e
build: use spawn instead of spawnSync for build ( #49774 )
2026-02-17 13:24:19 -05:00
John Kleinschmidt
f19cfce430
chore: add Copilot CLI instructions ( #49784 )
...
chore: add copilot-instructions
2026-02-17 09:49:59 -05:00
dependabot[bot]
ca61f2d7df
build(deps): bump actions-cool/issues-helper from 3.7.5 to 3.7.6 ( #49813 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.7.5 to 3.7.6.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](e2ff99831a...71b62d7da7 )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.7.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-17 11:24:20 +01:00
dependabot[bot]
1322bee878
build(deps): bump github/codeql-action from 4.32.2 to 4.32.3 ( #49814 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.32.2 to 4.32.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](45cbd0c69e...9e907b5e64 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-17 11:24:06 +01:00
Samuel Attard
dda71a464c
chore: add PR Notes section requirement to CLAUDE.md ( #49816 )
...
docs: add PR Notes section requirement to CLAUDE.md
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-17 01:02:52 -08:00
Shelley Vohr
a056c63fd8
fix: excise abort_report_np usage in MAS ( #49726 )
...
* fix: excise abort_report_np usage in MAS
* chore: fix it harder
2026-02-16 12:23:53 +01:00
reito
bf3eb098bd
fix: missing shared texture docs ( #49797 )
2026-02-16 10:51:31 +01:00
Shelley Vohr
67cced1270
build: remove *.star files ( #49796 )
2026-02-16 10:49:39 +01:00
Shelley Vohr
eb29568e45
feat: introduce os_crypt_async in safeStorage ( #49054 )
...
* feat: support Freedesktop Secret Service OSCrypt client
Refs https://issues.chromium.org/issues/40086962
Refs https://issues.chromium.org/issues/447372315
* chore: rework to async interface
* refactor: allow customizing freedesktop config
* docs: add more async impl info
* refactor: reject when temporarily unavailable
* chore: feedback from review
* chore: push_back => emplace_back
2026-02-15 19:54:50 +01:00
Shelley Vohr
dcdbb0397e
feat: allow defaulting to printer default page size ( #49523 )
...
Co-authored-by: Edvan de Matos <edvan.santos@querodelivery.com >
2026-02-13 07:40:14 -05:00
electron-roller[bot]
3a5f9e0a33
chore: bump node to v24.13.1 (main) ( #49744 )
...
* chore: bump node in DEPS to v24.13.1
* chore: fixup patches
refs:
* https://github.com/nodejs/node/pull/60425
* https://github.com/nodejs/node/pull/61270
* https://github.com/nodejs/node/pull/61044
* fix: generate_config_gypi needs to generate valid JSON
https://github.com/nodejs/node/pull/60794
* doc: align Buffer.concat documentation with behavior
https://github.com/nodejs/node/pull/60405
* src: fix off-thread cert loading in bundled cert mode
https://github.com/nodejs/node/pull/60764
* build: fix extraneous includes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-13 09:48:05 +01:00
Keeley Hammond
f90e35cb45
chore: cherry-pick e045399a1ecb from chromium ( #49788 )
...
* chore: cherry-pick e045399a1ecb from chromium
* chore: update patch
2026-02-12 19:24:19 -08:00
Shelley Vohr
74fd10450f
feat: improve Windows Toast actions support ( #48132 )
...
* feat: improve Windows Toast actions support
* fix: ensure MSIX compatibility
* test: add bad clsid format test
2026-02-12 17:25:20 -05:00
electron-roller[bot]
a65cfed500
chore: bump chromium to 146.0.7666.0 (main) ( #49528 )
...
* chore: bump chromium in DEPS to 146.0.7652.0
* fix(patch-conflict): update mas_avoid_private_macos_api_usage context for constrainFrameRect method
The upstream CL added a new constrainFrameRect:toScreen: method override to
NativeWidgetMacNSWindow as part of headless mode window zoom implementation.
The MAS patch's #endif for frameViewClassForStyleMask now correctly appears
after that method, since constrainFrameRect is a public API override that
doesn't need to be guarded.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7487666
* fix(patch-conflict): update printing.patch for base::DictValue rename
Updated printing.patch to use the new base::DictValue type name instead of
base::Value::Dict following Chromium's type renaming change. This affects
CompleteUpdatePrintSettings() signature and related code.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820
* fix(patch-conflict): update accessibility_ui patch for base::DictValue/ListValue rename
Updated adjust_accessibility_ui_for_electron.patch to use the new
base::DictValue and base::ListValue type names instead of base::Value::Dict
and base::Value::List following Chromium's type renaming change.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820
* chore: update patches
* 6625736: Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency | https://chromium-review.googlesource.com/c/chromium/src/+/6625736
* chore: bump chromium in DEPS to 146.0.7653.0
* chore: update patches
* 7000847: add type tag to v8::External for gin_helper function templates
The upstream gin function templates now use v8::ExternalPointerTypeTag
for type safety when using v8::External. Updated Electron's forked
gin_helper function template to use the same kGinInternalCallbackHolderBaseTag
that Chromium's gin uses.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847
* fix(patch-update): extend V8 Object API deprecation patch for Node.js
Extended the existing patch to cover additional files that use
GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField:
- src/stream_base-inl.h
- src/udp_wrap.cc
- src/js_udp_wrap.cc
- src/node_process_methods.cc
- src/node_snapshotable.cc
- src/base_object.cc
These APIs now require an EmbedderDataTypeTag parameter.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* 7000847: add type tag to v8::External calls in shared_texture
Updated v8::External::New and v8::External::Value calls to use the
kExternalPointerTypeTagDefault tag as required by the V8 API change
that deprecates the tagless versions.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847
* 7508687: use ChildProcessId for file permission APIs
The ChildProcessSecurityPolicy::CanReadFile and GrantReadFile APIs
now require ChildProcessId instead of int. Updated to use GetID()
instead of GetDeprecatedID() for these specific calls.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7508687
* 7000847: add type tag to v8::External calls in callback and osr_converter
The v8::External API now requires an EmbedderPointerTypeTag parameter
for both New() and Value() methods to improve V8 sandbox type safety.
Updated calls in:
- callback.cc: TranslatorHolder constructor and CallTranslator
- osr_converter.cc: OffscreenSharedTextureValue converter
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7000847
* fixup! 7087956: [api] Promote deprecation of v8::Context and v8::Object API methods
Extended the Node.js patch to cover histogram.cc which also uses
SetAlignedPointerInInternalField and GetAlignedPointerFromInternalField
APIs that now require the EmbedderDataTypeTag parameter.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* chore: bump chromium in DEPS to 146.0.7655.0
* chore: update patches
* 7509043: update WebSpellingMarker type for API change
The upstream Chromium API changed - WebSpellingMarker was moved from a
nested type within WebTextCheckClient to a standalone type in the blink
namespace.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509043
* 7498491: update process_id to use OriginatingProcess type
The upstream Chromium API changed - URLLoaderFactoryParams::process_id
was changed from an integer to a union type network::OriginatingProcess
that distinguishes between browser and renderer processes.
- For browser process requests, use OriginatingProcess::browser()
- For renderer process lookups, check !is_browser() and use
renderer_process().value() to get the child_id
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7498491
* 5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception | https://chromium-review.googlesource.com/c/chromium/src/+/5710330
5710330 added a new NSNextStepFrame interface extension and
implementations for NativeWidgetMacNSWindowTitledFrame and
NativeWidgetMacNSWindowBorderlessFrame. These use private macOS APIs
that are not available in Mac App Store builds.
* chore: update patches
* chore: bump chromium in DEPS to 146.0.7661.0
* chore: bump chromium in DEPS to 146.0.7663.0
* fix(patch-conflict): update accessibility_ui for string_view API change
Upstream removed redundant std::string(default_api_type) conversion as part
of a string_view optimization cleanup. Updated patch context to match.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7514107
* fix(patch-conflict): update service process launch options for sandbox API refactor
Upstream removed content/common/sandbox_init_win.cc and
content/public/common/sandbox_init_win.h, moving the functionality directly
into ChildProcessLauncherHelper. Updated patch to call
sandbox::policy::SandboxWin::StartSandboxedProcess directly with the
LaunchOptions pointer instead of going through the removed helper.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7528253
* fix(patch-conflict): update MAS safestorage for keychain API refactor
Upstream refactored KeychainPassword::GetPassword() to use a new
GetPasswordImpl() helper function with improved error tracking via
base::expected<std::string, OSStatus>. Adapted patch to use the new
GetPasswordImpl with the suffixed account name and handle migration
from legacy accounts through the new API.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7516438
* chore: update patches
* chore: bump chromium in DEPS to 146.0.7663.0
* fix: base::Value::Dict -> base::DictValue
https://chromium-review.googlesource.com/c/chromium/src/+/7513889
* fix: include new cookie exclusion reason
https://chromium-review.googlesource.com/c/chromium/src/+/7486527
* fix: enable libc++ ABI flag for trivially copyable std::vector<bool>
Required for changes introduced in the following CL
https://chromium-review.googlesource.com/c/chromium/src/+/7513653
* fixup! fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889
* fix: spellcheck not working in tests
https://chromium-review.googlesource.com/c/chromium/src/+/7452579
* fix: cookie test failing due to multiple rejection reasons
https://chromium-review.googlesource.com/c/chromium/src/+/7506629
* fix: macos sizing unmaximized window incorrectly
https://chromium-review.googlesource.com/c/chromium/src/+/7487666
Changes to headless mode caused the unmaximized window to subtract
the height of the menubar.
* fix: skip tests for incompatible BoringSSL ML-DSA crypto
https://boringssl-review.googlesource.com/c/boringssl/+/84929
* test: fix pseudonymization registration in utility process on Linux
Ref: 7486913: Pass pseudonymization salt via shared memory at process launch | https://chromium-review.googlesource.com/c/chromium/src/+/7486913
* fix: restore MAS patch-outs
Restores some `#if !IS_MAS_BUILD()` gates dropped in 773054ad59
* fixup! 7508687: use ChildProcessId for file permission APIs
* fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor
* chore: add note about parallel upstream change
* fixup! Merge remote-tracking branch 'origin/main' into roller/chromium/main
* Revert "fixup! 7508687: use ChildProcessId for file permission APIs"
This reverts commit 05c43e4e5d .
The _impl version has the signature, but not the public interface. :oof:
* fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2026-02-12 12:37:56 -05:00
Calvin
e9faa14cc0
test: drag region tests ( #49266 )
2026-02-12 01:50:02 -06:00
Niklas Wenzel
ce47542ccd
feat: add support for long-animation-frame script attribution ( #49706 )
...
* feat: add support for `long-animation-frame` script attribution
* docs: document `AlwaysLogLOAFURL`
* chore: add test
* docs: adjust docs as per PR comment
* fix: test failures
* chore: simplify test
* fix: tests on Windows and Linux
2026-02-11 09:34:22 -08:00
dependabot[bot]
ff2df2c98a
build(deps): bump diff from 3.5.0 to 3.5.1 in the npm_and_yarn group across 1 directory ( #49666 )
...
build(deps): bump diff in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [diff](https://github.com/kpdecker/jsdiff ).
Updates `diff` from 3.5.0 to 3.5.1
- [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md )
- [Commits](https://github.com/kpdecker/jsdiff/compare/v3.5.0...v3.5.1 )
---
updated-dependencies:
- dependency-name: diff
dependency-version: 3.5.1
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-11 16:52:05 +01:00
John Kleinschmidt
0284b9afcc
build: fixup attestation for release assets ( #49732 )
...
* build: fixup attestation for release assets
* Generate artifact attestation for generated artifacts
* set id-token for attestation
* Add artifact-metadata permission for attestation
* add permissions for testing attestations
* Revert "add permissions for testing attestations"
This reverts commit 0284bed175 .
* Revert "set id-token for attestation"
This reverts commit 69a1b13a18 .
* Revert "Generate artifact attestation for generated artifacts"
This reverts commit ee0536eceb .
2026-02-11 07:17:59 -05:00
David Sanders
52061b4c28
ci: add markdownlint problem matcher ( #49751 )
2026-02-11 13:17:29 +01:00
David Sanders
ec6d2fe549
build(dev-deps): update micromark-core-commonmark to 2.0.3 ( #49749 )
2026-02-11 13:11:58 +01:00
Ronald Eddy Jr
1c621cc982
docs: fix typos across documentation ( #49734 )
...
Fix 40 typos across 25 documentation files including misspellings,
missing words, doubled words, wrong words, and grammatical errors.
2026-02-11 12:45:46 +01:00
Shelley Vohr
57a6e43025
fix: revoke Read access after removing file via FileSystemAccess API ( #49620 )
...
Refs https://chromium-review.googlesource.com/6677249
2026-02-10 15:48:05 +01:00
dependabot[bot]
ef5b232e9f
build(deps): bump github/codeql-action from 4.32.1 to 4.32.2 ( #49735 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.32.1 to 4.32.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](6bc82e05fd...45cbd0c69e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-10 15:06:42 +01:00
Bug-Reaper
99fce5b6ca
fix: address upstream Chromium shift to enable CoreAudio Tap API for audio capture used in electron's desktopCapturer ( 🍏 macOS). ( #49717 )
...
* fix: Enable CoreAudio Tap API for Audio Capture (🍏 macOS)
* fix: addressed markdown issue which caused pre-commit hook failure
🧑🔧 : Ref : https://github.com/electron/electron/pull/49717#issuecomment-3874660013
* fix: updated docs to cover `desktopCapturer` nuances with macOS
📝 : PR https://github.com/electron/electron/pull/49717
2026-02-10 15:06:21 +01:00
Rushikesh Bobade
7c66112e88
docs: link unlinked type references in API documentation ( #49651 )
...
docs: add missing type links in menu.md and shared-texture.md
2026-02-09 23:08:52 -08:00
John Kleinschmidt
fd0108907a
build: fixup build attestation ( #49730 )
2026-02-09 11:50:17 -05:00
reito
3fa3e91f90
docs: fix framerate limit when osr with shared texture ( #49705 )
2026-02-09 15:18:06 +01:00
David Sanders
a3563422c4
ci: fix patches changes detected in apply patches workflow ( #49701 )
2026-02-06 13:48:30 -08:00
Keeley Hammond
9db2290bcd
fix: restore macos 12 support in Node 24 ( #49697 )
2026-02-06 07:48:37 -08:00
Samuel Attard
60d35bbaf4
feat: add support for disclaiming utility processes ( #49128 )
...
* feat: add support for disclaiming utility processes
* chore: update patches
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2026-02-05 14:37:24 -08:00
Michaela Laurencin
15dc7170ef
ci: fix ai-pr label commenting ( #49685 )
2026-02-05 14:27:46 -05:00
Keeley Hammond
59e434a27f
refactor: use ComPtr pattern for MSIX to avoid exception handling ( #49645 )
...
* Revert "fix: fix Windows MSIX release build errors (#49613 )"
This reverts commit 4b5d5f9dd5 .
* refactor: use WRL ComPtr pattern for MSIX to avoid exception handling
The MSIX auto-updater code was using C++/WinRT (winrt::* namespace), which requires exception handling (/EHsc). Mixing exception and non-exception handling code in the same binary is problematic at runtime. This commit refactors electron_api_msix_updater.cc to use an upstream Chromium pattern and eliminates the need for special exception handling build flags
* build: import correct packages
* build: consolidate IPackage declarations
* refactor: use IPackageManager/IPackageManager5/IPackageManager9 and
IPackage/IPackage2/IPackage4/IPackage6 interfaces as needed for
different API methods.
Also consolidates duplicate completion handler logic, fixes a bug in
RegisterRestartOnUpdate where the command line string could go out of
scope, and removes unused includes.
2026-02-05 10:42:28 -08:00
Samuel Attard
dec7f937ae
build: generate artifact attestions for released assets ( #48239 )
...
* build: generate artifact attestions for released assets
* chore: address review feedback
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2026-02-05 09:37:17 -05:00
Noah Gregory
50381a6d57
refactor: don't log error just for unsigned code ( #49654 )
2026-02-05 15:26:17 +09:00
David Sanders
41c7e9bb21
ci: use squash merge for apply patches workflow ( #49667 )
2026-02-04 15:51:49 -08:00
Shelley Vohr
9740c989da
fix: default accelerator for role-based menu items ( #49558 )
...
fix: apply default accelerator for role-based menu items
Co-authored-by: Kimgun3383 <tygob5247@gmail.com >
2026-02-04 16:45:29 -05:00
John Kleinschmidt
4ea2d816b8
revert(ci): use new case syntax in workflows ( #49665 )
...
Revert "ci: use new case syntax in workflows (#49590 )"
This reverts commit def7854848 .
2026-02-04 14:55:20 -05:00
Noah Gregory
6a47bb4731
fix: use temp directory for singleton test and clean up at end ( #49604 )
...
* fix: create directory for singleton test in `temp` instead of `home`
* fix: remove directory for singleton test at test end
* refactor: avoid extraneous declarations in singleton test
* refactor: reintroduce `userDataFolder` declaration in singleton test
* refactor: move cleanup before app exit in singleton test
* style: add missing semicolon
* refactor: set the user data path after pre-test cleanup in singleton test
* fix: release lock before cleanup in singleton test
2026-02-04 14:43:36 -05:00
David Sanders
ef11669b67
ci: handle PRs with no checks in rerun apply patches ( #49630 )
2026-02-04 16:13:27 +01:00
Shelley Vohr
d7378d96a5
docs: add Wayland note to win.getPosition() and win.getBounds() ( #49632 )
...
docs: add Wayland note to win.getPosition()
2026-02-04 16:13:11 +01:00
Keeley Hammond
431f77ca1c
fix: remove menu observer before destroying menu_controller_ ( #49648 )
...
* fix: remove menu observer before destroying menu_controller_
* fix: resolves private inheritance conflict
2026-02-04 16:11:00 +01:00
Shelley Vohr
51a9101c3d
build: remove Core Graphics private macOS APIs on MAS ( #49633 )
2026-02-03 12:02:06 -05:00
Shelley Vohr
def7854848
ci: use new case syntax in workflows ( #49590 )
...
ci: use new case synta in workflows
2026-02-03 11:57:14 -05:00
Niklas Wenzel
28858ecb85
chore: add "I have built and tested this PR" box to PR template ( #49434 )
2026-02-03 11:39:07 -05:00
Shelley Vohr
8fdb7549bb
fix: alt-space should route through 'system-context-menu' ( #49619 )
...
fix: alt-space should route through system-context-menu
2026-02-03 11:34:58 -05:00
dependabot[bot]
c3428fa413
build(deps): bump lodash from 4.17.21 to 4.17.23 in the npm_and_yarn group across 1 directory ( #49577 )
...
build(deps): bump lodash in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [lodash](https://github.com/lodash/lodash ).
Updates `lodash` from 4.17.21 to 4.17.23
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.21...4.17.23 )
---
updated-dependencies:
- dependency-name: lodash
dependency-version: 4.17.23
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-03 11:05:40 -05:00
loc
233caf8469
fix(squirrel.mac): clean up old staged updates before downloading new update ( #49365 )
...
fix: clean up old staged updates before downloading new update
When checkForUpdates() is called while an update is already staged,
Squirrel creates a new temporary directory for the download without
cleaning up the old one. This can lead to disk usage growth when
new versions are released while the app hasn't restarted.
This adds a force parameter to pruneUpdateDirectories that bypasses
the AwaitingRelaunch state check. This is called before creating a
new temp directory, ensuring old staged updates are cleaned up.
2026-02-03 11:04:06 -05:00
Shelley Vohr
86209f60eb
fix: possible crash in FileSystem API ( #49578 )
...
Refs https://chromium-review.googlesource.com/6880247
Fixes a crash that can arise in the File System Access API in the
following scenario:
1. Create fileHandle1 at path1.
2. Call fileHandle1.remove() or user manually delete the file.
3. Create fileHandle2 at path2.
4. fileHandle2.move(path1).
2026-02-03 15:15:54 +01:00
dependabot[bot]
bdf2b67462
build(deps): bump github/codeql-action from 4.32.0 to 4.32.1 ( #49629 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.32.0 to 4.32.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b20883b0cd...6bc82e05fd )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-03 15:03:22 +01:00
Mr.Chaofan
4413a0f642
fix: wrong cause and removed flag in cookie change listener ( #49103 )
2026-02-03 10:19:35 +01:00
Shelley Vohr
3776731f4a
fix: menu state in macOS dock menus ( #49574 )
2026-02-02 17:01:34 -05:00
Robo
db5606b4b3
fix: handle out of order recording errors in skia graphite ( #49608 )
2026-02-02 14:20:19 +01:00
Calvin
1159de52e7
docs: app.getGPUInfo() may reject ( #49580 )
2026-02-02 10:00:05 +01:00
Keeley Hammond
4b5d5f9dd5
fix: fix Windows MSIX release build errors ( #49613 )
...
* fix: fix MSIX release build
* fix: add C++/WinRT headers
* build: modify include paths
* fix: compile msix as seperate source set
* build: add additional needed deps for msix
2026-02-01 22:27:42 -08:00
Prachi Maskar
0cbf3c2918
docs: add jsign instructions for Azure Trusted Signing on Linux/macOS ( #49345 )
...
* docs: add jsign instructions for Azure Trusted Signing on Linux/macOS
* docs: add clickable jsign link for Azure Trusted Signing
2026-01-30 15:24:08 -05:00
axolotl
f272723a33
feat: Allow View.setBounds to animate ( #48812 )
...
* feat: allow View::SetBounds to animate
* fix: support width/height animations
* fix: jumping on subsequent animations
* fix: segfault race condition
* fix: remove layer background
* fix: layer clips not being reset
* refactor: use gfx tween gin converter
* fix: layer cleanups causing flickering views
* chore: merge artifact
* fix: missing private method in header
* fix: return type
* fix: do not set layer opacity
* refactor: update animate parameter format
* refactor: move animate into options object
* chore: typo
* docs: update
* spec: add view animation test
2026-01-30 15:18:56 -05:00
Shelley Vohr
331d1e16f5
refactor: address PathProvider TODO ( #49563 )
2026-01-30 14:16:39 -05:00
Shelley Vohr
6825a522e9
fix: duplicate fullscreen macOS menu item ( #49074 )
2026-01-30 13:23:43 -05:00
Shelley Vohr
e033c10075
fix: issues with xdg activation on Linux ( #49499 )
2026-01-30 10:53:04 -05:00
Shelley Vohr
64872a6cb8
fix: macOS menu item accelerators when item disabled ( #49553 )
...
fix: macOS menu item acceerators when item disabled
2026-01-30 10:07:16 +01:00
Jan Hannemann
d74fcfcecb
feat: msix auto-updater ( #49230 )
...
* feat: native auto updater for MSIX on Windows
* doc: added MSIX debug documentation
* fix: allow downgrade with json release file and emit update-available
* test: msix auot-update tests
* doc: API documentation
* test: add package version validation
* fix: docs typo
* fix: don't allow auto-updating when using appinstaller manifest
* fix: getPackageInfo interface implementation
* fix: review feedback, add comment
* fix: missed filename commit
* fix: install test cert on demand
* fix: time stamp mismatch in tests
* fix: feedback - rename to MSIXPackageInfo
* fix: update and reference windowsStore property
* fix: remove getPackagInfo from public API
* fix: type error bcause of removed API
2026-01-29 16:38:26 -05:00
Michaela Laurencin
92a3f7d6c1
ci: add workflow for commenting with new 'ai-pr' label ( #49564 )
...
* add workflow for commenting with new 'ai-pr' label
* Update .github/workflows/pull-request-labeled.yml
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* add pr autoclose
* replace with specific secret
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* specify repo
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* update wording of comment
* chore: use GH app token
* chore: fix indentation
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-29 13:12:42 -05:00
David Sanders
0e161c18eb
ci: rework reapply patches ( #49552 )
2026-01-29 11:19:07 -05:00
David Sanders
3d76d3a469
build(dev-deps): bump @electron/lint-roller to 3.2.0 ( #49565 )
2026-01-29 16:06:47 +01:00
Kanishk Ranjan
82d350524e
test: fix flaky BrowserView test ( #49316 )
...
* test: fix flaky BrowserWindow test
* fix: improved as per review
2026-01-28 11:54:35 -08:00
Shelley Vohr
e6be04a7a0
fix: chrome://accessibility drift ( #49547 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/6870052
2026-01-28 12:07:14 +01:00
David Sanders
a7de47084b
test: remove split dependency ( #49551 )
2026-01-28 10:47:43 +01:00
Kanishk Ranjan
3820d3ae6c
test: fix flaky BrowserWindow test ( #49364 )
...
test: fix flaky BrowserWindow test
2026-01-27 21:47:02 -08:00
Charles Kerr
8364b62f68
fix: potential dangling pointer in api::Screen ( #49536 )
...
fixes a regression from #49506
2026-01-27 16:27:38 -05:00
dependabot[bot]
441729c3a0
build(deps): bump actions/checkout from 6.0.1 to 6.0.2 ( #49541 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8e8c483db8...de0fac2e45 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-27 11:37:15 +01:00
Shelley Vohr
c521c2b868
test: update/fix Node.js disabled specs ( #49467 )
2026-01-27 11:03:09 +01:00
Shelley Vohr
b2c5093542
docs: correct type for process.noDeprecation ( #49524 )
...
* docs: correct type for process.noDeprecation
* docs: mark `noDeprecation` as optional instead
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk >
2026-01-27 11:02:51 +01:00
dependabot[bot]
ec5eb64788
build(deps): bump github/codeql-action from 4.31.10 to 4.32.0 ( #49540 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.10 to 4.32.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](cdefb33c0f...b20883b0cd )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-27 11:00:13 +01:00
David Sanders
0cc15a6386
ci: reapply patches if PR base branch updates them ( #49516 )
2026-01-26 15:13:34 -05:00
David Sanders
4aa89b9c3c
ci: add pipeline segment to run clang-tidy ( #49072 )
...
* ci: add pipeline segment to run clang-tidy
* chore: set -header-filter='' for clang-tidy
Breaking change in `clang-tidy` 22.0.0:
> clang-tidy now displays warnings from all non-system headers by default.
> Previously, users had to explicitly opt-in to header warnings using
> -header-filter=’.*’. To disable warnings from non-system, set
> -header-filter to an empty string.
2026-01-26 14:37:01 -05:00
Felix Rieseberg
ae43f17b79
build: Run gh workflows only on e/e ( #49521 )
2026-01-26 14:35:11 -05:00
electron-roller[bot]
b847299f19
chore: bump chromium to 146.0.7650.0 (main) ( #49496 )
...
* chore: bump chromium in DEPS to 146.0.7650.0
* 7496671: WaaP: Control hung delay for Initial WebUI
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7496671
* 7494302: [//media] Rename renderable_gpu_memory_buffer_video_frame_pool*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7494302
* chore: update patches
* 7502996: [DevTools] Add ability to toggle Chromium feature flags from DevTools
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7502996
* 7456200: Vectorize StringImpl::CopyChars and EqualIgnoringASCIICase using Highway.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200
* 7236627: spellcheck: supply full spelling marker info, incld. marker type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7236627
* chore: rm dependency on wtf::string from blink public headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200
added a public dependency on //third_party/highway for
//third_party/blink/renderer/platform/wtf:wtf which will not be
inherited by //content/renderer since wtf is internal dependency of
blink leading to the following compilation error
```
In file included from ../../content/public/renderer/window_features_converter.cc:5:
In file included from ../../content/public/renderer/window_features_converter.h:10:
In file included from ../../third_party/blink/public/web/web_window_features.h:38:
In file included from ../../third_party/blink/renderer/platform/wtf/text/wtf_string.h:40:
../../third_party/blink/renderer/platform/wtf/text/string_impl.h:27:10: fatal error: 'hwy/highway.h' file not found
27 | #include <hwy/highway.h>
| ^~~~~~~~~~~~~~~
1 error generated.
```
Use `gn desc out/Testing content/renderer:renderer_sources --blame`
to verify the inherited config and dependency list.
* 7493995: Restore directive part of wasm-eval error message
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7493995
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-26 11:18:09 -08:00
Charles Kerr
6766343173
refactor: simplify NativeWindow-to-BaseWindow lookup ( #49520 )
...
refactor: simplify native window to base window lookup
2026-01-26 12:28:57 +01:00
Sourav Bera
75be2fe8d6
docs: add type reference links in Menu and MenuItem API documentation ( #49437 )
...
* docs: add type reference links in Menu and MenuItem API documentation
* docs: revert type links in Menu return types to fix parser
2026-01-26 12:22:28 +01:00
Charles Kerr
30f365d9d8
refactor: use gin::Wrappable for electron::api::PowerMonitor ( #49509 )
...
* refactor: use `gin::Wrappable` for `electron::api::PowerMonitor`
* chore: update patches
2026-01-25 22:51:31 -06:00
Charles Kerr
e8250f9955
refactor: use gin::Wrappable for electron::api::Screen ( #49506 )
2026-01-25 13:46:25 -06:00
Kyle Cutler
d5de8883a2
feat: add focusOnNavigation flag to WebPreferences ( #49425 )
...
* feat: add focusOnNavigation webPreference
* WebContentsView tests
* fix
* fix
2026-01-23 14:29:34 -05:00
David Franco
8a11d5afb1
fix: avoid startup crash when V8 sandbox is disabled ( #49210 )
...
* fix: avoid startup crash when V8 sandbox is disabled
* chore: update patch
---------
Co-authored-by: David Franco <davidfrsan@gmail.com >
2026-01-23 11:49:15 -05:00
Shelley Vohr
89963618d9
fix: second argument to shell.writeShortcutLink is optional ( #49476 )
...
fix: second argument to shell.writeShortcutLink is optional
2026-01-23 11:24:47 -05:00
Charles Kerr
8c5c6a6088
refactor: use gin::Wrappable for electron::api::DataPipeHolder ( #49495 )
...
* refactor: make `DataPipeHolder` inherit from `gin::Wrappable`
* test: add a test to ensure GC clears the data pipe holder
* chore: e patches all
* chore: e patches all (trivial only)
* refactor: make AllDataPipeHolders a base::flat_map of WeakPersistent
2026-01-23 20:29:01 +09:00
Szymon Kurek
24526ccd39
docs: correct yarn part of tutorial-5-packaging ( #49401 )
...
docs: fix yarn part of `tutorial-5-packaging` - adding electron forge
2026-01-23 11:14:19 +01:00
Keeley Hammond
1134d95c6d
chore: update main patches ( #49498 )
...
chore: update patches
2026-01-22 20:30:32 -08:00
Charles Kerr
d76608b945
refactor: use gin::Wrappable in electron::api::PowerSaveBlocker ( #49381 )
...
* refactor: PowerSaveBlocker subclasses gin::Wrappable
* chore: update chore_add_electron_objects_to_wrappablepointertag.patch
* chore: e patches all
2026-01-22 17:31:38 -06:00
electron-roller[bot]
d689f76ff9
chore: bump chromium to 146.0.7645.0 (main) ( #49453 )
...
* chore: bump chromium in DEPS to 146.0.7643.0
* chore: bump chromium in DEPS to 146.0.7645.0
* chore: update patches
* 7402162: Refactor app shims to call ContentMain
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7402162
* 7454282: Add master key management for HTTP Cache Encryption
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7454282
* 7490440: Reland "Delete unused base::Contains()"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7490440
* chore: update patches
* 7414864: Pass CSSParserLocalContext down to CSSMathExpressionNodeParser
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7414864
* 7460969: Move child_process_id.h to common
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7460969
* 7474608: [api] Remove deprecated v8::PropertyCallbackInfo<T>::This()
Refs https://chromium-review.googlesource.com/c/v8/v8/+/7474608
* 7461067: [Viz] Rename kPreferGpuMemoryBuffer
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7461067
* 7487174: Remove GLHelper
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7487174
* 7457538: Set timeout from multi source page context fetcher
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7457538
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-22 17:01:09 -05:00
reito
e3142865b2
fix: offscreen rendering with correct screen info. ( #48730 )
...
fix: osr use correct screen info.
2026-01-22 14:58:54 -05:00
David Sanders
1f8e4079cd
test: fix version color output when running prebuilt Electron ( #49491 )
2026-01-22 16:17:56 +01:00
Shelley Vohr
bad88c6ed4
fix: potential devtools crash on empty ( #49468 )
2026-01-21 17:05:26 -08:00
Noah Gregory
534cb33465
fix: return early from platform_util::Beep() on Linux if there is no default GDK display ( #49442 )
...
fix: return early from beep on linux if there is no default gdk display
2026-01-21 15:55:24 -05:00
Soobin Rho
51e7753ae9
docs: clearer wording performance common pitfalls ( #45308 )
...
docs: clearer wording (performance common pitfalls)
Signed-off-by: Soobin Rho <soobinrho@gmail.com >
2026-01-21 14:46:02 -05:00
sam marshall
d141934885
docs: document that shell.trashItem requires backslashes ( #49038 )
...
docs: Update shell.md: Document that shell.trashItem requires backslashes
In Windows many functions relating to files (e.g. shell.openItem, the Node fs functions, as well as native Win32 APIs) will accept either type of slash / or \ as a folder separator.
shell.trashItem does not work with / as folder separator in Windows. This documentation change explains that.
See also:
https://github.com/electron/electron/issues/28831
2026-01-21 13:21:01 -05:00
Erick Zhao
22e8cf9416
docs: add a few API history fragments ( #49340 )
...
* docs: add a few API history fragments
* manual fixes
2026-01-21 12:57:02 -05:00
David Sanders
5856b2e01c
ci: trigger website docs update on release published ( #49429 )
2026-01-21 10:44:18 -05:00
Shelley Vohr
49d91dd02b
revert: use deprecated setAllowedFileTypes in macOS dialogs ( #49444 )
...
* revert: use deprectated setAllowedFileTypes in macOS dialogs
Closes https://github.com/electron/electron/issues/48191
* chore: remove stray import
2026-01-21 13:08:04 +01:00
David Franco
2f20d287d1
feat: import shared texture supports p010le ( #49272 )
...
feat: import shared texture supports p010le.
2026-01-20 11:50:30 +01:00
Shelley Vohr
73377af79e
build: try removing zero-fill sandbox patch component ( #49452 )
2026-01-20 09:40:33 +01:00
dependabot[bot]
47766801e4
build(deps): bump actions/setup-node from 6.1.0 to 6.2.0 ( #49456 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](395ad32622...6044e13b5d )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 6.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-20 09:40:02 +01:00
dependabot[bot]
bf0510dc22
build(deps): bump electron/github-app-auth-action from 1.1.1 to 2.0.0 ( #49457 )
...
Bumps [electron/github-app-auth-action](https://github.com/electron/github-app-auth-action ) from 1.1.1 to 2.0.0.
- [Release notes](https://github.com/electron/github-app-auth-action/releases )
- [Commits](384fd19694...e14e47722e )
---
updated-dependencies:
- dependency-name: electron/github-app-auth-action
dependency-version: 2.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-20 09:39:47 +01:00
electron-roller[bot]
486a9a61d2
chore: bump chromium to 146.0.7635.0 (main) ( #49408 )
...
* chore: bump chromium in DEPS to 146.0.7635.0
* chore: update patch hunk headers
* 7078551: [wasm] Refactor caching API
https://chromium-review.googlesource.com/c/v8/v8/+/7078551
* 7141498: [api] Remove unused context parameter from FixedArray::Get
https://chromium-review.googlesource.com/c/v8/v8/+/7141498
* 7454865: Add timeouts to content API for CopyFromSurface
https://chromium-review.googlesource.com/c/chromium/src/+/7454865
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-19 15:37:02 +01:00
Niklas Wenzel
7851a34c2d
docs: fix webContents.hostWebContents types ( #49424 )
2026-01-19 10:45:23 +01:00
Shelley Vohr
faa21a748f
fix: MAS rejection for private APIs ( #49391 )
2026-01-18 10:34:16 +01:00
Shelley Vohr
5bd2938f6a
fix: try clearing InspectableWebContents delegate earlier ( #49406 )
...
fix: try clearing InspectableWebContents delegate earlier
2026-01-16 21:36:34 +01:00
electron-roller[bot]
f149efe32e
chore: bump node to v24.13.0 (main) ( #49189 )
...
* chore: bump node in DEPS to v24.12.0
* src: use CP_UTF8 for wide file names on win32
https://github.com/nodejs/node/pull/60575
* test,crypto: handle a few more BoringSSL tests
https://github.com/nodejs/node/pull/59030
* chore: fixup patch indices
* chore: re-add accidentally removed sslv23 test
* chore: fixup crypto patch rebase
* test: make buffer sizes 32bit-aware in test-internal-util-construct-sab
https://github.com/nodejs/node/pull/61026
* src: add internal binding for constructing SharedArrayBuffers
https://github.com/nodejs/node/pull/60497
* chore: bump node in DEPS to v24.13.0
* chore: fixup patch indices
* chore: fixup sandboxed pointers patch
* tls: route callback exceptions through error handlers
https://github.com/nodejs-private/node-private/pull/782
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-16 11:08:38 -05:00
Daniel Gräfe
5dd509d2f4
fix: restore AXDocument accessibility attribute for representedFilename on macOS ( #49346 )
...
Starting from Chromium 134.0.6989.0 (Electron 35.0.0-beta.5), the
NativeWidgetMacNSWindow class overrides accessibilityDocument to return
the web content URL from the accessibility tree, but doesn't fall back
to NSWindow's default behavior when that URL is empty.
This broke Electron's setRepresentedFilename() API - the file path was
still set on the NSWindow, but no longer exposed via the AXDocument
accessibility attribute that screen readers use.
This fix adds an accessibilityDocument override in ElectronNSWindow that
checks representedFilename first, falling back to Chromium's behavior
for web content URLs.
Fixes: https://github.com/electron/electron/issues/XXXXX
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-16 10:27:29 +01:00
Alex Schwartz
bdd7730a24
fix: make toplevel icon Wayland protocol work ( #49290 )
2026-01-16 09:55:52 +01:00
dependabot[bot]
060e76f1b6
build(deps): bump actions/upload-artifact from 5.0.0 to 6.0.0 ( #49220 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](330a01c490...b7c566a772 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-16 09:55:38 +01:00
David Sanders
2fbf1f5c72
ci: detect patch needs update error with problem matcher ( #49405 )
2026-01-15 19:18:50 -08:00
Charles Kerr
c769361af2
fix: warning: default arguments on virtual or override methods ( #49398 )
...
fix: warning: default arguments on virtual or override methods are prohibited [google-default-arguments]
we never override these, so just make them nonvirtual
2026-01-15 16:09:43 -08:00
electron-roller[bot]
6ea7d6d5a4
chore: bump chromium to 146.0.7633.0 (main) ( #49390 )
...
* chore: bump chromium in DEPS to 146.0.7633.0
* chore: fixup patch indices
* chore: fix unsafe buffer usage in browser_linux.cc
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-15 10:52:42 -05:00
Charles Kerr
27b3a32307
chore: update patches ( #49399 )
2026-01-14 22:33:23 -08:00
Charles Kerr
ddeb970f18
refactor: make ReplyChannel inherit from gin::Wrappable ( #49339 )
...
* refactor: make ReplyChannel inherit from gin::Wrappable
* chore: add kElectronReplyChannel to chore_add_electron_objects_to_wrappablepointertag.patch
* fix: use gin::PerIsolateData::DisposeObserver
* fix: lifetime issues
* chore: rm perisolatedata hook in favor of prefinalizer
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-14 18:35:01 -06:00
electron-roller[bot]
5d80264944
chore: bump chromium to 145.0.7628.0 (main) ( #49331 )
...
* chore: bump chromium in DEPS to 145.0.7620.0
* chore: bump chromium in DEPS to 145.0.7622.0
* chore: bump chromium in DEPS to 145.0.7624.0
* chore: bump chromium in DEPS to 145.0.7626.0
* chore: bump chromium in DEPS to 145.0.7628.0
* 7362759: Migrate various base::Contains() to contains() in ui | https://chromium-review.googlesource.com/c/chromium/src/+/7362759
* chore: update patches
* 7411324: url: Mark deprecated functions as UNSAFE_BUFFER_USAGE
https://chromium-review.googlesource.com/c/chromium/src/+/7411324
* 7366867: Store property info in CSSParserLocalContext for random()
https://chromium-review.googlesource.com/c/chromium/src/+/7366867
* 7277406: Exclude PiP from getDisplayMedia picker thumbnails
https://chromium-review.googlesource.com/c/chromium/src/+/7277406
* 7253489: activity_reporter: Create stub module owned by browser_process
https://chromium-review.googlesource.com/c/chromium/src/+/7253489
* 7404514: Create device parental controls delegate
https://chromium-review.googlesource.com/c/chromium/src/+/7404514
* 7269504: Update histograms to use the updated MediaStreamRequestResult enum
https://chromium-review.googlesource.com/c/chromium/src/+/7269504
* fixup! 7253489: activity_reporter: Create stub module owned by browser_process
* 7368549: Reland "Use native rollup"
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7368549
* 4803165: Enable suppressing input event dispatch while paint-holding.
https://chromium-review.googlesource.com/c/chromium/src/+/4803165
* chore: make device_parental_controls lazy
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-14 15:34:24 +01:00
Erick Zhao
dae76c2885
docs: remove stale example and standardize DevTools capitalization ( #49321 )
...
* docs: remove stale example and standardize `DevTools` capitalization
* Update docs/api/web-contents.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
---------
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com >
2026-01-14 10:35:53 +01:00
Erick Zhao
a368c5da0c
docs: improve build-tools instructions ( #49294 )
...
* docs: improve build-tools instructions
* address comments
* update directory structure
* update
* nits
* node -> electron_node
* update macos build version
* Update docs/development/build-instructions-gn.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-14 09:51:55 +01:00
Keeley Hammond
1b2679b315
fix: revert os_crypt async cookie provider implementation ( #49382 )
...
* Revert "fix: provide explicit cookie encryption provider for cookie encryption (#49348 )"
This reverts commit 95f097a392 .
* Revert "fix: fix cookie encryption provider loading on Windows and Linux (#49371 )"
This reverts commit 0e4ee9f03a .
* revert: 6996667: Reland "Port net::CookieCryptoDelegate to os_crypt async" | https://chromium-review.googlesource.com/c/chromium/src/+/6996667
2026-01-14 09:34:00 +01:00
Shelley Vohr
15acf70760
build: roll build-image to a82b87d ( #49377 )
...
build: roll build-image to a82b87d
2026-01-13 12:13:14 +01:00
dependabot[bot]
324eb0eb1c
build(deps): bump github/codeql-action from 4.31.7 to 4.31.10 ( #49376 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.7 to 4.31.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](cf1bb45a27...cdefb33c0f )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.10
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-13 10:25:10 +01:00
Keeley Hammond
0e4ee9f03a
fix: fix cookie encryption provider loading on Windows and Linux ( #49371 )
...
* fix: support cookie encryption provider cross-platform
* fix: add async macos key provider
2026-01-12 19:39:29 -08:00
Charles Kerr
ae94cefdba
refactor: add static ReplyChannel::SendError() helper ( #49338 )
...
* refactor: add static void ReplyChannel::SendError()
* refactor: use static SendError() instead of instantiating a temporary
* refactor: remove non-static version of SendError()
* refactor: remove redundant callback-is-non-null checks
2026-01-12 17:02:58 -06:00
Shelley Vohr
409c29b12b
build: roll build-tools SHA to 4430e4a ( #49362 )
...
build: roll build-tools SHA to 4430e4a
2026-01-12 12:22:30 -05:00
Shelley Vohr
b0e012f14e
build: update on-create-command for siso ( #49357 )
2026-01-12 14:30:48 +01:00
Calvin
9a5ffd920c
feat: suppress devtools console logging ( #49292 )
...
* feat: suppress devtools console logging
* Emit messages as-is in testing builds
* Promote `DCHECK_IS_ON()` to preprocessor check
2026-01-12 11:31:33 +01:00
Charles Kerr
cf2e283332
fix: clang-tidy warnings, pt. 1 ( #49083 )
...
* fix: google-readability-casting warning about the uint32_t cast
* fix: modernize-use-equals-default warnings
* fix: readability-redundant-member-init warning
* fix: modernize-make-unique warnings
* fix: modernize-use-emplace
warning: use emplace_back instead of push_back
* refactor: address code review feedback
2026-01-09 22:57:38 -08:00
Niklas Wenzel
d6a6312fc8
build: update NMV to 145 ( #49349 )
2026-01-09 18:14:18 -08:00
Keeley Hammond
95f097a392
fix: provide explicit cookie encryption provider for cookie encryption ( #49348 )
...
fix: provide explicit cookie encryption provider
Fixes 6996667: Reland "Port net::CookieCryptoDelegate to os_crypt async" | https://chromium-review.googlesource.com/c/chromium/src/+/6996667
2026-01-09 11:53:58 -08:00
Niklas Wenzel
b380755514
chore: remove stakeholders mention from PR template ( #49317 )
2026-01-09 00:36:40 -08:00
David Sanders
3985daa81c
chore: improvements to script/run-clang-tidy.ts ( #49335 )
...
* chore: disable color output for clang-tidy in CI
* chore: small QoL improvements to run-clang-tidy.ts
* chore: add --fix option to script/run-clang-tidy.ts
2026-01-08 22:05:44 -08:00
Erick Zhao
5901d8a6d8
docs: document ELECTRON_SKIP_BINARY_DOWNLOAD ( #49320 )
2026-01-07 14:54:22 -08:00
electron-roller[bot]
eee60f202c
chore: bump chromium to 145.0.7618.0 (main) ( #49314 )
...
* chore: bump chromium in DEPS to 145.0.7618.0
* 7399531: [GTK] Don't preselect file dialog accept buttons | https://chromium-review.googlesource.com/c/chromium/src/+/7399531
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2026-01-07 15:01:56 -05:00
Charles Kerr
b5a7d81c7d
refactor: have GetXdgAppId() return a std::optional<std::string> ( #49318 )
...
* refactor: GetXdgAppId() now returns std::optional<std::string>
* refactor: slightly simplify app.setDesktopName() ts calls
* refactor: add better documentation for dekstop-entry in XDG notifications
2026-01-07 14:30:09 -05:00
dependabot[bot]
a89b2cd9bc
build(deps): bump actions/download-artifact from 6.0.0 to 7.0.0 ( #49221 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](018cc2cf5b...37930b1c2a )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 7.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-06 15:48:38 -05:00
Niklas Wenzel
44fa30695f
docs: update roundedCorners documentation ( #49195 )
2026-01-05 16:27:46 -05:00
Niklas Wenzel
2ab56adbbd
test: remove outdated disabled test ( #49196 )
2026-01-05 16:27:01 -05:00
electron-roller[bot]
a1f0ef80d4
chore: bump chromium to 145.0.7616.0 (main) ( #49279 )
...
* chore: bump chromium in DEPS to 145.0.7605.0
* chore: bump chromium in DEPS to 145.0.7606.0
* chore: bump chromium in DEPS to 145.0.7608.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7610.0
* chore: update patches
* [InputVizard] Fix missing touch cancel in InputTransferHandlerAndroid
using InputEventSource
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7302368
* chore: bump chromium in DEPS to 145.0.7611.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7614.0
* chore: bump chromium in DEPS to 145.0.7615.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7616.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-05 13:34:36 -05:00
dependabot[bot]
c1a031be83
build(deps): bump actions-cool/issues-helper from 3.7.3 to 3.7.5 ( #49282 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.7.3 to 3.7.5.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](3809910bc1...e2ff99831a )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.7.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-05 12:26:03 -05:00
John Kleinschmidt
c8bb700509
build: fixup release notes generation ( #49302 )
2026-01-05 11:11:40 -05:00
Calvin
46922de638
fix: drag regions in child windows ( #49231 )
...
* fix: drag regions in child windows
* Update comments
2026-01-05 10:34:01 -05:00
Niklas Wenzel
75ea93a279
chore: remove quiet period mention from PR template ( #49298 )
2026-01-05 10:12:07 -05:00
John Kleinschmidt
ace0beaa3f
build: add logging to notes generator ( #49300 )
2026-01-05 09:49:51 -05:00
electron-roller[bot]
9eb43f3286
chore: bump chromium to 145.0.7604.0 (main) ( #49265 )
...
* chore: bump chromium in DEPS to 145.0.7599.0
* chore: bump chromium in DEPS to 145.0.7600.0
* chore: bump chromium in DEPS to 145.0.7602.0
* chore: bump chromium in DEPS to 145.0.7604.0
* chore: update patches (trivial only)
* [bytesize] Migrate network data in Task Manager to ByteSize.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/7266090
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-12-28 20:40:50 -08:00
electron-roller[bot]
809ab09b6f
chore: bump chromium to 145.0.7596.0 (main) ( #49224 )
...
* chore: bump chromium in DEPS to 145.0.7588.0
* fix(patch-conflict): update scroll_bounce_flag for split overscroll methods
Chromium split IsElasticOverscrollEnabled() into two methods:
IsElasticOverscrollEnabledOnRoot() and IsElasticOverscrollSupported().
Updated patch to apply the scroll-bounce command-line switch to both
methods.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7233733
* fix(patch-conflict): update exclusive_access patch context
Upstream refactored the profile variable declaration. Updated patch to
match new surrounding context with brace-style if statement.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7239252
* fix(patch-conflict): update screen capture kit non-shareable filter
Upstream refactored PiP window exclusion to use GetWindowsToExclude()
helper function. Updated patch to combine non-shareable window filtering
with the new helper's output.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7274596
* fix(patch-conflict): update corner smoothing CSS property id position
Upstream added new internal overscroll CSS properties. Updated patch to
add kElectronCornerSmoothing after the new entries.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7234051
* fix(patch-conflict): update permission patches for new permission types
Upstream added new permission types: LOCAL_NETWORK, LOOPBACK_NETWORK,
and GEOLOCATION_APPROXIMATE. Updated Electron permission patches to
include these new types and renumber Electron-specific permissions.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7231952
* fix(patch-conflict): update memory query fallback for new function signature
Upstream added AmountOfTotalPhysicalMemory() with PCHECK. Updated patch
to maintain fallback logic with correct ByteSize return type.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254886
* chore: update patch hunk headers
* fix(patch): update reclient-configs patch to use new file mode
The fix_add_python_remote_wrapper patch was using 'copy from' mode
which caused inconsistent behavior between local and CI git versions.
Changed to 'new file' mode for consistent patch application.
* fix(patch-conflict): remove duplicate GEOLOCATION_APPROXIMATE case
Upstream moved GEOLOCATION_APPROXIMATE earlier in the switch statement
in GetPermissionString(). The 3-way merge kept both the old and new
positions, causing a duplicate case error.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/6397637
* chore: update libcxx filenames for new headers
* chore: bump chromium in DEPS to 145.0.7590.0
* chore: update patch hunk headers
* fix(patch): update memory fallback return type to ByteSize
Upstream changed the return type from ByteCount to ByteSize.
* fix: suppress nodiscard warning in node_file.cc
libc++ added [[nodiscard]] to std::filesystem::copy_options operator|=
which causes build failures with -Werror.
* 7229082: update CopyFromSurface to use CopyFromSurfaceResult
Upstream changed CopyFromSurface callback to return
base::expected<viz::CopyOutputBitmapWithMetadata, std::string>
instead of SkBitmap, enabling better error handling.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7229082
* 7254070: add ip_address_space param to OnLocalNetworkAccessPermissionRequired
Upstream added IPAddressSpace parameter to check address space for
proper permission handling in Local Network Access.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254070
* 7136679: add spelling_markers param to RequestCheckingOfText
Upstream added spelling_markers parameter to report misspelling
ranges from Blink to Spellcheck to IME.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7136679
* 7240487: remove second param from RegisterWebSafeIsolatedScheme
Upstream removed the schemes_okay_to_appear_as_origin_headers_ parameter.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7240487
* 7254577: use explicit WebElement constructor
WebElement default constructor now requires explicit construction
rather than brace initialization.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7254577
* 7256335: remove override from CreateGlobalFeaturesForTesting
Upstream removed BrowserProcess::CreateGlobalFeaturesForTesting virtual
method so the override specifier is no longer valid.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7256335
* chore: add missing SingleThreadTaskRunner include
A transitive include of SingleThreadTaskRunner was removed upstream,
requiring an explicit include.
Ref: Unable to locate specific CL (transitive include change)
* 7260483: add LOCAL_NETWORK, LOOPBACK_NETWORK permission type cases
Upstream added new permission types for Local Network Access split
permissions.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7260483
* chore: update patch hunk headers
* 7264893: update postMessage tests for file: origin serialization change
Chromium now serializes file: origins as 'null' in MessageEvent per spec.
This is a security improvement aligning with the HTML spec behavior.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7264893
* fix: add paths to custom scheme URLs in protocol tests
Custom scheme URLs without paths (e.g. test-scheme://foo) cause a
DCHECK crash in ASAN builds when CorsURLLoader tries to log the
request via GenerateRequestLine -> PathForRequest, which asserts
that the path is non-empty.
Adding trailing slashes ensures URLs have valid paths.
* chore: bump chromium in DEPS to 145.0.7592.0
* chore: update patches (trivial only)
* chore: bump chromium in DEPS to 145.0.7594.0
* chore: bump chromium in DEPS to 145.0.7596.0
* chore: update accelerator.patch
no manual changes; patch applied with fuzz 2 (offset 1 line)
* chore: update patches (trivial only)
* chore: node ./script/gen-libc++-filenames.js
---------
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-12-25 17:15:53 -06:00
Samuel Attard
3df3a6a736
fix: webRequest.onBeforeSendHeaders not being able to modify reserved headers ( #49226 )
...
* fix: `webRequest.onBeforeSendHeaders` not being able to modify reserved headers
* chore: add unit test for reserved header
2025-12-19 23:08:40 +13:00
Samuel Attard
7433c14af5
chore: add CLAUDE.md and Chromium Upgrade claude skill ( #49229 )
...
* chore: add CLAUDE.md and Chromium Upgrade claude skill
* Update script/lint.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-12-19 13:07:58 +13:00
electron-roller[bot]
a90ccc753b
chore: bump chromium to 145.0.7577.0 (main) ( #49175 )
...
* chore: bump chromium in DEPS to 145.0.7572.0
* chore: update patches (trivial only)
* chore(patch-conflict): feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Polished the edits and formatted the result. No real changes.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7232079 "7232079: Use WindowsToExclude to exclude PiP window in macOS screencapture device"
* chore(patch-conflict): feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7214586 "7214586: Refactor SelectFileDialogLinuxPortal to request XDG portal on demand"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7237910 "7237910: Remove g_gtk_ui global"
* 7228586: Migrate SystemMemoryInfo from ByteCount to ByteSize
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7228586
* 7207583: GlobalRenderFrameHostId to ChildProcessId
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7207583
* 7205548: Remove uses of BodyAsStringCallbackDeprecated (extensions/)
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7205548
* chore: bump chromium in DEPS to 145.0.7574.0
* chore: update libc++ filenames
* chore: update patches (trivial only)
* chore(patch-conflict): feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7246150 "7246150: Fix crash in ScreenCaptureKitDeviceMac due to null PIPScreenCaptureCoordinator"
* fixup! chore(patch-conflict): feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
* fixup! chore(patch-conflict): feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
* 7239572: [OOPIF PDF] Enable OOPIF PDF by default on Windows/macOS/Linux
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7239572
* chore: bump chromium in DEPS to 145.0.7576.0
* fixup! chore(patch-conflict): feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
* chore: update patches (trivial only)
* chore: add note to keep patch that was upstreamed but reverted
fix_restore_original_resize_performance_on_macos.patch was organically upstreamed but that change got reverted just after the current roll's cutoff.
I've added a note in the patch contents so the patch sticks around and so we can keep it after the revert is included.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7255334 "7255334: Revert 'Fix jank when resizing browser window'"
* chore: bump chromium in DEPS to 145.0.7577.0
* chore: update patches (trivial only)
* chore(patch-conflict): keep patch after revert
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7255334 "7255334: Revert 'Fix jank when resizing browser window'"
* 7237910: Remove g_gtk_ui global
I tried to find a way to avoid the patch, but other approaches seemed complex and involved.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7237910
* 7251900: Reland "Remove callback_helpers.h include from is_callback.h (try 5)"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7251900
* 7170174: [LNA] Retry requests for cached local resources
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7170174
* fix: PDFs use OOPIF (behavior change)
* fixup! 7237910: Remove g_gtk_ui global
* fixup! 7251900: Reland "Remove callback_helpers.h include from is_callback.h (try 5)"
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2025-12-16 12:32:38 -05:00
John Kleinschmidt
e181fd040f
build: drop dugite as a dependency ( #49194 )
2025-12-12 13:43:12 -05:00
David Sanders
a486185e10
ci: disallow non-maintainer changes to Yarn files ( #49186 )
2025-12-11 09:25:29 -05:00
John Kleinschmidt
8cefc8425c
build: upgrade yarn to 4.12.0 ( #49176 )
2025-12-10 14:04:14 -05:00
electron-roller[bot]
fe477ce3aa
chore: bump chromium to 145.0.7568.0 (main) ( #49145 )
...
* chore: bump chromium in DEPS to 145.0.7562.0
* fix(patch-conflict): update code cache patch for PersistentCache refactor
Upstream refactored code cache to use PersistentCache with new class-based
implementation (NoopCodeCacheHost, LocalCodeCacheHost, CodeCacheWithPersistentCacheHost).
Updated patch to integrate custom scheme support into the new structure while
preserving ProcessLockURLIsCodeCacheScheme checks for embedder-registered schemes.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7044986
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(patch-conflict): update dialog patch for RequestXdgDesktopPortal API
Upstream changed from SetSystemdScopeUnitNameForXdgPortal to RequestXdgDesktopPortal
API pattern. Updated OnServiceStarted signature and kept OnSystemdUnitStarted callback
that calls Electron's file_dialog::StartPortalAvailabilityTestInBackground().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7204285
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(patch-conflict): remove reference to deleted AbortByPlaceholderLayout flag
Upstream removed the AbortByPlaceholderLayout runtime flag from
runtime_enabled_features.json5. Updated patch to only add ElectronCSSCornerSmoothing
without the removed flag reference.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7226494
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* chore: update patch hunk headers
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(build): guard media_file_system_registry for ChromeOS only
Upstream CL https://chromium-review.googlesource.com/c/chromium/src/+/7100719
moved media_file_system_registry to be ChromeOS-only since Media
Galleries is a Chrome Apps API and Chrome Apps are only available
on Chrome OS now.
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(build): update VideoPixelFormat API for SharedImageFormat
Upstream CL https://chromium-review.googlesource.com/c/chromium/src/+/7207153
removed VideoPixelFormatToGfxBufferFormat as part of migration to
SharedImageFormat. Update to use VideoPixelFormatToSharedImageFormat
which directly returns the SharedImageFormat.
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(build): extend profile methods patch for ShouldEnableXfaForms
The ShouldEnableXfaForms function uses Profile::FromBrowserContext()
which is not available in Electron. Wrap the profile-dependent code
in #if 0 to fall through to the feature flag default.
Co-Authored-By: Claude <noreply@anthropic.com >
* chore: bump chromium in DEPS to 145.0.7563.0
* chore: bump chromium in DEPS to 145.0.7565.0
* chore: bump chromium in DEPS to 145.0.7567.0
* chore: bump chromium in DEPS to 145.0.7568.0
* fix(patch-conflict): update content_main_delegate.h context for IsInitFeatureListEarly
Upstream added a new IsInitFeatureListEarly() virtual method to ContentMainDelegate
just before where our GetBrowserV8SnapshotFilename() method is added. Updated patch
context to account for this new method.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7092856
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* chore: update patch hunk headers
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(patch-update): include v8-cppgc.h for CppHeap complete type
The std::unique_ptr<v8::CppHeap> default argument in node.h requires
the complete CppHeap type definition for the destructor. Added the
v8-cppgc.h include to provide the full type definition.
Ref: Unable to locate CL - libc++ unique_ptr requires complete type for destructor
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* chore: update patch hunk headers
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(build): move NativeAppWindowFrameViewMacClient before constructor
The std::unique_ptr<NativeAppWindowFrameViewMacClient> member requires
the complete type definition to be visible at the point of the constructor
because the unique_ptr destructor may be instantiated during exception
handling. Moved the class definition before the NativeWindowMac constructor.
Ref: Unable to locate CL - libc++ unique_ptr requires complete type for destructor
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com >
* fix(patch-conflict): update create_browser_v8_snapshot_file_name_fuse context for IsInitFeatureListEarly
The upstream added IsInitFeatureListEarly() virtual method declaration to
ContentMainDelegate class. Updated the patch context to account for this
new function being present before the GetBrowserV8SnapshotFilename()
declaration we add.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7092856
Co-Authored-By: Claude <noreply@anthropic.com >
* chore: update patch hunk headers
Co-Authored-By: Claude <noreply@anthropic.com >
* fix(patch-update): remove reverted IsInitFeatureListEarly from v8 snapshot patch
The upstream added IsInitFeatureListEarly() was reverted, so the patch should
not include this declaration. Only GetBrowserV8SnapshotFilename() should be
added by the create_browser_v8_snapshot_file_name_fuse patch.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7230430
Co-Authored-By: Claude <noreply@anthropic.com >
* 6171655: include single_thread_task_runner.h for complete type
Added include for base/task/single_thread_task_runner.h in osr_converter.cc
to resolve incomplete type error when using
base::SingleThreadTaskRunner::GetCurrentDefault().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/6171655
Co-Authored-By: Claude <noreply@anthropic.com >
* 7224136: use CHROMIUM_GIT_REVISION directly instead of removed function
Upstream removed GetChromiumGitRevision() function from embedder_support.
Updated to use CHROMIUM_GIT_REVISION macro directly via
build/util/chromium_git_revision.h as recommended in the Chromium CL.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7224136
Co-Authored-By: Claude <noreply@anthropic.com >
* fixup! 7224136: use CHROMIUM_GIT_REVISION directly instead of removed function
* fix(build): add missing include
`components/dbus/xdg/systemd.h` for `void OnSystemdUnitStarted(dbus_xdg::SystemdUnitStatus)` in the same patch.
* fix(build): adapt to string-view-ification change in windows jump_list.cc
7186922: Fix unsafe buffer usage in base/win/win_util.cc
https://chromium-review.googlesource.com/c/chromium/src/+/7186922
* chore: update libc++ filenames
* fixup! fix(build): add missing include
* fixup! fix(build): extend profile methods patch for ShouldEnableXfaForms
* fixup! fix(build): guard media_file_system_registry for ChromeOS only
* fixup! fixup! fix(build): extend profile methods patch for ShouldEnableXfaForms
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Claude <svc-devxp-claude@slack-corp.com >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-12-10 10:28:31 -05:00
John Kleinschmidt
bab6bd3dae
build: use @electron-ci/dev-root for package.json default ( #49154 )
2025-12-09 14:49:12 -05:00
dependabot[bot]
33f6942565
build(deps): bump actions/stale from 10.1.0 to 10.1.1 ( #49159 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 10.1.0 to 10.1.1.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](5f858e3efb...997185467f )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-version: 10.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-09 12:14:50 -05:00
dependabot[bot]
a1b2e82778
build(deps): bump actions-cool/issues-helper from 3.7.2 to 3.7.3 ( #49157 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.7.2 to 3.7.3.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](9861779a69...3809910bc1 )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.7.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-09 12:14:13 -05:00
dependabot[bot]
1e06b74cd2
build(deps): bump github/codeql-action from 4.31.6 to 4.31.7 ( #49155 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.6 to 4.31.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fe4161a26a...cf1bb45a27 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.7
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-09 11:15:08 -05:00
dependabot[bot]
fe0caa0e0d
build(deps): bump actions/checkout from 6.0.0 to 6.0.1 ( #49158 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](1af3b93b68...8e8c483db8 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-09 11:14:41 -05:00
dependabot[bot]
cd48083be8
build(deps): bump actions/setup-node from 6.0.0 to 6.1.0 ( #49156 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](2028fbc5c2...395ad32622 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 6.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-09 11:13:56 -05:00
John Kleinschmidt
8d5b104c17
build: upgrade github-app-auth to 3.2.0 ( #49152 )
2025-12-09 09:49:37 -05:00
John Kleinschmidt
6e134a8ad9
build: use powershell for Electron build step ( #49144 )
2025-12-08 16:03:40 -05:00
electron-roller[bot]
95e87e46ab
chore: bump chromium to 144.0.7547.0 (main) ( #49058 )
...
* chore: bump chromium in DEPS to 144.0.7543.0
* Pass PipScreenCaptureCoordinatorProxy to ScreenCaptureKitDeviceMac
https://chromium-review.googlesource.com/c/chromium/src/+/7157590
* chore: update patches
* chore: update filenames.libcxx.gni
* 7142359: Spanification of process_singleton_posix.cc
https: //chromium-review.googlesource.com/c/chromium/src/+/7142359
Co-Authored-By: Charles Kerr <70381+ckerr@users.noreply.github.com >
* Move logging::LoggingSettings to base/logging/logging_settings.h
https://chromium-review.googlesource.com/c/chromium/src/+/7173024
* chore: bump chromium in DEPS to 144.0.7545.0
* 7159368: update PluginService API for sync GetPlugins
Upstream removed async PluginService APIs:
- GetPluginsAsync() removed, use synchronous GetPlugins()
- RegisterInternalPlugin() now takes single argument (remove add_at_beginning)
- RefreshPlugins() removed entirely
Updated ElectronPluginInfoHostImpl to use synchronous plugin loading and
simplified ElectronBrowserMainParts internal plugin registration.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159368
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159328
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159056
(cherry picked from commit 88cdf50b0a )
* 7159184: add missing base/files/file_path.h include
Add explicit include for base/files/file_path.h in electron_browser_context.h.
After removal of superfluous Mojo includes from content headers, base::FilePath
is no longer transitively included via content/public/browser/browser_context.h.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159184
(cherry picked from commit 6ca8ea03ec )
* 7126479: add ShouldForceRefreshTextCheckService parameter to SpellCheckClient
Upstream added a force-refresh parameter to WebTextCheckClient::RequestCheckingOfText
to bypass spell check cache. Add the new ShouldForceRefreshTextCheckService
parameter to SpellCheckClient's override (currently unused in Electron).
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7126479
(cherry picked from commit 879c0401c4 )
* 7083663: remove fingerprinting_protection_ruleset_service override
Upstream deleted external references to Fingerprinting Protection Filter (FPF)
component. Remove the fingerprinting_protection_ruleset_service() override
from BrowserProcessImpl as the method no longer exists in the base class.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7083663
(cherry picked from commit 8350d152f9 )
* 7155287: implement WebContentsView::GetSize and Resize
Upstream delegated WebContents::GetSize() and Resize() to WebContentsView,
making them pure virtual. Add const qualifier to GetSize() and implement
the Resize() override in OffScreenWebContentsView (no-op for offscreen).
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7155287
(cherry picked from commit 084eaa568e )
* 7184238: add OnUnconfirmedTapConvertedToTap override
Upstream added OnUnconfirmedTapConvertedToTap as a pure virtual method
to RenderWidgetHostViewBase to inform root view when child frame converts
an unconfirmed tap. Add empty override for offscreen rendering.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7184238
(cherry picked from commit ef03400d9a )
* 7143586: add widget parameter to OnCommandsChanged
GlobalAcceleratorListener::OnCommandsChanged gained a gfx::AcceleratedWidget
parameter for window association in the GlobalShortcutListenerLinux
implementation. Pass gfx::kNullAcceleratedWidget for Electron's usage.
Ref: : Pass parent handle to GlobalAcceleratorListenerLinux::BindShortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/7143586
(cherry picked from commit 38306e2bfc )
Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com >
* chore: update patches
Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com >
* chore: bump chromium in DEPS to 144.0.7547.0
* chore: update patches
* 7189232: Add support for UnownedUserData in GlobalFeatures
https: //chromium-review.googlesource.com/c/chromium/src/+/7189232
* Refactor: Use std::u16string for extension load error messages
https://chromium-review.googlesource.com/c/chromium/src/+/7185844
* fixup Add support for UnownedUserData in GlobalFeatures
* 7165650: Remove ResourceContext
https://chromium-review.googlesource.com/c/chromium/src/+/7165650
* fixup BUILD.gn for lint
* 7202164: Reland "Reland "Remove GenericScopedHandle:IsValid""
https://chromium-review.googlesource.com/c/chromium/src/+/7202164
* advance deprecation of v8::ReturnValue<void>::Set(Local<S>).
7168624: [runtime][api] Relax requirements for setter/definer/deleter callbacks | https://chromium-review.googlesource.com/c/v8/v8/+/7168624
* fixup advance deprecation of v8::ReturnValue<void>::Set(Local<S>)
* chore: skip setting LPAC ACLs
* Revert "chore: skip setting LPAC ACLs"
This reverts commit e187aec488 .
* chore: revert Convert to UNSAFE_TODO in sandbox
revert https://chromium-review.googlesource.com/c/chromium/src/+/7131661 to see if it fixes the Windows sandbox issue.
* Revert "chore: revert Convert to UNSAFE_TODO in sandbox"
This reverts commit 57afbfefe5 .
* chore: Revert "Enable network sandbox by default on Windows"
see if this fixes the Windows sandbox issue
* Enable network sandbox by default on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/7204292
* Revert "chore: Revert "Enable network sandbox by default on Windows""
This reverts commit 530ab6af82 .
* fixup! Enable network sandbox by default on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/7204292
* fixup!: Correct flag name, add kLocalNetworkAccessChecks to all platforms
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <70381+ckerr@users.noreply.github.com >
Co-authored-by: Samuel Attard <sattard@anthropic.com >
Co-authored-by: Samuel Attard <MarshallOfSound@users.noreply.github.com >
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-12-04 16:40:04 -08:00
Jan Hannemann
90e338df50
fix: run toast creation on background thread ( #49106 )
...
* fix: run toast creation on background thread
notes: attempts to fix app freeze when triggering notifications and the COM server in WindowsShellExperienceHost hangs
* fix: comments
2025-12-02 15:27:22 -08:00
dependabot[bot]
1b3fc9c174
build(deps): bump actions/checkout from 4.2.2 to 6.0.0 ( #49125 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.2 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.2.2...1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-02 14:02:06 -05:00
dependabot[bot]
c51018281f
build(deps): bump github/codeql-action from 4.31.5 to 4.31.6 ( #49124 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.5 to 4.31.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fdbfb4d275...fe4161a26a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-02 14:01:21 -05:00
Samuel Attard
8ce97df569
build: gate brew commands in free-space-macos action ( #49123 )
...
fix: gate brew commands in free-space-macos action
The brew uninstall and autoremove commands now only run if
brew is available on the machine. This prevents failures on
runners where Homebrew is not installed.
Co-authored-by: Claude <noreply@anthropic.com >
2025-12-01 17:32:46 -08:00
John Kleinschmidt
7aafe66717
chore: reclaim macOS disk space ( #49118 )
2025-12-01 13:34:06 -08:00
Samuel Attard
ba5f7d272f
fix: rename RUNNER_NAME to MATRIX_RUNNER in disk cleanup workflow ( #49120 )
...
RUNNER_NAME is a reserved environment variable in GitHub Actions.
Renamed to MATRIX_RUNNER to avoid conflicts.
Co-authored-by: Claude <noreply@anthropic.com >
2025-12-01 13:33:45 -08:00
Samuel Attard
6b50b5e816
ci: add nightly macOS disk space cleanup workflow ( #49119 )
...
Add a scheduled GitHub Action that runs every night to:
- Run the existing disk space reclaimer on macOS runners
- Log disk space metrics (before/after cleanup, space freed) to Datadog
This helps monitor disk space trends and proactively maintain
runner health after recent "No space left on device" failures.
Co-authored-by: Claude <noreply@anthropic.com >
2025-12-01 13:07:28 -08:00
Niklas Wenzel
06044b50f4
chore: mention quiet period in PR template ( #49117 )
...
* chore: mention quiet period in PR template
* fix: remove trailing spaces
2025-12-01 11:55:13 -05:00
Robo
4adfc212b3
fix: crash when attempting to resolve modules during process exit ( #49090 )
...
* fix: crash when attempting to resolve modules during process exit
* chore: fix build
2025-11-27 10:30:09 +01:00
David Sanders
640c7bb908
ci: use clang problem matcher with nan spec runner ( #49096 )
2025-11-26 16:55:44 -08:00
David Sanders
0767b42cb8
ci: fix import in issue opened workflow ( #49095 )
2025-11-26 13:33:45 -05:00
Shelley Vohr
555f507c17
fix: ensure menu-did-close is emitted for application menus ( #49075 )
...
fix: ensure menu-did-close is emitted for application menus
2025-11-26 09:44:20 -06:00
David Sanders
1ff8e8014a
ci: use yarn workspace for workflow dependencies ( #48246 )
2025-11-26 10:31:01 +01:00
John Kleinschmidt
20c7042a20
ci: don't build yarn modules for linux arm ( #49031 )
...
This should fix the oom errors
2025-11-26 10:25:16 +01:00
David Sanders
4786e80f33
ci: ignore Dependabot workflow failures in audit ( #49080 )
2025-11-25 17:06:36 -08:00
dependabot[bot]
64326e296b
build(deps): bump actions/checkout from 5.0.1 to 6.0.0 ( #49070 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](93cb6efe18...1af3b93b68 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-25 14:44:17 -05:00
dependabot[bot]
2f67242030
build(deps): bump github/codeql-action from 4.31.3 to 4.31.5 ( #49071 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.3 to 4.31.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](014f16e7ab...fdbfb4d275 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-25 12:44:10 -06:00
David Sanders
e6844a3640
test: remove already disabled nan tests from our disable list ( #49050 )
2025-11-25 12:04:52 -06:00
Luke Horwell
fdb7fc7794
docs: Clarify that menus use non-native styles ( #45033 )
...
* docs: Clarify menus use non-native styles
Addresses #42262
* empty commit to kick ci
* fix: make linter happy
* Strip trailing space for lint
---------
Co-authored-by: George Xu <george.xu@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-11-25 18:27:46 +01:00
John Kleinschmidt
e601d05cbd
docs: update linux build instructions ( #49030 )
...
* docs: update linux build instructions
* Update docs/development/build-instructions-linux.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
* Update docs/development/build-instructions-linux.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
---------
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
2025-11-24 14:36:32 -05:00
electron-roller[bot]
66367e9db4
chore: bump chromium to 144.0.7527.0 (main) ( #48959 )
...
* chore: bump chromium in DEPS to 144.0.7527.0
* 7106405: [video pip] Fix gesture handling issues
https://chromium-review.googlesource.com/c/chromium/src/+/7106405
* 7130938: Reland "Remove some dependencies from the custom_handlers component"
https://chromium-review.googlesource.com/c/chromium/src/+/7130938
* 7139361: Rename PluginService's GetPlugins methods
https://chromium-review.googlesource.com/c/chromium/src/+/7139361
* chore: fixup patch indices
* test: fix macos webgl test | 7128438: Reland "Flip SwiftShader deprecation to launched." | https://chromium-review.googlesource.com/c/chromium/src/+/7128438
* test: update webgl test to skip on fallback adapters
* Fixup spec runner to properly fail on linux when tests fail
* test: fixup dbus tests
* test: convert shared-texture-spec from old done callback to async
Fixes Error: done() called multiple times in test <sharedTexture module import shared texture produced by osr successfully imported and rendered with subtle api> of file /__w/electron/electron/src/electron/spec/api-shared-texture-spec.ts
* test: fixup shared texture spec
* Revert "test: fixup dbus tests"
This reverts commit 3e2e720003 .
* test: fixup dbus tests
* test: disable context menu spellcheck tests on linux
https://github.com/electron/electron/pull/48657 broke those tests
* disable sharedTexture tests on platforms other than macOS arm64
They were not working on other platforms previously but now they error out.
Also removed extraneous debugging.
* fix: use github.sha for yarn cache key to avoid hashFiles() composite action bug
* Use --immutable-cache to allow native module builds
* fix: wait for devtools blur event in focus test to avoid race condition
* fix: wait for devtools blur event in focus test to avoid race condition
* fix allow native module builds in spec workspace
* test:rebuild native modules
* Revert "fix allow native module builds in spec workspace"
This reverts commit ffda3be98c .
* Revert "Use --immutable-cache to allow native module builds"
This reverts commit 2e6eea4348 .
* Revert "fix: use github.sha for yarn cache key to avoid hashFiles() composite action bug"
This reverts commit 33560ba0de .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-11-24 12:30:57 -05:00
Teo Yu Qi
05233b4962
docs: explain how to create transparent window using BaseWindow ( #48921 )
...
docs: clarify how to create transparent BaseWindow
2025-11-23 21:40:42 +01:00
Shelley Vohr
e4f02faa0a
fix: only call popup closecallback for top-level menu ( #49017 )
2025-11-21 10:37:46 -05:00
Robo
d890ebd9fa
chore: backport 744f40f from devtools-frontend ( #49027 )
2025-11-21 10:35:41 -05:00
Robo
79e17ce4be
fix: exception when reading system certificates via nodejs ( #49028 )
2025-11-21 10:35:05 -05:00
reito
2200a70e8d
feat: import shared texture supports nv12. ( #48922 )
2025-11-21 10:32:29 -05:00
John Kleinschmidt
203540c8aa
build: automatically install git for dugite ( #49022 )
2025-11-20 10:12:02 -05:00
BILL SHEN
8f9637fde4
fix: revert the parent window remained interactive after the modal window was opened ( #48977 )
2025-11-19 18:24:12 +01:00
dependabot[bot]
5b5b24775e
build(deps): bump github/codeql-action from 4.31.2 to 4.31.3 ( #48997 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.2 to 4.31.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](0499de31b9...014f16e7ab )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-19 09:45:40 +01:00
dependabot[bot]
eb4b7bb82f
build(deps): bump actions/checkout from 5.0.0 to 5.0.1 ( #48998 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](08c6903cd8...93cb6efe18 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 5.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-19 09:45:28 +01:00
Shelley Vohr
13e84e6868
fix: abort more descriptively for beforeunload ( #48960 )
2025-11-18 12:16:08 -05:00
electron-roller[bot]
54a617caab
chore: bump node to v24.11.1 (main) ( #48917 )
...
* chore: bump node in DEPS to v24.11.1
* src: add a default branch for module phase
https://github.com/nodejs/node/pull/60261
* src: conditionally disable source phase imports by default
https://github.com/nodejs/node/pull/60364
* chore: update patches
* src: update locks to use DictionaryTemplate and other minor cleanups
https://github.com/nodejs/node/pull/60061
* deps: update simdjson to 4.0.7
https://github.com/nodejs/node/pull/59883
* test: move sea tests into test/sea
https://github.com/nodejs/node/pull/60250
* fixup deps: update simdjson to 4.0.7a
* src: conditionally disable source phase imports by default
https://github.com/nodejs/node/pull/60364
* module: handle null source from async loader hooks in sync hooks
https://github.com/nodejs/node/pull/59929
* Revert "src: conditionally disable source phase imports by default"
This reverts commit 5f85b84262 .
* src: allow disabling JS source phase imports
https://github.com/nodejs/node/pull/60364
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-18 09:34:51 -05:00
Robo
530be28bc5
fix: handle empty event scenario in ipc callbacks ( #48987 )
2025-11-17 15:28:25 -05:00
Samuel Attard
537fd7b10b
build: update to yarn v4 ( #48243 )
2025-11-17 15:18:14 -05:00
Keeley Hammond
3809093511
build: add header for SetStackDumpFirstChanceCallback in renderer client ( #48978 )
2025-11-15 11:32:08 +01:00
Keeley Hammond
71be38f87f
fix: revert enabling WASM trap handlers in all Node.js processes ( #48973 )
...
Revert "fix: enable wasm trap handlers in all Node.js processes (#48788 )"
This reverts commit ca0b46b413 .
2025-11-14 15:23:15 -08:00
Samuel Attard
925966fde4
build: limit workflow gh token permissions ( #48237 )
2025-11-14 12:11:42 -08:00
Noah Gregory
2d5597b1b0
feat: validate integrity of ASAR Integrity dictionary on macOS ( #48587 )
2025-11-14 11:24:08 -08:00
Shelley Vohr
e3a0ac06e2
test: add view.getBounds|setBounds tests ( #48936 )
...
test: add view.getBounds|setBounds tests
2025-11-14 14:46:21 +01:00
Keeley Hammond
b66bf5db0c
build: correct uploader copy for tar files ( #48953 )
2025-11-13 20:07:52 -08:00
Charles Kerr
16f1ec9001
refactor: use std::map::extract() in api::WebRequest ( #48929 )
...
refactor: use std::map::extract() in api::WebRequest
Small readability refactor to api::WebRequest::blocked_requests_:
use extract() when we want to pull a BlockedRequest from the map
and then process it.
2025-11-13 16:50:13 -05:00
Keeley Hammond
c896ab80fe
fix: handle tar.xz files in uploaders, add to breaking changes ( #48941 )
...
* fix: handle tar.xz files in uploaders, add to breaking changes
* docs: add additional file extension info
2025-11-13 13:03:24 -08:00
Shelley Vohr
40b6738735
test: fix types in chromium-spec ( #48943 )
2025-11-13 15:25:09 -05:00
Niklas Wenzel
05b9a5bfc7
docs: fix docs for app.isHardwareAccelerationEnabled() ( #48925 )
2025-11-13 14:39:59 -05:00
Fedor Indutny
b9d3f15265
fix: crash on windows when UTF-8 is in path ( #48898 )
...
In 6399527761 we changed the path strings
that `node_modules.cc` operates on from single-byte to wide strings.
Unfortunately this means that `generic_path()` that the
"fix: ensure TraverseParent bails on resource path exit" patch was
calling was no longer a safe method to call on Windows if the underlying
string has unicode characters in it.
Here we fix it by using `ConvertGenericPathToUTF8` from the Node.js
internal utilities.
2025-11-13 19:09:34 +01:00
electron-roller[bot]
8ecd064d2c
chore: bump chromium to 144.0.7526.0 (main) ( #48932 )
...
* chore: bump chromium in DEPS to 144.0.7526.0
* 7138583: [Partitioned Popins Removal] IPC
https://chromium-review.googlesource.com/c/chromium/src/+/7138583
* chore: fixup patch indices
* 7139794: Partially remove check for global handlers in plugin mime_type code
https://chromium-review.googlesource.com/c/chromium/src/+/7139794
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-13 11:09:51 -05:00
Niklas Wenzel
511809ef63
docs: explain how to load SF Symbols with nativeImage ( #48908 )
...
* docs: explain how to load SF Symbols with `nativeImage`
* fix: use single quotes
* fix: use single quotes
2025-11-13 10:41:00 -05:00
Nilay Arya
32ae696ee0
feat: add --disable-geolocation command-line flag for macOS ( #45934 )
...
* feat(macos): add --disable-geolocation-mac command-line flag
* internally deny geolocation requests if flag set
e
* wrap PermissionRequestHandler instead
* wrap custom handler and deny regardless of response
* Update docs/api/command-line-switches.md
Co-authored-by: Will Anderson <will@itsananderson.com >
* resolving conflicts during rebase
* tests added
* tests added: minor changes
* move IsGeolocationDisabledViaCommandLine inside ElectronPermissionManager as a static member
* test: inject fixturesPath via --boot-eval
* Update shell/browser/electron_permission_manager.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* chore: Fixup after merge
* fixup after merge
---------
Co-authored-by: Will Anderson <will@itsananderson.com >
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-11-13 10:39:03 -05:00
Niklas Wenzel
b121065984
docs: clarify meaning of string value for menu item icon ( #48919 )
...
* docs: clarify meaning of string value for menu item icon
* fix: format
* fix: wording
2025-11-13 16:10:18 +01:00
Keeley Hammond
2622e6606d
build: apply additional compression to dsym on upload ( #48930 )
...
build: use tar.xz compression
2025-11-13 10:43:53 +01:00
electron-roller[bot]
10b07deb97
chore: bump chromium to 144.0.7522.0 (main) ( #48892 )
...
* chore: bump chromium in DEPS to 144.0.7522.0
* 7131867: Remove GenericScopedHandle::IsValid in favor of is_valid
https://chromium-review.googlesource.com/c/chromium/src/+/7131867
* 7078879: [video pip] Remove old controls
https://chromium-review.googlesource.com/c/chromium/src/+/7078879
* chore: fixup patch indices
* 7128138: Add a pref to enable Secure DNS 'automatic mode with DoH fallback'.
https://chromium-review.googlesource.com/c/chromium/src/+/7128138
* chore: fixup indices
* fix: pip patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-13 09:49:51 +01:00
vulture
92a910d15c
fix: Windows: Calling window.setFocusable(true) will no longer cause a window to lose focus ( #45640 )
...
Make setFocusable only deactivate a window if focusable is false. Do not deactivate a window when setting focusable to true.
2025-11-12 15:15:40 -05:00
Charles Kerr
3c5513015a
refactor: make api::WebRequest inherit from gin::Wrappable ( #48762 )
...
* refactor: make api::WebRequest inherit from gin::Wrappable
refactor: remove unused v8::Isolate* arg from WebRequest ctor
refactor: make electron::api::Session::web_request_ a cppgc::Member<api::WebRequest>
refactor: allocate api::WebRequest on cpp heap
refactor: modify Create(), Find(), and FindOrCreate() to return a WebRequest*
* refactor: ProxyingURLLoaderFactory takes a concrete api::WebRequest instead of a WebRequestAPI
Experimental commit to ensure `ProxyingURLLoaderFactory::web_request_api_`
won't be a dangling pointer.
* chore: fix doc shear
* refactor: use cppgc::WeakPersistent<> in ProxyingURLLoaderFactory
* refactor: make ProxyingURLLoaderFactory::web_request_ const
* refactor: make ProxyingWebSocket::web_request_ a cppgc::WeakPersistent<>
* add a gin::WeakCellFactory to api::WebRequest
* refactor: use a gin::WeakCell for the bound WebRequest argument in HandleOnBeforeRequestResponseEvent()
* chore: update patches
2025-11-12 12:53:00 -06:00
John Kleinschmidt
27727dbe0a
docs: deprecate clipboard API access from renderer processes ( #48877 )
2025-11-12 10:16:31 -05:00
정승규
7961206fcb
docs: fix v40 stable release date ( #48889 )
...
* docs(timelines): Correct v40.0.0 stable release date
On the Electron Timelines tutorial page (/docs/latest/tutorial/electron-timelines), there is a clear typo in the release schedule for v40.0.0.
The table currently lists the dates as:
* Alpha: 2025-Oct-30
* Beta: 2025-Dec-03
* **Stable: 2025-Oct-28**
This is logically incorrect, as the 'Stable' release date (Oct 28) is listed *before* both the 'Alpha' (Oct 30) and 'Beta' (Dec 03) dates for the same version.
This appears to be a copy-paste error, as the 'Stable' date (2025-Oct-28) is identical to the 'Stable' date for the v39.0.0 release in the preceding row.
This commit updates the 'Stable' date for v40.0.0 to its correct value, ensuring the timeline is accurate and logical.
* docs: Update v40.0.0 stable date to 2026-Jan-13 based on Chromium schedule
2025-11-12 12:59:32 +01:00
dependabot[bot]
7da0b4b351
build(deps): bump actions-cool/issues-helper from 3.7.1 to 3.7.2 ( #48884 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.7.1 to 3.7.2.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](564cd9b1ba...9861779a69 )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.7.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-11 21:33:27 +01:00
BILL SHEN
3d31030fc5
fix: restore window's canHide property on macOS ( #47970 )
...
* fix: restore window's canHide property on macOS
* chore: empty commit to unstick CI
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-11-11 15:30:04 -05:00
Shelley Vohr
11d174344a
build: roll Mantle and remove patch ( #38437 )
2025-11-11 15:25:51 -05:00
dependabot[bot]
687f3d4a92
build(deps-dev): bump @electron/asar from 3.2.13 to 4.0.1 ( #48721 )
...
* build(deps-dev): bump @electron/asar from 3.2.13 to 4.0.1
Bumps [@electron/asar](https://github.com/electron/asar ) from 3.2.13 to 4.0.1.
- [Release notes](https://github.com/electron/asar/releases )
- [Changelog](https://github.com/electron/asar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/electron/asar/compare/v3.2.13...v4.0.1 )
---
updated-dependencies:
- dependency-name: "@electron/asar"
dependency-version: 4.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: bump Node.js to 22.21.x
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-11 15:01:19 -05:00
Shelley Vohr
93a611e224
ci: exclude top-level docs files from full CI ( #48872 )
2025-11-11 11:53:50 -05:00
Shelley Vohr
09db682529
build: remove track SSL_ERROR_ZERO_RETURN explicitly patch ( #48875 )
...
build: remove track SSL_ERROR_ZERO_RETURN explicitly patch
2025-11-11 14:16:04 +01:00
electron-roller[bot]
b811ca0cde
chore: bump chromium to 144.0.7521.0 (main) ( #48880 )
...
* chore: bump chromium in DEPS to 144.0.7521.0
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-11 13:16:38 +01:00
Robo
f260e06a62
chore: delay load pdfjs-dist for pdf spec ( #48888 )
...
trap handlers will be initialized once the user script starts
but before app#ready. Wasm compilation before that phase will
break trap handler registeration due to the check in
v8::internal::wasm::UpdateComputedInformation. For some reason
this issue was only visible in <= 39-x-y when pdf-reader.mjs
was being loaded, maybe some module loading logic changed in >= 40-x-y
which are based on Node.js v24.x. In either case, it is best to
align the loading of wasm module required for the tests in light
of changes to how we are registering the trap handlers for the
main process.
2025-11-11 19:00:39 +09:00
Charles Kerr
b659563724
refactor: use gin_helper's gin::Wrappable-to-v8::Local converter ( #48885 )
...
* refactor: Session::NetLog() returns a NetLog*
Use gin_helper's gin::Wrappable-to-v8::Local converter instead
of rewriting it.
* refactor: FromPath(base::FilePath&, gin::Arguments*) returns a Session*
refactor: FromPartition(std::string&, gin::Arguments*) returns a Session*
Use gin_helper's gin::Wrappable-to-v8::Local converter instead
of rewriting it.
2025-11-11 15:33:25 +09:00
Erick Zhao
dd7c7fddd1
docs: remove electronegativity ( #48878 )
2025-11-10 20:37:12 -05:00
Kai
bc86e68a72
feat: add bypassCustomProtocolHandlers option to net.request ( #47331 )
...
* feat: add bypassCustomProtocolHandlers option to net.request
* style: fix lint errors in api-protocol-spec
2025-11-10 16:37:29 -05:00
Shelley Vohr
4951b96235
feat: support WebSocket authentication handling ( #48512 )
...
* feat: support WebSocket authentication handling
* test: add a test
* refactor: route through login instead
2025-11-10 21:30:44 +01:00
electron-roller[bot]
a5cebb6df2
chore: bump chromium to 144.0.7520.0 (main) ( #48869 )
...
* chore: bump chromium in DEPS to 144.0.7520.0
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-10 18:44:49 +01:00
Foad Lind
1ad8d35be9
docs: update macOS version support in README ( #48785 )
...
Update macOS version support in README
Support for macOS 11 (BigSur) was removed from v38: https://www.electronjs.org/blog/electron-38-0#removed-macos-11-support
2025-11-10 13:57:34 +01:00
electron-roller[bot]
a22511a196
chore: bump chromium to 144.0.7514.0 (main) ( #48840 )
...
* chore: bump chromium in DEPS to 144.0.7514.0
* chore: update patches
* 7119882: Reorganize //ui/gfx GN build target
https://chromium-review.googlesource.com/c/chromium/src/+/7119882
* Replace includes with forward declares in rect_conversions.h
https://chromium-review.googlesource.com/c/chromium/src/+/7127098
* Add ssl info to TrustedHeaderClient
https://chromium-review.googlesource.com/c/chromium/src/+/7106780
* Replace ContentPluginInfo with WebPluginInfo
https://chromium-review.googlesource.com/c/chromium/src/+/7127893
* Reland "[temporal] Unflag Temporal"
https://chromium-review.googlesource.com/c/v8/v8/+/7123876
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-11-10 13:27:35 +01:00
BILL SHEN
068ac3c405
fix: the parent window remained interactive after the modal window was opened ( #48770 )
...
fix: fix the issue where the parent window remained interactive after the modal window was opened in somecases.
2025-11-10 12:06:28 +01:00
Robo
87d1ff59cb
build: add missing header for SetStackDumpFirstChanceCallback ( #48860 )
2025-11-10 18:12:02 +09:00
Charles Kerr
1073d7e2bb
refactor: remove unused ExtensionActionAPI methods & fields ( #48850 )
...
refactor: remove unused method ExtensionActionAPI::GetExtensionPrefs()
refactor: remove unused field ExtensionActionAPI::browser_context_
refactor: remove unused field ExtensionActionAPI::browser_context_
looks like these were added in 5b105f91 but never used
2025-11-10 09:52:11 +01:00
Fedor Indutny
6399527761
fix: ESM-from-CJS import when CJK is in path ( #48855 )
...
Upstream fix: https://github.com/nodejs/node/pull/60575
2025-11-10 09:51:56 +01:00
Charles Kerr
519187db1d
refactor: decouple api::WebRequest from api::BrowserContext ( #48848 )
...
* refactor: rename api::Session::CreateFrom() to api::Session::FromOrCreate()
This is both clearer and more consistent with other classes
* refactor: add Session::FromOrCreate(content::BrowserContext*)
* refactor: reimplement api::WebRequest::FromOrCreate() using api::Session::FromOrCreate()
* refactor: use base::PassKey to ensure WebRequest is only instantiated by Session
* refactor: remove WebRequest::From()
no longer needed; Session already guarantees uniqueness
* refactor: remove unused isolate arg from WebRequest ctor
* refactor: do not attach WebRequest to BrowserContext
no longer needed now that access goes through Session
2025-11-09 08:07:25 -06:00
Shelley Vohr
ab0ff5dffc
refactor: remove spellcheck::kWinDelaySpellcheckServiceInit patch ( #48843 )
...
refactor: remove spellcheck::kWinDelaySpellcheckServiceInit patch
2025-11-08 10:26:06 -06:00
John Kleinschmidt
bec1734d63
chore: update patches ( #48847 )
2025-11-07 17:12:51 -05:00
Ryota Murakami
78b32cafcb
docs: Update 404 devtools extension documentation link ( #48813 )
...
* docs: Update 404 devtools extension documentation link
https://developer.chrome.com/extensions/devtools
↑Current link is not exists.
So update to most relevant developer.chrome.com page.
https://developer.chrome.com/docs/extensions/how-to/devtools/extend-devtools#creating
* docs: remove unnecessary anchor link
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-11-07 10:32:33 -05:00
electron-roller[bot]
595920a308
chore: bump chromium to 144.0.7512.1 (main) ( #48768 )
...
* chore: bump chromium in DEPS to 144.0.7507.0
* chore: bump chromium in DEPS to 144.0.7508.0
* chore: update patches
* 7101838: [pathbuilder] Enforce immutable SkPath APIs globally
https://chromium-review.googlesource.com/c/chromium/src/+/7101838
* chore: update filenames.libcxx.gni
* [pathbuilder] Enforce immutable SkPath APIs globally
https://chromium-review.googlesource.com/c/chromium/src/+/7101838
* Reduce service_worker_info.h includes in headers
https://chromium-review.googlesource.com/c/chromium/src/+/7108401
* chore: bump chromium in DEPS to 144.0.7510.0
* chore: update patches
* Use internal popup menus for tabs in actor-controlled states
https://chromium-review.googlesource.com/c/chromium/src/+/7074751
* [api] Delete deprecated fields on v8::Isolate
https://chromium-review.googlesource.com/c/v8/v8/+/7081397
xref: 98d243aea0
* Fixup Reduce service_worker_info.h includes in headers
* Promote deprecation of v8::Context and v8::Object API methods
https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* fixup Promote deprecation of v8::Context and v8::Object API methods
* chore: bump chromium in DEPS to 144.0.7512.1
* chore: update patches
* fixup [pathbuilder] Enforce immutable SkPath APIs global
* chore: update filenames.hunspell.gni
* fix deprecation of v8::Context and v8::Object API methods for nan
https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* [PDF] Implement PdfHelpBubbleHandlerFactory
https://chromium-review.googlesource.com/c/chromium/src/+/7056325
also: [PDF Ink Signatures] Hook up IPH
https://chromium-review.googlesource.com/c/chromium/src/+/7056207
* Remove base/hash/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/7113738
* fixup for lint
* Remove deprecated interceptor callback types and AccessControl enum
https://chromium-review.googlesource.com/c/v8/v8/+/7112747
* fixup for lint
* fixup [PDF] Implement PdfHelpBubbleHandlerFactory
* use base::SHA1HashString instead of std::hash
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-11-07 10:13:45 -05:00
Robo
ca0b46b413
fix: enable wasm trap handlers in all Node.js processes ( #48788 )
...
* fix: enable wasm trap handlers in all Node.js processes
* fix: separate registrations to account for featurelist init
2025-11-07 20:56:51 +09:00
Mitchell Cohen
194ce1a1d6
fix: CSD window frame tiles properly on Wayland ( #48765 )
...
fix: CSD window frame tiles properly on Linux
2025-11-07 11:24:12 +01:00
Shelley Vohr
b6a9f08be1
refactor: remove allow_unsafe_buffers pragma from FD_ZERO ( #48811 )
...
refactor: remove allow_unsafe_buffers pragma from FD_ZERO
2025-11-07 11:23:52 +01:00
reito
bab11f8c7b
feat: add sharedTexture module to import shared texture ( #47317 )
...
feat: add `sharedTexture` module.
2025-11-07 09:50:28 +01:00
George Xu
38be633aa8
fix(reland): allow disabling all NSMenuItems ( #48795 )
...
* fix: allow disabling all `NSMenuItems` (#48598 )
fix: allow disabling all NSMenuItems
* fix: add guard for type
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-06 19:02:04 -08:00
Robo
9d01e6b3e3
fix: oom crash in v8 when optimizing wasm ( #48791 )
2025-11-06 21:58:13 +09:00
David Sanders
3c100c2229
build: use --keep-non-patch flag with git am ( #48797 )
2025-11-06 17:07:09 +09:00
Charles Kerr
f6ffb55c72
refactor: remove electron::WebRequestAPI interface ( #48792 )
...
* refactor: remove electron::WebRequestAPI interface
Remove the |electron::WebRequestAPI| interface class.
Use handles to the concrete class |electron::api::WebRequest| instead.
Prerequisite for https://github.com/electron/electron/pull/48762 .
Two classes (electron::ProxyingURLLoaderFactory and electron::ProxyingWebSocket)
hold a handle to a WebRequest via |raw_ptr<electron::WebRequestAPI>|.
|electron::WebRequestAPI| is a pure virtual interface whose concrete impl is
|electron::api::WebRequest|.
This is a problem when migrating |electron::api::WebRequest| to cppgc:
we need to change those |raw_ptr<>|s to |cppgc::WeakPersistent<>| but
can't instantiate |cppgc::WeakPersistent<electron::WebRequestAPI>| as-is.
We also can't change it to inherit from |cppgc::GarbageCollectedMixin|,
since that causes problems when |electron::api::WebRequest| inherits from
both |electron::WebRequestAPI| and |cppgc::GarbageCollected|.
* refactor: use name web_request, not web_request_api
* refactor: make ProxyingURLLoaderFactory::web_request() private
* chore: make linter happy by fixing whitespace
2025-11-06 17:05:50 +09:00
Keeley Hammond
27bea2576e
fix: revert allow disabling all NSMenuItems, fix menu crash ( #48794 )
...
Revert "fix: allow disabling all `NSMenuItems` (#48598 )"
This reverts commit 0cb4fdd0f2 .
2025-11-05 15:49:43 -08:00
Charles Kerr
c460992407
refactor: remove unnecessary template type in EmitEvent() ( #48778 )
...
refactor: remove unnecessary template type in EmitEvent()
refactor: CallMethodWithArgs() takes a std::string_view
2025-11-05 18:28:33 -05:00
Shelley Vohr
1f78d2258c
refactor: remove base::AdaptCallbackForRepeating patch ( #48774 )
...
refactor: remove base::AdaptCallbackForRepeating patch
2025-11-05 11:00:51 -08:00
BILL SHEN
513a6ee80a
fix: draw smoothing round rect corner ( #48769 )
2025-11-05 10:33:05 +01:00
Keeley Hammond
040b0e795b
build: apply additional compression on upload ( #48766 )
...
build: apply additional compression on upload for large files
2025-11-04 10:20:42 -05:00
electron-roller[bot]
184586f0b1
chore: bump node to v24.11.0 (main) ( #48728 )
...
chore: bump node in DEPS to v24.11.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-11-04 14:09:33 +01:00
dependabot[bot]
26759b8412
build(deps): bump github/codeql-action from 4.31.0 to 4.31.2 ( #48764 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.31.0 to 4.31.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4e94bd11f7...0499de31b9 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-04 11:54:33 +01:00
dependabot[bot]
de5041797f
build(deps): bump actions-cool/issues-helper from 3.6.2 to 3.7.1 ( #48763 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.6.2 to 3.7.1.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](50068f49b7...564cd9b1ba )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.7.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-11-04 11:54:19 +01:00
axolotl
5bd45a6a28
feat: add SF Symbol support to NativeImage::CreateFromNamedImage ( #48203 )
...
* feat: add SF Symbol support to NativeImage::CreateFromNamedImage
* use obj-c name in NSImage constructor
* add test for named symbol image
* apply suggested simplification
* fix: support NX cocoa prefix
2025-11-04 11:15:34 +01:00
David Sanders
d7727c9ec2
build: remove patch that landed in Chromium roll ( #48771 )
2025-11-04 10:07:52 +01:00
electron-roller[bot]
ba135e2f7f
chore: bump chromium to 144.0.7506.0 (main) ( #48744 )
...
* chore: bump chromium in DEPS to 144.0.7504.0
* chore: bump chromium in DEPS to 144.0.7506.0
* chore: update patches
* Revert "build: explicitly disable reclient"
This reverts commit e08c6adb08 .
No longer needed after https://crrev.com/c/7099239
* 7097498: Remove MSG_ROUTING_* constants from ipc_message.h
https://chromium-review.googlesource.com/c/chromium/src/+/7097498
* 7090671: [//gpu] Remove unneeded GpuInfo methods
https://chromium-review.googlesource.com/c/chromium/src/+/7090671
* 7103701: Remove IPC::PlatformFileForTransit.
https://chromium-review.googlesource.com/c/chromium/src/+/7103701
(This should have been removed with https://github.com/electron/electron/pull/17406 ).
* chore: update filenames.libcxx.gni
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-11-03 21:26:16 -08:00
Damglador
a88de8bf1c
fix: use app name as a part of tray id on Linux ( #48675 )
...
* fix: use browser name as tray id
* fix: remove unnecessary .c_str()
* fix: use string_view instead of string&
* fix: move app_name_ to the bottom of private: section
https://google.github.io/styleguide/cppguide.html#Declaration_Order
* fix: use base's string utils to join strings
* docs: note when to remove the patch
* fix: update patch
* fix: make linter happy
* fix: move app_name_ to the bottom of private: section
2025-11-03 16:53:53 -06:00
Mitchell Cohen
4d6db515bd
fix: release mouse buttons on focus loss on Wayland ( #48752 )
2025-11-03 14:37:42 +01:00
Niklas Wenzel
20fc76cb43
docs: explain how to handle incoming drag and drop ( #48718 )
...
Fixes https://github.com/electron/electron/issues/48667
2025-11-03 14:37:01 +01:00
Mitchell Cohen
2a94d414f7
docs: clarify BrowserWindow and App API support status on Wayland ( #48740 )
...
* docs: clarify BrowserWindow API support in Wayland
* typo fix
* updated docs
* wrapping
2025-10-31 16:35:08 -05:00
Charles Kerr
4abb1f2aa3
refactor: use Object.values() instead of Object.keys() in stringifyValues() ( #48741 )
...
refactor: use Object.values() instead of Object.keys() in stringifyValues
we only used the key to get the value
2025-10-31 16:32:34 -05:00
electron-roller[bot]
310490221e
chore: bump chromium to 144.0.7500.0 (main) ( #48725 )
...
* chore: bump chromium in DEPS to 144.0.7500.0
* chore: fixup patch indices
* 7088768: Reland "download reclient only for chromeos by default"
https://chromium-review.googlesource.com/c/chromium/src/+/7088768
* Revert "7088768: Reland "download reclient only for chromeos by default""
This reverts commit 149d9fc92e .
* build: explicitly disable reclient
* 7013355: [api] Remove deprecated PropertyCallbackInfo::Holder()
https://chromium-review.googlesource.com/c/v8/v8/+/7013355
* [video pip] Enable video picture-in-picture controls update
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6701399
* fixup! [api] Remove deprecated PropertyCallbackInfo::Holder()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-10-31 11:01:09 -04:00
Shelley Vohr
3345edd2bf
chore: upgrade Node.js to v24.10.0 ( #48613 )
...
* chore: upgrade Node.js to v24.10.0
* chore: fixup crypto patch
* chore: fixup crypto test patch
* src: prepare for v8 sandboxing
https://github.com/nodejs/node/pull/58376
* esm: fix module.exports export on CJS modules
https://github.com/nodejs/node/pull/57366
* chore: fixup lazyload fs patch
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
* module: remove --experimental-default-type
https://github.com/nodejs/node/pull/56092
* lib,src: refactor assert to load error source from memory
https://github.com/nodejs/node/pull/59751
* src: add source location to v8::TaskRunner
https://github.com/nodejs/node/pull/54077
* src: remove dependency on wrapper-descriptor-based CppHeap
https://github.com/nodejs/node/pull/54077
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
* test: update v8-stats test for V8 12.6
https://github.com/nodejs/node/pull/54077
* esm: unflag --experimental-wasm-modules
https://github.com/nodejs/node/pull/57038
* test: adapt assert tests to stack trace changes
https://github.com/nodejs/node/pull/58070
* src,test: unregister the isolate after disposal and before freeing
https://github.com/nodejs/node/pull/58070
* src: use cppgc to manage ContextifyContext
https://github.com/nodejs/node/pull/56522
* src: replace uses of FastApiTypedArray
https://github.com/nodejs/node/pull/58070
* module: integrate TypeScript into compile cache
https://github.com/nodejs/node/pull/56629
* deps: update ada to 3.2.7
https://github.com/nodejs/node/pull/59336
* src: make minor cleanups in encoding_binding.cc
https://github.com/nodejs/node/pull/57448
* src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2`
https://github.com/nodejs/node/pull/55453
* src: use non-deprecated Get/SetPrototype methods
https://github.com/nodejs/node/pull/59671
* src: simplify string_bytes with views
https://github.com/nodejs/node/pull/54876
* src: improve utf8 string generation performance
https://github.com/nodejs/node/pull/54873
* src: use non-deprecated Utf8LengthV2() method
https://github.com/nodejs/node/pull/58070
* src: use non-deprecated WriteUtf8V2() method
https://github.com/nodejs/node/pull/58070
* src: refactor WriteUCS2 and remove flags argument
https://github.com/nodejs/node/pull/58163
* src: use String::WriteV2() in TwoByteValue
https://github.com/nodejs/node/pull/58164
* node-api: use WriteV2 in napi_get_value_string_utf16
https://github.com/nodejs/node/pull/58165
* node-api: use WriteOneByteV2 in napi_get_value_string_latin1
https://github.com/nodejs/node/pull/58325
* src: migrate WriteOneByte to WriteOneByteV2
https://github.com/nodejs/node/pull/59634
* fs: introduce dirent\.parentPath
https://github.com/nodejs/node/pull/50976
* src: avoid copy by using std::views::keys
https://github.com/nodejs/node/pull/56080
* chore: fixup patch indices
* fix: errant use of context->GetIsolate()
* fix: tweak BoringSSL compat patch for new changes
* fix: add back missing isolate dtor declaration
* fixup! esm: fix module.exports export on CJS modules
* cli: remove --no-experimental-fetch flag
https://github.com/nodejs/node/pull/52611/files
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
* fixup! src: prepare for v8 sandboxing
* chore: bump @types/node to v24
* chore: fix const assignment in crypto test
* fix: sandbox pointer patch issues
* chore: rework source phase import patch
* src: add percentage support to --max-old-space-size
https://github.com/nodejs/node/pull/59082
* chore: fixup crypto tests
* chore: HostImportModuleWithPhaseDynamically todo
* fix: cjs esm failures
* fix: v8::Object::Wrappable issues
- b72a615754
- 490bac2496
- 4896a0dd69
* chore: remove deleted specs
* src: use v8::ExternalMemoryAccounter
https://github.com/nodejs/node/pull/58070
* fs: port SonicBoom module to fs module as FastUtf8Stream
https://github.com/nodejs/node/pull/58897
* chore: tweak sandboxed pr patch
* test: disable parallel/test-os-checked-function
* test: use WHATWG URL instead of url.parse
* fix: OPENSSL_secure_zalloc doesn't work in BoringSSL
* chore: fix accidental extra line
* 7017517: [defer-import-eval] Parse import defer syntax
https://chromium-review.googlesource.com/c/v8/v8/+/7017517
2025-10-30 19:16:48 +01:00
Charles Kerr
c5fe50be3b
refactor: remove redundant map lookups in browser/api/menu.ts ( #48706 )
...
perf: avoid double map lookup in Menu.prototype._shouldCommandIdWorkWhenHidden
perf: avoid double map lookup in Menu.prototype._isCommandIdVisible
perf: avoid double map lookup in Menu.prototype._shouldRegisterAcceleratorForCommandId
perf: avoid double map lookup in Menu.prototype._getSharingItemForCommandId
2025-10-29 11:42:15 -05:00
electron-roller[bot]
37de243f55
chore: bump chromium to 143.0.7499.0 (main) ( #48707 )
...
* chore: bump chromium in DEPS to 143.0.7499.0
* 7079895: Allow full screen reentry when full screen parameters changed
https://chromium-review.googlesource.com/c/chromium/src/+/7079895
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-29 12:32:33 +01:00
Erick Zhao
8c05e4b450
docs: use relative link for OffscreenSharedTexture ( #48717 )
2025-10-28 15:24:31 -07:00
Keeley Hammond
1eb2858e9a
build: bump NMV to 143 for Electron 40 ( #48714 )
2025-10-28 15:02:26 -07:00
Calvin
c761a7529e
docs: add release timeline for Electron 40 ( #48663 )
2025-10-28 12:42:59 -07:00
Calvin
75c722ca2f
docs: remove inaccurate EOL deprecation process ( #48696 )
2025-10-28 12:40:00 -07:00
byquanton
1d3cc9d554
docs: add caveats for Electron PipeWire implementation ( #48242 )
2025-10-28 12:39:12 -07:00
Shelley Vohr
0cb4fdd0f2
fix: allow disabling all NSMenuItems ( #48598 )
...
fix: allow disabling all NSMenuItems
2025-10-28 11:20:55 -04:00
syntax.sculptor
21dfa8c732
fix: use correct signal variable in nan-spec-runner install check ( #48639 )
...
The install process spawn was not capturing its own signal variable,
causing the error check to incorrectly reference the build signal
instead. This could lead to:
- Install termination by signal going undetected
- False positive errors when build was killed but install succeeded
This commit ensures the install signal is properly captured and
checked, matching the pattern used for the build process.
2025-10-28 11:18:47 -04:00
electron-roller[bot]
29e0948f7b
chore: bump chromium to 143.0.7497.0 (main) ( #48657 )
...
* chore: bump chromium in DEPS to 143.0.7492.0
* chore: bump chromium in DEPS to 143.0.7493.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update printing.patch
Avoid a reachable NOTREACHED() in PrintingContextLinux | https://chromium-review.googlesource.com/c/chromium/src/+/7081117
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
patch reapplied manually due to context shear
Cleanup: format some content files | https://chromium-review.googlesource.com/c/chromium/src/+/7083290
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
patch manually reapplied for files moved upstream
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update revert_cleanup_remove_feature_windelayspellcheckserviceinit.patch
no manual changes; patch applied with fuzz
[spelling+grammar restrictions] fix feature param name | https://chromium-review.googlesource.com/c/chromium/src/+/7081186
* chore: update patches
* chore: fix broken includes in ElectronBrowserMainParts
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: bump chromium in DEPS to 143.0.7495.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 143.0.7497.0
* chore: fixup patch indices
* 7085081: Roll libc++ from d6739a332fe9 to bc00f6e9f739 (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/7085081
* 7081087: Move os_crypt/sync and os_crypt/async shared code to os_crypt/common
https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* test: fix failing spec
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-28 11:17:29 -04:00
dependabot[bot]
08492b5977
build(deps): bump actions/upload-artifact from 4.6.2 to 5.0.0 ( #48691 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](ea165f8d65...330a01c490 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-28 07:50:01 -05:00
dependabot[bot]
3c1b51d949
build(deps): bump github/codeql-action from 4.30.9 to 4.31.0 ( #48692 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.30.9 to 4.31.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](16140ae1a1...4e94bd11f7 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-28 07:49:29 -05:00
michal-pichlinski-openfin
28f1cf1f11
feat: Focus DevTools when breakpoint is triggered ( #46386 )
...
`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
if (life_stage_ != kLoadCompleted)
return;
\#if BUILDFLAG(IS_ANDROID)
NOTIMPLEMENTED();
\#else
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.
Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.
Only supported for DevTools manged by `electron::InspectableWebContents`.
Closes : #37388
2025-10-28 08:46:33 -04:00
Erick Zhao
297319f931
ci: use <sup> in release notes generator ( #48690 )
2025-10-28 09:06:23 +01:00
dependabot[bot]
7fecc66e12
build(deps): bump actions/download-artifact from 5.0.0 to 6.0.0 ( #48693 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](634f93cb29...018cc2cf5b )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-28 08:58:28 +01:00
dependabot[bot]
705d120288
build(deps-dev): bump typescript from 5.6.2 to 5.8.3 ( #48694 )
...
Bumps [typescript](https://github.com/microsoft/TypeScript ) from 5.6.2 to 5.8.3.
- [Release notes](https://github.com/microsoft/TypeScript/releases )
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml )
- [Commits](https://github.com/microsoft/TypeScript/compare/v5.6.2...v5.8.3 )
---
updated-dependencies:
- dependency-name: typescript
dependency-version: 5.8.3
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-28 08:54:56 +01:00
Teaveloper
9ce27e5318
docs: security.md use runnable examples for permissions and csp ( #43248 )
...
* docs: security.md use runnable examples for permissions and csp
Signed-off-by: LeUser111 <florian.wiedenmann@grob.de >
* Removed semi-colon for uniform js code style in examples
Signed-off-by: LeUser111 <florian.wiedenmann@grob.de >
* docs: security.md, session.md - added clarification on defaultSession, added csp example
* docs: security.md/session.md incorporated review feedback
* docs: security.md/session.md incorporated more review feedback
* docs: security.md/session.md incorporated more review feedback
* docs: tutorial/security.md - fixed linting issue
* chore: empty commit for CI
---------
Signed-off-by: LeUser111 <florian.wiedenmann@grob.de >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-10-27 16:56:53 -04:00
CuzImSlymi
09c22ea979
docs: add net.isOnline() to online/offline detection tutorial ( #48665 )
...
* docs: add net.isOnline() to online/offline detection tutorial
* chore: make linter happy
docs/tutorial/online-offline-events.md:12:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
docs/tutorial/online-offline-events.md:13:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-27 15:35:38 -04:00
Charles Kerr
e44b96bbd3
refactor: avoid deprecated views a11y api ( #47674 )
...
* refactor: use GetViewAccessibility().SetName() instead of SetAccessibleName()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5537333
* refactor: use GetViewAccessibility().SetRole() instead of SetAccessibleRole()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5337377
* fixup! refactor: use GetViewAccessibility().SetRole() instead of SetAccessibleRole()
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-27 14:05:25 -05:00
Shelley Vohr
b389377c63
feat: add app.isHardwareAccelerationEnabled() ( #47614 )
...
* feat: add app.isHardwareAccelerationEnabled()
* chore: address review feedback
2025-10-27 14:03:08 -05:00
zoy
8f6ecd816b
docs: modify the thickFrame doc ( #48579 )
...
* doc: modify the thickFrame doc
* chore: update description
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
* update format
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2025-10-27 13:38:05 -04:00
Charles Kerr
a611881ff3
fix: logical bug in install.js env var handling ( #48634 )
...
If either `npm_config_electron_use_remote_checksums` or
`electron_use_remote_checksums` are set as environment variables, then
force Electron to verify with remote checksums instead of embedded ones.
Fixes #48594 .
2025-10-27 11:23:45 +01:00
dependabot[bot]
7925a4fe78
build(deps-dev): bump webpack-cli from 5.1.4 to 6.0.1 ( #48651 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 5.1.4 to 6.0.1.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/main/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@5.1.4...webpack-cli@6.0.1 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-version: 6.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-27 09:21:05 +01:00
Shelley Vohr
eda0a7e749
fix: crash on empty dialog extensions array on Windows ( #48640 )
2025-10-25 18:14:55 +02:00
electron-roller[bot]
777b6c70a2
chore: bump chromium to 143.0.7491.0 (main) ( #48650 )
...
* chore: bump chromium in DEPS to 143.0.7490.0
* chore: bump chromium in DEPS to 143.0.7491.0
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
Revert "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7078209
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Remove BackForwardTransitions flag | https://chromium-review.googlesource.com/c/chromium/src/+/7022596
* chore: update allow_electron_to_depend_on_components_os_crypt_sync.patch
no manual changes; patch applied with fuzz
Remove usage of os_crypt/sync in chrome/browser/ui | https://chromium-review.googlesource.com/c/chromium/src/+/7062066
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-24 16:54:44 -05:00
electron-roller[bot]
6d8196fba3
chore: bump chromium to 143.0.7489.0 (main) ( #48642 )
...
* chore: bump chromium in DEPS to 143.0.7489.0
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Remove BackForwardTransitions flag | https://chromium-review.googlesource.com/c/chromium/src/+/7022596
* chore: update process_singleton.patch
patch reapplied manually due to context shear
Use an empty prefix for socket temporary directory. | https://chromium-review.googlesource.com/c/chromium/src/+/7062192
* chore: update add_electron_deps_to_license_credits_file.patch
no manual changes; patch applied with fuzz
* chore: update expose_ripemd160.patch
Apply modernize-use-nullptr fixes in all .cc files | https://boringssl-review.googlesource.com/c/boringssl/+/83067
* chore: update feat_expose_several_extra_cipher_functions.patch
Apply modernize-use-nullptr fixes in all .cc files | https://boringssl-review.googlesource.com/c/boringssl/+/83067
* Pass Bus::Options by value with std::move. | https://chromium-review.googlesource.com/c/chromium/src/+/7056670
* chore: update patches
* Remove some includes of base/callback_list.h | https://chromium-review.googlesource.com/c/chromium/src/+/7055621
* chore: run gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-23 16:28:51 -04:00
Teaveloper
fbfd7c7126
docs: security.md mark 'Enable process sandboxing' as active by defau… ( #43247 )
...
* docs: security.md mark 'Enable process sandboxing' as active by default since electron 20
* Adjusted according to feedback
* Updated according to feedback - adjusted sandbox.md
* formatting
* Fixed broken markup
* Implemented docs linting suggestions
* docs: docs/tutorial/sandbox.md - fixed typo
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* docs: web-preferences.md - sandbox: mention default value and relation to nodeIntegration
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-10-23 16:11:55 -04:00
Ruben R
00e01e0e82
fix: remove killed check to allow multiple signals ( #40667 )
...
* fix: remove `killed` check to allow multiple signals
* fix: signal forwarding
2025-10-23 15:20:04 -04:00
Calvin
418b8235bc
chore: bump nan to 2.23.0 ( #48591 )
...
* chore: bump nan to 2.23.0
* Fix C++ flags passed to C compiler in NAN spec runner
Passing C++-specific flags to the C compiler caused failures building native test modules.
NAN uprgaded the version of node-gyp it uses, triggering a new codepath with the C compiler that didn't occur before. In that new branch, the C++ flags present in the CFLAGS environment variable we were passing in caused the C compiler to error out:
```
error: invalid argument '-std=c++20' not allowed with 'C'
```
The fix is to only pass C++-specific flags to the C++ compiler, and not the C compiler. This is done by separating out the CFLAGS and CXXFLAGS environment variables in our nan-spec-runner.js script.
I'm curious to know more about why each of these flags are necessary, but for now this change restores the previous behavior where native test modules could be built successfully.
* test: use v8 version check instead of node version check (patch)
* Re-enable `methodswithdata-test`
2025-10-23 20:58:40 +02:00
David Sanders
717eb0dca5
ci: add more fields to Slack payload for backport requested message ( #48148 )
...
* ci: add more fields to Slack payload for backport requested message
* chore: wrap values with toJSON
2025-10-23 11:58:18 -04:00
Niklas Wenzel
c6c3d405e2
docs: fix Ubuntu version used to build Electron ( #48638 )
2025-10-23 10:45:45 -04:00
electron-roller[bot]
9235dc0159
chore: bump chromium to 143.0.7485.0 (main) ( #48618 )
...
* chore: bump chromium in DEPS to 143.0.7485.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Patch applied manually due to context shear
* Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
* chore: e patches all
* chore: check for file existence before setting utime
* chore: stop disabling kWinDelaySpellcheckServiceInit
[cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087
This flag has been removed upstream. We've used it since c2d7164 (#38248 )
to fix a crash originally described in 97b353a (#34993 ):
> Delaying spell check initialization is causing specs for
> 'custom dictionary word list API' to fail in Electron.
Since we haven't touched this in a few years, and since there's a
clear success criteria (a passing/failing spec), and since the patch
to restore this flag would be pretty large (~750 lines), I'm going
to try just removing the flag from our source to see if the spec
passes or fails.
* Revert "chore: stop disabling kWinDelaySpellcheckServiceInit"
This reverts commit e688880396 .
Unfortunately, the crash persists.
* Revert [cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087
We currently need this feature
* fixup! chore: check for file existence before setting utime
* fixup! Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Address Robo's code review @ 64c7fd21ed
* fixup! fixup! chore: check for file existence before setting utime
fix: oops typo
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-23 08:30:29 -05:00
Shelley Vohr
f784ea6f4f
fix: icon in Windows toast notification ( #48543 )
2025-10-21 15:12:26 -04:00
Tau Gärtli
7ec0ebc50a
feat: Add getAccentColor on Linux ( #48027 )
...
* feat: Implement `getAccentColor` on Linux
* doc: Update OS support for accent color APIs
2025-10-21 14:26:30 -04:00
dependabot[bot]
4d329d466b
build(deps): bump actions/checkout from 4.2.2 to 5.0.0 ( #48051 )
...
* build(deps): bump actions/checkout from 4.2.2 to 5.0.0
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](11bd71901b...08c6903cd8 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: remove inaccurate version information
Version can easily be determined from sha
* ci: link node 24 for linux arm testing
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-21 14:12:05 -04:00
Shelley Vohr
e766d378e1
feat: enable more granular a11y feature management ( #48042 )
...
* feat: enable more granular a11y feature management
* Update docs/api/app.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-21 10:56:14 -04:00
Shelley Vohr
0a19176917
feat: enable resetting accent color ( #48274 )
2025-10-21 10:49:08 -04:00
Shelley Vohr
6562d6ed0b
fix: systemPreferences.getAccentColor inverted color ( #48511 )
...
fix: systemPreferences.getAccentColor inverted color
2025-10-21 10:46:46 -04:00
Shelley Vohr
0b179f8f05
fix: devtools crashing on Linux in detach mode ( #48600 )
2025-10-21 10:45:02 -04:00
Shelley Vohr
89d3067dd4
fix: trafficLightPosition incorrect with customButtonsOnHover ( #48538 )
...
fix: trafficLightPosition incorrect with customButtonsOnHover
2025-10-21 10:43:04 -04:00
electron-roller[bot]
00a3031357
chore: bump chromium to 143.0.7483.0 (main) ( #48590 )
...
* chore: bump chromium in DEPS to 143.0.7482.0
* chore: bump chromium in DEPS to 143.0.7483.0
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update mas_avoid_private_macos_api_usage.patch.patch
[graphite] Refactor backpressure fences on Mac to avoid GLContext | https://chromium-review.googlesource.com/c/chromium/src/+/7047167
* chore: update disable_compositor_recycling.patch
no manual changes; patch applied with fuzz
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update feat_allow_code_cache_in_custom_schemes.patch
[url] Change Add*Scheme*(...) functions to accept std::string_view | https://chromium-review.googlesource.com/c/chromium/src/+/7046471
* chore: e patches all
* [memory] Replace bool success with MemoryDumpRequestOutcome enum. | https://chromium-review.googlesource.com/c/chromium/src/+/7029767
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-21 08:11:09 -05:00
dependabot[bot]
46c344fb1c
build(deps): bump github/codeql-action from 4.30.8 to 4.30.9 ( #48606 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.30.8 to 4.30.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f443b600d9...16140ae1a1 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.30.9
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-21 10:47:44 +02:00
dependabot[bot]
28cf65eb33
build(deps): bump actions/setup-node from 5.0.0 to 6.0.0 ( #48607 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](a0853c2454...2028fbc5c2 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-21 07:30:39 +02:00
John Kleinschmidt
2a0c368105
build: use one build target ( #48527 )
...
This reverts commit Optimizes our builds for use with siso/avoids file contention on Windows
2025-10-20 15:57:50 -04:00
Mitchell Cohen
0c27c1a395
fix: position window titlebar buttons correctly in Ubuntu on Wayland ( #48490 )
2025-10-20 12:42:23 -07:00
Michaela Laurencin
a528547dc8
chore: exempt tracking-upstream issues from stale ( #48574 )
2025-10-20 11:47:58 -04:00
Shelley Vohr
413803188d
fix: background hover contrast for WCO buttons ( #48568 )
2025-10-20 09:54:14 +02:00
electron-roller[bot]
1cc2fce905
chore: bump chromium to 143.0.7477.0 (main) ( #48584 )
...
* chore: bump chromium in DEPS to 143.0.7477.0
* 7049117: [CodeCache] Adjust PersistentCache for CodeCache feature
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7049117
* chore: update patches
* chore: add missing includes of ui/gfx/image/image_skia.h
* 7028738: Rename several ipc_* files used by param_traits*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7028738
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-19 21:46:34 +02:00
electron-roller[bot]
3bfe1f2363
chore: bump chromium to 143.0.7474.0 (main) ( #48572 )
...
* chore: bump chromium in DEPS to 143.0.7474.0
* 7006208: [Mac] Fix rendering bug for manual occlusion detection on macOS 26
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006208
* chore: update patches
* 7038563: Forward declare more in page_navigator.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7038563
* 7023417: Remove ipc/ipc_message_macros.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023417
* 7006340: Move icon_util files to win/ subdrectory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7006340
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-17 13:04:24 -04:00
Shelley Vohr
7e031f7e33
ci: fix publish for macOS < 26.0 ( #48575 )
2025-10-16 16:53:13 -07:00
Robo
7580e3a5e2
chore: update fix_harden_blink_scriptstate_maybefrom.patch ( #48566 )
2025-10-16 10:16:17 +09:00
electron-roller[bot]
471a14432f
chore: bump chromium to 143.0.7469.0 (main) ( #48548 )
...
* chore: bump chromium in DEPS to 143.0.7469.0
* 7021651: [//gpu] Fold handle creation into D3DImageBackingFactory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7021651
* 7013047: Fix various C++23 build errors in //chrome
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7013047
* 7010850: [//ui] Port screen_mac.mm's calls to DisplayColorSpaces
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7010850
* 7007933: Remove superfluous mojom includes in //content/public headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7007933
* 7023196: Trim os_crypt/sync visibility list
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023196
* 7008912: Remove GURL::*_piece() method
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7008912
* 7003989: Add wrapper struct for CopyFromSurface output
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7003989
* 7017889: [MemoryPressureListener] Remove type aliases
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7017889
* 7027780: Delete viz::ResourceSizes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7027780
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6989572
* 6495189: [api] Delete old String::Write* APIs
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6495189
* chore: update patches
* chore: run script/gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-15 14:10:10 -07:00
Shelley Vohr
676406c9e6
build: run on macOS 15 ( #48563 )
2025-10-14 13:29:21 -07:00
CezaryKulakowski
357e42d907
fix: fixed white flash on call to BrowserWindow.show ( #47151 )
2025-10-14 15:58:27 +02:00
お餅のCreeeper
9b740594fb
fix: enable shader-f16 on windows ( #48342 )
...
* fix: Enable shader-f16 on Windows
* fix: include dxil.dll and dxcompiler.dll for windows x64 and arm64
* fix: modified to follow the chromium dawn build configuration
* fix: include dxil.dll and dxcompiler.dll for windows x86
* fix: Modified to avoid explicitly specifying dawn_use_built_dxc
2025-10-14 15:46:12 +02:00
dependabot[bot]
9e577ae60e
build(deps): bump ossf/scorecard-action from 2.4.2 to 2.4.3 ( #48551 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](05b42c6244...4eaacf0543 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-version: 2.4.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-14 14:45:03 +02:00
dependabot[bot]
b74bd8fc35
build(deps): bump github/codeql-action from 3.30.6 to 4.30.8 ( #48552 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.30.6 to 4.30.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](64d10c1313...f443b600d9 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.30.8
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-14 11:29:55 +02:00
David Sanders
f494dbb609
ci: upload build cache hit rate on Windows as well ( #48550 )
2025-10-14 09:57:47 +02:00
David Sanders
8dc5999f8b
build(deps): bump @electron/typescript-definitions to 9.1.5 ( #48210 )
2025-10-13 10:46:34 -07:00
electron-roller[bot]
d920c82fc4
chore: bump chromium to 143.0.7451.0 (main) ( #48362 )
...
* chore: bump chromium in DEPS to 142.0.7429.0
* chore: bump chromium in DEPS to 142.0.7430.0
* 6954508: Reland Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6954508
* https://chromium-review.googlesource.com/c/chromium/src/+/6955633
* 5584820: Fix font face resolution when renderer is blocked | https://chromium-review.googlesource.com/c/chromium/src/+/5584820
* chore: export patches
* chore: remove patch that keeley says is ok to remove in comments
* chore: bump chromium in DEPS to 142.0.7432.0
* chore: export patches
* chore: bump chromium in DEPS to 142.0.7434.0
* 6973697: Use type tags for data stored in V8 internal fields | https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* 6976272: Revert Reland mac: click through content area in main window | https://chromium-review.googlesource.com/c/chromium/src/+/6976272
* chore: export patches
* 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086
* 6951252: Correct PersistentCache backed code cache context grouping
* chore: bump chromium in DEPS to 142.0.7436.0
* 6981628: Reland Use unordered_map in AcceleratorMap | https://chromium-review.googlesource.com/c/chromium/src/+/6981628
* chore: export patches
* chore: resolve patch conflict with main
* chore: merge conflict with main
* chore: bump chromium in DEPS to 142.0.7438.0
* chore: bump chromium in DEPS to 142.0.7440.0
* chore: bump chromium in DEPS to 142.0.7442.0
* chore: bump chromium in DEPS to 142.0.7444.0
* chore: bump chromium in DEPS to 143.0.7445.0
* chore: bump chromium in DEPS to 143.0.7447.0
* chore: bump chromium in DEPS to 143.0.7449.0
* chore: bump chromium in DEPS to 143.0.7451.0
* 7001364: Migrate GURL accessors to Get* variants in //content | https://chromium-review.googlesource.com/c/chromium/src/+/7001364
* 6986521: Implicit second value 'any' instead of 'span-all' for fallback query | https://chromium-review.googlesource.com/c/chromium/src/+/6986521
* chore: update chromium patches
* chore: update chromium patches
* chore: update patches
* fix: parse macOS SDK version across line break
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* fix: replace v8::Object::SetPrototype() usage
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
https://github.com/nodejs/node/pull/55453
* fix: regenerate filenames.libcxx.gni
https://chromium-review.googlesource.com/c/chromium/src/+/6980307
* fix: replace additional usages of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* build: use macos 15 minimum
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* ci: ignore missing dir for strip_universal_deep
* fix: js2c compilation failure
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
See patch description explaining MacOS 26 SDK headers incompatibility.
* fixup! chore: export patches
* feat: add new memory-eviction exit reason
https://chromium-review.googlesource.com/c/chromium/src/+/6991933
* fix: set JSON reader parsing options
https://chromium-review.googlesource.com/c/chromium/src/+/6992114
* fix: provide DeviceEmulationCacheBehavior param
https://chromium-review.googlesource.com/c/chromium/src/+/6965238
* fix: views::NonClientFrameView -> views::FrameView
https://chromium-review.googlesource.com/c/chromium/src/+/7005027
https://chromium-review.googlesource.com/c/chromium/src/+/6966937
* fix: check new forced colors enum value
https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fix: migrate NetworkConditions -> MatchedNetworkConditions
https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fix: migrate GURL string methods to Get*()
https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: disable C++ modules in electron_lib builds
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
* fix: partially revert is_headless_mode removal
https://chromium-review.googlesource.com/c/chromium/src/+/6955633
This patch should likely be reworked. For now, this partially reverts the
removal of a required class property to restore behavior.
* Revert "build: use macos 15 minimum"
This reverts commit 2fc12d6acc .
Initially this change was made to test if it fixes libcxx
compilation issues. As that's now resolved by disabling libcxx
modules, this can be reverted.
* fix: disable C++ modules in libnode builds
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* build: switch to macos-15 runner
build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The
macos 15 runners default to an Xcode using the 15 SDK and removes older
versions.
* fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: use std::u16string for Extension::Create() error parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6975452
* fix: add missing image_skia include
https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fix: remove outdated V8 flag
https://chromium-review.googlesource.com/c/v8/v8/+/6948286
* fix: disable protocol handler DCHECK
https://chromium-review.googlesource.com/c/chromium/src/+/6727594
Ignore the extension custom protocol handler registry DCHECK until
we invest in supporting it. Replacing this DCHECK seems harmless
and will unblock the roll.
* fix: replace deprecated usage of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* chore: remove patch already included in roll
* chore: remove extraneous formatting added to patch
* chore: remove fix_harden_blink_scriptstate_maybefrom.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
No longer needed since the above CL landed.
* 6973697: Use type tags for data stored in V8 internal fields
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* chore: update patches
* fixup! chore: export patches
* chore: restore electron embedder data tag patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-13 12:21:54 -04:00
dependabot[bot]
d82b8f3b80
build(deps): bump github/codeql-action from 3.30.5 to 3.30.6 ( #48478 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.30.5 to 3.30.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](3599b3baa1...64d10c1313 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-13 16:02:16 +02:00
Samuel Attard
52929c93db
build: fail publish when upload fatal errors ( #48537 )
...
We logged a fatal error but didn't exit with code 1 so the publish kept going. This was caught by a sanity check later down the release process but would have been quicker to fail out here.
Also adds some code to maybe workaround the underlying auth error
2025-10-13 12:53:52 +02:00
Shelley Vohr
dd25a6361b
fix: auth required websocket crash ( #48510 )
2025-10-13 10:13:32 +02:00
Zuohui Yang
16b5776b01
fix: launch crash when null device is disabled on Windows ( #47870 )
...
fix: fix launch crash when null device is disabled on Windows
add node flag node::ProcessInitializationFlags::kNoStdioInitialization
Co-authored-by: yangzuohui <yangzuohui@bytedance.com >
Co-authored-by: yangliu <yangliu.leo@bytedance.com >
2025-10-11 18:00:04 -04:00
David Sanders
cbf5c3331f
ci: fix release branch name in build stats script ( #48533 )
2025-10-10 22:28:09 -07:00
David Sanders
3359f90389
ci: upload build effective cache hit rate stats to Datadog ( #48509 )
2025-10-10 19:55:21 -07:00
Erick Zhao
cf9fa5ef65
docs: unmark asar integrity as experimental and clean docs ( #48434 )
2025-10-10 12:56:48 -07:00
Niklas Wenzel
550e054168
docs: update Azure Trusted Signing availability ( #48494 )
...
* docs: update Azure Trusted Signing availability
Source: https://github.com/Azure/trusted-signing-action/issues/93#issuecomment-3383517386
* docs: remove unused link
2025-10-10 11:43:29 -04:00
Shelley Vohr
b992ead837
fix: dialog.showMessageBox defaultid on Windows ( #48216 )
...
* fix: dialog.showMessageBox defaultid on Windows
* Update shell/browser/ui/message_box_win.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-10-10 15:39:23 +02:00
Shelley Vohr
11f76118db
fix: unexpected openExternal dialog on macOS Tahoe ( #48502 )
...
fix: unexpected openExternal dialog on macOS Tahoe
2025-10-10 12:48:44 +02:00
Robo
37c7487600
fix: crash when inspector evaluates on provisional frames ( #48503 )
2025-10-10 11:34:09 +02:00
reito
9e46efb8f7
feat: offscreen rendering support rgbaf16 hdr output format. ( #48265 )
...
* feat: offscreen rendering support rgbaf16
* docs: update doc
* docs: update doc.
2025-10-09 10:33:34 +02:00
dependabot[bot]
9c38917a14
build(deps): bump actions/github-script from 7.0.1 to 8.0.0 ( #48329 )
...
Bumps [actions/github-script](https://github.com/actions/github-script ) from 7.0.1 to 8.0.0.
- [Release notes](https://github.com/actions/github-script/releases )
- [Commits](60a0d83039...ed597411d8 )
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 8.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-09 10:33:24 +02:00
zoy
3a53c71324
fix: broken transparent window styles on resizable change ( #48378 )
...
* fix: wrong api call
* fix: consistency of the resize state
* fix: edge cases
* chore: add detailed comments
* fix: lint
* chore: only windows
* chore: use transparent
2025-10-09 09:49:20 +02:00
David Sanders
0d478ec69c
ci: ignore lost communication with server annotation in audit ( #48493 )
2025-10-09 09:48:56 +02:00
Erick Zhao
9143f7c6e2
docs: clarify postinstall requirements ( #48485 )
...
postinstall
2025-10-09 09:48:47 +02:00
Erick Zhao
df86312e2f
docs: add note for node_modules for Yarn and pnpm ( #48484 )
...
* Add instructions on using node_modules with Yarn
* update text for pnpm
---------
Co-authored-by: CodingOtto <otto+github@fysiker.fi >
2025-10-09 09:48:22 +02:00
Ulises Gascón
ffbae02a95
docs: add security escalation policy ( #48317 )
2025-10-08 15:19:07 -07:00
Sam Maddock
a87ee21f5c
build: bump version in .nvmrc to 22 ( #48413 )
2025-10-08 14:21:55 -04:00
electron-roller[bot]
ea8f43f9b9
chore: bump node to v22.20.0 (main) ( #48383 )
...
* chore: bump node in DEPS to v22.20.0
* chore: fixup patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-08 15:19:08 +02:00
Fedor Indutny
e8e91c331a
feat: dynamic ESM import in preload without context isolation ( #48375 )
...
Dynamic ESM import in non-context-isolated preload
Extend `HostImportModuleWithPhaseDynamically`'s routing to support
Node.js import resolution in non-context-isolated preloads through
`v8_host_defined_options` length check. The length of host defined
options is distinct between Blink and Node.js and we can use it to
determine which resolver to use.
2025-10-08 10:44:09 +02:00
Charles Kerr
49c1139ab9
chore: remove unused reference to api::BrowserView ( #48474 )
...
chore: remove unused reference to api::BrowserView
Unused since #35658 / 15c60143
2025-10-08 10:43:28 +02:00
dependabot[bot]
16bcd645b5
build(deps): bump actions/stale from 9.1.0 to 10.1.0 ( #48477 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.1.0 to 10.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](5bef64f19d...5f858e3efb )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-version: 10.1.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-10-08 09:56:23 +02:00
John Kleinschmidt
6756974828
build: fixup chromedriver and mksnapshot ( #48470 )
...
* build: update build tools to get proper exit codes from e build
xref: https://github.com/electron/build-tools/pull/759
* build: target zips directly
mksnapshot and chromedriver have issues with siso trying to run a separate build and zip step, so just target the zip target
* build: don't unzip chromedriver and mksnapshot in tests
The contents of these files are not used in testing, so we shouldn't unzip them.
2025-10-06 23:22:55 -04:00
Keeley Hammond
d6dfd4ed7a
build: handle Metal toolchain being unbundled from Xcode 26 ( #48467 )
...
* chore: add metal patch dir
* chore: cherry-pick 2f564f1ca07b from angle (#48465 )
* chore: update patch
2025-10-06 10:17:46 -04:00
Charles Kerr
a1ca9a8d55
refactor: DRY in App::SetAppLogPath() ( #48452 )
2025-10-05 12:32:28 -05:00
Charles Kerr
38e491689a
perf: avoid a little extra work in InvokeIpcCallback() ( #48456 )
...
perf: two minor perf refactors in InvokeIpcCallback()
1. Allocate the CallbackScope on the stack instead of the heap
2. Skip a redundant call to node::Environment::GetCurrent()
2025-10-04 21:52:53 -07:00
Niklas Wenzel
6e2be00f0f
docs: recommend calling renderer process modules from preload script ( #48427 )
2025-10-04 18:44:10 +02:00
Charles Kerr
497b5a68a4
docs: clarify optional args in webFrame.executeJavaScript() ( #48447 )
2025-10-04 09:28:06 -05:00
Kaiichiro Ota
715808ecbe
docs: mention that webUtils should be used via preload script ( #45861 )
...
* docs: mention that webUtils should be used via preload script
* docs: suppress lint errors
* docs: clarify webUtils usage scope
* docs: exclude potentially dangerous alert() in the example code
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: make linter happy
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: apply suggestion
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* docs: minor change
* docs: minor change
* docs: remove preload line
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2025-10-03 13:07:38 -07:00
Charles Kerr
01cab978f7
refactor: remove gin_helper::Arguments ( #48374 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in StopRecording()
* refactor: use gin::Arguments in ImageView::New()
* refactor: use gin::Arguments in AppendSwitch()
* refactor: use gin::Arguments WebContentsView::New()
* refactor: make gin::Arguments arg const in WrappableBase::InitWithArgs()
This makes explicit that we are using it for wrapper + isolate, not the args values
* refactor: remove gin_helper::Arguments arg from ExposeAPI()
refactor: remove gin_helper::Arguments arg from ExposeAPIInWorld()
* refactor: remove gin_helper::Arguments arg from ElectronBindings::GetSystemMemoryInfo()
* refactor: remove gin_helper::Arguments arg from preload_utils::GetBinding()
* refactor: use gin::Arguments in OpenExternal()
* refactor: use gin::Arguments in ExecuteInWorld()
* refactor: use gin::Arguments in ExecuteJavaScript()
* refactor: use gin::Arguments in InvokeNew()
* refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
* refactor: remove unused GetNextArgument() marshaller for gin_helper::Arguments
* refactor: remove unused #include gin_helper/arguments.h
* chore: remove unused gin_helper::Arguments
* fixup! refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()
Xref: https://github.com/electron/electron/pull/48447
2025-10-03 14:10:29 -05:00
zoy
7cb1552614
fix: accentColor set distinguishes the frame ( #48405 )
...
* fix: accentColor set distinguishes the frame
* chore: invalid change
* fix: lint
2025-10-03 20:10:18 +02:00
Niklas Wenzel
49c37b4daa
docs: update allowed window.open options ( #48428 )
2025-10-03 01:29:26 +02:00
Robo
37a115b8fd
fix: initialze featurelist before parsing features ( #48411 )
2025-10-03 01:18:14 +02:00
Shelley Vohr
e7e29ea876
fix: snapped window restoring to correct position ( #48296 )
2025-10-02 18:14:48 +02:00
Erick Zhao
b40a4befd4
docs: fix formatting in asar integrity ( #48431 )
2025-10-01 22:27:28 -07:00
dependabot[bot]
61a7303531
build(deps): bump github/codeql-action from 3.30.1 to 3.30.5 ( #48420 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.30.1 to 3.30.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f1f6e5f6af...3599b3baa1 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-30 18:36:57 +02:00
Fedor Indutny
6f9cd718c4
fix: runtime JS error that crashes GetPackageJSON ( #48293 )
...
We overriden the `GetPackageJSON` in Node.js to let us read files
straight from the ASAR file instead of disk. The override works by
providing a JS method with the limitation that it should not throw a
runtime error. However, this invariant was accidentally violated by
`asar.splitPath` that sometimes contrary to its' TypeScript definition
returned `false`.
2025-09-30 18:32:13 +02:00
Samuel Attard
a95180e080
build: add missing copied tarball to cloudstore paths ( #48408 )
...
It's guarunteed that `iojs-*` and `node-*` were the same origin file (we azcopy them) but this was missing in logs and it annoyed me
2025-09-29 11:16:39 -07:00
BILL SHEN
d4a5fdc8fc
fix: add missed enum SaveRequestType to PdfViewerPrivate function ( #48372 )
...
fix: add missed SaveRequestType enum to PdfViewerPrivate function
2025-09-26 16:34:06 -04:00
avarayr
3a7c6dd4a5
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load ( #48376 )
...
fix: macOS stop overriding private cornerMask API to fix WindowServer GPU load spike
Electron fetched a custom `_cornerMask` for `ElectronNSWindow` to smooth
vibrancy corners. On macOS 15 (Tahoe) that private hook forces the window
shadow to be rendered from a fully transparent surface, causing the
WindowServer GPU load regression. Remove the `cornerMask` property and
the `_cornerMask` override so we stay on Apple’s default shadow path.
2025-09-26 12:41:16 -07:00
Robo
26e886c517
fix: disable NSAutoFillHeuristicController on macOS 26 ( #48379 )
...
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-09-26 08:40:55 +09:00
Charles Kerr
26a473db98
refactor: make api::Menu inherit from gin::Wrappable ( #48351 )
...
* refactor: make api::Menu inherit from gin::Wrappable*
* refactor: make api::Menu::kWrapperInfo const
* refactor: use three-arg version of GetConstructor in Menu
refactor: undo branch changes to two-arg version of GetConstructor
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
fix: return type of Menu::New
* fixup! refactor: make api::Menu inherit from gin::Wrappable*
make MenuMac's constructor public so that cppgc can use it
* refactor: Pinnable -> SelfKeepAlive
2025-09-24 19:42:22 -05:00
Charles Kerr
6661457cdf
refactor: prefer upstream gin::Arguments::ThrowTypeError() over gin_helper ( #48368 )
...
* refactor: use gin::Arguments::ThrowTypeError() in AutoUpdater::SetFeedURL()
* refactor: use gin::Arguments::ThrowTypeError() in Browser::Focus()
* refactor: use gin::Arguments::ThrowTypeError() in SystemPreferences::SetUserDefault()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::Create()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::PostMessage()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBundleMover::ShouldContinueMove()
* refactor: use gin::Arguments::ThrowTypeError() in OnClientCertificateSelected()
* refactor: use gin::Arguments::ThrowTypeError() in Session::ClearData()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBrowserContext::DisplayMediaDeviceChosen()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::ReplaceMisspelling()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::Print()
* chore: iwyu shell/common/gin_helper/error_thrower.h
2025-09-24 19:10:05 -05:00
John Kleinschmidt
b51e82c5fb
test: rerun failed tests individually ( #48205 )
...
* test: rerun failed tests individually
* ci: use screencapture-nag-remover
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
* Revert "chore: test with 1st quadrant of the window"
No longer needed because of the addition of the
screencapture-nag-remover script.
This reverts commit f4a7e04c0b .
* test: fixup navigationHistory flake
* rerun test up to 3 times
2025-09-24 13:35:14 -07:00
Charles Kerr
235fdc41f6
refactor: use gin::Arguments in BaseWindow ( #48355 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in BaseWindow::MoveAbove()
refactor: use gin::Arguments in BaseWindow::SetAlwaysOnTop()
refactor: use gin::Arguments in BaseWindow::SetIgnoreMouseEvent()
* refactor: use gin::Arguments in BaseWindow::SetProgresBar()
* refactor: use gin::Arguments in BaseWindow::SetVisibleOnAllWorkspaces()
* refactor: use gin::Arguments in BaseWindow::SetVibrancy()
* refactor: use gin::Arguments in BaseWindow::SetAspectRatio()
* refactor: use gin::Arguments in BaseWindow::PreviewFile()
* refactor: use gin::Arguments in BaseWindow::SetThumbarButtons()
* refactor: use gin::Arguments in BaseWindow::SetBounds()
* refactor: use gin::Arguments in BaseWindow::SetContentBounds()
* refactor: use gin::Arguments in BaseWindow::SetSize()
* refactor: use gin::Arguments in BaseWindow::SetContentSize()
* refactor: use gin::Arguments in BaseWindow::SetSheetOffset()
* refactor: use gin::Arguments in BaseWindow::SetPosition()
* refactor: use gin::Arguments in BaseWindow::AddTabbedWindow()
* refactor: use gin::Arguments in BaseWindow::SetParentWindow()
* refactor: use gin::Arguments in BaseWindow::BaseWindow()
* refactor: use gin::Arguments in BaseWindow::SetAccentColor()
* refactor: use gin::Arguments in BaseWindow::SetTitleBarOverlay()
2025-09-24 09:39:16 -04:00
Charles Kerr
6bbbc1232e
chore: remove unused, undocumented, untested executionMode arg from web_frame.executeJavaScriptInIsolatedWorld() ( #48361 )
...
chore: remove unused, undocumented execution mode arg from web_frame.executeJavaScriptInIsolatedWorld()
2025-09-24 08:13:49 -05:00
Niklas Wenzel
49335805d5
docs: mention setContentProtection macOS limitations ( #48290 )
2025-09-23 16:28:21 -05:00
John Kleinschmidt
b27e721f69
build: update patches ( #48364 )
...
chore: update patches
2025-09-23 16:37:38 -04:00
electron-roller[bot]
1fda08b8c8
chore: bump chromium to 142.0.7417.0 (main) ( #48275 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
* chore: fixup patch indices
* chore: bump chromium in DEPS to 142.0.7402.0
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
* chore: fixup patch indices
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
* chore: fix patch
* chore: bump chromium in DEPS to 142.0.7403.0
* build: remove ninja logs
* chore: fixup patch indices
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
* build: don't kill blink/web_tests
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
* chore: bump chromium in DEPS to 142.0.7405.0
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
* chore: fixup patch indices
* fix: Protocol complex inline dtor
* chore: bump chromium in DEPS to 142.0.7407.0
* chore: bump chromium in DEPS to 142.0.7409.0
* chore: bump chromium in DEPS to 142.0.7411.0
* chore: bump chromium in DEPS to 142.0.7413.0
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* chore: fixup patch indices
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
* chore: bump chromium in DEPS to 142.0.7415.0
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
* chore: update patches
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
* fixup for lint
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 142.0.7417.0
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
* chore: update patches
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* Revert "build: remove ninja logs"
This reverts commit 72874740fd .
* test: fix flakey test picked from PR 48205
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-09-22 20:16:27 -07:00
Charles Kerr
19256a07dd
refactor: use gin::Arguments in api::Clipboard ( #48354 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBuffer()
* refactor: remove unused gin_helper::Arguments* arg from Clipboard::ReadBookmark()
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in api::Clipboard
2025-09-23 04:12:47 +09:00
John Kleinschmidt
f62d7254c4
build: update build tools to get siso for forks fix ( #48345 )
2025-09-18 00:04:09 -04:00
Keeley Hammond
c7aa0b537d
chore: cherry-pick ec6c18478382 from v8 ( #48335 )
...
* chore: cherry-pick ec6c18478382 from v8
* chore: update patches
2025-09-16 19:08:15 -07:00
Robo
048d620701
fix: remove unneeded handlescope from JS callbacks ( #48318 )
...
fix: remove handlescope from JS callbacks
2025-09-16 06:56:38 +09:00
Charles Kerr
15cdae1cf0
refactor: make api::NetLog inherit from gin::Wrappable ( #48308 )
...
* refactor: remove unused v8::Isolate* arg from NetLog ctor
* refactor: allocate api::NetLog on cpp heap
* refactor: make electron::api::Session::net_log_ a cppgc::Member<api::NetLog>
* refactor: remove unnecessary EscapableHandleScope
* chore: code style consistency
2025-09-16 06:29:46 +09:00
Shelley Vohr
bac383c219
feat: add fileSystem to ses.setPermissionCheckHandler ( #48170 )
...
feat: add fileSystem to ses.setPermissionCheckHandler
2025-09-15 17:00:58 -04:00
John Kleinschmidt
49eb165ef9
ci: Use Local Execution, Remote Caching (LERC) for fork PRS ( #48319 )
...
cleanup
2025-09-15 16:31:49 -04:00
Charles Kerr
a468ed7f10
refactor: narrow or remove gin arguments ( #48300 )
...
* refactor: narrow App:SetJumpList() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow WebContents::AddWorkSpace() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowMessageBox() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowOpenDialog() arg from gin::Arguments* to v8::Isolate*
* refactor: remove unused gin::Arguments* arg from OverrideGlobalPropertyFromIsolatedWorld()
* refactor: narrow WebContents::StartDrag() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow NetLog::StopLogging() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow Protocol::IsProtocolHandled() arg from gin::Arguments* to v8::Isolate*
2025-09-13 08:19:07 +09:00
Calvin
5444738721
fix: set ozone platform for wayland ( #48301 )
...
* fix: set ozone platform for wayland
* whoops, includes. thx charles
2025-09-13 08:17:06 +09:00
Charles Kerr
a6959ca97b
refactor: allocate api::Debugger on cpp heap ( #48266 )
...
* refactor: remove unused isolate arg from Debugger ctor
* refactor: make Debugger ctor, dtor public
needed for cppgc::MakeGarbageCollected()
This is what upstream does, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/6722236
* fixup! refactor: remove unused isolate arg from Debugger ctor
mark Debugger ctor as explicit
* refactor: in EventEmitterMixin, handle both old and new WrapperInfo types
* refactor: make electron::api::Debugger inherit from gin::Wrappable
* refactor: add api::Debugger::GetTypeName()
* refactor: add api::Debugger::GetClassName()
2025-09-11 16:03:17 -04:00
dependabot[bot]
45353ae38c
build(deps): bump actions/setup-node from 4.4.0 to 5.0.0 ( #48282 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.4.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](49933ea528...a0853c2454 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-10 21:35:54 -05:00
Charles Kerr
f702327dce
refactor: avoid unused inheritance in ServiceWorkerMain ( #48279 )
...
ServiceWorkerMain does not need to inherit from EventEmitterMixin
2025-09-10 11:16:35 -05:00
dependabot[bot]
fda3a3d493
build(deps): bump github/codeql-action from 3.29.11 to 3.30.1 ( #48283 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.11 to 3.30.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](3c3833e0f8...f1f6e5f6af )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-10 09:47:34 -05:00
Michaela Laurencin
dae5dad167
docs: update release timeline for unsupported v35 ( #48285 )
2025-09-09 15:03:48 -07:00
John Kleinschmidt
940ebb6c7a
chore: update patches ( #48278 )
2025-09-08 15:44:47 -04:00
electron-roller[bot]
793565e4be
chore: bump chromium to 141.0.7390.7 (main) ( #48212 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7382.0
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7384.0
* chore: bump chromium in DEPS to 141.0.7386.0
* [Extensions] Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
* chore: update patches
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update patches
* [FSA] Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
* chore: IWYU
* [DevToolsUIBindings] Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
* chore: IWYU
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update filenames.libcxx.gni
* chore: IWYU
* fixup: chore: IWYU
* fixup: Reland "[exit-time-destructors] Enable by default
* fixup: Reland "[exit-time-destructors] Enable by default
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
* fixup: Reland "[exit-time-destructors] Enable by default
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
* chore: bump chromium in DEPS to 141.0.7390.7
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
* fixup: Move "system integrated UI" concept out of NativeTheme.
* fixup: Reland "[exit-time-destructors] Enable by default
* chore: update patches
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* fixup: 6906096: Remove GetSysSkColor()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-09-08 12:57:15 +02:00
electron-roller[bot]
1f322ebce3
chore: bump node to v22.19.0 (main) ( #48222 )
...
* chore: bump node in DEPS to v22.19.0
* chore: fixup patch indices
* crypto: add tls.setDefaultCACertificates()
https://github.com/nodejs/node/pull/58822
* esm: js-string Wasm builtins in ESM Integration
https://github.com/nodejs/node/pull/59179
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-09-05 17:16:45 -04:00
Samuel Attard
f009e077f2
build: update spec deps for clean audit ( #48238 )
2025-09-03 15:05:49 -04:00
Calvin
fed73040e2
docs: move some planned breaking changes to 39 ( #48236 )
2025-09-01 14:55:11 -07:00
Shelley Vohr
828fd59a72
fix: file-only picker incorrectly allowing some directories ( #48198 )
2025-08-29 13:14:45 -04:00
Shelley Vohr
e892840975
fix: ensure dragging works again after emitting contextmenu event ( #48199 )
2025-08-29 10:37:37 -04:00
Shelley Vohr
7373173e44
fix: showMessageDialog should center dialog to parent ( #48181 )
2025-08-29 09:56:51 +02:00
electron-roller[bot]
5d5e672f17
chore: bump chromium to 141.0.7361.0 (main) ( #48054 )
...
* chore: bump chromium in DEPS to 141.0.7352.0
* chore: update patches
* 6830573: Revert 'Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable' | https://chromium-review.googlesource.com/c/chromium/src/+/6830573
* chore: bump chromium in DEPS to 141.0.7354.0
* chore: bump chromium in DEPS to 141.0.7356.0
* chore: bump chromium in DEPS to 141.0.7357.0
* chore: bump chromium in DEPS to 141.0.7359.0
* chore: bump chromium in DEPS to 141.0.7361.0
* 6838518: [Mac] Correctly deallocate sandbox error buffers and prevent crash resulting from nullptr assignment | https://chromium-review.googlesource.com/c/chromium/src/+/6838518
* 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* chore: update patches
* fixup! 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* fixup! 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* fix: unsafe buffer warning in fix_properly_honor_printing_page_ranges.patch
* fix: FTBFS in src_remove_dependency_on_wrapper-descriptor-based_cppheap.patch
This change should be upstreamed.
Fixes this error:
../../third_party/electron_node/src/env.cc:606:3: error: no matching function for call to 'Wrap'
606 | v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1076:14: note: candidate function template not viable: cannot convert argument of incomplete type 'void *' to 'v8::Object::Wrappable *' for 3rd argument
1076 | void Object::Wrap(v8::Isolate* isolate, const v8::Local<v8::Object>& wrapper,
| ^
1077 | v8::Object::Wrappable* wrappable) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1084:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const PersistentBase<Object>' for 2nd argument
1084 | void Object::Wrap(v8::Isolate* isolate, const PersistentBase<Object>& wrapper,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1093:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const BasicTracedReference<Object>' for 2nd argument
1093 | void Object::Wrap(v8::Isolate* isolate,
| ^
1094 | const BasicTracedReference<Object>& wrapper,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
* [v8-init] Access crash key only from main thread | https://chromium-review.googlesource.com/c/chromium/src/+/6827167
* chore: e patches all
* chore: remove chore_restore_some_deprecated_wrapper_utility_in_gin.patch from patches
this remove line got re-added when rebasing roller/chromium/main
* chore: e patches all
* fix: include base/time/time.h when using base::Time
* chore: update patches
* Make --host-rules an alias for --host-resolver-rules.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4867872
* ci: update BUILD_TOOLS_SHA
Refs https://github.com/electron/build-tools/pull/746
* [Fontations] Remove Fontations suffix from font names
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6835930
* temp: debug macOS addon build failure
* Revert "temp: debug macOS addon build failure"
This reverts commit 40bc8abab65dc83e17c4ab97cb6e7522a193fb44.
* test: run tests with Xcode 16.4
* ci: fix tccdb update for macOS 15
* spec: disable opening external application for loadURL
on macOS opening unknown external application will bring
up dialog to choose apps from application store which will
break our other test suites that want to capture screen
for pixel matching.
The loadURL spec that tests bad-scheme://foo is sufficient
that we hit the permission handler for openExternal since
at that point we already know the runtime gave up on handling
the scheme.
* chore: rebase patches
* chore: disable codesiging tests
* ci: update ScreenCaptureApprovals.plist for /bin/bash
* ci: try updating tcc permissions
* ci: update TCC permissions
Refs https://www.rainforestqa.com/blog/macos-tcc-db-deep-dive
* chore: test with 1st quadrant of the window
* chore: adjust for macOS 15 menubar height
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-08-29 12:31:47 +09:00
LZL
e39943bf45
fix: BrowserWindow add the same BrowserView ( #48053 )
...
fix: BrowserWindow add the same BrowserView (#48057 )
2025-08-28 10:31:41 +02:00
David Sanders
f331606e07
build: bump NMV to 140 ( #48196 )
2025-08-27 18:57:00 -07:00
David Sanders
cca55117e4
build: refactor Linux binary stripping to align with upstream ( #47932 )
2025-08-27 18:56:31 -07:00
Erick Zhao
bf29d2f0bd
docs: fix some module headings ( #48177 )
2025-08-27 14:52:26 -07:00
John Kleinschmidt
fea1a2a987
ci: use free GH arm runners ( #47872 )
2025-08-27 10:01:36 -04:00
dependabot[bot]
a51c56aca9
build(deps): bump amannn/action-semantic-pull-request from 6.0.1 to 6.1.1 ( #48175 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 6.0.1 to 6.1.1.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](fdd4d3ddf6...48f256284b )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-version: 6.1.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:52:36 +02:00
dependabot[bot]
89f25e6af3
build(deps): bump github/codeql-action from 3.29.10 to 3.29.11 ( #48174 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.10 to 3.29.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](96f518a34f...3c3833e0f8 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.11
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:49:43 +02:00
Robo
e0db4046b2
refactor: allocate gin_helper::internal::Event on cpp heap ( #48161 )
2025-08-27 09:30:50 +09:00
Calvin
3b9130d815
docs: add release timeline for Electron 39 ( #48167 )
2025-08-26 14:19:56 -07:00
Shelley Vohr
52ed4646d9
chore: remove upstream OSR temp fix ( #48162 )
2025-08-26 16:22:45 -04:00
John Kleinschmidt
68098c317f
build: remove no longer needed arg for siso ( #48164 )
...
* build: remove no longer needed arg for siso
* chore: test ffmpeg zip
* build: fix ffmpeg build with siso
* Revert "chore: test ffmpeg zip"
This reverts commit 2bbcc86039 .
2025-08-25 16:46:36 -04:00
dependabot[bot]
52e0307cc1
build(deps): bump github/codeql-action from 3.29.7 to 3.29.10 ( #48113 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.7 to 3.29.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](51f77329af...96f518a34f )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.10
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-25 13:23:15 +02:00
dependabot[bot]
7fffe77909
build(deps-dev): bump stream-json and @types/stream-json ( #48114 )
...
Bumps [stream-json](https://github.com/uhop/stream-json ) and [@types/stream-json](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/stream-json ). These dependencies needed to be updated together.
Updates `stream-json` from 1.8.0 to 1.9.1
- [Commits](https://github.com/uhop/stream-json/compare/1.8.0...1.9.1 )
Updates `@types/stream-json` from 1.7.7 to 1.7.8
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/stream-json )
---
updated-dependencies:
- dependency-name: stream-json
dependency-version: 1.9.1
dependency-type: direct:development
update-type: version-update:semver-minor
- dependency-name: "@types/stream-json"
dependency-version: 1.7.8
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-25 12:58:38 +02:00
Robo
3ccb1bc0a8
refactor: allocate api::Session on cpp heap ( #48141 )
2025-08-25 18:52:06 +09:00
Shelley Vohr
0917ed5f6f
fix: snapped restoration after minimization ( #48142 )
2025-08-22 14:37:45 -04:00
Samuel Attard
a67aad0f50
build: use siso instead of reclient ( #47534 )
2025-08-22 14:17:02 -04:00
reito
ceb6d28fd3
fix: webContent.fromId should be number instead of string ( #48059 )
2025-08-22 11:40:10 -04:00
Shelley Vohr
e12ab6708e
chore: improve failed notification error messages on Windows ( #48131 )
2025-08-22 11:35:39 -04:00
Shelley Vohr
6101025368
fix: net.isOnline always true in utility processes ( #48111 )
...
* fix: net.isOnline always true in utilityProcesses
* Update shell/services/node/node_service.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-08-22 14:30:41 +02:00
dependabot[bot]
97b0280ad4
build(deps): bump amannn/action-semantic-pull-request from 5.5.3 to 6.0.1 ( #48115 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.3 to 6.0.1.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](0723387faa...fdd4d3ddf6 )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-21 10:44:27 +02:00
John Kleinschmidt
1044fe675d
build: use new 7z command line switch ( #48136 )
...
-snld20 replaces -snld
2025-08-20 17:05:25 -04:00
John Kleinschmidt
42af60cc7e
docs: update 38.0 breaking changes ( #48117 )
2025-08-20 14:15:01 -04:00
John Kleinschmidt
cadba11088
build: fixup docs only condition ( #48128 )
2025-08-20 12:58:54 -04:00
Shelley Vohr
8aeee3f714
refactor: use XmlWriter for Windows toasts ( #48065 )
...
refactor: use XmlWriter for Windows toasts
2025-08-20 16:06:51 +02:00
Robo
dd54e84a58
refactor: allocate api::App on cpp heap ( #48118 )
2025-08-20 20:35:08 +09:00
John Kleinschmidt
d4b7d9e9cf
build: get source cache for docs only pipeline ( #48120 )
2025-08-20 11:07:00 +02:00
BILL SHEN
83a5ba1e2c
feat: add fileBacked and purgeable fields to process.getSystemMemoryInfo() for macOS ( #47628 )
...
* fix: Optimize the value of memory.free in the return data of getSystemMemoryInfo().
* fix: Improve the value of memory in the return data of getSystemMemoryInfo().
* fix: complete API doc.
* Update docs/api/process.md
Co-authored-by: Will Anderson <will@itsananderson.com >
* fix: update name to fileBacked.
* fix: fix with code conflict
---------
Co-authored-by: Will Anderson <will@itsananderson.com >
2025-08-20 09:49:41 +02:00
Shelley Vohr
13d955a73e
fix: system accent color parsing hex order ( #48085 )
...
fix: system accent color parsing
2025-08-19 10:01:41 +02:00
Samuel Attard
fdf29ce838
fix: ensure snapshot is valid ( #48101 )
2025-08-18 14:35:58 -07:00
Samuel Attard
3770bb31a7
fix: avoid deprecated login item methods ( #48090 )
2025-08-17 22:00:52 -07:00
dependabot[bot]
ed4a99ba5b
build(deps-dev): bump @azure/storage-blob from 12.25.0 to 12.28.0 ( #48055 )
...
Bumps [@azure/storage-blob](https://github.com/Azure/azure-sdk-for-js ) from 12.25.0 to 12.28.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases )
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md )
- [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/storage-blob_12.25.0...@azure/storage-blob_12.28.0 )
---
updated-dependencies:
- dependency-name: "@azure/storage-blob"
dependency-version: 12.28.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-16 09:39:46 +02:00
Shelley Vohr
0e6c26096f
fix: shell.openPath should be non-blocking ( #48079 )
...
fix: shell.openPath should be non-blocking
2025-08-15 13:55:31 -07:00
Keeley Hammond
7792ed1efa
build: revert bump @octokit/rest from 20.1.2 to 22.0.0 ( #48082 )
...
Revert "build(deps-dev): bump @octokit/rest from 20.1.2 to 22.0.0 (#48014 )"
This reverts commit 13ed526ca7 .
2025-08-14 20:50:09 -07:00
Robo
c75c390ccf
chore: add uma results in macOS keychain patch ( #48080 )
2025-08-15 11:10:37 +09:00
Shelley Vohr
4c3c3049e1
build: disallow non-maintainer changes to GitHub Actions workflows ( #48038 )
2025-08-14 13:54:05 -07:00
Shelley Vohr
68e7b38c05
build: use quick tunnels for ssh debugging ( #47938 )
...
* build: use dynamic local tunnels for ssh debugging
* weeee
* that'll do
* chore: pretty output
* build: allow ssh input
---------
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2025-08-14 07:41:07 -04:00
dependabot[bot]
a051c7c274
build(deps): bump actions/download-artifact from 4.3.0 to 5.0.0 ( #48052 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.3.0 to 5.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](d3f86a106a...634f93cb29 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-13 14:33:48 +02:00
Shelley Vohr
53003d7af9
fix: app.accessibilitySupportEnabled ( #48041 )
...
fix: app.accessibilitySupportEnabled on macOS
2025-08-12 16:51:27 -04:00
David Sanders
63d7f609cd
ci: manually fetch author_association in workflow automations ( #48013 )
2025-08-12 10:30:41 -07:00
electron-roller[bot]
01291623af
chore: bump chromium to 141.0.7350.0 (main) ( #48032 )
...
* chore: bump chromium in DEPS to 141.0.7349.0
* chore: bump chromium in DEPS to 141.0.7350.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-08-12 11:31:17 +02:00
dependabot[bot]
13ed526ca7
build(deps-dev): bump @octokit/rest from 20.1.2 to 22.0.0 ( #48014 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.2 to 22.0.0.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.2...v22.0.0 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 22.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-12 11:18:08 +02:00
Shelley Vohr
afb0ee418c
fix: re-entrancy issues in webContents.loadURL() ( #48004 )
...
fix: re-entrancy issues in webContents.loadURL()
2025-08-11 11:20:35 -04:00
electron-roller[bot]
55d8b71d72
chore: bump chromium to 141.0.7346.0 (main) ( #47983 )
...
* chore: bump chromium in DEPS to 141.0.7341.0
* chore: bump chromium in DEPS to 141.0.7342.0
* chore: update patches
manually resolved conflict in `osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch` due to https://crrev.com/c/6681354
* 6819541: WebShare: Improve mac share behavior when sharing a URL
https://chromium-review.googlesource.com/c/chromium/src/+/6819541
* Add missing include for SkBitmap
Couldn't quickly find where we lost the full definition in this file's includes. 🤷
* 6771055: [SxS] Move devtools to ContentsContainerView supporting side-by-side.
https://chromium-review.googlesource.com/c/chromium/src/+/6771055
There may be some simplification possible here (set_x, Rect position, ...), but this change is satisfactory to maintain the current behavior.
* 6813689: Switch SystemMemoryInfoKB to use ByteCount
https://chromium-review.googlesource.com/c/chromium/src/+/6813689
* 6818486: Track DevTools feature usage in new badge tracker
https://chromium-review.googlesource.com/c/chromium/src/+/6818486
* chore: bump chromium in DEPS to 141.0.7344.0
* Remove ELECTRON_OZONE_PLATFORM_HINT env var
6819616: Remove OzonePlatformHint | https://chromium-review.googlesource.com/c/chromium/src/+/6819616
See: https://github.com/electron/electron/issues/48001
* chore: update patches
* Add missing include for `base::NumberToString`
* Remove `DESKTOP_STARTUP_ID` code
This was removed upstream in https://chromium-review.googlesource.com/c/chromium/src/+/6819616 and I confirmed with the author that it was an intentional change. Going to mirror upstream and remove it here too.
* chore: bump chromium in DEPS to 141.0.7346.0
* chore: update patches
* 6828465: Reland "Remove BluezDBusThreadManager"
https://chromium-review.googlesource.com/c/chromium/src/+/6828465
* Patch change to Node.js test output
V8 enhanced the stack trace of "thenable" async tasks. A couple of Node.js tests needed to have their snapshots updates to accomodate the extra stack trace frames in the output.
This patch should be upstreamed to Node.js.
See:
6826001: fix thenable async stack trace
https://chromium-review.googlesource.com/c/v8/v8/+/6826001
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2025-08-11 12:57:31 +09:00
Calvin
b9ceaabb85
docs: deprecate ELECTRON_OZONE_PLATFORM_HINT env var ( #48002 )
2025-08-10 21:49:23 +02:00
David Sanders
d6c0691a63
fix: importing from electron/utility in ESM ( #47998 )
2025-08-09 09:47:47 +02:00
David Sanders
a201d6c541
build: drop @types/webpack-env in favor of webpack/module types ( #47798 )
...
* build: drop @types/webpack-env in favor of webpack/module types
* chore: improve type when assigning to global.require
2025-08-08 18:09:23 -07:00
John Kleinschmidt
51add3e847
ci: cleanup use new arc cluster ( #47916 )
2025-08-08 09:26:10 -04:00
reito
9dcdec5015
feat: paint event move texture data to handle, add colorSpace ( #47315 )
...
* feat: paint event move shared texture to handle, add color space
* feat: add breaking change
* fix: properties.
* fix: remove utf8 bom
2025-08-08 10:13:56 +02:00
reito
095e622a6a
feat: context bridge support VideoFrame ( #47316 )
...
* feat: context bridge support VideoFrame
* docs: add VideoFrame to docs
2025-08-07 16:41:49 -04:00
Shelley Vohr
a0d983e4b5
feat: allow macOS tray to maintain position ( #47838 )
...
* feat: allow macOS tray to maintain position
* refactor: just use guid
* test: fixup tests
* docs: clarify UUID format
2025-08-07 19:25:50 +02:00
wujinli
f49a645c06
fix: compilation error when disabling extensions and pdf_viewer ( #47964 )
2025-08-07 11:18:32 -04:00
John Kleinschmidt
8ab5ac9069
ci: fixup mac runner hang ( #47982 )
2025-08-07 10:52:26 +02:00
Will Anderson
27a8cc531b
chore: Remove redundant IS_WIN check inside electron_main_win.cc ( #47967 )
2025-08-07 09:54:13 +02:00
David Sanders
26ffc8505c
fix: allow importing from electron/utility at runtime ( #47968 )
2025-08-07 09:53:42 +02:00
electron-roller[bot]
3b0f35a7e8
chore: bump chromium to 140.0.7339.2 (main) ( #47929 )
...
* chore: bump chromium in DEPS to 140.0.7330.0
* chore: bump chromium in DEPS to 140.0.7331.0
* chore: update patches
* fix: gn check failing on crashpad.h
Not yet sure what caused this
* fix: predictors::PreconnectManager -> content::PreconnectManager
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473
* chore: bump chromium in DEPS to 140.0.7333.0
* chore: bump chromium in DEPS to 140.0.7335.0
* chore: bump chromium in DEPS to 140.0.7337.0
* chore: update patches
* chore: restore some gin utility
* 6804057: [Extensions] Validate nodoc is specified as a boolean in schemas
https://chromium-review.googlesource.com/c/chromium/src/+/6804057
* fixup! chore: restore some gin utility
* fixup! fix: predictors::PreconnectManager -> content::PreconnectManager CL: https://chromium-review.googlesource.com/c/chromium/src/+/6788473
* 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected
https://chromium-review.googlesource.com/c/chromium/src/+/6772346
Not certain about what the "correct" argument to pass here is. A quick dive into the CL suggests that passing `false` is safe to keep things working. The blast radius if this assumption is wrong is that "fling" scroll gestures may not work as expected with the OSR.
* 6789383: Uninstall SODA language pack after 30 days of inactivity
https://chromium-review.googlesource.com/c/chromium/src/+/6789383
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 140.0.7339.0
* chore: update patches
* fixup! 6772346: Reset MouseWheelPhaseHandler state when trackpoint scroll is detected https://chromium-review.googlesource.com/c/chromium/src/+/6772346
* chore: bump chromium in DEPS to 140.0.7339.2
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-08-06 20:14:23 -04:00
David Sanders
8769d5ba9e
build: check zip manifest for chromedriver.zip ( #47972 )
2025-08-06 20:04:19 -04:00
dependabot[bot]
7f8b7c3873
build(deps-dev): bump @electron/lint-roller from 3.1.1 to 3.1.2 ( #47963 )
...
Bumps [@electron/lint-roller](https://github.com/electron/lint-roller ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/electron/lint-roller/releases )
- [Changelog](https://github.com/electron/lint-roller/blob/main/.releaserc.json )
- [Commits](https://github.com/electron/lint-roller/compare/v3.1.1...v3.1.2 )
---
updated-dependencies:
- dependency-name: "@electron/lint-roller"
dependency-version: 3.1.2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-06 11:21:55 +02:00
David Sanders
8bf4260e3e
test: add TS smoke test for electron/utility ( #47969 )
2025-08-06 10:30:39 +02:00
Charles Kerr
7a13c6f175
refactor: avoid deprecated v8::Context::GetIsolate() pt 4 ( #47961 )
...
* refactor: remove GetIsolate() calls from SetPrivate()
* refactor: remove excess GetIsolate() calls in PassValueToOtherContextInner()
* refactor: remove GetIsolate() calls from GetPrivate()
* refactor: add a v8::Isolate* local to ProxyFunctionWrapper()
* refactor: remove error_context->GetIsolate() call from PassValueToOtherContextInner()
* refactor: remove GetIsolate() call from ProxyFunctionWrapper()
* refactor: pass source and destination isolate as arg to CreateProxyForAPI()
2025-08-05 20:08:04 -05:00
Keeley Hammond
678fb400fd
fix: video scrubbing on playback ( #47703 )
...
* fix: fix video scrubbing on playback
* chore: address review feedback
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-05 18:48:52 +02:00
Shelley Vohr
8806499904
fix: offscreen mode under window.open creation ( #47868 )
...
fix: offscreen mode under new window creation
2025-08-05 14:56:33 +02:00
dependabot[bot]
637a504e28
build(deps): bump github/codeql-action from 3.29.4 to 3.29.5 ( #47962 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.4 to 3.29.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4e828ff8d4...51f77329af )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-05 14:41:57 +02:00
electron-roller[bot]
40cdfdb1d1
chore: bump node to v22.18.0 (main) ( #47937 )
...
* chore: bump node in DEPS to v22.18.0
* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define
https://github.com/nodejs/node/pull/58845
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58960
* permission: propagate permission model flags on spawn
https://github.com/nodejs/node/pull/58853
* esm: syncify default path of ModuleLoader\.load
https://github.com/nodejs/node/pull/57419
* src: remove fast API for InternalModuleStat
https://github.com/nodejs/node/pull/58489
* src: simplify adding fast APIs to ExternalReferenceRegistry
https://github.com/nodejs/node/pull/58896/
* chore: fixup patch indices
* src: fix internalModuleStat v8 fast path
https://github.com/nodejs/node/pull/58054
* test: add tests to ensure that node.1 is kept in sync with cli.md
https://github.com/nodejs/node/pull/58878
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58942
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-04 14:40:36 -04:00
Robo
4ca10a1056
chore: move gin::Handle to gin_helper ( #47959 )
...
* chore: move gin::Handle to gin_helper
* chore: fix lint
2025-08-05 02:03:06 +09:00
Robo
9d05454dc7
chore: move gin::DeprecatedWrappable to gin_helper ( #47958 )
...
* chore: move gin::DeprecatedWrappable to gin_helper
This is in preparation for migrating to gin::Wrappable
based on cppgc #47922
The upstream class will be deleted soon via roller PR but
the cppgc migration should happen outside the roll, this
change retains the current functionality by copying the
implementation into //electron/shell/common/gin_helper.
The class can be deleted once the cppgc migration is complete.
* chore: fix lint:cpp
2025-08-04 23:28:01 +09:00
dependabot[bot]
0e862bba61
build(deps-dev): bump remark-preset-lint-markdown-style-guide from 4.0.0 to 6.0.1 ( #47940 )
...
build(deps-dev): bump remark-preset-lint-markdown-style-guide
Bumps [remark-preset-lint-markdown-style-guide](https://github.com/remarkjs/remark-lint ) from 4.0.0 to 6.0.1.
- [Release notes](https://github.com/remarkjs/remark-lint/releases )
- [Changelog](https://github.com/remarkjs/remark-lint/blob/main/changelog.md )
- [Commits](https://github.com/remarkjs/remark-lint/commits )
---
updated-dependencies:
- dependency-name: remark-preset-lint-markdown-style-guide
dependency-version: 6.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-04 14:29:36 +02:00
Shelley Vohr
4232ed2814
fix: crash on window.close() with webContents on blur ( #47933 )
...
fix: crash on window.close with WebContentsView on blur
2025-08-04 10:35:29 +02:00
Will Anderson
e7683bdd25
feat: Use DIR_ASSETS path to locate resource bundles ( #47439 )
...
* feat: Use DIR_ASSETS path to locate resource bundles
* Use DIR_ASSETS for calculating ASAR relative paths
* Add test to verify 'assets' matches parent dir of 'exe'
* Add Mac-specific test for assets path (but it is failing)
* test: Update app.getPath('assets') to expect an exception on Mac
* docs: Update docs for 'assets' path to indicate that it's only available on Windows + Linux
* fix: Don't define 'assets' mapping on macOS
2025-08-04 12:34:08 +09:00
Sam Maddock
bdaf3b9a2b
refactor: replace webFrame.routingId with sync IPC ( #47717 )
...
* refactor: replace webFrame.routingId with sync IPC
* fix: GetConstructor missing isolate
* fix: missing isolate
2025-08-02 11:00:42 -04:00
Shelley Vohr
5c98e3609f
feat: add {get|set}AccentColor on Windows ( #47741 )
...
* feat: add setAccentColor on Windows
* refactor: unify GetSystemAccentColor
* refactor: remove redundant parsing
* chore: fixup documentation
* Update docs/api/browser-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
* Update docs/api/base-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
---------
Co-authored-by: Will Anderson <andersonw@dropbox.com >
2025-08-01 22:29:02 +02:00
dependabot[bot]
2cfccac074
build(deps-dev): bump folder-hash from 2.1.2 to 4.1.1 ( #47931 )
...
Bumps [folder-hash](https://github.com/marc136/node-folder-hash ) from 2.1.2 to 4.1.1.
- [Release notes](https://github.com/marc136/node-folder-hash/releases )
- [Changelog](https://github.com/marc136/node-folder-hash/blob/main/CHANGELOG.md )
- [Commits](https://github.com/marc136/node-folder-hash/compare/v2.1.2...v4.1.1 )
---
updated-dependencies:
- dependency-name: folder-hash
dependency-version: 4.1.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-01 19:16:43 +02:00
electron-roller[bot]
03aad28412
chore: bump chromium to 140.0.7327.0 (main) ( #47902 )
...
* chore: bump chromium in DEPS to 140.0.7324.0
* chore: bump chromium in DEPS to 140.0.7325.0
* chore: remove @dsanders11's unused include patch
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6782507
* fix: apply keychain patch to new apple subdir
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update chromium patches
* chore: update other patches
* chore: bump chromium in DEPS to 140.0.7327.0
* fix: mistake in reapplied patch
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update patches
* fix: remove OnPrivateNetworkAccessPermissionRequired override
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6769208
* fix: update colorSpace property to use new unified value
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6795085
* fix: include OverlayWindowLiveCaptionButton
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787420
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* fix: format chromium_src/BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* fix: format BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* chore: include script/ in logged path
* fix: update filenames.libcxx.gni
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787279
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-31 18:11:00 -04:00
Sam Maddock
25e2459f31
feat: webFrameMain.fromFrameToken ( #47850 )
...
* feat: webFrameMain.fromFrameToken
* refactor: return null instead of undefined
* docs: mention renderer webFrame property
* chore: undo null->undefined in wfm.fromId api
this will be updated in another pr
2025-07-31 16:41:44 -04:00
Shelley Vohr
18af498cf1
build: roll build-images to 933c7d6 ( #47880 )
2025-07-31 12:08:45 -04:00
John Kleinschmidt
9f43503b3e
chore: revert "ci: fixup mac runners" ( #47917 )
...
This reverts commit 06d7a51a58 .
2025-07-31 11:08:43 -04:00
Shelley Vohr
ecb1eb0b5d
feat: add app.getRecentDocuments() ( #45839 )
...
feat: add app.getRecentDocuments()
2025-07-31 16:15:33 +02:00
dependabot[bot]
2c916cfa33
build(deps-dev): bump @octokit/rest from 20.1.1 to 20.1.2 ( #47818 )
...
* build(deps-dev): bump @octokit/rest from 20.1.1 to 22.0.0
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.1 to 22.0.0.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.1...v22.0.0 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 22.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: bump octokit/rest to 20.1.2
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-07-31 14:30:45 +02:00
Shelley Vohr
4c9ab8765b
fix: dark mode on Linux default themeing ( #47869 )
2025-07-31 10:54:55 +02:00
dependabot[bot]
051f78dd1d
build(deps): bump actions-cool/issues-helper from 3.6.0 to 3.6.2 ( #47905 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.6.0 to 3.6.2.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](a610082f8a...50068f49b7 )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-version: 3.6.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-31 10:54:25 +02:00
dependabot[bot]
c796a74467
build(deps): bump github/codeql-action from 3.29.2 to 3.29.4 ( #47904 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.2 to 3.29.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](181d5eefc2...4e828ff8d4 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-31 10:54:03 +02:00
John Kleinschmidt
0d0cbaf7b4
ci: use new arc cluster ( #47897 )
2025-07-30 13:45:24 -04:00
Charles Kerr
63c452dcc7
refactor: avoid deprecated v8::Context::GetIsolate() calls pt 3 context get isolate pt 3 ( #47901 )
...
* refactor: add a v8::Isolate* arg to RendererClientBase::IsWebViewFrame()
Needed for creating gin dictionaries
refactor: add a v8::Isolate* arg to ShouldLoadPreload()
Needed for calling IsWebViewFrame()
* refactor: add a v8::Isolate* arg to electron::util::CompileAndCall()
* refactor: add a v8::Isolate* arg to OnCreatePreloadableV8Context()
* refactor: add a v8::Isolate* arg to InvokeEmitProcessEvent()
* refactor: add a v8::Isolate* arg to ServiceWorkerData's constructor
* refactor: add a v8::Isolate* arg to RendererClientBase::SetupMainWorldOverrides()
* refactor: add a v8::Isolate* arg to RendererClientBase::WilLReleaseScriptContext()
* docs: update docs to avoid v8::Context::GetIsolate()
* refactor: add a v8::Isolate* arg to ElectronSandboxedRendererClient::InitializeBindings()
* refactor: avoid v8::Context::GetIsolate() call in PromiseBase::SettleScope::~SettleScope()
2025-07-30 09:14:38 -05:00
electron-roller[bot]
f6407b4949
chore: bump chromium to 140.0.7314.0 (main) ( #47882 )
...
* chore: bump chromium in DEPS to 140.0.7314.0
* 6769821: Delegate checking whether preconnect is enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769821
* 6632993: PDF Searchify IPH: Use embedder WebContents for GuestView PDF
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6632993
* 6769214: [ios blink] Set IOSurface shared memory region on all GMB handles
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769214
* chore: update patches
* 6769572: [soft navs]: Move AsyncSameDocumentNavigationStarted to TaskAttributionTracker
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769572
* chore: node gen-libc++-filenames.js
* 6765740: [SxS] Implement support for split view in extensions API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6765740
* 6769821: Delegate checking whether preconnect is enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769821
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-28 15:31:54 -07:00
John Kleinschmidt
06d7a51a58
ci: fixup mac runners ( #47877 )
...
ci: make sure camera and bluetooth are available on macos
ci: turn off spotlight indexing
2025-07-28 13:37:05 -04:00
Charles Kerr
2255bb620a
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) ( #47879 )
...
* refactor: add a v8::Isolate* arg to Constructible::GetConstructor()
* refactor: add a v8::Isolate* arg to NodeBindings::Initialize()
This is needed for the GetConstructor() call
* refactor: avoid v8::Context::GetIsolate() call in GetIpcObject() by taking it as an arg
* refactor: avoid v8::Context::GetIsolate() call in ipc_native::EmitIPCEvent() by taking it as an arg
2025-07-28 10:22:27 -05:00
Charles Kerr
084c6ef549
refactor: prefer GetCreationContextChecked(v8::Isolate*) over GetCreationContextChecked() ( #47878 )
...
* refactor: pass an isolate when calling GetCreationContextChecked() in V8FunctionInvoker
* refactor: pass an isolate when calling GetCreationContextChecked() in RendererClientBase
* refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::Completed()
* refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::CopyResultToCallingContextAndFinalize()
* refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame()
* refactor: pass an isolate when calling GetCreationContextChecked() in gin_helper::internal::CallMethodWithArgs()
* refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalPropertyFromIsolatedWorld()
* refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalValueFromIsolatedWorld()
* refactor: pass an isolate when calling GetCreationContextChecked() in ProxyFunctionWrapper()
* refactor: pass an isolate when calling GetCreationContextChecked() in PassValueToOtherContextInner()
* fixup! refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame()
2025-07-25 09:06:57 -05:00
Shelley Vohr
01faaa30ea
fix: window content protection on older Windows versions ( #47856 )
2025-07-24 12:05:28 -07:00
electron-roller[bot]
c569d5e4ba
chore: bump chromium to 140.0.7312.0 (main) ( #47862 )
...
* chore: bump chromium in DEPS to 140.0.7312.0
* 6769540: Move NetworkTrafficAnnotationTag out of PreconnectManager.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769540
* 6771377: Roll libc++ from 3eda1e62e799 to 569aa83b4bbc (7 revisions)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771377
* 6771398: Remove unnecessary std::optional wrappers in ResolveHostClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771398
* chore: update patches
* 6776165: Use shared session bus for MPRIS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6776165
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-23 16:26:30 -07:00
Shelley Vohr
670da27305
ci: add ability to debug SSH sessions in CI ( #47819 )
2025-07-23 10:57:06 -04:00
dependabot[bot]
5f901174c5
build(deps): bump slackapi/slack-github-action from 2.1.0 to 2.1.1 ( #47748 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](b0fa283ad8...91efab103c )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-version: 2.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-23 11:24:17 +02:00
xufuhang
b39a1fb877
fix: webContents.downloadURL() did not support referer header ( #47625 )
...
Signed-off-by: xufuhang <576484918@qq.com >
2025-07-23 10:37:24 +02:00
Robo
2156ccb577
ci: update llvmobjdump package as part of fix sync ( #47858 )
2025-07-23 17:05:30 +09:00
electron-roller[bot]
9e2f7065a0
chore: bump chromium to 140.0.7309.0 (main) ( #47848 )
...
* chore: bump chromium in DEPS to 140.0.7309.0
* 6762172: Replace MSG_ROUTING_NONE with IPC::mojom::kRoutingIdNone.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6762172
* 6759543: [exit-time-destructors] Exclude target with warnings
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6759543
* 6765167: Split PreconnectManager into interface and implementation.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6765167
* 6766775: [media] Clarify coded and visible size in FrameResources
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6766775
* 6760878: Move PreconnectRequest to //content/public
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6760878
* 6718973: Implement media playback trust check for the video PiP overlay window
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6718973
* chore: add missing include of <iterator> in ada
* chore: update patches
* chore: node gen-libc++-filenames.js
* 6759633: [media] Use format from shared image in FrameResources
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6759633
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-07-22 16:09:47 -07:00
Niklas Wenzel
51bfe07da9
build: extend Chromium options in bug report template ( #47829 )
...
* build: extend Chromium options in bug report template
As predicted by @dsanders11 and others, we got a bunch of bug reports with clearly incorrect values for "does this issue appear in Chromium?" because people didn't test or didn't know how to test.
This PR adds an "I didn't know how to test" option.
* build: update wording to use present tense
2025-07-21 15:26:02 -04:00
Shelley Vohr
4699761649
build: improve check-zip-manifest ( #47828 )
...
* build: improve check-zip-manifest
* fix: unicode on Windows
2025-07-21 15:20:27 -04:00
electron-roller[bot]
26e1bda335
chore: bump chromium to 140.0.7301.0 (main) ( #47747 )
...
* chore: bump chromium in DEPS to 140.0.7296.0
* chore: update patches
* 6702959: Remove OwnedByWidgetPassKey usage from content analysis dialog tests | https://chromium-review.googlesource.com/c/chromium/src/+/6702959
* 6722750: Remove un-used `stream_id` argument for `AidaCodeComplete` | https://chromium-review.googlesource.com/c/chromium/src/+/6722750
* 6696478: Reland Reland [video pip] Add fade in/out animation to controls visibility changes | https://chromium-review.googlesource.com/c/chromium/src/+/6696478
* chore: update libc++-filenames
* build: explicitly include cstdlib in Boyer-Moore patch
* chore: bump chromium in DEPS to 140.0.7297.0
* chore: update patches
* 6729537: [FPF] Pipe flag state from the browser to the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6729537
* 6727996: [Win] Detect pre-IPC crashes in sandboxed utility processes | https://chromium-review.googlesource.com/c/chromium/src/+/6727996
* 6707182: Move wtf/cross_thread_copier*.* to "blink" namespace | https://chromium-review.googlesource.com/c/chromium/src/+/6707182
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* chore: bump chromium in DEPS to 140.0.7299.0
* chore: update patches
* chore: update main patches
* build: reset the minimum macOS SDK to 15 to match upstream
This reverts commit 499e987c77 .
* 6730215: Remove IPC_MESSAGE_LOG_ENABLED ifdef blocks. | https://chromium-review.googlesource.com/c/chromium/src/+/6730215
* 6690442: Delete ppapi/buildflags/buildflags.h | https://chromium-review.googlesource.com/c/chromium/src/+/6690442
* [wip]: 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
* chore: bump chromium in DEPS to 140.0.7301.0
* chore: update patches
* 6656309: extensions: Port proxy API to desktop Android | https://chromium-review.googlesource.com/c/chromium/src/+/6656309
* 6758510: Reland 'Move GN enable_plugins variable out of //ppapi' | https://chromium-review.googlesource.com/c/chromium/src/+/6758510
* 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* 6735979: [FSA] Replace `request_writable` with a new enum `FileSystemAccessPermissionMode`. | https://chromium-review.googlesource.com/c/chromium/src/+/6735979
* 6712080: Reland "Turn on gender translation PAK generation everywhere" | https://chromium-review.googlesource.com/c/chromium/src/+/6712080
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* build: restore minimum macOS SDK to 10, restore patch
This reverts commit a04c579b99 .
* fixup! 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* chore: correct node patches
* fixup! 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-21 09:32:53 -07:00
Shelley Vohr
cf871bce4e
build: fix ffmpeg generation on Windows non-x64 ( #47768 )
...
* build: fix ffmpeg generation on Windows non-x64
* test: ffmpeg artifact
2025-07-21 11:33:42 -04:00
Charles Kerr
39cca586f6
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) ( #47760 )
...
* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment()
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615
* refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext()
* fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
2025-07-21 16:34:38 +02:00
Shelley Vohr
2f4a070c39
fix: dialog file filters and macOS app bundles ( #47825 )
2025-07-21 13:57:50 +02:00
electron-roller[bot]
2b098408a8
chore: bump node to v22.17.1 (main) ( #47776 )
...
* chore: bump node in DEPS to v22.17.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-18 15:18:18 -04:00
Shelley Vohr
fa844268ec
ci: remove kTCCServiceMicrophone change ( #47816 )
...
ci: remove kTCCServiceMicrophone change
2025-07-18 10:02:06 +02:00
Shelley Vohr
a29a72c3ab
build: update codespace on-create-command ( #47810 )
...
build: update codespace on-create-command
2025-07-18 10:01:49 +02:00
Shelley Vohr
4601aeccde
chore: clean up NativeWindowMac::UpdateVibrancyRadii ( #47665 )
...
chore: clean up NativeWindowMac::UpdateVibrancyRadii
2025-07-17 11:45:24 -04:00
Shelley Vohr
31b18c9830
fix: abnormal behavior of windows background material ( #47386 )
...
* fix: abnormal behavior of windows background material
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches
* fix: setting background material after init
---------
Co-authored-by: zoy <zoy-l@outlook.com >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-17 14:50:12 +02:00
Shelley Vohr
895bf9103e
fix: handle missing NativeWindowMac in ElectronNSWindow ( #47751 )
...
fix: handle missing NativeWindowMac in ElectronNSWindow
2025-07-17 14:49:37 +02:00
David Sanders
bf51d345c8
build(dev-deps): drop unused @types/webpack dep ( #47767 )
2025-07-17 11:04:11 +02:00
Shelley Vohr
6eef170d9a
test: re-enable native module tests ( #46747 )
2025-07-17 11:03:15 +02:00
Shelley Vohr
31725b4a86
fix: window accentColor should adhere to native window behavior ( #47740 )
...
* fix: window accentColor should adhere to native window behavior
* fix: address review feedback
* chore: remove duplicate UpdateWindowAccentColor call in ctor
2025-07-17 10:59:42 +02:00
John Kleinschmidt
ec748eb915
test: cleanup RenderFrame lifespan tests ( #47746 )
...
* test: cleanup RenderFrame lifespan tests
* test: disable navigator.serial tests on arm64 mac
debug the hang
test: disable navigator.bluetooth on arm64 mac
Revert "test: disable navigator.bluetooth on arm64 mac"
This reverts commit 4b53a8485a5ff391832c7da93d859f1aa8722e70.
Revert "debug the hang"
This reverts commit 00338f0d49a7918224822087b4510fa9db0686c3.
Revert "test: disable navigator.serial tests on arm64 mac"
This reverts commit fb515ce447a9d42185e84b17b460e4fb6d1bf71d.
Reapply "test: disable navigator.serial tests on arm64 mac"
This reverts commit 0e5608108ffebbe8b8b27af9ea06aadae2ea85dd.
Reapply "test: disable navigator.bluetooth on arm64 mac"
This reverts commit f4c7d3fc0624a22421cba5d3d75df8c5d4367eea.
fixup
* test: add waitUntil for flaky test
2025-07-16 16:19:55 -04:00
Shelley Vohr
5feb91e2f4
test: fix extensions console flake ( #47750 )
2025-07-16 18:27:20 +02:00
Shelley Vohr
5128ebeddb
test: deflake clipboard read/write specs ( #47752 )
2025-07-16 18:27:11 +02:00
Calvin
389927dce8
fix: corner smoothing feature gate crash ( #47759 )
...
* fix: corner smoothing feature gate crash
* Fix ElectronCornerSmoothing::CSSValueFromComputedStyleInternal
2025-07-16 08:39:17 -07:00
Calvin
67afc10b75
fix: add macos memory query fallback patch to avoid crash ( #47765 )
2025-07-16 08:18:54 -07:00
Pratyush
f570e6967f
docs: fix broken sentence in crashReporter.start() documentation ( #47688 )
2025-07-16 15:05:45 +02:00
Shelley Vohr
09ab71de43
fix: deprecation warning crash when no Node.js environment available ( #47700 )
2025-07-16 12:45:59 +02:00
Milan Burda
21b325b034
docs: improve win.setContentProtection() docs ( #46596 )
...
* docs: improve win.setContentProtection() docs
* docs: update Windows display affinity value
* docs: update Windows behavior description
* Revert "docs: update Windows behavior description"
This reverts commit 6d1942c53a .
* Revert "docs: update Windows display affinity value"
This reverts commit c15363e75d .
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-07-15 15:16:56 -07:00
Erick Zhao
cc9ca4bee2
docs: add Menu module tutorials ( #47268 )
...
* docs: add `Menu` module tutorials
* link API docs to new tutorials
* removed unreferenced fiddles
* add wording for new types
* fix import sort errors
* delete accelerator.md
* fixes
2025-07-15 15:09:32 -07:00
Shelley Vohr
17dba93587
fix: missing SQLite builtin support in Node.js ( #47706 )
...
https://github.com/nodejs/node/pull/58122
2025-07-15 15:39:16 +02:00
electron-roller[bot]
603cafad7e
chore: bump chromium to 140.0.7281.0 (main) ( #47616 )
...
* chore: bump chromium in DEPS to 140.0.7269.2
* chore: bump chromium in DEPS to 140.0.7270.0
* chore: bump chromium in DEPS to 140.0.7271.0
* chore: bump chromium in DEPS to 140.0.7273.0
* 6516731: [ExclusiveAccessForAndroid] remove unneeded includes & deps | https://chromium-review.googlesource.com/c/chromium/src/+/6516731
* 6694809: dbus: Ensure systemd scope is started before using any portal services | https://chromium-review.googlesource.com/c/chromium/src/+/6694809
* chore: patch chromium
* chore: export patches
* chore: bump chromium in DEPS to 140.0.7275.0
* 6677511: [pepper] More pepper removal | https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: export chromium patches
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: bump chromium in DEPS to 140.0.7277.0
* chore: bump chromium in DEPS to 140.0.7279.0
* chore: bump chromium in DEPS to 140.0.7281.0
* 6677314: Plumb enabled client hints in the network requestion to network layer
https://chromium-review.googlesource.com/c/chromium/src/+/6677314
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* 6700077: [renderer] Avoid calls to deprecated GetIsolate methods
https://chromium-review.googlesource.com/c/chromium/src/+/6700077
* 6692873: Reland "Reland "FSA: Only normalize the hardcoded rules once during initialization""
https://chromium-review.googlesource.com/c/chromium/src/+/6692873
* 6686234: [gin] Cleanup NamedPropertyInterceptor for Wrappable
https://chromium-review.googlesource.com/c/chromium/src/+/6686234
* chore: export patches
* 6667723: Remove content_enable_legacy_ipc GN arg.
https://chromium-review.googlesource.com/c/chromium/src/+/6667723
* 6646566: ui: Move NativeWindowTracker to its own directory
https://chromium-review.googlesource.com/c/chromium/src/+/6646566
* fix: add missing includes
* 6580522: [WAR, DNR] Fix unsafe redirect error to web accessible resource
https://chromium-review.googlesource.com/c/chromium/src/+/6580522
* 6680477: Implement `completeCode` endpoint and expose to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/6680477
* 6677511: [pepper] More pepper removal
https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6696689: Rename views::WidgetFocusManager -> NativeViewFocusManager
https://chromium-review.googlesource.com/c/chromium/src/+/6696689
* 6702812: Move wtf/text/string_impl*.* to "blink" namespace
https://chromium-review.googlesource.com/c/chromium/src/+/6702812
* chore: fix dialog patch
* 6702431: [animation-trigger] Parse timeline-trigger-name
https://chromium-review.googlesource.com/c/chromium/src/+/6702431
* chore: fixup patch indices
* feat: replace webFrame.routingId with webFrame.frameToken
* feat: WebFrameMain.prototype.frameToken
* test: refactor to use replacement APIs
* chore: fixup pip patch
* test: adjust webFrame tests for frameToken changes
* 6703757: Reland "Enable -fsanitize=array-bounds in non-UBSan builds"
https://chromium-review.googlesource.com/c/chromium/src/+/6703757
* test: switch to frameTokens
* test: routingId is fine to test in the main process
* docs: add routingId to breaking changes
* docs: update plugin-crashed event
* chore: fixup linux dialog patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-14 13:42:37 -07:00
Shelley Vohr
09f269426e
test: add response to bluetooth request possibilities ( #47725 )
2025-07-14 13:12:27 -04:00
Shelley Vohr
3bbb82b42b
ci: roll BUILD_TOOLS_SHA for macOS 15.5 SDK ( #47694 )
...
ci: roll BUILD_TOOLS_SHA for macOS 15.5 SDK
2025-07-14 13:11:07 -04:00
Shelley Vohr
a9504abde9
build: roll sysroots ( #47710 )
2025-07-14 11:27:19 -04:00
BILL SHEN
9f3636ffe2
build: add platform-specific conditions to the source_set in chromium_src ( #47627 )
...
* build: Add platform-specific if conditions to the source sets in chromium_src.
* build: Add platform-specific if conditions to the source sets in chromium_src.
2025-07-14 11:25:16 +02:00
Shelley Vohr
4a89068fb7
ci: add kTCCServiceAppleEvents perm override to fix AppleScript errors ( #47726 )
...
ci: add kTCCServiceAppleEvents perm override to fix AppleScript errors
2025-07-13 21:05:52 +02:00
John Kleinschmidt
137d4ec329
build: cleanup symlinks in cache ( #47727 )
...
* build: cleanup symlinks in cache
* build: ignore broken links
* try --ignore-failed-read
* build: dont deref symlinks
* build: add flag to 7zip to resolve symlink error
Needed to ignore Dangerous symbolic link path was ignored errors
* Revert "build: cleanup symlinks in cache"
This reverts commit 69e53cdc88 .
2025-07-11 16:13:12 -04:00
David Sanders
624d085632
build: deep update brace-expansion to resolve an audit alert ( #47692 )
2025-07-11 09:57:41 +02:00
Robo
600b6b3315
build: reenable v8_enable_temporal_support ( #47699 )
...
* build: reenable v8_enable_temporal_support
* ci: test with increased vm map count
* chore: backport PA use fewer vmas by default on linux
* chore: update patches
* Revert "ci: test with increased vm map count"
This reverts commit b626c9a5ab7ad3f01e17d77c330abfd8096a8b02.
* ci: remove logs
---------
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-11 02:49:54 +09:00
David Sanders
9e67bd3508
ci: update audit CI workflow dependencies ( #47691 )
...
* ci: update audit CI workflow dependencies
* ci: bump to @electron/fiddle-core@2.0.1
2025-07-10 19:19:36 +02:00
Shelley Vohr
909fd3d55a
ci: set git core.longpaths to true ( #47695 )
...
ci: set git core.longpaths to true
2025-07-10 19:13:39 +02:00
Niklas Wenzel
f2429c31c1
build: ask bug reporters to check if it is a Chromium issue ( #47702 )
...
* build: ask bug reporters to check if it is a Chromium issue
Inspiration: https://github.com/electron/electron/issues/47672#issuecomment-3051298922
* build: fix options
2025-07-10 08:47:04 -07:00
Shelley Vohr
fbb83be785
refactor: use dbus_thread_linux::GetSharedSessionBus() ( #47685 )
...
refactor: use dbus_thread_linux::GetSharedSessionBus()
2025-07-10 10:17:34 +02:00
Shelley Vohr
1eab19fc7c
build: remove unused script ( #47642 )
2025-07-09 10:35:04 -04:00
Shelley Vohr
02f2feabe6
docs: update build prerequisites ( #47680 )
2025-07-09 12:07:24 +02:00
David Sanders
712262597d
build: drop eslint-plugin-unicorn ( #47676 )
2025-07-08 15:20:56 +02:00
Shelley Vohr
31bc5ca903
fix: default to system accent color on invalid user color ( #47660 )
...
fix: default to system accent color on invalid user color"
2025-07-08 11:15:13 +02:00
Shelley Vohr
03a02fc31e
fix: fullscreen for windows without rounded corners ( #47664 )
2025-07-08 11:14:14 +02:00
Shelley Vohr
5ef6897bc7
fix: accent color should reflect system settings without restart ( #47629 )
...
fix: accentColor should reflect system settings without restart
2025-07-03 18:13:39 +02:00
Charles Kerr
bc585b6a3f
refactor: avoid a few unnecessary strings ( #47644 )
...
* perf: replace string temporary with string_view in GetXdgAppId()
* perf: replace string temporary with string_view in ToV8(WindowOpenDisposition)
* perf: replace string temporary with string_view in ToV8(electron::api::WebContents::Type)
2025-07-03 11:08:59 -05:00
David Sanders
4c460df0a4
ci: fix audit workflow alerting on stale results ( #47643 )
2025-07-03 14:42:04 +02:00
Shelley Vohr
cf193b279b
fix: crash on source capture with empty thumbnail size ( #47641 )
2025-07-03 14:41:19 +02:00
Shelley Vohr
655037fbdf
fix: window.open popups are always resizable ( #47540 )
...
fix: window.open popups are always resizable
Closes https://github.com/electron/electron/issues/43591 .
Per current WHATWG spec, the `window.open` API should always
create a resizable popup window. This change updates the
`parseFeaturesString` function to ensure that windows opened
with `window.open` are always resizable, regardless of the
`resizable` feature string.
2025-07-02 15:02:59 +02:00
Samuel Attard
07338bb1cf
build: update yarn to 1.22.22 ( #47635 )
2025-07-02 12:11:42 +02:00
reito
fb0b77b731
feat: add ColorSpace ( #47314 )
2025-07-02 00:09:09 -07:00
Keeley Hammond
499e987c77
build: set the minimum macOS SDK to 10.15 ( #47634 )
...
* build: set the minumum macOS SDK to 10.15
* build: revert "Update mac_sdk_min to match minimum required SDK version"
This reverts commit 3d4654fc18 .
2025-07-01 18:51:08 -07:00
Cas_
f7138344d8
docs: discoverability of chromium switches ( #44947 )
...
* docs: document discoverability of chromium switches
* docs: fixed typo
* docs: reference chromium endorsed list of swithes
* docs: reorder command-line-switches
* fix: address review
* fix: typo
* fix: wording
* Update command-line-switches.md
fix: lint space
* fix: Update docs/api/command-line-switches.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-07-01 14:31:49 -07:00
dependabot[bot]
b9248e6782
build(deps): bump github/codeql-action from 3.29.0 to 3.29.2 ( #47622 )
2025-07-01 11:12:15 +02:00
Shelley Vohr
af39dcfb09
refactor: use non-deprecated macOS API in RemoveAsDefaultProtocolClient ( #47506 )
...
refactor: use non-deprecated macOS API in RemoveAsDefaultProtocolClient
2025-07-01 10:19:28 +02:00
Samuel Attard
d347632046
build: write abi version to published npm package ( #47598 )
2025-06-30 15:01:09 -07:00
electron-roller[bot]
4f69c5835e
chore: bump chromium to 140.0.7261.0 (main) ( #47561 )
...
* chore: bump chromium in DEPS to 140.0.7259.0
* chore: update patches
* Add fade in animation to Picture-in-Picture windows
https://chromium-review.googlesource.com/c/chromium/src/+/6538268
* [v8] Use V8 Apis that don't return JSGlobalObject
Refs https://issues.chromium.org/issues/333672197
* chore: IWYU
* chore: bump chromium in DEPS to 140.0.7261.0
* chore: update patches
* revert: update to siso-chromium image
* [v8] Use v8::Object::WrapGlobal()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6650977
* chore: IWYU
* chore: fix --trace-startup spec
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-30 12:30:05 -04:00
Taiki Komoda
fa15332587
docs: update automated-testing.md ( #47017 )
...
* Update automated-testing.md
* fixed lint error
2025-06-30 10:56:48 +02:00
Shelley Vohr
e299a1d098
feat: support complete WebUSB device properties ( #47459 )
...
* feat: support complete WebUSB device properties
* docs: correct type consistency
2025-06-30 10:28:21 +02:00
Charles Kerr
c2302960a8
refactor: reduce scope of temporaries when getting dictionary values ( #47581 )
...
refactor: reduce scale of temporaries when getting dictionary values
2025-06-29 21:58:18 +02:00
Charles Kerr
5e862f398e
fix: Reland "[accessibility] Platform node lifetime cleanups" ( #47590 )
...
Reland "[accessibility] Platform node lifetime cleanups"
https://chromium-review.googlesource.com/c/chromium/src/+/6462552
2025-06-29 21:57:48 +02:00
Shelley Vohr
61c245761c
test: fix nan tests on macOS ( #47583 )
2025-06-29 21:57:44 +02:00
Charles Kerr
7c55b24be2
refactor: avoid copies of large objects in range based for loops ( #47588 )
...
* Avoid copies of large objects in range-based for-loops.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6527689
* Avoid copies of large objects in range-based for-loops in Browser::ShowAboutPanel()
2025-06-29 21:32:26 +02:00
Charles Kerr
4af248f2b6
perf: avoid copying a vector when calling ConvertToWeakPtrVector() ( #47593 )
2025-06-29 21:32:03 +02:00
Erick Zhao
69e9b653ba
docs: update example apps ( #47597 )
2025-06-29 21:31:42 +02:00
electron-roller[bot]
4dccccadbb
chore: bump node to v22.17.0 (main) ( #47557 )
...
* chore: bump node in DEPS to v22.17.0
* build: use //third_party/simdutf by default in GN
https://github.com/nodejs/node/pull/58115
* chore: adjust crypto specs:
- https://github.com/nodejs/node/pull/58117
- https://github.com/nodejs/node/pull/58387
* deps: update libuv to 1.51.0
https://github.com/nodejs/node/pull/58124
* test: fix test-buffer-tostring-range on allocation failure
https://github.com/nodejs/node/pull/58416
* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
https://github.com/nodejs/node/pull/58090
* build: use //third_party/simdutf by default in GN
https://github.com/nodejs/node/pull/58115
* inspector: add protocol method Network.dataReceived
https://github.com/nodejs/node/pull/58001
* test: force slow JSON.stringify path for overflow
https://github.com/nodejs/node/pull/58181
* chore: fixup patch indices
* 6049967: Remove protocol::Maybe and roll inspector_protocol
https://chromium-review.googlesource.com/c/chromium/src/+/6049967
* chore: fixup crypto test patch
* src: fix module buffer allocation
https://github.com/nodejs/node/pull/57738
* crypto: expose process.features.openssl_is_boringssl
https://github.com/nodejs/node/pull/58387
* util: add internal assignFunctionName() function
https://github.com/nodejs/node/pull/57916
* build: fix pointer compression builds
https://github.com/nodejs/node/pull/58171
* chore: put back config options
* fixup! deps: update libuv to 1.51.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-06-28 16:33:09 +02:00
Charles Kerr
79cd6a2614
refactor: sync IsKillURL() with upstream impl in extension_tab_util.cc ( #47580 )
...
Use base::MakeFixedFlatSet()
2025-06-27 15:49:41 -05:00
Charles Kerr
2ba8fe9140
refactor: extract-constant static Windows registry keys in Browser code ( #47569 )
...
* refactor: extract-constant for registry key in GetProcessExecPath()
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
* refactor: extract-constant for registry key in Browser::GetLoginItemSettings()
* chore: document the symbolic constants
* refactor: prefer base::wcstring_view::c_str() to data() to make zero-termination clearer
2025-06-27 10:34:55 -05:00
Charles Kerr
b21c4b0f88
refactor: make context bridge's private keys hidden, constexpr string_views ( #47562 )
...
* refactor: local functions GetPrivate(), SetPrivate() now take std::string_views
* refactor: make local keys std::string_views instead of C-style char arrays
* refactor: make local keys constexpr
* refactor: move local keys into local anonymous namespace
2025-06-27 09:29:53 -05:00
Charles Kerr
f50ad3d022
refactor: remove stray .c_str() calls for absl::StrFormat() ( #47548 )
...
refactor: remove stray .c_str() calls for absl::StrFormat()
StrFormat() understands std::string, std::string_view
2025-06-26 11:41:30 +02:00
Keeley Hammond
7a274a711c
fix: revert upstream MacOS mouse event routing ( #47560 )
...
* fix: revert upstream MacOS mouse event routing
* fix: reduce patch surface area
* chore: update patches
2025-06-26 11:41:11 +02:00
Niklas Wenzel
bc499ffb8a
docs: fix --experimental-network-inspection spelling ( #47565 )
...
doc: fix `--experimental-network-inspection` spelling
2025-06-26 11:40:55 +02:00
Niklas Wenzel
0a74e91580
docs: update asar integrity fuse availability ( #47528 )
2025-06-25 23:15:59 +02:00
electron-roller[bot]
035879357e
chore: bump chromium to 139.0.7256.0 (main) ( #47481 )
...
* chore: bump chromium in DEPS to 139.0.7242.0
* chore: update render_widget_host_view_mac.patch
no code changes; just updating patch context
Do a cleanup pass on the history swiper code | https://chromium-review.googlesource.com/c/chromium/src/+/6604367
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no code changes; just updating patch context
[tracing] Delete base/trace_event/base_tracing.h | https://chromium-review.googlesource.com/c/chromium/src/+/6624012
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
no manual changes; just updating patch context
[ActorFramework] Refactor Actor Task Management | https://chromium-review.googlesource.com/c/chromium/src/+/6618684
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
[pip] Tuck picture-in-picture windows when a file dialog is open | https://chromium-review.googlesource.com/c/chromium/src/+/6449682
Reland "[document pip] Restrict the size that a website can request" | https://chromium-review.googlesource.com/c/chromium/src/+/6372104
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
Xref: corner-shape: constraint radii based on opposite corner overlap | https://chromium-review.googlesource.com/c/chromium/src/+/6592572
* chore: update revert_code_health_clean_up_stale_macwebcontentsocclusion.patch
no manual changes; just updating patch context
* chore: update fix_rename_sqlite_win32_exports_to_avoid_conflicts_with_node_js.patch
no code changes; just updating patch context
* chore: e patches all
* Plumb Verify2QwacBinding and hook it up in QwacWebContentsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/6624719
* [Extensions] Remove host delegate OnMainFrameCreatedForBackgroundPage
https://chromium-review.googlesource.com/c/chromium/src/+/6631123
* Extensions: Rename GetResourceURL to ResolveExtensionURL
https://chromium-review.googlesource.com/c/chromium/src/+/6625053
* [NonClientFrameView] Consolidate NativeFrameViewMac
https://chromium-review.googlesource.com/c/chromium/src/+/6614239
* ICWYU
* [views-ax] Remove dead code WidgetAXTreeIDMap
https://chromium-review.googlesource.com/c/chromium/src/+/6619701
* Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS"
https://chromium-review.googlesource.com/c/chromium/src/+/6630056
* NavigationThrottleRunner2: Remove MaybeAddThrottle
https://chromium-review.googlesource.com/c/chromium/src/+/6628079
* [pip] Tuck picture-in-picture windows when a file dialog is open
https://chromium-review.googlesource.com/c/chromium/src/+/6449682
* build: fix snapshot_blob.bin build error
xref: https://issues.chromium.org/issues/416540976
* chore: e patches all
* build: freeup disk space on macos
* chore: bump chromium in DEPS to 139.0.7244.0
* chore: update printing.patch
no manual changes; just updating patch context
* chore: remove upstreamed ignore_parse_errors_for_resolveshortcutproperties.patch
Prevent Windows crash on unexpected shortcut type | https://chromium-review.googlesource.com/c/chromium/src/+/6633298
* chore: e patches all
* Revert "Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS""
This reverts commit 77c4f967a6 .
Revert CL for the high confidence crash culprit for http://crash/28f897bb9743dfe0 | https://chromium-review.googlesource.com/c/chromium/src/+/6641819
* Fix spec's expected base64-encoded PNG strings to match upstream changes.
[rust png] Enable by default. | https://chromium-review.googlesource.com/c/chromium/src/+/6085801
* chore: bump chromium in DEPS to 139.0.7246.0
* chore: e patches all
* chore: bump chromium in DEPS to 139.0.7248.0
* chore: update patches
* siso: Enable Siso by default for non-Google builds
https://chromium-review.googlesource.com/c/chromium/src/+/6638830
Disabling for now until we are ready to build siso on all platforms.
* Revert "revert Don't use static variable for UseExternalPopupMenus"
This reverts commit e91e3894e6 .
* Update mac_sdk_min to match minimum required SDK version
https://chromium-review.googlesource.com/c/chromium/src/+/6493969
(cherry picked from commit 3e7cbe912d )
* [video pip] Use default window styling on Mac
https://chromium-review.googlesource.com/c/chromium/src/+/6648665
* Reland "Force the unintentional renderer process creation check by default"
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* chore: bump chromium in DEPS to 139.0.7249.0
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
* chore: update patches
* chore: bump chromium in DEPS to 139.0.7250.0
* chore: bump chromium in DEPS to 139.0.7252.0
* chore: bump chromium in DEPS to 139.0.7254.0
* 6638187: browser level TOCTOU check for coordinate target
https://chromium-review.googlesource.com/c/chromium/src/+/6638187
* chore: fixup patch indices
* chore: add missing base/notimplemented includes
* 6652910: [Frame Cleanup] Push down/hide implementation-specific API
https://chromium-review.googlesource.com/c/chromium/src/+/6652910
* chore: bump chromium in DEPS to 139.0.7256.0
* chore: fix lint
* fixup! 6652910: [Frame Cleanup] Push down/hide implementation-specific API
* fix: move HandleScope location
* chore: bump chromium in DEPS to 139.0.7258.0
* fixup! [NonClientFrameView] Consolidate NativeFrameViewMac
* Revert "chore: bump chromium in DEPS to 139.0.7258.0"
This reverts commit 264b2e934f .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-26 00:12:49 +09:00
Felix Rieseberg
e4c37e4b38
docs: Add C++/Linux tutorial ( #46822 )
2025-06-25 12:57:43 +02:00
Calvin
828fc84e60
build: update NMV to 139 ( #47529 )
2025-06-24 12:24:17 -04:00
Shelley Vohr
51fbc964a6
fix: ensure /dev/null fd is closed on failure ( #47525 )
...
* fix: ensure /dev/null fd is closed on failure
* chore: ignore closehandle for windows
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-06-24 17:44:50 +02:00
Shelley Vohr
3e8e87d186
feat: support customizing window accent color on Windows ( #47285 )
2025-06-24 14:43:02 +02:00
Samuel Attard
498f4bc98c
build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed ( #47401 )
...
* build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed
* again
(cherry picked from commit a21afc3e45 )
* use pr head ref
(cherry picked from commit 0edcc985fa )
2025-06-23 22:26:43 -07:00
Michaela Laurencin
a6ad5a6e60
docs: update timelines for E38 ( #47488 )
...
Update electron-timelines.md
2025-06-23 15:50:22 +02:00
Shelley Vohr
93d5152a25
fix: chrome://accessibility loading correctly ( #47497 )
...
fix: chrome://accessibility loading correctly
2025-06-23 14:38:29 +02:00
Shelley Vohr
fb65124234
chore: fix nightly issues getting unsupported label comment ( #47503 )
...
* chore: fix nightly issues getting unsupported label comment
* chore: address review feedback
2025-06-23 14:22:41 +02:00
dependabot[bot]
93f4b3cf9f
build(deps): bump github/codeql-action from 3.28.19 to 3.29.0 ( #47486 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.19 to 3.29.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fca7ace96b...ce28f5bb42 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-23 11:24:18 +02:00
Charles Kerr
bb22eaccec
refactor: simplify titlebar overlay initialization ( #47480 )
2025-06-23 11:24:05 +02:00
David Sanders
90a14299fd
ci: fix sending Slack message in CI audit workflow ( #47494 )
2025-06-23 11:23:39 +02:00
Shelley Vohr
60924690d9
build: combine dependent libc patch ( #47491 )
2025-06-23 11:22:35 +02:00
John Kleinschmidt
9b158238dc
build: update cache action to latest ( #47501 )
2025-06-23 11:22:14 +02:00
Samuel Attard
dac5e0cd1a
build: add siso backend.star ( #47509 )
2025-06-20 11:25:27 -07:00
Robo
626895848e
fix: utilityProcess running user script after process.exit is called ( #47469 )
...
* fix: utilityProcess running user script after process.exit is called
* docs: update breaking changes
* chore: update spec
* chore: update spec/api-utility-process-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: remove interface bound checks
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-18 04:36:22 +09:00
Keeley Hammond
3536d4976a
fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() ( #47482 )
...
Revert "refactor: move `IsClosed()` and `IsClosable()` tests into `NativeWindow::Close()` (#46888 )"
This reverts commit 3faddd5ae2 .
2025-06-16 16:41:19 -07:00
Shelley Vohr
2ad762e075
feat: support HIDDevice.collections ( #47391 )
...
* feat: support HIDDevice.collections
* Update docs/api/structures/hid-device.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
---------
Co-authored-by: Erick Zhao <ezhao@slack-corp.com >
2025-06-16 15:56:08 -04:00
electron-roller[bot]
6779769d22
chore: bump chromium to 139.0.7219.0 (main) ( #47348 )
...
* chore: bump chromium in DEPS to 139.0.7205.0
* 6543986: Mac: decouple deserializing and applying sandbox policy
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6543986
* 6580079: Reland 'Remove the third-party blocking feature'
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6580079
* 6505716: guest-contents: Add components/guest_contents
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6505716
* 6572556: Move LogMessageManager out of gpu_service_impl.cc.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6572556
* 6566111: Change UtilityProcessHost to manage its instance internally
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6550237: Rename ReconnectEventObserver to ConnectionChangeObserverClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6550237
* 6565918: Validate path is valid UTF8 in SelectFileDialogLinuxPortal
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6565918
* 6579713: Remove base::NotFatalUntil::M130 usage
6566111: Change UtilityProcessHost to manage its instance internally
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/6579713
https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* chore: update chromium patches
* chore: update remaining patches
* fixup! 6566111: Change UtilityProcessHost to manage its instance internally Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6577970: Remove superfluous includes for base/strings/stringprintf.h in headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6577970
* 6568811: Add FunctionCall structured metrics event for DevTools
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6568811
* [PDF Ink Signatures] Support PdfAnnotationsEnabled policy
https://chromium-review.googlesource.com/c/chromium/src/+/6558970
* build: disable libcxx modules for rbe
* chore: bump chromium in DEPS to 139.0.7217.0
* chore: bump chromium in DEPS to 139.0.7218.0
* chore: update patches
fix_use_delegated_generic_capturer_when_available.patch was updated to handle a small change:
6582142: Use content::Create*Capturer in DesktopCaptureDevice. | https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* 6594615: Change Chromium's deployment target to macOS 12
https://chromium-review.googlesource.com/c/chromium/src/+/6594615
Updated the assertion message to match the docs structure now too. I removed the callout to the supported versions doc because it has moved and doesn't contain minimum platform version information.
* 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_
https://chromium-review.googlesource.com/c/chromium/src/+/6606232
|NativeWindow::GetContentMinimumSize| and |NativeWindow::GetContentMaximumSize| may be good opportunities for a refactor now.
* add squirrel.mac patch for removed function
This was triggered by the macOS 12.0 deployment upgrade change.
See: https://developer.apple.com/documentation/coreservices/1444079-uttypeconformsto?language=objc
* 6582142: Use content::Create*Capturer in DesktopCaptureDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* 6579732: Two minor API "quality of life" cleanups in OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/6579732
* chore: add include for base::SingleThreadTaskRunner
Not sure what change caused this, I expect it would be a removed include somewhere else, but it's likely not important to track down.
* chore: update libcxx filenames
* chore: update CI build-tools commit target for macOS SDK 15.4
The following change uses an API that was added in the macOS 15.4 SDK. Support for that SDK version was added later than the current build-tools commit target.
6575804: Use a quick-and-dirty solution to avoid glitching with paste-and-go | https://chromium-review.googlesource.com/c/chromium/src/+/6575804
See: https://developer.apple.com/documentation/appkit/nspasteboard/accessbehavior-swift.enum?language=objc
* fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ https://chromium-review.googlesource.com/c/chromium/src/+/6606232
* chore: bump chromium in DEPS to 139.0.7220.0
* chore: update patches
Minor changes due to:
6613978: pwa: let events fall through in the transparent area of TopContainerView | https://chromium-review.googlesource.com/c/chromium/src/+/6613978
6614778: Refactor auto pip tab observer for Android support | https://chromium-review.googlesource.com/c/chromium/src/+/6614778
* 6543986: Mac: decouple deserializing and applying sandbox policy
https://chromium-review.googlesource.com/c/chromium/src/+/6543986
The DecodeVarInt and DecodeString functions look benign from a MAS perspective. I suspect they were patched out to avoid "unused function" errors. Their complements for encoding are unpatched, supporting this idea.
The code that uses these functions was refactored out of the section that we patch out. Instead of patching out that new function, I decided to treat it the same as the serialization function that is unpatched.
* chore: bump chromium in DEPS to 139.0.7222.0
* chore: bump chromium in DEPS to 139.0.7224.0
* chore: bump chromium in DEPS to 139.0.7226.0
* chore: bump chromium in DEPS to 139.0.7228.0
* chore: update patches
* Don't use static variable for UseExternalPopupMenus
https://chromium-review.googlesource.com/c/chromium/src/+/6534657
* Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59
https://chromium-review.googlesource.com/c/chromium/src/+/6607589
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* revert Don't use static variable for UseExternalPopupMenus
* tls: remove deprecated tls.createSecurePair and SecurePair
https://github.com/nodejs/node/pull/57361
* Revert "Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59"
This reverts commit 33e1436a0c .
* test: cleanup api-desktop-capturer-spec.ts
* test: more cleanup of api-desktop-capturer-spec.ts
* chore: debug dcheck error in webrtc on linux
* fixup patch
* add debugging to desktop capturer spec
* test: fixup api-desktop-capturer-spec.ts for linux
* chore: remove debugging patch
* Revert "fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ https://chromium-review.googlesource.com/c/chromium/src/+/6606232 "
This reverts commit 32e75651c1 .
* Revert "6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_"
This reverts commit 89c51aa1c7 .
* [views] Remove DesktopWindowTreeHostWin::window_enlargement_
https://chromium-review.googlesource.com/c/chromium/src/+/6606232
Reverting as we need this functionality for now.
* fixup: remove patch that was accidentally added back
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-06-16 12:46:06 -05:00
Shelley Vohr
96fcc2f8c8
chore: exempt upgrade-follow-up issues from stale ( #47460 )
...
chore: exempt upgrade-follow-upissues from stale
2025-06-14 21:43:57 -07:00
Charles Kerr
3c9b8475a2
refactor: move gin::Converter<PreloadScript> impl to a .cc file ( #47445 )
...
refactor: move gin::Converter<PreloadScript> impl to a .cc file
2025-06-13 10:15:32 +02:00
Charles Kerr
6f915e85e2
refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> ( #47428 )
...
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
2025-06-12 12:25:40 +02:00
Anny Yang
0259abe920
docs: update remaining references to electron-quick-start ( #47405 )
...
* chore: udpate remaining references to electron-quick-start
* chore: Update docs/tutorial/tutorial-1-prerequisites.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: Update docs/tutorial/tutorial-3-preload.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: Update docs/tutorial/tutorial-2-first-app.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: linebreak
* chore: swap minimal-repro for npx create-electron-app
* chore: add back code commands
* chore: add whitespace
* chore: remove reference to repo containing old quick start
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-06-12 10:32:17 +02:00
Shelley Vohr
38fe14041d
fix: crash calling Fetch.continueResponse with WebContentsView ( #47434 )
...
fix: crash calling Fetch.continueResponse with WebContentsView
2025-06-11 15:43:47 +02:00
dependabot[bot]
996945d3e3
build(deps): bump github/codeql-action from 3.28.18 to 3.28.19 ( #47426 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.18 to 3.28.19.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff0a06e83c...fca7ace96b )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.19
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-11 11:24:03 +02:00
Niklas Wenzel
d7ef8b79ae
docs: mention kwallet6 command line option ( #47427 )
2025-06-10 16:12:31 -04:00
Erick Zhao
6aa3665b96
docs: no class inheritance ( #47403 )
2025-06-10 10:00:06 +02:00
Robo
c964296ec3
feat: add support for --no-experimental-global-navigator ( #47370 )
...
chore: add support for --no-experimental-global-navigator
2025-06-09 14:57:27 +09:00
David Sanders
6f48e3ab12
ci: fix up branch CI audit workflow ( #47404 )
2025-06-07 09:58:48 +02:00
Shelley Vohr
06bc59be88
fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation ( #47361 )
...
* fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-06-07 08:00:30 +02:00
David Sanders
0b84c68229
ci: ignore network-related error annotations in audit ( #47333 )
...
* ci: ignore network-related error annotation in audit
* chore: add another error message
2025-06-06 16:52:25 -04:00
Shelley Vohr
09a0926c5b
fix: printing PDF via webContents.print() ( #47377 )
...
fix: printing PDF via webContents.print()
2025-06-06 14:20:37 -04:00
Shelley Vohr
6606230813
fix: silent printing of PDFs with webContents.print ( #47378 )
...
fix: silent printing
2025-06-06 14:19:08 -04:00
David Sanders
a42afaa866
chore: fix docs lint ( #47389 )
2025-06-06 10:01:26 +02:00
John Kleinschmidt
b1f0ab11c5
build: cache gitcache dir ( #47328 )
...
* revert build: migrate to new chromium git auth
* build: cache gitcache dir
2025-06-05 17:00:21 -04:00
David Sanders
4c3e2eb560
build(deps-dev): bump husky and lint-staged ( #47291 )
2025-06-05 20:23:55 +02:00
Niklas Wenzel
72340e79e8
docs: remove electron-quick-start from README ( #47359 )
...
Refs https://github.com/electron/.permissions/pull/293
The repo was renamed to `minimal-repro` and is no longer intended to be used as a way to start new projects (see PR above).
Since we really want bugs in `electron/electron` to be reported with a Fiddle gist instead of a standalone repo (makes reproducing and bisecting sooo much easier and safer!), I removed the repo from the README completely instead of mentioning as an issue reproduction starting point.
2025-06-05 20:12:21 +02:00
Niklas Wenzel
7196a28d3a
docs: mention Azure Trusted Signing ( #47323 )
2025-06-05 19:13:39 +02:00
Shelley Vohr
6c96979b6c
chore: remove unused spec-chromium ( #47367 )
...
chore: remove unused spec-chromium
2025-06-05 15:50:19 +02:00
Felix Rieseberg
5cbab906c9
docs: Add Swift/macOS tutorial ( #46697 )
...
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2025-06-05 15:45:04 +02:00
Erick Zhao
2a51a997eb
docs: update link to runAsNode fuse ( #47350 )
2025-06-05 10:03:58 +02:00
Shelley Vohr
fbb3fa7503
feat: allow intercepting mouse events ( #47280 )
...
* feat: allow intercepting mouse events
* test: add specs
* Update spec/api-web-contents-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-04 14:10:33 +02:00
Shelley Vohr
c22f94037a
docs: document possible print failureReasons ( #47337 )
...
docs: document possible print failureReasons
2025-06-04 14:09:24 +02:00
John Kleinschmidt
ba7c3bbdf7
chore: update patches ( #47346 )
2025-06-03 13:52:17 -04:00
electron-roller[bot]
53fd879043
chore: bump chromium to 138.0.7190.0 (main) ( #47107 )
...
* chore: bump chromium in DEPS to 138.0.7180.0
* 6546797: Add a metric for the overall success of the "safe storage" item retrieval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6546797
* 6548078: extensions: Fix TODO in ScriptInjectionTracker for desktop Android
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6548078
* 6544950: Revert "FSA: Only normalize the hardcoded rules once during initialization"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6544950
* chore: bump chromium in DEPS to 138.0.7181.0
* chore: update patches
* fix: correctly clamp HSL shift values between 0 and 1
* chore: bump DEPS to 138.0.7183.0
* 6553142: Remove SelectFileDialogLinuxKde | https://chromium-review.googlesource.com/c/chromium/src/+/6553142
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7184.0
* chore: bump chromium in DEPS to 138.0.7186.0
* chore: bump chromium in DEPS to 138.0.7190.0
* chore: update patches
* 6547778: Remove some superfluous //ui/gfx includes from //chrome headers | https://chromium-review.googlesource.com/c/chromium/src/+/6547778
* 6556022 : Reland FSA: Only normalize the hardcoded rules once during initialization | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: remove pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/4099130
This was removed 2 years ago in Chrome.
* fix: provide BrowserContext to pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/6558173
* fixup! 6556022 : Reland FSA: Only normalize the hardcoded rules once during initialization | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: pass in navigation throttle registry
https://chromium-review.googlesource.com/c/chromium/src/+/6536175
* fixup! 6556022 : Reland "FSA: Only normalize the hardcoded rules once during initialization" | https://chromium-review.googlesource.com/c/chromium/src/+/6556022
This partially reverts commit 20d709dd15ba0ff332e24ee314149d642dc5d47c.
* 6545984: corner-shape: render dashed & dotted borders
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6545984
* Update corner smoothing expected images
* Apply "future" revert commit to fix windows build
> Reason for revert: Multiple eng reporting that this is causing build failures due to too-long pathnames, with no immediate feasible workaround
This issue also affects our CI builds.
Problematic CL in current roll: 6494836: [webgl] Add stub WebGL[2]RenderingContextWebGPU | https://chromium-review.googlesource.com/c/chromium/src/+/6494836
"Future" revert CL: 6565622: Revert "[webgl] Add stub WebGL[2]RenderingContextWebGPU" | https://chromium-review.googlesource.com/c/chromium/src/+/6565622
This patch should automatically disappear when we roll the revert.
* 6533919: win: don't add WS_CAPTION style to popup windows
https://chromium-review.googlesource.com/c/chromium/src/+/6533919
This mirrors the change made earlier to the code ours is based on: 6374074: [headless] Provide headless aware window metrics on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-06-03 11:19:20 -04:00
Shelley Vohr
5f5e8d012d
fix: add back fallback wasm-trap handling ( #47186 )
...
* fix: add back fallback wasm-trap handling
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5372409
This change sets up wasm-trap handling for the case where content_shell
has not enabled crash reporting but moves the responsibility to
ElectronRendererClient. The default ContentRendererClient assumes
that crash reporting is enabled (crashpad enabled by default) and does
not set up its own handler.
* chore: fix build
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-06-03 15:31:23 +02:00
Calvin
508c601996
fix: do not load source for electron module in ESM loader synchronous flow ( #46810 )
2025-06-03 12:50:17 +02:00
Sta Zhu
158176f0f3
fix: addChildView() crashes when adding a closed WebContentsView ( #47099 )
...
fix: addChildView() crashes when add a closed WebContentsView
2025-06-03 10:53:25 +02:00
dependabot[bot]
d1e64c37a2
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 ( #47329 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](f49aabe0b5...05b42c6244 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-version: 2.4.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-03 10:18:03 +02:00
Shelley Vohr
17ba863f69
docs: correct 'select-bluetooth-device' requirement ( #47325 )
2025-06-03 10:16:16 +02:00
electron-roller[bot]
82a59d9894
chore: bump node to v22.16.0 (main) ( #47217 )
...
* chore: bump node in DEPS to v22.16.0
* crypto: remove BoringSSL dh-primes addition
https://github.com/nodejs/node/pull/57023
* tools: enable linter in test/fixtures/test\-runner/output
https://github.com/nodejs/node/pull/57698
* src: improve thread safety of TaskQueue
https://github.com/nodejs/node/pull/57910
* buffer: define global v8::CFunction objects as const
https://github.com/nodejs/node/pull/57676
* src: disable abseil deadlock detection
https://github.com/nodejs/node/pull/57582
* zlib: fix pointer alignment
https://github.com/nodejs/node/pull/57727
* chore: fixup patch indices
* src: set default config as node.config.json
https://github.com/nodejs/node/pull/57171
* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
https://github.com/nodejs/node/pull/57578
* test: disable chmod tests failing in Docker
https://github.com/nodejs/node/issues/58326
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-06-02 17:30:15 -04:00
David Sanders
55006fe9a8
ci: change patches stats DataDog metric type to gauge ( #47319 )
2025-06-02 14:49:44 -04:00
zeeker999
dc5efca0f6
feat: [net] add "priority" option to net.request ( #42628 )
...
document the default value of priority option
Update the priority test to not use the httpbin.org as server
Fixed the lint errors
Fixed the build error
2025-05-30 15:28:13 -04:00
David Sanders
cf6c662702
ci: upload stats about patches to DataDog ( #47206 )
2025-05-30 11:14:57 -04:00
Shelley Vohr
c84e8c6c22
feat: expose win.isContentProtected() ( #47242 )
...
* feat: expose win.isContentProtected()
* chore: remove stray _isContentProtected
2025-05-30 11:00:13 +02:00
John Kleinschmidt
46921d3652
docs: document commit signing requirement ( #47290 )
2025-05-30 10:59:29 +02:00
David Sanders
b303413a04
build: drop shx dependency ( #47293 )
2025-05-30 10:59:11 +02:00
David Sanders
83524adf17
chore: fix lint for ImageView doc ( #47304 )
2025-05-29 17:10:41 -04:00
David Sanders
14b3183eb5
ci: add a problem matcher for ESLint output ( #47303 )
2025-05-29 16:58:17 -04:00
David Sanders
0d70389ccb
chore: lint code blocks in docs with ESLint ( #42113 )
2025-05-29 12:45:26 -07:00
Niklas Wenzel
4e61f5b26f
fix: Squirrel.Mac crash when zip extraction fails ( #47271 )
...
* fix: Squirrel.Mac crash when zip extraction process fails to launch
* chore: add end-to-end test
2025-05-29 10:31:46 -07:00
Will Anderson
5b5f900e34
docs: add documentation for ImageView ( #46760 )
...
* docs: Add documentation for ImageView
* docs: Add ImageView main process module list in README.md
* test: Add some basic tests for ImageView
* test: Fill out Window embedding tests to better reflect how someone might use an ImageView
* docs: Add notes about using ImageView as a splash screen
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: Update ImageView example to show a more complete splash screen example
* docs: Remove view resizing logic since the ImageView automatically gets resized
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-29 10:24:16 -07:00
David Sanders
2e0b4eca94
build: remove unnecessary eslint-plugin-standard package ( #47283 )
2025-05-28 13:58:14 +02:00
David Sanders
3a32f25750
ci: audit important branches for CI errors ( #47207 )
...
* ci: audit important branches for CI errors
* chore: move message to Slack workflow
2025-05-27 11:35:33 -04:00
Erick Zhao
f6b8ee0731
chore: add .eslintrc.json for docs/fiddles ( #47269 )
2025-05-27 09:13:10 -05:00
Robo
5ccbfa2faf
fix: regression with directory selection in macOS dialogs ( #47259 )
2025-05-27 19:08:11 +09:00
Shelley Vohr
f89c2a0ef4
fix: titlebar showing in content protected window ( #47241 )
...
Closes https://github.com/electron/electron/issues/47152 .
2025-05-26 09:46:04 +02:00
Shelley Vohr
c6f368acc6
chore: debug crash on DevTools SetOwnerWindow ( #47243 )
2025-05-26 09:45:43 +02:00
David Sanders
5e3b5ef04c
chore: update @electron/lint-roller to 3.1.1 ( #47202 )
...
* chore: update @electron/lint-roller to 3.1.1
* docs: fix broken link in breaking-changes.md
* chore: fix for Node.js versions without require(esm)
2025-05-25 07:58:55 -05:00
John Kleinschmidt
ac5e3c76f3
build: migrate to new chromium git auth ( #47230 )
2025-05-25 07:57:20 -05:00
Gellert Hegyi
b9b96a96f7
feat: add menu item role palette and header ( #45538 )
...
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-05-23 12:43:49 -04:00
Charles Kerr
2248de847d
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop() ( #47201 )
...
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop()
2025-05-22 18:20:39 -05:00
Charles Kerr
38e7ff944e
refactor: make NativeWindow::has_frame_ const ( #47200 )
...
* refactor: make NativeWindow::is_modal_ const
* refactor: make NativeWindow::title_bar_style_ const and private
* refactor: make NativeWindow::has_client_frame() protected
refactor: make NativeWindow::transparent() protected
* refactor: make NativeWindow::enable_larger_than_screen() protected
* refactor: make NativeWindow::has_frame_ const
* fixup! refactor: make NativeWindow::has_client_frame() protected
fix: GetExpandedWindowSize()
2025-05-22 17:32:46 -05:00
David Sanders
8f09d7037b
ci: add problem matcher for patch conflict output ( #47183 )
2025-05-22 09:27:23 -04:00
David Sanders
d0102ff392
ci: add problem matcher for clang output ( #46577 )
2025-05-22 09:25:57 -04:00
Keeley Hammond
274e1df1ca
build: revert bump @octokit/rest from 20.1.1 to 21.1.1 ( #47208 )
...
Revert "build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 (#47159 )"
This reverts commit 517f5c15b9 .
2025-05-21 18:39:24 -07:00
John Kleinschmidt
b2d0074cc6
build: fix depot tool pathing on Windows ( #47194 )
...
build: properly set depot_tools pathing for Windows
2025-05-21 16:05:50 -07:00
Charles Kerr
2e8fc17f07
refactor: pass views::Widget* into constructors of our TreeHosts and NativeWidgets ( #47177 )
...
* refactor: remove unnecessary downcast in MenuViews::PopupAt()
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostLinux ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopNativeWidgetAura ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostWin ctor
* refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
* fixup! refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
fix: tyop
2025-05-21 16:02:55 -05:00
Charles Kerr
4af0c5d762
refactor: make NativeWindow::transparent_ const ( #47172 )
...
* refactor: use in-class member initialization for NativeWindow::widget_
* refactor: make NativeWindow::transparent_ const
refactor: make NativeWindow::enable_larger_than_screen_ const
* chore: make linter happy after rebase
2025-05-21 19:42:08 +02:00
Charles Kerr
a7a3e10300
refactor: prefer base::circular_deque over std::deque ( #47171 )
...
* refactor: use base::circular_deque in ResolveProxyHelper
* refactor: use base::circular_deque in GetExtraCrashKeys()
refactor: reduce visibility of kMaxCrashKeyValueSize
This change is to match Chromium's usage advice from
base/containers/README.md: `base:circular_deque` is preferred over
`std::deque` to provide consistent performance across platforms.
2025-05-21 12:04:36 -05:00
Shelley Vohr
7b77a24211
fix: remove extra 'suspend'/'resume' handling from powerMonitor ( #47162 )
...
fix: remove extra 'suspend'/'resume' handling from powerMonitor
2025-05-21 10:00:38 -05:00
David Sanders
7112c592c9
test: strip color output in ESM spec ( #47185 )
2025-05-21 10:50:06 +02:00
Charles Kerr
d6638f9564
refactor: make NativeWindow::pending_transitions_ a base::queue ( #47157 )
...
refactor: make NativeWindow::pending_transitions a base::queue
Follow the base/containers/README.md advice that "Chromium code should
always use `base::circular_deque` or `base::queue` in preference to
`std::deque` or `std::queue` due to memory usage and platform variation."
2025-05-20 17:35:51 -05:00
Charles Kerr
9f8bcc4d98
refactor: make NativeWindow::has_client_frame_ const ( #47156 )
2025-05-20 17:14:28 -05:00
Charles Kerr
21155679a0
refactor: add NativeWindowViews::GetClientFrameViewLinux() ( #47130 )
...
* refactor: add NativeWindowViews::GetClientFrameViewLinux()
* chore: clarify code comment
2025-05-20 14:15:06 -05:00
Charles Kerr
211faed848
refactor: add NativeWindow::IsActive() ( #47148 )
...
this was already present on macOS; use in NativeWindowViews too
2025-05-20 11:08:44 -04:00
Shelley Vohr
296e39456a
refactor: match upstream macOS a11y handling ( #47144 )
2025-05-20 11:06:57 -04:00
John Kleinschmidt
a19198d784
build: update_depot_tools on initial install ( #47160 )
...
this ensures that python is setup for proper use from depot_tools
2025-05-20 10:40:48 -04:00
reito
263c76df09
fix: prevent gc monitor 2nd pass crash ( #46987 )
2025-05-20 22:54:03 +09:00
dependabot[bot]
517f5c15b9
build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 ( #47159 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.1 to 21.1.1.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.1...v21.1.1 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 21.1.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-20 09:57:30 +02:00
dependabot[bot]
d29293556d
build(deps): bump github/codeql-action from 3.28.15 to 3.28.18 ( #47158 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.15 to 3.28.18.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](45775bd823...ff0a06e83c )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.18
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-20 09:56:54 +02:00
Shelley Vohr
e0ea069859
build: remove fix_linter_error.patch ( #47150 )
...
build: remove fix_linter_error.patch
2025-05-19 22:52:01 +02:00
electron-roller[bot]
7cc76c094a
chore: bump node to v22.15.1 (main) ( #47105 )
...
* chore: bump node in DEPS to v22.15.1
* chore: fixup patch indices
* src: fix error handling on async crypto operations
https://github.com/nodejs-private/node-private/pull/709
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-19 16:12:48 -04:00
Charles Kerr
3660432f42
refactor: NativeWindows should prefer widget() over GetWidget() for internal use ( #47133 )
2025-05-19 21:43:16 +02:00
Charles Kerr
687e50b4f3
refactor: add NativeWindowViews::SetTitleBarOverlay() ( #47126 )
...
* refactor: move SetTitleBarOverlay() impl to NativeWindowViews
* refactor: make NativeWindowViews::set_overlay_button_color() private
refactor: make NativeWindowViews::set_overlay_symbol_color() private
refactor: make NativeWindow::set_titlebar_overlay_height() protected
* refactor: simplify downcasting in NativeWindowViews::SetTitleBarOverlay()
2025-05-19 08:19:03 -05:00
David Sanders
d426667a01
build(dev-deps): update @electron/lint-roller and markdownlint-cli2 ( #47082 )
2025-05-19 14:19:04 +02:00
Charles Kerr
208bbc0504
refactor: add NativeWindow::SetShape() ( #47131 )
...
use NativeWindow::SetShape() in api::BaseWindow
2025-05-19 10:29:29 +02:00
dependabot[bot]
e2f496cfbc
build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.7.0 to 8.32.1 ( #47135 )
...
build(deps-dev): bump @typescript-eslint/eslint-plugin
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 8.7.0 to 8.32.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.32.1/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-version: 8.32.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-19 10:27:22 +02:00
Charles Kerr
1da150f9a3
chore: remove gclient sync macOS CI hack patch ( #47123 )
...
chore: remove hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch
2025-05-19 10:26:58 +02:00
Calvin
5dd6481e53
fix: explicit microtask scope DCHECK condition ( #47134 )
2025-05-19 12:08:59 +09:00
dependabot[bot]
d72e622a3f
build(deps): bump slackapi/slack-github-action from 2.0.0 to 2.1.0 ( #47060 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](485a9d42d3...b0fa283ad8 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-version: 2.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 12:55:00 -05:00
Charles Kerr
8efd24c339
perf: don't create unused menuitem icons ( #47100 )
...
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
2025-05-16 02:43:03 -05:00
Erick Zhao
dc34e8732c
docs: add note on DIP and DPI ( #47080 )
2025-05-15 16:51:49 -05:00
Charles Kerr
77c58658c5
refactor: decouple NativeWindowViews and GlobalMenuBarX11 ( #47094 )
...
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
2025-05-15 16:10:56 -05:00
Charles Kerr
d720aea700
refactor: make TrackableObject::weak_map_id() constexpr ( #47092 )
...
* refactor: make TrackableObject::weak_map_id() constexpr
refactor: make BaseWindow::GetID() inline and constexpr
* refactor: make NativeWindow::window_id() constexpr too
2025-05-15 16:10:33 -05:00
Charles Kerr
e2bcd8f0aa
test: fix desktopCapturer mocha syntax ( #47088 )
...
* test: fix desktopCapturer mocha syntax
do not nest `it` calls in desktopCapturer specs
* empty commit
2025-05-15 16:54:49 -04:00
Robo
99a3e360ec
fix: opening package paths as directory on macOS ( #47077 )
2025-05-15 12:47:46 -05:00
electron-roller[bot]
883f48b9b4
chore: bump chromium to 138.0.7178.0 (main) ( #47086 )
...
* chore: bump chromium in DEPS to 138.0.7178.0
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* chore: update patches
* 6509682: extensions: Use ChromeExtensionsBrowserClient on desktop Android, part 2
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6509682
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-15 12:47:07 -05:00
Charles Kerr
9a7b73b533
refactor: use kKeyModifiers in IsAltModifier() ( #47066 )
...
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
2025-05-14 11:00:00 -04:00
Charles Kerr
6170a5af40
chore: combine all the "patch out Profiles" changes into a single patch ( #47063 )
...
* chore: fold the profile patches into one patch
* chore: e patches all
* chore: patch out ProfileSelections::ApplyProfileSelection()
Another profile reference. Referenced iff making a debug build.
2025-05-14 09:21:11 -05:00
electron-roller[bot]
d65a856bf3
chore: bump chromium to 138.0.7177.0 (main) ( #47081 )
...
* chore: bump chromium in DEPS to 138.0.7177.0
* 6530423: [WebContents] Fix IsNeverComposited() calls during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6530423
* 6512551: [ios] Enable -Wobjc-property-assign-on-object-type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512551
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-14 10:08:31 -04:00
Shelley Vohr
f2639d13cc
refactor: remove CreateViewForWidget patch ( #46981 )
...
* refactor: remove CreateViewForWidget patch
* chore: rm unintended osr change
* Trigger CI
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-14 21:43:23 +09:00
Charles Kerr
11fa915724
refactor: remove introduce_ozoneplatform_electron_can_call_x11_property.patch ( #47075 )
...
* refactor: use x11_util::IsX11() in BuildSubmenuFromModel()
* refactor: use x11_util::IsX11() in ElectronDesktopWindowTreeHostLinux::OnBoundsChanged()
* refactor: use skia_can_fall_back_to_x11 in x11_util::IsX11()
it is identical in practice to electron_can_call_x11 and does not require a Chromium patch
* chore: remove introduce_ozoneplatform_electron_can_call_x11_property.patch
* refactor: use ui::GetOzonePlatformId() to test for x11
2025-05-14 13:38:35 +09:00
David Sanders
9aacc473e6
build: remove patch that landed upstream ( #47079 )
2025-05-13 20:10:48 -05:00
Charles Kerr
c218128675
chore: remove disable_unload_metrics.patch ( #47059 )
2025-05-13 14:55:59 -04:00
electron-roller[bot]
e3e647d21e
chore: bump chromium to 138.0.7175.0 (main) ( #46986 )
...
* chore: bump chromium in DEPS to 138.0.7166.0
* chore: bump chromium in DEPS to 138.0.7166.2
* 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* 6470924: Introduce auto-populated Search Engine icons.
https://chromium-review.googlesource.com/c/chromium/src/+/6470924
* 6502977: Force same tab navigation while actor coordinator is acting on a tab
https://chromium-review.googlesource.com/c/chromium/src/+/6502977
* chore: bump chromium in DEPS to 138.0.7168.0
* chore: update patches
* fix grit patch
* chore: bump Chromium to 138.0.7169.2
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
* 6493688: NavigationThrottleRunner2: void CreateThrottlesForNavigation
https://chromium-review.googlesource.com/c/chromium/src/+/6493688
* 6488755: Reland "WebSQL: Remove WebPreference"
https://chromium-review.googlesource.com/c/chromium/src/+/6488755
* 6428707: FSA: Only normalize the hardcoded rules once during initialization
https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* chore: fixup patch indices
* chore: bump chromium in DEPS to 138.0.7170.0
* 6514121: Remove origin calculation debug info and related methods
https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* chore: bump chromium in DEPS to 138.0.7172.0
* chore: bump chromium in DEPS to 138.0.7173.0
* chore: bump chromium in DEPS to 138.0.7175.0
* fixup! 6514121: Remove origin calculation debug info and related methods
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* 6531585: Don't retry LayerTreeSink creation on the high priority queue
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6531585
* 6512253: Modernize base::apple's base bundle ID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512253
* fixup! 6428707: FSA: Only normalize the hardcoded rules once during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-13 14:51:20 -04:00
Shelley Vohr
7ab032f594
fix: white window flicker on window creation ( #47022 )
2025-05-10 18:24:35 -05:00
Erick Zhao
2493e530d0
docs: unify [!NOTE] structure ( #46893 )
...
* docs: unify [!NOTE] structure
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/browser-window.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/download-item.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* Update docs/api/global-shortcut.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* revert line break
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-09 14:36:42 -07:00
Michaela Laurencin
10e4f9ad37
feat: enable secondary label for macOS menu ( #46887 )
...
* feat: enable secondary label for macOS menu
* Update shell/browser/ui/cocoa/electron_menu_controller.mm
Co-authored-by: Robo <hop2deep@gmail.com >
* fix for lint
* update docs for sublabel
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-05-09 12:05:26 -04:00
Michaela Laurencin
b9f0aebb2f
feat: enable innerWidth and innerHeight for window open ( #46749 )
...
* feat: enable innerWidth and innerHeight for window open
* update comment for added special innerWidth and innerHeight
* update 100 min spec requirement handling
* update testing to include getContentSize
* update macOS min requirement handling
* adjust refactored consts
* update const values from nativewindowviews
2025-05-09 12:03:45 -04:00
Shelley Vohr
8ecd731e96
fix: webview crash on focus ( #46979 )
2025-05-09 17:56:22 +02:00
Shelley Vohr
75cf8ea96d
fix: restore previous Windows screenshotting ( #47020 )
...
Fixes https://github.com/electron/electron/issues/45990
We previously made a change in https://github.com/electron/electron/pull/45868
to fix content protection being lost on hide and re-show. However, this
cause a breaking change where protected windows were made opaque black
instead of being hidden as before. This overrides relevant methods in
ElectronDesktopWindowTreeHostWin to restore the previous behavior.
without regressing the original issue.
2025-05-09 09:38:27 -05:00
Aman Karmani
376634c75a
feat: add support for --experimental-network-inspection ( #46690 )
...
* feat: add support for `--experimental-network-inspection`
* docs: fix minor formatting issues
visible on both GH[1] and the docs site[2]
[1] https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags
[2] https://www.electronjs.org/docs/latest/api/command-line-switches#--inspect-brkhostport
* docs: add entry for new nodejs flag
2025-05-09 09:44:14 -04:00
Robo
8e8d3a4f3e
fix: use-after-move of bus connection in xdg portal detection ( #47008 )
2025-05-09 18:32:08 +09:00
Charles Kerr
2cbd968da5
refactor: use gin_helper::Dictionary::ValueOrDefault() ( #46982 )
...
* refactor: use ValueOrDefault() in electron_api_web_contents.cc
* refactor: use ValueOrDefault() in electron_api_url_loader.cc
* refactor: use ValueOrDefault() in electron_download_manager_delegate.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in electron_url_loader_factory.cc
* refactor: use ValueOrDefault() in electron_browser_context.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in blink_converter.cc
* feat: add ValueOrDefault() to PersistentDictionary
* empty commit
* refactor: use ValueOrDefault() in blink_converter.cc
* refactor: inline the rectangle base::Value::Dict
* refactor: remove has_scroll temporary
---------
Co-authored-by: Deepak Mohan <hop2deep@gmail.com >
2025-05-08 14:17:22 -05:00
Keeley Hammond
aea7b4ae8c
build: update hasher return value ( #47009 )
2025-05-08 11:34:21 -07:00
Charles Kerr
9f8a629126
refactor: reduce use of NativeWidgetPrivate ( #46942 )
...
* refactor: do not use native_widget_private() in NativeWindowViews::SetContentProtection()
refactor: do not use native_widget_private() in NativeWindowViews::IsContentProtected()
* refactor: do not use native_widget_private() in NativeWindowViews::Show()
* chore: remove native_widget_private #include from native_window_views_win
Not needed since Feb 2025: 9199d5c6
2025-05-08 09:02:19 -05:00
Charles Kerr
d4ca829069
test: enable hasShadow tests on Linux ( #46984 )
...
refactor: enable hasShadow tests on Linux
2025-05-08 10:07:10 +02:00
Charles Kerr
54a6bbb4cb
build: remove skip_atk_toolchain_check.patch ( #46988 )
...
chore: remove skip_atk_toolchain_check.patch
2025-05-08 10:06:55 +02:00
Charles Kerr
24f1f7ed57
build: remove deps_add_v8_object_setinternalfieldfornodecore.patch ( #46992 )
...
chore: remove deps_add_v8_object_setinternalfieldfornodecore.patch
This was a Node 20-specific workaround that's no longer needed in Node 22.
Xref: https://github.com/nodejs/node/pull/49874 .
2025-05-08 09:39:58 +02:00
Keeley Hammond
153dae5b48
build: move release script to new hasher function ( #46989 )
...
build: move to new hasher function
2025-05-08 01:15:08 -05:00
Calvin
580fa57a29
refactor: Node.js temporary "explicit" microtask policy scope pattern ( #46973 )
...
refactor: Node.js explicit microtask scope pattern
2025-05-08 10:21:39 +09:00
Calvin
37639b5400
refactor: replace gin_helper::MicrotasksScope with v8::MicrotasksScope ( #46963 )
...
* Remove microtasks_scope.h and microtasks_scope.cc
* Use v8::MicrotasksScope when ignoring browser checkpoint
These call always skip the browser checkpoint, so they are equivalent to using v8::MicrotasksScope directly (modulo the optional wrapper behavior).
* Remove MicrotasksScope from node_bindings.cc
This code seems contradictory: it explicitly specifies "do not run microtasks" yet runs a microtask checkpoint in the browser process.
Looking at its history, it [was introduced][1] with the intention to not run microtasks, but a [subtle C++ language behavior][2] caused it to do the opposite later in the same roll. Since the original intention was to not run microtasks, and since that is also the simplest explanation, we can assume `ignore_browser_checkpoint` should be true and migrate this to `v8::MicrotasksScope` as it is equivalent (modulo the optional wrapper behavior).
[1]: a4ea80dd47 (diff-efe58cf03c97028f37f801db044d396a5f428686da6595d2c692f1c052bbd09c)
[2]: https://github.com/electron/electron/pull/43185
* Migrate gin_helper/promise.h and gin_helper/promise.cc to v8::MicrotasksScope
Restores the [original][1] behavior of running the microtask checkpoint at destruction, but preserves the behavior of running microtasks in the browser process. This had last changed in the migration to gin_helper::MicroTasks.
[1]: https://github.com/electron/electron/pull/16401
2025-05-07 14:10:34 -05:00
electron-roller[bot]
a8695d4387
chore: bump chromium to 138.0.7166.0 (main) ( #46975 )
...
* chore: bump chromium in DEPS to 138.0.7165.0
* 6492127: Add new less invasive context menu mode for mobile interesttarget
https://chromium-review.googlesource.com/c/chromium/src/+/6492127
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-07 13:04:15 -04:00
Charles Kerr
924a8da940
refactor: use WidgetDelegate::SetAccessibleTitle() ( #46765 )
...
* refactor: use WidgetDelegate::SetAccessibleTitle()
* test: add window.accessibleTitle tests
2025-05-07 10:44:53 -05:00
Shelley Vohr
c16ea8d54e
fix: printing when no mediaSize specified ( #46937 )
...
fix: printing when no mediaSize specified
2025-05-06 19:12:25 -05:00
Charles Kerr
b7ae162716
refactor: add gin_helper::Dictionary::ValueOrDefault() ( #46939 )
...
* feat: add gin_helper::Dictionary::ValueOrDefault()
A convenience function for using a default value if the
specified key isn't present in the dictionary.
* refactor: use ValueOrDefault() in native_window.cc
* refactor: use ValueOrDefault() in native_window_mac.mm
* refactor: use ValueOrDefault() in native_window_views.cc
* refactor: use ValueOrDefault() in electron_api_native_image.cc
2025-05-06 15:20:12 -05:00
Shelley Vohr
e876cecbc7
test: test menu rendering accelerators ( #44634 )
...
* test: test menu rendering accelerators
* Update spec/api-menu-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-06 14:09:35 -04:00
electron-roller[bot]
c4ac192aa4
chore: bump chromium to 138.0.7164.0 (main) ( #46948 )
...
* chore: bump chromium in DEPS to 138.0.7164.0
* 6508870: Add missing PermissionType mapping and remove default case.
https://chromium-review.googlesource.com/c/chromium/src/+/6508870
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-06 14:01:37 -04:00
Charles Kerr
8308ac29c8
refactor: pass gfx::ResizeEdge by value ( #46935 )
...
refactor: pass gfx::ResizeEdge by value
It is an enum class, so no reason to pass by reference
2025-05-06 11:57:53 -05:00
Shelley Vohr
206544cbc0
fix: crash on macOS dialog after window-all-closed ( #46927 )
...
fix: crash on dialog after window-all-closed
2025-05-06 07:47:50 -05:00
Shelley Vohr
a5ec3f7476
fix: allowed dialog file types with one filter ( #46900 )
2025-05-06 10:31:00 +02:00
Erick Zhao
be399f2fee
docs: use correct heading level for API function ( #46892 )
2025-05-05 16:10:37 -05:00
electron-roller[bot]
b90de7d07e
chore: bump chromium to 138.0.7160.0 (main) ( #46915 )
...
* chore: bump chromium in DEPS to 138.0.7158.0
* chore: bump chromium in DEPS to 138.0.7160.0
* 6509206: Move Keychain UI suppression code into apple_keychain.cc
https://chromium-review.googlesource.com/c/chromium/src/+/6509206
* 6489036: Fix DesktopDataControlsDialog for Glic
https://chromium-review.googlesource.com/c/chromium/src/+/6489036
* chore: fixup patch indices
* 6506662: Reland "NavigationThrottleRunner2: content::NavigationThrottleRegistry"
https://chromium-review.googlesource.com/c/chromium/src/+/6506662
* 6499811: [video pip] Add live caption dialog
https://chromium-review.googlesource.com/c/chromium/src/+/6499811
* 6487926: Add GetMaxImageDimension function to ScreenAI service API for OCR.
https://chromium-review.googlesource.com/c/chromium/src/+/6487926
* 6494942: [json] Activate stringify fast-path by default
https://chromium-review.googlesource.com/c/v8/v8/+/6494942
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-05 13:58:40 -04:00
Charles Kerr
9460300506
refactor: devirtualize NativeWindow methods ( #46904 )
...
* refactor: devirtualize NativeWindow::SetSize()
refactor: devirtualize NativeWindow::GetSize()
refactor: devirtualize NativeWindow::SetPosition()
refactor: devirtualize NativeWindow::GetPosition()
* refactor: devirtualize NativeWinodw::SetMinimumSize()
refactor: devirtualize NativeWinodw::GetMinimumSize()
refactor: devirtualize NativeWinodw::SetMaximumSize()
refactor: devirtualize NativeWinodw::GetMaximumSize()
* refactor: devirtualize NativeWindow::SetSheetOffset()
refactor: devirtualize NativeWindow::GetSheetOffsetX()
refactor: devirtualize NativeWindow::GetSheetOffsetY()
* refactor: devirtualize NativeWindow::GetContentMinimumSize()
refactor: devirtualize NativeWindow::GetContentMaximumSize()
2025-05-05 09:29:05 -05:00
Charles Kerr
3362db0655
refactor: remove some NativeWindow public API ( #46919 )
...
* refactor: make NativeWindow::titlebar_overlay_height_ private
* refactor: make NativeWindow::set_has_frame() protected
* refactor: remove NativeWindow::background_material()
It's only used once, in NativeWindow, so use |background_material_| directly.
* refactor: remove NativeWindow::vibrancy()
It's only used once, in a NativeWindow method, so use |vibrancy_| directly.
* refactor: unfriend api::BrowserView
It was added in Oct 2022 by 23d4a25 for access to protected NativeWindow
methods add_inspectable_view() and remove_inspectable_view().
That dependency was removed in Nov 2022 by 184ac2b , so BrowserView
doesn't need access to NativeWindow's private fields & methods anymore.
* refactor: make NativeWindow::ContentBoundsToWindowBounds() protected
refactor: make NativeWindow::WindowBoundsToContentBounds() protected
2025-05-05 09:28:49 -05:00
Charles Kerr
2e2776611f
refactor: simplify NativeWindow::FullScreenTransitionState ( #46918 )
...
* refactor: make NativeWindow::fullscreen_transition_state_ private
* refactor: add NativeWindow::is_transitioning_fullscreen() helper
* refactor: remove unused NativeWindow::fullscreen_transition_state()
* refactor: replace NativeWindow::set_fullscreen_transition_state() with NativeWindow::set_is_transitioning_fullscreen()
refactor: remove unused NativeWindow::FullScreenTransitionState
2025-05-05 09:28:29 -05:00
Charles Kerr
1f4f1b4afc
refactor: add NativeWindow::FromWidget() helper ( #46917 )
...
refactor: add NativeWindow::FromWidet() helper
refactor: make kElectronNativeWindowKey a protected field
2025-05-05 09:27:41 -05:00
electron-roller[bot]
cb445b3bbd
chore: bump node to v22.15.0 (main) ( #46742 )
...
* chore: bump node in DEPS to v22.15.0
* inspector: fix GN build
https://github.com/nodejs/node/pull/56798
* test: search cctest files
https://github.com/nodejs/node/pull/56791
* crypto: fix missing OPENSSL_NO_ENGINE guard
https://github.com/nodejs/node/pull/57012
* test,crypto: make tests work for BoringSSL
https://github.com/nodejs/node/pull/57021
* module: use synchronous hooks for preparsing in import(cjs)
https://github.com/nodejs/node/pull/55698
* deps: update simdjson to 3.12.0
https://github.com/nodejs/node/pull/56874
* build: remove explicit linker call to libm on macOS
https://github.com/nodejs/node/pull/56901
* test: make eval snapshot comparison more flexible
https://github.com/nodejs/node/pull/57020
* src: allow embedder customization of OOMErrorHandler
https://github.com/nodejs/node/pull/57325
* src: do not pass nullptr to std::string ctor
https://github.com/nodejs/node/pull/57354
* src: lock the isolate properly in IsolateData destructor
https://github.com/nodejs/node/pull/57031
* chore: shrink --trace-atomics-wait patch
* chore: fixup patch indices
* build: fix GN build failure
https://github.com/nodejs/node/pull/57013
* crypto: expose security levels
https://github.com/nodejs/node/pull/56601
* zlib: add zstd support
https://github.com/nodejs/node/pull/52100
* test: move crypto related common utilities in common/crypto
https://github.com/nodejs/node/pull/56714
* cli: move --trace-atomics-wait to eol
https://github.com/nodejs/node/pull/52747
* test: disable test-https-client-renegotiation-limit
BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-05-05 10:23:17 +02:00
Robo
91626a8eac
fix: xdg portal version detection for file dialogs on linux ( #46905 )
...
* chore: use dbus thread for portal version detection
* Update shell/browser/ui/file_dialog_linux_portal.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-05-05 16:57:20 +09:00
electron-roller[bot]
5390728cb7
chore: bump chromium to 138.0.7156.0 (main) ( #46902 )
...
* chore: bump chromium in DEPS to 138.0.7156.0
* chore: update patches
* chore: ICWYU
* Allow SecKeychain and SecItem implementations of AppleKeychain to coexist
https://chromium-review.googlesource.com/c/chromium/src/+/6444777
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-02 21:06:50 -04:00
Derek Cicerone
074b9344b5
fix: prevent log files being written to current directory on Windows ( #44413 )
...
* fix: prevent log files being written to current directory on Windows
* Update shell/common/logging.cc
Co-authored-by: Robo <hop2deep@gmail.com >
* chore: add test
* chore: update includes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6418805
* chore: address review feedback
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-05-02 16:27:29 -05:00
Charles Kerr
3faddd5ae2
refactor: move IsClosed() and IsClosable() tests into NativeWindow::Close() ( #46888 )
...
refactor: devirtualize NativeWindow::IsClosed()
2025-05-02 13:21:29 -05:00
Yuri
7153008bfa
docs: clarified usage of createFromPath() ( #46809 )
...
* docs: clarified usage of createFromPath()
* Update docs/api/native-image.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-05-02 11:11:54 +02:00
Charles Kerr
f6b297a06a
refactor: use base::ObserverList::Notify() ( #46875 )
...
* refactor: use ObserverList::Notify() in shell/browser/window_list.cc
* refactor: use ObserverList::Notify() in shell/browser/web_contents_zoom_controller.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/usb_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/electron_usb_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/views/menu_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/tray_icon.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/electron_menu_model.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/serial_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/native_window.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/electron_serial_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/browser.cc
* refactor: use ObserverList::Notify() in shell/browser/api/electron_api_web_contents.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/electron_hid_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/hid_chooser_context.cc
2025-05-02 11:10:52 +02:00
Shelley Vohr
ede84fc327
feat: support dip <-> screen conversion on Linux X11 ( #46211 )
...
feat: support dip <-> screen conversion on Linux
2025-05-02 10:31:45 +02:00
electron-roller[bot]
2b07e6450c
chore: bump chromium to 138.0.7154.0 (main) ( #46872 )
...
* chore: bump chromium in DEPS to 138.0.7152.0
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7154.0
* chore: update patches
* ozone/wayland: Fix bookmark dropdown right click context menu
https://chromium-review.googlesource.com/c/chromium/src/+/6488801
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* [A11yPerformance] Remove Add/Remove AXMode methods
https://chromium-review.googlesource.com/c/chromium/src/+/6418444
xref: https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* build: update filenames.libcxx.gni
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* Use getters to expose NativePixmapHandle from GpuMemoryBufferHandle
https://chromium-review.googlesource.com/c/chromium/src/+/6374406
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-01 23:53:40 -05:00
Keeley Hammond
63114e2b8e
fix: revert macOS content protection logic refactor ( #46886 )
...
Revert "refactor: use upstream content protection logic on macOS (#46813 )"
This reverts commit 34adb976b6 .
2025-05-01 13:49:55 -07:00
Charles Kerr
df4564dc39
refactor: don't call deprecated WidgetDelegate API in NativeWindowViews ( #46858 )
...
* refactor: don't call RegisterDeleteDelegateCallback()
move NativeWindowViews' on-widget-delegate-destroyed callback logic to
the NativeWindowViews destructor.
Since NativeWindowViews subclasses from WidgetDelegate and |this| *is*
the delegate being destroyed, we can handle this more cleanly in
~NativeWindowViews() instead of in a separate callback.
* chore: remove NativeWindowViews from the grandfathered-classes-that-can-call-deprecated-views-behavior patch
* refactor: don't call RegisterDeleteDelegateCallback()
RegisterDeleteDelegateCallback() is private upstream API, so we
shouldn't be using it.
Move the on-widget-delegate-destroyed callback logic over to our methods
NativeWindowViews::OnWidgetDestroying() and
NativeWindowViews::OnWidgetDestroyed().
2025-05-01 12:07:20 -05:00
David Sanders
4f89c31956
refactor: add EmitDeprecationWarning helper ( #46860 )
...
* refactor: add EmitDeprecationWarning helper
Also switches EmitWarning to using Node's ProcessEmitWarningGeneric
* chore: use node namespace for function call
2025-04-30 13:48:35 -05:00
Charles Kerr
25d77fd1ce
refactor: use WidgetDelegate's title property ( #46849 )
...
* refactor: use WidgetDelegate::SetTitle()
* Make NativeWindow::SetTitle() and NativeWindow::GetTitle() non-virtual.
Use WidgetDelegate for their implementation.
* Add NativeWindow::OnTitleChanged(), a new protected virtual method to update
subclasses (e.g. NativeWindowMac needs to redraw the button proxy).
* In NativeWindowMac, replace SetTitle() and GetTitle() with OnTitleChanged().
* In NativeWindowViews, replace SetTitle() and GetTitle() with OnTitleChanged().
* test: enable BrowserWindow.title tests on Linux
* test: add a test to confirm win.title changes when document.title is set in the renderer
2025-04-30 08:22:27 -07:00
electron-roller[bot]
d842d17ff3
chore: bump chromium to 137.0.7151.0 (main) ( #46854 )
...
* chore: bump chromium in DEPS to 137.0.7151.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-04-29 16:49:44 -04:00
dependabot[bot]
ecd745305e
build(deps): bump actions/download-artifact from 4.2.1 to 4.3.0 ( #46852 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](95815c38cf...d3f86a106a )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 4.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-29 11:20:23 -04:00
Charles Kerr
2734088d20
fix: fix and enable accessibilitySupportEnabled tests ( #46825 )
...
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* test: enable accessibilitySupportEnabled tests
test: check both getters after calling each setter
fix: do not assume the default initial value of accessibilitySupportEnabled
* chore: remove redundant test case
* chore: disable accessibilitySupportEnabled tests on Linux
2025-04-28 23:52:26 -05:00
zoy
4641bc9619
fix: fullscreen fillet / recovery is incorrect ( #46641 )
...
* fix: fullscreen fillet / recovery is incorrect
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
* fix: maintain frameless consistency on windows 11
* fix: maintain frameless consistency on windows 11
* chore: modify the comments
---------
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
2025-04-28 16:54:08 -04:00
Charles Kerr
3f3c297c7a
fix: enable some tests that were accidentally disabled ( #46816 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* chore: make the process.platform test simpler
* fix: tests that were not run in api-app-spec due to nested it()
* fix: tests that were not run in api-browser-window-spec due to nested it()
* chore: annotate disabled test
* fix: enable `autoHideMenuBar` tests on Linux and Windows (#46818 )
* fix: enable autoHideMenuBar tests
* docs: mark autoHideMenuBar as supported on Linux, Windows
2025-04-28 12:32:57 -05:00
Bruno Pitrus
062d3a6168
fix: build error with enable_electron_extensions=false ( #46812 )
...
Fix build error with enable_electron_extensions=false
In file included from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.h:13,
from ../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr.h:50,
from ../../base/memory/raw_ptr.h:11,
from ../../base/memory/weak_ptr.h:82,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:14,
from ../../electron/shell/browser/usb/electron_usb_delegate.cc:5:
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:279:3: warning: multi-line comment [-Wcomment]
279 | // \
| ^
../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h:281:3: warning: multi-line comment [-Wcomment]
281 | // \
| ^
In file included from /usr/include/c++/14/memory:78,
from ../../electron/shell/browser/usb/electron_usb_delegate.h:8:
/usr/include/c++/14/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = device::mojom::UsbDeviceInfo]’:
/usr/include/c++/14/bits/unique_ptr.h:399:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = device::mojom::UsbDeviceInfo; _Dp = std::default_delete<device::mojom::UsbDeviceInfo>]’
399 | get_deleter()(std::move(__ptr));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../../mojo/public/cpp/bindings/struct_ptr.h:48:3: required from ‘constexpr void std::destroy_at(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
48 | ~StructPtr() = default;
| ^
/usr/include/c++/14/bits/stl_construct.h:149:22: required from ‘constexpr void std::_Destroy(_Tp*) [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
149 | std::destroy_at(__pointer);
| ~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:163:19: required from ‘static constexpr void std::_Destroy_aux<<anonymous> >::__destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; bool <anonymous> = false]’
163 | std::_Destroy(std::__addressof(*__first));
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_construct.h:193:44: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*]’
193 | return std::_Destroy_aux<false>::__destroy(__first, __last);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/alloc_traits.h:981:20: required from ‘constexpr void std::_Destroy(_ForwardIterator, _ForwardIterator, allocator<_T2>&) [with _ForwardIterator = mojo::StructPtr<device::mojom::UsbDeviceInfo>*; _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>]’
981 | std::_Destroy(__first, __last);
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_vector.h:735:15: required from ‘constexpr std::vector<_Tp, _Alloc>::~vector() [with _Tp = mojo::StructPtr<device::mojom::UsbDeviceInfo>; _Alloc = std::allocator<mojo::StructPtr<device::mojom::UsbDeviceInfo> >]’
735 | std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
| ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
736 | _M_get_Tp_allocator());
| ~~~~~~~~~~~~~~~~~~~~~~
../../electron/shell/browser/usb/electron_usb_delegate.cc:231:74: required from here
231 | std::move(callback).Run(std::vector<device::mojom::UsbDeviceInfoPtr>());
| ^
/usr/include/c++/14/bits/unique_ptr.h:91:23: error: invalid application of ‘sizeof’ to incomplete type ‘device::mojom::UsbDeviceInfo’
91 | static_assert(sizeof(_Tp)>0,
| ^~~~~~~~~~~
2025-04-28 11:56:17 -04:00
electron-roller[bot]
f2240e07f0
chore: bump chromium to 137.0.7149.0 (main) ( #46777 )
...
* chore: bump chromium in DEPS to 137.0.7144.0
* chore: bump chromium in DEPS to 137.0.7145.0
* chore: bump chromium in DEPS to 137.0.7147.0
* chore: update patches
* Remove deprecated GetVar(std::string_view, std::string*) overload
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6468873
* fixup! Remove deprecated GetVar(std::string_view, std::string*) overload
* fixup! Remove deprecated GetVar(std::string_view, std::string*) overload
* chore: bump chromium in DEPS to 137.0.7149.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-28 11:39:12 -04:00
David Sanders
0c103f390c
test: refactor deprecate-helpers.ts to warning-helpers.ts ( #46808 )
...
Add a generic expectWarningMessages and start checking warning names
2025-04-28 11:18:34 -04:00
Charles Kerr
27f6adf8df
fix: run visibleOnAllWorkspaces tests on the right platforms ( #46815 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* chore: make the process.platform test simpler
2025-04-28 10:34:00 -04:00
Shelley Vohr
b03c71213e
refactor: use upstream content protection logic on macOS ( #46780 )
...
* refactor: use upstream content protection logic on macOS
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-26 11:31:30 -05:00
Charles Kerr
c2ab63f6d7
refactor: use absl::InlinedVector in ToV8(ElectronPermissionManager) ( #44854 )
...
perf: use a stack-allocated string_view array in ToV8(USBProtectedClasses)
2025-04-25 16:11:15 -05:00
Calvin
b92c68b053
docs: call out breaking change for GTK 4 default on GNOME ( #46793 )
...
docs: add breaking change for GTK 4 default on GNOME
2025-04-25 13:31:28 -07:00
Charles Kerr
450b2d0ba3
refactor: remove public method BrowserWindow::GetWeakPtr() ( #46763 )
...
refactor: remove public method electron::api::BrowserWindow::GetWeakPtr()
2025-04-25 15:01:52 -05:00
Charles Kerr
b40b4dc015
refactor: use std::map::try_emplace() over std::map::insert() ( #46761 )
...
refactor: prefer std::map::try_emplace() over std::map::insert()
2025-04-25 13:11:53 -05:00
Evan Simkowitz
8fa7d324d1
fix: set XDG_CURRENT_DESKTOP env var back to original value before invoking xdg utils ( #45310 )
...
* Fix XDG_CURRENT_DESKTOP before invoking XDGUtil
* apply suggestion
* use existing XDG_CURRENT_DESKTOP const
2025-04-25 11:31:36 -05:00
Felix Rieseberg
7fa297a849
docs: Add ObjC/macOS tutorial ( #46694 )
2025-04-25 10:29:25 -05:00
John Kleinschmidt
55505ba4df
docs: additional update of breaking changes for 36-x-y ( #46781 )
2025-04-25 11:28:33 -04:00
Shelley Vohr
372cdb5dee
fix: bluetooth crash in select-bluetooth-device event ( #46745 )
...
fix: bluetooth crash on bluetooth off
2025-04-25 10:26:19 -05:00
Calvin
973e5d0249
build: update NMV to 136 for Electron 37 ( #46764 )
...
build: update NMV to 136 for Electron 36
2025-04-25 11:20:29 -04:00
Michaela Laurencin
0171f648b1
docs: correct breaking-changes.md for 36.0.0 release ( #46762 )
2025-04-25 16:10:35 +02:00
Charles Kerr
74c4ae0b55
refactor: use net::CanonicalCookie::IsDomainMatch() ( #46748 )
...
* refactor: use net::CanonicalCookie::IsDomainMatch()
Previously we had been rolling our own impl
* test: add pattern-matching tests for our cookie API
2025-04-25 16:08:16 +02:00
Charles Kerr
06a99d6770
refactor: make node Buffers more friendly to base::span / std::span ( #46724 )
...
* refactor: add electron::Buffer namespace; move the Buffer as_byte_span() into it
* feat: add electron::Buffer::Copy()
a span-friendly version of node::Buffer::Copy()
* refactor: use electron::Buffer::Copy() in electron_api_base_window.cc
* refactor: use electron::Buffer::Copy() in electron_api_data_pipe_holder.cc
* refactor: use electron::Buffer::Copy() in electron_api_safe_storage.cc
* refactor: use electron::Buffer::Copy() in electron_api_clipboard.cc
* refactor: use electron::Buffer::Copy() in osr_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_native_image.cc
* refactor: use electron::Buffer::Copy() in net_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_web_contents.cc
* refactor: make NewEmptyBuffer() return a Local<Value>
2025-04-25 08:00:09 -05:00
Shelley Vohr
1976e935e7
fix: missing HandleScope in RemoveFromParentChildWindows ( #46758 )
2025-04-25 14:04:25 +02:00
Calvin
51dbe69e45
fix: vibrancy window border ( #46648 )
...
* fix: vibrancy window border
* Use WidgetDelegate::OnWidgetInitialized instead
2025-04-25 11:42:48 +02:00
Calvin
08318dc05d
fix: corner smoothing with 0 radii ( #46751 )
2025-04-25 10:54:04 +02:00
wujinli
3e78bbde6a
fix: crash when renderer process crashes while webview is reloading ( #46735 )
...
WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
and triggers a fatal NOTREACHED.
2025-04-25 10:10:27 +02:00
electron-roller[bot]
37f8db15e9
chore: bump chromium to 137.0.7143.0 (main) ( #46757 )
...
* chore: bump chromium in DEPS to 137.0.7142.0
* chore: bump chromium in DEPS to 137.0.7143.0
* Add accelerator API to get shortcut vector representation
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6442193
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-25 14:53:51 +09:00
electron-roller[bot]
08b7a1f801
chore: bump chromium to 137.0.7141.0 (main) ( #46725 )
...
* chore: bump chromium in DEPS to 137.0.7139.0
* chore: bump chromium in DEPS to 137.0.7141.0
* chore: update patches
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6474596
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6443472
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6471184
* [ServiceWorker] Pipe is_for_service_worker into OverrideURLLoaderFactoryParams
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6459481
* Reland "[PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6455975
* clickiness: Check attestation and user settings on origins
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6356796
* extensions : Move ReloadExtension from ExtensionService
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6472812
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6472777
* fixup! Update AppleKeychain API to be friendlier
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6443472
* chore: script/gen-libc++-filenames.js
* Rename ColorVariant::CovertToSkColor() to ColorVariant::ResolveToSkColor()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6373793
* [headless] Provide headless aware window metrics on Windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-24 17:18:38 +09:00
Charles Kerr
e9f279afd1
chore: remove WebContents.getNativeView() ( #46734 )
...
chore: remove never-used WebContents.getNativeView().
This was added in https://github.com/electron/electron/pull/10308 but
was never used and never documented, not even as experimental API.
2025-04-23 20:33:50 -05:00
Charles Kerr
c7b0bdab7e
fix: explicitly call GetNativeNSView() on macOS ( #46733 )
...
* fix: explicitly call GetNativeNSView() on macOS
* chore: move macOS impl to a .mm file
This is needed in order to access gfx::NativeView::GetNativeNSView()
2025-04-23 17:55:18 -05:00
Charles Kerr
686ae47696
refactor: remove redundant NativeImage::GetBitmap() ( #46696 )
...
* refactor: remove redundant NativeImage::GetBitmap()
* docs: mark NativeImage.getBitmap() as deprecated
* have getBitmap() emit a deprecation warning
* docs: update obsolete refefence to getBitmap()
* test: update obsolete refefences to getBitmap()
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-04-23 11:00:43 +02:00
electron-roller[bot]
dd03cceda0
chore: bump chromium to 137.0.7128.1 (main) ( #46482 )
...
* chore: bump chromium in DEPS to 137.0.7107.0
* chore: bump chromium in DEPS to 137.0.7109.0
* chore: bump chromium in DEPS to 137.0.7111.0
* chore: bump chromium in DEPS to 137.0.7113.0
* 6384240: Remove double-declaration for accessibility on macOS | https://chromium-review.googlesource.com/c/chromium/src/+/6384240
* 6422872: Remove unused includes in isolation_info_mojom_traits.h | https://chromium-review.googlesource.com/c/chromium/src/+/6422872
* chore: update patches
* 6400733: Avoid ipc_message_macros.h usage in some foo_param_traits_macros.h files | https://chromium-review.googlesource.com/c/chromium/src/+/6400733
* chore: update patches
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: iwyu
* refactor: prefer value initialization over memset()
From the looks up upstream commits in base/, it looks like memset()
could trigger `-Wunsafe-buffer-usage` warnings soon?
Value initialization is more C++ish and less error-prone anyway,
due to memset()'s easily swappable parameters.
* refactor: NotifyIcon::InitIconData() returns a NOTIFYICONDATA
This follows F.20 in the C++ Core Guidelines and also removes the need
for memset()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- strcmp()
* fixup! 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* 6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: bump chromium in DEPS to 137.0.7115.0
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: update patches
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* fix: add pragma for MacSDK unsafe buffers | 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: bump chromium in DEPS to 137.0.7117.0
* chore: update patches
* chore: update filesnames.libcxx.gni
* 6431756: Replace SetOwnedByWidget() bool arg with a PassKey. | https://chromium-review.googlesource.com/c/chromium/src/+/6431756
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* 6428345: Remove ExtensionService usage from ChromeExtensionRegistrarDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/6428345
* 6384315: Migrate extensions_enabled from ExtensionService to Registrar | https://chromium-review.googlesource.com/c/chromium/src/+/6384315
* 6428749: [extensions] Refactor ExtensionService for AddNewAndUpdateExtension. | https://chromium-review.googlesource.com/c/chromium/src/+/6428749
* chore: bump chromium in DEPS to 137.0.7119.0
* 6440290: corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* 6429230: FSA: Move blocked paths to the PermissionContext class | https://chromium-review.googlesource.com/c/chromium/src/+/6429230
* chore: update patches
* chore: bump chromium in DEPS to 137.0.7121.0
* chore: update patches
* fix: partially revert 6443473: Remove ItemDelete from the Mac version of AppleKeychain | https://chromium-review.googlesource.com/c/chromium/src/+/6443473
* fix: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 137.0.7123.0
* chore: update patches
* chore: "grandfather in" electron views too
Lock further access to View::set_owned_by_client() | https://chromium-review.googlesource.com/c/chromium/src/+/6448510
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* refactor: grandfather in AutofillPopupView as a subclass of WidgetDelegateView
Add a PassKey for std::make_unique<WidgetDelegateView>() | https://chromium-review.googlesource.com/c/chromium/src/+/6442265
* Provide dbus appmenu information on Wayland | https://chromium-review.googlesource.com/c/chromium/src/+/6405535
* [extensions] Move OnExtensionInstalled out of ExtensionService. | https://chromium-review.googlesource.com/c/chromium/src/+/6443325
* refactor: grandfather in NativeWindowViews for delete callbacks
6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: merge the four "grandfather" patches into one
* [A11yPerformance] Remove IsAccessibilityAllowed() | 6404386: [A11yPerformance] Remove IsAccessibilityAllowed() | https://chromium-review.googlesource.com/c/chromium/src/+/6404386
NB: the changes here are copied from the upstream changes in
chrome/browser/ui/webui/accessibility/accessibility_ui.cc
* 6420753: [PermissionOptions] Use PermissionDescriptorPtr in PermissionController | https://chromium-review.googlesource.com/c/chromium/src/+/6420753
* 6429573: [accessibility] Move mode change out of AccessibilityNotificationWaiter | https://chromium-review.googlesource.com/c/chromium/src/+/6429573
* chore: e patches all
* 6419936: [win] Change ScreenWin public static methods to virtual | https://chromium-review.googlesource.com/c/chromium/src/+/6419936
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- fprintf()
- fputs()
- snprintf()
- vsnprintf()
* fix: size conversion FTBFS on Win
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcscpy_s()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcsncpy_s()
* chore: update mas_avoid_private_macos_api_usage.patch.patch
6394283: Remove double-declaration for accessibility on iOS | https://chromium-review.googlesource.com/c/chromium/src/+/6394283
Lots of context shear in this commit but the only interesting part is:
-+ return nullptr;
++ return {};
Which is needed because the return type is sometimes not a pointer.
* chore: e patches all
* chore: disable -Wmacro-redefined warning in electron_main_win.cc
* chore: bump chromium in DEPS to 137.0.7123.5
* refactor: patch electron PermissionTypes into blink
6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: e patches all
* chore: remove the box_painter_base.cc part of feat_corner_smoothing_css_rule_and_blink_painting.patch
as per code review @ https://github.com/electron/electron/pull/46482#pullrequestreview-2777338370
* test: enable window-smaller-than-64x64 test on Linux
* chore: bump chromium in DEPS to 137.0.7124.1
* chore: bump chromium in DEPS to 137.0.7125.1
* chore: bump chromium in DEPS to 137.0.7127.3
* 6459201: [Extensions] Remove ExtensionSystem::FinishDelayedInstallationIfReady() | https://chromium-review.googlesource.com/c/chromium/src/+/6459201
* 6454796: [Extensions] Move (most) registrar delayed install logic to //extensions | https://chromium-review.googlesource.com/c/chromium/src/+/6454796
* chore: bump chromium in DEPS to 137.0.7128.1
* chore: e patches all
* chore: node ./script/gen-libc++-filenames.js
* [views] Gate DesktopWindowTreeHostWin::window_enlargement_ behind flag
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428649
* feat: allow opt-out animated_content_sampler.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6438681
* Trigger CI
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-04-22 15:53:29 -04:00
Kolja
d0e13cc262
fix: file dialog filters not working correctly ( #46660 )
2025-04-22 13:31:04 +02:00
Shelley Vohr
858a93f886
build: don't kill ssh sessions on checkout failure ( #46708 )
2025-04-22 13:30:27 +02:00
Michaela Laurencin
e383eaa465
fix: stop menu minimization if set false ( #46279 )
2025-04-22 10:58:30 +02:00
Milan Burda
274b148554
docs: cleanup docs/tutorial/custom-window-styles.md ( #46597 )
2025-04-22 10:23:35 +02:00
Charles Kerr
7083419361
refactor: make electron::api::BaseWindow fields private ( #46689 )
...
refactor: make electron::api::BaseWindow fields private
2025-04-22 10:19:11 +02:00
reito
ac2c0c76fe
fix: osr stutter fix backport for electron. ( #46650 )
...
* fix: osr stutter fix backport for electron.
* nit: chromium upstream patch link
2025-04-22 10:18:21 +02:00
Michaela Laurencin
3ad87787f8
docs: update timelines for E37 ( #46704 )
2025-04-21 13:34:02 -07:00
Robo
ec8f7f185e
fix: crash on reconversion with google IME and editcontext on macOS ( #46688 )
2025-04-21 09:49:14 +09:00
Calvin
f15fa56e38
refactor: reduce & remove no-op MicrotasksScope calls ( #46681 )
...
* fix: do not run microtasks in V8Serializer in browser process
* Remove no-op MicrotasksScope in `shell/browser/api/electron_api_auto_updater.cc`
This call was added in https://github.com/electron/electron/pull/40576 as an expansion of `gin_helper::EmitEvent`.
Since this only runs in the browser process and `bool ignore_browser_checkpoint = true` this code is a no-op.
Node should perform a microtask checkpoint if necessary in `node::MakeCallback`.
* Remove no-op MicrotasksScope in `shell/common/api/electron_bindings.cc`
This method is only called by the browser process. The containing function, `ElectronBindings::DidReceiveMemoryDump`, is only used in two places:
* `ElectronBindings::GetProcessMemoryInfo` in the same file, which has a `CHECK` that it's running in the browser process at the top.
* From `shell/browser/api/electron_api_web_contents.cc`, which is only run in the browser process.
Added a DCHECK for clarity and validation.
* Replace `gin_helper::MicrotasksScope` with `v8::MicrotasksScope` in `shell/renderer/`
The browser check is unnecessary in the renderer. Since `gin_helper::MicrotasksScope` will always act exactly like `v8::MicrotasksScope`, it's clear to just use the v8 object directly. This also brings them in line with the many other uses of `v8::MicrotasksScope` in `shell/renderer/`.
2025-04-19 12:18:03 -05:00
Charles Kerr
297c4297b1
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver() ( #46672 )
...
perf: avoid triple map lookup in ElectronHidDelegate::GetContextObserver()
2025-04-19 10:51:52 -05:00
Calvin
3a982ecad5
fix: do not run microtasks in V8Serializer in browser process ( #46668 )
2025-04-19 11:43:02 +09:00
Charles Kerr
926a6ee8bd
refactor: remove WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK ( #46670 )
...
refactor: remove electron::WebContentsPermissionHelper::PermissionTypes::KEYBOARD_LOCK
This was added in 344aba0 . In the time when this PR initially went up and
when 344aba0 landed, upstream added blink::PermissionTypes::KEYBOARD_LOCK.
Our duplicate copy can be removed.
2025-04-18 16:14:45 -05:00
Shelley Vohr
437542767a
fix: backgroundMaterial on initial activate ( #46657 )
...
* fix: backgroundMaterial on initial activate
Closes https://github.com/electron/electron/issues/38466
* Update patches/chromium/fix_activate_background_material_on_windows.patch
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-17 20:34:45 +02:00
Shelley Vohr
a29e1170b9
feat: support Web Serial & WebUSB blocklists ( #46600 )
2025-04-17 20:34:34 +02:00
Shelley Vohr
352a403efd
fix: postMessage crash with invalid transferrable ( #46639 )
2025-04-17 15:09:48 +02:00
John Kleinschmidt
e8117f8e40
build: update build tools ( #46656 )
...
* build: update build tools
* chore: fix core.fscache
* chore: fix core.preloadindex
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-04-17 10:32:17 +02:00
Shelley Vohr
32fea719b3
refactor: migrate to non-deprecated allowedContentTypes on macOS ( #46623 )
...
refactor: migrated to non-deprecated allowedContentTypes on macOS
2025-04-15 09:51:34 -05:00
Shelley Vohr
14df4aab83
fix: window border on Gnome Wayland ( #46624 )
2025-04-15 15:45:33 +02:00
dependabot[bot]
24e46849c7
build(deps): bump actions/setup-node from 4.3.0 to 4.4.0 ( #46636 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](cdca7365b2...49933ea528 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-version: 4.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-15 15:44:04 +02:00
Shelley Vohr
489d30edfb
build: roll build-images ( #46625 )
2025-04-14 16:10:46 -04:00
Shelley Vohr
e748b521b2
test: fix node spec disabled tests ( #46627 )
2025-04-14 11:38:27 -04:00
Shelley Vohr
51bffb533e
fix: paint and flash issues on macOS ( #46615 )
...
* fix: paint and flash issues on macOS
* Adhere to paintWhenInitiallyHidden
2025-04-14 16:29:07 +02:00
Shelley Vohr
62b5b5f99d
fix: handle potential missing close event property ( #46605 )
...
fix: handle missing close event property
2025-04-11 13:07:26 -04:00
Keeley Hammond
a9b2ec514b
fix: fallback to old MacOS context menu behavior if no frame is present ( #46595 )
...
* fix: fallback to old MacOS context menu behavior if no frame is present
Co-authored-by: georgexu99 <georgexu99@electronjs.org >
Co-authored-by: erickzhao <erickzhao@electronjs.org >
Co-authored-by: clavin <calvin@electronjs.org >
* docs: add additional option for focusedFrame
* fix: handle frame found, but no view update from rfh
* fix: fix conditional
Co-authored-by: Calvin <clavin@users.noreply.github.com >
---------
Co-authored-by: georgexu99 <georgexu99@electronjs.org >
Co-authored-by: erickzhao <erickzhao@electronjs.org >
Co-authored-by: clavin <calvin@electronjs.org >
Co-authored-by: Calvin <clavin@users.noreply.github.com >
2025-04-11 10:15:35 -04:00
Shelley Vohr
3064b24c9d
refactor: use default printing path when no user options ( #46587 )
2025-04-11 10:14:29 -04:00
David Sanders
74d641c7b3
build: ignore files in .git when running markdownlint-cli2 ( #46608 )
2025-04-10 18:37:07 -05:00
Shelley Vohr
446d0769ed
feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI ( #46438 )
...
feat: expose shouldUseDarkColorsForSystemIntegratedUI
Closes https://github.com/electron/electron/issues/46429 .
Refs https://github.com/electron/electron/pull/19735 .
This PR adds a new API `shouldUseDarkColorsForSystemIntegratedUI` to the
`nativeTheme` module. This API returns a boolean indicating whether the
system is using dark colors for system integrated UI elements. This is
useful for applications that want to adapt their UI to match the system
theme, especially for those that use system integrated UI elements like
the shell theme or taskbar appearance.
2025-04-10 12:08:29 +02:00
Jemil Suleimanov
013133867b
docs: unify documentation example and fiddle for IPC pattern-1 ( #46517 )
...
* docs: unify documentation examples and fiddle
* docs: remove changes in ipc documentation
2025-04-10 12:08:10 +02:00
Yuri
de407e82b7
docs: updated tray doc with tooltip removing ( #46515 )
...
added tooltip removing doc
2025-04-09 11:50:08 -04:00
Charles Kerr
c6e6a03a24
fix: NativeWindow.window_id() returns same value for all windows ( #46562 )
...
fix: NativeWindow.window_id() returns same value for all windows
2025-04-09 10:45:06 -05:00
Shelley Vohr
c1c74b0a6c
fix: re-enable OOP printing on Linux ( #46529 )
2025-04-09 15:42:16 +02:00
Shelley Vohr
45a0494287
fix: remove obsoleted --inspect-brk logic ( #46560 )
...
fix: remove obsoleted --inspect-brk logic
2025-04-09 15:35:40 +02:00
Shelley Vohr
521108e2a5
fix: crash on parent window close and focur/blur ( #46559 )
2025-04-09 15:35:30 +02:00
dependabot[bot]
93a51cc756
build(deps): bump github/codeql-action from 3.28.13 to 3.28.15 ( #46554 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.13 to 3.28.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](1b549b9259...45775bd823 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.28.15
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-09 10:36:38 +02:00
Charles Kerr
ab23758e51
refactor: use v8::True(isolate) and v8::False(isolate) ( #46544 )
2025-04-08 12:58:39 -05:00
Charles Kerr
9069542d0b
refactor: remove unnecessary const_cast ( #46543 )
...
refactor: remove unnecessary const_cast
unnecessary since July 2019 in 50b9c70
2025-04-08 12:58:28 -05:00
Charles Kerr
636cbc19ac
refactor: simplify some BaseWindow JS getters ( #46542 )
...
* refactor: return a std::array<int 2> from BaseWindow::GetMaximumSize()
* refactor: return a std::array<int 2> from BaseWindow::GetMinimumSize()
* refactor: return a std::array<int 2> from BaseWindow::GetPosition()
* refactor: return a std::array<int 2> from BaseWindow::GetSize()
* refactor: return a std::array<int 2> from BaseWindow::GetContentSize()
* refactor: extract helper method ToArray(const gfx::Size)
* refactor: #include correctness
2025-04-08 10:58:12 -05:00
Shelley Vohr
1a6de10da8
fix: assert.ok in the renderer process ( #46528 )
...
fix: assert.ok in the renderer process
2025-04-08 07:09:54 -05:00
Charles Kerr
b1731407bc
refactor: make TrackableObjectBase::weak_map_id_ const ( #46524 )
...
refactor: make TrackableObjectBase::weak_map_id_ const
simplify declaration and initialization
2025-04-07 20:49:05 -05:00
Charles Kerr
4bb7a4ceb0
refactor: make api::View methods const, private ( #46545 )
...
* refactor: make api::View::GetBounds() const
* refactor: make api::View::OnViewBoundsChanged() private
refactor: make api::View::OnViewIsDeleting() private
refactor: make api::View::OnChildViewRemoved() private
* refactor: make ChildPair private
2025-04-07 16:23:36 -05:00
Shelley Vohr
e22b83abf2
build: update codespaces config ( #46533 )
2025-04-07 16:29:33 -04:00
Niklas Wenzel
bbc9d1cdc1
build: emphasize the need for a testcase in our issue template ( #46447 )
2025-04-07 10:50:59 -07:00
Charles Kerr
85dce12be3
refactor: migrate to View::AddChildView(std::unique_ptr<ui::View*>) ( #46474 )
...
* refactor: use AddChildView(std::unique_ptr<View>) in OpaqueFrameView::CreateButton()
Xref: https://issues.chromium.org/issues/40485510
* refactor: use AddChildView(std::unique_ptr<View>) in MenuBar::RebuildChildren()
* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux labels
* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux buttons
* refactor: use AddChildView(std::unique_ptr<View>) in AutofillPopupView
* refactor: use AddChildViewRaw() to flag the edge cases that we still need to fix
* chore: use west coast const for consistency
2025-04-07 09:20:46 -05:00
Charles Kerr
a6875c732c
docs: note that titleBarOverlay.symbolColor is supported on Linux ( #46492 )
...
docs: note that titleBarOverlay.symbolColor is supported on Linux
this is supported via OpaqueFrameView
2025-04-07 11:10:54 +02:00
Charles Kerr
c0fdf09f28
perf: on Windows, make Archive::HeaderIntegrity() faster ( #46509 )
...
* perf: do not clone the map each time we call Archive::HeaderIntegrity()
* perf: use absl::flat_hash_map for the integrity cache
* perf: do not clone the JSON payload string
* perf: preallocate capacity for the integrity cache
* perf: use move variant of insert_or_assign()
* refactor: simplify integrity cache building
remove unnecessary std::optional<>
* refactor: use base::FindOrNull()
* refactor: remove unused #includes
* refactor: make variable types explicit
* fix: make res_size unsigned
* refactor: put GetIntegrityConfigCache() in an unnamed namespace
refator: put LoadIntegrityConfig() in an unnamed namespace
* fix: oops, missing rel_path_utf8 key
* fix: oops, fix Wunreachable-code-return
2025-04-07 11:10:29 +02:00
Charles Kerr
41d8f90d68
refactor: use base::flat_set in WebContents::DidUpdateFaviconUrl() ( #46475 )
...
* refactor: add gin::Converter<std::span>::ToV8()
* feat: add ToV8(const base::flat_set<T>&)
* perf: use a flat_set in WebContents::TitleWasSet()
* refactor: add gin::Converter<std::array>::ToV8()
2025-04-07 10:16:02 +02:00
Charles Kerr
3c5c9c8e19
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal() ( #46508 )
...
perf: avoid redundant virtual method call in NativeWindowViews::SetEnabledInternal()
Why waste time make lot call when few call do trick?
2025-04-06 19:02:04 -07:00
Hailey
ac18decc56
revert: allow NSMenuItems to be disabled ( #46502 )
...
Revert "fix: allow NSMenuItems to be disabled (#46307 )"
This reverts commit ac616ef41d .
2025-04-06 20:42:05 -05:00
Charles Kerr
052da50aeb
refactor: remove unused electron::api::App::FileIconCallback ( #46490 )
...
refactor: remove electron::api::App::FileIconCallback
last use removed in 2018 by 3f15f516
2025-04-05 00:39:17 -05:00
Charles Kerr
4e33d1690d
refactor: instantiate navigation_entries local variable on the stack ( #46453 )
...
* refactor: instantiate navigation_entries on the stack instead of the heap
* refactor: reserve the full size of navigation_entries
* refactor: use emplace_back to simplify the code a little
2025-04-04 16:55:27 -05:00
Shelley Vohr
c2ae4afb8f
fix: destroy parent port backend when JS env exits ( #46437 )
...
* fix: destroy parent port backend when JS env exits
* fix: close parent port before destroying
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-04-04 11:02:54 -05:00
Felix Rieseberg
e81e3acd2d
docs: Add C++/Win32 tutorial ( #46160 )
...
* docs: Add C++/Win32 tutorial
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/native-code-and-electron-cpp-win32.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* docs: make linter happy
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-04 08:00:45 -05:00
electron-roller[bot]
9c019b6147
chore: bump chromium to 136.0.7095.0 (main) ( #46118 )
...
* chore: bump chromium in DEPS to 136.0.7076.0
* chore: bump chromium in DEPS to 136.0.7077.0
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6356528: Clean up LegacyRenderWidgetHostHWND code | https://chromium-review.googlesource.com/c/chromium/src/+/6356528
* chore: export patches
* 6339113: [Viewport Segments] Add CDP commands to override Viewport Segments without overriding other device properties. | https://chromium-review.googlesource.com/c/chromium/src/+/6339113
* 6352169: [DevTools][MultiInstance] Support new tab in another window on Android | https://chromium-review.googlesource.com/c/chromium/src/+/6352169
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6360858:Clickiness: Wire response from URLLoader to DB, add e2e tests| https://chromium-review.googlesource.com/c/chromium/src/+/6360858
* chore: bump chromium in DEPS to 136.0.7079.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7081.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7083.0
* 6361987: Remove double-declaration with gfx::NativeView and gfx::NativeWindow | https://chromium-review.googlesource.com/c/chromium/src/+/6361987
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7087.0
* chore: export patches
* fix: include node patch for missing AtomicsWaitEvent
https://chromium-review.googlesource.com/c/chromium/src/+/6385540
* build: add depot_tools python to path
* fix: cppgc init and unregistering v8 isolate
https://chromium-review.googlesource.com/c/v8/v8/+/6333562
CppGc is now initialized earlier so Node can skip reinitializing it.
Additionally, gin::IsolateHandle was attempting to destruct an already destructed
v8::Isolate upon electron::JavaScriptEnvironment destruction. By removing the call
to NodePlatform::UnregisterIsolate, this fixes the crash on app shutdown.
* fix: unregister isolate after destruction
See code comment.
* chore: bump chromium in DEPS to 136.0.7095.0
* chore: sync patches
* fix: add script_parsing::ContentScriptType parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6298395
* fix: migrate content::BrowserAccessibilityState methods
https://chromium-review.googlesource.com/c/chromium/src/+/6401437
https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* feat: enableHappyEyeballs option for host resolver
https://chromium-review.googlesource.com/c/chromium/src/+/6332599
* fix: add new cookie exclusion reason
https://chromium-review.googlesource.com/c/chromium/src/+/6343479
* fix: add new url loader method
https://chromium-review.googlesource.com/c/chromium/src/+/6337340
* fix: add new cppgc header file for electron_node headers
https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* fix: disable CREL on Linux ARM64
https://chromium-review.googlesource.com/q/I3a62f02f564f07be63173b0773b4ecaffbe939b9
* fixup! fix: add new cppgc header file for electron_node headers https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* chore: update corner smoothing patch
* fixup! chore: update corner smoothing patch
* chore: disable NAN weak tests
These two tests are incompatible with a V8 change that disallows running JS code from a weak finalizer callback.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
* test: fix task starvation in node test
A V8 change makes these contexts get collected in a task that is posted
and run asynchronously. The tests were synchronously GC'ing in an
infinite loop, preventing the task loop from running the task that would
GC these contexts.
This change should be upstreamed in some way.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2025-04-03 19:02:49 -05:00
Charles Kerr
0a5da83a1b
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged() ( #46451 )
...
perf: avoid redundant map lookup in HidChooserContext::DeviceChanged()
2025-04-03 17:51:37 -05:00
Fedor Indutny
7601af5200
fix: don't copy 'package.json's out of ASAR file ( #46390 )
...
New Node.js module resolution system reads `package.json` from imported
modules by reading from the file natively in C++ without calling into
`fs.readFileSync`. The ASAR FS wrapper code had copied files out into a
temporary folder as a workaround, but it is inefficient and does not
cover all module resolution mechanisms in Node.js.
In this change we expose `overrideReadFileSync` method on the `modules`
binding in Node.js, and use this override to call into ASAR-supporting
`fs.readFileSync`.
2025-04-03 13:39:53 -07:00
yangllu
e46b0c8ddc
fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 ( #46434 )
...
* fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8
* fix: use CleanedUpAtExit to control the lifetime of GPUInfoManager
2025-04-03 10:12:12 -07:00
Samuel Attard
0e3246e20d
fix: ensure maximize is emitted when reduce motion is enabled on macOS ( #46459 )
...
* fix: ensure maximize is emitted when reduce motion is enabled on macOS
* Revert "build: reenable graphics effects for macOS tests (#46454 )"
This reverts commit 682ea345ac .
2025-04-03 11:14:16 -05:00
Charles Kerr
0ff98810ba
fix: NativeWindowViews::GetRestoredState() can return wrong state when maximized ( #46450 )
...
fix: NativeWindowViews::GetRestoredState() returning wrong state
Introduced by the af58931 Chromium 131.0.6744.0 roll, specifically
https://github.com/electron/electron/pull/43948/commits/9840662#diff-f9d7ef7
98406626
2025-04-03 08:55:04 -05:00
Shelley Vohr
f48680a983
fix: zlib pointer alignment ( #46435 )
...
fix: fix zlib pointer alignment
2025-04-03 09:35:38 -04:00
Niklas Wenzel
682ea345ac
build: reenable graphics effects for macOS tests ( #46454 )
2025-04-02 21:33:12 -05:00
Charles Kerr
a21c805ece
perf: avoid redundant call to virtual methods GetProcess() and GetID() ( #46409 )
2025-04-02 11:57:09 -05:00
Charles Kerr
6f24dbaab4
perf: prefer absl::flat_hash_set over std::set when sorted order is not needed ( #46410 )
...
* perf: use an absl::flat_hash_set for UsbChooserContext::ephemeral_devices_
* perf: use an absl::flat_hash_set for GlobalMenuBarRegistrarX11::live_windows_
* perf: use an absl::flat_hash_set for NativeWindowViews::forwarding_windows_
* perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::guest_host_views_
perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::proxy_views_
* perf: use an absl::flat_hash_set for NativeWindow::injected_frames_
* perf: use an absl::flat_hash_set for NativeWindow::background_throttling_sources_
2025-04-02 11:03:36 -05:00
Charles Kerr
36e233797c
perf: cache the return value of IsX11() ( #46391 )
...
* perf: cache the return value of IsX11()
* fix: mark as nodiscard for those who call, but mark as maybe_unused for Windows
2025-04-01 15:28:01 -05:00
Shelley Vohr
c02e5bc72c
build: make it clearer when cookie auth runs ( #46406 )
2025-04-01 10:44:51 -07:00
Charles Kerr
5499c800a7
perf: avoid redundant map lookup in UsbChooserContext::OnDeviceRemoved() ( #46387 )
2025-04-01 12:39:34 -05:00
Charles Kerr
0492f0f745
perf: have ErrorThrower lazily lookup the current isolate ( #46388 )
...
perf: have ErrorThrower lazy-lookup the current isolate
ErrorThrower's default constructor is marked as "should rarely if ever
be used" because it's expensive to call.
Unfortunately, nearly every instance of ErrorThrower comes as an argument
in gin_helper's JS-->C++ function marshalling where a thrower is
default-constructed and then populated in gin_helper::GetNextArgument()
with an assignment operator to a temporary ErrorThrower constructed
with the gin::Arguments' isolate.
tldr: most of the time we use the slow constructor first, then throw
that work away unused by overwriting with a fast-constructed one.
This refactor avoids that cost by deferring the expensive work to
`ErrorThrower::isolate()`, where it happens only as a fallback iff
isolate_ hasn't been set.
2025-04-01 12:25:27 -05:00
Charles Kerr
ac1ffb1bff
fix: leaked gfx::Canvas in AutofillPopupView::OnPaint() ( #46384 )
...
* perf: avoid redundant call to popup_bounds_in_view()
* refactor: use a std::optional<> for paint_canvas local
* fix: fix leaked gfx::Canvas in AutofillPopupView::OnPaint()
* refactor: remove redundant get() call when testing smart pointer for nonempty
* refactor: remove unnecessary draw_canvas variable
* refactor: rename bitmap to offscreen_bitmap for symmetry
* refactor: avoid another redundant call to popup_bounds_in_view()
2025-04-01 11:22:26 -05:00
Charles Kerr
5a6f1ede6a
feat!: remove support for ProtocolResponse.session null value ( #46264 )
...
BREAKING CHANGE
This was deprecated in f7ba0d3b & is now being removed for Electron 37.
2025-04-01 08:52:12 -05:00
zoy
0e687d3082
fix: rounded corners disappear momentarily on window close ( #46382 )
...
fix: Explicitly set rounded corners in borderless mode on Windows 11
Signed-off-by: zoy <zoy-l@outlook.com >
2025-04-01 15:43:54 +02:00
Calvin
08da2b0b07
chore: move build files to build/ dir ( #46368 )
2025-04-01 13:42:14 +02:00
Shelley Vohr
9c4720766d
fix: UtilityProcess.fork crash before app ready ( #46380 )
...
fix: UtilityProcess.fork crash before app ready
2025-04-01 13:42:03 +02:00
Shelley Vohr
5da75c4a97
feat: support system-context-menu on Linux ( #45848 )
...
feat: support system-context-menu on Linux
2025-04-01 11:00:39 +02:00
Charles Kerr
77833eddfb
perf: avoid unnecessary vector copy in GetMimeTypeToExtensionIdMap() ( #46373 )
...
* perf: avoid making an unnecessary copy of the vector
MimeTypesHandler::GetMIMETypeAllowlist() returns a const&, so we can
iterate that directly instead of making a temporary copy of it.
* perf: move the call to ExtensionRegistry::Get() outside of the loop
Also, keep the previous behavior of not calling it at all if there
aren't any whitelisted extensions.
* perf: avoid redundant map lookup
* refactor: const correctness
* refactor: cleanup
2025-03-31 21:52:49 -05:00
Calvin
1730062c8f
fix: flicker and ghosting in transparent windows on macOS ( #46353 )
...
* fix: transparent flicker on MAS
* Gate condition on `IsTranslucent` instead
2025-03-31 18:12:35 -05:00
Calvin
09135443a0
feat: Corner Smoothing CSS rule (Reland) ( #46278 )
...
* feat: Corner Smoothing CSS rule (Reland)
Reland of #45185
* Fix patch conflicts
* fixup! Fix patch conflicts
* Update expected image
The dashed border is subtly different. The new version is correct and the old one was incorrect.
2025-03-31 11:22:23 -05:00
Charles Kerr
fcd836e34f
refactor: remove field unused weak_factory_ ( #46363 )
...
refactor: remove unused weak_factory_
Appears to have been added in e3f61b46 but never used
2025-03-31 10:39:21 +02:00
Charles Kerr
28fd7c5a17
perf: improve temporaries in WebWorkerObserver::WorkerScriptReadyForEvaluation() ( #46347 )
...
refactor: small refactor to WebWorkerObserver::WorkerScriptReadyForEvaluation()
- replace a std::vector<std::string> local with a compile-time array
of std::string_view
- remove .c_str() pessimization when making v8 Strings from string_views
2025-03-30 23:21:39 -05:00
Charles Kerr
ae6930030a
perf: prefer absl::flat_hash_set over std::unordered_set ( #46348 )
...
* perf: use absl::flat_hash_set in SpellCheckClient::SpellCheckText()
* perf: use absl::flat_hash_set in MessagePort::DisentanglePorts()
2025-03-30 23:21:18 -05:00
Charles Kerr
2fa4fb0da9
refactor: use v8::String::Empty() when creating empty strings ( #46349 )
...
refactor: use v8::String::Empty() when creating empty strings
2025-03-30 21:14:18 -05:00
Charles Kerr
bf93427cbb
perf: avoid double map lookup in HidChooserContext::DeviceRemoved() ( #46343 )
2025-03-28 21:34:24 -05:00
Charles Kerr
72fc65d2c5
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance() ( #46339 )
...
perf: avoid 3x call to GetID() in RegisterPendingSiteInstance()
2025-03-28 21:33:45 -05:00
Charles Kerr
2baa4a3514
perf: avoid a double-map lookup in NotificationPresenter::RemoveNotification() ( #46338 )
...
perf: avoid a double-map lokup in NotificationPresenter::RemoveNotification()
2025-03-28 21:33:11 -05:00
Samuel Attard
49aba471dc
feat: add support for associating a Menu with a WebFrameMain ( #45138 )
...
* feat: add support for associating a Menu with a WebFrameMain
This allows certain OS level features to activate such as Writing Tools, Autofill.. and Services.
There appears to be a bug in macOS where the responder chain isn't traversed if the menu is not popped up using an event, as such we spoof a fake mouse event at the write coordinates in the right window and use that to open the menu.
* build: fix build on non-mac
* build: oops missed a header
* fix: safely handle optional T* by checking nullptr too
* build: fix gn check and build errors
* docs: suggested changes
* feat: default `frame` to `window.webContents.mainFrame` when possible
* fix: avoid deref nullptr view
* Revert "feat: default `frame` to `window.webContents.mainFrame` when possible"
This reverts commit 2e88836819 .
* fix: lint
* Remove redundant scoped objects
This code, including the comments, matches almost exactly the behavior of this argument to the function.
* Add ScopedPumpMessagesInPrivateModes patch
* More null pointer safety
---------
Co-authored-by: clavin <clavin@electronjs.org >
2025-03-28 11:50:07 -07:00
Charles Kerr
46b108e9a4
perf: avoid redundant map lookups in GetStorageMask() ( #46315 )
...
* perf: avoid a redundant map lookuop in GetStorageMask()
* perf: avoid a redundant map lookup in GetDataTypeMask()
2025-03-28 00:25:25 -05:00
Hailey
ac616ef41d
fix: allow NSMenuItems to be disabled ( #46307 )
...
* fix: disable NSMenu autoenable feature to allow disabling of NSMenuItems
* style: fix linter issues and update comments
* chore: remove unneeded comment
2025-03-27 17:43:46 -07:00
Charles Kerr
e09712f0e1
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges() ( #46306 )
...
perf: avoid a triple-redundant map lookup in ViewsDelegate::GetAppbarAutohideEdges()
2025-03-27 14:32:27 -05:00
Charles Kerr
35c90fd807
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() ( #46293 )
...
perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost()
2025-03-27 14:32:01 -05:00
Shelley Vohr
756423e81e
build: validate Chromium cookie authentication ( #46274 )
2025-03-27 14:29:01 -05:00
Shelley Vohr
dc61a6ab80
fix: possible crash in shell.readShortcutLink ( #46294 )
...
fix: possible crash in shell.readShortcutLink
2025-03-27 14:27:32 -05:00
Shelley Vohr
a0c859fc4f
build: roll build-images SHAs ( #46291 )
2025-03-27 10:39:02 +01:00
Shelley Vohr
17e38230d5
fix: crash when drag-dropping some files ( #46253 )
...
* fix: crash when drag-dropping some files
* fix: extra destination context scope
2025-03-26 17:17:23 -05:00
Charles Kerr
3ae285b614
perf: avoid std::map temporaries in WebContents::DevToolsRequestFileSystems() ( #46268 )
...
* perf: move the GetDevToolsWebContents() call outside of the loop
* perf: remove std::map temporary in WebContents::DevToolsRequestFileSystems()
* refactor: remove unused GetAddedFileSystemPaths()
* perf: remove std::vector temporary in WebContents::DevToolsRequestFileSystems()
2025-03-26 16:26:56 -05:00
Shelley Vohr
3212f60d69
fix: set userAgent on navigationHistory.restore() ( #46260 )
...
fix: set userAgent on navigationHistory restore
2025-03-26 10:59:19 -05:00
Charles Kerr
a5076a663b
perf: avoid redundant map lookup in WebContents::DevToolsIndexPath() ( #46254 )
...
perf: avoid double map lookup in WebContents::DevToolsIndexPath()
2025-03-26 10:30:02 -05:00
Shelley Vohr
d2c2261c58
fix: hard crash on invalid command line switches ( #46004 )
...
* fix: hard crash on invalid command line switch
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: feedback from review
* docs: Add breaking change note
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-03-26 08:14:03 -05:00
Charles Kerr
8412d78310
perf: avoid redundant map lookup in AddComponentResourceEntries() ( #46255 )
...
* perf: avoid double map lookup in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
* perf: move the path key when calling try_emplace()
2025-03-26 08:12:16 -05:00
Charles Kerr
48a38c0289
fix: build failure when printing is disabled ( #46283 )
...
fix: ftbfs when printing is disabled
2025-03-26 10:04:39 +01:00
Charles Kerr
6e44662f15
perf: avoid redundant map lookup in WebFrameMain constructor ( #46238 )
...
perf: avoid double map lookup in WebFrameMain constructor
2025-03-25 16:53:24 -05:00
Charles Kerr
c8d3184a95
refactor: migrate hashing code to new upstream crypto::hash API ( #46237 )
...
* refactor: migrate AsarFileValidator to crypto::hash
This change migrates AsarFileValidator's uses of crypto::secure_hash
to the new crypto::hash API, which has more memory safety and less
heap allocations.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6287609
* refactor: migrate ValidateIntegrityOrDie to crypto::hash
This change migrates ValidateIntegrityOrDie's use of crypto::SHA256Hash
to the new crypto::hash API, which has more memory safety and less heap
allocations.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6287609
2025-03-25 15:01:17 -05:00
dependabot[bot]
bb0ddcad27
build(deps): bump actions/setup-node from 4.2.0 to 4.3.0 ( #46092 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1d0ff469b7...cdca7365b2 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-25 13:29:22 -05:00
John Kleinschmidt
4eda76de36
build: fixup windows source cache for release ( #46236 )
...
* build: fixup windows source cache for release
* build: fixup ffmpeg gn gen
* build: add build-tools depot_tools to PATH
There are some cases where it is still expected that depot_tools be in the path
* put back regular gn gen for ffmpeg
* build: add retry to moving source cache
This resolves the error: `Move-Item : The process cannot access the file because it is being used by another process.`
2025-03-25 14:24:58 -04:00
Charles Kerr
ced8fdbce8
perf: avoid std::map temporaries in IsDevToolsFileSystemAdded() ( #46230 )
...
* refactor: extract-method GetAddedFileSystems()
* refactor: use GetAddedFileSystems() in GetAddedFileSystemPaths()
* refactor: use GetAddedFileSystems() in IsDevToolsFileSystemAdded()
2025-03-25 11:42:58 -05:00
Charles Kerr
f7ba0d3b4b
docs: deprecate setting ProtocolResponse.session to null ( #46131 )
...
* docs: deprecate setting ProtocolResponse.session to null
* docs: mark null ProtocolResponse.session as deprecated in struct docs
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-03-25 10:04:21 -05:00
Charles Kerr
4f4e23a3b3
perf: avoid redundant map lookups in GlobalShortcut ( #46229 )
...
* perf: avoid redundant map lookup in GlobalShortcut::OnKeyPressed()
* perf: avoid redundant map lookup in GlobalShortcut::ExecuteCommand()
2025-03-25 09:46:03 -05:00
Shelley Vohr
1d6cb348b4
fix: webContents.printToPDF() with cross-process subframes ( #46218 )
...
fix: webContents.printToPDF() with cross-process subframes
2025-03-25 08:16:47 -05:00
dependabot[bot]
8e856dfdb8
build(deps): bump github/codeql-action from 3.28.11 to 3.28.13 ( #46240 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.11 to 3.28.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](6bb031afdd...1b549b9259 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-25 12:21:23 +01:00
John Beutner
cf82c3215f
perf: don't wait for thumbnails if they were not requested on macOS ( #46138 )
...
When using the SCK thumbnail capturer, the first refresh has the list of
sources, and the second refresh has the thumbnails. If thumbnails are
not needed, only wait for the first refresh.
2025-03-25 12:20:38 +01:00
Robo
307d4f94c7
fix: oob string read when parsing node_options ( #46210 )
...
* fix: oob string read when parsing node_options
* chore: re-enable test
* fix: missing linux server env for tests
2025-03-25 19:33:10 +09:00
dependabot[bot]
cfada0347e
build(deps): bump actions/download-artifact from 4.1.9 to 4.2.1 ( #46239 )
2025-03-25 08:47:33 +01:00
dependabot[bot]
7cb921369b
build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2 ( #46241 )
2025-03-25 08:46:18 +01:00
Robo
a86e44b176
fix: NODE_OPTIONS parsing for child processes on macOS ( #46209 )
...
* fix: NODE_OPTIONS parsing for child processes on macOS
* chore: temporarily disable test
* chore: apply review feedback
* chore: fix build
2025-03-25 13:01:37 +09:00
Calvin
abaef13c0b
fix: Revert "feat: Corner Smoothing CSS rule" ( #46231 )
...
Revert "feat: Corner Smoothing CSS rule (#45185 )"
This reverts commit b75e802280 .
2025-03-24 20:36:49 +01:00
John Beutner
cfd64b5f89
fix: handle OnDelegatedSourceListDismissed asynchronously ( #46112 )
...
This fixes a crash with the PipeWire capturer caused by a Chromium
change introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/5783826 .
DesktopMediaListBase now calls Refresh(true) after dispatching
DesktopMediaListObserver::OnDelegatedSourceListDismissed, so it's
important not to call DesktopCapturer::HandleFailure (which deallocates
the DesktopMediaList) synchronously from OnDelegatedSourceListDismissed.
2025-03-24 20:09:11 +01:00
John Kleinschmidt
cbcd779610
build: fixup release builds ( #46228 )
2025-03-24 14:34:57 -04:00
Calvin
b75e802280
feat: Corner Smoothing CSS rule ( #45185 )
...
* feat: Corner Smoothing
* Patch Blink to add CSS rule and Painting
* Add `system-ui` keyword
* Add `cornerSmoothingCSS` web preference
* Add tests
* Documentation
* fixup! Documentation
* fix: initialize smoothness value
* Use a 1.0 scale factor in tests
* Fix tests for CI
* Fix tests
* fixup! Merge branch 'main' into clavin/corner-smoothing
* Add code docs
* Document `system-ui` keyword values
* Address review comments
* fixup! Address review comments
* Address review comments
* Update patch to address upstream changes
The patch went from 694 lines to 505 lines, which is a 27.2% smaller!
* fixup! Update patch to address upstream changes
2025-03-24 11:46:12 -04:00
Shelley Vohr
9ec14b91e7
feat: add BrowserWindow.isSnapped() ( #46079 )
...
* feat: add BrowserWindow.isSnapped() on Windows
* docs: mark _Readonly_
2025-03-24 12:09:14 +01:00
Shelley Vohr
47cf4e7bfd
fix: Wayland resizing border ( #46155 )
...
* fix: Wayland resizing border
Closes https://github.com/electron/electron/issues/44543
Refs CL:5180720
Fixes an issue where the resizing border didn't work as expected on Wayland windows.
* fix: border insets when fullscreen
2025-03-24 12:08:24 +01:00
Charles Kerr
b8150f33db
refactor: remove unused weak_factory_ in electron_management_api_delegate.cc ( #46200 )
...
refactor: remove unused weak_factory_
Appears to have been added in 3745b76da but never used
2025-03-24 12:07:49 +01:00
Charles Kerr
02a4bd5942
refactor: remove unused method ProxyingWebSocket::web_request_api() ( #46201 )
...
Appears to have been added in c608d6d7 but never used
2025-03-24 10:09:24 +01:00
Charles Kerr
7ed4f0ca27
perf: use absl::flat_hash_map instead of std::unordered_map ( #46202 )
...
* perf: make ElectronUsbDelegate::controller_map_ an absl::flat_hash_map
* perf: make ElectronSerialDelegate::controller_map_ an absl::flat_hash_map
* perf: make ElectronHidDelegate::controller_map_ an absl::flat_hash_map
* perf: make FrameTreeNodeIdMap an absl::flat_hash_map
* perf: make AutofillDriverFactory::driver_map_ an absl::flat_hash_map
* perf: make asar::Archive::external_files_ an absl::flat_hash_map
* perf: make VersionIdMap an absl::flat_hash_map
* perf: make ObjectCache::proxy_map_ an absl::flat_hash_map
* docs: add TODO to investigate absl map in KeyWeakMap
2025-03-24 10:09:14 +01:00
Shelley Vohr
964090d086
fix: ensure TraverseParent bails on resource path exit ( #46100 )
...
* fix: ensure TraverseParent bails on resource path exit
* Address review changes
2025-03-24 10:06:59 +01:00
Erik Moura
e9082ea57a
docs: fix capitalization for InputEvent.modifiers ( #46130 )
2025-03-23 16:38:15 -05:00
Charles Kerr
5623c96dd7
refactor: remove unused field ServiceWorkerMain::weak_factory_ ( #46171 )
...
refactor: remove unused field ServiceWorkerMain::weak_factory_
Added in a467d06 , appears to have never been used
2025-03-23 10:14:45 +01:00
Charles Kerr
3fd35abe98
refactor: remove unused method ElectronBrowserContext::GetWeakPtr() ( #46170 )
...
* refactor: use forward declaration of MediaDeviceIDSalt in electron_browser_context.h
* refactor: remove unused #include from browser_context.h
* refactor: remove unused ElectronBrowserContext::GetWeakPtr()
last use removed in Aug 2020 by bac2f46
2025-03-22 10:15:15 -05:00
Charles Kerr
a81e11d9de
refactor: use = default to define trivial destructors ( #46165 )
...
refactor: use '= default' to define trivial destructors
2025-03-21 16:15:34 -05:00
John Kleinschmidt
db47267be4
build: Use windows src cache ( #45881 )
...
build: use source cache on windows
2025-03-21 14:45:08 -04:00
Charles Kerr
6723bfbe32
refactor: reduce coupling in electron::api::Protocol ( #46122 )
...
* refactor: decouple api::Protocol from ElectronBrowserContext
now they do not know about each other
* refactor: make electron::api::ProtocolError private
* refactor: remove unused isolate arg in Protocol constructor
* refactor: use =default for trivial destructor
2025-03-21 07:33:25 -05:00
Shelley Vohr
603057b198
fix: remove File.path from types ( #46005 )
2025-03-21 08:40:49 +01:00
Shelley Vohr
9ccc63d682
fix: add missing cpp_heap to Node.js worker CreateParams ( #46104 )
2025-03-21 08:40:28 +01:00
LZL
4d7161f36e
feat: add ffmpeg.dll to delay load configuration ( #46151 )
...
feat: set ffmpeg.dll as a delay-loaded DLL
Updated the /DELAYLOAD linker config in BUILD.gn to set ffmpeg.dll
as a delay-loaded DLL. This reduces startup overhead and prevents unnecessary
loading when ffmpeg-related functionality is not used (e.g., the browser process
was unnecessarily loading it).
2025-03-21 16:24:34 +09:00
Shelley Vohr
32141eacfb
refactor: use upstream Widget::IsVisibleOnAllWorkspaces() ( #45887 )
...
* refactor: use upstream Widget::IsVisibleOnAllWorkspaces()
* chore: add to breaking changes
2025-03-20 23:43:47 -05:00
Charles Kerr
1b5db9989e
refactor: make URLPipeLoader private ( #46113 )
...
Move the URLPipeLoader class into an anonymous namespace in
electron_url_loader_factory.cc.
2025-03-20 15:47:47 -05:00
Charles Kerr
46967ca9c9
refactor: Add ElectronBrowserContext::BrowserContexts() ( #46089 )
...
* refactor: add ElectronBrowserContext::BrowserContexts()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronBrowserMainParts::PostMainMessageLoopRun()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::IsValidContext()
* refactor: use ElectronBrowserContext::BrowserContexts() in ElectronExtensionsBrowserClient::BroadcastEventToRenderers()
* refactor: move PartitionKey, BrowserContextMap private
* refactor: add ElectronBrowserContext::IsValidContext()
decouple ElectronExtensionsBrowserClient from the internals of ElectronBrowserContext
2025-03-20 11:17:26 -05:00
Charles Kerr
273baf4ec2
refactor: use base::NumberToString() ( #46141 )
...
base::NumberToString() is slightly more efficient than
absl::StrFormat("%u").
2025-03-20 10:13:28 +01:00
Charles Kerr
c4800d9934
refactor: remove ToV8(isolate, const char*) ( #46108 )
2025-03-20 10:04:50 +01:00
Shelley Vohr
86cc9f626f
fix: APNS token ids are lowercase ASCII ( #46101 )
2025-03-20 07:57:50 +01:00
Shelley Vohr
09a3bcf0f0
fix: webContents.print() crash on Linux ( #46087 )
2025-03-20 06:41:00 +01:00
Shelley Vohr
bf64967b68
build: combine pipewire patches ( #46129 )
2025-03-19 23:26:06 -05:00
Niklas Wenzel
bf1d377e08
docs: use optional chaining for app.dock ( #46119 )
...
docs: use optional chaining for app.dock
2025-03-19 18:34:03 -05:00
Shelley Vohr
d424c3aee7
test: disable parallel/test-worker-resource-limits ( #46105 )
...
test: disable parallel/test-worker-resource-limits
2025-03-19 22:03:26 +01:00
Niklas Wenzel
e4d660af86
docs: fix code example in breaking-changes.md ( #46093 )
2025-03-19 11:20:22 +01:00
Shelley Vohr
2efd75e2ca
build: fail for out of date patches on forks ( #46080 )
2025-03-19 10:05:51 +01:00
electron-roller[bot]
b13f05e2dc
chore: bump chromium to 136.0.7067.0 (main) ( #46018 )
...
* chore: bump chromium in DEPS to 136.0.7066.0
* chore: bump chromium in DEPS to 136.0.7067.0
* 6325710: [LNA] Add Local Network Access permission type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6325710
* 6342514: Create frame mojo endpoints in renderer during window.open()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6342514
* 6344040: Create widget mojo endpoints in renderer process for window.open()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6344040
* chore: update patches
* 6349218: Move ExtensionService::install_directory() to ExtensionRegistrar
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6349218
* 6349395: Move ExtensionService::extensions_enabled() to ExtensionRegistrar
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6349395
* 6331510: Migrate views::Background class to ui::ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6331510
* build: reorder set-cookie step https://github.com/electron/electron/pull/46091
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: alice <alice@makenotion.com >
2025-03-18 19:20:54 -04:00
Shelley Vohr
dcbab692c0
test: fix app.dock for corrected type ( #46110 )
...
test: fix app.dock for corrected type
2025-03-18 17:44:39 -04:00
Niklas Wenzel
71f3ff6bf2
docs: fix types of app.dock ( #46073 )
2025-03-18 13:14:08 +01:00
Alice Zhao
ff0a14a7c6
build: move set chromium cookie before build tools step ( #46091 )
...
build: move set cookie before build tools
2025-03-18 10:07:05 +01:00
Charles Kerr
4bf99c9bea
refactor: add ElectronBrowserContext::GetDefaultBrowserContext() ( #46065 )
...
* refactor: add ElectronBrowserContext::DestroyAllContexts()
Simpler semantics than previous implementation; also hides the
"default context must be destroyed last" implementation detail.
* refactor: add ElectronBrowserContext::GetDefaultBrowserContext()
clearer semantics than everyone calling From("", false)
2025-03-17 08:43:23 -05:00
Charles Kerr
9513486bf3
refactor: use GetDefaultStoragePartition() instead of GetStoragePartition(nullptr) ( #46064 )
...
refactor: use GetDefaultStoragePartition()
Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr)
- It improves code uniformity, since we use get-default everywhere else
- It's more readable
- It's marginally faster, since GetStoragePartition() has more steps
Added in 49b0a1bf4a
2025-03-17 08:39:55 -05:00
Charles Kerr
bea7d618f1
fix: warning in file picker UI ( #46067 )
2025-03-16 20:49:15 -05:00
Charles Kerr
4ad20ccb39
chore: e patches all ( #46068 )
2025-03-16 14:04:01 -05:00
Charles Kerr
73a017577e
perf: avoid redundant map lookup in ElectronBrowserContext::From() ( #46044 )
...
perf: avoid redundant map lookup in ElectronBrowserContext::FromPath()
2025-03-15 09:51:20 -05:00
Shelley Vohr
2d8a547692
build: fix compound bash conditional in patchup ( #46047 )
2025-03-15 09:57:59 +01:00
Charles Kerr
5f0603ed28
fix: ElectronBrowserContext raw_ptr bug + remove dead code ( #46030 )
...
refactor: remove unused ElectronBrowserContext::extension_system()
Last use removed on Jul 21, 2020 by 2fb14f5 in PR #24575
This fixes a raw_ptr warning by letting us remove the raw_ptr field
`ElectronBrowserContext::extension_system_`.
2025-03-14 23:35:10 -05:00
Sam Maddock
afca4e271e
feat: ServiceWorkerMain.scriptURL ( #45863 )
...
feat: serviceWorker.scriptURL
2025-03-14 21:00:13 -04:00
Charles Kerr
30d2fadb28
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #46024 )
...
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
2025-03-14 17:14:32 -05:00
Charles Kerr
3271b82094
refactor: remove unused system header includes ( #46015 )
...
* chore: remove unused #include <string>
* chore: remove unused #include <optional>
* chore: remove unused #include <vector>
* chore: remove unused #include <string_view>
* chore: remove unused #include <memory>
* chore: remove unused #include <utility>
* chore: remove unused #include <tuple>
* chore: remove unused #include <unordered_set>
* chore: remove unused #include <functional>
* chore: iwyu <set>
* chore: iwyu <map>
2025-03-14 10:59:15 -05:00
Shelley Vohr
c0e180758b
fix: don't crash Utility Processes on unhandled rejections ( #45921 )
...
* fix: don't crash on unhandled rejections
* Update docs/breaking-changes.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2025-03-14 09:09:02 -05:00
Shelley Vohr
5817d27429
fix: take Snapped status into account when showing a window ( #46006 )
2025-03-14 09:07:27 -05:00
Michaela Laurencin
4812b4e6c2
fix: prevent title change for within page navigation ( #45981 )
...
* fix: prevent title change for on page navigation
* add back and forward testing
* update Chromium comment
* remove errant script tag
2025-03-14 12:10:23 +01:00
Shelley Vohr
7c0b7b417b
fix: emit context-menu event in Windows draggable regions ( #45851 )
...
fix: emit context-menu event in Windows draggable regions
2025-03-14 10:29:29 +01:00
Charles Kerr
785fe5f3b6
refactor: make a variadic gin_helper::internal::InvokeFactory() ( #45988 )
...
refactor: make a variadic gin_helper::internal::InvokeFactory()
2025-03-13 17:24:49 -05:00
Shelley Vohr
502a6b0166
build: roll sysroots again ( #46016 )
2025-03-13 16:28:53 -05:00
Shelley Vohr
4a28e60e89
fix: package import existence verification ( #45997 )
2025-03-13 14:51:43 -05:00
Shelley Vohr
a90d50e13f
fix: don't crash Web Workers on unhandled rejections ( #45992 )
2025-03-13 13:09:23 -05:00
electron-roller[bot]
962d8b325a
chore: bump chromium to 136.0.7064.0 (main) ( #45985 )
...
* chore: bump chromium in DEPS to 136.0.7063.0
* chore: bump chromium in DEPS to 136.0.7064.0
* 6169919: Instantiate Linux (or CrOS) system fonts using Fontations
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6169919
* 6341209: Remove file-wide unsafe buffer suppression from content/ [1 of N].
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6341209
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-03-13 12:02:06 -05:00
Charles Kerr
c813bc2a92
refactor: use private inheritance from mojo::MessageReceiver ( #45973 )
...
* refactor: make UtilityProcessWrapper inherit privately from mojo::MessageReceiver
* refactor: make ParentPort inherit privately from mojo::MessageReceiver
* refactor: make MessagePort inherit privately from mojo::MessageReceiver
2025-03-12 19:06:41 +01:00
Shelley Vohr
5ce41bac8d
fix: system-context-menu should only fire in draggable regions ( #45893 )
...
fix: system-context-menu should only fire in draggable regions
2025-03-12 13:47:58 +01:00
David Sanders
6bc7bde229
ci: don't fail branch created workflow if previous board not found ( #45986 )
2025-03-12 09:27:40 +01:00
electron-roller[bot]
2de8fd7d93
chore: bump chromium to 136.0.7062.0 (main) ( #45957 )
...
* chore: bump chromium in DEPS to 136.0.7059.0
* chore: bump chromium in DEPS to 136.0.7060.0
* chore: bump chromium in DEPS to 136.0.7062.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-11 17:44:08 -04:00
Shelley Vohr
dcd319cfbe
build: roll sysroots to pick up glibc fix ( #45974 )
2025-03-11 17:31:48 -04:00
Shelley Vohr
cd56b96544
refactor: remove usage of V8's {Attach|Detach}CppHeap() ( #45922 )
...
* refactor: remove usage of V8's {Attach|Detach}CppHeap()
* chore: remove revert patch
2025-03-11 18:54:33 +01:00
Charles Kerr
22262c14f1
test: fix timing issue in utilityProcess test fixtures ( #45964 )
...
* fix: potential timing issue in utilityProcess test
* fix: potential timing issue in utilityProcess esm test
2025-03-11 17:41:42 +01:00
dependabot[bot]
6e056709be
build(deps): bump github/codeql-action from 3.28.10 to 3.28.11 ( #45970 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.10 to 3.28.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b56ba49b26...6bb031afdd )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-11 10:44:00 -05:00
dependabot[bot]
2f63b20acf
build(deps): bump dsanders11/project-actions from 1.5.2 to 1.7.0 ( #45969 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.5.2 to 1.7.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](7fc3c5441a...2134fe7cc7 )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-11 10:43:46 -05:00
Felix Rieseberg
eb126eecb0
docs: Add 'Native Code and Electron' ( #45882 )
...
* docs: Add 'Native Code and Electron'
* docs: Add node-gyp requirements
* Update docs/tutorial/native-code-and-electron.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Cross-platform clean command
* Mention napi-rs
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Fix lint, fix more comments
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-03-10 13:45:33 -07:00
Shelley Vohr
4e1a915f1a
build: remove patches merged upstream ( #45963 )
2025-03-10 20:00:28 +01:00
Charles Kerr
f2b09ff0bd
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call ( #45929 )
...
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call
This appears to be a copy-paste error introduced in 465dee2c
2025-03-10 09:44:24 -05:00
electron-roller[bot]
b0c11371e0
chore: bump chromium to 136.0.7058.1 (main) ( #45928 )
...
* chore: bump chromium in DEPS to 136.0.7056.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no manual changes; patch applied with fuzz
* chore: update fix_adapt_exclusive_access_for_electron_needs.patch
patch applied manually due to context shear
6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
no manual changes; patch applied with fuzz
6311876: Expose captured surface resolution for MacOS | https://chromium-review.googlesource.com/c/chromium/src/+/6311876
* chore: e patches all
* 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958
* 6326673: views: Delete the single-parameter Widget::InitParams constructor. | https://chromium-review.googlesource.com/c/chromium/src/+/6326673
* https://chromium-review.googlesource.com/c/chromium/src/+/6331102
* 6331102: [A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties | https://chromium-review.googlesource.com/c/chromium/src/+/6331102
Sync with shell/browser/ui/webui/accessibility_ui.cc to
upstream chrome/browser/accessibility/accessibility_ui.cc
changes in 4af8657
* chore: bump Chromium 136.0.7058.1 (#45933 )
chore: bump chromium in DEPS to 136.0.7058.1
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-10 00:30:34 -05:00
Samuel Attard
9b2e7db469
chore: cherry-pick 9dacf5694dfd from chromium ( #45936 )
2025-03-09 16:26:06 -07:00
Samuel Attard
f04c06a0db
chore: cherry-pick 521faebc8a7c from chromium ( #45941 )
2025-03-09 16:23:04 -07:00
Charles Kerr
8ac061ebe7
fix: race condition in utilityProcess tests ( #45926 )
2025-03-09 17:37:35 -05:00
Milan Burda
b30f31e1f6
refactor: eliminate duplicate code in spec/api-process-spec.ts ( #45927 )
2025-03-09 17:37:14 -05:00
Charles Kerr
288ef37b1d
perf: prefer base::SplitStringPiece() over base::SplitString() ( #45924 )
...
* perf: use base::SplitStringPiece() in SetNodeOptions()
* perf: use base::SplitStringPiece() in StringToAccelerator()
* refactor: StringToAccelerator() now takes a std::string_view
2025-03-09 17:36:13 -05:00
electron-roller[bot]
20414f66ca
chore!: bump chromium to 136.0.7054.0 (main) ( #45923 )
...
* chore: bump chromium in DEPS to 136.0.7054.0
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5906158
patch applied manually due to context shear
* chore: e patches all
* refactor!: Session.clearStorageData(syncable)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6309405
Remove syncable type from opts.quota in Session.clearStorageData(opts)
because it that category has been removed upstream.
BREAKING CHANGE: Removed ses.clearDataStorage({ quota: 'syncable' })
* docs: deprecate Session.clearDataStorage({ quota })
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-07 17:49:21 -06:00
electron-roller[bot]
458b14b8ed
chore: bump chromium to 136.0.7053.1 (main) ( #45906 )
...
* chore: bump chromium in DEPS to 136.0.7052.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6318359
patch applied manually due to context shear
* chore: update preconnect_manager.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420
patch applied manually due to context shear
* chore: e patches all
* chore: bump chromium to 136.0.7053.1
* chore: update fix_remove_profiles_from_spellcheck_service.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575
patch applied manually due to context shear
* chore: e patches all
* chore: revert removal of v8 API used by Node.js
* devtools: Remove DevToolsUIBindings::SendJsonRequest() | https://chromium-review.googlesource.com/c/chromium/src/+/6326236
* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461
* 6313744: Migrate views::Background factory methods to ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6313744
* 6314545: Remove multiple argument support from base::ToString() | https://chromium-review.googlesource.com/c/chromium/src/+/6314545
* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | https://chromium-review.googlesource.com/c/chromium/src/+/6317362
* 6308998: Add SettingAccess structured metrics event for DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/6308998
* 6295214: Remove redundant state field in per-extension preferences | https://chromium-review.googlesource.com/c/chromium/src/+/6295214
NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc
* fix: ui/ linter error
This is showing up in an eslint build step in Electron:
> /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts
> 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion
>
> ✖ 1 problem (1 error, 0 warnings)
> 1 error and 0 warnings potentially fixable with the `--fix` option.
However, removing the assertion causes a typescript build failure:
> gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'.
> Type 'null' is not assignable to type 'HTMLElement'.
>
> 77 items.indexOf(this.querySelector<HTMLElement>(':focus'));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
So I think the two different steps may be picking up typescript definitions.
This patch should be removed after the issue is tracked down
and fixed in a followup task.
* fix: -Wnonnull warning
Fixes this warning:
> 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
> 2025-03-07T01:05:01.8638267Z 257 | return nullptr;
> 2025-03-07T01:05:01.8638481Z | ^~~~~~~
> 2025-03-07T01:05:01.8638700Z 1 error generated.
Not sure why this warning was never triggered before; `git blame`
indicates this code hasn't changed in ages:
> c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG
> 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) }
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr;
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) }
Presumably this is failing in this Chromium roll due to a
clang version bump.
We should remove this patch after upstreaming it.
* docs: add upstream pr link for Node patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-03-07 11:35:59 -06:00
Robo
530ccfe350
fix: resolve font list in default prefernce values ( #45905 )
...
* fix: resolve font list in default prefernce values
* chore: fix unsafe buffer usage
* docs: add code comment
2025-03-07 18:22:03 +09:00
Robo
041ada1586
build: match upstream with unsafe buffer paths ( #45853 )
...
* build: match upstream with unsafe buffer paths
* Don't assume STL iterators are pointers
Refs https://issues.chromium.org/issues/328308661
* chore: spanify process_singleton_win.cc
2025-03-06 16:04:18 -05:00
yangllu
d987bee007
fix: javascript heap OOM is not raised ( #45895 )
...
fix: javascript heap oom is not raised in node::OOMErrorHandler
node::OOMErrorHandler terminates the process directly without raising an
oom exception. To fix it, set an oom handler into node from electron.
2025-03-06 17:34:19 +01:00
Erick Zhao
431a791a99
chore: emphasize documentation style guide ( #45639 )
...
docs: emphasize documentation style guide
2025-03-06 17:17:06 +01:00
dependabot[bot]
9441cf4627
build(deps): bump dsanders11/project-actions from 1.5.1 to 1.5.2 ( #45901 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](9c80cd31f5...7fc3c5441a )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-06 16:38:31 +01:00
Charles Kerr
bb1c3dff21
chore: bump chromium to 135.0.7049.7 (main) ( #45900 )
...
chore: bump chromium in DEPS to 135.0.7049.7
2025-03-05 16:36:52 -05:00
electron-roller[bot]
49a27cba6b
chore: bump chromium to 135.0.7049.5 (main) ( #45898 )
...
chore: bump chromium in DEPS to 135.0.7049.5
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-05 09:47:38 -06:00
Shelley Vohr
99c943df23
fix: setContentProtection(true) after hide on Windows ( #45868 )
...
fix: content protection after hide on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5789117
2025-03-04 16:39:59 -05:00
Sam Maddock
8c11764800
feat: WebContents.focusedFrame ( #45667 )
...
feat: webContents.focusedFrame
2025-03-04 11:38:58 -05:00
electron-roller[bot]
54136042c6
chore: bump chromium to 135.0.7049.0 (main) ( #45885 )
...
* chore: bump chromium in DEPS to 135.0.7049.0
* 6312439: Revert "Preconnect to the Glic FRE when the button is hovered."
https://chromium-review.googlesource.com/c/chromium/src/+/6312439
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-04 11:20:25 -05:00
dependabot[bot]
28ed8a821a
build(deps): bump actions/download-artifact from 4.1.8 to 4.1.9 ( #45883 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](fa0a91b85d...cc20338598 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-04 12:44:46 +01:00
Niklas Wenzel
ec9b589402
ci: preserve blocked/* labels on collaborator comments ( #45877 )
...
ci: keep `blocked/*` labels on collaborator comments
2025-03-04 10:49:14 +01:00
marekharanczyk
2a7133b7a6
fix: correct electron gin embedder indices ( #45389 )
...
fix: correct gin embedder indices.
Move electron extra embedders to the end of the enum so they do not
interfere with chromium embedders indices.
Also use kEmbedderBlinkTag directly in its index calculation without
adding extra indices from other tags.
2025-03-03 17:03:54 -05:00
electron-roller[bot]
64158114aa
chore: bump chromium to 135.0.7047.0 (main) ( #45873 )
...
chore: bump chromium in DEPS to 135.0.7047.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-03 19:15:23 +01:00
electron-roller[bot]
e8631b2f3a
chore: bump chromium to 135.0.7047.0 (main) ( #45859 )
...
* chore: bump chromium in DEPS to 135.0.7043.0
* chore: bump chromium in DEPS to 135.0.7045.0
* 6305947: Preconnect to the Glic FRE when the button is hovered.
https://chromium-review.googlesource.com/c/chromium/src/+/6305947
* 6207093: Remove line_bounds from ImeCompositionRangeChanged
https://chromium-review.googlesource.com/c/chromium/src/+/6207093
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-03-03 14:26:52 +01:00
Sam Maddock
21ad7cdda5
test: service worker contextBridge leak ( #45852 )
...
* test: contextBridge prototype leak in service workers
* test: deep prototype checks
2025-03-01 09:56:03 +01:00
electron-roller[bot]
add374ef6a
chore: bump chromium to 135.0.7041.2 (main) ( #45850 )
...
* chore: bump chromium in DEPS to 135.0.7041.2
* [Extensions] Remove ExtensionsBrowserClient::GetUserAgent()
https://chromium-review.googlesource.com/c/chromium/src/+/6306854
* chore: update patches
* [api] Remove deprecated FunctionCallbackInfo::Holder()
https://chromium-review.googlesource.com/c/v8/v8/+/6309166
* [test] Add createExternalizableTwoByteString to extension
https://chromium-review.googlesource.com/c/v8/v8/+/6304942
* fixup [test] Add createExternalizableTwoByteString to extension
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-28 17:29:23 -05:00
David Sanders
eac270bea7
build: bump NMV to 135 ( #45789 )
2025-02-28 09:53:02 -05:00
co63oc
36ec9d7236
docs: fix spelling errors in code comments ( #45842 )
...
chore: Fix typos
2025-02-28 12:24:00 +01:00
Michaela Laurencin
3041fd66cd
docs: update timelines for E36 ( #45785 )
...
Update electron-timelines.md
2025-02-28 11:24:40 +01:00
Charles Kerr
b504f65ace
docs: update breaking-changes.md for 35.0.0 ( #45822 )
...
* docs: update breaking-changes.md for 35.0.0
* fixup! docs: update breaking-changes.md for 35.0.0
docs: make lint happy
2025-02-27 22:01:26 -06:00
electron-roller[bot]
5cb87b7110
chore: bump chromium to 135.0.7040.0 (main) ( #45846 )
...
chore: bump chromium in DEPS to 135.0.7040.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-27 21:59:50 -06:00
Charles Kerr
d19cac6772
docs: fix PrinterInfo info in breaking-changes.md ( #45843 )
...
> ### Removed:`isDefault` and `status` properties on `PrinterInfo`
> These properties have been removed from the PrinterInfo Object
> because they have been removed from upstream Chromium.
These properties won't be removed until Electron 36, but
breaking-changes.md lists them as being removed in 35.
This PR corrects the error.
2025-02-27 17:49:58 -06:00
Shelley Vohr
eac1a7ff68
fix: context-menu event emitted in draggable regions ( #45813 )
...
* fix: context-menu event emitted in draggable regions
* fix: only trigger on mouse release
2025-02-27 14:44:46 -05:00
electron-roller[bot]
00089a951b
chore: bump chromium to 135.0.7039.0 (main) ( #45836 )
...
* chore: bump chromium in DEPS to 135.0.7039.0
* chore: update patches
* extensions: Refactor ExtensionService GrantPermissionsAndEnableExtension
https://chromium-review.googlesource.com/c/chromium/src/+/6302374
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-27 13:20:42 -05:00
reito
b8d0f18ff8
docs: add docs about shared texture mode osr ( #45670 )
...
* docs: add docs about shared texture mode osr
* docs: add docs about shared texture mode osr
* docs: fix dot
* 更新 web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2025-02-27 11:10:58 -05:00
co63oc
96c2022483
chore: Fix typos ( #45825 )
2025-02-27 14:31:21 +01:00
Dietrich Ayala
ff05d4a96c
docs: dialog.md - typo fix s/wndow/window/ ( #45831 )
...
Update dialog.md - typo fix
2025-02-27 10:32:42 +01:00
Charles Kerr
989918a59c
refactor: simplify Invoker::IsOK() ( #45803 )
...
* refactor: simplify Invoker::IsOK()
* refactor: might as well make it [[nodiscard]] as well
2025-02-26 18:50:57 -06:00
electron-roller[bot]
6c4b5d81dd
chore: bump chromium to 135.0.7037.0 (main) ( #45811 )
...
* chore: bump chromium in DEPS to 135.0.7036.0
* chore: bump chromium in DEPS to 135.0.7037.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-26 17:30:11 +01:00
Charles Kerr
7d045dcddb
refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) ( #45793 )
...
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)
2025-02-25 19:50:09 -06:00
Charles Kerr
199f6d64db
perf: avoid redundant method calls in EventEmitter ( #45786 )
...
* refactor: move EventEmitter::EmitWithEvent() into EventEmitter::Emit()
* perf: remove redundant calls to isolate() in EventEmitter::Emit()
* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitEvent()
* perf: remove redundant calls to isolate() in EventEmitter::EmitWithoutEvent()
* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitWithoutEvent()
* refactor: remove unused method EventEmitter::isolate()
* refactor: remove unused method EventEmitter::GetWrapper(v8::Isolate*)
* refactor: remove unused method EventEmitter::GetWrapper()
refactor: make the EventEmitter::Base typedef private
* refactor: remove unused typedef EventEmitter::Base
See "Workarounds" section in
https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members
* refactor: remove redundant gin_helper:: namespace use
2025-02-25 19:20:33 -06:00
dependabot[bot]
b82e4585cf
build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 ( #45792 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9e8d0789d4...b56ba49b26 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 15:25:24 -05:00
electron-roller[bot]
9303a3fae9
chore: bump chromium to 135.0.7035.0 (main) ( #45764 )
...
* chore: bump chromium in DEPS to 135.0.7028.0
* chore: bump chromium in DEPS to 135.0.7029.0
* chore: bump chromium in DEPS to 135.0.7031.0
* chore: bump chromium in DEPS to 135.0.7033.0
* Split //component/embedder_support:browser_util into multiple targets
https://chromium-review.googlesource.com/c/chromium/src/+/6246155
* chore: update patches
* build: update filenames.libcxx.gni
* 6275531: Enable Float16Array
https://chromium-review.googlesource.com/c/chromium/src/+/6275531
* chore: bump chromium in DEPS to 135.0.7035.0
* chore: update patches
* Move Service Process Host files to a separate folder
https://chromium-review.googlesource.com/c/chromium/src/+/6089368
* Remove NOTREACHED()s after return statements
https://chromium-review.googlesource.com/c/chromium/src/+/6297811
* Move ServiceProcessTracker and UtilityProcessClient into separate files
https://chromium-review.googlesource.com/c/chromium/src/+/6088677
* chore: update filenames.libcxx.gni
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-25 15:16:15 -05:00
Keeley Hammond
9b6ba1ced1
fix: re-enable MacWebContentsOcclusion feature flag ( #45775 )
2025-02-25 09:28:09 -08:00
dependabot[bot]
7870ade07a
build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 ( #45791 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](62b2cac7ed...f49aabe0b5 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 08:13:06 +01:00
dependabot[bot]
9699422cd6
build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 ( #45790 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65c4c4a1dd...4cec3d8aa0 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-25 08:13:01 +01:00
Charles Kerr
3ee2ec8e4f
build: re-enable unsafe buffer checks ( #45770 )
2025-02-24 20:06:30 -06:00
Charles Kerr
0de1e8e610
refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor ( #45773 )
...
refactor: remove unused isolate arg from GlobalShortcut constructor
has not been used since f1a0d5e811 (#22755 )
2025-02-24 19:38:20 -06:00
Shelley Vohr
01554f39a8
revert: drag and drop icons on Windows ( #45779 )
...
This reverts commit 698cce6707 .
2025-02-24 11:35:29 -06:00
Charles Kerr
69eb076bca
refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc ( #45771 )
...
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
2025-02-24 11:09:01 -05:00
reito
f3259be73c
feat: remove osr framerate limit when use shared texture ( #45669 )
...
feat: remove framerate limit, if use shared texture osr.
2025-02-24 10:21:46 -05:00
David Sanders
698cce6707
fix: drag and drop icons on Windows ( #45767 )
2025-02-24 09:54:08 +01:00
Nilay Arya
3eab549369
docs: added upstream doc links for node, chromium, and v8 in default_app ( #45392 )
2025-02-22 10:15:36 -06:00
Shelley Vohr
3e51ee516e
fix: rework and improve legacyMainResolve patch ( #45754 )
...
fix: rework and improve legacyMainResolve patch
2025-02-22 10:06:04 -06:00
Sam Maddock
e3f61b465d
refactor: move extension APIs to session.extensions ( #45597 )
...
refactor: move extensions to session.extensions
2025-02-21 17:36:51 -06:00
Erick Zhao
a63f6143ea
docs: clarify navigationhistory offsets ( #45616 )
...
* docs: clarify navigationhistory offsets
* "relative offset"
2025-02-21 17:35:17 -06:00
Charles Kerr
2a383e9ddd
refactor: use C++20's contains() method ( #45742 )
...
* chore: use std::map<>::contains() instead of count() or find()
* chore: use std::map<>::contains() instead of base::Contains()
2025-02-21 17:33:43 -06:00
electron-roller[bot]
612da3ec47
chore: bump chromium to 135.0.7027.0 (main) ( #45677 )
...
* chore: bump chromium in DEPS to 135.0.7021.0
* chore: bump chromium in DEPS to 135.0.7023.0
* chore: update patches
* chore: gen-libc++-filenames.js
* [Extensions] Add a BUILD.gn file for the chrome.system.display API.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6227347
* chore: bump chromium in DEPS to 135.0.7025.0
* fixup! [Extensions] Add a BUILD.gn file for the chrome.system.display API.
* [DevTools] Add support for automatic workspace folders.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6275926
* Add UseCounter for potential PNA 2.0 breakage
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6259197
* Remove references to NavigationEntry/Controller in Zoom code.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6258070
* chore: update patches
* Allow DevTools to record UmaHistogramMediumTimes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6183713
* chore: update patches
* [gpu] Remove unnecessary media_buildflags include
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6286526
* chore: bump chromium in DEPS to 135.0.7027.0
* chore: update patches
* Remove type alias
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6280957
* [Refactor] Make ExtensionRegistrar a browser keyed service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6285230
* Remove unused functions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6278736
* chore: IWYU
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-02-21 14:46:51 -08:00
Keeley Hammond
6248c2436a
fix: re-enable synchronous spellcheck on Windows ( #45712 )
...
* fix: re-enable synchronous spellcheck on Windows
* revert: fix: empty suggestions with windows platform checker
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-02-21 14:45:46 -08:00
Charles Kerr
8d58999135
refactor: use base's map utills in WebFrameMain ( #45741 )
...
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameTreeNodeId()
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameToken()
2025-02-21 15:28:00 -06:00
Shelley Vohr
324fc0f62a
fix: crash on getUserMedia with invalid chromeMediaSourceId ( #45733 )
...
* fix: crash on getUserMedia with invalid chromeMediaSourceId
* test: add a test
2025-02-21 10:17:52 -06:00
Charles Kerr
f62668e2e3
refactor: use base::as_byte_span() in EncodeToken(). ( #45723 )
...
This matches the change in upstream's serial_chooser_context.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/5247305
2025-02-20 20:20:16 -05:00
Charles Kerr
a15fa87558
refactor: use base::as_bytes() in WriteAsciiChunk() ( #45724 )
...
refactor: use base::as_bytes() in WriteAsciiChunk()
this avoids a reinterpret_cast and a static_cast
2025-02-20 20:19:48 -05:00
Charles Kerr
ceaa0e26c7
refactor: use base::as_string_view() ( #45722 )
...
Use `base::as_string_view()` as a safer alternative to `reinterpret_cast`
in a couple of places.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5472408
2025-02-20 18:19:36 -06:00
Shelley Vohr
4867b5dc75
refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected ( #45671 )
...
* refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected
https://chromium-review.googlesource.com/c/chromium/src/+/5737296
* chore: review feedback
2025-02-20 16:44:35 -06:00
Shelley Vohr
340fdaf511
feat: allow setting roundedCorners on Windows ( #45594 )
...
* feat: allow setting roundedCorners on Windows
* Update docs/api/structures/base-window-options.md
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: Will Anderson <will@itsananderson.com >
2025-02-20 15:39:12 -05:00
Sam Maddock
5ea885c87f
build: skip chromium git cookie on forks ( #45735 )
2025-02-20 14:38:20 -05:00
Shelley Vohr
d8baceb08c
fix: crash loading about:blank in subframes ( #45694 )
...
fix: crash loading about:blank in subframes
2025-02-20 12:07:15 -05:00
Charles Kerr
d6f4982522
fix: possible timing issue in utility-process spec ( #45690 )
...
This fixture has been calling process.exit() immediately after writing
to stdout and stderr, which the Node.js docs say is risky behavior:
> Calling process.exit() will force the process to exit as quickly as
> possible even if there are still asynchronous operations pending that
> have not yet completed fully, including I/O operations to
> process.stdout and process.stderr.
This fixture's been around for years without problems (AFAIK).
The writes are very small ('hello\n' and 'world') and finish quickly.
But recently I've been testing on a very slow CI machine. There, I see
this spec flaking when it expects stderr to be 'world' but it gets ''.
This PR changes the fixture to wait for stdout & stderr to flush
before calling process.exit().
2025-02-19 23:28:04 -06:00
Sam Maddock
9d558cec5e
fix: action.openPopup function missing ( #45697 )
2025-02-19 18:05:02 -05:00
Shelley Vohr
159e1a42b3
refactor: track downloads by guid ( #45675 )
2025-02-19 16:49:34 -06:00
Sam Maddock
b50066f420
fix: extension web workers net request failing ( #45698 )
2025-02-19 13:08:28 -05:00
Milan Burda
22b7403cd1
chore: remove deprecated systemPreferences.isAeroGlassEnabled() ( #45563 )
2025-02-18 18:59:00 -06:00
Charles Kerr
670e0ca076
chore: disable 'should lock the keyboard' test on macOS ( #45681 )
2025-02-18 18:00:01 -06:00
Sam Maddock
ee67bc7dcb
fix: dangling speculative frames ( #45609 )
...
* fix: dangling speculative frames
* harden lifecycle state checks
* feedback
* add const
2025-02-18 17:52:05 -05:00
John Kleinschmidt
ecd7eb36ac
build: remove appveyor bake ( #45073 )
2025-02-18 12:04:47 -08:00
electron-roller[bot]
47572286f3
chore: bump chromium to 135.0.7015.0 (main) ( #45500 )
...
* https://chromium-review.googlesource.com/c/chromium/src/+/6230977
* chore: bump chromium to 135.0.7012.0
* chore: update accelerator.patch
Support parsing Ctrl+Alt shortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/6238137
* 6234236: Reapply bindings: Pass CppHeap on Isolate creation | https://chromium-review.googlesource.com/c/chromium/src/+/6234236
* 6234614: [ios blink] Move to use external begin frame source | https://chromium-review.googlesource.com/c/chromium/src/+/6234614
* chore: update chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
no manual changes; patch applied with fuzz
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch applied with fuzz
* chore: remove chromium/cherry-pick-dd8e2822e507.patch
landed upstream
* 6188884: Grit: Remove output_all_resource_defines from list of valid attributes. | https://chromium-review.googlesource.com/c/chromium/src/+/6188884
* 6226981: [views-ax] Remove View::GetAccessibleNodeData() method | https://chromium-review.googlesource.com/c/chromum/src/+/6226981
* 6214895: [views-ax] Deprecate View::NotifyAccessibilityEvent | https://chromium-review.googlesource.com/c/chromium/src/+/6214895
* 6196494: Remove ImageView::SetImage() with ImageSkia param | https://chromium-review.googlesource.com/c/chromium/src/+/6196494
* 6236267: [cleanup] Remove unused PrinterBasicInfo fields | https://chromium-review.googlesource.com/c/chromium/src/+/6236267
* refactor: remove status, isDefault properties from PrinterInfo
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6236267
* chore: lint
* fixup: added mas bypass to new file added in https://chromium-review.googlesource.com/c/chromium/src/+/6208630 see slack for more context
* chore: node script/gen-libc++-filenames.js
* chore: e patches all
* fix: duplicate crdtp symbols
* chore: update patches
* fixup! [Media Features] Remove launched features
---------
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-02-18 11:51:27 -05:00
Sam Maddock
6be1151ffc
fix: win.closeFilePreview recreates panel when called twice ( #45319 )
...
* fix: close quick look during tests on macOS
* use longer delay 🤷
* fix: sharedPreviewPanel being recreated on close
* test: ensure preview panel gets closed
2025-02-17 17:25:19 -05:00
Sam Maddock
c0422d7cc9
refactor: dispatch IPC messages from Session ( #45452 )
...
* refactor: dispatch IPC messages from Session
* refactor: move MessageHost to Session
2025-02-17 16:36:28 -05:00
reito
e9ba5876d1
fix: osr stutter fix backport for electron. ( #45572 )
2025-02-17 22:13:44 +01:00
Alice Zhao
02be7c1185
feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering ( #44692 )
...
* feat: add excludeUrls to web request filter
* refactor: add deprecated field
* test: update tests
* lint: newline
* docs: improve API doc
* fix: add is filter defined property to match all urls
* refactor: remove includeUrls
* refactor: remove typescript binding
* refactor: all_url
* refactor: remove isDefined methods
* refactor: remove comment
* fix: logic
* docs: add to breaking changes
2025-02-17 12:40:47 -08:00
Shelley Vohr
7dfcec931a
build: run source cache clean daily ( #45652 )
2025-02-17 13:57:22 -05:00
John Kleinschmidt
a329024793
build: make sure chromium cookie is set everywhere ( #45631 )
2025-02-14 13:19:43 -05:00
Robo
137a552641
fix: support for v8.setHeapSnapshotNearHeapLimit api ( #45606 )
...
* fix: support for v8.setHeapSnapshotNearHeapLimit api
* docs: add support
2025-02-14 10:00:39 -06:00
electron-roller[bot]
a841d6484c
chore: bump node to v22.14.0 (main) ( #45578 )
...
* chore: bump node in DEPS to v22.14.0
* src: move more crypto impl detail to ncrypto dep
https://github.com/nodejs/node/pull/56421
* test: move crypto related common utilities in common/crypto
https://github.com/nodejs/node/pull/56714
* module: add findPackageJSON util
https://github.com/nodejs/node/pull/55412
* module: mark evaluation rejection in require(esm) as handled
https://github.com/nodejs/node/pull/56122
* chore: fixup patch indices
* deps: move inspector_protocol to deps
https://github.com/nodejs/node/pull/56649
* fixup! src: move more crypto impl detail to ncrypto dep
* fixup! deps: move inspector_protocol to deps
* fixup! src: move more crypto impl detail to ncrypto dep
* crypto: fix checkPrime crash with large buffers
https://github.com/nodejs/node/pull/56559
* tls: fix error stack conversion in cryptoErrorListToException()
https://github.com/nodejs/node/pull/56554
* module: add findPackageJSON util
https://github.com/nodejs/node/pull/55412
Our revert of native legacyMainResolve makes this very difficult to make
work, so disable for now.
* lib: add typescript support to STDIN eval
https://github.com/nodejs/node/pull/56359
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-02-14 11:05:01 +01:00
Shelley Vohr
2af57c4b6a
fix: osr crash on window close ( #45573 )
2025-02-14 11:01:00 +01:00
Shelley Vohr
47dbab3856
fix: pointer lock permission after focus loss and regain ( #45574 )
2025-02-14 10:22:13 +01:00
Charles Kerr
a1e4550c9e
chore: disable flaky content tracing tests on Linux ( #45612 )
2025-02-14 10:18:42 +01:00
Charles Kerr
2b8706bf44
chore: change node test timeout from 20m to 30m ( #45611 )
2025-02-13 17:27:35 -06:00
Shelley Vohr
3a3595f2af
build: remove PDF edited saved files patch ( #45604 )
2025-02-13 14:52:31 -05:00
Shay Molcho
9a2ee763d0
docs: added missing period for consistency and readability ( #45333 )
...
Added missing period for consistency and readability
Added a missing period in a specific part of the text to maintain consistency across the document. This ensures a uniform writing style, improves readability, and aligns with the formatting used throughout the content.
2025-02-13 10:55:43 +01:00
Keeley Hammond
237429bb85
build: set chromium cookie on depot tools requests ( #45581 )
...
* build: set chromium cookie on depot tools requests
* build: correct secrets syntax
* build: handle windows cmd
2025-02-12 17:44:43 +01:00
Will Anderson
50d1c803dd
chore: remove var declarations from DEPS that no longer have any effect ( #45535 )
...
* chore: Remove checkout_google_benchmark var that no longer has any effect
This variable stopped having any effect in https://chromium-review.googlesource.com/c/chromium/src/+/4322306
It was removed from Chromium entirely in https://chromium-review.googlesource.com/c/chromium/src/+/4339138
* chore: remove checkout_oculus_sdk and checkout_libaom from DEPS
2025-02-12 10:51:11 +01:00
John Kleinschmidt
0d3e34d0be
test: disable unexpectedly quit dialog on macOS ( #45553 )
...
* test: disable unexpectedly quit dialog on macOS
* test: take screenshot before keyboard lock test
* Revert "test: take screenshot before keyboard lock test"
This reverts commit 3ba5c6984f .
2025-02-11 21:08:38 -05:00
Charles Kerr
aa06b065c0
chore: bump chromium to 134.0.6998.10 (main) ( #45564 )
...
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com >
2025-02-11 17:26:39 -06:00
Felix Rieseberg
9f47c9a051
feat: Restore webContents navigation history and page state ( #45433 )
...
* feat: Working navigationHistory.restore with just title/url
* feat: Restore page state, too
* chore: Docs, lint, tests
* Implement feedback
* More magic
* Make _awaitNextLoad truly private
* Implement API group feedback
* One more round of feedback
2025-02-11 15:09:38 -08:00
Will Anderson
6fdfca6e49
build: make gen-libc++-filenames.js produce the same results on Windows ( #45556 )
2025-02-11 12:56:05 +01:00
dependabot[bot]
196352bf0b
build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 ( #45561 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.8 to 3.28.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](dd746615b3...9e8d0789d4 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-11 11:39:29 +01:00
Robo
46d316692d
fix: asan build on macOS ( #45541 )
...
* fix: asan build on macOS
* chore: fix build
2025-02-11 15:04:07 +09:00
Josh Jancourtz
2f288bc7cc
docs: fix grammar in preload tutorial summary ( #45522 )
2025-02-10 16:15:32 -05:00
Calvin
f5025b6246
fix: avoid IPC for renderer webFrame.getZoom... APIs ( #45499 )
...
* fix: avoid IPC for renderer `webFrame.getZoom...` APIs
* Remove `DoGetZoomLevel` IPC
* Fix synchronous behavior & nullptr deref
* Use local root
2025-02-10 16:09:11 -05:00
Milan Burda
e055ce7c39
chore: deprecate systemPreferences.isAeroGlassEnabled() ( #45434 )
2025-02-10 15:17:07 -05:00
John Kleinschmidt
14fe0932f0
test: make sure test window is on top for focus tests ( #45435 )
2025-02-10 13:40:27 -05:00
dependabot[bot]
3ba85878a5
build(deps): bump github/codeql-action from 3.28.6 to 3.28.8 ( #45453 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.6 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](17a820bf2e...dd746615b3 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-10 19:40:01 +01:00
Keeley Hammond
70168c8bdc
fix: fix mksnapshot gen/v8 path ( #45488 )
...
* fix: fix mksnapshot gen/v8 path
* build: use 7z compression
* build: unzip mksnapshot on Windows and update zip
* chore: escape backslashes
* chore: try another attempt
* chore: remove rmdir for now
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-10 10:21:29 -05:00
Sam Maddock
e4cd162433
docs: fix powerMonitor event types ( #45518 )
...
* fix: powerMonitor event types
* fix: thermal-state-change missing Returns
2025-02-10 10:13:11 -05:00
Calvin
4085185e2d
docs: transactions-updated event type ( #45527 )
...
fix: `transactions-updated` event type
2025-02-10 10:12:17 -05:00
Shelley Vohr
a141f68c83
refactor: use node::tracing::Agent() directly ( #45489 )
...
refactor: use node::tracing::Agent()
2025-02-09 21:36:42 +01:00
Shelley Vohr
9199d5c610
fix: window maximizing with Mica ( #45456 )
...
* fix: window maximizing with Mica
* Fix rounded corners after restore
2025-02-07 15:00:36 -05:00
michal-pichlinski-openfin
96460becf9
fix: Update widget visibility in NativeWindowMac::ShowInactive ( #45427 )
...
When using `views::WebView` on macOS `NativeWidgetMacNSWindowHost`
contains a layer and compositor responsible for drawing web contents.
To trigger drawing `NativeWidgetMacNSWindowHost::OnVisibilityChanged`
needs to be called and `[NSWindow orderFrontRegardless]` does not trigger
`[NSWindow orderWindow:relativeTo:]` which can change
`NativeWidgetMacNSWindowHost` visiblity with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::OnVisibilityChanged()
-[ViewsNSWindowDelegate onWindowOrderChanged:]
-[NativeWidgetMacNSWindow orderWindow:relativeTo:]
```
`views::Widget` has method for showing inactive window:
`views::Widget::ShowInactive` which triggers
`NativeWidgetMacNSWindowHost::OnVisibilityChanged` with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMacNSWindowHost::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMac::Show(ui::mojom::WindowShowState, gfx::Rect const&)
views::Widget::ShowInactive() + 168
```
However this call seems to be insufficient to bring window to front,
therefore `[NSWindow orderFrontRegardless]` still needs to be called.
Calling `views::Widget::ShowInactive` ensures that all logic related to
showing Chromium widget will be properly executed, but onfortunately it
does not call `[NSWindow orderWindow:relativeTo:]` which is used to
disabling headless mode by the `ElectronNSWindow`, therefore we need to
trigger it manually through exposed `[ElectronNSWindow disableHeadlessMode]`.
Fixes : #45415
2025-02-07 11:31:08 -08:00
Charles Kerr
d7c6fb8250
refactor: follow upstream's suggestions on when to use EmptyGURL() ( #45498 )
...
- Prefer GURL() when we want to return a non-reference empty URL.
- In ServiceWorkerMain::GetStorageKey(), use a reference instead
of instantiating a new temporary GURL.
From url/gurl.h:
> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
2025-02-07 13:58:31 -05:00
Charles Kerr
3db691804b
chore: bump chromium 134.0.6990.0 ( #45507 )
...
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6219304
Partially upstreamed by @codebytere
* chore: e patches all
2025-02-07 10:25:46 -06:00
David Sanders
4512b2b5c4
chore: remove remaining references to AppVeyor ( #45339 )
2025-02-07 12:57:36 +01:00
John Kleinschmidt
7bde100a1a
build: make sure there is at least 35GB free for source cache ( #45501 )
...
build: make sure there is at least 35GB free for cache
2025-02-07 12:03:38 +01:00
Kavindu Udara
d0110d897d
docs: remove width and height params ( #45331 )
...
remove width and height params
2025-02-07 11:42:16 +01:00
Charles Kerr
ef34892a76
chore: bump chromium 134.0.6989.0 ( #45506 )
...
* chore: bump chromium to 134.0.6989.0
* chore: update patches/chromium/cherry-pick-dd8e2822e507.patch
* chore: e patches all
2025-02-07 10:00:09 +01:00
Charles Kerr
67f5ac5bbc
fix: RenderFrameHost nullptr dereference ( #45487 )
...
* fix: add nullptr tests before using render_frame_
* refactor: extract-method HasRenderFrame()
2025-02-06 22:02:57 -06:00
Milan Burda
517935cd55
refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor ( #45484 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
2025-02-07 10:44:19 +09:00
Samuel Attard
326957009a
chore: cherry-pick dd8e2822e507 from chromium ( #45495 )
2025-02-06 14:33:42 -08:00
electron-roller[bot]
213165a467
chore: bump chromium to 134.0.6988.0 (main) ( #45334 )
...
* chore: bump chromium in DEPS to 134.0.6976.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6171046
process_info_mac.cc -> process_info_mac.mm
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6196857
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6182296
https://chromium-review.googlesource.com/c/chromium/src/+/6183404
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
A lot changed in the upstream implementation. There's a good chance I got
this wrong as threading has changed and moved some variables into globals.
* chore: remove build_remove_vr_directx_helpers_dependency.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6186102
This landed upstream
* chore: e patches all
* chore: update net::CookieInclusionStatus::ExclusionReason enum
https://chromium-review.googlesource.com/c/chromium/src/+/6183252
https://chromium-review.googlesource.com/c/chromium/src/+/6185544
* chore: update content::WebAuthenticationDelegate import
https://chromium-review.googlesource.com/c/chromium/src/+/6189769
* Revert "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 1a57ba5d59 .
* chore: bump chromium in DEPS to 134.0.6978.0
* chore: bump chromium in DEPS to 134.0.6980.0
* chore: bump chromium in DEPS to 134.0.6982.0
* chore: bump chromium in DEPS to 134.0.6984.0
* 6196281: Allow direct embedder IsPdfInternalPluginAllowedOrigin() interaction
https://chromium-review.googlesource.com/c/chromium/src/+/6196281
* 6196283: Delete PdfInternalPluginDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/6196283
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6986.0
* chore: update patches
* 6205762: Support option to use window.showSaveFilePicker() in PDF attachment code
https://chromium-review.googlesource.com/c/chromium/src/+/6205762
See also:
* https://issues.chromium.org/issues/373852607
* 5939153: [PDF] Add PdfUseShowSaveFilePicker feature flag | https://chromium-review.googlesource.com/c/chromium/src/+/5939153
* 6205761: Delete spurious Ink-specific code in pdf_viewer.ts | https://chromium-review.googlesource.com/c/chromium/src/+/6205761
* 6209609: Remove WebVector: Automatic changes
https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6205488: UI: make QT5 optional
https://chromium-review.googlesource.com/c/chromium/src/+/6205488
* 6178281: Rename pak files from branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/6178281
* fixup! 6209609: Remove WebVector: Automatic changes https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6193249: Switch from safe_browsing::EventResult to enterprise_connectors:EventResult
https://chromium-review.googlesource.com/c/chromium/src/+/6193249
* 6197457: Remove Pause/ResumeReadingBodyFromNet IPCs
https://chromium-review.googlesource.com/c/chromium/src/+/6197457
* 6191230: Record total time spent on a picture in picture window
https://chromium-review.googlesource.com/c/chromium/src/+/6191230
* chore: bump chromium in DEPS to 134.0.6988.0
* chore: update patches
* 6215440: Remove base/ranges/.
https://chromium-review.googlesource.com/c/chromium/src/+/6215440
* Disable unsafe buffers error
Not sure what changed, but we're now seeing unsafe buffer errors in Chromium code, at least when using reclient. Will update this comment if we find out the cause.
* 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* fix `setDisplayMediaRequestHandler` test
Given how this test is written, I would expect this assertion to be false. It seems the oppositue was true before, but that was also acknowledged to be suprising. Seems that the underlying implementation is now fixed and works as expected.
* fixup! 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* chore: udpate patches
* Multiple PRS: https://chromium-review.googlesource.com/c/chromium/src/+/6185544 | https://chromium-review.googlesource.com/c/chromium/src/+/6183252
* fix: cast enum class to numeric type
* fix: add 1 to MAX_EXCLUSION_REASON because enum values are zero-based, and we want the total count of reasons.
* Reapply "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 760b1a519b .
* refactor: use ExclusionReasonBitset::kValueCount for size
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-06 15:30:54 -05:00
David Sanders
3dad07f338
test: dump Electron process PID to path if environment variable set ( #45481 )
2025-02-06 09:15:10 -06:00
Anh Le
6adc737a89
docs: use correct headings in tutorial/security.md ( #45397 )
2025-02-06 11:16:24 +01:00
max54nj
c0282eb9c8
docs: style fixes ( #45458 )
...
* docs: fix code field
* docs: add missing space
2025-02-05 15:10:07 -05:00
Maria Alejandra Arias Frontanilla
471b1a873d
fix: fix typo in docs why-electron.md ( #45437 )
2025-02-05 09:26:47 -06:00
Shelley Vohr
aee8ea8b10
fix: WCO not working with some window configurations ( #45422 )
2025-02-05 12:48:51 +01:00
Shelley Vohr
57cf4fc846
fix: legacyMainResolve respecting permission model ( #45421 )
...
fix: legacyMainResolve respecting permission model
2025-02-05 12:48:34 +01:00
Charles Kerr
9fe12cd01b
fix: handle exclude aliasing in InclusionStatusToString() ( #45454 )
...
* refactor: use MakeFixedFlatMap() in InclusionStatusToString()
* fix: add log message for EXCLUDE_ALIASING
refactor: add static_assert() to ensure our messages stay
in sync with the CookieInclusion reasons in net/cookies/
2025-02-05 12:48:11 +01:00
Shelley Vohr
6486ce8191
build: remove debugger agent timeout patch ( #45457 )
2025-02-05 12:47:54 +01:00
Robo
bec6ddda70
feat: route deprecated sync clipboard read through permission checks ( #45377 )
...
* feat: route deprecated clipboard commands through permission checks
* docs: address review feedback
* fix: enable checks for child windows
2025-02-05 15:13:29 +09:00
Shelley Vohr
e9d5eeb118
build: try removing embedder exception patch ( #45429 )
2025-02-04 19:39:20 +01:00
Keeley Hammond
c147e4fa81
build: add win toolchain for release builds ( #45380 )
...
* build: add win toolchain for release builds
* build: fix installed_software.json script
* chore: run pwsh script within src
* build: fixup uploader arch
2025-02-03 22:06:01 -08:00
Niklas Wenzel
1d27a27813
docs: document deletion of databases directory ( #45412 )
2025-02-03 16:28:44 -05:00
Niklas Wenzel
d3bead5e0e
docs: mention C++20 requirement in breaking changes document ( #45413 )
...
* docs: mention C++20 requirement in breaking changes document
* chore: fix linter issue
2025-02-03 13:19:26 -08:00
David Sanders
9f1bb531ba
build: always use python3 in script/lib/get-version.js ( #45400 )
...
build: always use python3 in script/lib/get-version.js
2025-02-03 16:13:36 -05:00
Shelley Vohr
9971087678
build: remove outdated Node.js serdes patch ( #45401 )
...
build: remove outdates Node.js serdes patch
2025-02-03 14:09:02 +01:00
Shelley Vohr
e7fa5c709c
fix: incorrect WCO tooltip in RTL ( #45405 )
2025-02-03 10:50:50 +01:00
Shelley Vohr
7a1d410e0a
fix: default path not working on KDE Linux ( #45402 )
2025-02-03 09:49:48 +01:00
Sam Maddock
e2a7981dd3
feat: view.getVisible() ( #44999 )
...
* feat: view.getVisible()
* test: visible apis
* docs: clarify getVisible
2025-01-31 13:27:16 -05:00
Sam Maddock
26da3c5d6e
feat: service worker preload scripts for improved extensions support ( #44411 )
...
* feat: preload scripts for service workers
* feat: service worker IPC
* test: service worker preload scripts and ipc
2025-01-31 09:32:45 -05:00
Shelley Vohr
bc22ee7897
build: fix slack-github-action for backports ( #45388 )
...
build: fix slack-github-action for backports
2025-01-31 10:29:50 +01:00
Shelley Vohr
784201ecee
build: try removing Read/WriteBarrier patch ( #45393 )
...
build: try removing Read/WriteBarrier patch
2025-01-31 10:29:34 +01:00
Shelley Vohr
6e72cbb5e0
fix: multiple directory selection on Linux ( #45373 )
2025-01-30 16:34:44 +01:00
Shelley Vohr
233b99a0a8
chore: update chrome.scripting.execute logic ( #45369 )
...
chore: update chrome.scripting.execute logic
Refs:
- https://chromium-review.googlesource.com/c/chromium/src/+/6123601
- https://chromium-review.googlesource.com/c/chromium/src/+/6142377
- https://chromium-review.googlesource.com/c/chromium/src/+/6173554
2025-01-30 12:56:44 +01:00
Shelley Vohr
43e328f363
chore: update pdf_viewer_private.idl ( #45370 )
...
chore: update pdf_viewer_private.idl
- https://chromium-review.googlesource.com/c/chromium/src/+/6160067
2025-01-30 11:03:27 +01:00
John Kleinschmidt
8543820d98
build: fixup concurrent builds on protected branches ( #45355 )
2025-01-29 16:47:25 -05:00
electron-roller[bot]
93f4a93e12
chore: bump node to v22.13.1 (main) ( #45307 )
...
* chore: bump node in DEPS to v22.13.1
* chore: fixup GN build file
* https://github.com/nodejs/node/pull/55529
* https://github.com/nodejs/node/pull/55798
* https://github.com/nodejs/node/pull/55530
* module: simplify --inspect-brk handling
https://github.com/nodejs/node/pull/55679
* src: fix outdated js2c.cc references
https://github.com/nodejs/node/pull/56133
* crypto: include openssl/rand.h explicitly
https://github.com/nodejs/node/pull/55425
* build: use variable for crypto dep path
https://github.com/nodejs/node/pull/55928
* crypto: fix RSA_PKCS1_PADDING error message
https://github.com/nodejs/node/pull/55629
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* test,crypto: make crypto tests work with BoringSSL
https://github.com/nodejs/node/pull/55491
* fix: suppress clang -Wdeprecated-declarations in libuv
https://github.com/libuv/libuv/pull/4486
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
* test: make test-node-output-v8-warning more flexible
https://github.com/nodejs/node/pull/55401
* [v22.x] Revert "v8: enable maglev on supported architectures"
https://github.com/nodejs/node/pull/54384
* fix: potential WIN32_LEAN_AND_MEAN redefinition
https://github.com/c-ares/c-ares/pull/869
* deps: update nghttp2 to 1.64.0
https://github.com/nodejs/node/pull/55559
* src: provide workaround for container-overflow
https://github.com/nodejs/node/pull/55591
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* chore: fixup patch indices
* fixup! module: simplify --inspect-brk handling
* lib: fix fs.readdir recursive async
https://github.com/nodejs/node/pull/56041
* lib: avoid excluding symlinks in recursive fs.readdir with filetypes
https://github.com/nodejs/node/pull/55714/
This doesn't currently play well with ASAR - this should be fixed in a follow up
* test: disable CJS permission test for config.main
This has diverged as a result of our revert of
src,lb: reducing C++ calls of esm legacy main resolve
* fixup! lib: fix fs.readdir recursive async
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-29 15:41:00 -05:00
Robo
ecd5d0a3a4
fix: crash in gin::wrappable::secondweakcallback ( #45368 )
2025-01-29 10:20:37 -08:00
Niklas Wenzel
8cf2e46c1f
docs: reference security guide in ipcRenderer.on docs ( #45325 )
2025-01-29 12:50:20 +01:00
dependabot[bot]
50387043d1
build(deps): bump github/codeql-action from 3.28.1 to 3.28.6 ( #45351 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.1 to 3.28.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b6a472f63d...17a820bf2e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-29 07:01:15 +01:00
Keeley Hammond
e715607178
build: use Python311 exe ( #45360 )
...
build: yse Python311 exe
2025-01-28 11:59:04 -08:00
Milan Burda
0e388bce3e
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist ( #45318 )
...
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist
2025-01-28 14:58:48 +01:00
dependabot[bot]
9457a56607
build(deps): bump actions/setup-node from 4.1.0 to 4.2.0 ( #45353 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](39370e3970...1d0ff469b7 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 14:57:39 +01:00
dependabot[bot]
f9553a35d5
build(deps): bump actions/stale from 9.0.0 to 9.1.0 ( #45354 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](28ca103628...5bef64f19d )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 14:56:34 +01:00
dependabot[bot]
e2ef160beb
build(deps): bump actions/checkout from 4.1.6 to 4.2.2 ( #45352 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 10:48:35 +01:00
David Lönnhager
ae56a03e33
fix: crash parsing CLSID in shell.readShortcutLink() ( #45195 )
...
* fix: crash parsing CLSID in shell.readShortcutLink
* fix: ignore clsid if it could not be set
2025-01-27 15:22:56 -05:00
Keeley Hammond
4629e449a9
build: remove generate-sas-token ( #45347 )
2025-01-27 12:21:53 -08:00
Keeley Hammond
74c6669a8e
build: use windows builders for win-publish ( #45340 )
2025-01-24 14:43:38 -08:00
Niklas Wenzel
5c67cd9150
docs: fix broken code in drag and drop example ( #45332 )
2025-01-24 13:28:30 -08:00
Niklas Wenzel
f66a0c2acf
build: create maintainer issue template and disable blank issues ( #45309 )
...
* build: create maintainer task issue template and disable blank issues
* Implement review feedback by @dsanders11
* Rename issue template file
2025-01-24 13:28:05 -08:00
Sam Maddock
a467d0684e
feat: ServiceWorkerMain ( #45232 )
...
* feat: ServiceWorkerMain
* refactor: disconnect remote
* handle version_info_ nullptr case
* initiate finish request when possible and enumerate errors
* explicit name for test method
* oops
* fix: wait for redundant version to stop before destroying
* docs: clarify when undefined is returned
* chore: remove extra semicolons
2025-01-24 08:33:44 -05:00
electron-roller[bot]
75eac86506
chore: bump chromium to 134.0.6968.0 (main) ( #45172 )
...
* chore: bump chromium in DEPS to 134.0.6948.0
* chore: update can_create_window.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6151982
no patch code changes, but had to manually apply due to upstream context shear
* chore: update proxy_config_monitor.patch
no manual changes; patch applied with fuzz 2
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6126219
* chore: update build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6149256
* chore: update adjust_accessibility_ui_for_electron.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6105650
no patch code changes, but had to manually apply due to upstream context shear
* chore: e patches all
* chore: use fully-qualified path for all.gn
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* chore: do not use a variable when assigning rtc_use_h264
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* Move GlobalShortcutListenerLinux to //ui/base
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6097375
* [MPArch Guest View] Make WebPreferences queried per frame tree root
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6096390
* [Status Icons] Allow vector resources
https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* [Extensions] Move MatchOriginAsFallbackBehavior to Mojom
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6141793
* Remove StrongAlias::Hasher
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6132291
* Rename text-change and select-change methods and related stuff
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6148816
* [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker
https://chromium-review.googlesource.com/c/chromium/src/+/6115161
* [Extensions Cleanup] Move creation of tab-based ports to factory method
https://chromium-review.googlesource.com/c/chromium/src/+/6143725
* refactor: add StatusIconGtk::SetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
copied from chrome/browser/status_icons/status_icon.cc
* refactor: add TrayIconLinux::GetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
remove unused filter_ field
* chore: bump chromium in DEPS to 134.0.6950.0
* chore: bump chromium in DEPS to 134.0.6952.0
* chore: bump chromium in DEPS to 134.0.6954.0
* chore: bump chromium in DEPS to 134.0.6956.0
* chore: update Chromium patches
* 6165749: Check scanout support in RenderableGpuMemoryBufferPool | https://chromium-review.googlesource.com/c/chromium/src/+/6165749
* 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6958.0
* chore: bump chromium in DEPS to 134.0.6960.0
* chore: update chromium patches
* 6168371: Remove extensions GlobalShortcutListener wrapper | https://chromium-review.googlesource.com/c/chromium/src/+/6168371
* chore: update patches
* 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | https://chromium-review.googlesource.com/c/chromium/src/+/6161637
* chore: bump chromium in DEPS to 134.0.6962.0
* 6177329: Remove policy.used_policy_certificates pref on ChromeOS | https://chromium-review.googlesource.com/c/chromium/src/+/6177329
* 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | https://chromium-review.googlesource.com/c/chromium/src/+/6180524
* 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6144831
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6964.0
* 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | https://chromium-review.googlesource.com/c/chromium/src/+/6181010
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6966.0
* 6180598: [api] Remove Reallocate | https://chromium-review.googlesource.com/c/v8/v8/+/6180598
* 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | https://chromium-review.googlesource.com/c/chromium/src/+/6170781
* chore: update filenames.libcxx.gni
* 6168207: cdm: Remove widevine_cdm_version.h | https://chromium-review.googlesource.com/c/chromium/src/+/6168207
* chore: bump chromium in DEPS to 134.0.6968.0
* 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | https://chromium-review.googlesource.com/c/chromium/src/+/6030552
* fix: use explicit copy to replace realloc impl
https://chromium-review.googlesource.com/c/v8/v8/+/6180598
https://issues.chromium.org/issues/331326406
As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway"
* fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* fix: undefine win32 StrCat
https://chromium-review.googlesource.com/c/chromium/src/+/6172292
* fix: //device/vr:directx_helpers breaking the build
https://chromium-review.googlesource.com/c/chromium/src/+/6064548
Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/6186102
* fix: avoid calling ui::Layer::SetFillsBoundsOpaquely
https://chromium-review.googlesource.com/c/chromium/src/+/6175787
The layer opacity is determined by the background color's alpha value
* fix: build with proprietary_codecs
The explicit setting of rtc_use_h264 is no longer needed since
https://webrtc-review.googlesource.com/c/src/+/62380
* fix: increase empty trace file size threshold
https://chromium-review.googlesource.com/c/chromium/src/+/6176642
Traces now contain a net-constants property to allow them to be converted to a net log.
These contain ~1240 new properties with formatted JSON data.
* fix: node tests missing resource management globals
https://chromium-review.googlesource.com/c/chromium/src/+/6174695
* fixup! fix: use explicit copy to replace realloc impl
* chore: disable focus handling test due to win32/ia32 regression
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org >
2025-01-23 23:07:43 -05:00
Sam Maddock
996477152d
feat: contextBridge.executeInMainWorld ( #45229 )
2025-01-23 21:12:46 -05:00
Sam Maddock
e09577b123
feat: redesign preload APIs ( #45230 )
...
* feat: redesign preload APIs
* docs: remove service-worker mentions for now
* fix lint
* remove service-worker ipc code
* add filename
* fix: web preferences preload not included
* fix: missing common init
* fix: preload bundle script error
2025-01-23 21:12:23 -05:00
Felix Rieseberg
26d228ccfe
docs: Add note about directly exposing Electron APIs in preload ( #45241 )
...
* docs: Add note about directly exposing Electron APIs in preload
* Implement feedback
2025-01-23 13:59:00 -08:00
Keeley Hammond
aafb1ba72c
build: migrate Windows release builds to GHA ( #45137 )
...
* build: migrate release builds to GHA
* build: alter CI jobs release script
2025-01-23 14:10:24 -05:00
Charles Kerr
db7ef90159
chore: better logging if Node initialization fails ( #45286 )
...
feat: better logging if Node initialization fails
2025-01-23 08:55:28 -06:00
electron-roller[bot]
863faea542
chore: bump node to v22.11.0 (main) ( #44530 )
...
* chore: bump node in DEPS to v22.11.0
* src: move evp stuff to ncrypto
https://github.com/nodejs/node/pull/54911
* crypto: add Date fields for validTo and validFrom
https://github.com/nodejs/node/pull/54159
* module: fix discrepancy between .ts and .js
https://github.com/nodejs/node/pull/54461
* esm: do not interpret "main" as a URL
https://github.com/nodejs/node/pull/55003
* src: modernize likely/unlikely hints
https://github.com/nodejs/node/pull/55155
* chore: update patch indices
* crypto: add validFromDate and validToDate fields to X509Certificate
https://github.com/nodejs/node/pull/54159
* chore: fixup perfetto patch
* fix: clang warning in simdjson
* src: add receiver to fast api callback methods
https://github.com/nodejs/node/pull/54408
* chore: fixup revert patch
* fixup! esm: do not interpret "main" as a URL
* fixup! crypto: add Date fields for validTo and validFrom
* fix: move ArrayBuffer test patch
* src: fixup Error.stackTraceLimit during snapshot building
https://github.com/nodejs/node/pull/55121
* fix: bad rebase
* chore: fixup amaro
* chore: address feedback from review
* src: revert filesystem::path changes
https://github.com/nodejs/node/pull/55015
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-01-22 12:16:26 -05:00
Shelley Vohr
5aabb6bec5
fix: potential crash in chrome.tabs.update() ( #45276 )
...
fix: potential crash in chrome.tabs.update()
2025-01-22 10:02:29 -06:00
dependabot[bot]
5e05dff949
build(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0 ( #45274 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](6f51ac03b9...65c4c4a1dd )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-22 12:29:23 +01:00
Maksim Sisov
3ea623364b
feat: support global shortcuts via GlobalShortcutsPortal feature with ozone/wayland ( #45171 )
...
* fix: backport patch to fix systemd unit activation in Chromium
This backports a patch from Chromium, which fixes systemd unit
activation. That is, a globalShortcuts feature that Chromium has
needs to create a systemd unit and rename it properly. Portal's
global shortcuts uses that name afterwards to map the app with
the shortcuts bound. However, there might be a race between
Chromium binding shortcuts and renaming the unit.
This is a first step to add Portal's globalShortcuts to
Electron.
* feat: Support global shortcuts via GlobalShortcutsPortal feature
Chromium has a new feature called GlobalShortcutsPortal. It
allows clients to use Portal's globalShortcuts to register and
listen to shortcuts.
This patches adds necessary bits, which allows Electron to
use that feature.
In order to make it work, one has to add
--enable-features=GlobalShortcutsPortal
Test: tested manually with a sample app.
* docs: add GlobalShortcutsPortal feature to globalShortcuts docs
Electron supports Portal's globalShortcuts API now via Chromium, and Electron
apps can use that in a Wayland session. Update the docs with the required
feature flag that must be passed to be able to use that implementation.
2025-01-22 11:59:48 +01:00
Erick Zhao
cf67dc8898
docs: add DocCardList component for index doc ( #45275 )
2025-01-22 10:27:30 +01:00
David Sanders
d7b568a1c0
ci: fix issue workflow failures ( #45294 )
2025-01-22 09:40:10 +01:00
Charles Kerr
fe9031eb23
refactor: in StopTracing(), use string literals instead of optional<string> ( #45270 )
...
refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>
We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
2025-01-21 17:41:52 -06:00
Charles Kerr
f5eba67f0d
refactor: simplify ParseUserScript() ( #45269 )
...
refactor: simplify ParseUserScript()
local variable user_script no longer needed after #43205
2025-01-21 15:21:56 -05:00
Charles Kerr
e1762e6e44
fix: consume the file permission callback when used ( #45267 )
...
fixes 0e5fe3f regression
2025-01-21 11:59:38 -06:00
Shelley Vohr
9d32b6ddfc
fix: webContents.print() with OOP printing ( #45266 )
...
* fix: webContents.print() with OOP printing
* Update patches/chromium/printing.patch
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-01-21 11:39:21 -05:00
David Sanders
7a413ff2ad
ci: don't fail issue triage workflows if issue not found on project ( #45252 )
2025-01-21 16:06:24 +01:00
Shelley Vohr
0090d171fd
chore: align clipboard blink::web_pref::WebPreferences with upstream ( #45277 )
...
chore: align clipboard blink::web_pref::WebPreferences with upstream
2025-01-21 06:50:36 -08:00
dependabot[bot]
980b68e9cc
build(deps): bump github/codeql-action from 3.28.0 to 3.28.1 ( #45272 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](48ab28a6f5...b6a472f63d )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-21 15:12:42 +01:00
dependabot[bot]
44a630e634
build(deps): bump mikefarah/yq from 4.44.6 to 4.45.1 ( #45271 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.6 to 4.45.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](4839dbbf80...8bf425b4d1 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-21 15:12:29 +01:00
Shelley Vohr
81d12fa452
build: fix clang-format duplicate message ( #45235 )
2025-01-20 11:05:40 +01:00
Shelley Vohr
83666ddc36
fix: page scaling in silent mode printing ( #45218 )
2025-01-20 11:05:15 +01:00
Shelley Vohr
fa5de40f86
fix: two possible FSA crashes ( #45233 )
...
* 5786874: Change Observer: Fix crash when navigating to new page
https://chromium-review.googlesource.com/c/chromium/src/+/5786874
* 5794141: Change Observer: Fix Get*PermissionGrant crash
https://chromium-review.googlesource.com/c/chromium/src/+/5794141
2025-01-20 10:23:57 +01:00
Shelley Vohr
7d05fb2a1b
fix: broken OOP window.print() on macOS/Linux ( #45214 )
...
fix: broken OOP printing on macOS/Linux
2025-01-20 10:23:44 +01:00
Sam Maddock
51a249f380
chore: skip flaky contentTracing test ( #45240 )
2025-01-20 09:57:10 +01:00
Sam Maddock
90754e5fd2
test: quit Finder ( #45239 )
2025-01-20 09:54:26 +01:00
Shelley Vohr
0e5fe3fa60
fix: getAsFileSystemHandle failure when drag-dropping two directories ( #45234 )
...
fix: drag-dropping two directories
2025-01-20 09:54:12 +01:00
michal-pichlinski-openfin
6953f5505f
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #44628 )
...
* refactor: remove InspectableWebContentsViewMac in favor of the Views version
* cherry-pick: refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )
commit e67ab9a93d
Confilcts not resolved, except removal of the files removed
by the original commit.
* resolved conflicts and build issues after cherry-pick
* cherry-picked: fix: add method allowing to disable headless mode in native widget
https://github.com/electron/electron/pull/42996
fixing
https://github.com/electron/electron/issues/42995
* fix: displaying select popup in window created as fullscreen window
`constrainFrameRect:toScreen:` is not being call for windows created
with `fullscreen: true` therefore `headless` mode was not being removed
and `RenderWidgetHostNSViewBridge::DisplayPopupMenu` ignored displaying
popup.
Issue could be fixed by placing additional removal of `headless` mode
in the `toggleFullScreen:`, but `orderWindow:relativeTo:` is called
both for a regular and a fullscreen window, therefore there will be
a single place fixing both cases.
Because `electron::NativeWindowMac` lifetime may be shorter than
`ElectronNSWindow` on which macOS may execute `orderWindow:relativeTo:`
we need to clear `shell_` when `NativeWindow` is being closed.
Fixes #43010 .
* fix: Content visibility when using `vibrancy`
We need to put `NSVisualEffectView` before `ViewsCompositorSuperview`
otherwise when using `vibrancy` in `BrowserWindow` `NSVisualEffectView`
will hide content displayed by the compositor.
Fixes #43003
Fixes #42336
In fact main issues reported in these tickets were not present after
cherry-picking original refactor switching to `views::WebView`, so
text could be selected and click event was properly generated. However
both issues testcases were using `vibrancy` and actual content was
invisible, because it was covered by the `NSVisualEffectView`.
* fix: EXCEPTION_ACCESS_VIOLATION crash on BrowserWindow.destroy()
Restored postponed deletion of the `NativeWindow`.
Restoration caused `DCHECK(new_parent_ui_layer->GetCompositor());` failure
in `BrowserCompositorMac::SetParentUiLayer` after the spec test:
`chrome extensions chrome.webRequest does not take precedence over Electron webRequest - http`
with stack:
```
7 Electron Framework 0x000000011fe07830 content::BrowserCompositorMac::SetParentUiLayer(ui::Layer*) + 628
8 Electron Framework 0x000000011fe0c154 content::RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer*) + 220
9 Electron Framework 0x000000011fe226a8 content::WebContentsViewMac::CreateViewForWidget(content::RenderWidgetHost*) + 600
10 Electron Framework 0x000000011fd37e4c content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager(content::RenderViewHost*) + 164
11 Electron Framework 0x000000011fb32278 content::RenderFrameHostManager::CreateSpeculativeRenderFrame(content::SiteInstanceImpl*, bool, scoped_refptr<content::BrowsingContextState> const&) + 816
12 Electron Framework 0x000000011fb2ab8c content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost(content::SiteInstanceImpl*, content::SiteInstanceImpl*, bool) + 1308
13 Electron Framework 0x000000011fb28598 content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, content::BrowsingContextGroupSwap*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) + 1796
14 Electron Framework 0x000000011fa78660 content::NavigationRequest::SelectFrameHostForOnRequestFailedInternal(bool, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&) + 280
15 Electron Framework 0x000000011fa6a994 content::NavigationRequest::OnRequestFailedInternal(network::URLLoaderCompletionStatus const&, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&, bo
+ 1008
16 Electron Framework 0x000000011fa7772c content::NavigationRequest::OnRequestFailed(network::URLLoaderCompletionStatus const&) + 72
17 Electron Framework 0x000000011f8554ac content::NavigationURLLoaderImpl::NotifyRequestFailed(network::URLLoaderCompletionStatus const&) + 248
```
This was probably the reason of removing `NativeWindow` immediately
in order to cleanup `views_host_` in `WebContentsViewMac` to prevent
using layer without compositor in `WebContentsViewMac::CreateViewForWidget`.
`[ElectronNSWindowDelegate windowWillClose:]` is deleting window host
and the compositor used by the `NativeWindow` therefore detach `NativeWindow`
contents from parent. This will clear `views_host_` and prevent failing
mentioned `DCHECK`.
Fixes #42975
* chore: Applied review suggestions
* refactor: directly cleanup shell
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-01-17 10:21:10 -05:00
Felix Rieseberg
45f90cd5dd
docs: Why Electron? ( #45191 )
...
* docs: Why Electron?
* Apply suggestions from code review
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/why-electron.md
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2025-01-15 18:32:56 -05:00
Anny Yang
8294f44c74
docs: remove quickstart ( #45194 )
2025-01-15 14:42:53 -08:00
Calvin
6f7999ad0d
fix: session.clearData avoidClosingConnections default to false ( #45187 )
2025-01-15 11:38:50 -05:00
Keeley Hammond
d829ee3145
build: bump NMV to 133 ( #45145 )
2025-01-15 11:36:34 -05:00
Keeley Hammond
88b4e1a9b7
build: bump actions/cache past deprecated version ( #45192 )
2025-01-15 11:33:46 +01:00
dependabot[bot]
7c784a1758
build(deps): bump actions/setup-node from 4.0.4 to 4.1.0 ( #45049 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.4 to 4.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/v4.0.4...39370e3970a6d050c480ffad4ff0ed4d3fdee5af )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-15 11:06:10 +01:00
wujinli
5680c628b6
fix: only remove the 'v' prefix from the git tag name ( #45132 )
...
In the old version of get-version.js, it replaces the leading 'v',
i.e. |output.stdout.toString().trim().replace(/^v/g, '')|. However,
in the new version of get-git-version.py, it directly replaces all
'v'. Obviously, it does not conform to the original semantics.
Although it will not affect the existing electron version calculation,
it may affect other developers' customized git-tag-version, such as
v0.0.0-dev.xxx, which will lose the 'v' of dev.
2025-01-13 22:36:03 -05:00
Calvin
e57b69f106
docs: correct breaking changes versions ( #45173 )
2025-01-13 14:15:24 -08:00
Michaela Laurencin
19ee4464c2
docs: update timelines for E35 ( #45167 )
2025-01-10 16:21:08 -08:00
electron-roller[bot]
7d05b78479
chore: bump chromium to 133.0.6920.0 (main) ( #45055 )
...
* chore: bump chromium in DEPS to 133.0.6902.0
* chore: bump chromium in DEPS to 133.0.6903.0
* chore: update patches
* Update PdfViewer Save File Picker to use showSaveFilePicker.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6074308
* Code Health: Clean up stale MacWebContentsOcclusion
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Change RenderProcessHost::GetID to RenderProcessHost::GetDeprecatedID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6065543
* [WebRTC] Make WebRTC IP Handling policy a mojo enum
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6063620
* chore: gen filenames.libcxx.gni
* Remove allow_unsafe_buffers pragma in //printing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6092280
* refactor: to use ChildProcessId where possible
Refs https://issues.chromium.org/issues/379869738
* [Win] Update TabletMode detection code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6003486
* chore: bump chromium in DEPS to 133.0.6905.0
* chore: update patches
* Reland "Move global shortcut listener to //ui/base"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6099035
* [shared storage] Implement the batch `with_lock` option for response header
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6072742
* chore: bump chromium in DEPS to 133.0.6907.0
* chore: bump chromium in DEPS to 133.0.6909.0
* chore: bump chromium in DEPS to 133.0.6911.0
* chore: bump chromium in DEPS to 133.0.6912.0
* chore: update patches
* WebUI: Reveal hidden deps to ui/webui/resources.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6096291
* chore: bump chromium in DEPS to 133.0.6913.0
* chore: bump chromium in DEPS to 133.0.6915.0
* Code Health: Clean up stale base::Feature "AccessibilityTreeForViews"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6104174
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix: remove fastapitypedarray usage
* chore: update patches
* chore: script/gen-libc++-filenames.js
* Code Health: Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6109477
* fix: empty suggestions with windows platform checker
Amends the fix from https://github.com/electron/electron/pull/29690
since the feature flag is no longer available. We follow the
same pattern as //chrome/browser/renderer_context_menu/spelling_menu_observer.cc
to generate the suggestion list on demand when context menu action
is invoked.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fixup! fix: empty suggestions with windows platform checker
* fixup! fix: empty suggestions with windows platform checker
* revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Revert "revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344 "
This reverts commit 9cacda452e .
* chore: bump to 133.0.6920.0, update patches
* Revert "6078344: Code Health: Clean up stale MacWebContentsOcclusion"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* fixup! Update PdfViewer Save File Picker to use showSaveFilePicker.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-01-10 10:52:34 -06:00
Charles Kerr
062d14e553
perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set ( #45143 )
...
* perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set
* chore: remove unused #include
2025-01-08 20:46:17 -06:00
Charles Kerr
59ed1db9a2
refactor: remove redundant CreateExtensionsClient() ( #45135 )
2025-01-08 10:36:08 -06:00
dependabot[bot]
da8288106b
build(deps): bump github/codeql-action from 3.27.9 to 3.28.0 ( #45090 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.9 to 3.28.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](df409f7d92...48ab28a6f5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-06 15:11:28 -05:00
dependabot[bot]
679eb3c266
build(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #45089 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](b4b15b8c7c...6f51ac03b9 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-06 15:11:06 -05:00
David Sanders
c2d0a28fa2
ci: enable debugging mode when building electron_dist_zip ( #45108 )
2025-01-06 14:41:48 -05:00
John Kleinschmidt
2745771a22
test: reenable disabled GHA windows tests ( #45062 )
...
* test: renable GHA on Windows disabled tests
* test: close edge after shell.openExternal
* test: close edge sync after shell.openExternal
2024-12-20 14:49:55 -05:00
dependabot[bot]
1ecb2a2998
build(deps): bump actions/checkout from 4.1.6 to 4.2.2 ( #45048 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-19 17:22:01 -05:00
electron-roller[bot]
e0f72dc332
chore: bump chromium to 133.0.6887.0 (main) ( #44986 )
...
* chore: bump chromium in DEPS to 133.0.6887.0
* chore: update render_widget_host_view_base.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5952851
* chore: update osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6068570
* chore: e patches all
* Remove ClipboardFormatType::GetType()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6075792
* Remove raw byte range methods from network::ResourceRequestBody
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6038757
* fix: update patches/chromium/fix_crash_loading_non-standard_schemes_in_iframes.patch:wq
Refs https://issues.chromium.org/issues/40092527
* fix: windows gn check
* chore: update patches/chromium/render_widget_host_view_base.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-12-18 15:45:19 +09:00
George Xu
caf24ef417
fix: add patch to fix desktopCapturer.getSources not returning electron windows on Windows ( #45000 )
...
* fix: add patch to fix desktopCapturer.getSources not returning electron window on Windows
* add chromium link
* Update patches/chromium/fix_desktop_capturer_show_own_window.patch
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* fix on electron side
* set flag to true
* wrong capturer
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-12-17 15:20:44 -08:00
dependabot[bot]
ff13bcd08d
build(deps): bump github/codeql-action from 3.27.6 to 3.27.9 ( #45047 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.6 to 3.27.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](aa57810251...df409f7d92 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-17 10:09:56 +01:00
Quinn
dc74092a09
fix: better prompt not supported message in window-setup.ts ( #45017 )
...
Update window-setup.ts
The message should simply read "is not supported" or, alternatively, "is not, and will not, be supported", but not "is and will not be supported".
2024-12-16 15:38:25 -05:00
Kavindu Udara
f89813401d
docs: remove extra " ( #45029 )
...
remove extra "
2024-12-16 13:20:17 -05:00
Sam Maddock
3aa0014d23
fix: chrome.i18n unavailable in extension service workers ( #45031 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
2024-12-16 09:46:20 -05:00
John Kleinschmidt
69479b2fb7
build: update build tools to correct sha ( #45018 )
...
chore: update build tools to correct sha
2024-12-13 17:26:25 -08:00
Jesper Ek
e2e71502b1
fix: custom spell-checker stuck in infinite loop ( #45001 )
...
`ReadUnicodeCharacter` updates index to the last character read, and not after it. We need to manually increment it to move to the next character.
It also doesn't validate that the index is valid, so we need to check that index is within bounds.
Refs: #44336
2024-12-13 11:47:29 -05:00
Samuel Attard
be1a3dce83
build: use github actions for windows ( #44136 )
...
* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094
and https://chromium-review.googlesource.com/c/chromium/src/+/5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37 .
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d6 )
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a180658376 .
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f538 .
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129 .
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffe .
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01 .
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049 .
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7 .
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839 .
* Revert "remove debugging"
This reverts commit f18dd8b1a5 .
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f .
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd4322 .
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1 .
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d .
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-12 11:51:24 -05:00
Alice Zhao
a5b4339884
fix: add missing index arg in navigationHistory.canGoToOffset ( #44989 )
...
fix: add missing arg
2024-12-12 10:56:27 -05:00
Sam Maddock
6961e9458a
chore: update vm module warning ( #44985 )
...
* chore: update vm module warning
* Update lib/renderer/init.ts
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-12-11 17:22:50 -05:00
electron-appveyor-updater[bot]
2191e9b8e1
build: update appveyor image to latest version ( #44992 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-11 13:27:21 -05:00
Sam Maddock
2c698d3f75
fix: context-menu emitted twice ( #44978 )
...
* fix: context-menu emitted twice
* refactor: simplify disabling draggable regions
* cleanup
2024-12-11 11:42:48 -05:00
electron-roller[bot]
cf5a4640f5
chore: bump chromium to 133.0.6878.0 (main) ( #44831 )
...
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
https://chromium-review.googlesource.com/c/chromium/src/+/6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
https://chromium-review.googlesource.com/c/chromium/src/+/6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
https://chromium-review.googlesource.com/c/chromium/src/+/6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
https://chromium-review.googlesource.com/c/chromium/src/+/6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | https://chromium-review.googlesource.com/c/chromium/src/+/6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | https://chromium-review.googlesource.com/c/chromium/src/+/6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | https://chromium-review.googlesource.com/c/chromium/src/+/6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | https://chromium-review.googlesource.com/c/chromium/src/+/6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | https://chromium-review.googlesource.com/c/chromium/src/+/6051058
* 6038981: Remove most remaining CHECK(false)s | https://chromium-review.googlesource.com/c/chromium/src/+/6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-10 13:16:07 -06:00
dependabot[bot]
3bd5f14cee
build(deps): bump github/codeql-action from 3.27.5 to 3.27.6 ( #44981 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.5 to 3.27.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f09c1c0a94...aa57810251 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:52:27 +01:00
dependabot[bot]
7462d449e0
build(deps): bump mikefarah/yq from 4.44.5 to 4.44.6 ( #44980 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.5 to 4.44.6.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bc5b54cb1d...4839dbbf80 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:51:25 +01:00
Calvin
82ea3faae5
docs: update security scoped bookmarks info ( #44968 )
2024-12-09 10:44:43 -08:00
Charles Kerr
578c1e5dae
fix: build failure when PDF viewer is disabled ( #44960 )
...
* fix: unused variable warning when the PDF viewer is disabled
* fix: unused function error when PDF viewer is disabled
error: unused function ParseManifest [-Werror,-Wunused-function]
2024-12-06 17:54:04 +09:00
Shelley Vohr
208dc568d8
fix: context-menu event with BaseWindows ( #44940 )
...
fix: context-menu event with BaseWindows
2024-12-04 13:35:28 -08:00
Felix Rieseberg
687a59b43b
feat: Add shared dictionary management APIs ( #44750 )
...
* Add bare-bones GetSharedDictionaryUsageInfo
* Add GetSharedDictionaryInfo()
* Improve API, use isolation keys
* Add documentation
* Update docs/api/session.md
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* Add tests
* Implement feedback <3
* Improve tests
* chore: lint
* docs: add note about clearing cache in ses.clearData
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-12-04 12:25:11 -05:00
Charles Kerr
158a87d494
fix: modernize-use-equals-default warnings ( #44935 )
...
fix: use '= default' to define a trivial destructor [modernize-use-equals-default]
2024-12-03 16:25:48 -06:00
Shelley Vohr
229c2a8f50
chore: make version parsing more tolerant ( #44918 )
...
* chore: make version parsing more tolerant
* Update .github/workflows/issue-opened.yml
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-03 17:03:43 -05:00
Niklas Wenzel
5324c0e6c3
docs: fix grammar in app.relaunch docs ( #44920 )
2024-12-03 09:56:09 -08:00
Sam Maddock
2222920429
feat: WebFrameMain.collectJavaScriptCallStack() ( #44204 )
...
* feat: WebFrameMain.unresponsiveDocumentJSCallStack
* Revert "feat: WebFrameMain.unresponsiveDocumentJSCallStack"
This reverts commit e0612bc1a00a5282cba5df97da3c9c90e96ef244.
* feat: frame.collectJavaScriptCallStack()
* feat: frame.collectJavaScriptCallStack()
* Update web-frame-main.md
2024-12-03 13:32:24 +09:00
Charles Kerr
6d4c271268
chore: remove unused registry arg from GetPrivilegeRequiredByUrl() ( #44908 )
...
this has never been used; introduced by 91071570
2024-12-02 14:02:47 -05:00
Niklas Wenzel
c6b4bde7b5
docs: clarify what session.clearData() with data type 'cache' deletes ( #44852 )
...
* docs: clarify what session.clearData() with data type 'cache' deletes
* docs: include `shadercache`, too
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2024-12-02 13:50:35 -05:00
Niklas Wenzel
bba9ee1cb8
docs: clarify session.clearData() can delete more types than listed ( #44851 )
...
docs: warn that session.clearData() might delete more than expected
2024-12-02 13:29:25 -05:00
Charles Kerr
a7fa6e89b5
chore: remove unused arg from BaseWindow::GetBackgroundColor() ( #44906 )
...
chore: remove unused gin_helper::Arguments* arg from BaseWindow::GetBackgroundColor()
looks like this was added in db79734b but never used
2024-12-02 11:39:10 -05:00
Charles Kerr
06612cf5d4
chore: remove unused isolate argument from Cookies constructor ( #44907 )
...
* chore: remove unused isolate argument from Cookies constructor
unused since the ginify cookies refactor in Mar 2020, commit 22202255
* fix: constructor only takes one arg now, so mark it explicit
2024-12-02 11:34:21 -05:00
electron-appveyor-updater[bot]
49b294628c
build: update appveyor image to latest version ( #44840 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-02 11:14:41 -05:00
Charles Kerr
493e3c4537
fix: don't use deprecated ui::MouseEvent constructor ( #44868 )
...
* refactor: do not use deprecated gfx::Point constructor for MouseEvent
Deprecated in https://chromium-review.googlesource.com/c/1444251
* refactor: use WebInputEvent::GetTypeAsUiEventType() instead of rolling our own
Added in https://chromium-review.googlesource.com/c/chromium/src/+/2180291
2024-12-02 11:13:38 -05:00
Charles Kerr
b2ce5296af
fix: remove unused id argument from TranslateToStock() ( #44900 )
...
unused since fb537d91fc
2024-12-01 16:34:48 -06:00
illusory-dream
4e40b49d1a
docs: fix a syntax issue in document breaking changes ( #44841 )
...
fix: syntax issue in docs
2024-11-30 21:44:33 -08:00
Niklas Wenzel
d8149aa376
docs: specify default value for respondToAuthRequestsFromMainProcess ( #44855 )
...
docs: specify default value for respondToAuthRequestsFromMainProcess
2024-11-30 21:33:33 -08:00
Charles Kerr
033a0abb59
refactor: reduce scope of relauncher's internal constants ( #44860 )
...
* refactor: make kRelauncherArgSeparator private to relauncher.cc
* refactor: make kRelauncherTypeArg private to relauncher.cc
* refactor: remove unused type relauncher::CharType
* refactor: move private constants into standalone private namespace
* refactor: move kWaitEventName into the only function that uses it
2024-11-30 06:54:40 -06:00
Shelley Vohr
8f00cc9c0e
build: remove context-aware patch ( #44862 )
2024-11-29 11:45:33 -06:00
Charles Kerr
f7e823ac80
refactor: return-braced-init-list pt 2 of 2 ( #44870 )
...
* refactor: more return-braced-init-list, this time for v8 and gin objects
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
2024-11-29 11:44:33 -06:00
Charles Kerr
4a695d07c6
fix: misc-use-internal-linkage warnings ( #44843 )
...
* refactor: misc-use-internal-linkage warnings in context bridge
move impl functions into anonymous namespace so that they're not visible
to other compilation units:
- ExposeAPIInWorld()
- IsCalledFromMainWorld()
- OverrideGlobalPropertyFromIsolatedWorld()
- OverrideGlobalValueFromIsolatedWorld()
- TraceKeyPath()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct ScaleFactorPair
- kScaleFactorPairs[]
- GetScaleFactorFromPath()
- AddImageSkiaRepFromPath()
* refactor: misc-use-internal-linkage warnings in printing util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFullPagePlugin()
* refactor: misc-use-internal-linkage warnings in blijnk converter
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetKeyLocationCode()
- ModifiersToArray()
* refactor: misc-use-internal-linkage warnings in extrension system
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- ParseManifest()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFrameTokenMap()
- GetFrameTreeNodeIdMap()
* refactor: misc-use-internal-linkage warnings in electron_api_utility_process.cc
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetAllUtilityProcessWrappers()
* refactor: misc-use-internal-linkage warnings in electron_api_menu
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- InvokeBoolMethod()
* refactor: misc-use-internal-linkage warnings in platform util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct TrashItemResult
- TrashItemOnBlockingThread()
2024-11-27 10:40:39 -06:00
Charles Kerr
4aa1855e39
refactor: use base::Extend in AddAdditionalSchemes() ( #44839 )
2024-11-27 07:55:54 -06:00
Charles Kerr
f595443a22
refactor: fix modernize-return-braced-init-list warnings ( #44838 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
2024-11-27 09:41:46 +09:00
dependabot[bot]
9f1e23c405
build(deps): bump github/codeql-action from 3.27.4 to 3.27.5 ( #44837 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.4 to 3.27.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ea9e4e3799...f09c1c0a94 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-26 11:26:35 +01:00
Charles Kerr
93f49d1189
fix: modernize-use-using clang-tidy warnings ( #44806 )
2024-11-25 10:50:33 -05:00
Charles Kerr
3c941c7e8f
fix: modernize-avoid-c-arrays ( #44813 )
...
use string_view for constants used in methods that take string_view args
2024-11-25 10:49:58 -05:00
Charles Kerr
024fee4e44
fix: modernize-use-nodiscard clang-tidy warnings ( #44808 )
2024-11-25 10:48:28 -05:00
electron-roller[bot]
7e7010dacf
chore: bump chromium to 133.0.6852.0 (main) ( #44748 )
...
* chore: bump chromium in DEPS to 133.0.6847.0
* chore: bump chromium in DEPS to 133.0.6848.0
* chore: update patches
* implement extensions::GlobalShortcutListener::ExecuteCommand stub
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* fix: ismediakey patch, oops
* fix: another missing bracket
* chore: bump chromium in DEPS to 133.0.6850.0
* chore: update patches
* SharedStorageOperationPtr -> SharedStorageModifierMethodPtr
https://chromium-review.googlesource.com/c/chromium/src/+/5990970
* build GlobalShortcutListenerLinux
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* chore: bump chromium in DEPS to 133.0.6851.0
* fix: include full type for network::mojom::SharedStorageModifierMethod
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6852.0
* chore: update patches
* build: remove duplicated icudtl.dat and snapshot_blob.bin
https://chromium-review.googlesource.com/c/chromium/src/+/5999387
* fix: include static methods in node tests involving call stacks
https://chromium-review.googlesource.com/c/v8/v8/+/5907815
* revert: moved code in picture-in-picture.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-25 10:45:47 -05:00
Ajay Kemparaj
fbe01cdc16
docs: correct stable release dates for v34.0.0 ( #44807 )
...
* docs: correct stable release dates for v34.0.0
* docs: correct stable release dates for v34.0.0
2024-11-25 10:43:56 -05:00
Niklas Wenzel
b8b2e12c9c
docs: fix wording in auto-updater.md ( #44787 )
...
* docs: fix wording in auto-updater.md
* docs: update wording
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-11-24 13:00:42 -08:00
Charles Kerr
94a65df270
refactor: remove unnecessary constructor code ( #44816 )
2024-11-24 08:55:46 -06:00
Charles Kerr
24df5f96d7
fix: remove unused local variables ( #44815 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de5
* chore: only declare program_name local variable if used
We declared it everywhere but only used it on Windows
* chore: remove unused local non-trivial variable path from UnregisterXWindow
it became unused in 2020 by 72a08926
2024-11-23 17:34:51 -06:00
David Sanders
4a3513377c
docs: update new GitHub issue link ( #44791 )
2024-11-22 11:48:59 -08:00
Savely Krasovsky
c5ea177b3d
feat: add query-session-end and improve session-end events on Windows ( #44598 )
...
* feat: add query-session-end event for Windows
* fix: remove debug line
* feat: notify with reason on session-end
* docs: add comments and return params
* docs: add same docs to the BrowserWindow
* fix: add shutdown reason if lParam == 0
* docs: remove 'force' word
* docs: revert multithreading.md change
* docs: add reasons documentation, reason variable renamed to reasons
* docs: improve 'shutdown' reason wording
* docs: reword with 'can be'
* fix: pass reasons by reference
* fix: use newer approach which expose reasons value directly on Event object
* docs: add escaping
* style: linter fixes
* fix: project now should compile
* fix: EmitWithoutEvent method added, EmitWithEvent moved to private again
* docs: typo fix
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* docs: dedicated WindowSessionEndEvent type created
* docs: better wording for session-end event description
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Will Anderson <will@itsananderson.com >
2024-11-22 11:47:36 -08:00
Shelley Vohr
0285592d61
fix: crash calling shell.readShortcutLink ( #44784 )
...
fix: crash calling shell.readShortcutLink
2024-11-22 09:37:17 -05:00
Shelley Vohr
86e4529d26
fix: ensure context-menu emitted for draggable regions ( #44761 )
...
* fix: ensure context-menu emitted for draggable regions
* chore: address suggestions from review
2024-11-22 12:33:38 +01:00
Charles Kerr
4fd1b5b186
fix: big endian bug in V8 serialization ( #44776 )
2024-11-22 12:04:53 +01:00
BILL SHEN
1d55eb9a45
build: remove duplicate line in gn file ( #44786 )
...
style: remove duplicate line in gn file
2024-11-22 12:03:49 +01:00
Charles Kerr
0005ae9557
docs: sync 34.0.0 release date to Chromium 132 release date ( #44766 )
2024-11-21 10:51:19 -06:00
Charles Kerr
86962ba2c3
fix: clang-tidy performance-inefficient-vector-operation warnings ( #44743 )
...
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-20 18:11:00 -06:00
Charles Kerr
6789431f74
fix: performance-no-automatic-move clang-tidy warnings ( #44742 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
2024-11-20 18:10:30 -06:00
nilaoda
0ea64850af
fix: windows save dialog extension bug ( #44296 )
...
* fix: windows save dialog extension bug
* refactor: simplify firstSpec extraction
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: split when necessary
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2024-11-20 17:27:49 -05:00
Den Delimarsky
769b045c8b
docs: removes redundant phrasing in the code signing documentation ( #44716 )
...
Update code-signing.md
2024-11-20 16:41:01 -05:00
Charles Kerr
85e2622b68
refactor: use gdk_display_beep() on Linux ( #44734 )
...
* refactor: use gdk_display_beep() to beep on Linux
* chore: make a stub declaration for gdk_display_beep()
* chore: remove unused file electron_gtk.sigs
* chore: remove unused #includes to make gn check happy
2024-11-20 16:24:59 -05:00
electron-appveyor-updater[bot]
15c3064780
build: update appveyor image to latest version ( #44751 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-20 16:18:01 -05:00
Shelley Vohr
f95e1d8ea0
chore: fix textured window conditional on macOS ( #44728 )
2024-11-20 10:34:46 -06:00
Shelley Vohr
eba0edf81e
build: allow unbundling of Node.js dependencies ( #44754 )
2024-11-20 11:34:37 -05:00
Sam Maddock
8223ebc111
test: run script to help target discovery and reduce flakes ( #44741 )
2024-11-20 08:55:09 -06:00
Shelley Vohr
54d53bfa51
fix: tooltips in WCO caption buttons ( #44721 )
...
fix: tooltips in WCO capton buttons
2024-11-20 12:45:08 +01:00
dependabot[bot]
8ed48e2295
build(deps): bump mikefarah/yq from 4.44.3 to 4.44.5 ( #44714 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.3 to 4.44.5.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bbdd97482f...bc5b54cb1d )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 10:49:50 +01:00
electron-roller[bot]
43ed763f18
chore: bump chromium to 133.0.6846.0 (main) ( #44665 )
...
* chore: bump chromium in DEPS to 133.0.6836.0
* chore: bump chromium in DEPS to 133.0.6838.0
* chore: update patches
* 6006096: [Sync ESB] Integrate Chrome Toast UI
https://chromium-review.googlesource.com/c/chromium/src/+/6006096
* Confine enable_device_bound_sessions buildflag to //net
https://chromium-review.googlesource.com/c/chromium/src/+/6014679
* revert [api] Delete deprecated struct FastApiTypedArray
https://chromium-review.googlesource.com/c/v8/v8/+/5982984
Also
https://chromium-review.googlesource.com/c/v8/v8/+/5979766/1
* fixup revert [api] Delete deprecated struct FastApiTypedArray
* Migrate remaining NOTREACHED()s in chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* [Reland][Extensions] Remove ExtensionHostDelegate::GetJavaScriptDialogManager()
https://chromium-review.googlesource.com/c/chromium/src/+/6020106
* Remove NOTREACHED_IN_MIGRATION()
https://chromium-review.googlesource.com/c/chromium/src/+/6021996
* Remove Lock screen apps [#8 ] : remove lock screen extension
https://chromium-review.googlesource.com/c/chromium/src/+/6005846
* Reland "Add CrashReporterClient::GetProductInfo(ProductInfo*)"
https://chromium-review.googlesource.com/c/chromium/src/+/6012631
* Ozone/Wayland: remove lacros specific window states
https://chromium-review.googlesource.com/c/chromium/src/+/6011215
* chore: bump chromium in DEPS to 133.0.6840.0
* chore: bump chromium in DEPS to 133.0.6841.0
* chore: bump chromium in DEPS to 133.0.6844.0
* implement virtual WebContents::CanUserEnterFullscreen
* OnSearchifyStateChange -> OnSearchifyStarted
* regen libc++ filenames
* chore: bump chromium in DEPS to 133.0.6846.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-19 19:52:20 -08:00
Charles Kerr
ac61c74ddc
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44708 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image.cc:155:26: warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int32_t' (aka 'int') is implementation-defined [bugprone-narrowing-conversions]
155 | new_memory_usage = image_skia->bitmap()->computeByteSize();
* fix: bugprone-narrowing-conversions warnings in NativeImage::CreateFromBitmap()
`SkImageInfo::MakeN32()` and `SkBitmap::allocN32Pixels()` both take int
width and height args, but we were feeding them unsigned ints.
../../electron/shell/common/api/electron_api_native_image.cc:508:36: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:508:43: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:25: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:32: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:528:48: warning: narrowing conversion from 'double' to 'float' [bugprone-narrowing-conversions]
528 | gfx::ImageSkia::CreateFromBitmap(bitmap, scale_factor);
2024-11-19 16:04:18 -06:00
Charles Kerr
1cf5e6d88c
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h ( #44705 )
...
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
2024-11-19 13:45:18 -06:00
Robo
48c9149a52
fix: utility process exit code for graceful termination (reland) ( #44726 )
...
* chore: reland "fix: utility process exit code for graceful termination"
This reverts commit 1cae73ba09 .
* fix: exit code on posix when killed via api
* chore: fix code style
2024-11-20 02:48:15 +09:00
Robo
0d6743e79b
fix: destroy url loader wrapper when JS env exits ( #44574 )
...
* fix: destroy url loader wrapper when JS env exits
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
* fix: double free of JSChunkedDataPipeGetter
* fix: crash on process exit after stream completes
2024-11-19 11:32:48 -05:00
Shelley Vohr
7a5e9613d2
build: rework header generation in Node.js ( #44657 )
...
* build: rework header generation in Node.js
* build: fix patch location error
* fix: set --root-dir correctly
2024-11-19 10:57:38 -05:00
dependabot[bot]
9d1be5f824
build(deps): bump the npm_and_yarn group across 2 directories with 1 update ( #44701 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
---
updated-dependencies:
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 15:06:42 +01:00
Shelley Vohr
4b3d1caae4
fix: improve single-pixel resize handling on Windows ( #44700 )
...
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-11-19 13:24:07 +01:00
dependabot[bot]
2cea2282eb
build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 ( #44715 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.27.0 to 2.0.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](37ebaef184...485a9d42d3 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 11:45:56 +01:00
dependabot[bot]
8efc4c7a56
build(deps): bump github/codeql-action from 3.27.1 to 3.27.4 ( #44713 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4f3212b617...ea9e4e3799 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 11:45:09 +01:00
David Sanders
febf305a4f
chore: fix unsupported major comment in issue automation ( #44706 )
2024-11-19 10:52:08 +01:00
Robo
1cae73ba09
chore: Revert "fix: utility process exit code for graceful termination" ( #44717 )
...
Revert "fix: utility process exit code for graceful termination (#44698 )"
This reverts commit 36e1a0bf00 .
2024-11-18 22:13:23 -06:00
Will Anderson
10d967028a
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44651 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
* fix: clear all listeners before running ipcMain removeAllListeners tests
2024-11-18 14:44:30 -08:00
Niklas Wenzel
aa7a5e6ca9
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44680 )
...
Fixes #44450
2024-11-18 14:36:41 -08:00
Shelley Vohr
58dc990f7a
chore: fix multi-version parsing in issue assignment ( #44679 )
...
* chore: fix multi-version parsing
* chore: tweak for review
2024-11-18 21:25:20 +01:00
Robo
36e1a0bf00
fix: utility process exit code for graceful termination ( #44698 )
2024-11-18 23:57:06 +09:00
Shelley Vohr
d320840a54
build: re-enable container_overflow ASAN check ( #44699 )
...
build: re-enable container_overflow ASAN check
2024-11-18 09:22:17 -05:00
Shelley Vohr
dd50afa8c2
fix: utilityProcess pid should be undefined after exit ( #44677 )
...
fix: utilityProcess pid should be undefined after exit
2024-11-18 10:06:27 +01:00
electron-appveyor-updater[bot]
15ff999bdc
build: update appveyor image to latest version ( #44675 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-15 14:54:00 -05:00
Shelley Vohr
a15e42e9ff
chore: cleanup following internal switch to readPackageJSON ( #44644 )
...
chore: cleanup following internal switch to readPackageJSON
2024-11-15 11:36:18 -05:00
Sam Maddock
aca84be970
chore: update extensions features ( #44653 )
...
* chore: update extensions features
* restore header
2024-11-15 11:32:43 -05:00
Robo
4fb5aab2ef
fix: revert required portal version for file chooser dialogs ( #44426 )
...
* feat: add support for configuring xdg portal version at runtime
* doc: update command-line-switches.md
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* doc: required portal version for defaultPath support
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* doc: update more occurrances
* fix: remove warning from save dialogs
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-15 09:31:33 -05:00
Shelley Vohr
27fe6cc97f
fix: WebContentsView removal should compare directly ( #44656 )
...
* fix: WebContentsView removal should compare directly
* fixup view comparision
* chore: use erase_if
* Apply review suggestions
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-14 22:11:20 -05:00
electron-roller[bot]
b1957f52e3
chore: bump chromium to 132.0.6834.0 (main) ( #44602 )
...
* chore: bump chromium in DEPS to 132.0.6827.0
* chore: bump chromium in DEPS to 132.0.6828.0
* chore: bump chromium in DEPS to 132.0.6830.0
* chore: bump chromium in DEPS to 132.0.6832.0
* chore: bump chromium in DEPS to 132.0.6834.0
* chore: update chromium patches
* 5977022: Apply os setting of overlay scrollbar to web instances | https://chromium-review.googlesource.com/c/chromium/src/+/5977022
* 5991440: Cleanup //ui/compositor from LaCros support code. | https://chromium-review.googlesource.com/c/chromium/src/+/5991440
* chore: update all patches
* 6000058: Add base_subdirs to file_chooser.mojom NativeFileInfo | https://chromium-review.googlesource.com/c/chromium/src/+/6000058
* 6009949: Rename NOTREACHED_NORETURN() uses to NOTREACHED() | https://chromium-review.googlesource.com/c/chromium/src/+/6009949
* 5966419: [freezing] Expose frozen state to extensions (3/3 - add frozen to chrome.tabs.Tab).
https://chromium-review.googlesource.com/c/chromium/src/+/5966419
Also https://chromium-review.googlesource.com/c/chromium/src/+/6006424
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-14 18:18:11 +01:00
Charles Kerr
8a67e77f03
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44650 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
* chore: remove some unused imports
* fix: E711 warning 'Comparison to should be '
2024-11-14 12:27:20 +01:00
Sam Maddock
41b5d7e312
refactor: unfilter unresponsive events ( #44629 )
...
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4 .
* fix: emit unresponsive if close not prevented
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-11-13 17:59:13 -08:00
Keeley Hammond
946ab5f1d7
build: reland bump Node.js to v22.9.0 ( #44597 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-11-13 15:34:30 +01:00
Shelley Vohr
0fd16dc9e2
fix: WCO buttons hidden on Linux in fullscreen ( #44621 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
2024-11-13 15:11:58 +01:00
BILL SHEN
a120d87570
fix: add theme data source for devtools. ( #44114 )
...
* fix: add theme data source for devtools.
* chore: add ut.
* chore: remove recording histograms
* fix: add theme data source for devtools.
* chore: separate files
* chore: separate files
* chore: remove pragma once
* chore: fix lint issue.
2024-11-13 13:23:37 +01:00
David Sanders
d380cda14a
ci: remove from issue triage on issue transferred ( #44631 )
2024-11-13 12:05:11 +01:00
Shelley Vohr
80ff7a14c6
test: exercise fuller globalShortcut matrix ( #44488 )
...
test: test fuller globalShortcut matrix
2024-11-12 15:31:39 -05:00
Gellert Hegyi
7a79d4c96e
feat: add optional animation parameter to BrowserWindow.setVibrancy ( #35987 )
...
adds optional animation parameter to BrowserWindow.setVibrancy
2024-11-12 09:03:30 -08:00
dependabot[bot]
a6390b539c
build(deps): bump github/codeql-action from 3.27.0 to 3.27.1 ( #44611 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.0 to 3.27.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](662472033e...4f3212b617 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-12 10:29:59 -05:00
John Kleinschmidt
777e547922
fix: segfault when moving WebContentsView between BrowserWindows ( #44599 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
* chore: actually enable fix
* fixup segfault when moving WebContentsView between BrowserWindows
2024-11-11 18:44:13 -05:00
dependabot[bot]
c6c430bff1
build(deps): bump dsanders11/project-actions from 1.3.0 to 1.4.0 ( #44566 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](eb760c4889...438b25e007 )
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 21:30:31 +01:00
electron-appveyor-updater[bot]
928c0301e7
build: update appveyor image to latest version ( #44606 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-11 13:56:59 -05:00
electron-roller[bot]
6e3a5daf62
chore: bump chromium to 132.0.6826.0 (main) ( #44584 )
...
* chore: bump chromium in DEPS to 132.0.6821.0
* chore: bump chromium in DEPS to 132.0.6822.0
* chore: update patches
* chore: bump chromium in DEPS to 132.0.6824.0
* chore: update patches
* 5998172: Migrate remaining NOTREACHED()s in chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* 5872484: Pass along accelerators for menu items coming from DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/5872484
* chore: update patches
* 5872913: Enable `raw_span` clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
* fixup! picture-in-picture import
* 5912245: [video pip] Add progress bar to 2024 UI | https://chromium-review.googlesource.com/c/chromium/src/+/5912245
* fixup! 5872913: Enable raw_span clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-11-08 16:12:42 -08:00
Keeley Hammond
f9a04012b9
build: revert bump Node.js to v22.9.0 ( #44596 )
...
* Revert "chore: bump Node.js to v22.9.0 (#44281 )"
This reverts commit c63d0d61e7 .
* chore: update patches
2024-11-07 19:20:50 -08:00
John Kleinschmidt
4b57a8fb1a
chore: remove revert_mojo_force_blink_headers_to_only_be_included_in_blink.patch ( #44589 )
2024-11-07 12:30:57 -08:00
Samuel Attard
e3d75b3087
build: also lint mjs files ( #44581 )
2024-11-06 18:46:09 -05:00
electron-appveyor-updater[bot]
ea7b0a4cc8
build: update appveyor image to latest version ( #44570 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-06 13:54:39 -05:00
Charles Kerr
2002472b10
chore: remove unused gin::Converter<char[]>::ToV8(isolate, const char*) ( #44568 )
...
No longer needed after #44498
2024-11-06 08:49:25 -06:00
electron-roller[bot]
adbd25f699
chore: bump chromium to 132.0.6820.0 (main) ( #44544 )
...
* chore: bump chromium in DEPS to 132.0.6817.0
* chore: update chromium patches
* 5979290: Temoporarily disable crel on arm. | https://chromium-review.googlesource.com/c/chromium/src/+/5979290
* 5981701: Include callback.h instead of callback_forward.h | https://chromium-review.googlesource.com/c/chromium/src/+/5981701
* 5964918: [v8 code cache] Add a wpt_internal test demonstrating the code cache 304 problem | https://chromium-review.googlesource.com/c/chromium/src/+/5964918
* 5969697: Add NetworkTrafficAnnotationTag to PreconnectManager | https://chromium-review.googlesource.com/c/chromium/src/+/5969697
* chore: update remaining patches
* chore: bump chromium in DEPS to 132.0.6818.0
* chore: update patches
* 5983492: MPArch GuestView: Have executeScript target correct frame | https://chromium-review.googlesource.com/c/chromium/src/+/5983492
* chore: bump chromium in DEPS to 132.0.6820.0
* chore: update patches
* 5989717: Revert "win: Remove special check for 10.0.22621.2428 Win SDK version" | https://chromium-review.googlesource.com/c/chromium/src/+/5989717
* 5968218: Send PDF Searchifier running state to browser to show UX elements. | https://chromium-review.googlesource.com/c/chromium/src/+/5968218
* build: also update the MSVS_HASH for WOA
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-11-05 16:46:57 -08:00
Charles Kerr
3090e40c09
chore: remove executable flag from docs/api/app.md file permissions ( #44548 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
2024-11-05 11:48:23 -05:00
Niklas Wenzel
4f2fb7b1a0
docs: clarify that sessions use cache by default ( #44547 )
2024-11-05 10:27:19 -06:00
Charles Kerr
9bf067dd5a
fix: ftbfs when including simdjson in Node.js ( #44567 )
2024-11-04 20:28:44 -05:00
John Kleinschmidt
f0d3e42338
test: fixup flaky session tests ( #44545 )
...
test: fixup broken tests in 32-x-y (#44389 )
* test: fixup broken tests in 32-x-y
* test: fixup additional failing test
(cherry picked from commit c61bb1654e )
2024-11-04 17:26:19 -05:00
Charles Kerr
24dc9ddf5c
fix: remove use of banned std::to_string() ( #44514 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
2024-11-04 16:42:42 -05:00
Charles Kerr
1835c0ab6c
docs: capitalize POSIX and Windows correctly ( #44546 )
...
* docs: capitalize POSIX correctly
* docs: capitalize Windows correctly
2024-11-04 13:12:23 -08:00
John Kleinschmidt
1c1eb3e19d
build: add new status to verify if all the required gha jobs have run ( #44432 )
2024-11-04 14:35:10 -05:00
Charles Kerr
726d439399
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #44515 )
...
refactor: replace base::StringPrintf() calls with absl::StFormat()
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
2024-11-04 12:58:16 -06:00
Shelley Vohr
c63d0d61e7
chore: bump Node.js to v22.9.0 ( #44281 )
...
* chore: bump Node.js to v22.9.0
* build: drop base64 dep in GN build
https://github.com/nodejs/node/pull/52856
* build,tools: make addons tests work with GN
https://github.com/nodejs/node/pull/50737
* fs: add fast api for InternalModuleStat
https://github.com/nodejs/node/pull/51344
* src: move package_json_reader cache to c++
https://github.com/nodejs/node/pull/50322
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* src: shift more crypto impl details to ncrypto
https://github.com/nodejs/node/pull/54028
* src: switch crypto APIs to use Maybe<void>
https://github.com/nodejs/node/pull/54775
* crypto: remove DEFAULT_ENCODING
https://github.com/nodejs/node/pull/47182
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* build: fix conflict gyp configs
https://github.com/nodejs/node/pull/53605
* lib,src: drop --experimental-network-imports
https://github.com/nodejs/node/pull/53822
* esm: align sync and async load implementations
https://github.com/nodejs/node/pull/49152
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* module: detect ESM syntax by trying to recompile as SourceTextModule
https://github.com/nodejs/node/pull/52413
* test: adapt debugger tests to V8 11.4
https://github.com/nodejs/node/pull/49639
* lib: update usage of always on Atomics API
https://github.com/nodejs/node/pull/49639
* test: adapt test-fs-write to V8 internal changes
https://github.com/nodejs/node/pull/49639
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* src: use non-deprecated v8::Uint8Array::kMaxLength
https://github.com/nodejs/node/pull/50115
* src: update default V8 platform to override functions with location
https://github.com/nodejs/node/pull/51362
* src: add missing TryCatch
https://github.com/nodejs/node/pull/51362
* lib,test: handle new Iterator global
https://github.com/nodejs/node/pull/51362
* src: use non-deprecated version of CreateSyntheticModule
https://github.com/nodejs/node/pull/50115
* src: remove calls to recently deprecated V8 APIs
https://github.com/nodejs/node/pull/52996
* src: use new V8 API to define stream accessor
https://github.com/nodejs/node/pull/53084
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
* src: migrate to new V8 interceptors API
https://github.com/nodejs/node/pull/52745
* src: use supported API to get stalled TLA messages
https://github.com/nodejs/node/pull/51362
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* test: make snapshot comparison more flexible
https://github.com/nodejs/node/pull/54375
* test: do not set concurrency on parallelized runs
https://github.com/nodejs/node/pull/52177
* src: move FromNamespacedPath to path.cc
https://github.com/nodejs/node/pull/53540
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* build: add option to enable clang-cl on Windows
https://github.com/nodejs/node/pull/52870
* chore: fixup patch indices
* chore: add/remove changed files
* esm: drop support for import assertions
https://github.com/nodejs/node/pull/54890
* build: compile with C++20 support
https://github.com/nodejs/node/pull/52838
* deps: update nghttp2 to 1.62.1
https://github.com/nodejs/node/pull/52966
* src: parse inspector profiles with simdjson
https://github.com/nodejs/node/pull/51783
* build: add GN build files
https://github.com/nodejs/node/pull/47637
* deps,lib,src: add experimental web storage
https://github.com/nodejs/node/pull/52435
* build: add missing BoringSSL dep
* src: rewrite task runner in c++
https://github.com/nodejs/node/pull/52609
* fixup! build: add GN build files
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
* fix: shadow variable
* build: add back incorrectly removed SetAccessor patch
* fixup! fixup! build: add GN build files
* crypto: fix integer comparison in crypto for BoringSSL
* src,lib: reducing C++ calls of esm legacy main resolve
https://github.com/nodejs/node/pull/48325
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* chore: fixup GN files for previous commit
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* Fixup Perfetto ifdef guards
* fix: missing electron_natives dep
* fix: node_use_node_platform = false
* fix: include src/node_snapshot_stub.cc in libnode
* 5507047: [import-attributes] Remove support for import assertions
https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fix: restore v8-sandbox.h in filenames.json
* fix: re-add original-fs generation logic
* fix: ngtcp2 openssl dep
* test: try removing NAPI_VERSION undef
* chore(deps): bump @types/node
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
* lib: rewrite AsyncLocalStorage without async_hooks
https://github.com/nodejs/node/pull/48528
* module: print amount of load time of a cjs module
https://github.com/nodejs/node/pull/52213
* test: skip reproducible snapshot test on 32-bit
https://github.com/nodejs/node/pull/53592
* fixup! src: move more crypto_dh.cc code to ncrypto
* test: adjust emittedUntil return type
* chore: remove redundant wpt streams patch
* fixup! chore(deps): bump @types/node
* fix: gn executable name on Windows
* fix: build on Windows
* fix: rename conflicting win32 symbols in //third_party/sqlite
On Windows otherwise we get:
lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
* docs: remove unnecessary ts-expect-error after types bump
* src: move package resolver to c++
https://github.com/nodejs/node/pull/50322
* build: set ASAN detect_container_overflow=0
https://github.com/nodejs/node/issues/55584
* chore: fixup rebase
* test: disable failing ASAN test
* win: almost fix race detecting ESRCH in uv_kill
https://github.com/libuv/libuv/pull/4341
2024-11-04 13:41:56 -05:00
Charles Kerr
e3f2ca1425
chore: remove use of banned absl::optional ( #44513 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
2024-11-04 12:37:04 -06:00
Charles Kerr
f5bdbdb1e8
refactor: more inline constexpr string view ( #44498 )
...
* chore: remove unused electron::kHidProductIdKey
* refactor: make electron::kHidDeviceNameKey inline constexpr std::string_view
refactor: make electron::kHidGuidKey inline constexpr std::string_view
* refactor: make serial_chooser_context keys inline constexpr std::string_view
* refactor: make native_window keys inline constexpr std::string_view
* refactor: make electron::options keys inline constexpr std::string_view pt 1
* fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
chore: make kElectronNativeWindowKey a base::cstring_view
ui::Widget::GetNativeWindowProperty requires a const char*
* refactor: make electron::options keys inline constexpr std::string_view pt 2
* refactor: make electron::options keys inline constexpr std::string_view pt 3
* refactor: make electron::options keys inline constexpr std::string_view pt 4
* refactor: make electron::options keys inline constexpr std::string_view pt 5
* refactor: make electron::options keys inline constexpr std::string_view pt 6
* refactor: make electron::options keys inline constexpr std::string_view pt 7
* refactor: make electron::options keys inline constexpr std::string_view pt 8
* chore: remove unused file shell/common/options_switches.cc
* docs: add code comment explaining use of base::cstring_view
* fixup! fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
* chore: use consistent capitalization of the word 'fullscreen'
2024-11-04 12:27:49 -06:00
electron-roller[bot]
48801be8e9
chore: bump chromium to 132.0.6807.0 (main) ( #44360 )
...
* chore: bump chromium in DEPS to 132.0.6791.0
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5804481
* chore: try revert PA CL
* chore: bump chromium in DEPS to 132.0.6793.0
* chore: bump chromium in DEPS to 132.0.6794.0
* 5952404: Clean up //ui/base/resource from Lacros code.
https://chromium-review.googlesource.com/c/chromium/src/+/5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
https://chromium-review.googlesource.com/c/chromium/src/+/5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
https://chromium-review.googlesource.com/c/chromium/src/+/5943708
* chore: fixup patch indices
* 5937004: Remove components/services/language_detection
https://chromium-review.googlesource.com/c/chromium/src/+/5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
https://chromium-review.googlesource.com/c/chromium/src/+/5920322
* chore: bump chromium in DEPS to 132.0.6797.0
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
https://chromium-review.googlesource.com/c/chromium/src/+/5947724
* chore: fixup patch indices
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
https://chromium-review.googlesource.com/c/chromium/src/+/5948024
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/5945209
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5942398
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5963016
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6805.0
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5924816
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
* 5829616: MPArch based GuestViews basic implementation
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5829616
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5953710
* chore: fixup patch indices
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | https://chromium-review.googlesource.com/c/chromium/src/+/5938657
* chore: bump chromium in DEPS to 132.0.6807.0
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5868889
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5956408
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962696
* chore: update patches
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973073
* chore: update filenames.libcxx.gni
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-11-04 09:10:00 -05:00
Ani Betts
d9a9d5b8fe
docs: Update Squirrel Run at Login docs to be modern ( #44487 )
...
Update Squirrel Run at Login docs to be modern
The current docs for setting up Run at Login use the legacy way that
Squirrel does shortcuts. This was replaced by an easier method, let's
use that instead
2024-11-02 15:56:02 -05:00
Charles Kerr
7fea537fbf
docs: fix apostrophe typo "Electrons" -> "Electron's" ( #44516 )
...
s/Electrons/Electron's/
2024-11-02 15:52:22 -05:00
David Sanders
bc6c7bd757
build: remove unused lint package ( #44525 )
2024-11-02 13:57:15 -05:00
Charles Kerr
9137d96ef4
refactor: remove unused C string ToV8() gin converter ( #44500 )
2024-11-01 18:11:46 -05:00
Charles Kerr
b985d8eb28
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter ( #44501 )
2024-11-01 15:01:09 -05:00
Anny Yang
2081f771e4
docs: add custom titlebar example ( #43693 )
...
* docs: add custom titlebar example
* docs: add links and other small edits
* docs: add panel window docs
* docs: remove panel example
* docs: specify expected emphasis style
* docs: responding to feedback
* docs: fix section names in links
* docs: rework baseWindow note
* docs: making window customization its own section
* responding to feedback
2024-11-01 11:04:37 -04:00
Shelley Vohr
15151c6853
fix: EventSource undefined in Renderer/Worker ( #44475 )
2024-10-31 15:24:44 -04:00
John Kleinschmidt
8be4ae4bab
build: handle out of disk space on source cache ( #44490 )
...
* build: handle out of disk space on source cache
* build: add cron job to free up source cache disk space
2024-10-31 15:03:28 -04:00
Sam Maddock
31f8e7553b
fix: flaky utility and BrowserView tests ( #44451 )
...
* fix: flake wait for crash with specific serviceName
* fix: flake when unrelated WebContents exists during BrowserView tests
* fix: wait for crash before forking
* use name
2024-10-30 20:29:01 -05:00
Charles Kerr
7cdf1a01b8
docs: fix win.setContentView() arg type ( #44478 )
...
fix: setContentView type
2024-10-30 15:56:10 -04:00
Charles Kerr
a720c8daf6
perf: remove isolate scope from DidProcessTask() ( #44439 )
2024-10-29 23:25:40 -05:00
Charles Kerr
fb959f8d30
build: enable -Wunsafe-buffer-usage warnings ( #44056 )
2024-10-29 17:28:34 -05:00
Alice Zhao
de04fc3b90
fix: update shell.openExternal to correctly focus on external window ( #44408 )
...
* fix: Use openURL:configuration:completionHandler instead of openUrl
* test: add a test
* fix: add dispatch_async to replace GetUIThreadTaskRunner
* refactor: remove unused import
* fix: update to use BindPostTaskToCurrentDefault
* test: add regression test for window focus
* refactor: update to explicit task runner
2024-10-29 15:10:10 -07:00
Shelley Vohr
7ff7160135
docs: fix win.getContentView() return type ( #44430 )
...
docs: fix win.getContentView() return type
2024-10-29 21:41:44 +01:00
Shelley Vohr
9fc94a162b
build: fix python util verbose mode logic ( #44431 )
...
build: fix verbose mode logic
2024-10-29 11:35:57 -04:00
Devin Binnie
53458da01e
docs: Fix powerMonitor docs for type generation of speed-limit-change ( #44391 )
...
Fix `powerMonitor` docs for type generation of `speed-limit-change`
2024-10-29 10:16:29 -05:00
Charles Kerr
dffe00b232
fix: -Wunsafe-buffer-usage warnings with argc, argv ( #44366 )
...
* refactor: move uv_setup_args() calls to startup
* refactor: call base::CommandLine::Init() before ContentMain()
* feat: add ElectronCommandLine::AsUtf8()
* refactor: call base::CommandLine::Init() before NodeMain()
* refactor: use ElectronCommandLine::AsUtf8() in NodeMain()
* fix: -Wunsafe-buffer-usage warning in ElectronCommandLine::Init()
* chore: add a DCHECK to confirm ElectronCommandLine was initialized before AsUtf8() is called
* chore: const correctness in ElectronCommandLine::Init() args
* chore: add ElectronCommandLine to macOS Electron Helper app
* chore: move argc, argvc setup into electron_library_main on macOS
* chore: revert BUILD.gn changes
* fix: WideToUTF8() call in ElectronCommandLine::AsUtf8()
* build: add uv to the include paths for app/electron_main_linux
* build: add uv to the include paths for app/electron_library_main.mm
* chore: revert unrelated changes
these were intended for another branch
2024-10-29 13:23:08 +01:00
Shelley Vohr
39b24aed92
refactor: move node ofs script to electron ( #44425 )
...
* refactor: move node ofs script to electron
* chore: remove empty file
2024-10-29 13:22:26 +01:00
dependabot[bot]
f7ead785cd
build(deps): bump actions/setup-node from 4.0.4 to 4.1.0 ( #44433 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.4 to 4.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](0a44ba7841...39370e3970 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 13:21:09 +01:00
Charles Kerr
b3c2e83243
refactor: prefer inline constexpr string_view for string constants ( #44405 )
...
* refactor: BaseWindow::OnExecuteAppCommand() now takes a std::string_view
* refactor: NativeWindow::NotifyWindowExecuteAppCommand() takes a std::string_view
* refactor: AppCommandToString() returns a std::string_view, is now constexpr
* refactor: make kBrowserBackward, kBrowserForward inline constexpr std::string_view
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: use inline constexpr string_view for kDevice*Key constants
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: IsEnvSet now takes a base::cstring_view
* refactor: use inline constexpr cstring_view for kRunAsNode
* refactor: use inline constexpr string_view for kPDF*PluginName
* refactor: use base::FilePath::FromASCII() since "internal-pdf-viewer" is ascii
* chore: remove unused shell/common/electron_constants.cc
* fixup! refactor: IsEnvSet now takes a base::cstring_view
2024-10-29 10:30:12 +01:00
dependabot[bot]
cc3359f126
build(deps): bump actions/checkout from 4.2.1 to 4.2.2 ( #44435 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901b )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 09:59:22 +01:00
Shelley Vohr
46561fc5bc
build: improve gen-libc++-filenames output ( #44424 )
...
build: improve gen-libc++-filenames output
2024-10-29 09:59:10 +01:00
dependabot[bot]
214c8228ed
build(deps): bump github/codeql-action from 3.26.13 to 3.27.0 ( #44434 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.13 to 3.27.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f779452ac5...662472033e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 01:05:46 -05:00
Robo
739688214b
fix: keep gdk_pixbuf a dynamic dependency ( #44423 )
2024-10-29 09:44:20 +09:00
Charles Kerr
5d0d15a0b3
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals ( #44412 )
...
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
* perf: string length is known when calling NewFromUtf8(), so use it
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
2024-10-28 14:12:32 +01:00
Sam Maddock
348801b20e
fix: crash on netlog connection error ( #44406 )
...
* fix: crash on netlog connection error
* refactor: remove default PromiseBase constructor
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d .
* remove dcheck
2024-10-28 10:24:54 +01:00
John Kleinschmidt
57920e7747
test: deflake flaky tests on linux ( #44383 )
2024-10-24 20:47:17 -04:00
John Kleinschmidt
a0f51d816e
build: update linux container ( #44392 )
2024-10-24 16:58:36 -04:00
Charles Kerr
83d7040096
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44348 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
* refactor: use base::HexEncode() instead of rolling our own
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
2024-10-23 14:18:22 -05:00
John Kleinschmidt
c42fb09fc9
test: fixup flaky tests ( #44349 )
...
* test: fixup flaky test
* test: disable flaky protocol speed test on macOS
* test: fixup flaky test in api-browser-window-spec.ts
2024-10-23 15:14:50 -04:00
Shelley Vohr
fd500477ac
docs: clarify utilityProcess child.pid value ( #44339 )
2024-10-22 13:09:33 -04:00
electron-appveyor-updater[bot]
d60d526df6
build: update appveyor image to latest version ( #44334 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-10-22 10:40:00 -04:00
Charles Kerr
e3e94d45ee
fix: silence -Wunsafe-buffer-usage warning in GetPreferredLanguages() ( #44333 )
...
fix: use UNSAFE_BUFFERS macro in GetPreferredLanguages()
2024-10-21 18:20:00 -05:00
Sam Maddock
fff6ea438a
fix: software compositing infinite loop ( #44318 )
...
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-10-21 18:56:03 -04:00
Robo
3e77faf2f7
fix: crash when generating shortcut text for super accelerator ( #44341 )
2024-10-22 03:26:38 +09:00
John Kleinschmidt
cc9d85d3ca
build: fixup reclient use for prod builds ( #44340 )
2024-10-21 14:07:02 -04:00
electron-roller[bot]
d3d02ef111
chore: bump chromium to 132.0.6789.0 (main) ( #44337 )
...
chore: bump chromium in DEPS to 132.0.6789.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-21 10:48:59 -04:00
electron-roller[bot]
e70f70f5b4
chore: bump chromium to 132.0.6788.0 (main) ( #44331 )
...
chore: bump chromium in DEPS to 132.0.6788.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-20 23:54:06 -05:00
electron-roller[bot]
0d948da4b9
chore: bump chromium to 132.0.6787.0 (main) ( #44329 )
...
* chore: bump chromium in DEPS to 132.0.6785.0
* chore: bump chromium in DEPS to 132.0.6787.0
* 5837702: mac fullscreen: always show traffic lights
https://chromium-review.googlesource.com/c/chromium/src/+/5837702
* 5892572: Move SimpleMenuModel out of ui/base
https://chromium-review.googlesource.com/c/chromium/src/+/5892572
* 5938185: Remove lacros code from //ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/5938185
* chore: fixup patch indices
* 5939514: Wire up the preference of overlay scrollbars to the ChromeOS settings
https://chromium-review.googlesource.com/c/chromium/src/+/5939514
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-10-20 19:02:21 -05:00
dependabot[bot]
2cf59b3885
build(deps-dev): bump webpack from 5.94.0 to 5.95.0 ( #44309 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.94.0 to 5.95.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.94.0...v5.95.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-20 10:40:03 +02:00
Sam Maddock
87bd665e41
feat: expose frame & move properties to console-message event object ( #43617 )
...
* feat: expose frame on console-message event
refactor: use property names similar to ServiceWorker's console-message event
refactor: don't use deprecated params in tests
doc: console-message breaking change
chore: add deprecation warning
docs: restore deprecated argument descriptions
* move console-message deprecations to v34
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 16:07:06 -04:00
John Beutner
35aeab6ecd
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44078 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 14:29:52 -04:00
electron-roller[bot]
738533dec7
chore: bump chromium to 132.0.6783.0 (main) ( #44307 )
...
* chore: bump chromium in DEPS to 132.0.6782.0
* chore: bump chromium in DEPS to 132.0.6783.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-18 12:06:33 -04:00
electron-appveyor-updater[bot]
456aac1f94
build: update appveyor image to latest version ( #44311 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-10-18 11:24:24 -04:00
dependabot[bot]
6c6e5c002a
build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3 ( #44173 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](50769540e7...b4b15b8c7c )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-18 15:39:55 +02:00
electron-roller[bot]
089f233054
chore: bump chromium to 132.0.6781.0 (main) ( #44301 )
...
* chore: bump chromium in DEPS to 132.0.6781.0
* chore: update patches
* 5933789: [MappableSI] Remove kill-switch from RenderableGpuMemoryBufferVideoFramePool.
https://chromium-review.googlesource.com/c/chromium/src/+/5933789
* 5938992: Reland: Remove `force_guest_profile` param from context getters.
https://chromium-review.googlesource.com/c/chromium/src/+/5938992
* 5928743: spanification: Add WTF::String::FromUTF8(span<>) overloads
https://chromium-review.googlesource.com/c/chromium/src/+/5928743
* 5898835: Update windows SDK version to 10.0.26100.1742
https://chromium-review.googlesource.com/c/chromium/src/+/5898835
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-17 20:00:59 -04:00
dependabot[bot]
2b0624f2f1
build(deps-dev): bump remark-cli from 10.0.0 to 12.0.1 ( #44258 )
...
Bumps [remark-cli](https://github.com/remarkjs/remark ) from 10.0.0 to 12.0.1.
- [Release notes](https://github.com/remarkjs/remark/releases )
- [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md )
- [Commits](https://github.com/remarkjs/remark/compare/10.0.0...remark-cli@12.0.1 )
---
updated-dependencies:
- dependency-name: remark-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-17 15:15:48 -04:00
Keeley Hammond
ac09d11ed1
build: fix main printing patch conflict ( #44302 )
...
build: update patches
2024-10-17 11:29:04 -04:00
John Kleinschmidt
9280add5b4
chore: fixup reclient read only access on forks ( #44280 )
2024-10-17 11:17:54 -04:00
Mayur
44c398fedb
docs: removed AngularJS Batarang from the Devtool Extension Support ( #44261 )
...
docs: update Devtool Extension Support
2024-10-17 10:55:05 -04:00
David Sanders
cbc12d6675
ci: use Node.js 20 in Bake AppVeyor Image workflow ( #44290 )
...
* ci: use Node.js 20 in Bake AppVeyor Image workflow
* chore: add bake workflow to CODEOWNERS
2024-10-17 10:35:50 -04:00
electron-roller[bot]
d801bad5d2
chore: bump chromium to 132.0.6779.0 (main) ( #44273 )
...
* chore: bump chromium in DEPS to 132.0.6779.0
* chore: update patches
* 5904951: controlledframe: Disable File System Access for <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5904951
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-16 21:41:31 -04:00
Shelley Vohr
d386664900
build: use new Issue Template types in templates ( #44224 )
...
* build: use new Issue Template types in templates
* build: restore existing labels for now
2024-10-16 15:34:35 -04:00
David Sanders
67775d19ec
build: remove dead code in prepare release script ( #44256 )
2024-10-16 15:05:09 -04:00
Shelley Vohr
cbe3cb770a
fix: Linux crash after webContents.print() with no parent window ( #44246 )
...
fix: Linux crash after print with no parent window
2024-10-16 13:15:21 -04:00
Shelley Vohr
bd4ea5ba72
fix: use proper PDF save approach ( #44248 )
2024-10-16 11:33:21 -04:00
Robo
af6e2fb257
fix: trace-startup crashing child process on macOS ( #44257 )
2024-10-16 11:03:00 -04:00
Shelley Vohr
df45474b58
fix: ensure utilityProcess only emits one 'exit' event ( #44243 )
...
fix: ensure utilityProcess only emits one exit
2024-10-16 10:47:12 +02:00
Charles Kerr
b5acebf3ba
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44238 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
2024-10-15 18:31:44 -05:00
electron-roller[bot]
ef84f13650
chore: bump chromium to 131.0.6778.0 (main) ( #44251 )
...
* chore: bump chromium in DEPS to 131.0.6778.0
* 5803393: [UI] Add alias for mojo version of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5803393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-15 16:41:14 -04:00
electron-roller[bot]
36b7cf341e
chore: bump chromium to 131.0.6776.0 (main) ( #44137 )
...
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs 4017a6c8b4
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
https://github.com/nodejs/node/pull/54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092fc51 .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-15 11:51:11 -04:00
Niklas Wenzel
72802c374b
docs: add section on resource management to base-window.md ( #43610 )
2024-10-15 11:49:54 -04:00
David Sanders
d3e368003b
ci: use env variable in branch created workflow ( #44240 )
2024-10-15 11:16:04 -04:00
dependabot[bot]
0064b23440
build(deps): bump github/codeql-action from 3.26.12 to 3.26.13 ( #44239 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.12 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c36620d31a...f779452ac5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 10:51:34 +02:00
Shelley Vohr
1cab6bde94
build: update devcontainer sha ( #44229 )
2024-10-15 10:35:43 +02:00
George Xu
9ecb848c67
docs: update timelines for E34 ( #44210 )
...
update dates for e34
2024-10-14 10:52:18 -04:00
John Kleinschmidt
48156aee06
test: run visibility-state-spec.ts first ( #44206 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2024-10-14 09:40:22 -04:00
Charles Kerr
566c72cd46
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44211 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
* refactor: restore node buffer span util
* refactor: remove redundant span wrapper
2024-10-14 10:46:24 +02:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:33:53 -04:00
Charles Kerr
527efc01a4
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44185 )
2024-10-11 14:29:00 -05:00
dependabot[bot]
6c1b377192
build(deps): bump actions/checkout from 4.1.7 to 4.2.1 ( #44140 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...eef61447b9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 12:28:45 -05:00
dependabot[bot]
13b39e0eeb
build(deps): bump github/codeql-action from 3.26.8 to 3.26.12 ( #44139 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.8 to 3.26.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](294a9d9291...c36620d31a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-11 18:32:17 +02:00
Samuel Attard
7402648ee3
build: update ts defs and docs parser ( #43985 )
...
* build: update ts defs and docs parser
* build: update dig
2024-10-11 10:44:18 -04:00
Niklas Wenzel
5400c04e43
docs: clarify interplay between utility process events ( #44015 )
2024-10-11 10:25:25 -04:00
Robo
dd5b36f557
fix: clang variable configuration in generated node headers ( #44189 )
...
* fix: clang variable configuration in generated node headers
* chore: restore value in common.gypi
2024-10-11 10:22:56 -04:00
John Kleinschmidt
8201623d92
test: fix visibility-state-spec.ts flaky test ( #44037 )
...
* test: refactor visibility-state-spec
* ci: shard tests
* test: update split-tests for use on Windows
* test: run visibility-state-spec.ts first
2024-10-11 10:00:22 -04:00
John Kleinschmidt
d93285dde1
ci: don't call datadog test logging on forks ( #44181 )
2024-10-11 12:08:51 +02:00
Charles Kerr
3d2f68a9df
refactor: spanify image utils ( #44127 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
* feat: add Node-buffer-to-base-span helper function
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
* refactor: use base::as_byte_span()
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
* chore: add // SAFETY comment for Node-buffer-to-span func
* chore: add // SAFETY comment for NSData-to-span func
2024-10-10 09:34:55 -04:00
Michaela Laurencin
d51ef7d794
build: update NMV to 132 ( #44135 )
...
Node PR: https://github.com/nodejs/node/pull/55306
Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34
Please merge this PR before branching 34-x-y
2024-10-09 11:55:59 -07:00
Charles Kerr
78fa477726
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44133 )
2024-10-09 13:02:00 -05:00
Charles Kerr
dbbdf55493
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44134 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
2024-10-09 12:18:19 -05:00
Charles Kerr
b5227b4a17
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 )
...
fixup e8948397 really fix the warning this time
2024-10-09 09:12:48 -05:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
John Kleinschmidt
ebeae6f301
ci: only upload to datadog when running tests ( #44152 )
2024-10-08 15:07:17 -04:00
Charles Kerr
4cf69f396f
fix: context shear in cli_remove_deprecated_v8_flag.patch ( #44148 )
...
fix: patch shear in cli_remove_deprecated_v8_flag.patch
2024-10-08 07:54:33 -07:00
electron-roller[bot]
bcbc8d3bb2
chore: bump chromium to 131.0.6762.0 (main) ( #44117 )
...
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-10-07 18:06:47 -05:00
John Kleinschmidt
aa40e817c8
ci: add datadog test logging ( #44094 )
2024-10-07 18:51:23 -04:00
electron-roller[bot]
b95ee8964c
chore: bump node to v20.18.0 (main) ( #44119 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-10-07 18:51:08 -04:00
electron-roller[bot]
ab1488a1be
chore: bump chromium to 131.0.6754.0 (main) ( #44110 )
...
* chore: bump chromium in DEPS to 131.0.6754.0
* chore: update gin_enable_disable_v8_platform.patch
fix minor context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5901115
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-03 13:35:03 -04:00
Samuel Attard
122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
Charles Kerr
684e345f68
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44068 )
...
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
2024-10-02 16:44:28 -04:00
Charles Kerr
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
Keeley Hammond
93dd9fc17b
build: use node 20.17 on Windows ( #44065 )
...
* build: rebake image
* build: use e-131.0.6734.0-node-20.17-0
* build: bump msvs version to 2022
2024-10-02 20:12:41 +02:00
electron-roller[bot]
59a43ef2e3
chore: bump chromium to 131.0.6752.0 (main) ( #44093 )
...
* chore: bump chromium in DEPS to 131.0.6752.0
* chore: update refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
adjust to upstream #include shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5872830
* chore: e patches all
* Remove the <selectlist> prototype implementation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5855076
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-02 08:35:18 -07:00
electron-roller[bot]
5a97ee26ff
chore: bump chromium to 131.0.6751.0 (main) ( #44087 )
...
chore: bump chromium in DEPS to 131.0.6751.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:30:40 -05:00
Samuel Attard
5b34138db8
build: fix relative file read during npm publish ( #44088 )
2024-10-01 17:09:57 -07:00
electron-roller[bot]
1fc2064f6a
chore: bump chromium to 131.0.6750.0 (main) ( #44066 )
...
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-10-01 19:34:32 -04:00
Samuel Attard
f4ffd018e6
build: cleanup release scripts, separate cli entrypoints from logic ( #44058 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 13:51:40 -07:00
Charles Kerr
15c8759ee0
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() ( #44053 )
2024-10-01 10:06:02 -07:00
Charles Kerr
06bce8166b
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44055 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
2024-10-01 10:05:46 -07:00
Charles Kerr
6f88f0c795
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44067 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-01 10:04:57 -07:00
Samuel Attard
f828c1da09
build: remove github actions dependabot on release branches ( #44054 )
2024-10-01 08:50:42 -07:00
Samuel Attard
47cf1e3acd
build: use ts-node to spawn the version-bumper ( #44057 )
...
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-09-30 21:19:59 -07:00
Samuel Attard
61565465fd
build: convert all release scripts to typescript ( #44035 )
...
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
2024-09-30 17:55:27 -07:00
Keeley Hammond
7ebc427bf5
build: update appveyor to node 20.17 ( #44026 )
...
* build: update appveyor to node 20.17
* build: bake new images with npm dir
* build: use e-131.0.6734.0-node-20.17-1
2024-09-30 16:14:46 -04:00
electron-roller[bot]
5d9800e176
chore: bump chromium to 131.0.6748.0 (main) ( #44027 )
...
* chore: bump chromium in DEPS to 131.0.6748.0
* chore: gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 13:32:50 -04:00
Charles Kerr
1d4b86cb3e
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44024 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
2024-09-30 11:01:24 -05:00
Charles Kerr
77f7ba96ca
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44014 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: remove logging
* fix: unconditionally write
* chore: naming
* chore: add code comments
* chore: more code comments
* chore: remove unrelated changes
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: naming
* refactor: naming
* refactor: naming
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
2024-09-30 15:09:36 +02:00
electron-roller[bot]
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 14:54:44 +02:00
Charles Kerr
eb40d2cbfa
fix: FTBFS when building with enable_plugins = false ( #44003 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
2024-09-29 17:10:34 -05:00
John Kleinschmidt
27d2a8f9e2
ci: write test logging to console on Windows ( #43990 )
...
test: write logging to console on Windows
2024-09-27 15:17:32 -04:00
Shelley Vohr
d4e4cdee6c
fix: remove resize listener when BrowserWindow closed ( #43972 )
2024-09-27 10:34:00 -04:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-09-27 10:17:06 +09:00
Charles Kerr
8397fef3ef
chore: remove unused nogncheck includes ( #43964 )
2024-09-26 17:09:42 -05:00
Charles Kerr
852f9ff329
perf: build g_dgettext domain name at compile time ( #43960 )
...
perf: build GettextPackage name at compile time
2024-09-26 13:10:30 -04:00
Charles Kerr
a974b74e82
fix: replace deprecated libnotify API calls ( #43962 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 11:21:45 -05:00
Shelley Vohr
da6ab92353
fix: ensure correct WebContents when checking PDFReadyToPrint ( #43943 )
...
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
2024-09-26 10:54:13 -04:00
Charles Kerr
ddd45db6ca
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43956 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
2024-09-26 08:32:43 -05:00
John Kleinschmidt
40cae71df8
test: re-enable tests that were disabled in chromium rolls ( #43968 )
...
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
2024-09-26 08:53:27 -04:00
electron-appveyor-updater[bot]
b60013fcf1
build: update appveyor image to latest version ( #43971 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-26 13:10:34 +02:00
Samuel Attard
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
Fedor Indutny
15db63e26d
fix: SCContentSharingPicker crash in iframes ( #43905 )
...
When running `getDisplayMedia` from an `iframe` and then destroying that
`iframe`, the destrutcor for ScreenCaptureKitDeviceMac gets run, but it
doesn't clean up the observers for the shared macOS picker.
In this change we remove the observer on cleanup and fix the associated
crash:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x12c024123a0> was mutated while being enumerated.'
0 CoreFoundation 0x000000018eda0ec0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018e886cd8 objc_exception_throw + 88
2 CoreFoundation 0x000000018ee47f80 -[__NSSingleObjectEnumerator init] + 0
3 ScreenCaptureKit 0x000000022971f3e0 -[SCContentSharingPicker contentPickerDidSelectFilter:forStream:] + 436
4 ReplayKit 0x00000001d7b879d8 -[RPScreenRecorder contentPickerDidSelectFilter:forStream:] + 84
5 ReplayKit 0x00000001d7b95ce0 -[RPDaemonProxy contentPickerDidSelectFilter:forStream:] + 224
6 CoreFoundation 0x000000018ed0e8b4 __invoking___ + 148
7 CoreFoundation 0x000000018ed0e72c -[NSInvocation invoke] + 428
8 ReplayKit 0x00000001d7b91678 -[RPDaemonProxy connection:handleInvocation:isReply:] + 316
9 Foundation 0x0000000190899f64 -[NSXPCConnection _decodeAndInvokeMessageWithEvent:reply:flags:] + 1108
10 Foundation 0x000000019089b7d0 message_handler_message + 88
11 Foundation 0x000000018feb0160 message_handler + 152
12 libxpc.dylib 0x000000018e954460 _xpc_connection_call_event_handler + 144
13 libxpc.dylib 0x000000018e952bb4 _xpc_connection_mach_event + 1120
14 libdispatch.dylib 0x000000018ea94718 _dispatch_client_callout4 + 20
15 libdispatch.dylib 0x000000018eab0c00 _dispatch_mach_msg_invoke + 464
16 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
17 libdispatch.dylib 0x000000018eab1954 _dispatch_mach_invoke + 456
18 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
19 libdispatch.dylib 0x000000018ea9c79c _dispatch_lane_invoke + 432
20 libdispatch.dylib 0x000000018eaa77e8 _dispatch_root_queue_drain_deferred_wlh + 288
21 libdispatch.dylib 0x000000018eaa7034 _dispatch_workloop_worker_thread + 540
22 libsystem_pthread.dylib 0x000000018ec433d8 _pthread_wqthread + 288
23 libsystem_pthread.dylib 0x000000018ec420f0 start_wqthread + 8
2024-09-25 16:43:23 -07:00
dependabot[bot]
ff36ff84b7
build(deps-dev): bump eslint-plugin-promise from 4.3.1 to 7.1.0 ( #43935 )
...
Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise ) from 4.3.1 to 7.1.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-promise/releases )
- [Changelog](https://github.com/eslint-community/eslint-plugin-promise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint-community/eslint-plugin-promise/compare/v4.3.1...v7.1.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-promise
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 16:49:03 -05:00
dependabot[bot]
846b31b77d
build(deps-dev): bump @types/chai-as-promised from 7.1.3 to 8.0.1 ( #43936 )
...
Bumps [@types/chai-as-promised](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai-as-promised ) from 7.1.3 to 8.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai-as-promised )
---
updated-dependencies:
- dependency-name: "@types/chai-as-promised"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 09:06:26 -05:00
John Beutner
c8895d0547
fix: close all open sheets before closing window on macOS ( #43706 )
2024-09-25 13:23:49 +02:00
Charles Kerr
1d3b1284c4
test: ensure sender-pid hint is set in Linux notifications ( #43928 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
2024-09-25 13:20:36 +02:00
electron-roller[bot]
30fbeec036
chore: bump chromium to 131.0.6734.0 (main) ( #43769 )
...
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119 : Declutter: Allow opening to a specific feature
https://chromium-review.googlesource.com/c/chromium/src/+/5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
https://chromium-review.googlesource.com/c/chromium/src/+/5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-09-25 06:19:39 -05:00
Charles Kerr
af54c5a4b6
test: add tests dbus notification images ( #43938 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
2024-09-25 13:17:27 +02:00
Shelley Vohr
bcf4095ace
fix: crash when focusing WebView webContents ( #43921 )
...
fix: crash when focusing WebView
2024-09-24 18:19:04 -05:00
Charles Kerr
500d4f0d05
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43896 )
2024-09-24 15:41:24 -05:00
CezaryKulakowski
e64a66bfd3
fix: detach native view when its removed from parent on macOS ( #43627 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
2024-09-24 15:28:36 +02:00
dependabot[bot]
7222a9fe1f
build(deps-dev): bump null-loader from 4.0.0 to 4.0.1 ( #43904 )
...
Bumps [null-loader](https://github.com/webpack-contrib/null-loader ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/webpack-contrib/null-loader/releases )
- [Changelog](https://github.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/null-loader/compare/v4.0.0...v4.0.1 )
---
updated-dependencies:
- dependency-name: null-loader
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 10:13:43 +02:00
dependabot[bot]
65e3c336e0
build(deps-dev): bump eslint from 8.41.0 to 8.57.1 ( #43903 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.41.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.41.0...v8.57.1 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:31:47 -07:00
Charles Kerr
79627deea3
refactor: add SerialChooserController::web_contents_ ( #43823 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
2024-09-23 22:38:13 -07:00
Charles Kerr
9598d88b7c
refactor: remove C-style void arg type for no-arg functions ( #43884 )
...
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-23 22:37:32 -07:00
Charles Kerr
01330805cb
refactor: prefer member initializers in asar structs ( #43883 )
...
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
2024-09-23 22:37:18 -07:00
Charles Kerr
33d7c9ac3e
refactor: hide printing impl details in api::WebContents ( #43893 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
* refactor: remove unused #include
2024-09-23 22:36:55 -07:00
Keeley Hammond
a3af8ea768
build: use Node 20 in Appveyor images ( #43897 )
...
* build: update Appveyor to Node 20
* build: update appveyor images
* chore: return bake script to original form
2024-09-23 16:58:46 -07:00
dependabot[bot]
82879d1f43
build(deps-dev): bump webpack-cli from 4.10.0 to 5.1.4 ( #43880 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.10.0 to 5.1.4.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.10.0...webpack-cli@5.1.4 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 18:21:43 -05:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Alice Zhao
ceea1225a2
docs: navigation history example ( #42980 )
...
* docs: add fiddle example
* docs: add tutorial guide
* refactor: PR review comments
* refactor: add eof
* refactor: render navigation history and make demo better.
* refactor: fix broken links
* refactor: add eof newline
* docs: review feedback :)
* chore: lint add space around list
* doc: transformURL
2024-09-23 10:18:26 -07:00
Samuel Attard
517d04de16
build: add support for fetching github token from sudowoodo ( #43808 )
...
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 09:39:54 -07:00
dependabot[bot]
f0afcaa777
build(deps-dev): bump @types/w3c-web-serial from 1.0.3 to 1.0.7 ( #43879 )
...
Bumps [@types/w3c-web-serial](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/w3c-web-serial ) from 1.0.3 to 1.0.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/w3c-web-serial )
---
updated-dependencies:
- dependency-name: "@types/w3c-web-serial"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 08:07:53 -05:00
Samuel Attard
be68d4f336
build: update-check-skip on dependabot backport PRs ( #43874 )
2024-09-23 11:08:03 +02:00
dependabot[bot]
0fb50c408b
build(deps): bump github/codeql-action from 3.26.7 to 3.26.8 ( #43826 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8214744c54...294a9d9291 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 11:04:21 +02:00
dependabot[bot]
1b52f005ee
build(deps): bump actions/setup-node from 4.0.3 to 4.0.4 ( #43825 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1e60f620b9...0a44ba7841 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-22 23:40:30 -07:00
Samuel Attard
da449b00dd
build: stop dependabot doing things ( #43871 )
2024-09-22 23:10:23 -07:00
Samuel Attard
8be458d1a2
build: enable dependabot on supported branches ( #43755 )
2024-09-22 22:57:23 -07:00
Charles Kerr
e894839709
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43803 )
2024-09-21 17:21:02 -05:00
Shelley Vohr
f89bd745d5
fix: createWindow shouldn't load URL for webContents ( #43775 )
...
* fix: createWindow shouldn't load URL for webContents
* chore: add non about blank test
2024-09-20 09:56:03 +02:00
Charles Kerr
bcb7362ab9
docs: document Windows pitfall when updating patches ( #43787 )
2024-09-19 23:35:21 -05:00
Charles Kerr
53e89b565d
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43795 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
* chore: add a DCHECK to confirm the BigBuffer is full
2024-09-19 23:10:35 -05:00
Fedor Indutny
6aa6bada79
fix: third time screen sharing on macOS ( #43767 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com >
2024-09-19 18:28:28 -07:00
Charles Kerr
d100921289
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43794 )
2024-09-19 19:02:49 -05:00
BILL SHEN
855f219301
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43773 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
2024-09-19 13:01:36 +02:00
dependabot[bot]
0ac8ff6439
build(deps): bump path-to-regexp from 1.8.0 to 1.9.0 in /spec in the npm_and_yarn group across 1 directory ( #43753 )
...
build(deps): bump path-to-regexp
Bumps the npm_and_yarn group with 1 update in the /spec directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp ).
Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 10:34:06 +02:00
Charles Kerr
5904d31264
perf: hold V8FunctionInvoker args in a std::array ( #43752 )
...
perf: hold V8FunctionInvoker args in a std::array
2024-09-18 16:23:29 -05:00
Samuel Attard
8cff5a7d20
build: let darwin/mas run concurrently ( #43788 )
2024-09-18 13:54:58 -07:00
Charles Kerr
d897359b82
perf: hold Emit() arg arrays in a std::array ( #43750 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
2024-09-18 09:40:14 -05:00
electron-appveyor-updater[bot]
02fd8bbcc1
build: update appveyor image to latest version ( #43772 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-18 09:39:49 -05:00
electron-roller[bot]
4bcbc955dd
chore: bump chromium to 130.0.6695.0 (main) ( #43454 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: clavin <clavin@electronjs.org >
2024-09-17 18:12:11 -07:00
Samuel Attard
de33cc68f6
build: split darwin/mas macOS publish jobs ( #43754 )
2024-09-17 15:32:47 -07:00
Samuel Attard
f987f8ad83
build: improve logging on http errors during release process (again, but more) ( #43758 )
2024-09-17 15:01:02 -07:00
Samuel Attard
cf4ab2186c
build: improve logging on http errors during release process (again) ( #43757 )
2024-09-17 14:49:59 -07:00
Samuel Attard
10ba87a85e
build: improve logging on http errors during release process ( #43756 )
2024-09-17 14:30:51 -07:00
Charles Kerr
233724fe00
chore: iwyu mojom-forward header files ( #43741 )
...
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-17 12:58:56 -07:00
dependabot[bot]
4dc923a327
build(deps): bump the npm_and_yarn group across 2 directories with 5 updates ( #43681 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [send](https://github.com/pillarjs/send ).
Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0 )
Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases )
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/body-parser/compare/1.20.2...1.20.3 )
Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10 )
Updates `serve-static` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/expressjs/serve-static/releases )
- [Changelog](https://github.com/expressjs/serve-static/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/serve-static/compare/v1.15.0...1.16.0 )
Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases )
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md )
- [Commits](https://github.com/pillarjs/send/compare/0.16.2...0.19.0 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: body-parser
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: serve-static
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: send
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-17 11:27:32 -04:00
Charles Kerr
5a76655fb8
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43729 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
2024-09-17 09:00:52 -05:00
Shelley Vohr
aa719a4066
fix: resizing border on Linux WCO caption buttons ( #43724 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
2024-09-17 11:56:43 +02:00
Samuel Attard
c1c8fbfd9a
build: make is_mas_build a generated header instead of config ( #43737 )
2024-09-17 01:38:56 -07:00
dependabot[bot]
b83810982e
build(deps): bump github/codeql-action from 3.26.6 to 3.26.7 ( #43738 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.6 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4dd16135b6...8214744c54 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-16 23:09:24 -05:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
05dfd14913
refactor: add EmitWarning(v8::Isolate*) helper ( #43722 )
...
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-16 15:53:04 -05:00
John Kleinschmidt
7d4f202c1c
ci: move Archaeologist to GHA ( #43701 )
...
* chore: move Archaeologist to GHA
* chore: test archaelogist changes
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a .
* chore: properly name steps in archaeologist-dig
2024-09-16 15:58:51 -04:00
Niklas Wenzel
f84ffc8fc8
fix: prevent loading spinner when launching utility process on Windows ( #43657 )
...
fix: prevent spinning cursor when launching utility process on Windows
2024-09-16 14:20:42 -04:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Charles Kerr
1c3a5ba5d1
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43690 )
...
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-12 15:44:14 -05:00
Piotr Płaczek
29c2744e57
feat: hide menu bar on windows fullscreen ( #43402 )
...
* feat: hide menu bar on windows fullscreen
* test: state prior to html fullscreen transition
* refactor: restore `#ifdef` for readability
Reference: https://github.com/electron/electron/pull/43402#discussion_r1729356262
* docs: menu bar behavior changed
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-12 20:13:04 +02:00
Charles Kerr
3dd7e46291
refactor: avoid minor code repetition in native_image.cc ( #43689 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
2024-09-12 10:56:15 -05:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Shelley Vohr
3c8321a987
fix: EyeDropper working in devtools ( #43685 )
2024-09-12 15:40:56 +02:00
Shelley Vohr
74b54278bf
fix: native View wrapper crash missing when adding child view ( #43638 )
...
fix: native View wrapper crash missing when adding child view
2024-09-12 10:01:05 +02:00
Shelley Vohr
dea6a4e5fb
fix: ensure SetPluginCanSave updated in PDFs ( #43667 )
...
fix: ensure SetPluginCanSave updated in PDFs
2024-09-11 09:25:05 -04:00
Shelley Vohr
90fbf30491
build: compile Node.js with C++20 support ( #43555 )
...
* build: compile with C++20 support
* build: update build-image-sha for gcc 10
2024-09-11 09:01:46 -04:00
dependabot[bot]
5580349c3a
build(deps-dev): bump webpack from 5.76.0 to 5.94.0 in the npm_and_yarn group across 1 directory ( #43659 )
...
build(deps-dev): bump webpack
Bumps the npm_and_yarn group with 1 update in the / directory: [webpack](https://github.com/webpack/webpack ).
Updates `webpack` from 5.76.0 to 5.94.0
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.0...v5.94.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-11 09:56:03 +02:00
Keeley Hammond
309d5dade3
feat: add support for system picker in setDisplayMediaRequestHandler ( #43581 )
...
* tmp
* feat: add support for system picker in setDisplayMediaRequestHandler
* oops
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* stuff
* well...
* seems legit
* chore: update patch to handle screenCapturer
* feat: modify API to use useSystemPicker
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
* fix: don't use native picker with legacy media selection
* chore: code review, boolean set & docs update
* fix: add cancelCallback
* docs: clarify session & desktopCapturer docs
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-09-10 16:05:57 -07:00
Charles Kerr
a3df950281
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() ( #43642 )
2024-09-10 15:05:05 -05:00
Milan Burda
0cc60500ed
fix: restore Chromium default Content-Disposition header parsing ( #43611 )
...
* fix: restore Chromium default Content-Disposition header parsing
* Update api-web-request-spec.ts
2024-09-10 15:32:30 +02:00
Charles Kerr
f1019c2c4a
fix: -Wunsafe-buffer-usage warnings in asar file IO ( #43624 )
...
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()
* fix: -Wunsafe-buffer-usage warnings in Archive::Init()
2024-09-09 16:34:42 -04:00
Charles Kerr
5718ea4e1e
fix: out-of-scope Local handle in node::CallbackScope ( #43622 )
...
refactor: use an EscapableHandleScope
2024-09-09 12:14:40 -05:00
Charles Kerr
2844e346b9
refactor: use std::optional in MicrotasksScope ( #43621 )
...
avoid an unnecessary heap allocation/free
2024-09-09 12:51:42 -04:00
Zorro Liu
e2fe8f50e2
fix: update BrowserView#lastWindowSize after window resize ( #43463 )
...
fix: update BrowserView#lastWindowSize after window resize (#43462 )
2024-09-09 14:22:30 +02:00
Charles Kerr
8c5e7bbf6b
fix: UvHandle move semantics ( #43615 )
...
reassign the uv_handle_t of the source
2024-09-09 14:13:39 +02:00
dependabot[bot]
0d4d752c1b
build(deps): bump the npm_and_yarn group across 2 directories with 3 updates ( #43511 )
...
* build(deps): bump the npm_and_yarn group across 2 directories with 3 updates
Bumps the npm_and_yarn group with 1 update in the / directory: [braces](https://github.com/micromatch/braces ).
Bumps the npm_and_yarn group with 3 updates in the /spec directory: [braces](https://github.com/micromatch/braces ), [pdfjs-dist](https://github.com/mozilla/pdf.js ) and [ws](https://github.com/websockets/ws ).
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
Updates `pdfjs-dist` from 2.16.105 to 4.2.67
- [Release notes](https://github.com/mozilla/pdf.js/releases )
- [Commits](https://github.com/mozilla/pdf.js/compare/v2.16.105...v4.2.67 )
Updates `ws` from 7.5.9 to 7.5.10
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.5.9...7.5.10 )
---
updated-dependencies:
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: braces
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: pdfjs-dist
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: ws
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
* chore: update api-web-contents-spec to us newer version of pdfjs-dist
* test: create fixture to read PDF files for verification
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-09 11:49:43 +02:00
Charles Kerr
0568686340
perf: avoid redundant Promise.GetContext calls ( #43609 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
2024-09-07 23:39:42 -05:00
Charles Kerr
44a4328ea8
refactor: take a uint8_t span in ValidateIntegrityOrDie() ( #43592 )
...
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
2024-09-06 20:22:44 -05:00
Charles Kerr
18b1b33adc
refactor: NativeWindow::Create() returns a unique_ptr ( #43576 )
...
refactor: NativeWindow::Create() returns a unique_ptr
2024-09-06 12:59:32 -04:00
Charles Kerr
fe0d4274e2
fix: confirm a v8::Value is a v8::Object before casting it ( #43575 )
...
fix: confirm a v8::Value is a v8::Object before casting it
2024-09-06 11:20:04 -05:00
Charles Kerr
cc5aa65cb4
fix: delete UvTaskRunner's timers only after they're closed ( #43561 )
...
* fix: free UvTaskRunner timers only after they are closed
* refactor: UvTaskRunner now holds UvHandles
2024-09-06 07:16:56 -05:00
Shelley Vohr
25f4691e78
fix: ensure version of xdg-dialog-portal with defaultPath support ( #43570 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
Closes https://github.com/electron/electron/issues/43310
2024-09-06 11:12:16 +02:00
Charles Kerr
3fde574db1
fix: -Wunsafe-buffer-usage warnings in url-loader ( #43564 )
...
Use v8::ArrayBufferView::CopyContents() instead of doing the pointer
math + memcpy() ourselves. This not only solves the buffer warnings,
but may also avoid some additional overhead:
> Copy the contents of the ArrayBufferView's buffer to an
> embedder defined memory without additional overhead that
> calling ArrayBufferView::Buffer might incur.
2024-09-05 20:22:03 -05:00
Shelley Vohr
eff862b083
build: use proper targets for building ( #43550 )
2024-09-05 17:03:07 -04:00
Kilian Valkhof
32d5f9e3ef
docs: explain ipcRenderer behavior in context-bridge.md ( #43455 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev >
* Update context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Erik Moura <erikian@erikian.dev >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-09-05 16:48:22 -04:00
Orko Garai
69df09dc90
fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland ( #43480 )
...
* fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland
Ensure apps are launched with the activation token received from
xdg_activation_v1 protocol.
* add focus_launched_process option
2024-09-05 13:07:10 -05:00
dependabot[bot]
6aae1264dd
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43530 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184 )
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 11:26:17 -05:00
dependabot[bot]
4b5a831979
build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 ( #43528 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.6 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](834a144ee9...50769540e7 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-05 12:04:52 +02:00
David Sanders
2c3840af76
ci: remove blocked/need-info label on user comment ( #43562 )
2024-09-05 10:12:02 +02:00
John Kleinschmidt
73d480d401
build: fix telemetry error when using autoninja ( #43563 )
2024-09-05 10:08:27 +02:00
Charles Kerr
2d868ecb8d
perf: use v8::Local<v8::Object> as the key in ObjectCache ( #43519 )
...
* perf: use v8::Object* as direct keys instead of using hash + a linked list
* refactor: use v8::Local<v8::Object> as the key
2024-09-04 22:53:06 -05:00
Charles Kerr
0467790aee
chore: migrate to v8::Object::SetPrototypeV2() ( #43535 )
...
chore: migrate to v8::Object::SetPrototypeV2().
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5600627
[api] Mark v8::Object::GetPrototype() for deprecation
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 20:30:54 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final ( #43527 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-04 18:40:02 -05:00
Keeley Hammond
94f2722fa3
build: don't run symbol generation on PS ( #43554 )
...
fix: don't run symbol generation on PS
2024-09-04 17:18:57 +01:00
Charles Kerr
054cbcd6eb
fix: don't use deprecate-soon class v8::String::Value ( #43518 )
...
* fix: remove use of deprecated v8::String::Value
Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.
The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().
Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk
v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)
History on why we used it:
80c1a9739d
f49ed30f72
* Update shell/common/gin_converters/file_path_converter.h
Co-authored-by: Robo <hop2deep@gmail.com >
* fixup! Update shell/common/gin_converters/file_path_converter.h
do not return success for all non-Null non-Strings
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2024-09-04 08:56:14 -05:00
dependabot[bot]
4c83016cf3
build(deps): bump github/codeql-action from 3.26.3 to 3.26.6 ( #43529 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.3 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](883d8588e5...4dd16135b6 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-04 09:35:09 -04:00
Orko Garai
53dcda1fe9
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app ( #43481 )
...
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
2024-09-04 12:54:00 +02:00
George Xu
635d421123
fix: systemMediaPermissionDenied should not check camera perms when the request is asking for screen share ( #43517 )
...
* fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera
* Revert "fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera"
This reverts commit e9cc672165 .
* should only do these checks for audio or video, but not screenshare
* no service
* oops
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-09-04 09:56:26 +01:00
Charles Kerr
b42c0ae00d
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() ( #43477 )
...
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()
* chore: improve code comments for CheckCommandLineArguments()
* chore: reduce diffs from main
* refactor: CheckCommandLineArguments takes a StringVector arg
Fixes another buffer warning!
2024-09-03 21:51:39 -04:00
John Kleinschmidt
90ba2df4fa
build: free up macos disk space as soon as possible ( #43533 )
...
* chore: free up macos disk space as soon as possible
* build: free up disk space on gn check too
2024-09-03 21:32:05 -04:00
John Kleinschmidt
c41a28d7c8
chore: speed up cache only reclient for fork PRs ( #43497 )
2024-08-29 13:51:06 -04:00
Robo
41b8fdca5c
fix: devtools dock state with WCO on linux ( #43490 )
2024-08-29 09:17:00 +09:00
electron-roller[bot]
38512efd25
chore: bump node to v20.17.0 (main) ( #43428 )
...
* chore: bump node in DEPS to v20.17.0
* module: disallow CJS <-> ESM edges in a cycle from require(esm)
https://github.com/nodejs/node/pull/52264
* src: expose LookupAndCompile with parameters
https://github.com/nodejs/node/pull/53886
* src: fix -Wshadow warning
https://github.com/nodejs/node/pull/53885
* lib: convert WeakMaps in cjs loader with symbol properties
https://github.com/nodejs/node/pull/52095
* src: reduce unnecessary serialization of CLI options in C++
https://github.com/nodejs/node/pull/52451
* build: ensure v8_pointer_compression_sandbox is enabled on 64bit
https://github.com/nodejs/node/pull/53884
* lib: improve error message when index not found on cjs
https://github.com/nodejs/node/pull/53859
* src,lib: expose getCategoryEnabledBuffer to use on node.http
https://github.com/nodejs/node/pull/53602
* deps: update c-ares to v1.32.2
https://github.com/nodejs/node/pull/53865
* chore: fixup patch indices
* deps: update V8 to 12.2
https://github.com/nodejs/node/pull/51362
* stream: Expose DuplexPair API
https://github.com/nodejs/node/pull/34111
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-26 15:09:33 -04:00
Charles Kerr
7cea992926
refactor: simplify KeyWeakMap impl ( #43461 )
2024-08-26 13:19:05 -05:00
Charles Kerr
2390706030
refactor: prefer std::ranges over begin() and end() ( #43464 )
2024-08-26 10:58:32 -04:00
David Sanders
56829f75c1
chore: cleanup include groupings ( #43478 )
2024-08-26 10:44:20 -04:00
Charles Kerr
5994b34a5d
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha ( #43448 )
...
added in Aug 2021 (41646d11 , #29600 ) but never used
2024-08-23 20:59:41 -05:00
electron-appveyor-updater[bot]
e6555ac5e1
build: update appveyor image to latest version ( #43451 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-23 18:36:32 -04:00
Charles Kerr
5a1eeea102
perf: prefer GURL string_view getters ( #43443 )
...
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()
* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()
* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()
* refactor: add std::less<> to HandlersMap
This lets us search it using string_view keys
* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view
* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()
* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view
* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
2024-08-23 17:15:45 -05:00
Charles Kerr
7f34b0e6f5
chore: remove unused method asar::ClearArchives() ( #43442 )
...
chore: remove unused asar::ClearArchives()
last use removed in Jun 2021 (b1d1ac65 , #29293 )
2024-08-23 14:53:01 -05:00
John Kleinschmidt
c1eee18e41
test: add -pdf-ready-to-print event to WebContents for testing ( #43436 )
2024-08-23 12:34:26 -05:00
Charles Kerr
9ce0ca74c3
build: remove fix_disable_scope_reuse_associated_dchecks.patch ( #43441 )
...
chore: remove fix_disable_scope_reuse_associated_dchecks.patch
2024-08-23 11:04:20 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43430 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
2024-08-23 11:02:43 -04:00
Shelley Vohr
6e4d90fcdb
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43431 )
...
* fix: ensure bounds stability in OnWidgetBoundsChanged
* Update shell/browser/native_window_views.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-23 11:02:05 -04:00
Erick Zhao
fd8d9f06fd
chore: mention signed commit requirement ( #43406 )
...
chore: mentioned signed commit requirement
2024-08-23 15:52:33 +02:00
Alexander Cyon
ca0837c852
chore: fix typos in 'shell/' folder. ( #43373 )
2024-08-22 19:48:32 -05:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering ( #42953 )
...
* feat: GPU shared texture offscreen rendering
* docs: clarify texture infos that passed by the paint event.
* feat: make gpu osr spec test optional
* fix: osr image compare
* fix: remove duplicate test
* fix: update patch file
* fix: code review
* feat: expose more metadata
* feat: use better switch design
* feat: add warning when user forget to release the texture.
* fix: typo
* chore: update patch
* fix: update patch
* fix: update patch description
* fix: update docs
* fix: apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix: apply suggested fixes
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-22 19:23:13 -05:00
electron-roller[bot]
b481966f02
chore: bump chromium to 130.0.6672.0 (main) ( #43445 )
...
chore: bump chromium in DEPS to 130.0.6672.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-22 18:27:25 -05:00
electron-roller[bot]
baf0182a42
chore: bump chromium to 130.0.6671.0 (main) ( #43429 )
...
* chore: bump chromium in DEPS to 130.0.6671.0
* 5802591: [Partitioned Popins] (6) Add permissions policy for popin
https://chromium-review.googlesource.com/c/chromium/src/+/5802591
* 5794132: [video pip] Move back to tab button to the header
https://chromium-review.googlesource.com/c/chromium/src/+/5794132
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-22 13:16:40 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Shelley Vohr
7391db93e2
build: roll sysroots ( #43261 )
2024-08-22 16:22:12 +02:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors ( #43366 )
...
chore: fix typos in 'docs/' folder.
2024-08-22 15:44:55 +02:00
Alexander Cyon
ae0c8881c3
chore: fix typos in 'spec/' folder (and one in 'lib/' folder) ( #43374 )
2024-08-22 15:44:15 +02:00
Shelley Vohr
4ae43dcb3b
fix: touch bar functionality on BaseWindow ( #43353 )
...
* fix: touch bar functionality on BaseWindow
* test: add test for BaseWindow.setTouchBar
2024-08-22 12:48:25 +02:00
electron-appveyor-updater[bot]
46bed807ca
build: update appveyor image to latest version ( #43369 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-22 10:12:57 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification ( #43377 )
...
* docs: clarify icon value in Notification
* Update docs/api/notification.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-08-21 19:38:06 -05:00
Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace ( #43372 )
2024-08-21 15:26:06 -05:00
electron-roller[bot]
f366caac84
chore: bump chromium to 130.0.6669.0 (main) ( #43397 )
...
* chore: bump chromium in DEPS to 130.0.6669.0
* 5789734: Consolidate all the accessibility scale factor utility code into one file
https://chromium-review.googlesource.com/c/chromium/src/+/5789734
* 5798543: [autofill] Don't emit autofill audit reports if inspector not connected
https://chromium-review.googlesource.com/c/chromium/src/+/5798543
* 5797073: [wasm] Spill all loop inputs before entering loop
https://chromium-review.googlesource.com/c/v8/v8/+/5797073
* chore: fixup patch indices
* 5795224: Version 13.0.0
https://chromium-review.googlesource.com/c/v8/v8/+/5795224
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-21 12:34:18 -04:00
David Sanders
4874233aae
chore: set wg-infra as CODEOWNER for GHA build configs ( #43223 )
...
* chore: set wg-releases as CODEOWNER for GHA build configs
* chore: change to wg-infra
2024-08-21 10:49:22 +02:00
David Sanders
b7af0537c8
docs: update timelines for E33 ( #43389 )
2024-08-20 15:47:32 -07:00
Keeley Hammond
7da9c0b2f7
docs: update window customization tutorial ( #43388 )
2024-08-20 15:29:01 -07:00
Shelley Vohr
46af43db49
chore: cherry-pick 9797576 from v8 ( #43376 )
2024-08-20 16:49:02 -04:00
Charles Kerr
93a6f3e607
refactor: NodeBindings::Create() returns a unique_ptr ( #43361 )
...
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
2024-08-20 15:34:59 -04:00
Charles Kerr
a2de94dda1
chore: remove unused ConvertableToTraceFormatWrapper ( #43356 )
...
* chore: remove unused ConvertableToTraceFormatWrapper
Last use removed in Apr 2024 (39bf441b , #41880 )
* fixup! chore: remove unused ConvertableToTraceFormatWrapper
remove now-unused trace_event.h header, too
2024-08-20 15:21:43 -04:00
electron-roller[bot]
2cc14c6e8f
chore: bump chromium to 129.0.6668.0 (main) ( #43368 )
...
* chore: bump chromium in DEPS to 129.0.6668.0
* 5787687: [Extensions] Remove EventRouterForwarder from BrowserProcess
https://chromium-review.googlesource.com/c/chromium/src/+/5787687
* 5788808: Resolve Blob URL's origin using info from browser process
https://chromium-review.googlesource.com/c/chromium/src/+/5788808
* chore: fixup patch indices
* 5786747: Remove "int WriteFile"
https://chromium-review.googlesource.com/c/chromium/src/+/5786747
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-20 16:54:27 +02:00
dependabot[bot]
945aabfaee
build(deps): bump github/codeql-action from 3.26.0 to 3.26.3 ( #43365 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.0 to 3.26.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](eb055d739a...883d8588e5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-20 13:11:50 +02:00
Charles Kerr
3186c2f0ef
refactor: remove unused SetWMSpecState ( #43347 )
...
last use removed in Aug 2022 by 53cd2315 #35179
2024-08-19 17:15:19 -04:00
Charles Kerr
44e4e4521c
chore: remove unused method Erase() ( #43348 )
...
Last use removed in Mar 2018 by 4b39d17e
2024-08-19 17:14:57 -04:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
electron-roller[bot]
4c3014944c
chore: bump chromium to 129.0.6664.0 (main) ( #43329 )
...
* chore: bump chromium in DEPS to 129.0.6657.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6658.0
* chore: update patches
* 5743786: [ServiceWorker] Populate service worker start token to WorkerId.
https://chromium-review.googlesource.com/c/chromium/src/+/5743786
* 5784424: [Extensions] Move ownership of Dispatcher to ExtensionsRendererClient
https://chromium-review.googlesource.com/c/chromium/src/+/5784424
* chore: bump chromium in DEPS to 129.0.6659.0
* chore: bump chromium in DEPS to 129.0.6660.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6662.0
* chore: bump chromium in DEPS to 129.0.6664.0
* 5789627: [Partitioned Popins] (3) `popin` feature triggers third-party storage partitioning
https://chromium-review.googlesource.com/c/chromium/src/+/5789627
* 5791367: Remove some chrome:: namespace from chrome/browser/app_mode/*
https://chromium-review.googlesource.com/c/chromium/src/+/5791367
* 5791522: [SCK] Skip redundant getShareableContentWithCompletionHandler
https://chromium-review.googlesource.com/c/chromium/src/+/5791522
* 5761330: Send refresh rate prefs b/w RefreshRateController and DisplayPrivate
https://chromium-review.googlesource.com/c/chromium/src/+/5761330
* chore: fixup patch indices
* 5793591: Remove unused GetHeader overload
https://chromium-review.googlesource.com/c/chromium/src/+/5793591
* 5787624: [Extensions] Simplify ExtensionsRendererClient::RenderThreadStarted()
https://chromium-review.googlesource.com/c/chromium/src/+/5787624
* 5721709: Fix Incorrect last_accessed_time Tracking for Tabs
https://chromium-review.googlesource.com/c/chromium/src/+/5721709
* 5789215: [Extensions] Add a //chrome/common/extensions build target
https://chromium-review.googlesource.com/c/chromium/src/+/5789215
* Roll V8 from 48f669a0758c to eee3eb91d01c
48f669a075..eee3eb91d0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-08-19 14:52:53 -04:00
Shelley Vohr
cc16de7032
fix: printing occasionally showing failed when cancelled ( #43337 )
...
Closes https://github.com/electron/electron/issues/36084
2024-08-19 14:25:14 -04:00
Piotr Płaczek
4d51edc504
docs: api history ( #42982 )
...
* feat(api-history): api history schema
Reference: f36e0a8483/text/0004-api-history-schema.md
* feat(api-history): add `lint:api-history` to `package.json`
* docs(api-history): add api history to `styleguide.md`
* docs(api-history): `win.flashFrame(flag)`
* docs(api-history): `new WebContentsView([options])`
* docs(api-history): non-navigation APIs on `WebContents`
* docs(api-history): `nativeImage.toDataURL`
* docs(api-history): `window.flashFrame(bool)`
* docs(api-history): `browser-view.md`
* docs(api-history): `ipcRenderer`
* docs(api-history): `protocol.*Protocol`
* revert: `new WebContentsView([options])`
This reverts commit 0a11efcf57 .
* Apply suggestions from code review
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix(api-history): remove incorrect `pr-url`
Reference: https://github.com/electron/electron/pull/42982/files#r1692532877
* docs(api-history): schema word choice
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Reference: 0b1b6a7cc0
* docs(api-history): nicer format example in `styleguide.md`
Reference: https://github.com/electron/electron/pull/42982#discussion_r1692539906
* docs(api-history): Always use double quotes for descriptions
* docs(api-history): `styleguide.md` improvements
* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`
* docs(api-history): `styleguide.md` placement
* docs(api-history): add migration guide
* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`
Reference: 7b03c0703d (r1703444772)
* docs(api-history): move migration guide
Reference: https://github.com/electron/electron/pull/42982#discussion_r1703441001
* docs(api-history): update `breaking-changer-header`
Reference: https://github.com/electron/electron/pull/43217
* docs(api-history): deprecate `browser-view.md`
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-08-19 11:17:10 -07:00
Calvin
8474bbe689
build: update NMV to 130 for Electron 33 ( #43325 )
2024-08-19 12:47:40 -04:00
Shelley Vohr
3f71ed7355
build: fix valid versions in issue version parsing ( #43346 )
2024-08-19 11:04:30 +02:00
Shelley Vohr
d7689bb9b5
docs: expand dialog window to BaseWindow ( #43334 )
...
docs: expand dialog window to BaseWindow
2024-08-16 10:49:10 -04:00
Shelley Vohr
b497700e36
test: fixup Node.js snapshot tests to run correctly ( #43332 )
2024-08-16 11:17:42 +02:00
electron-appveyor-updater[bot]
1c991ff765
build: update appveyor image to latest version ( #43331 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-15 16:09:47 -04:00
Shelley Vohr
4801a54d08
refactor: migrate deprecated platform_util_mac calls ( #43161 )
...
refactor: migrate deprecated platform_util_mac calls
2024-08-15 10:53:38 -04:00
electron-roller[bot]
a7c52f1fb2
chore: bump chromium to 129.0.6656.0 (main) ( #43323 )
...
* chore: bump chromium in DEPS to 129.0.6656.0
* chore: update patches
* 5750664: Introduce Signin.NumberOfActiveAccounts.* metrics
https://chromium-review.googlesource.com/c/chromium/src/+/5750664
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-14 16:47:37 -04:00
Shelley Vohr
286384258b
fix: blank page when printing pdf ( #43309 )
2024-08-14 15:47:47 -04:00
Shelley Vohr
f6bae51025
build: remove upstreamed DraggableRegions patch ( #43311 )
...
build: remove upstreamed patch
2024-08-14 10:11:02 -04:00
electron-appveyor-updater[bot]
ffcbc32031
build: update appveyor image to latest version ( #43318 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-14 10:10:33 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
David Sanders
62406708cd
docs: fix formatting in fuses tutorial ( #43303 )
2024-08-13 15:27:44 -04:00
electron-roller[bot]
d004329f6f
chore: bump chromium to 129.0.6654.0 (main) ( #43312 )
...
* chore: bump chromium in DEPS to 129.0.6654.0
* chore: update patches
* 5766075: Chromium UI for integration with the MacOS SCContentSharingPicker
https://chromium-review.googlesource.com/c/chromium/src/+/5766075
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-13 15:04:43 -04:00
electron-appveyor-updater[bot]
275b6a13b7
build: update appveyor image to latest version ( #43308 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-13 11:25:05 -04:00
dependabot[bot]
a9e56f2c36
build(deps): bump dsanders11/github-app-commit-action from 1.4.0 to 1.5.0 ( #43305 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](48d2ff8c1a...43de6da2f4 )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-13 15:13:55 +02:00
electron-roller[bot]
bc2628ad7e
chore: bump chromium to 129.0.6652.0 (main) ( #43298 )
...
* chore: bump chromium in DEPS to 129.0.6652.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-08-12 13:47:27 -04:00
Charles Kerr
bba31189a0
feat: accept-encoding zstd ( #43150 )
...
* fix: accept-encoding zstd
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
* chore: make lint happy
---------
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-08-12 10:00:04 -04:00
electron-appveyor-updater[bot]
0f55b45282
build: update appveyor image to latest version ( #43268 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-12 09:32:52 -04:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
electron-roller[bot]
c9b7806418
chore: bump chromium to 129.0.6650.0 (main) ( #43266 )
...
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b6 ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-12 10:28:33 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d3 .
2024-08-12 09:56:51 +02:00
Charles Kerr
bff298987f
chore: remove unused Notification fields icon_path_, has_icon_ ( #43286 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584 )
Last use of `has_icon_` was removed on May 30, 2017 (5048425e )
2024-08-12 09:55:54 +02:00
Shelley Vohr
6d13c503c5
refactor: update chrome.scripting extensions api impls ( #43205 )
2024-08-11 21:31:37 +02:00
Charles Kerr
7721fdf886
chore: remove unused method ElectronDesktopWindowTreeHostLinux::UpdateClientDecorationHints() ( #43283 )
...
Xref: dff980c9c2
Removed in #41868
2024-08-10 18:55:10 -05:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Charles Kerr
c4dfff9844
fix: accidental handle copying in a range loop ( #43260 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
2024-08-09 13:38:03 -05:00
Shelley Vohr
346244ef9e
build: add nacl back to buildtools gitignore ( #43238 )
2024-08-09 19:09:01 +02:00
dependabot[bot]
4edc7a4372
build(deps): bump actions/upload-artifact from 4.3.4 to 4.3.6 ( #43245 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.4 to 4.3.6.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](0b2256b8c0...834a144ee9 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-09 10:43:51 +02:00
Shelley Vohr
f49f6ff68b
fix: check screen capture permissions in desktopCapturer ( #43080 )
...
fix: check screen capture permissions in desktopCapturer
2024-08-09 10:08:49 +02:00
Shelley Vohr
0718c2b9ee
fix: system-context-menu with frameless BrowserWindows ( #43243 )
2024-08-09 10:08:01 +02:00
electron-roller[bot]
1a6563fb66
chore: bump chromium to 129.0.6644.0 (main) ( #43224 )
...
* chore: bump chromium in DEPS to 129.0.6640.0
* chore: update patches
* Reland "DEPS: update ninja to 1.12.1"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5645474
* chore: bump chromium in DEPS to 129.0.6642.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6644.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-08 17:16:59 -05:00
electron-appveyor-updater[bot]
11fdc6f78e
build: update appveyor image to latest version ( #43237 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-08 16:10:16 +02:00
dependabot[bot]
0fcc18359f
build(deps): bump github/codeql-action from 3.25.15 to 3.26.0 ( #43246 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.15 to 3.26.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](afb54ba388...eb055d739a )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-08 16:09:14 +02:00
Shelley Vohr
70dda694e2
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43206 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
2024-08-07 14:51:38 +02:00
David Sanders
aa19087bed
ci: set labels on Dependabot PRs for GitHub Actions deps ( #43222 )
2024-08-07 11:57:40 +02:00
Felix Rieseberg
3fabf7837e
docs: Document ideal iconPath size ( #43149 )
2024-08-07 11:43:05 +02:00
dependabot[bot]
8d5ad8afe1
build(deps): bump mikefarah/yq from 4.44.2 to 4.44.3 ( #43220 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.2 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](f15500b20a...bbdd97482f )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-07 10:02:31 +02:00
Shelley Vohr
45891aa75b
build: fix patchup logic only running on one platform ( #43139 )
2024-08-07 10:01:59 +02:00
Charles Kerr
6293bbced0
perf: avoid redundant calls to GetView() ( #43216 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
Piotr Płaczek
f42331f277
docs: add missing deprecations to breaking-changes.md ( #43217 )
...
* docs: deprecate `BrowserView`
Reference: https://github.com/electron/electron/pull/35658
* docs: deprecate `webContents.goToIndex(index)`
Reference: https://github.com/electron/electron/pull/41752/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6R1165-R1167
* docs: deprecate some protocol methods
Reference: https://github.com/electron/electron/pull/36674/files#diff-74861ecada868821b139e79f244ea32b840a93f60de572d585117a0ff8d165c8R380
2024-08-06 09:07:36 -07:00
electron-roller[bot]
29fd2d343b
chore: bump chromium to 129.0.6638.0 (main) ( #43207 )
...
* chore: bump chromium in DEPS to 129.0.6638.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-08-06 17:43:48 +09:00
electron-appveyor-updater[bot]
c70f86fe03
build: update appveyor image to latest version ( #43204 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-08-05 16:41:40 -04:00
Samuel Attard
701a09d44f
build: use smaller instances for gn-check ( #43187 )
2024-08-05 15:42:41 -04:00
John Kleinschmidt
a4dcb0fb32
build: fixup patches in main ( #43218 )
...
chore: fixup patches in main
2024-08-05 13:51:17 -04:00
David Sanders
acd39bd077
ci: auto label bug issues with platform ( #43198 )
2024-08-05 09:52:49 -04:00
Charles Kerr
3d766e9ccb
perf: don't build unused vectors in HidChooserContext ( #43192 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
* refactor: use structured bindings for readability
2024-08-05 15:31:58 +02:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
Shelley Vohr
e64302cc91
refactor: simplify window moveAbove/moveTop impl on macOS ( #43157 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
2024-08-05 09:57:16 +02:00
Shelley Vohr
2a613cabaa
refactor: migrate electron_login_helper to non-deprecated API ( #43182 )
...
refactor: migrate electron_login_helper to non-deprecated API
2024-08-05 09:56:18 +02:00
Shelley Vohr
78995b956e
fix: potential draggable regions crash in DevTools ( #43179 )
2024-08-05 09:56:08 +02:00
electron-roller[bot]
f508f6b6b5
chore: bump chromium to 129.0.6636.0 (main) ( #43194 )
...
* chore: bump chromium in DEPS to 129.0.6636.0
* chore: e patches all
to make GH actions happy
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 11:36:40 -05:00
electron-roller[bot]
20e77afe0f
chore: bump chromium to 129.0.6634.0 (main) ( #43189 )
...
* chore: bump chromium in DEPS to 129.0.6634.0
* chore: update chore_add_electron_deps_to_gitignores.patch
no manual changes. patch applied with fuzz 1.
* chore: e patches all
* chore: update call to gfx::Image::CreateFrom1xPNGBytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597
The call now takes a base::span
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-08-04 07:31:31 -05:00
Charles Kerr
5a809a6694
refactor: prefer std::ranges over base::ranges ( #43172 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5668999
Xref: https://groups.google.com/a/chromium.org/g/cxx/c/ZnIbkfJ0Glw
2024-08-02 21:21:59 -05:00
Charles Kerr
305b28e9c7
chore: bump chromium to 129.0.6632.0 ( #43184 )
...
* chore: bump chromium in DEPS to 129.0.6632.0
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5755242
* chore: e patches all
2024-08-02 13:58:13 -05:00
Charles Kerr
5b18cc46bc
chore: bump chromium to 129.0.6630.0 (main) ( #43087 )
...
* chore: bump chromium in DEPS to 129.0.6623.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654
* chore: update fix_disable_scope_reuse_associated_dchecks.patch
We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076
* chore: e patches all
* Bump the Chrome macOS deployment target to 11.0
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361
BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0
* src: stop using deprecated fields of `v8::FastApiCallbackOptions`
Xref: d0000b118d
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741336
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199
* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch
chore: re-disable DCHECKs
yep, it is still needed
* refactor use non-deprecated variant of openApplicationAtURL
old version is deprecated now in macOS 11
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl
* chore: bump chromium in DEPS to 129.0.6626.0
* chore: e patches all
* chore: disable NSUserNotification deprecation errors
* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors
Xref: https://github.com/electron/electron/issues/43125
* chore: disable deprecation errors in platform_util_mac.mm
* chore: disable launchApplication deprecation errors
* chore: bump chromium in DEPS to 129.0.6630.0
* chore: update refactor_expose_file_system_access_blocklist.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444
* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch
no manual changes. patch applied with fuzz 1 (offset -5 lines)
* chore: e patches all
* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 09:02:11 -05:00
Tingsong (Terrence) Ou
7c79221a54
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc ( #43129 )
...
fixed electron-fiddle build and config links
2024-08-01 20:28:50 -05:00
Charles Kerr
e7ca92a574
chore: remove unused internal env.unSetVar() ( #43148 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260 , #25623 ) but never used
2024-08-01 18:41:41 -05:00
Shelley Vohr
3a07bd8821
fix: take bluetooth serial ports into account in serial.getPorts() ( #43101 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
* chore: remove port.path.LossyDisplayName()
2024-08-01 11:13:31 -05:00
dependabot[bot]
cc956420ef
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 ( #43094 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7ed )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:47:56 +02:00
cptpcrd
2337d8676d
fix: handle failing to enter fullscreen on macOS ( #43112 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
2024-08-01 12:13:13 +02:00
Charles Kerr
45e5ccc55e
chore: remove unused KeyWeakMap JS bindings ( #43111 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8 #25711 )
- Jun 2020 (e1e73fa5 #24115 )
- Jun 2020 (c0182bca #24116 ).
2024-07-31 16:37:04 -05:00
Charles Kerr
a68a33f036
docs: fix broken link in bug report template ( #43105 )
...
chore: fix broken link in bug report template
2024-07-31 11:45:07 -04:00
Shelley Vohr
791e6df82a
docs: update Node.js stable release policy ( #43100 )
...
* docs: update Node.js stable release policy
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-31 16:33:58 +02:00
dependabot[bot]
283810dbfc
build(deps): bump github/codeql-action from 3.25.13 to 3.25.15 ( #43095 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.13 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](2d790406f5...afb54ba388 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-31 10:00:39 +02:00
Shelley Vohr
ed3242adc1
fix: vibrant view is inserted into Views API hierarchy ( #43078 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-07-30 18:21:20 -05:00
John Kleinschmidt
87fb2ad70c
build: fixup ffmpeg release on x64 macOS ( #43093 )
...
chore: fixup arch on x64 macOS ffmpeg
2024-07-30 16:35:11 -04:00
Charles Kerr
1bcc566ad8
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43090 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a (#26659 )
2024-07-30 15:25:37 -05:00
electron-appveyor-updater[bot]
60bb4a2617
build: update appveyor image to latest version ( #43098 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-30 11:44:18 -04:00
Charles Kerr
47dde3b6e2
chore: remove unused class electron::ObjectLifeMonitor ( #43089 )
...
* chore: remove unused electron::ObjectLifeMonitor
The last users were removed in June 2020 e1e73fa5f (#24115 )
and May 2020 9d7ba982 (#23592 ).
* fixup! chore: remove unused electron::ObjectLifeMonitor
fix: oops
2024-07-30 08:25:28 -05:00
John Kleinschmidt
1a6e651844
test: fixup flaky visibility test ( #43064 )
2024-07-30 09:14:45 -04:00
Shelley Vohr
d09a2e513c
fix: showInactive window not showing ( #43079 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
2024-07-30 12:37:27 +02:00
Charles Kerr
7e9eb9e3f1
perf: avoid duplicate calculations in gin_helper::Dictionary getters ( #43073 )
...
* perf: cache the dictionary handle
* refactor: prefer result.IsJust() over !result.IsNothing()
for consistency
* refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust()
the inlined code is simpler
* refactor: simplify Get() impl
* refactor: add private helper Dictionary::MakeKey()
refactor: add private helper Dictionary::MakeHiddenKey()
2024-07-29 12:43:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
electron-roller[bot]
92496c1930
chore: bump chromium to 129.0.6616.0 (main) ( #43012 )
...
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076
* chore: export patches
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | https://chromium-review.googlesource.com/c/chromium/src/+/5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | https://chromium-review.googlesource.com/c/chromium/src/+/5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | https://chromium-review.googlesource.com/c/chromium/src/+/5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | https://chromium-review.googlesource.com/c/chromium/src/+/5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | https://chromium-review.googlesource.com/c/chromium/src/+/5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-29 09:37:35 -04:00
Alice Zhao
4286234721
fix: redirect webview navigation methods ( #42981 )
2024-07-29 13:00:51 +02:00
Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
2024-07-27 12:25:43 -05:00
Keeley Hammond
8db1563d73
fix: remove InspectableWebContentsViewMac ( #43033 )
...
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93d .
* build: fix gn check
* chore: implement setCornerRadii in inspectable_web_contents_view_mac
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: pass in cornerRadii value in setCornerRadii
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: forward declaration
* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-27 11:44:22 -05:00
electron-roller[bot]
b3d52c01e8
chore: bump node to v20.16.0 (main) ( #43029 )
...
* chore: bump node in DEPS to v20.16.0
* test: skip unstable shadow realm gc tests
https://github.com/nodejs/node/pull/52855
* test: extend env for `test-node-output-errors`
https://github.com/nodejs/node/pull/53535
* src: fix typo in env.cc
https://github.com/nodejs/node/pull/53418
* src: reset `process.versions` during pre-execution
https://github.com/nodejs/node/pull/53444
* chore: fixup patch indices
* src,permission: --allow-wasi & prevent WASI exec
https://github.com/nodejs/node/pull/53124
* tls: use SSL_get_peer_tmp_key
https://github.com/nodejs/node/pull/53366
* deps: update c-ares to 1.29.0
https://github.com/nodejs/node/pull/53155
* src: account for OpenSSL unexpected version
* crypto: fix propagation of "memory limit exceeded"
https://github.com/nodejs/node/pull/53300
* process: add process.getBuiltinModule(id)
https://github.com/nodejs/node/pull/52762
* windows 32bit: config change callback needs to be stdcall
8f265c9d51
* fix: building with UNICODE
https://github.com/c-ares/c-ares/pull/802
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-07-26 12:52:05 -04:00
BILL SHEN
77ba40bc01
chore: avoid crash while notification removal ( #43040 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
* fix notification removal crash due to the nullptr presenter
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-07-26 15:34:40 +02:00
Keeley Hammond
2fd04a78a1
fix: revert BrowserWindow unresponsive handling refactor ( #43034 )
...
* Revert "refactor: JSify BrowserWindow unresponsive handling (#37902 )"
This reverts commit 67ba30402b .
* chore: remove BrowserWindow::SetTitleBarOverlay
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-25 13:02:02 -07:00
electron-appveyor-updater[bot]
0886d2f50f
build: update appveyor image to latest version ( #43021 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-25 15:21:02 -04:00
Charles Kerr
660872c048
refactor: move safe_storage functions into anonymous namespace ( #43032 )
2024-07-25 13:18:13 -05:00
Shelley Vohr
976f5d1b75
fix: File System API permissions should reset on WebContents destruction ( #43009 )
...
fix: active File System API permissions should reset on WebContents destruction
2024-07-25 09:53:30 -04:00
Charles Kerr
aa23198ad8
chore: remove more unused #include calls ( #43000 )
...
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b (##41610)
* chore: iwyu electron/fuses.h
* chore: iwyu media/base/video_frame.h
* chore: iwyu base/functional/callback.h
* chore: iwyu base/task/cancelable_task_tracker.h
* chore: iwyu shell/browser/draggable_region_provider.h
* chore: iwyu shell/browser/ui/inspectable_web_contents_view.h
* chore: iwyu ui/aura/window.h
* chore: iwyu ui/base/win/shell.h
* chore: iwyu ui/display/win/screen_win.h
* chore: iwyu ui/gfx/geometry/insets.h
* chore: iwyu ui/display/display.h
* chore: iwyu ui/gfx/geometry/skia_conversions.h
* chore: iwyu ui/gfx/geometry/rect_conversions.h
* chore: iwyu ui/gfx/geometry/point.h
* chore: iwyu ui/gfx/scoped_canvas.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu ui/accessibility/ax_node_data.h
* chore: iwyu ui/views/animation/ink_drop_highlight.h
* chore: iwyu ui/gfx/font_list.h
* chore: iwyu ui/linux/nav_button_provider.h
* chore: iwyu shell/browser/ui/views/frameless_view.h
* chore: iwyu services/metrics/public/cpp/ukm_source_id.h
* chore: iwyu net/http/http_util.h
* chore: iwyu net/base/mime_util.h
* chore: iwyu content/public/common/content_client.h
* chore: iwyu <list>
* chore: iwyu <optional>
* chore: iwyu <memory>
* chore: iwyu base/files/file_path.h
* chore: iwyu ui/base/cursor/cursor.h
* chore: iwyu build/build_config.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/hid/hid_chooser_context.h
* chore: iwyu shell/common/platform_util.h
* chore: iwyu base/task/single_thread_task_runner.h
* chore: iwyu content/browser/renderer_host/render_widget_host_impl.h
* chore: iwyu content/public/browser/render_widget_host.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu content/public/browser/web_contents_observer.h
* chore: iwyu content/public/browser/render_frame_host.h
* chore: iwyu content/public/browser/media_stream_request.h
* chore: iwyu chrome/common/chrome_paths.h
* chore: iwyu chrome/browser/icon_manager.h
* chore: iwyu printing/print_settings.h
* chore: iwyu renderer/pepper_helper.h
* chore: iwyu shell/browser/api/process_metric.h
* chore: iwyu shell/browser/electron_browser_client.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu shell/browser/api/electron_api_session.h
* chore: iwyu shell/browser/api/electron_api_app.h
* chore: iwyu shell/browser/ui/views/client_frame_view_linux.h
* chore: iwyu shell/browser/native_window_views.h
* chore: iwyu base/win/windows_version.h
* chore: iwyu shell/common/electron_paths.h
* chore: iwyu content/public/common/content_switches.h
* chore: iwyu third_party/skia/include/core/SkRRect.h
* chore: iwyu third_party/skia/include/core/SkBitmap.h
* chore: iwyu third_party/skia
* chore: iwyu shell/browser/osr/osr_host_display_client.h
* chore: iwyu shell/browser/login_handler.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu shell/browser/event_emitter_mixin.h
* fix: mac
* fix: mac
* chore: iwyu base/nix/xdg_util.h
* fix: win
* fix: win
* fix: win
* fix: win
2024-07-25 11:25:45 +02:00
Shelley Vohr
cfdcf48e1b
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43013 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
* test: oops fix showing
2024-07-25 11:17:37 +02:00
David Sanders
c2c079dc82
build: update docs-parser and typescript-definitions packages ( #43038 )
...
build: update docs-parser and typescript-definitions pacakges
2024-07-25 11:00:32 +02:00
David Sanders
f979d4c742
test: add test for nodeCliInspect fuse ( #43035 )
2024-07-25 11:00:02 +02:00
Charles Kerr
df524c6eca
chore: use v8::Local<>, not v8::Handle<> ( #43019 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
2024-07-24 18:24:07 -05:00
Shelley Vohr
5669a40d5c
feat: add transparency checking to nativeTheme ( #42862 )
...
* feat: add transparency checking to nativeTheme
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870
* chore: deprecate previous function
* chore: fix lint
2024-07-24 14:38:22 +02:00
Shelley Vohr
9fc760bc4c
docs: note macOS fullscreen events in fullscreen query ( #42997 )
...
docs: note macOS fullscreen events in fs query
2024-07-23 16:40:59 -04:00
electron-roller[bot]
3e22f992b0
chore: bump chromium to 128.0.6611.0 (main) ( #42779 )
...
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
2024-07-23 08:59:44 -07:00
dependabot[bot]
364631ee0b
build(deps): bump github/codeql-action from 3.25.12 to 3.25.13 ( #42999 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.12 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4fa2a79536...2d790406f5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 12:38:02 +02:00
Shelley Vohr
3c9d4452c6
docs: improve desktop capture example ( #42957 )
2024-07-23 11:55:23 +02:00
dependabot[bot]
daa8244cdf
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42998 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.3...0b2256b8c012f0828dc542b3febcab082c67f72b )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-23 10:18:36 +02:00
Shelley Vohr
8454f4e49f
feat: emit an event when accessing restricted path in File System Access API ( #42561 )
...
* fix: show a dialog when accessing restricted path in File System Access API
* fix: allow overriding initial blocked paths
* docs: fix doc
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: change block to deny for consistency
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-22 12:18:15 +02:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
David Sanders
296a558c32
build: update @electron/lint-roller to 2.3.0 ( #42950 )
2024-07-22 10:45:49 +02:00
Charles Kerr
780677e00f
chore: remove unused BaseWindow::GetWeakPtr() ( #42973 )
...
last caller removed in 67ba3040 (#37902 )
2024-07-22 10:44:34 +02:00
Charles Kerr
8c8a7709e6
chore: remove unused WrappableBase::AfterInit() ( #42974 )
...
last caller removed in 6159066c (#22916 )
2024-07-22 10:44:21 +02:00
Charles Kerr
c72a714dd5
refactor: remove WindowListObserver::OnWindowAdded() ( #42979 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
2024-07-22 10:44:08 +02:00
Charles Kerr
7a101a1c4b
refactor: remove unused web contents preferences methods ( #42947 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c
* chore: remove unused WebContentsPreferences::GetSafeDialogsMessage()
caller removed in 85bc005c
* refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath>
* refactor: make WebContentsPreferences::last_preference() const
2024-07-19 12:26:57 -05:00
Charles Kerr
5b7ed6097e
chore: remove unused typedef CreateDownloadPathCallback ( #42949 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
2024-07-19 11:49:58 -05:00
Charles Kerr
32a74b0942
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42956 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
2024-07-19 11:48:52 -05:00
Charles Kerr
5773a2dce6
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42933 )
2024-07-17 23:30:09 -05:00
Charles Kerr
bc345db351
fix: dangling raw_ptr<views::View> in api::View ( #42929 )
2024-07-17 21:31:48 -05:00
David Sanders
ce45450c28
ci: refactor non-maintainer lockfile change check to request changes ( #42855 )
2024-07-17 12:28:08 -07:00
arno renevier
81bdba67ec
feat: Implement password delegate for NSS ( #41205 )
...
* feat: Implement password delegate for NSS (#41188 )
Introduce an app event client-certificate-request-password. It allows
the user to display a UI to prompt for the password.
An alternative would have been to implement a class similar to
CryptoModulePasswordDialogView, to provide the UI. This might have been
simpler for the user, comparing to letting them implement the UI. But it
seems like electron does not have an i18n framework, so it's not
possible to provide a locale aware UI.
* fix lint:markdown error
* address review comments
* use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler
* use properties on the Event object instead of positional parameters
* remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_)
* address review comments second round
- backslash escape parametrized TypeScript
- rename hostName param to hostname
- use base::ScopedAllowBaseSyncPrimitivesForTesting
- and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate
* Update docs/api/app.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/app.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Arno Renevier <arnaud@switchboard.app >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-07-17 09:48:03 -04:00
dependabot[bot]
c210ae9b33
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #42831 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:41 +02:00
dependabot[bot]
734ba50ee1
build(deps): bump amannn/action-semantic-pull-request from 5.5.2 to 5.5.3 ( #42834 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.2 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](cfb60706e1...0723387faa )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 15:18:33 +02:00
wujinli
9023707b9b
fix: crash with creating OffScreenWebContentsView ( #42920 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
2024-07-17 13:09:32 +02:00
dependabot[bot]
2875fab452
build(deps): bump actions/setup-node from 4.0.2 to 4.0.3 ( #42917 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...1e60f620b9 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-17 11:36:52 +02:00
Shelley Vohr
fd907bc0a3
fix: getUserMedia needs macOS system permissions check ( #42899 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
2024-07-17 11:30:05 +02:00
Sam Maddock
c7709747d0
ci: upload test artifacts ( #42925 )
...
* Upload test-artifacts directory
* Rename test artifacts directory to avoid conflicts
* Update .gitignore
* Upload test artifacts
* Update .gitignore
* Update move-artifacts.sh
* Update artifacts.ts
* Update pipeline-segment-electron-test.yml
* Make output less noisy
* reduce artifact image size
2024-07-16 22:56:56 -07:00
Sam Maddock
778d3098a0
feat: customize border radius of Views ( #42320 )
...
* feat: add View#setBorderRadius
test: initial setBorderRadius tests
fix: robustly set border radius
chore: add PAUSE_CAPTURE_TESTS for easier screencap dev
feat: add view border radius support
test: view border radius
refactor: cleanup view code
* maybe delay capture to fix tests?
* refactor: retry screen captures in an attempt to fix flakiness
* refactor: ScreenCapture constructor no longer async
* increase screen capture timeout, feels a little short
* refactor: move rounded rect util into chromium_src
* skip some capture tests on mas
2024-07-16 20:16:25 -04:00
Shelley Vohr
cbd11bb605
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42824 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
2024-07-16 20:11:49 +02:00
Calvin
81351dd1a9
build: fix clang format location helper (again) ( #42911 )
2024-07-16 11:21:18 -04:00
dependabot[bot]
f575e52586
build(deps): bump github/codeql-action from 3.25.11 to 3.25.12 ( #42916 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.11 to 3.25.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b611370bb5...4fa2a79536 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-16 11:25:42 +02:00
Theo Gravity
bab3fcc9ab
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42805 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
2024-07-15 19:32:44 -04:00
David Sanders
0fddfd1b28
ci: auto comment on new issues for unsupported majors ( #42856 )
2024-07-15 15:25:47 -04:00
Keeley Hammond
c006e129b3
build: remove CircleCI ( #42844 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
2024-07-15 14:26:41 -04:00
reito
f173a0637a
chore: fix npm run lint not working on Windows ( #42281 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-07-15 18:08:33 +02:00
Shelley Vohr
ae1a684d10
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42851 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
2024-07-15 10:41:38 -04:00
Robo
1e1dc22e16
fix: crash when resolving proxy due to network service restart ( #42878 )
2024-07-15 17:46:24 +09:00
Shelley Vohr
bbd7f4a5ad
fix: File System Access API should remember last picked directory ( #42850 )
2024-07-14 18:43:37 +02:00
Calvin
493bc3ac9d
fix: desktopCapturer and screen display ids should match ( #42883 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
* simplify wide-to-utf8 conversion
* remove unnecessary include
2024-07-14 09:51:57 +02:00
John Kleinschmidt
3a6a201534
build: fixup GHA running on fork PRs ( #42880 )
...
* chore: update build-tools for GHA
* chore: don't rely on environment variables for source cache location
2024-07-13 13:38:03 -04:00
Samuel Attard
53d7cca7a2
build: use new arc runner names ( #42881 )
2024-07-12 22:22:49 -07:00
David Sanders
7dd6d7697d
chore: allow multiple OS selection on bug reports ( #42854 )
2024-07-11 13:23:43 -07:00
John Kleinschmidt
514e9bbb04
build: update build-tools for GHA ( #42870 )
...
chore: update build-tools for GHA
2024-07-11 16:18:26 -04:00
Shelley Vohr
dab006b1cf
ci: fix Nan test failure on Linux ( #42863 )
...
ci: Nan test failure on Linux
2024-07-11 10:47:02 -04:00
Shelley Vohr
4e10eeb87e
fix: desktopCapturer and screen source ids should match screen ids ( #42781 )
...
* fix: desktopCapturer screen source ids should match screen ids
* test: add a regression test
2024-07-10 16:32:29 -07:00
Shelley Vohr
fa6ce4f0f8
fix: High Contrast mode not working on Windows ( #42853 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
2024-07-10 15:14:02 -07:00
Charles Kerr
f9d94211bb
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener ( #42806 )
...
All the listener functions are empty stubs (and have been since d4e3c39 )
so it doesn't seem like we need a listener?
SpeechRecognitionManagerDelegate declares this method:
> // Checks whether the delegate is interested (returning a non nullptr
> // ptr) or not (returning nullptr) in receiving a copy of all sessions
> // events. This is called on the IO thread.
> virtual SpeechRecognitionEventListener* GetEventListener() = 0;
This PR has ElectronSpeechRecognitionManagerDelegate stop subclassing
from the Listener and changes GetEventListener() to return nullptr.
2024-07-10 15:32:50 +02:00
electron-roller[bot]
48fc352bcf
chore: bump node to v20.15.1 (main) ( #42841 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-10 14:52:06 +02:00
John Kleinschmidt
1a9f99b3ed
chore: speed up azcopy on src cache ( #42742 )
2024-07-09 16:20:18 -04:00
dependabot[bot]
34e7648478
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11 ( #42832 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](23acc5c183...b611370bb5 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:27:37 +02:00
dependabot[bot]
c2ea3881fc
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42833 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-09 11:25:07 +02:00
David Sanders
170b72ccfa
ci: fix CircleCI config ( #42829 )
...
* ci: fix CircleCI config
* ci: fix syntax error
2024-07-08 21:38:05 -04:00
Shelley Vohr
e54ffdf7ed
build: clean up BoringSSL patch ( #42730 )
2024-07-08 16:35:54 -04:00
Charles Kerr
e9db02948e
fix: multiple move() calls on the same unique_ptr ( #42788 )
2024-07-08 11:04:35 -04:00
Charles Kerr
27e3273f0a
refactor: minor electron browser context cleanup ( #42789 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
* refactor: remove unused forward declarations of v8 classes
* chore: forward declare gin::Arguments
* refactor: use unique_ptr operator bool
2024-07-08 16:49:41 +02:00
electron-appveyor-updater[bot]
e99e554655
build: update appveyor image to latest version ( #42771 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-08 12:56:52 +02:00
Charles Kerr
5ff91159cd
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42785 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
2024-07-08 12:56:03 +02:00
Charles Kerr
e89da2bad2
fix: dangling raw_ptr<Session> in UserDataLink ( #42786 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
* chore: make linter happy
2024-07-08 12:55:48 +02:00
Shelley Vohr
cb2e7f130b
fix: potentially closed webContents in BrowserView ( #42633 )
2024-07-08 12:13:53 +02:00
Shelley Vohr
2f4a46f47a
fix: video and audio capture should be separate ( #42775 )
2024-07-08 10:11:40 +02:00
Shelley Vohr
ac074a5548
refactor: run Windows SelectFileDialog out of process ( #42758 )
...
* refactor: run Windows SelectFileDialog out of process
* fix: add missing IS_WIN guard
* refactor: use upstream SelectFileDialogFactory
* fix: build chrome/services/util_win/public/mojom target
2024-07-05 11:36:44 +02:00
electron-roller[bot]
19e030a6e8
chore: bump chromium to 128.0.6573.0 (main) ( #42766 )
...
* chore: bump chromium in DEPS to 128.0.6573.0
* chore: update patches
* 5665092: Remove default arguments on virtual functions in WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/5665092
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-05 09:51:21 +02:00
Shelley Vohr
5bff883c40
chore: clean up outdated goma references ( #42762 )
2024-07-05 09:44:34 +02:00
Shelley Vohr
25eb1bd4b2
build: remove all publish & build on macOS ( #42763 )
2024-07-03 15:17:17 -04:00
electron-roller[bot]
07e6b34a07
chore: bump chromium to 128.0.6571.0 (main) ( #42749 )
...
* chore: bump chromium in DEPS to 128.0.6571.0
* 5636652: [4/n] Introduce RenderInputRouterClient and move InputRouterClient implementation to RenderInputRouter.
https://chromium-review.googlesource.com/c/chromium/src/+/5636652
* 5655811: Revert "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"""
https://chromium-review.googlesource.com/c/chromium/src/+/5655811
* 5581006: [tracing] Forward startup tracing config as shmem
https://chromium-review.googlesource.com/c/chromium/src/+/5581006
* chore: fixup patch indices
* 5608450: [Views AX] Move Image Auto Captioning strings to ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5608450
* 5648900: [Extensions] Move ExtensionAPIEnabledForServiceWorkerScript()
https://chromium-review.googlesource.com/c/chromium/src/+/5648900
* 5651681: Remove Web Speech API profanity masking
https://chromium-review.googlesource.com/c/chromium/src/+/5651681
* 5651361: `content::RenderFrame::GetBrowserInterfaceBroker`: return a const-ref.
https://chromium-review.googlesource.com/c/chromium/src/+/5651361
* 5604943: Start capture of toolbar after gesture end events are received
https://chromium-review.googlesource.com/c/chromium/src/+/5604943
* 5624392: [BRP] Enforce raw_ptr/ref in Renderer code
https://chromium-review.googlesource.com/c/chromium/src/+/5624392
* 5659259: Portals: Remove WebContentsView::TransferDragSecurityInfo
https://chromium-review.googlesource.com/c/chromium/src/+/5659259
* 5230721: Move ComposeStatus to components/compose
https://chromium-review.googlesource.com/c/chromium/src/+/5230721
* 5647894: [api] Cleanup usages of v8::ReturnValue<void>::Set[NonEmpty](..)
https://chromium-review.googlesource.com/c/v8/v8/+/5647894
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-03 11:15:35 -04:00
Charles Kerr
cf5fb4505e
refactor: make session::browser_context_ a const raw_ref ( #42728 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-07-02 17:53:36 -04:00
Erick Zhao
0a8eae9019
docs(autoUpdater): document static storage strategy ( #42690 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
2024-07-02 19:06:38 +02:00
Erick Zhao
6cca75ac76
docs(autoUpdater): signing is only a pre-req on macOS ( #42709 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
2024-07-02 19:06:25 +02:00
electron-appveyor-updater[bot]
67d7944271
build: update appveyor image to latest version ( #42748 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-02 10:38:43 -04:00
Shelley Vohr
1729a9868c
fix: use BlockedRequest struct to handle webRequest data ( #42647 )
...
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.
This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33d .
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Alice Zhao <alice@makenotion.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-07-02 09:51:33 +02:00
Anny Yang
14303a0a71
docs: grammar fix in isBeingCaptured docs ( #42692 )
2024-07-01 15:01:27 -04:00
Chris Stringer
2b5342cb49
docs - Update net.md ( #42691 )
...
Update net.md
Changes heading level for net.resolveHost() entry to H3
2024-07-01 14:45:49 -04:00
Alice Zhao
e9a93a8c5c
fix: setTopBrowserView focus issue with reordering ( #42653 )
...
* fix: reorder top browser view instead of adding/removing
* fix: update browserViews order
* test: add a test for setTopBrowserView
2024-07-01 11:36:04 +02:00
Keeley Hammond
efff369639
build: remove MacOS x64 from CircleCI ( #42718 )
2024-07-01 11:34:37 +02:00
Keeley Hammond
3ac57e17d5
build: fix clang format/lint ( #42715 )
...
* build: fix clang format path
* fix: use gclient sync instead of gclient runhooks
Refs https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5659261
* fix: use gclient sync instead of gclient runhooks in GHA
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-06-28 13:30:07 -07:00
Shelley Vohr
398dde9dfb
build: use inputs for target_arch in build ( #42684 )
2024-06-27 08:11:10 -07:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
David Sanders
1d4b00692d
build: bump version in .nvmrc to 20 ( #42668 )
2024-06-27 13:46:11 +02:00
electron-roller[bot]
ec24b51808
chore: bump node to v20.15.0 (main) ( #42616 )
...
* chore: bump node in DEPS to v20.15.0
* doc: Add OpenSSL errors to API docs
https://github.com/nodejs/node/pull/34213
* test: crypto-rsa-dsa testing for dynamic openssl
https://github.com/nodejs/node/pull/52781
* src: allow preventing debug signal handler start
https://github.com/nodejs/node/pull/46681
* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler
https://github.com/nodejs/node/pull/52766
* chore: fixup indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-27 13:34:39 +02:00
Shelley Vohr
c628de52d9
fix: defaultPath should apply on all dialog types in Linux Portal ( #42655 )
...
fix: defaultPath should apply on all dialog types in Linux Portal dialogs
2024-06-27 11:07:26 +02:00
Shelley Vohr
2b31d8459d
fix: param passed to showSaveDialogSync on Linux ( #42652 )
...
fix: pass correct param to sync functions on Linux
2024-06-27 10:23:18 +02:00
Keeley Hammond
912706b23a
build: strip linux release binaries ( #42675 )
2024-06-26 17:41:36 -07:00
Samuel Attard
b31acfb706
docs: clarify security semantics of safeStorage ( #42666 )
...
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-06-26 13:24:06 -07:00
Shelley Vohr
607b9b8f11
build: clean up upload-index-json error handling ( #42657 )
2024-06-26 09:25:58 -07:00
Keeley Hammond
a8baa6f1ad
build: remove CircleCI from release pipeline ( #42651 )
...
* build: remove CircleCI from release pipeline
* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
2024-06-25 14:25:04 -07:00
Shelley Vohr
3534923bd2
build: account for subjectAndDescription null in patch linting ( #42636 )
...
fix: account for subjectAndDescription null in patch linting
2024-06-24 22:32:43 -07:00
Keeley Hammond
66b8b79229
build: turn on GitHub Actions by default for all branches and pull requests ( #42623 )
...
* build: turn GitHub Actions on by default for push and pull_request
* build: try env var build-image-sha
* build: use ternery for input vs default
* build: pain
* build: modify setup to cascade build-image-sha
* build: move outputs into setup step
* build: add SAS key generation on re-run
* build: only build on push, not pull_request
* build: only build on push for main & release branches, build on PR for everything else
* build: rebase with main, handle asan build
* build: add exit 1, sha value
2024-06-24 12:06:13 +02:00
Corbin Crutchley
243be0a638
docs: fix typo in ASAR integrity docs ( #42538 )
...
Fix typo in ASAR integrity docs
2024-06-22 20:26:23 +02:00
Charles Kerr
24d6c28b5a
chore: remove walkdir dev dependency ( #42591 )
2024-06-21 10:31:10 -04:00
George Xu
ba8ad4716b
feat: expose system preferences to utility process ( #42203 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
2024-06-20 11:15:57 -04:00
Shelley Vohr
37608933ae
fix: fetch-dependent interfaces in Web Workers ( #42579 )
2024-06-20 11:01:50 -04:00
Keeley Hammond
edb939ae80
build: Add ASan Linux build to Actions build/test ( #42545 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-20 12:11:53 +02:00
Milan Burda
003c32331d
chore: add/fix interface comments for sections of methods ( #42566 )
2024-06-20 10:49:07 +02:00
Shelley Vohr
18abeb3add
build: re-enable self-cert codesigning on x64 macOS ( #42576 )
...
build: re-enable self-cert codesigning
2024-06-19 10:28:07 -04:00
Charles Kerr
dad6e130f5
build: remove fs-extra devdep ( #42533 )
...
* build: remove fs-extra dependency from script/gen-filenames.ts
* build: remove fs-extra dependency from script/spec-runner.js
* build: remove fs-extra dependency from script/gn-asar.js
* build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts
* build: remove fs-extra dependency from spec/api-safe-storage-spec.ts
* build: remove fs-extra dependency from spec/lib/codesign-helpers.ts
* build: remove fs-extra dependency from spec/api-app-spec.ts
* build: remove fs-extra dependency from spec/esm-spec.ts
* build: remove fs-extra dependency from spec/lib/fs-helpers.ts
* build: remove fs-extra dependency from spec/lib/api-shell-spec.ts
* build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* build: remove fs-extra dependency from spec/asar-integrity-spec.ts
* build: remove fs-extra dependency from spec/node-spec.ts
* build: remove fs-extra devdiv
* fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* fix: use force: true when removing directories
* chore: reduce diffs to main
2024-06-19 10:10:16 -04:00
Shelley Vohr
8e8ea3ee8b
fix: MessagePort closing unexpectedly with non-cloneable objects ( #42535 )
...
* fix: MessagePort closing unexpectedly with non-cloneable objects
* fix: handle serialization failure in parentPort
2024-06-19 11:27:07 +02:00
Keeley Hammond
6d2c72b14e
build: correct GCLIENT_EXTRA_ARGS in linux-publish ( #42575 )
2024-06-18 21:54:20 -07:00
Charles Kerr
980e884fa5
build: remove klaw dependency ( #42529 )
...
* refactor: remove klaw dependency
Node 20 added recursive readdir() so klaw is not needed
* fixup! refactor: remove klaw dependency
findMatchingFiles returns a Promise<string[]>
2024-06-18 18:54:26 -04:00
Keeley Hammond
71338140a4
build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release ( #42571 )
...
* build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release
* build: move to GN_EXTRA_ARGS, remove GN_BUILDFLAG_ARGS
2024-06-18 14:03:53 -07:00
David Sanders
2e4857fbcb
ci: auto close non-maintainer PRs that touch lockfiles ( #42534 )
2024-06-18 15:30:08 -04:00
Robo
29b8fbf419
chore: cherry-pick f8010390 from chromium ( #42559 )
2024-06-19 01:28:51 +09:00
dependabot[bot]
540a42fb96
build(deps): bump github/codeql-action from 3.25.7 to 3.25.10 ( #42540 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.7 to 3.25.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f079b84933...23acc5c183 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-18 12:14:56 +02:00
dependabot[bot]
b8512a0cd9
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #42539 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a5ac7e51b4...692973e3d9 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-18 12:14:15 +02:00
Shelley Vohr
86cf60c3f1
chore: improve error message on failed SMApp register/unregister ( #42526 )
2024-06-18 10:51:37 +02:00
Samuel Attard
e217b063a5
build: fix nan/node tests on GHA ( #42548 )
2024-06-18 10:49:39 +02:00
John Kleinschmidt
ae88e64c88
test: use longer timeout on contentTracing tests on WOA ( #42537 )
2024-06-18 10:37:18 +02:00
David Sanders
6d4c2057e4
docs: add backticks around example URL ( #42536 )
2024-06-17 16:35:26 -07:00
dependabot[bot]
db9742a1ff
build(deps): bump mikefarah/yq from 4.44.1 to 4.44.2 ( #42541 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.1 to 4.44.2.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](557dcb87b8...f15500b20a )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-17 16:34:32 -07:00
Samuel Attard
a0a13ad623
build: fix macOS tests on GHA ( #42524 )
...
* build: use --frozen-lockfile
* build: don't include src/electron in src artifacts
* Use mac intel runner for mac-x64 tests
* test: debug mac tests not exiting
* skip navigator.serial tests on GHA
* TCC magic
* Fix release notes tests needing ELECTRON_GITHUB_TOKEN
* Add Azure env vars to gn check pipeline segment
* use RO token for tests
* temporarily disable codesign tests
* test: disable LoginItemSettings on x64 macOS
* test: bump up time on protocol test for slower machines
* fixup: use RO token for tests
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-17 16:33:44 -07:00
Shelley Vohr
b35adaee2d
build: fix clang format location helper ( #42527 )
2024-06-17 19:47:59 +02:00
Shelley Vohr
1a4d58a9fb
build: run GN Check everywhere ( #42515 )
...
* build: run GN Check everywhere
* build: remove gn check matrix
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2024-06-17 08:58:29 -07:00
Samuel Attard
2b259bd69e
build: de-dupe load build tools into composite action ( #42518 )
2024-06-17 11:26:18 +02:00
Samuel Attard
a371c2cd54
build: fix GHA arm tests ( #42514 )
2024-06-16 10:59:51 -07:00
Shelley Vohr
6bf83b389b
build: add GN check step ( #42508 )
...
* build: add GN check step
* Remove extra loggin
* Fix BUILD_TOOLS_SHA
* Fix concurrency group naming
2024-06-14 15:29:11 -05:00
Samuel Attard
2c985366c8
build: fix dubious ownership error in version bumper spec ( #42509 )
2024-06-14 13:47:58 -05:00
Keeley Hammond
429d50bb18
build: add production-release environment to publish jobs ( #42483 )
...
* build: move publish workflows to use production environment
* build: pass in target_cpu to GN_EXTRA_ARGS on Linux
2024-06-14 11:14:38 -05:00
Keeley Hammond
5b98be3ccb
build: add docs-only path gating to GHA ( #42499 )
...
* build: add docs only workflow
* build: add path filtering action
* build: add actions/checkout
* build: explicitly set shell to bash -_-
* build: why regex when you could do something much dumber
* build: correct conditionals
* test: (do not merge) add base for testing
* test: remove git base (used for testing)
2024-06-14 11:08:41 -05:00
John Kleinschmidt
5397560ab3
build: adjust concurrency for release branches ( #42507 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-14 11:08:21 -05:00
Samuel Attard
c2c3673e8a
build: fix linux tests ( #42496 )
...
* build: use runuser for electron spec runner
* chown
* run tests in priv
* fixed
* build: setup testing on arm for GHA
* no build-tools for test
* start xvfb for the right user
* no more gn-build-type
* debug env
* ue xvfb-run
* use 8 core for node tests
* build: do test sharding on linux
* fix: disable hung node test
* build: index splits are hard
* build: use --init to reap children
* allow write junit
* use custom xvfb wrapper
* pipefail
* dont kill xvfb, its already dead
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-06-14 10:57:28 -05:00
Shelley Vohr
c1094013eb
build: allow running only mac, lint, or linux ( #42504 )
...
build: allow running only mac or linux
2024-06-14 10:08:04 -05:00
Keeley Hammond
8650682c5b
build: revert removal of CIPD patch from depot tools ( #42500 )
...
Revert "build: remove the CIPD patch from depot tools (#42484 )"
This reverts commit a0a8bd2222 .
2024-06-14 09:11:30 -05:00
Shelley Vohr
422511753f
build: use BUILD_TYPE from env ( #42498 )
...
build: use BUILD_TYPE from env
2024-06-14 06:47:18 -05:00
Samuel Attard
9f862af743
build: add lint GHA job ( #42494 )
2024-06-13 22:14:49 -05:00
John Kleinschmidt
16b2a09787
build: only load SDK for mac builds ( #42485 )
2024-06-13 17:49:38 -05:00
Keeley Hammond
ad8e89de01
build: fix v8 toolchain for macOS x64 ( #42492 )
...
build: do better
2024-06-13 17:14:57 -05:00
Samuel Attard
b7aad14e8d
build: run gha on tag not branch ( #42490 )
2024-06-13 17:14:45 -05:00
Keeley Hammond
c41ded2e89
build: remove gclient-extra-args from publish jobs ( #42491 )
...
build: remove gclient-extra-args from publish ymls
2024-06-13 17:11:47 -05:00
Keeley Hammond
4701795dc0
build: fix datetime module for Linux Publish ( #42489 )
2024-06-13 16:36:45 -05:00
Samuel Attard
cfdc623c4d
build: pin and dedupe build image sha ( #42488 )
2024-06-13 16:35:47 -05:00
Keeley Hammond
9e066e7b74
build: add v8_toolchain to darwin/x64 ( #42487 )
...
build: add v8_toolchain to darwin/x64
2024-06-13 16:35:20 -05:00
Shelley Vohr
9fe1b05025
build: upload separate artifact for src files ( #42486 )
2024-06-13 16:35:13 -05:00
Keeley Hammond
a0a8bd2222
build: remove the CIPD patch from depot tools ( #42484 )
...
* build: try to remove the CIPD patch from depot tools
* build: remove cipd patch from GHA
2024-06-13 16:06:16 -05:00
Samuel Attard
b92a4023c1
build: unify pipelines ( #42482 )
2024-06-13 16:02:38 -05:00
Tomáš Hübelbauer
15c404a3c8
docs: fix the Apple HIG link for Dock context menu ( #42450 )
...
Fix the Apple human interface guidelines link for Dock context menu
The link seems to have changed. This is the up to date link.
2024-06-13 15:24:05 -05:00
Shelley Vohr
0affad3be6
build: add several missing test steps for GHA ( #42479 )
2024-06-13 14:26:20 -05:00
Shelley Vohr
30885e5f9f
build: add Linux GHA test step ( #42460 )
...
* build: add Linux GHA test step
* Switch to medium AKS runners
* Add missing BUILD_TYPE to restore-artifact
* Fix untar to current dir
* Remove known hosts logic
* Add missing Node.js headers step
* Fix for active SSH sessions
* Fix storing artifacts
* Build on x64 for test
2024-06-13 14:14:33 -05:00
Keeley Hammond
75d0e725be
build: fix conditional for sas token ( #42481 )
2024-06-13 09:43:06 -05:00
Keeley Hammond
42266546eb
build: move hunspell generation to Linux ( #42480 )
2024-06-13 09:37:36 -05:00
Samuel Attard
f72096194f
build: reuse checkout steps across mac and linux ( #42475 )
2024-06-13 09:09:35 -05:00
Samuel Attard
1e219e457b
build: generate deps hash quietly ( #42476 )
2024-06-13 01:43:33 -05:00
Keeley Hammond
a4f201a5f3
build: add needed steps/tweaks to Linux publish job ( #42477 )
...
* build: add libcxx to Linux publish
* build: temp change ref to branch
* build: remove hunspell dictionaries
* build: modify release build script for linux
* build: switch back to main
2024-06-12 23:13:17 -05:00
Shelley Vohr
5abefc5dc3
build: use GN_EXTRA_ARGS on macOS ( #42473 )
...
* build: use GN_EXTRA_ARGS on macOS
* Switch back to main
2024-06-12 22:12:30 -05:00
Keeley Hammond
9d6c894e89
build: save/restore cache on Linux builds ( #42472 )
...
* build: update checkout and cache restore for Linux
* build: clean up variables
* build: temporarily set ref to branch
* build: actually check if cache exists or not and correctly store it
* build: correct cache paths
* build: restore electron_node/deps/v8
* build: restore sha to @main, not branch
* build: remove cache_key and use $DEPSHASH
* build: remove sas, backup_cache logic
* build: revert openssl deletion
2024-06-12 17:41:07 -05:00
Samuel Attard
08bd588e71
build: use dynamic RO sas token provided by sas-sidecar ( #42470 )
2024-06-12 16:04:28 -05:00
Shelley Vohr
2afe657873
build: cleanup to macos pipeline ( #42445 )
...
* build: cleanup to macos pipeline
* Fix generated artifact key finding
* Fix cache restore key
* Switch ref to main
* Use artifacts for build artifact persisting
* Fix TARGET_ARCH env var in test
* Remove npm install
2024-06-12 14:58:47 -05:00
Mark Lee
1d2f2eb113
docs(web-embeds): replace BrowserView ref with WebContentsView ( #42416 )
2024-06-12 14:55:06 -05:00
Keeley Hammond
f6a9c55907
build: remove unneeded installs/secrets ( #42467 )
...
build: remove unneeded azure installs/secrets
2024-06-12 14:53:18 -05:00
Keeley Hammond
1cb63b4d77
build: use the linux aks for macos checkout/cache ( #42447 )
...
* build: use the linux aks for checkout/cache
* build: use latest container sha
* build: persist the AKS cache (first try)
* build (do not merge): use current branch for workflows
* build: do not check for existing cache
* build: try to move src into /var/portal
* build: add AZURE_AKS_CACHE_SHARE_NAME & AZURE_AKS_CACHE_STORAGE_ACCOUNT
* build: add volumes: /mnt/cross-instance-cache
* build: temporarily skip cache exists checks
* build: reset to aks-linux-large, upload/download tar
* build: pass detailed credentials into download
* build: be better
* build: add skip if cache exists, declare env vars earlier
* build: add quotes
* build: change to connection-string
* build: remove connection string
* build: migrate to azcopy
* build: lol
* build: revert ref to @main
2024-06-12 14:21:19 -05:00
Shelley Vohr
ffe1d70f1d
build: add Linux GHA build step ( #42432 )
...
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-06-12 14:16:49 -05:00
Erick Zhao
83748bd181
docs: clean up MAS submission guide ( #42368 )
...
* docs: clean up MAS submission guide
* add info from osx-sign wiki
2024-06-12 12:58:21 -05:00
voidfill
7a6a2a51e0
docs: fix info admonitions in security.md ( #42451 )
2024-06-12 11:38:21 -05:00
Shelley Vohr
6caf9f06f3
fix: don't observe WebUSB for in-memory partitions ( #42443 )
2024-06-12 10:59:04 -05:00
Shelley Vohr
4aa9070e6c
fix: missing fetch-dependent interfaces in Node.js ( #42419 )
...
fix: missing fetch-dependent interfaces in Node.js
2024-06-11 16:59:53 -05:00
George Xu
ea219dd702
docs: update timelines for E32 ( #42431 )
...
docs: update timelines for e32
2024-06-11 16:36:36 -05:00
Keeley Hammond
eacdf56e0b
build: build ffmpeg on MAS publish ( #42448 )
2024-06-11 14:43:11 -05:00
Charles Kerr
89ce1cbd39
build: add an option to skip the install-sysroot hooks ( #42436 )
2024-06-11 10:08:07 -05:00
rcombs
d8e4579e3c
feat: add cumulativeCPUUsage to AppMetrics and CPUUsage ( #41819 )
...
This allows apps to measure their CPU usage over any given period
without worrying about other calls affecting the output,
as they would with `percentCPUUsage`.
2024-06-11 09:38:03 -05:00
Shelley Vohr
f35a755086
fix: bad js-flags shouldn't crash the app ( #42414 )
...
* fix: bad js-flags shouldn't crash the app
* Update shell/browser/javascript_environment.cc
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2024-06-11 08:32:16 -05:00
Charles Kerr
f2481ed44f
refactor: move impl classes into unnamed namespaces ( #42390 )
...
* refactor: move ReplyChannel into an anonymous namespace
* refactor: move ChunkedDataPipeReadableStream into an anonymous namespace
* refactor: move linux helpers into an anonymous namespace
* refactor: move linux helpers into an anonymous namespace
2024-06-10 17:00:20 -05:00
Keeley Hammond
c4abaec56a
build: fix upload script defaults ( #42430 )
2024-06-10 16:58:29 -05:00
Shelley Vohr
92de23bb3c
build: initial Linux pipeline checkout ( #42429 )
...
* build: create config for GHA build linux
* build: restructure linux pipeline files
* build (do not merge): don't run CircleCI or Appveyor
* build: run on push
* build: add checkout step
* build: fix .yml syntax
* Remove Azure CLI install
* Revert "build (do not merge): don't run CircleCI or Appveyor"
This reverts commit eb55e317bc .
* build: change pipeline SHA to main
* chore: update patches
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-10 14:39:34 -05:00
Shelley Vohr
ff4494c18f
build: allow kicking build with workflow_dispatch ( #42420 )
...
* build: allow kicking build with workflow_dispatch
* build: ensure macOS build works
* fix: no upload in build
* build: add target_cpu to MAS config
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-06-10 11:55:16 -05:00
electron-appveyor-updater[bot]
839ba30009
build: update appveyor image to latest version ( #42418 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-06-10 11:46:44 -05:00
Shelley Vohr
92db4f0b8a
build: fix generate_gn_filenames_json.py ( #42389 )
...
build: fix generate_gn_filenames_json.py
2024-06-10 10:34:36 -05:00
David Sanders
c6845b0afc
chore: update @electron/lint-roller to 2.2.0 ( #42412 )
2024-06-10 10:14:03 -05:00
Shelley Vohr
035b10daf9
fix: multiple selection in //shell_dialogs Portal/KDE implementations ( #42308 )
...
* fix: multiple selection in //shell_dialogs portal implementation
* fix: allow multiple directory selection in KDE implementation
2024-06-10 09:43:16 -05:00
Shelley Vohr
91205540c4
fix: restore wasOpenedAtLogin functionality ( #42411 )
...
fix: restore opened at login functionality
2024-06-10 09:39:56 -05:00
electron-roller[bot]
c3b4cd987c
chore: bump chromium to 127.0.6521.0 (main) ( #42118 )
...
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
https://chromium-review.googlesource.com/c/chromium/src/+/5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5545807: Migrate most remaining NOTREACHED()
https://chromium-review.googlesource.com/c/chromium/src/+/5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147
* chore: add kPip to enumeration as a no-op
https://chromium-review.googlesource.com/c/chromium/src/+/5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251
* Require client for InitParams to always specify an ownership mode.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2 , was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ | https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
https://chromium-review.googlesource.com/c/chromium/src/+/5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
https://chromium-review.googlesource.com/c/chromium/src/+/5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
https://chromium-review.googlesource.com/c/chromium/src/+/5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | https://chromium-review.googlesource.com/c/v8/v8/+/5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/5539852
* 5573603: Modularize //chrome/browser/themes
https://chromium-review.googlesource.com/c/chromium/src/+/5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-06-07 17:18:35 -04:00
Shelley Vohr
84e15e2d04
build: Azure CLI install step not needed ( #42410 )
2024-06-07 10:05:15 -07:00
Shelley Vohr
25ed286706
fix: loginService -> loginItemService ( #42380 )
...
fix: loginService -> loginItemService
2024-06-07 11:49:00 +02:00
Shelley Vohr
d97dcf388a
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var ( #42402 )
...
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var
2024-06-07 11:46:30 +02:00
Shelley Vohr
54c315c9b0
refactor: improve cookie failure rejection messages ( #42362 )
2024-06-07 10:06:37 +02:00
Shelley Vohr
7f3dc7d4ce
fix: utilityProcess exit codes ( #42297 )
2024-06-07 10:06:00 +02:00
Shelley Vohr
1c6d7d7ece
build: fix depot_tools patch ( #42388 )
...
build: fix depot_tools patch
2024-06-06 22:49:59 +02:00
Keeley Hammond
6ccb9861f6
build: increase fetch-deps ( #42387 )
...
* build: use fetch-depth: 0 and fetch-tags
* debug: readd tmate SSH debugging
* build: run SSH by default, remove debug conditional
* build: remove redundent fetch-tags
* build: pin tmate to SHA
* build: remove tmate action
2024-06-06 12:09:50 -07:00
Shelley Vohr
ec4461d1f2
fix: iframe.contentWindow.document.fonts resolution ( #42366 )
...
fix: iframe.contentWindow.document.fonts resolution
2024-06-06 15:06:28 +02:00
Keeley Hammond
c9349a2590
build: [GHA] cross-compile x64 MacOS jobs on arm64 ( #42370 )
...
* build: split x64 mas/darwin to run concurrently
* Retry src cache download on failure
* build: gate FFMpeg, etc, to release & darwin
* build: cross-compile x64 on arm hardware
* chore (do not merge): comment out CircleCI config
* build: fix FFMpeg conditional but harder
* build: add fetch-deps to checkout
* build: correctly add target_arch to MAS configs
* build: correct target arch
* build: consolidate darwin/mas back into single runner per arch
* build: re-enable CircleCI
* Add missing ELECTRON_OUT_DIR for upload
* Add missing ELECTRON_GITHUB_TOKEN to secrets
* build: (do not merge) run only darwin
* build: remove seperate upload step
* build: re-enable mas, remove upload seperate job
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-05 23:06:25 -07:00
Charles Kerr
791907f0f3
refactor: move WebFrameRenderer into an anonymous namespace ( #42369 )
2024-06-05 18:31:52 -05:00
Keeley Hammond
7569d90f59
build: bump NMV to 128 for Electron 32 ( #42311 )
2024-06-05 12:55:45 -04:00
Alice Zhao
406f644d26
feat: duplicate navigation related APIs to contents.navigationHistory ( #41752 )
...
* refactor: move navigation related api to navigationHistory
* docs: add deprecation messages to old web content methods
* fix: add deprecation warnings to webcontents
* fix: add deprecation warnings and make existing naviagation apis internal
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* docs: fix links
* docs: add breaking change to 31
* docs: move breaking change to 32
* chore: re-run pipeline
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2024-06-05 09:34:47 -07:00
Anny Yang
5fb117a7d7
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42353 )
...
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
2024-06-05 09:58:38 +02:00
Shelley Vohr
39c984e23a
fix: WebUSB should not crash when using in-memory partitions ( #42347 )
2024-06-04 15:24:08 +02:00
dependabot[bot]
b74d3e14b0
build(deps): bump github/codeql-action from 3.25.6 to 3.25.7 ( #42354 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.6 to 3.25.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9fdb3e4972...f079b84933 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:12:16 +02:00
dependabot[bot]
01bf60bf66
build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.3 ( #42355 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...65462800fd760344b1a7b4382951275a0abb4808 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:56 +02:00
dependabot[bot]
1c36b8b390
build(deps): bump actions/checkout from 4.1.1 to 4.1.6 ( #42356 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...a5ac7e51b41094c92402da3b24376905380afc29 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:46 +02:00
Keeley Hammond
5f8a490a00
build: add release config/dsymutil fix, test-releases for GHA ( #42350 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
* build: use GN_CONFIG
* remove: hardcode release gn config
* Fix GN args import for release
* Use BUILD_TOOLS_SHA when cloning build-tools in test
* build: create test release in prepare-release
* build: fix GN_CONFIG for mas builds
* Fix dsymutil arch resetting
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-06-03 11:43:54 -07:00
Keeley Hammond
361b37592a
build: add GitHub Actions publishing pipeline for macOS ( #42236 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
2024-05-31 10:58:39 -07:00
electron-roller[bot]
4436ce53bc
chore: bump node to v20.14.0 (main) ( #42329 )
...
* chore: bump node in DEPS to v20.14.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-31 18:06:36 +02:00
Shelley Vohr
9f88820be9
fix: dialogs should work with BaseWindows internally ( #42315 )
2024-05-31 12:04:22 +02:00
Krzysztof Halwa
85df2a86dd
feat: Allow WebContentsView to accept webContents object. ( #42086 )
...
feat: Allow WebContentsView to accept webContents object
2024-05-30 12:45:35 -07:00
Keeley Hammond
d92a80dfe3
chore: cherry-pick 22db6918bac9 from chromium ( #42304 )
...
* chore: cherry-pick 22db6918bac9 from chromium
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-30 10:08:12 +02:00
Michaela Laurencin
5715cc0921
build: update NMV to 125 ( #42312 )
2024-05-29 13:03:23 -07:00
Charles Kerr
ae0c55c0b1
refactor: inherit Observer classes privately, pt. 2 ( #42237 )
...
* refactor: use private inheritance in PushNotifications
* refactor: use private inheritance in electron::api::App
* refactor: use private inheritance in electron::api::BrowserWindow
* refactor: use private inheritance in electron::api::NativeTheme
* refactor: use private inheritance in electron::api::Tray
* refactor: use private inheritance in electron::api::Session
* refactor: use private inheritance in electron::api::WebContents
* refactor: use private inheritance in electron::api::DownloadItem
* refactor: use private inheritance in electron::api::MenuBar
* refactor: use private inheritance in ClearDataOperation
* refactor: use private inheritance in electron::api::Screen
* refactor: use private inheritance in electron::ElectronDesktopWindowTreeHostLinux
* refactor: use private inheritance in SpellCheckerHolder
* refactor: use private inheritance in electron::api::PowerMonitor
* refactor: use private inheritance in electron::api::BaseWindow
* refactor: use private inheritance in electron::api::AutoUpdater
* refactor: use private inheritance in electron::api::Menu
* refactor: use private inheritance in electron::api::NativeWindowViews
* refactor: use private inheritance in electron::ElectronBrowserClient
* refactor: use private inheritance in electron::AutofillPopupView
* refactor: use private inheritance in GtkMessageBox
* refactor: use private inheritance in electron::OffScreenRenderWidgetHostView
* refactor: use private inheritance in electron::InspectableWebContents
* refactor: use private inheritance in electron::ElectronUsbDelegate
* refactor: use private inheritance in electron::LoginHandler
* refactor: use private inheritance in WebFrameRenderer
* refactor: use private inheritance in electron::ElectronSerialDelegate
* refactor: use private inheritance in electron::ClientFrameViewLinux
* refactor: use private inheritance in electron::ElectronHidDelegate
* refactor: use private inheritance in IPCRenderer
* refactor: use private inheritance in electron::WinCaptionButtonContainer
* refactor: use private inheritance in electron::ElectronApiIPCHandlerImpl
* refactor: use private inheritance in electron::api::ServiceWorkerContext
* refactor: use private inheritance in ui::FileSelectHelper
* refactor: use private inheritance in electron::api::WebContentsView
* refactor: use private inheritance in electron::api::SimpleURLLoaderWrapper
* refactor: use private inheritance in electron::api::InAppPurchase
* refactor: use private inheritance in electron::api::Debugger
* refactor: use private inheritance in electron::ElectronWebContentsUtilityHandlerImpl
* refactor: use private inheritance in electron::OffScreenWebContentsView
2024-05-29 13:07:02 -05:00
IsmaelMartinez
705d92c5f6
docs: fix broken notification-spec markdown link ( #42243 )
...
* docs: fix broken notification-spec markdown link
* docs: update notification-spec linkt to point to freedesktop
2024-05-29 14:41:17 +02:00
Samuel Attard
22ba8b6f01
fix: restore original BrowserWindow.show() behavior ( #42300 )
2024-05-28 23:31:11 -07:00
Erick Zhao
09fb892c6e
docs: ensure all links are on a single line ( #42235 )
2024-05-28 11:15:18 -07:00
Charles Kerr
bb4374ee2c
fix: potential null dereference in normalizeSpawnArguments() patch ( #42260 )
...
fix: potential null deref in normalizeSpawnArguments() patch
Use upstream's practice of using `env = options.env || process.env`.
Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD
and CRASHPAD_HANDLER_PID to options.env.
2024-05-27 10:41:42 +02:00
Evo
6423968dc5
fix: fixed the type of WebviewTag.webpreferences ( #42275 )
...
fix: fixed the type of WebviewTag.webpreferences
2024-05-25 22:06:06 -07:00
BILL SHEN
3ffa35dc8d
fix: calculate a hash for the Tag property of ToastNotification. ( #42239 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
* fix: calculate a hash for the Tag property of ToastNotification.
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com >
2024-05-24 21:20:59 +02:00
Keeley Hammond
7ec813732a
chore: cherry-pick 3e037e195e50 from v8 ( #42253 )
2024-05-23 07:20:13 -07:00
dependabot[bot]
0285ff0c0f
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #42230 )
...
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:23 +02:00
dependabot[bot]
f6bdbd6000
build(deps): bump github/codeql-action from 3.25.5 to 3.25.6 ( #42229 )
...
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:12 +02:00
Charles Kerr
752efddf89
refactor: prefer to inherit observer classes privately ( #41360 )
...
* refactor: use private inheritance in CookieChangeNotifier
* refactor: use private inheritance in WebViewGuestDelegate
* refactor: use private inheritance in UsbChooserController
* refactor: use private inheritance in DesktopCapturer
* refactor: use private inheritance in Browser
* refactor: use private inheritance in WebContentsZoomController
* refactor: use private inheritance in FrameSubscriber
* refactor: use private inheritance in AutofillAgent
* refactor: use private inheritance in HidChooserController
* refactor: use private inheritance in PepperHelper
* refactor: use private inheritance in AutofillPopup
* refactor: use private inheritance in SerialChooserController
* refactor: use private inheritance in MediaCaptureDevicesDispatcher
* refactor: use private inheritance in electron::api::View
* refactor: use private inheritance in AutofillDriverFactory
* refactor: use private inheritance in GPUInfoManager
* refactor: use private inheritance in SavePageHandler
* refactor: use private inheritance in GlobalShortcut
* refactor: use private inheritance in ElectronRenderFrameObserver
2024-05-21 14:21:31 -05:00
dependabot[bot]
23a5d8b64a
build(deps): bump mikefarah/yq from 4.43.1 to 4.44.1 ( #42228 )
...
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 20:41:47 -07:00
Samuel Attard
2e778a98b9
fix: ensure showInactive actually shows ( #42226 )
2024-05-20 14:12:05 -07:00
Erick Zhao
b8381b7d93
docs: fix broken anchors ( #42213 )
2024-05-17 09:46:18 +02:00
Shelley Vohr
af9a59cc40
build: cancel in-progress runs on new commits ( #42193 )
2024-05-15 23:45:54 +02:00
Charles Kerr
c67744a127
refactor: use raw_ref in RootView ( #42114 )
...
* refactor: make RootView::window_ a const raw_ref
The Chromium C++ style guide says "prefer const raw_ref<T> whenever
the held pointer will never be null," so let's do that.
* refactor: make RootView::main_view_ a const raw_ref
> The Chromium C++ style guide says "prefer const raw_ref<T> whenever
> the held pointer will never be null," so let's do that.
* refactor: aggregate RootView::last_focused_view_tracker_
RootView already owns it, so aggregate it
2024-05-15 14:45:47 -04:00
David Sanders
0b62abf244
chore: use markdownlint-cli2 directly for linting Markdown ( #42192 )
2024-05-15 14:44:46 -04:00
Jeremy Rose
19dc276878
feat: remove File.path ( #42053 )
2024-05-15 11:07:23 -07:00
Shelley Vohr
a54afabe04
fix: win.center() on Windows ( #42195 )
...
fix: win.center() on Windows
2024-05-15 10:36:24 -07:00
Piotr Płaczek
125bd6aa2b
docs: troubleshooting advice for rbe auth 'token not valid' error ( #42027 )
2024-05-15 10:35:32 -07:00
Keeley Hammond
7f8fabbe7b
chore: remove focus ring patch ( #42183 )
2024-05-14 15:57:00 -07:00
Samuel Attard
435003566d
fix: restore non-panel focus behavior ( #42180 )
2024-05-14 15:52:08 -07:00
Keeley Hammond
d7099b0ad4
chore: cherry-pick b3c01ac1e60a from v8 ( #42172 )
...
* chore: cherry-pick b3c01ac1e60a from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 18:02:24 -04:00
Fedor Indutny
f2af35182c
fix: fix cast in ElectronDesktopWindowTreeHostLinux ( #42179 )
...
Fix cast in ElectronDesktopWindowTreeHostLinux
The frame view of the widget is an `ClientFrameViewLinux` instance only
when both `frame` and `client_frame` booleans are set to `true`.
Otherwise it is an instance of a different class and thus casting to
`ClientFrameViewLinux` is incorrect and leads to crashes.
Fix : #41839
2024-05-14 14:26:39 -07:00
Shelley Vohr
d0cb298f95
fix: webContents.navigationHistory should be enumerable ( #42139 )
...
fix: webContents.navigationHistory should be enumerable
2024-05-14 16:47:47 -04:00
David Sanders
1ef5406c8c
chore: enable no autolink markdownlint rule ( #42127 )
2024-05-14 16:32:52 -04:00
dependabot[bot]
4e70213037
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.4.0 ( #42161 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...48d2ff8c1a )
---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:53:15 -04:00
dependabot[bot]
45cc31fd2f
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 ( #42160 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.3 to 3.25.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d39d31e687...b7cec75265 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:52:54 -04:00
dependabot[bot]
03e259dc25
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 ( #42159 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](0864cf1902...dc50aa9510 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:51:35 +02:00
dependabot[bot]
e4d89ba2b4
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5.5.2 ( #42158 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.4.0 to 5.5.2.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](e9fabac35e...cfb60706e1 )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 10:50:36 +02:00
John Kleinschmidt
44ebc1b1c2
chore: update patches after #42126 was merged ( #42153 )
2024-05-13 15:46:59 -07:00
electron-appveyor-updater[bot]
4c27b0c282
build: update appveyor image to latest version ( #42135 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-05-13 16:58:15 -04:00
Samuel Attard
e19754d7fd
test: add tests for electron fuses ( #42129 )
...
* spec: add tests for electron fuses
* spec: fix tests for windows
* spec: handle weird crash codes on win32
* spec: disable fuse tests on arm64 windows
2024-05-13 10:48:26 -07:00
Keeley Hammond
c56e1dffb0
fix: partially revert invalidate focus ring ( #42126 )
2024-05-13 11:02:59 -05:00
electron-roller[bot]
653d0f009e
chore: bump node to v20.13.1 (main) ( #42088 )
...
* chore: bump node in DEPS to v20.13.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
https://github.com/nodejs/node/pull/52217
* test: skip test for dynamically linked OpenSSL
https://github.com/nodejs/node/pull/52542
* lib, url: add a `windows` option to path parsing
https://github.com/nodejs/node/pull/52509
* src: use dedicated routine to compile function for builtin CJS loader
https://github.com/nodejs/node/pull/52016
* test: mark test as flaky
https://github.com/nodejs/node/pull/52671
* build,tools: add test-ubsan ci
https://github.com/nodejs/node/pull/46297
* src: preload function for Environment
https://github.com/nodejs/node/pull/51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
https://github.com/nodejs/node/pull/52285
* chore: handle updated filenames
- https://github.com/nodejs/node/pull/51999
- https://github.com/nodejs/node/pull/51927
* chore: bump node in DEPS to v20.13.1
* events: extract addAbortListener for safe internal use
https://github.com/nodejs/node/pull/52081
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* fs: add stacktrace to fs/promises
https://github.com/nodejs/node/pull/49849
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 11:43:14 -04:00
Charles Kerr
10fd0ba655
refactor: use base::Value::Take*() ( #41169 )
...
* perf: avoid temporary strings in Converter<net::HttpRequestHeaders>::FromV8()
* perf: take strings instead of copying them in ToResponseHead()
* refactor: prefer base::Value::Take*() where appropriate
As per the base::Value docs: "prefer over `std::move(value.Get...())`
so clang-tidy can warn about potential use-after-move mistakes."
2024-05-13 15:58:52 +02:00
David Sanders
88f28a302f
docs: improve protocol.handle file examples ( #42111 )
...
* docs: improve protocol.handle file examples
* chore: fix lint
2024-05-13 11:49:18 +02:00
Richard Torres
8d4467bdc4
docs: fixing typo in dark mode fiddle and doc ( #42112 )
2024-05-13 10:50:55 +02:00
David Sanders
188196e78c
ci: auto label bug issues with version label ( #42044 )
2024-05-13 10:49:23 +02:00
Shelley Vohr
c765d57265
fix: BrowserView autoresizing conversion error ( #42056 )
2024-05-13 10:27:01 +02:00
Samuel Attard
3ea3b0e8e1
fix: ensure originalFs.promises.cp works ( #42132 )
2024-05-12 21:03:00 -07:00
Keeley Hammond
96dda274e9
chore: cherry-pick f320600cd1f4 from v8 ( #42120 )
2024-05-11 14:17:02 -07:00
electron-roller[bot]
9b0409f7c9
chore: bump chromium to 126.0.6445.0 (main) ( #41868 )
...
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-05-10 11:21:10 -04:00
dependabot[bot]
0725f5c5cf
build(deps): bump mikefarah/yq from 4.40.7 to 4.43.1 ( #42074 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.43.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...c35ec752e3 )
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-10 11:33:15 +02:00
David Sanders
c00eb5d491
chore: update @electron/lint-roller to 2.1.0 ( #42078 )
2024-05-10 11:00:15 +02:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
Charles Kerr
e2acdffe58
perf: avoid protocol registry redundant lookup ( #41991 )
...
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource()
* refactor: remove unused ProtocolRegistry::IsProtocolRegistered()
refactor: remove unused ProtocolRegistry::IsProtocolIntercepted()
* refactor: remove unused ProtocolRegistry::handlers()
* refactor: rename ProtocolRegistry::FindIntercepted()
refactor: rename ProtocolRegistry::FindRegistered()
similar semantics to base::Value::Find*()
* chore: follow Google C++ brace style
chore: use same variable names as in main
2024-05-09 09:53:09 -04:00
Shelley Vohr
865b0499bb
refactor: use //ui/shell_dialogs on Linux ( #42045 )
...
* refactor: use //ui/shell_dialogs on Linux
* fix: add proper filtering
* fix: add support for missing dialog features to //shell_dialogs
* fix: parent_window could be null
* chore: cleanup patch
* fix: use a OnceCallback in the sync implementation
* chore: remove stray debuglog
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use settings struct
* fix: show hidden file property checking
* chore: changes from review
* fix: multi selection for dialogs
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-05-09 09:51:42 -04:00
Shelley Vohr
6675f3ae65
fix: CHECK when adding view as its own child ( #42067 )
2024-05-09 09:47:47 -04:00
Shelley Vohr
731bc7a334
fix: BrowserWindow.center() should center relative to screen ( #42048 )
2024-05-08 15:42:20 -07:00
dependabot[bot]
793276ac87
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 ( #42076 )
2024-05-08 13:36:33 +02:00
Peter Xu
0128a072d6
docs: make corrections for BrowserViews since it is deprecated ( #42030 )
2024-05-08 11:21:26 +02:00
dependabot[bot]
a059dd7b69
build(deps): bump github/codeql-action from 3.24.0 to 3.25.3 ( #42073 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.25.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...d39d31e687 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-08 10:43:29 +02:00
dependabot[bot]
53a4484372
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #42075 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a )
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-08 10:42:32 +02:00
Christian Clauss
8cfc4b9d50
ci: keep GitHub Actions up to date with GitHub's Dependabot ( #42042 )
...
* Keep GitHub Actions up to date with GitHub's Dependabot
Fixes software supply chain safety warnings like at the bottom right of
https://github.com/electron/electron/actions/runs/8619491231
* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot )
* [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem )
* Apply suggestion from code review
* chore: fully remove groups
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-05-07 19:25:46 -04:00
Erick Zhao
c3c4173377
docs: update formatting for mdx3 compatibility ( #42052 )
...
docs: update formatting for mdx3 compat
2024-05-07 19:20:47 -04:00
cptpcrd
d5c8f2d6d9
fix: avoid crash after upgrade on Linux ( #41046 )
2024-05-07 16:04:50 +02:00
Piotr Płaczek
5b60698dea
docs: fix lint command ( #42028 )
2024-05-04 15:48:08 +02:00
Charles Kerr
05631ec445
chore: disable tests that require nut.js ( #42006 )
...
* chore: disable tests that require nut.js
* fixup! chore: disable tests that require nut.js
2024-04-30 21:13:38 -04:00
John Kleinschmidt
36310b8729
chore: fixup gn check when enable_pdf_viewer is false ( #41990 )
2024-04-30 20:32:11 -04:00
Shelley Vohr
f5fb44eaf8
fix: requestFullscreen from WebContentsView ( #41966 )
...
fix: requestFullscreen from WebContentsView
2024-04-29 19:09:29 -04:00
Shelley Vohr
441dbda833
fix: recentDocuments on macOS not working ( #41978 )
2024-04-29 19:07:14 -04:00
Michaela Laurencin
ef097b77ad
chore: fix notes stack updates ( #41600 )
...
* chore: fix removeSupercededStackUpdates for generating notes
* add early stop for less than
* Update script/release/notes/notes.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* clean up comparison functionality
* add tests
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-04-29 11:41:54 -04:00
Shelley Vohr
5310b79ffb
fix: setTitleBarOverlay should be implemented on BaseWindow ( #41960 )
...
fix: setTitleBarOverlay should be implemented on BaseWindow
2024-04-29 11:28:24 -04:00
Shelley Vohr
b95d0f7623
build: use env var for build-tools pinning ( #41969 )
2024-04-29 10:07:42 -04:00
Shelley Vohr
b41da150ca
build: add GitHub Actions testing pipeline for macOS ( #41812 )
...
* build: test the Mac runner space
* build: baby steps, super basic checkout
* chore: simplify depot-tools
* build: try a sync
* build: fix path
* build: pass different URL for sync
* build: gclient sync with --verbose
* debug: add logging for mtime cache
* build: add psuedocode for Azure workflow, add workflow_dispatch
* build: enable ssh access to runners
* build: test azure upload without full sync
* build: full sync and cache upload test
* build (WIP): mock out download logic
* build: remove sync, try disk space prune
* build: lets try it again, lads
* ci: add cache downloading wip
* fix: correct json parsing
* chore: use depshash and fix output syntax
* chore: rework depshash state and delete more
* refactor: split checkout to Linux runner
* fix: depot_tools get on Linux
* fix: add infra/3pp/tools/swift-format handling
* chore: move to patch file in build as well
* chore: misc cleanup of env steps
* chore: add fix sync step
* build: use tar file, strip .git dirs
* build: set GIT_CACHE_PATH outside of src
* ci: fix cache prefix, add check for ssh debug
* fix: fix tar pack/unpack
* build: add reclient support & ninja build step
* chore: clean up reclient round 1
* fix: grab ELECTRON_RBE_JWT from secrets
* chore: run tmate if debug logging enabled
* chore: move ulimit setting
* fix: missing GN gen env vars
* fix: workaround packed-refs issue
* chore: fixup PATH usage
* chore: remove GIT_CACHE env var
* fix: call pack refs manually
* fix: add RBE_experimental_credentials_helper_args
* chore: whoops we need electron_node/deps/v8 actually
* fix: we need electron_node/deps/openssl too
* build: load build-tools & xcode
* build: add dist, chromedriver & mksnapshot
* build: add test job, download artifacts
* Cache non-generated build artifacts
* chore: set download path explicitly
* chore: load-xcode is called by e build
* Add codesigning certificate step
* Add Test Step
* Try without codesigning just to get tests running
* Add depot_tools to PATH in test
* Persist src/buildtools/mac
* chore: use script/yarn test directly
* Build Node.js Headers for caching
* Add initial matrix for mas build
* Fix GN_EXTRA_ARGS generation syntax
* Fix BUILD_TYPE interpolation
* Use matrix in test correctly
* feat: add publish config, alter release-build script
* build: force trigger the first workflow
* build: oops
* Ensure env vars escaped
* Move GN_EXTRA_ARGS to gn gen step
* chore: rename yml to match convention
* ci: fix helperPath calls in action configs
* chore: try setting directly
* fix: switch to mas config
* chore: Testing -> Default
* Re-enable darwin build
* Use mas JSON config
* refactor: extract artifact logic to bash scripts
* refactor: build MAS after darwin
* chore: move to script/actions
* chore: use Node.js 20.11.x
* Don't fail-fast in tests
* build: tweak release script
* build: remove macos-publish.yml
* build: change action to trigger on publish workflow dispatch
* chore: remove SSH debugging using action-tmate
* build: do not disable CircleCI config
* chore: switch away from cURL for AzureCLI
* chore: move evm.mas.json to .github/workflows/config
* chore: remove publish logic from initial build flow
* build: add patchup check for non-release builds
* build: pin build-tools to sha 2bb63e2
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2024-04-24 10:29:19 -07:00
Charles Kerr
b684a98267
refactor: replace base::EndsWith() with std::ends_with() ( #41937 )
2024-04-23 21:13:59 -05:00
South Drifted
7621e7cff7
docs: Windows typo in Tutorial document ( #41896 )
...
Update tutorial-6-publishing-updating.md
2024-04-23 13:14:26 -04:00
Shelley Vohr
d8f8560b1c
refactor: address changes and fix errors in chrome://accessibility ( #41911 )
...
refactor: address changes and fix errors in chrome://accessibility
2024-04-23 11:30:47 -04:00
Kilian Valkhof
1cf194faae
docs: correct the return value for canceled showSaveDialog ( #41926 )
2024-04-23 11:29:14 -04:00
Shelley Vohr
a0fee8f47a
build: fixup codespaces on-create ( #41428 )
2024-04-22 20:26:11 -04:00
Jeremy Rose
4e8c28fdf0
fix: data corruption in protocol.handle ( #41894 )
2024-04-22 13:40:01 -07:00
tuanzijiang
46adb0a3a9
fix: offscreen rendering does not paint after gpu process crashed ( #41904 )
...
Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com >
2024-04-22 09:50:55 -04:00
Shelley Vohr
a8db7fe2ef
build: use latest devcontainer buildimage with codespaces ( #41916 )
2024-04-22 09:48:30 -04:00
Charles Kerr
0346e0a8bf
refactor: use std::erase() ( #41881 )
...
* refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences()
* refactor: use std::erase() in WindowList::RemoveWindow()
* refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed()
* refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit()
* refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission()
* refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList()
* refactor: move DoesDeviceMatch() out of class into anonymous namespace
2024-04-19 10:55:59 -05:00
Shelley Vohr
39bf441b3b
build: enable Perfetto in Chromium ( #41880 )
...
* build: enable perfetto in Chromium
* refactor: delete TracingControllerImpl
* fix: TraceObject isn't present when v8_use_perfetto is true
* fix: update lib/internal/http for perfetto
* chore: remove stray log
2024-04-19 11:07:36 -04:00
Samuel Attard
46ef7ef8fb
build: update typescript-definitions to 8.15.6 ( #41900 )
2024-04-19 10:29:45 -04:00
JakobDev
07a68c2bf8
fix: don't check for Desktop Environment in unity_service.cc ( #41211 )
...
Don't check for Desktop Environment in unity_service.cc
2024-04-19 09:58:32 -04:00
Jeremy Rose
ed9fec7da4
fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer ( #41875 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
* also fix shell.openExternal
2024-04-19 09:43:01 -04:00
Shelley Vohr
c4aeb17245
fix: EINVAL when spawning cmd files on Windows ( #41893 )
...
fix: EINVAL when spawning on Windows
2024-04-19 09:27:58 -04:00
Jeremy Rose
67ba30402b
refactor: JSify BrowserWindow unresponsive handling ( #37902 )
2024-04-18 13:14:07 -07:00
Charles Kerr
b683754c16
chore: remove unused hash function ( #41876 )
...
Unused since e1e73fa #24115
2024-04-17 19:04:06 -05:00
nashaofu
0222686e9a
docs: update build docs,support Powershell on Windows ( #41567 )
...
* docs: update build docs,support Powershell on Windows
* chore: fix capitalization
2024-04-17 18:46:52 -04:00
James Yuzawa
bf754a3cae
fix: make window.flashFrame(bool) flash continuously on macOS ( #41391 )
...
fix: window.flashFrame to flash continuously on mac
This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest ) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest ) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos ).
2024-04-17 12:42:34 -04:00
electron-roller[bot]
7120c58297
chore: bump node to v20.12.2 (main) ( #41710 )
...
* chore: bump node in DEPS to v20.12.0
* chore: update build_add_gn_build_files.patch
* chore: update patches
* chore: bump node in DEPS to v20.12.1
* chore: update patches
* build: encode non-ASCII Latin1 characters as one byte in JS2C
https://github.com/nodejs/node/pull/51605
* crypto: use EVP_MD_fetch and cache EVP_MD for hashes
https://github.com/nodejs/node/pull/51034
* chore: update filenames.json
* chore: bump node in DEPS to v20.12.2
* chore: update patches
* src: support configurable snapshot
https://github.com/nodejs/node/pull/50453
* test: remove test-domain-error-types flaky designation
https://github.com/nodejs/node/pull/51717
* src: avoid draining platform tasks at FreeEnvironment
https://github.com/nodejs/node/pull/51290
* chore: fix accidentally deleted v8 dep
* lib: define FormData and fetch etc. in the built-in snapshot
https://github.com/nodejs/node/pull/51598
* chore: rebase on main
* chore: remove stray log
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Cheng <zcbenz@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-04-17 12:39:13 -04:00
Shelley Vohr
b118c70f77
refactor: fold silent print into settings ( #41873 )
...
* refactor: fold silent print into settings
* chore: feedback
2024-04-17 12:04:47 -04:00
electron-appveyor-updater[bot]
cdafe09ffb
build: update appveyor image to latest version ( #41871 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-04-17 10:51:13 -04:00
Charles Kerr
b428315c6d
perf: remove unnecessary .c_str() calls ( #41869 )
...
* perf: remove unnecessary c_str() call when invoking promise.RejectWithErrorMessage()
RejectWithErrorMessage() takes a std::string_view
* perf: remove unnecessary c_str() call when invoking Environment::SetVar()
the val arg to Environment::SetVar() takes a const std::string&
* refactor: use string_view variant of base::UTF8ToWide()
* perf: remove unnecessary c_str() call when instantiating a ScopedHString
ScopedHString has always taken a StringPiece
* refactor: use simpler invocation of base::make_span()
* perf: remove unnecessary c_str() call when calling base::CommandLine::HasSwitch()
HasSwitch() already takes a string_piece
* perf: remove unnecessary c_str() call when calling net::HttpResponseHeaders::AddHeader()
AddHeader() already takes a StringPiece arg
* perf: omit unnecessary str -> wstr -> str conversion in DesktopCapturer::UpdateSourcesList()
this conversion was made redundant by c670e38
2024-04-16 19:48:54 -04:00
electron-roller[bot]
c670e38b4b
chore: bump chromium to 125.0.6412.0 (main) ( #41610 )
...
* chore: bump chromium in DEPS to 124.0.6361.0
* chore: bump chromium in DEPS to 124.0.6363.0
* chore: update patches
Manually apply printing.patch w/no code changes due to upstream shear.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5349263
* chore: bump chromium in DEPS to 124.0.6365.0
* chore: bump chromium in DEPS to 124.0.6367.0
* update patches
* 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple
https://chromium-review.googlesource.com/c/chromium/src/+/5371735
* missed a MAS bit
* chore: update windows toolchain
5350823: New toolchain for Windows 11 10.0.22621.2428 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/5350823
* chore: bump chromium in DEPS to 125.0.6368.0
* fix patches
* chore: update patches
* 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2)
https://chromium-review.googlesource.com/c/chromium/src/+/5232401
* revert https://chromium-review.googlesource.com/c/chromium/src/+/5380898
* chore: bump chromium in DEPS to 125.0.6370.0
* build: use updated windows toolchain
* fix patches
* chore: update patches
* more pdf_util to components
* 5372414: [Extensions] Remove DispatcherDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5372414
* fix accessibility_ui patch
* chore: bump chromium in DEPS to 125.0.6372.0
* chore: bump chromium in DEPS to 125.0.6374.0
* chore: bump chromium in DEPS to 125.0.6376.0
* chore: bump chromium in DEPS to 125.0.6378.0
* chore: bump chromium in DEPS to 125.0.6379.3
* chore: update patches (+ MAS patch changes)
* chore: update patches
* 5381159: Cleanup media::KeySystemSupportObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5381159
* 5382233: Reland "Web `Speech to Text` with SODA backend"
https://chromium-review.googlesource.com/c/chromium/src/+/5382233
* chore: update `exclusive_access` patch
- 5367497: Add a metric for the website state when Fullscreen API is requested
- https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: add build dependency
5367497: Add a metric for the website state when Fullscreen API is requested
https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: bump chromium in DEPS to 125.0.6382.0
* chore: update libcxx filenames
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6384.0
* chore: remove old patch
* 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files
https://chromium-review.googlesource.com/c/chromium/src/+/5394039
* fix: remove deprecated errno constants in node/libuv
* 5362194: Return expected from ProcessMetrics CPU methods
https://chromium-review.googlesource.com/c/chromium/src/+/5362194
* 5383927: Add new Pickle factory functions with explicit ownership
https://chromium-review.googlesource.com/c/chromium/src/+/5383927
* 5373340: Simplify app-region/Draggable Region implementation
https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* 5386875: Cleanup printing preferences files
https://chromium-review.googlesource.com/c/chromium/src/+/5386875
* chore: update libc++ filenames
* fix: add enterprise buildflags dep
* chore: bump chromium in DEPS to 125.0.6386.0
* chore: add build dep
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6388.0
* chore: bump chromium in DEPS to 125.0.6390.0
* chore: update patches
* 4918014: preloading: Add NewTabPagePageLoadMetricsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/4918014
* 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API
https://chromium-review.googlesource.com/c/chromium/src/+/5401234
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* fixup! 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* fixup! chore: add build dep
* chore: remove dead code & dead patch
Was dealing with https://chromium-review.googlesource.com/c/chromium/src/+/5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514 ).
The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay!
* chore: bump chromium in DEPS to 125.0.6392.0
* chore: bump chromium in DEPS to 125.0.6393.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6394.0
* chore: bump chromium in DEPS to 125.0.6396.0
* chore: bump chromium in DEPS to 125.0.6397.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5100842
No code changes, but had to apply patch manually due to upstream code shear
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 2
* chore: silence "space before tab in indent" git rebase-apply warning
* chore: e patches all
* build: update all.gn to avoid FTBFS when disabling raw_ptr
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5371737
* Rename PdfService Mojo interface to PdfHost
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5411957
* chore: bump chromium in DEPS to 125.0.6398.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6400.0
* chore: update patches
* [media] Remove unused `GetSupportedKeySystems` from MediaClient
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5420247
* chore: update JSInjection::New call to match upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5403967
[Extensions] Wire up the renderer for multiple user script worlds
* 5362362: Derive display ID from monitor adapter ID instead of szDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/5362362
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* chore: add v8-sandbox.h to electron-node
* chore: update patches
* chore: update patches
* fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files
* chore: bump chromium in DEPS to 125.0.6412.0
* chore: update patches
* chore: node script/gen-libc++-filenames.js
* [FPF] Create Fingerprinting Protection ruleset service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5420158
* Add ExclusiveAccessPermissionManager
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5273787
* Preserve the PNG colorspace when decoding into a SkBitmap.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5421254
* chore: iwyu
* fix: abstract-socket compilation
* ci: bump container for node 20 support
* fixup! abstract-socket compilation
* fix: compiling nan specs
* chore: revert winreg version bump
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient
test suite. Should be revisited separately.
* ci: set node 20 for darwin x64 tests
* fix: broken patch export
* chore: cleanup mas_avoid_private_macos_api_usage.patch.patch
Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-04-15 18:10:32 -04:00
lauren n. liberda
6aa9a003c8
fix: stop using std::vector<const uint8_t> in ProcessingSingleton ( #41832 )
2024-04-15 10:32:48 -07:00
Shelley Vohr
2a6ad42113
chore: delete unused PrintPreviewMessageHandler ( #41841 )
2024-04-15 11:34:56 -04:00
lauren n. liberda
d80c5f8377
build: redundant regex character class in generate-config-gypi.py ( #41858 )
...
fix: redundant regex character class in generate-config-gypi.py
'\w' already includes '_'. solves a SyntaxWarning on python 3.12.
2024-04-15 11:33:55 -04:00
Erick Zhao
755f7d5ed0
docs: clarify before ready usage ( #41849 )
2024-04-15 10:38:58 -04:00
Cedrik Ewers
734395bea9
docs: use "id" instead of "label" for positions ( #41843 )
...
Co-authored-by: Cedrik Ewers <C.Ewers@beckhoff.com >
2024-04-14 17:10:09 -07:00
dependabot[bot]
75dae2e004
build(deps): bump tar from 6.1.13 to 6.2.1 in the npm_and_yarn group across 1 directory ( #41842 )
...
build(deps): bump tar in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [tar](https://github.com/isaacs/node-tar ).
Updates `tar` from 6.1.13 to 6.2.1
- [Release notes](https://github.com/isaacs/node-tar/releases )
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.13...v6.2.1 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-12 13:28:37 -07:00
Robo
b446ce7f22
fix: package <__assertion_handler> as part of libcxx headers ( #41830 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5208502
2024-04-12 23:50:03 +09:00
Mitchell Cohen
05fba85aa3
fix: do not activate app when showing a panel on Mac ( #41750 )
...
* fix: do not activate app when showing or focusing a panel on Mac
* restored panel activation test
2024-04-12 14:27:59 +02:00
Shelley Vohr
db11090e58
fix: silent printing default dpi on Windows ( #41811 )
2024-04-11 19:56:39 -04:00
Calvin
df22e62bf4
docs: update release timeline ( #41825 )
2024-04-11 19:37:47 -04:00
Erick Zhao
f8c832d80d
docs: update ASAR integrity tutorial ( #41828 )
...
* docs: document windows asar integrity
* docs: update ASAR integrity tutorial
* fix lint
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-04-11 13:41:58 -07:00
Shelley Vohr
344aba0838
feat: implement File System API support ( #41419 )
2024-04-10 22:06:47 +02:00
RoboSchmied
41ba963392
fix: typos in comment section of in_app_purchase.mm ( #41788 )
...
fix 2 typo
Signed-off-by: Michael Seibt <github@roboschmie.de >
2024-04-10 11:54:56 -04:00
Shelley Vohr
43a9f70d19
feat: support NODE_EXTRA_CA_CERTS ( #41689 )
...
* feat: support NODE_EXTRA_CA_CERTS
* chore: allow disabling NODE_EXTRA_CA_CERTS
* chore: call base::Environment::UnSetVar
* docs: link to fuses from env vars
* chore: update patch to match upstream
* docs: note enabled by default
* Update environment-variables.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-10 10:30:35 -04:00
Kaitlin Newson
0a7df0ef3d
docs: typo fix ( #41787 )
...
Typo fix
2024-04-10 10:25:13 +02:00
Shelley Vohr
38ef9a7690
refactor: move PDF viewer to OOPIF ( #41728 )
...
https://issues.chromium.org/issues/40268279
2024-04-09 19:59:48 -04:00
Shelley Vohr
ba3b647fd7
fix: WCO maximize button visibility when non-maximizable ( #41793 )
...
fix: WCO button visibility when non-maximizable
2024-04-09 13:14:29 +02:00
Jeremy Rose
76f7bbb0a8
fix: move BrowserWindow's WebContentsView to be a child of rootview ( #41256 )
2024-04-08 10:30:23 -07:00
Bruno Pitrus
22c149812c
build: add missing header for content::SyntheticGestureTarget ( #41789 )
...
IWYU: add missing header for `content::SyntheticGestureTarget`
GNU libstdc++ does not allow using std::unique_ptr on incomplete types,
leading to a compile error.
2024-04-08 18:17:00 +02:00
David Sanders
42164d7081
build: add Markdown lint check for unescaped angle brackets ( #41753 )
2024-04-04 14:50:35 -04:00
Calvin
3eb94b72ba
feat: Options parameter for Session.clearData API ( #41355 )
...
* feat: Options parameter for `Session.clearData` API
* Consolidate & curate data type categories
* Update docs for better typing
* off-by-one typo
* refactor to use `std::shared_ptr` instead of `base::RefCounted`
* fix compile errors
* std::enable_shared_from_this didn't work 🤷
* Refine docs with defaults
2024-04-01 12:09:01 -04:00
Keeley Hammond
752f2eb124
build: add GH Actions to release-build script ( #41639 )
...
* build: add GH Actions to release-build script
* Update script/release/ci-release-build.js
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-01 10:02:26 -04:00
Shelley Vohr
beafbfd511
build: combine ImportModuleDynamically patches ( #41712 )
...
build: combine ImportModuleDynamically patches
2024-03-29 13:34:56 +01:00
dependabot[bot]
d54645e554
build(deps-dev): bump express from 4.18.2 to 4.19.2 ( #41716 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 16:12:14 -07:00
Shelley Vohr
0bf53a3876
fix: Storage.{get|set|clear}Cookies via CDP not working ( #41718 )
2024-03-28 16:09:27 -07:00
Shelley Vohr
62d4b21819
test: disable flaky <webview>.capturePage() specs ( #41713 )
...
test: disable flaky <webview>.capturePage() specs
2024-03-28 22:37:14 +01:00
Shelley Vohr
61457c9498
feat(serial): allow Bluetooth ports to be requested by service class ID ( #41638 )
...
* feat(serial): allow Bluetooth ports to be requested by service class ID
* fix: bluetooth dependency
2024-03-28 18:23:13 +01:00
Jeremy Rose
c6102b9278
docs: add missing headers option to ClientRequest options ( #41723 )
2024-03-28 09:38:16 -07:00
daihere1993
72c2b9e862
fix: recognize 'undefined' header value in ClientRequest ( #41615 )
...
Co-authored-by: zowu <luke.wu@nokia-sbell.com >
2024-03-27 16:46:07 -07:00
Shelley Vohr
08241669bc
test: add tests for Storage Access API ( #41698 )
2024-03-27 19:52:24 +01:00
Samuel Attard
6e36153799
build: fix potential source of errors in issue workflow ( #41715 )
2024-03-27 09:50:55 -07:00
taoky
4f76fff978
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41691 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
2024-03-27 10:53:23 +01:00
Alice Zhao
c82ec0c72b
test: remove hardcoded url ( #41706 )
2024-03-27 10:53:02 +01:00
Alice Zhao
c57ce31e84
test: fix flaky tests in webContents.navigationHistory ( #41705 )
...
test: fix flaky tests by replacing real urls with data urls
2024-03-27 13:49:11 +09:00
Shelley Vohr
32b44aa5c8
fix: crash on extension unload when script validation finishes ( #41686 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5225796
2024-03-26 14:32:06 +01:00
Shelley Vohr
7032c0d03c
test: add test and api_feature definition for chrome.scripting.globalParams ( #41685 )
...
chore: add test and api_feature for chrome.scripting.globalParams
2024-03-26 12:33:47 +01:00
Erick Zhao
b9c4b27781
docs: backslash escape parametrized TypeScript types ( #41575 )
...
* docs: backslash escape parametrized TypeScript types
* missing instances
2024-03-25 11:19:44 +01:00
Shelley Vohr
8c427253b3
refactor: update gin_helper/function_template ( #41534 )
...
* refactor: update gin_helper/function_template
* fix: crash in Node.js Worker threads
2024-03-25 10:01:54 +01:00
Shelley Vohr
ed28ead8ac
fix: WTF-8 decoding issue in node:fs ( #41673 )
...
fix: WTF-8 decoding issue in node:fs
2024-03-24 20:39:37 +01:00
Piotr Płaczek
90a7e5acae
fix: normalize path before calling showItemInFolder and openPath ( #41642 )
...
* fix: normalize path before calling ShowItemInFolder
* fix: normalize path before calling OpenPath
2024-03-22 10:28:44 -04:00
Shelley Vohr
707b9a58cc
fix: app.setLoginItemSettings error getting swallowed by gin conversion ( #41647 )
...
* fix: errors getting swallowed by gin conversion
* fix: Windows build
* test: re-enable disabled test
2024-03-22 09:00:21 -04:00
Shelley Vohr
a32705fd30
test: add test for setJumpList arguments ( #41650 )
...
test: add test for setJumpList arguments
2024-03-21 19:01:54 -04:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41577 )
2024-03-21 14:59:23 -07:00
John Kleinschmidt
1036d824fe
ci: use CircleCI hosted macOS arm64 runners for testing ( #41649 )
2024-03-21 14:07:18 -04:00
Kenneth Gerald Hamilton
587b66acc1
docs: nodejs trademark policy link broken ( #41558 )
...
* Fix broken Trademark Policy link
* add durable link
Per codebyter: https://github.com/electron/electron/pull/41558#discussion_r1522938560
2024-03-21 10:25:35 -04:00
Shelley Vohr
040acaaf30
fix: support withFileTypes in fs.{readdir|readdirSync} ( #41627 )
...
fix: support withFileTypes in fs.{readdir|readdirSync}
2024-03-21 10:22:40 -04:00
David Sanders
dd3fd78e63
ci: automatically add the 'has-repro-gist' label ( #41646 )
...
ci: automatically add the 'has-gist-repro' label
2024-03-21 10:22:14 -04:00
Charles Kerr
61ddb1aa07
chore: bump pylint to 2.17 ( #41576 )
...
* build: bump pylint to 2.17
Xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345
* fix pylint consider-using-f-string warnings pt 1: use flynt for automated fixes
* fix pylint consider-using-f-string warnings pt 2: manual fixes
* fix pylint consider-using-with warnings
* fix pylint line-too-long warnings
* fix pylint unspecified-encoding warnings
* fix py lint consider-using-generator warning
* fixup! fix pylint unspecified-encoding warnings
* fix pylint line-too-long warnings
2024-03-21 09:48:23 -04:00
David Sanders
00da7279cb
ci: set issue status to triaged on status/{confirmed,reviewed} label ( #41645 )
2024-03-21 09:43:40 -04:00
electron-appveyor-updater[bot]
7609156ae1
build: update appveyor image to latest version ( #41617 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-20 11:50:10 -04:00
Shelley Vohr
66dec24e32
fix: serial-port-added should respect filters ( #41621 )
...
fix: serial-port-added should respect filters
2024-03-20 10:18:41 -04:00
Shelley Vohr
433d6c33d8
fix: missing badge text on Windows ( #41618 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5053607
2024-03-19 12:50:30 +01:00
Shelley Vohr
b02918883f
fix: support recursive readdir in Asar files ( #41582 )
2024-03-19 11:10:14 +01:00
Shelley Vohr
1cd7419718
build: work around ScreenCaptureKit bad feature flag parsing in Chromium ( #41622 )
2024-03-19 10:49:41 +01:00
Shelley Vohr
daecbb90fe
test: modify remote specs to allow skip or only ( #41620 )
2024-03-19 10:49:24 +01:00
electron-roller[bot]
193e162ec6
chore: bump chromium to 124.0.6359.0 (main) ( #41584 )
...
* chore: bump chromium in DEPS to 124.0.6355.0
* 5341411: view-transition: Ensure resources are cleaned up in all cases.
https://chromium-review.googlesource.com/c/chromium/src/+/5341411
* chore: fixup patch indices
* 5354013: Return nullopt on error from ProcessMetrics CPU measurements
https://chromium-review.googlesource.com/c/chromium/src/+/5354013
* chore: bump chromium in DEPS to 124.0.6357.0
* chore: update patches
* 5368769: Reland "[mojo] Use large worker for mojom_parser action"
https://chromium-review.googlesource.com/c/chromium/src/+/5368769
* 5336171: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5336171
* 5367334: [FS Shortcut] Refactor ExclusiveAccessManager
https://chromium-review.googlesource.com/c/chromium/src/+/5367334
* 5354161: Rename GeolocationManager to GeolocationSystemPermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5354161
* fixup: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
* chore: bump chromium in DEPS to 124.0.6359.0
* chore: update patches
* 5371370: [Extensions] Move core NativeHandler registration
https://chromium-review.googlesource.com/c/chromium/src/+/5371370
* 5370702: [Extensions] Introduce ShellExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5370702
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-15 14:03:42 -04:00
Fedor Indutny
3759e59bbd
fix: asan build on macos ( #41587 )
2024-03-15 13:06:43 +09:00
electron-appveyor-updater[bot]
41b2102d10
build: update appveyor image to latest version ( #41591 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-14 13:03:13 -04:00
Shelley Vohr
1bfd3e0631
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain ( #41538 )
...
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-14 09:50:52 +01:00
electron-appveyor-updater[bot]
122a2fd177
build: update appveyor image to latest version ( #41579 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-13 13:15:29 -04:00
Shelley Vohr
1840d7b7ee
fix: improve caption button appearance on Windows 11 ( #41561 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4428171
2024-03-13 10:58:48 -04:00
Shelley Vohr
6cb84ddbfb
test: disable transparency tests on macOS arm64 ( #41580 )
2024-03-13 15:05:10 +01:00
David Sanders
02020fbb63
build: update @electron/lint-roller to 1.11.1 ( #41522 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-13 11:14:10 +01:00
electron-roller[bot]
26752d3a06
chore: bump chromium to 124.0.6353.0 (main) ( #41566 )
...
* chore: bump chromium in DEPS to 124.0.6353.0
* chore: update patches
* 5365462: Add missing perfetto::Flow and TRACE_EVENT includes
https://chromium-review.googlesource.com/c/chromium/src/+/5365462
* 5356336: Ensure destruction of mojo channel when destructing KeySystemsImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5356336
* 5332839: [Extensions] Register NativeHandlers with the RendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5332839
* 5148827: Add permission types for keyboard lock and pointer lock [1/N]
https://chromium-review.googlesource.com/c/chromium/src/+/5148827
* 5358818: Revert "[object] Fast path for adding props with existing transition"
https://chromium-review.googlesource.com/c/v8/v8/+/5358818
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-13 09:44:49 +01:00
Shelley Vohr
80f34ecd2c
test: re-enable app.getGPUInfo() specs on Linux ( #41568 )
...
test: re-enable getGPUInfo() specs on Linux
2024-03-12 12:39:29 -04:00
Erick Zhao
2f133f5e28
docs: nativeImage api cleanup ( #41519 )
...
* docs: `nativeImage` api cleanup
* Update docs/api/native-image.md
* Update native-image.md
* Update docs/api/native-image.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* Update link to app icon
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
2024-03-12 12:33:56 -04:00
electron-roller[bot]
150c2bcef9
chore: bump chromium to 124.0.6351.0 (main) ( #41514 )
...
* chore: bump chromium in DEPS to 124.0.6339.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6341.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6343.0
* chore: bump chromium in DEPS to 124.0.6345.0
* chore: update patches
* build: temporarily patch out usage of reclient inputs cfg
* chore: implement missing OnPortConnectedStateChanged
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5039155
* fix: move NativeHandlers in extensions to new RendererAPIProvider
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5332839
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5334058
* chore: add missing websocket method
* refactor: use std::erase instead of base::Erase
Ref: https://issues.chromium.org/issues/40256229
* build: fix reclient inputs processor bug (workaround)
* fix: delay extensions::Dispatcher construction
* chore: bump chromium in DEPS to 124.0.6347.0
* chore: bump chromium in DEPS to 124.0.6349.0
* 5326217: [ViewsAX] Remove WebAXPlatformTreeManagerDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5326217
* 5347916: Get origin from parent for process-isolated srcdoc.
https://chromium-review.googlesource.com/c/chromium/src/+/5347916
* chore: patches fixup
* 4866222: [api] Deprecate vector<v8::Local>, part 1
https://chromium-review.googlesource.com/c/v8/v8/+/4866222
* 5337304: Remove DXDiag telemetry code.
https://chromium-review.googlesource.com/c/chromium/src/+/5337304
* 5328275: Implement watermark routing to the BrowserView
https://chromium-review.googlesource.com/c/chromium/src/+/5328275
* [libc++] Rename __fwd/hash.h to __fwd/functional.h and add reference_wrapper
* chore: bump chromium in DEPS to 124.0.6351.0
* chore: update patches
* 5342763: [object] Fast path for adding props with existing transition
https://chromium-review.googlesource.com/c/v8/v8/+/5342763
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-12 10:15:41 +01:00
Shelley Vohr
1252f92431
chore: remove 8088 from codespaces port forwarding ( #41557 )
2024-03-10 18:18:56 +01:00
electron-appveyor-updater[bot]
c0f9d0eeed
build: update appveyor image to latest version ( #41523 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-08 14:32:08 -05:00
Felix Rieseberg
4ec4efd3e5
docs: Update code signing documentation ( #41535 )
2024-03-08 10:02:39 -08:00
John Kleinschmidt
fb1b5ca4ce
test: disable CapturableScreen tests on Windows x64 ( #41543 )
...
* test: disable CapturableScreen tests on Windows x64
* test: disable js-execute-iframe" case should not crash on win 32-bit
2024-03-07 19:17:39 -05:00
Shelley Vohr
f826506218
fix: chrome://process-internals failing to load ( #41476 )
...
fix: chrome://process-internals failing to load
2024-03-07 15:31:16 +01:00
Shelley Vohr
62331f5ac1
chore: add missing gin::Wrappable GetTypeName overrides ( #41512 )
...
chore: add missing gin::Wrappable GetTypeName overrides
2024-03-06 12:45:28 +01:00
Shelley Vohr
a7d664e3a3
fix: user-did-{resign|become}-active events on macOS ( #41506 )
...
fix: user-did-{resign|become}-active events on macOS
2024-03-06 12:43:39 +01:00
Shelley Vohr
62a897b75b
chore: fix fs overrides for asar ( #41507 )
...
fix: fs overrides for asar
2024-03-06 10:39:30 +01:00
Shelley Vohr
cc7e80c4e3
docs: correct release timeline inaccuracy ( #41510 )
...
docs: correct timeline inaccuracy
2024-03-05 10:49:21 -08:00
electron-roller[bot]
9f673c859d
chore: bump chromium to 124.0.6331.0 (main) ( #41474 )
...
* chore: bump chromium in DEPS to 124.0.6329.0
* chore: update patches
* 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5321532: [//ui] Remove ContextFactory::SharedMainThreadContextProvider() | https://chromium-review.googlesource.com/c/chromium/src/+/5321532
* fixup! 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5319141: [OOPIF PDF] Create PdfNavigationThrottle for main frame navigations | https://chromium-review.googlesource.com/c/chromium/src/+/5319141
* test: disable webview.capturePage test for mac arm64
* chore: bump chromium in DEPS to 124.0.6337.0
* chore: update patches
* build: roll back DEPS to 124.0.6331.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2024-03-05 11:47:48 -05:00
Jeremy Rose
e67ab9a93d
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #41326 )
2024-03-04 09:32:40 -08:00
Cheng Zhao
814ba71dc1
chore: update src_preload_function_for_environment.patch ( #41500 )
2024-03-04 13:11:14 +01:00
David Sanders
cc9e21c260
build: update appveyor image to latest version ( #41483 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-03-01 15:54:10 -05:00
David Sanders
9565b7de74
chore: set wg-releases as CODEOWNER for AppVeyor configs ( #41485 )
2024-03-01 15:53:30 -05:00
Shelley Vohr
d5912fd05a
fix: webContents.print options should be optional ( #41467 )
2024-02-29 10:19:44 -05:00
Krzysztof Halwa
a0dad83ded
feat: Allow creation of new window to be customizable. ( #41432 )
2024-02-29 10:15:01 -05:00
electron-roller[bot]
04df5ce492
chore: bump chromium to 124.0.6323.0 (main) ( #41412 )
...
* chore: bump chromium in DEPS to 124.0.6315.0
* chore: update patches
* 5279678: Stream AIDA responses
https://chromium-review.googlesource.com/c/chromium/src/+/5279678
* 5276439: Remove non_network_url_loader_factory_remotes_
https://chromium-review.googlesource.com/c/chromium/src/+/5276439
* 5310165: Add DevTools API to show search results
https://chromium-review.googlesource.com/c/chromium/src/+/5310165
* chore: bump chromium in DEPS to 124.0.6317.0
* chore: update patches
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
https://chromium-review.googlesource.com/c/chromium/src/+/5314269
* browser: Make cmd line non-const in process singleton callback
https://chromium-review.googlesource.com/c/chromium/src/+/5311256
* chore: bump chromium in DEPS to 124.0.6319.0
* chore: bump chromium in DEPS to 124.0.6321.0
* chore: bump chromium in DEPS to 124.0.6323.0
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
https://chromium-review.googlesource.com/c/chromium/src/+/5318335
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
https://chromium-review.googlesource.com/c/chromium/src/+/5318051
* chore: fixup patch indices
* 4946553: Delegate HID permission to Chrome App in webview
https://chromium-review.googlesource.com/c/chromium/src/+/4946553
* 5310001: DevTools UI binding for reporting client events to AIDA
https://chromium-review.googlesource.com/c/chromium/src/+/5310001
* [libc++] Refactor the predicate taking variant of `__cxx_atomic_wait`
* chore: fix browser_view patch harder
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
https://chromium-review.googlesource.com/c/chromium/src/+/5293937
* fix: filter {video|audio} devices by eligible device id
* 5267921: enable speak content under the pointer on PWA and WV2
https://chromium-review.googlesource.com/c/chromium/src/+/5267921
* 5310195: heap: Remove Blink's GCTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/5310195
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-29 10:31:13 +01:00
David Sanders
13e601e35c
ci: verified commits for appveyor update PR ( #41470 )
2024-02-28 21:36:56 -08:00
Calvin
a6133e85d1
test: disable flaky macOS panel test & refactor screen capture testing ( #41441 )
...
* Disable flaky test
* Add helper for storing test artifacts
* Refactor screen capture tests
We have a pattern for inspecting a screen capture, so this refactor codifies that pattern into a helper. This gives us shorter test code, consistency (previously, the display in test code and the display captured could theoretically be different), and better debugging/observability on failure.
2024-02-28 12:54:20 +09:00
John Kleinschmidt
267c0796dd
ci: add logging to uploading to GitHub releases ( #41453 )
2024-02-27 19:55:08 -05:00
Shelley Vohr
b468b5e6e8
build: print error and retry on symstore fail ( #41452 )
2024-02-27 15:40:42 -08:00
Shelley Vohr
d89ad1106f
chore: add engflow-reclient-configs to gitignore ( #41447 )
2024-02-27 15:39:41 -08:00
Milan Burda
3885011220
chore: remove deprecated inputFieldType ( #41239 )
...
chore: remove deprecated inputFieldType
2024-02-26 07:47:16 -05:00
Milan Burda
3394ee71f0
chore: fix import from patches.py in script/lib/git.py ( #41430 )
2024-02-26 11:36:30 +09:00
Calvin
12d7a8ff66
feat: Session#clearData API ( #40983 )
...
* WIP: Session.clearBrowsingData API
* impl API method
* clean up
* tidy types and comments
* add docs
* add barebones test
* forgot a `#` :(
* tidy: address review comments
* use format macro for cross-platform build
* add another test
* amend docs to disambiguate
* Rename to `clearData`
2024-02-26 09:39:17 +09:00
Shelley Vohr
e95673b052
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} ( #41400 )
...
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
2024-02-23 10:35:20 +01:00
Robo
26131b23b8
feat: add support for configuring system network context proxies ( #41335 )
...
* feat: add support for configuring system network context proxies
* chore: add specs
* chore: fix lint
* fix: address review feedback
2024-02-22 12:08:25 -05:00
Shelley Vohr
136762b45f
build: don't modify deps/v8/tools paths ( #41386 )
...
build: don't modify deps/v8/tools paths
2024-02-22 11:35:06 -05:00
github-actions[bot]
d73a937375
build: update appveyor image to latest version-e-123.0.6312.5 ( #41408 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-22 11:10:52 -05:00
Samuel Attard
ddd93529d5
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher ( #41397 )
...
This fixes a nasty warning / permission dialog that pops up to end-users
when consuming legacy APIs. Chrome has flipped these flags via field trials
as have other Electron apps. It should just be the default.
2024-02-21 12:59:49 -08:00
electron-roller[bot]
e72f4f7f26
chore: bump chromium to 123.0.6312.5 (main) ( #41337 )
...
* chore: bump chromium in DEPS to 123.0.6300.2
* chore: bump chromium in DEPS to 123.0.6301.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6302.0
* chore: bump chromium in DEPS to 123.0.6304.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6306.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6308.0
* chore: update patches
* Refactor //components/pdf/common constants
https://chromium-review.googlesource.com/c/chromium/src/+/5292816
* Rename URLLoaderFactoryParams::is_corb_enabled to is_orb_enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5277040
* Add placeholder of speaker-selection permission.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5278243
* Move kPdfMimeType to //components/pdf/common/constants.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293155
* chore: gen-libc++-filenames.js
* Make GetClassName non virtual
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293075
Refs https://issues.chromium.org/issues/324596267
* chore: bump chromium in DEPS to 123.0.6310.0
* chore: update filenames.libcxx.gni
* 5282732: Compute input region using correct pixel size.
https://chromium-review.googlesource.com/c/chromium/src/+/5282732
* fixup: Make GetClassName non virtual
* chore: bump chromium in DEPS to 123.0.6312.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6312.5
* fixup: Make GetClassName non virtual
* docs: document speaker-selection
https://chromium-review.googlesource.com/c/chromium/src/+/5278243
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-02-21 15:27:05 -05:00
Keeley Hammond
f350cce64f
docs: update breaking changes language ( #41387 )
2024-02-21 11:25:53 -08:00
Keeley Hammond
94e643ab33
build: bump NMV to 123 for Electron 30 ( #41370 )
2024-02-21 10:02:36 -08:00
electron-roller[bot]
e87746ff0f
chore: bump node to v20.11.1 (main) ( #41353 )
...
* chore: bump node in DEPS to v20.11.1
* chore: update patches
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-21 12:49:20 -05:00
Keeley Hammond
136d7e7e6a
fix: check for draggable regions outside of main frame ( #41377 )
2024-02-20 19:10:43 -08:00
Charles Kerr
7cd23a4900
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient() ( #41347 )
...
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient()
- (perf) GetBlinkPreferences() returns a const&, so we can use that
reference instead of making a temporary copy
- (perf) Don't create url object unless it's needed.
- (refactor) Move is_main_world() and is_isolated_world() from the
header into an anonymous namespace in the .cc file so they can
be inlined and made constexpr
2024-02-20 13:29:11 +01:00
Keeley Hammond
995f3dc120
fix: revert to legacyMainResolve in JavaScript for asar compatibility ( #41367 )
2024-02-18 23:21:13 -08:00
Keeley Hammond
d0b4489b7d
ci: fix helperPath calls in ci configs ( #41363 )
...
* ci: fix helperPath calls in ci configs
Co-authored-by: codebytere <codebytere@electronjs.org >
* ci: fix helperPaths harder
---------
Co-authored-by: codebytere <codebytere@electronjs.org >
2024-02-17 15:04:36 -08:00
Michaela Laurencin
ca0920872d
chore: update breaking-changes.md to reflect WebContentsView revert ( #41361 )
2024-02-17 09:20:53 -08:00
Henrik Gaßmann
80906c0adb
fix: properly stream uploadData in protocol.handle() ( #41052 )
...
* refactor(protocol): extract file stream factory
Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
* fix: properly flatten streams in `protocol.handle()`
Refs: electron/electron#39658
* fix: `protocol.handle()` filter null origin header
Refs: electron/electron#40754
* fix: remove obsolete TODO comment
Refs: electron/electron#38929
* fix: forward `Blob` parts in `protocol.handle()`
Refs: electron/electron#40826
* fix: explicitly error out on unknown chunk parts
2024-02-16 14:29:29 -05:00
Shelley Vohr
d4413a8e53
chore: remove unused anonymous namespace methods ( #41333 )
2024-02-16 10:31:34 -06:00
Calvin
0356812026
docs: update release schedule for E30 ( #41339 )
2024-02-15 12:38:07 -08:00
github-actions[bot]
6acacf061c
build: update appveyor image to latest version - e-123.0.6296.0. ( #41350 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-15 14:56:41 -05:00
Samuel Attard
7d6a754d47
fix: skip the first two invalid updates when SCK is enabled ( #41340 )
2024-02-14 11:56:29 -08:00
electron-roller[bot]
0dad99561b
chore: bump chromium to 123.0.6296.0 (main) ( #41204 )
...
* chore: bump chromium in DEPS to 123.0.6273.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6274.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6276.0
* chore: update patches
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* chore: bump chromium in DEPS to 123.0.6278.0
* chore: bump chromium in DEPS to 123.0.6280.0
* chore: update patches
* chore: use net::CanonicalCookie::SecureAttribute()
renamed from IsSecure()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
* refactor: handle multiple requested device ids
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5132210
* refactor: trigger View layouts async with View::InvalidateLayout()
Upstream has introduced a PassKey to restrict who can call Layout()
directly. I've opted for calling `InvalidateLayout()` which is the
approach that upstream recommends.
If for some reason this approach doesn't work for us, we could use
`DeprecatedLayoutImmediately()` as a stopgap.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Xref: https://chromium.googlesource.com/chromium/src/+/main/ui/views/view.h#809
Xref: https://chromium.googlesource.com/chromium/src/+/main/docs/ui/learn/bestpractices/layout.md?pli=1#don_t-invoke-layout_directly
* chore: bump chromium in DEPS to 123.0.6282.0
* chore: bump chromium in DEPS to 123.0.6284.0
* chore: update patches
* refactor: remove use of blink::MainThreadIsolate() pt 1/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 2/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 3/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* chore: update enum name to ui::AXMode::kPDFPrinting
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5270301
* chore: rebuild filenames.libcxx.gni
* chore: sync with upstream rename of PortProvider.TaskForHandle()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5259103
* chore: bump chromium in DEPS to 123.0.6286.0
* chore: bump chromium in DEPS to 123.0.6288.0
* WebPreferences: Initialize in declaration.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5277099
* chore: update webview_fullscreen.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5053508
Simple update to fix patch shear
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5254861
Simple update to fix patch shear
* chore: add IWC::Delegate::RecordResize() stub to fix FTBFS
https://chromium-review.googlesource.com/c/chromium/src/+/5268963
* chore: add FormControlType::kButtonPopover to the FormControlType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
* chore: e patches all
* chore: node script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 123.0.6290.0
* chore: bump chromium in DEPS to 123.0.6291.0
* chore: bump chromium in DEPS to 123.0.6292.0
* chore: bump chromium in DEPS to 123.0.6294.0
* chore: update fix_aspect_ratio_with_max_size.patch
Xref: fix_aspect_ratio_with_max_size.patch
note: simple absl::optional -> std::optional conversion
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5272337
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; just adjusting line patch offsets
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5258688
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5281322
* chore: update fix_select_The_first_menu_item_when_opened_via_keyboard.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5279376
note: simple absl::optional -> std::optional conversion
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5268792
* chore: script/export_all_patches.py
* chore: bump chromium in DEPS to 123.0.6296.0
* chore: update patches
* fixup! chore: update feat_allow_code_cache_in_custom_schemes.patch
* fix: restore MessagePort close event
* spec: fix CORB testing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5231506
* fix: use sync layout when content view changes
* fixup! chore: update feat_configure_launch_options_for_service_process.patch
* Add remote-cocoa support for context menus.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5259806
* Rename //net/base/mac directory to //net/base/apple (1/n)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5211389
* fixup! Add remote-cocoa support for context menus.
* [Clipboard] Don't add meta charset tag for async write() method on Mac.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5187335
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-02-14 12:33:32 -05:00
David Sanders
7e241eef7c
ci: update GitHub actions workflow dependencies ( #41321 )
2024-02-14 11:13:03 +01:00
Mikhail Leliakin
79147e4dd8
fix: Ignore -webkit-app-region: drag; when window is in full screen mode. ( #41307 )
...
Co-authored-by: Mikhail Leliakin <lelyakin.aus@gmail.com >
2024-02-14 11:12:41 +01:00
Samuel Attard
32920af4b7
fix: add capability to use ScreenCaptureKit for thumbnail generation ( #41328 )
...
This aligns us with Chromiums flags / capabilities in regards to using SCK for
everything. Currently on 14.4 Electron apps will pop warnings for usage of
deprecated APIs. With this change and a few "enable-features" toggles.
`--enable-features="ScreenCaptureKitMac,ScreenCaptureKitStreamPickerSonoma,ThumbnailCapturerMac:capture_mode/sc_screenshot_manager"`
As Chromium enables these by default Electron will inherit those changes, apps wishing to skip ahead can apply these flags early.
2024-02-13 20:46:51 -08:00
Shelley Vohr
0218af9af0
fix: work around unarchivedObjectOfClass requiring secureCoding ( #41319 )
2024-02-13 19:08:03 -08:00
Charles Kerr
6a616ab70c
feat: allow custom refs for patch import & export ( #41306 )
...
* feat: allow custom refs for patch import & export
feat: add Patch-Dir metainfo, a sibling to Patch-Filename
* chore: copyediting
* refactor: minor copyediting
2024-02-12 10:05:53 -06:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54 .
2024-02-12 09:35:34 +01:00
Shelley Vohr
4ded4d16a8
fix: destroy NodeService message pipe last ( #41277 )
...
refactor: destroy NodeService message pipe last
2024-02-09 22:44:35 +01:00
Shelley Vohr
c894645ac6
fix: crash on macOS non-programmatic close ( #41264 )
2024-02-09 22:44:24 +01:00
Charles Kerr
9655ae7d6a
fix: GetCursorScreenpoint() sometimes wrongly returns (0,0) ( #41275 )
2024-02-09 09:44:46 -06:00
Charles Kerr
cee51785e1
refactor: inline simple getters, pt . 2 ( #41254 )
...
* refactor: inline AutofillPopup::line_count()
refactor: inline AutofillPopup::value_at()
refactor: inline AutofillPopup::label_at()
* refactor: inline NativeWindow::aspect_ratio()
refactor: inline NativeWindow::aspect_ratio_extra_size()
* refactor: inline BrowserProcessImpl::linux_storage_backend()
* refactor: inline ElectronMenuModel::sharing_item()
* refactor: inline Browser::badge_count()
* refactor: inline WebContents::is_guest()
refactor: inline InspectableWebContents::is_guest()
* refactor: inline InspectableWebContents::dev_tool_bounds()
* refactor: inline WebContents::type()
2024-02-09 10:29:14 +01:00
Charles Kerr
b253d52faf
build: export matching patches ( #41174 )
...
* build: make patches/config.json an array of objects
This file was previously an object of patch_dir keys to repo values;
Now is an array of objects containing `patch_dir` and `repo` properties.
This makes other per-target properties (e.g. `grep`) possible.
* build: include Note metadata when exporting patches
* build: support keyword filtering in export_patches()
* build: add optional `--grep` arg to git-export-patches script
* build: update export_all_patches to understand new config file
* fixup! build: update export_all_patches to understand new config file
chore: make lint happy
* fixup! build: make patches/config.json an array of objects
chore: fix oops
* refactor: remove support for the old file format
There is more code using config.json than I thought, so the
effort-to-reward of supporting the old format is not worth it.
* build: update apply_all_patches to understand new config file
* build: update lint.js to understand new config file
* build: update patches-mtime-cache.py to understand new config file
* fixup! build: update apply_all_patches to understand new config file
fix: oops
* fixup! build: update apply_all_patches to understand new config file
fix minor syntax wart
* fixup! build: support keyword filtering in export_patches()
refactor: use idiomatic python
* refactor: warn if config.json has an invalid repo
2024-02-08 13:47:59 -05:00
github-actions[bot]
4d060afc98
build: update appveyor image to latest version ( #41206 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-02-08 15:01:05 +01:00
Shelley Vohr
8eb580e79a
docs: note EXIF data unsupported in nativeImage ( #41261 )
...
* docs: note EXIF data unsupported in nativeImage
* Update docs/api/native-image.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 14:59:46 +01:00
Bogdan Cerovac
42087e306c
fix: add language to html in quick-start.md ( #41225 )
...
Add language to html in quick-start.md
We must define language in HTML for different reasons (accessibility++)
2024-02-08 10:27:50 +09:00
Milan Burda
2ea569e0d2
docs: fix docs/api/base-window.md ( #41240 )
...
* docs: fix docs/api/base-window.md
* Update docs/api/base-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-02-08 10:13:48 +09:00
Felix Rieseberg
4367c5ad9e
docs: Properly document runAsNode utility process option ( #41255 )
...
* docs: Properly document runAsNode utility process option
* Update docs/api/utility-process.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-02-06 15:54:36 -08:00
Cheng Zhao
92c5ff30a7
build: add flag for setting vendor version ( #41247 )
2024-02-06 14:23:17 -08:00
Charles Kerr
5686f88bd2
refactor: KeyWeakMap cleanup ( #41242 )
...
* refactor: make KeyWeakMap::KeyObject private
* perf: avoid redundant map lookup
* refactor: remove unused KeyWeakMap::Has()
* refactor: make KeyWeakMap dtor nonvirtual
no inheritance used, so no need for virtual dtor?
* chore: fix KeyWeakMap code comment
* refactor: use if statement in KeyWeakMap::Get()
* refactor: use better variable names in KeyWeakMap::Values()
2024-02-06 09:18:05 -06:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded() ( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Charles Kerr
08236f7a9e
refactor: remove deprecated BrowserContext::ResourceContext ( #41221 )
...
* refactor: remove ResourceContext* arg from GetNSSCertDatabaseForResourceContext()
* refactor: remove ResourceContext* arg from CertificateManagerModel::GetCertDBOnIOThread()
* refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
* refactor: remove unused forward declarations
* refactor: rename method to GetNSSCertDatabase()
* fixup! refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
chore: remove unneeded line
2024-02-05 18:12:34 -06:00
Shelley Vohr
5dfa9e3317
fix: original-fs import replacement ( #41209 )
...
fix: original-fs import replacement
2024-02-05 09:51:04 +01:00
wujinli
fb888a6989
fix: crash problem with message_port close event ( #41201 )
...
When worker_thread shutdown, it will destory context and close
message_port. In this case, it should not dispatch close event.
Because it forbid script running during NotifyContextDestroyed in
ContextLifecycleNotifier.
Now chromium has implemented close_event and will not crash,
so we remove the patch with #22532 and add one test.
2024-02-05 16:38:30 +09:00
marekharanczyk
398ca2a019
fix: make sure invalid URL loads promises are fulfilled. ( #41194 )
...
* fix: make sure invalid URL loads promisses are fulfilled.
* fixup! fix: make sure invalid URL loads promisses are fulfilled.
2024-02-05 16:36:51 +09:00
Milan Burda
dac29f9949
refactor: type-safe module imports / requires ( #41192 )
2024-02-05 16:36:28 +09:00
Kilian Valkhof
3ec04fd449
docs: add note about fuses to our security documentation ( #41210 )
...
* Add note about fuses to our security documentation
Additionally, add the missing #18 to the ToC.
* lint issues for security.md
* Update docs/tutorial/security.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
* move reference links to bottom of security.md
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-02-02 17:28:36 -06:00
Charles Kerr
2ebaebb603
refactor: replace use of deprecated base::JSONWriter::WriteJson() ( #41215 )
...
* refactor: use base::WriteJson() in ListValueToNSArray()
refactor: use base::WriteJson() in DictionaryValueToNSDictionary()
* refactor: use base::WriteJson() in Debugger::SendCommand()
* refactor: use base::WriteJson() in ScriptingExecuteScriptFunction::Run()
* refactor: use base::WriteJson() in HandleAccessibilityRequestCallback()
2024-02-02 12:25:58 -06:00
Sam Maddock
9bfa16ad7f
fix: typescript error for optional dependency ( #41202 )
2024-02-01 13:00:20 +09:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c )
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Sam Maddock <smaddock@slack-corp.com >
2024-01-31 17:04:13 -06:00
Sam Maddock
12870cafb7
fix: move nut-js to optional spec deps ( #41199 )
2024-02-01 07:35:09 +13:00
Shelley Vohr
e4d5dc138f
fix: select-usb-device should respect filters option ( #41166 )
...
fix: select-usb-device should respect filters option
2024-01-31 09:53:30 -05:00
Shelley Vohr
6df3443617
fix: validate printToPDF margins against pageSize ( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Sam Maddock
85bebfb180
test: draggable region allows moving window ( #41127 )
...
* chore: add nut.js
* test: dragging window updates position
* instantly move mouse position
* limit platforms to run drag tests on
* defer loading nut-js
2024-01-31 10:29:17 +01:00
Milan Burda
fb88375ab4
refactor: type-safe imports in lib/node/init.ts ( #41148 )
2024-01-31 08:38:56 +09:00
Charles Kerr
0e0a0bf724
fix: avoid potential CHECK() failure in DictionaryToRect() ( #41160 )
...
refactor: use gfx::Rect::Contains() instead of reinventing the wheel
perf: use base::Value::FindInt() to avoid redundant map lookups
2024-01-30 14:48:47 -06:00
Charles Kerr
08615b2d4e
refactor: simplify code by using base::Value::EnsureList() ( #41162 )
2024-01-30 14:48:09 -06:00
Shelley Vohr
90c7d6c823
fix: shouldPrintBackgrounds -> printBackground in webContents.printToPDF ( #41161 )
...
fix: shouldPrintBackgrounds -> printBackground
2024-01-30 14:47:55 -06:00
Shelley Vohr
6786fde576
docs: document printToPDF generateDocumentOutline option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Shelley Vohr
fc917985ae
fix: ensure WebContents before checking draggable region ( #41154 )
...
fix: ensure WebContents before checking draggable region
2024-01-30 11:53:19 +01:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
github-actions[bot]
4e19321ba8
build: update appveyor image to latest version ( #41134 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-29 14:12:59 -05:00
David Sanders
679a6589cd
chore: add extra links to issue template chooser ( #41135 )
2024-01-29 09:51:43 -05:00
Cheng Zhao
de76fc01ec
chore: fix outdated osk patch on main branch ( #41152 )
2024-01-29 15:35:33 +09:00
Cheng Zhao
2571396584
fix: update osk patch to fix more corner cases ( #41131 )
...
This is a follow up to https://github.com/electron/electron/pull/35921
that, it fixes more corner cases that on-screen-keyboard does not hide
for webviews.
This change has been applied in Teams for quite a while and should be
reliable enough to introduce to Electron.
2024-01-29 10:42:59 +09:00
Shelley Vohr
8104c7908a
fix: potential async_hooks crash in NotifyWindowRestore on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Cheng Zhao
db2bf1a0d1
fix: apply module search paths restriction on worker and child process ( #41118 )
2024-01-26 17:29:04 +09:00
electron-roller[bot]
6c9f9de40a
chore: bump chromium to 123.0.6264.0 (main) ( #41124 )
...
* chore: bump chromium in DEPS to 123.0.6264.0
* chore: update patches
* 5224145: Revert "Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'""
https://chromium-review.googlesource.com/c/chromium/src/+/5224145
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 18:57:47 -05:00
John Kleinschmidt
9e630eb66a
build: remove unneeded dlls in Windows zip ( #41120 )
...
* build: fixup zip manifest check on Windows
* build: remove unused dlls
2024-01-25 15:26:21 -05:00
electron-roller[bot]
1a0991a9b9
chore: bump chromium to 122.0.6261.6 (main) ( #40949 )
...
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* 5105227: [media_preview] Show requested device in permission bubble
https://chromium-review.googlesource.com/c/chromium/src/+/5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | https://chromium-review.googlesource.com/c/chromium/src/+/5190661
* 5206106: Make sure RenderFrameHosts are active when printing | https://chromium-review.googlesource.com/c/chromium/src/+/5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
https://chromium-review.googlesource.com/c/chromium/src/+/5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
https://chromium-review.googlesource.com/c/chromium/src/+/5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
https://chromium-review.googlesource.com/c/chromium/src/+/5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
https://chromium-review.googlesource.com/c/chromium/src/+/5171446
* 5213708: Move DownloadTargetInfo into components/download
https://chromium-review.googlesource.com/c/chromium/src/+/5213708
* extensions: Add a loader for Controlled Frame embedder scripts
https://chromium-review.googlesource.com/c/chromium/src/+/5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
https://chromium-review.googlesource.com/c/chromium/src/+/5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
https://chromium-review.googlesource.com/c/chromium/src/+/5170669
* 5178824: [Fullscreen] Record UKM data
https://chromium-review.googlesource.com/c/chromium/src/+/5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 12:46:30 -05:00
Charles Kerr
921da723b8
fix: dangling raw_ptr in OSRWHV destructor ( #41088 )
...
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`.
Since `delegated_frame_host_client_` was being destroyed first, that
pointer was dangling in the OSRWHV destructor.
Also, make these two unique_ptr fields `const` since they point to the
same objects for the lifespan of the OSRWHV.
2024-01-25 10:15:32 +09:00
Shelley Vohr
3e6a038af7
fix: draggable regions not working ( #41030 )
...
* fix: draggable regions not working
* fix: only support app regions for main frame
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-01-25 09:12:54 +09:00
Maikel Ortega Hernández
a05bfd332d
fix: on error, reset spawnedProcess ( #41033 )
...
reset spawnedProcess instance in case of error
2024-01-24 16:45:08 -06:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Cheng Zhao
d13a93fb61
chore: remove node patches by using the preload feature ( #41080 )
2024-01-24 09:54:32 -06:00
Cheng Zhao
031d636823
fix: only remove hijackable envs from foreign parent ( #41079 )
2024-01-24 09:51:27 -06:00
Max Schmitt
5ced88a90a
docs: update Playwright automated-testing guide ( #41081 )
2024-01-24 09:50:55 -06:00
Charles Kerr
1af9612edf
fix: ElectronBrowserContext::PartitionKey comparisons ( #41055 )
...
* fix: ElectronBrowserContext::PartitionKey comparisons
Use c++20 default comparisons to simplify + fix PartitionKey sorting:
- The equality operator is broken. `PartitionKey{"foo", false}` is both
equal, to and less than, `PartitionKey{"foo", true}`
- For some keys, the same session can be retrieved via both `fromPath()`
and `fromPartition()`. This use case was discussed and removed from
the original PR after code review said "always returning different
sessions feels lower maintenance." The current behavior is a bug that
comes from the comparison operators not checking the keys' types.
Xref: 3f1aea9af9 (r1099745359)
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed
* fixup! fix: ElectronBrowserContext::PartitionKey comparisons
2024-01-23 09:41:44 -06:00
Valerius Petrini
1300e83884
docs: fixed typos and grammatical errors ( #40966 )
...
* docs: fixed typos
* Update docs/tutorial/performance.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* Update performance.md
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-01-19 08:21:42 -06:00
Michaela Laurencin
03a3deca18
ci: add stale-exempt label to exempt issues from automation ( #41031 )
2024-01-18 16:57:49 -05:00
electron-roller[bot]
f4ee3c1b2a
chore: bump node to v20.11.0 (main) ( #40941 )
...
* chore: bump node in DEPS to v20.11.0
* module: bootstrap module loaders in shadow realm
https://github.com/nodejs/node/pull/48655
* src: add commit hash shorthand in zlib version
https://github.com/nodejs/node/pull/50158
* v8,tools: expose necessary V8 defines
https://github.com/nodejs/node/pull/50820
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* esm: fallback to readFileSync when source is nullish
https://github.com/nodejs/node/pull/50825
* vm: allow dynamic import with a referrer realm
https://github.com/nodejs/node/pull/50360
* test: skip test-diagnostics-channel-memory-leak.js
https://github.com/nodejs/node/pull/50327
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* lib: fix assert throwing different error messages in ESM and CJS
https://github.com/nodejs/node/pull/50634
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* deps: update base64 to 0.5.1
https://github.com/nodejs/node/pull/50629
* src: avoid silent coercion to signed/unsigned int
https://github.com/nodejs/node/pull/50663
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* chore: fix patch indices
* chore: update patches
* test: disable TLS cipher test
This can't be enabled owing to BoringSSL incompatibilities.
https://github.com/nodejs/node/pull/50186
* fix: check for Buffer and global definition in shadow realm
https://github.com/nodejs/node/pull/51239
* test: disable parallel/test-shadow-realm-custom-loader
Incompatible with our asar logic, resulting in the following failure:
> Failed to CompileAndCall electron script: electron/js2c/asar_bundle
* chore: remove deleted parallel/test-crypto-modp1-error test
* test: make test-node-output-v8-warning generic
https://github.com/nodejs/node/pull/50421
* chore: fixup ModuleWrap patch
* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream
* fix: sandbox is not enabled on arm
* chore: disable v8 sandbox on ia32/arm
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-18 16:16:45 -05:00
github-actions[bot]
6ea7da4b90
build: update appveyor image to latest version ( #40951 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2024-01-18 16:08:00 -05:00
Guo Hao (Andrew) Lay
135c542555
feat: Windows integrity check ( #40504 )
...
* Add Windows integrity check feature into Electron
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Add integrity checker header file to sources
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Moved integrity checker after checking command line args
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
* Revert previous Windows integrity check commits (2379a60 , 331cf3c , a3c47ec )
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Implement asar header integrity for Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Fix Archive::RelativePath() on Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com >
* Address comments.
* Address Windows integrity check PR comments.
* Update absl::optional to std::optional.
* Fix spelling.
---------
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com >
Co-authored-by: Weiyun Dai <weiyund@amazon.com >
Co-authored-by: Weiyun Dai <35878488+WeiyunD@users.noreply.github.com >
2024-01-19 09:00:49 +13:00
John Kleinschmidt
3dafb318a8
test: fixup assertNotWindows ( #41045 )
...
* chore: fixup assertNotWindows
* remove logging
2024-01-18 14:04:43 -05:00
Shelley Vohr
7e6fb97a2f
fix: crash when dialog.showMessageBoxSync with missing buttons ( #40996 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
* chore: feedback from review
2024-01-18 13:21:15 +01:00
Shelley Vohr
df7f07a8af
fix: modal rounding on nonmodal windows ( #41003 )
...
* fix: modal rounding on nonmodal windows
* chore: feedback from review
2024-01-18 09:59:54 +01:00
Tamás Zahola
f97d8719e6
fix: use HasStyleMask(NSWindowStyleMaskResizable) instead of IsResizable() for enabling/disabling window maximize button ( #40994 )
2024-01-17 18:23:41 +01:00
Charles Kerr
021592200e
refactor: remove deprecated ToInternalValue() ( #40980 )
...
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad()
* refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem()
* chore: rename temp variable to now_usec for clarity
2024-01-17 10:17:43 -05:00
Shelley Vohr
6803624576
fix: check for Node.js-created module when contextIsolation disabled ( #40993 )
2024-01-16 14:29:00 +01:00
Robo
4949c4c4e1
chore: fix building blink_tests target ( #40982 )
2024-01-16 12:24:14 +01:00
Shelley Vohr
61f619a5e6
ci: correctly export RBE_experimental_credentials_helper_args ( #40997 )
2024-01-15 19:48:10 +01:00
Charles Kerr
b3e01220cb
refactor: fix deprecated base::Base64Encode() API calls ( #40962 )
...
* refactor: replace deprecated Base64Encode() usage in IWC::NetworkResourceLoader::OnDataReceived()
* refactor: replace deprecated Base64Encode() usage EncodeToken(const base::UnguessableToken& token)
2024-01-15 11:01:35 +01:00
Charles Kerr
80b220d214
refactor: use base::NoDestructor instead of base::LazyInstance ( #40947 )
...
* refactor: use NoDestructor for g_io_thread_application_locale
* refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance()
* refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
* refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
* chore: remove unused #include
* fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
make sure instance is static
* chore: remove unused #include "base/lazy_instance.h"
2024-01-12 14:50:29 +01:00
Shelley Vohr
57b29903e3
build: log got error response bodies ( #40965 )
2024-01-12 14:37:39 +01:00
Samuel Attard
bbfe809d02
docs: add reclient docs, remove goma docs ( #40948 )
...
* docs: add reclient docs, remove goma docs
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-01-12 13:50:20 +13:00
Keeley Hammond
e83192adba
ci: revert CI git cache removal ( #40964 )
...
* Revert "ci: increase "gclient sync" output timeout (#40963 )"
This reverts commit be4eb4e8a7 .
* Revert "build: remove CI cache of git cache (#40953 )"
This reverts commit b39ebb8625 .
2024-01-11 13:51:19 -08:00
Keeley Hammond
be4eb4e8a7
ci: increase "gclient sync" output timeout ( #40963 )
...
ci: increase gclient output timeout
2024-01-11 11:56:22 -08:00
Samuel Attard
8b9eb518a9
build: fix windows remote exec of python actions ( #40958 )
2024-01-11 07:17:35 -08:00
Shelley Vohr
d5d162b622
fix: InAppPurchase pre-emptive deallocation ( #40938 )
...
* fix: InAppPurchase pre-emptive deallocation
* test: try re-enabling IAP tests
2024-01-11 13:32:29 +01:00
Samuel Attard
b39ebb8625
build: remove CI cache of git cache ( #40953 )
2024-01-11 23:29:49 +13:00
electron-roller[bot]
2e4e6f10de
chore: bump chromium to 122.0.6236.2 (main) ( #40871 )
...
* chore: bump chromium in DEPS to 122.0.6223.0
* 5129828: Removes special cases for selenium-atoms dependencies.
https://chromium-review.googlesource.com/c/chromium/src/+/5129828
* chore: fixup patch indices
* 5139789: Deduplicate BrowserContext's ResourceContext
https://chromium-review.googlesource.com/c/chromium/src/+/5139789
* 5148579: Simplify SelectFileDialog::Listener
https://chromium-review.googlesource.com/c/chromium/src/+/5148579
* 5134038: Code Health: Use string_view in base::i18n::BreakIterator::SetText
https://chromium-review.googlesource.com/c/chromium/src/+/5134038
* 5137427: Code Health: Use string_view in SpellCheck::SpellCheckWord
https://chromium-review.googlesource.com/c/chromium/src/+/5137427
* [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left
Notable things in this commit:
* refactors `__indirect_binary_left_foldable`, making it slightly
different (but equivalent) to _`indirect-binary-left-foldable`_, which
improves readability (a [patch to the Working Paper][patch] was made)
* omits `__cpo` namespace, since it is not required for implementing
niebloids (a cleanup should happen in 2024)
* puts tests ensuring invocable robustness and dangling correctness
inside the correctness testing to ensure that the algorithms' results
are still correct
[patch]: https://github.com/cplusplus/draft/pull/6734
* chore: bump chromium in DEPS to 122.0.6224.0
* 5154766: [Refresh 2023] [GTK] Fix gap above toolbar with fractional scaling
https://chromium-review.googlesource.com/c/chromium/src/+/5154766
* chore: fixup patch indices
* 5094458: Remove extra CGColorSpace parameters from skia and ui helpers
https://chromium-review.googlesource.com/c/chromium/src/+/5094458
* chore: bump chromium in DEPS to 122.0.6226.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6227.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6228.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6230.0
* chore: bump chromium in DEPS to 122.0.6232.0
* chore: bump chromium in DEPS to 122.0.6234.0
* chore: bump chromium in DEPS to 122.0.6236.2
* chore: update patches
* fix: remove --disable-color-correct-renderering
Per https://electronhq.slack.com/archives/CB6CG54DB/p1698444047862459 it is not used any more and was never documented.
* chore: add WEB_PRINTING to content permission converter
Unused in non-cros so no need to document
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5136178
* chore: Views is now vec<raw_ptr> instead of raw<T*>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5140028
* spec: add Iterator to global intrinsics
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-01-11 19:33:40 +13:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Charles Kerr
fac964ac0d
refactor: migrate deprecated LazyInstance code to NoDestructor ( #40927 )
...
* refactor: do not use deprecated NoDestructor in javascript_environment.cc
* refactor: do not use deprecated NoDestructor in window_list.cc
2024-01-10 14:01:49 -06:00
David Sanders
c2c64d27fd
ci: fix missing inputs for release project board automation ( #40726 )
2024-01-10 13:25:11 +01:00
Samuel Attard
d5c658545a
chore: fix content tracing flake ( #40939 )
...
* chore: fix contentTracing test
* cry
2024-01-11 01:13:36 +13:00
Samuel Attard
ebf9a49fba
build: use container runner for arm tests ( #40875 )
...
* build: use aks arm64 test runners
* build: better image
* build: even more stuff
* build: arm par
* build: use aks arm32
* build: arm32 par
* build: get test timings from abs paths
* build: avoid realpath, use echo
2024-01-10 13:12:19 +13:00
Samuel Attard
3afb012ad1
build: add infra for reclient support ( #40850 )
...
* chore: add patch to always set macos platform for x-build
* build: add infra for reclient support
* build: override reclient version
* build: use RBE in CI
* chore: hardcode reclient fix version
* build: lower process count on macOS
* build: use large macOS instance for testing-arm64
* Revert "build: use large macOS instance for testing-arm64"
This reverts commit 6844adfd00a5230e68234112dfd84caa50d3f621.
* build: login in via helper not writing file
* chore: update patches
* build: use recelint from DEPS
* build: fix windows reproxy cfg
* build: use reclient in appveyor
* build: update WOA job too
* build: force another build
* build: do not checkout reclient
2024-01-10 10:19:42 +13:00
Shelley Vohr
c184b93fc5
fix: crash using powerMonitor before ready event ( #40888 )
...
* fix: crash using powerMonitor before ready event
* refactor: continue using DBusBluezManagerWrapperLinux
2024-01-09 09:41:42 +01:00
Charles Kerr
7b4d490bfe
perf: use fixed-size arrays for the font cache ( #40898 )
...
refactor: use fixed-size arrays for the font cache
Since we know at compile time which [family x script] combos we want to
cache, we can hold the cache in fixed std::arrays instead of in nested
std::unordered_maps.
2024-01-08 10:31:02 +01:00
Calvin
37630a6128
fix: wide string concatenation ( #40892 )
...
* fix: wide string concatenation
* Use wstring_views to keep length in context
* forgot a space, oopsies
2024-01-07 22:02:20 -08:00
Shelley Vohr
3a22fd3216
docs: add missing vibrancy breaking change ( #40893 )
...
docs: add missing vibranch change
2024-01-07 13:56:52 -08:00
Charles Kerr
73e7125041
chore: do not inject DXVA_Decoding trace category ( #40891 )
...
This doesn't need to be injected. Looks like it was an accident in
60ca38fb for https://github.com/electron/electron/pull/38465 .
2024-01-05 17:54:41 -06:00
Tamás Zahola
cc1b64e01c
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable ( #40705 )
...
* fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable
* add test
* fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`
2024-01-05 12:15:35 -05:00
Charles Kerr
22970f573b
perf: use flat_set, flat_map for small, trivially-moved containers ( #40817 )
...
* refactor: use base::flat_map in ElectronMenuModel
* refactor: use base::flat_map in BuildSubmenuFromModel()
* refactor: use base::flat_map in GetDialogsMap()
* refactor: use base::flat_map in DesktopCapturer
* refactor: use base::flat_map, flat_set in ElectronBrowserClient
* refactor: use base::flat_map in ProxyingURLLoaderFactory
* refactor: use base::flat_map in MapToCommonId()
* refactor: use base::flat_map for g_map_id
* refactor: use base::flat_map for ViewsDelegate::AppbarAutohideEdgeMap
* refactor: use base::flat_map for App::app_metrics_
* refactor: use base::flat_map for PowerSaveBlocker::wake_lock_types_
* refactor: use base::flat_map for NativeImage::hicons_
* refactor: use base::flat_map for MenuViews::menu_runners_
* refactor: use base::flat_map for WebViewManager::web_contents_embedder_map_
* refactor: use base::flat_map for InspectableWebContents::extensions_api_
* refactor: use base::flat_set for libnotify GetServerCapabilities()
* refactor: use base::flat_set for InspectableWebContents::loaders_
* refactor: use base::flat_set for ElectronRendererClient::environments_
refactor: use base::flat_set for ElectronRendererClient::injected_frames_
* refactor: use base::flat_set for WebWorkerObserver::environments_
2024-01-05 12:18:31 +01:00
Brandon Fowler
5086071294
feat: add transparent webpreference to webview ( #40301 )
...
* feat: add transparent option to WebContents
* feat: add transparent attribute to webview
* test: add tests for webview transparent attribute
* docs: add transparent attribute to webview docs
* fix: run tests on macOS only
* refactor: remove unneeded html tag
* fix: only apply transparent option to guests
* refactor: correct comment
* refactor: use opaque instead
Retains current webview behaviour by default.
* fix: correct variable name to guest_opaque_
* refactor: use transparent webpreference
* docs: remove unused web preference
* fix: uncomment condition for transparency test
* docs: converted to list format and linked to MDN
* fix: make webviews transparent by default again
* fix: rebase error
---------
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-05 13:00:27 +09:00
Devraj Mehta
8c71e2adc9
feat: add net module to utility process ( #40017 )
...
* chore: initial prototype of net api from utility process
* chore: update url loader to work on both browser and utility processes
* chore: add net files to utility process bundle
* chore: re-add app ready check but only on main process
* chore: replace browser thread dcheck's with sequence checker
* refactor: move url loader from browser to common
* refactor: move net-client-request.ts from browser to common
* docs: add utility process to net api docs
* refactor: move net module app ready check to browser only
* refactor: switch import from main to common after moving to common
* test: add basic net module test for utility process
* refactor: switch browser pid with utility pid
* refactor: move electron_api_net from browser to common
* chore: add fetch to utility net module
* chore: add isOnline and online to utility net module
* refactor: move net spec helpers into helper file
* refactor: break apart net module tests
Adds two additional net module test files: `api-net-session-spec.ts` for
tests that depend on a session being available (aka depend on running on
the main process) and `api-net-custom-protocols-spec.ts` for custom
protocol tests. This enables running `api-net-spec.ts` in the utility
process.
* test: add utility process mocha runner to run net module tests
* docs: add utility process to net module classes
* refactor: update imports in lib/utility to use electron/utility
* chore: check browser context before using in main process
Since the browser context supplied to the SimpleURLLoaderWrapper can now
be null for use in the UtilityProcess, adding a null check for the main
process before use to get a more sensible error if something goes wrong.
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* chore: remove test debugging
* chore: remove unnecessary header include
* docs: add utility process net module limitations
* test: run net module tests in utility process individually
* refactor: clean up prior utility process net tests
* chore: add resolveHost to utility process net module
* chore: replace resolve host dcheck with sequence checker
* test: add net module tests for net.resolveHost
* docs: remove utility process limitation for resolveHost
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2024-01-04 16:20:37 -05:00
Charles Kerr
f229201f41
refactor: make NativeWindow getter methods const ( #40804 )
...
* refactor: make NativeWindow getter methods const
* fixup! refactor: make NativeWindow getter methods const
make GetZOrderLevel() const
* fixup! refactor: make NativeWindow getter methods const
fix oops
2024-01-04 09:51:59 -06:00
Mathew Bino
3a06047e61
docs: note accelerator case insensitivity ( #40783 )
...
* Fix PR#38673
As requested in PR#38673 , a line has been added that explicitly states that accelerators are case sensitive
* Update docs/api/accelerator.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update accelerator.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-01-04 10:06:12 -05:00
Jeremy Rose
84ba0c6c7d
fix: BrowserView and <webview> should be transparent by default ( #40866 )
2024-01-04 10:04:56 -05:00
Keeley Hammond
0672f59f26
chore: add disclaimer to release timeline ( #40717 )
...
* chore: add disclaimer to release timeline
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2024-01-04 10:01:40 -05:00
Cheng Zhao
dfce1a9eb4
fix: ignore all NODE_ envs from foreign parent in node process ( #40770 )
...
* fix: ignore all NODE_ envs from foreign parent
* fix: recognize ad-hoc signed binary
2024-01-04 16:34:08 +09:00
Shelley Vohr
baca2e302d
chore: drop ada ICU requirement for parsing hostnames ( #40860 )
2024-01-03 13:58:28 -05:00
electron-roller[bot]
8c89137ecd
chore: bump chromium to 122.0.6194.0 (main) ( #40750 )
...
* chore: bump chromium in DEPS to 122.0.6180.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532
minor manual changes to match upstream changes
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
* chore: update feat_add_onclose_to_messageport.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
no manual changes; patch applied with fuzz 1
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072
minor manual changes to match upstream changes
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481
no manual changes; patch applied with fuzz 2
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
* Remove performActionOnRemotePage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017
It appears it is not used by anything within Chromium or outside.
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872
The copy construtor is more expensive and has been removed upstream
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614
* chore: e patches all
* chore: bump chromium to 122.0.6181.0
* chore: e patches all
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
* chore: make lint happy
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
upstream reverted this change
* chore: bump chromium in DEPS to 122.0.6182.0
* chore: update patches
* chore: fix virtual function names that were renamed upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989
* chore: node script/gen-libc++-filenames.js
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
* chore: bump chromium in DEPS to 122.0.6184.0
* chore: bump chromium in DEPS to 122.0.6186.0
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619
minor manual changes to match upstream changes
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922
minor manual changes to match upstream changes
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595
no manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: bump chromium in DEPS to 122.0.6188.0
* chore: bump chromium in DEPS to 122.0.6190.0
* chore: bump chromium in DEPS to 122.0.6192.0
* chore: bump chromium in DEPS to 122.0.6194.0
* Remove an unnecessary DCHECK which causes Lacros to crash.
https://chromium-review.googlesource.com/c/chromium/src/+/5124880
* [FixIt Week] Add shared regular profile function that includes ash
https://chromium-review.googlesource.com/c/chromium/src/+/5100709
* Simplify the PrintManagerHost::ScriptedPrint() call
https://chromium-review.googlesource.com/c/chromium/src/+/5019703
* [local compile hints] Add tests
https://chromium-review.googlesource.com/c/chromium/src/+/5024173
* chore: update patches
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: node script/gen-libc++-filenames.js
* Remove //ui/ozone/buildflags.h
https://chromium-review.googlesource.com/c/chromium/src/+/5119048
* fixup! Remove //ui/ozone/buildflags.h
* fixup! Remove //ui/ozone/buildflags.h
* chore: update patches
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
* fixup! Remove //ui/ozone/buildflags.h
* Add permission policy verification in PermissionControllerImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5059112
* fix: ensure spellcheck interface is registered for frame
* [exceptions] Unify pending and scheduled exceptions
https://chromium-review.googlesource.com/c/v8/v8/+/5050065
* fix: dchecks in node.js tests
* fix: try adding termination check
* chore: document breaking iframe change
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-03 09:52:49 +01:00
Jeremy Rose
be4e4ff11b
fix: make grant_file_protocol_extra_privileges fuse also block CORS fetches ( #40801 )
2024-01-02 13:06:33 -08:00
Bruno Henrique da Silva
a208d45aca
fix: titlebar incorrectly displayed on frameless windows ( #40749 )
...
* fix: titlebar incorrectly displayed on frameless windows
* fix: enable transparency for Mica windows
* Refactor ShouldWindowContentsBeTransparent
---------
Co-authored-by: clavin <clavin@electronjs.org >
2024-01-02 13:59:47 -05:00
Charles Kerr
7995c56fb0
refactor: use a FixedFlatMap for v8 converting ui::MenuSourceType ( #40786 )
2023-12-20 17:44:17 -06:00
Nikhil Simon Toppo
ab2a4fd836
docs: corrected the ipcMain import path ( #40764 )
...
Update tutorial-3-preload.md
corrected the import path for ipcMain
2023-12-19 12:30:48 -06:00
Keeley Hammond
95d094d75b
fix: add partition alloc check for MacOS 13/14+ ( #40757 )
2023-12-14 13:47:31 -08:00
Jeremy Rose
ba97679901
ci: re-comment pdb.zip download in appveyor.yml ( #40758 )
2023-12-14 12:24:05 +01:00
Jeremy Rose
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
Tamás Zahola
a94fb2cb5d
fix: don't reject loadURL() promise from did-fail-load - use did-finish-load instead ( #40661 )
2023-12-12 11:45:14 -08:00
Kishanjay
80d85c0e8e
fix: incorrectly mapped toggleDevTools in custom menu fiddle ( #40703 )
2023-12-12 11:36:34 -08:00
Jeremy Rose
66b2f697ea
build: remove dcheck.patch ( #40744 )
...
chore: remove dcheck.patch
2023-12-12 12:01:02 +01:00
Robo
83f15bd957
chore: cleanup tests creating crashpad handler in the test runner process ( #40668 )
...
* chore: cleanup tests creating crashpad handler in the test runner process
* ci: logging
* ci: enable logging
* ci: more logging
* ci: run all tests
* ci: more logging
* ci: increase timeout
* Revert "ci: increase timeout"
This reverts commit 870f74455d .
* Revert "ci: more logging"
This reverts commit 46837f8b3a .
* Revert "ci: run all tests"
This reverts commit 6a7889ce67 .
* Revert "ci: more logging"
This reverts commit 351473ab43 .
* Revert "ci: enable logging"
This reverts commit 194109ed5a .
* Revert "ci: logging"
This reverts commit 9a3396fc7a .
* chore: disable flaky ia32 tests
2023-12-12 19:38:42 +09:00
Keeley Hammond
a6417cc265
build: remove font flooding in devtools patch ( #40746 )
2023-12-12 10:13:31 +01:00
electron-roller[bot]
08a51f3339
chore: bump chromium to 121.0.6159.0 (main) ( #40632 )
...
* chore: bump chromium in DEPS to 121.0.6154.0
* chore: bump chromium in DEPS to 121.0.6155.0
* fix patches
* chore: update patches
* patch out reference to GetOcclusionTracker
* un-flag PIPOcclusionTracker
* chore: bump chromium in DEPS to 121.0.6157.0
* fix conflicts
https://chromium-review.googlesource.com/c/chromium/src/+/5038807
* add PIP occlusion tracker sources to chromium_src
* 5037591: Replace feature_list's Initialize* methods with Init*.
https://chromium-review.googlesource.com/c/chromium/src/+/5037591
* 4811903: Move //content/browser/renderer_host/input/synthetic_gesture_controller to //content/common/input
https://chromium-review.googlesource.com/c/chromium/src/+/4811903
* 4917953: usb: Add usb-unrestricted to permission policy
https://chromium-review.googlesource.com/c/chromium/src/+/4917953
* 5072395: Remove unused `creation_context` parameter from blink/public APIs
https://chromium-review.googlesource.com/c/chromium/src/+/5072395
* 5052035: [X11] Change AtomCache from a singleton to owned by Connection
https://chromium-review.googlesource.com/c/chromium/src/+/5052035
* fix v8/.patches
* node script/gen-libc++-filenames.js
* 5035771: Remove the SetImage method of ImageButton
https://chromium-review.googlesource.com/c/chromium/src/+/5035771
* fixup! 5052035: [X11] Change AtomCache from a singleton to owned by Connection
* fixup! 5035771: Remove the SetImage method of ImageButton
* chore: bump chromium in DEPS to 121.0.6159.0
* 4505903: [Extensions] Add lastAccessed property to chrome.tabs.Tab
https://chromium-review.googlesource.com/c/chromium/src/+/4505903
* update patches
* don't duplicate tabs API types
this causes weird memory bugs if the two get out of sync
* fix UAF in TrayIconCocoa
not sure why this is popping up just now ... this has been broken for ages afaict
* Revert "don't duplicate tabs API types"
This reverts commit 80dff2efaa .
This is failing tests with extensions API schema check failures, so
revert for now. we'll fix it later.
* revert v8 change causing node crashes
* chore: reduce diffs in revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-12-11 14:58:26 -06:00
electron-roller[bot]
890a557eed
chore: bump node to v20.10.0 (main) ( #40675 )
...
* chore: bump node in DEPS to v20.10.0
* chore: update feat_initialize_asar_support.patch
no code changes; patch just needed an update due to nearby upstream changes
Xref: https://github.com/nodejs/node/pull/49986
* chore: update pass_all_globals_through_require.patch
no manual changes; patch applied with fuzz
Xref: https://github.com/nodejs/node/pull/49657
* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls
Xref: https://github.com/nodejs/node/pull/49912
no code changes; patch just needed an update due to nearby upstream changes
* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch
Xref: https://github.com/nodejs/node/pull/49986
minor manual changes needed to sync with upstream change
* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/50096
Xref: https://github.com/nodejs/node/pull/50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this
Xref: https://github.com/nodejs/node/pull/49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream
* fix: lazyload fs in esm loaders to apply asar patches
* https://github.com/nodejs/node/pull/50127
* https://github.com/nodejs/node/pull/50096
* esm: jsdoc for modules code
https://github.com/nodejs/node/pull/49523
* test: set test-cli-node-options as flaky
https://github.com/nodejs/node/pull/50296
* deps: update c-ares to 1.20.1
https://github.com/nodejs/node/pull/50082
* esm: bypass CommonJS loader under --default-type=module
https://github.com/nodejs/node/pull/49986
* deps: update uvwasi to 0.0.19
https://github.com/nodejs/node/pull/49908
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* crypto: account for disabled SharedArrayBuffer
https://github.com/nodejs/node/pull/50034
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* src: generate snapshot with --predictable
https://github.com/nodejs/node/pull/48749
* chore: fixup patch indices
* fs: throw errors from sync branches instead of separate implementations
https://github.com/nodejs/node/pull/49913
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* esm: detect ESM syntax in ambiguous JavaScrip
https://github.com/nodejs/node/pull/50096
* fixup! test: fix edge snapshot stack traces
* esm: unflag extensionless ES module JavaScript and Wasm in module scope
https://github.com/nodejs/node/pull/49974
* [tagged-ptr] Arrowify objects
https://chromium-review.googlesource.com/c/v8/v8/+/4705331
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-12-11 21:09:50 +01:00
Felipe C
5094cb4115
fix: wrong default port in docs ( #40665 )
...
fix: wrong default port
2023-12-11 11:43:06 -05:00
Yureka
2eb13d377e
docs: fix year typos in electron-timelines.md ( #40728 )
2023-12-07 19:14:54 -08:00
David Sanders
93fdc8d33c
ci: roll back the link release project board to repo automation ( #40716 )
...
* ci: roll back the link release project board to repo automation
* ci: add workflow_dispatch
2023-12-06 20:58:41 -08:00
Keeley Hammond
d6a80bad05
build: bump NMV to 121 ( #40707 )
2023-12-05 20:31:36 -08:00
Cheng Zhao
cb0da6ff34
fix: prevent node mode to be used as script runner by other apps ( #40579 )
2023-12-06 11:23:54 +09:00
Cheng Zhao
9aa73abe78
feat: enable code cache for custom protocols ( #40544 )
2023-12-06 11:22:41 +09:00
Jeremy Rose
85bc005cd6
refactor: move JS dialog handling to JS ( #40598 )
2023-12-05 17:36:23 -08:00
tr2-harada
ee8d97d7fe
build: update typescript-definitions to 8.15.2 ( #40670 )
...
* build: update typescript-definitions to 8.15.2
* chore: update yarn.lock
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-12-05 00:53:52 -08:00
Robo
3a510a26d0
chore: cleanup global reject handler leaking into tests ( #40689 )
2023-12-05 12:56:51 +09:00
Keeley Hammond
9afeaa3a4c
docs: add E28 support for ESM in tutorial.md ( #40690 )
...
docs: add E28 support for ESM in tutorial
2023-12-04 12:36:37 -08:00
Shelley Vohr
10a165a9ff
fix: webview zoom level persistence on navigation ( #40650 )
2023-12-04 10:39:20 -05:00
David Sanders
66b4b21646
ci: tweak new release board workflow ( #40680 )
...
* ci: tweak new release board workflow
* ci: fix workflow
2023-12-04 10:18:14 -05:00
Ryan Manuel
6f14dba7a0
fix: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium ( #40681 )
...
* chore: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium
* update patch message
2023-12-04 13:37:03 +09:00
Albert Xing
3609fc7402
fix: clean up devtools frontend_host on webcontents destroy ( #40666 )
...
* fix: clean up devtools frontend_host on destroy
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
* test: add a test for re-opening devtools
2023-12-01 11:37:52 -08:00
George Xu
344b7f0d06
docs: add dates for e29 ( #40622 )
...
* docs: add dates for e29
* update dates for e26 eol
* Update docs/tutorial/electron-timelines.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: update Jan to Dec
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-11-30 20:55:42 -08:00
Cheng Zhao
96f5f89f1b
chore: fix building content_browsertests ( #40652 )
2023-11-30 07:23:21 -08:00
Shelley Vohr
9c94fd7afb
chore: upgrade to Node.js v20 ( #40545 )
...
* chore: upgrade to Node.js v20
* src: allow embedders to override NODE_MODULE_VERSION
https://github.com/nodejs/node/pull/49279
* src: fix missing trailing ,
https://github.com/nodejs/node/pull/46909
* src,tools: initialize cppgc
https://github.com/nodejs/node/pull/45704
* tools: allow passing absolute path of config.gypi in js2c
https://github.com/nodejs/node/pull/49162
* tools: port js2c.py to C++
https://github.com/nodejs/node/pull/46997
* doc,lib: disambiguate the old term, NativeModule
https://github.com/nodejs/node/pull/45673
* chore: fixup Node.js BSSL tests
* https://github.com/nodejs/node/pull/49492
* https://github.com/nodejs/node/pull/44498
* deps: upgrade to libuv 1.45.0
https://github.com/nodejs/node/pull/48078
* deps: update V8 to 10.7
https://github.com/nodejs/node/pull/44741
* test: use gcUntil() in test-v8-serialize-leak
https://github.com/nodejs/node/pull/49168
* module: make CJS load from ESM loader
https://github.com/nodejs/node/pull/47999
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* chore: address changes to CJS/ESM loading
* module: make CJS load from ESM loader (https://github.com/nodejs/node/pull/47999 )
* lib: improve esm resolve performance (https://github.com/nodejs/node/pull/46652 )
* bootstrap: optimize modules loaded in the built-in snapshot
https://github.com/nodejs/node/pull/45849
* test: mark test-runner-output as flaky
https://github.com/nodejs/node/pull/49854
* lib: lazy-load deps in modules/run_main.js
https://github.com/nodejs/node/pull/45849
* url: use private properties for brand check
https://github.com/nodejs/node/pull/46904
* test: refactor `test-node-output-errors`
https://github.com/nodejs/node/pull/48992
* assert: deprecate callTracker
https://github.com/nodejs/node/pull/47740
* src: cast v8::Object::GetInternalField() return value to v8::Value
https://github.com/nodejs/node/pull/48943
* test: adapt test-v8-stats for V8 update
https://github.com/nodejs/node/pull/45230
* tls: ensure TLS Sockets are closed if the underlying wrap closes
https://github.com/nodejs/node/pull/49327
* test: deflake test-tls-socket-close
https://github.com/nodejs/node/pull/49575
* net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
https://github.com/nodejs/node/pull/49400
* net: use asserts in JS Socket Stream to catch races in future
https://github.com/nodejs/node/pull/49400
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* src: create BaseObject with node::Realm
https://github.com/nodejs/node/pull/44348
* src: implement DataQueue and non-memory resident Blob
https://github.com/nodejs/node/pull/45258
* sea: add support for V8 bytecode-only caching
https://github.com/nodejs/node/pull/48191
* chore: fixup patch indices
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* build: modify js2c.py into GN executable
* fix: (WIP) handle string replacement of fs -> original-fs
* [v20.x] backport vm-related memory fixes
https://github.com/nodejs/node/pull/49874
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* src: avoid copying string in fs_permission
https://github.com/nodejs/node/pull/47746
* look upon my works ye mighty
and dispair
* chore: patch cleanup
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* fix: missing include for NODE_EXTERN
* chore: fixup patch indices
* fix: fail properly when js2c fails in Node.js
* build: fix js2c root_gen_dir
* fix: lib/fs.js -> lib/original-fs.js
* build: fix original-fs file xforms
* fixup! module: make CJS load from ESM loader
* build: get rid of CppHeap for now
* build: add patch to prevent extra fs lookup on esm load
* build: greatly simplify js2c modifications
Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c
* chore: update to handle moved internal/modules/helpers file
* test: update @types/node test
* feat: enable preventing cppgc heap creation
* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler
* fix: no cppgc initialization in the renderer
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* test: disable single executable tests
* fix: nan tests failing on node headers missing file
* tls,http2: send fatal alert on ALPN mismatch
https://github.com/nodejs/node/pull/44031
* test: disable snapshot tests
* https://github.com/nodejs/node/pull/47887
* https://github.com/nodejs/node/pull/49684
* https://github.com/nodejs/node/pull/44193
* build: use deps/v8 for v8/tools
Node.js hard depends on these in their builtins
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* build: remove js2c //base dep
* build: use electron_js2c_toolchain to build node_js2c
* fix: don't create SafeSet outside packageResolve
Fixes failure in parallel/test-require-delete-array-iterator:
=== release test-require-delete-array-iterator ===
Path: parallel/test-require-delete-array-iterator
node:internal/per_context/primordials:426
constructor(i) { super(i); } // eslint-disable-line no-useless-constructor
^
TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
at new Set (<anonymous>)
at new SafeSet (node:internal/per_context/primordials:426:22)
* fix: failing crashReporter tests on Linux
These were failing because our change from node::InitializeNodeWithArgs to
node::InitializeOncePerProcess meant that we now inadvertently called
PlatformInit, which reset signal handling. This meant that our intentional
crash function ElectronBindings::Crash no longer worked and the renderer process
no longer crashed when process.crash() was called. We don't want to use Node.js'
default signal handling in the renderer process, so we disable it by passing
kNoDefaultSignalHandling to node::InitializeOncePerProcess.
* build: only create cppgc heap on non-32 bit platforms
* chore: clean up util:CompileAndCall
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* fix: use thread_local BuiltinLoader
* chore: fixup v8 patch indices
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-11-30 09:51:35 -05:00
Tamás Zahola
39ee94089a
fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive() ( #40546 )
...
* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()
* add test
2023-11-30 12:43:22 +01:00
Charles Kerr
b2fcc15ec7
build: fix release notes script bug that omitted edited release-clerk comments ( #40634 )
...
* build: fix release notes script bug that omitted edited release-clerk comments
add a warning when neither notes nor no-notes are found
* fixup! build: fix release notes script bug that omitted edited release-clerk comments
use console.warn() instead of console.log()
2023-11-30 12:41:48 +01:00
Jeremy Rose
763bc62c7f
chore: remove fix_add_check_for_sandbox_then_result.patch ( #40633 )
2023-11-29 10:30:21 -08:00
Cheng Zhao
abb71f5307
chore: make use of the v8_expose_public_symbols flag ( #40624 )
...
* chore: make use of the v8_expose_public_symbols flag
Use the newly added v8_expose_public_symbols flag to expose V8 symbols,
instead of relying on custom patches.
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-29 12:46:27 +09:00
David Sanders
c12ab7c941
ci: use pull_request_target for PR labeled workflows ( #40623 )
2023-11-29 08:33:07 +09:00
electron-roller[bot]
5c7579ab1c
chore: bump chromium to 121.0.6147.0 (main) ( #40523 )
...
* chore: bump chromium in DEPS to 121.0.6128.0
* build: update patches
* refactor: remove instrumentation from extensions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5002404
* refactor: modernization of tabs_api
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4997031
* fix: add RecordHover and RecordDrag handlers
* build: add missing pdf files
* chore: bump chromium in DEPS to 121.0.6129.0
* chore: bump chromium in DEPS to 121.0.6131.0
* chore: update patches
* refactor: remove will_cause_resize from ExitFullscreen
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
* chore: add missing std converter include
Before these were being inferred as std::string implicitly, not anymore
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5029573
* chore: Unwrap UserScriptList from unique_ptrs
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5005198
* refactor: add PDF internal id into PDF stream info
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4876972
* refactor: add metadata to view classes
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4994885
* chore: run lint --fix
* chore: update libc++ filenames
* chore: clean up menubar
* chore: update patches after main merge
* 5010979: Replace base::WStringPiece usage with std::wstring_view | https://chromium-review.googlesource.com/c/chromium/src/+/5010979
* chore: bump chromium in DEPS to 121.0.6142.0
* chore: update patches
* 4969574: Refactor NativeDesktopMediaList | https://chromium-review.googlesource.com/c/chromium/src/+/4969574
* 5031192: [blink] Create new blink test suite that doesn't create blink Isolate | https://chromium-review.googlesource.com/c/chromium/src/+/5031192
* chore: update v8/devtools patches
* 5040722: [base] Replace MakeFixedFlatTreeSorted with tag type overloads | https://chromium-review.googlesource.com/c/chromium/src/+/5040722
* 5026474: Add --generate-pdf-document-outline | https://chromium-review.googlesource.com/c/chromium/src/+/5026474
* 5024297: Change parameter of CheckMediaAccessPermission from GURL to URL::Origin | https://chromium-review.googlesource.com/c/chromium/src/+/5024297
* 5034217: [RWS] Remove CanonicalCookie::IsSameParty method | https://chromium-review.googlesource.com/c/chromium/src/+/5034217
* 5037192: Rewrite usage of RenderFrame::GetRoutingID | https://chromium-review.googlesource.com/c/chromium/src/+/5037192
* 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* chore: bump chromium in DEPS to 121.0.6143.0
* chore: bump chromium in DEPS to 121.0.6145.0
* chore: update chromium patches
* 5049986: Use std::unique_ptr for MenuItemView::submenu_ member. | https://chromium-review.googlesource.com/c/chromium/src/+/5049986
* 5041595: picture-in-picture: Add PictureInPictureOcclusionTracker | https://chromium-review.googlesource.com/c/chromium/src/+/5041595
* chore: update all patches
* chore: bump chromium in DEPS to 121.0.6147.0
* chore: update patches
* 5051069: Use base::FunctionRef for BrowserPluginGuestManager. | https://chromium-review.googlesource.com/c/chromium/src/+/5051069
* 5057330: [base] Remove base::Erase()/base::EraseIf() overloads for std::set | https://chromium-review.googlesource.com/c/chromium/src/+/5057330
* fixup! 5041802: Reland "Incorporate policy override for OOPPD feature" | https://chromium-review.googlesource.com/c/chromium/src/+/5041802
* 5017518: Remove PPAPI if NaCl is disabled | https://chromium-review.googlesource.com/c/chromium/src/+/5017518
* 5002232: [DevTools] Console Insights: move from build flag to Feature API | https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* 4970322: [X11] Move utils into x11::Connection | https://chromium-review.googlesource.com/c/chromium/src/+/4970322
* 5048950: Let MenuModelAdapter::CreateMenu return a std::unique_ptr<>. | https://chromium-review.googlesource.com/c/chromium/src/+/5048950
* chore: update libcxx filenames
* use Context::Scope in RunScriptsAtDocument{Start,End}
* 4775128: content: Reuse CC instance for main frame navigations
https://chromium-review.googlesource.com/c/chromium/src/+/4775128
* also wrap WebWorkerObserver::ContextWillDestroy with Context::Scope
* set LIBCPP_HARDENING_MODE
https://chromium-review.googlesource.com/c/chromium/src/+/5014271
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-11-28 13:40:12 -08:00
Felix Rieseberg
f0f027c06d
fix: Use activateIgnoringOtherApps for non-panels ( #40570 )
...
Use activateIgnoringOtherApps for non-panels
2023-11-27 12:58:46 -05:00
Cheng Zhao
58a21a3cd9
chore: allow passing more roots to lint.js ( #40571 )
2023-11-27 09:26:33 +09:00
Samuel Attard
79e714a825
chore: add patch upstream plan for resize patch ( #40596 )
2023-11-22 12:36:52 -08:00
Samuel Attard
44e055a788
build: specify explicit typeroots for ts builds ( #40588 )
...
Upstreaming of bf63336f60
2023-11-22 09:39:36 -08:00
Shelley Vohr
e78ce82641
fix: do not call after() async_hook for asyncId 0 ( #40574 )
...
fix: do not call after() async_hook for asyncId 0
2023-11-22 17:37:40 +01:00
Samuel Attard
1574cbf137
fix: restore performance of macOS window resizing ( #40577 )
2023-11-21 23:58:57 -08:00
Tomasz
3340bc1bf9
fix: maximized window bounds when toggle setResizable ( #40503 )
2023-11-22 15:21:18 +09:00
David Sanders
2029224a84
ci: trigger Slack workflow on backport requested ( #40487 )
2023-11-22 15:20:34 +09:00
clintharris
f3676ff975
docs: wording in IPC tutorial docs ( #40555 )
...
fix: wording in IPC tutorial docs
2023-11-22 15:19:54 +09:00
Alex Browne
0b5fceb50e
docs: update quick-start.md ( #40556 )
...
Updates the Quick Start guide to specify _where_ JavaScript code is supposed to be added. This is more descriptive than just "your file".
2023-11-22 15:19:39 +09:00
Samuel Attard
dbe170c665
build: simplify mas patches ( #36368 )
...
* build: simplify mas patches
* build: re-add configs
2023-11-21 10:53:21 -08:00
David Sanders
3d2a754531
chore: extend linting of code blocks in the docs ( #40245 )
...
* chore: extend linting of code blocks in the docs
* chore: combine lint:markdownlint and lint:markdown scripts
2023-11-21 16:50:08 +09:00
Samuel Attard
d6bb9b40b0
feat: add webUtils module with getPathForFile method ( #38776 )
...
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* chore: update patches
* fix: provide isolate to WebBlob::FromV8Value
* chore: add tests
* build: fix depshash mismatch on arm64 macOS
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-20 15:59:36 -08:00
Xie Jingyi
2c03b8fd6b
fix: ShowItemUsingFileManager should escape path in Linux ( #40527 )
2023-11-20 09:00:56 +09:00
Milan Burda
67894f1493
test: convert a few more specs to async/await ( #40313 )
2023-11-17 10:44:03 +01:00
Shelley Vohr
471449d9f6
feat: add/update missing Display properties ( #40497 )
2023-11-17 10:43:04 +01:00
Samuel Attard
dec96acf14
fix: add patch for simdutf base64 crash ( #40536 )
2023-11-15 20:11:08 -08:00
github-actions[bot]
d2b07a484d
build: update appveyor image to latest version e-121.0.6116.0 ( #40531 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-15 09:44:10 -08:00
Shelley Vohr
371bca69b6
refactor: use new extensions Messaging API IPC ( #40511 )
...
* refactor: use new extensions Messaging API IPC
Refs CRBUG:993189
Incorporates changes from:
* Bind ServiceWorker associated interfaces on Worker Thread (CL:4929154)
* [extensions] Move WakeEventPage to mojom::RendererHost (CL:4902564)
* [extensions] Convert Extension Messaging APIs over to mojo (CL:4947890)
* [extensions] Port GetMessageBundle over to mojom (CL:4956841)
* 5008635: [extensions] Bind the mojo interfaces to the frame instance
https://chromium-review.googlesource.com/c/chromium/src/+/5008635
2023-11-15 15:30:47 +01:00
Samuel Maddock
088affd4a4
fix: emit will-navigate for links in chrome: pages ( #40390 )
...
* fix: emit will-navigate for links in chrome: pages
* test: will-navigate emitted from chrome: pages
* Update shell/browser/electron_navigation_throttle.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-11-14 14:09:44 -08:00
electron-roller[bot]
0e4e9dc98c
chore: bump chromium to 121.0.6116.0 (main) ( #40490 )
...
* chore: bump chromium in DEPS to 121.0.6116.0
* chore: update patches
* Update webIDL to support close event.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4970653
* Remove uses of implicit conversion of ScopedTypeRef
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439
* Add GlobalRenderFrameHostToken
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5001743
* [DevTools] Console Insights: move from build flag to Feature API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* [Extensions] Use script serialization in scripting API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4968680
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4998265
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* chore: update libcxx files
* chore: address nan compilation error
* spec: use nan dependency from third_party
It is easier to get fixes for spec modules depending on nan
* ci: publish nan artifact for woa
* fix: bad patch update
* chore: update nan resolution
* Revert "chore: update nan resolution"
This reverts commit 786cdb858c .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-11-14 13:21:32 -08:00
David Sanders
b639fa4626
ci: close previous release project board after creating new one ( #40425 )
...
* ci: close previous release project board after creating new one
* ci: tweak release project board closure to major - 2
2023-11-13 10:37:26 -08:00
Shelley Vohr
7981d955b8
fix: chrome.action API registration ( #40500 )
2023-11-13 08:27:18 +01:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
Cheng Zhao
262723e394
build: fix building content_unittests ( #40491 )
...
chore: fix building content_unittests
2023-11-10 08:50:28 -08:00
github-actions[bot]
6697042c0a
build: update appveyor image to latest version ( #40453 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-09 16:58:46 -05:00
David Sanders
2677f36db1
docs: update references to Electron Packager ( #40480 )
2023-11-09 11:15:32 -08:00
Samuel Attard
d504d150ef
feat: add new fuse to treat file: identically to browsers ( #40372 )
2023-11-09 10:23:52 -08:00
Milan Burda
0f68d845f9
refactor: AutoUpdater for Windows using async/await ( #40289 )
2023-11-07 14:55:22 -08:00
Shelley Vohr
1ba535296e
docs: fix hid-device-{added|removed|revoked} event types ( #40462 )
...
docs: fix hid-device-{added|removed|revoked} types
2023-11-07 14:26:35 -08:00
electron-roller[bot]
e8d9294d9d
chore: bump chromium to 121.0.6110.0 (main) ( #40448 )
...
* chore: bump chromium in DEPS to 121.0.6106.0
* chore: bump chromium in DEPS to 121.0.6108.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6110.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-07 07:24:50 -05:00
Felix Rieseberg
b55d7f4a16
fix: Do not activate app when calling focus on inactive panel window ( #40307 )
...
* fix: Do not activate app when calling focus on inactive panel window
* Use activate
* Use "activate" for all windows
2023-11-06 13:38:12 -08:00
Shelley Vohr
7999ea39e2
feat: keyboard.lock() should use permissions helper ( #40369 )
...
feat: `keyboard.lock()` should use permissions helper
2023-11-06 11:54:31 -08:00
electron-roller[bot]
ee108903a0
chore: bump chromium to 121.0.6104.0 (main) ( #40418 )
...
* chore: bump chromium in DEPS to 121.0.6101.0
* chore: update patches
* Explictly use python3 to check patch diff
* chore: bump chromium in DEPS to 121.0.6102.0
* chore: update patches
* 4995136: [extensions] Enable Extension Mojo messaging
https://chromium-review.googlesource.com/c/chromium/src/+/4995136
* Bind the components interfaces to a RenderFrame
https://chromium-review.googlesource.com/c/chromium/src/+/4985961
Also:
3986427: Create RendererHost mojom interface for Extensions | https://chromium-review.googlesource.com/c/chromium/src/+/3986427
* 4997024: Enum modernisation for resources_private.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997024
* 4997025: Enum modernisation for scripting.idl
https://chromium-review.googlesource.com/c/chromium/src/+/4997025
* chore: bump chromium in DEPS to 121.0.6103.0
* chore: update patches
* chore: bump chromium in DEPS to 121.0.6104.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-03 15:37:55 -04:00
Shelley Vohr
5b18d90597
fix: crash when unloading some WebViews ( #40400 )
2023-11-03 10:36:25 -04:00
github-actions[bot]
f501dabc80
build: update appveyor image to latest version, e-121.0.6100.0 ( #40428 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-11-02 14:56:36 -04:00
Shelley Vohr
719e52928e
build: remove patch for EOL MSVC version ( #40419 )
2023-11-02 09:17:30 -04:00
Brandon Fowler
089eb34e8d
docs: add bypassCustomProtocolHandlers to ses.fetch ( #40358 )
2023-11-01 20:27:23 -04:00
electron-roller[bot]
5200abe744
chore: bump chromium to 121.0.6100.0 (main) ( #40408 )
...
* chore: bump chromium in DEPS to 121.0.6100.0
* chore: update patches
* 4970322: [X11] Move utils into x11::Connection
https://chromium-review.googlesource.com/c/chromium/src/+/4970322
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 19:01:01 -04:00
Shelley Vohr
83f0d2645e
docs: document our Node.js versioning policy ( #40373 )
2023-11-01 18:21:16 -04:00
github-actions[bot]
878c6e3062
build: update appveyor image to latest version ( #40325 )
...
* build: update appveyor image to latest version
* chore: update version to e-120.0.6099.0
* chore: rename base image for bakes
---------
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 16:19:59 -04:00
Milan Burda
b163187235
docs: avoid leaking the IpcRendererEvent in contextBridge examples ( #40321 )
...
* docs: avoid leaking the `IpcRendererEvent` in `contextBridge` examples
* Update docs/fiddles/ipc/pattern-3/preload.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/ipc.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-11-01 13:46:25 -04:00
David Sanders
425efb5e47
chore: remove py2 compatibility code ( #40375 )
2023-11-01 10:20:32 -04:00
electron-roller[bot]
bc1ba1fe9d
chore: bump chromium to 120.0.6099.0 (main) ( #40316 )
...
* chore: bump chromium in DEPS to 120.0.6086.0
* chore: update patches
* chore: rename FrameSubscriber::OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4905819
just a simple renaming
* chore: rename ToJsTime() to .InMillisecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename ToDoubleT() to .InSecondsFSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: rename FromDoubleT() to .FromSecondsSinceUnixEpoch()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
function renamed upstream
* chore: bump chromium in DEPS to 120.0.6088.2
* chore: update patches
* chore: regen filenames.libcxx.gni
* chore: migrate from (removed upstream) inputFormType to formControlType
* chore: bump chromium in DEPS to 120.0.6089.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4828507
manually sync to upstream changes + reduce diff size
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6090.0
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 2 (4 lines)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944206
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4946653
do not patch WebContentsImpl::SetWindowShowState() any longer because it has been removed
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6091.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6093.0
* chore: bump chromium in DEPS to 120.0.6095.0
* chore: bump chromium in DEPS to 120.0.6096.0
* chore: bump chromium in DEPS to 120.0.6097.0
* chore: update patches
* chore: update patch after rebase
* 4961495: [document pip] Focus the window when opened manually
https://chromium-review.googlesource.com/c/chromium/src/+/4961495
* [Extensions UserScripts] Store extensions with user scripts in tracker
| https://chromium-review.googlesource.com/c/chromium/src/+/4950530
* chore: bump chromium in DEPS to 120.0.6099.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: remove trailing space
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-11-01 10:02:12 -04:00
Samuel Attard
83892ab995
refactor: ensure IpcRenderer is not bridgable ( #40330 )
...
* refactor: ensure IpcRenderer is not bridgable
* chore: add notes to breaking-changes
* spec: fix test that bridged ipcrenderer
2023-10-31 17:29:40 -04:00
John Kleinschmidt
39d36e4462
build: actually show github upload output if verbose is true. ( #40393 )
...
* build: actually show github upload output if verbose is true.
* chore: fixup lint
2023-10-31 17:05:16 -04:00
Ninglo
f526206095
feat: configure use remote checksums via rc ( #40253 )
...
* feat: support for configuring use_remote_checksums via .npmrc
* docs: support for configuring use_remote_checksums via .npmrc
---------
Co-authored-by: jiujianian <jiujianian@bytedance.com >
2023-10-31 16:51:59 -04:00
Devraj Mehta
29d7be1565
build: update @electron/docs-parser and @electron/typescript-definitions ( #40264 )
...
* feat: add utility process typescript namespace
Upgrades docs-parser and typescript-definitions to add new
'electron/utility' namespace added in:
- https://github.com/electron/docs-parser/pull/95
- https://github.com/electron/typescript-definitions/pull/246
- https://github.com/electron/typescript-definitions/pull/247
* build: update yarn.lock
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-31 16:36:41 -04:00
Samuel Attard
e1c413c845
build: update deps to fix yarn audit ( #40376 )
2023-10-31 11:05:12 -07:00
Shelley Vohr
fcdd5cba71
fix: navigator.keyboard.lock() fullscreen exit handling ( #40365 )
...
fix: navigator.keyboard.lock() fullscreen exit handling
2023-10-31 11:59:39 -04:00
Milan Burda
4b1c31e4db
fix: implement missing applicationSupportsSecureRestorableState ( #40296 )
2023-10-31 10:22:58 -04:00
Shelley Vohr
8210d0f90e
build: don't rename files in electron_node/deps/base64 ( #40368 )
...
build: don't rename files in electron_node/deps/base64
Refs https://github.com/electron/electron/pull/35999/files#r1018305596 .
Finally addresses an old TODO to use a separate build target for conflicting
filenames instead of renaming files in the source tree.
2023-10-31 09:27:31 -04:00
Milan Burda
dd68581d30
docs: add reference to app.getAppMetrics() in serviceName for utilityProcess ( #40338 )
2023-10-30 10:07:23 -04:00
Shelley Vohr
652f995128
refactor: remove DevTools legacy UI patching ( #40331 )
2023-10-26 14:36:04 -04:00
Milan Burda
30fbcfca7b
chore: remove deprecated gpu-process-crashed event ( #40255 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-26 14:05:40 -04:00
Shelley Vohr
3f92a98315
fix: prevent PopUpButtonHandler premature dealloc ( #40308 )
...
fix: prevent PopUpButtonHandler dealloc
2023-10-26 11:40:02 -04:00
Samuel Attard
621b3ba897
build: upload slow, more time good ( #40332 )
2023-10-25 12:18:19 -07:00
Milan Burda
f66d4c7ee0
fix: make sure classes in lib correctly implement Electron interfaces ( #40291 )
2023-10-25 14:02:15 -04:00
Shelley Vohr
514a9319b9
refactor: use non-deprecated NSKeyedArchiver APIs ( #40315 )
...
* refactor: use non-deprecated NSKeyedArchiver APIs
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-25 12:01:34 -04:00
electron-roller[bot]
be44a2c5b7
chore: bump chromium to 120.0.6078.0 (main) ( #40114 )
...
* chore: bump chromium in DEPS to 120.0.6049.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6050.0
* chore: update patches
* 4910494: Reland "[autopip] Show autopip UI for video pip"
https://chromium-review.googlesource.com/c/chromium/src/+/4910494
* 4812338: Move partition_alloc into a "partition_alloc" dir.
https://chromium-review.googlesource.com/c/chromium/src/+/4812338
* [Extensions Cleanup] Remove mojom ViewType::kExtensionDialog
https://chromium-review.googlesource.com/c/chromium/src/+/4909897
* 4894923: Force enable raw_ptrs pointer arithmetic check.
https://chromium-review.googlesource.com/c/chromium/src/+/4894923
* gin: Prevent wrappables from being constructed from author code.
https://chromium-review.googlesource.com/c/chromium/src/+/4905829
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6052.0
* chore: bump chromium in DEPS to 120.0.6054.0
* chore: bump chromium in DEPS to 120.0.6056.0
* chore: fix patches
* 4918545: Reland "[autopip] Add permissions embargo"
https://chromium-review.googlesource.com/c/chromium/src/+/4918545
* 4881761: UI bindings for visual logging with structured metrics.
https://chromium-review.googlesource.com/c/chromium/src/+/4881761
* chore: bump chromium in DEPS to 120.0.6058.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6060.0
* chore: bump chromium in DEPS to 120.0.6061.0
* chore: bump chromium in DEPS to 120.0.6062.0
* chore: gen libc++ filenames
* chore: update patches
* 4911894: Move //c/b/ui/views/eye_dropper to //components
https://chromium-review.googlesource.com/c/chromium/src/+/4911894
* chore: bump chromium in DEPS to 120.0.6064.0
* chore: bump chromium in DEPS to 120.0.6066.0
* chore: bump chromium in DEPS to 120.0.6068.0
* chore: bump chromium in DEPS to 120.0.6070.0
* chore: remove temp_prevent_unused_function_error.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4931270
* chore: add TransferDragSecurityInfo()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4928028
* mark TransferDragSecurityInfo() as NOTREACHED
A follow-up to previous commit. I think this is commit is correct (i.e.
that this function shouldn't get called) but am not positive, so I'm
including it in a standalone commit in case we need to revert.
* chore: update signature of OnPrivateNetworkAccessPermissionRequired()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4919478
Our impl is a no-op, so updating the signature is the only change.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6072.0
* chore: update patches
* chore: sync ParseMatchPattern() param order with upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4944243
* chore: update fix_crash_loading_non-standard_schemes_in_iframes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4939602
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6073.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6074.0
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4908053
no manual changes; patch applied with fuzz 1
* chore: update fix_handle_no_top_level_aura_window_in_webcontentsimpl.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4936315
minor manual sync to upstream code shear
* chore: rebuild patches
* chore: update ClearHttpAuthCache arguments
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4937937
adding ClearDataFilterPtr arg. Upstream added this arg, which is already
present in other NetworkContext methods. Our code uses `nullptr` there.
* chore: bump chromium in DEPS to 120.0.6076.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4865412
minor manual sync to upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4942936
minor manual sync to upstream code shear
* fix: move x11_util.h include to top of source file
This is a short-term fix to unblock the roll. I will follow up a better fix in a standalone PR.
* chore: rebuild patches
* chore: bump chromium in DEPS to 120.0.6077.0
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6078.0
* chore: update patches
* refactor: add BrowserProcessImpl::os_crypt_async()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4455776
This is one to keep an eye on. This commit copies the upstream impl,
which appears to be an interim step with more upstream code changes
still forthcoming.
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1373092
* fixup! refactor: add BrowserProcessImpl::os_crypt_async()
chore: make 'gn check' happy
* chore: remove ensure_messageports_get_gced_when_not_referenced.patch
Xref: ensure_messageports_get_gced_when_not_referenced.patch
no longer needed because upstreamed
* chore: remove webrtc/pipewire_capturer_make_restore_tokens_re-usable_more_than_one_time.patch
Xref: https://webrtc-review.googlesource.com/c/src/+/322621
no longer needed because upstreamed
* chore: add //components/compose:buildflags dep
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4912601
needed by browser/ui/browser_dialogs.h
* chore: update filenames.libcxx.gni
node ./script/gen-libc++-filenames.js
* test: fix UI.InspectorView -> UI.InspectorView.instance()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-24 11:24:20 -04:00
Milan Burda
54ff706b71
test: add spec for app.getAppMetrics() for utility process ( #40306 )
2023-10-24 09:25:30 -04:00
Milan Burda
a867503af6
test: add spec for child-process-gone event for utility process ( #40281 )
2023-10-23 11:30:08 -04:00
Milan Burda
beb0cbc6d0
refactor: options parsing in WebContents.prototype.printToPDF() ( #40257 )
...
* refactor: options parsing in WebContents.prototype.printToPDF()
* tweak parsePageSize
2023-10-19 15:38:30 -04:00
Shelley Vohr
025af3500c
chore: Show FIDO devices in the chooser if allowed ( #40216 )
...
* chore: Show FIDO devices in the chooser if allowed
* chore: tweak HidChooserContext::IsFidoAllowedForOrigin
* chore: feedback from review
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 19:19:51 -04:00
Shelley Vohr
32a721fa2b
test: fix Node.js color edge snapshot stack traces ( #40250 )
2023-10-18 21:39:53 +02:00
Ali Yousefi
e254593616
docs: replace the example app using electron ( #37805 )
...
* replace the example app using electron
* Update README.md
Remove the trailing space to pass linter. Suggested by @jkleinsc. Thank you @jkleinsc for the suggestion.
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-18 10:56:17 -04:00
Samuel Attard
fd2861117e
fix: correctly track receiver for methods called via ctx bridge ( #39978 )
...
* fix: correctly track receiver for methods called via ctx bridge
* spec: test for correct contextBridge passage
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-18 10:21:42 -04:00
Shelley Vohr
5b105f911f
chore: implement no-op chrome.action extension APIs ( #40222 )
...
chore: implement no-op chrome.action extension APIs
2023-10-18 10:19:31 -04:00
John Kleinschmidt
29270f3df5
test: fixup node force colors test ( #40241 )
...
* test: fixup node force colors test
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-18 12:33:24 +02:00
Milan Burda
657e88b173
chore: remove deprecated crashed and renderer-process-crashed events ( #40115 )
2023-10-18 12:05:41 +02:00
David Sanders
09bab60a9e
docs: fix represented file fiddle ( #40233 )
2023-10-18 11:32:10 +02:00
Shelley Vohr
666907d50d
fix: Windows Toast notification dismissal from Action Center ( #40197 )
...
* fix: Windows Toast notification dismissal from Action Center
* docs: note Toast behavior in event
* chore: address feedback from review
2023-10-17 19:33:00 -04:00
Shelley Vohr
73a42d0b7b
refactor: partition HidDelegate observers by browser context ( #40215 )
2023-10-17 16:54:53 -04:00
Keeley Hammond
f65d1f3d55
build: re-enable partition alloc on mac ( #33981 )
2023-10-17 11:18:39 +09:00
Christian Bromann
ba4d6d08a7
docs: Update docs on testing Electron apps with WebdriverIO ( #40083 )
2023-10-16 12:23:44 -07:00
Samuel Attard
b6ec19a582
fix: support the throwIfNoEntry option to statSync and lstatSync in asar files ( #40221 )
2023-10-16 09:35:25 -07:00
Shelley Vohr
f7b1c75c72
feat: update app.{set|get}LoginItemSettings(settings) ( #37244 )
...
* feat: update app.{set|get}LoginItemSettings(settings)
* test: fixup and add tests
* docs: add type link
* chore: name -> serviceName
2023-10-16 12:25:11 -04:00
electron-roller[bot]
6d0d350e13
chore: bump node to v18.18.2 (main) ( #40205 )
...
* chore: bump node in DEPS to v18.18.2
* chore: update patches
* deps: update nghttp2 to 1.55.0
https://github.com/nodejs/node/pull/48746
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-16 17:13:35 +02:00
Shelley Vohr
f362e089b1
fix: incorrect wco bounds in macOS fullscreen ( #40179 )
2023-10-16 11:18:31 +02:00
Samuel Maddock
c9f6f15df6
refactor: use getter property for RFH ( #40200 )
2023-10-16 09:16:51 +09:00
Shelley Vohr
bbd2236bdd
fix: ensure MessagePorts get GCed when not referenced ( #40189 )
2023-10-13 22:09:28 +02:00
David Sanders
5d6023ae0d
docs: fix some string union typings ( #40180 )
2023-10-13 12:00:44 +02:00
Max Tower
dc4476d480
docs: rename renderer.d.ts in documentation ( #40137 )
...
Rename renderer.d.ts
This doesn't compile when the declaration name has the same root name as the TS file.
https://github.com/Microsoft/TypeScript/issues/7624#issuecomment-202501572
https://stackoverflow.com/questions/59728371/typescript-d-ts-file-not-recognized
2023-10-13 11:31:50 +02:00
David Sanders
ce4ae584e3
docs: update supported Linux versions ( #40177 )
2023-10-12 14:56:28 -04:00
Milan Burda
344f8fd384
chore: formally deprecate gpu-process-crashed event ( #40169 )
2023-10-12 14:53:52 -04:00
Shelley Vohr
592a30aa0b
build: remove native specs ( #40190 )
2023-10-12 14:51:59 -04:00
Athul Iddya
3c31246343
fix: store portal restore token under the right source ID ( #40098 )
...
XDG Desktop Portal provides restore tokens to restore a previously
selected PipeWire stream instead of prompting the user again. This
restore token is single use only and it has to be replaced when the
stream is completed/stopped.
BaseCapturerPipewire maintains two source IDs: one is initialized by
the constructor for new sources (source_id_) and another is for
capturing previously selected sources (selected_source_id_). The
restore token was always being stored under `source_id_`, even if the
capture was ongoing for `selected_source_id_`. This prevents a stream
from being restored more than once. Fix that by storing the restore
token under the selected source ID if it exists.
2023-10-12 13:17:27 +02:00
electron-roller[bot]
7ab2a82166
chore: bump node to v18.18.1 (main) ( #40174 )
...
* chore: bump node in DEPS to v18.18.1
* Revert "deps: upgrade to libuv 1.46.0"
https://github.com/nodejs/node/pull/50036
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-10-12 09:53:37 +02:00
Shelley Vohr
5c821d3379
fix: webContents.capturePage() for hidden windows on Windows/Linux ( #39730 )
2023-10-12 09:35:23 +02:00
Milan Burda
3e70692e4b
chore: formally deprecate crashed and renderer-process-crashed events ( #40089 )
2023-10-10 19:49:01 -04:00
Keeley Hammond
c892c61b90
docs: update dates for E28 ( #40154 )
...
* docs: update dates for E28
* docs: update node version
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-10-10 19:43:35 -04:00
Milan Burda
2c88626b51
chore: revert deprecate as an internal module ( #40146 )
...
Revert "chore: restore deprecate as an internal module (#40124 )"
This reverts commit 737e3de3fa .
2023-10-10 11:50:47 -04:00
Shelley Vohr
7e312c81ca
test: make capturePage color matching timeouts consistent ( #40158 )
2023-10-10 11:13:07 -04:00
Shelley Vohr
86df4db6f1
fix: crash when calling non-reentrant function in loadURL ( #40143 )
2023-10-10 12:46:04 +02:00
Milan Burda
563c370d51
refactor: use gin_helper::Dictionary::CreateEmpty() helper ( #40140 )
2023-10-10 12:45:44 +02:00
Jade Flute
47beca1d2a
docs: fix typo in session docs ( #40138 )
...
Fix typos for doc
Signed-off-by: zhangdiandian <1635468471@qq.com >
2023-10-10 12:43:18 +02:00
Tomasz
925e4f7d74
feat: Add 'mouse-enter' and 'mouse-leave' Tray events for Windows. ( #40072 )
2023-10-09 19:56:38 -04:00
John Kleinschmidt
a31deea1ba
ci: fixup diagnose_goma_log.py call ( #40131 )
2023-10-09 15:19:21 +02:00
Milan Burda
24bc0ee5c7
test: fix "crashed event does not crash main process when destroying WebContents in it" ( #40135 )
2023-10-09 09:56:48 +02:00
Cheng Zhao
f5c177698e
fix: remove EarlyMallocZoneRegistration call ( #40128 )
2023-10-09 09:43:51 +09:00
Milan Burda
737e3de3fa
chore: restore deprecate as an internal module ( #40124 )
...
* Revert "refactor: don't expose deprecate as an internal module (#35311 )"
This reverts commit 8424779906 .
* check crashed event warnings
2023-10-09 08:55:16 +09:00
David Sanders
8b8fbd0408
test: add back smoke test for removed API ( #40132 )
2023-10-09 08:46:56 +09:00
Milan Burda
6a99c7b840
refactor: eliminate duplicate code ( #40088 )
2023-10-09 08:43:50 +09:00
Keeley Hammond
cff50ac65a
fix: fix vibrancy applying without transparency on MacOS ( #40109 )
2023-10-06 11:57:26 -07:00
github-actions[bot]
a55c163db0
build: update appveyor image to latest version - e-119.0.6045.0 ( #40075 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-06 11:47:17 -04:00
Robo
fdf8b02e14
chore: cherry-pick c03569f from libuv ( #40101 )
...
Refs c03569f0df
2023-10-06 19:25:19 +09:00
Shelley Vohr
73553032ea
fix: toggling DevTools while minimized on Windows ( #40091 )
...
fix: toggling devtools while minimized on Windows
2023-10-05 20:26:31 -04:00
electron-roller[bot]
8f7a48879e
chore: bump chromium to 119.0.6045.0 (main) ( #40076 )
...
* chore: bump chromium in DEPS to 119.0.6045.0
* chore: update patches
* 4864948: Remove legacy-legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4864948
* 4907760: Remove ui/base/glib/glib_signal.h
https://chromium-review.googlesource.com/c/chromium/src/+/4907760
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-05 19:59:39 -04:00
Milan Burda
83a928f6e3
fix: crashed events deprecation ( #40090 )
2023-10-05 19:57:14 -04:00
Shelley Vohr
3392d9a2e7
fix: all children showing when showing child window ( #40062 )
2023-10-05 09:19:57 -04:00
David Sanders
5ad69df52e
build: update NMV to 119 ( #40081 )
2023-10-05 09:14:02 -04:00
Shelley Vohr
b3a1c6d13c
fix: error using webcrypto.subtle.importKey() ( #40070 )
...
fix: error using webcrypto.subtle.importKey()
2023-10-05 10:46:53 +02:00
Shelley Vohr
b0590b6ee8
fix: failing build with enable_electron_extensions=false ( #40032 )
...
* fix: ENABLE_EXTENSIONS -> ENABLE_ELECTRON_EXTENSIONS
* fix: extension guard fixes
* chore: fix linker errors
2023-10-04 10:40:01 +02:00
Shelley Vohr
713d8c4167
feat: add tabbingIdentifier property to BrowserWindow ( #39980 )
...
feat: add tabbingIdentifier property to BrowserWindow
2023-10-03 12:27:40 -07:00
Milan Burda
04b2ba84cd
refactor: replace remaining NULL with nullptr ( #40053 )
...
refactor: use nullptr everywhere
2023-10-03 12:26:35 -07:00
electron-roller[bot]
9d0e6d09f0
chore: bump chromium to 119.0.6043.0 (main) ( #40045 )
...
* chore: bump chromium in DEPS to 119.0.6036.0
* chore: bump chromium in DEPS to 119.0.6037.0
* chore: bump chromium in DEPS to 119.0.6039.0
* chore: bump chromium in DEPS to 119.0.6041.0
* chore: update chromium patches
* 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230
* 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325
* chore: update all patches
* chore: bump chromium in DEPS to 119.0.6043.0
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* 4837192: Plumb origin through for drags.
https://chromium-review.googlesource.com/c/chromium/src/+/4837192
* Prevent content analysis on web pages that don't accept drag and drop.
https://chromium-review.googlesource.com/c/chromium/src/+/4814086
* Make getting displayed notifications work with notification attribution.
https://chromium-review.googlesource.com/c/chromium/src/+/4738935
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* chore: remove Goma warning from mksnapshot_args
* 4776412: Remove Windows-specific wstring variants of StringPrintf() etc.
https://chromium-review.googlesource.com/c/chromium/src/+/4776412
* [dPWA] Prevent WebAppInstallInfo from being included on Android
https://chromium-review.googlesource.com/c/chromium/src/+/4886594
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-10-02 18:01:07 -04:00
github-actions[bot]
503ae86ab2
build: update appveyor image to latest version - e-119.0.6029.0 ( #40046 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-10-02 11:11:07 -04:00
Athul Iddya
37c79ea844
docs: add PipeWire integration instructions for snaps ( #40019 )
2023-10-02 12:19:23 +02:00
Shelley Vohr
93bcb30c3e
fix: BroadcastChannel initialization location ( #40049 )
...
fix: `BroadcastChannel` initialization location (#37421 )
* fix: BroadcastChannel initialization location
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-10-02 10:57:09 +02:00
Milan Burda
d301616f60
chore: remove deprecated app.runningUnderRosettaTranslation() ( #39956 )
2023-10-02 10:55:32 +02:00
Shelley Vohr
5643e86956
chore: update extensions url handling to match upstream ( #40038 )
...
- https://chromium-review.googlesource.com/c/chromium/src/+/4772028
- https://chromium-review.googlesource.com/c/chromium/src/+/4264656
- https://chromium-review.googlesource.com/c/chromium/src/+/4712150
2023-10-02 10:35:00 +02:00
Samuel Attard
371e83a8d2
fix: support esm entrypoint to utility process ( #40047 )
2023-09-29 14:38:37 -07:00
electron-roller[bot]
d6c8ff2e70
chore: bump chromium to 119.0.6029.0 (main) ( #39944 )
...
* chore: bump chromium in DEPS to 119.0.6021.0
* 4727729: Initial ScreenCaptureKit AudioInputStream implementation
https://chromium-review.googlesource.com/c/chromium/src/+/4727729
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6023.0
* 4875713: mac: Switch to Xcode 15.0 15A240d with macOS SDK 14.0 23A334
https://chromium-review.googlesource.com/c/chromium/src/+/4875713
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4877868: Remove all gitignore entries for submodules
https://chromium-review.googlesource.com/c/chromium/src/+/4877868
* 4824705: Set origin to commit for data: URLs
https://chromium-review.googlesource.com/c/chromium/src/+/4824705
* chore: fixup patch indices
* 4881382: Expose selection in WebFormControlElement as unsigned
https://chromium-review.googlesource.com/c/chromium/src/+/4881382
* 4874216: Portals: Cancel drag-drop in predecessor before activation
https://chromium-review.googlesource.com/c/chromium/src/+/4874216
* chore: bump chromium in DEPS to 119.0.6025.0
* chore: bump chromium in DEPS to 119.0.6027.0
* 4884489: Update gitignore to be explicit about directories
https://chromium-review.googlesource.com/c/chromium/src/+/4884489
* 4881091: Add debug info about owner document's origin when inheriting
https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* chore: fixup patch indices
* chore: bump chromium in DEPS to 119.0.6029.0
* chore: update patches
* 4881091: Add debug info about owner document's origin when inheriting
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4881091
* 4831380: [task-attribution] Reland: Move to an implicit GCed task container model
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4831380
* 4866732: Extract document.title for installable checks
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4866732
* chore: link to crbug in message port test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-28 22:26:41 -07:00
ILikeTeaALot
d002f16157
feat: systemPreferences.getColor should return RGBA instead of RGB ( #38960 )
...
* fix: return RGBA hex value from `SystemPreferences.getColor`
* docs: update docs to match changes of last commit
* fix: GetColor on windows now returns RGBA too
* fix: update tests for getColor RGBA on Windows
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-28 18:56:16 -04:00
Bruno Pitrus
dd7395ebed
chore: add missing include for std::variant ( #40007 )
2023-09-28 12:50:58 -04:00
Bruno Pitrus
e3e793d25b
chore: remove invalid constexpr qualification ( #40006 )
...
GetPathConstant calls base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::find(Key const&) const which is not constexpr.
GCC 12 and earlier raise a compile error on this.
2023-09-28 12:49:09 -04:00
dependabot[bot]
da92c9aa27
build(deps): bump get-func-name from 2.0.0 to 2.0.2 in /spec ( #40012 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 12:47:36 -04:00
David Sanders
02b58333dc
ci: update release project board workflows ( #40020 )
2023-09-28 11:27:02 -04:00
David Sanders
23cf9fa4e9
ci: update automation workflows ( #40021 )
2023-09-28 11:26:04 -04:00
Cheng Zhao
4cf6884dd4
fix: detect screen readers by testing their existences ( #39988 )
2023-09-28 11:17:42 -04:00
marekharanczyk
94585f5889
fix: propagate layout call to all children of InspectableWebContentsViewViews ( #39994 )
...
Propagate layout call to all children of InspectableWebContentsViewViews.
When BrowserView bounds are set from js, those might not trigger layout
immediately, sometimes propagating InvalidateLayout call to parent.
View is marked as needing layout, expecting to receive it from parent on
next layout call. The problem is that BrowserView's view is added as child
of InspectableWebContentsViews which does not call setBounds (which
would trigger layout) on all of it's children when doing it's layout,
so it skips propagating Layout call to its children BrowserViews views,
even though those were marked as needing layout.
Call base class View::Layout which will iterate over views' children
and call Layout on those that were marked as needing them.
Fixes #39993 .
2023-09-28 11:17:21 -04:00
John Kleinschmidt
43a646ed85
build: log uploads to GitHub ( #40034 )
2023-09-28 11:15:52 -04:00
dependabot[bot]
f628ce67dd
build(deps): bump get-func-name from 2.0.0 to 2.0.2 ( #40013 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 10:44:16 +02:00
Shelley Vohr
c8156c3c57
fix: failure on immutable webContents.print(options) ( #39985 )
...
fix: failure on immutable webContents.print(options)
2023-09-28 10:41:46 +02:00
Tomasz
689d1b76de
feat: add middle click event to tray ( #39926 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:21:15 -04:00
Robert Günzler
480f48b2fc
feat: enable dark mode on GTK UIs ( #38977 )
...
feat: port DarkModeManagerLinux
This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903
and replaces the previous workaround to detect dark mode on GTK.
Detect system dark theme preference via xdg settings portal:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings
Closes: https://github.com/electron/electron/issues/38961
Closes: https://github.com/electron/electron/issues/28838
Signed-off-by: Robert Günzler <r@gnzler.io >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 14:17:40 -04:00
Erick Zhao
a0ae691a9c
docs: document type-specific module aliases ( #39685 )
2023-09-27 11:07:04 -04:00
Bruno Henrique da Silva
f943b8c940
fix: set window contents as opaque to decrease DWM GPU usage ( #39895 )
...
* set window contents as opaque to decrease DWM GPU usage
* chore: add more context to ShouldWindowContentsBeTransparent
2023-09-27 10:42:46 -04:00
Shelley Vohr
b7c9c895b5
build: fix with enable_pdf_viewer = false ( #39990 )
...
build: fix with enable_pdf_viewer = false
2023-09-27 10:09:53 -04:00
Shelley Vohr
1ba321b733
fix: rounded corners on vibrant macOS modals ( #39979 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-27 15:12:37 +02:00
Cheng Zhao
ad57867594
fix: apply size constraints to NSWindow ( #39975 )
2023-09-27 11:11:24 +02:00
Cheng Zhao
e613595982
build: allow overriding electron version ( #39974 )
2023-09-27 14:49:10 +09:00
NoxFly
624ae024e2
docs: Quick Start | Electron Forge chapter requirements updated ( #39639 )
...
* Update quick-start.md
Added a note to a pre-require of Electron Forge.
Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild`
* Add two required steps for Electron Forge to build without errors
* Update docs/tutorial/quick-start.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-09-27 08:56:39 +09:00
michal-pichlinski-openfin
2190793fe6
fix: disable background throttling also in the viz::DisplayScheduler ( #38924 )
...
* fix: disable background throttling also in the `viz::DisplayScheduler`
`viz::DisplayScheduler` is responsible for drawing and swapping frames
in the `DisplayScheduler::DrawAndSwap` which is called from the
`DisplayScheduler::AttemptDrawAndSwap` if the `DisplayScheduler::ShouldDraw`
returns true. `ShouldDraw` depends on the `DisplayScheduler` visibility
and when it is not visible then it returns false.
In order to keep producing frames, disabling `backgroundThrottling`
should also prevent changing `DisplayScheduler` visibility to false.
`DisplayScheduler` lives in the `ui::Compositor` where every
`electron::NativewWindow` has its own `Compositor`. `electron::NativewWindow`
may be host of the multiple `electron::api::WebContents` instances which may
have different `WebPreferences` settings. Therefore if at least one
of the `WebContents` requires disabling throttling then all other `WebContents`
using the same window will have it disabled in the `ui::Compositor`.
BREAKING CHANGE:
`backgroundThrottling` set to false will disable frames throttling
in the `BrowserWindow` for all `WebContents` displayed by it.
Close: [#31016 ](https://github.com/electron/electron/issues/31016 )
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-26 16:00:46 -04:00
Milan Burda
fa215f1009
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md ( #39897 )
...
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md
2023-09-26 13:42:56 -04:00
John Kleinschmidt
943bfa89ce
test: fixup parallel/test-node-output-error test ( #39972 )
2023-09-25 16:23:05 -04:00
Milan Burda
d75a852743
refactor: use type enum in file stats for asar archive ( #39889 )
2023-09-25 13:17:24 +02:00
David Sanders
18f517d8a6
test: vendor node-is-valid-window ( #39965 )
2023-09-25 12:43:57 +02:00
Leon
fdf1ecec47
docs: correct v24 Alpha date ( #39963 )
2023-09-24 23:03:29 -07:00
John Kleinschmidt
beb52ce61c
build: update patch ( #39950 )
2023-09-22 10:33:29 -07:00
Erick Zhao
2085aae915
docs: esm tutorial ( #39722 )
...
* docs: esm tutorial
* Update esm.md
* Update docs/tutorial/esm.md
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
* table adjustment
* fix lint
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* Update esm.md
---------
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-22 09:49:16 -07:00
Fredy Whatley
7c2df8860b
docs: tiny update on example message-ports.md ( #39884 )
...
Update message-ports.md
fix multiplying object * a number. It would multiply number * number.
2023-09-21 11:46:23 -04:00
github-actions[bot]
56e45baeb8
build: update appveyor image to latest version - e-119.0.6019.2 ( #39924 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-21 09:49:04 -04:00
Robo
5f712fa325
chore: cherry-pick tls shutdown crash fix from upstream ( #39928 )
2023-09-21 09:47:31 -04:00
John Kleinschmidt
ba8915242a
ci: fix linux builds of forks ( #39933 )
2023-09-21 12:10:46 +02:00
Milan Burda
c9eb3deab5
chore: remove deprecated scroll-touch-{begin,end,edge} events ( #39814 )
...
* chore: remove deprecated `scroll-touch-{begin,end,edge}` events
* update spec/ts-smoke
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 17:41:29 -04:00
Valentin Hăloiu
58fd8825d2
fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var ( #39792 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-20 16:21:23 -04:00
Milan Burda
6a8b70639b
fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 ( #39920 )
...
fix: app.runningUnderARM64Translation() always returning true on ARM64
2023-09-20 16:15:19 -04:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:13:43 -04:00
electron-roller[bot]
28eda03aba
chore: bump chromium to 119.0.6019.2 (main) ( #39925 )
...
* chore: bump chromium in DEPS to 119.0.6018.4
* chore: update patches
* chore: bump chromium in DEPS to 119.0.6019.2
* chore: update patches
* 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4876292
* 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts
https://chromium-review.googlesource.com/c/chromium/src/+/4851616
* 4869393: [Extensions UserScripts] Add error messages for script matching errors
https://chromium-review.googlesource.com/c/chromium/src/+/4869393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-20 16:08:26 -04:00
George Xu
7685f27b31
feat: expose app accessibility transparency settings api ( #39631 )
...
* feat: expose app accessibility transparency settings api
* docs: fix typo
* chore: add doc
* change to property
* add as property instead of method
* chore: fix lint
* rename function name in header
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-09-20 12:48:02 -07:00
Shelley Vohr
463586a6c5
chore(deps): roll nan to pick up upstreams ( #39916 )
2023-09-20 15:37:10 +02:00
electron-roller[bot]
a39c0ee659
chore: bump chromium to 119.0.6017.0 (main) ( #39922 )
...
* chore: bump chromium in DEPS to 119.0.6017.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-20 11:30:38 +02:00
github-actions[bot]
0b0a8a5ef3
build: update appveyor image to latest version, e-119.0.6006.0 ( #39908 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-19 23:46:47 -07:00
electron-roller[bot]
986becdb4d
chore: bump chromium to 119.0.6016.0 (main) ( #39898 )
...
* chore: bump chromium in DEPS to 119.0.6016.0
* chore: update patches
* 4839124: Rename chrome/app/ branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/4839124
* 4846834: Clean up PrintRenderFrameHelper interaction with Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/4846834
* 4850759: Cache bounds of document pip windows
https://chromium-review.googlesource.com/c/chromium/src/+/4850759
* 4864669: Roll libc++ from 84fb809dd6da to 68a6f0b88287 (352 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4864669
* 4863987: Remove five gpu workarounds.
https://chromium-review.googlesource.com/c/chromium/src/+/4863987
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-19 19:34:56 +02:00
Samuel Attard
75ea294b6f
build: use afs on aks instead of circle cache ( #39881 )
...
* build: use afs on aks instead of circle cache
* build: do not use aks logic on linux hosts checking out for macOS
* build: fix gn-check could-be-aks
* build: sigh
* build: no ls mnt
* build: keep build alive while debugging
* build: make debuggable
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-09-19 03:12:14 -07:00
spencer17x
18717ee62d
docs: add a more detailed explanation to cookies.flushStore() ( #37572 )
...
* docs: cookies.flushStore()
* docs: modify cookies.flushStore()
* Update docs/api/cookies.md
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-09-18 16:51:46 -04:00
electron-roller[bot]
73e33bc876
chore: bump chromium to 119.0.6006.0 (main) ( #39774 )
...
* chore: bump chromium in DEPS to 119.0.5994.0
* chore: update patches
* Add some more debugging for navigation origin & process lock mismatch
https://chromium-review.googlesource.com/c/chromium/src/+/4829483
* chore: bump chromium in DEPS to 119.0.5996.2
* chore: bump chromium in DEPS to 119.0.5997.0
* chore: bump chromium in DEPS to 119.0.6000.0
* chore: bump chromium in DEPS to 119.0.6002.0
* 4781766: Port remaining control color ids to the color pipeline
https://chromium-review.googlesource.com/c/chromium/src/+/4781766
* 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/
https://chromium-review.googlesource.com/c/chromium/src/+/4846057
* chore: fixup patch indices
* 4848108: Pass v8::Isolate into FromV8Value calls on blink API
https://chromium-review.googlesource.com/c/chromium/src/+/4848108
* 4834471: Reland "[api] allow v8::Data as internal field"
https://chromium-review.googlesource.com/c/v8/v8/+/4834471
* 4808884: Major overhaul of ExceptionState in the v8 bindings
https://chromium-review.googlesource.com/c/chromium/src/+/4808884
* 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap
https://chromium-review.googlesource.com/c/v8/v8/+/4791643
* chore: bump chromium in DEPS to 119.0.6005.0
* 4776268: [v8][etw] Enables filtering of ETW tracing by URL
https://chromium-review.googlesource.com/c/chromium/src/+/4776268
* chore: fixup patch indices
* 4673258: WebSQL: Disable WebSQL by default
https://chromium-review.googlesource.com/c/chromium/src/+/4673258
* chore: bump chromium in DEPS to 119.0.6006.0
* chore: update patches
* 4854732: Reland^2 "[iterator-helpers] Unship due to incompat"
https://chromium-review.googlesource.com/c/v8/v8/+/4854732
* 4794133: [AWC] Add `display-state` CSS @media feature
https://chromium-review.googlesource.com/c/chromium/src/+/4794133
* fixup! Add some more debugging for navigation origin & process lock mismatch
* Revert "fixup! Add some more debugging for navigation origin & process lock mismatch"
This reverts commit 38fef075fc .
* 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks"
https://chromium-review.googlesource.com/c/chromium/src/+/4858437
* refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879 )
* chore: 4869108: handle absolute and relative gn imports in autoninja
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108
* chore: set GOMA_DIR for autoninja
* Revert "chore: 4869108: handle absolute and relative gn imports in autoninja"
This reverts commit d94c7720ba .
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com >
2023-09-18 16:44:09 -04:00
John Kleinschmidt
c8544e25df
build: fixup autoninja ( #39896 )
...
chore: set GOMA_DIR for autoninja
(cherry picked from commit 94f24bde4d )
(cherry picked from commit 90c1f6e1cb8d22d94dd01791dc4b9c3e0a7e86fc)
2023-09-18 16:43:27 -04:00
Milan Burda
9c7086074e
docs: add missing ipcRenderer.off() / ipcRenderer.addListener() aliases ( #39816 )
...
* docs: add missing `ipcRenderer.off()` / `ipcRenderer.addListener()` aliases
* Update docs/api/ipc-renderer.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* fix ipcRenderer.removeListener
* update ts-smoke
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-09-19 01:58:20 +09:00
Milan Burda
d7e4bb6608
chore: remove no-op fullscreenWindowTitle option ( #39815 )
2023-09-19 01:55:47 +09:00
David Sanders
706653d5e4
ci: fix issue-commented workflow sytnax ( #39875 )
2023-09-17 19:23:59 -07:00
John Kleinschmidt
65952abc99
test: fixup node flakes ( #39871 )
...
chore: fixup node flakes
2023-09-15 03:43:13 -07:00
Athul Iddya
50ce02c312
fix: check PipeWire init before creating generic capturer ( #39846 )
...
Check if PipeWire can be initialized before creating generic capturer.
This harmonizes the conditions with the ones used in Linux
implementations of DesktopCapturer::CreateRawScreenCapturer and
DesktopCapturer::CreateRawWindowCapturer.
2023-09-14 15:50:20 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
David Sanders
d6c04a3787
ci: ignore actions taken by triage bot ( #39855 )
...
* ci: ignore actions taken by triage bot
* ci: don't remove blocked label on bot comment
2023-09-14 14:01:07 -04:00
Samuel Attard
2791474a01
build: run on circle hosts for forks ( #39858 )
2023-09-14 11:07:11 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
David Sanders
650ef9a51c
build: update @electron/lint-roller to 1.9.0 ( #39812 )
2023-09-12 12:38:31 +02:00
Charles Kerr
a1c44a18e2
fix: NodeService order-of-destruction issue ( #39783 )
...
* refactor: make ElectronRendererClient::node_bindings_ a const ptr
refactor: make ElectronRendererClient::electron_bindings_ a const ptr
* fix: order-of-destruction bug in NodeService
js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_
* chore: revert unintentional commit
2023-09-12 12:27:14 +02:00
Shelley Vohr
ec9c8476fe
fix: keyCodes being incorrectly converted in webContents.sendInputEvent() ( #39776 )
...
fix: sendInputEvent keyCodes being incorrectly converted
2023-09-12 11:28:45 +02:00
Samuel Attard
470a14d8d4
docs: add missing macOS tag
2023-09-11 14:07:25 -07:00
Samuel Attard
5bff0fe342
feat: add new ElectronSquirrelPreventDowngrades flag ( #38625 )
...
* sketch
* feat: add new ElectronSquirrelPreventDowngrades flag
* test: remove only
* chore: fix lint
2023-09-11 11:54:51 -07:00
Samuel Attard
16aec702b4
fix: ensure app load is limited to real asar files when appropriate ( #39788 )
2023-09-11 11:51:14 -07:00
Samuel Attard
ac040bf734
build: update @electron/typescript-definitions to fix titlebaroverlay ( #39799 )
...
build: update @electron/typescript-definitions to fix titlebarstyle
2023-09-11 11:36:36 -07:00
David Sanders
aceb432f45
chore: remove deprecated systemPreferences APIs ( #39696 )
2023-09-11 11:34:13 -04:00
Calvin
d182794179
fix: frameless mica/acrylic windows ( #39708 )
...
* fix: backgroundMaterial works with frameless
* TODO: fix frameless mica/acrylic windows
* update caption color appropriately
* set background color properly
* refactor translucency method
* actualization
2023-09-11 14:51:54 +02:00
Shelley Vohr
ab185c058f
fix: fullscreen crashing with no roundedCorners and no frame ( #39747 )
2023-09-11 09:38:10 +02:00
David Sanders
2324c4d8fd
ci: ignore blocked label removed on closed issues ( #39793 )
2023-09-11 09:33:39 +02:00
Charles Kerr
792037b338
fix: raw_ptr destruction order in NodeBindings ( #39762 )
2023-09-07 18:25:17 -05:00
Samuel Attard
0b44f433c8
fix: make titlebar opaque while fullscreen ( #39759 )
2023-09-07 15:55:17 -07:00
github-actions[bot]
5fa9dee68a
build: update appveyor image to latest version e-118.0.5993.0 ( #39765 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-07 09:40:42 -04:00
Shelley Vohr
75bad34131
fix: prevent errors when extensions listen for chrome.tabs events ( #39729 )
...
* fix: prevent errors when extensions listen for chrome.tabs events
* chore: mark events unsupported in Electron
2023-09-07 12:41:24 +02:00
Robo
0a064cece9
fix: devtools allow restoring saved dock state on Windows ( #39734 )
...
* fix: devtools allow restoring saved dock state on Windows
* chore: address feedback
2023-09-07 17:14:01 +09:00
Milan Burda
f6e8544ef6
refactor: use replaceAll() instead of replace() when appropriate ( #39721 )
...
refactor: use replaceAll() instead of replace() when appropriate
2023-09-07 15:50:14 +09:00
electron-roller[bot]
029127a8b6
chore: bump chromium to 118.0.5993.0 (main) ( #39745 )
...
* chore: bump chromium in DEPS to 118.0.5993.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-06 19:27:25 -04:00
Milan Burda
e71a56d11e
refactor: const Module = require('module') as NodeJS.ModuleInternal; ( #38757 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-09-06 18:04:25 -04:00
Samuel Attard
65901f4c6a
fix: restore flag that allowed websockets to not be backgrounded ( #39738 )
2023-09-06 11:23:17 -07:00
github-actions[bot]
feb804cea8
build: update appveyor image to latest version ( #39716 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-09-06 14:07:34 -04:00
Shelley Vohr
34b79c15c2
build: fix depot_tools patch application ( #39742 )
...
build: fix depot_tools patch application
2023-09-06 07:49:00 -04:00
electron-roller[bot]
d9ba26273a
chore: bump chromium to 118.0.5991.0 (main) ( #39714 )
...
* chore: bump chromium in DEPS to 118.0.5982.0
* chore: bump chromium in DEPS to 118.0.5983.0
* chore: bump chromium in DEPS to 118.0.5985.0
* chore: bump chromium in DEPS to 118.0.5987.0
* chore: update v8 patches
* chore: update chromium patches
* chore: update patches
* [PEPC] Add new structs to contain permission request data
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4756727
* Add ThumbnailCapturer interface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4812256
* Reland "[ChromeRefresh2023] Update document pip windows for Chrome Refresh"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4814275
* chore: bump chromium in DEPS to 118.0.5989.0
* chore: bump chromium in DEPS to 118.0.5991.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-05 21:17:56 -04:00
David Sanders
c96bb9958f
chore: remove deprecated webContents.getPrinters() ( #39663 )
2023-09-05 10:16:41 +02:00
Milan Burda
d76a35afe4
test: remove a few casts to any ( #39713 )
2023-09-05 11:22:41 +09:00
Milan Burda
c5b20eeb13
test: add missing tests to api-web-frame-spec.ts ( #39720 )
...
test: add missing tests to spec/api-web-frame-spec.ts
2023-09-05 11:20:58 +09:00
John Kleinschmidt
4cc0f6fb78
test: fix flaky content tracing test ( #39682 )
2023-09-04 14:08:26 +02:00
Milan Burda
f27b034045
test: convert a few more specs to async/await ( #39712 )
2023-09-04 12:33:29 +02:00
Shelley Vohr
54d8402a6c
fix: broken chrome.scripting compilation ( #39725 )
...
fix: broken chrome.scripting impl after roll
2023-09-04 16:03:10 +09:00
Samuel Attard
89659fa9c9
chore: fix broken patches on main ( #39715 )
2023-09-01 01:28:01 -07:00
electron-roller[bot]
89117fdd99
chore: bump chromium to 118.0.5975.0 (main) ( #39531 )
...
* chore: bump chromium in DEPS to 118.0.5951.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4727894
No logic changes, but patch needed to be manually re-applied due to upstream code shear
* chore: update port_autofill_colors_to_the_color_pipeline.patch
No manual changes; patch applied with fuzz
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5953.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5955.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5957.0
* chore: update patches
* chore: include path of native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
* chore: remove reference to eextensions/browser/notification-types.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4771627
* chore: update references to renamed upstream field NativeWebKeyboardEvent.skip_if_unhandled (formerly known as skip_in_browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689
Need a second pair of eyes on this commit. In particular the reference in content_converter.cc, skipInBrowser, seems to not be set or documented anywhere? Is this unused/vestigal code?
* chore: sync signature of ElectronExtensionsBrowserClient::IsValidContext() to upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4784198
* chore: add auto_pip_setting_helper.[cc,h] to chromium_src build
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4688277
Exiting upstream code used by chromium_src now depends on this new upstream class
* chore: bump chromium in DEPS to 118.0.5959.0
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
manually adjust patch to minor upstream chagnes
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5961.0
* chore: bump chromium in DEPS to 118.0.5963.0
* chore: update patches
* 4780994: Rename various base files to "apple" since iOS uses them too
https://chromium-review.googlesource.com/c/chromium/src/+/4780994
* Many files moved from `mac` -> `apple`
This commit follows a handful of CLs that simply rename files/symbols to change `mac`
to `apple`
to signify their use across both macOS and iOS:
- 4784010: Move scoped_nsautorelease_pool to base/apple, leave a forwarding header
- 4790744: Move foundation_util to base/apple, leave a forwarding header
- 4790741: Move scoped_cftypreref to base/apple, leave a forwarding header
- 4787627: Move and rename macOS+iOS base/ files in PA to "apple"
- 4780399: Move OSStatus logging to base/apple
- 4787387: Remove forwarding headers
- 4781113: Rename message_pump_mac to "apple" because iOS uses it too
* fixup minor patch update error
A function param got dropped from this patch somewhere earlier
* chore: bump chromium in DEPS to 118.0.5965.2
* chore: update patches
* 4799213: Move ScopedTypeRef and ScopedCFTypeRef into base::apple::
https://chromium-review.googlesource.com/c/chromium/src/+/4799213
* Fix removed include to BrowserContext
In crrev.com/c/4767962 an include to BrowserContext was removed,
which was necessary for compilation. This broke only for us because
"chrome/browser/profiles/profile.h" includes that class, but we remove
all references to profiles.
* chore: bump chromium in DEPS to 118.0.5967.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5969.0
* chore: update patches
* chore: bump chromium in DEPS to 118.0.5971.0
* chore: bump chromium in DEPS to 118.0.5973.0
* chore: update patches
* 4772121: [OOPIF PDF] Replace PDFWebContentsHelper with PDFDocumentHelper
https://chromium-review.googlesource.com/c/chromium/src/+/4772121
* 4811164: [Extensions] Do some cleanup in ChromeManagementAPIDelegate.
https://chromium-review.googlesource.com/c/chromium/src/+/4811164
* 4809488: Remove duplicate dnd functionality between Web and Renderer prefs
https://chromium-review.googlesource.com/c/chromium/src/+/4809488
Given that this is no longer an option of web preferences, we should
consider deprecating this option and then removing it.
* chore: bump chromium in DEPS to 118.0.5975.0
* chore: update patches
* fixup! chore: add auto_pip_settings_helper.{cc|h} to chromium_src build
* Reland "[windows] Remove RegKey::DeleteEmptyKey"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4813255
* Ensure StrCat means StrCat
Refs https://chromium-review.googlesource.com/c/chromium/src/+/1117180
* fixup! Remove RegKey::DeleteEmptyKey
* Consistently reject large p and large q in DH
Refs https://boringssl-review.googlesource.com/c/boringssl/+/62226
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-09-01 15:54:59 +09:00
Milan Burda
0b0707145b
refactor: replace .forEach() with for-of ( #39691 )
...
* refactor: replace `.forEach()` with `for-of`
* refactor docs/fiddles/features/web-hid/renderer.js
2023-08-31 23:36:43 +09:00
David Sanders
7858921a1f
docs: fix return typing of ses.getExtension ( #39697 )
2023-08-30 18:10:32 -07:00
Samuel Attard
ac031bf8de
feat: I guess it's esm ( #37535 )
...
* fix: allow ESM loads from within ASAR files
* fix: ensure that ESM entry points finish loading before app ready
* fix: allow loading ESM entrypoints via default_app
* fix: allow ESM loading for renderer preloads
* docs: document current known limitations of esm
* chore: add patches to support blending esm handlers
* refactor: use SetDefersLoading instead of JoinAppCode in renderers
Blink has it's own event loop so pumping the uv loop in the renderer is not enough, luckily in blink we can suspend the loading of the frame while we do additional work.
* chore: add patch to expose SetDefersLoading
* fix: use fileURLToPath instead of pathname
* chore: update per PR feedback
* fix: fs.exists/existsSync should never throw
* fix: convert path to file url before importing
* fix: oops
* fix: oops
* Update docs/tutorial/esm-limitations.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* windows...
* windows...
* chore: update patches
* spec: fix tests and document empty body edge case
* Apply suggestions from code review
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* spec: add tests for esm
* spec: windows
* chore: update per PR feedback
* chore: update patches
* Update shell/common/node_bindings.h
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: update patches
* rebase
* use cjs loader by default for preload scripts
* chore: fix lint
* chore: update patches
* chore: update patches
* chore: fix patches
* build: debug depshash
* ?
* Revert "build: debug depshash"
This reverts commit 0de82523fb .
* chore: allow electron as builtin protocol in esm loader
* Revert "Revert "build: debug depshash""
This reverts commit ff86b1243c .
* chore: fix esm doc
* chore: update node patches
---------
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com >
2023-08-30 17:38:07 -07:00
Erick Zhao
b8ac798344
docs: use node: imports for node core modules ( #39681 )
...
docs: use `node:` imports for node builtin modules
2023-08-30 11:55:23 -04:00
David Sanders
2182202e8e
ci: use new GitHub App for issue triage related actions ( #39635 )
2023-08-30 11:09:33 -04:00
Milan Burda
e66c1f6c56
refactor: generate 'chrome:// pages' specs to remove duplicate code ( #39684 )
2023-08-30 11:07:41 -04:00
Milan Burda
9280b79112
docs: enable contextIsolation in fiddles ( #39613 )
2023-08-29 15:52:16 -04:00
Milan Burda
2e79f34c84
docs: fix the minimum supported macOS version to Catalina ( #39667 )
...
docs: update the minimum supported macOS version to Catalina
2023-08-29 09:01:11 +09:00
Tomasz
f30fbebb98
fix: promise resolved to early when browser initiated in-page navigation v2 ( #39597 )
2023-08-28 12:37:28 -04:00
Shelley Vohr
f0ad357af2
feat: support chrome.scripting extension APIs ( #39395 )
...
feat: support chrome.scripting extension APIs
2023-08-28 10:39:28 -04:00
Milan Burda
5078cae861
chore: remove deprecated ipcRenderer.sendTo() ( #39087 )
...
chore: remove deprecated ipcRenderer.sendTo()
2023-08-28 10:29:27 -04:00
Robo
b5997a012d
chore: enable v8_enable_private_mapping_fork_optimization by default ( #39253 )
...
* chore: enable v8_enable_private_mapping_fork_optimization by default
* chore: cherry-pick 292a4a6 from v8
2023-08-28 10:16:20 -04:00
Shelley Vohr
f369b144d6
feat: add more extensions manifest key options ( #39599 )
...
feat: add more manifest key options
2023-08-28 10:02:22 -04:00
Milan Burda
f2f83a73fc
docs: use electron/main & electron/renderer imports in fiddles ( #39666 )
2023-08-28 20:23:10 +09:00
Shelley Vohr
d42a94ddde
fix: webview exiting fullscreen presentation mode ( #39616 )
2023-08-25 14:11:58 -04:00
David Sanders
3bdc7ce64a
ci: don't mark status/confirmed labeled issues as stale ( #39659 )
2023-08-25 14:09:28 -04:00
David Sanders
48e14bc54e
ci: fix deprecation review automation for PRs ( #39649 )
2023-08-25 14:09:12 -04:00
John Kleinschmidt
83760bd5c6
ci: explicitly use python3 to start goma ( #39650 )
...
* ci: explicitly use python3 to start goma
* ci: explicitly use python3 for goma
2023-08-24 21:43:24 -04:00
wanted002
e14964ccd0
feat: add setter and getter apis to specify udp port range for webrtc ( #39046 )
...
* feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042)
* lint error fix for PR#39046
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview
* fix lint error
* fix lint errors in file api-web-contents-spec.ts
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc
* fix lint error
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter
2023-08-24 17:21:22 -04:00
Athul Iddya
33000c4b42
feat: enable WaylandWindowDecorations by default ( #39582 )
2023-08-24 17:02:05 -04:00
Shelley Vohr
33e66b5cd0
fix: ensure windows respect fullscreenability with different resizability values ( #39620 )
...
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen
* test: add an extra resize test
2023-08-24 16:54:08 -04:00
Shelley Vohr
2affecd4dd
feat: allow generating accessible pdf with printToPDF ( #39563 )
...
* feat: allow generating accessible pdf with printToPDF
* docs: mark generateTaggedPDF experimental
2023-08-24 11:01:59 -04:00
Erick Zhao
381c955bca
docs: mention alternative tooling ( #39337 )
...
* docs: mention alternative tooling
* Update forge-overview.md
* Update forge-overview.md
2023-08-24 12:03:30 +02:00
Charles Kerr
35969939a1
refactor: node::Environment self-cleanup ( #39604 )
...
* chore: savepoint
* chore: turn raw_ptr tests back off
2023-08-23 09:56:16 -04:00
Shelley Vohr
a8999bc529
fix: ensure BrowserView bounds are always relative to window ( #39605 )
...
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
Shelley Vohr
522bba3dc6
chore: cleanup arc migration helpers ( #39606 )
2023-08-23 09:54:21 -04:00
Shelley Vohr
ddc7e3ebb3
fix: assert module in the renderer process ( #39540 )
2023-08-23 11:38:47 +02:00
Bruno Henrique da Silva
2481f94b4e
fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack ( #39074 )
...
return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack
2023-08-23 10:49:24 +02:00
Shelley Vohr
e1d63794e5
fix: chrome.tabs 'url' and 'title' are privileged information ( #39595 )
...
fix: tabs url and title are privileged information
2023-08-22 14:56:58 +02:00
Cheng Zhao
bfa58df7c9
chore: move node headers generation to electron ( #39589 )
2023-08-22 11:13:49 +02:00
Milan Burda
c1898c39bf
chore: remove obsolete "simple" object annotations for the remote module ( #39486 )
2023-08-22 13:43:30 +09:00
Milan Burda
3102a257af
feat: expose dummy module.exports to the sandboxed preload scripts ( #39484 )
2023-08-22 13:43:08 +09:00
Milan Burda
90865fa97d
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition() ( #39479 )
...
chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
2023-08-21 15:58:09 +02:00
Charles Kerr
3a91d1f1e1
fix: dangling raw_ptr in ElectronBrowserMainParts dtor ( #39539 )
...
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor
* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor
Browser::WhenReady() holds a reference to JsEnv isolate so must come after
2023-08-21 10:29:25 +02:00
Milan Burda
09190085c0
refactor: add gin_helper::Dictionary::CreateEmpty() helper ( #39547 )
2023-08-21 10:43:41 +09:00
tr2-harada
9937a2bbe8
fix: explorer restart does not recreated thumbnail toolbar buttons ( #39551 )
...
fix: explorer restart does not recreated thumbnail toolbar buttons.
2023-08-21 09:43:49 +09:00
Shelley Vohr
95bf9d8adb
fix: chrome://gpu failing to load ( #39556 )
...
fix: chrome://gpu failing to load
2023-08-21 09:41:00 +09:00
Athul Iddya
c75e193a3e
fix: use tiled edges to calculate frame inset sizes in Linux ( #39523 )
...
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
2023-08-17 14:26:49 -04:00
Shelley Vohr
0621f39296
test: enable parallel/test-debugger-random-port-with-inspect-port ( #39533 )
...
test: enable parallel/test-debugger-random-port-with-inspect-port
2023-08-17 12:16:14 -04:00
Shelley Vohr
aeb89b143b
chore: cleanup asar initialization logic ( #39532 )
2023-08-17 16:42:53 +02:00
Charles Kerr
213388cd87
refactor: prefer Sorted variant of MakeFixedFlatSet() ( #39537 )
...
perf: prefer Sorted variant of MakeFixedFlatSet()
https://chromium-review.googlesource.com/c/chromium/src/+/4660000
says that the sorted version is simpler at compile time because it
can skip MakeFixedFlatSet()'s compile-time dynamic sorting.
2023-08-17 08:58:04 -05:00
David Sanders
8374b9c2ad
ci: add prev-major variable to release board templating ( #39454 )
2023-08-17 14:24:57 +02:00
Shelley Vohr
00746e662b
feat: allow headers to be sent with webContents.downloadURL() ( #39455 )
...
feat: allow headers to be sent with webContents.downloadURL()
2023-08-17 14:17:55 +02:00
Shelley Vohr
31dfde7fa6
docs: note macOS bounds Tray offset ( #39512 )
...
* docs: note macOS bounds Tray offset
* Update docs/api/browser-window.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-08-17 11:02:03 +02:00
Charles Kerr
dd8df3b0c4
fix: destruction order of js env fields ( #39521 )
...
isolate_ depends on isolate_holder_ and so must be destroyed first.
2023-08-16 23:06:24 -05:00
Milan Burda
b04ce6a5c8
docs: add missing webview render-process-gone event ( #39494 )
...
docs: add mising webview 'render-process-gone' event
2023-08-17 08:52:15 +09:00
Keeley Hammond
fce9ed65d6
build: update NMV to 118 ( #39538 )
2023-08-16 11:46:16 -07:00
github-actions[bot]
a4a3ba9341
build: update appveyor image to latest version - e-118.0.5949.0. ( #39524 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-16 14:06:19 -04:00
John Kleinschmidt
9d6d606192
build: fixup libcxx zip ( #39536 )
2023-08-16 14:05:39 -04:00
Shelley Vohr
1eb398b328
fix: crash when calling BrowserWindow.moveTop() on modal children ( #39499 )
...
fix: crash when calling moveTop() on modal children
2023-08-16 13:28:29 +02:00
Sergei Chestakov
f7a7085019
docs: fix typo in open-url API docs ( #39513 )
...
* Fix typo in open-url API docs
* Update app.md
2023-08-16 12:26:02 +02:00
electron-roller[bot]
0c45d160d6
chore: bump chromium to 118.0.5949.0 (main) ( #39505 )
...
* chore: bump chromium in DEPS to 118.0.5949.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4705386
no manual code changes; existing patch applied with fuzz
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4779059
no manual code changes; existing patch applied with fuzz
* chore: add OffScreenRenderWidgetHostView::InvalidateLocalSurfaceIdAndAllocationGroup()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4563504
Add an impl for a new pure virtual method that was added upstream.
Local impl inspired by upstream implementations in same CL
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-08-15 15:44:24 -04:00
Shelley Vohr
22429e2112
refactor: clean up Node.js cli arg parsing ( #39465 )
...
* refactor: clean up Node.js arg parsing
* chore: feedback from review
2023-08-15 14:49:21 -04:00
David Sanders
1d20ec5b99
ci: fix @electron/github-app-auth CLI usage ( #39507 )
2023-08-15 11:41:29 -07:00
Michaela Laurencin
22c359ac4f
docs: update timelines for E27 ( #39493 )
2023-08-15 12:57:48 -05:00
electron-roller[bot]
c3036d4557
chore: bump chromium to 117.0.5938.0 (main) ( #39375 )
...
* chore: bump chromium in DEPS to 117.0.5929.0
* chore: bump chromium in DEPS to 117.0.5931.0
* chore: bump chromium in DEPS to 117.0.5932.0
* chore: update patches
* 4728317: Prevent PrintRenderFrameHelper from printing when already printing
| https://chromium-review.googlesource.com/c/chromium/src/+/4728317
* 4739501: Use base::SequenceBound to manage SerialPortManagerImpl |
https://chromium-review.googlesource.com/c/chromium/src/+/4739501
* 4702051: Allow overriding source in install-sysroot.py | https://chromium-review.googlesource.com/c/chromium/src/+/4702051
* chore: update filenames.libcxx.gni
* 4727002: Rename "enable_arc2" to "enable_arc" |
https://chromium-review.googlesource.com/c/chromium/src/+/4727002
* chore: bump chromium in DEPS to 117.0.5934.0
* 4736873: Rename ColorSpaces methods on display::Display | https://chromium-review.googlesource.com/c/chromium/src/+/4736873
* 4727203: Replace bool with an enum in as suggested in DevtoolsManagerDelegate. | https://chromium-review.googlesource.com/c/chromium/src/+/4727203
* 4744479: [DevTools] Add 'generateTaggedPDF' option to DevTools Page.printToPDF | https://chromium-review.googlesource.com/c/chromium/src/+/4744479
* 4735893: Don't share WebUSB permissions with webviews | https://chromium-review.googlesource.com/c/chromium/src/+/4735893
* revert: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 117.0.5936.0
* chore: update patches
* 4746465: SAA: Query for embargoed StorageAccess permissions | https://chromium-review.googlesource.com/c/chromium/src/+/4746465
* 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
* chore: bump chromium in DEPS to 117.0.5938.0
* chore: bump chromium in DEPS to 118.0.5939.0
* chore: update patches
* Send line bounds through CursorAnchorInfo on requestCursorUpdate
https://chromium-review.googlesource.com/c/chromium/src/+/4394588
* Fixup lint for Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src
* 4700305: [mac] Fix override of CHILD_PROCESS_EXE
https://chromium-review.googlesource.com/c/chromium/src/+/4700305
Needed because of 4729689: Reland "Remove redundant existence check in PathService" | https://chromium-review.googlesource.com/c/chromium/src/+/4729689
* 4753759: More consistent icon handling for menus.
https://chromium-review.googlesource.com/c/chromium/src/+/4753759
* chore: bump chromium in DEPS to 118.0.5941.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5938.0
* test: update nan-spec-runner cflags
* build: fix isystem include path in nan-spec-runner
* fixup! 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
fix a few more instances of the old path
libc++.a and libc++abi.a are still in buildtools/
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-15 10:49:41 -05:00
Robo
bee5d94886
feat: support dns-result-order Node.js cli flag ( #39376 )
...
* feat: support dns-result-order Node.js cli flag
* chore: update docs
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* chore: remove patch
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2023-08-15 12:19:45 +02:00
electron-roller[bot]
ef5d5f888d
chore: bump node to v18.17.1 (main) ( #39457 )
...
* chore: bump node in DEPS to v18.17.1
* chore: update patches
* policy: disable process.binding() when enabled
d4570fae35
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-08-15 10:06:55 +02:00
wgsheng
127584dc37
feat: add a 'title' parameter to openDevTools() ( #39047 )
...
* [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar
* all titles->title
* add GetDevToolsTitle(),update docs
* fix:lint error
* fix:lint error
* add setDevToolTitle
* lint errror
* lint errror
* ling errror (.md)
* build error
* build error in mac
* build error
* build error
* change docs
* std::string->std::u16string
* lint error
* build error
* build error
2023-08-15 14:32:53 +09:00
Shelley Vohr
8e3dcc8b17
refactor: update WebContentsZoomController ( #39428 )
...
refactor: update WebContentsZoomController
2023-08-15 10:33:30 +09:00
David Sanders
5d11c30720
ci: improve blocked/need-repro workflow ( #39451 )
...
* ci: improve blocked/need-repro workflow
* ci: let maintainer comments suppress bot comment
* ci: ensure failures bubble up
2023-08-15 10:32:38 +09:00
David Sanders
813853297d
ci: automation for deprecation project board ( #39477 )
2023-08-15 10:28:42 +09:00
David Sanders
dbff7bb531
ci: automation for issue triage board ( #39464 )
2023-08-15 10:28:17 +09:00
David Sanders
effafdf498
test: use as const to remove some usages of as any ( #39475 )
2023-08-15 10:24:32 +09:00
Shelley Vohr
9eeef55469
test: resolve failing Node.js line number failure ( #39490 )
2023-08-14 13:08:55 -04:00
David Sanders
1b3e4dae8d
chore: document deprecated systemPreferences APIs ( #39343 )
...
* chore: document deprecated systemPreferences APIs
* chore: forgot systemPreferences.appLevelAppearance
* test: expect deprecation messages
2023-08-14 11:34:04 +02:00
Milan Burda
d5f31c2208
docs: remove duplicate fiddles (part #2 ) ( #39474 )
...
docs: remove duplicate fiddles
2023-08-14 10:44:07 +02:00
David Sanders
d166182865
chore: remove deprecated systemPreferences color scheme events ( #39341 )
2023-08-14 10:37:18 +02:00
Cheng Zhao
cf658b700d
fix: use nested run loop in clipboard.readImage ( #39466 )
2023-08-14 10:35:37 +02:00
Milan Burda
08bbff5361
docs: handle opening links in the default browser in main.js (part #2 ) ( #39473 )
...
docs: handle opening links in the default browser in main.js
2023-08-14 10:04:29 +02:00
Shelley Vohr
117d5310f5
revert: promise resolved too early when browser initiates in-page navigation ( #39481 )
...
This reverts commit a0effaf9b8 .
2023-08-14 13:13:15 +09:00
John Kleinschmidt
f16dffccd0
ci: fixup known hosts for linux publish ( #39437 )
...
* ci: fixup known hosts for linux publish
* build: use 2023 known hosts
* build: use rebuilt docker image
* Revert "build: use rebuilt docker image"
This reverts commit f9506a9cc0 .
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-08-10 12:40:58 -04:00
Milan Burda
255064659f
docs: update external links ( #39421 )
2023-08-10 11:55:52 +02:00
David Sanders
11600c5f96
chore: document deprecated webContents.getPrinters API ( #39356 )
...
* chore: document deprecated webContents.getPrinters API
* chore: remove duplicate deprecation warning
2023-08-10 11:50:30 +02:00
Milan Burda
1ce2fdd63d
docs: fix take-screenshot fiddle to use desktopCapturer in main.js ( #39420 )
2023-08-10 10:53:23 +02:00
Milan Burda
c4d417b6f6
docs: remove duplicate fiddles ( #39419 )
2023-08-10 10:52:52 +02:00
Milan Burda
0f49868234
chore: deprecate senderId and senderIsMainFrame ( #39381 )
2023-08-09 10:38:48 -04:00
Shelley Vohr
70508b5273
chore: update _api_features manifest requirements ( #39412 )
...
chore: update api_resources manifest requirements
2023-08-09 10:38:13 -04:00
Tomasz
a0effaf9b8
fix: promise resolved to early when browser initiated in-page navigation ( #39260 )
2023-08-09 16:06:39 +02:00
Shelley Vohr
d9329042e2
feat: add support for chrome.tabs.query ( #39330 )
...
* feat: add support for tabs.query
* fix: scope to webContents in current session
* test: add test for session behavior
2023-08-09 14:47:19 +02:00
David Sanders
0425454687
test: helper to expect deprecation warnings ( #39405 )
2023-08-09 11:01:52 +02:00
Samuel Attard
d24d8f1f78
fix: avoid package.json check on built-in modules ( #39418 )
2023-08-09 00:32:00 -07:00
electron-roller[bot]
ab08803959
chore: bump node to v18.17.0 (main) ( #39154 )
...
* chore: bump node in DEPS to v18.17.0
* chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch
Xref: https://github.com/nodejs/node/pull/46930
manually sync patch to minor upstream code shear
* chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch
Xref: https://github.com/nodejs/node/pull/48248
manually sync patch to minor upstream code shear
* chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/47824
chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it
* chore: update api_pass_oomdetails_to_oomerrorcallback.patch
Xref: https://github.com/nodejs/node/pull/47695
manually sync patch to minor upstream code shear
* chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch
Xref: https://github.com/nodejs/node/pull/46979 (upstreamed patch)
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related)
* chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch
Xref: https://github.com/nodejs/node/pull/47274
manually sync patch to minor upstream code shear
some tests moved from sequential to parallel
* chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch
Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch
Xref: https://github.com/nodejs/node/pull/47339
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: rebuild filenames.json
several files removed/added/changed upstream
* chore: update build_add_gn_build_files.patch
upstream dep histogram 0.11.7 moved its include path from src/ to include/
Xref: https://github.com/nodejs/node/pull/47742
* chore: update fix_crypto_tests_to_run_with_bssl.patch
Xref: https://github.com/nodejs/node/pull/47160
BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of
BIO_s_mem()), so use BIO_s_mem() instead.
Related discussion of secure heap support in BoringSSL:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: ftbfs in node dep ada
* fix: ftbfs in node dep uvwasi
* chore: rebuild patches
* chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch
Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`.
BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead.
Upstream Node.js change that prompted this:
https://github.com/nodejs/node/pull/47160
Related discussion of BoringSSL support of secure heap:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: work around Node 18 isURL() regression
* chore: sort script/node-disabled-tests.json alphabetically
* test: add parallel/test-snapshot-argv1 to disabled list
test: add parallel/test-snapshot-namespaced-builtin to disabled list
We don't support that type of snapshotting at the moment.
* chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error
fails upstream in v18.x on my box as well
* ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
* fixup! fix: work around Node 18 isURL() regression
fix: infinite loop regression
* fixup! fix: work around Node 18 isURL() regression
* chore: patch fixtures/errors/force_colors.snapshot
The line numbers in the stacktrace from our v8 build don't match what
Node's tests are expecting, so update the stacktrace to match our build.
The specific numbers probably aren't t needed for the force_colors test,
which is trying to see whether or not the lines are greyed out. One option
is to upstream a test change to stop hardcoding the stacktrace.
* fixup! fix: work around Node 18 isURL() regression
fix; pull in upstream bugfix
* fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js
* chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-08-08 17:52:51 -05:00
Shelley Vohr
5e59ddca1a
chore: update chrome.runtime.getPlatformInfo impl ( #39392 )
...
chore: update chrome.runtime.getPlatformInfo impl
2023-08-08 22:29:03 +02:00
Shelley Vohr
1b3c63145c
chore: remove i18n JSON spec ( #39391 )
2023-08-08 14:02:16 -04:00
Samuel Attard
814735cb72
build: use aks backed runners for linux builds ( #39403 )
...
* build: test aks runner
* build: stress test
* build: use super-large nodes for publish jobs
* build: try using aks for everything...
* build: shared host not great
* build: clean up
* build: apparently tests dont run in kube infra?
* build: do not change test size
2023-08-08 09:56:41 -07:00
David Sanders
dcf1c65426
chore: fix ipcRenderer.sendTo deprecation warning ( #39342 )
2023-08-08 13:49:56 +02:00
Milan Burda
24c9cbcc0a
docs: handle opening links in the default browser in main.js ( #39379 )
...
docs: handle opening links in the default browser in the main process
2023-08-08 12:35:59 +02:00
Robo
eecfaec8c9
fix: crash when closing active macOS native tab ( #39394 )
...
fix: crash when closing current active macOS native tab
2023-08-08 17:45:03 +09:00
Shelley Vohr
8f4f82618c
fix: removeBrowserView draggable region removal ( #39387 )
...
fix: removeBrowserView draggable region removal
Closes https://github.com/electron/electron/issues/39377 .
2023-08-08 10:23:14 +02:00
github-actions[bot]
1548a2f9fb
build: update appveyor image to e-117.0.5921.0 ( #39390 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-07 13:08:53 -07:00
Milan Burda
3d45429667
refactor: use for-of instead of for simple array iteration ( #39338 )
2023-08-07 11:30:15 +02:00
Shelley Vohr
67523a47b4
fix: chrome.tabs.update return value ( #39365 )
...
fix: chrome.tabs.update return value
2023-08-07 10:03:45 +02:00
David Sanders
330c775252
docs: fix description of pageRanges ( #39378 )
...
Co-authored-by: Alain BUFERNE <albu.consult@gmail.com >
2023-08-07 09:56:36 +02:00
Shelley Vohr
dc707ee938
fix: macOS tray button selection with VoiceOver ( #39352 )
2023-08-07 09:52:18 +02:00
John Kleinschmidt
1eb6e45a36
ci: fix hang when validating AppVeyor artifacts ( #39362 )
2023-08-07 09:51:53 +02:00
Shelley Vohr
2e0517c0ad
feat: allow more Node.js cli flags in main process ( #39344 )
...
* feat: allow more Node.js cli flags in main process
* docs: update cli switch documentation
2023-08-04 19:59:40 +09:00
electron-roller[bot]
c5b9f766f3
chore: bump chromium to 117.0.5923.0 (main) ( #39304 )
...
* chore: bump chromium in DEPS to 117.0.5921.0
* chore: update chromium patches
* 4721409: Remove redundant ARC configuration in /components | https://chromium-review.googlesource.com/c/chromium/src/+/4721409
* 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* 4022621: Re-register status item when owner of status watcher is changed | https://chromium-review.googlesource.com/c/chromium/src/+/4022621
* chore: update V8/boringssl patches
* fixup! 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* chore: bump chromium in DEPS to 117.0.5923.0
* build [debug]: remove assert
4722125: Update enterprise content analysis buildflags usage | https://chromium-review.googlesource.com/c/chromium/src/+/4722125
* chore: manually rollback to 117.0.5921.0
* build [arc]: ARC conversion in auto_updater
* build [arc]: ARC conversion in browser/api
* build [arc]: ARC conversion in notifications/mac
* build [arc]: ARC conversion in in_app_purchase
* build [arc]: ARC conversion in browser/ui
* build [arc]: ARC conversion in ui/cocoa
* build [arc]: ARC conversion in shell/common
* build [arc]: ARC conversion in OSR
* build [arc]: ARC conversion in login_helper
* build [arc]: ARC conversion in app_mas
* build [arc]: fix up ARC syntax (thanks @codebytere!)
* 4726946: [Extensions] Work around dangling BrowserContext pointer. | https://chromium-review.googlesource.com/c/chromium/src/+/4726946
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-08-04 10:47:29 +02:00
Shelley Vohr
6d0e8044eb
fix: update chrome.tabs for Manifest v3 ( #39317 )
2023-08-03 18:34:02 +02:00
Shelley Vohr
f8b05bc127
feat: support minimum_chrome_version manifest key ( #39256 )
...
feat: support minimum_chrome_version extension key
2023-08-03 11:38:31 -04:00
David Sanders
e6931a788f
docs: clean up removed systemPreferences methods ( #39334 )
2023-08-03 14:40:29 +02:00
Robo
e96b1613a4
fix: destroy message port backend when JS env exits ( #39335 )
2023-08-03 14:30:19 +02:00
Milan Burda
fe93f69e5a
refactor: use Set instead of Array when appropriate ( #39324 )
2023-08-03 14:29:57 +02:00
Milan Burda
c5e50e4882
refactor: use more appropriate array methods ( #39321 )
2023-08-02 19:43:45 +02:00
Shelley Vohr
7686d1c379
docs: correct powerSaveBlocker.stop(id) return type ( #39320 )
...
doc: correct powerSaveBlocker.stop return type
2023-08-02 11:39:40 +02:00
Shelley Vohr
303b707fbf
fix: update chrome.i18n for Manifest v3 ( #39291 )
...
fix: update chrome.i18n for Manifest v3
2023-08-02 11:02:16 +02:00
github-actions[bot]
aaae2abf20
build: update appveyor image to latest version e-117.0.5911.0. ( #39318 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-08-02 10:23:21 +02:00
David Sanders
0eef6c67d1
docs: fix return type for ipcMain handle functions ( #39237 )
2023-08-01 10:02:20 +02:00
Shelley Vohr
1f19a74417
fix: potential crash calling tray.popUpContextMenu() ( #39231 )
...
fix: potential crash calling tray.popUpContextMenu
2023-08-01 15:07:30 +09:00
Shelley Vohr
c8f7a0e052
fix: Chrome Extensions service worker host registration ( #39290 )
2023-08-01 15:04:38 +09:00
David Sanders
b2c62d6ad1
fix: initial dark mode title bar on Windows 10 ( #39287 )
2023-07-31 22:02:23 -07:00
electron-roller[bot]
cfc0826b65
chore: bump chromium to 117.0.5913.0 (main) ( #39172 )
...
* chore: bump chromium in DEPS to 117.0.5899.0
* 4686653: webui: Filter out non-chrome scheme URLs in WebUIConfigMap
https://chromium-review.googlesource.com/c/chromium/src/+/4686653
* 4696355: Remove deprecated version of base::CommandLine::CopySwitchesFrom()
https://chromium-review.googlesource.com/c/chromium/src/+/4696355
* chore: fixup patch indices
* 4603888: Reland "Enable raw_ref check on linux"
https://chromium-review.googlesource.com/c/chromium/src/+/4603888
* chore: bump chromium in DEPS to 117.0.5901.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5903.0
* chore: bump chromium in DEPS to 117.0.5903.2
* chore: bump chromium in DEPS to 117.0.5905.0
* 4706792: Printing: Add debug code for a DispatchBeforePrintEvent() failure
https://chromium-review.googlesource.com/c/chromium/src/+/4706792
* 4704786: Refactor libunwind build rules/flags
https://chromium-review.googlesource.com/c/chromium/src/+/4704786
* 4701710: [Linux Ui] Set toolkit dark preference based on FDO dark preference
https://chromium-review.googlesource.com/c/chromium/src/+/4701710
* chore: fixup patch indices
* chore: bump chromium in DEPS to 117.0.5907.0
* chore: bump chromium in DEPS to 117.0.5909.2
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5911.0
* chore: update patches
* chore: build-what-we-include
* fix: set allowFileAccess on devtools extensions correctly
Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725
* 4670615: Reland "[iterator-helpers] Shipping iterator helpers"
https://chromium-review.googlesource.com/c/v8/v8/+/4670615
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-07-31 10:47:32 -07:00
Shelley Vohr
8e5bb4949b
fix: skip artifact validation for doc-only PRs ( #39296 )
2023-07-31 09:59:51 -04:00
Milan Burda
724f90a2a7
refactor: throw errors directly in async functions ( #39233 )
2023-07-31 10:39:37 +02:00
David Sanders
68701c4c3c
chore: update @electron/lint-roller and improve doc type checks ( #39262 )
2023-07-31 10:39:01 +02:00
hunter
2b283724ce
docs: fix some string union type ( #39258 )
...
* docs: fix some string union types
Improve Type Union Typings in the Docs
* test: add smoke tests
* test: update `ses.clearStorageData` test case
* test: update `ses.clearStorageData` test case
---------
Co-authored-by: mhli <mhli@hillinsight.com >
2023-07-31 10:32:59 +02:00
Shelley Vohr
6df392162f
fix: pageVisibility state when backgroundThrottling disabled ( #39223 )
...
fix: pageVisibility state when backgroundThrottling disabled
2023-07-28 10:48:25 +02:00
Milan Burda
c9bae5da8e
refactor: use optional catch binding ( #39232 )
2023-07-27 10:53:45 -04:00
Samuel Attard
8dea783805
fix: do not resolve electron entrypoints on disk ( #39247 )
2023-07-26 22:10:58 -07:00
Shelley Vohr
695fcf3cb2
fix: reparenting after BrowserWindow.destroy() ( #39062 )
...
fix: reparenting after BrowserWindow.destroy()
2023-07-26 16:47:32 +02:00
Athul Iddya
fa5b1be6f3
fix: delete desktop capturers when they're not needed ( #39194 )
...
* fix: delete desktop capturers when they're not needed
Delete desktop capturer objects by resetting the DesktopMediaList
objects that own them after the sources have been collected. Capturers
that are not delegated are already being reset via a patch on
NativeDesktopMediaList. That is not safe for delegated capturers as
thumbnail generation depends on user events. Deleting the
DesktopMediaList operation is safe for all capturers and releases OS
capture resources as soon as possible.
* fix: add a patch to clean up PipeWire resources
Adding a patch to workaround a Chromium issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1467060
The patch can be removed when the issue is resolved.
2023-07-26 10:40:19 +02:00
Shelley Vohr
38c3d8df29
fix: traffic lights not working when child windows are restored via parent window ( #39225 )
2023-07-26 10:10:34 +02:00
Shelley Vohr
12548294c0
fix: resizable: false should disable fullscreen button at start ( #39086 )
...
fix: resizable should disable fullscreen button at start
2023-07-25 12:18:36 -04:00
Milan Burda
455f57322f
refactor: use TypeError instead of generic Error when appropriate ( #39209 )
...
refactor: use TypeError instead of generic Error when appropriate
2023-07-25 12:08:46 -04:00
George Xu
77cc1d6ffa
chore: add dependencies upgrade policy to readme ( #39163 )
...
* chore: add dependencies upgrade policy to readme
as per wg-releases july 19 meeting
https://docs.google.com/document/d/1XWdD4uAu9m8Gcpiw1j5fLwwZ_hU4rce9JyTpuKU6uM8/edit?pli=1
* Update CONTRIBUTING.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-07-25 11:58:16 +02:00
John Kleinschmidt
e543126957
ci: fail appveyor build if artifacts are missing ( #39210 )
2023-07-24 16:38:34 -04:00
Shelley Vohr
1231f0a734
docs: document idleDetector permissions ( #39180 )
...
doc: document idleDetector permissions
2023-07-24 14:57:41 -04:00
github-actions[bot]
cd408a826c
build: update appveyor image to latest version - e-117.0.5897.0 ( #38970 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-07-24 12:44:27 -04:00
Milan Burda
3df6d337f3
feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo() ( #38868 )
...
* feat: add isMainFrame to events emitted via ipcRenderer.sendTo()
* chore: rename isMainFrame to senderIsMainFrame
2023-07-24 14:27:30 +02:00
Michaela Laurencin
09e6e4b9a7
docs: update window-open.md to include target ( #39162 )
...
Update window-open.md to include target
2023-07-24 12:33:41 +02:00
David Sanders
2caf08059e
docs: update @electron/fuses code examples ( #39175 )
2023-07-24 12:33:26 +02:00
David Sanders
1ca3a7d3c9
docs: fill in Node.js version for v25 release ( #39187 )
2023-07-24 12:33:10 +02:00
Milan Burda
2c52eb7e1c
refactor: replace .indexOf() with .includes() ( #39195 )
2023-07-24 12:32:54 +02:00
Athul Iddya
9cd5de7588
fix: use generic capturer to list both screens and windows when possible ( #39111 )
...
Screensharing with PipeWire via XDG Desktop Portal requires explicit
user permission via permission dialogs. Chromium has separate tabs for
screens and windows and thus its portal implementation requests
permissions separately for each. However, the screencast portal has no
such limitation and supports both screens and windows in a single
request.
WebRTC now supports this type of capture in a new method called
called `CreateGenericCapturer`. The `desktopCapturer` implementation has
been modified to use it. Additionally, Chromium has been patched to use
same generic capturer to ensure that the source IDs remain valid for
`getUserMedia`.
2023-07-21 16:03:01 -07:00
David Sanders
a83f9c06d7
docs: update binding linking example in creating API doc ( #39177 )
2023-07-21 14:33:39 -07:00
David Sanders
b66449add5
ci: don't set column for draft issues on new project board ( #39178 )
2023-07-21 14:33:14 -07:00
Milan Burda
ada8eb33b2
feat: deprecate ipcRenderer.sendTo() ( #39091 )
...
* feat: deprecate ipcRenderer.sendTo()
* docs: add _Deprecated_ to ipcRenderer.sendTo()
2023-07-21 11:16:44 +02:00
David Sanders
3a5e2dd90c
docs: remove redundant IPC event sections ( #39133 )
...
* docs: use correct names for IPC events
* docs: remove redundant IPC event sections
2023-07-20 11:43:08 -07:00
Shelley Vohr
6688b0f31a
build: fix Appveyor test workflow checkout ( #39137 )
...
* build: fix Appveyor test workflow checkout
* fix: +refs/pull/num/merge -> +refs/pull/num/head
* chore: add to appveyor-woa as well
2023-07-20 11:19:57 +02:00
David Sanders
565705bd1d
docs: fix casing of _Deprecated_ ( #39152 )
2023-07-20 11:16:20 +02:00
electron-roller[bot]
e02cf8674d
chore: bump chromium to 117.0.5897.0 (main) ( #39147 )
...
* chore: bump chromium in DEPS to 117.0.5896.0
* chore: update patches
* 4622260: [Service Workers] Allow fetches from workers to use auto-picked certs
https://chromium-review.googlesource.com/c/chromium/src/+/4622260
* chore: bump chromium in DEPS to 117.0.5897.0
* 4665672: [ProfileSelections] Transition extension keyed factories to use Profile Selections
https://chromium-review.googlesource.com/c/chromium/src/+/4665672
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-20 09:36:59 +02:00
dependabot[bot]
3e7c904f02
build(deps): bump word-wrap from 1.2.3 to 1.2.4 ( #39148 )
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-19 19:24:26 +02:00
Charles Kerr
f2b32af1f6
perf: small perf changes in HidChooserController ( #39057 )
...
* perf: avoid string temporary in HidChooserController::PhysicalDeviceIdFromDeviceInfo()
return a const ref instead of a new string
* perf: avoid second map lookup in HidChooserController::AddDeviceInfo()
2023-07-19 16:54:30 +02:00
Cheng Zhao
cc39ddb728
test: add some environment variables for controlling tests ( #39149 )
...
chore: add some environment variables for controlling tests
2023-07-19 16:54:08 +02:00
electron-roller[bot]
bbdd037219
chore: bump chromium to 117.0.5892.0 (main) ( #39118 )
...
* chore: bump chromium in DEPS to 117.0.5892.0
* 4670267: Don't send javascript: or empty URLs to browser in CreateNewWindow.
https://chromium-review.googlesource.com/c/chromium/src/+/4670267
* 4662090: Add metrics for WebGPU support
https://chromium-review.googlesource.com/c/chromium/src/+/4662090
* 4672599: Use set_defaults for mac_app_bundle
https://chromium-review.googlesource.com/c/chromium/src/+/4672599
* 4663771: usb: Add connection count tracking methods for UsbDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/4663771
* 4664578: Remove unused parameter from ExtensionsGuestViewManagerDelegate ctor
https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* 4622253: usb: Create classes for usb system tray icon
https://chromium-review.googlesource.com/c/chromium/src/+/4622253
* 4678263: Remove ARC support from scoped_nsobject
https://chromium-review.googlesource.com/c/chromium/src/+/4678263
* chore: follow-up ARC changes and missing guard corrections
* chore: don't mark 0-param ctor explicit
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/4664578
* chore: fixup patch indices
* 4670865: Merge ObjectProxy::CallMethodAndBlock{,WithErrorDetails}.
https://chromium-review.googlesource.com/c/chromium/src/+/4670865
* chore: follow-up ARC changes and missing guard corrections
* fixup: retain ElectronApplicationDelegate
* fix: correct rustc binary
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-19 00:26:27 +02:00
Shelley Vohr
ee4460ac68
build: correct codespaces devcontainer extensions settings ( #39123 )
2023-07-19 00:20:11 +02:00
Shelley Vohr
00d96970cb
build: fixup Codespaces build-tools setup ( #39138 )
...
* build: fixup Codespaces build-tools setup
* oops evm.testing1.json -> evm.testing.json
2023-07-18 22:58:26 +02:00
Keeley Hammond
139774ce48
docs: update stable dates ( #39128 )
2023-07-18 09:30:04 -07:00
Milan Burda
47951cc95b
refactor: use Date.now() instead of +new Date() ( #38901 )
...
refactor: use Date.now()
2023-07-18 10:58:02 +02:00
Shelley Vohr
8874306dc0
fix: window.open causing occasional Node.js crashes ( #38754 )
...
* fix: window.open causing occasional Node.js crashes
* chore: always free isolate data
* chore: clear pending ticks in worker thread
* fix: UAF crash when creating WebWorkerObserver
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-07-18 10:41:50 +02:00
ZWJKFLC
4ab0a5ade4
docs: fix a capitalization problem in messagePort tutorial ( #39083 )
...
fix a capitalization problem
For a rookie, this little mistake took a long time to find out.
2023-07-17 10:41:46 -07:00
Milan Burda
626f46f75a
refactor: use node scheme imports in docs/fiddles ( #39110 )
2023-07-17 10:30:53 +02:00
electron-roller[bot]
9645f7f6d8
chore: bump chromium to 117.0.5884.1 (main) ( #38969 )
...
* chore: bump chromium in DEPS to 117.0.5866.0
* chore: bump chromium in DEPS to 117.0.5868.0
* chore: update mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Minor manual patch syncing due to upstream code shear
* chore: update mas_disable_remote_layer.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4647191
Manually sync patch to minor upstream code shear
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641746
No manual changes; patch applied with fuzz
* chore: update mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925
Manually sync base/process/launch_mac.cc to minor upstream shear
Manually sync base/mac/foundation_util.mm to upstream changes:
_CFIsObjC use has been removed upstream, so we no longer need
to remove it 🎉
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658496
Manually sync patch to minor upstream code shear
* chore: update disable_color_correct_rendering.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4625254
Manually sync patch to minor upstream code shear
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Xref: services/network/public/cpp/resource_request.cc
No manual changes; patch applied with fuzz
* chore: update add_electron_deps_to_license_credits_file.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634961
No manual changes; patch applied with fuzz
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4648411
No manual changes; patch applied with fuzz
* chore: update patches
* fixup! chore: update add_electron_deps_to_license_credits_file.patch
chore: license files must be an array
* chore: bump chromium in DEPS to 117.0.5870.0
* chore: update patches
* chore: run ./script/gen-libc++-filenames.js
* chore: update json_parse_errors_made_user-friendly.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4652014
v8 error message changed upstream; update Node test to match it
* chore: bump chromium in DEPS to 117.0.5872.0
* chore: update patches
* chore: explicitly cast x11::Window to unsigned int
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661049
This is an `enum class Window : uint32_t` defined in ui/gfx/x/xproto.h.
Previous versions of clang let this implicit cast happen,
but it generates a warning in the new clang roll.
* chore: remove unused #include
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4650453
header was removed upstream, so FTBFS unless removed here
* chore: add include guard patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4628373
h/t @jkleinsc
* chore: bump chromium in DEPS to 117.0.5874.0
* chore: update render_widget_host_view_mac.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661244
Manually sync patch to minor upstream code
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to upstream code shear
* chore: update build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209
Manually sync patch to minor upstream code shear
* chore: update GetInitiatorProcessId()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641991
trivial upstream naming change: s/ProcessID/ProcessId/
* chore: sync to upstream SetInputRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4665245
Simple upstream chang: SetInputRegion() used to take a gfx::Rect* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<gfx::Rect> w/the same meaning.
* chore: sync to upstream SetOpaqueRegion() changes
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4656738
Simple upstream chang: SetOpaqueRegion() used to take a vector<Rect>* where
`nullptr` meant "no opaque region". The function signature changed to
absl::optional<std::vector<gfx::Rect>> w/the same meaning.
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5876.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658375
We no longer need to patch out a field that's now removed upstream.
RenderWidgetHostNSViewBridgeOwner.remote_accessibility_element_
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658680
Manually sync patch to upstream code shear (ARC adoption).
* chore: update patches
* fix: -Werror,-Wshadow error in Node.js
* chore: bump chromium in DEPS to 117.0.5878.0
* chore: bump chromium in DEPS to 117.0.5880.0
* chore: bump chromium in DEPS to 117.0.5880.4
* chore: update patches
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
* WIP: 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
* chore: update printing patch after rebase
* chore: bump chromium in DEPS to 117.0.5882.0
* Revert "WIP: 4658680: Convert /content/browser to use ARC"
This reverts commit c8559ea448 .
* Revert "4669995: Remove CFToNSCast and NSToCFCast"
This reverts commit 38e145f33d .
* chore: bump chromium in DEPS to 117.0.5874.0
* 4661244: Convert /content/browser/renderer_host to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4661244
* 4653209: Convert /ui/views:views to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4653209
* chore: fixup mas_disable_remote_accessibility.patch
* chore: fixup render_widget_host_view_mac.patch
* chore: update to newer clang
* chore: bump chromium in DEPS to 117.0.5884.1
(cherry picked from commit a3879acfde8f3d962d58d6ad0632164ccb88ee63)
* 4669995: Remove CFToNSCast and NSToCFCast
https://chromium-review.googlesource.com/c/chromium/src/+/4669995
(cherry picked from commit 38e145f33d )
(cherry picked from commit b1224ab7e00aedbd0e5dc78ebb3c6162573b28c4)
* 4658680: Convert /content/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4658680
(cherry picked from commit 77039a323b9ebb3e8edb3a92a3b94a8d7d026a32)
* Rename and cleanup ExtensionsBrowserClient functions
| https://chromium-review.googlesource.com/c/chromium/src/+/4665670
(cherry picked from commit 677a2e646a8d82da60dc252b08b320c3ddff6be6)
* chore: bump chromium in DEPS to 117.0.5886.0
* chore: update patches
* Revert "chore: update patches"
This reverts commit db9294f944 .
* Revert "chore: bump chromium in DEPS to 117.0.5886.0"
This reverts commit a7de0276e6 .
* build: use built toolchains instead of locally installed VSCode
* fixup: build: use built toolchains instead of locally installed VSCode
* chore: add missing mojo dep
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-16 16:14:43 +02:00
Shelley Vohr
f61425efdb
fix: clipboard.readImage() should be synchronous ( #39069 )
...
* feat: clipboard.readImage returns a Promise
* chore: update breaking changes doc
* fix: make function synchronous
* Update docs/api/native-image.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-07-13 16:59:14 -04:00
Robo
34e7c3696a
feat: expose safestorage backend information on linux ( #38873 )
...
* feat: expose safestorage backend information on linux
* Remove gnome-keyring
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704
2023-07-13 11:14:33 +02:00
Charles Kerr
dc671804da
perf: avoid redundant lookup in BluetoothChooser::AddOrUpdateDevice() ( #39059 )
...
perf: avoid redundant map lookup in BluetoothChooser::AddOrUpdateDevice()
2023-07-13 10:16:25 +02:00
Milan Burda
b14b876d50
docs: fix fiddles ( #39060 )
...
* refactor: replace Array.prototype.forEach.call with plain for-of
* fix: add missing contextIsolation: false
* fix: open links in default browser
2023-07-13 10:10:37 +02:00
Charles Kerr
a8622aed7b
perf: avoid redundant map lookup in NativeImage::GetHICON() ( #39058 )
...
perf: avoid double map lookup in NativeImage::GetHICON()
2023-07-13 15:37:43 +09:00
Shelley Vohr
da3475998f
fix: BrowserWindow.moveAbove() not working for child windows ( #39034 )
...
fix: BrowserWindow.moveAbove() not working for child windows
2023-07-12 17:42:24 +02:00
Alka Vats
9d1a16b2e6
docs: updated the markup tag i with the em ( #39041 )
2023-07-12 15:52:10 +02:00
Shelley Vohr
b142fce229
fix: protocol.handle not intercepting file protocol ( #39048 )
...
fix: protocol.handle not intercepting file protocol
2023-07-12 11:42:49 +02:00
Mikhail Leliakin
f959fb0c96
feat: browserWindow.getBrowserViews() to return sorted by z-index array ( #38943 )
2023-07-11 11:01:30 +02:00
Athul Iddya
905e41bbdd
fix: use StartUpdating method for PipeWire capturer ( #38833 )
...
* fix: use StartUpdating method for PipeWire capturer
Fixed a crash related to PipeWire capturer by adapting to Chromium's
interface changes. Chromium expects a call to
`NativeDesktopMediaList::StartUpdating` with an implementation of
`DesktopMediaListObserver` for delegated capturers like PipeWire. This
interface allows listening to user permission events and listing
sources only after the user has made a choice on the permission dialog.
The interface has been implemented by an inner class to allow listening
to screen and window capture permissions concurrently using two
instances of the class. A patch that was resetting the capturer on the
first refresh has been changed to exclude PipeWire. PipeWire capturer
object will follow the lifecycle of `NativeDesktopMediaList`, as is the
case in Chromium.
Fixes #37463
* fix: wait for thumbnails from PipeWire when necessary
The PipeWire stream starts after the dialog is dismissed. If the sources
are listed immediately afterwards, the thumbnail may not have been
generated by that time. Explicitly wait for both thumbnail generation
and a selection on the source dialog before listing sources.
2023-07-11 10:21:11 +02:00
Athul Iddya
3e3152008f
fix: remove types from GTK CSS selectors ( #39003 )
...
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.
Fixes #38786
Co-authored-by: Athul Iddya <athul@iddya.com >
2023-07-10 22:52:12 +02:00
Anton Gilgur
f3f3f53904
docs: add link to Travis CI headless page ( #38990 )
...
docs(headless): link to Travis CI docs
- Travis has a specific page in its docs all about headless, with several different methods of using `xvfb`
- c.f. https://docs.travis-ci.com/user/gui-and-headless-browsers/
2023-07-10 16:45:18 -04:00
Shelley Vohr
117a700724
fix: printing optional access crash on Windows ( #38976 )
2023-07-10 09:26:29 -04:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
Mikhail Leliakin
56b5c00312
feat: add BrowserWindow.showAllTabs() for macOS ( #38965 )
2023-07-10 10:43:37 +02:00
John Kleinschmidt
040e9a027a
build: disable unneeded depot_tools update on Windows CI ( #39011 )
...
build: disable unneeded depot_tools update
2023-07-06 16:13:20 -04:00
Shelley Vohr
a97028bacf
fix: Notification 'Show' button visible when no actions exist ( #38997 )
2023-07-06 15:50:08 -04:00
Shelley Vohr
cc7d724a3b
fix: menu border being created properly on Windows 11 ( #38998 )
...
* fix: menu border being created properly on Windows 11
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-07-06 15:46:12 +02:00
Shelley Vohr
c7a64ab994
fix: webview crash when removing in close event ( #38996 )
2023-07-06 10:20:34 +02:00
Shelley Vohr
5a77c75753
revert: compensate for title bar height when setting bounds on BrowserView ( #38981 )
...
This reverts commit 75f9573e53 .
2023-07-06 09:50:08 +02:00
Varun Sood
ec4c9024b9
docs: Improved the Documentation on BrowserWindow type attribute ( #38666 )
...
* docs: Documentation changes
* made the required changes in the docs
* made the toolbar type text correction
2023-07-05 16:26:39 -04:00
Cheng Zhao
3fa15ebb7e
fix: use Chromium's way to compute min/max sizes ( #38974 )
2023-07-05 11:02:05 -04:00
David Sanders
52fe76ca28
ci: automate release board creation ( #38629 )
...
* ci: refactor determining major branch
* ci: automate release board creation
2023-07-03 10:34:57 +02:00
Sergei Chestakov
e991c1868e
docs: fix misleading code sample for handling deeplinks on Linux ( #38862 )
...
Fix misleading docs for handling deeplinks in Linux
2023-07-03 10:30:45 +02:00
electron-roller[bot]
ccd4531bfb
chore: bump chromium to 117.0.5852.0 (main) ( #38891 )
...
* chore: bump chromium in DEPS to 117.0.5846.0
* chore: update patches
* 4628901: Bump the macOS deployment target to 10.15
https://chromium-review.googlesource.com/c/chromium/src/+/4628901
* 4593350: [Private Network Access] Trigger Permission Prompt
https://chromium-review.googlesource.com/c/chromium/src/+/4593350
* 4631011: Remove unlaunched "InstallReplacementAndroidApp" Platform App APIs
https://chromium-review.googlesource.com/c/chromium/src/+/4631011
* chore: disable API deprecation warnings in NSKeyedArchiver
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 117.0.5848.2
* chore: update feat_add_set_theme_source_to_allow_apps_to.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629743
No manual changes; patch succeeded with fuzz
* chore: update process_singleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4605398
Trivial manual patch adjustments to account for code shear.
* chore: remove electron::BrowserContext::GetMediaDeviceIDSalt()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4608130
upstream tldr:
- content::BrowserContext::GetMediaDeviceIDSalt()
- content::ContentBrowserClient::ArePersistentMediaDeviceIDsAllowed()
+ content::ContentBrowserClient::GetMediaDeviceIDSalt()
This commit leaves ElectronBrowserContext::GetMediaDeviceIDSalt() in
place (now non-virtual, non-override). It is now called by the new
function ElectronBrowserClient::GetMediaDeviceIDSalt().
As a followup, we might want to consider using the new upstream
media_device_salt::MediaDeviceSaltService and removing our
electron::MediaDeviceIDSalt code. CC @MarshallOfSound for 2nd
opinion since he has done the most work on MediaDeviceIDSalt and
may have more context.
* chore: fix iwyu breakage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629624
electron_browser_main_parts.cc uses ui::ColorProviderManager but didn't
include it. Things worked anyway because we got it indirectly from
content/public/browser/web_contents.h until 4629624.
* chore: remove call to base::mac::IsAtLeastOS10_14
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in IAP
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove obsolete API_AVAILABLE calls in electron_application_delegate
upstream has bumped minimum version to 10.15 so this call is moot?
* chore: remove broken-before-macOS-10.15 patch in mas_avoid_usage_of_private_macos_apis.patch
Upstream has bumped minimum to macOS 10.15
* chore: remove @available(macOS 10.14) check
Upstream minimum requirement for macOS is now 10.15
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5850.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5852.0
* chore: update patches
* Move two params from NetworkContextParams to NetworkContextFilePaths.
https://chromium-review.googlesource.com/c/chromium/src/+/4615930
* WebUSB: Add exclusionFilters to USBRequestDeviceOptions
https://chromium-review.googlesource.com/c/chromium/src/+/4614682
* Convert /chrome/browser/ui to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4615920
* fixup! Bump the macOS deployment target to 10.15
* fixup! Bump the macOS deployment target to 10.15
* chore: update libcxx files
* win: Remove 10Glass from Windows10Glass function and var names
https://chromium-review.googlesource.com/c/chromium/src/+/4641314
* chore: revert 392e5f43 from chromium
* Add an ExecutionContext to ScriptState
https://chromium-review.googlesource.com/c/chromium/src/+/4609446
* fixup! Add an ExecutionContext to ScriptState
* chore: fix header
* Revert "chore: revert 392e5f43 from chromium"
This reverts commit b7f782943e4ce83cae8cd35780d8d3618cf0772c.
* fix: return correct min/max sizes in WinFrameView
* fixup! Revert chore: revert 392e5f43 from chromium
* fixup! Add an ExecutionContext to ScriptState
* Revert "fixup! Revert chore: revert 392e5f43 from chromium"
This reverts commit 7e2c7281abfc4f309255339fdba073d90a9ae3eb.
* Revert "fix: return correct min/max sizes in WinFrameView"
This reverts commit 3f418b1ab5155686730e087ae6cabe4a21b4bb61.
* Revert "Revert "chore: revert 392e5f43 from chromium""
This reverts commit 56296d8b7c434147e032e3c3b08c0e371b6c27ba.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2023-07-01 16:22:55 -04:00
Samuel Attard
499d893040
feat: add support for keyboard initialized menu popup ( #38903 )
...
* feat: add support for keyboard initialized menu popup
* Update docs/api/menu.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* fix: add patch to chromium for keyboard accessibility menu behavior
* refactor: s/initiatedByKeyboard/sourceType
* fix: ignore initial mouse event to retain keyboard initiated focus
* Update docs/api/menu.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2023-06-29 15:54:06 -07:00
Milan Burda
607e71d563
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() ( #38929 )
2023-06-27 16:57:33 -04:00
Cheng Zhao
09669f9d21
fix: child window may have opener removed ( #38910 )
2023-06-26 17:04:54 -04:00
github-actions[bot]
ff6d0df2d5
build: update appveyor image to latest version e-116.0.5845.0 ( #38913 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-26 15:57:10 -04:00
Milan Burda
81a454d148
chore: re-enable node/no-deprecated-api linting ( #38899 )
...
* chore: re-enable node/no-deprecated-api linting
* chore: re-enable no-global-assign linting
2023-06-26 13:51:59 -04:00
Charles Kerr
acba6d79fb
docs: document e27 breaking change of dropping macOS 10.13, 10.14 ( #38917 )
...
docs: document e27 breaking change of dropping macOS 10.13, 10.14 support
2023-06-26 13:29:00 -04:00
electron-roller[bot]
327af3b03c
chore: bump node to v18.16.1 (main) ( #38869 )
...
* chore: bump node in DEPS to v18.16.1
* chore: update patches
* deps: update c-ares to 1.19.1
https://github.com/nodejs/node/pull/48115
* chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
* chore: disable x509 bssl test
new test added in bf3e2c892
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix related -Werror,-Wunused-function FTBFS
* fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares
also fix another related -Werror,-Wunused-function FTBFS
* fixup! chore: disable x509 bssl test
fix yet another -Werror,-Wunused-function FTBFS
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-26 12:03:30 -04:00
Milan Burda
ef6569b7d3
chore: cleanup unusued variables + enable linting ( #38898 )
2023-06-26 02:51:54 -07:00
dependabot[bot]
e900f6ecc3
build(deps-dev): bump semver from 5.7.0 to 7.5.2 ( #38916 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.0 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.0...v7.5.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-23 13:17:43 -07:00
Milan Burda
9226cc662b
refactor: use types for once() return values in spec ( #38872 )
2023-06-22 14:38:52 -04:00
Milan Burda
abec9ead06
refactor: use node scheme imports in scripts ( #38846 )
...
* refactor: use node scheme imports in script
* refactor: use node scheme imports in build
2023-06-22 16:21:42 +02:00
Charles Kerr
395b608dd5
refactor: more constexpr lookup tables ( #38886 )
...
* refactor: use constexpr lookup table in electron_api_web_contents.cc
* refactor: make KeyboardCodeFromStr() private
it is only used as a helper to KeyboardCodeFromStr()
* chore: savepoint
* chore: make lint happy
* fixup! refactor: make KeyboardCodeFromStr() private
* refactor: use constexpr lookup table in electron_url_loader_factory
* refactor: use constexpr lookup table in electron_api_tray
* refactor: use constexpr lookup table in web_contents_preferences.cc
* refactor: use constexpr lookup table in content_converter
2023-06-22 14:33:44 +02:00
electron-roller[bot]
1eb19f3078
chore: bump chromium to 116.0.5845.0 (main) ( #38827 )
...
* chore: bump chromium in DEPS to 116.0.5835.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5837.0
* chore: bump chromium in DEPS to 116.0.5839.0
* chore: bump chromium in DEPS to 116.0.5841.0
* chore: bump chromium in DEPS to 116.0.5843.0
* Update patches
CLs that affected printing.patch:
- 4616791: Refactor PrintViewManagerBase::PrintNow()
https://chromium-review.googlesource.com/c/chromium/src/+/4616791
- 4602776: Make PrintNodeUnderContextMenu operation go through PrintViewManager
https://chromium-review.googlesource.com/c/chromium/src/+/4602776
* 4506614: geolocation: Add LocationProvider::FillDiagnostics
https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* chore: bump chromium in DEPS to 116.0.5845.0
* chore: update patches
* fixup! 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614
* 4609704: Remove gnome-keyring
https://chromium-review.googlesource.com/c/chromium/src/+/4609704
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2023-06-22 10:51:15 +02:00
Shelley Vohr
a00a25376d
fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents ( #38842 )
...
fix: crash calling removeBrowserView() with destroyed webContents
https://github.com/electron/electron/issues/37642
2023-06-21 15:20:54 -04:00
Michaela Laurencin
ce6fe040fe
fix: set minimize visibility true with enable ( #38860 )
2023-06-21 14:58:33 -04:00
Shelley Vohr
e73edb5481
feat: allow headers to be sent with session.downloadURL() ( #38785 )
2023-06-21 15:31:28 +02:00
Milan Burda
74d73166d9
chore: remove deleted guest-window-proxy.ts from CODEOWNERS ( #38848 )
...
chore: remove deleted /lib/browser/guest-window-proxy.ts from CODEOWNERS
2023-06-20 17:19:33 -04:00
Milan Burda
6bd02bf181
refactor: use node scheme imports in default_app ( #38847 )
2023-06-20 17:17:03 -04:00
github-actions[bot]
a595044989
build: update appveyor image to latest version - e-116.0.5833.0. ( #38803 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-20 14:15:00 -04:00
Shelley Vohr
f6bbc34658
fix: set supported scale factors on startup ( #38836 )
2023-06-20 12:24:03 -04:00
Milan Burda
2b3902e526
refactor: use content::GlobalRenderFrameHostId ( #38843 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-20 15:32:31 +02:00
Milan Burda
93024be3b2
build: rename spec/.eslintrc -> spec/.eslintrc.json ( #38838 )
...
chore: rename spec/.eslintrc -> spec/.eslintrc.json
2023-06-19 14:19:11 +02:00
Shelley Vohr
b693f88491
fix: crash on nativeTheme change during context menu close ( #38824 )
2023-06-19 11:26:54 +02:00
Charles Kerr
97132ece33
refactor: use constexpr lookup tables in gin helper ( #38818 )
...
* feat: add gin_helper::FromV8WithLookup()
feat: add gin_helper::FromV8WithLowerLookup()
* refactor: use constexpr lookup table in gin Converters
2023-06-19 10:33:09 +02:00
Charles Kerr
41ab5f327f
refactor: remove unused InspectableWebContentsView::GetWebView() ( #38799 )
2023-06-16 00:44:19 -05:00
electron-roller[bot]
7219142a54
chore: bump chromium to 116.0.5833.0 (main) ( #38809 )
...
* chore: bump chromium in DEPS to 116.0.5833.0
* chore: update patches
* 4530656: Add DeviceLoginScreenWebHidAllowDevicesForUrls policy
https://chromium-review.googlesource.com/c/chromium/src/+/4530656
* Split CertDatabase notifications between trust changes and client cert changes
https://chromium-review.googlesource.com/c/chromium/src/+/4596317
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-15 16:37:01 -04:00
Shelley Vohr
46fb0d8f5f
fix: webContents.print({ silent: true }) not working correctly ( #38741 )
...
fix: webContents.print({ silent: true }) not working correctly
2023-06-15 10:46:38 -04:00
Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-15 10:42:27 -04:00
Charles Kerr
bf1ba4a857
refactor: constexpr lookup tables ( #38771 )
...
* refactor: use a constexpr lookup table in GetPathConstant()
* refactor: use a constexpr lookup table in SystemPreferences::GetColor()
* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
2023-06-14 17:00:46 -04:00
electron-roller[bot]
bb4e9b27b5
chore: bump chromium to 116.0.5831.0 (main) ( #38784 )
...
* chore: bump chromium in DEPS to 116.0.5831.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-14 16:59:54 -04:00
github-actions[bot]
30579859c4
build: update appveyor image to latest version - e-116.0.5829.0 ( #38779 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-14 15:35:25 -04:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
Shelley Vohr
f7c0a29d89
build: update to latest TypeScript ( #38763 )
2023-06-14 11:06:46 -07:00
Shelley Vohr
10852b3fd5
fix: preferCSSPageSize error type ( #38761 )
...
fix: preferCSSPageSize error type
2023-06-14 10:49:00 -04:00
Milan Burda
dc2e822dc7
fix: asar integration for require('node:child_process') ( #38742 )
2023-06-14 18:03:53 +09:00
Samuel Attard
46458ab517
build: update typescript-generator and docs-parser ( #38747 )
...
* build: update typescript-generator and docs-parser
* again...
* build: handle more specific pageSize types
2023-06-13 16:22:53 -07:00
Keeley Hammond
9aefe5db33
build: move chrome_lib_arc to chromium_src/BUILD.gn ( #38764 )
2023-06-13 16:23:11 -04:00
Charles Kerr
167c2b250e
refactor: use compile-time cli arg sets. ( #38748 )
...
We're currently building these on the heap with `std::set<std::string>`
but this can be a very small compile-time container instead.
Marking as 'refactor' rather than 'perf' since this isn't called often,
but moving from heap to compile-time is good and using this container
makes the code more readable.
2023-06-13 14:37:59 -05:00
Milan Burda
1621fcf5d3
docs: add missing isSameDocument property to will-frame-navigate event details ( #37940 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 15:15:20 -04:00
github-actions[bot]
18d484f39c
build: update appveyor image to latest version e-116.0.5815.0. ( #38739 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-06-13 14:56:43 -04:00
Milan Burda
e37111edcc
build: remove enable_osr build flag ( #38703 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-13 14:48:53 -04:00
electron-roller[bot]
80a3ba5c68
chore: bump chromium to 116.0.5829.0 (main) ( #38726 )
...
* chore: bump chromium in DEPS to 116.0.5823.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5825.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5827.0
* chore: update patches
* 4568811: Integrate Search Prefetch with Extensions.
https://chromium-review.googlesource.com/c/chromium/src/+/4568811
* 4567511: [DevTools] Add recordCountHistogram API.
https://chromium-review.googlesource.com/c/chromium/src/+/4567511
* 4507692: Delete base/guid.h
https://chromium-review.googlesource.com/c/chromium/src/+/4507692
* 4589551: Convert some of /base to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4589551
Also:
4601769: Convert immersive mode controllers to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4601769
* [viz] Convert MaybeSizeInBytes() to take in SharedImageFormat
https://chromium-review.googlesource.com/c/chromium/src/+/4594677
* 4564108: [BRP] Enable check_raw_ptr_fields for Mac
https://chromium-review.googlesource.com/c/chromium/src/+/4564108
* chore: bump chromium in DEPS to 116.0.5828.0
* chore: bump chromium in DEPS to 116.0.5829.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-13 14:45:48 -04:00
Shelley Vohr
678d1aa37d
docs: clarify supported accelerator punctuation ( #38740 )
...
doc: clarify supported accelerator punctuation
2023-06-13 12:42:55 +02:00
David Sanders
f5869b6fb9
chore: change remaining usages of process.mainModule ( #38705 )
2023-06-12 09:55:36 +02:00
Charles Kerr
ab49e98401
perf: prefer base::StringPiece over std::string for build-time strings ( #38717 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
2023-06-12 09:55:22 +02:00
Shelley Vohr
fa6d14c22d
fix: webContents.print() cancellation callback ( #38709 )
...
fix: webContents.print() cancellation callback
2023-06-12 09:42:18 +02:00
Milan Burda
5d123765d9
feat: support node: prefixed requires in sandboxed renderer preloads ( #38567 )
...
feat: support node: prefixed requires in sandboxed renderer preloads
2023-06-10 14:36:16 -04:00
electron-roller[bot]
fd5e6fbc14
chore: bump chromium to 116.0.5817.0 (main) ( #38465 )
...
* chore: bump chromium in DEPS to 116.0.5793.3
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5795.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5797.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5799.0
* 4522192: [serial] Allow Bluetooth ports to be requested by service class ID. | https://chromium-review.googlesource.com/c/chromium/src/+/4522192
* 4545385: Create base::apple::Owned[frameworktype], use it for gfx::NativeEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4545385
* chore: bump chromium in DEPS to 116.0.5801.0
* chore: update patches
* 4562796: Use base::apple::Owned[frameworktype] for ui::PlatformEvent | https://chromium-review.googlesource.com/c/chromium/src/+/4562796
* 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
* chore: bump chromium in DEPS to 116.0.5803.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5805.2
* chore: update patches
* 4547630: Move content/public/common/network_service_util.h to c/p/browser/ | https://chromium-review.googlesource.com/c/chromium/src/+/4547630
* 4510075: Adding extensions to network response experiment | https://chromium-review.googlesource.com/c/chromium/src/+/4510075
* 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: bump chromium in DEPS to 116.0.5807.0
* chore: update patches
* 4533536: [Privacy Hub] Geolocation manager used directly | https://chromium-review.googlesource.com/c/chromium/src/+/4533536
* chore: patch out ARC support from /chrome/browser
4571955: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4571955
* chore: bump chromium in DEPS to 116.0.5809.2
* chore: bump chromium in DEPS to 116.0.5811.0
* chore: update patches
* 4573627: Adopt base::NoDestructor for KeyedService factories | https://chromium-review.googlesource.com/c/chromium/src/+/4573627
* 4576878: Reland "Shared Storage: Add mojo method for observing response headers" | https://chromium-review.googlesource.com/c/chromium/src/+/4576878
* chore: bump chromium in DEPS to 116.0.5813.0
* chore: update patches
* fixup! 4566552: Auto-generate grd file for chrome://accessibility. | https://chromium-review.googlesource.com/c/chromium/src/+/4566552
* chore: fix up lint
* test: (debug) use Promise.all in asan tests
* chore: manually roll DEPS to 116.0.5815.0
* chore: update patches
* 4585150: Convert /printing to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4585150
* test: (asan) extend timeout, clean up debugging
* chore: remove ARC chromium patch
* chore: update patches after main sync
* 4546398: Convert /chrome/browser to use ARC | https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* build: add chrome_lib_arc for chromium_src/BUILD.gn sources
* fixup! 4559790: Manual raw_ptr rewrite: //base | https://chromium-review.googlesource.com/c/chromium/src/+/4559790
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-06-09 16:08:36 -07:00
Charles Kerr
a3448376a1
refactor: api web contents ownership ( #38695 )
...
* refactor: aggregate api::WebContents::exclusive_access_manager_ directly
* refactor: make WebContents::devtools_file_system_indexer_ scoped_refptr const
* refactor: make WebContents::file_task_runner_ scoped_refptr const
* refactor: make WebContents::print_task_runner_ scoped_refptr const
2023-06-09 15:28:11 -05:00
Shelley Vohr
c0d9764de9
fix: webContents.print parameter validation error ( #38614 )
2023-06-09 21:41:01 +02:00
Samuel Maddock
e8fd5fd3a8
fix: WCO transparent background ( #38693 )
...
* fix: WCO transparency
* doc: wco color transparency
* fix: transparent buttons when calling setTitleBarOverlay
2023-06-09 09:57:57 -07:00
Charles Kerr
d95ae19edf
refactor: add SessionPreferences::CreateForBrowserContext() ( #38656 )
...
Copy the NativeWindowRelay::CreateForWebContents() idiom
to simplify SessionPreferences's constructor and lifecycle.
2023-06-09 11:20:43 -05:00
Samuel Attard
12b85a77a8
build: upload node checksums before validating them ( #38710 )
2023-06-09 02:30:26 -07:00
Samuel Attard
38dc43f649
build: actually use m1.large for publish job ( #38706 )
2023-06-08 23:56:26 -07:00
Samuel Attard
43f5cf1eae
build: update sentry cli for m1 support ( #38704 )
2023-06-08 16:31:15 -07:00
David Sanders
2a81b2aea3
build: move uploadIndexJson to just before publishRelease ( #38659 )
...
* build: move uploadIndexJson to just before publishRelease
* chore: move uploadNodeShasums as well
2023-06-08 16:41:23 -04:00
Milan Burda
05d39d8313
build: remove enable_run_as_node build flag ( #38413 )
...
* feat: remove enable_run_as_node flag
* drop features.isRunAsNodeEnabled()
* use IsEnvSet() helper in electron_main_linux.cc
* cleanup [[maybe_unused]]
---------
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-08 16:40:08 -04:00
John Kleinschmidt
806f00285c
build: ensure correct dsymutil is downloaded for macOS ( #38692 )
2023-06-08 13:39:13 -07:00
Cheng Zhao
534bf77d9b
chore: modify patches so we can build other chromium targets ( #38637 )
...
chore: tune patches so we can build other chromium targets
2023-06-08 13:30:36 -04:00
Charles Kerr
9d8da7839e
fix: dangling pointer warning when updating menus ( #38643 )
2023-06-08 09:29:32 -05:00
Charles Kerr
95d6a932ca
build: use upstream's presubmit cpplint filters. ( #38638 )
2023-06-08 09:25:56 -05:00
David Sanders
4956bcc6bd
ci: remove release dependencies workflow ( #38646 )
2023-06-08 12:33:35 +02:00
wgsheng
c8bdd014c8
fix: menu bar visibility when exiting full screen ( #38599 )
2023-06-08 12:19:34 +02:00
Shelley Vohr
5ee890fb6f
fix: reparenting UAF crash on macOS ( #38603 )
2023-06-08 12:18:37 +02:00
Shelley Vohr
9a9d8ae5ea
refactor: add ARC scaffolding for macOS ( #38621 )
2023-06-08 10:26:33 +02:00
Milan Burda
0294debc31
build: remove enable_picture_in_picture build flag ( #38620 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-06-07 23:56:31 -07:00
Shelley Vohr
933544d449
chore: clean up ElectronPermissionManager ( #38636 )
...
chore: clean up ElectronPermissionManager
2023-06-07 23:55:36 -07:00
David Sanders
bbfba4fc24
build: fix semver/none label on appveyor update PR ( #38647 )
2023-06-07 23:52:05 -07:00
Dani Haro
be45614f6f
docs: indicate app.setBadgeCount() needs notifications permission to work ( #38648 )
...
docs: match docs for `app.badgeCount` and `app.setBadgeCount()`
2023-06-07 23:51:49 -07:00
Erick Zhao
1f08e46bca
docs: use local img for contents.adjustSelection api ( #38655 )
...
* docs: use local img for contents.adjustSelection api
* fixup
2023-06-07 23:49:19 -07:00
David Sanders
714402b08e
build: improve error output in release.js ( #38658 )
2023-06-07 16:49:12 -07:00
Samuel Attard
08ab45535d
build: use m1 hosts to build apple silicon binaries ( #38258 )
...
* build: try m1 speed test
* yolo?
* build: fix gn binary on m1
* build: remove arm64 snapshot logic
* build: strip x64 on arm64 hosts...
* if is fi
* build: no more GENERATE_CROSS_ARCH_SNAPSHOT
* build: chromedriver inline on arm64 darwin
* build: no copy chromedriver
* build: use m1 for publish
* medium?
2023-06-07 16:34:02 -07:00
Charles Kerr
69790f4b2a
refactor: remove unused OffScreenRenderWidgetHostView fields ( #38623 )
2023-06-07 16:28:35 -05:00
Shelley Vohr
c5972ba43c
fix: bad error passing webContents.print(null) ( #38612 )
...
fix: bad error passing webContents.print(null)
2023-06-07 19:18:26 +02:00
Shelley Vohr
86824c070e
fix: validate response in protocol.handle() ( #38587 )
...
fix: validate response in protocol.handle()
2023-06-07 09:29:04 +02:00
Charles Kerr
5931f69f18
fix: sync api::Screen wrapper method sigs to upstream ( #38597 )
...
refactor: sync api::Screen getter sigs to upstream
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(),
and GetDisplayNearestPoint() methods are all const, so make our wrappers
const too.
ui::Display GetAllDisplays() returns a const reference, so make our
wrapper return a const reference too. This avoids creating a new
std::vector<display::Display> each time it's called.
2023-06-07 09:28:50 +02:00
John Kleinschmidt
80246cf97f
docs: removed outdated Appveyor doc ( #38622 )
2023-06-06 15:38:07 -07:00
zeeker999
28332c94bf
feat: Allow customizing the default math font ( #38514 )
2023-06-06 17:26:32 -04:00
Charles Kerr
5c1321b20a
refactor: remove redundant resizing strategy equality check ( #38596 )
...
* refactor: remove redundant resizing strategy equality check
Upstream already checks this.
2023-06-06 14:03:39 -05:00
Shelley Vohr
7982c6cee2
build: remove V8 patch for ArrayBuffer DCHECK ( #38591 )
2023-06-06 10:21:58 +02:00
Shelley Vohr
b2059f288a
fix: account for BrowserView bounds in setting autofill popup bounds ( #38489 )
2023-06-06 10:21:42 +02:00
Milan Burda
bb2ba35b51
refactor: use process_util.h helpers ( #38574 )
...
refactor: use process_util.h helpers
2023-06-06 17:19:13 +09:00
Shelley Vohr
8d689c565a
fix: file selection when disallowed on macOS ( #38557 )
2023-06-05 14:08:10 +02:00
David Sanders
905aad9cb6
chore: type check JS in docs ( #38423 )
...
* build(deps): update @electron/lint-roller
* chore: type check JS in docs
* docs: add @ts-check and @ts-expect-error to code blocks
* chore: fix type check errors in docs
* chore: add ts-type to blocks
2023-06-05 16:26:26 +09:00
David Sanders
4c89061e0e
docs: fix SerialPort typing ( #38544 )
2023-06-05 15:58:30 +09:00
Milan Burda
8fdd7de3d2
docs: clarify which electron modules are exposed in sandboxed renderers ( #38568 )
2023-06-05 15:57:15 +09:00
Charles Kerr
83d023747c
refactor: use direct aggregation in NativeWindowViews ( #38559 )
...
* refactor: in NativeWindowViews, aggregate root_view_ directly
* refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly
* refactor: make NativeWindowClientView::window_ a raw_ref
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields
Prefer const raw_ref<T> whenever the held pointer will never be null
* chore: make lint happy
2023-06-05 14:37:46 +09:00
Charles Kerr
05db963f87
chore: remove unused electron::api::View code ( #38561 )
...
chore: remove unused electron::api::View methods
Remove code that was added in 2c8dc9e but never used.
2023-06-03 10:40:44 -05:00
Charles Kerr
f247ca3f62
perf: avoid unnecessary base value clone ( #38537 )
2023-06-02 08:38:29 -05:00
Shelley Vohr
d818f35ad4
build: fix doc-only early exit on Appveyor ( #38547 )
2023-06-01 10:40:35 -04:00
Sergey
9ffffdb6ef
docs: fix performance tutorial ( #38469 )
...
* docs: fixed "Analyze runtime performance" link
* docs: added missing list item
2023-05-31 15:56:06 -04:00
Charles Kerr
c14f7b7d0b
refactor: remove unused switches ( #38497 )
...
* refactor: remove unused declaration of electron::kSHA1Certificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MajorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSHA1MinorDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kCertificateError
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificate
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kValidCertificateDescription
usage removed in 13a1d79
* refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription
usage removed in 497f5a1
* refactor: remove electron::options::kPreloadScripts
removed in bad8d5e0
* refactor: remove electron::options::kImageAnimationPolicy
removed in 385d0f5
2023-05-31 15:55:21 -04:00
David Sanders
74b8133a93
ci: set description for release labels ( #38528 )
2023-05-31 15:49:16 -04:00
Shelley Vohr
57147d1b8d
fix: navigator.connection not working as intended ( #38491 )
...
* fix: navigator.connection not working as intended
* chore: make network quality methods private
2023-05-31 11:06:25 -04:00
Milan Burda
67f273a6d6
docs: add <webview> new-window event removal to breaking-changes.md ( #36985 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-31 10:47:08 -04:00
Shelley Vohr
b454f8c7c1
build: combine and elaborate on exposed BoringSSL ciphers ( #38506 )
...
build: combine and elaborate on exposed BoringSSL ciphers
2023-05-31 10:30:04 -04:00
Shelley Vohr
663497dc6b
chore: make contentTracing.stopRecording() failure clearer ( #38488 )
...
chore: make contentTracing.stopRecording() failure clearer
2023-05-31 09:54:41 -04:00
Shelley Vohr
115d37477e
build: shrink unnecessary test changes in patch revert ( #38505 )
...
build: shrink unneccesary test changes in patch revert
2023-05-31 09:52:13 -04:00
Matt Henkes
2c742cfadb
chore: cherry-pick 0e1cc35 from v8 ( #38490 )
2023-05-31 11:58:48 +02:00
Shelley Vohr
40e724e5dd
fix: DCHECK minimizing parent window with non-modal child ( #38460 )
2023-05-31 11:57:44 +02:00
github-actions[bot]
13f9e2db40
build: update appveyor image to latest version ( #38449 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-30 21:13:33 -04:00
Shelley Vohr
a769b48164
ci: clean up docs only change logic ( #38456 )
2023-05-30 12:38:41 -04:00
John Kleinschmidt
b4ec363b3d
feat: add USB protected classes handler ( #38263 )
...
* feat: add USB protected classes handler
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs
* chore: apply review suggestions
* update doc per suggestion
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-05-30 12:35:25 -04:00
Milan Burda
71fb19ea14
chore: upgrade to eslint v8 ( #38472 )
...
chore: upgrade to eslint@8
2023-05-30 13:10:22 +02:00
Milan Burda
a6f7c7690d
refactor: use literals instead of new RegExp() where possible ( #38458 )
2023-05-30 10:53:11 +02:00
Charles Kerr
0203bd3305
refactor: prefer base::Contains() over find() + end() ( #38443 )
...
* refactor: use base::Contains() in KeyWeakMap::Has()
* refactor: use base::Contains() in WebRequest::RequestFilter::MatchesType()
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in DeepFreeze()
* refactor: use base::Contains() in Clipboard::Read()
* Revert "refactor: use base::Contains() in BaseWindow::AddBrowserView()"
This reverts commit 60152359d3978451ebdd7c8eed602c2fb8a9cafa.
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in IsDevToolsFileSystemAdded()
* refactor: use base::Contains() in MessagePort::DisentanglePorts()
* refactor: use base::Contains() in PowerSaveBlocker::IsStarted()
* refactor: use base::Contains() in SpellCheckClient::OnSpellCheckDone()
* refactor: use base::Contains() in ShowTaskDialogWstr()
* refactor: use base::Contains() in PrintViewManagerElectron::ScriptedPrint()
* refactor: use base::Contains() in PrintViewManagerElectron::DidGetPrintedPagesCount()
* refactor: use base::Contains() in NativeWindow::AddDraggableRegionProvider()
* refactor: use base::Contains() in ElectronBindings::ActivateUVLoop()
* refactor: use base::Contains() in NativeWindowViews::IsVisibleOnAllWorkspaces()
* refactor: use base::Contains() in HidChooserController::OnDeviceAdded()
* refactor: use base::Contains() in ElectronSandboxedRendererClient::WillReleaseScriptContext()
* refactor: use base::Contains() in ElectronRendererClient::WillDestroyWorkerContextOnWorkerThread()
* refactor: use base::Contains() in GlobalShortcut::OnKeyPressed()
2023-05-30 10:28:43 +02:00
Shelley Vohr
9640ac441d
build: make ReactiveObjC/Mantle deps format consistent ( #38450 )
2023-05-29 10:44:21 +02:00
Shelley Vohr
b233d0805a
chore: process.mainModule -> require.main ( #38452 )
...
chore: process.mainModule -> require.main
2023-05-29 10:44:09 +02:00
Shelley Vohr
56138d879e
fix: Windows FrameView always appearing inactive ( #38468 )
2023-05-28 18:39:13 -04:00
electron-roller[bot]
ddcec84ace
chore: bump chromium to 116.0.5791.0 (main) ( #38448 )
...
* chore: bump chromium in DEPS to 116.0.5791.0
* 4504298: Relax checks in BlobDataBuilder::AppendBlob.
https://chromium-review.googlesource.com/c/chromium/src/+/4504298
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-25 16:10:08 +02:00
Milan Burda
185180a8e2
refactor: tweak bindings in typings/internal-ambient.d.ts for readability ( #38411 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-25 14:53:23 +02:00
Milan Burda
470b1d9e9d
refactor: split clipboard module implementation for browser / renderer ( #38429 )
2023-05-25 20:36:12 +09:00
Charles Kerr
a20896f519
refactor: remove InspectableWebContents::GetAll() ( #38442 )
...
It is unused and also keeps a persistent std::list<>, so remove it.
2023-05-25 17:23:19 +09:00
electron-roller[bot]
64045fd058
chore: bump chromium to 115.0.5790.0 (main) ( #38418 )
...
* chore: bump chromium in DEPS to 115.0.5789.0
* 4550346: Revert "Convert /chrome/browser to use ARC"
https://chromium-review.googlesource.com/c/chromium/src/+/4550346
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5790.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-25 09:54:26 +02:00
David Sanders
294f196907
build: upgrade @electron/github-app-auth to 2.0.0 ( #38435 )
2023-05-25 09:54:09 +02:00
Milan Burda
82af000a37
chore: cleanup eslint suppressions ( #38417 )
...
* chore: cleanup eslint suppressions
* address feedback
* revert script/lib/azput.js
* revert spec/fixtures/apps/remote-control/main.js
* address feedback
* revert typings/internal-ambient.d.ts
2023-05-25 10:09:17 +09:00
github-actions[bot]
1c075e5ea0
chore: update appveyor image to latest version ( #38426 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-24 17:03:14 -04:00
Shelley Vohr
ec85be3fb0
docs: ensure app.md examples are runnable ( #38416 )
...
docs: ensure app.md examples are runnable
2023-05-24 16:41:29 -04:00
Milan Burda
06cc9caeaa
build: remove enable_desktop_capturer flag ( #38412 )
...
feat: remove enable_desktop_capturer flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 15:32:31 -04:00
Milan Burda
13fae292a7
build: remove unused enable_color_chooser build flag ( #38419 )
...
chore: remove unused enable_color_chooser build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 21:24:42 +02:00
Alexey Kuzmin
c4c17d7534
build: fix build with "enable_pdf_viewer=false" ( #38421 )
...
* build: fix build with "enable_pdf_viewer=false"
* fixup! build: fix build with "enable_pdf_viewer=false"
2023-05-24 14:37:07 -04:00
Milan Burda
a043a60b89
refactor: cleanup global variable declarations ( #38410 )
...
refactor: eliminate duplicate isolatedApi typing
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:01:07 +02:00
Milan Burda
2f8e68f8b3
chore: remove ViewsDelegate::IsWindowInMetro() override ( #38409 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:00:52 +02:00
Shelley Vohr
16cd486356
fix: MediaDevices missing DisplayMediaInformation ( #38390 )
...
fix: MediaDevices missing DisplayMediaInformation
2023-05-24 11:17:08 -04:00
David Sanders
f07b040cb9
build: update yarn.lock ( #38422 )
2023-05-24 10:19:47 +02:00
Milan Burda
b6ef4a3929
build: remove unused enable_tts build flag ( #38420 )
...
chore: remove unused enable_tts build flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 10:18:43 +02:00
Cheng Zhao
dec9a1d9db
chore: remove dead draggable region code ( #38404 )
2023-05-24 10:03:07 +02:00
Charles Kerr
b6c80ba646
fix: dangling_raw_ptr warning in electron_api_web_contents ( #38403 )
...
fix: dangling_raw_ptr warning in electron_api_web_contents
2023-05-23 21:52:07 -04:00
Charles Kerr
30e992dec4
chore: bump chromium to 115.0.5786.0 (main) ( #38301 )
...
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609a ),
but upstream has removed this API.
CC @codebytere
* fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch
* chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
https://chromium-review.googlesource.com/c/chromium/src/+/4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
https://chromium-review.googlesource.com/c/chromium/src/+/4521894
* 4525355: Move backup_util and bundle_locations to base/apple
https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
https://chromium-review.googlesource.com/c/chromium/src/+/4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
https://chromium-review.googlesource.com/c/chromium/src/+/4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
https://chromium-review.googlesource.com/c/v8/v8/+/4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-23 21:58:58 +02:00
Kilian Valkhof
e7b8bb4766
docs: disablewebsecurity on webview-tag can not be changed for an active session ( #38373 )
...
disablewebsecurity on webview-tag can not be changed for an active session
2023-05-22 16:29:41 +02:00
Shelley Vohr
aebcd3a8c4
build: try removing V8 symbol export patch for Windows ( #38391 )
2023-05-22 15:10:29 +02:00
Bruno Pitrus
395abf5620
fix: linker error missing uv__strtok ( #38382 )
...
fix: linker error missing uv__strtok
This symbol is referenced inside what seems to be dead code
in `uv__search_path` in third_party/electron_node/deps/uv/src/unix/core.c
When compiling in LTO mode, the reference is removed,
but not during a non-LTO build.
2023-05-22 13:00:45 +02:00
Keeley Hammond
508d7c1353
docs: update timelines for E26 ( #38378 )
...
docs: update E26 timeline, add E22 support note
2023-05-19 12:05:45 -07:00
Shelley Vohr
826c29abcc
build: use @octokit/request v6.2.4 ( #38346 )
2023-05-18 15:37:58 -07:00
Milan Burda
2acb97aa85
chore: eliminate a few uses of base::AdaptCallbackForRepeating() ( #38293 )
2023-05-18 17:01:44 -04:00
Shelley Vohr
642950a00e
build: try removing V8 DCHECK patch ( #38341 )
2023-05-18 20:53:15 +02:00
Shelley Vohr
b35ec4a23c
build: modify gclient.py with unified patch ( #38351 )
...
* build: modify gclient.py with unified patch
* ci: ensure depot_tools does not update
* ci: move auto-update disable outside if
2023-05-17 14:54:26 -04:00
David Sanders
e138f5f915
docs: fix typing of message box type value ( #38336 )
...
* docs: fix typing of dialog type value
* test: add smoke tests
* test: update test
2023-05-17 10:33:30 -07:00
David Sanders
a22635bd9f
docs: update example to use app.whenReady() ( #38337 )
...
* docs: update example to use app.whenReady()
* docs: retain async
2023-05-17 10:32:59 -07:00
Shelley Vohr
683235daf0
build: combine V8 BUILD.gn patches ( #38342 )
...
* build: combine V8 BUILD.gn patches
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-17 13:17:52 +02:00
Shelley Vohr
32d8f84cad
fix: getNormalBounds() for transparent windows on Windows ( #38218 )
2023-05-17 13:11:43 +02:00
Shelley Vohr
ad07712561
fix: win.isMaximized() for transparent windows on Windows ( #38234 )
2023-05-17 10:17:08 +02:00
Shelley Vohr
9902e01d2c
build: remove CppHeapCreateParams patch ( #38321 )
...
build: remove CppHeapCreateParams patch
2023-05-17 09:52:29 +02:00
Shelley Vohr
e08c583dea
build: remove V8 ARM undefined symbol patch ( #38316 )
2023-05-17 09:52:10 +02:00
Samuel Attard
2a16c73834
chore: cherry-pick e6e23ba00379 from chromium ( #38323 )
...
* chore: cherry-pick e6e23ba00379 from chromium
* make it work
2023-05-16 15:21:22 -07:00
David Sanders
c7ca29e80f
chore: add smoke test for devtools-open-url ( #38302 )
2023-05-16 16:42:24 -04:00
Calvin
fa81f77f40
test: re-enable tests that aren't broken & remove old test ( #38251 )
2023-05-16 14:30:25 +02:00
Shelley Vohr
c05051e307
chore: remove obsoleted DecrementCapturerCount patch ( #38294 )
...
chore: remove obsoleted DecrementCapturerCount patch
2023-05-16 14:29:01 +02:00
Shelley Vohr
8b63a3fc8a
build: bump brew cache to v6 ( #38312 )
2023-05-16 12:38:30 +02:00
Shelley Vohr
e83197669c
fix: unify BrowserWindow.isVisible() logic cross-platform ( #38242 )
2023-05-16 11:46:45 +02:00
Shelley Vohr
9bd9d312f8
fix: enable BrowserWindow.id access post-destruction ( #38241 )
...
fix: enable BrowserWindow id access post-destruction
2023-05-16 09:29:00 +02:00
Shelley Vohr
042663e190
fix: isMaximized after minimize/fullscreen on macOS ( #38291 )
...
fix: isMaximized after isMinimized on macOS
2023-05-16 09:26:41 +02:00
Shelley Vohr
e19500fa03
feat: support Mica/Acrylic on Windows ( #38163 )
...
* feat: support Mica/Acrylic on Windows
* chore: feedback from review
2023-05-15 16:31:57 -04:00
Shelley Vohr
c2d7164021
chore: remove unnecessary spellchecker revert patch ( #38248 )
2023-05-15 16:17:00 -04:00
Shelley Vohr
a1b2dae68e
build: add labels to appveyor update PR ( #38292 )
2023-05-15 16:52:25 +02:00
David Sanders
c591ecf518
test: prewarm Node headers cache if specifying Electron version ( #38287 )
2023-05-15 02:10:22 -07:00
Samuel Attard
d1c5e623fa
build: drop python2 from CI ( #38259 )
...
* build: drop python2 from CI
* python3
* python3 uses linux not linux2
2023-05-15 02:06:12 -07:00
github-actions[bot]
9ac4787325
build: update appveyor image to latest version ( #38257 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-05-15 10:53:38 +02:00
Cesar Kohl
6645f49a9d
chore: variable name should comply with naming convention ( #38249 )
2023-05-15 10:30:22 +02:00
Shelley Vohr
e7fc1a422d
feat: add missing 'cursor-changed' type values ( #38210 )
2023-05-15 10:27:09 +02:00
David Sanders
eeb1e7d499
chore: fix lint:js-in-markdown script ( #38260 )
2023-05-15 09:58:35 +02:00
Milan Burda
0149ae72e6
refactor: use standard naming for enum class values ( #38232 )
2023-05-12 15:24:01 +02:00
Milan Burda
88a9962e22
refactor: convert HashAlgorithm to enum class ( #38233 )
2023-05-12 15:23:42 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Keeley Hammond
141175c723
build: disable v8 builtins pgo ( #38252 )
2023-05-10 20:53:18 -07:00
Keeley Hammond
95cd84f140
build: fix octokit resolution with patch-package ( #38250 )
2023-05-10 20:52:59 -07:00
electron-roller[bot]
894e056e6b
chore: bump chromium to 115.0.5760.0 (main) ( #38033 )
...
* chore: bump chromium in DEPS to 114.0.5721.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5723.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5725.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5727.0
* chore: bump chromium in DEPS to 114.0.5729.0
* chore: bump chromium in DEPS to 114.0.5731.0
* chore: update patches
* 4450570: Clean up content shell
https://chromium-review.googlesource.com/c/chromium/src/+/4450570
* 4262527: geolocation: Introduce mojom::GeopositionResult
https://chromium-review.googlesource.com/c/chromium/src/+/4262527
* 4450327 : Android/Nav: Stop taking content timeout timer from old host.
https://chromium-review.googlesource.com/c/chromium/src/+/4450327
Also, see:
4451366: Reland "Prerender: Fix prerender new content timeout start timing"
https://chromium-review.googlesource.com/c/chromium/src/+/4451366
* chore: bump chromium in DEPS to 114.0.5733.2
* chore: update patches
* chore: bump CircleCI xcode version
this will hopefully get us the necessary macOS sdk 13.3 on CI.
* chore: bump chromium in DEPS to 114.0.5735.0
* chore: update patches
* test: fix geolocation test
* chore: bump chromium in DEPS to 115.0.5736.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5738.0
* chore: update patches
* fix: remove profiles from spellcheck service
* chore: update libc++ filenames
* chore: bump chromium in DEPS to 115.0.5740.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5742.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5744.0
* chore: update patches
* chore: bump chromium in DEPS to 115.0.5746.0
* chore: update patches
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 115.0.5748.0
* chore: update patches
* build: update libcxx filenames
* chore: bump chromium in DEPS to 115.0.5750.0
* chore: bump chromium in DEPS to 115.0.5752.2
* chore: bump chromium in DEPS to 115.0.5754.0
* chore: bump chromium in DEPS to 115.0.5756.0
* chore: bump chromium in DEPS to 115.0.5758.0
* chore: update patches
* chore: update patch after rebase
* 4500969: Delete content/dev_ui_content_resources.grd file.
https://chromium-review.googlesource.com/c/chromium/src/+/4500969
* Use base.Value.Dict in OmahaAttributesHandler related code
https://chromium-review.googlesource.com/c/chromium/src/+/4506402
* chore: bump chromium in DEPS to 115.0.5760.0
* chore: update patches
* chore: fixup line endings
* 4336172: Include client-drawn window decorations in aspect ratio. |
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4336172
(cherry picked from commit 27c2f6c43e )
* spec: fix race condition in alwaysOnTop test
(cherry picked from commit 2ec5213fa0 )
* build: use xcode 14.2 not 14.3
(cherry picked from commit b7c62351a7 )
* build: use macOS 12 to run tests
The new macOS 13 VMs appear to have different screen / display behavior
(cherry picked from commit 14dc1dbc24 )
* Remove always-true flag --harmony-sharedarraybuffer
https://chromium-review.googlesource.com/c/v8/v8/+/4429630
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2023-05-10 10:47:48 -04:00
Shelley Vohr
2806feede2
docs: fix devtools-open-url ts definition ( #38231 )
...
docs: fix devtools-open-url ts definition
2023-05-10 11:25:50 +02:00
Shelley Vohr
13e309e1fb
fix: only exit fullscreen conditionally with setKiosk ( #38219 )
...
fix: only exit fullscreen conditionally with setKiosk
2023-05-09 12:28:37 -04:00
Shelley Vohr
f432245456
fix: handle AXManualAccessibility attribute cross-protocol ( #38142 )
...
* fix: handle AXManualAccessibility attribute cross-protocol
* Update shell/browser/mac/electron_application.mm
Co-authored-by: Robo <hop2deep@gmail.com >
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2023-05-09 11:13:14 +02:00
Shelley Vohr
0212c264ca
build: fix CRLF endings in messages.json ( #38212 )
2023-05-08 14:51:24 -04:00
David Sanders
9ccf2275d2
chore: migrate to @electron/lint-roller for Markdown linting ( #38191 )
2023-05-08 12:50:42 +02:00
David Sanders
911900eae9
build: add pretest script to create TS definitions ( #38201 )
2023-05-08 11:30:06 +02:00
David Sanders
7a03509b71
ci: automate release label tasks ( #38181 )
2023-05-08 10:39:28 +02:00
Shelley Vohr
a6c9aefb4a
chore: fix TrustedTypes policy in chrome://accessibility ( #38179 )
...
chore: fix TrustedTypes policy in chrome://accessibility
2023-05-08 10:39:04 +02:00
Calvin
13be6dc8b4
test: enable CircleCI's "re-run failed tests only" feature ( #38178 )
...
* test: enable CircleCI rerun failed *tests* only
* .
* .
* console.log never fails 🤷
* normalize the filtered paths
circleci gives us a list of absolute paths here
* remove test output check
sometimes rerunning only failed tests results in some runners having
no tests to run, and thus no output
* keep relative paths the same
* error for when no tests match
* cleanup
* .
2023-05-08 17:14:59 +09:00
David Sanders
3a7cfe300a
ci: do conditional in blocked/need-repro workflows at job level ( #38186 )
2023-05-08 17:07:04 +09:00
Adam Stone-Lord
88710612a3
docs: update dead link to Apple Human Interface notification guidelines ( #38187 )
2023-05-08 17:05:50 +09:00
Calvin
58d49927a3
test: disable flaky asar worker test on ASan build ( #38193 )
2023-05-08 17:03:30 +09:00
Shelley Vohr
534e90c2a6
build: force LF checkout of more files ( #38194 )
2023-05-08 17:02:42 +09:00
Shelley Vohr
35a03a6bc1
refactor: remove IPC from mouse_util ( #38183 )
2023-05-08 09:50:30 +02:00
David Sanders
a7adbae543
docs: fix typing of session.setDevicePermissionHandler ( #38188 )
2023-05-08 09:46:35 +02:00
Shelley Vohr
f8d534f33e
chore: stop using a RenderWidgetHost observer in FileSelectHelper ( #38168 )
...
chore: stop using a RenderWidgetHost observer in FileSelectHelper
2023-05-04 21:43:29 +02:00
David Sanders
ec75172d68
ci: update CircleCI CLI install URL ( #38176 )
2023-05-04 10:40:01 -04:00
Shelley Vohr
bb490161fb
fix: printing crash when settings invalid ( #38165 )
2023-05-04 09:10:54 -04:00
Alexey Kuzmin
bc957e3945
test: use await to call "closeWindow" ( #38166 )
...
* test: wait for an async "closeWindow" call
* fixup! test: wait for an async "closeWindow" call
2023-05-04 07:14:46 +09:00
Shelley Vohr
ee1e6aab3e
chore: implement WebContentsDelegate::GetFullscreenState ( #38141 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4255184
2023-05-03 15:55:47 +02:00
Russell Carpenella
7f5364f98d
docs: moves icpMain.handle call in tutorial part 3 ( #38138 )
2023-05-03 14:52:02 +02:00
Shelley Vohr
a8c0ed890f
feat: surface more webContents text selection commands ( #37978 )
...
* feat: surface more text selection commands
* refactor: use options argument
* docs: correct for review
2023-05-02 21:14:29 -04:00
David Sanders
a26343f3e0
fix: falsy transparent shouldn't affect webContents background ( #36914 )
2023-05-02 14:44:34 -07:00
Shelley Vohr
d95f9d2c63
chore: add OCR scaffolding to PDF Viewer ( #38127 )
2023-05-02 10:27:32 +02:00
Fedor Indutny
c548f8f59e
feat: net.resolveHost ( #37853 )
2023-05-02 09:53:00 +02:00
Milan Burda
7c482518bf
chore: add missing content::WebContentsDelegate section ( #38133 )
2023-05-01 09:23:47 -04:00
Shelley Vohr
a2d35e9cf5
test: re-enable extensions test with http server ( #38129 )
2023-04-28 01:20:46 +02:00
Shelley Vohr
ba8887f586
feat: emit context-menu event from extensions ( #38029 )
...
feat: emit context-menu event from extensions
2023-04-27 12:54:51 +02:00
Shelley Vohr
f35b9b3f06
fix: AXManualAccessibility showing failure ( #38102 )
...
fix: AXManualAccessibility showing failure
2023-04-26 19:41:56 +02:00
Bruno Pitrus
a0a44f07dd
chore: correct extra qualification causing build error with GCC ( #37548 )
...
* chore: correct extra qualification causing build error with GCC
* fixup for lint
* chore: fix lint
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-26 10:40:02 -04:00
David Sanders
08593fd2bd
chore: fix clang-tidy warnings ( #38079 )
...
* chore: fix clang-tidy warnings
* refactor: avoid need for NOLINTNEXTLINE
2023-04-26 10:09:54 -04:00
Shelley Vohr
fe5cdd39d6
test: re-enable passing Node.js tests ( #38116 )
2023-04-26 12:08:50 +02:00
Shelley Vohr
05faabe9e8
test: re-enable multi-window fullscreen test ( #38119 )
2023-04-26 10:13:36 +02:00
Shelley Vohr
9d525f9861
test: formally mark some Node.js tests as flaky ( #38117 )
2023-04-26 10:11:14 +02:00
Milan Burda
e823869bb0
docs: add separate linkable browser-window-options.md and web-preferences.md ( #34633 )
2023-04-25 15:16:11 +02:00
Shelley Vohr
f4b7e59b2d
fix: crash on missing RenderWidgetHostView ( #38100 )
...
chore: fix crash on missing RenderWidgetHostView
2023-04-25 11:30:16 +02:00
Francis Chartrand
a0a1a3645b
docs: fix start highlight tutorial-2-first-app.md ( #38069 )
...
doc: fix start highlight tutorial-2-first-app.md
2023-04-25 11:19:14 +02:00
David Sanders
9b41ab1e53
chore: always lint JS in docs/fiddles ( #38025 )
2023-04-24 10:35:14 -04:00
Black-Hole️
141f65b291
fix: webContents return type incorrect ( #38026 )
...
* fix: webContents type incorrect
* fix: ci failed
* fix: ci failed 2
2023-04-24 10:28:21 -04:00
Quang Lam
b626be5e33
docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings ( #38035 )
...
* Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings
* Add webContents
2023-04-23 22:16:38 +02:00
Milan Burda
964934c161
fix: defaults broken in shell.openExternal() options ( #38038 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-04-21 13:13:59 -04:00
github-actions[bot]
f727da4a74
ci: update appveyor image to latest version ( #38015 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-21 10:37:02 -04:00
Jason Etcovitch
cf4c46c8e0
build: fix Codespaces prebuilds with missing comma ( #38052 )
...
Add missing comma
2023-04-20 15:41:54 -07:00
Robo
0240f6664e
fix: crash in utilityProcess when generating code from strings ( #38014 )
2023-04-20 09:27:02 +09:00
Shelley Vohr
f12e12b341
chore: remove --no-harmony-atomics related code ( #38030 )
...
chore: remove --no-harmony-atomics related code
2023-04-19 10:29:18 -04:00
Shelley Vohr
7e715b66ae
test: re-enable reporting specs ( #35936 )
2023-04-19 14:24:38 +02:00
Jeremy Rose
ba835ddac1
feat: add thermal states to powerMonitor ( #37935 )
...
* feat: add thermal states to powerMonitor
* update docs
2023-04-19 11:46:55 +02:00
electron-roller[bot]
b2411e05a8
chore: bump chromium to 114.0.5719.0 (main) ( #38017 )
...
* chore: bump chromium in DEPS to 114.0.5719.0
* chore: update patches
* revert eb07a797cc
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-18 14:23:22 -07:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) ( #37973 )
...
* chore: bump node in DEPS to v18.16.0
* build,test: add proper support for IBM i
https://github.com/nodejs/node/pull/46739
* lib: enforce use of trailing commas
https://github.com/nodejs/node/pull/46881
* src: add initial support for single executable applications
https://github.com/nodejs/node/pull/45038
* lib: do not crash using workers with disabled shared array buffers
https://github.com/nodejs/node/pull/41023
* src: remove shadowed variable in OptionsParser::Parse
https://github.com/nodejs/node/pull/46672
* src: allow embedder control of code generation policy
https://github.com/nodejs/node/pull/46368
* src: allow optional Isolate termination in node::Stop()
https://github.com/nodejs/node/pull/46583
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* chore: fixup patch indices
* chore: sync filenames.json
* fix: add simdutf dep to src/inspector BUILD.gn
- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472
* deps: replace url parser with Ada
https://github.com/nodejs/node/pull/46410
* tls: support automatic DHE
https://github.com/nodejs/node/pull/46978
* fixup! src: add initial support for single executable applications
* http: unify header treatment
https://github.com/nodejs/node/pull/46528
* fix: libc++ buffer overflow in string_view ctor
https://github.com/nodejs/node/pull/46410
* test: include strace openat test
https://github.com/nodejs/node/pull/46150
* fixup! fixup! src: add initial support for single executable applications
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-04-18 22:23:11 +02:00
Samuel Attard
941153be32
build: bump dependencies to clean yarn audit ( #37998 )
...
* build: bump dependencies to clean yarn audit
* build: add url
2023-04-18 16:54:16 +02:00
Shelley Vohr
32afdda9ee
feat: add did-resign-active event on app ( #37933 )
...
feat: add did-resign-active event on app
2023-04-18 16:53:39 +02:00
github-actions[bot]
f4b172b9ec
ci: update appveyor image to latest version ( #37817 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-17 20:04:12 -04:00
electron-roller[bot]
7a6af1a529
chore: bump chromium to 114.0.5715.0 (main) ( #37976 )
...
* chore: bump chromium in DEPS to 114.0.5712.0
* chore: update patches
* 4401084: Remove extensions::InfoMap which is no longer needed. | https://chromium-review.googlesource.com/c/chromium/src/+/4401084
* 4415646: Add more details to print settings error log | https://chromium-review.googlesource.com/c/chromium/src/+/4415646
* chore: bump chromium in DEPS to 114.0.5714.0
* chore: update patches
* chore: update libcxx filenames
* chore: bump chromium in DEPS to 114.0.5715.0
* chore: update patches
* fix extensions test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-04-17 14:40:26 -07:00
Alexey Kuzmin
1ffe7ee76b
build: fix building with no PDF support ( #38003 )
2023-04-17 11:02:43 -04:00
Shelley Vohr
c857c9b7e2
docs: add note to win.setFullScreen(flag) ( #37921 )
...
docs: add note to win.setFullScreen(flag)
2023-04-17 10:45:40 +02:00
Shelley Vohr
f0e1848a5e
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator& ( #37948 )
...
chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator&
2023-04-16 17:08:37 -07:00
David Sanders
d1cddf2517
docs: update github.com links ( #37958 )
2023-04-15 21:20:59 -07:00
David Sanders
c7ea887227
chore: drop patch for fixed Linux menus issue in Views ( #37984 )
2023-04-15 21:20:34 -07:00
Shelley Vohr
fa3379a5d5
chore: fix lint ( #37971 )
2023-04-13 15:54:41 +02:00
Calvin
cdace75389
chore: disable flaky node test ( #37900 )
2023-04-13 13:27:45 +02:00
David Sanders
e84bcb39e7
fix: defaultFontFamily in webPreferences ( #37863 )
...
* fix: defaultFontFamily in webPreferences
* chore: check if default_font_family_ is empty
2023-04-13 11:30:25 +02:00
Shelley Vohr
fceeb64e7c
fix: swipe event emission on macOS ( #37946 )
2023-04-13 11:28:22 +02:00
Zenkie Bear
f03315ad4d
docs: Fix the syntax error for code fragment ( #37939 )
...
By using `app.on('ready').then(xxx)`, application will throw a TypeError
2023-04-13 10:00:27 +02:00
Michaela Laurencin
6f2ab392ab
docs: update 22-x-y EOL dates ( #37955 )
...
To account for https://www.electronjs.org/blog/electron-22-0#windows-7881-support-update
Not sure if it is worth adding as a historical change though
2023-04-12 18:10:47 -07:00
electron-roller[bot]
33a625d0ee
chore: bump chromium to 114.0.5710.0 (main) ( #37950 )
...
* chore: bump chromium in DEPS to 114.0.5710.0
* chore: update patches
* 4411421: [json-schema-compiler] Support separating numbers in enum entries |
https://chromium-review.googlesource.com/c/chromium/src/+/4411421
* 4400251: Remove MayBlock and TaskShutdownBehavior from BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4400251
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2023-04-12 18:10:31 -07:00
David Sanders
2ad1324b9d
ci: only remove blocked/need-repro on comment ( #37879 )
2023-04-12 16:33:59 -07:00
Jeremy Rose
fef1b04238
feat: remove on(ready) requirement from powerMonitor ( #37937 )
2023-04-12 15:37:52 -07:00
electron-roller[bot]
908bef7ca9
chore: bump chromium to 114.0.5708.0 (main) ( #37834 )
...
* chore: bump chromium in DEPS to 114.0.5696.0
* chore: update patches
* chore: revert clang revert
(cherry picked from commit 4c3ffa8001b5fdbfc99374bf77895d8d8e35ee31)
* test: remove unneeded test for title on ses.setCertificateVerifyProc
This test is unnecessary because all that really needs to be verified is that the request was rejected.
* chore: Revert "Reland "[BRP] Enable clang plugin check for Linux""
* chore: bump chromium in DEPS to 114.0.5697.0
* chore: bump chromium in DEPS to 114.0.5698.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5700.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5702.0
* chore: bump chromium in DEPS to 114.0.5704.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5705.0
* 4368281: Add bottom-up CertVerifier change observer flow. |
https://chromium-review.googlesource.com/c/chromium/src/+/4368281
* 4402277: Enable check_raw_ptr_fields for Linux |
https://chromium-review.googlesource.com/c/chromium/src/+/4402277
* 4389621: [ChromeAppsDeprecation] Remove deprecated chrome apps from AppService |
https://chromium-review.googlesource.com/c/chromium/src/+/4389621
* 4402191: Allow default initializing BrowserTaskTraits |
https://chromium-review.googlesource.com/c/chromium/src/+/4402191
* chore: bump chromium in DEPS to 114.0.5708.0
* chore: remove incorrectly re-added clang patch
* chore: update patches (clean sync)
* ci: use newer clang for 32-bit Linux ARM
Fixes crash on compiling skia/skia/SkPatchUtils.cpp
* build: generate new libcxx filenames
* 4409898: Update paper printable area in UpdatePrintSettings |
https://chromium-review.googlesource.com/c/chromium/src/+/4409898
* chore: update sysroots.json
Sysroot CL: https://chromium-review.googlesource.com/c/chromium/src/+/4383374
Chromium CL: 4246577: media/gpu: Add CQP AV1 VA-API video encoder | https://chromium-review.googlesource.com/c/chromium/src/+/4246577
* 4336198: [task] Move source location and use it in v8 platform | https://chromium-review.googlesource.com/c/v8/v8/+/4336198
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-04-12 07:37:48 -04:00
Darshan Sen
c326b0068e
fix: recommended node-gyp version in node.h error ( #37829 )
...
fix: recommended node-gyp version in node.h error
In
https://github.com/electron/electron/blob/main/docs/tutorial/using-native-node-modules.md#using-npm ,
we recommend setting the `npm_config_disturl` variable but doing that
does not work on node-gyp v8.4.0 because after
https://github.com/nodejs/node-gyp/pull/2497
landed, the dist URL was read only from `gyp.opts['dist-url']`. The fix
for reading the value from `npm_config_disturl` by parsing
`gyp.opts.disturl` was landed in
https://github.com/nodejs/node-gyp/pull/2547 and that change was
released in node-gyp v9.0.0, so this change updates the error macro to
recommend node-gyp v9.0.0 as the minimum required version.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2023-04-11 13:26:26 +02:00
Samuel Attard
c01dff8d89
fix: exceptions during function/promise result conversions live in calling world ( #37904 )
2023-04-11 11:57:48 +02:00
Shelley Vohr
c65632d404
fix: broken buttons in PDF viewer ( #37856 )
2023-04-11 15:30:36 +09:00
David Sanders
adb1172066
chore: use nested namespaces ( #37855 )
2023-04-11 15:30:25 +09:00
David Sanders
e929b2140d
chore: change some for loops to range-based ( #37857 )
2023-04-11 15:27:07 +09:00
David Sanders
82442239bc
chore: use emplace when possible ( #37877 )
2023-04-11 15:21:03 +09:00
David Sanders
3c0c4d5c27
fix: menus on Linux after window modification ( #37798 )
...
* fix: menus on Linux after window modification
* test: don't run on CI
2023-04-11 15:17:45 +09:00
Samuel Attard
6958668448
fix: exceptions in nested conversions live in the target world ( #37895 )
2023-04-10 14:58:27 -07:00
Keeley Hammond
1e206deec3
docs: update E24/E25 breaking changes ( #37878 )
2023-04-06 21:23:29 -07:00
Mikael Finstad
e8c87859c4
fix: showAboutPanel also on linux ( #37828 )
...
showAboutPanel also on linux
2023-04-06 14:50:24 -04:00
Keeley Hammond
83e186fdbc
docs: update 21-x-y EOL dates ( #37841 )
...
* docs: update 21-x-y EOL dates
* doc: update node versions
2023-04-06 14:04:15 -04:00
David Sanders
9563b5f98b
test: support 'latest'/'latest@X' Electron version strings ( #37840 )
2023-04-06 14:03:14 -04:00
Shelley Vohr
251e567eff
fix: don't emit did-fail-load for MediaDocuments ( #37824 )
...
* fix: don't emit did-fail-load for MediaDocuments
* spec: add test
2023-04-06 10:23:34 +02:00
Fedor Indutny
6bfef67aae
feat: session.resolveHost ( #37690 )
...
* feat: session.resolveHost
Expose Chromium's host resolution API through the Session object.
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* address feedback
* fix tests
* address feedback
* Add options
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Update shell/browser/net/resolve_host_function.cc
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* lint
* return object
* add missing file
* fix crash
* handle scope
* links
---------
Co-authored-by: Fedor Indutny <indutny@signal.org >
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2023-04-05 10:06:14 -04:00
David Sanders
db27b9f433
chore: initial linting fixes for JS in docs/fiddles ( #37689 )
2023-04-05 09:42:20 -04:00
Shelley Vohr
be32740991
docs: fix app.getPreferredSystemLanguages() return type ( #37821 )
...
docs: fix app.getPreferredSystemLanguages() return type
2023-04-05 09:31:53 -04:00
Calvin
b8a21dbcd7
test: migrate to helpers & disabled tests list ( #37513 )
...
* test: migrate to helpers & disabled tests list
* can't disable a test suite
* correct condition
* address review comments
2023-04-04 09:48:51 -04:00
electron-roller[bot]
58f3c0ee37
chore: bump chromium to 114.0.5694.0 (main) ( #37820 )
...
* chore: bump chromium in DEPS to 114.0.5694.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-04 15:42:56 +02:00
Shelley Vohr
3f42040a1b
fix: Fn+F fullscreen transitioning on macOS ( #37803 )
2023-04-04 15:16:59 +02:00
Jeremy Rose
e9d5c3517c
fix: apply csp correctly when contextIsolation: false ( #37756 )
...
* fix: apply csp correctly when contextIsolation: false
* better comments
2023-04-04 17:31:49 +09:00
Shelley Vohr
91f62ae73f
refactor: only override V8Platform::CreateJob ( #37800 )
...
refactor: only override V8Platform::CreateJob
2023-04-04 10:28:28 +02:00
David Sanders
4c8583c365
test: remove workaround for fixed Menu.closePopup issue ( #37802 )
2023-04-04 10:27:51 +02:00
Shelley Vohr
0b4ef2b1e5
chore: combine parallel/test-v8-stats v8 patches ( #37801 )
...
* chore: combine parallel/test-v8-stats v8 patches
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-04 10:19:45 +02:00
electron-roller[bot]
4ba5723aed
chore: bump chromium to 114.0.5692.0 (main) ( #37806 )
...
* chore: bump chromium in DEPS to 114.0.5692.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-03 15:45:36 -07:00
Keeley Hammond
652d603e69
build: bump nmv to 116 (Electron 25) ( #37797 )
...
build: bump nmv to 116 (e25)
2023-04-03 15:26:31 -07:00
Jeremy Rose
f40bd2da23
fix: record helper error messages in electron_main_mac ( #37807 )
2023-04-03 13:14:19 -07:00
electron-roller[bot]
e31f101712
chore: bump chromium to 114.0.5690.0 (main) ( #37780 )
...
* chore: bump chromium in DEPS to 114.0.5686.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5688.0
* chore: update patches
* chore: bump chromium in DEPS to 114.0.5690.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-04-03 18:56:57 +02:00
David Sanders
4415b7638a
chore: enforce consistent Markdown style for strong and emphasis ( #37787 )
2023-04-03 13:20:10 +02:00
github-actions[bot]
f7c6545eab
build: update appveyor image to latest version ( #37773 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-04-02 21:08:27 -07:00
Shelley Vohr
ef657bdc9d
chore: remove wasm CompileJSToWasmWrapperJob patch ( #37782 )
...
chore: remove wasm CompileJSToWasmWrapperJob patch
2023-04-01 08:47:54 -04:00
David Sanders
6012172187
fix: set background color for menu bar on Windows ( #37766 )
2023-03-31 18:06:09 +02:00
Samuel Attard
a75b892e90
build: remove request dependency ( #37747 )
...
* build: remove request dependency
* oops
2023-03-31 12:20:25 +02:00
Shelley Vohr
7c4f4c537e
build: fix build-tools schema in config ( #37765 )
2023-03-31 12:20:02 +02:00
Erick Zhao
4ca6fb3c4e
docs: update references to @electron/rebuild ( #37757 )
2023-03-31 11:36:59 +02:00
electron-roller[bot]
3fa03977c7
chore: bump chromium to 114.0.5684.0 (main) ( #37701 )
...
* chore: bump chromium in DEPS to 113.0.5672.0
* chore: bump chromium in DEPS to 114.0.5673.0
* chore: bump chromium in DEPS to 114.0.5675.0
* chore: update patches
* 4223697: [json-schema-compiler] T::Populate with base::Value::Dict
https://chromium-review.googlesource.com/c/chromium/src/+/4223697
* chore: update filenames.libcxx.gni
* 4290476: Report an explicit pause reason when stopping after taking a step.
https://chromium-review.googlesource.com/c/v8/v8/+/4290476
* chore: bump chromium in DEPS to 114.0.5682.0
* 4373699: [SystemProfileSelectionDefaultNone] Enable feature by default
https://chromium-review.googlesource.com/c/chromium/src/+/4373699
* chore: update patches
* Revert AsyncCompileJSToWasmWrapperJob simplification
https://chromium-review.googlesource.com/c/v8/v8/+/4347597/11
* 4365718: Reland "Reland "Reland "[Tracing] Use Perfetto client library for tracing on Linux"""
https://chromium-review.googlesource.com/c/chromium/src/+/4365718
* chore: bump chromium in DEPS to 114.0.5684.0
* chore: update patches
* 4335544: [handles] Refactor classes for abstract handles
https://chromium-review.googlesource.com/c/v8/v8/+/4335544
* update patch description to include tracking issue
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-03-30 22:03:58 -04:00
David Sanders
75919e28b8
docs: add links to IPC event structures ( #37760 )
2023-03-30 10:13:21 -07:00
Jeremy Rose
ac58607605
docs: remove save-to-disk disposition ( #37758 )
2023-03-30 10:07:54 -07:00
David Sanders
835ace243c
ci: don't use pull_request_target with semantic PR title check ( #37745 )
2023-03-29 14:28:52 -07:00
John Kleinschmidt
8f3ef39f1e
chore: update line endings on HTML files ( #37755 )
2023-03-29 15:02:13 -04:00
David Sanders
48e13fde80
docs: update docs.microsoft.com links to learn.microsoft.com ( #37707 )
2023-03-29 12:16:44 +02:00
David Sanders
bb6648b79e
chore: force LF endings for .html files in .gitattributes ( #37704 )
2023-03-28 11:17:16 -04:00
Will Anderson
2b9dae4b06
feat: add will-frame-navigate event ( #34418 )
...
* feat: add will-navigate-in-frame event to webContents
* docs: add documentation for webview will-frame-navigate event
* feat: Eliminate isInPlace argument from will-frame-navigate event
* fix: Fire will-frame-navigate before will-navigate
* feat: send will-frame-navigate with a WebFrameMain in the event details
* docs: Update WebContents docs for new API signature
* feat: Add custom event forwarding for <webview> will-frame-navigate
* fix: wrap WebFrameMain so it can be sent as an event
* test: update webContents and <webview> tests to match new signatures
* chore: undo unnecessary change
* fix: don't switch will-navigate to use EmitNavigationEventDetails
* test: clean up will-navigate and will-frame-navigate tests for <webview>
* chore: apply lint fixes
* chore: move GetRenderFrameHost helper into anonymous namespace
* docs: auto-generate WillFrameNavigateDetails rather than defining it manually
* test: Update <webview> tests to actually pass under new spec runner
* docs: Add section explaining relationship between various nav events
* test: Add some tests to ensure navigation event order doesn't silently change
* test: Always monitor all nav events to ensure unexpected ones don't fire
* test: Add test to verify in-page navigation event order
* feat: Change to new style where extra params are exposed as event props
* fix: Remove unused EmitNavigationEventDetails
* fix: Update tests to use new async helpers
* docs: Rename and reorder sections documenting navigation events
---------
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-03-28 10:55:41 -04:00
Mikołaj Sawicki
2e1f803f37
docs: updated package.json content and electron version in build first app guide ( #37554 )
...
* Docs: updated package.json content and electron version in build first app guide
* docs: removed caret from electron version
2023-03-28 10:53:20 -04:00
Shelley Vohr
4c6092e151
fix: draggable regions shouldn't capture clicks on frames windows ( #37594 )
2023-03-28 10:52:28 -04:00
github-actions[bot]
b72f81ab5b
ci: fixup update appveyor image workflow ( #37684 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-27 20:57:27 -04:00
Shelley Vohr
97b19a7946
chore: generator objects can't be sent over the context bridge ( #37593 )
...
* chore: generator objects can't be sent over the context bridge
* Trigger Build
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-27 20:36:55 -04:00
Shelley Vohr
b27e4cae21
fix: crash in MessagePortMain with some postMessage params ( #37585 )
...
* fix: crash in MessagePortMain postMessage
* Update shell/browser/api/message_port.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-03-27 13:56:55 -04:00
Peter Xu
1e106c8aa4
docs: fixup incorrect value for disabling sandbox ( #37711 )
2023-03-27 13:27:55 -04:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
John Kleinschmidt
6a6908c4c8
fix: allow cancelling of bluetooth requests ( #37601 )
...
* fix: allow cancelling of bluetooth requests
allows cancelling of bluetooth requests when no devices present
* docs: update docs to reflect how bluetooth works.
2023-03-27 09:31:15 -04:00
electron-roller[bot]
42e7cd9b3f
chore: bump chromium to 113.0.5670.0 (main) ( #37675 )
...
* chore: bump chromium in DEPS to 113.0.5670.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-23 17:15:56 -04:00
John Kleinschmidt
8cf03f5661
ci: fixup gn check to actually run gn check ( #37676 )
2023-03-23 15:02:08 -04:00
electron-roller[bot]
916861036d
chore: bump chromium to 113.0.5668.0 (main) ( #37646 )
...
* chore: bump chromium in DEPS to 113.0.5668.0
* chore: update patches
* chore: fixup for lint
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-22 20:09:13 -04:00
Erick Zhao
52481bc923
docs: update notifications tutorial ( #37602 )
...
* docs: update notifications tutorial
* delete unused assets
2023-03-21 21:40:43 -04:00
electron-roller[bot]
5023b49713
chore: bump chromium to 113.0.5666.0 (main) ( #37634 )
...
* chore: bump chromium in DEPS to 113.0.5666.0
* chore: update patches
* Make Clear-Site-Data: "cookies" respect third-party cookie blocking
https://chromium-review.googlesource.com/c/chromium/src/+/4346675
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-21 21:19:23 -04:00
Erick Zhao
2ac9ff1f20
docs: change MSDN links to new Microsoft docs ( #37603 )
2023-03-21 11:39:19 -04:00
electron-roller[bot]
46d3c4e04f
chore: bump chromium to 113.0.5664.0 (main) ( #37620 )
...
* chore: bump chromium in DEPS to 113.0.5664.0
* chore: update patches
* [Code Health] Migrate to WebUIDataSource::CreateAndAdd(), part 8
https://chromium-review.googlesource.com/c/chromium/src/+/4121701
Needed because of 4349773: Get rid of WebUIDataSource::Create() and WebUIDataSource::Add() | https://chromium-review.googlesource.com/c/chromium/src/+/4349773 landing
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-20 21:37:21 -04:00
John Kleinschmidt
0f77fec9d9
ci: make sure that strip_binary.gni is properly preserved ( #37626 )
2023-03-20 20:06:27 -04:00
dependabot[bot]
94f701edb8
build(deps-dev): bump webpack from 5.73.0 to 5.76.0 ( #37583 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.73.0 to 5.76.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.73.0...v5.76.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-20 13:33:08 -04:00
Charles Kerr
caa5989eed
fix: avoid deprecated value apis ( #37590 )
...
* fix: use base::Value::Dict:::Remove() instead of RemoveKe()
the latter is deprecated.
* fix: use base::Value::Dict::FindString() instead of base::Value::FindStringKey()
The latter is deprecated.
* chore: make lint happy
2023-03-20 10:38:45 -04:00
George Joseph
e0c348a2f8
feat: Allow usage of an absolute path for partitions used in a session ( #37604 )
...
* Allow an absolute path to be used for creating sessions
Allows an absolute path to be used for creating sessions
by adding the session.fromPath() API.
* Fixup! Clarify that an emptry string is not permitted as a parameter to fromPath()
2023-03-20 10:34:49 -04:00
Shelley Vohr
eb613ef3d4
fix: invoke app.dock.{hide|show} instead of duplicating logic ( #37599 )
...
fix: invoke app.dock.{hide|show} instead of duplicating logic
2023-03-20 10:30:49 -04:00
Milan Burda
7ed3c7a359
chore: remove unnecessary casting to base::Value ( #37591 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-03-20 10:26:42 -04:00
David Sanders
64b39dce14
docs: update broken links ( #37610 )
2023-03-20 10:25:54 -04:00
electron-roller[bot]
5261e08d0c
chore: bump chromium to 113.0.5660.0 (main) ( #37612 )
...
* chore: bump chromium in DEPS to 113.0.5657.0
* chore: bump chromium in DEPS to 113.0.5660.0
* chore: update patches
printing.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4347664
https://chromium-review.googlesource.com/c/chromium/src/+/4347664
https://chromium-review.googlesource.com/c/chromium/src/+/4338810
https://chromium-review.googlesource.com/c/chromium/src/+/4339496
mas_disable_remote_layer.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4334544
https://chromium-review.googlesource.com/c/chromium/src/+/4335299
* Add API to verify `TOP_LEVEL_STORAGE_ACCESS` permission status
https://chromium-review.googlesource.com/c/chromium/src/+/4306712
* Move os_crypt into a sync/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/4336304
* chore: generate libc++ headers
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-20 07:06:57 -04:00
John Kleinschmidt
9611b641c9
chore: Use thread_local: base/threading/ ( #37600 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4335524
2023-03-17 09:27:41 -04:00
Erick Zhao
095f9067a7
docs: delete synopsis.md ( #37580 )
...
* docs: delete synopsis.md
* remove code references to doc
2023-03-16 17:05:15 -07:00
Shelley Vohr
b8f970c1c7
fix: properly bubble up cookie creation failure message ( #37586 )
2023-03-16 13:48:14 +01:00
electron-roller[bot]
48d0b09ad9
chore: bump chromium to 113.0.5653.0 (main) ( #37587 )
...
* chore: bump chromium in DEPS to 113.0.5653.0
* chore: update patches
* [Extensions c2s] Move HasActiveTabAndCanAccess() to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/4305558
* [Privacy Hub] Respecting ChromeOS geoloc setting
https://chromium-review.googlesource.com/c/chromium/src/+/4171824
* Add runtime DLLs to win_clang_x64 when needed
https://chromium-review.googlesource.com/c/chromium/src/+/4336228
* chore: fix lint
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-16 19:03:53 +09:00
John Kleinschmidt
c5fc5efc00
chore: update filenames.libcxx.gni ( #37588 )
2023-03-15 15:41:32 -04:00
Milan Burda
6dc46e5bcf
refactor: replace deprecated base::Value::Set<Type>Key usage ( #37570 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-03-15 09:07:51 -04:00
electron-roller[bot]
061e2e5e73
chore: bump chromium to 113.0.5651.0 (main) ( #37553 )
...
* chore: bump chromium in DEPS to 113.0.5645.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4300129
Fix simple code shear
* chore: update patches/chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297496
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4327491
patch-fuzz update; no manual changes
* chore: remove patches/chromium/fix_x11_window_restore_minimized_maximized_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4252946
Upstreamed by zcbenz, so local patch is no longer needed
* chore: update chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019
Remove cookie parameter from PrintViewManagerBase::UpdatePrintSettings()
* chore: remove NOTIMPLEMENTED BrowserProcessImpl::GetBreadcrumbPersistentStorageManager()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4247145
method removed upstream, so we do not need to add a stub for it in the subclass
* chore: remove PrintViewManagerElectron::UpdatePrintSettings()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019
Previously, our implementation checked to see if we recognized the
cookie param that was passed in. If so, we reported a bad message.
Otherwise, we passed it up to the base class' UpdatePrintSettings().
CL4313019 removed the cookie param, so checking for a bad cookie
param is no longer necessary / no longer possible. Since the only
remaining task was to pass the work up to the base class, this commit
removes the subclass implmentation entirely.
* chore: update patches
* chore: bump chromium in DEPS to 113.0.5647.0
* chore: bump chromium in DEPS to 113.0.5649.2
* chore: bump chromium in DEPS to 113.0.5651.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2023-03-15 18:20:32 +09:00
Jeremy Spiegel
bf1cc1aeb2
fix: don't set delegate for QLPreviewPanel ( #37530 )
...
fix: don't set delegate for QLPreviewPanel
2023-03-14 14:41:34 +01:00
Shelley Vohr
e480cb7103
docs: clarify open-url not preventable ( #37564 )
...
docs: clarify open-url not preventable
2023-03-14 14:17:28 +01:00
github-actions[bot]
3b69a542fb
build: update appveyor image to latest version ( #37561 )
...
* build: update appveyor image to latest version
* build: update appveyor-woa.yml with latest image
* build: modify action to update both appveyor & appveyor-woa
---------
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2023-03-13 19:44:27 -04:00
Yureka
82456c6915
refactor: DEPS: remove squirrel.mac from recursedeps ( #37496 )
...
DEPS: remove squirrel.mac from recursedeps
squirrel.mac repository does not contain a gclient DEPS file, so recursing into it is useless
2023-03-13 22:16:23 +01:00
John Kleinschmidt
e58f0411d9
chore: fixup filenames.libcxx.gni ( #37567 )
2023-03-13 13:55:25 -04:00
electron-roller[bot]
e61728beb9
chore: bump node to v18.15.0 (main) ( #37532 )
...
* chore: bump node in DEPS to v18.15.0
* chore: update patches
* chore: update node filenames patch
* chore: re-enable parallel/test-intl
* chore: disable parallel/test-webcrypto-wrap-unwrap
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-03-13 09:51:03 -04:00
electron-roller[bot]
feaf18e371
chore: bump chromium to 113.0.5636.0 (main) ( #37130 )
...
* chore: bump chromium in DEPS to 112.0.5576.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4211172
* 4191759: Reuse PrintBackend process from query for printing
https://chromium-review.googlesource.com/c/chromium/src/+/4191759
* 4189718: Revert "[code health] Remove NotificationService use by SpellcheckService"
https://chromium-review.googlesource.com/c/chromium/src/+/4189718
* 4216074: web_contents_delegate: remove content::
https://chromium-review.googlesource.com/c/chromium/src/+/4216074
* 4192284: ios: Add feature flag for PartitionAlloc.
https://chromium-review.googlesource.com/c/chromium/src/+/4192284
* chore: bump chromium in DEPS to 112.0.5578.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4211172
* 4067682: Define ThirdPartyCookiesUserBypass runtime feature and plumb it through to URLRequest.cookie_setting_overrides.
https://chromium-review.googlesource.com/c/chromium/src/+/4067682
* chore: fixup patch indices
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: fixup patch indices
* chore: bump chromium in DEPS to 112.0.5579.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5581.0
* chore: update patches
* refactor: use modern base values in tracing
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4210912
* refactor: remove GetFontLookupTableCacheDir
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4191820
* refactor: base value type DICTIONARY replaced with DICT
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4198081
* chore: add stub impls for WCO routing
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4182690
* refactor: rename latency metrics
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4048262
* refactor: add sanitized context to clipboard write
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4178264
* refactor: s/Rect/WindowFeatures
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4167001
* refacotr: switch mojom::NetworkHintsHandler to use SchemeHostPair instead of URL
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4185417
* chore: remove dead DecodeToken code
* refactor: refactoring geolocation manager
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4161603
* chore: iwyu net/cert/cert_verify_result.h
* build: use xcode 14
* chore: bump chromium in DEPS to 112.0.5583.0
* chore: update patches
* chore: fixup mas patches
* refactor: base::span explicit conversion checks
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4219636
* chore: bump chromium in DEPS to 112.0.5591.0
* chore: bump chromium in DEPS to 112.0.5593.0
* chore: bump chromium in DEPS to 112.0.5594.3
* chore: bump chromium in DEPS to 112.0.5597.0
* chore: update chromium patches
* 4242507: Move most of GetChromeKeySystems() into components/cdm
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4242507
It seems as though the bug this patch was trying to resolve is now fixed.
* chore: update v8 patches
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* 4247938: Bump min required GTK version to 3.20
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4247938
* 4173660: Remove unused argument in BeforeUnloadCompleted
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4173660
* 4226656: Add response url to SimpleURLLoader::OnRedirectCallback
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4226656
* fixup!: 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManager Host.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* chore: bump chromium in DEPS to 112.0.5599.0
* chore: update patches
* 4251237: [StorageKey Cleanup] (2) Rename CreateFirstParty constructors
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4251237
* 4256866: [Extensions] Replace GetHooksForAPI with a RegisterHooksDelegate
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4256866
* chore: bump chromium in DEPS to 112.0.5601.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5603.0
* chore: bump chromium in DEPS to 112.0.5605.0
* chore: bump chromium in DEPS to 112.0.5607.0
* update patches
* fix mas patch
* chore: bump chromium in DEPS to 112.0.5609.0
* chore: update patches
* build: update appveyor image
4072083: New toolchain for Windows 11 10.0.22621.755 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/4072083
* chore: bump chromium in DEPS to 112.0.5611.0
* fix patches
* chore: update patches
* 4261434: Remove browser_watcher (1/3): Move ExitCodeWatcher to chrome/app
https://chromium-review.googlesource.com/c/chromium/src/+/4261434
* 4258446: Move network::mojom::ClearDataFilter to its own mojom file
https://chromium-review.googlesource.com/c/chromium/src/+/4258446
* 4128591: Enable large pdbs by default
https://chromium-review.googlesource.com/c/chromium/src/+/4128591
* move dbgcore/dbghelp to extensions_to_skip
* chore: bump chromium in DEPS to 113.0.5624.0
* chore: bump chromium in DEPS to 113.0.5626.0
* chore: bump chromium in DEPS to 113.0.5628.2
* chore: bump chromium in DEPS to 113.0.5630.0
* chore: bump chromium in DEPS to 113.0.5632.0
* chore: bump chromium in DEPS to 113.0.5634.0
* chore: bump chromium in DEPS to 113.0.5636.0
* 4255184: Permit popups from fullscreen-within-tab openers
https://chromium-review.googlesource.com/c/chromium/src/+/4255184
* 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
https://chromium-review.googlesource.com/c/chromium/src/+/4297715
* 4301154: Remove GLContextCGL and cleanup relevant code
https://chromium-review.googlesource.com/c/chromium/src/+/4301154
* 4278389: CDP: fix Page.addScriptToEvaluateOnNewDocument in iframes
https://chromium-review.googlesource.com/c/chromium/src/+/4278389
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
https://chromium-review.googlesource.com/c/chromium/src/+/4240798
* 4291989: Refactor logic determining untrusted mojo invitation flag.
https://chromium-review.googlesource.com/c/chromium/src/+/4291989
* 4110189: Add Select option to content touch selection menu.
https://chromium-review.googlesource.com/c/chromium/src/+/4110189
* 4309923: [Extensions] Add a unit test for API permissions having features
https://chromium-review.googlesource.com/c/chromium/src/+/4309923
* 4282657: Revert "[headless] Route stdio to parent console on Windows."
https://chromium-review.googlesource.com/c/chromium/src/+/4282657
* 4306685: [v8] Improve V8 flag configuration to avoid errors
https://chromium-review.googlesource.com/c/chromium/src/+/4306685
* 4295455: Add fallback Linux UI for when GTK 3.20 isn't available
https://chromium-review.googlesource.com/c/chromium/src/+/4295455
* 4289774: Remove feature for shared sandbox policies
https://chromium-review.googlesource.com/c/chromium/src/+/4289774
* 4292705: Rename WebSwapCGLLayer to ANGLESwapCGLLayer outside WebKit.
https://chromium-review.googlesource.com/c/angle/angle/+/4292705
* chore: fixup patch indices
* fixup! 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
* 4289789: Remove base::JSONReader::ReadDeprecated
https://chromium-review.googlesource.com/c/chromium/src/+/4289789
* 4281521: Remove `base::Value::FindKey()`
https://chromium-review.googlesource.com/c/chromium/src/+/4281521
* 4276761: Update NAK constructor and GetIsCrossSite
https://chromium-review.googlesource.com/c/chromium/src/+/4276761
* 4288119: Let GetUpload work with UploadInfo pointers
https://chromium-review.googlesource.com/c/chromium/src/+/4288119
* 4285322: content: Move WebExposedIsolationLevel to its own public header
https://chromium-review.googlesource.com/c/chromium/src/+/4285322
* 4251818: [Extensions] Make ExtensionSet moveable.
https://chromium-review.googlesource.com/c/chromium/src/+/4251818
* 4299554: [json-schema-compiler] Refactor to Params::Create (14/74)
https://chromium-review.googlesource.com/c/chromium/src/+/4299554
* chore: update printing patch indices
* chore: update chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4295455
Our patch changes the signature of `LinuxUiTheme::GetWindowFrameProvider()`.
Upstream 4295455 added a new subclass (FallbackLinuxUi) so sync its version
of GetWindowFrameProvider() to match our changes.
* chore: disable node test parallel/test-intl
Disabling the test because upstream is still working on this feature.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1414292
When upstream churn is done we should re-enable this test and update
it as necessary.
* win7dep: Remove ResolveCoreWinRTStringDelayload
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4277708
Upstream has removed this since Win7 support is deprecated.
This updates our `language_util_win.cc` file using the same
approach that 4277708 uses for `base/win/win_util.cc`.
* fix: remove use of ResolveCoreWinRTDelayload()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297979
A followup to prev commit, which removed ResolveCoreWinRTStringDelayload().
This PR follows the 4297979 approach of simply removing the calls, e.g.
https://chromium-review.googlesource.com/c/chromium/src/+/4297979/4/chrome/browser/device_reauth/win/authenticator_win.cc
* fix: add d3dcompiler_47 to the zip manifest
Xref: https://chromium-review.googlesource.com/c/angle/angle/+/4285717
Xref (24-x-y): 0fb1def32b
* This clang roll breaks Linux arm 32-bit
Xref (24-x-y): 1229114494
Xref (chromium): https://crbug.com/1410101
* fix: WebUSB on ARM64 macs (#37441 )
* chore: update patches
* chore: fix macOS CI build.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4278307
That whole dir was previously being removed to save space since we don't
use it. We still don't use anything in the file, but gn needs it to exist.
* fixup! chore: fix macOS CI build.
chore: mkdir --parents does not exist on BSD; use mkdir -p
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4273450
Upstream added a new block of code using NSAccessibilityRemoteUIElement,
so stub it out with `#if !IS_MAS_BUILD()` same as we do everwhere else.
* chore: address code review nit :)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-03-10 10:07:42 -06:00
Shelley Vohr
8ee58e18fd
refactor: createThumbnailFromPath takes size not maxSize ( #37362 )
...
refactor: createThumbnailFromPath takes size not maxSize
2023-03-08 21:48:29 -05:00
Erick Zhao
f33bf2a271
docs: remove outdated ipc example ( #37523 )
2023-03-08 21:41:26 -05:00
Keeley Hammond
77bd80dfb2
fix: fallback to X11 capturer if pipewire fails on Wayland ( #37511 )
...
* fix: fallback to x11 desktop capturer on Wayland
* fix: sanitize window/screen capturer inputs
* chore: clean up patch description
2023-03-07 13:59:06 -08:00
John Kleinschmidt
0d3aee26b9
docs: fixup WebUSB fiddle ( #37455 )
...
docs: fixup webusb fiddle
2023-03-07 21:36:31 +01:00
John Kleinschmidt
efde7a140b
fix: WebUSB on ARM64 macs ( #37441 )
2023-03-07 12:40:40 -05:00
Jeremy Rose
4e85bb921b
docs: remove misleading info from will-finish-launching docs ( #37514 )
2023-03-06 16:24:52 -08:00
Shelley Vohr
512e56baf7
feat: expose audio-state-changed on webContents ( #37366 )
...
feat: expose audio-state-changed on webContents
2023-03-06 17:00:24 +01:00
Calvin
c8f715f9a1
fix: Showing the about panel is async on all platforms ( #37440 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
* what if the about dialog was not blocking
* add this test back in
* document synchronicity
* github editor is a fan of spaces
2023-03-06 09:46:35 -05:00
Shelley Vohr
829fb4f586
fix: don't double-log unhandled rejections ( #37464 )
2023-03-06 11:04:43 +01:00
Shelley Vohr
17ccb3c6ec
refactor: leverage Skia helpers for NSColor ANSI logic ( #37452 )
2023-03-03 09:42:50 +01:00
Jeremy Rose
6bd9ee6988
feat: net.fetch() supports custom protocols ( #36606 )
2023-03-02 15:47:45 -08:00
Jeremy Rose
76c825d619
fix: draggable regions on MAS ( #37466 )
2023-03-02 11:21:51 -08:00
Kevin Law
692876c737
docs(clipboard): fix an issue of demo code ( #37438 )
...
doc(clipboard): fix an issue of demo code
2023-03-02 12:24:59 +01:00
Jeremy Rose
c3f06ef037
fix: DCHECK in MessageSync in rare cases ( #37439 )
2023-03-02 10:03:52 +01:00
Shelley Vohr
9b20b3a722
chore: improve contents.takeHeapSnapshot error messages ( #37434 )
...
* chore: improve contents.takeHeapSnapshot error messages
* fix wstring conversion issue
2023-03-01 10:50:36 -05:00
Shelley Vohr
8f2917db01
fix: min/max width/height enforcement when aspectRatio is set ( #37306 )
...
fix: min/max width/height with aspect ratio
2023-03-01 10:50:14 -05:00
Theo Gravity
49df19214e
feat: add enableLocalEcho flag to setDisplayMediaRequestHandler() callback ( #37315 )
2023-03-01 11:37:19 +01:00
Shelley Vohr
5e25d23794
fix: handle closing webContents in BrowserViews ( #37420 )
...
* fix: handle closing webContents in BrowserViews
* test: add window.close() test
2023-03-01 11:35:06 +01:00
Shelley Vohr
8fb0f43030
fix: Notification with reply obscuring first action on macOS ( #37381 )
...
fix: Notification with reply obscuring first action
2023-03-01 09:46:56 +01:00
Calvin
1f390119fe
test: add disabled tests list ( #37334 )
2023-02-28 17:27:54 -05:00
Shelley Vohr
87f2a1d572
fix: BroadcastChannel initialization location ( #37421 )
...
* fix: BroadcastChannel initialization location
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-28 17:26:37 -05:00
Calvin
2e03bdb9b6
fix: about panel crash ( #37373 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
2023-02-28 17:26:00 -05:00
Jeremy Rose
3a5ae28c95
feat: expose initiator in navigation events ( #37085 )
2023-02-28 11:08:22 -08:00
Milan Burda
ed7b5c44a2
feat: add types to webRequest filter ( #30914 )
2023-02-27 11:16:59 -08:00
Milan Burda
edf887bdc5
refactor: use _loadURL(url, options ?? {}); ( #37337 )
2023-02-27 10:05:58 +01:00
David Sanders
1ff7f098f1
chore: set wg-releases as owner of /docs/breaking-changes.md ( #37405 )
2023-02-24 11:34:23 -08:00
David Sanders
fb100e8f49
chore: remove dead config code for trop ( #37406 )
2023-02-24 11:11:04 -08:00
Jeremy Rose
3384908da1
docs: document change in draggable region behavior on macOS ( #37396 )
2023-02-24 11:10:27 -08:00
John Kleinschmidt
73bd9a3155
ci: rename Electron build step to include type of build being built ( #37371 )
...
ci: rename Electron build step to describe what is being built
2023-02-23 21:13:54 -05:00
Jeremy Rose
e27905c765
fix: allow contextmenu event in draggable regions ( #37386 )
2023-02-23 16:05:30 -08:00
Jeremy Rose
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise ( #37374 )
2023-02-23 15:53:53 -08:00
electron-roller[bot]
46c8b9c728
chore: bump node to v18.14.2 (main) ( #37380 )
...
* chore: bump node in DEPS to v18.14.2
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-22 19:17:03 +01:00
Shelley Vohr
6395898a79
refactor: use associated v8::Context for event setup ( #37355 )
...
refactor: use associated v8::Context for event setup
2023-02-22 10:03:46 +01:00
Shelley Vohr
32c60b29bb
fix: html fullscreen when window not fullscreenable ( #37348 )
2023-02-21 12:11:34 +01:00
Black-Hole
868676aa5c
feat: add httpOnly cookies.get filter ( #37255 )
...
feat: add httpOnly cookies filter
2023-02-21 11:44:35 +01:00
Shelley Vohr
85cf56d80b
fix: guard more private API usage on MAS builds ( #37309 )
2023-02-21 11:44:18 +01:00
Cheng Zhao
a92fd2aa05
fix: restoring X11 window should not remove previous maximize state ( #37346 )
2023-02-21 09:49:02 +01:00
Shelley Vohr
ee966ad6ec
build: remove unused python code ( #37351 )
2023-02-21 09:48:52 +01:00
Jeremy Rose
872d1fe05a
feat: implement net.fetch ( #36733 )
2023-02-20 12:57:38 -08:00
electron-roller[bot]
63f94f2359
chore: bump node to v18.14.1 (main) ( #37332 )
...
* chore: bump node in DEPS to v18.14.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-20 09:22:08 -08:00
Mikael Finstad
67a6fbf265
docs: fixed a typo in process.defaultApp doc ( #37342 )
...
docs: improve `defaultApp`
2023-02-20 13:06:19 +01:00
Milan Burda
f97d68c4bf
test: convert functions to async & eliminate duplicates ( #37316 )
...
test: convert functions to async
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-20 12:30:57 +01:00
Milan Burda
969665eaa2
test: type-safe import of menu-item-roles in api-menu-item-spec.ts ( #37320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-19 01:27:03 -08:00
Milan Burda
0d8dd61257
test: use expect(dir).to.be.an.instanceof(fs.Dirent); ( #37331 )
2023-02-19 01:25:40 -08:00
Milan Burda
cf10c19c33
test: cleanup let xyz = null as unknown as T; ( #37335 )
2023-02-19 01:24:24 -08:00
Milan Burda
fcfbcbc7e1
test: move desktopCapturer usage from renderer to main in ts-smoke ( #37321 )
2023-02-17 16:29:36 -06:00
Milan Burda
e34cc6f48c
test: enable linting of ts-smoke and fix all issues ( #37322 )
2023-02-17 12:56:09 -06:00
Milan Burda
ee87438d28
test: use async helpers to simplify tests ( #37314 )
...
test: use async helpers to simplify the tests
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-17 12:32:39 -06:00
Cheng Zhao
0de1012280
feat: add BrowserWindow.set/getWindowButtonPosition APIs ( #37094 )
2023-02-17 19:06:32 +09:00
Milan Burda
0a5e634736
test: rename & split internal module tests ( #37318 )
2023-02-17 10:14:40 +01:00
Alexey Kuzmin
73b7aac6a4
test: fix "crash cases" tests not failing properly ( #37304 )
...
* test: fix "crash cases" tests not failing properly
* fixup! test: fix "crash cases" tests not failing properly
2023-02-17 10:14:00 +01:00
Milan Burda
ea848bc1c5
test: use webContents.create() in type-safe way ( #37281 )
...
test: use (webContents as typeof ElectronInternal.WebContents).create()
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-16 15:41:41 +01:00
Shelley Vohr
a44e76fb70
build: strip warnings from stdout in get_release ( #37277 )
...
build: strip warnings from stdout in get_release
2023-02-16 15:20:19 +01:00
Shelley Vohr
3138acc377
chore: remove redundant Node.js patch ( #37279 )
...
* chore: fix patch for other patch
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-02-16 15:18:47 +01:00
Milan Burda
beed240454
test: use render-process-gone event in tests ( #37280 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-16 01:25:41 -08:00
Milan Burda
fdab0799fe
docs: only macOS 10.13+ is supported now ( #37286 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-15 16:29:02 -08:00
Keeley Hammond
17ea7f42fc
build: ignore makeLatest on pre-releases ( #37274 )
...
* build: ignore makeLatest on pre-releases
* chore: set makeLatest to false by default
Co-authored-by: Samuel Attard <sam@electronjs.org >
---------
Co-authored-by: Samuel Attard <sam@electronjs.org >
2023-02-14 21:12:07 -08:00
Shelley Vohr
d0cf9c4b08
build: add missing is_verbose_mode import ( #37273 )
...
build: add missing is_verbose_mode import
2023-02-14 22:52:53 +01:00
Keeley Hammond
fe7c535a3f
chore: add logging for debugging release json ( #37270 )
...
* chore: add debug logging for JSON
* chore: better logging
2023-02-14 13:03:50 -08:00
Shelley Vohr
8eee4f2df1
fix: BrowserView crash when 'beforeunload' prevented ( #37205 )
...
fix: crash when beforeunload prevented
2023-02-14 18:40:37 +01:00
Keeley Hammond
4d6f230d21
build: re-bake node v18.12.1 image for asset upload ( #37254 )
...
* debug: peek node version
* build: force uninstall/reinstall 18.12.1
* build: update image, re-comment out deps
* build: remove nodejs-lts uninstall, node debug line
2023-02-14 07:44:39 -08:00
Shelley Vohr
889859df5b
feat: include all standard paper sizes for webContents.print() ( #37159 )
2023-02-14 11:44:34 +01:00
Andrew Ferreira
cb03c6516b
docs: add win.isFocusable() return type ( #37245 )
...
docs: fix `win.isFocusable()` return type
2023-02-14 10:01:22 +01:00
Shelley Vohr
2e8114aea3
refactor: simplify Node.js event loop with SpinEventLoop ( #34884 )
...
refactor: simplify Node.js event loop with SpinEventLoop
2023-02-14 09:54:09 +01:00
Milan Burda
a38b711fb1
feat: add logUsage to shell.openExternal() options ( #37139 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-14 17:53:18 +09:00
Keeley Hammond
3972073116
build: revert to e-110.0.5451.0 on Appveyor ( #37253 )
2023-02-13 18:13:34 -08:00
Keeley Hammond
8c986ff194
build: bake node v18.12.1 Appveyor image ( #37250 )
...
* chore: bake a new AppVeyor image
* build: use image e-111.0.5560.0-4
* build: remove nodejs-lts
* build: use new baked image
2023-02-13 14:03:12 -08:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
Black-Hole
8b3e498436
fix: cookies filter secure invalid ( #37203 )
2023-02-13 15:02:55 +01:00
Samuel Attard
cf80994729
build: set make_latest correctly on published releases ( #37233 )
2023-02-13 01:16:27 -08:00
Jeremy Rose
01f1522cbd
chore: change undocumented protocol.registerProtocol to detect body type ( #36595 )
...
* feat: add protocol.registerProtocol
* remove wip handleProtocol code
* lint
* Update shell/browser/net/electron_url_loader_factory.h
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
* fix
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2023-02-13 16:48:30 +09:00
David Sanders
a37f572388
chore: update links in comments ( #37197 )
2023-02-11 18:52:54 -08:00
Milan Burda
3180312595
chore: update https://cs.chromium.org/ links to https://source.chromium.org/ ( #37190 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-11 18:52:32 -08:00
John Kleinschmidt
ff60fe25c1
ci: update appveyor build agent ( #37211 )
...
ci update appveyor image
2023-02-11 13:28:28 -05:00
Shelley Vohr
12ed401ca2
chore: re-enable worker spec failures ( #37015 )
2023-02-09 18:18:35 +01:00
Milan Burda
e5e9186d61
docs: add missing clipboard-sanitized-write permission value to setPermissionRequestHandler() ( #37173 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-09 11:38:39 +01:00
Shelley Vohr
478ce96914
fix: avoid using v8 on Isolate termination ( #35766 )
...
* fix: avoid using v8 on Isolate termination
* chore: refactor for review
---------
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-02-09 09:48:49 +01:00
Jeremy Rose
8dc98aeeae
chore: remove load-url event ( #37174 )
2023-02-09 14:40:37 +09:00
Milan Burda
35a9e67dba
chore: rename built-in modules to bindings to match naming update in node ( #37182 )
2023-02-09 10:31:38 +09:00
Samuel Attard
8b380ee2f2
test: ensure fullscreen test is retryable ( #37179 )
...
spec: ensure fullscreen test is retryable
2023-02-08 12:40:24 -08:00
Shelley Vohr
a15c9d3058
test: Node.js hkdf tests work now ( #37180 )
2023-02-08 13:35:28 -05:00
David Sanders
22de86d5f4
docs: remove reference to electron/releases ( #37164 )
2023-02-08 15:27:09 +01:00
Samuel Attard
8783d03a59
test: mark some node specs as flaky ( #37181 )
2023-02-08 15:19:02 +01:00
Bruno Pitrus
df6f99aa72
fix: correct redefinition which is invalid C++ ( #36096 )
...
* fix: correct redefinition which is invalid C++
See https://stackoverflow.com/a/15538759 for an explanation of class scope.
GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE
* Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
---------
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2023-02-08 16:03:47 +09:00
Samuel Attard
00a542358d
build: only retry tests on CI ( #37167 )
2023-02-07 22:44:53 -08:00
Jeremy Rose
9a0a0a7a46
fix: type for received-apns-notification event ( #37177 )
2023-02-07 22:43:29 -08:00
Milan Burda
6a3cb34326
fix: expose native bindings by process type ( #35949 )
2023-02-07 20:22:18 -05:00
electron-roller[bot]
de607cbcde
chore: bump node to v18.14.0 (main) ( #37129 )
...
* chore: bump node in DEPS to v18.14.0
* src: add support for externally shared js builtins
https://github.com/nodejs/node/pull/44376
* test: fix test broken under --node-builtin-modules-path
https://github.com/nodejs/node/pull/45894
* build: add option to disable shared readonly heap
https://github.com/nodejs/node/pull/45887
* src: remove unnecessary semicolons
https://github.com/nodejs/node/pull/46171
* src: remove return after abort
https://github.com/nodejs/node/pull/46172
* chore: fixup patch indices
* test_runner: parse yaml
https://github.com/nodejs/node/pull/45815
* src: use simdutf for converting externalized builtins to UTF-16
https://github.com/nodejs/node/pull/46119
* src: rename internal module declaration as internal bindings
https://github.com/nodejs/node/pull/45551
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-02-07 15:51:07 -05:00
David Sanders
7abe38b46e
build: fix version check in release_dependency_versions.yml ( #37155 )
...
* build: fix version check in release_dependency_versions.yml
* chore: also mksnapshot
2023-02-07 11:38:50 -05:00
David Sanders
d17507e3f6
docs: use relative links within docs ( #37042 )
2023-02-07 19:28:24 +09:00
Keeley Hammond
9b2b3aa287
docs: update stable dates ( #37150 )
2023-02-06 13:42:58 -08:00
github-actions[bot]
b4acbbb1e9
build: update appveyor image to latest version ( #37151 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com >
2023-02-06 13:42:32 -08:00
David Sanders
dc972b3919
chore: remove old script code for ATOM_SHELL_ ( #37140 )
...
The TODO is from 2016, seems like it's time
2023-02-06 13:07:45 -08:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
Milan Burda
8d382b9c60
chore: remove deprecated capturer count APIs ( #37075 )
...
chore: remove deprecated incrementCapturerCount() / decrementCapturerCount()
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-06 07:54:47 -08:00
Samuel Attard
7dcd97f864
fix: enable basic a11y when voice control is active ( #37122 )
...
c.f. https://chromium-review.googlesource.com/c/chromium/src/+/2680102
2023-02-06 20:32:21 +09:00
David Sanders
9ec13afeaf
docs: add missing ipcRenderer require to example code ( #37134 )
2023-02-06 14:40:16 +09:00
dependabot[bot]
9c0dcaf36b
build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 ( #37132 )
...
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases )
- [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: http-cache-semantics
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-04 13:50:33 -08:00
Samuel Attard
e60b0958e2
build: update spec dependencies to clean up yarn audit ( #37116 )
2023-02-03 13:17:05 -08:00
Shelley Vohr
0524b4e98a
build: allow workflow_dispatch on scheduled Actions ( #37128 )
2023-02-03 20:55:04 +01:00
electron-roller[bot]
d02c9f8bc6
chore: bump chromium to 111.0.5544.3 (main) ( #36820 )
...
* chore: bump chromium in DEPS to 111.0.5522.0
* chore: bump chromium in DEPS to 111.0.5524.0
* chore: bump chromium in DEPS to 111.0.5526.0
* chore: bump chromium in DEPS to 111.0.5528.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807
Fix simple code shear
* chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675
Fix simple code shear
* chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/disable_unload_metrics.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/preconnect_manager.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch
https://chromium-review.googlesource.com/c/v8/v8/+/3533019
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches
* chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765
Upstream added a new call to HeaderContext(), whose signature we have patched
* chore: bump chromium in DEPS to 111.0.5530.0
* chore: update patches
* Move ChildProcessHost* from content/common to content/browser
Xref: Move ChildProcessHost* from content/common to content/browser
* Remove RenderViewHostChanged
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[upstream removal of RenderViewHostChanged]
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[examples of upstream code adjusting to the change]
Upstream handles this change in roughly two approaches:
1. Move the code over to RenderFrameHostChanged(old_host, new_host)
but test for new_host->IsInPrimaryMainFrame() before acting
2. Migrate to the PrimaryPageChanged(page) API and use
page.GetMainDocument() to get the RenderFrameHost.
I've chosen 1. because electron_api_web_contents needed that pointer
to old_host to call RemoveInputEventListener(), but I may be missing
some context & would appreciate review on this commit.
* Make electron/shell/browser/relauncher_win.cc use <winternl.h>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135
Many internal Windows types are now available in winternl.h
so upstrem no longer defines the types themselves.
* Move ChildProcessHost* from content/common to content/browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795
* fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h>
winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace
* fixup! Move ChildProcessHost* from content/common to content/browser
chore: update #includes too
* chore: bump chromium in DEPS to 111.0.5532.0
* chore: sync patches/chromium/pepper_plugin_support.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/chromium/mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865
the content/common/pseudonymization_salt.cc patch is no longer needed
* chore: sync patches/chromium/mas_disable_remote_accessibility.patch
patch-fuzz update; no manual changes
* chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725
manually reync patch; no code changes
* chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230
patch-fuzz update; no manual changes
* chore: rebuild patches
* fixup! Remove RenderViewHostChanged
Use PrimaryPageChanged()
* chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991
This private, already-unused function showed up as a FTBFS because it
took a base::ListValue parameter and ListValue was removed upstream.
* task posting v3: remove includes of runner handles and IWYU task runners
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
* chore: lint
* chore: more lint
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
macOS, too
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
* chore: bump chromium in DEPS to 111.0.5534.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110
Sync to minor upstream changes. Add const correctness.
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787
patch-fuzz update; no manual changes
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5536.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
Sync with upstream code changes. Minor code golf for readability.
Note: upstream is laying groundwork for being able to work off of env vars
instead of switches. Doesn't affect us yet but worth being aware of.
> + // Environment variables could be supported in the future, but are not
> + // currently supported when launching with the zygote.
* chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836
patch-fuzz update; no manual changes
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
manual sync
* chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
https://chromium-review.googlesource.com/c/v8/v8/+/4147788
fuzz-patch
* chore: rebuild patches
* chore: bump chromium in DEPS to 111.0.5538.0
* chore: bump chromium in DEPS to 111.0.5540.0
* chore: update patches
* Remove sdk_forward_declarations
https://chromium-review.googlesource.com/c/chromium/src/+/4166680
* task posting v3: Remove task runner handles from codebase entirely
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928
* Cleanup child_process_launcher_helper*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* fix: utilityprocess spec on macOS
* fix: build on windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* chore: fix lint
* chore: bump chromium 111.0.5544.3
* chore: gen filenames.libcxx.gni
* Add check for Executable+Writable handles in renderer processes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416
* fixup! Add check for Executable+Writable handles in renderer processes.
* 4143761: [110] Disable SwiftShader for WebGL on M1 Macs.
https://chromium-review.googlesource.com/c/chromium/src/+/4143761
(cherry picked from commit 2f74db3c21 )
* chore: bump chromium to 111.0.5555.0
* 56085: Remove hmac.h include from ssl.h.
https://boringssl-review.googlesource.com/c/boringssl/+/56085
* 4167020: Remove forwarding headers
https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* chore: bump chromium to 111.0.5559.0
* 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura
https://chromium-review.googlesource.com/c/chromium/src/+/4181044
* 4189437: views: rename ink_drop_host_view to ink_drop_host
https://chromium-review.googlesource.com/c/chromium/src/+/4189437
* chore: bump chromium to 111.0.5560.0
* 4167016: win7dep: remove non aeroglass code
https://chromium-review.googlesource.com/c/chromium/src/+/4167016
* fixup after rebase: Remove forwarding header
s https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* 4125755: Reland "Reject getDisplayMedia calls without user activation"
https://chromium-review.googlesource.com/c/chromium/src/+/4125755
* test: add workaround
* chore: update patches
* fix: alter coreModuleRegExp to prevent arm crash
* Revert "fix: alter coreModuleRegExp to prevent arm crash"
This reverts commit 7e50630c98 .
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: review changes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-02-03 12:43:42 +01:00
Milan Burda
446c7809cc
refactor: process event emitting for sandboxed renderers ( #37109 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-02-03 11:59:57 +01:00
Samuel Attard
6e0d63c356
build: update mocha for retries and audit fix ( #37117 )
2023-02-02 17:40:30 -08:00
Samuel Attard
d069b8fc66
build: actually upload symbol zips ( #37124 )
2023-02-02 17:39:51 -08:00
Samuel Attard
1a6085e20e
docs: improve globalShortcut and hookWindowMessage types ( #37115 )
2023-02-02 12:31:28 -08:00
Shelley Vohr
33c32a798b
build: remove mips64el build config ( #37093 )
...
build: remove mips64el build config
2023-02-02 20:53:54 +09:00
David Sanders
23ae0dde17
docs: use automatic link syntax for symbol server link ( #37089 )
2023-02-02 19:16:41 +09:00
Milan Burda
ac266e2187
docs: remove invalid appcache value from storages in clearStorageData() ( #37095 )
2023-02-01 17:35:21 -08:00
Jeremy Rose
6aa7e27b39
fix: nodeIntegrationInWorker fails to boot in AudioWorklets ( #37041 )
2023-02-01 16:03:23 -08:00
Shelley Vohr
2dc76d0d80
build: fixup release_dependency_versions action ( #37036 )
2023-02-01 19:12:19 +01:00
Milan Burda
fd761ec8f7
chore: strip trailing whitespace ( #35969 )
2023-02-01 12:59:16 +01:00
Samuel Attard
dbdbb6fb3b
build: bump deps to clean up yarn audit ( #36535 )
...
build: update dependencies to clean up yarn audit
2023-01-31 13:58:39 -08:00
Shelley Vohr
26ee197fe5
chore: validate .mjs spec files in Node.js smoke tests ( #37073 )
...
chore: take mjs spec files in Node.js smoke tests
2023-01-31 12:36:27 -08:00
Shelley Vohr
730a07ad62
docs: note how to clear an aspect ratio ( #37074 )
2023-01-31 12:36:09 -08:00
David Sanders
01b4e3b521
ci: update actions/stale to v6.0.1 ( #37079 )
2023-01-31 12:30:40 -08:00
David Sanders
899881457b
docs: update modules list in docs/README.md ( #37080 )
2023-01-31 12:29:33 -08:00
John Kleinschmidt
9adbf49240
ci: fixup ninja for release ( #37083 )
2023-01-31 11:29:39 -05:00
Milan Burda
c6203d54d0
refactor: simplify script/lint.js ( #37077 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-31 14:33:50 +01:00
Shelley Vohr
23739c644b
fix: crash on WebWorkerObserver script execution ( #37050 )
...
fix: crash on WebWorkerObserver script execution
2023-01-31 12:29:29 +01:00
Shelley Vohr
ce35bda805
fix: crash on window.print() ( #37052 )
...
fix: crash on window.print()
2023-01-31 12:06:11 +01:00
John Kleinschmidt
fcc7a869f2
ci: ensure correct ninja is used ( #37069 )
2023-01-30 12:35:38 -05:00
Jeremy Rose
85f41d59ac
fix: ensure autofill popup view is > 1x1 in size ( #36121 )
...
* fix: ensure autofill popup view is > 1x1 in size
ref #26667
* Update shell/browser/ui/views/autofill_popup_view.cc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-27 10:50:19 +01:00
Shelley Vohr
0026fdb78a
fix: resizing borders in nondraggable regions ( #37016 )
...
* fix: resizing borders in nondraggable regions
* chore: remove frame handling from ShouldDescendIntoChildForEventHandling
2023-01-26 14:04:19 +01:00
Mikaël Barbero
1486cbdf64
feat: add support for unlocking with Apple Watch ( #36935 )
2023-01-26 13:05:42 +01:00
Cheng Zhao
c303135b02
fix: fallback to GtkStatusIcon when app indicator is not supported ( #36815 )
...
* chore: get ready for multi backend tray
* fix: fallback to GtkStatusIcon when app indicator is not supported
* chore: use smart pointers
2023-01-26 19:15:55 +09:00
Shelley Vohr
7d46d3ec9d
feat: emit devtools-open-url event for DevTools link selection ( #36774 )
...
* feat: emit event for DevTools link selection
* chore: devtools-open-in-new-tab -> devtools-open-url
2023-01-26 09:54:26 +01:00
Himanshu Patil
8d008c977d
docs: updated deep link docs ( #36952 )
...
* removed open-url listener from windows code
* updated deep-link fiddle
* fixed url hash to app.requestSingleInstanceLock
* code linted
* updated website url to relative file path
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-01-26 16:20:10 +09:00
Shelley Vohr
c6b9340b89
chore: fix memory leak in v8.serialize() ( #37021 )
...
chore: fix memory leak in v8.serialize()
2023-01-26 15:43:57 +09:00
Milan Burda
397aee7315
chore: update README.md ( #37002 )
...
Update README.md
2023-01-26 09:57:20 +09:00
Robo
a30a9c7c4f
chore: remove crashpad related sandbox policy ( #37013 )
2023-01-26 09:01:34 +09:00
kyrylo-hrechykhin
a59f11fdb1
feat: enable whole-program optimization native modules by default ( #36937 )
...
* feat: enable whole-program optimization
Enable whole-program optimization in electron native modules by default.
* pass --with-ltcg to configure.py instead of setting variable
* enable ltcg only on windows
Co-authored-by: Kyrylo Hrechykhin <khrechykhin@microsoft.com >
2023-01-25 13:06:05 -08:00
Samuel Attard
58beec1da2
fix: do not error on null exports in ESM loader ( #37009 )
2023-01-25 13:03:47 -08:00
Milan Burda
4bc6b15f53
refactor: move spec helpers to spec/lib ( #37010 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 13:01:25 -08:00
Milan Burda
355f322dbd
chore: remove unused fixture_support.md ( #37011 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 13:00:51 -08:00
Milan Burda
2f79444535
refactor: separate WEB_VIEW_ATTRIBUTES / WEB_VIEW_ERROR_MESSAGES ( #36972 )
2023-01-25 16:08:46 +01:00
Milan Burda
a9b6041d38
chore: remove unused files in spec/fixtures ( #37012 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-01-25 16:02:44 +01:00
Shelley Vohr
afca3ff965
chore: call ListenerDestroyed() in FileSelectHelper::RunFileChooserEnd() ( #37006 )
...
chore: call ListenerDestroyed() in FileSelectHelper::RunFileChooserEnd()
2023-01-25 15:51:01 +01:00
Shelley Vohr
86f99e9cf0
chore: cleanup ElectronContentClient::AddPlugins ( #37005 )
...
chore: cleanup ElectronContentClient::AddPlugins
2023-01-25 14:57:30 +01:00
David Sanders
ca3145a547
chore: use vscode-markdown-languageservice for link linting ( #36901 )
...
* chore: use vscode-markdown-languageservice for docs link linting
* docs: make links relative
2023-01-24 09:00:25 +01:00
Shelley Vohr
37f5881882
test: add a <datalist> spec for time type ( #36953 )
...
spec: add a datalist spec for time type
2023-01-23 11:21:28 -05:00
David Sanders
f20d0b4ecb
chore: clean up .keep files ( #36980 )
2023-01-23 09:57:00 +01:00
Robo
cdb65c15a8
fix: make plugin helper executable unconditional ( #36971 )
2023-01-21 09:42:45 +09:00
Shelley Vohr
c3f02d7df2
chore: cleanup autofill agent shutdown sequence ( #36954 )
2023-01-20 14:35:06 -08:00
David Sanders
3b018143b4
ci: don't run stale workflow jobs in parallel ( #36967 )
2023-01-20 13:02:50 -08:00
David Sanders
885c1878d4
test: fix nativeTheme test when system in dark mode ( #36943 )
2023-01-19 21:59:20 -05:00
GGIEnrike
5ce8dfdcb5
docs: Change factuality and word choice in app.runningUnderARM64Translation ( #36947 )
...
Change factuality and word choice.
Added "or WOW" to the phrase, "when they are running the x64 version under Rosetta", to reflect the use of a supported platform, Windows, as a possible scenario.
Changed the wording of that same sentence to make it appear clearer. "incorrectly" to "mistakenly" and moved this word to before the verb instead of the end of the sentence.
2023-01-19 15:00:06 -05:00
David Sanders
4e4ae9ff53
docs: update clipboard fiddles ( #36946 )
2023-01-19 14:59:35 -05:00
Shelley Vohr
55c818d0a8
fix: <datalist> dropdown positioning ( #36934 )
...
fix: datalist dropdown positioning
2023-01-19 19:44:23 +01:00
David Sanders
9630e26e6d
test: support running tests against Electron releases ( #36944 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-01-19 12:14:59 +01:00
David Sanders
b69236d177
test: fix test for USB device.forget() ( #36942 )
2023-01-18 16:30:01 -05:00
Shelley Vohr
b1548c2dbe
fix: webview background color on reload ( #36920 )
2023-01-18 14:46:47 +01:00
Shelley Vohr
1d98b27a66
chore: update node types version ( #36924 )
2023-01-18 14:46:27 +01:00
John Kleinschmidt
91ccf08853
ci: run WOA tests on AppVeyor ( #36925 )
2023-01-18 12:12:57 +01:00
Milan Burda
2c56a06ad3
feat: add label property to Display objects ( #36855 )
2023-01-18 15:44:40 +09:00
David Sanders
a7bc579220
ci: update pinned versions for security scorecard workflow ( #36910 )
2023-01-17 10:41:05 -08:00
David Sanders
e2b21d87d7
ci: update amannn/action-semantic-pull-request version ( #36902 )
2023-01-16 10:23:38 +01:00
David Sanders
d94f35a8f6
chore: disallow shortcut reference links in docs Markdown ( #36860 )
...
* chore: disallow shortcut reference links in docs Markdown
* docs: clean up shortcut-style links
2023-01-16 10:22:49 +01:00
Shelley Vohr
a9e7bb0027
fix: Cmd+Tab not working when exiting kiosk mode ( #36854 )
2023-01-16 10:06:43 +01:00
Keeley Hammond
ad1a09bb10
build: bump appveyor to e-111.0.5518.0 ( #36900 )
2023-01-12 17:54:06 -05:00
Shelley Vohr
c953109f01
build: remove older branch migration helpers ( #36888 )
...
* build: remove older branch migration helpers
* chore: fix typo
2023-01-12 12:05:26 -05:00
Shelley Vohr
3f764cbbd5
build: remove ScriptOrModule V8 flag ( #36887 )
...
build: remove ScriptOrModule V8 flag
2023-01-12 13:02:40 +01:00
Eugene Nesvetaev
ce56d614a3
chore: fix typo in promise rejection ( #36763 )
2023-01-12 12:32:56 +01:00
David Sanders
a9c03950c0
docs: cleanup reference links ( #36659 )
2023-01-11 22:16:34 -08:00
Robo
fefb22a83d
chore: enable microtask queue per window agent ( #36870 )
...
* chore: enable microtask queue per window agent
* chore: switch policies on context microtask queue
* fix: ensure node::Environment is valid
2023-01-12 01:59:32 +09:00
Robo
2a7d0a84c0
fix: missing libcxx headers ( #36863 )
...
* chore: add libcxx script to precommit hook
* chore: run gen-libc++-filename.js
2023-01-12 01:59:03 +09:00
Shelley Vohr
f31826f4a0
fix: getUserMedia duplicate permissions call ( #36787 )
...
* fix: getUserMedia duplicate permissions call
* test: add regression test
2023-01-11 11:55:31 +01:00
electron-roller[bot]
1d9a4ab02c
chore: bump node to v18.13.0 (main) ( #36818 )
...
* chore: bump node in DEPS to v18.13.0
* child_process: validate arguments for null bytes
https://github.com/nodejs/node/pull/44782
* bootstrap: merge main thread and worker thread initializations
https://github.com/nodejs/node/pull/44869
* module: ensure relative requires work from deleted directories
https://github.com/nodejs/node/pull/42384
* src: add support for externally shared js builtins
https://github.com/nodejs/node/issues/44000
* lib: disambiguate `native module` to `binding`
https://github.com/nodejs/node/pull/45673
* test: convert test-debugger-pid to async/await
https://github.com/nodejs/node/pull/45179
* deps: upgrade to libuv 1.44.2
https://github.com/nodejs/node/pull/42340
* src: fix cppgc incompatibility in v8
https://github.com/nodejs/node/pull/43521
* src: use qualified `std::move` call in node_http2
https://github.com/nodejs/node/pull/45555
* build: fix env.h for cpp20
https://github.com/nodejs/node/pull/45516
* test: remove experimental-wasm-threads flag
https://github.com/nodejs/node/pull/45074
* src: iwyu in cleanup_queue.cc
https://github.com/nodejs/node/pull/44983
* src: add missing include for `std::all_of`
https://github.com/nodejs/node/pull/45541
* deps: update ICU to 72.1
https://github.com/nodejs/node/pull/45068
* chore: fixup patch indices
* chore: remove errant semicolons
- https://github.com/nodejs/node/pull/44179
- https://github.com/nodejs/node/pull/44193
* src: add support for externally shared js builtins
https://github.com/nodejs/node/pull/44376
* chore: add missing GN filenames
* deps: update nghttp2 to 1.51.0
https://github.com/nodejs/node/pull/45537
* chore: disable more Node.js snapshot tests
The Snapshot feature is currently disabled
* chore: disable ICU timezone tests
Node.js uses a different version of ICU than Electron so they
will often be out of sync.
* chore: disable threadpool event tracing test
Event tracing is not enabled in embedded Node.js
* chore: fixup patch indices
* chore: comments from review
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-11 11:33:48 +01:00
Samuel Attard
b3d16e727c
build: migrate patch-up to use app creds ( #36817 )
2023-01-10 21:56:50 -08:00
Shelley Vohr
dfe501941c
build: update release deps workflow ( #36530 )
2023-01-10 12:46:30 +01:00
Shelley Vohr
414791232a
fix: RTL WindowButtonsProxy buttons ( #36839 )
...
* fix: RTL WindowButtonsProxy buttons
* chore: address review feedback
2023-01-10 12:19:00 +01:00
David Sanders
168726a052
fix: handle null/undefined options for fs.readdir ( #34764 )
2023-01-10 12:16:39 +01:00
Milan Burda
1c9e7687f9
docs: add missing window-management permission value to setPermissionRequestHandler() ( #36776 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-01-10 09:49:04 +01:00
Shelley Vohr
f56a26c4f7
build: fix broken stale issues workflow ( #36843 )
2023-01-09 19:16:58 +01:00
Shelley Vohr
1a9c338c92
chore: cleanup drag_util ( #36806 )
...
chore: cleanup drag_util
2023-01-09 10:00:47 +01:00
David Sanders
0d05273024
docs: fix link in breaking-changes.md ( #36793 )
2023-01-09 16:37:57 +09:00
electron-roller[bot]
90af7d7fe2
chore: bump chromium to 111.0.5518.0 (main) ( #36575 )
...
* chore: bump chromium in DEPS to 110.0.5461.0
* chore: update patches
* 3903024: hid: Add connection count tracking methods for HidDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/3903024
* 4076211: Turn FrameTreeNode::frame_tree into raw_ref.
https://chromium-review.googlesource.com/c/chromium/src/+/4076211
* chore: bump chromium in DEPS to 110.0.5463.0
* chore: bump chromium in DEPS to 110.0.5465.0
* fix patches
* 3835037: Add new slides media session actions to Picture-in-Picture window
https://chromium-review.googlesource.com/c/chromium/src/+/3835037
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5467.0
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5469.0
* chore: bump chromium in DEPS to 110.0.5471.0
* chore: bump chromium in DEPS to 110.0.5473.0
* chore: bump chromium in DEPS to 110.0.5475.0
* chore: update patches
* 4074449: Add gl::FrameData to software path
https://chromium-review.googlesource.com/c/chromium/src/+/4074449
* 4065264: [Extensions] Add a new side panel view type
https://chromium-review.googlesource.com/c/chromium/src/+/4065264
* 4060548: Remove base::Value::GetListDeprecated().
https://chromium-review.googlesource.com/c/chromium/src/+/4060548
* chore: add missing RefCountedMemory include
* 4081108: task posting v3: remove task_runner_util{.h,_unittest.cc}
https://chromium-review.googlesource.com/c/chromium/src/+/4081108
* 4072471: Rename Mixed Download Blocking to Insecure Download Blocking
https://chromium-review.googlesource.com/c/chromium/src/+/4072471
* 4025927: [Code Health] Migrate e/c/manifest.cc to base::Value::Dict interface
https://chromium-review.googlesource.com/c/chromium/src/+/4025927
* chore: fixup patch indices
* chore: bump chromium in DEPS to 110.0.5477.0
* chore: fixup preconnect_manager.patch
* chore: fixup patch indices
* fixup! 4074449: Add gl::FrameData to software path
* 4074449: Add gl::FrameData to software path
This commit also reformatted the two files in this patch. The only
change here is the addition of the |data| arg to |OnSwapBuffers|.
https://chromium-review.googlesource.com/c/chromium/src/+/4074449
* 4081108: task posting v3: remove task_runner_util{.h,_unittest.cc}
https://chromium-review.googlesource.com/c/chromium/src/+/4081108
* 4085814: [Test Automation] Move NativeWindowTracker to ui/views
https://chromium-review.googlesource.com/c/chromium/src/+/4085814
* 4032656: hid: Abstract HidSystemTrayIcon class for profiles' HID connections
https://chromium-review.googlesource.com/c/chromium/src/+/4032656
* chore: bump chromium in DEPS to 110.0.5479.0
* chore: fixup patches & simplify printing patch
To be specific, I replaced some combination of line removals &
commenting-out with `#if 0` blocks since they were already there for
android.
Should be functionally the same, just written differently for better
patch maintainability.
* chore: bump chromium in DEPS to 110.0.5481.0
* chore: update patch indicies
* 4098946: Migrate Extension::Create() argument to base::Value::Dict (part 4 of 4)
https://chromium-review.googlesource.com/c/chromium/src/+/4098946
* chore: bump chromium in DEPS to 111.0.5482.0
* chore: bump chromium in DEPS to 111.0.5484.0
* chore: bump chromium in DEPS to 111.0.5486.0
* chore: update patch indices
* 4112903: Reland "Move gl::FrameData to gfx::FrameData"
https://chromium-review.googlesource.com/c/chromium/src/+/4112903
* 4056216: Option to create a tab target with Target.createTarget in /json/new
https://chromium-review.googlesource.com/c/chromium/src/+/4056216
* chore: bump chromium in DEPS to 111.0.5488.0
* chore: bump chromium in DEPS to 111.0.5490.0
* chore: bump chromium in DEPS to 111.0.5492.0
* chore: bump chromium in DEPS to 111.0.5494.0
* chore: bump chromium in DEPS to 111.0.5496.0
* chore: bump chromium in DEPS to 111.0.5498.0
* chore: bump chromium in DEPS to 111.0.5500.0
* chore: bump chromium in DEPS to 111.0.5502.0
* chore: update patch indices
+ small update to printing.patch due to:
3653941: [printing] Extract settings logic from PrintJobWorker
https://chromium-review.googlesource.com/c/chromium/src/+/3653941
* 4113994: Cleanup: Rename webui_generated_resources_* to webui_resources_*.
https://chromium-review.googlesource.com/c/chromium/src/+/4113994
* 4112537: Remove DictionaryPrefUpdate.
https://chromium-review.googlesource.com/c/chromium/src/+/4112537
* 4072073: Remove //chrome/browser/ash dependency from pdf_extension_util.cc
https://chromium-review.googlesource.com/c/chromium/src/+/4072073
* 4055223: [Remove FileSystemConnector] Remove DownloadItemRerouteInfo
https://chromium-review.googlesource.com/c/chromium/src/+/4055223
* Migrate base::DictionaryValue to base::Value::Dict
This relates to multiple CLs cleaning up this class in this roll,
but the ones that are specifically relevant here:
4116096: [CodeHealth] Remove DictionaryValue::GetInteger
https://chromium-review.googlesource.com/c/chromium/src/+/4116096
4113764: [CodeHealth] Remove deprecated DictionaryValue::SetInteger()
https://chromium-review.googlesource.com/c/chromium/src/+/4113764
* 3653941: [printing] Extract settings logic from PrintJobWorker
https://chromium-review.googlesource.com/c/chromium/src/+/3653941
* chore: bump chromium in DEPS to 111.0.5504.0
* chore: update patches
* (WIP) 4003663: Enable Microtask queues per WindowAgent.
https://chromium-review.googlesource.com/c/chromium/src/+/4003663
* chore: bump chromium in DEPS to 111.0.5506.0
* chore: update patches
* fix: printing patch
It was complaining that this method isn't used on windows
* chore: bump chromium in DEPS to 111.0.5508.0
* chore: bump chromium in DEPS to 111.0.5510.0
* chore: bump chromium in DEPS to 111.0.5512.0
* chore: bump chromium in DEPS to 111.0.5514.0
* chore: bump chromium in DEPS to 111.0.5516.0
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5518.0
* chore: update patches
* 4027428: [rsafor] Move rsaFor requests to a separate permission
https://chromium-review.googlesource.com/c/chromium/src/+/4027428
* Revert "(WIP) 4003663: Enable Microtask queues per WindowAgent."
This reverts commit cc36d226e3f3fe5f4bea6538102d55ce3203190f.
* chore: disable Microtask queues per WindowAgent.
see https://chromium-review.googlesource.com/c/chromium/src/+/4003663
* chore: cleanup after rebase
* fixup: disable Microtask queues per WindowAgent.
* chore: cleanup password from keychain after test
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Calvin Watford <cwatford@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
2023-01-05 21:35:34 -05:00
Mikael Finstad
ba962c94cc
docs: Add note about argv getting modified ( #36735 )
...
Add note about argv getting modified
See https://github.com/electron/electron/issues/20322
2023-01-05 11:39:45 +01:00
Jeremy Rose
9b8b8f5880
fix: move report_raw_headers to TrustedParams ( #36725 )
...
* fix: move report_raw_headers to TrustedParams
* Update electron_api_url_loader.cc
* missed a copy constructor
2023-01-05 10:36:14 +01:00
Shelley Vohr
32288ac9c5
fix: focus rings with multiple buttons in showMessageBox ( #36772 )
...
fix: focus rings with multiple buttons in messageBox
2023-01-05 09:56:38 +01:00
Milan Burda
42cda4a893
fix: rename WebSwapCGLLayer to WebSwapCGLLayerChromium ( #35961 )
...
* fix: rename WebSwapCGLLayer to WebSwapCGLLayerChromium
* undo changes to patches/config.json
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2023-01-05 15:49:08 +09:00
David Sanders
700f43c90c
docs: cleanup some rogue backticks ( #36778 )
2023-01-04 14:52:46 +01:00
Marco Pelloni
6cb5f5a1eb
docs: update incorrect grammar ( #36780 )
...
#### Description of Change
The first sentence within the documentation "[Important: signing your code](https://www.electronjs.org/docs/latest/tutorial/tutorial-packaging#important-signing-your-code )" is grammatically incorrect.
> In order to distribute desktop applications to end users, we highly recommended for you to code sign your Electron app.
I've adjusted the copy to switch "highly recommended" to "highly recommend". I've also switched out "for you to code sign" for "that you code sign" for clarity.
> In order to distribute desktop applications to end users, we _highly recommend_ that you **code sign** your Electron app.
2023-01-04 14:52:29 +01:00
David Sanders
20cff64282
docs: update links ( #36657 )
2023-01-02 11:52:18 +01:00
David Sanders
20ac617c03
chore: update electron/clerk links in PR template ( #36658 )
2023-01-02 11:23:43 +01:00
Roger Zurawicki
28cfaccb1d
docs: update code highlights in tutorial ( #36691 )
...
docs: fix code highlighting in preload tutorial
The highlighted lines in the code snippets were unaligned,
which could cause a newcomer unneeded confusion on what
lines need to be changed.
2023-01-02 11:14:34 +01:00
YongWoo Roh
c4a93390dd
docs: main.js file change was displayed incorrectly ( #36709 )
...
main.js file change was displayed incorrectly
The line in the main.js file change was displayed incorrectly, so it was corrected.
2023-01-02 11:04:41 +01:00
David Sanders
327abb4b52
docs: improve dark mode example fiddle ( #36596 )
2023-01-02 11:02:15 +01:00
George Xu
644243efd6
docs: update visual studio min version ( #36702 )
2022-12-22 11:48:48 -08:00
Jeremy Rose
8f23b1527b
fix: use chrome headers in net.request for everything except cookie ( #36666 )
2022-12-21 14:53:29 -08:00
MAPGarrett
8c837fda4f
docs: Fix incorrect highlight in an example snippet ( #36700 )
...
Fix incorrect highlight in an example snippet
At the moment, the "Communicating between processes" `main.js` snippet highlights the line containing `})` when the relevant line is `ipcMain.handle('ping', () => 'pong')`.
2022-12-20 10:06:25 -08:00
Milan Burda
5fd7a43970
test: replace (webContents as any).destroy() with webContents.destroy() ( #36653 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-14 16:07:38 -05:00
Jeremy Rose
fb461effae
chore: cherry-pick 32b7dc86a763 from v8 ( #36651 )
...
* chore: cherry-pick 32b7dc86a763 from v8
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-14 16:06:10 -05:00
Jeremy Rose
9e7fbc7021
fix: blend node and blink code generation policy when both are loaded ( #36567 )
2022-12-14 10:05:34 -08:00
Webster Xu
f72e6551f0
fix: use the process cache to reduce the memory for asar file ( #36600 )
...
* fix: use the process cache to reduce the memory for asar file
* Update shell/common/api/electron_api_asar.cc
Co-authored-by: webster.xu <webster.xu@ringcentral.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-12-14 12:37:28 -05:00
Robert Günzler
ab890fb8c3
fix: strip branded binaries ( #36641 )
...
When creating branded release builds and using scripts/strip-binaries.py
on Linux, the final artifacts end up unstripped due to the static set of
binaries considered for stripping.
With this patch the name of the electron binary is taken from the
BRANDING.json `project_name` key.
Signed-off-by: Robert Günzler <r@gnzler.io >
Signed-off-by: Robert Günzler <r@gnzler.io >
2022-12-13 17:01:20 -05:00
John Kleinschmidt
425f1ffa98
chore: update AppVeyor image to include latest Windows updates ( #36649 )
...
clenaup
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2022-12-13 14:28:09 -05:00
David Sanders
4d9c84d7c0
chore: update markdownlint ( #36540 )
2022-12-13 10:55:53 -08:00
Bruno Pitrus
1432f9bb65
chore: reland “fix ambiguous reference gcc compile error” ( #36544 )
...
This is a reland of #35714 . The broken code got reintroduced in #35310 due to a mismerge.
2022-12-13 10:55:08 -08:00
Michał Zarach
6a798b1c58
feat: added username to IAP purchaseProduct method ( #35902 )
2022-12-12 10:11:48 -08:00
Hugh Davey
4e66184287
docs: add mdn link to web-request-filter.md ( #36603 )
...
* Add MDN link to web-request-filter.md
When I was using the Electron docs I wanted to know how to use [webRequest.onBeforeSendHeaders](https://www.electronjs.org/docs/latest/api/web-request#webrequestonbeforesendheadersfilter-listener ) but I was unable to correctly guess the correct format for the `WebRequestFilter` URL strings, and there was no explanation in the Electron docs. Eventually I googled it and found the MDN article which helped me.
* Update docs/api/structures/web-request-filter.md
Co-authored-by: Black-Hole <158blackhole@gmail.com >
* Update docs/api/structures/web-request-filter.md
Co-authored-by: Black-Hole <158blackhole@gmail.com >
Co-authored-by: Black-Hole <158blackhole@gmail.com >
2022-12-08 17:11:42 -05:00
Jeremy Rose
99b0d63c84
ci(not-really): autoclose issues with blocked/need-repro and no response ( #36532 )
2022-12-05 20:53:07 -05:00
Samuel Attard
e1e66fc8ac
docs: link net.request options to ClientRequestConstructorOptions ( #36556 )
2022-12-05 15:17:37 -08:00
electron-roller[bot]
8acf6039e7
chore: bump chromium to 110.0.5451.0 (main) ( #36394 )
...
* chore: bump chromium in DEPS to 110.0.5425.0
* chore: bump chromium in DEPS to 110.0.5427.0
* chore: bump chromium in DEPS to 110.0.5429.0
* chore: bump chromium in DEPS to 110.0.5431.0
* chore: update patches/chromium/picture-in-picture.patch to fix upstream code shear
https://chromium-review.googlesource.com/c/chromium/src/+/4024078
* chore: sync patch w/upstream shear: remove_usage_of_incognito_apis_in_the_spellchecker.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3967854
* chore: sync patch w/upstream shear: feat_expose_raw_response_headers_from_urlloader.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3983373
* chore: sync patch w/upstream shear: chromium/custom_protocols_plzserviceworker.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3983373
* build: update references to core_api_provider; its location was moved upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4006696
* build: remove back_to_tab_image_button from our enable_picture_in_picture deps
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4024078
back_to_tab_image_button has been removed upstream
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5433.0
* chore: sync patch w/upstream shear: chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4006638
* chore: sync patch w/trivial upstream shear: chromium/process_singleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4031817
* refactor: remove kAutofillCenterAlignedSuggestions feature flag check.
This behavior had been an experiment behind a feature flag. The
experiment was a success so the feature was kept & the flag was removed.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3870616
moves from disabled-by-default to enabled-by-default
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4030556
removed the feature flag
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5435.0
* chore: update patches
* chore: sync code with upstream change: AXLMode method name
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3950054
* 3841761: Adapting code to support kSystemProfileSelectionDefaultNone experiment
https://chromium-review.googlesource.com/c/chromium/src/+/3841761
* chore: bump chromium in DEPS to 110.0.5437.0
* 4040140: Pip 2.0: Merge VideoOverlayWindowViews and OverlayWindowViews
https://chromium-review.googlesource.com/c/chromium/src/+/4040140
* 4045567: Fix a crash opening a popup from tab capture fullscreen
https://chromium-review.googlesource.com/c/chromium/src/+/4045567
* chore: fixup patch indices
* 4048263: Remove deprecated Value calls in frame_tracker_unittest.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/4048263
* 4004606: [intl] Migrate to ICU 72
https://chromium-review.googlesource.com/c/v8/v8/+/4004606
* chore: bump chromium in DEPS to 110.0.5439.0
* 3890670: Prerender: Add first implementation of prerender-in-new-tab mode
https://chromium-review.googlesource.com/c/chromium/src/+/3890670
* chore: fixup patch indices
* chore: bump chromium in DEPS to 110.0.5441.0
* chore: update patches
* chore: bump chromium in DEPS to 110.0.5443.0
* 4035451: Remove remaining uses of ScopedNestableTaskAllower.
https://chromium-review.googlesource.com/c/chromium/src/+/4035451
* chore: bump chromium in DEPS to 110.0.5445.0
* chore: update patches
* fixup! 3890670: Prerender: Add first implementation of prerender-in-new-tab mode
* test: disable parallel/test-worker-init-failure
Refs https://chromium-review.googlesource.com/c/v8/v8/+/4017512
Refs https://github.com/nodejs/node-v8/issues/246
* chore: disable parallel/test-fetch
Test is flaky on Linux CI, but runs fine locally.
* chore: bump chromium in DEPS to 110.0.5451.0
* chore: update patches
* chore: cleanup patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-12-05 17:59:19 -05:00
StepSecurity Bot
2a26cef577
ci: pin action shas ( #36562 )
...
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
2022-12-05 12:11:10 -08:00
David Sanders
993d0337a7
docs: fix broken links ( #36519 )
...
* docs: fix broken links
* docs: change link to navigator.getUserMedia
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* docs: fix link in examples.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-12-05 13:18:57 -05:00
Shelley Vohr
b90a5baa6d
fix: new WebAssembly API support in Node.js ( #36420 )
2022-12-05 12:07:49 -05:00
Milan Burda
909ee0ed6b
refactor: make StatusIconType an enum class ( #36500 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-12-05 00:59:20 -08:00
John Kleinschmidt
79d2fc9c23
build: fixup mksnapshot args on linux ( #36531 )
2022-12-01 14:12:32 -05:00
Shelley Vohr
d092e6bda4
feat: expose window.invalidateShadow() ( #32452 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Darshan Sen <raisinten@gmail.com >
2022-12-01 10:24:44 -08:00
Keeley Hammond
35a7c07306
chore: update NMV for Electron 24 ( #36465 )
2022-11-30 22:10:36 -08:00
Milan Burda
eb291485bb
chore: drop support for Windows 7 / 8 / 8.1 ( #36427 )
...
* chore: drop support for Windows 7 & 8
* chore: remove disable-redraw-lock.patch
* chore: update patches
* Update docs/breaking-changes.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* fix breaking-changes.md
* chore: note last supported version
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: add link to deprecation policy
* Update docs/breaking-changes.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* update README.md
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-11-30 17:13:29 -08:00
Jeremy Rose
4ff0642af7
fix: treat maxWidth/Height<=0 as unlimited ( #36487 )
2022-11-30 17:02:22 -08:00
Jeremy Rose
835e248dff
docs: document outlivesOpener option in window open handler ( #36486 )
2022-11-30 15:20:19 -08:00
Jeremy Spiegel
665cf03f74
fix: handle Notification requireInteraction option ( #36477 )
2022-11-30 16:18:35 -05:00
Black-Hole
f527b8aa2a
refactor: improve accelerator check failed message ( #36476 )
2022-11-30 11:31:16 -08:00
Jeremy Rose
e3b7c3024f
docs: fix loadExtension example ( #36489 )
2022-11-30 11:29:02 -08:00
Keeley Hammond
9f007b9afb
chore: update NMV for Electron 23 ( #36464 )
2022-11-30 10:57:27 -08:00
George Xu
d5ce1387ce
docs: change pull request template to include mentions of templates and examples ( #36474 )
2022-11-29 22:22:09 -08:00
Michaela Laurencin
42ca25c338
docs: update E23 release dates ( #36475 )
2022-11-29 15:08:55 -08:00
Robo
2c723d7e84
fix: enable crashpad for ELECTRON_RUN_AS_NODE processes ( #36460 )
...
* wip: enable crashpad for node processes
fix: add PID testing method
wip: plumb fd into child_process in node
* node::ProcessInitializationFlags::kNoDefaultSignalHandling
* chore: clean up debug logging
* chore: gate platform includes
* test: clean up node process test
* fix: pass pid in node_main
* chore: cleanup impl
* chore: fixup patch method definition
* fix: expose bound methods to node_main
* fix: remove bound methods
* fix: crashpad connection for all ELECTRON_RUN_AS_NODE processes
* chore: fix typo
* chore: address review feedback
* chore: delay crashpad initialization
* chore: ensure options.env, code hygiene
* chore: add argv test, check for process.env over {}
* fix: fix test, return options.env immutability
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2022-11-29 10:33:54 -05:00
Cheng Zhao
16a7bd7102
fix: reimplement Tray with StatusIconLinuxDbus on Linux ( #36333 )
2022-11-28 11:36:25 -08:00
dependabot[bot]
bbb590b777
build(deps): bump minimatch from 3.0.4 to 3.0.8 ( #36418 )
...
Bumps [minimatch](https://github.com/isaacs/minimatch ) from 3.0.4 to 3.0.8.
- [Release notes](https://github.com/isaacs/minimatch/releases )
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.0.8 )
---
updated-dependencies:
- dependency-name: minimatch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-28 11:24:13 -08:00
Jeremy Rose
32583ac756
docs: add missing event-emitter link to utility-process docs ( #36428 )
...
add missing event-emitter link
2022-11-23 17:52:36 +09:00
John Kleinschmidt
679ce632a9
build: fixup appveyor image for release ( #36429 )
...
* build: make sure symstore is in the PATH when baking an image
* build: update to use fixed baked image
* cleanup sdk install
2022-11-22 16:57:49 -05:00
John Kleinschmidt
629c54ba36
feat: add support for WebUSB ( #36289 )
...
* feat: add support for WebUSB
* fixup for gn check
* fixup gn check on Windows
* Apply review feedback
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: address review feedback
* chore: removed unneeded code
* Migrate non-default ScopedObservation<> instantiations to ScopedObservationTraits<> in chrome/browser/
https://chromium-review.googlesource.com/c/chromium/src/+/4016595
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-11-22 16:50:32 -05:00
Samuel Attard
2751c2b07f
build: update devcontainer and use latest codespaces features ( #36422 )
...
* build: update devcontainer to latest build image
* build: add update-content-command
* build: set good vscode config
* build: be less noisy in update command
* build: only run sync in prebuild environment
* build: list env vars
* build: run sync always
2022-11-22 12:16:15 -08:00
electron-roller[bot]
c6d6af2551
chore: bump node to v18.12.1 (main) ( #36356 )
...
* chore: bump node in DEPS to v18.12.1
* chore: update patches
* chore: add missing <algorithm> include
* src: add detailed embedder process initialization AP
https://github.com/nodejs/node/pull/44121
* chore: update gn build files
* dns: support dns module in the snapshot
https://github.com/nodejs/node/pull/44633
https://github.com/electron/electron/issues/36118
* src: fix OOB reads in process.title getter
https://github.com/nodejs/node/pull/31633
* chore: fix incorrectly removed patch bit
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-11-21 10:55:01 -05:00
Keeley Hammond
b71cccb0d6
ci: bake appveyor images automatically, run sync on depshash change ( #35396 )
...
* chore: update yml formatting for parser
* ci: bake appveyor images automatically, run sync on depshash change
* chore: clean up .yml files
* chore: bump to e-110.0.5415.0
2022-11-21 10:24:26 -05:00
Samuel Attard
3a94634ae5
build: force ninja binary to the right arch after src cache restore ( #36401 )
2022-11-18 23:45:22 -08:00
hyrious
9c48992e21
chore: fix dangling promise in npm install ( #36379 )
...
* Fix dangling promise introduced in #33979
* fix reject in callback
* simplify code
Co-authored-by: Black-Hole <158blackhole@gmail.com >
Co-authored-by: Black-Hole <158blackhole@gmail.com >
2022-11-18 15:21:11 -08:00
John Kleinschmidt
7529ebfe0e
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args ( #36378 )
...
fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
2022-11-17 17:49:12 -05:00
dependabot[bot]
4f1f263a9a
build(deps): bump loader-utils from 1.4.1 to 1.4.2 in /spec ( #36375 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-17 17:48:48 -05:00
electron-roller[bot]
87c183df6a
chore: bump chromium to 110.0.5415.0 (main) ( #36186 )
...
* chore: bump chromium in DEPS to 109.0.5386.0
* chore: bump chromium in DEPS to 109.0.5388.0
* chore: bump chromium in DEPS to 109.0.5390.0
* chore: bump chromium in DEPS to 109.0.5392.0
* chore: bump chromium in DEPS to 109.0.5394.0
* chore: bump chromium in DEPS to 109.0.5396.0
* chore: bump chromium in DEPS to 109.0.5398.0
* chore: bump chromium in DEPS to 109.0.5400.0
* chore: update galactus
* chore: bump chromium in DEPS to 109.0.5402.0
* chore: bump chromium in DEPS to 109.0.5403.0
* chore: bump chromium in DEPS to 109.0.5406.0
* chore: update patches
* 4004247: Delete unused DocumentWebContentsDelegate
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4004247
* chore: bump chromium in DEPS to 109.0.5408.1
* chore: update patches
* 3949284: Support pkey debug mode without pkey 0 access
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3949284
* chore: bump chromium in DEPS to 109.0.5410.0
* chore: update patches
* 4000944: [Extensions] Create an API directory in //chrome/renderer/extensions
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4000944
* 3988524: Remove DocumentOverlayWindowViews | https://chromium-review.googlesource.com/c/chromium/src/+/3988524
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com >
* chore: bump chromium in DEPS to 109.0.5412.0
* chore: update patches
* 3984022: Add AddChildWindowToBrowser to DisplayClient mojo interface
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3984022
* 3957079: Delete the CryptoToken component extension and internal API
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3957079
* 4004421: Migreate ScopedAllowIO to ScopedAllowBlocking
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4004421
Co-authored-by: George Xu <georgexu99@users.noreply.github.com >
* chore: bump chromium in DEPS to 109.0.5414.0
* chore: update patches
* 4016180: Split PPAPI Mojo interfaces out of RenderFrameHostImpl.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4016180
* 3970838: [MPArch] Convert HostZoomMap and ZoomController off of RenderViewHost ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3970838
* 3997795: Don't add Chromium as a login item
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3997795
* 3993482: Remove RefCountedString::TakeString
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3993482
* 3990749: Allow forward-declared sources in base::ScopedObservation<>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3990749
* fixup! 3957079: Delete the CryptoToken component extension and internal API
* chore: bump chromium in DEPS to 110.0.5415.0
* 3883790: Move devtools_frame_token to the RenderFrameHost, to preserve RFH identity across MPArch activations.
https://chromium-review.googlesource.com/c/chromium/src/+/3883790
* 4022205: Move license tooling into //tools/licenses
https://chromium-review.googlesource.com/c/chromium/src/+/4022205
* chore: fixup patch indices
* fixup! 3957079: Delete the CryptoToken component extension and internal API
* 4008687: Finish ScopedAllowIO migration
https://chromium-review.googlesource.com/c/chromium/src/+/4008687
* 3991548: Move WindowButtonOrderObserver and WindowFrameAction to LinuxUi
https://chromium-review.googlesource.com/c/chromium/src/+/3991548
* fixup! 3984022: Add AddChildWindowToBrowser to DisplayClient mojo interface
* 4016595: Migrate non-default ScopedObservation<> instantiations to ScopedObservationTraits<> in chrome/browser/
https://chromium-review.googlesource.com/c/chromium/src/+/4016595
* 4000481: Rename :chromedriver to :chromedriver_server
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4000481
* 4008687: Finish ScopedAllowIO migration
https://chromium-review.googlesource.com/c/chromium/src/+/4008687
* 3988524: Remove DocumentOverlayWindowViews
https://chromium-review.googlesource.com/c/chromium/src/+/3988524
* fixup! 3997795: Don't add Chromium as a login item
* chore: fixup patches
* 3996872: Plumb input event task runner to EventFactoryEvdev
https://chromium-review.googlesource.com/c/chromium/src/+/3996872
* 4014994: Enable SiteIsolationForGuests by default.
https://chromium-review.googlesource.com/c/chromium/src/+/4014994
* chore: adopt new thread restrictions api for //electron (#36357 )
chore: add thread blocking api
* fixup! 4014994: Enable SiteIsolationForGuests by default.
* pull parent HWND for dialogs on ui thread
* chore: set parent_window in MessageBoxSettings
* chore: remove redundant patch
* chore: revert accidental deletion
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com >
Co-authored-by: George Xu <georgexu99@users.noreply.github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-17 14:59:23 -05:00
Step Security Bot
517225b99e
ci: add default action permissions ( #36363 )
...
* [StepSecurity] Apply security best practices
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
* Delete dependabot.yml
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-11-16 15:44:25 -05:00
Samuel Attard
bd345358f6
build: build mas and darwin simultaneously ( #36354 )
...
build: build mas on osx
2022-11-16 10:57:09 -08:00
Samuel Attard
9616dfb1f6
docs: update SECURITY.md with new GHSA reporting feature ( #36367 )
2022-11-15 20:02:01 -08:00
dependabot[bot]
41d393c076
build(deps): bump loader-utils from 1.4.1 to 1.4.2 ( #36365 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-15 17:31:16 -08:00
Samuel Attard
2cc24542f5
build: remove out cache ( #36355 )
2022-11-15 12:00:46 -05:00
Samuel Attard
d57d9f71df
build: make src cache smaller ( #36344 )
2022-11-15 00:30:07 -08:00
Tierney Cyren
f8aee0fbe7
docs: update README.md to use correct twitter handle ( #36345 )
...
doc: update README.md to use correct twitter handle
2022-11-14 22:23:37 -08:00
Step Security Bot
f9d1b9aded
ci: pin some more action versions ( #36343 )
...
* [StepSecurity] ci: Harden GitHub Actions
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
* Update electron_woa_testing.yml
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-11-14 18:39:13 -08:00
Jeremy Rose
9618a7227e
ci: pin amannn/action-semantic-pull-request ( #36341 )
2022-11-14 16:46:58 -08:00
Jeremy Rose
9f8308907b
ci: pin version of actions/checkout ( #36342 )
2022-11-14 16:46:45 -08:00
Joyce
05577d0903
chore: enable scorecard github action ( #35741 )
2022-11-14 16:22:10 -08:00
Samuel Attard
a9ef68f126
refactor: change defined(MAS_BUILD) to IS_MAS_BUILD() ( #36332 )
...
* refactor: change defined(MAS_BUILD) to IS_MAS_BUILD()
This is missing-definition safe and thus allows us to move the definition of this macro away from "all compilation targets" to "just the compilation targets that depend on this macro".
In turn this makes the rebuild time changing from mas <-> darwin only 80 seconds on my machine, instead of the 12-15 minutes it used to take. This will also allow us in the future to build both MAS and darwin on the same CI machine. Costing us ~2 minutes on one machine but saving us anywhere from 30 minutes to an hour of CI time on other parts of the matrix.
* build: always define IS_MAS_BUILD even on non-mac builds
* build: use extra_configs
2022-11-14 12:46:52 -08:00
Samuel Attard
d8bb172318
fix: abort ShipIt installation attempt at the final mile if the app is running ( #36130 )
...
* fix: abort ShipIt installation attempt at the final mile if the app is running
* chore: remove only
* Update patches/squirrel.mac/fix_abort_installation_attempt_at_the_final_mile_if_the_app_is.patch
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: update patches
* spec: make the ShipIt process lister helper more resilient
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-14 10:12:16 -08:00
Samuel Attard
654e571512
build: provide moduleVersion to docs-parser directly ( #36329 )
2022-11-14 10:04:36 -05:00
Erick Zhao
46a74d1086
docs: update tutorials for Forge 6 ( #36313 )
...
docs: update tutorial for Forge 6
2022-11-11 11:42:27 -08:00
Shelley Vohr
75d2caf451
chore: upgrade to Node.js v18 ( #35999 )
...
* chore: update to Node.js v18
* child_process: improve argument validation
https://github.com/nodejs/node/pull/41305
* bootstrap: support configure-time user-land snapshot
https://github.com/nodejs/node/pull/42466
* chore: update GN patch
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* src: use a typed array internally for process._exiting
https://github.com/nodejs/node/pull/43883
* chore: lib/internal/bootstrap -> lib/internal/process
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* chore: remove redudant browserGlobals patch
* chore: update BoringSSL patch
* src: allow embedder-provided PageAllocator in NodePlatform
https://github.com/nodejs/node/pull/38362
* chore: fixup Node.js crypto tests
- https://github.com/nodejs/node/pull/44171
- https://github.com/nodejs/node/pull/41600
* lib: add Promise methods to avoid-prototype-pollution lint rule
https://github.com/nodejs/node/pull/43849
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* src: add kNoBrowserGlobals flag for Environment
https://github.com/nodejs/node/pull/40532
* chore: consolidate asar initialization patches
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* deps: update V8 to 9.8
https://github.com/nodejs/node/pull/41610
* src,crypto: remove AllocatedBuffers from crypto_spkac
https://github.com/nodejs/node/pull/40752
* build: enable V8's shared read-only heap
https://github.com/nodejs/node/pull/42809
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
* chore: fixup ESM patch
* chore: fixup patch indices
* src: merge NativeModuleEnv into NativeModuleLoader
https://github.com/nodejs/node/pull/43824
* [API] Pass OOMDetails to OOMErrorCallback
https://chromium-review.googlesource.com/c/v8/v8/+/3647827
* src: iwyu in cleanup_queue.cc
* src: return Maybe from a couple of functions
https://github.com/nodejs/node/pull/39603
* src: clean up embedder API
https://github.com/nodejs/node/pull/35897
* src: refactor DH groups to delete crypto_groups.h
https://github.com/nodejs/node/pull/43896
* deps,src: use SIMD for normal base64 encoding
https://github.com/nodejs/node/pull/39775
* chore: remove deleted source file
* chore: update patches
* chore: remove deleted source file
* lib: add fetch
https://github.com/nodejs/node/pull/41749
* chore: remove nonexistent node specs
* test: split report OOM tests
https://github.com/nodejs/node/pull/44389
* src: trace fs async api
https://github.com/nodejs/node/pull/44057
* http: trace http request / response
https://github.com/nodejs/node/pull/44102
* test: split test-crypto-dh.js
https://github.com/nodejs/node/pull/40451
* crypto: introduce X509Certificate API
https://github.com/nodejs/node/pull/36804
* src: split property helpers from node::Environment
https://github.com/nodejs/node/pull/44056
* https://github.com/nodejs/node/pull/38905
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob
* lib,src: implement WebAssembly Web API
https://github.com/nodejs/node/pull/42701
* fixup! deps,src: use SIMD for normal base64 encoding
* fixup! src: refactor DH groups to delete crypto_groups.h
* chore: fixup base64 GN file
* fix: check that node::InitializeContext() returns true
* chore: delete _noBrowserGlobals usage
* chore: disable fetch in renderer procceses
* dns: default to verbatim=true in dns.lookup()
https://github.com/nodejs/node/pull/39987
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-11-10 22:31:20 +01:00
Shelley Vohr
1b1609aa0f
fix: app.dock.setIcon() crash before app ready ( #36279 )
...
fix: dock.setIcon() crash before app ready
2022-11-09 17:13:24 +01:00
Raymond Zhao
5fc3ed936e
feat: add app.getPreferredSystemLanguages() API ( #36035 )
...
* feat: add app.getSystemLanguage() API
* Change the API to getPreferredSystemLanguages
* Fix test
* Clarify docs and add Linux impl
* Remove USE_GLIB
* Don't add C to list
* Remove examples since there's a lot of edge cases
* Fix lint
* Add examples
* Fix compile error
* Apply PR feedback
* Update the example
2022-11-09 10:50:43 -05:00
dependabot[bot]
8f5959aad2
build(deps): bump loader-utils from 1.2.3 to 1.4.1 in /spec ( #36281 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.2.3 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-09 10:49:23 -05:00
Milan Burda
31a0bb7de2
chore: remove unsupported OS_FREEBSD flag check ( #36273 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-11-08 20:43:04 +01:00
dependabot[bot]
5c1186f624
build(deps): bump loader-utils from 1.2.3 to 1.4.1 ( #36276 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.2.3 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-08 11:27:59 +01:00
Jeremy Rose
184ac2b382
refactor: move draggable regions to WebContents ( #36230 )
2022-11-07 10:15:57 -08:00
John Kleinschmidt
2008c9a5d0
fix: arm linux glibc dependency ( #36247 )
2022-11-07 09:38:08 -05:00
David Sanders
0ba0df4523
docs: fix driverId -> deviceId typo ( #36246 )
2022-11-07 09:37:51 -05:00
Georgescu Gabriel
71b8804fd0
docs: Fixed outdated documentation (uploading to App Store) ( #35116 )
...
* Updated docs on uploading
- replaced mention of Application Loader with Apple Transporter, its replacement
- replaced mention of iTunes Connect with App Store Connect
- updated link for creating a record
* Update mac-app-store-submission-guide.md
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-11-01 17:07:50 -04:00
Brad Carter
15540975ff
feat: Add BrowserWindow option to hide window in Mission Control (macOS) ( #36092 )
...
* feat: Add BrowserWindow option to ignore Mission Control (macOS)
* There are many circumstances when app developers may want to hide their
windows from mission control. E.g., full screen overlays, small helper
windows, dialogs, etc.
* This PR adds the functionality, docs, and tests.
* chore:Rename variables
* Update shell/browser/native_window_mac.h
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-11-01 16:43:42 -04:00
Shelley Vohr
8b430c9d26
test: re-enable window.open referrer test ( #36155 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-11-01 11:11:11 -04:00
Milan Burda
2f2c43e5e5
build: fix building with enable_plugins = false ( #36193 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-10-31 16:18:15 -07:00
Shelley Vohr
169cf531ba
docs: add EOL dates to timeline doc ( #36187 )
2022-10-28 13:08:06 -07:00
Jeremy Rose
b9464d89b8
fix: remove undocumented feature and flaky test for webview resize event ( #36154 )
2022-10-27 16:44:53 -07:00
Keeley Hammond
67a0c702fa
build: prefix version in uploader script ( #36169 )
...
build: prefix v in uploader script
2022-10-27 12:02:18 -07:00
electron-roller[bot]
ea6f873f97
chore: bump chromium to 109.0.5382.0 (main) ( #36057 )
...
* chore: bump chromium in DEPS to 109.0.5364.0
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5366.0
* chore: update patches
* i3940364: Change PermissionType::WINDOW_PLACEMENT to WINDOW_MANAGEMENT
https://chromium-review.googlesource.com/c/chromium/src/+/3940364
* 3866812: Change content::PluginList to only run on the UI thread.
https://chromium-review.googlesource.com/c/chromium/src/+/3866812
* chore: bump chromium in DEPS to 109.0.5368.0
* [cleanup] Replace enable_basic_printing with enable_printing
https://chromium-review.googlesource.com/c/chromium/src/+/3957357
* chore: update patches
* 3956318: Desktop PWAs: Retire kWebAppWindowControlsOverlay flag
https://chromium-review.googlesource.com/c/chromium/src/+/3956318
* fixup! Change content::PluginList to only run on the UI thread.
(cherry picked from commit 7b5ec87d4f )
Co-Authored-By: Robo <hop2deep@gmail.com >
* chore: bump chromium in DEPS to 109.0.5370.0
* 3956299: Quota: Cleanup QuotaPermissionContext
https://chromium-review.googlesource.com/c/chromium/src/+/3956299
* chore: update patches
* 3803867: Add Mojo interface to parse XML for OOP printer capabilities
https://chromium-review.googlesource.com/c/chromium/src/+/3803867
* fixup: Add Mojo interface to parse XML for OOP printer capabilities
* chore: bump chromium in DEPS to 109.0.5372.0
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5374.0
* chore: bump chromium in DEPS to 109.0.5376.0
* chore: bump chromium in DEPS to 109.0.5378.0
* chore: update patches
* Quota: Cleanup kPersistent in BrowsingDataRemover
https://chromium-review.googlesource.com/c/chromium/src/+/3964859
* 3955976: serial: Create DOMException with V8ThrowDOMException
https://chromium-review.googlesource.com/c/chromium/src/+/3955976
* 3758405: Append trailer data to serialized messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3758405
* chore: revert clang roll
This patch reverts https://chromium-review.googlesource.com/c/chromium/src/+/3967491
because that roll breaks the WOA build: https://crbug.com/1377819
* chore: update patches
* chore: bump chromium in DEPS to 109.0.5380.0
* chore: update patches
* 3859750: [linux/wayland] Added plumbing for the state of tiled edges.
https://chromium-review.googlesource.com/c/chromium/src/+/3859750
Also 3970920: [linux/wayland] Fixed the tiled edges for the GTK frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3970920
* chore: bump chromium in DEPS to 109.0.5382.0
* chore: update patches
* chore: revert Use accessibility.pkey when setting page access.
https://chromium-review.googlesource.com/c/chromium/src/+/3949281
breaks our Linux builds run under Docker.
This patch should be removed once
https://chromium-review.googlesource.com/c/chromium/src/+/3949284
is merged.
* 3976312: Roll clang llvmorg-16-init-8189-g97196a2d-2 : llvmorg-16-init-8697-g60809cd2-1
https://chromium-review.googlesource.com/c/chromium/src/+/3976312
* 3967841: [heap] Remove AllocationSpace::MAP_SPACE enum constant
https://chromium-review.googlesource.com/c/v8/v8/+/3967841
* 3956131: [cleanup] Remove flag for Wasm threads & atomics
https://chromium-review.googlesource.com/c/v8/v8/+/3956131
* chore: update docs for Quota: Cleanup kPersistent in BrowsingDataRemover
https://chromium-review.googlesource.com/c/chromium/src/+/3964859
* test: fixup HID test for ARM CI
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2022-10-27 12:37:04 -04:00
Jeremy Rose
07530f8e37
test: fix flake in will-navigate test ( #36153 )
2022-10-27 09:29:19 -04:00
Robo
260678bd0c
docs: add utility process info to tutorial docs ( #36074 )
2022-10-27 20:55:28 +09:00
Shane Gannon
02ad8fcd5f
docs: correcting main example in WebRequest documentation ( #36113 )
...
Correcting main example
The entry `*://electron.github.io` is invalid and produces an exception. i.e.
> UnhandledPromiseRejectionWarning: TypeError: Invalid url pattern *://electron.github.io: Empty path.
Setting a valid path to resolve this issue
2022-10-27 16:18:07 +09:00
daief
ff4816367e
refactor: handle uncaught promise error ( #35484 )
2022-10-27 16:16:26 +09:00
Samuel Attard
ff3289d260
build: use npm@7 for npm view command
2022-10-26 18:31:20 -07:00
Samuel Attard
99a34d5209
build: strip v in the getElectronVersion helper
2022-10-26 17:56:30 -07:00
Jeremy Rose
625b4619d6
fix: resolve loadURL properly for in-page navigations ( #36129 )
2022-10-26 13:57:39 -07:00
Jeremy Rose
a75e8e051e
docs: document that when invoke rejects, it gives a different Error ( #36127 )
2022-10-26 13:56:41 -07:00
Samuel Attard
09302a2fc6
build: use python3 for appveyor commands ( #36131 )
2022-10-25 16:39:21 -07:00
Samuel Attard
b13f776d1b
build: ensure get-version runs in the electron git checkout ( #36128 )
2022-10-25 11:27:10 -07:00
Samuel Attard
7ca2bb5f9c
build: determine electron version from tags not files ( #36106 )
...
* build: determine electron version from tags not files
* build: make electron_version dependent on packed-refs and git HEAD
* build: do not delete electron/.git
* build: do not revert a commit we didn't make
* build: gen version file instead of just writing it
* build: update cache and ninja targets
* build: copy resource.h to generated electron.rc
* build: electron_win32_resources should be public deps
* build: also copy the icon
2022-10-24 23:44:43 -07:00
flynow10
ad289d120f
docs: fixed MenuItem documentation to use the same formatting for all role options ( #36112 )
...
Fixed MenuItem documentation
Some of the items in the list of possible roles were formatted differently, which made it harder to read.
Sorry if this was intended, but I found it easier to read with them all formatted the same.
2022-10-24 14:51:50 -04:00
Sudowoodo Release Bot
85b193178f
Bump v23.0.0-nightly.20221024
2022-10-24 06:01:28 -07:00
Sudowoodo Release Bot
3aed596fba
Bump v23.0.0-nightly.20221021
2022-10-21 06:01:08 -07:00
Shelley Vohr
3e730ab016
test: exit properly when node-spec-runner validates specs ( #36091 )
...
test: exit properly when node spec runner validates specs
2022-10-21 11:13:59 +02:00
John Kleinschmidt
0158077bec
test: disable flaky linux arm/arm64 crash test case ( #36094 )
...
test: disable failing linux arm/arm64 crash test case
2022-10-20 18:06:06 -04:00
Shelley Vohr
7921fec761
refactor: enable OOPIF printing to PDF ( #36051 )
2022-10-20 14:30:40 -04:00
Sudowoodo Release Bot
289bdbe4bc
Bump v23.0.0-nightly.20221020
2022-10-20 06:03:15 -07:00
Robo
da0fd286b4
feat: UtilityProcess API ( #34980 )
...
* chore: initial scaffolding
* chore: implement interface and docs
* chore: address code style review
* fix: cleanup of utility process on shutdown
* chore: simplify NodeBindings::CreateEnvironment
* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
* chore: implement process.parentPort
* chore(posix): implement stdio pipe interface
* chore(win): implement stdio interface
* chore: reenable SetNodeOptions for utility process
* chore: add specs
* chore: fix lint
* fix: update kill API
* fix: update process.parentPort API
* fix: exit event
* docs: update exit event
* fix: tests on linux
* chore: expand on some comments
* fix: shutdown of pipe reader
Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.
* fix: remove exit code check for crash spec
* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
* chore: fix incorrect rebase
* fix: address review feedback
* chore: rename utility_process -> utility
* chore: update docs
* chore: cleanup c++ implemantation
* fix: leak in NodeServiceHost impl
* chore: minor cleanup
* chore: cleanup JS implementation
* chore: flip default stdio to inherit
* fix: some api improvements
* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support
* fix: add tests for cwd and env option
* chore: alt impl for reading stdio handles
* chore: support message queuing
* chore: fix lint
* chore: new UtilityProcess => utilityProcess.fork
* fix: support for uncaught exception exits
* chore: remove process.execArgv as default
* fix: windows build
* fix: style changes
* fix: docs and style changes
* chore: update patches
* spec: disable flaky test on win32 arm CI
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-19 22:49:49 -07:00
Samuel Attard
44c40efecf
refactor: migrate from asar to @electron/asar ( #36070 )
...
* refactor: migrate from asar to @electron/asar
* fix: update asar require calls
2022-10-19 13:39:31 -07:00
Sudowoodo Release Bot
8bd66026a8
Bump v23.0.0-nightly.20221019
2022-10-19 06:02:29 -07:00
Yusoo
dde513b0d3
fix: printToPDF default margins ( #36060 )
...
printToPDF default margins
The document printToPDF has a 1cm margin and this default value has been added in the code.
2022-10-19 10:16:28 +02:00
Shelley Vohr
a8d89b3d52
fix: headless job tracking in printToPDF ( #36046 )
2022-10-18 15:46:19 +02:00
Sudowoodo Release Bot
b13606e55d
Bump v23.0.0-nightly.20221018
2022-10-18 06:01:30 -07:00
Shelley Vohr
4310468513
feat: support serialPort.forget() ( #35310 )
...
feat: enable serialPort.revoke()
2022-10-18 11:22:32 +02:00
Daniel Kocielinski
23d4a252c6
chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView ( #35007 )
...
* hore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView
The draggable regions implementation is related to WebView, so
InspectableWebContentsView is a more appropriate place to put it there.
Also, this refactoring will allow the subsequent extension of the
WebContentsView API, which will eventually replace BrowserView API.
* fix: Lint error
* fix: Adjusted owner-window
2022-10-17 11:10:07 -04:00
electron-roller[bot]
f2c341b655
chore: bump chromium to 108.0.5355.0 (main) ( #35900 )
...
* chore: bump chromium in DEPS to 108.0.5339.0
* chore: bump chromium in DEPS to 108.0.5341.0
* chore: sync patch to unrelated upstream code shear
patches/chromium/network_service_allow_remote_certificate_verification_logic.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3927793
* chore: sync patch to unrelated upstream code shear
patches/chromium/printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3927793
* chore: sync patch to unrelated upstream code shear
patches/chromium/chore_add_electron_deps_to_gitignores.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3906023
* chore: refresh patches - `e patches all`
* chore: remove unused parameter from WillCreateURLLoaderRequestInterceptors
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3932218
* perf: avoid unique pointer round trip
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3913938
* refactor: Simplify entropy provider management.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3901211
* fixup! perf: avoid unique pointer round trip
* fixup! perf: avoid unique pointer round trip
* refactor: update typeof FileSelectHelper::select_file_dialog_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3930092
* fixup! fixup! perf: avoid unique pointer round trip
* chore: bump chromium in DEPS to 108.0.5343.0
* chore: update patches
* chore: bump chromium in DEPS to 108.0.5345.0
* chore: bump chromium in DEPS to 108.0.5347.0
* chore: bump chromium in DEPS to 108.0.5349.0
* chore: bump chromium in DEPS to 108.0.5351.0
* chore: bump chromium in DEPS to 108.0.5353.0
* chore: bump chromium in DEPS to 108.0.5355.0
* chore: update patches
* Refactor display::win::DisplayInfo to display::win::internal::DisplayInfo
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3929014
* Update proxy resolution to use NAK - Part 2
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3934016
* Disable PreconnectManager when the user disabled preloading.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3928470
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3937183
* chore: update patches
* chore: update sysroot
* linux: Remove breakpad integration
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3764621
* chore: update comments
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2022-10-17 10:22:24 -04:00
Sudowoodo Release Bot
bcafe8f654
Bump v23.0.0-nightly.20221017
2022-10-17 06:01:25 -07:00
David Sanders
d8d5d4a4a1
docs: update VS Code debugger types to remove "pwa-" prefix ( #36042 )
2022-10-17 13:35:36 +02:00
Piroro-hs
295c5331ee
fix: override app's desktop name and v8 flags in default-app ( #35997 )
2022-10-17 10:34:24 +02:00
John Kleinschmidt
76880be6d2
test: re-enable <webview> tag DOM events emits resize event ( #36026 )
2022-10-17 14:57:44 +09:00
Shelley Vohr
e660fdf776
chore: remove useless Node.js V8 patch ( #36013 )
2022-10-17 14:57:31 +09:00
Sudowoodo Release Bot
dd757f4e22
Bump v23.0.0-nightly.20221014
2022-10-14 06:01:11 -07:00
Jeremy Rose
dc5d27a73b
docs: fix erroneous removal warning for decrementCapturerCount ( #36016 )
2022-10-13 11:40:25 -04:00
Raymond Zhao
ce138fe969
fix: Windows 7 frame showing for frameless non-resizable windows ( #35365 )
2022-10-13 11:39:40 -04:00
Sudowoodo Release Bot
79454dc50d
Bump v23.0.0-nightly.20221013
2022-10-13 07:17:26 -07:00
Sudowoodo Release Bot
8f09d6b47e
Revert "Bump v23.0.0-nightly.20221013"
...
This reverts commit 294f27900c .
2022-10-13 07:14:49 -07:00
John Kleinschmidt
b307314401
test: re-enable power monitor tests on arm64 ( #36015 )
...
test: re-enable powermonitor on arm64
2022-10-13 10:09:09 -04:00
Sudowoodo Release Bot
294f27900c
Bump v23.0.0-nightly.20221013
2022-10-13 06:01:22 -07:00
Jeremy Rose
8a926ffde4
refactor: use views NonClientHitTest for draggable regions on mac ( #35603 )
...
* refactor: use views NonClientHitTest for draggable regions on mac
* iwyu
* add backport of 9bb5f0316
* chore: update patches
* remove some unneeded functions
* remove test for triggering when BW is focused
* chore: update patches
* simplify views/mac split now that the draggable logic is the same
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix build
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-10-12 12:05:45 -04:00
Shelley Vohr
7ce94eb0b4
fix: disable nodeIntegrationInWorker for certain Worker types ( #35919 )
...
fix: disable nodeIntegrationInWorker for certain Worker types
2022-10-12 10:36:24 -04:00
Milan Burda
1328d8d670
docs: use webContents.mainFrame.on() in MessagePort tutorial ( #35824 )
...
* docs: use webContents.mainFrame.on() in MessagePort tutorial
* Update docs/tutorial/message-ports.md
Co-authored-by: Samuel Maddock <smaddock@salesforce.com >
Co-authored-by: Samuel Maddock <smaddock@salesforce.com >
2022-10-12 10:27:58 -04:00
Shelley Vohr
76afd8c028
test: more robust PDF specs ( #35979 )
2022-10-12 10:15:49 -04:00
Milan Burda
eb97ce1931
build: fix building with enable_ppapi = false ( #35988 )
2022-10-12 10:04:30 -04:00
Sudowoodo Release Bot
b6eadf2414
Bump v23.0.0-nightly.20221012
2022-10-12 06:01:34 -07:00
Milan Burda
8212616c76
chore: remove WebKit leftovers after it was renamed to Blink ( #35966 )
2022-10-11 20:01:57 -04:00
Shelley Vohr
ee7cf5a6d4
fix: webContents.printToPDF option plumbing ( #35975 )
...
fix: contents.printToPDF option plumbing
2022-10-11 16:06:34 -07:00
John Kleinschmidt
0759f3320e
docs: remove references to Widevine ( #35980 )
2022-10-11 16:06:13 -07:00
kyrylo-hrechykhin
c2cb97ea29
fix: on-screen-keyboard hides on input blurred in webview ( #35921 )
...
Co-authored-by: Kyrylo Hrechykhin <khrechykhin@microsoft.com >
2022-10-11 13:21:41 -04:00
Shelley Vohr
e8ae0571b8
test: remove redundant color diffing dependency ( #33215 )
2022-10-11 13:11:58 -04:00
Shelley Vohr
b3fd5eb258
fix: drag and drop should copy on macOS ( #35963 )
2022-10-11 18:19:59 +02:00
Sudowoodo Release Bot
9006f0e0c5
Bump v23.0.0-nightly.20221011
2022-10-11 06:00:46 -07:00
Darshan Sen
7493062555
test: add tests for valid electron module names ( #35931 )
...
* test: add tests for valid electron module names
https://github.com/electron/electron/pull/35915 landed without any
tests, so this change adds some. This also documents why these
variations exist.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* fixup! doc: rephrase comment
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* fixup! test: remove "Uncaught Error:" from error regex
Signed-off-by: Darshan Sen <raisinten@gmail.com >
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-10-11 15:59:23 +09:00
Sudowoodo Release Bot
e02de74ff2
Bump v23.0.0-nightly.20221010
2022-10-10 14:35:21 -07:00
Shelley Vohr
ebb866e63d
fix: override content::ContentMainDelegate::CreateContentClient() ( #35932 )
2022-10-10 16:48:44 +02:00
Sudowoodo Release Bot
ef00a2a1da
Revert "Bump v23.0.0-nightly.20221010"
...
This reverts commit 6072c4c71b .
2022-10-10 07:35:18 -07:00
Sudowoodo Release Bot
6072c4c71b
Bump v23.0.0-nightly.20221010
2022-10-10 06:01:40 -07:00
Samuel Attard
1fe21ff712
fix: expose the built-in electron module via the ESM loader ( #35930 )
2022-10-10 03:02:30 -07:00
David Sanders
a072f06168
docs: remove pywin32 mention in Windows build instructions ( #35940 )
2022-10-10 03:01:11 -07:00
Milan Burda
8bfbb251cc
fix: add missing #include "base/cxx17_backports.h" ( #35945 )
2022-10-10 03:00:56 -07:00
Sudowoodo Release Bot
3f4c4a4470
Bump v23.0.0-nightly.20221007
2022-10-07 06:01:54 -07:00
Sudowoodo Release Bot
5c784c2b1b
Bump v23.0.0-nightly.20221006
2022-10-06 06:01:26 -07:00
Samuel Attard
e1494ddc47
chore: cherry-pick c83640db21b5 from chromium ( #35924 )
...
* chore: cherry-pick c83640db21b5 from chromium
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-06 04:27:28 -07:00
Samuel Attard
e31c96a564
fix: only override valid electron module names ( #35915 )
...
Fixes #33014
2022-10-06 19:14:03 +09:00
Shelley Vohr
faafcc7f87
refactor: eliminate DecrementCapturerCount patch ( #35710 )
2022-10-05 19:51:33 +02:00
Shelley Vohr
a6b6816bec
build: clean up patch linting errors ( #35917 )
2022-10-05 10:34:53 -07:00
Sudowoodo Release Bot
f916ce2c49
Bump v23.0.0-nightly.20221005
2022-10-05 06:01:06 -07:00
Keeley Hammond
6196393c94
docs: update supported Mac versions ( #35911 )
2022-10-04 21:25:03 -07:00
Shmuel Leider
ff0517be3e
docs: update bluetooth fiddle example event name to trigger correct event ( #35894 )
...
* Fix event type spelling for bluetooth fiddle example
* docs: Fix event type spelling for bluetooth documentation fiddle example
2022-10-04 15:31:02 -04:00
Sudowoodo Release Bot
d8e037e426
Bump v23.0.0-nightly.20221004
2022-10-04 12:30:32 -07:00
Keeley Hammond
3bd85c8dc2
chore: update libcxx filenames ( #35904 )
...
* chore: update libcxx filenames
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-04 15:29:24 -04:00
Sudowoodo Release Bot
e63d4a6321
Revert "Bump v23.0.0-nightly.20221004"
...
This reverts commit 256d4678bb .
2022-10-04 08:16:47 -07:00
Sudowoodo Release Bot
256d4678bb
Bump v23.0.0-nightly.20221004
2022-10-04 06:00:58 -07:00
Samuel Attard
2cda1443fc
fix: ensure mas builds of the same application can use safestorage ( #35864 )
...
feat: ensure mas builds of the same application can use safestorage
This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account.
Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.
We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.
Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app.
2022-10-03 23:36:17 -07:00
Samuel Attard
12eade752d
build: move from stale GH app to stale action ( #35845 )
...
* build: move from stale GH app to stale action
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update .github/workflows/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-10-03 23:36:01 -07:00
Shelley Vohr
c76a931e20
fix: TryCatch scope in node_bindings ( #35850 )
...
fix: TryCatch scope in node_bindings
2022-10-03 23:35:20 -07:00
electron-roller[bot]
16f459228b
chore: bump chromium to 108.0.5329.0 (main) ( #35628 )
...
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-10-03 13:21:00 -07:00
Sudowoodo Release Bot
94955a7999
Bump v23.0.0-nightly.20221003
2022-10-03 06:01:17 -07:00
Sudowoodo Release Bot
29ca3d1467
Bump v23.0.0-nightly.20220930
2022-09-30 06:01:05 -07:00
Sudowoodo Release Bot
3f598ef1ed
Bump v23.0.0-nightly.20220929
2022-09-29 06:00:48 -07:00
Calvin
6a68afdb8a
docs: update breaking changes for v21 ( #35820 )
2022-09-28 09:47:25 -07:00
Sudowoodo Release Bot
fea844c3da
Bump v22.0.0-nightly.20220928
2022-09-28 06:01:05 -07:00
Jeremy Rose
f82a863f65
feat: replace scroll-touch* with generic input-event ( #35531 )
2022-09-27 12:47:46 -07:00
Shelley Vohr
dfb8a2d804
build: fix deps workflow tag comparison ( #35830 )
2022-09-27 12:24:11 -04:00
James Cash
998a0820d9
fix: set display_id in desktop capturer on Linux ( #33861 )
...
Previously, display_id was an empty string, pending Chrome support for
sharing individual screens. Now that this has been added, it is
desirable to have this property set correctly.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-27 11:40:44 -04:00
Sudowoodo Release Bot
621baa7bb7
Bump v22.0.0-nightly.20220927
2022-09-27 06:01:07 -07:00
Felix Rieseberg
74d59af3c5
fix: Handle an electron.d.ts file in a custom build ( #33979 )
...
* Handle an electron.d.ts file in a custom build
* Fix linter issues
Co-authored-by: Felix Rieseberg <felixr@stripe.com >
2022-09-26 14:39:26 -04:00
Samuel Maddock
c09c94fc98
feat: add WebContents.opener and webContents.fromFrame() ( #35140 )
...
* feat: add WebContents.opener
* feat: add webContents.fromFrame(frame)
* fix: unknown type name
* test: fix and add more fromFrame cases
* docs: clarified terminology
2022-09-26 12:37:08 -04:00
John Kleinschmidt
697a219bcb
feat: add support for Web Bluetooth pin pairing ( #35416 )
...
* feat: add bluetooth pairing handler
* Update docs/api/session.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update docs/api/session.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* docs: update based on review
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs per review
* chore: cleanup callback per review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2022-09-26 10:19:58 -04:00
Shelley Vohr
f8077cc004
build: fix major dependencies update workflow file ( #35811 )
2022-09-26 10:15:37 -04:00
Sudowoodo Release Bot
e0b4c485fe
Bump v22.0.0-nightly.20220926
2022-09-26 06:01:48 -07:00
David Sanders
a2ae308448
build: remove unused GitHub app config file ( #35797 )
2022-09-26 10:55:52 +02:00
Dominik Ilja
7d96321786
docs: minor grammar fixes in tutorial ( #35804 )
2022-09-26 10:53:08 +02:00
electron-roller[bot]
39d79c5c28
chore: bump node to v16.17.1 (main) ( #35800 )
...
* chore: bump node in DEPS to v16.17.1
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-09-26 10:12:52 +02:00
Milan Burda
f62aab76b3
fix: potential exception when calling webFrameMainBinding.fromIdOrNull() ( #35785 )
...
* fix: potential exception when calling webFrameMainBinding.fromIdOrNull()
* replace try/catch in getWebFrameForEvent
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-24 12:19:07 -07:00
Samuel Attard
324db14969
fix: set macOS crypto keychain name earlier ( #34683 )
...
* fix: set macOS crypto keychain name earlier
* spec: ensure arm64 mac tests are cleaned up
2022-09-23 12:32:10 -07:00
Raymond Zhao
8a0b4fa338
feat: add app.getSystemLocale() method ( #35697 )
...
* feat: add app.getSystemLocale() method
* Update shell/browser/electron_browser_main_parts.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Change methods to be const
* Apply PR feedback
* Fix mac compile
* Add missing scope
* Apply style changes
* Change note
* Add braces to get the comment indentation right
* Change to static
* Apply PR feedback
* Fix the documentation
* Remove extraneous file
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-09-23 11:50:46 -07:00
Keeley Hammond
626e248dea
chore: update NMV for Electron 22 ( #35772 )
2022-09-23 11:38:29 -07:00
Keeley Hammond
22d6102702
docs: update E22 release dates ( #35773 )
...
* doc: update E22 release dates
* chore: update 18.0.0 supported chart
2022-09-23 11:38:02 -07:00
Sudowoodo Release Bot
ad33a5f364
Bump v22.0.0-nightly.20220923
2022-09-23 06:02:20 -07:00
Cyril Chukwuebuka
d357218654
docs: changed event.data to data under the message.port in docs ( #35086 )
...
* docs: changed event.data to data under the message.port in docs
* docs: corrected BrowserWindow wrong usage and change window.messagePort to window.electronMessagePort
2022-09-23 01:07:53 -07:00
Samuel Attard
c69754b8e6
build: make patches owned by patch-owners (formed by upgrades + security) ( #35778 )
2022-09-22 14:15:40 -07:00
Aman Gupta
0df8878da4
docs: update the link for Introduction to Node.js ( #35761 )
...
Updated the link for Introduction to NodeJs
2022-09-22 09:46:11 -07:00
Sudowoodo Release Bot
4438731124
Bump v22.0.0-nightly.20220922
2022-09-22 06:01:15 -07:00
Shelley Vohr
eb3262cd87
fix: allow docking DevTools with WCO ( #35754 )
...
fix: allow for docking devtools with WCO
2022-09-22 10:44:27 +02:00
George Xu
4ffdd284c3
docs: add forge-overview.md ( #35473 )
...
* docs: move forge-specific docs to electronforge.io
* docs: add reference to forge icon tutorial
* docs: add references to forge-overview.md
* docs: add recommended
* docs: update forge-overview
* docs: apply code review comments
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-09-21 16:49:22 -04:00
Alexander Prinzhorn
9719cea250
docs: remove claim that HTTPS authenticates the remote server ( #35526 )
...
Update security.md
I don't think this is accurate. This is not a feature of HTTPS. This would require certificate pinning. It has been in the security docs since 2db125890c
Related
https://github.com/electron/electron/issues/3330
https://www.npmjs.com/package/electron-ssl-pinning
https://cheatsheetseries.owasp.org/cheatsheets/Pinning_Cheat_Sheet.html
2022-09-21 16:19:04 -04:00
Akshay Deo
dfc134de42
feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge ( #34974 )
...
* feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge
* Updates exposeInIslatedWorld worldId documentation
2022-09-21 13:17:10 -05:00
Sudowoodo Release Bot
8c3c0f0b50
Bump v22.0.0-nightly.20220921
2022-09-21 06:01:04 -07:00
xrkffgg
0783692809
ci: add blocked/needs-repro issues-helper ( #35605 )
2022-09-21 10:58:15 +02:00
matthewloft
4935fd2422
fix: WebAuthn Discoverable Credential (Resident Credential) ( #35374 )
...
* fix: WebAuthn Discoverable Credential (Resident Credential) #33353
Enables support for Webauthn discoverable credentials (aka resident
credentials). This allows users to authenticate without first having to
select or type a username.
To decide if discoverable credentials are supported, the class
'AuthenticatorCommon', in the chrome content code, indirectly calls the
method 'context::WebAuthenticationDelegate.SupportsResidentKeys(..)'.
The default implementation of this returns false, leaving it up to
specific implementations to override.
This change adds a new class 'ElectronWebAuthenticationDelegate' to
subclass 'WebAuthenticationDelegate' and override the behaviour of the
'SupportsResidentKeys' method to return true.
The implementation is copied from the Chrome browser equivalent
'ChromeWebAuthenticationDelegate', though the chrome class includes
other methods that don't seem to be required for this functionality.
The 'ElectronContentClient' class was also updated to store an instance
of 'ElectronWebAuthenticationDelegate', and to provide an accessor
method, GetWebAuthenticationDelegate().
* Remove redundant, commented-out code
* style: comment cleanup
* style: updated comments and formatting based on pull request review
* style: fix lint error on header guard clause
2022-09-20 15:47:42 -07:00
Milan Burda
99f4a42d41
chore: add missing .eslintrc.json files to limit imports properly ( #35719 )
2022-09-20 13:25:33 -05:00
Sebastian Vittersø
b1d7b30ca3
docs: fix wording mistake in security.md section 4 ( #35682 )
...
Update security.md
Under "4. Process Sandboxing", it said "For mor information on what `contextIsolation` is..." which was the previous section (copied from there). This updates it to say "For more information on what Process Sandboxing is..."
2022-09-20 11:14:44 -04:00
Sudowoodo Release Bot
d71b5e53fd
Bump v22.0.0-nightly.20220920
2022-09-20 06:01:49 -07:00
Bruno Pitrus
6cc69122ce
chore: fix ambiguous reference gcc compile error ( #35714 )
2022-09-19 17:05:24 -05:00
Kishan Bagaria
76ce6d5fb4
fix: edge case in app.isInApplicationsFolder() ( #35636 )
...
* fix: edge case in IsInApplicationsFolder
* use realpath instead
* lint
* revert lowercasing
* optimize
* Update shell/browser/ui/cocoa/electron_bundle_mover.mm
* lint
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-19 14:19:49 -04:00
Sudowoodo Release Bot
01cf5c5f99
Bump v22.0.0-nightly.20220919
2022-09-19 07:46:33 -07:00
Sudowoodo Release Bot
80bcea7e55
Revert "Bump v22.0.0-nightly.20220919"
...
This reverts commit 9aed5bcac5 .
2022-09-19 07:45:31 -07:00
Sudowoodo Release Bot
9aed5bcac5
Bump v22.0.0-nightly.20220919
2022-09-19 06:01:44 -07:00
Jeremy Rose
eebf34cc6c
feat: add webContents.close() ( #35509 )
...
* feat: add webContents.close()
* update docs, add test for beforeunload override
* Update web-contents.md
2022-09-16 16:22:59 -07:00
Sudowoodo Release Bot
994834d25a
Bump v22.0.0-nightly.20220916
2022-09-16 06:01:11 -07:00
Milan Burda
7d3f22dd32
fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) ( #35702 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-15 22:33:01 -07:00
Jeremy Rose
fa3cd17475
docs: reverse support matrix order ( #35699 )
2022-09-15 15:53:26 -07:00
Erik Marks
ee8a27492f
build: update .nvmrc Node.js version from 14 to 16 ( #35676 )
...
Update `.nvmrc` Node.js version from 14 to 16
The `DEPS` file states that Electron is on Node.js ^16.x. I am guessing that the PR bumping to Node.js 16 overlooked the `.nvmrc` file, which is updated in this PR. If leaving the `.nvmrc` file on 14 was intentional, please disregard this PR.
2022-09-15 15:40:18 -07:00
Samuel Attard
bd6612273b
build: add stale configuration ( #35698 )
...
* build: add stale configuration
* Update .github/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update stale.yml
* Update stale.yml
* Update .github/stale.yml
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-09-15 15:37:33 -07:00
Ryan Manuel
f25c87dc70
feat: allow custom v8 snapshots to be used in the main process and the default snapshot in the renderer process ( #35266 )
...
* Updates to allow for using a custom v8 snapshot file name
* Allow using a custom v8 snapshot file name
* Fix up patch due to merge
* Use fuse to set up custom v8 snapshot file in browser process
* Refactor to use delegate instead of command line parameter
* Refactoring
* Update due to merge
* PR comments
* Rename patch
* Rename patch
2022-09-15 13:21:16 -07:00
Milan Burda
5cf15cdab7
build: fix building with enable_basic_printing false ( #35687 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-09-15 19:29:10 +02:00
marekharanczyk
532162d2b5
fix: EventEmitter is missing properties in sandbox preload script. ( #35522 )
2022-09-15 09:33:08 -07:00
Sudowoodo Release Bot
30bdede09f
Bump v22.0.0-nightly.20220915
2022-09-15 06:02:38 -07:00
Shelley Vohr
38a7da692a
chore: make macOS spellchecker fns formal no-ops ( #35514 )
...
* chore: make macOS spellchecker fns formal no-ops
* docs: correct no-op note
* test: add no-op specs
2022-09-14 15:10:16 -07:00
Sudowoodo Release Bot
bf20aabb9e
Bump v22.0.0-nightly.20220914
2022-09-14 06:01:23 -07:00
Juan Cruz Viotti
3a3be23f0e
build: make check-symlinks.js aware of BRANDING.json changes ( #35579 )
...
Right now the `check-symlinks.js` assumes that the branding product name
is "Electron". If users change `BRANDING.json` on custom builds, the
script will fail.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2022-09-13 14:13:40 -07:00
Cheng Zhao
748c6af61e
docs: add back docs about asar archives ( #35563 )
2022-09-13 14:00:42 -07:00
Aryan Shridhar
f244e75927
docs: add IPC validation guideline link in checklist ( #35573 )
2022-09-13 13:56:41 -07:00
Shyamkumar Yadav
c847229a7e
docs: Markdown linting and typo ( #35568 )
...
* Fix reference definitions should be needed
* typo
* typo
* typo and style
* Fix reference definitions should be needed
* Fix typo
* restore to previous
2022-09-13 13:49:11 -07:00
Raymond Zhao
62502b8937
fix: allow maximizing when window enters tablet mode with WCO ( #35617 )
...
* fix: Backport CL 3753528 for WCO
* Update comment
* Update shell/browser/ui/views/win_caption_button_container.cc
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
2022-09-13 13:41:23 -07:00
Michaela Laurencin
12a7d7eea5
fix: remove extra dot in extension ( #35618 )
2022-09-13 11:47:04 -07:00
Jeremy Rose
9f97c3e50a
feat: expose content-bounds-updated event ( #35533 )
2022-09-13 10:49:34 -07:00
Leon Schwanitz
200153da8e
docs: fix typescript error in code samples ( #35641 )
...
Fixed typescript error
2022-09-13 09:38:06 -07:00
Sudowoodo Release Bot
71ba841f0a
Bump v22.0.0-nightly.20220913
2022-09-13 06:01:41 -07:00
Adrian Petrescu
ef463b39be
docs: Use inline image link in faq.md ( #35413 )
...
* Use absolute URL in faq.md image link
The relative link is rendered relative to the host domain, which works fine when viewing it on Github, but since you also use the same generated HTML in your doc site, the link is broken. See here: https://www.electronjs.org/docs/latest/faq#the-font-looks-blurry-what-is-this-and-what-can-i-do
Using an absolute URL here should fix the issue on the main site.
* Use inline image reference for subpixel rendering example
As suggested by @dsanders11
2022-09-12 16:09:12 -07:00
Benjamin Pasero
6ec4c7e563
docs: add performance advice to disable default menu creation ( #35525 )
2022-09-12 15:29:42 -07:00
Milan Burda
b3a744db8a
fix: potential "Object has been destroyed" error in BrowserWindow.getFocusedWindow ( #35520 )
2022-09-12 14:46:05 -07:00
Sudowoodo Release Bot
c14f52aeb7
Bump v22.0.0-nightly.20220912
2022-09-12 06:01:41 -07:00
Sudowoodo Release Bot
88dac9afc5
Bump v22.0.0-nightly.20220909
2022-09-09 06:00:50 -07:00
Jeremy Spiegel
730d9181b3
fix: ensure history navigations are sandboxed-iframe-aware ( #35420 )
2022-09-09 09:08:56 +09:00
electron-roller[bot]
b0036ea43a
chore: bump chromium to 107.0.5286.0 (main) ( #35590 )
...
* chore: bump chromium in DEPS to 107.0.5286.0
* 3866335: media: Rename KeySystemProperties to KeySystemInfo - file renaming
https://chromium-review.googlesource.com/c/chromium/src/+/3866335
* 3864686: [PA] Introduce *Scan buildflag
https://chromium-review.googlesource.com/c/chromium/src/+/3864686
* chore: fixup patch indices
* 3849359: Remove unused PrefValueStore::Delegate
https://chromium-review.googlesource.com/c/chromium/src/+/3849359
* 3873005: [CodeHealth] Modernising extensions Tab utils
https://chromium-review.googlesource.com/c/chromium/src/+/3873005
* 3846595: Auto-select PipeWire target once selection is made
https://chromium-review.googlesource.com/c/chromium/src/+/3846595
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
* fixup! Remove unused PrefValueStore::Delegate
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-09-08 16:23:08 -07:00
Jeremy Rose
a0dbae72c8
chore: remove UnresponsiveSuppressor altogether ( #35507 )
...
* chore: drop unresponsive suppressor for menu_mac
* also for views
* header
* chore: remove UnresponsiveSuppressor altogether
2022-09-08 15:49:33 -07:00
CanadaHonk
a0c20fef96
docs: fix misspelling in fuses ( #35609 )
2022-09-08 15:33:58 -07:00
Erick Zhao
34cb360730
docs: update sandbox renderer defaults for Electron 20 ( #35379 )
...
* docs: update E20 sandbox rendering defaults
* docs: update tutorial
* simplify paragraph
* dont mention context isolation
2022-09-08 13:21:50 -07:00
Raymond Zhao
4fb4167b8b
fix: Set background for WCO container ( #35569 )
...
* fix: Set background for WCO container
* Add background when invalidating as well
2022-09-08 22:11:51 +09:00
Sudowoodo Release Bot
17d5016163
Bump v22.0.0-nightly.20220908
2022-09-08 06:01:03 -07:00
Frank Pian
e3efa16415
fix: session.getBlobData never resolves with blob sizes > 65536 ( #35277 )
...
* fix: session.getBlobData never resolves with blob sizes > 65536 (#34398 )
* Add unit test case for session.getBlobData
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-09-07 17:47:06 -04:00
Kishan Bagaria
3a6d6ff008
docs: improve registerFileProtocol example ( #35580 )
...
* improve registerFileProtocol example
* link ProtocolResponse
* kick lint
2022-09-07 14:45:09 -04:00
John Kleinschmidt
ebd1c8358b
ci: make sure artifacts are saved for fork PRs ( #35593 )
2022-09-07 13:25:44 -04:00
Keeley Hammond
84c94c3ebb
chore: move dark mode activation to main_win.cc ( #35529 )
2022-09-07 09:39:35 -07:00
Samuel Attard
142eb89d5e
docs: add fuses and asar integrity docs ( #35528 )
2022-09-07 08:41:03 -07:00
Gregory R. Wroblewski
c16baa063a
docs: fix missing includes in code example ( #35479 )
2022-09-07 15:37:29 +02:00
dependabot[bot]
87145c393c
build(deps): bump ansi-regex from 4.1.0 to 4.1.1 ( #35541 )
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-07 15:34:15 +02:00
Jeremy Rose
7d89cb1bd4
chore: remove no-op force-paint for hidden windows ( #35532 )
...
* chore: remove no-op force-paint for hidden windows
* fix build
2022-09-07 11:48:59 +02:00
electron-roller[bot]
08ccc81574
chore: bump chromium to 107.0.5274.0 (main) ( #35375 )
...
* chore: bump chromium in DEPS to 106.0.5247.1
* chore: update can_create_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
* chore: update patches/chromium/printing.patch
Normal code shear.
* chore: update patches/chromium/add_contentgpuclient_precreatemessageloop_callback.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3764862
fix minor code shear that caused the patch to not apply
* chore: update patches/chromium/picture-in-picture.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3781646
Normal code shear.
* chore: update patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3792324
Normal code shear.
* chore: update patches/chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
Normal code shear.
* chore: update patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3798548
Normal code shear.
* chore: update patches/chromium/build_disable_print_content_analysis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3810473
Normal code shear.
* chore: short-circuit_permissions_checks_in_mediastreamdevicescontroller.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3807504
Normal code shear.
* chore: update patches
* chore: bump chromium in DEPS to 106.0.5249.0
* chore: bump chromium in DEPS to 107.0.5250.0
* chore: bump chromium in DEPS to 107.0.5252.0
* chore: bump chromium in DEPS to 107.0.5254.0
* chore: bump chromium in DEPS to 107.0.5256.1
* chore: update v8 patches
* chore: update chromium patches
* [CodeHealthRotation] base::Value::Dict (v2) migration for //c/b/ui/zoom
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3778239
* Add support for snapped window states for lacros
https://chromium-review.googlesource.com/c/chromium/src/+/3810538
* webui: Migrate /chrome/browser/ui/webui URLDataSources to GetMimeType(GURL)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774560
* Provide explicit template arguments to blink::AssociatedInterfaceRegistry::AddInterface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3773459
* Make WebScriptExecutionCallback base::OnceCallback
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/3676532
https://chromium-review.googlesource.com/c/chromium/src/+/3724623
https://chromium-review.googlesource.com/c/chromium/src/+/3675752
* Add implementation of reduce accept language service
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3687391
* Add PermissionResult in //content/public.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3807504
* [Extensions] Add new Webstore domain to extension URLs and clients
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3793043
* chore: update node patches
* chore: fix lint
* chore: update filenames.libcxx.gni
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* chore: bump chromium in DEPS to 107.0.5266.1
* chore: bump chromium in DEPS to 107.0.5268.0
* chore: bump chromium in DEPS to 107.0.5270.1
* chore: update patches
* 3848842: [DevTools] Added 'printing-in-progress' error code.
https://chromium-review.googlesource.com/c/chromium/src/+/38488
* 3855766: PA: Move the allocator shim files into partition_allocator/shim/ | https://chromium-review.googlesource.com/c/chromium/src/+/3855766
* Change gfx::Rect to blink::mojom::WindowFeatures in AddNewContents and some related functions.
https://chromium-review.googlesource.com/c/chromium/src/+/3835666
* Use base::FunctionRef for the various ForEachRenderFrameHost helpers.
https://chromium-review.googlesource.com/c/chromium/src/+/3767487
* [loader] Send cached metadata as part of OnReceiveResponse
https://chromium-review.googlesource.com/c/chromium/src/+/3811219
* 3832927: [json-schema-compiler] Support abs::optional<int>
https://chromium-review.googlesource.com/c/chromium/src/+/3832927
* Use unique_ptr for BrowserPluginGuestDelegate::CreateNewGuestWindow
https://chromium-review.googlesource.com/c/chromium/src/+/3847070
* 3847044: [Android] Dismiss select popup upon entering fullscreen
https://chromium-review.googlesource.com/c/chromium/src/+/3847044
* chore: update patches
* chore: add missing header
* Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3786946: cast pwrite64 arg to long to avoid compilation error on arm
https://chromium-review.googlesource.com/c/linux-syscall-support/+/3786946
* chore: update patches after rebase
* 3846114: float: Implement for lacros p2.
https://chromium-review.googlesource.com/c/chromium/src/+/3846114
* 3825237: Enable -Wunqualified-std-cast-call
https://chromium-review.googlesource.com/c/chromium/src/+/3825237
* chore: bump chromium in DEPS to 107.0.5272.0
* chore: update patches
* 3835746: Rename PepperPluginInfo to ContentPluginInfo
https://chromium-review.googlesource.com/c/chromium/src/+/3835746
* 3852542: Plumb drag-image rect from blink to browser to RenderWidgetHostImpl
https://chromium-review.googlesource.com/c/chromium/src/+/3852542
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
Also 3840687: [json-schema-compiler] Support abs::optional<double>
https://chromium-review.googlesource.com/c/chromium/src/+/3840687
* 3857319: Reland "Remove PrefService::Get"
https://chromium-review.googlesource.com/c/chromium/src/+/3857319
* 3854614: Rework LinuxUi ownership and creation
https://chromium-review.googlesource.com/c/chromium/src/+/3854614
* chore: bump chromium in DEPS to 107.0.5274.0
* 3866104: [DownloadBubble] Change download notifications in exclusive_access
https://chromium-review.googlesource.com/c/chromium/src/+/3866104
* chore: update patches
* chore: disable optimization guide for preconnect feature
* 3860569: Enable -Wshadow on Linux.
https://chromium-review.googlesource.com/c/chromium/src/+/3860569
* chore: update patches after rebase
* fixup: update to accomodate Wc++98-compat-extra-semi flag
* Revert "fixup! Make WebScriptExecutionCallback base::OnceCallback"
This reverts commit 0866fe8648671f04e4ea45ceed85db6e4a3b260b.
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* 3840937: [sandbox] Merge V8_SANDBOXED_POINTERS into V8_ENABLE_SANDBOX
https://chromium-review.googlesource.com/c/v8/v8/+/3840937
* fixup! chore: update can_create_window.patch
* chore: update patches
* 53946: Track SSL_ERROR_ZERO_RETURN explicitly.
https://boringssl-review.googlesource.com/c/boringssl/+/53946
* fixup: Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3805932: [headless] Added print compositor support for OOPIF printing.
https://chromium-review.googlesource.com/c/chromium/src/+/3805932
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-09-07 09:46:37 +02:00
Sudowoodo Release Bot
f53ca20d41
Bump v22.0.0-nightly.20220906
2022-09-06 07:21:50 -07:00
Sudowoodo Release Bot
e09a4a31ca
Revert "Bump v22.0.0-nightly.20220906"
...
This reverts commit bda094674f .
2022-09-06 06:55:15 -07:00
Sudowoodo Release Bot
bda094674f
Bump v22.0.0-nightly.20220906
2022-09-06 06:01:28 -07:00
Sudowoodo Release Bot
de206987fe
Bump v22.0.0-nightly.20220905
2022-09-05 06:01:13 -07:00
Shelley Vohr
2db0f7f8d4
fix: screen.getCursorScreenPoint() crash on Wayland ( #35503 )
...
fix: screen.getCursorScreenPoint() crash on Wayland
2022-09-05 10:10:50 +02:00
Sudowoodo Release Bot
98c0fa1c8b
Bump v22.0.0-nightly.20220902
2022-09-02 06:01:55 -07:00
Sudowoodo Release Bot
bfbe73396b
Bump v22.0.0-nightly.20220901
2022-09-01 06:00:49 -07:00
Jeremy Rose
6ad679f540
feat: webFrameMain.origin ( #35438 )
2022-08-31 17:40:57 -07:00
Jeremy Rose
a7248af79e
chore: remove unneeded SetBackgroundOpaque hack ( #35496 )
2022-08-31 17:40:26 -07:00
Jeremy Rose
f99122abfc
refactor: BrowserView is owned by a BaseWindow ( #35511 )
2022-08-31 17:40:02 -07:00
Jeremy Rose
9cdc8bf6ca
chore: drop unresponsive suppressor for menus ( #35498 )
2022-08-31 10:25:01 -07:00
Milan Burda
b7c5b48c38
test: move api-media-handler-spec from spec-main to spec ( #35518 )
2022-08-31 08:32:57 -07:00
Jeremy Rose
5fe1ac5c3d
refactor: simplify WebContents::Destroy ( #35510 )
2022-08-31 10:16:27 -05:00
Sudowoodo Release Bot
1830c0f6c3
Bump v22.0.0-nightly.20220831
2022-08-31 06:01:55 -07:00
Shelley Vohr
e0fb5cbe1f
fix: crash loading non-standard schemes in iframes ( #35485 )
2022-08-31 10:08:11 +02:00
Sudowoodo Release Bot
bfced8cbfe
Bump v22.0.0-nightly.20220830
2022-08-30 06:00:55 -07:00
Shelley Vohr
75f9573e53
fix: compensate for title bar height when setting bounds on BrowserView ( #34713 )
...
fix: compensate for title bar height when setting bounds
2022-08-29 17:53:03 +02:00
electron-roller[bot]
d0e220cbce
chore: bump node to v16.17.0 (main) ( #35350 )
...
* chore: bump node in DEPS to v16.17.0
* chore: fixup asar patch
* lib: use null-prototype objects for property descriptors
https://github.com/nodejs/node/pull/43270
* src: make SecureContext fields private
https://github.com/nodejs/node/pull/43173
* crypto: remove Node.js-specific webcrypto extensions
https://github.com/nodejs/node/pull/43310
* test: refactor to top-level await
https://github.com/nodejs/node/pull/43500
* deps: cherry-pick two libuv fixes
https://github.com/nodejs/node/pull/43950
* src: slim down env-inl.h
https://github.com/nodejs/node/pull/43745
* util: add AggregateError.prototype.errors to inspect output
https://github.com/nodejs/node/pull/43646
* esm: improve performance & tidy tests
https://github.com/nodejs/node/pull/43784
* src: NodeArrayBufferAllocator delegates to v8's allocator
https://github.com/nodejs/node/pull/43594
* chore: update patch indices
* chore: update filenames
* src: refactor IsSupportedAuthenticatedMode
https://github.com/nodejs/node/pull/42368
* src: add --openssl-legacy-provider option
https://github.com/nodejs/node/pull/40478
* lib,src: add source map support for global eval
https://github.com/nodejs/node/pull/43428
* trace_events: trace net connect event
https://github.com/nodejs/node/pull/43903
* deps: update ICU to 71.1
https://github.com/nodejs/node/pull/42655
This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
* lib: give names to promisified exists() and question()
https://github.com/nodejs/node/pull/43218
* crypto: add CFRG curves to Web Crypto API
https://github.com/nodejs/node/pull/42507
* src: fix memory leak for v8.serialize
https://github.com/nodejs/node/pull/42695
This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.
* buffer: fix atob input validation
https://github.com/nodejs/node/pull/42539
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-08-29 09:55:36 -04:00
Shelley Vohr
1847581848
fix: crash on WebWorker destruction ( #35422 )
2022-08-29 15:45:48 +02:00
Sudowoodo Release Bot
2f23bdb19e
Bump v22.0.0-nightly.20220829
2022-08-29 06:02:20 -07:00
Shelley Vohr
4744674e93
fix: crash when switching origins with emulation settings set ( #35466 )
2022-08-29 14:53:24 +02:00
Shelley Vohr
f6bbad287a
chore: use nghttp2's config.h on all platforms ( #35449 )
...
https://github.com/nodejs/node/pull/27283
2022-08-29 12:23:47 +02:00
Nik K
23264488c5
docs: update docs description to match sidebar ( #35144 )
...
Update introduction.md
2022-08-29 17:17:58 +09:00
Shelley Vohr
d829fb7ef2
chore: delete implicit fallthrough patch ( #35452 )
2022-08-26 13:21:33 +02:00
Samuel Attard
f65b05b8cc
fix: pass rfh instances through to the permission helper ( #35419 )
...
* fix: pass rfh instances through to the permission helper
* refactor: use WeakDocumentPtr instead of frame node id
* fix: handle missing initiator document
* fix: dispatch openExternal event for top level webview navs still
2022-08-26 12:31:33 +02:00
Shelley Vohr
8128fa6d85
build: fix missing patch config dir error ( #35451 )
2022-08-25 09:39:16 -07:00
Jeremy Rose
3eb593dfde
test: fix some broken globs for spec-main ( #35439 )
2022-08-25 09:36:08 -07:00
Sudowoodo Release Bot
3de7844212
Bump v22.0.0-nightly.20220825
2022-08-25 06:02:31 -07:00
Shelley Vohr
a3a9463024
fix: fullscreen crashing with roundedCorners: false ( #35421 )
2022-08-25 13:39:01 +02:00
Shelley Vohr
70d6cbfb44
chore: remove unused GuestViewContainer ( #35405 )
...
chore: remove unused GuestViewContainer
2022-08-25 15:56:47 +09:00
Shelley Vohr
22ff2b6b93
fix: Node.js atob input validation ( #35415 )
...
fix: Node.js atob input validation
2022-08-25 15:55:07 +09:00
Keeley Hammond
7e8607fd7a
ci: fix appveyor x64 tests ( #35406 )
...
* ci: fix appveyor x64 tests
* extract builtins-pgo to correct directory
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-08-25 10:11:44 +09:00
John Kleinschmidt
6f77e63804
ci: fixup doc-only-change on Windows ( #35431 )
2022-08-24 17:39:56 -04:00
John Kleinschmidt
07c3e62d68
build: fix export patches to work when source directory does not exist ( #35432 )
2022-08-24 17:37:11 -04:00
Sudowoodo Release Bot
e1459f4d50
Bump v22.0.0-nightly.20220824
2022-08-24 06:02:36 -07:00
Sudowoodo Release Bot
900ffede41
Bump v22.0.0-nightly.20220823
2022-08-23 06:01:36 -07:00
Michaela Laurencin
3ce35f224e
fix: add restore event for minimized maximization ( #35342 )
2022-08-23 10:32:42 +09:00
Raymond Zhao
0ff6508f5b
chore: apply chromium commit 30a32e6 ( #35370 )
...
chore: Apply Chromium commit 30a32e6
2022-08-23 10:31:23 +09:00
Robo
33325e3608
fix: undefined details.requestingUrl from session.setPermissionCheckHandler ( #35281 )
...
fix: undefined details.requestingUrl from setPermissionCheckHandler
2022-08-23 10:25:57 +09:00
Jeremy Rose
221bb51326
feat: session.setDisplayMediaRequestHandler ( #30702 )
2022-08-22 14:15:32 -07:00
Sudowoodo Release Bot
0c04be502c
Bump v22.0.0-nightly.20220822
2022-08-22 13:13:15 -07:00
Keeley Hammond
d6d86f8b16
build: update libcxx filenames ( #35397 )
...
* build: update libcxx filenames
* build: change upload_to_storage variable
2022-08-22 13:11:41 -07:00
Sudowoodo Release Bot
eca6029c0a
Revert "Bump v22.0.0-nightly.20220822"
...
This reverts commit fc2e6bd0ed .
2022-08-22 08:58:00 -07:00
Samuel Attard
9b2b1998b8
fix: ensure chrome colors are initialized ( #35034 )
...
* fix: ensure chrome colors are initialized
* build: fix linking on windows
* build: fix linking on windows
* build: add needed files to chromium_src/BUILD
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2022-08-22 16:38:45 +02:00
Sudowoodo Release Bot
fc2e6bd0ed
Bump v22.0.0-nightly.20220822
2022-08-22 06:02:41 -07:00
Robo
19baea4bc2
chore: update process singleton patch ( #35376 )
...
* chore: update process singleton patch
* fix: windows compilation error
* chore: remove outdated comment in patch
2022-08-20 07:45:58 +09:00
John Kleinschmidt
9b787d30f4
ci: use AppVeyor workflows ( #35377 )
...
* ci: use AppVeyor workflows
* fixup for skipping test on pr jobs
2022-08-19 13:10:16 -04:00
Sudowoodo Release Bot
748a739291
Revert "Bump v22.0.0-nightly.20220819"
...
This reverts commit b9bffb19ca .
2022-08-19 08:35:09 -07:00
Sudowoodo Release Bot
b9bffb19ca
Bump v22.0.0-nightly.20220819
2022-08-19 06:01:57 -07:00
Sudowoodo Release Bot
82f146e223
Revert "Bump v22.0.0-nightly.20220818"
...
This reverts commit 402553aeeb .
2022-08-18 08:56:57 -07:00
Sudowoodo Release Bot
402553aeeb
Bump v22.0.0-nightly.20220818
2022-08-18 06:01:56 -07:00
Jeremy Rose
1d6885c781
fix: don't bypass redirect checks ( #35357 )
2022-08-17 17:04:47 -07:00
electron-roller[bot]
97b353a30a
chore: bump chromium to 106.0.5216.0 (main) ( #34993 )
2022-08-17 11:35:53 -07:00
George Xu
e15e66f229
docs: add dependencies and troubleshooting section to build-instructions ( #35345 )
...
* docs: add dependencies and troubleshooting section to build-instructions
* docs: update certifi description
2022-08-17 10:54:49 -07:00
Sudowoodo Release Bot
532025c207
Bump v22.0.0-nightly.20220817
2022-08-17 06:05:24 -07:00
Robo
43182bf030
fix: promise support with webFrameMain.executeJavaScript ( #35292 )
...
* fix: promise support with webFrameMain.executeJavaScript
* chore: reject when result is an error
2022-08-17 13:08:13 +09:00
Bruno Pitrus
8e4a168a13
build: allow Linux distros to build against system shared libraries ( #34841 )
...
* build: allow Linux distros to build against system shared libraries
Add GN flags to build the embedded nodejs copy against system libraries
instead of vendored copies in `third_party/electron_node/deps`:
* cares
* llhttp
* nghttp2
* hdr_histogram
See also chromium's build/linux/unbundle/README for more
Electron-relevant information about vendored dependencies.
* Update patches/node/build_add_gn_build_files.patch
Co-authored-by: Darshan Sen <raisinten@gmail.com >
Co-authored-by: Darshan Sen <raisinten@gmail.com >
2022-08-16 22:50:15 -04:00
Raymond Zhao
947f1b0abf
fix: Frameless window shows frame while opening ( #35189 )
...
* fix: Frameless window shows frame while opening
* Clarify comments
* Inline setter
* Edit comment
2022-08-16 14:22:47 -07:00
Jeremy Rose
db7c92fd57
test: drop now-empty remote runner ( #35343 )
...
* test: drop the now-empty remote runner from CI
* move fixtures to spec-main
* remove remote runner
* fix stuff
* remove global-paths hack
* move ts-smoke to spec/
* fix test after merge
* rename spec-main to spec
* no need to ignore spec/node_modules twice
* simplify spec-runner a little
* no need to hash pj/yl twice
* undo lint change to verify-mksnapshot.py
* excessive ..
* update electron_woa_testing.yml
* don't search for test-results-remote.xml
it is never produced now
2022-08-16 15:23:13 -04:00
Sudowoodo Release Bot
e87c4015fe
Bump v22.0.0-nightly.20220816
2022-08-16 06:01:24 -07:00
Milan Burda
e85450b21a
fix: IPC emit order in -ipc-ports handler ( #35320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2022-08-16 11:21:56 +09:00
Shelley Vohr
672539187c
fix: serialPort.open() failing ( #35306 )
...
fix: serialPort.open() failing
2022-08-15 11:49:20 -04:00
Zuohui Yang
cbc1ee5775
fix: add uv_loop_close when object release to fix crash ( #35322 )
...
Co-authored-by: yangzuohui <yangzuohui@bytedance.com >
2022-08-15 10:40:52 -04:00
Sudowoodo Release Bot
9c2d89476c
Bump v22.0.0-nightly.20220815
2022-08-15 06:01:59 -07:00
Milan Burda
8424779906
refactor: don't expose deprecate as an internal module ( #35311 )
2022-08-15 17:09:33 +09:00
Jeremy Rose
81766707fc
test: migrate remaining webview specs to main ( #35213 )
...
* test: migrate remaining webview specs to main
* fix merge
* add dirty-chai
* retry capturePage()
* fix test
2022-08-15 17:06:02 +09:00
Rhitik Bhatt
4cb57ad1a0
docs: removes unused import in preload script ( #35324 )
...
* Remove unused import of path
This import gives out the error in the preload script:
Error: module not found: path
at preloadRequire
* Removes unused import in preload script
notes: Removes unused import which causes issue in preload script of drag and drop tutorial
* Remove import path as it is not used in the script
note: Removes import path as it is not used in the script
2022-08-15 15:23:59 +09:00
Charles Kerr
a8934d2302
docs: add Electron deps to license credits file ( #35283 )
...
* docs: add Electron deps to license credits file
* fixup! docs: add Electron deps to license credits file
remove nan; it is dev-only
2022-08-15 10:35:12 +09:00
Shelley Vohr
f1216ca593
refactor: simplify Browser::SetLoginItemSettings ( #35303 )
...
refactor: simplify Browser::SetLoginItemSettings
2022-08-15 09:44:23 +09:00
Sudowoodo Release Bot
ceabca850c
Bump v22.0.0-nightly.20220812
2022-08-12 06:01:44 -07:00
Keeley Hammond
81d95b53b3
build: bump @electron/get to 2.0.0, node to >= 12+ ( #35301 )
...
* infra: bump @electron/get to 2.0.0, node to >= 12+
* chore: empty commit to trigger CircleCI
2022-08-11 15:31:24 +02:00
Shelley Vohr
4d54cadb28
fix: WCO occlusion of DevTools ( #35209 )
2022-08-11 15:16:12 +02:00
Sudowoodo Release Bot
eab7ab2c47
Bump v22.0.0-nightly.20220811
2022-08-11 06:01:27 -07:00
Sudowoodo Release Bot
882cdb1f7a
Bump v22.0.0-nightly.20220810
2022-08-10 06:01:07 -07:00
Samuel Attard
1d95b98cc8
docs: fix getStoragePath return type ( #35288 )
...
Fixes #35255
2022-08-09 22:39:36 -07:00
Milan Burda
8646bf8d30
chore: remove deprecated 'new-window' event ( #34526 )
2022-08-09 17:57:05 -04:00
Trang Le
32fefb1f50
fix(docs): fix a typo in section on debugging with VSCode ( #35256 )
...
fix(docs): fix a typo
2022-08-09 15:01:38 -04:00
Sudowoodo Release Bot
6548808054
Bump v22.0.0-nightly.20220809
2022-08-09 06:01:28 -07:00
Jeremy Rose
faa2f7afa3
test: migrate asar specs to main runner ( #35230 )
...
* test: migrate node specs to main
* test: migrate asar specs to main runner
* fix execFile
2022-08-09 09:39:14 +02:00
Darshan Sen
f3dbdaaf33
build: fix error in the ts-compile-doc-change step ( #35258 )
...
build: fix error in the ts-compile-doc-change step
Fixes the following error: https://app.circleci.com/pipelines/github/electron/electron/56517/workflows/ea0f6548-e0ac-40c6-bacb-e24610cd6670/jobs/1287168?invite=true#step-103-29
```sh
$ webpack --config build/webpack/webpack.config.asar.js --output-filename=asar.js --output-path=./.tmp --env.mode=development
[webpack-cli] Error: Unknown option '--env.mode=development'
[webpack-cli] Run 'webpack --help' to see available commands and options
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
This probably started happening because of the recent webpack upgrade
in https://github.com/electron/electron/pull/34990 .
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-08-08 17:09:09 -04:00
Sudowoodo Release Bot
0400eb2e60
Bump v22.0.0-nightly.20220808
2022-08-08 06:02:50 -07:00
Aaron Meriwether
91f9436ad8
fix: app.relaunch loses args when execPath specified ( #35108 )
2022-08-08 10:12:06 +02:00
Milan Burda
34b985c556
refactor: use optional chaining / nullish coalescing operator ( #35217 )
2022-08-08 10:11:04 +02:00
John Kleinschmidt
76431ac1fa
test: temporarily disable tests on mas arm64 that are causing a crash ( #35226 )
...
* test: temporarily disable test on mas arm64 that is causing crash
* disable the right test
* chore: speculative fix for CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER crash
* enable all the tests
* Revert "chore: speculative fix for CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER crash"
This reverts commit b7c8ef364c .
* test: disable tests that crash on mas arm64
2022-08-06 19:02:04 -04:00
Shelley Vohr
a11cc3274f
build: fix webpack prod failure ( #35227 )
2022-08-05 09:21:00 -07:00
Sudowoodo Release Bot
a719568ac1
Revert "Bump v22.0.0-nightly.20220805"
...
This reverts commit fbcd8f8a6e .
2022-08-05 07:54:04 -07:00
Sudowoodo Release Bot
fbcd8f8a6e
Bump v22.0.0-nightly.20220805
2022-08-05 06:01:13 -07:00
Jeremy Rose
aaa60dc0bc
test: migrate remaining chromium specs to main ( #35216 )
2022-08-04 17:20:56 -07:00
Jeremy Rose
4cfdef0ffd
test: migrate node specs to main ( #35212 )
2022-08-04 17:20:17 -07:00
Erick Zhao
b9fea0d2d2
docs: remove reference to electron/i18n in README ( #35228 )
2022-08-04 15:18:06 -07:00
Sudowoodo Release Bot
1b2e5b4106
Revert "Bump v22.0.0-nightly.20220804"
...
This reverts commit 47a08f9570 .
2022-08-04 08:27:56 -07:00
Sudowoodo Release Bot
47a08f9570
Bump v22.0.0-nightly.20220804
2022-08-04 06:00:52 -07:00
Brad Carter
21117ea5b2
docs: update tray docs with info for mac menubar icons ( #35136 )
2022-08-04 11:24:32 +02:00
Jeremy Rose
6d859dcd7f
feat: add WebContents.ipc ( #34959 )
2022-08-03 16:55:12 -07:00
Jeremy Rose
bba22ae720
test: migrate <webview> tag event specs to main runner ( #35077 )
2022-08-03 12:03:44 -07:00
Jeremy Rose
d15348ecc2
test: migrate webview attribute specs to spec-main ( #35076 )
2022-08-03 09:59:00 -07:00
Shelley Vohr
3baf713648
build: upgrade webpack and related deps ( #34990 )
2022-08-03 10:42:50 -04:00
Sudowoodo Release Bot
2b96d06960
Revert "Bump v21.0.0-nightly.20220803"
...
This reverts commit 4e919c919c .
2022-08-03 07:36:56 -07:00
TAN
c47031a279
docs: Fix the URL bugs at tutorial-6-publishing-updating.md ( #35175 )
...
* Update tutorial-6-publishing-updating.md
The dot at the end of the URL will depend on the site that cannot open. Because it will open `https://update.electronjs.org./ ` which does not exist.
* docs: fix the URL problems at tutorial-6-publishing-updating.md
The dot at the end of the URL will depend on the site that cannot open. Because it will open `https://update.electronjs.org./ ` which does not exist.
* docs: fix the URL problems at tutorial-6-publishing-updating.md
* docs: fix the URL problems at tutorial-6-publishing-updating.md
2022-08-03 10:20:37 -04:00
Erick Zhao
74432a313c
docs: fix link in tutorial ( #35192 )
...
Relands https://github.com/electron/electronjs.org-new/pull/240 upstream
2022-08-03 10:12:06 -04:00
Sudowoodo Release Bot
4e919c919c
Bump v21.0.0-nightly.20220803
2022-08-03 06:01:39 -07:00
Maya Nedeljković Batić
fb39f241fb
docs: update categories to match sidebar ( #35196 )
...
This page describes each of the categories available in the sidebar, but some of the category titles didn't match.
2022-08-03 12:03:45 +02:00
Cheng Zhao
afa4f5052b
fix: consider dock space when showing menu ( #35194 )
2022-08-03 17:52:42 +09:00
msizanoen1
7b8fb2b074
fix: Wayland general CSD fixes ( #34955 )
...
* fix: broken wayland window decorations due to botched chromium update
The `GetTitlebarBounds().height()` is obviously intended to be placed in
the `top` parameter, which used to be the second one before upstream
removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter
for `gfx::Insets::TLBR`, which was intended to replace the removed
`Inset` function. However, whoever updated Chromium kept the parameter
unchanged, causing the title bar height to be passed to the `left`
parameter, causing the window title bar to be unclickable.
* fix: wayland window top bar buttons unclickable
Use NonClientFrameView::TargetForRect for the ClientFrameViewLinux
implementation because the default inherited from FramelessView blocks
any non-HTCLIENT events.
* fix: add maximized parameter to LinuxUI::GetWindowFrameProvider
* fix: pass frame_->IsMaximized() to GetWindowFrameProvider
This ensures that the toolkit renders the window decorations in maximized mode
while the window is maximized to ensure that there is no empty space around the window.
2022-08-03 17:51:52 +09:00
Cheng Zhao
4e8480b15b
chore: fix linking with component ffmpeg ( #35178 )
2022-08-03 16:51:30 +09:00
Keeley Hammond
3fe00d75e9
chore: update NMV for Electron 21 ( #35124 )
2022-08-02 12:57:42 -07:00
Jeremy Rose
3d4d1b33ba
fix: fail non-fatally when InitLogging fails ( #35138 )
2022-08-02 15:45:30 -04:00
Robo
53cd23159e
chore: remove unsupported skiptaskbar linux impl ( #35179 )
...
chore: unsupported skiptaskbar linux impl
2022-08-02 11:53:36 -07:00
Sudowoodo Release Bot
31be6ecf7b
Bump v21.0.0-nightly.20220802
2022-08-02 06:01:38 -07:00
Robo
e3893632e7
fix: touch events not recognized by WCO on windows ( #35117 )
2022-08-02 12:13:58 +09:00
Michaela Laurencin
0cdc946b27
fix: modify file extension generation on Windows ( #34723 )
...
* fix: modify file extension generation on Windows
* modify includes
* include vector in header
* add win build flags
* remove hardcoded strings
* Update shell/browser/electron_download_manager_delegate.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix string manipulation and function definitions
* Update electron_download_manager_delegate.h
* convert to std::string and modify for electron
* Update shell/browser/electron_download_manager_delegate.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* remove vector include and update conversion
* add vectr include for lint
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-08-02 09:40:17 +09:00
John Kleinschmidt
0d36c0cdc6
ci: turn off windows on arm test result comments ( #35142 )
2022-08-01 18:59:20 -04:00
Shelley Vohr
7588bb7425
fix: DCHECK entering fullscreen while loading url ( #35111 )
...
* fix: DCHECK entering fullscreen while loading url
* spec: fixup test
2022-08-01 16:52:58 -04:00
Keeley Hammond
6c17dd2296
fix: ensure native modules use the correct config ( #35159 )
...
* fix: ensure native modules are built with config.gypi
This works by patching node.h to check that two defines are set using the equivilant of an XNOR operation. One define "ELECTRON_ENSURE_CONFIG_GYPI" is set via common.gypi which is _already_ used to build native modules and has been since the dawn of time. Therefore this define will be set for all native module compilations targetting the Electron runtime. The second define "USING_ELECTRON_CONFIG_GYPI" is only defined when the gypi argument "using_electron_config_gypi" is set to 1 which is only done so via config.gypi. Only new enough versions of node-gyp correctly use the config.gypi file thus resulting in a compilation error on version of node-gyp that are too old.
* chore: fix lint
Co-authored-by: Samuel Attard <sattard@salesforce.com >
2022-08-01 07:52:26 -07:00
Sudowoodo Release Bot
29434ee7c6
Bump v21.0.0-nightly.20220801
2022-08-01 06:01:38 -07:00
Charles Kerr
b67c69d741
fix: remove skip-taskbar feature on Linux. ( #35123 )
2022-08-01 12:42:02 +02:00
Kilian Valkhof
00e9bf107a
docs: new main -> renderers messageChannel example ( #34978 )
...
* docs: new main -> renderers messageChannel example
* consistent use of your
* fix a typo
* linting
* markdown linting
* Update docs/tutorial/message-ports.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* update code example headings, reference contextIsolation example
* remove nodeIntegration: false from browserWindows
* rename "messagePort" to "electronMessagePort" for compatibility
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2022-07-29 09:47:43 -07:00
Shelley Vohr
9028bb79a8
fix: empty result of webContents.getUserAgent() ( #35069 )
...
fix: empty result of webContents.getUserAgent()
2022-07-29 11:09:47 -04:00
Sudowoodo Release Bot
8004cb8722
Bump v21.0.0-nightly.20220729
2022-07-29 06:00:43 -07:00
Sofia Nguy
7f757075bc
docs: update E21 release date ( #35122 )
...
* docs: update E21 release date
* chore: fix lint
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2022-07-28 21:54:48 -07:00
John Kleinschmidt
674596d11e
ci: switch to GHA for WOA ( #35109 )
...
* ci: switch to GHA for WOA
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-07-28 19:05:59 -04:00
Sudowoodo Release Bot
3c2ec2280e
Bump v21.0.0-nightly.20220728
2022-07-28 06:03:11 -07:00
Jeremy Rose
de1cec8693
test: migrate shell specs to main process ( #35058 )
2022-07-27 09:18:33 -07:00
Sudowoodo Release Bot
99c2706376
Bump v21.0.0-nightly.20220727
2022-07-27 06:01:22 -07:00
Stuart Schechter
63593ffb22
docs: don't wait for ready event to register open-url listener ( #35019 )
...
* Update app.md
Add warning about late registration of the open-url event.
* Update app.md
2022-07-27 14:00:35 +02:00
Samuel Attard
b0c6fb5152
chore: add electon deps to //src gitignore ( #35065 )
2022-07-27 13:15:34 +02:00
Jeremy Rose
77b4aab720
test: migrate the rest of the webFrame tests to main ( #35080 )
2022-07-27 11:10:14 +02:00
Jeremy Rose
7c2ed98214
test: migrate more chromium specs to main ( #35081 )
2022-07-27 11:10:04 +02:00
Charles Kerr
62001dc6cb
fix: crash on startup in X11 ( #35075 )
...
Fixes #34996 .
2022-07-27 13:44:44 +09:00
Keeley Hammond
ff804e3a74
fix: use win_clang_x64 binary for x86 extract symbols ( #35078 )
...
fix: use win_clang_x64 for x86 extract symbols
2022-07-27 13:33:07 +09:00
Ian German Mesner
9416091180
fix: allow setsize to be called within a move or resize for preventDefault ( #34843 )
...
fix : #34599 allow setsize to be called within a move or resize for preventDefault
2022-07-27 09:02:06 +09:00
Jeremy Rose
6d9e8b65bc
test: add process module tests for main process ( #35057 )
2022-07-26 15:42:50 -07:00
Shelley Vohr
b42fd1ddca
fix: handle WCO pressed state when going maximized -> minimized ( #35070 )
2022-07-26 13:30:15 -04:00
John Kleinschmidt
182ab9ad76
test: remove duplicate test that is causing hang in Windows ( #35071 )
2022-07-26 13:28:59 -04:00
Jeremy Rose
77e1a046ec
test: move chromium spec config to its own folder ( #35063 )
2022-07-26 09:37:11 -07:00
Devin Foley
0be73d18ef
fix: Make disable_color_correct_rendering patch work again ( #35050 )
...
Fix disable_color_correct_rendering patch.
2022-07-26 09:35:10 -07:00
Jeremy Rose
c842f63383
test: migrate process module specs to spec-main ( #35056 )
2022-07-26 09:31:26 -07:00
Sudowoodo Release Bot
6674082041
Bump v21.0.0-nightly.20220726
2022-07-26 06:01:07 -07:00
Jeremy Rose
cabfb8507d
test: remove references to robotjs ( #35064 )
2022-07-26 01:12:04 -07:00
Jeremy Rose
aa40652456
test: remove unused spec/expect-helpers ( #35055 )
2022-07-26 09:57:12 +02:00
Jeremy Rose
dd68fae081
test: migrate nativeImage specs to main ( #35062 )
...
* test: move nativeImage specs to main
* simplify test
2022-07-26 09:57:01 +02:00
Jeremy Rose
ad1bbc198b
test: migrate clipboard spec to spec-main ( #35059 )
2022-07-26 09:37:37 +02:00
electron-roller[bot]
2c51a81e85
chore: bump node to v16.16.0 (main) ( #34853 )
...
* chore: bump node in DEPS to v16.16.0
* chore: update patches
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-25 17:06:52 -04:00
John Kleinschmidt
648c9934c0
fix: properly fire serial-port-added and serial-port-removed events ( #34958 )
...
Based on 2309652: [webhid] Notify chooser context observers on shutdown | https://chromium-review.googlesource.com/c/chromium/src/+/2309652
2022-07-25 10:50:19 -04:00
Sudowoodo Release Bot
aeba6ca973
Bump v21.0.0-nightly.20220725
2022-07-25 06:01:47 -07:00
Mike Lee
49302e4a2f
docs: Add missing link to tutorial page ( #35035 )
...
Add missing link to tutorial page
2022-07-25 11:22:06 +02:00
Shelley Vohr
57c265198e
refactor: use Get/SetID from views:View in Button ( #35022 )
2022-07-25 09:46:14 +02:00
Keeley Hammond
08dd38d9be
docs: update build dependencies for Fedora ( #35024 )
2022-07-25 15:25:42 +09:00
Sudowoodo Release Bot
dd82a26e95
Bump v21.0.0-nightly.20220722
2022-07-22 06:01:06 -07:00
Jeremy Rose
3c63f075bd
chore: remove unused WebContents._sendToFrameInternal ( #35010 )
2022-07-21 10:25:54 -07:00
Sudowoodo Release Bot
fec4cca8d4
Bump v21.0.0-nightly.20220721
2022-07-21 06:01:19 -07:00
Shelley Vohr
1ed191114a
fix: clean up callback handling in webContents.print() ( #34894 )
...
* refactor: clean up callback handling in webContents.print()
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-21 12:46:15 +02:00
Milan Burda
d4e97483aa
refactor: only create webContents after 'will-attach-webview' ( #32941 )
2022-07-21 11:29:31 +02:00
dependabot[bot]
7ae3025fd5
build(deps): bump terser from 4.6.7 to 4.8.1 ( #34987 )
...
Bumps [terser](https://github.com/terser/terser ) from 4.6.7 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/commits )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-21 11:15:00 +02:00
Valentin Hăloiu
67eda4bcc8
fix: add support for --ozone-platform-hint flag on Linux ( #34937 )
2022-07-21 10:37:54 +02:00
Sudowoodo Release Bot
9f0e7126c4
Bump v21.0.0-nightly.20220720
2022-07-20 08:02:19 -07:00
Keeley Hammond
be7f90481d
build: update mediastreamdevicescontroller.patch ( #34995 )
2022-07-20 08:00:31 -07:00
Sudowoodo Release Bot
6dc1218c37
Revert "Bump v21.0.0-nightly.20220720"
...
This reverts commit cffcd0d47a .
2022-07-20 07:14:04 -07:00
Sudowoodo Release Bot
cffcd0d47a
Bump v21.0.0-nightly.20220720
2022-07-20 06:01:09 -07:00
electron-roller[bot]
9e0a3c44dd
chore: bump chromium to 105.0.5187.0 (main) ( #34921 )
...
* chore: bump chromium in DEPS to 105.0.5179.0
* chore: update patches
* 3758224: Reland^2 "[flags] Enable freezing of flags"
https://chromium-review.googlesource.com/c/v8/v8/+/3758224
* chore: bump chromium in DEPS to 105.0.5181.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5183.0
* chore: bump chromium in DEPS to 105.0.5185.0
* chore: bump chromium in DEPS to 105.0.5187.0
* chore: update patches
* 3723298: Pass RemoteFrame mojo channels through its creation messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3723298
* 3737382: [Code Heath] Replace base::{ListValue,DictionaryValue} in skia et al
https://chromium-review.googlesource.com/c/chromium/src/+/3737382
* Pass RemoteFrame mojo channels through its creation messages.
https://chromium-review.googlesource.com/c/chromium/src/+/3723298
* Changed PrintRenderFrame.PrintWithParams mojo interface to use callback.
https://chromium-review.googlesource.com/c/chromium/src/+/3761203
* 3738183: [CSP] Add support for `DisableWasmEval`
https://chromium-review.googlesource.com/c/chromium/src/+/3738183
* 3740498: Move LinuxUI from //ui/views/linux_ui to //ui/linux
https://chromium-review.googlesource.com/c/chromium/src/+/3740498
* 3558277: Moves subsystem and semantics to enum class
https://chromium-review.googlesource.com/c/chromium/src/+/3558277
* chore: fix broken steps-electron-gn-check
* 3749583: [arm64] Fix undefined symbol linker error
https://chromium-review.googlesource.com/c/v8/v8/+/3749583
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-07-20 13:03:34 +02:00
Shelley Vohr
1b96a3aa1d
build: consolidate gn templates ( #34918 )
2022-07-20 11:14:54 +02:00
Jeremy Rose
3c7d446fad
refactor: unduplicate MediaStreamDevicesController ( #34895 )
...
* refactor: unduplicate MediaStreamDevicesController
* restore old logic for GUM_* request types
* lint
* gn format
* add test for unsupported getDisplayMedia
* simplify + comment
2022-07-20 17:09:14 +09:00
Alexander Petrov
60b6e74e3f
fix: merge crash annotations instead of overwriting ( #34795 )
...
ElectronCrashReporterClient::GetProcessSimpleAnnotations() merges
annotations provided as argument with global_annotations_,
preserving useful information.
2022-07-19 09:18:04 -07:00
Sudowoodo Release Bot
ba25714e16
Bump v21.0.0-nightly.20220719
2022-07-19 06:01:27 -07:00
Shelley Vohr
05d4966251
fix: delegate to PrintViewManagerBase on failed print ( #34893 )
...
fix: delegate to PrintViewManagerBase on failed print
2022-07-19 14:46:08 +02:00
Shelley Vohr
eb8c9452cb
fix: crash on BrowserWindow.setEnabled() ( #34904 )
...
fix: crash on BrowserWindow.setEnabled()
2022-07-19 12:31:49 +02:00
Shelley Vohr
38848c5bf7
test: optionally validate disabled Node.js specs ( #34899 )
2022-07-19 12:14:21 +02:00
Shelley Vohr
57b02e153d
fix: potential hang on print settings failure ( #34892 )
2022-07-19 11:45:10 +02:00
John Kleinschmidt
8a0df1f487
ci: wait longer for goma to be ready ( #34956 )
2022-07-19 10:20:16 +02:00
Sudowoodo Release Bot
c4cde78818
Bump v21.0.0-nightly.20220718
2022-07-18 06:01:46 -07:00
Samuel Attard
f1746c81c6
fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules ( #34932 )
...
This define is only needed when linking against Chromiums libc++ which we currently
do not ship / expose the symbols of. We probably should make those symbols visible and
actually ensure that electron-rebuild et. al link against our libc++ instead of the system libc++
but for now this fixes compilation issues on macOS where the default system clang links to the system libc++
which does not (obviously) use the Chromium ABI namespace.
For our nan tests which do link against Chromiums libc++ we define the ABI namespace in the spec runner.
2022-07-15 16:57:29 -07:00
Sudowoodo Release Bot
9d23a624c1
Bump v21.0.0-nightly.20220715
2022-07-15 15:12:54 -07:00
Keeley Hammond
574da5a9a1
chore: cherry-pick 5e227bebf193 from v8 ( #34931 )
...
* chore: cherry-pick 5e227bebf193 from v8
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-07-15 15:12:01 -07:00
Sudowoodo Release Bot
2afb284456
Revert "Bump v21.0.0-nightly.20220715"
...
This reverts commit 4bec26cd0c .
2022-07-15 07:32:25 -07:00
Sudowoodo Release Bot
4bec26cd0c
Bump v21.0.0-nightly.20220715
2022-07-15 06:01:14 -07:00
Sudowoodo Release Bot
0cb39b5bb5
Revert "Bump v21.0.0-nightly.20220714"
...
This reverts commit e9f42b4ad4 .
2022-07-14 08:12:33 -07:00
Sudowoodo Release Bot
e9f42b4ad4
Bump v21.0.0-nightly.20220714
2022-07-14 06:03:36 -07:00
Samuel Attard
9a5d759ea3
fix: ensure that v8 sandbox isnt enabled for arm ( #34914 )
2022-07-14 10:46:41 +02:00
electron-roller[bot]
d32e6cc252
chore: bump chromium to 105.0.5173.0 (main) ( #34770 )
...
* chore: bump chromium in DEPS to 105.0.5147.0
* chore: update chromium/can_create_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3642216
fix minor code shear in patch
* chore: update chromium/port_autofill_colors_to_the_color_pipeline.patch
Xref: chromium/port_autofill_colors_to_the_color_pipeline.patch
fix minor code shear in patch
* chore: remove chromium/posix_replace_doubleforkandexec_with_forkandspawn.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3727368
Removing upstreamed patch
* chore: update patches
* chore: update patches
* chore: add new enum kOffscreenDocument to switch statement
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3722498
* chore: add stub for new parent virtual method OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3717305
* chore: remove download_schedule arg from DownloadTargetCallback invocation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3711096
Clean up DownloadLater flags and prefs
* chore: add stub for new parent virtual method OnNewCropVersion()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3717305
* chore: use base::List for extensions::Event
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3718366
Remove Event constructor overloads that take vector<base::Value>
* refactor: replace ClearStorageDataOptions.origin with .storage_key
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3702946
Refactor ClearData to take StorageKey
* chore: bump chromium in DEPS to 105.0.5149.0
* chore: update patches
* refactor: migrate InspectableWebContents to base::Value::List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3726326
Migrate DevToolsEmbedderMessageDispatcher to base::Value::List.
* refactor: update electron_api_clipboard_mac Clipboard::ReadFindText()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3721398
Mac: Remove unused FindPasteboard C++ interface
* chore: bump chromium in DEPS to 105.0.5151.0
* chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3714995
Move Cart DB proto to //components/commerce
* Revert "chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch"
This reverts commit f8de4605eb3d35152b186646fefd8e88d1df836b.
* chore: fix code shear in chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3714995
Move Cart DB proto to //components/commerce
* chore: update patches
* chore: update ElectronAccessibilityUIMessageHandler to use base::Value::List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3733367
Convert /chrome/browser/accessibility away from WebUI::RegisterDeprecatedMessageCallback
* chore: bump chromium in DEPS to 105.0.5153.0
* chore: bump chromium in DEPS to 105.0.5155.0
* chore: bump chromium in DEPS to 105.0.5157.0
* chore: bump chromium in DEPS to 105.0.5159.0
* chore: update patches
* chore: update CL reference
* Replace ContentMainDelegate::InvokedIn with a variant
https://chromium-review.googlesource.com/c/chromium/src/+/3705957
* Switch devtools_frontend.mojom to mojom.DictValue.
https://chromium-review.googlesource.com/c/chromium/src/+/3726425
* webhid: Bind HID service with service workers
https://chromium-review.googlesource.com/c/chromium/src/+/3680562
* chore: fix lint
* Don't fire load-complete AX notification on macOS for unfocused windows
https://chromium-review.googlesource.com/c/chromium/src/+/3695403
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5165.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5167.0
* chore: bump chromium in DEPS to 105.0.5169.0
* chore: bump chromium in DEPS to 105.0.5171.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5173.0
* chore: update patches
* 3743346: Stop generating unsupported policies on macOS
https://chromium-review.googlesource.com/c/chromium/src/+/3743346
* 3727612: [Bluetooth][Win] Refactor pairing prompt code
https://chromium-review.googlesource.com/c/chromium/src/+/3727612
* 3737325: system-extensions: Move IsEnabled() out of SystemExtensionsProvider.
https://chromium-review.googlesource.com/c/chromium/src/+/3737325
* 3748635: Remove RenderView from the public API.
https://chromium-review.googlesource.com/c/chromium/src/+/3748635
* fixup: 3743346: Stop generating unsupported policies on macOS
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-07-13 17:26:16 -04:00
Gellert Hegyi
440c575aa6
fix: alwaysOnTop browser window option for X11 Linux ( #34766 )
...
fix: alwaysontop browser window option for x11
2022-07-13 11:59:57 -07:00
Sudowoodo Release Bot
46e5c537c8
Bump v21.0.0-nightly.20220713
2022-07-13 06:01:20 -07:00
Shelley Vohr
07d168343a
fix: enable deviceName validation on Linux ( #34872 )
2022-07-13 12:23:24 +02:00
Shelley Vohr
62aeb74d7c
fix: base::DictionaryValue usage in APNS notifs ( #34897 )
2022-07-13 12:22:17 +02:00
Joan Xie
afd08c9450
feat: Enable APNS registration + notification delivery in macOS apps ( #33574 )
2022-07-12 08:38:49 -07:00
Sudowoodo Release Bot
5314ae5342
Bump v21.0.0-nightly.20220712
2022-07-12 06:01:28 -07:00
Samuel Attard
511ff8bc8d
fix: ensure that requestMediaKeySystemAccess resolves ( #34886 )
...
When widevine was disabled at the build level we never dealt with the callback passed into GetSupportedKeySystems. This was ok until requests became marked pending in https://chromium-review.googlesource.com/c/chromium/src/+/3430502 until the callback was called. This resulted in a promise never resolving / rejecting and certain media websites (E.g. spotify) hanging on load waiting for a signal that would never arrive.
2022-07-12 00:48:51 -07:00
Shelley Vohr
95019f0454
fix: update Windows caption buttons to match Win11 style ( #34790 )
2022-07-12 09:13:40 +02:00
Jeremy Rose
4190ec2482
feat: sandbox preloads by default ( #32869 )
2022-07-11 16:28:09 -07:00
Valentin Hăloiu
f63bba8ce2
fix: set Wayland application ID ( #34855 )
...
* refactor: extract XDG app ID logic into a method
* fix: set application ID on Wayland
2022-07-11 11:26:18 -07:00
Sudowoodo Release Bot
8f3fb8db09
Bump v21.0.0-nightly.20220711
2022-07-11 06:01:12 -07:00
David Sanders
2b862c18ba
chore: improve run-clang-tidy.ts behavior when filenames < jobs ( #34736 )
2022-07-11 12:25:39 +02:00
Samuel Attard
fa8e4a7610
build: use third_party DEPOT_TOOLS when running lint scripts ( #34846 )
...
Some folks (especially build_tools users) do not have a version of depot_tools on their path
2022-07-11 12:25:17 +02:00
Shelley Vohr
2eb0e5dcab
fix: safer check for WCO button updates ( #34833 )
2022-07-11 11:45:01 +02:00
Samuel Attard
459404f536
build: run CI tests on Xcode 13.3.0 ( #34850 )
...
* build: test disabling security
* build: install python2 during tests
* build: do not install python2 on arm64 runners
* attempt 2
* build: only allow 13.3.0 xcode
2022-07-11 17:04:32 +09:00
Sudowoodo Release Bot
78848f8bfe
Bump v21.0.0-nightly.20220708
2022-07-08 06:01:44 -07:00
Samuel Attard
eba9d3fc79
fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules ( #34844 )
...
* fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules
* build: rely on config.gypi to enable pointer compression
2022-07-08 01:06:06 -07:00
Shelley Vohr
1941c88442
fix: setRepresentedFilename with non-default titlebarStyle ( #34834 )
...
fix: setRepresentedFilename with non-default titlebarStyle
2022-07-07 23:33:42 -07:00
Keeley Hammond
e83c3ec744
test: add first-party-set chromium tests ( #34827 )
...
test: add first-part-set chromium feature tests
2022-07-07 15:14:53 -04:00
Shelley Vohr
7ec88584b5
fix: WCO pressed background state updates ( #34771 )
2022-07-07 17:17:20 +02:00
Sudowoodo Release Bot
47d8d4cc5c
Bump v21.0.0-nightly.20220707
2022-07-07 06:01:40 -07:00
Sudowoodo Release Bot
f7428baace
Bump v21.0.0-nightly.20220706
2022-07-06 06:02:02 -07:00
Jeremy Rose
403bd39d05
chore: modernize base::Value useage in asar/archive ( #34796 )
2022-07-05 12:35:38 -04:00
David Sanders
c418275228
chore: update Discord invite links ( #34730 )
2022-07-05 11:55:15 -04:00
David Sanders
98cd16d336
chore: fix typos ( #34731 )
2022-07-05 11:49:56 -04:00
Jeremy Rose
e5db178ab6
feat: enable v8 sandboxed pointers ( #34724 )
...
* feat: enable v8 sandboxed pointers
* update breaking-changes.md
* update zero-fill patch
benchmarks showed the function call was slower
2022-07-05 11:28:22 -04:00
Jeremy Rose
0ee7f14190
chore: modernize Value usage in converters ( #34794 )
...
* chore: modernize Value usage in converters
* Date is parsed as an empty object now
2022-07-05 11:25:18 -04:00
Sudowoodo Release Bot
d28ed0da20
Bump v21.0.0-nightly.20220705
2022-07-05 06:01:17 -07:00
Sudowoodo Release Bot
1edf9d2ada
Bump v21.0.0-nightly.20220704
2022-07-04 06:02:50 -07:00
Sudowoodo Release Bot
d359736e65
Bump v21.0.0-nightly.20220701
2022-07-01 06:00:58 -07:00
Darshan Sen
c885f9063b
docs: document the removal of IA32 Linux support ( #34787 )
...
* docs: document the removal of IA32 Linux support
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
https://github.com/electron/electron/pull/33731 , had introduced the commit,
389ef0731e ,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.
Closes: https://github.com/electron/electron/issues/34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2022-06-30 09:23:03 -07:00
Sudowoodo Release Bot
c3920c5c02
Bump v21.0.0-nightly.20220630
2022-06-30 06:02:00 -07:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Jeremy Rose
0d4e417594
chore: modernize ListValue usage in permission manager ( #34662 )
2022-06-29 10:09:48 -07:00
Jeremy Rose
4ddd03b1b3
chore: modernize some devtools code using deprecated ListValue ( #34655 )
2022-06-29 09:39:48 -07:00
Shelley Vohr
7c12baccab
build: remove appveyor hook to defunct service ( #34789 )
2022-06-29 17:19:05 +02:00
Sudowoodo Release Bot
461561c19c
Bump v21.0.0-nightly.20220629
2022-06-29 06:01:40 -07:00
Josh Soref
1f814eacb2
build: fix release_dependency_versions workflow ( #34573 )
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2022-06-29 14:55:59 +02:00
Shelley Vohr
ad2b1fee59
fix: re-enable HKDF crypto functionality ( #34767 )
...
* fix: re-enable HKDF crypto functionality
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-06-29 14:53:57 +02:00
Shelley Vohr
35ff95d3c7
fix: <datalist> bounds vertical cutoff ( #34759 )
2022-06-29 10:14:03 +02:00
Sudowoodo Release Bot
6257e0c348
Bump v21.0.0-nightly.20220628
2022-06-28 20:28:29 -07:00
Keeley Hammond
3310e4039f
build: update makeRequest parameters ( #34782 )
2022-06-28 20:26:00 -07:00
Jeremy Rose
40fbc05bb2
chore: modernize base::Value usage in accessibility_ui ( #34666 )
2022-06-28 16:40:56 -07:00
Keeley Hammond
3458eac276
chore: update printing patch for main gclient sync ( #34777 )
...
chore: update printing patch
2022-06-28 16:40:23 -07:00
Samuel Attard
44b9ee51f4
fix: resolve symlinks when computing relative asar paths for integrity ( #34776 )
2022-06-28 16:02:00 -07:00
Jeremy Rose
07294cbf15
chore: modernize ListValue usage in gpu info ( #34663 )
2022-06-28 09:52:59 -07:00
Sudowoodo Release Bot
a4043237da
Revert "Bump v21.0.0-nightly.20220628"
...
This reverts commit f1087cc830 .
2022-06-28 07:40:00 -07:00
Micha Hanselmann
704b2199b3
build: fix building with enable_basic_printing false ( #34711 )
...
* build: fix building with enable_basic_printing false
* temp flags for ci builds
* fix other systems
* disable cups
* disable print preview
* revert changes
* merge with printing.patch
2022-06-28 16:34:00 +02:00
Sudowoodo Release Bot
f1087cc830
Bump v21.0.0-nightly.20220628
2022-06-28 07:07:08 -07:00
Sudowoodo Release Bot
d028044a24
Revert "Bump v21.0.0-nightly.20220628"
...
This reverts commit 9c311a2059 .
2022-06-28 07:05:52 -07:00
Sudowoodo Release Bot
9c311a2059
Bump v21.0.0-nightly.20220628
2022-06-28 06:01:35 -07:00
dependabot[bot]
47afaddaf5
build(deps-dev): bump got from 6.7.1 to 11.8.5 ( #34697 )
...
Bumps [got](https://github.com/sindresorhus/got ) from 6.7.1 to 11.8.5.
- [Release notes](https://github.com/sindresorhus/got/releases )
- [Commits](https://github.com/sindresorhus/got/compare/v6.7.1...v11.8.5 )
---
updated-dependencies:
- dependency-name: got
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-28 11:18:47 +02:00
David Sanders
59d3c12cae
chore: remove spurious trailing namespace comments ( #34732 )
2022-06-28 10:08:55 +02:00
electron-roller[bot]
e86d1cba75
chore: bump chromium to 105.0.5129.0 (main) ( #34403 )
...
* chore: bump chromium in DEPS to 104.0.5096.0
* 3651284: Use the entry settings object for window.open navigation
https://chromium-review.googlesource.com/c/chromium/src/+/3651284
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* 3642842: Window Placement: Prototype Fullscreen Capability Delegation - Part 2
https://chromium-review.googlesource.com/c/chromium/src/+/3642842
* 3652785: [sandbox] Enable sandboxed pointers on sanitizer builds
https://chromium-review.googlesource.com/c/v8/v8/+/3652785
* 3611967: webhid: Migrate HidDelegate to use BrowserContext and Origin
https://chromium-review.googlesource.com/c/chromium/src/+/3611967
* 3665762: Remove RenderFrameHost::IsRenderFrameCreated from //content/.
https://chromium-review.googlesource.com/c/chromium/src/+/3665762
* 3659375: Fold x509_util_ios and most of x509_util_mac into x509_util_apple
https://chromium-review.googlesource.com/c/chromium/src/+/3659375
* 3656234: [CodeHealth] Remove uses of base::ListValue::Append() (Final, take 2)
https://chromium-review.googlesource.com/c/chromium/src/+/3656234
* chore: update patch indices
* chore: fix lint
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* webhid: Migrate HidDelegate to use BrowserContext and Origin
This is a temporary fix for https://chromium-review.googlesource.com/c/chromium/src/+/3611967 to get the build compiling, but we need to either patch around https://chromium-review.googlesource.com/c/chromium/src/+/3611967 or move our device permissioning to BrowserContext
* chore: fix lint
* build: run electron/script/gen-libc++-filenames.js
fixes gn check
* chore: bump chromium in DEPS to 104.0.5098.0
* chore: disable flaking tests
* 3682394: Change pipes surrounding code references in comments to backticks
https://chromium-review.googlesource.com/c/chromium/src/+/3682394
* 3652749: Delete GLRenderer and related classes
https://chromium-review.googlesource.com/c/chromium/src/+/3652749
* chore: fixup patch indices
* 3671199: Remove ContentMainDelegate::PostFieldTrialInitialization
https://chromium-review.googlesource.com/c/chromium/src/+/3671199
* 3607963: hid: Do not exclude HID device with no collections
https://chromium-review.googlesource.com/c/chromium/src/+/3607963
* refactor: use ElectronBrowserContext instead of WebContents to persist devices
due to changes like https://chromium-review.googlesource.com/c/chromium/src/+/3611967 ,
we can no longer use WebContents to store device permissions so this commit
moves device permission storage to live in memory in ElectronBrowserContext
instead.
* 3557253: Deprecate some signature checks
https://chromium-review.googlesource.com/c/v8/v8/+/3557253
* chore: bump chromium in DEPS to 104.0.5100.0
* 3680781: Add policy for Renderer App Container.
https://chromium-review.googlesource.com/c/chromium/src/+/3680781
* chore: update patch indices
* 3675465: Update NetLog network service API to use mojom::DictionaryValue.
https://chromium-review.googlesource.com/c/chromium/src/+/3675465
* chore: bump chromium in DEPS to 104.0.5102.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5103.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5104.0
* chore: update patches
* fix: add patch for DCHECK in fullscreen test
* build: fix nan build
* build: make the nan spec runner work on macOS
* chore: bump chromium in DEPS to 104.0.5106.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5108.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5110.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5112.0
* chore: bump chromium in DEPS to 105.0.5113.0
* chore: bump chromium in DEPS to 105.0.5115.0
* chore: bump chromium in DEPS to 105.0.5117.0
* chore: update patches
* chore: update libcpp patch
* 3693745: Delete base::LowerCaseEqualsASCII()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3693745
* 3669226: Remove printing PostTask usage of IO thread
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3669226
* 3687395: Remove DictionaryValue::HasKey().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3687395
* 3691014: Prevent unsafe narrowing: ui/accessibility, part 2
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3691014
* 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560567
* 3684873: [Bluetooth][Win/Linux] Add bluetooth pair confirmation prompt
https://chromium-review.googlesource.com/c/chromium/src/+/3684873
* chore: bump chromium in DEPS to 105.0.5119.0
* chore: missing includes in desktop_notification_controller
* chore: update patches
* 3685951: Reland "Make sure screen object is created once in tests."
https://chromium-review.googlesource.com/c/chromium/src/+/3685951
* fixup: Reland "Make sure screen object is created once in tests."
* 3646014: [API] Deprecate LegacyOOMErrorCallback
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3646014
* chore: bump chromium in DEPS to 105.0.5121.0
* chore: update patches
* 3699085: [cleanup] update PrintBackend::EnumeratePrinters to use reference
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3699085
* chore: bump chromium in DEPS to 105.0.5123.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5125.0
* chore: update patches
* 3630082: [sandbox] Also enable the sandbox outside of Chromium builds
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3630082
* chore: bump chromium in DEPS to 105.0.5127.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5129.0
* chore: update patches
* 3703741: Remove WebContents::GetMainFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/3703741
* chore: update patches
* fixup! 3703741: Remove WebContents::GetMainFrame.
* fix lint
* more lint
* chore: document breaking change
* 3687671: [v8] Freeze flags after initialization
https://chromium-review.googlesource.com/c/chromium/src/+/3687671
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* use the v8 allocator for node serdes
* chore: update patches
* remove faulty non-v8-sandbox-compatible code
* make NodeArrayBufferAllocator use the v8 allocator under the hood
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* fix build on windows
* 3691954: [Reland][Extensions Bindings] Validate arguments sent to API events
https://chromium-review.googlesource.com/c/chromium/src/+/3691954
* chore: remove deprecated AccessorSignatures
https://github.com/nodejs/nan/pull/941
* Update patches/chromium/notification_provenance.patch
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* remove chore_expose_v8_initialization_isolate_callbacks.patch
* add link to nodejs/nan#941
* 52026: Do not allow md4 or md5 based signatures in X.509 certificates.
https://boringssl-review.googlesource.com/c/boringssl/+/52026
* chore: update patches
* disable nan buffer-test
* disable sandboxed pointers for now
* force sandboxed pointers off
* improve node allocation patch
* restore accidentally dropped node crypto test patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com >
2022-06-27 15:50:08 -05:00
Sudowoodo Release Bot
032e1d9bef
Bump v21.0.0-nightly.20220627
2022-06-27 06:02:43 -07:00
David Sanders
39840502be
docs: replace broken Windows taskbar images ( #34729 )
2022-06-27 14:14:01 +02:00
David Sanders
8238cca87b
test: use maximize event instead of resize event ( #34740 )
2022-06-27 10:29:55 +02:00
David Sanders
e2c58d164d
chore: replace Object.assign with object spread syntax ( #34739 )
2022-06-27 10:29:18 +02:00
Milan Burda
ba4893c248
refactor: load webFrame via process._linkedBinding in security-warnings.ts ( #34735 )
2022-06-27 10:28:35 +02:00
Sudowoodo Release Bot
c5b87e4919
Bump v21.0.0-nightly.20220624
2022-06-24 06:01:02 -07:00
Shelley Vohr
3b881e4a13
fix: WCO respects maximizable/closable/minimizable ( #34677 )
2022-06-23 13:08:32 -04:00
Sudowoodo Release Bot
106aa0e922
Bump v21.0.0-nightly.20220623
2022-06-23 06:00:50 -07:00
Jeremy Rose
11924bdbb2
chore: modernize ListValue usage in dict_util.mm and related files ( #34661 )
...
* chore: modernize ListValue usage in dict_util.mm and related files
* use base::Value::{Dict,List} instead of raw base::Value
* fix compile
* fix build
* fix build again
2022-06-23 15:28:41 +09:00
Jeremy Rose
cd19a741b1
chore: modernize base::Value usage in shell/renderer/printing ( #34682 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-06-22 10:37:58 -07:00
Jeremy Rose
5895296239
test: disable flaky transparent window test ( #34660 )
2022-06-22 10:37:32 -07:00
Sudowoodo Release Bot
e3243ad113
Bump v21.0.0-nightly.20220622
2022-06-22 06:00:53 -07:00
David Sanders
5fee5b0e22
chore: chunk filenames when linting C++ files ( #34237 )
...
* chore: chunk filenames when linting C++ files
* chore: refactor code for better readability
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: further tweak
* chore: limit all platforms to 4095 characters on command line
* chore: use python3
* Revert "chore: use python3"
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-06-22 19:23:11 +09:00
Milan Burda
f172136752
chore: remove undocumented page-title-set webview event ( #34533 )
2022-06-22 17:18:42 +09:00
Juan Cruz Viotti
218797eb61
fix: allow macOS debug builds to be built ( #34536 )
...
Extending the `testing` GN profile with the arguments documented to
allow breakpoint debugging
(https://www.electronjs.org/docs/latest/development/debugging#breakpoint-debugging )
doesn't quite work on macOS:
```sh
is_debug = true
symbol_level = 2
forbid_non_component_debug_builds = false
```
The build eventually fails on both Intel and Apple Silicon with the
following (summarized) error:
```sh
[S:41062 R:1 (41062:41247) (C/s:0.1 O/s:13.6)] SOLINK 'obj/electron/electron_framework_shared_library/Electron Framework' 'obj/electron/electron_framework_shared_library/Electron Framework.TOC'
FAILED: obj/electron/electron_framework_shared_library/Electron Framework obj/electron/electron_framework_shared_library/Electron Framework.TOC
...
Undefined symbols for architecture x86_64:
"platform_util::GetViewForWindow(gfx::NativeWindow)", referenced from:
BoundsOverlapWithAnyOpenPrompt(gfx::Rect const&, content::WebContents*) in libchrome.a(autofill_popup_view_utils.o)
"platform_util::GetParent(gfx::NativeView)", referenced from:
BoundsOverlapWithAnyOpenPrompt(gfx::Rect const&, content::WebContents*) in libchrome.a(autofill_popup_view_utils.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
...
```
This symbol is defined on a file that is not declared as a dependency of
`libchrome` on the GN definitions. Why the problem is not reproducible
on plain testing or release builds remains a mystery to me. I'm guessing
some non-debug path somewhere in the GN definitions does eventually
require that file.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2022-06-22 17:18:12 +09:00
Erick Zhao
e410109a3d
docs: expand tutorial ( #34604 )
...
* docs: base tutorial update
* more docs
* zzz
* remove unused images
2022-06-22 17:17:48 +09:00
Milan Burda
a5869fe997
refactor: use std::size(args) instead of hardcoded values ( #34651 )
2022-06-22 10:15:27 +02:00
Jeremy Rose
bf52318c76
fix: modernize ListValue in net converters ( #34657 )
2022-06-22 10:14:57 +02:00
Jeremy Rose
73c85410c5
chore: modernize ListValue code in session ( #34656 )
...
* chore: modernize ListValue code in session
* also in browser_context
2022-06-22 10:14:35 +02:00
Jeremy Rose
ad7aab8338
chore: modernize base::Value usage in WebRequest ( #34667 )
2022-06-22 10:11:27 +02:00
Sudowoodo Release Bot
140c8d0d0a
Bump v21.0.0-nightly.20220621
2022-06-21 09:07:50 -07:00
Keeley Hammond
34fc53e5e6
chore: Revert "build: build & release libcxx objects on darwin ( #34586 )" ( #34680 )
...
Revert "build: build & release libcxx objects on darwin (#34586 )"
This reverts commit 2bbbc66eb8 .
2022-06-21 09:06:50 -07:00
Sudowoodo Release Bot
528cbe8131
Revert "Bump v21.0.0-nightly.20220621"
...
This reverts commit 116c32a030 .
2022-06-21 08:27:51 -07:00
Sudowoodo Release Bot
116c32a030
Bump v21.0.0-nightly.20220621
2022-06-21 06:00:53 -07:00
Shelley Vohr
530a022b05
fix: window button visibility fullscreen interaction ( #34530 )
2022-06-21 16:35:53 +09:00
Milan Burda
f3f327823e
chore: move main process only accessible API bindings away from common ( #34634 )
2022-06-21 16:34:56 +09:00
Milan Burda
0f528c1e43
chore: let result: ReturnType<typeof this._callWindowOpenHandler>; ( #34628 )
2022-06-21 10:39:41 +09:00
Keeley Hammond
2bbbc66eb8
build: build & release libcxx objects on darwin ( #34586 )
...
* build: build & release libcxx objects on darwin
* Fix merge error
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-06-21 10:35:16 +09:00
Shelley Vohr
3cd5223134
build: mark existing Node.js flakes as dontcare ( #34644 )
2022-06-20 15:54:52 -04:00
Shelley Vohr
8e45f43f18
refactor: remove deprecated drag-and-drop code ( #34615 )
2022-06-20 15:17:53 +02:00
Sudowoodo Release Bot
d341610d64
Bump v21.0.0-nightly.20220620
2022-06-20 06:01:30 -07:00
Shelley Vohr
6e9466f96b
fix: overzealous media key listening on Windows ( #34594 )
2022-06-20 19:40:10 +09:00
Shelley Vohr
e2f42e5d99
chore: fix BrowserView painting when origin updated ( #34581 )
...
chore: fix View painting when origin updated
2022-06-20 13:31:53 +09:00
Darshan Sen
ec98e95b8a
fix: performance problem in crashReporter.start() on macOS ( #34609 )
...
fix: performance problem in crashReporter.start() on macOS
This change reduces the duration of crashReporter.start() on Intel macOS
from 622 milliseconds to 257 milliseconds!
Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
posix: Replace DoubleForkAndExec() with ForkAndSpawn()
The DoubleForkAndExec() function was taking over 622 milliseconds to run
on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
some custom traces and found that the fork() syscall is the bottleneck
here, i.e., the first fork() takes around 359 milliseconds and the
nested fork() takes around 263 milliseconds. Replacing the nested fork()
and exec() with posix_spawn() reduces the time consumption to 257
milliseconds!
See https://github.com/libuv/libuv/pull/3064 to know why fork() is so
slow on macOS and why posix_spawn() is a better replacement.
Another point to note is that even base::LaunchProcess() from Chromium
calls posix_spawnp() on macOS -
8f8d82dea0 :base/process/launch_mac.cc;l=295-296
Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
Reviewed-by: Mark Mentovai <mark@chromium.org >
Commit-Queue: Mark Mentovai <mark@chromium.org >
Fixes: https://github.com/electron/electron/issues/34321
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-06-20 13:31:29 +09:00
dependabot[bot]
bf4efb693b
build(deps): bump jpeg-js from 0.4.3 to 0.4.4 in /spec-main ( #34607 )
...
Bumps [jpeg-js](https://github.com/eugeneware/jpeg-js ) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/eugeneware/jpeg-js/releases )
- [Commits](https://github.com/eugeneware/jpeg-js/compare/v0.4.3...v0.4.4 )
---
updated-dependencies:
- dependency-name: jpeg-js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-20 09:57:25 +09:00
Raymond Zhao
999a225edb
refactor: use stubs for gdk-pixbuf dependency ( #34077 )
...
* refactor: use stubs for gdk-pixbuf dependency
* Adjust build file
* Add includes
* Merge gdk_pixbuf stubs into gtk stubs
* Split pixbuf sigs into own file again
* Add initialization check
* Apply PR feedback
2022-06-19 17:42:30 -07:00
Milan Burda
b3ec0a801a
chore: cleanup undocumented keys from webFrame.getWebPreference() ( #34588 )
2022-06-19 17:40:03 -07:00
Sudowoodo Release Bot
6f8bfdeb7a
Bump v21.0.0-nightly.20220617
2022-06-17 06:02:13 -07:00
Shelley Vohr
20538c4f34
fix: draggable regions updating on bounds change ( #34582 )
2022-06-17 12:01:38 +02:00
Sudowoodo Release Bot
d2e539c7d4
Bump v21.0.0-nightly.20220616
2022-06-16 06:00:48 -07:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2022-06-16 16:46:11 +09:00
Milan Burda
f418a49857
chore: warn when using the deprecated new-window event ( #34528 )
2022-06-15 18:17:42 -07:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Sudowoodo Release Bot
4ec95edf06
Bump v21.0.0-nightly.20220615
2022-06-15 06:01:24 -07:00
Michaela Laurencin
4c7c0b41c2
feat: add immersive dark mode on windows ( #33624 )
...
* feat: add immersive dark mode
* fix syntax and add header
* add me
* Update fuses.json5
* fix: redraw title bar on dark mode change
* chore: SetWindowTheme doesn't seem to be needed
* chore: separate out Win 10 dark mode implementation
* final touches
* final touches
* chore: limit Win 10 to >= 20H1 and drop fuse
* fix types
* fix lint
Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2022-06-14 12:27:28 -04:00
isailaandrei
21ef8501e7
feat: add panel support for BrowserWindow ( #34388 )
...
* feat: add NSPanel support for BrowserWindow
* change header guard to satisfy linter
* change panel wording in browser-window
* Revert "change panel wording in browser-window"
This reverts commit 6f3f80f94a .
* change wording in browser-window
* Update shell/browser/ui/cocoa/electron_native_widget_mac.mm
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Update shell/browser/ui/cocoa/electron_native_widget_mac.h
Co-authored-by: Cheng Zhao <github@zcbenz.com >
* Changed ScopedDisableResize class to allow for nesting
Co-authored-by: andreiisaila <andreiisaila@microsoft.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2022-06-14 12:24:52 -04:00
Shelley Vohr
bed38e0985
fix: crash when setWindowOpenHandler callback throws ( #34523 )
...
* fix: crash when setWindowOpenHandler throws
* refactor: throw as process uncaughtException event
2022-06-14 12:22:23 -04:00
Milan Burda
8de5cdb426
test: add missing page-title-updated event spec for webview ( #34529 )
2022-06-14 12:15:45 -04:00
Sudowoodo Release Bot
9707812d68
Bump v21.0.0-nightly.20220614
2022-06-14 06:02:37 -07:00
Milan Burda
16cd22ff6a
test: use webContents.setWindowOpenHandler() in specs ( #34514 )
...
* test: use webContents.setWindowOpenHandler() in specs
* test: use browser-window-created instead of new-window for visibility spec
2022-06-13 13:07:47 -04:00
Jeremy Rose
954fd72500
fix: make navigator.userAgentData non-empty ( #34481 )
2022-06-13 09:35:42 -07:00
Sudowoodo Release Bot
8157a01a42
Bump v21.0.0-nightly.20220613
2022-06-13 08:39:00 -07:00
Sudowoodo Release Bot
d565243f98
Revert "Bump v21.0.0-nightly.20220613"
...
This reverts commit 77dcf4a5e0 .
2022-06-13 08:37:46 -07:00
Sudowoodo Release Bot
77dcf4a5e0
Bump v21.0.0-nightly.20220613
2022-06-13 06:01:32 -07:00
Milan Burda
2a9b3cc9cd
chore: remove unused proxy-window-open.snapshot.txt ( #34501 )
...
chore: remove unused spec-main/fixtures/snapshots/proxy-window-open.snapshot.txt
2022-06-13 16:01:34 +09:00
Milan Burda
7ca3f55b10
refactor: move duplicate code to RendererClientBase::ShouldLoadPreload helper ( #34477 )
2022-06-13 15:58:27 +09:00
Shelley Vohr
e5543a2dd2
fix: all files selection logic on linux ( #34496 )
2022-06-13 15:57:03 +09:00
John Kleinschmidt
bd81ae08ac
fix: don't require glibc 2.29+ on linux arm64 builds ( #34491 )
...
* build: use sid sysroot for linux arm64
2022-06-10 14:15:52 -04:00
Sudowoodo Release Bot
57b863c213
Bump v21.0.0-nightly.20220610
2022-06-10 06:02:06 -07:00
Michaela Laurencin
52c0a4fafc
docs: add macOS height option info ( #34451 )
2022-06-09 15:17:27 -04:00
Sudowoodo Release Bot
1302ebf50e
Bump v21.0.0-nightly.20220609
2022-06-09 06:01:17 -07:00
Shelley Vohr
37d93b0482
fix: update normal bounds prior to minimizing ( #34473 )
2022-06-09 10:48:50 +02:00
Shelley Vohr
2fd0194e94
build: update clang-format script ( #34286 )
2022-06-08 21:26:41 +02:00
Sudowoodo Release Bot
6d50717eed
Bump v21.0.0-nightly.20220608
2022-06-08 06:00:42 -07:00
David Sanders
289128b96c
chore: use --root instead of --project_root for cpplint ( #34456 )
...
--root has been improved upstream in depot_tools to better handle Windows:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3648533
2022-06-08 10:29:39 +02:00
Shelley Vohr
16db5a112e
fix: html fullscreen transitions stacking ( #32905 )
...
* fix: html fullscreen transitions stacking
* spec: move webview test to spec-main
2022-06-07 12:59:50 -04:00
Sudowoodo Release Bot
f44ecb7f03
Bump v21.0.0-nightly.20220607
2022-06-07 07:30:55 -07:00
Sudowoodo Release Bot
8e97f3badf
Revert "Bump v21.0.0-nightly.20220607"
...
This reverts commit a203123473 .
2022-06-07 07:12:33 -07:00
Sudowoodo Release Bot
a203123473
Bump v21.0.0-nightly.20220607
2022-06-07 07:11:11 -07:00
Sudowoodo Release Bot
c750936328
Revert "Bump v21.0.0-nightly.20220607"
...
This reverts commit 5f0f517486 .
2022-06-07 07:09:18 -07:00
Sudowoodo Release Bot
5f0f517486
Bump v21.0.0-nightly.20220607
2022-06-07 06:01:42 -07:00
Shelley Vohr
4ec2de659f
chore: fix nan spec runner on macOS ( #34447 )
2022-06-07 12:09:08 +02:00
David Sanders
30d15715a9
build: switch to --use-color flag for clang-tidy ( #34457 )
...
chore: switch to --use-color flag for clang-tidy
2022-06-07 09:49:52 +02:00
Samuel Maddock
882fa36940
test: fix for flaky renderer crash test ( #34452 )
2022-06-06 17:39:58 -04:00
Sudowoodo Release Bot
e56f626b94
Bump v21.0.0-nightly.20220606
2022-06-06 06:02:02 -07:00
Charles Kerr
92b0f3e808
build: add --unique option to release notes script ( #34296 )
...
Useful when looking for changes unique to a single branch
2022-06-06 14:51:10 +09:00
Will Anderson
4f99e3e46c
docs: fix did-frame-navigate example in webFrameMain docs ( #34419 )
...
docs: fix did-frame-navigate example in webFrameMain docs
2022-06-06 14:49:14 +09:00
electron-roller[bot]
f39c1a35e5
chore: bump node to v16.15.1 (main) ( #34424 )
2022-06-03 16:13:27 +02:00
Sudowoodo Release Bot
05b03b01dc
Bump v21.0.0-nightly.20220603
2022-06-03 06:00:36 -07:00
Shelley Vohr
6038e42c23
fix: fullscreen windows aren't resizable on macOS ( #34379 )
2022-06-03 09:47:19 +02:00
Samuel Maddock
b00c026a54
fix: render process crash handling ( #34428 )
...
* fix: crash when renderer process is reused
Could occur when a renderer crashes and the same-origin URL is loaded again
which leads to reusing the renderer process.
* test: renderer process crash recovery
* fix: handle case which leads to render frame DCHECK
* fix: lint
2022-06-02 17:23:01 -07:00
Shelley Vohr
eb26f99f6e
test: re-enable shared worker webview test ( #34338 )
2022-06-02 17:27:37 -04:00
Sudowoodo Release Bot
d13c879a15
Bump v21.0.0-nightly.20220602
2022-06-02 14:15:14 -07:00
Sudowoodo Release Bot
3ad70d0f0b
Revert "Bump v21.0.0-nightly.20220602"
...
This reverts commit eb9888d1d2 .
2022-06-02 14:12:58 -07:00
Keeley Hammond
0671f229ac
chore: increase timeout for electron-build step ( #34427 )
2022-06-02 14:12:10 -07:00
Shelley Vohr
539a53786c
chore: remove redundant @available checks ( #34407 )
...
* chore: require macOS 10.13 for Chromium
* chore: fix lint
2022-06-02 14:43:40 -04:00
Keeley Hammond
000c3d981c
build: disable 32-bit Windows symbol generation ( #34412 )
2022-06-02 09:01:33 -07:00
Sudowoodo Release Bot
eb9888d1d2
Bump v21.0.0-nightly.20220602
2022-06-02 06:01:23 -07:00
Samuel Attard
1cd07c565a
fix: crash in WebFrameMain mojo connection when RenderFrameHost is nullptr ( #34411 )
...
* fix: crash when RenderFrameHost is nullptr
* chore: lint fix
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
2022-06-01 16:03:04 -07:00
Sudowoodo Release Bot
f306fbc010
Revert "Bump v21.0.0-nightly.20220601"
...
This reverts commit 5057cbf418 .
2022-06-01 14:31:30 -07:00
Sudowoodo Release Bot
5057cbf418
Bump v21.0.0-nightly.20220601
2022-06-01 10:32:32 -07:00
Naoki Maeda
561be72373
chore: update husky to v8.0.1 ( #34343 )
...
* chore: update husky v8.0.1
* chore: remove unnecessary .husky/.gitignore
ref : https://github.com/typicode/husky/releases/tag/v7.0.0
* chore: add ^ prefix for husky version
* chore: update yarn.lock
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2022-06-01 13:00:48 -04:00
John Kleinschmidt
a38e5d20ff
ci: cache python install to better deal with download errors. ( #34360 )
...
* ci: cache python install to better deal with download errors.
* chore: use our CDN to download python2
* build: DRY up the python install steps
Co-authored-by: Samuel Attard <sattard@salesforce.com >
2022-06-01 12:59:26 -04:00
Sudowoodo Release Bot
cda8f3c15c
Revert "Bump v21.0.0-nightly.20220601"
...
This reverts commit df91dd6d2b .
2022-06-01 08:28:12 -07:00
Sudowoodo Release Bot
df91dd6d2b
Bump v21.0.0-nightly.20220601
2022-06-01 06:02:01 -07:00
electron-roller[bot]
470396d6ac
chore: bump chromium to 104.0.5073.0 (main) ( #34272 )
2022-06-01 08:12:47 +02:00
Sudowoodo Release Bot
3849d19e14
Bump v21.0.0-nightly.20220531
2022-05-31 06:01:31 -07:00
Shelley Vohr
2cb53c5db1
fix: zombie windows when fullscreening and closing ( #34378 )
2022-05-31 10:43:42 +02:00
Shelley Vohr
93b39b92b5
refactor: printToPDF should be headless ( #33654 )
2022-05-31 08:21:25 +02:00
Sudowoodo Release Bot
0d69067dee
Bump v21.0.0-nightly.20220530
2022-05-30 06:01:33 -07:00
Samuel Attard
fd88908457
fix: hide content protected windows during screen capture with ScreenCaptureKitMac ( #34362 )
...
fix: hide content protected windows during screen capture
2022-05-30 14:13:48 +02:00
Keeley Hammond
34a9268e97
ci: re-enable CalculateNativeWinOcclusion ( #34374 )
2022-05-30 10:28:33 +02:00
Sudowoodo Release Bot
03d9615f99
Bump v21.0.0-nightly.20220527
2022-05-27 06:02:05 -07:00
Sudowoodo Release Bot
2ffa31832e
Bump v21.0.0-nightly.20220526
2022-05-26 06:01:46 -07:00
Shelley Vohr
4accf67d2b
build: trigger mksnapshot/chromedriver releases automatically ( #34346 )
2022-05-25 20:52:41 +02:00
Sudowoodo Release Bot
afca3519fd
Revert "Bump v20.0.0-nightly.20220525"
...
This reverts commit 4b3a7b7762 .
2022-05-25 06:24:48 -07:00
Sudowoodo Release Bot
4b3a7b7762
Bump v20.0.0-nightly.20220525
2022-05-25 06:18:50 -07:00
Sudowoodo Release Bot
a6a2bb65a4
Revert "Bump v20.0.0-nightly.20220525"
...
This reverts commit fd559d8516 .
2022-05-25 06:16:08 -07:00
Sudowoodo Release Bot
fd559d8516
Bump v20.0.0-nightly.20220525
2022-05-25 06:01:00 -07:00
Shelley Vohr
7bc4b919dc
fix: esc not working on Windows during fullscreen ( #34317 )
...
* fix: esc not working on Windows during fullscreen
* chore: fix lint
2022-05-24 21:38:38 -07:00
Samuel Attard
6cb2b9eab7
build: do not checkout chromium for ts docs check ( #34331 )
2022-05-24 14:04:49 -07:00
Sudowoodo Release Bot
b8abf5e38a
Bump v20.0.0-nightly.20220524
2022-05-24 06:00:37 -07:00
Milan Burda
6667de28e3
chore: use webContents.setWindowOpenHandler() in default-app ( #34308 )
2022-05-24 10:23:56 +02:00
Milan Burda
9d3fc9c794
refactor: return options directly in makeBrowserWindowOptions() helper ( #34309 )
2022-05-24 10:23:16 +02:00
John Kleinschmidt
ba573f5583
feat: add support for HIDDevice.forget() ( #34210 )
...
* feat: add support for HIDDevice.forget()
* chore: remove whitespace
* chore: use `SetGetter` to serialize the render_frame_host
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
* fixup chore: use `SetGetter` to serialize the render_frame_host
* fixup after rebase
* fixup for crash on navigator.serial.getPorts()
* fixup for lint
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
2022-05-23 15:13:18 -04:00
Darshan Sen
df9383cb3c
chore: add a TRACE call for crash_reporter::Start() ( #34268 )
...
chore: add a TRACE call for crash_reporter::Start()
Initializing the crashReporter takes around 620 milliseconds on Intel
macOS. I have sent a CL to crashpad to partially fix the performance
issue in
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386 .
It would be beneficial to log the performance impact of this function in
the traces in case this slows down in the future.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-05-23 08:38:03 -07:00
Milan Burda
09a80ea48c
test: use webContents.setWindowOpenHandler() in specs ( #34310 )
2022-05-23 16:39:50 +02:00
John Kleinschmidt
887b5a7dc7
fix: crash on navigator.serial.getPorts() ( #34280 )
...
* fix: crash on navigator.serial.getPorts()
* test: fixup BrowserWindow.setTitlebarOverlay test
2022-05-23 10:33:39 -04:00
Sudowoodo Release Bot
c3fa6005db
Bump v20.0.0-nightly.20220523
2022-05-23 06:02:11 -07:00
FantasqueX
89fab6a549
docs: remove X-Content-Security-Policy header in quick-start.md ( #34307 )
...
reference: Note: It is known that having both Content-Security-Policy
and X-Content-Security-Policy or X-Webkit-CSP causes unexpected
behaviours on certain versions of browsers. Please avoid using deprecated
X-* headers. https://content-security-policy.com/
also:
1ad18486ed
2022-05-23 14:49:38 +02:00
Milan Burda
291eb60916
fix: building node modules with Visual Studio 2017 ( #34217 )
2022-05-23 20:04:08 +09:00
Michaela Laurencin
aa3e852a73
docs: add height option and color transparency info ( #34278 )
2022-05-23 20:01:22 +09:00
Robo
1639ccf98f
fix: service worker registration with custom protocols ( #34290 )
...
Refs https://github.com/electron/electron/issues/32664
2022-05-23 00:42:37 -07:00
Keeley Hammond
38c21b7aca
revert: add first-instance-ack event to the app.requestSingleInstanceLock() flow ( #34297 )
...
fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow"
2022-05-22 22:20:54 -07:00
Varun Sharma
ff13fa8f0a
ci: Add GitHub token permissions for workflows ( #34298 )
...
ci: add GitHub token permissions
2022-05-21 17:35:26 -07:00
Sudowoodo Release Bot
ba7dedcc6f
Bump v20.0.0-nightly.20220520
2022-05-20 06:00:58 -07:00
Samuel Maddock
5ff94e7f2b
fix: crash when creating interface for speculative frame ( #33919 )
2022-05-19 11:34:58 -07:00
Sudowoodo Release Bot
17c8ec765b
Bump v20.0.0-nightly.20220519
2022-05-19 06:00:53 -07:00
Shelley Vohr
588005a9d5
fix: DCHECK on webContents.print() ( #34271 )
2022-05-19 10:05:07 +02:00
Shelley Vohr
73e0bf973d
fix: delayed bounds when moving/resizing and preventing default ( #34204 )
2022-05-19 10:03:02 +02:00
Sofia Nguy
455544dfb6
docs: Update release dates for E20 ( #34267 )
2022-05-18 09:39:40 -07:00
Sudowoodo Release Bot
2436152536
Bump v20.0.0-nightly.20220518
2022-05-18 06:00:56 -07:00
electron-roller[bot]
61374019c0
chore: bump chromium to 103.0.5046.0 (main) ( #33906 )
...
* chore: bump chromium in DEPS to 103.0.5020.0
* chore: bump chromium in DEPS to 103.0.5022.0
* chore: bump chromium in DEPS to 103.0.5024.0
* chore: update patches
* 3587410: [Printing] Remove JobEventDetails
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587410
* chore: bump chromium in DEPS to 103.0.5026.0
* chore: update patches
* 3577218: WebUI: Delete webui_resources.grd and related GN targets.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3577218
* chore: bump chromium in DEPS to 103.0.5028.0
* chore: update patches
* 3579297: Convert UpdatePrintSettings() to use non-deprecated base::Value APIs.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3579297
* 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3581708: Restore original display when moving from tab-fullscreen to browser-fullscreen.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3581708
* chore: fix authorization flags lint error
* 3583363: Remove net wrappers around base/strings/escape.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* fixup! 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3587589: Reland "Propagate the MIME type from DownloadTargetDeterminer to DownloadItem"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587589
* 3584006: Remove IsRenderViewLive from content public
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3584006
* 3596174: [api] Remove APIs for resurrecting finalizers
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3596174
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: bump chromium in DEPS to 103.0.5030.0
* chore: update patches
* chore: bump chromium in DEPS to 103.0.5032.0
* chore: bump chromium in DEPS to 103.0.5034.0
* chore: bump chromium in DEPS to 103.0.5036.0
* chore: update patches
* 3586363: Introduce PrintRenderFrame.PrintWithParams() for batch printing to PDF
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3586363
* 3593199: Remove content::PermissionType references and replace them with blink::PermissionType
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3593199
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: lint
* chore: bump chromium in DEPS to 103.0.5038.0
* chore: update patches
* fixup! 3560622: serial: Add SerialPort.forget() method
* 3606495: mac screen capture: add metric
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3606495
* chore: bump chromium in DEPS to 103.0.5040.0
* chore: update patches
* 3590840: Add IPs to DnsOverHttpsServerConfig
https://chromium-review.googlesource.com/c/chromium/src/+/3590840
* stub functions for ElectronSerialDelegate and SerialChooserController to fix link
* 3566412: [base] Remove base/android dependency on post_task.h and officially remove post_task.h!
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 3347944: [content] No longer hand-off whole MainFunctionParams to BrowserMainParts
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3347944
* fixup! 3566412: [base] Remove base/android dependency on post_task.h and off…
e3ea3e1
…icially remove post_task.h!
* chore: update process_singleton patches for content::GetIOThreadTaskRunner({})
Ref: 2015655: [BrowserThread] Migrate co/pub/br and co/br/scheduler to the new API | https://chromium-review.googlesource.com/c/chromium/src/+/2015655
* chore: migrate base::DeleteSoon to content::GetUIThreadTaskRunner({})->DeleteSoon
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* chore: remove duplicate functions for RevokePortPermissionWebInitiated & GetPortInfo
* chore: migrate Linux/Windows methods off of post_task.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 64908: Stop building legacy SwiftShader GL in Chromium
https://swiftshader-review.googlesource.com/c/SwiftShader/+/64908
* 3573245: Added Themed versions of RoundedRectBackground and RoundedRectBorder.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3573245
* chore: bump chromium in DEPS to 103.0.5042.0
* chore: update patches
* 3571804: [api] Advance API deprecation for V8 version v10.2
https://chromium-review.googlesource.com/c/v8/v8/+/3571804
* fixup! 3571804: [api] Advance API deprecation for V8 version v10.2
* build: fix run-clang-format extension matching
* lint
* fix windows build
* how is clang-format still not working for me
* chore: update patches
* 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient.
https://chromium-review.googlesource.com/c/chromium/src/+/3623985
* no need to implement WillProvidePublicFirstPartySets; the default is false
* 3601036: [QT] Introduce ui/views/linux_ui/linux_ui_factory.*
https://chromium-review.googlesource.com/c/chromium/src/+/3601036
* 3583363: Remove net wrappers around base/strings/escape.h
https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* lint
* chore: bump chromium in DEPS to 103.0.5044.0
* fix conflicts
* chore: update patches
* upgrade nan
* pin version of nan in tests
* replace my hacky deprecated override fix with the fix from upstream
* revert runtime dcheck in v8
* pin nan version at root too
* refactor: tell gyp to use c++17 when building with our node
* Revert "refactor: tell gyp to use c++17 when building with our node"
This reverts commit 41a03a5799 .
* Undo the reversion of 41a03a5799 .
This reverts commit 54440abc59 .
* disable sequential/test-cpu-prof-kill for now
* also sequential/test-diagnostic-dir-cpu-prof
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-05-17 12:48:40 -04:00
mkiki01
04b33b319b
docs: added units to <webview>.print() pageSize option ( #34088 )
2022-05-17 11:59:24 -04:00
Shelley Vohr
97c9451efc
fix: WCO crash on bad titlebarStyle ( #34140 )
...
fix: WCO crash on bad titlebarStyle
2022-05-17 11:50:27 -04:00
Sudowoodo Release Bot
4e3587c7c6
Bump v20.0.0-nightly.20220517
2022-05-17 08:15:20 -07:00
Sudowoodo Release Bot
ccde8994b5
Revert "Bump v20.0.0-nightly.20220517"
...
This reverts commit 125c324a49 .
2022-05-17 08:12:04 -07:00
Sudowoodo Release Bot
125c324a49
Bump v20.0.0-nightly.20220517
2022-05-17 06:03:06 -07:00
Milan Burda
4aba68a59d
docs: add missing explanation for [angle|dawn]_enable_vulkan_validation_layers = false ( #34216 )
2022-05-16 16:18:01 -04:00
Shelley Vohr
7af0b58c98
test: add setTitlebarOverlay spec ( #34221 )
...
spec: add setTitlebarOverlay spec
2022-05-16 12:14:27 -04:00
Sudowoodo Release Bot
cc411946d7
Bump v20.0.0-nightly.20220516
2022-05-16 06:02:41 -07:00
Sudowoodo Release Bot
b06737fdac
Bump v20.0.0-nightly.20220513
2022-05-13 06:01:28 -07:00
Shelley Vohr
8b5613efcb
fix: fetching PDF element from WebLocalFrame ( #34176 )
...
fix: fetching PDF element from WebLocalFrame
2022-05-12 20:20:45 -04:00
Shelley Vohr
a8103691ac
fix: tray icon not highlighting on empty menu ( #34173 )
2022-05-12 16:14:11 +02:00
Sudowoodo Release Bot
142e1f667b
Bump v20.0.0-nightly.20220512
2022-05-12 06:02:20 -07:00
Samuel Maddock
ff5f66395e
chore: upgrade extract-zip for installer ( #34166 )
2022-05-12 10:18:42 +02:00
Samuel Attard
ba3aca8200
test: fix background transparency flake ( #34190 )
2022-05-12 09:41:58 +02:00
Shelley Vohr
d67532ee9f
fix: crash when loading extension with missing manifest ( #34168 )
...
* fix: crash when loading extension missing manifest
* Update electron_paks.gni
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
2022-05-11 13:41:06 -07:00
John Kleinschmidt
4f8a843606
docs: clarify added/removed events on device APIs ( #34177 )
2022-05-11 13:01:56 -07:00
Shelley Vohr
dd6ce91f57
fix: call loadUrl when opening new windows from links ( #34159 )
...
* fix: call loadUrl when opening new windows from links
* spec: add regression test
2022-05-11 11:34:33 -07:00
John Kleinschmidt
6f8a36f404
test: fixup done being called multiple times ( #34175 )
2022-05-11 10:23:24 -07:00
Keeley Hammond
c512993744
build: re-enable 32-bit Windows symbol generation ( #34162 )
2022-05-11 08:27:23 -07:00
FantasqueX
6063d4f8df
docs: fix typo in quick-start.md ( #34149 )
...
According to Jetbrains LanguageTool, "Consider using All the. "
2022-05-11 10:05:59 -04:00
Sudowoodo Release Bot
64dc90824b
Bump v20.0.0-nightly.20220511
2022-05-11 06:01:00 -07:00
Robo
79e1881b2a
chore: rm enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch ( #34157 )
...
* chore: rm enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch
* chore: update patch
2022-05-11 01:39:51 -07:00
Sudowoodo Release Bot
a853a6ce9f
Revert "Bump v20.0.0-nightly.20220510"
...
This reverts commit 5633c45c19 .
2022-05-10 18:40:53 -07:00
Sudowoodo Release Bot
5633c45c19
Bump v20.0.0-nightly.20220510
2022-05-10 18:39:00 -07:00
Jeremy Rose
9bcbe70dbe
test: run node specs with py3 ( #34154 )
2022-05-10 14:26:53 -07:00
Milan Burda
e76cf3e2ed
fix: building node modules with Visual Studio 2017 ( #34109 )
2022-05-10 14:26:07 -07:00
Keeley Hammond
627c2987ba
fix: create singleton pipename from user & executable ( #34139 )
...
* fix: create singleton pipename from user & executable
* fix: use process id & main thread id for pipe name
* fix: write rand to file using WIN method
* fix: remove file rand, add user_name to pipe
* chore: style fixes, shorten program_name & user_name
* fix: remove user_name
2022-05-10 13:24:40 -07:00
Sudowoodo Release Bot
7f5346b954
Revert "Bump v20.0.0-nightly.20220510"
...
This reverts commit 4fc42092b8 .
2022-05-10 10:33:23 -07:00
Sudowoodo Release Bot
4fc42092b8
Bump v20.0.0-nightly.20220510
2022-05-10 10:27:54 -07:00
Sudowoodo Release Bot
c8fbabae48
Revert "Bump v20.0.0-nightly.20220510"
...
This reverts commit b94f25c287 .
2022-05-10 09:14:27 -07:00
Sudowoodo Release Bot
b94f25c287
Bump v20.0.0-nightly.20220510
2022-05-10 09:05:20 -07:00
Sudowoodo Release Bot
5572659988
Revert "Bump v20.0.0-nightly.20220510"
...
This reverts commit 030087c1c7 .
2022-05-10 08:37:52 -07:00
Sudowoodo Release Bot
030087c1c7
Bump v20.0.0-nightly.20220510
2022-05-10 06:01:41 -07:00
electron-roller[bot]
5391211824
chore: bump node to v16.15.0 (main) ( #33947 )
...
* chore: bump node in DEPS to v16.15.0
* chore: update patches
* src: allow preventing InitializeInspector in env
https://github.com/nodejs/node/pull/35025
* chore: update node gn filenames
* crypto: change default check(Host|Email) behavior
* Revert "crypto: change default check(Host|Email) behavior"
This reverts commit 1f1eb23702 .
* update node crypto tests to work with boringssl
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-05-09 18:55:49 -04:00
Robo
00368aca37
chore: stub gtk_native_dialog_get_type ( #34141 )
2022-05-09 13:37:50 -07:00
Cheng Zhao
9483e714c4
feat: allow customizing browser data location ( #33554 )
...
* feat: redirect Electron/Chromium cache location
* fix: network services should also use browserData
* test: browserData
* chore: no need to explicitly create dir
* feat: browserData => sessionData
* test: check existings of specific items
* docs: add background on userData and sessionData
Co-authored-by: emmanuel.kimmerlin@thomsonreuters.com <emmanuel.kimmerlin@thomsonreuters.com >
2022-05-09 10:26:57 -04:00
Darshan Sen
03e68e2efe
fix: fix a crash in safeStorage on Linux ( #33913 )
...
On Linux, `isEncryptionAvailable()` was crashing instead of returning a
boolean before the 'ready' event was emitted by the app. The reason of
the crash is that [`CreateKeyStorage()`](https://source.chromium.org/chromium/chromium/src/+/main:components/os_crypt/os_crypt_linux.cc;l=74;drc=35be6215ec8f09e50176f36753c68f26c63d1885;bpv=1;bpt=0 )
expects the config to be set but the function responsible for setting the
config, [`SetConfig()`](https://source.chromium.org/chromium/chromium/src/+/main:components/os_crypt/os_crypt_linux.cc;l=237;drc=35be6215ec8f09e50176f36753c68f26c63d1885;bpv=1;bpt=0 ),
is called only after the app is ready inside [`PostCreateMainMessageLoop()`](https://github.com/electron/electron/blob/main/shell/browser/electron_browser_main_parts.cc#L499 ).
So this changes `IsEncryptionAvailable()` to return `false` when the app
is not ready on Linux and uses that instead of the raw API in other
places like `EncryptString()` and `DecryptString()`.
Fixes: https://github.com/electron/electron/issues/32206
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-05-09 09:38:53 -04:00
Keeley Hammond
6fea35271c
build: change upload-to-s3 vars to upload-to-storage ( #34105 )
...
* build: change upload-to-s3 vars to upload-to-az
* build: change upload-to-az to upload-to-storage
2022-05-09 09:34:17 -04:00
Sudowoodo Release Bot
dd7dfd7ecd
Bump v20.0.0-nightly.20220509
2022-05-09 06:01:36 -07:00
Raymond Zhao
3ba60de51d
docs: add missing ackCallback parameter ( #34126 )
2022-05-06 13:24:14 -07:00
Sudowoodo Release Bot
1bdbb69351
Bump v20.0.0-nightly.20220506
2022-05-06 12:58:25 -07:00
Keeley Hammond
2900bc55aa
build: remove ending slash upload-index-json ( #34125 )
2022-05-06 12:57:18 -07:00
Sudowoodo Release Bot
0d35084ada
Revert "Bump v20.0.0-nightly.20220506"
...
This reverts commit 0f2da5c830 .
2022-05-06 08:14:11 -07:00
Sudowoodo Release Bot
0f2da5c830
Bump v20.0.0-nightly.20220506
2022-05-06 06:01:48 -07:00
Samuel Attard
808efd89ed
build: use azure function to hash assets instead of lambda ( #34117 )
2022-05-06 02:42:34 -07:00
Keeley Hammond
0696320d28
build: remove S3 uploads ( #34104 )
2022-05-05 21:40:34 -07:00
Shelley Vohr
a401360057
refactor: prevent RemoveFromLoginItems() from mounting volumes from login items ( #34068 )
2022-05-05 20:46:36 -04:00
Jeremy Rose
d8a7219d07
chore: stop using v8::Locker everywhere ( #34078 )
2022-05-05 11:50:21 -07:00
Samuel Attard
a2a8e493eb
test: unflake some more tests ( #34084 )
...
* test: unflake webview fullscreen test
* test: unflake net throttle test
* Update spec-main/api-net-spec.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-05-05 11:42:38 -07:00
Shelley Vohr
90eb47f70b
fix: offscreen rendering crash on input select ( #34069 )
2022-05-05 09:53:39 -04:00
Sudowoodo Release Bot
323f7d4c19
Bump v20.0.0-nightly.20220505
2022-05-05 06:01:44 -07:00
Jeremy Rose
706d585eb8
build: fix run-clang-format extension matching ( #34076 )
2022-05-05 10:41:52 +02:00
Raymond Zhao
5b648854d5
fix: requestSingleInstanceLock API sometimes hangs ( #33777 )
2022-05-04 13:30:30 -04:00
Milan Burda
2091343b78
refactor: initialize member variables directly ( #34046 )
2022-05-04 16:30:05 +02:00
Sudowoodo Release Bot
4fad376b0e
Bump v20.0.0-nightly.20220504
2022-05-04 06:04:36 -07:00
Samuel Attard
60f1e5e008
test: unflake some focus tests ( #34061 )
...
* spec: unflake some focus tests
* test: disable flaky webFrame visibiilty spec
2022-05-04 01:29:30 -07:00
Milan Burda
349cd98b0a
test: fix nativeModulesEnabled in spec/webview-spec.js ( #34027 )
2022-05-03 23:56:45 -07:00
Samuel Attard
747dfe5851
build: remove dead circle config bits ( #34034 )
2022-05-03 12:06:25 -07:00
Milan Burda
658407df7a
test: fix require('echo') -> require('@electron-ci/echo') ( #34026 )
2022-05-03 11:49:01 -04:00
Sudowoodo Release Bot
0893733496
Bump v20.0.0-nightly.20220503
2022-05-03 06:02:57 -07:00
Darshan Sen
f887000d50
fix: make BrowserWindow#isFocused() return false when blur() is called on macOS ( #33734 )
...
The isFocused() method on macOS works by checking if the selected
BrowserWindow is a key window. Unfortunately, this didn't work well
with blur() because it wasn't calling any macOS APIs that would change
the key status of the window. Hence, this changes the implementation of
blur() to call orderOut first, which removes the key
status of the window. Then when the orderBack function is called, it
moves the window to the back of its level in the screen list, without
changing the key window.
Fixes: https://github.com/electron/electron/issues/33732
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-05-03 16:39:18 +09:00
Ruben R
7dee5179cb
Handle SIGUSR2 ( #33589 )
...
`start-server-webpack-plugin` uses `SIGUSR2` to signal an HMR update to a server process: https://github.com/ericclemmons/start-server-webpack-plugin/blob/master/src/StartServerPlugin.js#L70
Note that this signal does not actually kill the child process, but merely functions as a message-passing system.
2022-05-03 10:36:06 +09:00
John Kleinschmidt
a71936e395
test: skip flaky test on 32-bit Windows ( #34021 )
2022-05-02 21:08:20 -04:00
Jamie Magee
e1ed96b574
test: scope internal test fixtures under @electron-ci ( #33822 )
...
* test: scope internal test fixtures under `@electron`
* Missed references
* Move packages from @electron to @electron-ci scope
* Fix tests
2022-05-02 13:09:23 -04:00
Kevin Ushey
9901d2f281
fix: support mixed-case extensions in Linux file dialogs ( #33918 )
2022-05-02 11:54:17 -04:00
Keeley Hammond
14f07d7814
fix: move FirstPartySets into the browser process ( #33998 )
...
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3448551
2022-05-02 08:20:30 -07:00
Sudowoodo Release Bot
6f851afab5
Bump v20.0.0-nightly.20220502
2022-05-02 06:01:26 -07:00
Milan Burda
682d2e3f78
build: allow script/spec-runner.js with empty list of runners ( #33982 )
2022-05-02 14:49:13 +09:00
Milan Burda
b55f9d868a
spec: allow connections to port 2049 ( #33983 )
2022-04-30 04:29:05 -07:00
Sudowoodo Release Bot
ce562b6889
Bump v20.0.0-nightly.20220429
2022-04-29 06:01:34 -07:00
Keeley Hammond
015185ad5a
fix: fix FirstPartySetsHandler initialization ( #33971 )
2022-04-28 22:17:19 -07:00
Shelley Vohr
fb534c927a
refactor: better solution for resizable frameless DCHECK ( #33790 )
...
* refactor: better solution for resizable frameless DCHECK
* fix: also implement TargetForRectin WinFrameView
2022-04-28 20:34:12 -04:00
Jacek Oleksy
192a7fad0d
fix: disable MallocNanoZone on mac ( #33704 )
2022-04-28 10:28:27 -04:00
Sudowoodo Release Bot
097da1d4ba
Bump v20.0.0-nightly.20220428
2022-04-28 06:01:07 -07:00
Samuel Attard
b3530d5df8
build: use smaller resource_class because goma ( #33905 )
2022-04-28 03:17:05 -07:00
Darshan Sen
b5297ea8e2
docs: fix return type of setJumpList() in electron.d.ts ( #33910 )
...
Before:
```ts
setJumpList(categories: (JumpListCategory[]) | (null)): void;
```
After:
```ts
setJumpList(categories: (JumpListCategory[]) | (null)): ('ok' | 'error' | 'invalidSeparatorError' | 'fileTypeRegistrationError' | 'customCategoryAccessDeniedError');
```
Fixes: https://github.com/electron/electron/issues/33909
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-04-28 03:15:23 -07:00
Baoshuo Ren
15c931201a
chore: remove git.io ( #33933 )
...
* chore: remove git.io
All links on git.io will stop redirecting after April 29, 2022.
- https://github.blog/changelog/2022-04-25-git-io-deprecation/
* fix: lint
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-04-27 15:56:01 -04:00
Samuel Attard
f91b24deb5
build: ensure sync-done file exists during git cache save ( #33949 )
2022-04-27 15:54:52 -04:00
Samuel Attard
d2c3e78117
build: actually verify az urls too ( #33929 )
2022-04-27 10:37:26 -07:00
Sudowoodo Release Bot
a00544c745
Bump v20.0.0-nightly.20220427
2022-04-27 06:00:58 -07:00
Samuel Attard
160d6923db
build: improve CI speeds and reduce CI costs ( #33904 )
...
* rely on src cache instead of workspace
* run some tasks in the background and "thread join" later
* merge some ninja build commands to reduce overhead
2022-04-26 23:14:59 -07:00
Samuel Attard
6d5501d0bd
build: use dev-cdn instead of sysroots s3 bucket ( #33922 )
2022-04-26 15:21:59 -07:00
Sudowoodo Release Bot
bfabd67112
Bump v20.0.0-nightly.20220426
2022-04-26 06:01:17 -07:00
Sudowoodo Release Bot
40c022ad69
Bump v20.0.0-nightly.20220425
2022-04-25 14:01:18 -07:00
John Kleinschmidt
028a72daac
build: fix macos release GN gen ( #33915 )
2022-04-25 14:00:32 -07:00
John Kleinschmidt
6a1748da06
ci: update release script to handle new CircleCI configs ( #33914 )
2022-04-25 11:14:16 -04:00
Sudowoodo Release Bot
0a73f60423
Revert "Bump v20.0.0-nightly.20220425"
...
This reverts commit f48a921d14 .
2022-04-25 06:47:42 -07:00
Sudowoodo Release Bot
f48a921d14
Bump v20.0.0-nightly.20220425
2022-04-25 06:02:58 -07:00
electron-roller[bot]
f3e0517b6e
chore: bump chromium to 102.0.4999.0 (main) ( #33731 )
...
* chore: bump chromium in DEPS to 102.0.4999.0
* 3576640: Set OOM handler during V8 initialization
https://chromium-review.googlesource.com/c/chromium/src/+/3576640
* 3574964: Remove deprecated base::Value usage in print_settings_conversion code.
https://chromium-review.googlesource.com/c/chromium/src/+/3574964
* 3570062: Replicate Active state to render process for all RenderViews.
https://chromium-review.googlesource.com/c/chromium/src/+/3570062
* chore: fixup patch indices
* 3380402: Remove legacy SwiftShader
https://chromium-review.googlesource.com/c/chromium/src/+/3380402
* 3570254: [Local Fonts] Rename permission name from FONT_ACCESS to LOCAL_FONTS.
https://chromium-review.googlesource.com/c/chromium/src/+/3570254
* 3572172: Rename or remove several parameters involved in creation of MimeHandler streams
https://chromium-review.googlesource.com/c/chromium/src/+/3572172
* fix: add missing base/bits include
* chore: fix lint
* chore: remove ia32 Linux support
* chore: patch out swift-format cipd dep on macOS
* build: apply patch better
* build: reset all caches
* build: update zip manifests to remove swiftshared libraries
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3380402
* Revert "build: update zip manifests to remove swiftshared libraries"
This reverts commit 6aeec01ef1a79425a7b7d8c1cfb131a26b91c494.
* Revert "3380402: Remove legacy SwiftShader"
This reverts commit 4c7eebbbf2d0a459cc192959e17ae20f970c2da2.
* build: remove unused swiftshader egl libraries
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <sattard@salesforce.com >
2022-04-22 15:36:22 -07:00
Sudowoodo Release Bot
53c3dd68b2
Revert "Bump v20.0.0-nightly.20220422"
...
This reverts commit 283e4826af .
2022-04-22 11:45:02 -07:00
Sudowoodo Release Bot
283e4826af
Bump v20.0.0-nightly.20220422
2022-04-22 11:40:22 -07:00
Sudowoodo Release Bot
e571417c52
Revert "Bump v20.0.0-nightly.20220422"
...
This reverts commit a5501d7118 .
2022-04-22 09:22:41 -07:00
Sudowoodo Release Bot
a5501d7118
Bump v20.0.0-nightly.20220422
2022-04-22 09:18:12 -07:00
Sudowoodo Release Bot
0c8c755ffb
Revert "Bump v20.0.0-nightly.20220422"
...
This reverts commit bb146e3deb .
2022-04-22 09:17:29 -07:00
Sudowoodo Release Bot
bb146e3deb
Bump v20.0.0-nightly.20220422
2022-04-22 06:01:30 -07:00
Samuel Attard
33e9bfd99b
build: improve circleci config ( #33881 )
...
* build: fix conditional restore of git cache
* build: split lint out of setup.yml
2022-04-21 14:34:25 -07:00
Sudowoodo Release Bot
e864bc44c6
Bump v20.0.0-nightly.20220421
2022-04-21 06:05:18 -07:00
Milan Burda
64517b36ef
build: fix intermittent compilation failures on macOS ( #33768 )
...
* build: fix intermittent compilation failures on macOS
* chore: remove //base dependency from main executable
* chore: fix lint
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-04-21 17:25:51 +09:00
Robo
00021a41b1
chore: backport 7c9b3938d from libuv ( #33815 )
...
Backports https://github.com/libuv/libuv/pull/3597
2022-04-21 10:38:47 +09:00
Robo
b53118ca28
fix: adopt partition alloc early initialization ( #33832 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3298858
2022-04-20 13:52:15 -07:00
Jeremy Rose
0c864837af
chore: use semantic-commit-action ( #33857 )
...
* chore: use semantic-commit-action
* Update semantic.yml
2022-04-20 16:49:59 -04:00
Sudowoodo Release Bot
fec147a0cb
Bump v20.0.0-nightly.20220420
2022-04-20 06:01:22 -07:00
Samuel Attard
841e0a4e0c
fix: include accessibility blink strings ( #33840 )
2022-04-19 20:00:51 -07:00
Sudowoodo Release Bot
31c2b5703a
Bump v20.0.0-nightly.20220419
2022-04-19 06:00:47 -07:00
Darshan Sen
6733279037
docs: document when BrowserWindow and BrowserView can be used ( #33696 )
...
We already document such info for other APIs, like the 'screen' API in
f711fe6b57/docs/api/screen.md (L7-L8) .
So we should do the same thing for these ones too.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-04-18 10:11:44 -04:00
Samuel Attard
2d0ad04354
docs: update security guide regarding ctx isolation ( #33807 )
2022-04-18 10:09:54 -04:00
Sudowoodo Release Bot
5ae234d5e1
Bump v20.0.0-nightly.20220418
2022-04-18 06:38:13 -07:00
Robo
0f087127de
chore: fix patch conflicts from 37b7e347 ( #33818 )
...
* chore: update patches
* chore: address review feedback
2022-04-18 09:36:17 -04:00
Sudowoodo Release Bot
b9c0166b49
Revert "Bump v20.0.0-nightly.20220418"
...
This reverts commit fd191fc50b .
2022-04-18 06:35:44 -07:00
Sudowoodo Release Bot
fd191fc50b
Bump v20.0.0-nightly.20220418
2022-04-18 06:01:41 -07:00
Robo
37b7e347fc
fix: potential crash caused by dlopen different gtk libraries ( #33650 )
2022-04-18 13:24:32 +09:00
Sudowoodo Release Bot
9d4aceb940
Bump v20.0.0-nightly.20220415
2022-04-15 09:32:01 -07:00
Sudowoodo Release Bot
eee4232069
Bump v20.0.0-nightly.20220414
2022-04-14 20:08:45 -07:00
Sudowoodo Release Bot
635b3a94c8
Revert "Bump v20.0.0-nightly.20220414"
...
This reverts commit 99791f620b .
2022-04-14 20:08:02 -07:00
Sudowoodo Release Bot
99791f620b
Bump v20.0.0-nightly.20220414
2022-04-14 18:08:45 -07:00
Keeley Hammond
8b0af86097
ci: build python2 from source ( #33793 )
...
* ci: add python2 to publish jobs
* chore: install python2 via circle
2022-04-14 18:07:51 -07:00
Sudowoodo Release Bot
f5e874cbcb
Revert "Bump v20.0.0-nightly.20220414"
...
This reverts commit dda8bc3cd1 .
2022-04-14 07:03:05 -07:00
Sudowoodo Release Bot
dda8bc3cd1
Bump v20.0.0-nightly.20220414
2022-04-14 06:13:26 -07:00
Shelley Vohr
233a39dbc9
fix: event propagation after exiting fullscreen on Windows ( #33757 )
2022-04-14 12:35:36 +02:00
Keeley Hammond
7658edfa1a
ci: manually install python@2 ( #33785 )
2022-04-14 09:53:05 +02:00
Robo
16f8d713ab
fix: apply senderFrame details to ipcMain port event ( #33756 )
2022-04-13 21:01:00 -07:00
Keeley Hammond
3d4d39d67b
chore: interpret bytes to string ( #33766 )
2022-04-13 14:51:00 -07:00
Shelley Vohr
b66667b843
feat: allow null when subscribing notification ( #33641 )
...
* feat: allow null when subscribing notification
* docs: document null event
2022-04-13 22:02:33 +02:00
Shelley Vohr
bfbba9dad6
chore: add missing GN dep ( #33758 )
2022-04-13 10:55:57 -07:00
Shelley Vohr
341b7bdf4a
fix: #ARGB to #RGBA conversion ( #33707 )
...
* fix: argb to rgba conversion
* chore: remove logging import
* refactor: color_str -> converted_color_str
2022-04-13 10:46:05 +02:00
Sudowoodo Release Bot
4c4e02318f
Revert "Bump v20.0.0-nightly.20220412"
...
This reverts commit de2f48b40f .
2022-04-12 23:49:32 -07:00
Sudowoodo Release Bot
de2f48b40f
Bump v20.0.0-nightly.20220412
2022-04-12 21:26:21 -07:00
Sudowoodo Release Bot
a9c52926c0
Revert "Bump v20.0.0-nightly.20220412"
...
This reverts commit 7038d2d418 .
2022-04-12 21:25:04 -07:00
Jeremy Rose
bfa5b21044
docs: note reason for is_cfi = false ( #33749 )
2022-04-12 21:00:03 -07:00
Samuel Attard
d804cd5de2
build: add comment for enable_cet_shadow_stack ( #33747 )
2022-04-12 16:23:07 -07:00
Sudowoodo Release Bot
7038d2d418
Bump v20.0.0-nightly.20220412
2022-04-12 16:14:58 -07:00
Sudowoodo Release Bot
b8c0ef9713
Revert "Bump v20.0.0-nightly.20220412"
...
This reverts commit c5b93eaf17 .
2022-04-12 16:13:49 -07:00
Sudowoodo Release Bot
c5b93eaf17
Bump v20.0.0-nightly.20220412
2022-04-12 14:10:26 -07:00
Keeley Hammond
2ca46058cd
build: migrate urllib to python3 ( #33737 )
2022-04-12 14:07:40 -07:00
Shelley Vohr
3057ff0120
docs: note safeStorage.isEncryptionAvailable() needs ready event ( #33724 )
2022-04-12 12:47:15 -07:00
Sudowoodo Release Bot
48edb2c707
Revert "Bump v20.0.0-nightly.20220412"
...
This reverts commit 56ab3d73c6 .
2022-04-12 12:06:19 -07:00
Sudowoodo Release Bot
56ab3d73c6
Bump v20.0.0-nightly.20220412
2022-04-12 08:05:06 -07:00
Sudowoodo Release Bot
0287c3f511
Revert "Bump v20.0.0-nightly.20220412"
...
This reverts commit 1c53fc4331 .
2022-04-12 07:52:41 -07:00
Sudowoodo Release Bot
1c53fc4331
Bump v20.0.0-nightly.20220412
2022-04-12 06:00:49 -07:00
Jeremy Rose
c0d442364a
build: explicitly run scripts with python3 ( #33720 )
...
* build: explicitly run scripts with python3
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-04-12 13:21:55 +02:00
electron-roller[bot]
59dd17f2cf
chore: bump chromium to 102.0.4989.0 (main) ( #33557 )
...
* chore: bump chromium in DEPS to 102.0.4975.0
* chore: bump chromium in DEPS to 102.0.4977.0
* chore: update patches
* Remove parameter of OnGpuProcessCrashed()
https://chromium-review.googlesource.com/c/chromium/src/+/3543396
* hid: Add exclusionFilters option to requestDevice
https://chromium-review.googlesource.com/c/chromium/src/+/3478175
* chore: bump chromium in DEPS to 102.0.4979.0
* chore: bump chromium in DEPS to 102.0.4981.0
* chore: update patches
* Deny notification/push permission for documents in non-standard StoragePartitions
https://chromium-review.googlesource.com/c/chromium/src/+/3257305
* Improve FrameTreeNode tracking in URLLoaderNetworkContext
https://chromium-review.googlesource.com/c/chromium/src/+/3341866
* fixup! Remove parameter of OnGpuProcessCrashed()
* chore: fix lint
* Reland "Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome"
https://chromium-review.googlesource.com/c/chromium/src/+/3554236
* chore: bump chromium in DEPS to 102.0.4983.0
* Ensure EyeDropperView does not access a destroyed window
https://chromium-review.googlesource.com/c/chromium/src/+/3561542
* ci: don't delete dawn .git directory
83901: Adds a generated file with the dawn git hash encoded at build time. | https://dawn-review.googlesource.com/c/dawn/+/83901
* ci: update Windows toolchain
3550827: New toolchain for Windows 10 20348 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/3550827
* chore: bump chromium in DEPS to 102.0.4985.0
* chore: update patches
* chore: bump chromium in DEPS to 102.0.4987.0
* chore: update patches
* 3563432: codehealth: remove uses of DictionaryValue in cbui/webui
https://chromium-review.googlesource.com/c/chromium/src/+/3563432
* chore: update patches after rebase
* Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome
https://chromium-review.googlesource.com/c/chromium/src/+/3554236
* 3565724: Preserve "proper method names" as-is in error.stack.
https://chromium-review.googlesource.com/c/v8/v8/+/3565724
* chore: bump chromium in DEPS to 102.0.4989.0
* chore: update patches
* fixup ci: don't delete dawn .git directory for Windows
* 3560843: Remove multi-parameter version of gfx::Rect[F]::Inset()
https://chromium-review.googlesource.com/c/chromium/src/+/3560843
* 3572711: Remove unused IDS_PDF_TOOLTIP_ROTATE_CW resource.
https://chromium-review.googlesource.com/c/chromium/src/+/3572711
* 3572926: Reland "[Sysroot] Switch to Debian Bullseye stable"
https://chromium-review.googlesource.com/c/chromium/src/+/3572926
* build: fixup sysroots with electron specific dependencies
* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()
* fixup 3565724: Preserve "proper method names" as-is in error.stack.
* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()
* test: add spec for navigator.hid.requestDevice({ exclusionFilters: [...] }
* fixup 3565724: Preserve "proper method names" as-is in error.stack.
* ci: use python3 to get the windows toolchain profile
3525960: Explicitly run everything with python3 | https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525960
* chore: add diagnostic logging
* fix: try calling process.crash()
* chore: remove logging
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-04-12 13:19:14 +02:00
Shelley Vohr
e8ed9cb4b5
test: re-enable disabled ScriptOrModule specs ( #33702 )
2022-04-12 12:00:42 +02:00
Jeremy Rose
c9fd255093
build: use python3 to lint ( #33627 )
2022-04-11 16:05:21 -07:00
Shelley Vohr
caddc83cfe
feat: implement chrome.tabs.reload ( #33560 )
2022-04-11 22:51:10 +02:00
Sudowoodo Release Bot
a7a5e7fcfd
Bump v20.0.0-nightly.20220411
2022-04-11 11:23:37 -07:00
Sudowoodo Release Bot
207d4e5823
Revert "Bump v20.0.0-nightly.20220411"
...
This reverts commit 8e2310db31 .
2022-04-11 11:22:06 -07:00
Sudowoodo Release Bot
8e2310db31
Bump v20.0.0-nightly.20220411
2022-04-11 11:08:17 -07:00
Sudowoodo Release Bot
6872306117
Revert "Bump v20.0.0-nightly.20220411"
...
This reverts commit 9d6e6c45c1 .
2022-04-11 11:03:28 -07:00
Keeley Hammond
41c1a7e318
chore: modify uploaded assets for win-ia32 ( #33699 )
...
* chore: filter correct symbol files
* chore: upload correct assets
2022-04-11 11:02:01 -07:00
Sudowoodo Release Bot
9d6e6c45c1
Bump v20.0.0-nightly.20220411
2022-04-11 06:01:10 -07:00
Sudowoodo Release Bot
f711fe6b57
Bump v20.0.0-nightly.20220408
2022-04-08 06:04:36 -07:00
John Kleinschmidt
94c2a7671c
build: temporarily disable 32-bit Windows symbol generation ( #33653 )
...
* build: temporarily disable 32-bit Windows symbol generation
* fix: modify upload.py
* chore: fix comment
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
2022-04-08 04:17:51 -07:00
Milan Burda
4d4682c0e3
fix: report more detailed errors in shell.openExternal() on Windows ( #33620 )
2022-04-07 11:07:39 -07:00
Sudowoodo Release Bot
7fb1c8faad
Revert "Bump v20.0.0-nightly.20220407"
...
This reverts commit ba8e7b9638 .
2022-04-07 08:59:17 -07:00
Sudowoodo Release Bot
ba8e7b9638
Bump v20.0.0-nightly.20220407
2022-04-07 06:02:15 -07:00
Cheng Zhao
75ccec7996
docs: recommend setting e.returnValue ( #33628 )
2022-04-07 09:39:51 +02:00
Inclusive Coding Bot
68d6d8d451
chore: switch to gender neutral terms ( #33532 )
...
* Switch to gender neutral terms
* Update docs/api/web-contents.md
Co-authored-by: Milan Burda <milan.burda@gmail.com >
* Update docs/api/webview-tag.md
Co-authored-by: Milan Burda <milan.burda@gmail.com >
* Update script/release/uploaders/upload.py
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
* Update docs/tutorial/in-app-purchases.md
Co-authored-by: Milan Burda <milan.burda@gmail.com >
Co-authored-by: inclusive-coding-bot <inclusive-coding-bot@github.com >
Co-authored-by: Milan Burda <milan.burda@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2022-04-06 17:19:32 -04:00
Jeremy Rose
0168aede8e
chore: use //chrome resources directly ( #33626 )
2022-04-06 09:34:35 -07:00
Sudowoodo Release Bot
a05d9be44f
Bump v20.0.0-nightly.20220406
2022-04-06 06:01:36 -07:00
Shelley Vohr
f95e565884
chore: combine some smaller MAS patches ( #33595 )
...
* chore: combine some smaller MAS patches
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-04-06 13:40:52 +02:00
David Sanders
4615fc53ca
chore: fix typo in NotifyWindowRequestPreferredWidth method name ( #33568 )
2022-04-05 11:25:07 -05:00
Sudowoodo Release Bot
927ab3104d
Revert "Bump v20.0.0-nightly.20220404"
...
This reverts commit df34d20a21 .
2022-04-05 09:17:12 -07:00
Shelley Vohr
cc3743bd43
fix: remove usage of private pid API on MAS ( #33594 )
2022-04-05 09:09:12 -07:00
Samuel Attard
fcbdaab5e3
fix: add missing translation string for ax tree ( #33614 )
2022-04-04 20:22:36 -07:00
Samuel Attard
a72acfc535
fix: revert "fix: some frameless windows showing a frame on Windows ( #32692 )" ( #33599 )
...
This reverts commit 7c701367c0 .
2022-04-04 17:01:12 -07:00
Samuel Attard
477aa389e6
build: disable RDP
2022-04-04 16:25:32 -07:00
Samuel Attard
1ada5d7ddf
Revert "Revert "build: enable RDP for release builds""
...
This reverts commit dce6c23b33 .
2022-04-04 16:25:19 -07:00
Samuel Attard
dce6c23b33
Revert "build: enable RDP for release builds"
...
This reverts commit d309558f64 .
2022-04-04 16:25:10 -07:00
Sudowoodo Release Bot
df34d20a21
Bump v20.0.0-nightly.20220404
2022-04-04 15:50:33 -07:00
Samuel Attard
d309558f64
build: enable RDP for release builds
2022-04-04 15:49:43 -07:00
Sudowoodo Release Bot
128560c4ac
Revert "Bump v20.0.0-nightly.20220404"
...
This reverts commit bff1a37791 .
2022-04-04 15:49:20 -07:00
Sudowoodo Release Bot
bff1a37791
Bump v20.0.0-nightly.20220404
2022-04-04 15:46:28 -07:00
Samuel Attard
fcd7dbfa5c
build: enable RDP for release builds
2022-04-04 15:45:11 -07:00
Sudowoodo Release Bot
58386fbf43
Revert "Bump v20.0.0-nightly.20220404"
...
This reverts commit 5985e6fd76a552b9647eb81c0fbaf9f609b11935.
2022-04-04 15:44:53 -07:00
Sudowoodo Release Bot
09251fe24c
Bump v20.0.0-nightly.20220404
2022-04-04 15:44:53 -07:00
Samuel Attard
18db9c551d
Revert "build: enable RDP for release builds"
...
This reverts commit c2449c421c .
2022-04-04 15:43:57 -07:00
Samuel Attard
c2449c421c
build: enable RDP for release builds
2022-04-04 15:43:36 -07:00
Sudowoodo Release Bot
e28bde9947
Revert "Bump v20.0.0-nightly.20220404"
...
This reverts commit f287b0b382 .
2022-04-04 07:31:00 -07:00
Sudowoodo Release Bot
f287b0b382
Bump v20.0.0-nightly.20220404
2022-04-04 06:03:57 -07:00
Samuel Attard
204b53e7b8
build: upload to AZ as well as S3 ( #33573 )
...
* build: upload to AZ aswell as S3
* fix: provide env to azput
2022-04-04 02:32:57 -07:00
David Sanders
0ac6d74536
docs: mark platform-specific functionality for BrowserWindow ( #33512 )
2022-04-04 18:00:45 +09:00
Micha Hanselmann
78a3752ade
fix: create userData on requestSingleInstanceLock() if needed ( #33559 )
...
* test: use custom userData folder for requestSingleInstanceLock()
* update test
* prefix test folder path
* fix: create userDataDir on requestSingleInstanceLock() if needed
* Trigger Build
2022-04-04 10:39:55 +09:00
Sudowoodo Release Bot
9207c2aa68
Revert "Bump v20.0.0-nightly.20220401"
...
This reverts commit 1864edd287 .
2022-04-01 09:52:10 -07:00
Sudowoodo Release Bot
1864edd287
Bump v20.0.0-nightly.20220401
2022-04-01 06:02:12 -07:00
Sudowoodo Release Bot
9722ca78b2
Revert "Bump v20.0.0-nightly.20220331"
...
This reverts commit 7612df7687 .
2022-03-31 12:14:36 -07:00
Sudowoodo Release Bot
7612df7687
Bump v20.0.0-nightly.20220331
2022-03-31 06:01:00 -07:00
Cheng Zhao
cbd06cd25e
docs: remove "cache" from app.getPath ( #33509 )
2022-03-31 09:33:38 +09:00
Shelley Vohr
8c8642634d
fix: don't unmaximize on macOS if user set max bounds ( #33480 )
2022-03-31 00:29:02 +02:00
Robo
afe0116d59
fix: build when pdf component is disabled ( #33513 )
2022-03-30 11:55:38 -07:00
electron-roller[bot]
b711860d21
chore: bump chromium to 102.0.4971.0 (main) ( #33454 )
...
* chore: bump chromium in DEPS to 102.0.4965.0
* chore: 3-way merge of chromium/printing.patch
* chore: update patch shear in chromium/picture-in-picture.patch
* chore: update patches
* 3101519: Window Placement: Prototype fullscreen companion window support
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3101519
build: add popup_preventer.cc, .h to our library. It's needed because
FullscreenController, we were already using, started aggregating a
PopupPreventer in 3101519.
* chore: bump chromium in DEPS to 102.0.4967.0
* Revert "3101519: Window Placement: Prototype fullscreen companion window support"
This reverts commit fc215cb99c464e939882ed3f5cf8e9874a8e3311.
Adding popup_preventer might not be the right solution; there are
cascading dependencies.
* 3551449: Add service-based usage for system print settings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3551449
chore: fix code shear in patches/chromium/printing.patch
* chore: update patches
* chore: bump chromium in DEPS to 102.0.4969.0
* chore: update patches
* chore: bump chromium in DEPS to 102.0.4971.0
* chore: update fix_patch_out_permissions_checks_in_exclusive_access.patch
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3101519
PopupunderPreventer is not useful in //electron since the window
attributes are controlled by the user via setWindowOpenHandler.
* chore: update patches
* Add FirstPartySetsHandler as a interface class in content API.
https://chromium-review.googlesource.com/c/chromium/src/+/3503410
* Create a new MediaStreamRequestType for GetOpenDevice
https://chromium-review.googlesource.com/c/chromium/src/+/3541939
* Support site isolation for <webview> tags in WebViewRendererState.
https://chromium-review.googlesource.com/c/chromium/src/+/3537735
* ci: update xcode version
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3544199
https://developer.apple.com/documentation/screencapturekit/capturing_screen_content_in_macos
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-03-30 14:08:58 -04:00
Cheng Zhao
929fc8bea5
test: make test apps' name prefixed with electron-test- ( #33511 )
2022-03-30 13:17:34 -04:00
John Kleinschmidt
a508dce1bf
ci: save Windows artifacts at end of job in case they fail ( #33510 )
2022-03-30 09:50:26 -04:00
Sudowoodo Release Bot
f13f07023f
Bump v20.0.0-nightly.20220330
2022-03-30 06:01:28 -07:00
Shelley Vohr
aac546368f
test: re-enable test-child-process-stdio-overlapped ( #33502 )
2022-03-30 12:51:13 +02:00
Cheng Zhao
c119b1ebef
chore: remove redundant code in node integration ( #33500 )
2022-03-29 20:09:42 -07:00
Samuel Attard
df3cfb663c
refactor: use posix_spawn instead of NSTask so we can disclaim the spawned ShipIt executable ( #33468 )
2022-03-29 19:50:59 -07:00
Mitchell Cohen
a9296229c8
feat: add app.isHidden API for macOS ( #32155 )
...
* feat: add app.isHidden API
* Update docs/api/app.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
* fixed isHidden tests
* Update docs/api/app.md
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
* Update spec-main/api-app-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2022-03-29 21:34:07 -04:00
David Sanders
9c3b159b95
fix: on macOS show BrowserWindow on maximize if not currently shown ( #32949 )
2022-03-29 19:08:34 -04:00
Keeley Hammond
89c1abd1b3
chore: bump NMV for Electron 20 ( #33476 )
2022-03-29 16:07:55 -07:00
dependabot[bot]
10f67e64f9
build(deps): bump ansi-regex from 3.0.0 to 3.0.1 in /spec ( #33484 )
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-29 18:47:46 -04:00
Shelley Vohr
0615fadead
chore: set v8_typed_array_max_size_in_heap to default ( #33496 )
2022-03-29 15:34:44 -07:00
Samuel Attard
479f652f90
feat: add new Squirrel.Mac bundle installation method behind flag ( #33470 )
2022-03-29 14:47:34 -07:00
Samuel Attard
4c988a5a24
docs: fix type of 'value' param in setUserDefaults ( #33481 )
2022-03-29 14:47:06 -07:00
dependabot[bot]
94498b923e
build(deps): bump minimist from 1.2.5 to 1.2.6 in /spec-main ( #33431 )
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-29 12:25:40 -04:00
Shelley Vohr
d1ea62c3e8
fix: getting focused window with destroyed webContents ( #33404 )
...
* fix: getting focused window with destroyed webContents
* fix: add extra safeguards
2022-03-29 12:22:58 -04:00
Shelley Vohr
8ea0631b82
test: re-enable desktop specs ( #33497 )
2022-03-29 11:57:21 -04:00
Shelley Vohr
f0c22a770d
chore: fix moveAbove desktopCapturer spec ( #33471 )
2022-03-29 16:05:08 +02:00
dependabot[bot]
bf3d0e2257
build(deps-dev): bump minimist from 1.2.5 to 1.2.6 ( #33432 )
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-29 15:39:38 +02:00
Sudowoodo Release Bot
9a2b35163e
Bump v19.0.0-nightly.20220329
2022-03-29 06:01:08 -07:00
Cheng Zhao
4e66b072da
chore: update libuv patch for event loop integration ( #31647 )
...
* chore: update libuv patch for loop integration
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-03-29 19:03:07 +09:00
Joseph
6b66fea67d
docs: update heading level of webFrame.insertCSS ( #33467 )
2022-03-29 16:02:30 +09:00
John Kleinschmidt
37a94d9857
ci: fixup esbuild on macos ( #33486 )
...
* ci: fixup esbuild on macos
* ci: call update_depot_tools right after clone
* when all else fails, use sed
2022-03-28 20:57:11 -07:00
Gellert Hegyi
4aeeb64d30
fix: crash when WindowButtonsProxy references cleared NSWindow ( #33069 )
...
* resets WindowButtonsProxy on window delete on macOS
* fixes reset
2022-03-28 23:02:44 -04:00
Calvin
594dc7e24a
chore: update node types version ( #33452 )
...
* chore: update node types version
* update express types to solve type conflict
* one more yarn.lock type bump
* update another types package to fix incompatible global declarations
* remove incompatible type magicks
* update our ambient types to match the node types
* fix test type
2022-03-28 14:37:35 -07:00
Charles Kerr
1c5bbba5cf
docs: simplify skipTaskbar breaking changes text ( #33479 )
2022-03-28 15:06:11 -05:00
Baitinq
c4e3a1aad3
docs: Use Node's URL parser in the 5th security recommendation ( #33463 )
...
Rule 13 recommends using Node's URL parser for handling url inputs. At
the moment, this is not being followed in the code example for rule 5,
which falls back on checking that the url ends with a '/'. If this was
forgotten when a user copies this code it could introduce security
vulnerabilities if an attacker uses an URL in the following way:
"https://example.com.attacker.com "
Using Node's URL parser fixes this potential missuse and enables the
'/' to be omited from the code example.
Co-authored-by: Baitinq <you@example.com >
2022-03-28 14:25:44 -04:00
Samuel Attard
3c30b59c3e
build: store last ninja log in artifacts ( #32936 )
2022-03-28 13:34:10 -04:00
Marek Rusinowski
cdf2b3f4e4
fix: calling of X11 functions when running under Wayland ( #33355 )
...
* fix: don't call X11 functions in file dialog and message box
* refactor: remove unused GtkUiPlatform declaration
* fix: set gtk darktheme only when running under X11
* fix: replace X11 window state watcher with implementation using ozone
* fix: make sure global menu barr is used only when supported
* fix: don't call X11 function in native window views under wayland
* style: fix lint issues
* fix: use GtkUiPlatform::ShowGtkWindow instead of gtk_window_present directly
* refactor: extract CreateGlobalMenuBar into separate function
* refactor: move checking for WaylandWindowDecorations inside class
* fix: check if we run under X11 only in ozone build
* refactor: drop including unused ui/base/ui_base_features.h header
* fix: modify ui_gtk_public_header.patch to also export gtk_ui.h
* fix: refactor guarding of X11 calls
- Introduce patch exposing new electron_can_call_x11 property
- Replace defined(USE_OZONE) with BUILDFLAG(OZONE_PLATFORM_X11) flags
* fix: remove the last remaining usage of USE_X11
* fix: usage of BUILDFLAG(OZONE_PLATFORM_X11) not building on non ozone
* fix: call UpdateWindowState from OnBoundsChanged only under X11
2022-03-28 12:48:50 -04:00
Shelley Vohr
1153a5ce5a
fix: BrowserView background color in webContents ( #33435 )
...
* chore: fix BrowserView background color in webContents
* disable screen capture test on linux
* spec: fix platform failure condition
2022-03-28 12:47:08 -04:00
Sofia Nguy
9e45a1cd51
docs: Update release dates for E19 and fix typos ( #33464 )
2022-03-28 09:30:05 -07:00
Sudowoodo Release Bot
d4a34fb175
Bump v19.0.0-nightly.20220328
2022-03-28 06:02:03 -07:00
electron-roller[bot]
c11cd3c14c
chore: bump chromium to 102.0.4962.3 (main) ( #33447 )
...
* chore: bump chromium in DEPS to 102.0.4962.3
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-03-25 12:35:32 -05:00
Sudowoodo Release Bot
3c5c880a33
Bump v19.0.0-nightly.20220325
2022-03-25 06:01:13 -07:00
Calvin
b03d6dfba9
fix: non-client windows messages on legacy widget host (again) ( #33438 )
2022-03-25 11:12:09 +01:00
Robo
f60ff18b14
fix: gn check when //printing component is disabled ( #33429 )
2022-03-24 20:48:23 -07:00
electron-roller[bot]
7e59d784a0
chore: bump chromium to 102.0.4961.0 (main) ( #33091 )
...
* chore: bump chromium in DEPS to 101.0.4911.0
* chore: bump chromium in DEPS to 101.0.4913.0
* chore: bump chromium in DEPS to 101.0.4915.0
* chore: bump chromium in DEPS to 101.0.4917.0
* chore: bump chromium in DEPS to 101.0.4919.0
* chore: bump chromium in DEPS to 101.0.4921.0
* chore: bump chromium in DEPS to 101.0.4923.0
* chore: bump chromium in DEPS to 101.0.4925.0
* chore: bump chromium in DEPS to 101.0.4927.0
* chore: bump chromium in DEPS to 101.0.4929.0
* chore: update patches
* chore: bump chromium in DEPS to 101.0.4931.0
* chore: update patches
* 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3475388
Actual fixes in 1824792: Migrate DisplayClient to the new Mojo types | https://chromium-review.googlesource.com/c/chromium/src/+/1824792
* 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* chore: reconcile patches with main rebase
* chore: bump chromium in DEPS to 101.0.4933.0
* chore: update patches
* 3329593: [Fenced Frame] Ensure to support external protocols in a fenced frame
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3329593
* 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* 3446451: Use forward decl of ImageSkiaRep in //ui/gfx/image/image_skia.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3446451
* 3499818: partition_alloc: Rename AllocFlags to AllocWithFlags
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3499818
* chore: bump chromium in DEPS to 101.0.4935.0
* chore: update patches
* 3463286: partition_alloc: Move PartitionAlloc into the own namespaces (15 of N)
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3463286
* 3506590: Reland "Support ChromeOS external protocol dialog for Fenced Frame navigations"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3506590
* 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3475388
Actual fixes in 1880987: Convert URLLoaderReqeust from //content to new Mojo types | https://chromium-review.googlesource.com/c/chromium/src/+/1880987 The change in the roll started causing the legacy types to fail
* chore: missing SkRegion include
* 3499600: Introduce blink::WebCssOrigin
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3499600
* fixup!: 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* chore: bump chromium in DEPS to 101.0.4937.0
* chore: update patches
* 3500826: [locales] Refactor locales for ios
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3500826
* 3509531: Make some public Blink media files private
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3509531
* 3497377: bluetooth: Add BluetoothDevice.forget()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3497377
* chore: bump chromium in DEPS to 101.0.4939.0
* chore: bump chromium in DEPS to 101.0.4941.0
* 3514804: Deprecate all existing uses of mojo_base.mojom.{Dictionary,List}Value.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3514804
* 3502592: Delete PPAPI init/shutdown code in //pdf.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3502592
* chore: update patches
* fixup! 3502592: Delete PPAPI init/shutdown code in //pdf.
* chore: bump chromium in DEPS to 101.0.4943.0
* chore: fix lint, remove unneeded headers
* fixup! 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
* update mojo calls in offscreen patch
* update hunspell filenames
* chore: bump chromium in DEPS to 101.0.4945.0
* chore: update patches
* fix offscreen patch again
* chore: bump chromium in DEPS to 101.0.4947.0
* chore: update patches
* chore: bump chromium in DEPS to 101.0.4949.0
* support unseasoned pdf
* update patches
* chore: update patches
* chore: [IWYU] include missing skia headers
* chore: bump chromium in DEPS to 101.0.4951.0
* chore: update patches
* 3457645: media: Remove IsKeySystemsUpdateNeeded()
https://chromium-review.googlesource.com/c/chromium/src/+/3457645
* chore: bump chromium in DEPS to 102.0.4952.2
* chore: update patches
* 3488672: Add documentId as a parameter in tabs.connect() and tabs.sendMessage().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3488672
* 3508375: Fix an issue dangerous dialog is not shown for some apk download
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3508375
* chore: bump chromium in DEPS to 102.0.4953.0
* chore: update patches
* 3510189: Harden up drag and drop support across same-process boundaries.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3510189
* 3526815: Remove hardcoded colors from chrome/browser/ui/views/overlay/.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3526815
* chore: bump chromium in DEPS to 102.0.4955.0
* build: add af and ur locale to manifests
3498914 [locales] Add af and ur to desktop
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3498914
* fixup! build: add af and ur locale to manifests
* chore: bump chromium in DEPS to 102.0.4957.0
* 3529090: gin: set JS flags before v8 initialization
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3529090
chore: fix code shear in chromium/gin_enable_disable_v8_platform.patch
* chore: update patches
* 3536433: [network] Rename data_path and http_cache_path from _path to _directory.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3536433
* 3111565: Relocated Page.printToPDF implementation to //components
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3111565
refactor: inject E args to PrintRequestedPages() and ScriptedPrintCallback
TODO: currently passes a placeholder for job_settings. We have other
code paths that inject settings from electron_api_web_contents.cc.
Should those be injected here as well? (CC @codebytere)
* fixup! 3111565: Relocated Page.printToPDF implementation to //components
* fixup! 3111565: Relocated Page.printToPDF implementation to //components
* 3520025: Make "libcxx_abi_unstable" not a gn arg
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3520025
build: since it is no longer a gn arg, patch it in
* chore: change usages of std::vector with const elements (#33373 )
* chore: bump chromium in DEPS to 102.0.4959.0
* chore: update patches
* build: iwyu base/threading/platform_thread.h
* 3525774: Add GPSForCurrentDocument() into PermissionControllerDelegate.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3525774
refactor: copy upstream impl of GetPermissionStatusForCurrentDocument into +ElectronPermissionManager
* use gclient_gn_args_from instead of hand-copying
* checkout mac on mac
* chore: update patches
* Revert "checkout mac on mac"
This reverts commit fe9ccf49ec .
* fixup! 3525774: Add GPSForCurrentDocument() into PermissionControllerDelegate.
* fixup! 3457645: media: Remove IsKeySystemsUpdateNeeded()
add nogncheck
* fix: set .eslintrc.json to root to avoid cascade to chromium eslintrc
* Xref: 6dfdf79b8c
Xref: https://reviews.llvm.org/D101458
Upstream added a CMakeLists.txt in an include dir ¯\_(ツ)_/¯ and
so it must be enumerated in filenames.libcxxabi.gni
* 3511268: Remove unused headers from cxx17_backports.h
https://chromium-review.googlesource.com/c/chromium/src/+/3511268
use std::size instead of base::size
* iwyu: SkPaint
3488428: [includes] Fix transitive includes of SkImageEncoder
* chore: [IWYU] include missing skia headers
* fixup! 3511268: Remove unused headers from cxx17_backports.h
* chore: bump chromium in DEPS to 102.0.4961.0
* chore: update patches
* fixup! 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
chore: remove unused #include
* fixup! 3510189: Harden up drag and drop support across same-process boundaries. | https://chromium-review.googlesource.com/c/chromium/src/+/3510189
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-03-24 21:39:03 -04:00
Hanlin
92c5dedc76
Update china npmmirror ( #33401 )
...
Source: https://zhuanlan.zhihu.com/p/465424728
2022-03-24 20:08:33 -04:00
Calvin
f69b59effc
feat: add WCO title bar style setters ( #33066 )
...
* feat: add wco title bar style setters
* return after throwing
2022-03-24 20:02:45 -04:00
Jeremy Rose
4fdf8584ed
docs: fix SCA and postMessage links in web-frame-main.md ( #33415 )
2022-03-24 13:12:47 -04:00
David Sanders
962f4a6558
docs: remove pywin32 from Windows build instructions ( #33402 )
2022-03-24 09:09:12 -04:00
Sudowoodo Release Bot
d5ad18db03
Bump v19.0.0-nightly.20220324
2022-03-24 06:00:50 -07:00
Cheng Zhao
9d698c76c5
chore: update out-dated node patches ( #33421 )
2022-03-24 10:26:34 +01:00
electron-roller[bot]
db5a3c014a
chore: bump node to v16.14.2 (main) ( #32833 )
...
* chore: bump node in DEPS to v16.14.0
* src: add flags for controlling process behavior
https://github.com/nodejs/node/pull/40339
* src: add x509.fingerprint512 to crypto module
https://github.com/nodejs/node/pull/39809
* deps: upgrade to libuv 1.43.0
https://github.com/nodejs/node/pull/41398
* chore: fixup patch indices
* chore: add missing filenames
https://github.com/nodejs/node/pull/39283
https://github.com/nodejs/node/pull/40665
* crypto: trim input for NETSCAPE_SPKI_b64_decode
https://github.com/nodejs/node/pull/40757
* chore: update patches
* chore: bump node in DEPS to v16.14.1
* tools: enable no-empty ESLint rule
https://github.com/nodejs/node/pull/41831
* chore: update patches
* chore: update patches
* chore: bump node in DEPS to v16.14.2
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-03-23 18:59:54 -04:00
John Kleinschmidt
cc253f5de9
ci: abort CI if goma authentication is invalid ( #33413 )
2022-03-23 18:55:26 -04:00
John Kleinschmidt
41f94ef154
Revert "test: re-enable webview resize events test ( #33220 )" ( #33409 )
...
This reverts commit c262eac441 .
2022-03-23 12:40:29 -04:00
Jeremy Rose
f912130be6
fix: libuv patches to address child_process.spawn slowness ( #33337 )
...
* fix: libuv patches to address child_process.spawn slowness
* chore: backport additional patches
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-03-23 06:30:54 -07:00
Sudowoodo Release Bot
a5ab10f3d2
Bump v19.0.0-nightly.20220323
2022-03-23 06:00:58 -07:00
David Sanders
6bb492ac23
docs: update Ubuntu version used for Linux prebuilt binaries ( #33372 )
2022-03-23 18:46:45 +09:00
andreasdj
3744ac0a52
fix: persist BrowserView content bounds when calculating layout ( #32747 )
...
Reverting change introduced in PR: https://github.com/electron/electron/pull/30510
Co-authored-by: Andreas Johansson <aj3621@tobii.com >
2022-03-23 10:16:15 +09:00
Samuel Attard
800b96fe14
docs: add new IPC validation section to the security tutorial ( #33369 )
...
* docs: add new IPC validation section to the security tutorial
* Update security.md
* Update docs/tutorial/security.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/tutorial/security.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2022-03-22 20:45:23 -04:00
Fedor Indutny
06a00b74e8
fix: initialize asar support in worker threads ( #33216 )
...
* fix: initialize asar support in worker threads
Use `ObjectWrap` instead of gin's Wrap in `electron_api_asar.cc` because
gin isn't fully initialized (and apparently not possible to initialize
without ruining the isolate configuration and array buffer allocator) in
worker threads. In the worker thread call `setupAsarSupport` just as we
do for the main process.
* Update lib/asar/fs-wrapper.ts
Co-authored-by: Darshan Sen <raisinten@gmail.com >
* Update patches/node/worker_thread_add_asar_support.patch
Co-authored-by: Darshan Sen <raisinten@gmail.com >
* Add a test
Co-authored-by: Darshan Sen <raisinten@gmail.com >
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-03-22 20:37:55 -04:00
David Sanders
27ddf19f3c
chore: use pylint-2.7 ( #33232 )
...
* chore: use pylint-2.7
* chore: fix pylint errors
2022-03-22 20:17:35 -04:00
David Sanders
4633376b28
test: fix crash on image.crop ( #33148 )
...
* test: fix crash on image.crop
* Trigger CI
2022-03-22 20:14:49 -04:00
Johns Gresham
8ad1470d08
docs: remove extra $ from npm install command ( #33366 )
2022-03-23 08:54:08 +09:00
Black-Hole
3aec1c3e3f
chore: upgrade @electron/get version to ^1.14.1 ( #33259 )
...
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2022-03-22 09:41:21 -07:00
Keeley Hammond
feff8b3584
ci: enable thin LTO on Mac ( #33194 )
...
* build: remove thin lto mac patch
* build: remove step-get-more-space-on-mac
* build: remove USE_PREBUILT_V8_CONTEXT_SNAPSHOT
* ci: re-add mksnapshot logic
* ci: re-add USE_PREBUILT_V8_CONTEXT_SNAPSHOT
* ci: re-add get-more-space, delete thin LTO cache & .dSYM
* ci: don't delete v8_snapshot_generator.dSYM
* ci: add timeout to mksnapshot
2022-03-22 11:31:53 -04:00
Sudowoodo Release Bot
b7188f07f4
Bump v19.0.0-nightly.20220322
2022-03-22 06:00:54 -07:00
David Sanders
4d8ebcd19c
chore: change usages of std::vector with const elements ( #33373 )
2022-03-22 01:52:10 -07:00
Samuel Attard
81318f0acc
fix: disable SIGUSR1 when --inspect is disabled ( #33188 )
2022-03-22 16:51:04 +09:00
Samuel Attard
956406a193
fix: use stricter options in SecStaticCodeCheckValidity ( #33368 )
...
* fix: use stricter options in SecStaticCodeCheckValidity
* Update patches/squirrel.mac/fix_use_kseccschecknestedcode_kseccsstrictvalidate_in_the_sec.patch
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-03-22 00:19:46 -07:00
Charles Kerr
0af2b8de73
docs: mark skipTaskbar as unsupported on Linux ( #33226 )
...
Fixes #33124 .
2022-03-22 15:12:20 +09:00
Shelley Vohr
f5112632a3
fix: pend bounds change when moving BrowserWindows ( #33288 )
...
* fix: ensure bounds changes apply when moving windows
* chore: remove unused queue include
2022-03-22 15:07:09 +09:00
Charles Kerr
c262eac441
test: re-enable webview resize events test ( #33220 )
2022-03-22 08:55:53 +09:00
Jeremy Rose
d79d3fc7d7
test: fix and re-enable Network.getResponseBody test ( #33227 )
2022-03-22 08:38:46 +09:00
zeeker999
108ee7037f
fix: IncrementCapturerCount doesn't increase the capturer count ( #32973 )
2022-03-22 08:38:03 +09:00
Shelley Vohr
59246a4c7c
fix: NOTREACHED when resizing windows frameless bounds ( #33029 )
...
* fix: NOTREACHED when resizing windows frameless bounds
* fix: scope to window_->IsResizable()
2022-03-22 08:30:05 +09:00
David Sanders
2205d725f2
chore: bump @electron/docs-parser version ( #33346 )
2022-03-21 14:17:25 -04:00
David Sanders
1ccf206e77
docs: add note about supported versions to issue template ( #33348 )
2022-03-21 13:51:59 -04:00
Shelley Vohr
db79734bfb
feat: support more color formats for backgroundColor ( #31868 )
2022-03-21 18:35:54 +01:00
Sudowoodo Release Bot
4b8b492b62
Bump v19.0.0-nightly.20220321
2022-03-21 06:01:28 -07:00
Milan Burda
755feb4d81
feat: add nativeTheme.inForcedColorsMode ( #32956 )
2022-03-21 10:30:02 +01:00
Robo
4cc2ed842e
fix: iocp integration when process is reused ( #33207 )
2022-03-21 16:42:22 +09:00
Lalit
e100402b13
docs: possible change in tutorial/ipc ( #33218 )
...
The `counter` channel should be `update-counter` channel
2022-03-21 11:13:55 +09:00
David Sanders
45e2f86fe0
chore: fix pylint-2.7 errors ( #33233 )
2022-03-21 11:11:21 +09:00
BIKI DAS
fdb60240f3
fix: removed unused imported Objects ( #33304 )
2022-03-21 10:21:21 +09:00
Keeley Hammond
08d54d2416
fix: intialize FPS file in network service ( #33339 )
2022-03-18 21:29:42 -07:00
Samuel Attard
e07c2b84d7
fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames ( #33323 )
...
* fix: ensure ElectronBrowser mojo service is only bound to authorized render frames
Notes: no-notes
* refactor: extract electron API IPC to its own mojo interface
* fix: just check main frame not primary main frame
2022-03-18 19:50:05 -07:00
Sudowoodo Release Bot
f2b06324b8
Bump v19.0.0-nightly.20220318
2022-03-18 06:01:12 -07:00
Sudowoodo Release Bot
ac6ed62ab9
Bump v19.0.0-nightly.20220317
2022-03-17 06:01:17 -07:00
David Sanders
7acb513ba6
docs: update links to Chromium source ( #33309 )
2022-03-17 13:45:55 +01:00
David Sanders
ce8e248b60
docs: remove unused images ( #33310 )
2022-03-17 09:40:00 +01:00
David Sanders
df8fd1b269
build: fix build by removing usage of removed preloadUrl ( #33319 )
2022-03-17 00:13:48 -07:00
Jeremy Rose
4342b7ff55
chore: remove awkward semi-documented preloadURL WebPreference ( #33228 )
2022-03-16 16:23:41 -07:00
Jeremy Rose
e904486076
fix: BrowserWindow.fromWebContents should work in browser-window-created ( #33257 )
2022-03-16 16:23:14 -07:00
Robo
b2c5623a13
fix: crash when destroying node env with pending promises ( #33280 )
...
* fix: crash when destroying node env with pending promises
* chore: add spec
2022-03-16 18:54:45 +01:00
David Sanders
652680e801
fix: ensure external memory adjustments are balanced ( #33266 )
2022-03-16 18:54:30 +01:00
David Sanders
cf3ee7be56
build: drop pywin32 usage ( #26186 )
...
* build: drop pywin32 usage
* chore: ignore extra output on AppVeyor
2022-03-16 13:40:47 -04:00
Abhay Gupta
b274011720
fix: fiddle ipc code pattern 3 ( #33262 )
2022-03-16 11:01:29 -04:00
Jeremy Rose
02fe245521
docs: webFrame.insertCSS should mention options arg ( #33274 )
2022-03-16 10:56:20 -04:00
Sudowoodo Release Bot
a5382b7780
Bump v19.0.0-nightly.20220316
2022-03-16 06:02:33 -07:00
David Sanders
fc7f38c7ce
docs: remove "marked" from process.getBlinkMemoryInfo() ( #33263 )
2022-03-16 11:51:56 +01:00
Milan Burda
2657383ea7
feat: allow setting code cache directory ( #31154 )
...
* feat: allow setting code cache directory
* chore: address review feedback
* chore: update docs
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: rewrite with base::Contains
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-03-15 15:34:53 -05:00
CanadaHonk
37a904c299
docs: specify default for BrowserWindow's center option ( #33264 )
2022-03-15 10:48:25 -07:00
Samuel Attard
c8a3a00017
fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence ( #33063 )
...
* fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence
* chore: update electron_inspectable_web_contents_view.mm
2022-03-15 10:45:56 -07:00
Aryan Shridhar
7382891015
docs: reword sentence for better understanding ( #33265 )
2022-03-15 10:11:40 -07:00
Sudowoodo Release Bot
75339dccb3
Bump v19.0.0-nightly.20220315
2022-03-15 06:01:15 -07:00
Sudowoodo Release Bot
4bdb50eeee
Bump v19.0.0-nightly.20220314
2022-03-14 06:02:37 -07:00
Milan Burda
039c061d07
fix: add missing [[maybe_unused]] to IsEnvSet ( #33224 )
2022-03-14 18:19:15 +09:00
Jeremy Rose
f372953256
fix: cppgc/node collisions in renderer process ( #33252 )
...
* fix: cppgc/node collisions in renderer process
* Update be_compatible_with_cppgc.patch
2022-03-12 18:28:10 -05:00
Jeremy Rose
cdc27a3793
fix: prevent UAF crash in setCertificateVerifyProc ( #33204 )
2022-03-11 11:35:48 -08:00
Darshan Sen
bbb79880f7
chore: cherry-pick 2ed58f4 from chromium ( #33109 )
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658
Fixes: https://github.com/electron/electron/issues/33049
Signed-off-by: Darshan Sen <raisinten@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-03-11 11:19:51 -06:00
Sudowoodo Release Bot
dc63b8e7f4
Bump v19.0.0-nightly.20220311
2022-03-11 05:01:42 -08:00
Sudowoodo Release Bot
b888d9cd17
Bump v19.0.0-nightly.20220310
2022-03-10 05:01:04 -08:00
David Sanders
e589e9b259
fix: fire show event when BrowserWindow shown via maximize() ( #32979 )
2022-03-09 17:30:42 -05:00
Harry Hopkinson
86e746c36b
Formatted C++ Files According to the clang-format file. ( #33158 )
2022-03-09 16:28:54 -05:00
Jeremy Rose
ebfcf89a0b
fix: propagate unsafely-treat-insecure-origin-as-secure to renderer children ( #33189 )
...
* fix: propagate unsafely-treat-insecure-origin-as-secure to renderer children
* fix build
2022-03-09 10:15:50 -05:00
Sudowoodo Release Bot
865a29ed17
Bump v19.0.0-nightly.20220309
2022-03-09 05:00:38 -08:00
Shelley Vohr
373a905319
fix: settings not persisting across devtools loads ( #33120 )
...
* fix: settings not persisting across devtools loads
* chore: remove redundant RegisterPreference impl
2022-03-08 20:17:43 -05:00
Jeremy Rose
27527fe5ca
feat: warn that preloads will be sandboxed by default in v20 ( #32868 )
2022-03-08 15:39:53 -08:00
Calvin
e41c3e960d
fix: non-client mouse events on WCO-enabled windows ( #32871 )
2022-03-08 16:06:20 -05:00
Shelley Vohr
076bc58b2a
fix: crash when showin item in folder on DevTools ( #33024 )
2022-03-08 14:40:25 -05:00
Milan Burda
b96f15bfc2
fix: patches to use BUILDFLAG(IS_WIN) / BUILDFLAG(IS_MAC) checks ( #33160 )
2022-03-08 14:38:15 -05:00
Kevin Ushey
3bc3896ee7
docs: fix documented return value for getFocusedWebContents ( #33170 )
2022-03-08 14:15:05 -05:00
Sudowoodo Release Bot
a20216de7a
Bump v19.0.0-nightly.20220308
2022-03-08 05:01:16 -08:00
Samuel Attard
a5a4818b67
chore: add ignore revs file for GH blame UI ( #33171 )
2022-03-07 18:40:28 -08:00
Jeremy Rose
aa8119515f
fix: gracefully fail if app.configureHostResolver is called before ready ( #33062 )
2022-03-07 16:52:40 -08:00
John Kleinschmidt
3d9b9b97cf
build: put v8_context_snapshot_generator.dSYM in its own zip file ( #33183 )
2022-03-07 18:47:58 -05:00
Makonede
12aa991df2
Fix a typo ( #33042 )
2022-03-07 17:17:12 -05:00
Chuion
0ff1727ec0
docs: fix missing dependencies in ipc patterns ( #33082 )
2022-03-07 17:04:58 -05:00
Micha Hanselmann
a1c01ded9c
fix: really strip crashpad handler binary ( #33126 )
2022-03-07 14:49:50 -05:00
Sudowoodo Release Bot
94a85cb191
Revert "Bump v19.0.0-nightly.20220307"
...
This reverts commit b43f7702c8 .
2022-03-07 09:23:13 -08:00
John Kleinschmidt
f45aaea537
test: disable newly added tests on WOA ( #33143 )
...
* tests: disable newly added tests on WOA
* test: also disable test on arm64 macOS
2022-03-07 09:18:58 -05:00
Sudowoodo Release Bot
b43f7702c8
Bump v19.0.0-nightly.20220307
2022-03-07 05:01:43 -08:00
Sudowoodo Release Bot
7beffb51fc
Revert "Bump v19.0.0-nightly.20220303"
...
This reverts commit 89725f31bf .
2022-03-05 15:55:12 -08:00
John Kleinschmidt
3663f8e0ae
ci: use larger machine for docs only check ( #33141 )
2022-03-03 16:57:21 -08:00
Alvin Philips
41c81ed066
docs: Updated list numbering ( #32991 )
...
* docs: Updated list numbering
The steps to package and distribute an application using electron had incorrect numbering
* Indented text within ordered list sections
* Removed single space
* Fixed indentation
2022-03-03 15:35:51 -08:00
Erick Zhao
62366aeb95
docs: remove platform notices from tutorial titles ( #32937 )
...
* docs: remove platform notices from tutorial titles
* Update docs/tutorial/launch-app-from-url-in-another-app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2022-03-03 09:56:00 -08:00
Sudowoodo Release Bot
89725f31bf
Bump v19.0.0-nightly.20220303
2022-03-03 05:02:08 -08:00
Keeley Hammond
f71a6db3ff
ci: disable use-thin-lto on Mac only ( #33115 )
...
* build: remove use_thin_lto = false
* ci: enabling if things get really bad (all darwin)
* build: lol don't enable that
* build: add patch to disable thin lto for mac
2022-03-02 16:57:26 -08:00
Sudowoodo Release Bot
c040305db4
Revert "Bump v19.0.0-nightly.20220302"
...
This reverts commit d9bf02d9b6 .
2022-03-02 08:56:25 -08:00
Sudowoodo Release Bot
d9bf02d9b6
Bump v19.0.0-nightly.20220302
2022-03-02 05:01:04 -08:00
Sudowoodo Release Bot
318c91b78c
Revert "Bump v19.0.0-nightly.20220228"
...
This reverts commit 998c85af13 .
2022-03-01 16:48:02 -08:00
Shelley Vohr
ebd80a0602
fix: max window size defaults to 0 ( #33025 )
2022-03-01 14:20:07 -08:00
Keeley Hammond
306147ddf5
fix: disable partition alloc on mac ( #33114 )
2022-03-01 14:16:37 -08:00
Samuel Maddock
7cb62bfc22
test: BrowserWindow backgroundColor and transparency ( #31017 )
...
* test: BrowserWindow backgroundColor
* test: allow similar colors
* test: disable linux capturing
* refactor: split screen capture from reading pixel color
2022-03-01 14:14:11 -08:00
Shelley Vohr
283fa2b79d
fix: macOS tray icon alternate images ( #33026 )
2022-02-28 14:59:27 -08:00
Erick Zhao
1e50f7d2b6
docs: consolidate info docs ( #32964 )
...
* docs: consolidate info docs
* fill in table
* more newlines to admonitions
* update china mirror thing
2022-02-28 11:46:52 -08:00
Sudowoodo Release Bot
998c85af13
Bump v19.0.0-nightly.20220228
2022-02-28 05:00:53 -08:00
electron-roller[bot]
3da598015b
chore: bump chromium to 100.0.4894.0 (main) ( #32852 )
...
* chore: bump chromium in DEPS to 100.0.4880.0
* resolve conflicts
* chore: update patches
* fix patch
* PIP20: add a new DocumentOverlayWindowViews subtype
https://chromium-review.googlesource.com/c/chromium/src/+/3252789
* Clean up PictureInPictureWindowManager::EnterPictureInPicture()
https://chromium-review.googlesource.com/c/chromium/src/+/3424145
* Remove StoragePartitionId.
https://chromium-review.googlesource.com/c/chromium/src/+/2811120
* Remove FLoC code
https://chromium-review.googlesource.com/c/chromium/src/+/3424359
* media: Make AddSupportedKeySystems() Async
https://chromium-review.googlesource.com/c/chromium/src/+/3430502
* [Extensions] Move some l10n file util methods to //extensions/browser
https://chromium-review.googlesource.com/c/chromium/src/+/3408192
* chore: IWYU
* Reland "webhid: Grant permissions for policy-allowed devices"
https://chromium-review.googlesource.com/c/chromium/src/+/3444147
* Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 2/N.
https://chromium-review.googlesource.com/c/chromium/src/+/3435727
https://chromium-review.googlesource.com/c/chromium/src/+/3440910
https://chromium-review.googlesource.com/c/chromium/src/+/3440088
* [text blink period] Cache blink period instead of fetching from defaults
https://chromium-review.googlesource.com/c/chromium/src/+/3419059
* chore: update picture-in-picture.patch
https://chromium-review.googlesource.com/c/chromium/src/+/3252789
* ci: update to Xcode 13.2.1
https://chromium-review.googlesource.com/c/chromium/src/+/3437552
* chore: bump chromium in DEPS to 100.0.4882.1
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4884.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4886.0
* chore: update patches
* Refactor DownloadManager to use StoragePartitionConfig
https://chromium-review.googlesource.com/c/chromium/src/+/3222011
* Remove ToWebInputElement() in favor of new WebNode::DynamicTo<> helpers.
https://chromium-review.googlesource.com/c/chromium/src/+/3433852
* refactor: autofill to use the color pipeline
https://bugs.chromium.org/p/chromium/issues/detail?id=1249558
https://bugs.chromium.org/p/chromium/issues/detail?id=1003612
* [ProcessSingleton] Add many more trace events to cover all scenarios
https://chromium-review.googlesource.com/c/chromium/src/+/3429325
* fixup! PIP20: add a new DocumentOverlayWindowViews subtype
* chore: bump chromium in DEPS to 100.0.4888.0
* chore: update patches
* chore: update picture-in-picture.patch
* fixup! refactor: autofill to use the color pipeline
* ci: fixup fix sync
(cherry picked from commit c1e3e395465739bce5ca8e1c5ec1f5bd72b99ebd)
* chore: bump chromium in DEPS to 100.0.4889.0
* chore: update patches
* chore: fix feat_add_data_transfer_to_requestsingleinstancelock.patch
* fixup! PIP20: add a new DocumentOverlayWindowViews subtype
* Remove remaining NativeTheme::GetSystemColor() machinery.
https://chromium-review.googlesource.com/c/chromium/src/+/3421719
* ci: fetch proper esbuild for macos
* ci: fixup fetch proper esbuild for macos
* fix: failing Node.js test on outdated CurrentValueSerializerFormatVersion
* chore: bump chromium in DEPS to 100.0.4892.0
* 3460365: Set V8 fatal error callbacks during Isolate initialization
https://chromium-review.googlesource.com/c/chromium/src/+/3460365
* 3454343: PIP20: use permanent top controls
https://chromium-review.googlesource.com/c/chromium/src/+/3454343
* 3465574: Move most of GTK color mixers to ui/color/.
https://chromium-review.googlesource.com/c/chromium/src/+/3465574
* chore: fixup patch indices
* 3445327: [locales] Remove locales reference
https://chromium-review.googlesource.com/c/chromium/src/+/3445327
* 3456548: [DBB][#7 ] Blue border falls back to all tab if cropped-to zero pixels
https://chromium-review.googlesource.com/c/chromium/src/+/3456548
* 3441196: Convert GuestView's remaining legacy IPC messages to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/3441196
* 3455491: Don't include run_loop.h in thread_task_runner_handle.h
https://chromium-review.googlesource.com/c/chromium/src/+/3455491
* fixup! 3454343: PIP20: use permanent top controls
* 3442501: Add missing includes of //base/observer_list.h
https://chromium-review.googlesource.com/c/chromium/src/+/3442501
* 3437552: mac: Deploy a new hermetic build of Xcode 13.2.1 13C100
https://chromium-review.googlesource.com/c/chromium/src/+/3437552
* chore: bump chromium in DEPS to 100.0.4894.0
* fixup! 3460365: Set V8 fatal error callbacks during Isolate initialization
* chore: update patches
* 3425231: Use DnsOverHttpsConfig where appropriate
https://chromium-review.googlesource.com/c/chromium/src/+/3425231
* test: disable test-heapsnapshot-near-heap-limit-worker.js
As a result of CLs linked in https://bugs.chromium.org/p/v8/issues/detail?id=12503 ,
heap snapshotting near the heap limit DCHECKS in Node.js specs. This will
likely require a larger refactor in Node.js so i've disabled the test for
now and opened an upstream issue on node-v8 issue
at https://github.com/nodejs/node-v8/issues/218 .
* Port all usage of NativeTheme color IDs to color pipeline
https://bugs.chromium.org/p/chromium/issues/detail?id=1249558
* chore: update patches after rebase
* ci: use gen2 machine for more disk space
* ci: don't try to make root volume writeable
* ci: use older xcode/macos for tests
* fix: html fullscreen transitions stacking
(cherry picked from commit 5e10965cdd7b2a024def5fc568912cefd0f05b44)
* ci: speed up woa testing
(cherry picked from commit 75c33c48b032137794f5734348a9ee3daa60d9de)
(cherry picked from commit e819962340 )
* ci: disable flaky tests on WOA
* ci: run remote tests separately to isolate issue there
* tests: disable node test parallel/test-worker-debug for now
* revert: fix: html fullscreen transitions stacking
* tests: disable flaky test on macOS arm64
* fixup circleci config so build tools can find xcode version
* make sure the workspace is clean before job runs
(cherry picked from commit 75f713c974 )
* tests: disable flaky test on Linux
* ci: debug why windows i32 is crashing
* Revert "ci: debug why windows i32 is crashing"
This reverts commit 4c4bba87ea .
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2022-02-25 13:17:35 -05:00
Sudowoodo Release Bot
c1a667c931
Revert "Bump v19.0.0-nightly.20220225"
...
This reverts commit d5539ce834 .
2022-02-25 07:09:17 -08:00
Sudowoodo Release Bot
d5539ce834
Bump v19.0.0-nightly.20220225
2022-02-25 05:01:49 -08:00
Ruslan
067cc8ae2b
Update main.js ( #33039 )
2022-02-24 12:59:29 -08:00
Shelley Vohr
c5a2af7811
fix: tray garbage collection ( #33040 )
2022-02-24 20:03:59 +01:00
Sudowoodo Release Bot
8cf345660c
Bump v19.0.0-nightly.20220224
2022-02-24 05:01:41 -08:00
Sudowoodo Release Bot
da54cfcb3e
Revert "Bump v19.0.0-nightly.20220223"
...
This reverts commit 5b2d3910c1 .
2022-02-23 10:12:10 -08:00
Shelley Vohr
268cd31e38
fix: DCHECK when calling app.exit() ( #33035 )
2022-02-23 16:27:54 +01:00
Sudowoodo Release Bot
5b2d3910c1
Bump v19.0.0-nightly.20220223
2022-02-23 05:00:59 -08:00
Shelley Vohr
08e26175fd
fix: broken OSR transparent option ( #32885 )
2022-02-23 19:33:42 +09:00
t57ser
41b2945ced
feat: add ability to configure if window should close when opener closes ( #31314 )
...
* feat: Added ability to configure if window should close when opener closes
* fix: check if embedder is destroyed
* fix: correctly take over closeWithOpener property
* chore: Added documentation
* Update docs/api/window-open.md
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
* chore: refactor
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* chore: changed property name from `closeWithOpener` to `outlivesOpener`
* dummy change to kick lint
* undo above
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-02-23 16:59:50 +09:00
Sudowoodo Release Bot
bcf060fab6
Revert "Bump v19.0.0-nightly.20220221"
...
This reverts commit 83a4ac1841 .
2022-02-22 10:52:23 -08:00
Shelley Vohr
e9b9835feb
chore: fix out-of-date chromium patch ( #33030 )
2022-02-22 16:24:11 +09:00
dependabot[bot]
fa7461685d
build(deps): bump ajv from 6.10.1 to 6.12.6 ( #32865 )
...
Bumps [ajv](https://github.com/ajv-validator/ajv ) from 6.10.1 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases )
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.1...v6.12.6 )
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 14:28:34 -08:00
dependabot[bot]
484a70f9b8
build(deps): bump ajv from 6.11.0 to 6.12.6 in /spec-main ( #32864 )
...
Bumps [ajv](https://github.com/ajv-validator/ajv ) from 6.11.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases )
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.11.0...v6.12.6 )
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 14:27:56 -08:00
Sudowoodo Release Bot
83a4ac1841
Bump v19.0.0-nightly.20220221
2022-02-21 05:04:50 -08:00
David Sanders
1e8da899a3
chore: fix typos ( #32985 )
2022-02-21 10:27:45 +01:00
David Sanders
069cde09fb
fix: don't restore maximized BrowserWindow when calling showInactive ( #32870 )
2022-02-21 10:23:55 +01:00
Robo
bdad6335c4
fix: command string for windows protocol handler ( #32953 )
2022-02-21 16:43:27 +09:00
Jeremy Rose
9d72c8b0ad
chore: add @electron/wg-security to patches/ CODEOWNERS ( #32963 )
2022-02-21 10:27:58 +09:00
Kev
faa392af28
docs: fix broken link to GNOME notifications spec ( #32934 )
2022-02-21 10:23:17 +09:00
dependabot[bot]
683ff2ea02
build(deps): bump ajv from 6.10.2 to 6.12.6 in /spec ( #32863 )
...
Bumps [ajv](https://github.com/ajv-validator/ajv ) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases )
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6 )
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 10:19:53 +09:00
dependabot[bot]
9168f65321
build(deps): bump pathval from 1.1.0 to 1.1.1 ( #32861 )
...
Bumps [pathval](https://github.com/chaijs/pathval ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases )
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md )
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1 )
---
updated-dependencies:
- dependency-name: pathval
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 10:18:58 +09:00
Sudowoodo Release Bot
101e17d6f3
Revert "Bump v19.0.0-nightly.20220216"
...
This reverts commit c75ec2e689 .
2022-02-18 09:08:21 -08:00
Micha Hanselmann
b1463d2da1
fix: stale renderer process on quit ( #32888 )
2022-02-17 21:02:22 -08:00
Samuel Attard
36e730da93
build: use gen2 macOS resources for tests ( #32935 )
2022-02-17 13:57:23 -08:00
Cheng Zhao
e08ced5979
chore: update patch to fix CI ( #32950 )
2022-02-17 21:05:01 +09:00
Shelley Vohr
84cf685e76
fix: webContents.openDevTools({mode}) not working ( #32829 )
2022-02-17 14:59:13 +09:00
Fedor Indutny
fe43296f7f
chore: backport EPROTOTYPE fixes from libuv ( #32856 )
...
This commit backports three commits from libuv's 1.x branch to fix
issues with CPU going to 100% on macOS when EPROTOTYPE is returned.
See: abb109f30f
See: 3a7b95593a
See: de24da8c11
2022-02-17 14:58:21 +09:00
Shelley Vohr
34129b83a4
chore: error catching in node_bindings ( #32858 )
2022-02-17 14:56:53 +09:00
dependabot[bot]
b1777c5ad1
build(deps): bump pathval from 1.1.0 to 1.1.1 in /spec ( #32859 )
...
Bumps [pathval](https://github.com/chaijs/pathval ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases )
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md )
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1 )
---
updated-dependencies:
- dependency-name: pathval
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-17 14:56:38 +09:00
Erick Zhao
cc0eb7b908
docs: update checklists ( #32902 )
2022-02-16 09:47:32 -08:00
Sudowoodo Release Bot
c75ec2e689
Bump v19.0.0-nightly.20220216
2022-02-16 05:01:13 -08:00
Erick Zhao
600c37160b
docs: fix relative link in developer documentation ( #32844 )
2022-02-15 13:54:28 -08:00
Sudowoodo Release Bot
512bb96dcb
Revert "Bump v19.0.0-nightly.20220215"
...
This reverts commit 90f17e4945 .
2022-02-15 09:36:37 -08:00
Sudowoodo Release Bot
90f17e4945
Bump v19.0.0-nightly.20220215
2022-02-15 05:01:28 -08:00
Sudowoodo Release Bot
d36524c640
Revert "Bump v19.0.0-nightly.20220214"
...
This reverts commit 8397bfbd16 .
2022-02-14 06:25:11 -08:00
Sudowoodo Release Bot
8397bfbd16
Bump v19.0.0-nightly.20220214
2022-02-14 05:01:42 -08:00
Sudowoodo Release Bot
1e074605dc
Revert "Bump v19.0.0-nightly.20220211"
...
This reverts commit 96c3179f32 .
2022-02-11 09:47:06 -08:00
Sudowoodo Release Bot
96c3179f32
Bump v19.0.0-nightly.20220211
2022-02-11 05:00:51 -08:00
Sudowoodo Release Bot
8dfcf817e4
Revert "Bump v19.0.0-nightly.20220210"
...
This reverts commit 0a120468c0 .
2022-02-10 20:37:02 -08:00
Sudowoodo Release Bot
0a120468c0
Bump v19.0.0-nightly.20220210
2022-02-10 17:46:57 -08:00
Keeley Hammond
4fa3310887
build: add stack_trace.h to main delegate ( #32854 )
...
* build: add stack_trace.h to main delegate
* build: trigger circleci
* build: free up a tiny bit more space
* build: disable use_thin_lto
* fixup build/args/all.gn
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-02-10 17:43:14 -08:00
Sudowoodo Release Bot
ceab6a146a
Revert "Bump v19.0.0-nightly.20220210"
...
This reverts commit cd7dc52c53 .
2022-02-10 07:02:10 -08:00
Sudowoodo Release Bot
cd7dc52c53
Bump v19.0.0-nightly.20220210
2022-02-10 05:00:42 -08:00
electron-roller[bot]
28ada6ea8b
chore: bump chromium to 100.0.4857.0 (main) ( #32419 )
...
* chore: bump chromium in DEPS to 99.0.4819.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4824.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4827.0
* chore: update patches
* 3352511: PiP: Add inkdrop and pointer cursor to PiP window buttons
https://chromium-review.googlesource.com/c/chromium/src/+/3352511
* 3309164: webhid: Show FIDO devices in the chooser if allowed
https://chromium-review.googlesource.com/c/chromium/src/+/3309164
* 3297868: hid: Add experimental HIDDevice.forget()
https://chromium-review.googlesource.com/c/chromium/src/+/3297868
* 3362491: [Extensions] Move i18n API to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
* MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_.
https://chromium-review.googlesource.com/c/chromium/src/+/3281481
* 3352616: [Gtk] Remove libgtk from the link-line
https://chromium-review.googlesource.com/c/chromium/src/+/3352616
* 3249211: Clear-Site-Data support for partitioned cookies
https://chromium-review.googlesource.com/c/chromium/src/+/3249211
* [Extensions][COIL] Use [allow|block]list in //extensions/common
https://chromium-review.googlesource.com/c/chromium/src/+/3372668
* Begin ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3376154
* [Code Health] Refactor PrefService GetDict + GetList to use base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3343526
* 3354997: [CodeHealth] Remove deprecated SetDictionary method
https://chromium-review.googlesource.com/c/chromium/src/+/3354997
* 3287323: Add LacrosPrefStore for lacros settings
https://chromium-review.googlesource.com/c/chromium/src/+/3287323
* 3365916: [PA] Clean up remaining lazy commit code
https://chromium-review.googlesource.com/c/chromium/src/+/3365916
* [MPArch] Target the external protocol error at the responsible frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3011560
* Pass origin to RegisterNonNetworkSubresourceURLLoaderFactories
https://chromium-review.googlesource.com/c/chromium/src/+/3350608
* Linux: Send OSCrypt raw encryption key to the Network Service
https://chromium-review.googlesource.com/c/chromium/src/+/3320484
* [PlzServiceWorker] Remove remaining references to PlzServiceWorker.
https://chromium-review.googlesource.com/c/chromium/src/+/3359441
* chore: fixup for lint
* 3327621: Fix tablet mode detection for Win 11.
https://chromium-review.googlesource.com/c/chromium/src/+/3327621
* 3342428: ax_mac: move AXTextMarker conversion utils under ui umbrella
https://chromium-review.googlesource.com/c/chromium/src/+/3342428
* 3353974: Mac: Use base::Feature for overlay features
https://chromium-review.googlesource.com/c/chromium/src/+/3353974
* chore: bump chromium in DEPS to 99.0.4828.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4837.0
* chore: update patches
* chore: update patches
* 3379142: Drop FALLTHROUGH macro
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3379142
* 3381749: C++17: Allow use of std::map::try_emplace and std::map::insert_or_assign
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3381749
* chore: bump chromium in DEPS to 99.0.4839.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4840.0
* chore: bump chromium in DEPS to 99.0.4844.0
* 3395881: [api] Deprecate Local<v8::Context> v8::Object::CreationContext()
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3395881
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4845.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4847.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4849.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4851.0
* chore: bump chromium in DEPS to 100.0.4853.0
* update patches
* chore: update patches
* update patches
* 3383599: Fonts Access: Remove prototype that uses a font picker.
https://chromium-review.googlesource.com/c/chromium/src/+/3383599
* 3404768: Remove ALLOW_UNUSED macros
https://chromium-review.googlesource.com/c/chromium/src/+/3404768
* 3374762: Remove ignore_result.h
https://chromium-review.googlesource.com/c/chromium/src/+/3374762
* 3399305: [unseasoned-pdf] Apply proper frame offsets for touch selections
https://chromium-review.googlesource.com/c/chromium/src/+/3399305
* 3402210: [Extensions] Don't trigger unload event for already unloaded extension
https://chromium-review.googlesource.com/c/chromium/src/+/3402210
* 3410912: Combine URLLoaderClient OnReceiveResponse and OnStartLoadingResponseBody.
https://chromium-review.googlesource.com/c/chromium/src/+/3410912
* 3370428: Make the AuthSchemes policy support dynamic refresh
https://chromium-review.googlesource.com/c/chromium/src/+/3370428
* 3407603: Finish ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3407603
* 3378352: ozone/x11: move code from //ui/p/x11 to //ui/ozone/p/x11
https://chromium-review.googlesource.com/c/chromium/src/+/3378352
* 3370810: Delete chrome/service, AKA the Cloud Print service process.
https://chromium-review.googlesource.com/c/chromium/src/+/3370810
* chore: bump chromium in DEPS to 100.0.4855.0
* chore: update patches
* fixup! 3370810: Delete chrome/service, AKA the Cloud Print service process.
* revert 3348007 to fix windows build
* 3318572: [Code health] Fix gn check errors in //extensions/browser:*
https://chromium-review.googlesource.com/c/chromium/src/+/3318572
* fix printing.patch
* fix iwyu issue
* 3408515: win: Make ShorcutOperation an enum class and modernize names
https://chromium-review.googlesource.com/c/chromium/src/+/3408515
* 3388333: [UIA] Remove dead code accessibility_misc_utils.h/cc
https://chromium-review.googlesource.com/c/chromium/src/+/3388333
* fix windows build? i hope
* patch gn visibility of //ui/ozone/platform/x11
* missing include base/logging.h
* use BUILDFLAG for USE_NSS_CERTS
https://chromium-review.googlesource.com/c/chromium/src/+/3379123
* defined(OS_*) ==> BUILDFLAG(IS_*)
https://bugs.chromium.org/p/chromium/issues/detail?id=1234043
* fixup! 3404768: Remove ALLOW_UNUSED macros
* another attempt to fix windows build
* temporarily disable the custom scheme service worker test
https://github.com/electron/electron/issues/32664
* fix loading mv3 extensions
not sure what cl broke this unfort.
* fixup! 3404768: Remove ALLOW_UNUSED macros
* patch nan
https://chromium-review.googlesource.com/c/v8/v8/+/3395880
* fix node test
* fix nullptr in FindPdfFrame
* patch perfetto to fix build issue on win-ia32
bc44c3c753
* fix build for linux-x64-testing-no-run-as-node
* fix patch
* skip <webview>.capturePage() test
https://github.com/electron/electron/issues/32705
* test: fix failing tests of focus/blur events of WebContents (#32711 )
* inherit stdio from app module test child processes
this prevents them from timing out due to full stdout buffers
* test to see if we can get better logs on windows ci
* try again for appveyor log things
* skip contentTracing tests on ia32
* ci: disable gpu compositing
* drop applied patch
* fix merge fail
* Revert "ci: disable gpu compositing"
This reverts commit 0344129fcb .
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-02-09 18:58:52 -08:00
Erick Zhao
e9a43be9be
docs: add IPC doc ( #32059 )
...
* docs: add IPC doc
* fix: use "string" primitive
* use 'string' ipcrenderer
* use "number" primitive
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* add code sample
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-02-09 11:00:05 -05:00
Cheng Zhao
254dbd7400
test: disable the test that makes spec runner hang on exit ( #32834 )
2022-02-09 09:20:51 -05:00
Sudowoodo Release Bot
baaa7787af
Bump v19.0.0-nightly.20220209
2022-02-09 05:01:45 -08:00
Shelley Vohr
ac1d426c51
fix: pointer lock escape handling ( #32369 )
2022-02-09 10:40:50 +01:00
Darshan Sen
841d223b3b
build: rebuild the dist_zips when the deps get modified ( #32713 )
...
* build: rebuild the dist_zips when the deps get modified
The dist.zip generated by the electron_dist_zip action was not getting
updated when changes were being made to the dependencies, like the
source files. It turns out, we were using data_deps for the dependencies
instead of deps. Here is the difference:
data_deps: things needed to ultimately run the thing built by a target
deps: things needed to build the target
So the difference in treatment of both sets of dependencies is actually
intentional.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* fixup! build: rebuild the dist_zips when the deps get modified
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2022-02-08 13:03:33 -05:00
marekharanczyk
e119da8ce2
Make ElectronBrowser mojo interface frame associated. ( #32734 )
2022-02-08 11:33:21 -05:00
Shelley Vohr
58af7d2a9a
fix: failure to print on macOS ( #32767 )
2022-02-08 16:15:30 +01:00
Sudowoodo Release Bot
c09ce25ab6
Bump v19.0.0-nightly.20220208
2022-02-08 05:01:02 -08:00
Jeremy Rose
ce86e81aa6
docs: clarify meaning of cssOrigin ( #32753 )
2022-02-08 12:59:28 +01:00
Sudowoodo Release Bot
bf3650eb1f
Bump v19.0.0-nightly.20220207
2022-02-07 05:02:35 -08:00
Shelley Vohr
81fcd732c2
fix: savePage throw on relative paths ( #32728 )
2022-02-07 09:51:59 +01:00
Sudowoodo Release Bot
d46431b564
Bump v19.0.0-nightly.20220204
2022-02-04 05:01:08 -08:00
Shelley Vohr
fb3f5e490e
test: improve webContents.savePage() specs ( #32727 )
2022-02-03 16:56:50 -05:00
Juan Cruz Viotti
7442905dd2
build: Support cygwin in script/lib/util.py ( #32731 )
...
Running a build on Cygwin or MSYS2 otherwise fails.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2022-02-03 15:57:21 -05:00
Sudowoodo Release Bot
2526031a5f
Bump v19.0.0-nightly.20220203
2022-02-03 05:01:03 -08:00
Keeley Hammond
e0f2511cba
chore: bump NMV for Electron 19 ( #32703 )
2022-02-02 17:14:11 -05:00
Shelley Vohr
4c39eb32b0
refactor: use QuickLookThumbnailing where applicable ( #32456 )
2022-02-02 23:01:05 +01:00
Cheng Zhao
c3d11e2ea2
test: fix failing tests of focus/blur events of WebContents ( #32711 )
2022-02-02 10:32:53 -05:00
Sofia Nguy
ed185f324e
docs: Update E18 release date ( #32665 )
2022-02-02 10:07:11 -05:00
Calvin
9a5a45e804
fix: WCO window hover on window controls on Windows ( #32672 )
...
* fix: WCO window hover on window controls
* Update shell/browser/ui/win/electron_desktop_window_tree_host_win.cc
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Robo <hop2deep@gmail.com >
2022-02-02 10:06:36 -05:00
Sudowoodo Release Bot
8b6202b6a8
Bump v19.0.0-nightly.20220202
2022-02-02 05:20:39 -08:00
Shelley Vohr
7c701367c0
fix: some frameless windows showing a frame on Windows ( #32692 )
2022-02-02 11:23:02 +01:00
Shelley Vohr
56c6d25e98
fix: crash on printer dialog cancellation ( #32632 )
...
* fix: crash on printer dialog cancellation
* fix: remove commented out code
* chore: address review
2022-02-01 20:00:09 +01:00
John Kleinschmidt
b346f909e7
ci: fixup gclient cache on ubuntu 20 ( #32691 )
...
* ci: fixup gclient cache on ubuntu 20
* ci: update to Ubuntu 20.04 docker image
2022-02-01 11:54:27 -05:00
Sudowoodo Release Bot
939bfa50f6
Bump v18.0.0-nightly.20220201
2022-02-01 05:01:37 -08:00
Tobias Nießen
2289a52fb3
docs: fix typo in BrowserWindow description ( #32667 )
2022-02-01 12:47:49 +01:00
Samuel Maddock
aeee9cfb78
feat: add focus and blur events for WebContents ( #25873 )
...
test: add focus and blur WebContents event tests
test: confirm that webcontents focus event is fired on browserwindow focus
fix: mac focus event test timeout
2022-02-01 19:28:57 +09:00
Paul Hollinsky
e34d7f5d6f
docs: fix missing tag end in clipboard example ( #32673 )
2022-02-01 17:57:33 +09:00
Shelley Vohr
f5dc2a6535
fix: transparent window max/unmax event firing ( #32643 )
2022-01-31 22:10:57 +01:00
John Kleinschmidt
365933f1f3
fix: expose all serial devices to setDevicePermissionHandler ( #32651 )
2022-01-31 14:04:45 -05:00
Sudowoodo Release Bot
8e0e2d40e2
Bump v18.0.0-nightly.20220131
2022-01-31 05:01:27 -08:00
Milan Burda
db9ab80694
chore: update to latest TypeScript ( #32596 )
2022-01-31 20:37:40 +09:00
Harshil jain
32ae67c873
docs: update the build docs for electron to improve doc readability ( #32663 )
2022-01-31 20:36:47 +09:00
Marek Šuppa
c6d061c2d4
Update config.py ( #32666 )
...
* Fix missing comma
2022-01-31 10:57:52 +01:00
Harshil jain
d657cd8ed6
docs: Remove the latin words from doc ( #32641 )
2022-01-28 12:40:20 -08:00
Sudowoodo Release Bot
e693738f7c
Bump v18.0.0-nightly.20220128
2022-01-28 05:02:11 -08:00
John Kleinschmidt
63908ccf89
Revert "ci: update to Ubuntu 20.04 docker image ( #32614 )" ( #32656 )
...
This reverts commit 8803e7f020 .
2022-01-27 17:45:06 -05:00
Shelley Vohr
3768a7b25f
fix: css transparent background being lost ( #32593 )
2022-01-27 15:56:35 +01:00
Sudowoodo Release Bot
86f8faea6b
Bump v18.0.0-nightly.20220127
2022-01-27 05:01:10 -08:00
Mikael Finstad
20ed5701e9
docs: update context bridge docs about Promises and Errors ( #32533 )
...
* Update context bridge docs about Promises
From my testing it doesn't remove Promises in nested objects,
also according to the test suite it does not:
80577a4f08/spec-main/api-context-bridge-spec.ts (L693)
* docs: Update docs for errors too
2022-01-27 20:23:40 +09:00
Jeremy Rose
16fcad3488
fix: maxWidth not being respected ( #32628 )
2022-01-26 14:00:17 -08:00
Ryan Gonzalez
7caa88c46f
fix: Add support for Wayland window decorations ( #29618 )
...
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-01-26 13:59:09 -08:00
dependabot[bot]
cabad35383
build(deps): bump node-fetch from 2.6.1 to 2.6.7 ( #32599 )
...
Bumps [node-fetch](https://github.com/node-fetch/node-fetch ) from 2.6.1 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases )
- [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.1...v2.6.7 )
---
updated-dependencies:
- dependency-name: node-fetch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-26 15:42:38 -05:00
WeiZhiHuang
8ec81c1437
fix webRequest.onBeforeSendHeaders' attributes ( #32474 )
...
Co-authored-by: Wayne Huang <zjason4202@gmail.com >
2022-01-26 11:41:54 -05:00
Balakrishna Avulapati
7f517ba878
docs: separate the dependency list for ubuntu ( #32607 )
2022-01-26 10:29:16 -05:00
Sudowoodo Release Bot
bac0a28324
Revert "Bump v18.0.0-nightly.20220126"
...
This reverts commit 4f6b8d06be .
2022-01-26 07:03:50 -08:00
Sudowoodo Release Bot
4f6b8d06be
Bump v18.0.0-nightly.20220126
2022-01-26 05:03:03 -08:00
John Kleinschmidt
8803e7f020
ci: update to Ubuntu 20.04 docker image ( #32614 )
2022-01-25 16:06:41 -05:00
John Kleinschmidt
7814f96413
ci: update ts-compile-doc-change to properly use src cache ( #32613 )
2022-01-25 15:58:24 -05:00
Shelley Vohr
65bee9120f
docs: correct requestSingleInstanceLock parameter ( #32595 )
2022-01-25 12:57:57 -08:00
John Kleinschmidt
335f24b0d0
fix: webContents.setZoomFactor crash ( #32604 )
2022-01-25 12:54:48 -08:00
Cheng Zhao
1cf36822e3
fix: make window without rounded corners closable ( #32597 )
2022-01-25 09:51:53 -05:00
Sudowoodo Release Bot
a0b7e30fe7
Bump v18.0.0-nightly.20220125
2022-01-25 05:01:35 -08:00
Michaela Laurencin
2f0d5651a9
feat: add WCO height option ( #31222 )
...
* feat: add WCO height option
* add docs and mac functionality
* add macOS functionality and height lowerbound
* Update docs/api/browser-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* update macOS functionality
* add chromium related notes
* add test and fix pixel under button bug and fix typo
* revert changes to docs/api/frameless-window.md
* modify `useCustomHeight` calls
* update `useCustomHeight` and `getCurrentMargin`
* modify margin calculation
* fix minimum custom height on macOS
* Update window_buttons_proxy.mm
* fix specified traffic light positions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2022-01-24 17:09:21 -05:00
Kevin
2fe5d0e1e8
feat: Added missing info to IAP transaction and product structures ( #31739 )
2022-01-24 08:55:18 -08:00
Matthew Rayermann
d26d337bb8
feat: add rawHeaders to IncomingMessage ( #31853 )
...
* Add response.rawHeaders to docs for IncomingMessage
* Remove trailing spaces
* Implement raw headers, add tests
* Fix lint issues
* Add example from NodeJS docs
* Fix lint issue in doc example
* Add missing #
2022-01-24 11:46:15 -05:00
Sudowoodo Release Bot
d1b48c0636
Bump v18.0.0-nightly.20220124
2022-01-24 05:01:18 -08:00
Milan Burda
9d054755d6
refactor: implement ajax() in tests using native fetch instead of jQuery ( #32579 )
2022-01-24 10:34:23 +01:00
Jeremy Rose
7032be660d
fix: bundle a11y strings in resources ( #32564 )
2022-01-21 10:04:06 -08:00
Sudowoodo Release Bot
f5e138a5e3
Bump v18.0.0-nightly.20220121
2022-01-21 05:02:26 -08:00
Sudowoodo Release Bot
11a8a296b5
Revert "Bump v18.0.0-nightly.20220120"
...
This reverts commit d619804fc8 .
2022-01-20 19:35:20 -08:00
John Kleinschmidt
6fb013fc10
ci: call autoninja without ninjalog_uploader_wrapper.py ( #32569 )
2022-01-20 19:58:04 -05:00
Jeremy Rose
87b3f6db9d
fix: undisable AXTextMarker and related APIs on MAS ( #32543 )
2022-01-20 15:42:43 -08:00
John Kleinschmidt
6b41356868
test: disable flaky test on WOA ( #32542 )
2022-01-20 13:59:02 -05:00
Sudowoodo Release Bot
d619804fc8
Bump v18.0.0-nightly.20220120
2022-01-20 05:01:34 -08:00
Jeremy Rose
84e2460012
fix: strip crashpad_handler binary ( #32540 )
2022-01-19 19:48:48 -08:00
Shelley Vohr
df50a0efb1
fix: undefined backgroundColor ( #32517 )
2022-01-19 15:51:12 -05:00
Shelley Vohr
b89361a991
fix: crash when saving edited PDF files ( #32512 )
2022-01-19 12:58:32 -05:00
Sudowoodo Release Bot
edfadda899
Bump v18.0.0-nightly.20220119
2022-01-19 05:01:13 -08:00
dependabot[bot]
92bbac8ab6
build(deps): bump shelljs from 0.8.3 to 0.8.5 ( #32481 )
...
Bumps [shelljs](https://github.com/shelljs/shelljs ) from 0.8.3 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases )
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.3...v0.8.5 )
---
updated-dependencies:
- dependency-name: shelljs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-18 12:26:47 -05:00
David Sanders
4903d47ef3
docs: fix broken images for symbol server setup ( #32485 )
2022-01-18 12:14:48 -05:00
AN
ac0d6bdb1e
Clarify will-redirect event doc ( #32093 )
2022-01-18 12:06:22 -05:00
Julia Nam
6860429bf4
Remove broken link and update CircleCI's name ( #32448 )
2022-01-18 12:02:35 -05:00
Sudowoodo Release Bot
015d54ac10
Bump v18.0.0-nightly.20220118
2022-01-18 05:01:15 -08:00
Sudowoodo Release Bot
b93f5fb066
Bump v18.0.0-nightly.20220117
2022-01-17 05:02:43 -08:00
David Sanders
0c75b3b2ea
fix: check for maximized window before unmaximizings ( #32438 )
2022-01-17 16:47:14 +09:00
Shelley Vohr
2a8d49a059
fix: maximize/unmaximize firing on linux ( #32441 )
2022-01-17 16:46:52 +09:00
Jeremy Rose
6e6f5efad9
fix: re-enable PartitionAlloc on macOS ( #32442 )
...
* fix: re-enable PartitionAlloc on macOS
* no need to copy ignore_result on linux
* factor out FixStdioStreams
* include buildflags.h in electron_main_linux
* #include electron/fuses
* more missing includes
2022-01-17 16:46:33 +09:00
David Sanders
fac61122d5
docs: fix anchors for broken relative links ( #32478 )
2022-01-17 16:36:19 +09:00
Sudowoodo Release Bot
868794a6bd
Bump v18.0.0-nightly.20220114
2022-01-14 05:01:00 -08:00
Takao Baba
f75a274019
fix: Corrupted title of alert dialog ( #32434 )
2022-01-13 16:23:36 -05:00
Shelley Vohr
7f4efb6747
fix: desktop screen capture on macOS not releasing ( #32435 )
2022-01-13 16:21:28 +01:00
Shelley Vohr
6c88e3b8e7
fix: optional postMessage transfer arg ( #32433 )
2022-01-13 14:52:48 +01:00
Sudowoodo Release Bot
1aaa0fad69
Bump v18.0.0-nightly.20220113
2022-01-13 05:01:31 -08:00
Charles Kerr
ddd66543f7
docs: explicitly allow string for MessageBoxOptions.icon ( #32422 )
...
Fixes #32390 . See #19782 for context.
2022-01-13 10:30:15 +09:00
Gellert Hegyi
f4548985f4
fix: use setAspectRatio for frameless window on mac ( #32287 )
...
* fix(window): setAspectRatio for frameless windows
* dummy
* undo dummy
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2022-01-13 09:42:42 +09:00
David Sanders
506d82a902
chore: update IsWebContentsCreationOverridden patch ( #32421 )
2022-01-13 09:41:06 +09:00
Jeremy Rose
0a7bc4f5d1
feat: expose blowfish cipher family ( #32356 )
...
Closes #20238
2022-01-12 10:44:28 -08:00
Sudowoodo Release Bot
de436f040f
Bump v18.0.0-nightly.20220112
2022-01-12 05:01:36 -08:00
Milan Burda
99ee1fc0eb
fix: will-attach-webview handler modifying params.instanceId does not break <webview> ( #32386 )
2022-01-12 16:41:20 +09:00
David Sanders
cbe68bdbb8
chore: update DesktopMediaList patch ( #32414 )
2022-01-12 16:39:49 +09:00
David Sanders
2bbba9e242
chore: fix incorrect usage of reference ( #32413 )
2022-01-12 16:39:30 +09:00
David Sanders
94db8cd45e
chore: update notification provenance patch ( #32415 )
2022-01-11 11:27:24 -08:00
Charles Kerr
5d90ff083f
build: pin colors to v1.4.0 in package.json ( #32420 )
2022-01-11 11:24:54 -08:00
electron-roller[bot]
cb927af455
chore: bump node to v16.13.2 (main) ( #32418 )
...
* chore: bump node in DEPS to v16.13.2
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-01-11 10:12:30 -06:00
Sudowoodo Release Bot
d640260592
Bump v18.0.0-nightly.20220111
2022-01-11 05:01:39 -08:00
electron-roller[bot]
b0f315a637
chore: bump chromium to 99.0.4767.0 (main) ( #31986 )
...
* chore: bump chromium in DEPS to 98.0.4726.0
* 3292117: Remove unneeded base/compiler_specific.h includes in //chrome.
https://chromium-review.googlesource.com/c/chromium/src/+/3292117
* 3289198: Enables calculating line, word and sentence boundaries on the browser
https://chromium-review.googlesource.com/c/chromium/src/+/3289198
* 3276176: Remove expired gdi-text-printing flag and associated code.
https://chromium-review.googlesource.com/c/chromium/src/+/3276176
* 3240963: content: allow embedder to prevent locking scheme registry
https://chromium-review.googlesource.com/c/chromium/src/+/3240963
* 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree
https://chromium-review.googlesource.com/c/chromium/src/+/3269899
* chore: fixup patch indices
* 3276279: Enable -Wshadow by default for the "chromium code" config.
https://chromium-review.googlesource.com/c/chromium/src/+/3276279
* 3279737: appcache: Remove WebPreference/WebSetting
https://chromium-review.googlesource.com/c/chromium/src/+/3279737
* 3275564: [api] Advance API deprecation for APIs last marked in v9.6
https://chromium-review.googlesource.com/c/v8/v8/+/3275564
* 3261873: Clean up WebScriptSource constructors
https://chromium-review.googlesource.com/c/chromium/src/+/3261873
* 3279346: appcache: Remove ConsoleMessage appcache field
https://chromium-review.googlesource.com/c/chromium/src/+/3279346
* 3264212: Move legacy file loading to legacy_test_runner
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Both Persistence and UI have been removed from globals, but the issues they
seemed to be patching are no longer reproducible from what I can tell, and
so we can just delete these and re-evaluate if something surfaces.
* 3290415: x11: remove the USE_X11 define.
https://chromium-review.googlesource.com/c/chromium/src/+/3290415
* chore: bump Chromium to 98.0.4728.0
* 3179530: Defer system calls in PrintingContext for OOP printing
https://chromium-review.googlesource.com/c/chromium/src/+/3179530
* 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn.
https://chromium-review.googlesource.com/c/chromium/src/+/3299445
* chore: update patch indices
* 3223975: Break PrintJobWorker OOP logic into separate class
https://chromium-review.googlesource.com/c/chromium/src/+/3223975
* chore: bump chromium in DEPS to 98.0.4730.0
* 3279001: Remove support for font-family: -webkit-pictograph
https://chromium-review.googlesource.com/c/chromium/src/+/3279001
* chore: fixup patch indices
* chore: bump chromium in DEPS to 98.0.4732.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4734.0
* chore: bump chromium in DEPS to 98.0.4736.0
* chore: update patches
* chore: update printing patch for miracle ptr
* chore: add noexcept to fix clang error
* chore: bump chromium in DEPS to 98.0.4738.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4740.0
* chore: bump chromium in DEPS to 98.0.4742.0
* chore: bump chromium in DEPS to 98.0.4744.0
* chore: bump chromium in DEPS to 98.0.4746.0
* chore: bump chromium in DEPS to 98.0.4748.0
* chore: bump chromium in DEPS to 98.0.4750.0
* chore: update patches
* 3293841: Remove File Handling permissions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841
* chore: update patches
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* 3289260: [CodeHealth]: Remove uses of Notification Service
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260
* 3301600: Disable scripted print in fenced frames
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600
* chore: add missing thread_restrictions headers
* 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
* fix: add ppapi_sandbox header for linux
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* chore: manually bump chromium in DEPS to 98.0.4757.0
* chore: update patches
* 3321044: Remove DictionaryValue::Clear()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044
* chore: update printing.patch
Refs:
- 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556
- 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095
* build: add v8-embedder-state headers to GN patch
* chore: bump chromium in DEPS to 99.0.4767.0
* chore: update patches
* chore: rename CookiePartitionKeychain
...to CookiePartitionKeyCollection
* chore: update video consumers
* refactor: use newer base::Value API
* 3232598: Convert net::DnsOverHttpsServerConfig into a class | https://chromium-review.googlesource.com/c/chromium/src/+/3232598
* 3327865: Remove the default WebContentsUserData ctor. | https://chromium-review.googlesource.com/c/chromium/src/+/3327865
* 3302814: DevTools: Add getPreference binding | https://chromium-review.googlesource.com/c/chromium/src/+/3302814
* 3301474: [tq][runtime] Use build flags for JS context promise hooks | https://chromium-review.googlesource.com/c/v8/v8/+/3301474
* oops 😵💫
* 3272411: Reland "base/allocator: Enable PartitionAlloc-Everywhere on macOS" | https://chromium-review.googlesource.com/c/chromium/src/+/3272411
build: turn PartitionAlloc back off on mac for now
* fix: WCO method got renamed
* 3344749: Revert "Stop using NSRunLoop in renderer process"
https://chromium-review.googlesource.com/c/chromium/src/+/3344749
* 3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues.
https://chromium-review.googlesource.com/c/chromium/src/+/3288746
* Revert "3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues."
This reverts commit 5cc69f102e43ca72ac9ef45063711bcc7d849740.
* chore: disable serial device enumerator sequence dcheck
* fix: comment out line in DeviceService dtor
* fixup! 3279001: Remove support for font-family: -webkit-pictograph
* fixup! 3279346: appcache: Remove ConsoleMessage appcache field
* chore: update patches after rebase
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-01-10 17:31:39 -05:00
Romain Pokrzywka
483808a8cf
fix: Support running git-[im,ex]port-patches with Python3 too ( #32303 )
...
* script: Python3 compatibility for utf8 conversion
The unicode() method has been renamed to str() in Python3,
add a wrapper around it to support running against both versions.
* script: don't require python2 for git-[import,export]-patches
The scripts work just fine with python3 too, so use the generic
python executable as the script interpreter.
Most setups don't even require or provide python 2 anymore,
so this saves one from having to install it just for the scripts.
2022-01-10 16:47:55 -05:00
Raymond Zhao
746927c972
feat: Add first-instance-ack event to the app.requestSingleInstanceLock() flow ( #31460 )
...
* feat: Add onFirstInstanceAck event for requestSingleInstanceLock
* Add tests
* Apply patch fix
* Add back missing docs
* Rebase
* Listen for exit earlier in test
* Rebase
2022-01-10 11:54:46 -05:00
Sudowoodo Release Bot
7c16ef1f62
Bump v18.0.0-nightly.20220110
2022-01-10 05:02:55 -08:00
Evan Hahn
ef058892bb
docs: clarify case insensitive dictionary hosting ( #32222 )
...
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.
[0]: https://github.com/electron/electron/issues/22482#issuecomment-593617375
2022-01-10 11:07:46 +01:00
David Sanders
bd861e5079
docs: fix note for will-move event ( #32362 )
2022-01-10 11:02:16 +01:00
Milan Burda
cb2c1f888e
fix: incorrect skipTransformProcessType option parsing in win.setVisibleOnAllWorkspaces() ( #32364 )
2022-01-10 11:00:28 +01:00
Milan Burda
6d8a858897
docs: left is a valid mode in contents.openDevTools() options ( #32372 )
2022-01-10 10:50:18 +01:00
Sudowoodo Release Bot
948db1d881
Bump v18.0.0-nightly.20220107
2022-01-07 05:01:26 -08:00
Tommy MacWilliam
824c909e2a
fix: Allow npm_config_arch override on mac ( #32266 )
...
If the npm_config_arch environment variable is set on Mac, then use the
specified architecture rather than overriding it to x64.
2022-01-07 17:53:15 +09:00
Milan Burda
7678a0aebb
chore: cleanup spec-main/ambient.d.ts ( #32363 )
2022-01-07 17:52:47 +09:00
Raymond Zhao
88ae6c0635
fix: Don't create console window when creating process ( #32340 )
...
* fix: Don't create console window when creating process
* Update patches/node/fix_don_t_create_console_window_when_creating_process.patch
Co-authored-by: Robo <hop2deep@gmail.com >
* Remove extra line in description
Co-authored-by: Robo <hop2deep@gmail.com >
2022-01-07 17:38:34 +09:00
Jeremy Rose
a015332342
fix: drop nativeWindowOpen deprecation warning ( #32370 )
2022-01-06 12:01:55 -08:00
Mitchell Cohen
5af6b898d9
feat: add Substitutions menu roles on macOS ( #32024 )
2022-01-06 10:41:28 -08:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option ( #29405 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2022-01-06 09:28:03 -08:00
Milan Burda
2f9fd06534
chore: deprecate nativeWindowOpen in Electron 17 ( #32116 )
2022-01-06 05:08:59 -08:00
Sudowoodo Release Bot
c3b9f0e7b2
Bump v18.0.0-nightly.20220106
2022-01-06 05:01:49 -08:00
MikeBusuttil
c1c710bc01
docs: improve BrowserView example ( #32098 )
...
* working example
previous example not beginner-friendly
* Update browser-view.md
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2022-01-06 12:09:36 +09:00
Timothy
30e0620ccc
docs: fix wording on testing documentation ( #32279 )
2022-01-06 09:24:52 +09:00
Keeley Hammond
b61805b63a
fix: use allocationtype kold in v8 scriptormodule legacy lifetime ( #32339 )
2022-01-05 11:43:28 -08:00
Sudowoodo Release Bot
dd4eae8a3b
Bump v18.0.0-nightly.20220105
2022-01-05 05:01:56 -08:00
vulture
62c1c86be9
Rename patch file to .patch to conform to naming standard which utilizes .gitattributes settings ( #32324 )
...
Co-authored-by: stsean <stsean@justin.tv >
2022-01-05 10:36:48 +01:00
Sudowoodo Release Bot
b63c190fe6
Bump v18.0.0-nightly.20220104
2022-01-04 05:01:25 -08:00
Shubham Kumar
cbdb2e6ec2
fix : #32141 register wrong command for setAsDefaultProtocolClient for windows ( #32220 )
2022-01-04 10:47:28 +09:00
Maciej Krawczyk
84f1d78558
docs: correct webFrame description ( #32205 )
...
The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.
2022-01-04 10:12:55 +09:00
Darshan Sen
4600d7e7f6
fix: crash caused by app.getLocaleCountryCode() ( #32256 )
...
CFLocaleGetValue() returned null and crashed the process when
app.getLocaleCountryCode() was run on a CircleCI metal resource class
macOS instance with Xcode 12.5.1. This change fixes that logic and adds
further checks to make the code future-proof.
Here too people are complaining that the returned country code migth be
null: https://stackoverflow.com/questions/15202454/nslocalecountrycode-returns-nil
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2022-01-03 13:54:58 -08:00
Duncan Hewett
2c700da4de
docs: add Bugsnag as a 3rd party crash server ( #32053 )
2022-01-03 14:48:15 -05:00
Oran C
195d2b5b3e
[fix] Docs rendering issue with rendering on electronjs quick-start ( #32293 )
...
there is a issue with rendering on the bottom of page https://www.electronjs.org/docs/v14-x-y/tutorial/quick-start
which looks like this

all id did is remove the spacing and it should fix the issue. sometimes having spaces before a "```" will cause issues
hope this helps!
2022-01-03 11:18:02 -08:00
Romain Pokrzywka
727453ef04
build: remove stale dependency for webrtc desktop capture module ( #32304 )
...
WebRTC has changed how they integrate into Chromium, they don't
expose their dependencies externally anymore. Instead, one must
now go through webrtc_overrides:
https://chromium.googlesource.com/chromium/src.git/+/cbc90fd093956
We're already including webrtc_overrides as a dependency which
includes the modules, so this extra deps isn't needed anymore.
2022-01-03 11:57:00 -05:00
Sudowoodo Release Bot
84451e7daf
Bump v18.0.0-nightly.20220103
2022-01-03 05:04:24 -08:00
ganthern
f766bb483d
docs: fix typo in bug report issue template ( #32208 )
2022-01-03 10:35:19 +01:00
Jack Nemitz
1d8612ad5d
Fix typo in quick-start.md ( #32282 )
...
Resolve a grammar issue in the quick-start guide.
2022-01-03 09:59:55 +01:00
Sudowoodo Release Bot
ac39cb14e9
Bump v18.0.0-nightly.20211231
2021-12-31 05:01:03 -08:00
Sudowoodo Release Bot
f1b0d30d8d
Bump v18.0.0-nightly.20211229
2021-12-29 05:01:36 -08:00
Sudowoodo Release Bot
d59a4a0771
Bump v18.0.0-nightly.20211228
2021-12-28 05:01:13 -08:00
Sudowoodo Release Bot
6b2adea867
Revert "Bump v18.0.0-nightly.20211227"
...
This reverts commit 66a55ba778 .
2021-12-27 11:35:06 -08:00
Sudowoodo Release Bot
66a55ba778
Bump v18.0.0-nightly.20211227
2021-12-27 05:01:32 -08:00
Sudowoodo Release Bot
f17e8996ac
Bump v18.0.0-nightly.20211223
2021-12-23 05:02:41 -08:00
Sudowoodo Release Bot
b433163d7a
Bump v18.0.0-nightly.20211222
2021-12-22 05:04:57 -08:00
Sudowoodo Release Bot
79eaef4aab
Bump v18.0.0-nightly.20211221
2021-12-21 05:01:15 -08:00
Sudowoodo Release Bot
2b25e737a7
Bump v18.0.0-nightly.20211220
2021-12-20 05:02:21 -08:00
Keeley Hammond
ffbaa1d83f
fix: check for single bluetooth listener ( #32240 )
2021-12-17 16:55:43 -08:00
Sudowoodo Release Bot
909dbe6890
Bump v18.0.0-nightly.20211217
2021-12-17 05:01:12 -08:00
electron-roller[bot]
eaae6c1553
chore: bump node to v16.13.1 (main) ( #32086 )
...
* chore: bump node in DEPS to v16.13.1
* update patches
* update c-ares BUILD.gn
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2021-12-16 14:41:25 -08:00
Micha Hanselmann
e9420982d2
fix: older systems crash when playing media files ( #32046 )
...
* fix: win7 crash when playing media
* reset
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-12-16 09:23:30 -08:00
Sudowoodo Release Bot
c1b3b3064b
Bump v18.0.0-nightly.20211216
2021-12-16 05:00:36 -08:00
Samuel Attard
a11f5cbb27
fix: ensure bluetooth devices are not returned by default ( #32178 )
2021-12-15 11:46:48 -08:00
Sudowoodo Release Bot
1facbb4a09
Bump v18.0.0-nightly.20211215
2021-12-15 05:02:27 -08:00
Dennis
d5b6a2f800
Update discord url to electronjs ( #32173 )
...
The discord url in this page is discord.gg/electron, which refers to a (supposed) roblox scripting group.
2021-12-14 13:25:56 -08:00
Sudowoodo Release Bot
292409a301
Bump v18.0.0-nightly.20211214
2021-12-14 05:01:26 -08:00
Sudowoodo Release Bot
f887ca0082
Bump v18.0.0-nightly.20211213
2021-12-13 05:01:46 -08:00
stephen9357
6d9e2e3ad0
docs: Fix environment variable name ( #32094 )
...
The names of environment variables are case-sensitive on Linux and Mac.
2021-12-13 15:42:43 +09:00
Sudowoodo Release Bot
c4e471fbe2
Bump v18.0.0-nightly.20211210
2021-12-10 05:02:25 -08:00
Sudowoodo Release Bot
1341b0a6b7
Bump v18.0.0-nightly.20211209
2021-12-09 05:01:05 -08:00
Sudowoodo Release Bot
cf0959f834
Bump v18.0.0-nightly.20211208
2021-12-08 05:01:41 -08:00
Sudowoodo Release Bot
f615075847
Bump v18.0.0-nightly.20211207
2021-12-07 14:57:31 -08:00
Sudowoodo Release Bot
d53399ea31
Revert "Bump v18.0.0-nightly.20211207"
...
This reverts commit df7eb209a5 .
2021-12-07 08:21:50 -08:00
Sudowoodo Release Bot
df7eb209a5
Bump v18.0.0-nightly.20211207
2021-12-07 05:01:42 -08:00
Sudowoodo Release Bot
12c5b9eaac
Bump v18.0.0-nightly.20211206
2021-12-06 05:01:29 -08:00
Cheng Zhao
35ac7fb8e6
fix: window.open not overriding parent's webPreferences ( #32057 )
...
* fix: window.open not overriding parent's webPreferences
* test: remove "nativeWindowOpen: false" from renderer tests
2021-12-06 12:54:14 +09:00
Milan Burda
77287febf4
refactor: use process type specific electron imports in default_app ( #32097 )
2021-12-06 11:44:41 +09:00
fengmk2
f46e9c3205
docs: change China mirror domain to npmmirror.com ( #32076 )
2021-12-06 11:28:41 +09:00
Sudowoodo Release Bot
f3df76dbdc
Bump v18.0.0-nightly.20211203
2021-12-03 05:02:32 -08:00
Sudowoodo Release Bot
0c5b01f5f6
Bump v18.0.0-nightly.20211202
2021-12-02 05:05:03 -08:00
Tristan Partin
eabfd6c1b9
fix: gtk_native_dialog_run() calls show() internally ( #32049 )
...
In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.
2021-12-01 20:19:36 -08:00
Sudowoodo Release Bot
cce427dc46
Bump v18.0.0-nightly.20211201
2021-12-01 05:00:57 -08:00
Samuel Attard
ed7f9ad5c2
fix: avoid double call in OnRefreshComplete on aura platforms ( #32052 )
2021-11-30 15:12:39 -08:00
Black-Hole
bc8cfbac59
docs: add debug build ( #31979 )
...
* docs: add debug build
* docs: move debug config document to debugging.md
* fix: debug.gn import failed
* docs: modify debug.gn folder on doc
* docs: imporve gn import path
2021-11-30 16:40:58 -05:00
Sudowoodo Release Bot
3d34fd7c91
Bump v18.0.0-nightly.20211130
2021-11-30 11:14:36 -08:00
Sudowoodo Release Bot
ab92455fc8
Revert "Bump v18.0.0-nightly.20211130"
...
This reverts commit 90410e0419 .
2021-11-30 09:49:21 -08:00
Sudowoodo Release Bot
90410e0419
Bump v18.0.0-nightly.20211130
2021-11-30 09:18:59 -08:00
Keeley Hammond
83a4b234d7
build: account for path-filtering workflow in release-build script ( #32063 )
...
* build: account for path-filtering workflow in release-build script
* build: update syntax for workflow id
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-11-30 09:17:04 -08:00
Sudowoodo Release Bot
3278ff6a05
Revert "Bump v18.0.0-nightly.20211130"
...
This reverts commit 395b43b293 .
2021-11-30 09:16:09 -08:00
Sudowoodo Release Bot
395b43b293
Bump v18.0.0-nightly.20211130
2021-11-30 05:00:57 -08:00
Keeley Hammond
43f36b5b24
build: add CI path-filtering for docs-only changes ( #31741 )
...
build: (wip) initial dynamic config research
* build: (wip) test path filtering option
* build: (wip) remove doc-only script, use path filtering to check changes
* build: (wip) add docker image with Electron dependencies
* build: (wip) clean up config
* build (wip): readd parameters, executors and env*s
* build: re-add steps and commands
* build: change doc-only to ts-compile-doc-only
* build: re-add workflows and jobs
* build: split configs to setup & build
* build: move lint to "always run" config
* build: clean up, remove old reference config
* build: bump to path-filtering 0.1.0
* build: remove ts-compile step from build-linux
* build: remove nightly-linux-release-test, linux-checks-nightly
* build: don't run build on publish
* build: set base-revision to main (runs branch vs commit)
* build: update config from chromium roll
2021-11-29 18:09:07 -05:00
Sudowoodo Release Bot
46634bc0f2
Bump v18.0.0-nightly.20211129
2021-11-29 05:03:23 -08:00
Sudowoodo Release Bot
24d272ca41
Bump v18.0.0-nightly.20211126
2021-11-26 05:01:27 -08:00
Erick Zhao
b4b0667d52
chore: make Discord invite non-vanity ( #31991 )
2021-11-26 13:10:07 +13:00
Sudowoodo Release Bot
4609d4cb7a
Bump v18.0.0-nightly.20211125
2021-11-25 05:01:26 -08:00
Sudowoodo Release Bot
3834aaf4e9
Bump v18.0.0-nightly.20211124
2021-11-24 12:47:25 -08:00
John Kleinschmidt
f1b8f9692d
chore: update patches ( #31988 )
2021-11-24 15:35:48 -05:00
Sudowoodo Release Bot
b49a9629c0
Revert "Bump v18.0.0-nightly.20211124"
...
This reverts commit e53f1af97e .
2021-11-24 07:28:53 -08:00
Sudowoodo Release Bot
e53f1af97e
Bump v18.0.0-nightly.20211124
2021-11-24 05:02:04 -08:00
electron-roller[bot]
bd10b19b0c
chore: bump chromium to 98.0.4706.0 (main) ( #31555 )
...
* chore: bump chromium in DEPS to 97.0.4678.0
* chore: bump chromium in DEPS to 97.0.4679.0
* chore: bump chromium in DEPS to 97.0.4680.0
* chore: bump chromium in DEPS to 97.0.4681.0
* chore: bump chromium in DEPS to 97.0.4682.0
* chore: update patches
* 3234737: Disable -Wunused-but-set-variable
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3234737
* 3216953: Reland "Move task-related files from base/ to base/task/"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3216953
* 3202710: TimeDelta factory function migration.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3202710
* 3226841: Rename WCO::RenderProcessGone to PrimaryMainFrameRenderProcessGone
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3226841
* 3212165: blink/gin: changes blink to load snapshot based on runtime information
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3212165
* 3220292: Deprecate returning a GURL from GURL::GetOrigin()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3220292
* 3231995: build: Enable -Wbitwise-instead-of-logical everywhere except iOS and Windows
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3231995
* 3205121: Remove base::DictionaryValue::GetDouble
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3205121
* 3208413: [flags] Make --js-flags settings have priority over V8 features
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3208413
* chore: bump chromium in DEPS to 97.0.4683.0
* chore: update patches
* 3188834: Combine RWHVBase GetCurrentDeviceScaleFactor/GetDeviceScaleFactor
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3188834
* chore: update process_singleton patches
* chore: bump chromium in DEPS to 97.0.4684.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4685.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4686.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4687.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4688.0
* chore: update patches
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3247722
Update signature of HandleContextMenu()
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3247722
Update signature of HandleContextMenu()
* 3223422: Remove PP_ISOLATEDFILESYSTEMTYPE_PRIVATE_PLUGINPRIVATE enum option
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3223422
sync pepper_plugin_support.patch with upstream
* chore: bump chromium in DEPS to 97.0.4689.0
* 3247791: ax_mac_merge: Merge AX Math attribute implementations
Xref: ax_mac_merge: Merge AX Math attribute implementations
chore: fix minor patch shear in #includes
* 3243425: Add VisibleTimeRequestTrigger helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3243425
chore: fix minor patch shear in #includes
* chore: regen chromium patches
* fixup! 3247722: Use correct source_site_instance if navigating via context menu
* chore: bump chromium in DEPS to 97.0.4690.0
* 3188659: Window Placement: make GetScreenInfo(s) const
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3188659
simple sync GetScreenInfo with upstream refactor
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4690.4
* chore: bump chromium in DEPS to 97.0.4692.0
* 3198073: ozone: //content: clean up from USE_X11
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3198073
Fixing patch shear. Nothing to see here.
* 3252338: Remove label images checkbox from chrome://accessibility page
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3252338
Part of our a11y patch is no longer needed due to upstream label removal
* 3258183: Remove DISALLOW_IMPLICIT_CONSTRUCTORS() definition
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3258183
Replace our use of the macro with explicitly-deleted class methods.
See https://chromium-review.googlesource.com/c/chromium/src/+/3256952
for upstream examples of this same replacement.
* chore: update patches
* 3247295: Unwind SecurityStyleExplanations
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3247295
update GetSecurityStyle() signature and impl to match upstream changes
* 3259578: media: grabs lock to ensure video output when occluded
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3259578
Add stub for new upstream virtual method OnCapturerCountChanged()
* fixup! 3247295: Unwind SecurityStyleExplanations
* 3238504: Fix up drag image is not shown from bookmark bar
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3238504
SetDragImage() no longer takes a widget argument
* 3217452: [devtools] Add getSyncInformation host binding
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3217452
Add stub for new upstream method GetSyncInformation(). Stub sends info back to caller saying that syncing is disabled.
* chore: bump chromium in DEPS to 98.0.4693.0
* chore: bump chromium in DEPS to 98.0.4694.0
* chore: bump chromium in DEPS to 98.0.4695.0
* chore: bump chromium in DEPS to 98.0.4696.0
* chore: bump chromium in DEPS to 98.0.4697.0
* chore: bump chromium in DEPS to 98.0.4699.0
* chore: bump chromium in DEPS to 98.0.4701.0
* chore: bump chromium in DEPS to 98.0.4703.0
* chore: bump chromium in DEPS to 98.0.4705.0
* chore: bump chromium in DEPS to 98.0.4706.0
* chore: update patches
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
https://chromium-review.googlesource.com/c/chromium/src/+/3279210
* 3259964: Remove all DISALLOW_COPY_AND_ASSIGNs
https://chromium-review.googlesource.com/c/chromium/src/+/3259964
* 3269029: blink/gin: sets histogram callbacks during isolate creation
https://chromium-review.googlesource.com/c/chromium/src/+/3269029
* fixup after rebase
* [content] Make ContentMainParams and MainFunctionParams move-only
https://chromium-review.googlesource.com/c/chromium/src/+/3244976
* 3255305: Stop sending the securityStateChanged event and unwind
https://chromium-review.googlesource.com/c/chromium/src/+/3255305
* [Blink] Add promise support to WebLocalFrame::RequestExecuteScript()
https://chromium-review.googlesource.com/c/chromium/src/+/3230010
* 3256162: Simplify RWHV Show and ShowWithVisibility handling
https://chromium-review.googlesource.com/c/chromium/src/+/3256162
* 3263824: ozone: //ui/base: clean up from USE_X11 1/*
https://chromium-review.googlesource.com/c/chromium/src/+/3263824
* Request or cancel RecordContentToPresentationTimeRequest during capture
https://chromium-review.googlesource.com/c/chromium/src/+/3256802
* appcache: remove BrowsingData/quota references
https://chromium-review.googlesource.com/c/chromium/src/+/3255725
* [Autofill] Don't show Autofill dropdown if overlaps with permissions
https://chromium-review.googlesource.com/c/chromium/src/+/3236729
* Rename to_different_document to should_show_loading_ui in LoadingStateChanged() callbacks
https://chromium-review.googlesource.com/c/chromium/src/+/3268574
* cleanup patch
* fixup [content] Make ContentMainParams and MainFunctionParams move-only
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
https://chromium-review.googlesource.com/c/chromium/src/+/3279210
* ozone: //chrome/browser clean up from USE_X11
https://chromium-review.googlesource.com/c/chromium/src/+/3186490
Refs: https://github.com/electron/electron/issues/31382
* chore: update support_mixed_sandbox_with_zygote.patch
* Enable -Wunused-but-set-variable.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3234737
* fixup! ozone: //ui/base: clean up from USE_X11 1/*
* fixup! ozone: //chrome/browser clean up from USE_X11
* chore: fix deprecation warning in libuv
* chore: fixup for lint
* 3251161: Reland "Make the Clang update.py script require Python 3"
https://chromium-review.googlesource.com/c/chromium/src/+/3251161
* fixup: Enable -Wunused-but-set-variable.
* [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
https://chromium-review.googlesource.com/c/chromium/src/+/3262369
* Replace sandbox::policy::SandboxType with mojom Sandbox enum
https://chromium-review.googlesource.com/c/chromium/src/+/3213677
* fixup: [content] Make ContentMainParams and MainFunctionParams move-only
* build: ensure angle has a full git checkout available to it
* fixup: [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
* fixup lint
* [unseasoned-pdf] Dispatch 'afterprint' event in PDF plugin frame
https://chromium-review.googlesource.com/c/chromium/src/+/3223434
* fixup: [Autofill] Don't show Autofill dropdown if overlaps with permissions
* 3217591: Move browser UI CSS color parsing to own file part 2/2
https://chromium-review.googlesource.com/c/chromium/src/+/3217591
* Make kNoSandboxAndElevatedPrivileges only available to utilities
https://chromium-review.googlesource.com/c/chromium/src/+/3276784
* 3211575: [modules] Change ScriptOrModule to custom Struct
https://chromium-review.googlesource.com/c/v8/v8/+/3211575
* Address review feedback
* chore: update patches
* 3211575: [modules] Change ScriptOrModule to custom Struct
https://chromium-review.googlesource.com/c/v8/v8/+/3211575
* fix: unused variable compat
* chore: remove redundant patch
* fixup for 3262517: Re-enable WindowCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3262517
* chore: cleanup todo
The functions added in https://chromium-review.googlesource.com/c/chromium/src/+/3256802 are not used by offscreen rendering.
* fixup: update mas_no_private_api.patch
* 3216879: [PA] Make features::kPartitionAllocLazyCommit to be PartitionOptions::LazyCommit
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3216879 Fixes up commit b2f1aca956
* chore: cleanup support_mixed_sandbox_with_zygote.patch
* test: use window focus event instead of delay to wait for webContents focus
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-11-24 09:45:59 +01:00
Erick Zhao
065cad6d2c
docs: add playwright e2e testing docs ( #31961 )
2021-11-23 11:47:24 -08:00
Robo
9ab102e156
fix: console windows from ELECTRON_RUN_AS_NODE instances ( #31963 )
2021-11-23 09:34:07 -08:00
Sudowoodo Release Bot
681fe435fe
Bump v18.0.0-nightly.20211123
2021-11-23 05:01:47 -08:00
Sudowoodo Release Bot
4713acce8d
Bump v18.0.0-nightly.20211122
2021-11-22 05:00:55 -08:00
CezaryKulakowski
557e586667
fix: fix aspect ratio when max width/height is set ( #29101 )
...
Add the native frame border size to the minimum and maximum size if
the view reports its size as the client size. It allows to enlarge
window to proper values when aspect ratio and max width/height are
set. It also fixes DCHECK which was triggered when user tried to
enlarge window above dimensions set during creation of the
BrowserWindow.
2021-11-22 18:31:21 +09:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
dependabot[bot]
0865267387
build(deps-dev): bump aws-sdk from 2.727.1 to 2.814.0 ( #31867 )
...
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js ) from 2.727.1 to 2.814.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases )
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-js/compare/v2.727.1...v2.814.0 )
---
updated-dependencies:
- dependency-name: aws-sdk
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-22 09:50:36 +09:00
Shelley Vohr
239ba7d905
fix: BrowserView setBackgroundColor needs two calls ( #31863 )
2021-11-22 09:38:05 +09:00
Black-Hole
38d2ec0cb6
fix: ninja build failed on some system ( #31887 )
2021-11-22 09:37:13 +09:00
Milan Burda
7ff15038d6
fix: lint Objective-C header files ( #31923 )
2021-11-22 09:36:32 +09:00
Sudowoodo Release Bot
98a5996b30
Bump v18.0.0-nightly.20211119
2021-11-19 05:02:11 -08:00
Sudowoodo Release Bot
eb56209206
Bump v18.0.0-nightly.20211118
2021-11-18 05:01:32 -08:00
Keeley Hammond
0cb46a3712
fix: add resource strings for file selection ( #31881 )
2021-11-17 14:13:49 -08:00
Keeley Hammond
3e71310a9f
chore: update nmv to 103 for Electron 18 ( #31778 )
2021-11-17 11:35:00 -08:00
Sergey Zolotarev
9f12edac65
Fix typo in distribution docs ( #31791 )
2021-11-17 12:20:24 -06:00
Donald D. Nevermore
706143fe85
docs: update cache paths in installation doc ( #31803 )
2021-11-17 10:16:08 -05:00
Sudowoodo Release Bot
dcf1df0959
Bump v17.0.0-nightly.20211117
2021-11-17 05:01:22 -08:00
Sudowoodo Release Bot
16ba2eff9a
Bump v17.0.0-nightly.20211116
2021-11-16 05:01:49 -08:00
Darshan Sen
25f2abb64d
chore: use std::forward() in ConvertToV8() ( #31817 )
...
The variable `input` is accepted by a universal reference, so it doesn't
make sense to cast a potential lvalue reference into an rvalue
reference. In case `input` is an lvalue reference, we should rather
forward the value as is to `ToV8()`.
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2021-11-16 09:15:32 +01:00
Milan Burda
e6b1d95a1c
docs: type names changed from wrapper to primitive ( #31752 )
2021-11-15 22:13:18 -06:00
Samuel Attard
246884c4fb
fix: provide paths for all NetworkContextFilePaths keys ( #31777 )
...
* fix: provide paths for all NetworkContextFilePaths keys
* chore: include chrome features header
* chore: build browser_features
* yolo
* add pref service
* fix: include sandbox policy features
* fix pref key
* fix: gate pref key to OS_WIN
Co-authored-by: VerteDinde <khammond@slack-corp.com >
2021-11-15 15:26:09 -08:00
Shelley Vohr
65e4f75058
fix: make BrowserView aware of owning window ( #31796 )
2021-11-15 16:23:31 +01:00
Keeley Hammond
bf7b245fa0
fix: change cookie default from NO_RESTRICTION to LAX_MODE ( #31800 )
...
* fix: change default from NO_RESTRICTION to LAX_MODE
* chore: update cookie docs, redirect tests
2021-11-15 09:20:04 -06:00
Fedor Indutny
d9e93b3c4b
fix: media shouldn't open permissions dialog ( #31805 )
...
* fix: media shouldn't open permissions dialog
Playing media shouldn't open Accessibility permissions dialog on macOS.
However, we still need to watch for media events, just not globally and
`media_keys_listener_` is an API over global capture of the media keys.
The fix is to let chromium call `UpdateWhichKeysAreListenedFor` which
will call `UpdateSystemMediaControlsEnabledControls` and watch for
events on `system_media_controls_` without triggering permissions popup.
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-11-15 14:16:16 +01:00
Sudowoodo Release Bot
2e11f609ac
Bump v17.0.0-nightly.20211115
2021-11-15 05:01:56 -08:00
Micha Hanselmann
d4abb6fb66
fix: setContentProtection affects BrowserWindow frame ( #31768 )
2021-11-15 10:51:27 +01:00
Shelley Vohr
7e328c4b87
fix: crash on browserView.webContents.destroy() ( #31794 )
2021-11-15 08:24:22 +01:00
Charles Kerr
22f863b37a
fix: correct default text for button labels in gtk dialogs ( #31798 )
2021-11-15 08:18:33 +01:00
Charles Kerr
c8ba3b4556
fix: in GTK open dialog, do not preview huge files ( #31799 )
2021-11-15 08:17:11 +01:00
Cheng Zhao
a6a5ca1db3
fix: crash caused by GetHostNameW on Windows 7 ( #31804 )
2021-11-14 16:39:31 +09:00
Sudowoodo Release Bot
a41898bb9b
Bump v17.0.0-nightly.20211112
2021-11-12 05:00:58 -08:00
Charles Kerr
cac871c027
Revert "refactor: only create webContents after 'will-attach-webview' ( #30311 )" ( #31785 )
...
This reverts commit 6e43b0bcbf .
2021-11-11 15:04:06 -05:00
Sudowoodo Release Bot
09d160f406
Bump v17.0.0-nightly.20211111
2021-11-11 05:00:57 -08:00
Sofia Nguy
3108450c77
doc: Update E17 release dates ( #31786 )
2021-11-10 17:13:02 -08:00
Milan Burda
18cc33055d
chore: move libs only used in browser out of common ( #31780 )
2021-11-10 08:54:51 -08:00
Sudowoodo Release Bot
4c4ed6c705
Bump v17.0.0-nightly.20211110
2021-11-10 05:02:00 -08:00
Michaela Laurencin
6bc5fa3758
fix: generate angle brackets in release notes ( #31757 )
2021-11-10 10:06:59 +09:00
Milan Burda
dfb3b24de1
refactor: merge duplicate code from sandboxed/non-sandboxed renderer init ( #31755 )
2021-11-10 09:59:33 +09:00
Shelley Vohr
b40f3d4cfc
fix: BrowserView setBackgroundColor() ( #31746 )
2021-11-09 11:36:29 -05:00
Shelley Vohr
25cdbb7d3a
fix: failing Node.js certificate spec ( #31748 )
2021-11-09 11:29:04 -05:00
Sudowoodo Release Bot
0f83624693
Bump v17.0.0-nightly.20211109
2021-11-09 05:00:42 -08:00
Milan Burda
68b8e9be9a
chore: cleanup obsolete lib/common/remote/ipc-messages.ts ( #31756 )
2021-11-09 03:18:44 -08:00
John Kleinschmidt
4b3aed503f
test: fix crash in electron::NativeWindowMac::Close() ( #31750 )
...
* test: fix crash in electron::NativeWindowMac::Close()
* remove extra close
2021-11-08 19:27:32 -08:00
Milan Burda
fe7f296339
refactor: remove duplicate contextIsolation from getWebPreference() ( #31730 )
2021-11-08 11:57:56 -05:00
Sudowoodo Release Bot
4af21a1df8
Bump v17.0.0-nightly.20211108
2021-11-08 05:02:28 -08:00
Milan Burda
daed10512d
chore: remove Breakpad tests for crashReporter on Linux ( #31729 )
2021-11-08 10:20:43 +01:00
Milan Burda
97eb424450
refactor: move certificate_manager_model to shell ( #31631 )
2021-11-08 09:53:00 +09:00
Milan Burda
95a867b795
fix: <webview> background transparency ( #31722 )
2021-11-05 19:55:19 -07:00
Sudowoodo Release Bot
bc4308dcf8
Bump v17.0.0-nightly.20211105
2021-11-05 06:02:02 -07:00
henrit
3c33d70294
fix: clipboard.writeBuffer raw format access ( #31116 )
...
* fix: clipboard.writeBuffer raw format access
* test: clipboard.writeBuffer raw format access
* test: clipboard win32 test skip
* fixup spec
* cleanup patch
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-11-04 14:19:30 -04:00
John Kleinschmidt
f8df634197
test: deflake <webview> tag loads devtools extensions on WOA ( #31702 )
2021-11-04 14:00:28 -04:00
Shelley Vohr
96a04c67fd
fix: crash dump location on Linux ( #31668 )
...
* fix: crash dump location on Linux
* fix: ignore client_id for Zygote process
* chore: update comment
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-11-04 13:45:59 -04:00
Sudowoodo Release Bot
b6b9cec604
Bump v17.0.0-nightly.20211104
2021-11-04 06:04:56 -07:00
Raymond Zhao
9e0e04da25
fix: second-instance additionalData parameter ( #31661 )
...
* test: second-instance additionalData parameter
* Fix posix implementation
2021-11-04 01:14:09 -07:00
Keeley Hammond
86f6285299
fix: apply transparency settings to WebContentsPreferences ( #31685 )
...
* fix: add transparency to web_contents_preferences
* fix: correctly apply transparency settings to new webContents from webPreferences
2021-11-03 11:16:18 -07:00
Charles Kerr
190dd31dbc
refactor: use upstream AutofillDriverFactory diffs ( #31676 )
...
* refactor: use upstream AutofillDriverFactory diffs
Update our copy of AutofillDriver and AutofillDriverFactory to match chromium.
2021-11-03 12:17:06 -05:00
Shelley Vohr
24b02d68a7
fix: incorrect Content-Disposition serialization ( #31669 )
...
* fix: incorrect Content-Disposition serialization
* test: fixup test
2021-11-03 10:11:37 -04:00
Sudowoodo Release Bot
31e877515c
Bump v17.0.0-nightly.20211103
2021-11-03 06:05:31 -07:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
Sudowoodo Release Bot
2a2a1a834c
Bump v17.0.0-nightly.20211102
2021-11-02 06:04:29 -07:00
Cheng Zhao
c4d35cd18c
fix: do not run dialog callback inside transaction commit ( #31606 )
2021-11-01 17:08:31 -04:00
electron-roller[bot]
1e618ef06c
chore: bump node to v16.13.0 (main) ( #31607 )
...
* chore: bump node in DEPS to v16.13.0
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-11-01 16:58:35 -04:00
John Kleinschmidt
c40a292099
test: fix test-datetime-change-notify after daylight change ( #31654 )
2021-11-01 16:31:12 -04:00
John Kleinschmidt
5899a72df9
fix: clipboard.read() to recognize custom types ( #31623 )
2021-11-01 10:00:36 -04:00
John Kleinschmidt
a938af3f54
fix: use disable-hid-blocklist to allow FIDO ( #31626 )
2021-11-01 10:00:07 -04:00
Sudowoodo Release Bot
97a109991e
Bump v17.0.0-nightly.20211101
2021-11-01 06:04:57 -07:00
Shelley Vohr
20b4813cf8
fix: crash on close window when webContents destroyed ( #31620 )
2021-11-01 13:32:54 +09:00
Sudowoodo Release Bot
a6e5ff3607
Bump v17.0.0-nightly.20211029
2021-10-29 06:02:06 -07:00
Shelley Vohr
639f4428a5
fix: navigator.keyboard.lock() not working ( #31572 )
...
* fix: navigator.keyboard.lock() not working
* chore: address review feedback
2021-10-28 10:23:05 -04:00
Sudowoodo Release Bot
120cff38c5
Bump v17.0.0-nightly.20211028
2021-10-28 06:01:45 -07:00
Erick Zhao
ec34c6c6e7
docs: update test automation doc ( #31506 )
...
* Update WebdriverIO documentation
* Update docs/tutorial/using-selenium-and-webdriver.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* Update docs/tutorial/using-selenium-and-webdriver.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* docs: update automated testing docs
* lint
* update
* Update docs/tutorial/automated-testing.md
Co-authored-by: Christian Bromann <github@christian-bromann.com >
* fixes
Co-authored-by: Christian Bromann <github@christian-bromann.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-10-28 11:17:43 +09:00
Robo
3bf42593ba
fix: use shorter paths for creating singleton sockets ( #31608 )
2021-10-27 12:25:08 -07:00
Sudowoodo Release Bot
e88a2955da
Bump v17.0.0-nightly.20211027
2021-10-27 06:05:09 -07:00
Keeley Hammond
0f0ed5921d
chore: fix supported versions automation ( #31602 )
2021-10-26 22:26:17 -07:00
Shelley Vohr
771a8f70da
docs: update development-related documentation ( #31043 )
...
* docs: update chromium development-related documentation
* chore: remove obsolete clang-format doc
clang-format linting and fixing is a pre-commit hook now
* docs: update debugging documentation
* docs: misc updates
* Update docs/development/debugging-on-windows.md
Co-authored-by: Micha Hanselmann <mh74182@gmail.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/README.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/debugging-on-macos.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/testing.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/development/testing.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Micha Hanselmann <mh74182@gmail.com >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-10-27 10:18:38 +09:00
Erick Zhao
3193d7e99b
docs: link to Apple developer docs for app.ready event ( #31583 )
...
Changes some links around. There was no link for `NSUserNotification`, and
`UNNotificationResponse` incorrectly linked to our own `NotificationResponse`
API structure doc.
2021-10-27 09:06:01 +09:00
Milan Burda
be8b1a2727
chore: update chore_add_context_to_context_aware_module_prevention.patch ( #31579 )
2021-10-26 15:50:29 -04:00
Sudowoodo Release Bot
43987bbc19
Bump v17.0.0-nightly.20211026
2021-10-26 06:02:41 -07:00
Shelley Vohr
deb7ab2a40
fix: clipboard.read() crash ( #31566 )
2021-10-26 14:14:08 +02:00
Shelley Vohr
78626a5cc6
chore: fix malformed mojom::CreateNewWindowParams patch ( #31573 )
...
* chore: fix malformed mojom::CreateNewWindowParams patch
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-10-25 20:04:39 -04:00
Mitchell McCaffrey
23cdf65c53
feat: add webContents.getMediaSourceId() method ( #31204 )
...
* feat: add webContents.getMediaSourceId() method
* fix: account for null frame_hosts in webContents.getMediaSourceId()
* fix: move webContents.getMediaSourceId definition to be more organised
* fix: move webContents.getMediaSourceId implementation
* fix: move webContents.getMediaSourceId docs
2021-10-25 20:03:59 -04:00
Samuel Attard
63eed52626
fix: do not trigger CSP violations when checking eval ( #30991 )
...
* fix: do not trigger CSP violations when checking eval
* Update shell/renderer/api/electron_api_web_frame.cc
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-10-25 14:11:24 -07:00
Samuel Attard
add94f5fe6
build: retry hasher function if it fails first time ( #30899 )
...
* build: retry hasher function if it fails first time
* Update script/release/get-url-hash.js
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-10-25 14:11:07 -07:00
Darshan Sen
8f51d3e1bf
feat: add webContents.getPrintersAsync() ( #31023 )
...
This deprecates the synchronous and blocking `webContents.getPrinters()`
function and introduces `webContents.getPrintersAsync()`, which is
asynchronous and non-blocking.
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2021-10-25 14:16:58 -04:00
electron-roller[bot]
b936f5e14a
chore: bump node to v16.12.0 (main) ( #31518 )
...
* chore: bump node in DEPS to v16.12.0
* chore: update patches
* esm: consolidate ESM Loader methods
https://github.com/nodejs/node/pull/37468
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-10-25 13:33:01 -04:00
Shelley Vohr
2a4b262354
fix: silent print settings ( #31489 )
...
* fix: silent print settings
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-10-25 11:52:52 -04:00
Shelley Vohr
5f3af5fdf1
docs: remove Nw.js comparison document ( #31053 )
2021-10-25 11:28:26 -04:00
Milan Burda
3332420886
docs: win.getParentWindow() returns BrowserWindow | null ( #31548 )
2021-10-25 11:10:33 -04:00
Sudowoodo Release Bot
084bcf56ff
Bump v17.0.0-nightly.20211025
2021-10-25 06:03:30 -07:00
Sudowoodo Release Bot
f020ec4748
Bump v17.0.0-nightly.20211022
2021-10-22 14:27:46 -07:00
Keeley Hammond
35d6c2fa98
chore: import base/macros.h into asar archive.h ( #31557 )
2021-10-22 14:26:55 -07:00
Sudowoodo Release Bot
690dbb7e62
Revert "Bump v17.0.0-nightly.20211022"
...
This reverts commit b8ea7bf90b .
2021-10-22 13:22:03 -07:00
Sudowoodo Release Bot
b8ea7bf90b
Bump v17.0.0-nightly.20211022
2021-10-22 06:01:55 -07:00
Shelley Vohr
1d0f94f6b3
fix: vibrant window should have transparent background ( #31493 )
2021-10-21 15:53:52 -04:00
Shelley Vohr
40a8e4fb58
fix: MediaMetadata not working properly ( #31492 )
2021-10-21 15:39:38 -04:00
electron-roller[bot]
87f7625c5d
chore: bump chromium to 96.0.4664.4 (main) ( #31317 )
...
* chore: bump chromium in DEPS to 96.0.4662.0
* chore: bump chromium in DEPS to 96.0.4663.0
* chore: update patches
* [Extensions] Remove RuntimeData entirely
https://chromium-review.googlesource.com/c/chromium/src/+/3177328
* Make helper macros behave consistently for //content/public UserData types
https://chromium-review.googlesource.com/c/chromium/src/+/3198788
* Enabling sandboxing for the speech recognition service browser tests
https://chromium-review.googlesource.com/c/chromium/src/+/3146090
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* [Reland][Extensions]: Add persistAcrossSessions flag (scripting API)
https://chromium-review.googlesource.com/c/chromium/src/+/3175161
* [Bluetooth] Add Passkey prompt dialog for bonding.
https://chromium-review.googlesource.com/c/chromium/src/+/2841104
* Clipboard: Remove ReadImage path in browser
https://chromium-review.googlesource.com/c/chromium/src/+/3194826
* Split printing metafile code into its own target.
https://chromium-review.googlesource.com/c/chromium/src/+/3164925
* Cleanup unused DesktopMediaListObserver params
https://chromium-review.googlesource.com/c/chromium/src/+/3179203
* Remove base::DictionaryValue::GetBinary
https://chromium-review.googlesource.com/c/chromium/src/+/3201974
* Window Placement: change RWHV::GetDisplayList to GetScreenInfos
https://chromium-review.googlesource.com/c/chromium/src/+/3138774
* Add a preview to the Tab Capture picker dialog
https://chromium-review.googlesource.com/c/chromium/src/+/3045268
* Add service-based usage to update print settings
https://chromium-review.googlesource.com/c/chromium/src/+/3155426
* chore: bump chromium in DEPS to 96.0.4664.2
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4664.4
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4666.0
* Revert "chore: bump chromium in DEPS to 97.0.4666.0"
This reverts commit d73caae8ba4b39efc9b3ea4de52685b9c92ef3d0.
* Reland "Block external protocol handler with sandbox."
https://chromium-review.googlesource.com/c/chromium/src/+/3198263
* fixup for lint
* Add CookiePartitionKeychain parameter to CookeManager.GetCookieList.
https://chromium-review.googlesource.com/c/chromium/src/+/3206016
* Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
https://chromium-review.googlesource.com/c/chromium/src/+/3200392
* fixup Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
* ozone: //chrome/browser clean up from USE_X11
https://chromium-review.googlesource.com/c/chromium/src/+/3186490
* content: don't load v8 snapshot in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/3183394
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* 3186491: Add 'devtools.sync_preferences' preference
https://chromium-review.googlesource.com/c/chromium/src/+/3186491
* 2951147: DCHECK accessible names for focusable Views
https://chromium-review.googlesource.com/c/chromium/src/+/2951147
* 3201014: Use real font size for calculation of SmallTextRatio
https://chromium-review.googlesource.com/c/chromium/src/+/3201014
* fixup Clipboard: Remove ReadImage path in browser
* chore: update patches
* fix: disable PlzServiceWorker to fix custom protocol SW script loading
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3199761
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-10-21 11:51:36 -07:00
Sudowoodo Release Bot
ed2aaed4bd
Bump v17.0.0-nightly.20211021
2021-10-21 06:02:28 -07:00
Sudowoodo Release Bot
6bd06c9a71
Bump v17.0.0-nightly.20211020
2021-10-20 06:04:11 -07:00
Keeley Hammond
14e2678b00
fix: don't use private enterprise APIs in MAS build ( #31482 )
2021-10-19 23:12:59 -07:00
Michaela Laurencin
a2d993c9b4
fix: remove 'NOTREACHED()' from 'GetWindowResizeEdge' ( #31470 )
2021-10-19 11:19:04 -05:00
Shelley Vohr
8364375347
fix: ensure TracingAgent in place for SWs ( #31459 )
2021-10-19 15:04:48 +02:00
Sudowoodo Release Bot
51b49d5bd8
Bump v17.0.0-nightly.20211019
2021-10-19 06:02:51 -07:00
Daniel Ramp
054a32785b
fix: link to image ( #31454 )
...
windows progress bar image was linked with square brackets [] insted of parenthesis () and to github asset storage instead of local image directory.
2021-10-19 17:43:10 +09:00
Erick Zhao
c3a8ad254a
docs: add window customization guide ( #31054 )
...
* docs: add window customization guide
* fixes
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/fiddles/windows/manage-windows/frameless-window/index.html
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* fix code fence
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2021-10-19 09:58:35 +09:00
t57ser
7eaebe0bd6
fix: add isDestroyed check ( #31208 )
...
* Added isDestroyed check
fix: https://github.com/electron/electron/issues/31196
* fix: unregister frame name
Unregister the frame name so that we do not accidentally unregister the wrong window later on in case there is a timing issue with the events
* fix; check if webContents is destroyed
* fix: check if window/webContents is destroyed
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2021-10-19 09:57:10 +09:00
universalstrapping
14736c5f30
Avoid Undefined Variable In printToPdf Example ( #31455 )
2021-10-19 09:53:59 +09:00
Sudowoodo Release Bot
6f31683ea5
Bump v17.0.0-nightly.20211018
2021-10-18 06:03:07 -07:00
Sudowoodo Release Bot
e9c6f274f3
Bump v17.0.0-nightly.20211015
2021-10-15 06:01:08 -07:00
Raymond Zhao
db0a152bc1
feat: Add data parameter to app.requestSingleInstanceLock() ( #30891 )
...
* WIP
* Use serialization
* Rebase windows impl of new app requestSingleInstanceLock parameter
* Fix test
* Implement posix side
* Add backwards compatibility test
* Apply PR feedback Windows
* Fix posix impl
* Switch mac impl back to vector
* Refactor Windows impl
* Use vectors, inline make_span
* Use blink converter
* fix: ownership across sequences
* Fix upstream merge from Chromium
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-10-14 21:32:32 -04:00
Milan Burda
5592652504
feat: warn when ipcRenderer.sendSync() called with no listeners for channel ( #31344 )
2021-10-14 14:24:04 -04:00
Samuel Maddock
b744707536
fix: mac window crash native theme update ( #31329 )
2021-10-14 13:36:32 -04:00
Keeley Hammond
bff20bd769
fix: reset render_frame_disposed_ after render frame host change ( #31401 )
...
* fix: reset render_frame_disposed_ after hang
* fix: handle exception in webContents.send
2021-10-14 09:44:44 -07:00
CezaryKulakowski
11db6a7d9a
fix: event with invalid timestamp in trace log ( #31349 )
...
When node is started within Electron's environment it doesn't
initialize v8 and time of v8's start is never set. As a result
we log v8's start time as 0 and it breaks timestamps in the
trace log. With this change we log v8's start time only when
it was initialized by node.
2021-10-14 10:08:34 -04:00
Cheng Zhao
d1e0b6324a
fix: generate valid config.gypi ( #31404 )
2021-10-14 10:07:36 -04:00
Sudowoodo Release Bot
e883beadff
Bump v17.0.0-nightly.20211014
2021-10-14 06:02:25 -07:00
electron-roller[bot]
6c5fbe3566
chore: bump node to v16.11.1 (main) ( #31369 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-10-14 09:43:48 +02:00
Sudowoodo Release Bot
bc3198ed81
Bump v17.0.0-nightly.20211013
2021-10-13 16:14:39 -07:00
Samuel Attard
e4d5ddc85e
Revert "Bump v17.0.0-nightly.20211013"
...
This reverts commit b99b4e7f22 .
2021-10-13 16:13:52 -07:00
Maxime Serrano
b2a2b077da
fix: also pass securityOrigin to media permissions request handler ( #31357 )
2021-10-13 17:10:12 -04:00
Cheng Zhao
a751845afc
test: fix flaky contentTracing.startRecording spec ( #31409 )
2021-10-13 10:06:29 -04:00
Sudowoodo Release Bot
b99b4e7f22
Bump v17.0.0-nightly.20211013
2021-10-13 06:03:15 -07:00
Shelley Vohr
757c01587a
test: re-enable failing Node.js specs ( #31315 )
2021-10-12 20:59:40 +02:00
Sudowoodo Release Bot
22ae945311
Bump v17.0.0-nightly.20211012
2021-10-12 06:03:06 -07:00
Erick Zhao
5301795de6
docs: update Versioning doc ( #31248 )
...
* fix information
* move historical section to bottom
* Update docs/tutorial/electron-versioning.md
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-10-12 09:12:33 +09:00
Micha Hanselmann
95f81f5980
fix: black window on screen capture when content protection is enabled ( #31340 )
...
Co-authored-by: Micha Hanselmann <mhanselmann@microsoft.com >
2021-10-11 13:29:43 -07:00
Sudowoodo Release Bot
371b521dd2
Bump v17.0.0-nightly.20211011
2021-10-11 06:03:43 -07:00
Shelley Vohr
0e56b85604
chore: remove BoringSSL patch redundancy ( #31323 )
...
* chore: emove BoringSSL patch redundancy
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-10-11 10:07:17 +09:00
Shelley Vohr
f45bd693f4
chore: update false to use analogous function in SetGroups ( #31325 )
2021-10-11 10:02:26 +09:00
Cheng Zhao
0eb9c4b16d
fix: correctly notify WebViewGuestDelegate when webview is detached ( #31350 )
2021-10-11 09:33:35 +09:00
Milan Burda
f8e6d45b70
docs: nativeWindowOpen default was changed in Electron 15 ( #31345 )
2021-10-08 14:55:28 -07:00
Sudowoodo Release Bot
1e666e5076
Bump v17.0.0-nightly.20211008
2021-10-08 06:04:18 -07:00
Milan Burda
31e295a676
chore: update E17 node module version ( #31282 )
2021-10-07 10:25:56 -07:00
Sudowoodo Release Bot
65d7f893ad
Bump v17.0.0-nightly.20211007
2021-10-07 06:05:09 -07:00
Shelley Vohr
9c8bd18c41
fix: crash on missing render frame ( #31289 )
2021-10-07 07:26:18 +02:00
Samuel Attard
014ebbd6fa
feat: add commandLine.removeSwitch ( #30933 )
...
* feat: add commandLine.removeSwitch
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
* fix: add missing removeSwitch to app.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-10-06 16:45:58 -04:00
John Kleinschmidt
d6de243837
chore: refactor persisting permission granted to serial ports ( #31181 )
2021-10-06 16:18:00 -04:00
Sudowoodo Release Bot
21c6b33ebe
Bump v17.0.0-nightly.20211006
2021-10-06 06:04:50 -07:00
Milan Burda
36ed216040
docs: add missing 'context-menu' event to webview-tag.md ( #31277 )
2021-10-05 20:42:09 -07:00
Milan Burda
9505c2831a
test: add missing context-menu event spec for <webview> ( #31280 )
2021-10-05 20:41:34 -07:00
electron-roller[bot]
cc01272a8d
chore: bump chromium to 96.0.4647.0 (main) ( #30814 )
...
* chore: bump chromium in DEPS to 95.0.4630.0
* 3133701: Fix chrome root store codegen for cross-compile builds.
https://chromium-review.googlesource.com/c/chromium/src/+/3133701
* 49125: Include SHA512-256 in EVP_get_digestbyname and EVP_MD_do_all.
https://boringssl-review.googlesource.com/c/boringssl/+/49125
* chore: fixup patch indices
* 3131662: [Code Health] Remove ListValue::Append(Integer|Boolean)
https://chromium-review.googlesource.com/c/chromium/src/+/3131662
* chore: bump chromium in DEPS to 95.0.4631.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4635.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4636.0
* chore: bump chromium in DEPS to 95.0.4637.0
* chore: update patches
* refactor: move PlatformNotificationService into BrowserContext
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3137256
* refactor: ListValue::GetSize and ListValue::AppendString were removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3144540
* chore: bump chromium in DEPS to 95.0.4638.0
* chore: bump chromium in DEPS to 95.0.4638.4
* chore: bump chromium in DEPS to 96.0.4640.0
* chore: bump chromium in DEPS to 96.0.4641.0
* chore: bump chromium in DEPS to 96.0.4642.0
* chore: update patches
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
* 3134756: Move extensions/browser/value_store to components/value_store.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3134756
* 3150092: [Autofill] Allow aligning Autofill suggestions to the field's center
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3150092
* chore: bump chromium in DEPS to 96.0.4643.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4644.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4645.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4646.0
* chore: bump chromium in DEPS to 96.0.4647.0
* chore: update patches
Ref (for chromium): https://chromium-review.googlesource.com/c/chromium/src/+/3165772
* 3162087: Reland "Ensure Branch Target Identification is enabled for executable pages."
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3162087
* chore: update evert_add_inline_and_inline_origin_records_to_symbol_file.patch
Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166678
Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166674
* chore: update Allocator construction
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3135195
Change RefCount::kAllowed/Disallowed semantics into BackupRefPtr::kEnabled/Disabled
* chore: add UseConfigurablePool to v8::ArrayBuffer::Allocator invocation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3090845
* chore: do not set network_context_params.context_name
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3155743
Remove name field from mojom::NetworkContext
* fix: use ForEachRenderFrameHost to iterate frames.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3163336
New implementation partially cribbed from
https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/script_executor.cc;drc=f894f106c6d5fac8e0b75158f622256e0f34f593;l=109
* [Blink Cleanup] Remove WebLocalFrame::RequestExecuteScriptAndReturnValue()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3149699
ExecuteJavaScript's RequestExecuteScript() new params are cribbed from
https://chromium-review.googlesource.com/c/chromium/src/+/3149699/4/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
* Remove IsDescendantOf API on RenderFrameHost.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3165357
function is trivial to implement, so make a local copy in anon namespace
* Rewrite IsDescendantOf check to check GetParentOrOuterDocument.
https://chromium-review.googlesource.com/c/chromium/src/+/3160061
* Remove GetFramesInSubtree from RenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/3163336
* fix: dump_syms for macOS
* chore: update patches
* [Code Health] Remove ListValue::AppendString and ListValue::GetSize
https://chromium-review.googlesource.com/c/chromium/src/+/3144540
* fix: gn check
https://chromium-review.googlesource.com/c/chromium/src/+/3163890
* fix: crash with Isolate::GetHeapCodeAndMetadataStatistics
https://chromium-review.googlesource.com/c/v8/v8/+/3175820
* chore: update patches
* chore: fix windows build
* Add kPrintWithPostScriptType42Fonts feature.
https://chromium-review.googlesource.com/c/chromium/src/+/3150776
* chore: update patches
* chore: fix tests
* ozone/x11: fix VA-API.
https://chromium-review.googlesource.com/c/chromium/src/+/3141878
* Revert "ozone/x11: fix VA-API."
This reverts commit 23e742acb1 .
* Reland "Make Ozone/X11 default."
https://chromium-review.googlesource.com/c/chromium/src/+/3114071
* fixup Reland "Make Ozone/X11 default."
* fixup Reland "Make Ozone/X11 default." for clipboard
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2021-10-05 19:21:00 -07:00
Cheng Zhao
959b657903
chore: remove Node.js patch on Module.globalPaths ( #31275 )
...
* chore: remove Node.js patch on Module.globalPaths
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-10-06 09:20:05 +09:00
Robo
2a92d8f962
refactor: only access memory coordinator interface from browser process ( #31295 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3174305
2021-10-05 15:30:31 -07:00
Samuel Attard
34599114ce
fix: return HTNOWHERE in resize hit test to allow draggable regions to kick in when required ( #30925 )
2021-10-05 12:48:22 -07:00
Sudowoodo Release Bot
7919851451
Bump v17.0.0-nightly.20211005
2021-10-05 06:05:15 -07:00
Shelley Vohr
d2508a6941
chore: add logging for print_backend failures ( #29884 )
2021-10-05 09:16:04 +02:00
Milan Burda
d7a7c120d1
fix: "Failed to serialize arguments" when emitting 'context-menu' for webview ( #31259 )
...
* fix: sanitize params for 'context-menu' event sent over IPC for webview
* Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview"
This reverts commit 7fee455138 .
* fix: make frame property non-enumerable in params for 'context-menu' event
2021-10-04 14:00:25 -04:00
Sudowoodo Release Bot
3b2c46dfd6
Bump v17.0.0-nightly.20211004
2021-10-04 06:03:59 -07:00
Jeremy Rose
4fd7c2adcd
feat: make desktopCapturer main-process-only ( #30720 )
...
* feat: make desktopCapturer main-process-only
* remove --enable-api-filtering-logging
* remove test
* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts
* remove desktop-capturer-get-sources event
* fix specs
* getSources needs to be async
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-10-04 12:16:00 +09:00
Ryan Johnson
6db8d7918d
fix: dialog is not defined ( #31180 )
...
Corrects the following error in Electron Fiddle:
```
Uncaught Exception:
ReferenceError: dialog is not defined
...
```
2021-10-04 10:12:55 +09:00
Tobias Nießen
e53bd1b72a
fix: fix typo in description of secureDnsMode ( #31255 )
2021-10-04 09:57:19 +09:00
Sudowoodo Release Bot
d2425472df
Bump v17.0.0-nightly.20211001
2021-10-01 06:03:54 -07:00
Juan Cruz Viotti
0e042ca64d
fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL ( #31213 )
...
Fixes: https://github.com/electron/electron/issues/31212
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2021-09-30 13:22:14 -07:00
Sudowoodo Release Bot
6f684d564f
Bump v17.0.0-nightly.20210930
2021-09-30 06:02:17 -07:00
Shelley Vohr
e07d74cf29
chore: remove redundant 10.11 @avilable checks ( #31184 )
2021-09-30 11:41:28 +02:00
Shelley Vohr
2c10d0fe1b
fix: draggable regions in BrowserViews are independent ( #31085 )
2021-09-30 11:41:08 +02:00
Juan Cruz Viotti
1193a37d8f
build: Explicitly pass the project root to cpplint.py ( #31156 )
...
In order to validate that header guards match the corresponding file
names, `cpplint.py` determines the root of the project based on the
presence of a `.git` directory.
For space reasons, our Electron.js fork running on CircleCI deletes the
`.git` directories as upstream Electron.js does here:
cd09a54365/.circleci/config.yml (L426)
If the C++ linter is ran *after* deleting git directories, `cpplint.py`
gets the root wrong and throws errors for every single header guard in
the project.
Making sure we run the C++ linter *before* deleting git directories
fixes the issue. In any case, this commit always manually passes
`--project_root` to `cpplint.py` so that the implicit default is
explicitly declared and saves some confusion for the next person hitting
this.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2021-09-29 17:44:41 -04:00
Alexey Kuzmin
2d111a4e25
chore: fix pylint ( #31138 )
...
* chore: fix pylint
* chore: fix linter errors
2021-09-29 13:10:13 -04:00
Sudowoodo Release Bot
22d683e3f8
Bump v17.0.0-nightly.20210929
2021-09-29 06:01:29 -07:00
Aidan Nulman
abf6f1cf78
fix: BrowserView drag now delegates to the OS when possible ( #31114 )
2021-09-28 21:12:22 +02:00
Sudowoodo Release Bot
4da66b9d68
Bump v17.0.0-nightly.20210928
2021-09-28 06:03:27 -07:00
electron-roller[bot]
02d3e66bcb
chore: bump node to v16.10.0 (main) ( #31094 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-09-28 09:29:44 +02:00
Sudowoodo Release Bot
3b155f7391
Bump v17.0.0-nightly.20210927
2021-09-27 13:52:10 -07:00
Milan Burda
80577a4f08
refactor: use native WeakRef instead of v8util.weaklyTrackValue() ( #31153 )
2021-09-27 16:50:42 -04:00
Black-Hole
a5f1fbdc54
fix: .lldbinit config stale (unavailable) ( #31108 )
2021-09-27 14:50:36 -04:00
Sudowoodo Release Bot
ecf191e71f
Revert "Bump v17.0.0-nightly.20210927"
...
This reverts commit 104e0f3059 .
2021-09-27 10:18:22 -07:00
Sudowoodo Release Bot
104e0f3059
Bump v17.0.0-nightly.20210927
2021-09-27 09:35:35 -07:00
Sudowoodo Release Bot
10d92e9f29
Revert "Bump v17.0.0-nightly.20210927"
...
This reverts commit a758a2eab3 .
2021-09-27 09:34:24 -07:00
Sudowoodo Release Bot
a758a2eab3
Bump v17.0.0-nightly.20210927
2021-09-27 09:07:06 -07:00
John Kleinschmidt
0f6560f1f7
Revert "Bump v17.0.0-nightly.20210927"
...
This reverts commit c377fe4ba6 .
2021-09-27 12:05:51 -04:00
Daryl Haresign
265474882c
docs: Update Branch Name ( #31106 )
...
* docs: Update CI Badge Branch Name
The CI badges were still pointing at builds for the master branch, which
are stale since the rename to main.
* docs: Update electron/electron Branch Name
Update electron/electron branch name from master to main.
* docs: Update electron/governance Branch Name
Update electron/governance branch name from master to main.
2021-09-27 11:35:56 -04:00
Robo
68c738a177
fix: crash in v8 due to regexp reentrancy ( #31102 )
2021-09-27 16:58:16 +02:00
Milan Burda
98ac0ca52a
fix: running tests with release build ( #31092 )
2021-09-27 16:58:03 +02:00
Sudowoodo Release Bot
c377fe4ba6
Bump v17.0.0-nightly.20210927
2021-09-27 06:04:08 -07:00
Shelley Vohr
25d0963d9b
fix: crash creating private key with unsupported algorithm ( #31087 )
...
* fix: crash creating private key with unsupported algorithm
* test: add regression test
2021-09-27 15:02:13 +02:00
Cheng Zhao
2360012cad
fix: avoid double free when destroying WebContents ( #31104 )
2021-09-27 09:20:55 +02:00
Sudowoodo Release Bot
1a6a8f55af
Bump v17.0.0-nightly.20210924
2021-09-24 06:01:55 -07:00
Shelley Vohr
53bf308497
chore: remove obsolete chunk of BoringSSL patch ( #31086 )
...
Made obsolete in https://boringssl-review.googlesource.com/c/boringssl/+/40484
and can now be removed.
2021-09-24 11:36:56 +02:00
Shelley Vohr
5e1fbc9025
test: re-enable some Node.js specs ( #31077 )
2021-09-24 09:54:20 +02:00
Keeley Hammond
d88e71f688
chore: remove gin::Wrappable crash keys ( #31075 )
...
* chore: remove gin wrappable crash keys
* chore: remove class headers from crash keys
2021-09-23 21:38:40 -07:00
Shelley Vohr
919fd0f28d
fix: first mouse not dragging BrowserView ( #31062 )
2021-09-23 17:35:12 -04:00
Sudowoodo Release Bot
da921e680f
Bump v17.0.0-nightly.20210923
2021-09-23 06:02:26 -07:00
John Kleinschmidt
6aece4a83d
feat: add support for WebHID ( #30213 )
...
* feat: add support for WebHID
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Address review feedback
* Address review feedback
* chore: clear granted_devices on navigation
Also added test to verify devices get cleared
* fixup testing for device clear
* make sure navigator.hid.getDevices is run on correct frame
* clear granted devices on RenderFrameHost deletion/change
* manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
* Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* apply review feedback from @zcbenz
* Match upstream ObjectMap
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0
The main reason for this was to resolve this crash on Win x64:
ok 2 WebContentsView doesn't crash when GCed during allocation
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387)
node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415)
node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479)
uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609)
electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631)
base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266)
base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221)
base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470)
base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990)
content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153)
content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49)
content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104)
content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971)
content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394)
content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422)
wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291)
__scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FFEC0087034+20]
RtlUserThreadStart [0x00007FFEC1F02651+33]
✗ Electron tests failed with code 0xc0000005.
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-09-23 20:00:11 +09:00
Milan Burda
77579614e0
feat: add width option to dialog.showMessageBox() ( #30474 )
2021-09-23 19:56:14 +09:00
Black-Hole
e39a1d2ea0
fix: startDrag params type incorrect ( #31034 )
2021-09-23 17:07:39 +09:00
CezaryKulakowski
68d3659f75
fix: update Windows' cache after changing window's style ( #31021 )
...
To enable/disable window resizing we set/unset WS_THICKFRAME style
flag on the window. Window's frame styles are cached so we need to
call SetWindowPos with the SWP_FRAMECHANGED flag set to update
cache properly.
2021-09-23 16:33:41 +09:00
Keeley Hammond
bb6dc99d9d
chore: clarify new-window fix comment ( #31069 )
2021-09-22 15:30:55 -07:00
Shelley Vohr
38b810b2e3
fix: proper localization when using GtkFileChooserNative ( #30888 )
...
* fix: proper localization when using GtkFileChooserNative
* fix: iwyu
2021-09-22 14:12:50 -04:00
Sudowoodo Release Bot
a75617bff1
Bump v16.0.0-nightly.20210922
2021-09-22 06:01:20 -07:00
dependabot[bot]
3ef74abfe4
build(deps): bump tar from 4.4.15 to 4.4.19 ( #30776 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v4.4.15...v4.4.19 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-22 08:54:39 +09:00
Samuel Maddock
70c534fd14
feat: add frame to context-menu event params ( #30831 )
...
* feat: add frame to context-menu event params
* doc: rephrase frame description
2021-09-22 08:52:49 +09:00
Erick Zhao
52bacd38a9
docs: update glossary ( #30874 )
...
* docs: update glossary
* remove nsis entry
2021-09-22 08:52:24 +09:00
Sofia Nguy
dbd18d8562
docs: update public timeline for E16 ( #31000 )
2021-09-21 11:31:41 -07:00
Keeley Hammond
4fcc0884f8
fix: propagate window.open settings to child window ( #31031 )
2021-09-21 09:06:20 -07:00
Sudowoodo Release Bot
ee19e5ee48
Bump v16.0.0-nightly.20210921
2021-09-21 06:00:36 -07:00
Shelley Vohr
629d8913f6
fix: maximized state calculation for non-resizable windows ( #30989 )
2021-09-21 12:04:32 +02:00
Milan Burda
92bff00d43
feat: add isMainFrame argument to 'certificate-error' event ( #30879 )
2021-09-21 15:49:15 +09:00
Jeremy Rose
e38a0a67c6
fix: suppress insecure resource warning for more local hostnames ( #30885 )
...
* fix: suppress insecure resource warning for more local hostnames
* fix tests
2021-09-21 15:47:54 +09:00
Jeremy Rose
82da4b0090
fix: transparency on child windows being lost ( #31003 )
...
* fix: transparency on child windows being lost
* fix crash
* fix a different crash
* fix more crash
2021-09-21 09:20:54 +09:00
Milan Burda
6dd33b75b2
chore: add wg-security as required reviewer for security-warnings.ts ( #30987 )
2021-09-21 08:52:44 +09:00
Sudowoodo Release Bot
a96f42ce86
Bump v16.0.0-nightly.20210920
2021-09-20 06:01:27 -07:00
Darshan Sen
efa70131e2
refactor: make InitWithWebContents and InspectableWebContents take a unique_ptr ( #30920 )
...
* refactor: make InitWithWebContents take a unique_ptr
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
* refactor: make InspectableWebContents take a unique_ptr
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2021-09-20 09:34:11 +09:00
Shelley Vohr
6fdf350bea
fix: disabling and enabling resizability on macOS ( #30999 )
2021-09-17 15:54:15 +02:00
Sudowoodo Release Bot
8d8fcd88f5
Bump v16.0.0-nightly.20210917
2021-09-17 06:01:05 -07:00
祈緒ちゃん - Kiochan
ad98f4707f
chore: update links of documentation of chromes ( #30959 )
...
chrome now use developer.chrome.com/docs/extensions/* instead of developer.chrome.com/extensions/*
2021-09-17 10:53:28 +09:00
Antón Molleda
4576d9d23e
fix: links to images ( #30990 )
...
Images that used the inline link format do not show up on Docusaurus or
the old website infrastructure. There are only 2 guides using it so it
is faster to change the format rather than figuring out why the parsin
logic does not work.
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Ref: https://github.com/electron/electronjs.org-new/issues/84
2021-09-16 18:42:58 -04:00
Sudowoodo Release Bot
64c70c420f
Bump v16.0.0-nightly.20210916
2021-09-16 06:00:56 -07:00
Michaela Laurencin
b491a4c82f
fix: add casing for WCO edge ( #30938 )
2021-09-16 09:34:51 +09:00
Keeley Hammond
c5b517d89f
chore: update E16 node module version ( #30774 )
...
Ref: https://github.com/nodejs/node/pull/39950/files
2021-09-15 16:11:10 -07:00
Tierney Cyren
9c4e3b67fb
docs: add link to @electron/fuses ( #30978 )
2021-09-15 12:14:33 -07:00
electron-roller[bot]
93068cfab5
chore: bump node to v16.9.1 (main) ( #30919 )
...
* chore: bump node in DEPS to v16.9.1
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-09-15 10:25:26 -04:00
Shelley Vohr
c8e4cc29c0
fix: prevent navigator.fonts.query() from crashing ( #30930 )
...
* fix: prevent navigator.fonts.query() from crashing
* refactor: use base::PostTask instead
2021-09-15 09:56:38 -04:00
Sudowoodo Release Bot
9eaa9de3b4
Bump v16.0.0-nightly.20210915
2021-09-15 06:01:48 -07:00
Erick Zhao
664a452fb6
docs: update context isolation doc ( #30898 )
...
* docs: update context isolation doc
* Apply suggestions from code review
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2021-09-15 10:50:02 +09:00
Erick Zhao
54b44584fa
chore: correct hierarchy of BrowserWindow headings ( #30905 )
...
* chore: correct hierarchy of BrowserWindow headings
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2021-09-15 09:41:37 +09:00
Raymond Zhao
1295ba0ffc
fix: Building on macOS with is_debug true ( #30913 )
...
* fix: Building on macOS with is_debug true
* Change to no-op impl
2021-09-15 09:40:36 +09:00
Micha Hanselmann
02ac33c4cd
fix: always include pepper flash font file ( #30928 )
2021-09-15 09:39:01 +09:00
Sudowoodo Release Bot
87050d75b8
Bump v16.0.0-nightly.20210914
2021-09-14 06:01:52 -07:00
Shelley Vohr
00d0265782
refactor: reuse upstream //shell_dialogs ( #30663 )
2021-09-14 12:16:34 +02:00
Keeley Hammond
c74b9ff312
fix: remove conflicting RunFileChooserEnd for Mac ( #30935 )
2021-09-13 15:10:28 -07:00
Keeley Hammond
b6a12a53e3
fix: delete rfh after open/save dialog done ( #30916 )
2021-09-13 06:25:13 -07:00
Sudowoodo Release Bot
06b3b49214
Bump v16.0.0-nightly.20210913
2021-09-13 06:02:34 -07:00
Sudowoodo Release Bot
c556ccac08
Bump v16.0.0-nightly.20210910
2021-09-10 06:02:10 -07:00
Samuel Attard
fb539f15d0
chore: fix compile errors ( #30903 )
2021-09-09 19:52:23 -07:00
Samuel Attard
57d088517c
feat: add support for validating asar archives on macOS ( #30667 )
...
* feat: add support for validating asar archives on macOS
* chore: fix lint
* chore: update as per feedback
* feat: switch implementation to asar integrity hash checks
* feat: make ranged requests work with the asar file validator DataSourceFilter
* chore: fix lint
* chore: fix missing log include on non-darwin
* fix: do not pull block size out of missing optional
* fix: match ValidateOrDie symbol on non-darwin
* chore: fix up asar specs by repacking archives
* fix: maintain integrity chain, do not load file integrity if header integrity was not loaded
* debug test
* Update node-spec.ts
* fix: initialize header_validated_
* chore: update PR per feedback
* chore: update per feedback
* build: use final asar module
* Update fuses.json5
2021-09-09 14:49:01 -07:00
Sudowoodo Release Bot
fcad531f2e
Bump v16.0.0-nightly.20210909
2021-09-09 06:01:36 -07:00
electron-roller[bot]
eb955af459
chore: bump node to v16.9.0 (main) ( #30867 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-09-08 18:55:06 +02:00
Sudowoodo Release Bot
9dee1183f9
Bump v16.0.0-nightly.20210908
2021-09-08 06:02:30 -07:00
Shelley Vohr
9891ff14a7
refactor: remove dead code in NeedsCompleteGpuInfoCollection ( #30855 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/1208362
2021-09-08 08:42:03 +09:00
Mark Lee
22abbf76fb
docs(protocols): simplify packaging section & cleanup ( #30832 )
...
* docs(protocols): simplify packaging section & cleanup
* docs(protocol): add basic instructions for Linux support
* Fix typo
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2021-09-08 08:24:45 +09:00
Darshan Sen
90a3e7f927
feat: warn when crash key name is longer than 39 bytes ( #30742 )
...
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2021-09-07 11:09:48 -07:00
Jeremy Rose
55c57808fb
feat: serialize NativeImage over ipc ( #30729 )
2021-09-07 10:37:45 -07:00
Christian Engel
ee33374675
Fix wrong code example for preload property ( #30555 )
...
The text mentions that `preload` should be a property of `webPreferences`, but the code example shows something else.
2021-09-07 17:04:08 +02:00
Finn Behrens
6a1726576d
docs: Update windows info for auto-updater ( #30538 )
...
Squirrel.Mac can be served from a static host as well.
2021-09-07 17:03:56 +02:00
Sudowoodo Release Bot
64e33002f8
Bump v16.0.0-nightly.20210907
2021-09-07 06:02:06 -07:00
Samuel Maddock
fb40065c1e
fix: show maximized frameless window ( #30804 )
2021-09-07 10:18:43 +02:00
Sudowoodo Release Bot
ce6a71e936
Bump v16.0.0-nightly.20210906
2021-09-06 19:02:56 -07:00
Sudowoodo Release Bot
57e3c25378
Revert "Bump v16.0.0-nightly.20210906"
...
This reverts commit f39ba9281c .
2021-09-06 18:48:49 -07:00
Samuel Maddock
1546cb6e6c
refactor: use getter for frame in webrequest details ( #30830 )
2021-09-07 09:13:16 +09:00
Sudowoodo Release Bot
f39ba9281c
Bump v16.0.0-nightly.20210906
2021-09-06 06:02:05 -07:00
Milan Burda
8b7631228f
chore: move native-image.ts back into common ( #30838 )
2021-09-06 11:06:27 +02:00
Isaac Taylor
4a2f41ee58
docs: updated webview tag documentation to accurately reflect preload behavior with asar archives ( #30768 )
2021-09-06 17:00:17 +09:00
Samuel Maddock
7379e5eb36
fix: BrowserWindow backgroundColor ( #30778 )
...
* fix: BrowserWindow backgroundColor
* refactor: propagate transparency via backgroundColor
2021-09-06 16:59:09 +09:00
Shelley Vohr
26f981fa3e
fix: devtools not resizable on Windows ( #30823 )
2021-09-06 16:54:47 +09:00
Robo
99c0a723fd
chore: follow-up to roll 95.0.4612.5 ( #30835 )
...
* chore: enable v8 oilpan
* chore: update patches
* fix: network isolation key for preconnect requests
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
2021-09-06 09:33:10 +02:00
Milan Burda
94ca57e296
chore: move global_menu_bar_registrar_x11 out of chromium_src ( #30837 )
2021-09-06 09:03:07 +02:00
Jeremy Rose
1dcb8a370e
refactor: simplify desktop_capturer patch ( #30685 )
2021-09-03 16:37:36 -07:00
Raymond Zhao
e6f781f403
refactor: Convert ProcessSingleton changes to patch ( #30594 )
...
* Convert ProcessSingleton changes to patch
* Update patch
* Polish
* Add sandbox check to patch
* Add missing includes
* Fix linking error
* Fix compile error
* Apply PR feedback
* Fix compile fails
* Fix tests
* Remove extra patch
* Update test
2021-09-03 14:16:33 -07:00
Erick Zhao
b8372f20a0
docs: move module creation guide to /development ( #30826 )
2021-09-03 13:46:53 -07:00
Sudowoodo Release Bot
92222c874f
Bump v16.0.0-nightly.20210903
2021-09-03 06:02:32 -07:00
Sudowoodo Release Bot
c30303207a
Bump v16.0.0-nightly.20210902
2021-09-02 16:35:36 -07:00
Samuel Attard
873872a32b
build: temporarily revert broken dump_syms changes in breakpad ( #30825 )
2021-09-02 16:34:31 -07:00
Sudowoodo Release Bot
5554de0237
Revert "Bump v16.0.0-nightly.20210902"
...
This reverts commit 6d4995ec17 .
2021-09-02 14:40:45 -07:00
Jeremy Rose
ee0e15a52e
feat: deprecate desktopCapturer.getSources in the renderer ( #30721 )
2021-09-02 11:31:47 -07:00
Sudowoodo Release Bot
6d4995ec17
Bump v16.0.0-nightly.20210902
2021-09-02 06:01:22 -07:00
Jeremy Rose
8d86d84ff5
ci: fix setCertificateVerifyProc tests ( #30799 )
2021-09-01 18:58:29 -04:00
Black-Hole
fd8eb3de1b
fix: remove extension warning that do not have any impact ( #29695 )
2021-09-01 15:36:21 -07:00
Samuel Maddock
4d89174b41
feat: add 'dom-ready' event to WebFrameMain ( #29290 )
2021-09-01 15:21:15 -07:00
electron-roller[bot]
49e62f1261
chore: bump chromium to 95.0.4629.0 (main) ( #30676 )
...
* chore: bump chromium in DEPS to 95.0.4620.0
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* [GURL -> SiteForCookies] content/public/browser/content_browser_client.h
https://chromium-review.googlesource.com/c/chromium/src/+/3107759
* chore: fix -Wunreachable-code-return in node
* Tracing to diagnose ContentScriptTracker-related bad message reports
https://chromium-review.googlesource.com/c/chromium/src/+/3057922
* chore: bump chromium in DEPS to 95.0.4621.0
* chore: update patches
* Remove title from the URL format on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/3108445
* chore: bump chromium in DEPS to 95.0.4623.0
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
(cherry picked from commit ba5cde4da2 )
* Change file paths in network context params to be relative.
https://chromium-review.googlesource.com/c/chromium/src/+/3092927
* Code Health: Rename/replace content::WebUI::RegisterMessageCallback().
https://chromium-review.googlesource.com/c/chromium/src/+/3104691
* Migrate CanExecuteContentScriptSync to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/3108452
* chore: update patches
* remove unreachable code
* Revert "Revert "chore: disable v8 oilpan""
This reverts commit fef495c0294e21760df51bddb5f7bf1ec9ed5f1e.
* fixup mas patch
* Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4624.0
* chore: bump chromium in DEPS to 95.0.4625.0
* chore: bump chromium in DEPS to 95.0.4626.0
* 3033504: Pass NavigationDownloadPolicy in CreateNewWindowParams
https://chromium-review.googlesource.com/c/chromium/src/+/3033504
* 3058038: Introduce TestPrintingContext & test UpdatePrintSettings
https://chromium-review.googlesource.com/c/chromium/src/+/3058038
* 3114943: [Conditional Focus][#4 ] Add tests and remove flag gating
https://chromium-review.googlesource.com/c/chromium/src/+/3114943
* chore: update patch indices
* chore: bump chromium in DEPS to 95.0.4627.0
* chore: update patches
* 3093591: ozone: webpagepopups: calculate anchor for menu bounds. 4/*
https://chromium-review.googlesource.com/c/chromium/src/+/3093591
* 3110414: [PA] Remove the leading cookie
https://chromium-review.googlesource.com/c/chromium/src/+/3110414
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* 3113629: Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4628.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4629.0
* chore: update patches
* Fix chrome root store codegen for cross-compile builds.
https://chromium-review.googlesource.com/c/chromium/src/+/3133701
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-09-01 15:55:07 -04:00
John Kleinschmidt
e6802bf935
ci: ignore pdb download failure ( #30785 )
2021-09-01 10:26:12 -04:00
Sudowoodo Release Bot
ad776d6113
Bump v16.0.0-nightly.20210901
2021-09-01 06:01:17 -07:00
jiang kun
f533c44912
docs: fix code example in process-model.md ( #30690 )
...
* Update process-model.md
the demo have two error:
- at macos, close all window, the app will not quite, unless press cmd + q
- attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument
* Update docs/tutorial/process-model.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-09-01 20:46:32 +09:00
Shelley Vohr
63b35403ef
fix(linux): OpenURI portal support for shell.showItemInFolder() ( #30716 )
2021-09-01 10:04:28 +09:00
ComplexSpaces
399032252f
docs: improve documentation about macOS entitlement usage security ( #30740 )
2021-09-01 10:02:42 +09:00
Jeremy Rose
dd7aeda6fb
feat: add app.configureHostResolver ( #30576 )
2021-08-31 11:55:30 -07:00
Keeley Hammond
3b2db5f168
docs: add remote removal to E14 breaking changes ( #30769 )
2021-08-31 11:14:46 -07:00
electron-roller[bot]
c1075debf3
chore: bump node to v16.8.0 (main) ( #30714 )
...
* chore: bump node in DEPS to v16.8.0
* build: add option to hide console window
https://github.com/nodejs/node/pull/39712
* chore: fixup patch indices
* stream: duplexify
https://github.com/nodejs/node/pull/39519
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-08-31 10:36:04 -04:00
Sudowoodo Release Bot
88ff3a6a9a
Bump v16.0.0-nightly.20210831
2021-08-31 06:00:47 -07:00
Samuel Attard
8007d01874
feat: add support for the U2F Web API ( #30438 )
...
* feat: add support for the U2F Web API
* chore: fix lint
* chore: fix tests
* build: disable src caching
* Revert "build: disable src caching"
This reverts commit c4c8a60fc435a10788475ec171399a55ac2dd674.
* chore: update per feedback
* chore: consistent code removal
2021-08-30 11:22:46 -07:00
Sudowoodo Release Bot
c2da4ec2bc
Bump v16.0.0-nightly.20210830
2021-08-30 06:01:39 -07:00
Jeremy Rose
aa9da78edb
fix: remove ipc wrapper for nativeImage.createThumbnailFromPath ( #30728 )
2021-08-27 14:21:36 -07:00
Samuel Maddock
352ac21413
feat: add webContents.fromDevToolsTargetId() ( #29399 )
...
* feat: add webContents.fromDevToolsTargetId()
* refactor: avoid using FromOrCreate
2021-08-27 14:01:24 -07:00
Sudowoodo Release Bot
96131af5d3
Bump v16.0.0-nightly.20210827
2021-08-27 06:01:16 -07:00
Sudowoodo Release Bot
f9c6f9af83
Bump v16.0.0-nightly.20210826
2021-08-26 06:01:35 -07:00
Cheng Zhao
00d65eb9ac
fix: titlebar and buttons state under simple fullscreen ( #30671 )
2021-08-26 08:29:34 +09:00
Jeremy Rose
a9983c1d06
docs: feature_request additional information not required ( #30684 )
2021-08-25 10:11:52 -07:00
Sudowoodo Release Bot
c2c1b22a31
Bump v16.0.0-nightly.20210825
2021-08-25 06:03:14 -07:00
Milan Burda
501ac15b1d
feat: add <webview>.sendToFrame() / frameId to 'ipc-message' event ( #30451 )
2021-08-25 09:46:46 +02:00
Samuel Attard
be43996d35
docs: explain the null webContents case in permission checks ( #30645 )
...
* docs: explain the null webContents case in permission checks
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-08-25 09:41:56 +09:00
Shelley Vohr
32194f0f71
fix: crash when using TouchBarScrubber arrow button ( #30661 )
2021-08-24 18:28:57 +02:00
Sudowoodo Release Bot
e43a25724c
Bump v16.0.0-nightly.20210824
2021-08-24 06:01:17 -07:00
electron-roller[bot]
5513e66982
chore: bump chromium to 95.0.4612.5 (main) ( #30503 )
...
* chore: bump chromium in DEPS to 94.0.4604.0
* build: 3-way merge of chromium patches
* chore: bump chromium in DEPS to 94.0.4605.0
* build: 3-way merge of chromium patches
* 3076040: Reland Remove delete_children RemoveAllChildViews arg
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040
* 3069287: Remove the remaining uses and delete the deprecated API
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287
* 2297212: Replace RemoveWithoutPathExpansion(.*, nullptr) with Value::RemoveKey()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
* 3082756: Change transport_security_persister_path param to be a path to a file.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3082756
> this CL intentionally changes the name of the parameter
> in the network context parameters and the order of the constructor
> parameters to ensure all callers update their code to pass a full
> file path rather than a path to a directory.
The 'path' in this diff is already an absolute path, coming from
`CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &path_));` at
08ff1c2cbf/shell/browser/electron_browser_context.cc (L126)
* iwyu: network::mojom::HttpRawHeaderPair
* fixup! 3076040: Reland Remove delete_children RemoveAllChildViews arg
Missed one.
* 2999884: CodeHealth: Remove DictionaryValue::GetStringWithoutPathExpansion
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2999884
(example of replacing GetStringWithoutPathExpansion() w/FindStringKey())
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
(removal of DictionaryValue::GetStringWithoutPathExpansion)
* 3059260: Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3059260
We had both of these in a 'disable_features' list. Since these feature have
been removed upstream, remove them from our disable list, too.
IMPORTANT: this commit should not be backported to older branches that
still have these features, because doing so would un-disable them.
* 2920890: Load reroute_info from download in-progress and history db back into DownloadItem.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2920890
* 3039323: [Clipboard API] Clipboard Custom Formats implementation Part 5.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* chore: bump chromium in DEPS to 94.0.4606.0
* 3084502: Add a new PrintRasterizePdfDpi policy.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 94.0.4606.3
* chore: bump chromium in DEPS to 95.0.4608.0
* chore: bump chromium in DEPS to 95.0.4609.0
* [DevTools] Remove report_raw_headers from network::ResourceRequest
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* Remove content::WebContentsObserver::OnInterfaceRequestFromFrame
https://chromium-review.googlesource.com/c/chromium/src/+/3092665
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* Add a new PrintRasterizePdfDpi policy.
https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4609.3
* disable `use_lld` for macos
* chore: update patches
* Linux: use chrome_crashpad_handler instead of crashpad_handler
https://chromium-review.googlesource.com/c/chromium/src/+/3054290
* chore: fix lint
* Revert "[DevTools] Remove report_raw_headers from network::ResourceRequest"
This reverts commit 28f4da1582d046e96cb58f3cbb590503e89dfd0d.
* [DevTools] Remove report_raw_headers from network::ResourceRequest (Attempt #2 )
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* DCHECK that predictor always has a non-empty NetworkIsolationKey.
https://chromium-review.googlesource.com/c/chromium/src/+/3067698
* Remove --no-untrusted-code-mitigations from //content and //gin
https://chromium-review.googlesource.com/c/chromium/src/+/3096585
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
https://chromium-review.googlesource.com/c/chromium/src/+/3059260
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Convert PrintManager to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3072019
* chore: bump chromium in DEPS to 95.0.4612.5
* chore: disable v8 oilpan
* [Compiler] Remove untrusted code mitigations.
https://chromium-review.googlesource.com/c/v8/v8/+/3045704
* Remove most FTP logic from services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/3076119
* Rename scale_factor.h -> resource_scale_factor.h
https://chromium-review.googlesource.com/c/chromium/src/+/3057113
* [GURL -> SiteForCookies] extensions/
https://chromium-review.googlesource.com/c/chromium/src/+/3100825
* breadcrumbs: add desktop entry point
https://chromium-review.googlesource.com/c/chromium/src/+/3021746
* Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* chore: iwyu
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* fixup! [Compiler] Remove untrusted code mitigations.
* fixup! Disable kDesktopCaptureMacV2
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
* Reland "chore: disable v8 oilpan"
This reverts commit 1c252765b07a205560e7b5eed06de2605336e2d8.
The previous revert was to test on which platforms did the
heapsnapshot test actually fail.
* [Clipboard API] Clipboard Custom Formats implementation Part 5.
https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* Convert ExtensionFrameHost to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3063358
* Convert PDFWebContentsHelper to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3049751
* [Underscore Migration] Migrate ui/legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093160
* chore: remove unknown permission error
* chore: fix lint
* chore: ignore -Wunreachable-code-return for node deps/
* fixup! chore: ignore -Wunreachable-code-return for node deps/
* fix: windows build
* fix: build dependency
Dependency was missed in cbeae20438
* 3108669: arm,dsp: Fix 8bpp Dct64_NEON().
https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669
* chore: revert libgav1 roll
* Revert "3108669: arm,dsp: Fix 8bpp Dct64_NEON()."
This reverts commit 7ed3132312 .
* Revert "chore: revert libgav1 roll"
This reverts commit 084a490d29 .
* chore: revert clang roll
* chore: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: mlaurencin <mlaurencin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-08-23 20:52:17 -04:00
Jeremy Rose
10c4931477
docs: remove link to outdated examples from README ( #30648 )
2021-08-23 09:19:16 -07:00
Milan Burda
aad1c0d493
feat: add <webview> 'did-redirect-navigation' event ( #30457 )
2021-08-23 10:26:00 -04:00
Sudowoodo Release Bot
34f1bc0e82
Bump v16.0.0-nightly.20210823
2021-08-23 06:01:59 -07:00
electron-roller[bot]
fb990ba1eb
chore: bump node to v16.7.0 (main) ( #30350 )
...
* chore: bump node in DEPS to v16.6.0
* chore: bump node in DEPS to v16.6.1
* crypto: fix generateKeyPair with encoding 'jwk'
https://github.com/nodejs/node/pull/39319
* build: add library_files to gyp variables
https://github.com/nodejs/node/pull/39293
* debugger: rename internal module
https://github.com/nodejs/node/pull/39378
* chore: fixup patch indices
* deps: extract gtest source files to deps/googletest
https://github.com/nodejs/node/pull/39386
* crypto: fix generateKeyPair with encoding 'jwk'
https://github.com/nodejs/node/pull/39319
* deps: bump HdrHistogram_C to 0.11.2
https://github.com/nodejs/node/pull/39462
* fixup! deps: extract gtest source files to deps/googletest
* chore: bump node in DEPS to v16.6.2
* chore: update patches
* deps: reflect c-ares source tree
https://github.com/nodejs/node/pull/39653
* deps: update c-ares to 1.17.2
https://github.com/nodejs/node/pull/39724
* fix: _ReadBarrier undefined symbol error on WOA arm64
* chore: update patches
* chore: bump node in DEPS to v16.7.0
* deps: upgrade to libuv 1.42.0
https://github.com/nodejs/node/pull/39525
* chore: update filenames
* src: remove extra semicolons outside fns
* chore: fixup patch filenames
* chore: sort and alphabetize disabled tests
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-08-20 19:25:50 +02:00
Sudowoodo Release Bot
517b174c3c
Bump v16.0.0-nightly.20210820
2021-08-20 06:01:13 -07:00
Samuel Attard
c83de755c1
Revert "fix: DCHECK on reload when forcefullyCrashRenderer() is called ( #30544 )" ( #30646 )
...
This reverts commit 90b5ba3bed .
2021-08-19 12:07:48 -07:00
Samuel Attard
aab5ea5f9d
build: embed binary checksums in the npm package ( #30611 )
...
* build: embed binary checksums in the npm package
* Update docs/tutorial/installation.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* refactor: replace reduce with loop
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-08-19 11:26:17 -07:00
Samuel Attard
7093cd75cb
build: add nvmrc file ( #30612 )
2021-08-19 11:12:17 -07:00
Jeremy Rose
2a28ca226f
ci: drop with_tags with_branch_heads from sync on appveyor ( #30601 )
2021-08-19 09:23:34 -07:00
Sudowoodo Release Bot
4820dee980
Bump v16.0.0-nightly.20210819
2021-08-19 06:00:58 -07:00
Samuel Maddock
cb7c16cb2d
fix: WebFrameMain mojo pipe not reset ( #30629 )
2021-08-19 15:10:11 +09:00
Larry Kluger
11de995d38
docs: typo in launch-app-from-url-in-another-app.md ( #30566 )
...
* Typo in launch-app-from-url-in-another-app.md
Code snippet for the info.plist example had html formatting. Removed.
* Fix paddings
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2021-08-19 10:38:30 +09:00
Erick Zhao
ea889b423d
docs: update Hazel information ( #30517 )
2021-08-19 08:42:12 +09:00
Erick Zhao
655b614ecd
docs: remove unused Desktop Environment Integration doc ( #30577 )
...
* docs: remove unused Desktop Environment Integration doc
* Update docs/api/app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
* Update docs/api/app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
Co-authored-by: Mark Lee <malept@users.noreply.github.com >
2021-08-19 08:34:34 +09:00
Keeley Hammond
cbeae20438
fix: change gin_wrappable to scoped crash key ( #30578 )
2021-08-18 13:51:40 -07:00
Cheng Zhao
8699124397
refactor: dynamically search defines from node ( #30563 )
2021-08-18 13:34:15 -07:00
Shelley Vohr
ec13a0b0e6
fix: documentEdited with non-default titlebarStyle ( #30565 )
2021-08-18 12:09:57 -07:00
Shelley Vohr
e92d92d7eb
build: remove redundant --ignore_locks from appveyor ( #30591 )
2021-08-18 12:08:02 -07:00
Samuel Maddock
dd16d68e96
fix: cross-origin navigation disposing WebFrameMain instances ( #30076 )
2021-08-18 11:23:41 -07:00
Shelley Vohr
90b5ba3bed
fix: DCHECK on reload when forcefullyCrashRenderer() is called ( #30544 )
2021-08-18 11:23:06 -07:00
Jeremy Rose
29749f3dc6
chore: delete unused content_tracing.idl ( #30554 )
2021-08-18 09:54:40 -07:00
Sudowoodo Release Bot
f797159fbe
Bump v16.0.0-nightly.20210818
2021-08-18 06:00:48 -07:00
Samuel Attard
b62bbfda4e
fix: ensure web_contents() is alive before grabbing view ( #30571 )
2021-08-17 14:00:49 -07:00
Shelley Vohr
db8644ee7a
fix: media key globalShortcuts on macOS ( #30552 )
2021-08-17 13:44:17 -04:00
Milan Burda
04aafcc5ef
refactor: simplify <webview> event dispatch ( #30458 )
...
* refactor: simplify <webview> event dispatch
* Update lib/browser/guest-view-manager.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* remove undocumented new-window event properties
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-08-17 12:10:27 -04:00
Sudowoodo Release Bot
ff128a32d9
Bump v16.0.0-nightly.20210817
2021-08-17 06:00:38 -07:00
Shelley Vohr
a9a90fa1b6
fix: {exit|enter}-html-fullscreen emitted after esc in webview ( #30537 )
2021-08-17 09:03:45 +02:00
Samuel Attard
7cdd132d18
fix: handle nullish WebContentsView in UpdateDraggableRegions ( #30556 )
...
* fix: handle nullish WebContentsView in UpdateDraggableRegions
* build: nogncheck on webcontentsimpl include
2021-08-16 23:29:49 -07:00
Samuel Attard
93d7968d64
build: fix gclient config file
2021-08-16 10:56:29 -07:00
Samuel Attard
cd09a54365
build: add basic codespaces configuration ( #30528 )
...
* build: @jasonetco said that this will make codespaces work
* tmp
* Codespaces
* Update docker-compose.yml
* Update docker-compose.yml
* tada?
* e use
* do not use pizza...
* point at correct goma file
* use ghcr for codespaces
* pass --yes to npx
* build: use auth.notgoma codespace token auth to auto-auth goma
* build: move build-tools set up to Dockerfile
* build: provide default extensions list
* Fix locale tests
* add vnc support
* use prebuilt devcontainer image
* update docker images
* update docker images
* update docker images
* add docs for codespaces
* chore: update docker images
* build: do not overwrite modified buildtools configs on container rebuilds
* use gn language server
* update docker images
* update docker images
* fill in missing links
Co-authored-by: Codespaces <codespaces@github.com >
2021-08-16 10:33:49 -07:00
Sudowoodo Release Bot
eaa5d372fb
Bump v16.0.0-nightly.20210816
2021-08-16 06:01:11 -07:00
Erick Zhao
6669abf38d
docs: clarify platform-specific usage of the acceptFirstMouse option ( #30522 )
2021-08-16 14:13:02 +02:00
Erick Zhao
740dcc5c16
docs: uniformize tutorial titles ( #30527 )
2021-08-16 14:12:34 +02:00
Shelley Vohr
fcce2b16d5
fix: persist BrowserView background color when bounds offscreen ( #30510 )
2021-08-16 12:26:58 +02:00
John Kleinschmidt
94111c9d5c
ci: update git on CI machines ( #30526 )
2021-08-14 16:00:40 -07:00
Samuel Attard
8b9d0092cb
build: manually pull 64bit dugite for 32bit tests ( #30531 )
2021-08-14 15:44:43 -07:00
Samuel Attard
0c1f762119
build: fix publish-to-npm script post requests migration
2021-08-13 13:26:38 -07:00
Keeley Hammond
a11a234eac
fix: disable kWindowCaptureMacV2 for desktopCapturer ( #30507 )
2021-08-13 13:23:56 -07:00
Samuel Attard
fc9a197f6c
build: do not excessively log response bodies
2021-08-13 13:15:39 -07:00
Samuel Attard
61117a11a1
build: ensure getAssetContents is called in a async wrapper fn
2021-08-13 13:07:17 -07:00
Sudowoodo Release Bot
7132f36ddd
Bump v16.0.0-nightly.20210813
2021-08-13 10:41:03 -07:00
Samuel Attard
d1bd9afbbf
build: use basic auth to trigger CI if either a username OR password is provided
2021-08-13 10:40:26 -07:00
Sudowoodo Release Bot
1e983e2a6e
Revert "Bump v16.0.0-nightly.20210813"
...
This reverts commit c5db7a9013 .
2021-08-13 10:39:45 -07:00
Sudowoodo Release Bot
c5db7a9013
Bump v16.0.0-nightly.20210813
2021-08-13 10:38:06 -07:00
Samuel Attard
a48968c1ce
build: do not pass undefined to Auth header in CI scripts
2021-08-13 10:37:30 -07:00
Sudowoodo Release Bot
d313ddbd3d
Revert "Bump v16.0.0-nightly.20210813"
...
This reverts commit 6ad47322fa .
2021-08-13 10:30:22 -07:00
Sudowoodo Release Bot
6ad47322fa
Bump v16.0.0-nightly.20210813
2021-08-13 10:27:52 -07:00
Samuel Attard
93b1d2d932
build: fix release CI jobs start script ( #30521 )
...
This broke in #30492 , we weren't handled 20X status codes and weren't authing to appveyor correctly.
2021-08-13 10:25:17 -07:00
Sudowoodo Release Bot
17615654e8
Revert "Bump v16.0.0-nightly.20210813"
...
This reverts commit c6267d9fb0 .
2021-08-13 10:23:49 -07:00
Sudowoodo Release Bot
c6267d9fb0
Bump v16.0.0-nightly.20210813
2021-08-13 09:30:30 -07:00
Sudowoodo Release Bot
52890e9efd
Revert "Bump v16.0.0-nightly.20210813"
...
This reverts commit 7668507c9d .
2021-08-13 08:10:10 -07:00
Sudowoodo Release Bot
7668507c9d
Bump v16.0.0-nightly.20210813
2021-08-13 06:01:58 -07:00
Samuel Attard
439e83de6c
refactor: remove all usages of the legacy request module ( #30492 )
...
* Replaces request with got
* Replaces nugget with got streams
* Replaces request in docs with got
* Upgrades dugite to drop requests dependency
2021-08-12 10:34:49 -07:00
Sudowoodo Release Bot
08ff1c2cbf
Bump v16.0.0-nightly.20210812
2021-08-12 06:01:50 -07:00
electron-roller[bot]
81c143318b
chore: bump chromium to 94.0.4590.2 (main) ( #30274 )
...
* chore: bump chromium in DEPS to 94.0.4587.0
* chore: update patches
* 2823155: fix GPU video decoding capabilities enumeration
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/2823155
* 3041383: Reduce includes in url_request_mojom_traits.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3041383
* chore: bump chromium in DEPS to 94.0.4588.0
* chore: update patches
* chore: bump chromium in DEPS to 94.0.4589.0
* chore: update patches
* 3050633: Rename ScaleFactor to ResourceScaleFactor
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3050633
* 3048296: Create new mojo target to prevent traits header spreading
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3048296
* 3046186: Rename base::ClampToRange
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3046186
* chore: update picture-in-picture patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056037
* chore: bump chromium in DEPS to 94.0.4590.0
* chore: update patches
* 3057495: Fix base::NoDestructor usage in Mac KeychainPassword
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3057495
* 3056134: Remove NetworkIsolationKey unused methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056134
* 3035091: [rab/gsab] Fix gsab maxByteLength after transferring to worker
Adds a patch to v8 to disable a DCHECK that is also firing on node streams
in child processes.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3035091
* chore: bump chromium in DEPS to 94.0.4590.2
* chore: fix mas_no_private_api.patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049052
* 3049555: [views] Add CHECK to prevent fallthrough to global NativeTheme
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049555
* chore: empty commit
* chore: fix whitespace for lint
* chore: cherry-pick chromium woa fix
* Revert "chore: cherry-pick chromium woa fix"
This reverts commit 64f3082e2d .
* chore: fix the build on Windows on ARM
* chore: remove commented code in printing.patch
* fixup! chore: remove commented code in printing.patch
do not remove the new weak_ptr check
* build: sync disable_use_lld_for_macos.patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-08-11 17:04:56 -04:00
John Kleinschmidt
c8f3324610
ci: make arm64 macos test cleanup more resilient ( #30495 )
2021-08-11 16:23:47 -04:00
Keeley Hammond
60650abf09
fix: explicitly define REFGUID from ::GUID&, not base::GUID ( #30442 )
...
* fix: explicitly define REFGUID from ::GUID&
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076480
* fix: duplicate GUID_NULL symbol, add comment
2021-08-11 12:43:33 -07:00
Samuel Attard
e11953b0e6
build: update remark ( #30493 )
2021-08-11 11:13:33 -07:00
Michaela Laurencin
41646d1168
feat: enable windows control overlay on Windows ( #29600 )
...
* rebase "feat: enable windows control overlay on Windows"
* correct compilation error
* fix linting errors
* modify includes and build file
* change `hidden` option to `overlay`
* add patch to fix visual layout
* add button background color parameter
* add button text color parameter
* modify `overlay` in docs and modify button hover/press transition color
* change `text` to `symbol`
* remove todo and fix `text` replacement
* add new titleBarOverlay property and remove titleBarStyle `overlay`
* update browser and frameless window docs
* remove chromium patches
* chore: update patches
* change button hover color, update trailing `_`, update test file
* add dchecks, update title bar drawing checks, update test file
* modify for mac and linux builds
* update docs with overlayColor and overlaySymbolColor
* add corner and side hit test info
* modify docs and copyright info
* modify `titlebar_overlay_` as boolean or object
* move `title_bar_style_ to `NativeWindow`
* update docs with boolean and object titlebar_overlay_
* add `IsEmpty` checks
* move get options for boolean and object checks
* fix linting error
* disable `use_lld` for macos
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Apply docs suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* modify `true` option description `titleBarOverlay`
* ci: cleanup keychain after tests on arm64 mac (#30472 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-08-11 14:07:36 -04:00
Sudowoodo Release Bot
42936b07fe
Bump v16.0.0-nightly.20210811
2021-08-11 06:01:26 -07:00
dependabot[bot]
985f1b5c04
build(deps): bump path-parse from 1.0.6 to 1.0.7 ( #30480 )
...
Bumps [path-parse](https://github.com/jbgutierrez/path-parse ) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases )
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7 )
---
updated-dependencies:
- dependency-name: path-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-11 02:04:43 -07:00
Shelley Vohr
ac49e6af4a
repl: fix crash when SharedArrayBuffer disabled ( #30456 )
2021-08-11 09:42:15 +09:00
John Kleinschmidt
69f1c1b083
ci: cleanup keychain after tests on arm64 mac ( #30472 )
2021-08-10 16:15:30 -04:00
Sudowoodo Release Bot
f17e6ae318
Bump v16.0.0-nightly.20210810
2021-08-10 06:01:37 -07:00
Milan Burda
4f739d7837
docs: add missing <webview> event documentation ( #30450 )
2021-08-10 10:12:54 +09:00
nibbleswap
590858a38d
docs: fix camelcase in menu example ( #30341 )
...
* docs: fix camelcase in menu example and add hint to deal with TS error
hideothers -> hideOthers (the TS compiler caught this)
The TypeScript compiler also did not like the pattern used to
switch between platforms for submenus was loosing the type information
of the literal constants and generalized them as strings which
conflicts with the type definition of MenuItemConstructorOptions.
* docs: Fix spelling, added hint to TypeScript
Without explicitly stating the type for the const template TypeScript does not create a
with the correct shape due to generalization to strings.
* remove ts hints
Co-authored-by: a <a@b>
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2021-08-10 10:01:39 +09:00
Charles Kerr
edb7413bae
fix: mouse doesn't work on frameless browserwindows ( #30447 )
2021-08-10 10:01:20 +09:00
Jeremy Rose
e223b4db94
fix: respect image animation policy pref ( #30403 )
2021-08-09 09:58:03 -07:00
Electron Bot
08e9aea940
Bump v16.0.0-nightly.20210809
2021-08-09 06:02:07 -07:00
Electron Bot
66c458a353
Bump v16.0.0-nightly.20210806
2021-08-06 14:06:30 -07:00
Keeley Hammond
6a9cada98c
fix: build SetCrashKeyGW without tray on Windows ( #30437 )
2021-08-06 14:04:19 -07:00
Electron Bot
d783e944d3
Revert "Bump v16.0.0-nightly.20210806"
...
This reverts commit 641260bc32 .
2021-08-06 12:58:53 -07:00
Electron Bot
641260bc32
Bump v16.0.0-nightly.20210806
2021-08-06 06:01:19 -07:00
George Xu
bc508c6113
feat: add electron.safeStorage encryption API ( #30020 )
...
* feat: add SafeStorage api; first commit
* chore: rename files to fit semantically
* chore: add linkedBindings
* chore: fix function signatures
* chore: refactor eisCookieEncryptionEnabled() fuse
* chore: create test file
* chore: add tests and documentation
* chore: add copyright and lint
* chore: add additional tests
* chore: fix constructor
* chore: commit for pair programming
* wip: commit for keeley pairing
* chore: docs change and code cleanup
* chore: add linux import
* chore: add description to documentation
* chore: fixing tests
* chore: modify behaviour to not allow unencrypted strings as decyption input
* fix add patch for enabling default v11 encryption on Linux
* chore: remove file after each test
* chore: fix patch
* chore: remove chromium patch
* chore: add linux specific tests
* chore: fix path
* chore: add checker for linuux file deletion
* chore: add dcheck back
* chore: remove reference to headless mode
* chore: remove tests for linux
* chore: edit commit message
* chore: refactor safeStorage to not be a class
* chore: remove static variable from header
* chore: spec file remove settimeout
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
2021-08-05 15:12:54 -07:00
Jeremy Rose
ec6cd0053e
chore: more crash-keys for gin::Wrappable debugging ( #30404 )
2021-08-05 11:39:07 -07:00
Darshan Sen
8e1160fde4
build: use fully qualified path names for deps ( #30414 )
...
This aligns the code with the GN Style Guide: https://gn.googlesource.com/gn/+/refs/heads/main/docs/style_guide.md#deps
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
2021-08-05 11:03:50 -07:00
Samuel Attard
320bea4c28
feat: add fuses for NODE_OPTIONS and --inspect ( #30190 )
...
* feat: add fuses for NODE_OPTIONS and --inspect
* chore: add node patch to ensure NODE_OPTIONS are never parsed when fuse is disabledd
* chore: fix lint
* chore: flip boolean logic
* chore: update patches
* chore: add trailing _ to static member
* Update add_should_read_node_options_from_env_option_to_disable_node_options.patch
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-08-05 10:50:11 -07:00
Samuel Attard
59ab79417d
build: rebase release branch before reverting bump ( #30400 )
2021-08-05 10:49:12 -07:00
Electron Bot
423172775e
Bump v16.0.0-nightly.20210805
2021-08-05 06:01:09 -07:00
Samuel Attard
4703dc0a1d
build: bust the deps cache on windows ( #30401 )
2021-08-04 15:31:17 -07:00
Jeremy Rose
481b774fd7
docs: crashpad on linux lands in 16, not 15. ( #30387 )
2021-08-04 10:16:05 -07:00
Electron Bot
acbd643e2a
Bump v16.0.0-nightly.20210804
2021-08-04 06:00:53 -07:00
Cheng Zhao
97929eab5f
fix: move window buttons in-place on macOS ( #30322 )
2021-08-04 09:31:12 +09:00
Milan Burda
1c29734c91
build: fix building with enable_desktop_capturer = false ( #30372 )
2021-08-03 15:12:46 -07:00
Jeremy Rose
8179349625
feat: enable sandbox by default in limited circumstances ( #30197 )
2021-08-03 15:07:03 -07:00
Jeremy Rose
a17e48061a
fix: console window popping up when --enable-logging passed on windows ( #30375 )
2021-08-03 14:09:02 -07:00
Jeremy Rose
40e76dca07
feat: switch to crashpad on linux ( #30278 )
2021-08-03 14:01:12 -07:00
Milan Burda
6e43b0bcbf
refactor: only create webContents after 'will-attach-webview' ( #30311 )
2021-08-03 10:08:49 -07:00
Electron Bot
4519bc3cd1
Bump v16.0.0-nightly.20210803
2021-08-03 06:01:40 -07:00
Robo
2b897c8ad8
fix: crash due to race between attach and destruction of webview ( #24344 )
2021-08-02 08:35:57 -07:00
Electron Bot
0cabff0a21
Bump v16.0.0-nightly.20210802
2021-08-02 06:01:52 -07:00
Jeremy Rose
888ac65c72
fix: toggleDevTools menu role closes devtools window ( #29922 )
2021-08-02 10:58:28 +09:00
Matthew Shen
c0e72bd335
docs: update to the use of arrow functions in line with the style guide ( #30194 )
...
* docs: Update to the use of arrow functions in line with the style guide
* docs: Fixed unmatched bracket typo in previous commit 9ebe3e58f7948c6636d77f3c58a2693683b69691
* fix linting
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-08-02 10:57:37 +09:00
Biru Mohanathas
ced2e8779f
feat: Allow detection of MITM HTTPS proxies like ZScaler ( #30174 )
...
* feat: Allow detection of MITM HTTPS proxies like ZScaler
For security purposes, Figma heavily restrics the origins that are
allowed to load within our Electron app. Unfortunately some corporate
environments use MITM proxies like ZScaler, which intercepts our
connection to `https://www.figma.com ` and serves a redirect to e.g.
`https://gateway.zscloud.net ` before finally redirecting back to
`https://www.figma.com `.
In order to detect this situation and handle it gracefully, we need to
be able to know whether or not the certificate for our own origin
(`https://www.figma.com `) is chained to a known root. We do this by
exposesing `CertVerifyResult::is_issued_by_known_root`.
If the certification verification passed without the certificate being
tied to a known root, we can safely assume that we are dealing with a
MITM proxy that has its root CA installed locally on the machine. This
means that HTTPS can't be trusted so we might as well make life easier
for corporate users by loosening our origin restrictions without any
manual steps.
* Tweak docs wording
2021-08-02 10:24:58 +09:00
Samuel Attard
9693fb9a37
build: update build images to update npm and node ( #30359 )
2021-08-02 10:01:59 +09:00
Jeremy Rose
9a63d96e83
fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole ( #30312 )
2021-07-30 10:18:49 -07:00
Electron Bot
7b5deb2f3a
Bump v16.0.0-nightly.20210730
2021-07-30 06:01:04 -07:00
Samuel Attard
8651c5d02d
chore: update deps ( #30339 )
2021-07-30 02:21:54 -07:00
Shelley Vohr
639f03977f
fix: BrowserViews not painting their WebContents ( #29919 )
2021-07-30 08:59:24 +09:00
John Kleinschmidt
9cc1b55663
chore: remove experimental from navigator.serial implementation ( #30237 )
2021-07-30 08:57:22 +09:00
Shelley Vohr
3ee6326b93
fix: use contentAspectRatio not aspectRatio ( #30305 )
2021-07-29 23:27:21 +02:00
Shelley Vohr
39c3ff5292
fix: guard against missing native view ( #30304 )
2021-07-29 23:27:02 +02:00
Electron Bot
4aa9455613
Bump v16.0.0-nightly.20210729
2021-07-29 06:02:12 -07:00
Milan Burda
c5ad7ed0cd
refactor: remove guestInstanceId from WebPreferences ( #30280 )
...
* refactor: remove guestInstanceId from WebPreferences
* refactor: remove WebViewManager::GetEmbedder
2021-07-28 15:32:53 -07:00
Samuel Attard
c3abbdefdd
build: set the export goma auth fallback flag for the control process ( #30313 )
2021-07-28 14:02:50 -07:00
George Xu
bd85b1d028
docs: create documentation for browser api ( #30071 )
...
* docs: create documentation for browser api
* docs: add cpp theme
2021-07-28 12:37:45 -07:00
Jeremy Rose
fa464286ee
test: deflake crashReporter.getLastCrashReport test ( #30276 )
2021-07-28 08:56:15 -07:00
Electron Bot
d63980edeb
Bump v16.0.0-nightly.20210728
2021-07-28 06:01:28 -07:00
Anders Kaseorg
1c95d30c0f
fix: Add missing items to menuItem.role documentation ( #30217 )
2021-07-28 08:45:06 +02:00
Milan Burda
fc7ea75009
refactor: move related code to makeWebPreferences in guest-view-manager.ts ( #30272 )
2021-07-27 16:12:49 -07:00
Jeremy Rose
ceebae170e
feat: partially support chrome.tabs.update ( #30069 )
2021-07-27 13:36:22 -07:00
John Kleinschmidt
cce27a0961
chore: update publish to npm to use GitHub token ( #30275 )
...
ensures that we don't get hit with a rate limit while trying to publish a release.
2021-07-27 09:52:18 -04:00
Electron Bot
10424c0149
Bump v16.0.0-nightly.20210727
2021-07-27 06:00:51 -07:00
Milan Burda
a545cd3790
fix: type internal APIs that can return null properly ( #29852 )
2021-07-27 14:48:12 +09:00
John Kleinschmidt
461db8f1ab
fix: persist permission granted to serial ports ( #30209 )
2021-07-26 13:10:57 -04:00
Cheng Zhao
d2989de5d9
fix: update traffic lights position for macOS 11 ( #30263 )
2021-07-26 09:22:21 -07:00
Jeremy Rose
385d0f590f
refactor: remove base::Value from WebContentsPreferences ( #30193 )
2021-07-26 09:04:09 -07:00
electron-roller[bot]
64ba8feb93
chore: bump chromium to 94.0.4584.0 (main) ( #30030 )
...
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-07-26 09:02:16 -07:00
Electron Bot
a6ab702ae4
Bump v16.0.0-nightly.20210726
2021-07-26 06:01:26 -07:00
Antón Molleda
62711e23ad
docs: update title of guide ( #30205 )
2021-07-26 17:42:55 +09:00
Electron Bot
3cb06457c4
Bump v16.0.0-nightly.20210723
2021-07-23 06:01:58 -07:00
stephen9357
e3fe80e0e8
fix: increase stack size on windows x86 ( #29474 )
...
* fix: increace main thread stack size on windows x86
* chore: improve quit-on-crashed-event spec
* chore: add debug logs
* Revert "chore: add debug logs"
This reverts commit 0be81ae07c .
* chore: use a reliable crash endpoint
Co-authored-by: Stephen Wang <wangwenqiang.wwq@bytedance.com >
Co-authored-by: Deepak Mohan <hop2deep@gmail.com >
2021-07-22 12:49:21 -07:00
Shelley Vohr
b24cfe17bc
fix: process.exit crash in nativeWindowOpen ( #30218 )
2021-07-22 15:38:11 +02:00
Electron Bot
eca1098b55
Bump v16.0.0-nightly.20210722
2021-07-22 06:01:34 -07:00
Keeley Hammond
19820fc2a7
chore: add additional crash key to gin::Wrappable ( #30161 )
2021-07-21 09:33:25 -04:00
Electron Bot
adc3f39a9e
Bump v15.0.0-nightly.20210721
2021-07-21 06:02:02 -07:00
Samuel Attard
9fe70c5580
build: handle release failure by existing with code 1 ( #30216 )
2021-07-21 00:45:57 -07:00
Electron Bot
ea69da279f
Bump v15.0.0-nightly.20210720
2021-07-20 06:02:23 -07:00
Keeley Hammond
deb75ceaa5
build: update version-bumper to support alpha ( #30165 )
...
* build: update version-bumper to support alpha
* build: seperate alpha bump version tests
For easier deletion. If we want to continue supporting an alpha channel,
they can be reintegrated with main tests.
* chore: fix regex
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
2021-07-19 17:58:15 -07:00
Jeremy Rose
d35fb2a2e3
docs: mention sandboxing in security docs ( #30147 )
2021-07-19 12:45:47 -07:00
Jeremy Rose
c9ba0d02d7
feat: support crashpad on linux ( #29719 )
2021-07-19 10:11:10 -07:00
Jeremy Rose
612361c4da
chore: remove unused getWebPreferences method ( #30160 )
2021-07-19 09:29:23 -07:00
Mark Lee
a3298424b3
docs: update default branch for Electron Packager API links ( #30175 )
2021-07-19 09:25:05 -07:00
Jota
9441ff747d
docs: Ffx broken context isolation link in sandbox docs ( #30177 )
2021-07-19 09:24:27 -07:00
Electron Bot
d4b2f69f36
Bump v15.0.0-nightly.20210719
2021-07-19 06:02:42 -07:00
Electron Bot
cfb2829634
Bump v15.0.0-nightly.20210716
2021-07-16 06:01:06 -07:00
Jeremy Rose
0d9e6f29ba
fix: allow colored tray titles when font type is specified ( #30146 )
2021-07-15 16:45:20 -07:00
Shelley Vohr
1bb689e6dd
fix: BrowserWindow transparency not working ( #30136 )
2021-07-15 16:18:39 -04:00
electron-roller[bot]
063ac19712
chore: bump node to v16.5.0 (main) ( #30031 )
...
* chore: bump node in DEPS to v16.4.2
* chore: update patches
* ci: run main and remote woa tests separately
* chore: bump node in DEPS to v16.5.0
* build: restore libplatform headers in distribution
https://github.com/nodejs/node/pull/39288
* build: pass directory instead of list of files to js2c.py
https://github.com/nodejs/node/pull/39069
* chore: various BoringSSL/OpenSSL upstreams
- https://github.com/nodejs/node/pull/39136
- https://github.com/nodejs/node/pull/39138
- https://github.com/nodejs/node/pull/39054
* test: move debugger test case to parallel
https://github.com/nodejs/node/pull/39300
* chore: fixup patch indices
* build: pass directory instead of list of files to js2c.py
https://github.com/nodejs/node/pull/39069
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-07-15 11:25:00 -04:00
Electron Bot
849a3b6f81
Bump v15.0.0-nightly.20210715
2021-07-15 07:13:56 -07:00
David Sanders
341b370213
fix: handle redirects within registered protocols ( #29796 )
2021-07-15 20:14:46 +09:00
Shelley Vohr
3f38681c55
fix: double traffic lights on exit fullscreen ( #30114 )
2021-07-14 16:45:12 -07:00
Cheng Zhao
05ba6359d0
feat: add signal option to dialog.showMessageBox ( #26102 )
...
* mac: add dialog.closeMessageBox API
* win: Implement dialog.closeMessageBox
* mac: Return cancelId with closeMessageBox
* gtk: Implement dialog.closeMessageBox
* win: Fix 32bit build
* win: Reduce the scope of lock
* fix: Build error after rebase
* feat: Use AbortSignal to close message box
* chore: silently handle duplicate ID
* win: Add more notes about the threads
* chore: apply reviews
* fix: base::NoDestructor should be warpped in function
* chore: fix style on windows
2021-07-15 07:59:27 +09:00
George Xu
4b780f9770
docs: update supported versions to match new release cadence ( #30121 )
2021-07-14 15:38:28 -07:00
Utkarsh Dixit
b2da2f759a
docs: add runtime.reload as supported extension api ( #29925 )
2021-07-14 15:37:53 -07:00
Robo
4931c055a9
spec: disable flaky fullscreen test ( #30141 )
2021-07-14 15:26:09 -07:00
Antón Molleda
a855aa34d9
docs: fix fiddle path ( #30139 )
...
This is breaking the build in `electron/electronjs.org-new` and will
most likely not work when clicking the "Fiddle" button.
Rel: https://github.com/electron/electronjs.org-new/pull/65
2021-07-14 16:16:59 -04:00
Jeremy Rose
bec47f54f4
fix: use correct userData path when unbundled ( #30113 )
2021-07-14 13:10:37 -07:00
Electron Bot
4db7221c7d
Bump v15.0.0-nightly.20210714
2021-07-14 06:02:07 -07:00
Davenury
75b4267aa9
Update quick-start.md ( #30064 )
...
Change app-quit link definition, so both window-all-closed and app-quit redirects to appropriate sites.
2021-07-14 20:59:32 +09:00
Milan Burda
c0995b8dff
docs: add <webview> 'did-attach' event documentation ( #29899 )
2021-07-14 20:59:20 +09:00
Cheng Zhao
637ba48b42
fix: pressing ESC should exit fullscreen from webview ( #30063 )
2021-07-14 20:51:26 +09:00
Jeremy Rose
4d0475c9ce
feat: expose location and modifiers on before-input-event ( #29850 )
...
* feat: expose location and modifiers on before-input-event
* lint
2021-07-14 20:50:02 +09:00
Keeley Hammond
1897b14af3
chore: update releases to 8 weeks in CONTRIBUTING ( #30115 )
...
* chore: update releases to 8 weeks in CONTRIBUTING
* chore: update support.md for four version support
2021-07-13 13:57:19 -07:00
Sofia Nguy
eb2efd4b7e
docs: Update timeline for E15 alpha announcement ( #30109 )
...
* docs: Update timeline for E15 alpha announcement
* fix line break
2021-07-13 13:54:13 -07:00
1akshat1
d267f979b7
feat: continue-activity event is extended to support webpageURL property ( #30042 )
...
Co-authored-by: Akshat Malik <amalik@microstrategy.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-07-13 13:21:33 -07:00
Electron Bot
3582a513ca
Bump v15.0.0-nightly.20210713
2021-07-13 06:02:20 -07:00
Milan Burda
9959f01e4c
spec: fix check for electron_common_testing binding in logging-spec.ts ( #30086 )
2021-07-12 22:11:19 -07:00
Robo
19a6286dfd
chore: cherry-pick 9bab573a37 from chromium ( #30084 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3010140
2021-07-12 18:35:29 -07:00
Jeremy Rose
459a8417e3
test: disable failing node tests ( #30096 )
2021-07-13 09:40:58 +09:00
Jeremy Rose
96ff8d7bd7
build: decode error output as utf8 ( #30093 )
2021-07-12 15:22:26 -07:00
Jeremy Rose
e26901aba4
fix: crash when invoking login callback synchronously ( #30068 )
2021-07-12 12:33:41 -07:00
Jeremy Rose
0cb5631b0b
fix: return RGBA values from getSystemColor ( #30055 )
2021-07-12 11:08:10 -07:00
Robo
36079b822a
chore: disable fullscreen test on mac arm ( #30083 )
2021-07-12 08:53:35 -07:00
Electron Bot
c15f44c20f
Bump v15.0.0-nightly.20210712
2021-07-12 06:01:17 -07:00
Robo
c806184bfe
chore: fix flaky fullscreen inheritance test ( #30081 )
2021-07-11 23:19:30 -07:00
Cheng Zhao
21f6937728
chore: remove unneeded conversions between wstring and u16string ( #30047 )
2021-07-12 13:33:26 +09:00
Robo
ccfde6c9d4
fix: window ordering on mac ( #29857 )
2021-07-09 13:38:25 -07:00
Electron Bot
98f617e856
Bump v15.0.0-nightly.20210709
2021-07-09 06:01:45 -07:00
George Xu
b7164428ec
docs: modernize protocol-handler docs ( #29380 )
...
* docs: modernize protocol-handler docs
* docs: iadd contextIsolation
* docs: add guide for launch-app-from-URL-in-other-app
* docs: address comments
* chore: fix brackets
* chore: add escaped brackets
2021-07-08 11:42:28 -07:00
Electron Bot
0824fc57f7
Bump v15.0.0-nightly.20210708
2021-07-08 06:01:00 -07:00
Milan Burda
53386914e1
docs: move webRequest filters definition to structures/web-request-filter.md ( #29900 )
2021-07-08 00:20:08 -07:00
Milan Burda
635ed5a6e3
feat: add missing resourceType conversions for webRequest listener details ( #29902 )
2021-07-08 00:19:16 -07:00
Milan Burda
13bf2fd7ec
build: fix building with enable_plugins = false ( #30040 )
2021-07-08 00:18:11 -07:00
Electron Bot
cd031a77dd
Bump v15.0.0-nightly.20210707
2021-07-07 13:02:22 -07:00
Electron Bot
767b4973a3
Revert "Bump v15.0.0-nightly.20210707"
...
This reverts commit 5f1233cdad .
2021-07-07 12:11:40 -07:00
Electron Bot
5f1233cdad
Bump v15.0.0-nightly.20210707
2021-07-07 06:01:31 -07:00
Jeremy Rose
550d3c11a8
docs: mention contextIsolation in ipc-main example ( #29918 )
2021-07-06 10:27:35 -07:00
Electron Bot
257b796856
Bump v15.0.0-nightly.20210706
2021-07-06 06:01:39 -07:00
electron-roller[bot]
2585e6d5fa
chore: bump chromium to 93.0.4566.0 (main) ( #29980 )
...
* chore: bump chromium in DEPS to 93.0.4562.0
* chore: update patches
* [base] Made Value::Take{Dict,List}() rvalue ref-qualified.
https://chromium-review.googlesource.com/c/chromium/src/+/2988105
* Revert "Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)""
https://chromium-review.googlesource.com/c/chromium/src/+/2995482
This reverts commit 9691d6c265 and 797723ec83
* Pass gfx::Insets to GetHTComponentForFrame
https://chromium-review.googlesource.com/c/chromium/src/+/2984243
* chore: bump chromium in DEPS to 93.0.4563.0
* [Clipboard API] Clipboard Custom Formats implementation Part 2.
https://chromium-review.googlesource.com/c/chromium/src/+/2967649
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4564.0
* chore: bump chromium in DEPS to 93.0.4565.0
* chore: update patches
* Prevent use of base::NoDestructor for trivially-destructible types
https://chromium-review.googlesource.com/c/chromium/src/+/2998672
* chore: update patches
* fixup! [Clipboard API] Clipboard Custom Formats implementation Part 2.
* chore: bump chromium in DEPS to 93.0.4566.0
* chore: update patches
* chore: add missing header
* ci: do not run clipboard tests on WOA
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-07-06 08:17:13 -04:00
Samuel Attard
7169734470
fix: download the arm64 version of Electron when running node under rosetta ( #29953 )
2021-07-06 10:40:26 +09:00
Jenux
f3517b6635
docs: match css filename in dark-mode.md ( #29936 )
...
* Update dark-mode.md
Fix the unmatched css file name
* Update docs/tutorial/dark-mode.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-07-06 10:37:41 +09:00
David Sanders
6c251da201
chore: correct spelling of is_quitting in electron::Browser ( #29948 )
2021-07-05 15:45:50 -04:00
electron-roller[bot]
60366ad171
chore: bump node to v16.4.1 (main) ( #29994 )
...
* chore: bump node in DEPS to v16.4.1
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-07-05 13:47:09 -04:00
Electron Bot
6db9b274b7
Bump v15.0.0-nightly.20210705
2021-07-05 06:01:17 -07:00
Cheng Zhao
25a77761f6
fix: build error caused by extra ] ( #30015 )
2021-07-05 01:34:39 -07:00
Shelley Vohr
af991123f1
fix: self.module.paths not working in web workers ( #29955 )
...
* fix: global.module.paths in workers
* spec: add a regression test
2021-07-05 08:48:46 +09:00
Antón Molleda
20c1f504ae
docs: remove Experimental from contextBridge.exposeInMainWorld ( #29985 )
...
The API has been around for about 3 years. It should no longer be
considered experimental.
2021-07-05 08:46:47 +09:00
Cheng Zhao
18d0ed8155
fix: do not leak NSUUID ( #29990 )
2021-07-05 08:45:00 +09:00
Cheng Zhao
0403494a6b
docs: remove mention of node-mac-notifier ( #29991 )
2021-07-03 13:23:47 -07:00
Electron Bot
800873b44d
Bump v15.0.0-nightly.20210702
2021-07-02 06:01:44 -07:00
Cheng Zhao
85a69f88f1
chore: remove unused _grantOriginAccess method ( #29976 )
2021-07-01 19:53:38 -07:00
Cheng Zhao
6eff9231b8
fix: webview should maximize on requestFullscreen ( #29952 )
2021-07-01 20:56:29 -04:00
David Sanders
95a9ff952c
chore: cleanup usages of const char* ( #29906 )
2021-07-02 09:51:52 +09:00
David Sanders
f6531166ae
chore: clean up forward declarations ( #29904 )
2021-07-02 09:51:37 +09:00
John Kleinschmidt
1f8a46c9c6
feat: enable window controls overlay on macOS ( #29253 )
...
* feat: enable windows control overlay on macOS
* address review feedback
* chore: address review feedback
* Address review feedback
* update doc per review
* only enable WCO when titleBarStyle is overlay
* Revert "only enable WCO when titleBarStyle is overlay"
This reverts commit 1b58b5b1fc .
* Add new titleBarOverlay property to manage feature
* spelling fix
* Update docs/api/frameless-window.md
Co-authored-by: Samuel Attard <sam@electronjs.org >
* Update shell/browser/api/electron_api_browser_window.cc
Co-authored-by: Samuel Attard <sam@electronjs.org >
* update per review feedback
Co-authored-by: Samuel Attard <sam@electronjs.org >
2021-07-01 15:25:40 -04:00
Electron Bot
0fe2836151
Bump v15.0.0-nightly.20210701
2021-07-01 06:00:47 -07:00
Samuel Attard
331444d103
build: add support for spawning builds for a specific commit on appveyor ( #29971 )
2021-06-30 18:17:59 -07:00
Shelley Vohr
98809d8d64
fix: honor user-defined Downloads directory ( #29938 )
2021-06-30 22:54:02 +02:00
Shelley Vohr
372ecf32e6
fix: potential crash on macOS app exit ( #29941 )
2021-06-30 20:12:17 +02:00
Jeremy Rose
a8b3c22518
fix: correctly propagate title updates for window with no navigation entries ( #29946 )
2021-06-30 10:53:10 -07:00
Shelley Vohr
675bbfe092
refactor: modify Node.js options object directly ( #29939 )
...
* refactor: modify Node.js options object directly
* chore: update patch to reflect upstream
2021-06-30 16:07:28 +02:00
Electron Bot
a310bd7473
Bump v15.0.0-nightly.20210630
2021-06-30 06:00:59 -07:00
Electron Bot
cb8d9cebbc
Revert "Bump v15.0.0-nightly.20210630"
...
This reverts commit 97c4b59747 .
2021-06-30 03:50:14 -07:00
Electron Bot
97c4b59747
Bump v15.0.0-nightly.20210630
2021-06-30 02:43:32 -07:00
Robo
522b19e2d8
fix: crash when clicking links with target=_blank from webview ( #29874 )
2021-06-29 18:10:18 -07:00
Samuel Attard
da9261497e
feat: add MenuItem.userAccelerator property ( #26682 )
...
* feat: add MenuItem.userAccelerator property
This allows folks to read the user-assigned accelerator that macOS users can provide in system preferences. Useful for showing in-app shortcut help dialogs, you need to know if the accelerator you provided is not being used in favor of a user assigned one.
* chore: update syntax
* chore: add safety check for command index being -1
2021-06-29 16:28:16 -07:00
Rituka Patwal
3e69985b76
chore: set python interpreter to python3 in script/spec-runner.js ( #29740 )
...
The new installs of the python module, python-dbusmock, is broken for
python2. The tests still run fine on linux machine in Electron's
pipeline setup on CircleCI, because the docker image used has
the non-broken version of python-dbusmock for python2 installed.
But running electron tests on any other linux machine would fail if
they don't have this non-broken version of python-dbusmock for python2
installed, already, which is the case for most of the machines.
Moreover, Python2 is deprecated now. So it would be better if we change
the python interpreter in script/spec-runner.js file to python3, for
which all the python modules are updated and working.
Co-authored-by: Rituka Patwal <rituka.patwal@postman.com >
2021-06-29 15:46:12 -07:00
electron-roller[bot]
d3c1f10e33
chore: bump chromium to 93.0.4558.0 (main) ( #29895 )
...
* chore: bump chromium in DEPS to 93.0.4553.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4555.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4556.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4557.0
* chore: update patches
* Fix warnings for -Wc++11-narrowing.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2942212
* fixup! Fix warnings for -Wc++11-narrowing.
* chore: run gen-libc++-filenames.js
* Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)"
https://chromium-review.googlesource.com/c/chromium/src/+/2988699
* chore: bump chromium in DEPS to 93.0.4558.0
* chore: update patches
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-06-29 13:02:27 -07:00
Electron Bot
37b57a1013
Bump v15.0.0-nightly.20210629
2021-06-29 06:01:38 -07:00
Omar Kilani
1b4ce6c69a
fix: geolocation crashes electron on macOS ( #29343 ) ( #29913 )
2021-06-28 20:26:57 -07:00
David Sanders
9142563748
docs: remove requestHeaders in webRequest.onHeadersReceived ( #29907 )
2021-06-28 15:52:06 -07:00
electron-roller[bot]
e4807ac020
chore: bump node to v16.4.0 (main) ( #29699 )
2021-06-28 18:05:38 +02:00
Electron Bot
da2baabb96
Bump v15.0.0-nightly.20210628
2021-06-28 06:01:29 -07:00
David Sanders
b60b96b221
chore: remove unused using and namespace declarations ( #29892 )
2021-06-28 15:26:10 +09:00
Electron Bot
21319926a0
Bump v15.0.0-nightly.20210625
2021-06-25 06:00:29 -07:00
electron-roller[bot]
a518e4b2e1
chore: bump chromium to 93.0.4552.0 (main) ( #29862 )
...
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-06-24 17:06:42 -07:00
Shelley Vohr
f9bfd1da25
fix: properly order out child windows ( #29821 )
2021-06-24 20:43:28 +02:00
Shelley Vohr
9b5dd5380f
fix: Inspector method overrides when contextIsolation enabled ( #29841 )
2021-06-24 20:36:22 +02:00
Jeremy Rose
0f16575eee
fix: stop window.open from hanging when prevented ( #29851 )
2021-06-24 08:50:48 -07:00
Electron Bot
9de8e676dd
Bump v15.0.0-nightly.20210624
2021-06-24 06:01:03 -07:00
dependabot[bot]
47a8c952e9
build(deps): bump lodash from 4.17.20 to 4.17.21 in /spec ( #29067 )
...
* build(deps): bump lodash from 4.17.20 to 4.17.21 in /spec
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-06-23 16:51:28 -07:00
Jeremy Rose
2c01deae03
fix: deny instead of canceling when certificate-error passes false ( #29826 )
2021-06-23 16:40:51 -07:00
Electron Bot
d9d2f01563
Bump v15.0.0-nightly.20210623
2021-06-23 06:01:12 -07:00
David Sanders
ff39a0e939
fix: ensure set vibrancy with invalid value is a no-op ( #29795 )
2021-06-23 15:09:42 +09:00
Shelley Vohr
129f92e1fa
fix: child window alwaysOnTop level persistence ( #29813 )
...
* fix: child window alwaysOnTop level
* chore: add undocumented getAlwaysOnTopLevel
* test: add test for level persistence
* Address feedback from review
2021-06-23 15:09:09 +09:00
Robo
6e310b7424
chore: remove revert_remove_contentrendererclient_shouldfork.patch ( #29842 )
2021-06-22 14:50:57 -07:00
electron-roller[bot]
b8261f1591
chore: bump chromium to 93.0.4550.0 (main) ( #29751 )
2021-06-22 12:17:16 -07:00
Jeremy Rose
c5066cce22
docs: fix broken markdown in dialog.md ( #29782 )
2021-06-22 09:49:30 -07:00
Electron Bot
92901ddf18
Bump v15.0.0-nightly.20210622
2021-06-22 06:01:22 -07:00
David Sanders
bc8cb75e4e
fix: properly handle optional requestHeaders with onBeforeSendHeaders ( #29798 )
2021-06-22 15:08:52 +09:00
Keeley Hammond
0ad73ac423
fix: allow ppapi processes access to resource bundle on all platforms ( #29827 )
...
* wip: debug resource bundle failure
* fix: include ppapi subprocesses for windows resource bundle
* fix: allow ppapi plugin processes access to resource bundle on all platforms.
Aligns with chrome_main_delegate here: https://chromium-review.googlesource.com/c/chromium/src/+/2619003
2021-06-21 20:46:53 -07:00
David Sanders
98d2824c7f
refactor: migrate AdaptCallbackForRepeating to SplitOnceCallback ( #29825 )
2021-06-21 18:04:31 -07:00
Electron Bot
0e465f1885
Bump v15.0.0-nightly.20210621
2021-06-21 06:01:31 -07:00
marekharanczyk
507cbdc80a
fix: do not cancel CORS preflight request on proxy auth. ( #29266 )
...
* fix: do not cancel CORS preflight request on proxy auth.
If connecting via proxy, preflight request can receive 407
header response from proxy. This does not mean request
was finished even though it received headers (from proxy,
not the destination server), so prevent "completing"
and most importantly deleting it, which causes request
to be canceled in network layer. Just continue to monitor it
and await proper response from server. Also add circut breaker
to cancel request if proxy auth failed 3 times (for example
user keeps cancelling auth). This behavior happens only
when app registered WebRequest api listeners.
* Port chromium webrequest changes to electron code.
Move relevant parts of chromium WebRequestProxyingURLLoaderFactory from
https://chromium-review.googlesource.com/c/chromium/src/+/2011781
into electron ProxyingURLLoaderFactory.
* Update code to upstreamed version and remove retyr count failsafe.
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-06-21 14:06:52 +09:00
Fedor Indutny
d4a1b41129
fix: microtasks policy in CreateEnvironment ( #29531 )
...
* fix: microtasks policy in CreateEnvironment
Microtasks policy should not be updated for the renderer because
`NodeBindings::CreateEnvironment` might be entered with or without
`UvRunOnce()` on stack. One of the examples of such calls is
`window.open()` which is possible to invoke while `uv_run()` is still
running (e.g. with `setImmediate()`).
All in all, it doesn't matter that much which policy we use since
`v8::MicrotasksScope` has a check for the policy in its destructor and
no commits will be made if the policy is `kExplicit`. It is important,
however, to not change the policy in the middle of `UvRunOnce()` so we
should respect whatever we currently have and move on.
Fix : #29463
* Move test to a better place
* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
* simplify crash-case
* comment
* fix comment
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Fedor Indutny <indutny@signal.org >
2021-06-21 14:06:17 +09:00
Darshan Sen
cfc846a337
fix: relax app.getLocaleCountryCode() test ( #29679 )
...
If the app is run with LC_ALL=C on Linux, the test would fail as
app.getLocaleCountryCode() would return "".
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2021-06-21 14:05:28 +09:00
Samuel Attard
e7ae6edbd4
fix: update Squirel.Mac to fix CPU spin during update ( #29791 )
...
* fix: update Squirel.Mac to fix CPU spin during update
Refs: https://github.com/Squirrel/Squirrel.Mac/pull/259
Closes : #29119
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-06-21 14:02:20 +09:00
David Sanders
8844034fa8
chore: tune-up electron::api::NetLog ( #29534 )
2021-06-20 18:52:28 -07:00
Erick Zhao
aca14bf7dd
docs: fix frontmatter for Tray tutorial ( #29788 )
2021-06-21 10:13:39 +09:00
Samuel Maddock
ef2ce9dd67
fix: flakey extension bg page test ( #29744 )
2021-06-21 10:11:40 +09:00
sssooonnnggg
e54667e17e
fix: fix hover state not clear bug when BrowserWindow is not resizable ( #611 ) ( #29721 )
2021-06-21 10:10:40 +09:00
dependabot[bot]
cef4e434cb
build(deps-dev): bump ws from 7.2.1 to 7.4.6 in /spec-main ( #29421 )
...
Bumps [ws](https://github.com/websockets/ws ) from 7.2.1 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.2.1...7.4.6 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-18 14:20:29 -07:00
John Kleinschmidt
58c58c46c4
ci: cleanup electron dirs after running tests on arm ( #29769 )
...
* ci: cleanup electron dirs after running tests on arm
(cherry picked from commit 1c0a6045fb )
* use start-stop-daemon to kill Xvfb
2021-06-18 14:35:44 -04:00
Electron Bot
e5aa13e2a4
Bump v15.0.0-nightly.20210618
2021-06-18 06:01:54 -07:00
Shelley Vohr
4450327fda
fix: select element not working on Windows ( #29742 )
2021-06-18 09:05:18 +02:00
Milan Burda
de6696ef1d
chore: remove unused and broken ipcRendererInternal.sendTo() ( #29743 )
2021-06-17 23:26:18 -05:00
John Kleinschmidt
6b4c59b8d8
ci: run linux arm tests on CircleCI ( #29714 )
2021-06-17 18:38:25 -04:00
Charles Kerr
8ccab4ce91
feat: bring --enable-logging functionality in line with Chromium ( #25089 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-06-17 14:17:25 -07:00
Shelley Vohr
c841247815
fix: color select eyedropper not working within DevTools ( #29729 )
2021-06-17 08:42:51 -05:00
Electron Bot
f00a2d0629
Bump v15.0.0-nightly.20210617
2021-06-17 06:01:15 -07:00
Shelley Vohr
b3daa2d672
chore: fix BoringSSL conflict in patches ( #29748 )
2021-06-17 13:06:19 +02:00
Shelley Vohr
542abcd6fd
chore: bump Node.js to v16.2.0 ( #29244 )
2021-06-17 08:50:56 +02:00
Erick Zhao
9a7e61cfc0
docs: clarify use of ELECTRON_SKIP_BINARY_DOWNLOAD ( #29720 )
2021-06-17 15:34:08 +09:00
electron-roller[bot]
85718349cc
chore: bump chromium to 93.0.4539.0 (main) ( #29608 )
...
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Samuel Attard <sam@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-06-16 15:43:51 -07:00
Samuel Attard
f71c6c04fd
fix: ensure detached devtools are not always draggable ( #29717 )
2021-06-16 10:18:02 -07:00
Cheng Zhao
330c3bc136
chore: remove c-style conversion for vibrantView ( #29724 )
2021-06-16 10:13:42 -07:00
Shelley Vohr
d59e2d7b2e
fix: draggable regions with devtools open ( #29696 )
2021-06-16 09:58:30 -07:00
trop[bot]
6fd9e4280c
fix: disable CET as v8 deoptimization is incompatible with it ( #29689 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-06-16 09:57:58 -07:00
Electron Bot
7474c59ea0
Bump v15.0.0-nightly.20210616
2021-06-16 06:02:12 -07:00
kdau
226f2a9a56
fix setWindowOpenHandler call syntax ( #29551 )
2021-06-16 16:16:18 +09:00
Shelley Vohr
2ae7e04598
fix: potential crash when setting vibrancy ( #29677 )
2021-06-16 15:39:20 +09:00
Samuel Attard
81795744cf
fix: ensure the typescript definitions only export correct value types ( #28712 )
...
* fix: ensure the typescript definitions only export correct value types
In typescript there are two main types of "types" you can export, value types (class, const) and definition types (type, interface). The typescript compiler will let anything declared via const or class be used as a value. Unfortunately we were exporting a bunch of things (see the diff) as class/const when they weren't actually exported values. This lead to typescript being happy but the runtime throwing errors (not something we want).
This change passes "exported-in" context through our docs, to the parser and then to the definitions generator to ensure we only mark things as exported in the ts defs that we actually export.
Fixes #22167
* chore: update typescript-defs
* chore: update typescript-defs
* chore: fix bad typescript in IPC test
* docs: test rendering of new syntax
* chore: update per feedback, use same syntax but with 'this is not exportedd' line
2021-06-15 13:50:31 -07:00
Calvin
18b03db073
chore: bumping NAN dep to include test changes ( #29686 )
2021-06-15 16:09:39 -04:00
Keeley Hammond
af276c96ec
chore: disable default async spellchecker on Windows ( #29690 )
...
* chore: disable default async spellchecker on Windows
* chore: disable kWinRetrieveSuggestionsOnlyOnDemand in feature list
2021-06-15 09:11:49 -07:00
Electron Bot
31a4cc26d5
Bump v15.0.0-nightly.20210615
2021-06-15 06:01:55 -07:00
David Sanders
214fcfc46d
test: re-enable some skipped tests ( #29655 )
...
* test: re-enable some skipped tests
* test: enable more tests
2021-06-15 10:55:08 +09:00
George Xu
f022ead559
docs: added guide and updated docs for Tray ( #29385 )
...
* docs: added guide and updated docs for Tray
* docs: improve clarity
2021-06-15 10:34:53 +09:00
Kevin Hartman
3e2ec0e2ce
docs: Update represented-file fiddle tutorial ( #29245 )
...
* Update represented-file fiddle.
* add index and code back to guide
Co-authored-by: Ethan Arrowood <ethan.arrowood@gmail.com >
2021-06-15 10:29:51 +09:00
Milan Burda
56ac67e059
refactor: use std::make_unique/base::MakeRefCounted when possible ( #29637 )
2021-06-15 09:37:55 +09:00
Jeremy Rose
ebf54d7cc0
refactor: use PathProvider for user-data-dir and others ( #29649 )
...
* refactor: use PathProvider for user-data-dir and others
* consolidate logic for DIR_RECENT and DIR_APP_LOGS into path provider
* fix bad include
* remove debugging code
* fix build on mac
* fix build on win
* create app logs dir on both mac and non-mac
2021-06-15 09:32:56 +09:00
Samuel Attard
8b945cb296
build: restore workspace on osx builds to get docs-only-change file ( #29465 )
...
* build: restore workspace on osx builds to get docs-only-change file
* build: clean up attached workspace before checking out from cache
2021-06-14 12:20:59 -07:00
David Sanders
7019713126
docs: use relative links within docs ( #29651 )
2021-06-14 14:02:23 -05:00
Luke Ingalls
86ff4a9836
docs: fix typo in process-model.md ( #29563 )
2021-06-14 11:33:07 -04:00
Darshan Sen
cc04450b85
docs: fix file mode of versioning-sketch-2.png ( #29609 )
...
Unlike the other files, this file had its executable bit set in its file
mode. This change removes the executable bit to align its file mode with
the rest of the files.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2021-06-14 11:28:01 -04:00
Electron Bot
0b10c865d3
Bump v15.0.0-nightly.20210614
2021-06-14 06:01:21 -07:00
David Sanders
8d76b4ded1
chore: use consistent integer type for request ID ( #29540 )
2021-06-14 21:01:36 +09:00
Darshan Sen
4b9e804b82
refactor: use locale functions in command_line_args.cc ( #29550 )
...
This change refactors the code to use isalpha() and
isspace() so that the code is more readable.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
2021-06-14 21:01:00 +09:00
Jeremy Rose
34a4e26b24
fix: check DCHECK_IS_ON() instead of #ifdef DCHECK_IS_ON ( #29620 )
2021-06-14 11:06:09 +09:00
David Sanders
fed5ad5303
fix: use correct spelling of attachment with Content-Disposition header ( #29621 )
2021-06-14 11:05:16 +09:00
David Sanders
f6d673c32a
chore: use HTTP method constants ( #29650 )
2021-06-14 11:04:36 +09:00
David Sanders
e8c9a814d6
fix: copy received data in URLPipeLoader to prevent corruption ( #29567 )
2021-06-14 10:18:52 +09:00
Electron Bot
af7181b93f
Bump v15.0.0-nightly.20210611
2021-06-11 06:01:09 -07:00
Darshan Sen
9b99bdb570
docs: fix image links in performance.md ( #29592 )
...
* docs: fix image links in performance.md
Fixes https://github.com/electron/electron/issues/29580
Signed-off-by: Darshan Sen <raisinten@gmail.com >
* Apply suggestions from code review
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-10 12:44:04 -05:00
Electron Bot
057b15f7bb
Bump v15.0.0-nightly.20210610
2021-06-10 06:01:21 -07:00
Shelley Vohr
63cc82d91d
fix: ensure custom traffic lights float to top ( #29595 )
...
* fix: ensure custom traffic lights float to top
* chore: split into separate function
2021-06-10 14:52:23 +02:00
Samuel Attard
73266f8f3d
fix: ensure fuse order is read in a stable way ( #29599 )
2021-06-09 08:30:02 -07:00
Electron Bot
5f2e25b0b2
Bump v15.0.0-nightly.20210609
2021-06-09 08:29:41 -07:00
Samuel Attard
fa0323a3db
fix: Revert "fix: don't propagate GDK_BACKEND to subprocs ( #28898 )" ( #29610 )
...
This reverts commit 7b169c2884 .
2021-06-09 08:28:52 -07:00
Samuel Attard
c252deb878
Revert "Bump v15.0.0-nightly.20210609"
...
This reverts commit c9ccd136a8 .
2021-06-09 08:28:12 -07:00
John Kleinschmidt
396ea4b29c
fix: select-bluetooth-device on Windows ( #29591 )
2021-06-09 10:48:18 -04:00
Electron Bot
c9ccd136a8
Bump v15.0.0-nightly.20210609
2021-06-09 06:01:09 -07:00
electron-roller[bot]
04679121d6
chore: bump chromium to 93.0.4536.0 (main) ( #29586 )
...
* chore: bump chromium in DEPS to 93.0.4536.0
* chore: update patches
* [2918475] Make InkDrop a View class property
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918475
Replace old views::Button::ink_drop() calls with views::InkDrop::Get()
* [2935942] Convert use of gfx::ImageSkia to ui::ImageModel for WidgetDelegates
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2935942
Update GetWindowIcon(), GetWindowAppIcon(), and GetDevToolsWindowIcon()
to return ui::ImageModel instead of gfx::ImageSkia.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-06-08 15:22:43 -05:00
Shelley Vohr
7b169c2884
fix: don't propagate GDK_BACKEND to subprocs ( #28898 )
2021-06-08 16:10:27 +02:00
Electron Bot
b27c5b94f7
Bump v15.0.0-nightly.20210608
2021-06-08 06:00:58 -07:00
ZReC
330b7849a3
docs: fix typo ( #29553 )
...
* Typo fix
* Update main.js
2021-06-08 11:45:45 +09:00
John Kleinschmidt
556c91a989
ci: save artifacts before cleaning up big things on macOS ( #29578 )
2021-06-07 22:02:21 -04:00
Samuel Attard
8446ce1fc7
feat: add new imageAnimationPolicy webpref and webContents setter ( #29095 )
2021-06-08 11:00:22 +09:00
David Sanders
79cb5144ae
chore: use std::make_unique/base::MakeRefCounted when possible ( #29510 )
2021-06-08 11:00:05 +09:00
Shelley Vohr
a4decffe9a
fix: improper wrapping of fs.promises.readFile ( #29528 )
2021-06-07 21:19:39 +02:00
electron-roller[bot]
5665738ceb
chore: bump chromium to 93.0.4535.0 (main) ( #29549 )
...
* chore: bump chromium in DEPS to 93.0.4533.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4534.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4535.0
* chore: remove PdfViewerDocumentProperties from feature-flag conditional
https://chromium-review.googlesource.com/c/chromium/src/+/2938363
This feature is now enabled by default upstream.
* chore: remove kPdfViewerPresentationMode from feature-flag conditional
https://chromium-review.googlesource.com/c/chromium/src/+/2938037
This feature is now enabled by default upstream.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-06-07 14:09:41 -05:00
Samuel Attard
c48ec133a5
build: remove individual release build workflows ( #29344 )
...
* build: remove individual release build workflows
* build: ensure even builds we do not want to run have at least one step
2021-06-07 10:17:27 -04:00
David Sanders
070f25db54
fix: make intermediates work with 'select-client-certificate' ( #29552 )
2021-06-07 06:40:43 -07:00
Electron Bot
c5b0ba0c01
Bump v15.0.0-nightly.20210607
2021-06-07 06:02:04 -07:00
Jeremy Foster
fc10b53f95
docs: Update notifications (renderer) docs ( #29267 )
...
* remove version information from html
* change format for readability
* clarify which console the message should appear in
* minor changes to renderer.md
* update UI on click instead of developer console
* remove node-integration and fix md
* update content
* chore: remove ****
Co-authored-by: Ethan Arrowood <ethan.arrowood@gmail.com >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
2021-06-07 13:02:20 +09:00
Kevin Hartman
dd98fa3cd3
docs: Updated "recent documents" fiddle tutorial ( #29242 )
...
* Port recent-documents fiddle to 12-x-y.
* Update recent-documents tutorial.
* update for review comments
Co-authored-by: Ethan Arrowood <ethan.arrowood@gmail.com >
2021-06-07 10:43:24 +09:00
David Sanders
1a30f9f974
chore: update base class name in comment ( #29512 )
2021-06-07 10:18:17 +09:00
electron-roller[bot]
fa2db00e55
chore: bump chromium to 93.0.4532.2 (main) ( #29527 )
...
* chore: bump chromium in DEPS to 93.0.4531.0
* chore: update patches
* Remove IPC::Listener from WebContentsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/2910240
* serial: Move serial policy from profile to local state
https://chromium-review.googlesource.com/c/chromium/src/+/2914194
* chore: fix pip test
* chore: bump chromium in DEPS to 93.0.4532.2
* chore: update patches
* Follow up ColorChooser clean ups
https://chromium-review.googlesource.com/c/chromium/src/+/2928026
* Distinguish between no default printer vs. query error
https://chromium-review.googlesource.com/c/chromium/src/+/2932396
* chore: remove build_do_not_include_vr_directx_helpers_when_enable_vr.patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-06-04 19:03:31 -07:00
Electron Bot
1c0e8a65c4
Bump v15.0.0-nightly.20210604
2021-06-04 06:01:20 -07:00
David Sanders
79ae8b427c
chore: return early on promise rejection ( #29279 )
2021-06-04 13:21:02 +09:00
David Sanders
8e1176cbc0
chore: pull ProxyingURLLoaderFactory closer to upstream class it mirrors ( #29486 )
...
* chore: pull ProxyingURLLoaderFactory closer to upstream class it mirrors
* chore: add another change which was accepted upstream
2021-06-04 13:18:02 +09:00
David Sanders
81c5da5221
chore: use =default for default constructors/destructors ( #29511 )
2021-06-04 13:16:13 +09:00
David Sanders
b1d1ac6524
fix: change ASAR archive cache to per-process to fix leak ( #29293 )
...
* fix: change ASAR archive cache to per-process to fix leak (#29292 )
* chore: address code review comments
* chore: tighten up thread-safety
* chore: better address code review comments
* chore: more code review changes
2021-06-04 10:49:08 +09:00
Milan Burda
00693bab30
refactor: use auto env = base::Environment::Create(); everywhere ( #29502 )
2021-06-04 09:23:06 +09:00
Electron Bot
5929d6335f
Bump v15.0.0-nightly.20210603
2021-06-03 09:50:54 -07:00
Jeremy Rose
b79fc79a01
docs: remove devDependencies badge from README ( #29499 )
2021-06-03 09:44:48 -07:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08f
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-06-03 01:05:04 -07:00
Milan Burda
8d0ed05c99
refactor: replace a few usages of V8 hidden properties ( #29400 )
2021-06-03 14:59:56 +09:00
David Sanders
bb6903543c
docs: link to IncomingMessage ( #29457 )
2021-06-03 14:54:33 +09:00
Juan Cruz Viotti
d6d9a6a039
build: Improve squirrel.mac BUILD.gn xcrun_action error ( #29448 )
...
Right now, if executing `xcrun` fails, then the error message prints the
second argument to the `xcrun.py` script, which is the first argument to
the tool that `xcrun` is executing, making the whole error message quite
confusing.
Consider the following error:
```
python ../../third_party/squirrel.mac/build/xcrun.py dtrace -h -s /private/tmp/20210531211008-def376dc/src/third_party/squirrel.mac/vendor/ReactiveObjC/ReactiveObjC/RACSignalProvider.d -o /private/tmp/20210531211008-def376dc/src/out/release/gen/third_party/squirrel.mac/dtrace/RACSignalProvider.h
xcrun script '-h' failed with code '71':
xcrun: error: can't exec '/tmp/20210531211008-def376dc/dtrace' (errno=Permission denied)
```
The command that `xcrun` is executing is `dtrace`, but the error just
mentions the `-h` flag.
Notes: none
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2021-06-03 14:54:16 +09:00
Milan Burda
8040cb788f
test: add spec for --require filtering in NODE_OPTIONS ( #29501 )
2021-06-03 14:46:44 +09:00
Keeley Hammond
d8d6e2ebc0
build: update support.md on stable version bumps ( #29381 )
...
* build: update support.md on stable version bumps
* build: update supported on major stable & nightly bumps
* test: updateSupported tests
* chore: fix syntax
* chore: use fspromise in version-bumper script/spec
2021-06-02 12:53:23 -07:00
Jeremy Rose
8ce63a9f18
refactor: point prepare-release at main ( #29394 )
2021-06-02 12:21:20 -07:00
Milan Burda
44491b023a
refactor: eliminate duplicate C++ / JavaScript implementation of app.isPackaged ( #29464 )
2021-06-02 12:17:08 -07:00
Electron Bot
f0d3e1d1cf
Bump v15.0.0-nightly.20210602
2021-06-02 06:03:17 -07:00
David Sanders
97fde6dc9c
build: fix macOS build ( #29484 )
2021-06-02 19:42:07 +09:00
Cheng Zhao
3cfe5c6a21
fix: keep shifted character in menu accelerator ( #29202 )
...
* fix: correctly handle shifted char in accelerator
* test: use actual accelerator of NSMenuItem
* chore: simplify KeyboardCodeFromStr
* chore: GetAcceleratorTextAt is testing only
2021-06-02 16:32:48 +09:00
David Sanders
31190d4c6d
chore: use static_cast rather than C-style cast ( #29467 )
2021-06-02 00:32:10 -07:00
David Sanders
cb59bab8cf
chore: don't use after move ( #29468 )
2021-06-02 00:31:25 -07:00
Juan Cruz Viotti
f9213faec5
build: support building Electron on msys2 ( #29449 )
...
Electron already seems to support `cygwin`, so `msys` is a natural
addition. This is the only required change as far as I can see on my
local development environment, as otherwise the build scripts don't
realize that msys = windows.
Notes: none
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com >
2021-06-02 16:29:19 +09:00
Shelley Vohr
d6109b2eb4
chore: remove unused methods ( #29438 )
2021-06-02 16:27:45 +09:00
Sergio Padrino
abf6f5c8ba
feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM ( #29168 )
...
* feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM
* docs: add documentation for the new runningUnderARM64Translation property
* refactor: clean up `IsRunningUnderARM64Translation` Windows implementation
* Return false if IsWow64Process2 doesn't exist
* Emit deprecation warning in runningUnderRosettaTranslation
2021-06-02 16:16:33 +09:00
Shelley Vohr
3b75549511
fix: inspector context menu throwing an error ( #29436 )
2021-06-01 20:39:48 -07:00
Jeremy Foster
dee4c4b908
docs: Updated "progress bar" fiddle feature in docs ( #29237 )
...
* improve progress bar fiddle
* add comments to code snippet
* edits to progress-bar tutorial
* remove versions and nodeIntegration
* limit line length to 100
* implement standard linter suggestions
* add indeterminate and clear timers
* update to have reader replace all of main.js
* remove extra button
* loop the progress bar
* add logic to show reset state briefly
* Update docs/tutorial/progress-bar.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* chore: fix lint
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-06-02 11:41:13 +09:00
Samuel Maddock
f9d2a7077e
feat: include resize edge with will-resize event ( #29199 )
...
* feat: emit resize edge with will-resize event
fix: wparam type
fix: private member usage on mac
docs: will-resize event edge option
refactor: 'info' -> 'details' for better type gen
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-06-02 11:37:10 +09:00
Jeremy Rose
750a762bf0
feat: support loading debug urls with loadURL() ( #29404 )
2021-06-01 17:17:15 -07:00
Electron Bot
fa703016f0
Bump v15.0.0-nightly.20210601
2021-06-01 06:02:35 -07:00
David Sanders
a1a649c0d6
chore: remove duplicate option get for CustomScheme ( #29422 )
2021-06-01 17:47:12 +09:00
Cheng Zhao
0444d74830
fix: Alt+Click should not toggle menu bar ( #29318 )
2021-06-01 17:42:47 +09:00
Pete Torres
19dce8caa5
docs: adjust markdown link syntax in introduction.md ( #29426 )
...
Co-authored-by: peteness <hello@peteness.org >
2021-06-01 09:32:50 +02:00
David Sanders
80a039ec40
chore: move destructors to header so they can be trivially destructible ( #29379 )
2021-05-31 21:00:09 -07:00
Cheng Zhao
d74ad51826
fix: correctly handle Alt+Key shortcuts ( #29328 )
2021-06-01 10:48:52 +09:00
David Sanders
0208e4adad
chore: use HTTP status code constants ( #29378 )
2021-06-01 10:47:53 +09:00
David Sanders
ba26580f23
chore: use consistent parameter names ( #29361 )
2021-06-01 10:46:25 +09:00
David Sanders
d18dbdd72b
fix: add service worker schemes from command line in renderer ( #29425 )
2021-06-01 10:45:23 +09:00
David Sanders
038359a7d8
chore: fix typos in comments ( #29401 )
2021-06-01 10:42:38 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
Samuel Attard
71fff6ea0e
build: merge chromedriver gen and build ( #29439 )
2021-05-31 16:20:40 -07:00
Electron Bot
73adee6d53
Bump v15.0.0-nightly.20210531
2021-05-31 06:05:57 -07:00
dependabot[bot]
646b79470a
build(deps-dev): bump ws from 6.2.1 to 7.4.6 in /spec ( #29416 )
...
Bumps [ws](https://github.com/websockets/ws ) from 6.2.1 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/6.2.1...7.4.6 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-31 11:53:07 +02:00
Vishal
049d81e590
docs: fix issue with reference links ( #29384 )
2021-05-31 11:52:44 +02:00
Jeremy Rose
95bb0ba001
fix: use default_branch in release-notes ( #29415 )
2021-05-30 17:22:33 -07:00
Jeremy Rose
750ebfdbca
refactor: use main in release-notes ( #29395 )
2021-05-28 12:14:50 -07:00
Jeremy Rose
a61f1446bc
refactor: publish-to-npm respects main ( #29375 )
2021-05-28 12:13:12 -07:00
Electron Bot
221d4abca4
Bump v15.0.0-nightly.20210528
2021-05-28 06:01:45 -07:00
David Sanders
bedd587784
docs: update link to Chromium's coding style guide ( #29330 )
2021-05-27 19:07:46 -07:00
Jeremy Rose
1373a030b4
refactor: version-utils respects main ( #29374 )
2021-05-27 17:32:37 -07:00
Jeremy Rose
f664f37793
refactor: getCurrentBranch respects main ( #29369 )
2021-05-27 17:32:16 -07:00
Jeremy Rose
f3dff819fc
docs: remove freenode channel from support list ( #29370 )
2021-05-27 15:53:39 -07:00
David Sanders
d80e36bcdb
chore: simplify WrappableBase::SecondWeakCallback ( #29359 )
2021-05-27 13:15:25 -07:00
David Sanders
9bb7051f54
chore: prefer empty() check for readability ( #29360 )
2021-05-27 13:08:30 -07:00
David Sanders
77ecc7d432
chore: fix typos in comments ( #29362 )
2021-05-27 11:48:03 -07:00
aydon
9fcdb06272
Update quick-start.md ( #29333 )
...
In version 13.0.1 preload process should added to webPreferences.
2021-05-27 11:46:32 -07:00
Electron Bot
cc93b8acc0
Bump v15.0.0-nightly.20210527
2021-05-27 11:06:31 -07:00
Jeremy Foster
5e033cb7f8
docs: Update notifications (main) docs ( #29268 )
...
* remove version info from index.html page
* remove nodeIntegration
* format code and update readme
* add note to user in index.html
2021-05-27 10:18:50 +09:00
David Sanders
36bca3278d
docs: fix typos in clang-tidy examples ( #29327 )
2021-05-27 09:45:37 +09:00
Erick Zhao
bb26060564
docs: fix link to docs/fiddle/quick-start ( #29325 )
2021-05-27 09:45:23 +09:00
Cheng Zhao
acce13234e
fix: close autoHide menu bar when focus is lost ( #29320 )
2021-05-27 09:36:15 +09:00
George Xu
386572bb86
Chore: update Windows build instructions ( #29342 )
...
update "Change" to "Modify" to reflect the actual options the user sees when opening visual studio installer
2021-05-26 14:19:43 -07:00
Samuel Attard
7984933e9c
feat: add experimental cookie encryption support ( #27524 )
...
* feat: add experimental cookie encryption support on macOS
* chore: fix TODO
* update patches
* feat: make cookie encryption work on windows
* chore: update cookie encryption support comments
* fix: only call OSCrypt::Init on windows
* chore: make cookie encryption work on linux
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: fix lint
* chore: update patches
* chore: update patches to upstreamed variants
* chore: use chrome ::switches constants
* chore: remove bad patch
* build: disable cookie encryption by default
* chore: update patches
* fix: provide std::string to NoDestructor
* chore: fix macos, nodestructor syntax
* build: fix macOS build due to mismatch in DEFINE
Co-authored-by: Electron Bot <electron@github.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-26 12:16:55 -07:00
Samuel Attard
f01e35f4ea
feat: add support for Blob's going over the ctx bridge ( #29247 )
2021-05-26 10:34:29 -07:00