Compare commits

...

8332 Commits

Author SHA1 Message Date
Kevin Sawicki
0428632a4e Bump v1.6.11 2017-05-25 10:56:30 -07:00
Kevin Sawicki
855d2c4b20 Merge pull request #9586 from electron/upgrade-libcc
Upgrade libcc with 1.6.x fixes
2017-05-25 10:55:25 -07:00
Kevin Sawicki
f0402be869 Enable verbose bootstrap on CI 2017-05-25 10:25:51 -07:00
Kevin Sawicki
5a1e3fc0f3 Upgrade to electron/libchromiumcontent@e2ec6935 2017-05-25 09:51:16 -07:00
Kevin Sawicki
01c31ee924 Merge pull request #9564 from rreimann/pdf-plugins-preference-backport
Backport suppress dispatching to PDF viewer if plugins are disabled to 1.6.x
2017-05-24 09:04:33 -07:00
rreimann
c29316b568 Remove superfluous method 2017-05-24 07:09:51 +02:00
Kevin Sawicki
21f15fa87e Delete mock.pdf after download completes
(cherry picked from commit 647e88da5a)
2017-05-23 14:22:26 +02:00
rreimann
ab95ecda42 Fix naming and formatting
(cherry picked from commit 25015c4c63)
2017-05-23 14:22:08 +02:00
rreimann
456e83f286 Extract common code into IsPreferenceEnabled method
(cherry picked from commit 791486433d)
2017-05-23 14:21:53 +02:00
rreimann
1612ebc539 Move preferences check to OnPdfResourceIntercepted
(cherry picked from commit 65da983ccb)
2017-05-23 14:21:35 +02:00
rreimann
1ddb8a8bf1 Add new test and enable plugins for existing tests
(cherry picked from commit 13665090d5)
2017-05-23 14:21:09 +02:00
rreimann
bbcdbc2e7c Fix linting violations
(cherry picked from commit 7982754958)
2017-05-23 14:20:41 +02:00
rreimann
d94bbd1573 Suppress pdf plugin dispatch if plugins are disabled
(cherry picked from commit 1b75e45a62)
2017-05-23 14:20:00 +02:00
Kevin Sawicki
583e14efcd Merge pull request #9514 from electron/disable-crash-specs-on-linux
Backport disabling crash specs on linux to 1.6
2017-05-17 15:25:14 -07:00
Kevin Sawicki
b96803e3a0 Disable crashReporter specs on Linux CI 2017-05-17 15:00:39 -07:00
Kevin Sawicki
c03cb11aaf Merge pull request #9505 from electron/backport-sandbox-remote-exception-fix
Backport sandbox remote exception fix
2017-05-17 11:19:25 -07:00
Kevin Sawicki
5de881e668 Merge pull request #9499 from electron/node-cert-patch
Upgrade node for StartCom/WoSign cert rejection
2017-05-17 11:07:21 -07:00
Thiago de Arruda
964505398d Add test for #9387 2017-05-17 07:29:22 -03:00
Thiago de Arruda
16f2958ad7 Fix how rpc-server releases references after page reload
In addition to listening for "render-view-deleted", listen for
"ELECTRON_BROWSER_CONTEXT_RELEASE" synchronous message, which is sent by the
remote module when the page is about to be navigated.

This is required to allow child windows running in the same renderer to
correctly manage remote object references, since `render-view-deleted` is only
called when the renderer exits.

Close #9387
2017-05-17 07:29:06 -03:00
Kevin Sawicki
332b92ebab Upgrade node for StartCom/WoSign cert rejection 2017-05-16 16:29:43 -07:00
Kevin Sawicki
b9f66a342c Bump v1.6.10 2017-05-16 10:38:35 -07:00
Kevin Sawicki
23ce796450 Merge pull request #9484 from electron/1-6-x-typescript-backport
backport electron.d.ts fixes 1.6
2017-05-16 10:15:29 -07:00
Samuel Attard
df6d316dc2 Fix webcontents capital 2017-05-15 15:16:22 -07:00
Kevin Sawicki
82a93ce645 Correct property name to pid 2017-05-15 14:19:02 -07:00
Kevin Sawicki
5ceaca66f5 fix setAutoResize options 2017-05-15 14:18:44 -07:00
Kevin Sawicki
4c0e35776b fix setAutoResize options 2017-05-15 14:18:02 -07:00
Birunthan Mohanathas
cc1f213d84 bump versions of electron-docs-linter and electron-typescript-definitions 2017-05-15 14:04:22 -07:00
Birunthan Mohanathas
4c18037e6a Fix copy paste typos in BrowserView docs 2017-05-15 14:02:05 -07:00
Samuel Attard
7f0ccdadcd Fix createFromDataURL return type
Fixes #9469
2017-05-15 14:02:00 -07:00
Birunthan Mohanathas
8ac9499b45 Make docs for webview.findInPage and webContents.findInPage consistent 2017-05-15 14:01:55 -07:00
Birunthan Mohanathas
8094d68acc Fix postData type definition in docs 2017-05-15 14:01:50 -07:00
Samuel Attard
80066c22b2 Fix return type of makeSingleInstance 2017-05-15 14:01:45 -07:00
Zeke Sikelianos
8f78f3b253 add npm scripts for convenience 2017-05-15 14:01:34 -07:00
Kevin Sawicki
f0c38b7354 Bump v1.6.9 2017-05-10 08:35:30 -07:00
Zeke Sikelianos
7145aef02c Merge pull request #9415 from electron/no-more-tslint
let the typescript module do its own linting
2017-05-09 16:52:38 -07:00
Zeke Sikelianos
9b82d1a996 let the typescript module do its own linting 2017-05-09 15:44:25 -07:00
Kevin Sawicki
8c856922f3 Merge pull request #9292 from 22222/issue8911
Fix #8911
2017-05-09 09:06:26 -07:00
Kevin Sawicki
aa212bd955 Merge pull request #9408 from Hum4n01d/patch-1
Fix order of OSs
2017-05-09 08:57:03 -07:00
Zeke Sikelianos
08dc66c9aa Merge pull request #9388 from electron/use-tslint-config
use tsconfig file when linting electron.d.ts
2017-05-08 15:42:09 -07:00
Hum4n01d
a694110d48 Fix order of OSs
It was previously inconsistent
2017-05-08 13:36:28 -07:00
Kevin Sawicki
dd84fd4348 Merge pull request #9400 from brianzelip/patch-1
📝 minor docs copy edit - add two words
2017-05-08 08:57:50 -07:00
Brian Zelip
68c19fc509 📝 minor docs copy edit - add two words
[ci skip]
2017-05-07 11:06:46 -04:00
Kevin Sawicki
b712521056 Merge pull request #9381 from electron/cpu-usage-fix
CPU Usage requires process metrics to be preserved
2017-05-05 16:03:26 -07:00
Zeke Sikelianos
f228809317 fix the tslint.json path 2017-05-05 15:00:29 -07:00
Zeke Sikelianos
d4d1409e6f use tsconfig file when linting electron.d.ts 2017-05-05 13:52:14 -07:00
Zeke Sikelianos
0a941fe2f5 Merge pull request #9385 from LestaD/patch-1
Add Russian Telegram community
2017-05-05 10:34:06 -07:00
Sergey Sova
888b2d6bd1 Add Russian Telegram community 2017-05-05 19:34:53 +03:00
Zeke Sikelianos
7d7a2d9319 Merge pull request #7857 from electron/publish-electron.d.ts
Initial scripts to publish electron.d.ts
2017-05-05 08:31:00 -07:00
Zeke Sikelianos
c46b70c68d Merge pull request #9383 from johangp/patch-1
Is Google Chrome an open source browser?
2017-05-05 08:11:48 -07:00
Johan Giraldo
39d7981624 Is Google Chrome an open source browser?
Google Chrome isn't an open source project. Chromium is an open source project, so I think that is more precise say "and is used in Chromium, the open source browser from Google" or something like these.
2017-05-05 13:49:38 +02:00
Hari Krishna Reddy Juturu
d65c4fe912 CPU Usage requires process metrics to be preserved 2017-05-05 02:38:51 -07:00
Kevin Sawicki
6980e92a00 Merge pull request #8998 from electron/felix-notification-docs
Improve notification docs
2017-05-04 15:31:12 -07:00
Kevin Sawicki
70033009eb Merge pull request #9373 from electron/process-metrics
Adding CPU and I/O metrics to process module
2017-05-04 15:30:19 -07:00
Hari Krishna Reddy Juturu
07d8dfaa53 Fixing UT 2017-05-04 14:50:06 -07:00
Hari Krishna Reddy Juturu
6b51c25820 Exposing cpu & io counters function similar to mem methods 2017-05-04 14:48:37 -07:00
Hari Krishna Reddy Juturu
472dad1ffc convert var to const 2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
982c5064d8 Removing extra bool 2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
656fb593b4 Fixing lint error 2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
8bc4d3f8bd GetIOCounters is not implemented on mac 2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
3c71f542a8 Fixing UT on mac 2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
8a5aa04756 Adding CPU and I/O metrics to process module 2017-05-04 14:33:59 -07:00
Kevin Sawicki
70e199e255 Merge pull request #9333 from electron/process-memory-info-sandbox
Expose `process.get{System,Process}MemoryInfo` to sandbox
2017-05-04 14:17:44 -07:00
Kevin Sawicki
eebae82bc1 Merge pull request #9315 from electron/segmented-control-mode
Add mode prop to segmented touch bar control
2017-05-04 14:16:28 -07:00
Kevin Sawicki
01b3db3d2f 🎨 2017-05-04 14:15:48 -07:00
Kevin Sawicki
1e4b99bd7f Merge pull request #9338 from mcizol/master
add auto-invite for turkish community(en-readme)
2017-05-04 14:14:22 -07:00
Kevin Sawicki
59511354fd Merge pull request #9214 from electron/app-memoryinfo
API to get memory of all processes of the app
2017-05-04 14:00:30 -07:00
Kevin Sawicki
3b3e7cc14e Assert memory info for all returned processes 2017-05-04 13:43:45 -07:00
Hari Krishna Reddy Juturu
ab1bcefe9e Make pid an integer 2017-05-04 13:37:43 -07:00
Kevin Sawicki
edd28c9a91 Link to MemoryInfo structure 2017-05-04 13:35:12 -07:00
Kevin Sawicki
e206aae9fc 🎨 Use snake case 2017-05-04 13:27:42 -07:00
Kevin Sawicki
76c15a7a3e Merge pull request #9348 from tsekityam/patch-1
Change translation of `license` to `授權條款`
2017-05-04 11:32:12 -07:00
Kevin Sawicki
0343db53ad Merge pull request #9344 from rafbm/patch-1
Use actual Chromium l10n_util list in locales.md
2017-05-04 11:31:31 -07:00
Kevin Sawicki
c59fab0179 Merge pull request #9242 from shiftkey/certificate-addition-windows
certificate trust API for Windows
2017-05-03 16:39:00 -07:00
Kevin Sawicki
110611f242 🎨 2017-05-03 16:22:56 -07:00
22222
042b511a27 Fix #8911 2017-05-03 12:47:00 -05:00
Samuel Attard
718dc732ad Add docs and add isSelected arg 2017-05-03 20:25:50 +10:00
Zeke Sikelianos
7956d63e99 tslint electron.d.ts 2017-05-02 16:31:46 -07:00
Kevin Sawicki
96ca623846 Merge pull request #9353 from kainjow/patch-1
Add missing word
2017-05-02 09:08:06 -07:00
Kevin Wojniak
342a8fd577 Add missing word 2017-05-02 09:05:07 -07:00
Tse Kit Yam
58c3446e40 Change translation of license to 授權條款
The translation of `license` should not be `憑證`.
`憑證` means certificate but not license in Chinese.

For example, [Symantec](https://www.symantec.com/zh/tw/security_response/glossary/define.jsp?letter=d&word=digital-certificate) translated `digital certificate` as `數位憑證`; [Chrome Support](https://support.google.com/chrome/a/answer/3505249?hl=zh-Hant) used the teams `憑證授權單位` and `SSL 憑證` to describe `CA` and `SSL Certificate`. These are all proving that the word `憑證` is commonly used in the translation of `certificate`, but not `license`

I googled for a while, and found that the team `授權條款` is commonly used to describe `license` in Traditional Chinese. The user of the translation `授權條款` includes governments ([Taiwan Government](https://www.tipo.gov.tw/ct.asp?xItem=365132&ctNode=6885&mp=1), [Hong Kong government](http://www1.itfest.gov.hk/sc/event/supplements/0415_BIP_Asia_Seminar_Series_%28eDM%29.pdf)), communities ([Open Source Hong Kong](https://freehkfonts.opensource.hk/download/) and [OpenFoundry](https://www.openfoundry.org/of/download/openlegal/Analyses_and_applying_policies_of_FOSS_licenses_2parts_2/20131118_d.pdf)), and businesses ([Google](https://www.google.com/intl/zh-TW/chromebook/termsofservice.html)).

So I suggest we should use `授權條款`, which has been widely adopted  as translation of `license`, instead of a wrong translation `憑證`.
2017-05-02 17:59:15 +08:00
Brendan Forster
e5648072dc handle untrusted root as well as self-signed 2017-05-02 11:25:51 +10:00
Zeke Sikelianos
b9e6b188f7 🎨 2017-05-01 16:00:25 -07:00
Zeke Sikelianos
52d6e53001 preserve 46823f9 2017-05-01 15:59:00 -07:00
Zeke "Offline in April" Sikelianos
9fd1e2c8c4 Merge branch 'master' into felix-notification-docs 2017-05-01 15:56:14 -07:00
Kevin Sawicki
a748199833 Bump v1.6.8 2017-05-01 15:09:30 -07:00
Rafael Masson
410078bb54 Use actual Chromium l10n_util list in locales.md
I’m not sure where the locale list from the [original commit](bbaab9b355) came from, but it clearly wasn’t copied from `l10n_util`. It was missing Spanish, Portuguese, Polish, Vietnamese, to name a few…

This commit overwrite the whole list with [`l10n_util` as-is](61cfc2b0a8/ui/base/l10n/l10n_util.cc (L41-L175)).
2017-05-01 17:15:37 -04:00
Kevin Sawicki
98d17d64ef Merge pull request #9322 from electron/debugger-json-crash
Parse debugger protocol messages using v8 JSON parser
2017-05-01 10:44:14 -07:00
Kevin Sawicki
b639dd0c81 Remove unused include/require statement 2017-05-01 10:30:11 -07:00
Kevin Sawicki
f2f6415543 Use v8 to parse message as JSON 2017-05-01 10:30:11 -07:00
Kevin Sawicki
db6097ecec Add failing spec for invalid debugger message 2017-05-01 10:30:11 -07:00
Kevin Sawicki
f84c75aa1a Merge pull request #9301 from electron/post-message-origin-check
Use isSameOrigin helper when checking postMessage targetOrigin
2017-05-01 08:57:56 -07:00
Kevin Sawicki
56a4a69dee Add more non-matching target origins 2017-05-01 08:45:38 -07:00
Kevin Sawicki
efc62629ef Fix typo in fixture comment 2017-05-01 08:45:38 -07:00
Kevin Sawicki
fa4ec11a12 Use isSameOrigin helper when posting message 2017-05-01 08:45:38 -07:00
Kevin Sawicki
3c58d50f87 Add failing spec for targetOrigin handling 2017-05-01 08:45:38 -07:00
Thiago de Arruda
a8640fb8a3 Add test to verify memory is released after sandboxed popup is closed 2017-05-01 11:30:07 -03:00
Mustafa C. Izol
416cfeed40 update turkish community link 2017-05-01 15:44:39 +02:00
Mustafa C. Izol
1a2aaecd4b add auto-invite for turkish community(en-readme) 2017-05-01 15:33:25 +02:00
Thiago de Arruda
bbe21cce67 Expose more atom_bindings.cc functions to sandbox 2017-05-01 09:12:39 -03:00
Cheng Zhao
9e0c308b09 Merge pull request #9113 from electron/window_close_patch
browser: make destruction of webContents async
2017-05-01 17:45:58 +09:00
deepak1556
0476e2fd3d destroy browserView webContents asynchronously 2017-05-01 16:53:55 +09:00
deepak1556
c68f41b8d8 destroy new window webContents asynchronously 2017-05-01 16:53:55 +09:00
deepak1556
5e976be43b remove page-title-updated workaround for #3380 2017-05-01 16:53:55 +09:00
deepak1556
e4524ce42e add spec 2017-05-01 16:53:55 +09:00
deepak1556
9e3b8ade12 invoke WebContentsDestroyed manually when destruction path is async 2017-05-01 16:53:14 +09:00
deepak1556
f974a6bda9 browser: make destruction of webContents async 2017-05-01 16:53:14 +09:00
Cheng Zhao
ca7ca3ba1c Merge pull request #9314 from electron/fix-windowopen-memory-leak
Fix context leak in ObjectLifeMonitor.
2017-05-01 15:49:13 +09:00
Brendan Forster
541efc3b93 tidy up docs 2017-04-29 19:35:49 +10:00
Brendan Forster
14f29e1319 it's 2017 get with the times 2017-04-29 19:29:07 +10:00
Brendan Forster
1ccc2afb03 underscore case all the things 2017-04-29 19:28:42 +10:00
Thiago de Arruda
19b6ba044b Fix context leak in ObjectLifeMonitor.
The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with `window.open`.

Close #9191
2017-04-28 11:21:53 -03:00
Samuel Attard
225ccab3d2 Add mode prop to segmented touch bar control 2017-04-28 14:50:58 +10:00
Hari Krishna Reddy Juturu
07b53c0284 Return mate::Dictionary instead of v8::value 2017-04-27 21:07:35 -07:00
Kevin Sawicki
79b02ca71e Merge pull request #9310 from neilstuartcraig/patch-1
Show how to run the example in touch-bar.md
2017-04-27 14:23:13 -07:00
Kevin Sawicki
c26605c384 Minor edits to example guide 2017-04-27 14:22:56 -07:00
HariJ
88ad28b2a5 Removing describe.only 2017-04-27 14:06:53 -07:00
HariJ
81bd9fa3a2 fixing mac ut failure 2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
3d12440a4a Fixing mac build 2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
d77c1319f4 Fixing lint error 2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
27aad902b8 Adding docs, specs and fixing object returned 2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
bef7d5a520 API to get memory of all processes of the app 2017-04-27 14:06:53 -07:00
Neil Craig
c0669cb46e Update touch-bar.md
Add a simple example of running the example code as it might not be obvious to people who've not used Electron. Hopefully it makes sense :-)
2017-04-27 20:19:17 +01:00
Brendan Forster
5534181ebd rework docs 2017-04-27 15:12:30 +10:00
Brendan Forster
a1599cf881 focus on the self-signed certificate flow here 2017-04-27 15:06:23 +10:00
Brendan Forster
5151107c28 tighten up indenting 2017-04-27 15:01:55 +10:00
Brendan Forster
50af70a0e8 Merge branch 'master' into certificate-addition-windows 2017-04-27 14:47:50 +10:00
Brendan Forster
80212c0ab4 actually validate the chain before adding 2017-04-27 14:44:58 +10:00
Kevin Sawicki
dafd0b6c3c Merge pull request #9299 from electron/menu-item-doc-typos
Fix typos in MenuItem docs
2017-04-26 13:03:46 -07:00
Kevin Sawicki
f6bbcc6efa Fix typos 2017-04-26 13:03:15 -07:00
Kevin Sawicki
eabe7b9dce Merge pull request #9290 from electron/coerce-history-go-offset-to-number
Coerce window.history.go offset argument to number in renderer process
2017-04-26 13:02:53 -07:00
Kevin Sawicki
95ef422ab4 Coerce offset to number in renderer process 2017-04-26 12:37:16 -07:00
Kevin Sawicki
775753c3d7 Add spec for invalid window.history.go offset 2017-04-26 12:37:16 -07:00
Kevin Sawicki
8460a580b9 Merge pull request #9289 from electron/dont-allow-webpreferences-option-setting
Don't allow webPreferences to be overridden in features string
2017-04-26 12:36:51 -07:00
Kevin Sawicki
507f60e33e Don't allow webPreferences to be overrideden in features string 2017-04-26 10:56:53 -07:00
Kevin Sawicki
7726c7c6c4 Add spec for webPreferences in features string 2017-04-26 10:56:53 -07:00
Kevin Sawicki
0aa53f4af7 Merge pull request #9287 from electron/store-frames-to-guest-as-map
Store frames to guest as Map
2017-04-26 10:47:21 -07:00
Kevin Sawicki
91a1e5cdfe Store frame to guests in map 2017-04-26 10:14:11 -07:00
Kevin Sawicki
9643b2a5c5 Add specs for window.open frameName argument 2017-04-26 10:14:11 -07:00
Kevin Sawicki
b9b3abbeae Merge pull request #9286 from electron/to-string-renderer-errors
Throw string conversion errors in render process
2017-04-26 10:12:21 -07:00
Kevin Sawicki
2c48300daa Fix typos in comment 2017-04-26 09:09:42 -07:00
Kevin Sawicki
246937a372 Convert targetOrigin to string in render process 2017-04-26 09:08:47 -07:00
Kevin Sawicki
3894c1c625 Convert frameName/features to strings in render process 2017-04-26 09:08:47 -07:00
Kevin Sawicki
7e285711ca Add spec for window.open toString errors 2017-04-26 09:08:47 -07:00
Kevin Sawicki
4e7e9d1752 Merge pull request #9278 from electron/dont-override-argument-value
Disable node integration in chrome-devtools URLs
2017-04-26 09:08:24 -07:00
Kevin Sawicki
05b6d91bf4 Disable node integration in chrome-devtools: URLs 2017-04-25 13:36:08 -07:00
Kevin Sawicki
3f88eb2f86 Add spec for chrome-devtools URL with no node integration 2017-04-25 13:36:08 -07:00
Kevin Sawicki
c9ec45d9d8 Merge pull request #9250 from electron/inherit-javascript-option
Inherit javascript preference in opened windows
2017-04-25 13:33:53 -07:00
Kevin Sawicki
87db1b8aa7 Document other inherited web preferences 2017-04-25 12:57:53 -07:00
Kevin Sawicki
3e2a1034af Disable JavaScript on child when disabled on parent 2017-04-25 12:57:53 -07:00
Kevin Sawicki
cee0507090 Add failing spec for inheriting Javascript web preference 2017-04-25 12:57:53 -07:00
Kevin Sawicki
6ec74060b4 Enable setting javascript and contextIsolation via window.open 2017-04-25 12:57:53 -07:00
Kevin Sawicki
00a575c84a Merge pull request #9279 from electron/extract-default-app-script
Extract script tags to renderer.js file in default app
2017-04-25 12:55:58 -07:00
Kevin Sawicki
ca5a8b6166 Extract script tags to renderer.js file 2017-04-25 08:27:57 -07:00
Kevin Sawicki
7881376aff Merge pull request #9254 from electron/endsession-event
End session event on browser window
2017-04-24 12:02:05 -07:00
Hari Krishna Reddy Juturu
8458acff26 Removing #ifdef on endsession api 2017-04-24 11:58:08 -07:00
Hari Krishna Reddy Juturu
8a32826876 Removing #ifdef windows for endsession methods 2017-04-24 11:49:21 -07:00
Kevin Sawicki
b6192da757 Merge pull request #9255 from electron/emit-auto-updater-error
Emit auto updater error directly as Error
2017-04-24 10:26:00 -07:00
Hari Krishna Reddy Juturu
9e70372c1f change endsession event name to session-end 2017-04-24 10:16:11 -07:00
Kevin Sawicki
c2d4c93e12 Don't run error event on Linux 2017-04-24 09:47:30 -07:00
Kevin Sawicki
13e4582697 Emit autoUpdater error directly as Error object 2017-04-24 09:47:30 -07:00
Kevin Sawicki
423dd4d57a Add spec for remote autoUpdater error event 2017-04-24 09:47:30 -07:00
Kevin Sawicki
6c99d83b99 Merge pull request #9253 from electron/log-crashes-during-specs
Log all crashes during spec running
2017-04-24 09:47:05 -07:00
Kevin Sawicki
35a627fd60 Log all crashes during specs 2017-04-24 09:26:24 -07:00
Kevin Sawicki
2e223288d2 Merge pull request #9252 from electron/convert-to-string-in-render-process
Convert alert/confirm arguments to strings in render process
2017-04-24 09:26:00 -07:00
Kevin Sawicki
c90fd4dc88 Convert message/title to strings in render process 2017-04-24 09:15:01 -07:00
Kevin Sawicki
a00d36fb07 Add spec for alert/confirm toString errors 2017-04-24 09:15:01 -07:00
Kevin Sawicki
c146f8a308 Merge pull request #9249 from electron/document-write
Don't use document.write in default app
2017-04-24 09:14:29 -07:00
Kevin Sawicki
5f038cb3cb Don't use document.write in default app 2017-04-24 08:57:10 -07:00
Kevin Sawicki
d3ae1d8d23 Merge pull request #9246 from rreimann/master
Clarify requirements for resumable downloads
2017-04-24 08:50:55 -07:00
Kevin Sawicki
13eeb1d17f Minor wording tweaks 2017-04-24 08:50:40 -07:00
Kevin Sawicki
99985c0ed9 Wrap header names in backticks 2017-04-24 08:49:59 -07:00
Kevin Sawicki
9bb944f632 Merge pull request #9273 from electron/update_notification_docs
Updated documentation on desktop notifications on Windows 7
2017-04-24 08:48:44 -07:00
Kevin Sawicki
a26ae85017 Merge pull request #9262 from ArcticZeroo/patch-1
Fix a typo in faq.md
2017-04-24 08:48:20 -07:00
Ales Pergl
46823f944c Updated documentation on desktop notifications on Windows 7 2017-04-24 09:57:34 +02:00
Brendan Forster
f644ba56a3 clean up the code a bit 2017-04-24 11:49:55 +10:00
Brendan Forster
253a4b0114 Merge remote-tracking branch 'electron/master' into certificate-addition-windows 2017-04-24 11:13:34 +10:00
Brendan Forster
ac3385124a reload the current cert database if the certificate was added 2017-04-24 11:12:26 +10:00
ArcticZeroo
64cc537951 Update faq.md
Fix the most horrible typo of all time
2017-04-22 23:11:04 -04:00
rreimann
7ea6d01a8c Rephrase note for resume method 2017-04-22 18:15:07 +02:00
Hari Krishna Reddy Juturu
9e8252c1f9 Remove wm_state change 2017-04-21 14:35:30 -07:00
Hari Krishna Reddy Juturu
3c3e14b820 End session event on browser window 2017-04-21 14:22:11 -07:00
Kevin Sawicki
e9880e9c97 Merge pull request #8996 from swashcap/master
Add documentation note on dynamic Menu items
2017-04-21 13:44:01 -07:00
Kevin Sawicki
d1691e0a37 Merge pull request #9239 from pfrazee/patch-1
Make note about sync webview calls in docs
2017-04-21 13:40:17 -07:00
Kevin Sawicki
7177ea5e9a Bold note for emphasis 2017-04-21 13:39:51 -07:00
Kevin Sawicki
1256ab075c Merge pull request #9248 from electron/stream-test-output-on-windows
Stream test output on Windows CI
2017-04-21 09:15:41 -07:00
Kevin Sawicki
42ccb36df3 Stream test output on Windows CI 2017-04-21 08:53:40 -07:00
Kevin Sawicki
eee9ed2c5d Merge pull request #9241 from electron/doc-symstore
Document downloading debugging tools for windows
2017-04-21 08:50:33 -07:00
Kevin Sawicki
9acd9e878c Mention downloading debugging tools for windows 2017-04-21 08:37:01 -07:00
rreimann
7ce3571270 Clarify requirements for resumable downloads 2017-04-21 15:14:56 +02:00
Brendan Forster
304c8b9562 add some docs for Windows usage 2017-04-21 13:09:49 +10:00
Brendan Forster
c181a8269d and this is how we invoke the callback 2017-04-21 12:47:11 +10:00
Brendan Forster
1439a1e322 and the order here matters apparently 2017-04-21 12:23:50 +10:00
Brendan Forster
b3baf9976f coding style fixes 2017-04-21 12:17:01 +10:00
Kevin Sawicki
1a49374b4c Merge pull request #9237 from electron/root-modules-describe
Add root describe to modules spec
2017-04-20 15:11:27 -07:00
Kevin Sawicki
93603882b1 Add root describe to be able to run whole file 2017-04-20 14:17:58 -07:00
Kevin Sawicki
e95ba067a5 Merge pull request #9238 from electron/wait-for-stdout-close
Wait for close event instead of exit in spec
2017-04-20 14:17:07 -07:00
Paul Frazee
3068d7a43e Make note about sync webview calls in docs 2017-04-20 14:02:41 -05:00
Kevin Sawicki
361c3e0700 Wait for close event instead of exit so stdout done 2017-04-20 11:40:04 -07:00
Kevin Sawicki
a004cada7c Merge pull request #9095 from seanchas116/better-path-resolve
Search for module from app path when URL is not file protocol
2017-04-20 10:49:53 -07:00
Kevin Sawicki
dc8b43901b Merge pull request #9108 from yuya-oc/add-macos-sheet-events
Add sheet-begin and sheet-end events to macOS BrowserWindow
2017-04-20 10:33:31 -07:00
Kevin Sawicki
29a3e11893 Group sheet event methods with other macOS methods 2017-04-20 10:32:14 -07:00
Brendan Forster
5f1bcd2d16 a first pass at the script to import the certificate for Windows 2017-04-20 21:12:32 +10:00
Brendan Forster
dca08c208b and use the same signature for Windows 2017-04-20 14:21:08 +10:00
Brendan Forster
4f40b8a42c stub the windows source file 2017-04-20 14:21:08 +10:00
Kevin Sawicki
454dd00597 Merge pull request #9227 from electron/specs-on-new-ci-machines
Get specs passing on new macOS CI machines
2017-04-19 20:37:37 -07:00
Kevin Sawicki
fae0308861 Use app name in crash dir path on linux/macos 2017-04-19 20:19:17 -07:00
Kevin Sawicki
709d2933b7 🎨 2017-04-19 16:44:31 -07:00
Kevin Sawicki
de62f1ea6c Restart crash service in each spec 2017-04-19 16:37:24 -07:00
Kevin Sawicki
a7a92e1cd3 Still call done when stop server function is null 2017-04-19 09:52:28 -07:00
Kevin Sawicki
4d9cdad37a Close server and connections after each spec 2017-04-19 09:48:32 -07:00
Kevin Sawicki
ece4df0ac7 Increase timeout to 2 minutes 2017-04-19 09:30:03 -07:00
Kevin Sawicki
c05c324464 Remove extra space in description 2017-04-19 09:28:52 -07:00
Kevin Sawicki
6b13fab83a Wait for full screen event before leaving kiosk mode 2017-04-19 09:13:26 -07:00
Kevin Sawicki
5153c1f353 Disable media device specs on CI where they may not be available 2017-04-18 16:16:08 -07:00
Kevin Sawicki
f891df55d4 Call done callback with Error 2017-04-18 16:06:10 -07:00
Kevin Sawicki
4af44b1be6 Consolidate window closing 2017-04-18 16:04:27 -07:00
Kevin Sawicki
4a9383b50b Bump v1.6.7 2017-04-18 09:17:16 -07:00
Kevin Sawicki
6701a96216 Merge pull request #9211 from sindresorhus/patch-1
Add docs tip about testing Touch Bar usage
2017-04-18 12:10:45 -04:00
Kevin Sawicki
1fe10406ad Merge pull request #9194 from electron/external/cookie-flushstore-api
Adding cookie flush store api
2017-04-18 12:09:19 -04:00
Kevin Sawicki
8f0ac057e3 Add initial spec for cookies.flushStore 2017-04-18 09:08:27 -07:00
Hari Krishna Reddy Juturu
fe88697348 fixup! fixup! Adding cookie flush store api 2017-04-18 09:05:13 -07:00
Hari Krishna Reddy Juturu
efca0a6e07 fixup! Adding cookie flush store api 2017-04-18 09:05:13 -07:00
Hari Krishna Reddy Juturu
19709a50e9 Adding cookie flush store api 2017-04-18 09:05:13 -07:00
Kevin Sawicki
190fc46e77 Merge pull request #9208 from electron/touchbar-button-icon-pos
Add iconPosition property to touch bar buttons
2017-04-18 12:02:44 -04:00
Kevin Sawicki
ca46d52b0c Add button with icon to touch bar spec 2017-04-18 09:01:43 -07:00
Kevin Sawicki
c32a723e29 Only read iconPosition when icon is present 2017-04-18 08:58:54 -07:00
Samuel Attard
526d287d25 Make iconPosition non-breaking by defaulting to overlay 2017-04-18 08:56:39 -07:00
Samuel Attard
11c7c107a9 add iconPosition property to touch bar buttons 2017-04-18 08:56:39 -07:00
Kevin Sawicki
fa4e4eb3e0 Merge pull request #9195 from mcizol/master
add turkish quick-start file
2017-04-18 11:51:13 -04:00
Kevin Sawicki
f461a2f20b Merge pull request #9185 from sauber92/patch-2
Update protocol.md
2017-04-18 11:46:05 -04:00
Kevin Sawicki
bba3e866b7 Merge pull request #9180 from runinspring/patch-1
Update shell.md
2017-04-18 11:45:10 -04:00
Birunthan Mohanathas
4d9977dac1 Merge pull request #9219 from electron/update-libcc-dpi-scaling
Update libcc for electron/libchromiumcontent#285
2017-04-18 15:13:03 +03:00
Birunthan Mohanathas
3bcf5e0e9f Fix OverrideSiteInstanceForNavigation() signature 2017-04-18 11:51:38 +03:00
Birunthan Mohanathas
4a7125d9f8 Update libcc for electron/libchromiumcontent#285
This fixes non-client area DPI scaling on recent Windows 10 versions.
See discussion in #8786.
2017-04-18 11:11:26 +03:00
Birunthan Mohanathas
226c1c99a6 Merge pull request #9213 from electron/fix-autohide-menubar-layout
Actually hide menubar area when menu is autohidden
2017-04-17 12:34:23 +03:00
Birunthan Mohanathas
dcf6c52f51 Actually hide menubar area when menu is autohidden
This was a regression introduced in 638eae10.
2017-04-17 12:31:39 +03:00
Sindre Sorhus
39caa6ad23 📝 Add docs tip about testing Touch Bar usage
Disclosure: I made it.

Most devs don't have the new MacBook with Touch Bar, but would like to support it. I think it would be useful to point out how to easily develop and test Touch Bar usage in Electron apps.

[ci skip]
2017-04-17 14:39:37 +07:00
Birunthan Mohanathas
81879f8f8a Merge pull request #9204 from electron/upgrade-brightray-wmstate
Update Brightray for electron/brightray#289
2017-04-16 19:52:11 +03:00
Birunthan Mohanathas
dc914fdb28 Update Brightray for electron/brightray#289
This fixes #9197.
2017-04-16 18:01:32 +03:00
Yuya Ochiai
75184046f6 Add events to manage sheets of macOS BrowserWindow 2017-04-15 16:26:45 +09:00
Mustafa C. Izol
7b3f1b5d91 update link to turkish quick-start 2017-04-14 19:47:39 +02:00
Mustafa C. Izol
228517edde add turkish quick start file 2017-04-14 19:38:46 +02:00
Birunthan Mohanathas
3af50b92ca Merge pull request #9187 from electron/mac-messagebox-warning-icon
Fix missing warning icon with dialog.showMessageBox() on macOS
2017-04-14 19:27:49 +03:00
Birunthan Mohanathas
e7d71000ee Fix missing warning icon with dialog.showMessageBox() on macOS
Fixes #9183.
2017-04-14 19:27:25 +03:00
Junyoung Jung
eee0b35d19 Update protocol.md
오타 수정, Edit typo
2017-04-13 23:47:01 +09:00
Ryohei Ikegami
ea6890aa5c Use const 2017-04-13 23:26:42 +09:00
Birunthan Mohanathas
0c1d60381d Merge pull request #9167 from electron/frameless-overflow3
Fix frameless window overflow on Windows
2017-04-13 13:08:39 +03:00
Kevin Sawicki
108f246d89 Add SubSystem setting 2017-04-13 13:06:36 +03:00
Kevin Sawicki
4ca4eb01d4 Use MinimumRequiredVersion instead of argument 2017-04-13 13:03:46 +03:00
Kevin Sawicki
1a75bf8fb9 Add comment to subsystem linker option 2017-04-13 13:03:46 +03:00
Kevin Sawicki
fe8726d775 Use Chrome default client inset handling 2017-04-13 13:03:46 +03:00
Birunthan Mohanathas
7f4bd79b01 Merge pull request #9166 from electron/browserview
Implement initial, experimental BrowserView API
2017-04-13 11:00:16 +03:00
ZhangYu
ed20cc0af8 Update shell.md 2017-04-13 10:27:32 +08:00
Ryohei Ikegami
9d62b196d3 Use base::FilePath 2017-04-13 10:59:12 +09:00
Birunthan Mohanathas
000aedf2e7 Avoid insecure nodeIntegration in example 2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
ccdeb4746e Destroy BrowserViews after each test 2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
06fcf2c19d Add support for BrowserView autoresizing 2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
638eae1080 Remove MenuLayout in favor of NativeWindowViews::Layout 2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
8b9f7e5b00 Implement initial, experimental BrowserView API
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.

For us at [Figma](https://www.figma.com), the main issue is very slow
performance.

Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.

Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...

- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
  likely also be bugs in `BrowserWindow` web contents)

- is instantiated in the main process like `BrowserWindow` (and unlike
  `<webview>`, which lives in the DOM of a `BrowserWindow` web contents)

- needs to be added to a `BrowserWindow` to display something on the screen

This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.

In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Kevin Sawicki
779e4e5889 Merge pull request #9168 from electron/win-7-notifications
Upgrade brightray for Windows 7 notifications
2017-04-12 13:26:40 -07:00
Kevin Sawicki
4f26424ace Upgrade brightray for Windows 7 notifications 2017-04-12 13:01:52 -07:00
Kevin Sawicki
1c44bcf654 Merge pull request #8786 from electron/per-monitor-dpi-aware
Enable per-monitor DPI for Win10
2017-04-12 12:27:41 -07:00
Ryohei Ikegami
c77e07bc15 Fix afterEach 2017-04-12 11:55:41 +09:00
Kevin Sawicki
efa28503a7 Merge pull request #9148 from electron/share-render-frame-observer-with-sandbox
Refactor: Share AtomRenderFrameObserver with AtomSandboxedRendererClient
2017-04-11 10:02:12 -07:00
Kevin Sawicki
964b210ce0 Merge pull request #9133 from electron/app-exit-failure
Fix app.exit() not closing all windows
2017-04-11 09:49:54 -07:00
Kevin Sawicki
e7b679ead6 Add IsEmpty helper and remove GetInstance public usage 2017-04-11 09:09:17 -07:00
Kevin Sawicki
da5d7d72b0 Add GetWindows helper that returns a vector 2017-04-11 09:09:17 -07:00
Kevin Sawicki
0883a9f966 Use CloseAllWindows helper 2017-04-11 09:09:17 -07:00
Kevin Sawicki
8311aa667c Add DestroyAllWindows helper that uses vector copy 2017-04-11 09:09:17 -07:00
Kevin Sawicki
bfb9388191 Add failing spec for app.exit with >2 windows 2017-04-11 09:09:17 -07:00
Kevin Sawicki
a30cf30e93 Merge pull request #9134 from electron/scroll-bounce-fix
Always set NSScrollViewRubberbanding scroll bounce pref
2017-04-11 09:08:30 -07:00
Kevin Sawicki
b2761ab7dc Merge pull request #9157 from electron/cifratila/remove-unused-dll
#9128: Removed unused dll from distribution.
2017-04-11 08:52:20 -07:00
Kevin Sawicki
29c68182df Always set NSScrollViewRubberbanding scroll bounce pref 2017-04-11 08:42:41 -07:00
Cheng Zhao
c59ef0efc5 Enable per-monitor DPI 2017-04-11 15:17:15 +09:00
Kevin Sawicki
e2a00e423c Merge pull request #9104 from electron/fix-crash-reporter-test
Fix sandboxed crashReporter for windows
2017-04-10 15:38:12 -07:00
Kevin Sawicki
f3072e3b2d Merge pull request #9158 from mcizol/patch-1
add electron slack channel for turkish community
2017-04-10 15:37:17 -07:00
Mustafa
2c6ef95923 add electron slack channel for turkish community 2017-04-10 18:41:52 +02:00
Kevin Sawicki
0caa35d33c Merge pull request #9155 from Hum4n01d/master
Add information about dragging not working with Dev tools open
2017-04-10 08:18:09 -07:00
Kevin Sawicki
676f02e001 Tweak GitHub spelling 2017-04-10 08:17:55 -07:00
Kevin Sawicki
3ec7900e6e Merge pull request #9154 from miniak/fix-api-docs
Fix api docs
2017-04-10 08:16:54 -07:00
Kevin Sawicki
cfb4010415 Merge pull request #9151 from mcizol/master
add turkish translation files
2017-04-10 08:16:20 -07:00
Kevin Sawicki
53884580cc Merge pull request #9149 from electron/link-session-docs
Link session properties to class docs
2017-04-10 08:15:29 -07:00
Kevin Sawicki
2933eef07e Merge pull request #9144 from electron/wait-util-server-closes
Wait until server closes in afterEach in net spec
2017-04-10 08:14:42 -07:00
Kevin Sawicki
575ece69e2 Merge pull request #9137 from runinspring/patch-3
add some document
2017-04-10 08:14:13 -07:00
Kevin Sawicki
ef7dbf8b51 Merge pull request #9136 from runinspring/patch-2
Update README.md
2017-04-10 08:13:47 -07:00
Catalin Fratila
d3953f7280 #9128: Removed unused dll from distribution. 2017-04-10 16:41:16 +02:00
Hum4n01d
0ce983363b Add information about dragging not working with Dev tools open 2017-04-09 23:05:56 -07:00
Milan Burda
fa0de5c2b4 Define filter argument type for WebRequest methods 2017-04-10 02:18:36 +02:00
Mustafa C. Izol
475620119e add turkish translation link to readme 2017-04-10 02:12:53 +02:00
Milan Burda
8f46137fda Fix session.setPermissionRequestHandler webContents argument type 2017-04-10 02:12:15 +02:00
Mustafa C. Izol
613c835eec add turkish readme file 2017-04-10 02:10:52 +02:00
Mustafa C. Izol
34beb52edb fix link to electron faq 2017-04-10 01:23:14 +02:00
Mustafa C. Izol
6a729f90e5 add translation files for application-distrubution and supported platforms 2017-04-10 00:47:00 +02:00
Kevin Sawicki
b7b7f28c5a Link properties to class docs 2017-04-08 18:50:55 -07:00
Thiago de Arruda
039aaba758 Move AtomRenderFrameObserver creation to RendererClientBase.
Also remove AtomSandboxedRenderFrameObserver class.
2017-04-08 11:54:58 -03:00
Thiago de Arruda
72781e38c8 Change AtomRenderFrameObserver.renderer_client_ type to RendererClientBase. 2017-04-08 11:27:19 -03:00
Thiago de Arruda
ef07e25f9d Make SetupMainWorldOverrides/isolated_world pure virtual.
Also implement stubs in AtomSandboxedRendererClient.
2017-04-08 11:12:18 -03:00
Thiago de Arruda
f751335bf9 Make DidCreateScriptContext/WillReleaseScriptContext pure virtual. 2017-04-08 10:58:13 -03:00
Thiago de Arruda
0227254774 Move DidClearWindowObject into RendererClientBase.
Also adapt AtomSandboxedRenderFrameObserver to forward DidClearWindowObject to
RendererClientBase.
2017-04-08 10:43:19 -03:00
Thiago de Arruda
91ee0ea740 Move AtomRenderFrameObserver into a separate module.
Also move SetupMainWorldOverrides into the AtomRendererClient class(since the
code there is specific to AtomRendererClient).
2017-04-08 10:29:05 -03:00
Kevin Sawicki
e2e9e8ae24 Wait until server closes in afterEach 2017-04-07 16:42:01 -07:00
Kevin Sawicki
8a324a9375 Bump v1.6.6 2017-04-07 09:01:28 -07:00
ZhangYu
b6481fde14 Create upload-raw-data.md 2017-04-07 10:48:07 +08:00
ZhangYu
ca584fcaf9 Create upload-file.md 2017-04-07 10:47:52 +08:00
ZhangYu
6089456c84 Create upload-file-system.md 2017-04-07 10:47:37 +08:00
ZhangYu
05d59185b2 Create upload-data.md 2017-04-07 10:47:23 +08:00
ZhangYu
6b44692b0d Create upload-blob.md 2017-04-07 10:47:09 +08:00
ZhangYu
3ba8a7516a Create thumbar-button.md 2017-04-07 10:46:53 +08:00
ZhangYu
a584785254 Create task.md 2017-04-07 10:46:34 +08:00
ZhangYu
39111b9e34 Create size.md 2017-04-07 10:46:19 +08:00
ZhangYu
e8f030af15 Create shortcut-details.md 2017-04-07 10:46:04 +08:00
ZhangYu
3475387d9c Create segmented-control-segment.md 2017-04-07 10:45:50 +08:00
ZhangYu
826932199b Create scrubber-item.md 2017-04-07 10:45:36 +08:00
ZhangYu
bffec5e68e Create remove-password.md 2017-04-07 10:45:19 +08:00
ZhangYu
6e36ec7770 Create remove-client-certificate.md 2017-04-07 10:45:00 +08:00
ZhangYu
7a552da192 Create rectangle.md 2017-04-07 10:44:41 +08:00
ZhangYu
30fe4a6f2b Create point.md 2017-04-07 10:44:26 +08:00
ZhangYu
b117f14c2a Create mime-typed-buffer.md 2017-04-07 10:44:09 +08:00
ZhangYu
32ee0f05e3 Create memory-usage-details.md 2017-04-07 10:43:51 +08:00
ZhangYu
aa37030211 Create jump-list-item.md 2017-04-07 10:43:05 +08:00
ZhangYu
913644504c Create jump-list-category.md 2017-04-07 10:42:39 +08:00
ZhangYu
1fb0a5f0da Create file-filter.md 2017-04-07 10:42:04 +08:00
ZhangYu
27a45009b3 Create display.md 2017-04-07 10:40:47 +08:00
ZhangYu
e811f809b5 Create desktop-capturer-source.md 2017-04-07 10:36:50 +08:00
ZhangYu
6a4e7225e2 Create crash-report.md 2017-04-07 10:25:22 +08:00
ZhangYu
9e33f2efeb Create cookie.md 2017-04-07 10:24:11 +08:00
ZhangYu
5986d36059 Create certificate.md 2017-04-07 10:16:32 +08:00
ZhangYu
202b8e40c4 Create certificate-principal.md 2017-04-07 10:14:51 +08:00
ZhangYu
a6f5c35fa6 Create bluetooth-device.md 2017-04-07 10:10:12 +08:00
ZhangYu
ad0a22af23 Update README.md 2017-04-07 10:03:21 +08:00
Kevin Sawicki
e3407bb99e Merge pull request #9132 from electron/fork-eval-node-fix
Cherry pick node fix for ChildProcess.fork --eval bug
2017-04-06 13:17:13 -07:00
Kevin Sawicki
588f699d56 🎨 2017-04-06 09:52:52 -07:00
Kevin Sawicki
c3798be9b8 Upgrade node for fork --eval cherry pick fix 2017-04-06 09:48:36 -07:00
Kevin Sawicki
7f28b7a151 Add failing spec for fork --eval message bug 2017-04-06 09:48:34 -07:00
Kevin Sawicki
4ec7cc913d Merge pull request #9117 from electron/fix_debug_checks
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-06 08:48:15 -07:00
Kevin Sawicki
b11afc8591 Merge pull request #9129 from runinspring/patch-1
Update accelerator.md
2017-04-06 08:47:21 -07:00
Kevin Sawicki
7ea1253aae Merge pull request #9126 from runinspring/master
Update menu.md and menu-item.md
2017-04-06 08:46:55 -07:00
Kevin Sawicki
931290bc59 Merge pull request #9125 from electron/fix-chrome-upgrade-link
Fix link to the Upgrading Chrome doc
2017-04-06 08:46:25 -07:00
Kevin Sawicki
11abdb6378 Merge pull request #9124 from TasukuUno/fix-docs
Fix document of MimeTypedBuffer Object
2017-04-06 08:45:48 -07:00
ZhangYu
a7d9230497 Update accelerator.md 2017-04-06 17:29:06 +08:00
ZhangYu
c305517957 Update menu-item.md 2017-04-06 15:06:46 +08:00
ZhangYu
0eed821788 Update menu.md 2017-04-06 15:06:02 +08:00
Vadim Macagon
95e782d26c Fix link to the Upgrading Chrome doc 2017-04-06 16:04:19 +10:00
Tasuku Uno
59fe7d3dbb 📝 Fix document of MimeTypedBuffer Object
[ci skip]
2017-04-06 11:38:59 +09:00
Kevin Sawicki
d857b71557 Merge pull request #9111 from electron/deliver-ipc-messages-to-handlers
Fix printing on Windows
2017-04-05 16:27:58 -07:00
Thiago de Arruda
ce1a5e3c9c Fix sandboxed crashReporter for windows.
- Use `path` module from browser process in sandboxed renderer. This is required
  because the return value of `path.join` is platform-specific, and this is an
  assumtion of crash-reporter.js which is shared between sandboxed and
  non-sandboxed renderers.
- Set `process.platform` and `process.execPath` in sandboxed renderer
  environment. This is required to spawn the windows crash service from
  sandboxed renderer.
- Use a single temporary directory for all crashReporter tests. This is required
  to make tests more deterministic across platforms(since mac's crashpad doesn't
  support changing the crash dump directory). Also make a few improvements/fixes
  to the `uploadToServer` test.
2017-04-05 18:09:24 -03:00
Ales Pergl
73e3fd01eb Fixed a couple of failing debug checks when calling Chromium APIs 2017-04-05 14:45:46 +02:00
Kevin Sawicki
b27b1c3b24 Append printed page to job 2017-04-04 20:47:05 -07:00
Kevin Sawicki
aa75e4562e Restore delivering IPC messages to utility handlers 2017-04-04 20:40:57 -07:00
Kevin Sawicki
7574c33ef1 Merge pull request #9028 from electron/fix-popover-items-not-updating
Fix popover items not updating
2017-04-04 14:09:59 -07:00
Kevin Sawicki
6a22c6645e Guard against missing popover identifier 2017-04-04 13:51:39 -07:00
Kevin Sawicki
9c73c991d7 Use const references for params 2017-04-04 13:51:39 -07:00
Samuel Attard
bea56bbdc8 Update as per feedback 2017-04-04 13:51:38 -07:00
Samuel Attard
2fd62d090a Allow items to be assigned to multiple popovers 2017-04-04 13:51:33 -07:00
Samuel Attard
f05dfc74da Store parent popover in popover touch bar items 2017-04-04 13:51:13 -07:00
Kevin Sawicki
8c8b737fa2 Merge pull request #9023 from electron/touchbar-set-escape-button
TouchBar - Method to set escape button
2017-04-04 13:35:55 -07:00
Kevin Sawicki
74a3a34caa Add spec for interaction event with escape item 2017-04-04 13:14:56 -07:00
Kevin Sawicki
bbadeb62ac Check that escape item is non-null before checking id 2017-04-04 13:12:29 -07:00
Kevin Sawicki
414540bfcb Support passing escape item to TouchBar constructor 2017-04-04 12:50:41 -07:00
Kevin Sawicki
b24b4212c5 Make escape item a property instead of setter 2017-04-04 12:50:41 -07:00
Kevin Sawicki
21c1ddffb3 Handle change and interaction events on escape items 2017-04-04 12:50:41 -07:00
Kevin Sawicki
591cd8d073 Update window via listener when escape item changes 2017-04-04 12:50:41 -07:00
Kevin Sawicki
0501a20fe6 Clear escape item 2017-04-04 12:50:41 -07:00
Kevin Sawicki
6eacec7dc3 replaceEscapeItem -> setEscapeItem 2017-04-04 12:50:41 -07:00
Kevin Sawicki
7f8e490839 Take const reference 2017-04-04 12:50:41 -07:00
Kevin Sawicki
d596d85288 🎨 2017-04-04 12:50:41 -07:00
Kevin Sawicki
df0f468dea Add escapeKeyReplacementItemIdentifier forward declaration 2017-04-04 12:50:41 -07:00
Samuel Attard
60cc862031 Make everything pointer like 2017-04-04 12:50:41 -07:00
Samuel Attard
2ba937289c Add smoke test for escape replacement 2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b Add a method to set the escape identifier on the touch bar 2017-04-04 12:50:41 -07:00
Kevin Sawicki
3c1a372157 Merge pull request #9101 from electron/wrap-remote-set-as-args
Support calling remote setters with remote objects
2017-04-04 12:50:15 -07:00
Kevin Sawicki
fdd36334e5 Match args style of other IPC handlers 2017-04-04 11:18:16 -07:00
Kevin Sawicki
746f636016 Add tests for setting remote property null/undefined 2017-04-04 11:18:16 -07:00
Kevin Sawicki
7065123266 Wrap remote value being set as an arg 2017-04-04 11:18:16 -07:00
Kevin Sawicki
e5f70f90a4 Add spec for remote setter with remote object 2017-04-04 11:18:16 -07:00
Kevin Sawicki
3e9014c371 Merge pull request #9099 from electron/certificate-trust
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
Kevin Sawicki
2bd47eb672 Add specs for showCertificateTrustDialog option errors 2017-04-04 10:49:21 -07:00
Kevin Sawicki
2e32525e8f Make browser window optional 2017-04-04 10:49:10 -07:00
joshaber
2749ded062 Fix c&p error 2017-04-04 11:45:27 -04:00
Kevin Sawicki
af40a60937 Merge pull request #9072 from p-jackson/patch-1
Document passing null to Menu.setApplicationMenu
2017-04-04 08:42:08 -07:00
Kevin Sawicki
f64d82cf16 Merge pull request #9105 from miniak/fix-api-docs
Use point / size / rectangle structures consistently in API docs
2017-04-04 08:41:34 -07:00
joshaber
736d6afe73 As you wish linter 2017-04-04 09:23:30 -04:00
joshaber
146e1ed3ce Don't pass the result through
It's meaningless on macOS, at least.
2017-04-04 09:21:15 -04:00
joshaber
0cab8a3322 Put CertFromData in an anon namespace 2017-04-04 09:19:23 -04:00
Milan Burda
568454525d Use point / size / rectangle structures consistently in API docs 2017-04-04 08:31:09 +02:00
Philip Jackson
6169ccd1e2 📝 Document that setApplicationMenu(null) has no effect on macOS 2017-04-04 18:00:20 +12:00
Cheng Zhao
7265a0c1b4 Merge pull request #8528 from Anatzum/patch-1
Use kioclient for MoveItemToTrash on KDE
2017-04-04 12:15:21 +09:00
joshaber
8d465234e4 Appease our linty overlords 2017-04-03 21:40:46 -04:00
joshaber
e2bda3ca0f Use an options object for most of the params 2017-04-03 21:33:21 -04:00
joshaber
2badfbe04f Remove the intermediate function 2017-04-03 21:22:37 -04:00
joshaber
b3e865a478 Fix some style things 2017-04-03 21:22:14 -04:00
joshaber
398132cfe3 Fix file sorting 2017-04-03 21:19:00 -04:00
Ryohei Ikegami
24fedb2e20 No extra linebreak 2017-04-04 09:40:38 +09:00
Ryohei Ikegami
4a7eec8f2d Pass app path as command line argument 2017-04-04 09:36:01 +09:00
Ryohei Ikegami
9cb6bc098d Use beforeEach/afterEach 2017-04-04 09:08:27 +09:00
Kevin Sawicki
7860ea0227 Merge pull request #9097 from electron/handle-setter-errors
Surface errors setting remote properties
2017-04-03 13:30:39 -07:00
joshaber
370cf815d9 Get rid of intermediates and rehydrate from issuerCert 2017-04-03 16:27:53 -04:00
joshaber
74c0cbddae Linebreak to keep the linter happy 2017-04-03 16:07:02 -04:00
joshaber
b8ff4666c8 Remove stale includes 2017-04-03 15:48:47 -04:00
joshaber
da1b0aab3e Flesh out some docs 2017-04-03 15:39:45 -04:00
joshaber
b0ef7ddf44 Use better iteration 2017-04-03 15:28:51 -04:00
joshaber
06643e525a Const ref that message 2017-04-03 15:28:44 -04:00
joshaber
11f5c942ce Conditionalize 2017-04-03 15:25:09 -04:00
joshaber
0b7ffd094a Expose through the actual JS API too 2017-04-03 15:25:06 -04:00
Kevin Sawicki
e85e483c71 Parse setting response to surface thrown errors 2017-04-03 12:16:51 -07:00
Kevin Sawicki
f49e748020 Merge pull request #9096 from electron/upgrade-brightray-for-cpp-cleanup
Upgrade brightray to latest
2017-04-03 12:16:10 -07:00
joshaber
bcecba20e6 Fix indentation 2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99 Remove old unnecssary change on app 2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c Move it into dialog 2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b Handle the callback and cleanup properly 2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29 Do the callback & release dance 2017-04-03 13:21:44 -04:00
Kevin Sawicki
257f6b142f Add spec for remote setter not surfacing error 2017-04-03 09:10:46 -07:00
Kevin Sawicki
0989fd7a1c Upgrade brightray to latest 2017-04-03 08:32:16 -07:00
Kevin Sawicki
f5a75c4e87 Merge pull request #9076 from electron/cleanup-cpp
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Kevin Sawicki
2f692c1002 Merge pull request #9084 from runinspring/patch-1
Update web-contents.md
2017-04-03 08:20:06 -07:00
Ryohei Ikegami
001d03c859 Do not add search paths in devtools 2017-04-03 22:40:36 +09:00
Ryohei Ikegami
d1212d4a43 Fix JS style 2017-04-03 20:23:36 +09:00
Ryohei Ikegami
50c99e4507 Search for module under the app directory 2017-04-03 20:19:10 +09:00
Ryohei Ikegami
673f4f4d0c Add test for require to search under app dir 2017-04-03 20:11:19 +09:00
Haojian Wu
34a91434aa Remove extra spaces. 2017-04-01 22:01:29 +02:00
ZhangYu
671bcf2161 Update web-contents.md 2017-04-02 00:41:36 +08:00
Haojian Wu
f09e3f3835 Remove extra blank. 2017-04-01 15:09:53 +02:00
Zeke Sikelianos
c2230ca76a generate electron.d.ts during dist creation, not during build 2017-03-31 21:35:58 -07:00
Zeke Sikelianos
c00bac5c0b add a convenience script for manually generating API JSON 2017-03-31 21:09:23 -07:00
Zeke Sikelianos
9a10486514 generate and upload electron.d.ts with each release 2017-03-31 21:01:55 -07:00
joshaber
ee7389bb6d Rename to make VS happy 2017-03-31 22:57:56 -04:00
joshaber
4f3d3557cc Notify that the cert changed 2017-03-31 21:51:29 -04:00
Zeke Sikelianos
a686237d9b Merge pull request #9080 from electron/fixup-docs-5
Add missing finalUpdate prop
2017-03-31 18:29:16 -07:00
joshaber
bde2a597f3 Decode all the intermediates 2017-03-31 21:27:49 -04:00
joshaber
69defc5166 Encode all the intermediates 2017-03-31 21:27:33 -04:00
Samuel Attard
f757912f90 Add missing finalUpdate prop 2017-04-01 12:11:34 +11:00
Kevin Sawicki
372f209363 Merge pull request #9079 from electron/fix-dialog-args
Move normalizeAccessKeys docs to showMessageBox method
2017-03-31 16:35:31 -07:00
Kevin Sawicki
6d516fbae3 Move normalizeAccessKeys docs to right method 2017-03-31 15:08:03 -07:00
joshaber
302ca8669d Slightly better conversion 2017-03-31 15:44:47 -04:00
Kevin Sawicki
a724b6555f Bump v1.6.5 2017-03-31 12:10:09 -07:00
Kevin Sawicki
0faa15c6ca Merge pull request #9074 from electron/tabbing-mode-version-guard
Only define NSWindowTabbingModeDisallowed on pre-10.12 SDKs
2017-03-31 12:09:54 -07:00
Kevin Sawicki
08db63c3cc Only define NSWindowTabbingModeDisallowed on pre-10.12 2017-03-31 11:28:55 -07:00
Kevin Sawicki
8a01ebef63 Merge pull request #9053 from electron/enable-crash-reporter-upload-windows
Pass `uploadToServer` option to windows crash reporter
2017-03-31 11:28:35 -07:00
joshaber
141a5ad73f Maybe this is a valid conversion? 2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb Lines should be <= 80 characters. 2017-03-31 20:09:13 +02:00
joshaber
16cc79354c Errrrybody's a scoped_refptr now 2017-03-31 13:53:42 -04:00
joshaber
deae70de4d Dummy out the certificate FromV8 converter 2017-03-31 13:53:31 -04:00
Kevin Sawicki
d677a436ec 🎨 2017-03-31 10:42:43 -07:00
Thiago de Arruda
460fb9cdb9 Add tests for uploadToServer option. 2017-03-31 13:48:07 -03:00
Thiago de Arruda
f0d447cd68 Pass uploadToServer to windows crash reporter 2017-03-31 13:46:30 -03:00
Philip Jackson
1c80102218 📝 Document passing null to Menu.setApplicationMenu
[ci skip]
2017-03-31 16:42:03 +13:00
Kevin Sawicki
96407d9c17 Merge pull request #9057 from electron/upgrade-libcc-for-ffmpeg-linking-fix
Upgrade libcc for ffmpeg linking fix
2017-03-30 15:15:32 -07:00
Kevin Sawicki
39fdc26921 Time out after 5 minutes 2017-03-30 14:39:48 -07:00
Kevin Sawicki
c85d667e66 Upgrade libcc to latest master 2017-03-30 14:37:19 -07:00
Kevin Sawicki
90d0179fe9 Use correct dll name 2017-03-30 14:36:52 -07:00
Kevin Sawicki
b85ebb00aa Tweak logged messages 2017-03-30 14:36:52 -07:00
Kevin Sawicki
7873130019 Add comment to codecs app script 2017-03-30 14:36:52 -07:00
Kevin Sawicki
6b8f840da0 Add script to verify ffmpeg without proprietary codecs 2017-03-30 14:36:52 -07:00
Kevin Sawicki
740de02d6c builds -> Support 2017-03-30 14:36:52 -07:00
Kevin Sawicki
5b4f715d2e Add test page to check for proprietary codecs 2017-03-30 14:36:52 -07:00
Kevin Sawicki
c8951d0d4d Upgrade libcc for ffmpeg linking fix 2017-03-30 14:36:52 -07:00
Kevin Sawicki
76529b5065 Merge pull request #9067 from electron/check-name-param-directly
Check name directly instead of arguments length
2017-03-30 14:35:56 -07:00
joshaber
edf61d41ba Link against the Security frameworks 2017-03-30 17:26:11 -04:00
joshaber
7b044ffe0e Compile these lovely files 2017-03-30 17:26:03 -04:00
joshaber
653b2d15c3 Expose the certificate trust panel as part of app 2017-03-30 17:25:55 -04:00
joshaber
64369cd07f Show a certificate trust panel 2017-03-30 17:25:44 -04:00
Haojian Wu
328cf4789b Should override the virtual destructor. 2017-03-30 23:19:43 +02:00
Haojian Wu
e8abee9ca9 Replace C-style casts with static_cast. 2017-03-30 23:05:47 +02:00
Kevin Sawicki
fcb7cbc54a Check name directly instead of arguments length 2017-03-30 14:03:00 -07:00
Kevin Sawicki
a2588c1fd9 Merge pull request #9052 from tonyganch/native_tabs
Native tabs on macOS
2017-03-30 14:02:19 -07:00
Haojian Wu
ff745e1a82 Use prefix increment in for loops. 2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad Correct type cast. 2017-03-30 22:53:20 +02:00
Kevin Sawicki
6f27d466a5 Move tabbingIdentifier out of webPreferences list 2017-03-30 13:49:00 -07:00
Kevin Sawicki
42300ae58e Make tabbing identifier var local 2017-03-30 13:47:11 -07:00
Kevin Sawicki
e699e88b4c Add initial tabbingIdentifier spec 2017-03-30 13:46:58 -07:00
Kevin Sawicki
c8b992fa39 Remove 10.12 check handled by respondsToSelector 2017-03-30 13:46:34 -07:00
Haojian Wu
bb51401c4c Use base::mac::NSToCast. 2017-03-30 22:33:09 +02:00
Haojian Wu
1b9780035c Remove redundant calls to smart pointer's get method. 2017-03-30 22:22:40 +02:00
Haojian Wu
d425b63b0d NULL => nullptr 2017-03-30 22:12:14 +02:00
Haojian Wu
00693ba075 Replace "size()" with "empty()". 2017-03-30 21:59:18 +02:00
Haojian Wu
6ef3be23fd Avoid copy in for range loop. 2017-03-30 21:56:28 +02:00
Kevin Sawicki
77994a7856 Merge pull request #9066 from electron/segment-style-enum-warnings
Add descriptions for each segmentStyle
2017-03-30 12:36:35 -07:00
Kevin Sawicki
4001ba038e Add descriptions for each segmentStyle 2017-03-30 12:36:20 -07:00
Kevin Sawicki
f805bbee9b Merge pull request #9062 from electron/stringify-headers-in-net-module
Fix net module to accept non-string header values
2017-03-30 12:35:53 -07:00
Zeke Sikelianos
f0e7a84627 Merge pull request #9065 from electron/roles
Improve docs for MenuItem Roles
2017-03-30 12:28:14 -07:00
Thiago de Arruda
b3cf00a19a Fix net module to accept non-string header values
This is required to be compatible with node.js http module.
2017-03-30 16:01:40 -03:00
Kevin Sawicki
3100463117 Merge pull request #8917 from bcomnes/patch-1
Clarify remote require of relative modules
2017-03-30 12:00:47 -07:00
Kevin Sawicki
55bf2239df Remove spaces around brackets 2017-03-30 11:58:09 -07:00
Zeke Sikelianos
d5bc8990fc link to roles list from Menu doc 2017-03-30 11:08:12 -07:00
Zeke Sikelianos
b24be19fac tighten up formatting of menu example 2017-03-30 11:07:59 -07:00
Zeke Sikelianos
d779ecf674 create a linkable heading for MenuItem roles 2017-03-30 11:07:25 -07:00
Kevin Sawicki
bdd08b8baa Merge pull request #9054 from ColinEberhardt/patch-3
Some minor copy edit on sandbox documentation
2017-03-30 10:52:46 -07:00
Tony Ganch
bd935b213f Fix compilation against macOS 10.10 SDK 2017-03-30 15:13:49 +02:00
Colin Eberhardt
bed32682b7 Clarification of the chromium sandbox support 2017-03-30 10:47:14 +01:00
Haojian Wu
5f724e57bc Avoid unnecessary copy of parameters. 2017-03-29 22:06:07 +02:00
Kevin Sawicki
57edc28b0d Merge pull request #8880 from mst128256/2814
Default menu items for 'Edit' and 'Window' #2814
2017-03-29 12:31:58 -07:00
Kevin Sawicki
8b4bf1f29e 🎨 2017-03-29 12:29:36 -07:00
Haojian Wu
99293dd57f Fix namespace comments. 2017-03-29 20:47:41 +02:00
Tony Ganch
a7565f0d57 Enable native tabs on macOS 2017-03-29 13:51:39 +02:00
Tony Ganch
9e02c60e22 Revert "Disable Show Tab Bar menu item on macOS Sierrra"
This reverts commit 24b9313958.
2017-03-29 13:50:56 +02:00
Tony Ganch
ed76e03730 Revert "Add forward declaration of NSWindow.allowsAutomaticWindowTabbing"
This reverts commit 770a3509cf.
2017-03-29 13:50:56 +02:00
mst128256
6ae198a625 Empty objects within default menu replaced by nulls 2017-03-29 12:50:31 +02:00
Cheng Zhao
6db827cc9a Use GetDesktopEnvironment to determien desktop env
Which can get a much more precise result for us.
2017-03-29 16:21:38 +09:00
Anatzum
f9dbdf4522 Updated MoveItemToTrash in platform_util_linux.cc
If ELECTRON_TRASH is null, first check the DESKTOP_SESSION variable and set trash accordingly. Additional desktop environments can be added easily this way with the fallback of ELECTRON_DEFAULT_TRASH.
2017-03-29 16:08:26 +09:00
Cheng Zhao
208182d8cf Merge pull request #9039 from electron/extract-renderer-base-class
Create base class to share code between sandbox and non-sandbox
2017-03-29 15:20:46 +09:00
Cheng Zhao
9ef1f8cd5d Merge pull request #9043 from electron/fix-uv-run-crash
Fix crash happened in UvRunOnce
2017-03-29 13:37:07 +09:00
Kevin Sawicki
4441d557a2 Merge pull request #9007 from electron/net_redirect_patch
net: allow controlling redirects
2017-03-28 09:31:05 -07:00
Kevin Sawicki
03b2167f6c Merge pull request #9001 from electron/net_source_stream_error_patch
net: catch source stream creation failure for content encoding
2017-03-28 09:24:18 -07:00
Kevin Sawicki
e0003021cf Merge pull request #9041 from runinspring/master
Update dialog.md
2017-03-28 09:15:09 -07:00
Kevin Sawicki
d196486cb4 Merge pull request #8652 from electron/no-api-docs-generation
create-dist: Adding argument to supress api docs generation.
2017-03-28 08:59:46 -07:00
deepak1556
b14c4dcdc0 address review comments 2017-03-28 19:05:44 +05:30
deepak1556
8db1eacd1c [skip ci] add docs 2017-03-28 18:46:21 +05:30
deepak1556
3ae62615f4 net: allow controlling redirects 2017-03-28 18:46:21 +05:30
Cheng Zhao
2ef1b70897 Fix crash happened in UvRunOnce 2017-03-28 17:19:14 +09:00
Cheng Zhao
637bdc239b Merge pull request #8923 from electron/geolocation_request_context_patch
browser: Create separate request context for geolocation service.
2017-03-27 22:45:46 -07:00
ZhangYu
3004f3c762 Update dialog.md 2017-03-28 11:49:47 +08:00
Kevin Sawicki
8164ede297 Merge pull request #9037 from electron/upgrade-libcc-for-webview-drag-fix
Upgrade libcc for webview dnd fix
2017-03-27 17:18:17 -07:00
Thiago de Arruda
d1f08beddf Make AtomSandboxedRendererClient a RendererClientBase subclass. 2017-03-27 18:49:55 -03:00
Thiago de Arruda
c3a8f665f2 Extract base class from AtomRendererClient
The new `RendererClientBase` class contains code that is not specific to node.js
integration with the renderer.
2017-03-27 18:49:55 -03:00
Kevin Sawicki
3028bffa73 Upgrade libcc for webview dnd fix 2017-03-27 14:06:00 -07:00
Kevin Sawicki
9249228ac3 Merge pull request #9034 from electron/disable-flaky-appveyor-spec
Disable flaky post navigation spec on AppVeyor
2017-03-27 14:05:42 -07:00
Kevin Sawicki
f24baffc79 Expect count to be 0 2017-03-27 10:21:01 -07:00
Kevin Sawicki
ad5a48d255 Merge pull request #8983 from electron/sandbox-initial-documentation
Add initial documentation for `sandbox` option.
2017-03-27 10:16:24 -07:00
Kevin Sawicki
870dcb9071 Remove old sandbox option in list and mark as experimental 2017-03-27 10:14:47 -07:00
Kevin Sawicki
6a2cdcf32f Merge pull request #8956 from electron/expose-crash-reporter-to-sandbox
Expose crash reporter to sandbox
2017-03-27 10:09:36 -07:00
Kevin Sawicki
f979bbf9d3 Merge pull request #8897 from electron/versioning-doc
update versioning doc
2017-03-27 09:54:11 -07:00
Kevin Sawicki
b1275a8ef0 Merge pull request #8984 from hansenzhang/display-menuitem-label
Fix '&'  not showing in MenuItem label
2017-03-27 09:47:50 -07:00
Kevin Sawicki
9a4783bf34 Disable flaky post navigation spec on AppVeyor 2017-03-27 09:15:40 -07:00
Kevin Sawicki
2dabe8d6fa Merge pull request #9021 from owwo/master
Fix translation error
2017-03-27 09:11:24 -07:00
Kevin Sawicki
fecd018a35 Merge pull request #9024 from runinspring/patch-1
add getFileIcon method
2017-03-27 09:11:04 -07:00
Kevin Sawicki
10dc08b39b Merge pull request #9006 from electron/fix-thumbnailSize-doc
fix docs for thumbnailSize
2017-03-27 09:10:40 -07:00
ZhangYu
dccfadd2bc add getFileIcon method 2017-03-27 11:16:05 +08:00
Zeke Sikelianos
4d29392217 Merge pull request #9014 from electron/MarshallOfSound-patch-1
Fix return syntax in docs
2017-03-26 19:53:33 -07:00
owwo
4e1b237649 Fix translation error 2017-03-26 18:42:07 -05:00
Samuel Attard
168c47bf10 Update web-contents.md 2017-03-25 18:27:43 +11:00
Zeke Sikelianos
79346f1ac5 Merge pull request #9012 from electron/fixup-docs-4
Add missing property types on the process docs
2017-03-25 00:10:09 -07:00
Samuel Attard
b62f1fd022 Add missing return type on executeJavaScript 2017-03-25 14:59:48 +11:00
Samuel Attard
a80148aa29 Add missing property types on the process docs 2017-03-25 14:51:23 +11:00
Zeke Sikelianos
d39207f83a Merge pull request #9010 from electron/fixup-docs-3
Generic doc fixes
2017-03-24 20:30:53 -07:00
Samuel Attard
aa5c778ca2 Generic doc fixes 2017-03-25 12:37:07 +11:00
Hari Juturu
d95114016d V8 dev resources (#9008)
* Adding V8 documentation links

* Removing extra space

* use electron markdown conventions

* cross-link v8 and chromium dev docs

* fix v8 link
2017-03-24 15:40:23 -07:00
Zeke Sikelianos
32f278d92b Merge pull request #8988 from electron/chromium-dev-resources
document resources for tracking chromium development
2017-03-24 11:21:29 -07:00
Zeke Sikelianos
095df457b2 fix docs for thumbnailSize 2017-03-24 11:14:43 -07:00
mst128256
6a7b4feb35 Fixed for linting 2017-03-24 12:31:49 +01:00
mst128256
9e471d8f1c Added specs 2017-03-24 12:14:08 +01:00
Thiago de Arruda
437f1192d9 Add initial documentation for sandbox option. 2017-03-23 21:42:25 -03:00
Felix Rieseberg
d5c4ad5e2c 📝 Improve notification docs 2017-03-23 14:12:35 -07:00
Cory Reed
a92f639b64 📝 Add note regarding dynamic addition/removal of menu items.
Closes #8928.

[ci skip]
2017-03-23 11:57:44 -07:00
deepak1556
93b444eef9 net: catch source stream creation failure for content encoding 2017-03-23 23:36:05 +05:30
Thiago de Arruda
a5eef516a7 Fix indent in api-crash-reporter-spec.js 2017-03-23 10:01:02 -03:00
Thiago de Arruda
5ee6205c0a Run the crash reporter specs with sandbox option.
- Create a function that accepts BrowserWindow options and generates a suite
  that contains the renderer-specific tests.
- Run the function twice to execute the tests with and without sandbox option.
2017-03-23 10:01:02 -03:00
Thiago de Arruda
3a97cfc359 Expose crashReporter to sandbox 2017-03-23 10:01:02 -03:00
Thiago de Arruda
bf756e3c00 Prevent browserify from leaking the require function
Define a "require" argument in the wrapper functions that runs browserify
bundles, which will prevent browserify from leaking the require function.

Note that this doesn't affect the isolated renderer script, only when `-r` flag
is passed to browserify command it will export a require function. It is still
added to isolated renderer script to prevent future mistakes(doesn't hurt
defining a "require" local).
2017-03-23 10:01:02 -03:00
Thiago de Arruda
e1aebef57c Make sandbox APIs more compatible with normal renderers
- Expose remote shortcuts for the `fs`, `os` and `child_process` modules.
- Expose the `url` and `timers` modules(the browserify versions)
- Add `process.crash` and `process.platform`
2017-03-23 10:01:02 -03:00
Zeke Sikelianos
360d2b45f4 document resources for tracking chromium development 2017-03-22 22:59:11 -07:00
Zeke Sikelianos
d22910f554 mention tilde 2017-03-22 16:13:24 -07:00
Kevin Sawicki
46aed5ff6f Bump v1.6.4 2017-03-22 09:16:08 -07:00
Cheng Zhao
e539129db2 Merge pull request #8852 from electron/web-worker-hook
Add Node.js integration to WebWorker
2017-03-22 09:01:42 -07:00
Cheng Zhao
c1a478179e Merge pull request #8971 from electron/fix-freeenvironment-crash
node::Environment should be destroyed before AtomBindings
2017-03-22 09:00:38 -07:00
Hansen Zhang
426563a843 #8881 - Display '&' in MenuItem label 2017-03-22 11:52:25 -04:00
deepak1556
4ab2c92418 CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents 2017-03-22 07:30:36 +05:30
Kevin Sawicki
f7e3f9035d Merge pull request #8974 from electron/default-popup-async-value
Default async to false when object is specified
2017-03-21 06:36:29 -07:00
Kevin Sawicki
23b235c9c7 Default async to false when object is specified 2017-03-20 20:37:52 -07:00
Cheng Zhao
99d3fce3c7 node::Environment should be destroyed before AtomBindings
The shutdown code may still uses the APIs provieded by AtomBindings.
2017-03-20 13:01:28 -07:00
Cheng Zhao
71c3e97e81 Fix docs lint warnings 2017-03-20 12:52:46 -07:00
Cheng Zhao
0287f23e3b Fix cpplint warning 2017-03-20 12:52:46 -07:00
Cheng Zhao
40b35a991f Fix js lint 2017-03-20 12:52:46 -07:00
Cheng Zhao
940d77b9a0 Fix typos and adjust sentences 2017-03-20 12:52:46 -07:00
Cheng Zhao
033aa16e04 test: Node integration in web workers 2017-03-20 12:52:46 -07:00
Cheng Zhao
ab83aa0bfd docs: Multithreading 2017-03-20 12:52:46 -07:00
Cheng Zhao
a49af26e39 Add nodeIntegrationInWorker option 2017-03-20 12:52:46 -07:00
Cheng Zhao
e496e18f6e Make Archive thread safe 2017-03-20 12:52:46 -07:00
Cheng Zhao
c068285ff8 AtomBindings should not use default uv loop 2017-03-20 12:52:46 -07:00
Cheng Zhao
9c9c8ec5f1 WebWorkerObserver should be destroyed on exit 2017-03-20 12:52:46 -07:00
Cheng Zhao
d2f185bea5 Create new uv loop in each worker 2017-03-20 12:52:46 -07:00
Cheng Zhao
69df934710 Converter for base::Callback is not thread safe 2017-03-20 12:52:45 -07:00
Cheng Zhao
bb5ad4ac05 Correctly initialize Node environment in worker 2017-03-20 12:52:45 -07:00
Cheng Zhao
b467c3939e Add a new type of NodeBindings 2017-03-20 12:52:45 -07:00
Cheng Zhao
aac934b34e Update native_mate: Make Wrappable thread safe 2017-03-20 12:52:45 -07:00
Cheng Zhao
2cbdb6bac3 Wrap ContextCreated with context scope 2017-03-20 12:52:45 -07:00
Cheng Zhao
e017e157ba Insert node integrations into WebWorker 2017-03-20 12:52:45 -07:00
Kevin Sawicki
253caf35ab Merge pull request #8955 from babanesma/feat/new-clean-command
Feat/new clean command
2017-03-20 10:36:19 -07:00
Kevin Sawicki
2d638e5da7 Add option to clean.py to only remove dist and out dirs 2017-03-20 10:33:04 -07:00
Kevin Sawicki
6ded27f3a9 Merge pull request #8878 from TanninOne/patch-1
Update browser-window.md
2017-03-20 10:14:23 -07:00
Kevin Sawicki
caae03f954 Use rendered language in both ready-to-show docs 2017-03-20 10:13:45 -07:00
Kevin Sawicki
286f529968 Merge pull request #8890 from twolfson/dev/proxy.to.string.sqwished
🐛 Add toString support to remote functions
2017-03-20 09:35:51 -07:00
Kevin Sawicki
75d934e4a2 Merge pull request #8962 from feserafim/patch-1
Update README.md
2017-03-20 09:35:09 -07:00
deepak1556
72adbf7a2f destroy guest webcontents before embedder 2017-03-19 10:25:13 +05:30
Felipe Serafim
deef2da87c Update README.md
Correcting some Spanish words mistakes.
2017-03-18 23:23:14 +01:00
deepak1556
16f9754445 Create separate request context for geolocation service.
* Geolocation service cannot hold reference to browser context,
    since it is destroyed at the end of everything and this will
    confuse the shutdown path of browser context.
  * Geolocation service run on its own thread.
2017-03-19 01:11:55 +05:30
Adham Saad
8060b0966f 🐛 #8919 - fix typo 2017-03-17 20:47:20 +02:00
Adham Saad
487a195320 🐛 #8919 - add new command to the docs 2017-03-17 20:44:18 +02:00
Kevin Sawicki
a215e8fb82 Merge pull request #8954 from electron/mark-touchbar-apis-with-experimental-label
Mark touch bar apis with _Experimental_ in docs
2017-03-17 11:02:46 -07:00
Kevin Sawicki
6f047fd4b7 Mark touch bar apis with _Experimental_ 2017-03-17 10:56:41 -07:00
Kevin Sawicki
64984ac23b Merge pull request #8942 from electron/read-binary-data-from-clipboard
Add clipboard.readBuffer(format)
2017-03-17 10:56:24 -07:00
Kevin Sawicki
f119bc0944 Remove unused args param 2017-03-17 10:35:54 -07:00
Kevin Sawicki
c50b518493 Check toString after loading remote properties 2017-03-17 10:29:07 -07:00
Kevin Sawicki
648d3324fb Add spec for remote function with toString property 2017-03-17 10:28:23 -07:00
Kevin Sawicki
11a4c7e408 🎨 2017-03-17 09:57:17 -07:00
Kevin Sawicki
3ae034deab Change data -> format in clipboard docs 2017-03-17 09:57:17 -07:00
Kevin Sawicki
ab05346572 Add clipboard.readBuffer 2017-03-17 09:57:17 -07:00
Kevin Sawicki
0e55e5cbb5 Add initial spec for clipboard.readBuffer 2017-03-17 09:57:17 -07:00
Kevin Sawicki
fe5db82d47 Merge pull request #8926 from electron/upgrade-libcc-for-heap-snapshot-patch
Upgrade libcc and brightray to latest
2017-03-17 09:55:39 -07:00
Kevin Sawicki
f71353a4c5 Merge pull request #8939 from electron/expose-remote-to-sandbox
Expose remote module to sandbox
2017-03-17 09:41:59 -07:00
Kevin Sawicki
9642381c02 Upgrade to libcc 44448acf 2017-03-17 09:37:28 -07:00
Kevin Sawicki
a35cce5f7a Enable takeHeapSnapshot spec 2017-03-17 09:14:17 -07:00
Kevin Sawicki
469ab8b509 Upgrade libcc for heap snapshot patch 2017-03-17 09:14:17 -07:00
Todd Wolfson
818738ce84 🐛 Add toString support to remote functions 2017-03-17 08:21:37 -07:00
Thiago de Arruda
e9b955b9ec Use remote/fs to read preload script during sandboxed setup
Also expose the "fs" module to preload scripts, as a shortcut to
`require('electron').remote.require('fs')`
2017-03-16 14:23:00 -03:00
Thiago de Arruda
f6befbe764 Expose lib/renderer/api/remote.js to sandboxed renderer 2017-03-16 14:21:23 -03:00
Kevin Sawicki
6d45052eea Merge pull request #8900 from electron/handle-buffer-instances-in-sandbox
Handle Buffer deserialization in sandboxed renderers
2017-03-16 10:12:09 -07:00
Thiago de Arruda
a6e4867111 Handle Buffer deserialization in sandboxed renderers
In sandboxed renderers we use browserify to provide a node-like environment. The
Buffer class used by browserify is actually just a wrapper around Uint8Array,
but to deserialize Buffer correctly we must expose the class as a hidden value
and use it in V8ValueConverter.
2017-03-16 13:20:09 -03:00
Kevin Sawicki
da0d0e7aac Merge pull request #8910 from electron/touchbar-scrubber
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Adham Saad
713e256843 🐛 #8919 - add new command that cleans only out & dist dirs 2017-03-16 13:34:53 +02:00
Kevin Sawicki
e98ac94d51 🎨 2017-03-15 11:22:31 -07:00
Kevin Sawicki
bc31f05404 highlightedStyle -> overlayStyle 2017-03-15 09:47:07 -07:00
Kevin Sawicki
f41db87e47 Use NSZeroRect for scrubber frame 2017-03-15 09:45:50 -07:00
Kevin Sawicki
466c39ed19 Use icon for consistency with other touch bar APIs 2017-03-15 09:33:11 -07:00
Kevin Sawicki
019883f2fa Merge pull request #8899 from electron/dynamically-generate-browserify-dep-list
Dynamically generate dependencies of browserify build actions
2017-03-15 09:12:31 -07:00
Cheng Zhao
5200b1a1ab Merge pull request #8435 from electron/pdf_rendering
browser: implement native pdf rendering
2017-03-15 18:36:50 +09:00
Kevin Sawicki
49d48a4eb0 Add more non-default options to scrubber spec 2017-03-14 14:15:04 -07:00
Kevin Sawicki
87c219748d Document more constructor options 2017-03-14 14:12:41 -07:00
Kevin Sawicki
2e0e4e69bb Drop on prefix from property names 2017-03-14 14:02:48 -07:00
Kevin Sawicki
6175ee05e2 Remove unneeded long cast 2017-03-14 13:59:29 -07:00
Kevin Sawicki
8b7675baee Add more forward declarations for scrubber APIs 2017-03-14 13:57:39 -07:00
Kevin Sawicki
eeccdf967c Merge pull request #8924 from electron/update-appveyor-badge
Update AppVeyor badge URL
2017-03-14 13:18:04 -07:00
Bret Comnes
b67c81226c fix linting 2017-03-14 10:48:44 -07:00
Kevin Sawicki
069baf8cd8 Update AppVeyor badge URL 2017-03-14 10:13:53 -07:00
Samuel Attard
a55cddaa53 Add more options 2017-03-14 18:57:57 +11:00
Bret Comnes
85c48a2336 make main process example shorter 2017-03-13 17:20:11 -07:00
Bret Comnes
2276357f72 update with a tree 2017-03-13 17:18:23 -07:00
Bret Comnes
f82590b9ab Wrap at 80 2017-03-13 15:48:42 -07:00
Bret Comnes
46af3cefec Clarify remote require of relative modules
The docs for the `remote.require(module)` method were a little too terse for me to understand the behavior of relative module loading for `remote.require` and I had to run an experiment to understand the behavior (e.g. is the relative path relative to caller of `remote.require` or relative to some other path in the project related to the main process?).   I think this is correct but someone please double check my understanding.

Adding an example and additional explanation should help clarify this.  Feel free to edit the copy as needed.
2017-03-13 15:42:26 -07:00
deepak1556
15e2b2335f address review comments 2017-03-14 00:26:27 +05:30
deepak1556
80ce60f644 spec: check if pdf has loaded 2017-03-14 00:26:27 +05:30
deepak1556
6e02d18a40 update submodules 2017-03-14 00:26:27 +05:30
deepak1556
6be779c777 update spec with new asset 2017-03-14 00:26:27 +05:30
deepak1556
d022d108a3 Dont intercept pdf request for subframes
Will not work without OOPIF support
2017-03-14 00:26:27 +05:30
deepak1556
4381e0895f propagate zoom changes to pdf plugin 2017-03-14 00:26:27 +05:30
deepak1556
eda413861a update spec 2017-03-14 00:26:27 +05:30
deepak1556
093cff5548 update libcc commit 2017-03-14 00:26:27 +05:30
deepak1556
b28e686228 code cleanup 2017-03-14 00:26:27 +05:30
deepak1556
b1b6573bcd build pdf resource in vendor/pdf_viewer 2017-03-14 00:26:27 +05:30
deepak1556
e5100cd103 Remove grit submodule 2017-03-14 00:26:27 +05:30
deepak1556
5a8e522526 StreamManager class is no longer required.
Stream lifetime is managed by webui
2017-03-14 00:26:27 +05:30
deepak1556
c982af991d request for pdf resource from the webui 2017-03-14 00:26:27 +05:30
Cheng Zhao
210f40dd53 Convert "\" to "/" in file:// url 2017-03-14 00:26:27 +05:30
Cheng Zhao
422b7acece Do not store resource_path as FilePath
On Windows the path value returned by PathWithoutParams also uses "/" as
separator, so there is no need to use the FilePath class.
2017-03-14 00:26:27 +05:30
Cheng Zhao
cca1db47ee Print error when path is not found 2017-03-14 00:26:27 +05:30
deepak1556
528853efbf handle reload api call from pdf ui 2017-03-14 00:26:27 +05:30
deepak1556
010193ef44 remove unused header 2017-03-14 00:26:27 +05:30
deepak1556
e4b97a3c93 update submodules to latest 2017-03-14 00:26:27 +05:30
deepak1556
6987e3ecd0 check if target stream is intercepted for correct request 2017-03-14 00:26:27 +05:30
deepak1556
ed89a603f3 update pdf_viewer to chrome 56.0.2924.87 2017-03-14 00:26:27 +05:30
deepak1556
b9710532e1 update api changes 2017-03-14 00:26:27 +05:30
deepak1556
07835bf4e6 update libcc commit 2017-03-14 00:26:27 +05:30
deepak1556
6e241c5e0d update submodule 2017-03-14 00:26:27 +05:30
deepak1556
bd9a9657aa disable node integration for chrome scheme 2017-03-14 00:26:27 +05:30
deepak1556
a4400dc549 add basic spec 2017-03-14 00:26:27 +05:30
deepak1556
3aba23b471 view_id=>stream_id and add some code comments. 2017-03-14 00:26:27 +05:30
deepak1556
e90fd1444f move constants to atom_constants.h 2017-03-14 00:26:27 +05:30
deepak1556
671a8a2cd6 address review comments 2017-03-14 00:26:27 +05:30
deepak1556
6cb626db88 use existing ipc message generator 2017-03-14 00:26:27 +05:30
deepak1556
56c0eb74ff update submodule 2017-03-14 00:26:27 +05:30
deepak1556
cc09b9ac7d BINDINGS_POLICY_WEB_UI is not required 2017-03-14 00:26:27 +05:30
Paul Betts
846d516584 Get us compiling on macOS 2017-03-14 00:26:27 +05:30
Paul Betts
8580a34f9f Get us compiling on Win32 2017-03-14 00:26:27 +05:30
deepak1556
2b64452d9c fix build config 2017-03-14 00:26:27 +05:30
deepak1556
3baa186c0a fix failing download spec 2017-03-14 00:26:27 +05:30
deepak1556
e767c59da2 enable pdf plugin by default 2017-03-14 00:26:27 +05:30
deepak1556
c15f6af892 fix crash when pdf viewer is reloaded 2017-03-14 00:25:59 +05:30
deepak1556
ddc2e0df71 code cleanup 2017-03-14 00:25:59 +05:30
deepak1556
de7dcdedba setup strings for ui 2017-03-14 00:25:59 +05:30
deepak1556
0c7bb72891 listen to ipc messages from plugin to perform SaveAs op 2017-03-14 00:25:59 +05:30
deepak1556
fd8c450ef3 move pdfviewer ui data source to separate file 2017-03-14 00:25:59 +05:30
deepak1556
008497500b update pdf_viewer submodule to use stream url 2017-03-14 00:25:59 +05:30
deepak1556
945e26750e manage the lifetime of streams created 2017-03-14 00:25:59 +05:30
deepak1556
0ab37da785 replace redundant mimetype helper with net utility 2017-03-14 00:25:59 +05:30
deepak1556
578b717b5f fix cpplint error 2017-03-14 00:25:59 +05:30
deepak1556
c8b932fce4 build pdf resources from submodule 2017-03-14 00:25:59 +05:30
deepak1556
c4dd2f4f56 add pdf webui as submodule 2017-03-14 00:25:59 +05:30
deepak1556
3c90fabab7 update pdf ui to work with webui 2017-03-14 00:25:59 +05:30
deepak1556
41c1623824 handle more messages from webui 2017-03-14 00:25:59 +05:30
deepak1556
a2db14476a create webui message handler 2017-03-14 00:25:59 +05:30
deepak1556
8a2b9c893e initialize webui with message handlers 2017-03-14 00:25:59 +05:30
deepak1556
a7ed7068f6 remove grit 2017-03-14 00:25:59 +05:30
deepak1556
be480fb634 import pdf ui 2017-03-14 00:25:59 +05:30
deepak1556
fdd574cea5 browser: implement pdf renderer as webui 2017-03-14 00:25:59 +05:30
Kevin Sawicki
5e70adb511 Guard against only specifying select or highlight handler 2017-03-13 11:23:27 -07:00
Kevin Sawicki
0dcdd60010 Add initial TouchBarScrubber spec 2017-03-13 11:17:55 -07:00
Kevin Sawicki
268dd1a6c2 Remove unneeded include 2017-03-13 11:15:36 -07:00
Kevin Sawicki
e52ece1a1e Implement NSScrubberDataSource in AtomTouchBar 2017-03-13 11:06:41 -07:00
Kevin Sawicki
4f31a5c452 Fix duplicate protocol method declaration 2017-03-13 10:39:42 -07:00
Kevin Sawicki
d7f458d232 Add protocol methods 2017-03-13 10:31:51 -07:00
Kevin Sawicki
2fe21ecdd0 🎨 2017-03-13 10:28:30 -07:00
Kevin Sawicki
37c9d76cd5 Take const references 2017-03-13 10:25:30 -07:00
Kevin Sawicki
dac6e0ce66 Sort filenames 2017-03-13 10:09:09 -07:00
Kevin Sawicki
634bd7b17f Add NSScrubber forward declarations 2017-03-13 10:07:48 -07:00
Kevin Sawicki
48152a813b Merge pull request #8907 from electron/plugin_list_patch
renderer: reset plugin cache when render frame is created
2017-03-13 09:22:21 -07:00
Kevin Sawicki
84e7387b17 Merge pull request #8906 from roramirez/docs-es
Add translated CODE_OF_CONDUCT.md and README.md for spanish language.
2017-03-13 09:11:30 -07:00
mst128256
76ee7fda2b Fixed linting 2017-03-13 14:26:34 +01:00
Samuel Attard
cfb3798703 Add docs for TouchBarScrubbber 2017-03-13 11:00:25 +11:00
Samuel Attard
a85ae27d68 Fix linting 2017-03-13 11:00:10 +11:00
Samuel Attard
25a231fc50 Initial NSScrubber implementation 2017-03-13 10:51:12 +11:00
Adham Saad
3b265747fe updating README 2017-03-12 14:17:03 +02:00
deepak1556
4281c73cf2 renderer: reset plugin cache when render frame is created 2017-03-12 00:53:39 +05:30
Rodrigo Ramírez Norambuena
eed098277c Add translated CODE_OF_CONDUCT.md and README.md for spanish language. 2017-03-10 22:24:00 -03:00
Kevin Sawicki
280337bf46 Merge pull request #8887 from electron/touchbar-segmneted-control
Touchbar segmented control
2017-03-10 14:43:12 -08:00
Thiago de Arruda
da023b72ee Dynamically generate dependencies of browserify build actions
Instead of having to list in filenames.gypi every javascript file that may go
into a browserify build, generate this list dynamically when the build files are
created by gyp.
2017-03-10 16:30:23 -03:00
Kevin Sawicki
5b1d5b39a2 Set automatic via else block 2017-03-10 10:11:56 -08:00
Kevin Sawicki
3349e32196 Verify selectedIndex to prevent NSRangeException 2017-03-10 10:09:18 -08:00
Kevin Sawicki
3b2faf7b89 Add initial TouchBarSegmentedControl spec 2017-03-10 10:04:22 -08:00
Kevin Sawicki
458e4be77c Add forward declaration for 10.12 API 2017-03-10 09:53:47 -08:00
Kevin Sawicki
7ef69a5af5 Merge pull request #8815 from tarruda/improve-sandbox-expose-more-modules
Improvements to sandbox mode
2017-03-10 09:23:31 -08:00
Zeke Sikelianos
582662e40f fix markdown link 2017-03-10 09:03:04 -08:00
Zeke Sikelianos
7fefb75de5 update versioning doc 2017-03-10 08:08:23 -08:00
Samuel Attard
bfe63d7a88 Fix linting 2017-03-10 17:56:26 +11:00
Samuel Attard
e6a66b6006 Add docs for segmented control touch bar item 2017-03-10 17:50:23 +11:00
Samuel Attard
1c027c526b Add segmented control implementation 2017-03-10 17:40:39 +11:00
Thiago de Arruda
dda2288541 Remove lib/renderer/api/ipc-renderer-setup.js
This file is no longer required since sandboxed renderer directly imports
ipc-renderer.js.
2017-03-09 20:40:32 -03:00
Thiago de Arruda
cd05834d96 Refactor sandboxed renderer init scripts
This change gives sandboxed renderer scripts a similar structure to what already
exists in the lib/{browser,renderer,common} directories.

It also allows sandboxed renderer initialization to share more code with
non-sandboxed renderers (ipcRenderer is now imported directly from
lib/renderer/api/ipc-renderer).
2017-03-09 20:39:14 -03:00
Thiago de Arruda
2b8203e383 Make sandboxed ipcRenderer API compatible with non-sandboxed version 2017-03-09 20:39:14 -03:00
Thiago de Arruda
d78f3cae7b Expose builtin v8 modules to AtomSandboxedRendererClient
- Adapt node.cc code that implements `process.binding` to create a similar
  object in AtomSandboxedRendererClient.
- Replace the ipc binding object passed to `lib/sandboxed_renderer/init.js` by
  the new binding object.
- Refactor the initialization script to use this new object to fetch the ipc
  binding and store as a hidden value using the `v8_util` module.

This change also required applying a patch to node.js, so the submodule commit
was updated.
2017-03-09 20:39:14 -03:00
Kevin Sawicki
85d66d2413 Merge pull request #8882 from electron/list-modules-in-separate-files
Refactor electron exports to keep module list in separate files
2017-03-09 15:36:02 -08:00
Thiago de Arruda
44bd93589a Refactor electron exports to keep module list in separate files 2017-03-09 19:08:01 -03:00
Kevin Sawicki
e79a22da5d Merge pull request #8883 from electron/pass-crash-reporter-upload-parameter
Pass `uploadToServer` parameter to linux crash reporter
2017-03-09 12:59:35 -08:00
Thiago de Arruda
e03e37e984 Pass uploadToServer parameter to linux crash reporter 2017-03-09 17:23:52 -03:00
Kevin Sawicki
14e8e463b3 Merge pull request #8864 from electron/zoom_controller_webview_patch
browser: track origin zoom with HostZoomMap
2017-03-09 11:27:34 -08:00
Kevin Sawicki
14b548f27a Merge pull request #8858 from electron/native-image-add-representation
Add nativeImage.addRepresentation API
2017-03-09 10:49:19 -08:00
Kevin Sawicki
f19998ef4c Add more default values 2017-03-09 10:26:44 -08:00
Kevin Sawicki
2946f624ac Add spec for adding representation to existing image 2017-03-09 09:56:42 -08:00
Kevin Sawicki
089bfd2cd2 Document nativeImage.addRepresentation(options) 2017-03-09 09:56:42 -08:00
Kevin Sawicki
6e977cbc3a Assert emptiness and size of built up images 2017-03-09 09:56:42 -08:00
Kevin Sawicki
7e039d92ec Support adding representation from data URL 2017-03-09 09:56:42 -08:00
Kevin Sawicki
d67863aa9f Add addRepresentation buffer support 2017-03-09 09:56:42 -08:00
Kevin Sawicki
17b70670f8 Add initial NativeImage.addRepresentation specs 2017-03-09 09:56:42 -08:00
Kevin Sawicki
783b5e84f4 Merge pull request #8866 from jkleinsc/master
Add WebRTCIPPolicy setting to webContents
2017-03-09 09:55:08 -08:00
Kevin Sawicki
ff5081816f Remove unneeded done call 2017-03-09 09:53:01 -08:00
mst128256
8aba640250 added default menu items for 'Edit' and 'Window' #2814 2017-03-09 16:01:33 +01:00
John Kleinschmidt
3c74404a3e Updated docs. 2017-03-09 09:54:09 -05:00
TanninOne
410e80682a Update browser-window.md
Notes that maximize will also show the window and that ready-to-show won't fire if the window is already being displayed. (See issue #8861)
2017-03-09 15:41:31 +01:00
John Kleinschmidt
d5a658bbe4 Fixed pass by reference and added spec 2017-03-08 22:06:26 -05:00
Kevin Sawicki
c004cf0894 Merge pull request #8870 from electron/touch-bar-links
Add more links to touch bar docs
2017-03-08 13:16:09 -08:00
Kevin Sawicki
dcfab1b6a0 Link more touch bar params 2017-03-08 13:04:55 -08:00
John Kleinschmidt
950e3436c2 Removed webrtcippolicy attribute from webview 2017-03-08 13:52:04 -05:00
John Kleinschmidt
1c2a78a896 Add WebRTCIPPolicy setting to webContents and webview
Resolves #8777
Code to set and get the policy come from the muon framework code:
https://github.com/brave/muon/blob/master/atom/browser/api/atom_api_web_
contents.cc#L1324...L1343
2017-03-08 10:15:48 -05:00
deepak1556
224ffe44aa add spec 2017-03-08 19:16:55 +05:30
deepak1556
b5cfa2e92d track host zoom levels with HostZoomMap 2017-03-08 19:03:43 +05:30
Kevin Sawicki
4f817873f1 Merge pull request #8849 from electron/to-data-url-scale-factor
Support scale factor in more NativeImage APIs
2017-03-07 12:55:56 -08:00
Kevin Sawicki
31cae8e1aa Add more scale factor specs 2017-03-07 12:34:31 -08:00
Kevin Sawicki
8852b128ec Add GetScaleFactorFromOptions helper 2017-03-07 12:27:55 -08:00
Kevin Sawicki
6d5fbe6be2 Document scale factor option 2017-03-07 12:27:55 -08:00
Kevin Sawicki
82a81bb26e Support scale factor to buffer APIs 2017-03-07 12:27:55 -08:00
Kevin Sawicki
e4ead6d018 Remove hasRepresentation and just use 1x png result 2017-03-07 12:27:55 -08:00
Kevin Sawicki
c11cdf321b Support toPNG on image without 1x representation 2017-03-07 12:27:55 -08:00
Kevin Sawicki
8bc65ef495 Add failing spec for toPNG with scale factor 2017-03-07 12:27:55 -08:00
Kevin Sawicki
86babdd412 Remove unused include 2017-03-07 12:27:55 -08:00
Kevin Sawicki
50ade57700 Add more hasRepresentation asserts 2017-03-07 12:27:55 -08:00
Kevin Sawicki
0bbbeb307e Support toDataURL without 1x representation 2017-03-07 12:27:55 -08:00
Kevin Sawicki
8eaf48e552 Add spec for 1x1 PNG data URL 2017-03-07 12:27:55 -08:00
Kevin Sawicki
b46e48cae1 Add failing toDataURL spec 2017-03-07 12:27:55 -08:00
Kevin Sawicki
c0d57d609e Merge pull request #8845 from electron/promise-resolve-assignment
Assign Promise.resolve to constant
2017-03-07 12:27:40 -08:00
Kevin Sawicki
dbe9893d29 Assign Promise.resolve to constant 2017-03-07 12:10:09 -08:00
Kevin Sawicki
e0260d6f53 Bump v1.6.3 2017-03-07 09:49:39 -08:00
Kevin Sawicki
5b8fcb740c Merge pull request #8856 from electron/touch-bar-experimental
Mark TouchBar API as experimental
2017-03-07 09:48:59 -08:00
Kevin Sawicki
bb8d42f1e1 Mark TouchBar as experimental 2017-03-07 09:42:45 -08:00
Kevin Sawicki
8d512de157 Merge pull request #8851 from joaomoreno/joaomoreno-patch-1
Update `ses.resolveProxy` return type
2017-03-07 09:35:29 -08:00
Samuel Attard
f97066511f Capitalize type 2017-03-07 21:25:40 +11:00
João Moreno
5a4d9807ee Update ses.resolveProxy return type
As far as I'm aware, after using the `ses.resolveProxy` API, it seems to return a string in the shape of `PROXY foopy:80;SOCKS5 bar.com:1080`, not an object. Correct me if I'm wrong.
2017-03-07 11:21:51 +01:00
Kevin Sawicki
9547ff135f Merge pull request #8744 from electron/MarshallOfSound-patch-1
Ensure userGesture is boolean when calling executeJavaScript
2017-03-06 11:19:23 -08:00
Kevin Sawicki
6bc464d4b0 Mention userGesture default 2017-03-06 10:51:48 -08:00
Kevin Sawicki
6240e30be1 Default hasUserGesture to false when null 2017-03-06 10:51:17 -08:00
Kevin Sawicki
6fcb784f6e Add failing spec for no callback 2017-03-06 10:49:23 -08:00
Samuel Attard
095e79b043 Ensure the callback is a function when executing JS 2017-03-06 10:46:20 -08:00
Kevin Sawicki
f549bda9fc Merge pull request #8799 from nitsakh/baseURLForDataURL
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713 Merge pull request #8724 from electron/defer_load_url
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
479af3c9e2 Merge pull request #8678 from liusy182/download-item
only emit `download-item done` event once
2017-03-06 10:11:22 -08:00
Kevin Sawicki
94b7fef30f Merge pull request #8604 from electron/groundwater-patch-1
Emphasize asking for repo URL in bug reports
2017-03-06 09:48:36 -08:00
Kevin Sawicki
e485ff6cea Incorporate feedback 2017-03-06 09:48:11 -08:00
Kevin Sawicki
d26e4a4abf Merge pull request #8800 from electron/https-website
Update website URLs to use HTTPS
2017-03-06 09:32:20 -08:00
Kevin Sawicki
cb66a769d4 Merge pull request #8795 from electron/rename-shortcuts-to-keyboard-shortcuts
Rename shortcuts to keyboard shortcuts
2017-03-06 09:30:55 -08:00
Kevin Sawicki
8b53ff3900 Merge pull request #8840 from Yarkhan/patch-1
Correcting typo
2017-03-06 09:27:38 -08:00
Kevin Sawicki
c7d3d48875 Merge pull request #8837 from rhysd/fix-touchbar-doc
Fix TouchBarSpacer class name in doc
2017-03-06 09:25:57 -08:00
Kevin Sawicki
9234bddc38 Merge pull request #8834 from electron/tb-doc-fixups
Add more explicit types to docs for TouchBar
2017-03-06 09:25:29 -08:00
Cheng Zhao
aaa8e81cd4 Merge pull request #8811 from electron/clean-node-on-exit
Clean up node Environment on exit
2017-03-06 20:36:59 +09:00
Yarkhan
ef5c2bbded Correcting typo 2017-03-05 20:40:18 -03:00
deepak1556
90885d1d8c simply spec 2017-03-06 00:22:20 +05:30
deepak1556
e936143da2 listen for browser initiated pending nav entries too 2017-03-06 00:21:52 +05:30
deepak1556
eb827eb020 update spec 2017-03-06 00:10:46 +05:30
deepak1556
dead1ae1ba webContents: defer url load when there is a pending navigation entry 2017-03-06 00:10:46 +05:30
rhysd
c209b886bf fix TouchBarSpacer class name in doc 2017-03-05 15:09:57 +09:00
Samuel Attard
f97ee56c9f Add more explicit types to docs for TouchBar 2017-03-04 16:14:41 +11:00
Kevin Sawicki
e315116336 Merge pull request #8830 from electron/touchbar-label-color
Support setting TouchBarLabel text color
2017-03-03 15:51:16 -08:00
Kevin Sawicki
4d6c779839 identList -> identifiers 2017-03-03 15:28:32 -08:00
Kevin Sawicki
b879872317 Always set properties in update calls 2017-03-03 15:24:32 -08:00
Kevin Sawicki
2680ee9f8f Add support for setting TouchBarLabel text color 2017-03-03 15:14:51 -08:00
Kevin Sawicki
0098822fcf Merge pull request #8095 from electron/touchbar
Add TouchBar Support
2017-03-03 14:37:56 -08:00
Kevin Sawicki
9f323104e7 Remove unused include 2017-03-03 14:11:09 -08:00
Kevin Sawicki
edebb32014 Drop nullable for consistency 2017-03-03 14:07:59 -08:00
Kevin Sawicki
fde310f50d Mention it only effects 10.12.1 with touch bar 2017-03-03 14:04:55 -08:00
Kevin Sawicki
d9a8c15c69 Add clover to possible values 2017-03-03 14:00:39 -08:00
Kevin Sawicki
ca2898a60e Check that window responds to touchBar selector for pre-10.12.1 compat 2017-03-03 14:00:39 -08:00
Kevin Sawicki
c349aeff80 Add initial touch bar specs 2017-03-03 14:00:39 -08:00
Kevin Sawicki
002369576f Add initial touch bar docs 2017-03-03 14:00:39 -08:00
Kevin Sawicki
81ecd4499c Make exported properties match class names 2017-03-03 14:00:39 -08:00
Kevin Sawicki
eb03ab561d Make config optional 2017-03-03 14:00:39 -08:00
Kevin Sawicki
ce12dcd3b4 Add live popover icon property 2017-03-03 14:00:39 -08:00
Kevin Sawicki
a34f9d3583 Support icon property to match MenuItem 2017-03-03 14:00:39 -08:00
Kevin Sawicki
506b42b563 🎨 2017-03-03 14:00:39 -08:00
Kevin Sawicki
ecc0478e3c Match Popover casing in macOS APIs 2017-03-03 14:00:39 -08:00
Kevin Sawicki
79b17c2cd9 Expose TouchBar on remote module 2017-03-03 14:00:39 -08:00
Kevin Sawicki
d1edd80ef8 Use NSTouchBar itemForIdentifier to lookup existing item 2017-03-03 14:00:39 -08:00
Kevin Sawicki
8d716e8b17 Register item after validating 2017-03-03 14:00:39 -08:00
Kevin Sawicki
93bbe8e70b Use device NS colors consistently 2017-03-03 14:00:39 -08:00
Kevin Sawicki
70d61869a5 Use array to create empty NSMutableArray 2017-03-03 14:00:39 -08:00
Kevin Sawicki
76f112ffc5 Only export TouchBar to start 2017-03-03 14:00:39 -08:00
Kevin Sawicki
5fe3ac60fa Check that atom_touch_bar_ is set 2017-03-03 14:00:39 -08:00
Kevin Sawicki
708ed9d1cd Store ordered settings in AtomTouchBar 2017-03-03 14:00:39 -08:00
Kevin Sawicki
5f9e9d4b36 Add move live updating properties 2017-03-03 14:00:39 -08:00
Kevin Sawicki
61aa9bbff4 Add support for spacer items 2017-03-03 14:00:39 -08:00
Kevin Sawicki
f153d08297 Support setting the initial/available colors 2017-03-03 14:00:39 -08:00
Kevin Sawicki
f9dd91d54d Add static helper to bind touch bar to window 2017-03-03 14:00:39 -08:00
Kevin Sawicki
51f1c5a557 Use SetTouchBar withe empty vector instead of DestroyTouchBar 2017-03-03 14:00:39 -08:00
Kevin Sawicki
d5dbe3676e Add window helpers to TouchBar class 2017-03-03 14:00:39 -08:00
Kevin Sawicki
347d472841 Remove unused clear method 2017-03-03 14:00:39 -08:00
Kevin Sawicki
b959f782f6 Rename instance variable maps 2017-03-03 14:00:39 -08:00
Kevin Sawicki
ec500b2852 Use scoped_nsobject to match Chrome implementation 2017-03-03 14:00:38 -08:00
Kevin Sawicki
812beb240b Remove unneeded includes 2017-03-03 14:00:38 -08:00
Kevin Sawicki
823b3baed0 Use vector of dictionaries instead of mate::Arguments 2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11 Initial support for dynamic properties 2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e Store event listeners in each TouchBar class 2017-03-03 14:00:38 -08:00
Kevin Sawicki
1972e2eff9 Update renamed variable 2017-03-03 14:00:38 -08:00
Kevin Sawicki
28f2a4951b touch_bar_helper_ -> atom_touch_bar_ 2017-03-03 14:00:38 -08:00
Kevin Sawicki
b39b49a15a Rename to touch_bar_helper_ to differentiate from touchBar property 2017-03-03 14:00:38 -08:00
Kevin Sawicki
14ef5c5957 Reset helper when makeTouchBar is called 2017-03-03 14:00:38 -08:00
Kevin Sawicki
ca29ec0101 Use reference 2017-03-03 14:00:38 -08:00
Kevin Sawicki
f297ba987e touchBarFromMutatableArray -> touchBarFromItemIdentifiers 2017-03-03 14:00:38 -08:00
Kevin Sawicki
b30f7c3c94 Use std::string ctor 2017-03-03 14:00:38 -08:00
Kevin Sawicki
8500538793 Use base::SysUTF8ToNSString helper 2017-03-03 14:00:38 -08:00
Kevin Sawicki
cf7cd1f32b hasTBDict -> hasItemWithID 2017-03-03 14:00:38 -08:00
Kevin Sawicki
48515d9ecc Ignore objective-c header lint 2017-03-03 14:00:38 -08:00
Kevin Sawicki
b632cdd37d Extract helper class to encapsulate touch bar items 2017-03-03 14:00:38 -08:00
Kevin Sawicki
1b5149ae7a Few memory and scope tweaks 2017-03-03 14:00:38 -08:00
Kevin Sawicki
b16d649819 Use skia color helpers 2017-03-03 14:00:38 -08:00
Kevin Sawicki
eff49ad19c Return early when touchBar is null 2017-03-03 14:00:38 -08:00
Kevin Sawicki
69638a399c Make touchBar readwrite/nullable 2017-03-03 14:00:38 -08:00
Kevin Sawicki
d4d3c78701 Ignore lint warnings in Objective-C header 2017-03-03 14:00:38 -08:00
Kevin Sawicki
9bdca3bbfb Remove linter warnings 2017-03-03 14:00:38 -08:00
Kevin Sawicki
9272582bd6 Revert default_app changes 2017-03-03 14:00:38 -08:00
Kevin Sawicki
52905ae9b3 Get compiling against 10.10 SDK 2017-03-03 14:00:38 -08:00
Kevin Sawicki
2a00bb30c5 Use new NativeWindowObserver helper 2017-03-03 14:00:38 -08:00
Samuel Attard
ba3fbc9d1b Fix Group items 2017-03-03 14:00:38 -08:00
Samuel Attard
28d5c8bbde Add updateConfig ability to other items 2017-03-03 14:00:38 -08:00
Samuel Attard
dd09c91cf2 initial work on updating touch bar item config without rerender 2017-03-03 14:00:38 -08:00
Samuel Attard
61949657f0 Some docs for touch bar 2017-03-03 14:00:38 -08:00
Samuel Attard
15dcc314d3 Export the TouchBar items as their own props on the electron main export 2017-03-03 14:00:38 -08:00
Samuel Attard
d1b3ba39bd Fix cpp linting 2017-03-03 14:00:38 -08:00
Samuel Attard
4f0caffc3b Fix JS linting 2017-03-03 14:00:38 -08:00
Samuel Attard
257b32b84b Remove unused ident 2017-03-03 14:00:38 -08:00
Samuel Attard
43cc5079d8 Implement group item 2017-03-03 14:00:38 -08:00
Samuel Attard
269d899a99 Implement popOver item type (woo hoo it worked) 2017-03-03 14:00:38 -08:00
Samuel Attard
2bc45c8665 Change demo touchbar values 2017-03-03 14:00:38 -08:00
Samuel Attard
c92c4138a8 Add Slider item type and add options to the button type 2017-03-03 14:00:38 -08:00
Samuel Attard
18c7c3ece8 Make label and colorpicker types work 2017-03-03 14:00:38 -08:00
Samuel Attard
7857c83ea1 Make dynamic buttons work along with click events 2017-03-03 14:00:38 -08:00
Samuel Attard
703b5738c8 Initial TouchBar Magic
* Make the AtomNSWindow also a NSTouchbarDelegate
* Implement basic makeTouchBar and makeItemForIdentifier methods
* Initial sending of touch / update events through IPC to BrowserWindowObjects

TODO:
* JS API
* JS Object Converters
* Generalize methods so that popovers can work
2017-03-03 14:00:38 -08:00
Zeke Sikelianos
e027f4aacf Merge pull request #8816 from electron/webview-docs-fixes
Fix API docs for webview tag
2017-03-03 11:23:52 -08:00
Zeke Sikelianos
67dc1b1070 use updated docs linter with webview support 2017-03-03 10:53:30 -08:00
Nitish Sakhawalkar
d75db0ea1a Fixed js lint issues. 2017-03-02 14:37:09 -08:00
Zeke Sikelianos
ffc7a4c8a0 move platform labels to end of description for consistency 2017-03-02 13:57:04 -08:00
Zeke Sikelianos
23eecac288 document arguments for webview methods 2017-03-02 13:29:46 -08:00
Zeke Sikelianos
5ee7434a54 fix indentation of app.setLoginItemSettings arguments 2017-03-02 13:28:58 -08:00
Zeke Sikelianos
01423f79b3 denote webview process so linter will recognize it as an API 2017-03-02 13:27:04 -08:00
Nitish Sakhawalkar
370562b129 Moving data url test outside post navigation block. Trailing separator comment in the docs. 2017-03-02 12:14:18 -08:00
Nitish Sakhawalkar
e8c0813f46 Changes based on review. 2017-03-02 10:58:39 -08:00
Nitish Sakhawalkar
bcda67b8eb No more extra whitespace. 2017-03-02 10:50:48 -08:00
Kevin Sawicki
8f7785bb05 Merge pull request #8806 from electron/felix-winstore-moved
Fix init check for process.windowsStore
2017-03-02 10:35:08 -08:00
Kevin Sawicki
e51a4f0af1 Merge pull request #8804 from electron/isolated-world-origin
Set context isolation origin policy
2017-03-02 09:16:51 -08:00
Kevin Sawicki
7fb77ee1cb Set isolated world security origin 2017-03-02 08:49:18 -08:00
Kevin Sawicki
7f6283352f Add failing spec for fetch from isolated world 2017-03-02 08:49:18 -08:00
Cheng Zhao
cf198904a4 Fix cpplint warnings 2017-03-02 17:26:15 +09:00
Cheng Zhao
1709e74958 Fix crash when the main frame is replaced 2017-03-02 17:19:00 +09:00
Cheng Zhao
24574f7299 Avoid touch an Environemnt after it gets destroyed 2017-03-02 17:19:00 +09:00
Cheng Zhao
29278e500b Destroy node environment when a JS context in renderer is destroyed 2017-03-02 17:19:00 +09:00
Cheng Zhao
d379b05890 async handles should be closed on exit 2017-03-02 17:19:00 +09:00
Cheng Zhao
a0605275b9 Clean up node environment on exit in main process 2017-03-02 17:19:00 +09:00
Nitish Sakhawalkar
c06c4c0ccb Reverting formatting changes made by clang format. 2017-03-01 14:04:41 -08:00
Felix Rieseberg
4aaa936803 Fix init check for process.windowsStore
Windows now allows users to move their `WindowsApps` folder, meaning that it can end up on a different drive (and outside of `Program Files`).
2017-03-01 11:48:51 -08:00
Kevin Sawicki
d009b3267a Bump v1.6.2 2017-03-01 09:11:05 -08:00
Kevin Sawicki
59e656586d Merge pull request #8801 from tomfloyer/patch-1
Fixed typo
2017-03-01 09:05:04 -08:00
Tom Floyer
34e21cb91f Fixed typo 2017-03-01 12:03:00 +03:00
Zeke Sikelianos
15bf7ed536 use https URLs for images 2017-02-28 21:24:31 -08:00
Zeke Sikelianos
166bf7ab8c link to default docs URL from default app nav 2017-02-28 21:21:34 -08:00
Zeke Sikelianos
69f0cb26e7 use https for all Electron website URLs 2017-02-28 21:19:55 -08:00
Nitish Sakhawalkar
879082b1a6 Issue #8735:Support base URL option to loadURL for data URLs 2017-02-28 16:49:03 -08:00
Kevin Sawicki
dba154b062 Merge pull request #8766 from electron/browser-require-in-renderer-process
Don't require browser process API in renderer process
2017-02-28 09:19:30 -08:00
Kevin Sawicki
7a99f0435b Fix typo in comment 2017-02-28 08:45:39 -08:00
Kevin Sawicki
bb1a981a01 Mention variable name to update 2017-02-28 08:45:39 -08:00
Kevin Sawicki
ca8983bf6c Add initial spec for remote modules 2017-02-28 08:45:39 -08:00
Kevin Sawicki
e8a79cb88d Don't require browser process module from renderer
This can cause issues when it is accessed from the
require cache or module tree since the getters throw
errors when called.
2017-02-28 08:45:39 -08:00
Kevin Sawicki
51d6a55061 Merge pull request #8742 from electron/webview-visibility
Route webview window visibility change events in browser process
2017-02-28 08:45:15 -08:00
Zeke Sikelianos
8e7a26ec25 link to keyboard shortcuts from docs README 2017-02-28 08:44:28 -08:00
Zeke Sikelianos
61bce3ef39 rename shortcuts to keyboard-shortcuts for clarity 2017-02-28 08:44:12 -08:00
Kevin Sawicki
54232ee21a Emit event after listener is registered 2017-02-28 08:23:00 -08:00
Kevin Sawicki
1d84d83fd4 Forward webview visibility change events from browser process 2017-02-28 08:23:00 -08:00
Kevin Sawicki
7564a9973b Use const instead of var 2017-02-28 08:23:00 -08:00
Kevin Sawicki
f4717b34e9 Register visibility change listener when attached 2017-02-28 08:23:00 -08:00
Kevin Sawicki
2f5f7721fc Merge pull request #8792 from LasseJacobs/master
Pull request, for dutch translation of glossary.md
2017-02-28 08:18:17 -08:00
Rik Theunis
5fe62d23d9 📝 Fix typos and grammatical errors.
[ci skip]
2017-02-27 23:23:39 +01:00
Lasse Jacobs
76e1f882c0 📝 Fix some grammar mistakes
[ci-skip]
2017-02-27 23:23:05 +01:00
Lasse Jacobs
19a948298b 📝 Fix some spelling mistakes
[ci-skip]
2017-02-27 23:15:51 +01:00
Zeke Sikelianos
5a173965ed Merge pull request #8775 from electron/shortcuts
add a guide to keyboard shortcuts
2017-02-27 09:48:49 -08:00
Zeke Sikelianos
250c656aa7 lint 2017-02-27 09:34:35 -08:00
Kevin Sawicki
776fd56e41 Merge pull request #8787 from serant/translation-doc-typo
Fix typo in translation doc for BrowserWindow
2017-02-27 08:54:02 -08:00
Kevin Sawicki
368da3300e Merge pull request #8783 from thesbros/docs/blink-features-link
📝 Update link to Blink features.
2017-02-27 08:53:34 -08:00
Kevin Sawicki
20a9cf834b Merge pull request #8769 from jwheare/docs-cancel-id
Clarify docs for dialog.showMessageBox cancelId
2017-02-27 08:52:59 -08:00
Zeke Sikelianos
f774ea857e remove electron-localshortcut recommendation 2017-02-27 08:20:23 -08:00
serant
6b138e0215 Fixed typo in translation doc for BrowserWindow 2017-02-27 11:01:44 -05:00
Oden
c10f1210bc 📝 Update link to Blink features. 2017-02-26 20:34:00 -08:00
Zeke Sikelianos
ba4a2d7c30 describe local shortcuts before global 2017-02-25 19:21:33 -08:00
Zeke Sikelianos
5c64075032 add section for browser window events 2017-02-25 19:07:09 -08:00
Zeke Sikelianos
32f44d7917 add a guide to keyboard shortcuts 2017-02-25 18:59:13 -08:00
Zeke Sikelianos
dd5fa2df85 Merge pull request #8746 from electron/clarify-app-activation
clarify actions that cause app.activate event to be emitted
2017-02-25 18:20:43 -08:00
James Wheare
cdc6b13fc8 Clarify docs for dialog.showMessageBox cancelId 2017-02-24 23:56:47 +00:00
Kevin Sawicki
8e4bdec6b6 Merge pull request #8758 from electron/use-local-buffer
Use local Buffer variable in module.js require wrapper
2017-02-24 10:35:35 -08:00
Kevin Sawicki
6c40b1eead Verify global.Buffer is undefined 2017-02-24 09:57:32 -08:00
Kevin Sawicki
ad03ba73a4 Upgrade node for Buffer wrapper fix 2017-02-24 09:57:32 -08:00
Kevin Sawicki
e6fec57bd8 Add failing spec for Buffer from preload required module 2017-02-24 09:57:32 -08:00
Kevin Sawicki
b936221b63 Merge pull request #8733 from electron/macos-cancel-id
Support explicit cancelId on macOS
2017-02-24 09:32:07 -08:00
Kevin Sawicki
be16e75be2 Support explicit cancelId on macOS 2017-02-24 09:05:55 -08:00
Kevin Sawicki
d01250eceb Merge pull request #8739 from electron/pepper-context-menu
Use owner browser window in pepper context menu
2017-02-24 09:05:33 -08:00
Kevin Sawicki
739f3ed102 Popup pepper menu in owner browser window 2017-02-24 08:39:22 -08:00
Kevin Sawicki
c951e253c6 Default to focused window whenever param is null/undefined 2017-02-24 08:39:22 -08:00
Kevin Sawicki
3e05350d6b Check that window is non-null before accessing constructor prop 2017-02-24 08:39:22 -08:00
Kevin Sawicki
5819acbc20 Merge pull request #8745 from electron/async-web-dialog-helper
Use callback dialog methods in RunFileChooser
2017-02-24 08:38:19 -08:00
Kevin Sawicki
ef085a1f15 Remove unneeded AddRef/Release calls handled by base::Bind 2017-02-24 08:15:02 -08:00
Kevin Sawicki
6837ec8576 Check render frame host before getting context 2017-02-24 07:49:26 -08:00
Kevin Sawicki
a62c2f9e2e Remove unused include 2017-02-24 07:37:28 -08:00
Kevin Sawicki
29f92bfb53 Extend RefCounted and add private destructor 2017-02-24 07:37:28 -08:00
Kevin Sawicki
a33ffd621f Use callback dialog methods in RunFileChooser 2017-02-24 07:37:28 -08:00
liusi
ff513f2a84 remove the call to download_item_->Remove() on cancel 2017-02-24 14:08:21 +08:00
Kevin Sawicki
cc688d7fa6 Merge pull request #8760 from popod/popod-startDrag-doc
update startDrag(item) doc
2017-02-23 13:45:22 -08:00
Kevin Sawicki
eb260c3593 Update parameter prefix 2017-02-23 13:03:22 -08:00
popod
ea3b14f0bb update startDrag(item) doc
add doc for `files` option
2017-02-23 21:28:36 +01:00
Zeke Sikelianos
7c4529a01a clarify actions that cause app.activate event to be emitted 2017-02-22 16:42:34 -08:00
Kevin Sawicki
62f4a77755 Merge pull request #8702 from electron/async-menu-popup
Add async menu.popup option
2017-02-22 12:50:57 -08:00
Kevin Sawicki
211bedf910 Invoke close callback after itemSelected runs 2017-02-22 11:47:58 -08:00
Kevin Sawicki
d0b07d5c36 Check that x is non-null 2017-02-22 10:49:25 -08:00
Kevin Sawicki
a8d1a7aed4 Make variables private instead of protected 2017-02-22 10:30:28 -08:00
Kevin Sawicki
2006e22aa4 🎨 2017-02-22 10:30:28 -08:00
Kevin Sawicki
6c6506e5aa Document menu.closePopup 2017-02-22 10:30:28 -08:00
Kevin Sawicki
ce5ac1b056 Implement ClosePopupAt on Windows/Linux 2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f Implement Menu.closePopup on Windows/Linux 2017-02-22 10:30:28 -08:00
Kevin Sawicki
0a5ccdccb4 Add spec for async Menu.popup 2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe Add Menu.closePopup API on macOS 2017-02-22 10:30:28 -08:00
Kevin Sawicki
947556a23f Move MenuItem spec into root describe 2017-02-22 10:30:28 -08:00
Kevin Sawicki
55f90b4a4b Add new menu.popup signature to planned breaking changes 2017-02-22 10:30:28 -08:00
Kevin Sawicki
d686cf77e9 Update menu.popup docs to take options object 2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb Map async option to MenuRunner::ASYNC flag 2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98 Add async option to menu.popup 2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5 Add async menu.popup on Windows/Linux 2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29 Add async menu.popup on macOS 2017-02-22 10:30:28 -08:00
Kevin Sawicki
85bdce0722 Merge pull request #8731 from herrmannplatz/patch-1
update setCertificateVerifyProc example
2017-02-22 08:22:21 -08:00
Kevin Sawicki
91bd95a0b2 Add space after if 2017-02-22 08:11:21 -08:00
René Herrmann
c4280612c1 update setCertificateVerifyProc example
setCertificateVerifyProc example should reflect new api
2017-02-22 11:49:14 +01:00
Lasse Jacobs
e5d82edf5d 📝 Add glossary.md to dutch translations part1
[ci skip] Add glossary.md with the first 8 topics.
2017-02-21 14:54:00 -08:00
Kevin Sawicki
92092bed41 Bump v1.6.1 2017-02-21 08:49:50 -08:00
Kevin Sawicki
f80af6e3ed Merge pull request #8718 from demopark/master
add translations files for zh-CN
2017-02-21 08:48:15 -08:00
Kevin Sawicki
1dd37eaab7 Merge pull request #8717 from gerhardberger/vibrancy-version-fix
Fix OS version check of vibrancy
2017-02-21 08:45:10 -08:00
DemoPark
c78d7fc125 add translations files for zh-CN
add zh-CN translations file - debug-instructions-windows.md
add zh-CN translations file - debugging-instructions-macos.md
update zh-CN translations file - README.md
2017-02-19 21:38:37 +08:00
gellert
a1ede4a4b0 fixes os version check of vibrancy 2017-02-18 20:25:03 +01:00
Kevin Sawicki
1f75df0253 Merge pull request #8693 from electron/zoom_specs
webContents: add basic zoom specs
2017-02-17 12:50:26 -08:00
deepak1556
a57af31b99 add zoom specs based on standard protocols 2017-02-18 01:41:39 +05:30
deepak1556
0c022fdc36 set zoom changes for in page navigaitons 2017-02-18 01:34:32 +05:30
deepak1556
403e7681c1 add basic webview zoom specs 2017-02-18 01:34:32 +05:30
deepak1556
c71b44048c address review comments 2017-02-18 01:34:32 +05:30
deepak1556
dfc2e6c4a8 add temporary zoom api spec 2017-02-18 01:34:32 +05:30
deepak1556
71fd3e807c use sync zoom api with guest view manager webpreferences 2017-02-18 01:34:32 +05:30
deepak1556
763b9ab8d8 add zoom spec 2017-02-18 01:34:32 +05:30
deepak1556
203a920c64 fix signature of zoom getter apis 2017-02-18 01:34:32 +05:30
Kevin Sawicki
5e30ccd891 Merge pull request #8709 from electron/upgrade-native-mate
Upgrade native_mate
2017-02-17 10:57:39 -08:00
Kevin Sawicki
e60601898d Upgrade native_mate 2017-02-17 10:25:20 -08:00
Kevin Sawicki
440e48fe19 Merge pull request #8707 from demopark/master
add translations files for zh-CN
2017-02-17 08:22:05 -08:00
Kevin Sawicki
91677ade89 Merge pull request #8704 from YurySolovyov/update-icon-fetch-impl
Update icon loading API implementation
2017-02-17 08:21:10 -08:00
DemoPark
529b84ff9c add translations files for zh-CN
add zh-CN translations file - clang-format.md
add zh-CN translations file - styleguide.md
update zh-CN translations file - README.md
2017-02-17 17:28:55 +08:00
deepak1556
5687f8b3b7 Destroy icon manager after file thread is destroyed 2017-02-17 14:16:18 +05:30
Yury Solovyov
977abc6458 Update icon loading API implementation 2017-02-16 23:16:34 +03:00
Kevin Sawicki
8fe025d6c9 Merge pull request #8695 from ericbrumer/master
[Win] Allow favicon.png to be on the root of any drive letter
2017-02-16 11:56:52 -08:00
Eric Brumer
87e606627c Smaller regex now that it's case insensitive 2017-02-16 09:26:20 -08:00
Eric Brumer
7cb101b566 Case insensitive filepath 2017-02-16 09:17:37 -08:00
Kevin Sawicki
19b686c90b Merge pull request #8696 from demopark/master
add translations files for zh-CN
2017-02-16 08:12:18 -08:00
DemoPark
6dd18678a9 add translations files for zh-CN
add zh-CN translations file - security.md
add zh-CN translations file - repl.md
add zh-CN translations file - windows-store-guide.md
update zh-CN translations file - glossary.md
update zh-CN translations file - README.md
2017-02-16 16:31:55 +08:00
Eric Brumer
d97585d06d Allow favicon.png to be on the root of any drive letter 2017-02-15 19:02:11 -08:00
Kevin Sawicki
a00bb332ca Merge pull request #8686 from demopark/master
Optimize zh-CN language logic and grammar
2017-02-15 12:27:06 -08:00
Kevin Sawicki
9a7ac5326c Merge pull request #8676 from electron/focus-delegate
Prevent invisible windows from being activated
2017-02-15 11:22:00 -08:00
Kevin Sawicki
70849de8c4 Mark constructor as explicit 2017-02-15 08:28:55 -08:00
Kevin Sawicki
52801c4a41 Use internal IsVisible method 2017-02-15 08:28:55 -08:00
Kevin Sawicki
db79f4f450 Implement Activate instead of CanFocus 2017-02-15 08:28:55 -08:00
Kevin Sawicki
bda8af8dd3 Just use visible state in CanFocus delegate 2017-02-15 08:28:55 -08:00
Kevin Sawicki
86007fe61d Update blur parent window spec 2017-02-15 08:28:55 -08:00
Kevin Sawicki
35908ac398 Add webContents.focus() spec 2017-02-15 08:28:55 -08:00
Kevin Sawicki
be79417a03 Include CanFocus on Windows and map to state 2017-02-15 08:28:55 -08:00
Kevin Sawicki
0ac3969c6a Merge pull request #8682 from electron/use-electron-version-in-chromedriver-asset-name
Use electron version in Chromedriver asset name
2017-02-15 08:28:43 -08:00
Kevin Sawicki
a0fc5ae63d Use electron version in Chromedriver asset name 2017-02-15 08:17:40 -08:00
DemoPark
1170ecb269 add zh-CN translations for offscreen-rendering.md
add zh-CN translations for offscreen-rendering.md
2017-02-15 17:45:52 +08:00
DemoPark
f79ce38a57 add zh-CN translations for electron-versioning.md
add zh-CN translations for 'electron-versioning.md'
2017-02-15 17:21:20 +08:00
Jonas Zhang
20aeec7cf5 Merge pull request #1 from demopark/demopark-patch-1
Optimize zh-CN language logic and grammar
2017-02-15 14:21:37 +08:00
Jonas Zhang
b3ab426a5e Optimize zh-CN language logic and grammar
Optimize zh-CN language logic and grammar.
2017-02-15 14:20:48 +08:00
Cheng Zhao
c127ce3e46 Merge pull request #8679 from electron/disable-active-tracker
Disable the ActiveVerifier
2017-02-15 11:04:36 +09:00
Kevin Sawicki
fe59f413f6 Merge pull request #8684 from electron/compiler-error
Rename variable for compiler error
2017-02-14 12:40:21 -08:00
Kevin Sawicki
36e6501c44 Rename variable for compiler error 2017-02-14 12:30:23 -08:00
Kevin Sawicki
9be42db8d5 Merge pull request #8628 from Spacetech/master
Implement invalidate for non-offscreen mode
2017-02-14 11:41:16 -08:00
Kevin Sawicki
52d989f908 Update docs for non-offscreen invalidate 2017-02-14 11:17:39 -08:00
Kevin Sawicki
643cb5d6de Remove unused variable 2017-02-14 11:13:23 -08:00
Kevin Sawicki
5cb6648686 Use underscore variable name for consistency 2017-02-14 11:12:30 -08:00
Kevin Sawicki
82f452568c 🎨 Minor formatting tweaks 2017-02-14 11:09:15 -08:00
Kevin Sawicki
897d58bde1 Merge pull request #8648 from electron/set-extra-crash-reporter-data
Support updating crash reporter extra parameters
2017-02-14 10:09:02 -08:00
Kevin Sawicki
272a0824e8 Fix darwin platform name 2017-02-14 09:37:09 -08:00
Kevin Sawicki
af7702d0f2 🎨 2017-02-14 09:37:09 -08:00
Kevin Sawicki
07173cdd9d Tweak setExtraParameter description 2017-02-14 09:37:09 -08:00
Kevin Sawicki
b51adf8ae5 Add spec for updated extra parameters 2017-02-14 09:37:09 -08:00
Kevin Sawicki
a4bbad03c2 autoSubmit -> uploadToServer 2017-02-14 09:37:09 -08:00
Kevin Sawicki
f3756ccf29 Run crash reporter specs on all platforms 2017-02-14 09:37:09 -08:00
Kevin Sawicki
3b7207da9f Support removing extra parameters 2017-02-14 09:37:09 -08:00
Kevin Sawicki
41fef3999c Document setExtraParameter 2017-02-14 09:37:09 -08:00
Kevin Sawicki
9a434af03e Clear crash keys in InitBreakpad 2017-02-14 09:37:09 -08:00
Kevin Sawicki
ba975d552a Add setExtraParameter support on macOS 2017-02-14 09:37:09 -08:00
Kevin Sawicki
cfe3ae234b Correct , -> . typo 2017-02-14 09:37:09 -08:00
Kevin Sawicki
3e18d8baf5 Remove _ prefix on binding methods 2017-02-14 09:37:09 -08:00
Kevin Sawicki
e4c54fd0d8 Merge pull request #8662 from oukan/feature/translate-zh-CN
Modules for the Main Process to zh-CN
2017-02-14 09:33:27 -08:00
Kevin Sawicki
e9e8595605 Merge pull request #8673 from electron/scroll-touch-end
Call OnWindowScrollTouchEnd instead of Edge
2017-02-14 09:32:56 -08:00
Kevin Sawicki
c54ae66fb9 Call OnWindowScrollTouchEnd instead of Edge 2017-02-14 09:13:07 -08:00
Kevin Sawicki
624e44dd6f Merge pull request #8605 from electron/no-more-global-buffer
Delete Buffer global when node integration is disabled
2017-02-14 09:07:24 -08:00
Kevin Sawicki
fdc1d3d763 Add Buffer typeof assertion 2017-02-14 08:42:34 -08:00
Kevin Sawicki
8e09fcd2a9 Upgrade node for require wrapper Buffer change 2017-02-14 08:42:34 -08:00
Kevin Sawicki
2a18e3f9ea Remove Buffer global on load 2017-02-14 08:42:34 -08:00
Kevin Sawicki
1933a4fc9f Remove global Buffer mention now handled as require wrapper 2017-02-14 08:42:34 -08:00
Kevin Sawicki
7e138083ef Add declared const Buffer spec 2017-02-14 08:42:34 -08:00
Kevin Sawicki
70010fdb8e Add spec for Buffer global 2017-02-14 08:42:34 -08:00
Kevin Sawicki
80dad58a59 Merge pull request #8654 from electron/context-shutdown-crash
Upgrade brigthray for context crash fix
2017-02-14 08:41:55 -08:00
Kevin Sawicki
1f0bc7fe86 Upgrade brigthray for context crash fix 2017-02-14 08:25:27 -08:00
Cheng Zhao
bad6954911 Disable the ActiveVerifier 2017-02-14 17:23:20 +09:00
liusi
d56c1909df only emit download-item done event once. 2017-02-14 14:39:33 +08:00
Gary Wilber
f19924bcb0 Add Invalidate method to NativeWindow and add Mac implementation 2017-02-13 19:41:24 -08:00
Kevin Sawicki
d3c967401d Merge pull request #8672 from electron/reorder-compiler-error-in-zoom-controller
Call content::WebContentsObserver first
2017-02-13 09:24:38 -08:00
Kevin Sawicki
d7ab142e10 Call content::WebContentsObserver first 2017-02-13 09:09:42 -08:00
Kevin Sawicki
8c2cf03f37 Merge pull request #8617 from electron/resolves-aliases-nsopen
Add resolvesAliases option to openDialog
2017-02-13 08:29:18 -08:00
Kevin Sawicki
a746651d1c Use dialog setter for consistency with other properties 2017-02-13 08:23:53 -08:00
Samuel Attard
17fe5efa13 Fix linting 2017-02-13 08:23:53 -08:00
Samuel Attard
7c33f3ee65 Document the noResolveAliases property 2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8 Add support for a noResolveAliases property 2017-02-13 08:23:53 -08:00
Kevin Sawicki
266c78b861 Merge pull request #8669 from poppinlp/patch-1
Fix typo
2017-02-13 08:18:19 -08:00
Kevin Sawicki
c9e5d7d1e2 Merge pull request #8660 from fab1an/patch-3
Update session.md
2017-02-13 08:17:23 -08:00
Kevin Sawicki
070cc40af4 Merge pull request #8659 from fab1an/patch-2
Update web-contents.md
2017-02-13 08:16:55 -08:00
Cheng Zhao
16382162f8 Update brightray for electron/brightray#275. 2017-02-13 19:27:21 +09:00
Cheng Zhao
7f7df5a6dd Merge pull request #8537 from deepak1556/webcontents_zoom_patch
webContents: manage zoom changes on the browser side with HostZoomMap
2017-02-13 17:24:33 +09:00
PoppinL
9b8e4eb6cb Fix typo
Fix typo
2017-02-13 16:14:49 +08:00
Cheng Zhao
593b7cc92a Merge pull request #8668 from electron/fix-mas
Update libchromiumcontent: fix usage of private API in MAS build
2017-02-13 17:03:37 +09:00
Cheng Zhao
51d5706b48 Update libchromiumcontent: fix usage of private API in MAS build 2017-02-13 16:45:43 +09:00
Weiqiang Lin
e262f6c63e webContents to zh-CN 2017-02-12 23:12:33 +08:00
Weiqiang Lin
b7551b5d84 Class: Tray to zh-CN 2017-02-12 22:51:36 +08:00
Weiqiang Lin
dddb6458da systemPreferences to zh-CN 2017-02-12 22:38:24 +08:00
Weiqiang Lin
c9dd59eb86 session to zh-CN 2017-02-12 22:36:08 +08:00
Weiqiang Lin
9fd9b39448 protocol to -zh-CN 2017-02-12 22:35:03 +08:00
Weiqiang Lin
6a0738aa88 powerSaveBlocker to zh-CN 2017-02-12 22:07:24 +08:00
Weiqiang Lin
50fbd5266a powerMonitor to zh-CN 2017-02-12 22:00:09 +08:00
Fabian Zeindl
46c65ae5fc Update session.md 2017-02-12 10:06:24 +01:00
Fabian Zeindl
5efa34ce6d Update web-contents.md 2017-02-12 10:03:33 +01:00
deepak1556
7a0aff2bae code cleanup 2017-02-12 01:48:24 +05:30
deepak1556
cbeaa6be87 simply handling temporary zoom levels of webview 2017-02-12 00:49:17 +05:30
deepak1556
e3fe3cc490 map webframe zoom api to use HostZoomMap 2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1 Add ZoomController to manager zoom changes for webcontents 2017-02-12 00:49:17 +05:30
deepak1556
07794a58aa use zoom factor webpreference option when required.
* When setzoomlevel is not called for the host.
* When there is no zoom preference for the host.
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d webContents: set zoom levels with HostZoomMap 2017-02-12 00:49:17 +05:30
Kevin Sawicki
5e78330c6d Merge pull request #8540 from electron/SECURITY.md
Add SECURITY.md
2017-02-10 13:27:50 -08:00
Kevin Sawicki
9b6b8752d4 Merge pull request #8655 from electron/thai-translations
Add Thai translations
2017-02-10 12:18:43 -08:00
Kevin Sawicki
4d7d72256d Remove doc linter warnings 2017-02-10 12:18:24 -08:00
Kevin Sawicki
9dd960fc97 Remove untranslated files 2017-02-10 12:06:06 -08:00
ThePooE
c49363f521 📝 Thai: translated accessibility.md 2017-02-10 11:54:51 -08:00
ThePooE
45a1ffef8f 📝 Thai: fix small line breaking, word warpping in glossary.md 2017-02-10 11:54:51 -08:00
ThePooE
43b09b7360 📝 Thai: translated glossary.md 2017-02-10 11:54:51 -08:00
ThePooE
d3bf36e12a 📝 Thai: translated styleguide.md 2017-02-10 11:54:51 -08:00
wit543
0f55468042 📝 Thai: translate the header ++
translate the header and opening statement
2017-02-10 11:54:51 -08:00
wit543
f4ea70d2c2 Update about.md 2017-02-10 11:54:51 -08:00
ThePooE
9ce93e6cac 📝 Thai: add English placeholders for files to be translated 2017-02-10 11:54:51 -08:00
ThePooE
a78cd79a58 📝 Thai: add link from README.md to the translated version 2017-02-10 11:54:51 -08:00
ThePooE
e008d86e76 📝 Thai: added electron-faq.md 2017-02-10 11:54:51 -08:00
ThePooE
7fdfaa13e7 📝 Thai: fully translated README.md 2017-02-10 11:54:51 -08:00
ThePooE
888dc5702f 📝 Thai: add prelude translation to README.md 2017-02-10 11:54:51 -08:00
Kevin Sawicki
b92c4f6ce5 Merge pull request #8651 from electron/new-window-docs
[ci skip] Improve docs for `new-window` event
2017-02-10 10:29:07 -08:00
Kevin Sawicki
e85d2f00dd Fix linting errors around spacing and semicolons 2017-02-10 08:49:13 -08:00
Kevin Sawicki
5d0da398bf Merge pull request #8650 from electron/will-attach-webview-docs
[ci skip] Improve docs for `will-attach-webview` event
2017-02-10 08:45:40 -08:00
Catalin Ionut Fratila
19d7f0733e create-dist: Adding argument to supress api docs generation. 2017-02-10 14:26:53 +01:00
Vadim Macagon
035d9df29b Fix example code 2017-02-10 18:02:03 +07:00
Vadim Macagon
197ad915b7 [ci skip] Improve docs for new-window event
This should help clarify the purpose of `event.newGuest` as per the recent discussion in #7407.
2017-02-10 17:57:55 +07:00
Cheng Zhao
e8f689ecd3 Merge pull request #8640 from electron/fix-debug-symbols
Update libchromiumcontent: Fix debug symbols not generated
2017-02-10 19:11:31 +09:00
Vadim Macagon
e8f0331aeb Improve docs for will-attach-webview event 2017-02-10 10:33:33 +07:00
Kevin Sawicki
acedc3e726 Merge pull request #8584 from electron/new-webview-event
Add will-attach-webview event
2017-02-09 12:40:11 -08:00
Kevin Sawicki
81addbdcbf Remove only call 2017-02-09 11:49:14 -08:00
Kevin Sawicki
941f6c63e3 🎨 Use embedder var for clarity 2017-02-09 11:48:45 -08:00
Kevin Sawicki
a7c050107b Remove guest from will-attach-webview event 2017-02-09 11:47:45 -08:00
Kevin Sawicki
acff2f6baf Adjust src from will-attach-webview 2017-02-09 11:45:07 -08:00
Kevin Sawicki
8b0d3a2567 Emit attach params as well in event 2017-02-09 11:45:07 -08:00
Kevin Sawicki
792f3c3030 Document will-attach-webview 2017-02-09 11:45:07 -08:00
Kevin Sawicki
46f1a49594 new-webview -> will-attach-webview 2017-02-09 11:45:07 -08:00
Kevin Sawicki
7eda8fbdfb Add new-webview event that can be prevented 2017-02-09 11:45:07 -08:00
Kevin Sawicki
706b9f6cbf Add new-webview specs 2017-02-09 11:45:07 -08:00
Kevin Sawicki
5bf60ad8e8 Merge pull request #8556 from yamgent/macos-open-save-panel
Support message, nameFieldLabel and showsTagField for macOS dialog
2017-02-09 11:34:19 -08:00
Kevin Sawicki
5130ad24eb 🎨 2017-02-09 11:30:17 -08:00
Kevin Sawicki
35654d872b Document new settings 2017-02-09 11:29:10 -08:00
Kevin Sawicki
f7f4de36af Merge remote-tracking branch 'origin/master' into macos-open-save-panel 2017-02-09 11:25:05 -08:00
Kevin Sawicki
c3f3a6f133 Merge pull request #8623 from electron/dialog-options-helper
Add DialogSettings helper
2017-02-09 11:07:02 -08:00
Kevin Sawicki
867bb5a94e Add DialogSettings helper struct 2017-02-09 10:13:11 -08:00
Kevin Sawicki
e7410976f0 Merge pull request #8590 from electron/showmessagebox-checkbox
Add support for checkbox with dialog.showMessageBox
2017-02-09 10:07:03 -08:00
Kevin Sawicki
7994acf0ea Use CHROMEGTK_CALLBACK_0 and ignore gpointer data 2017-02-09 09:49:09 -08:00
Birunthan Mohanathas
c8c11e68c6 Add support for checkbox with dialog.showMessageBox
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048.
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5 Fix code formatting 2017-02-09 21:51:11 +08:00
Tan Wang Leng
a4a71a1dc9 Change qualifier of ShowSaveDialog() parameter
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
72723646dd Add tests to check errors in parameters 2017-02-09 21:23:02 +08:00
Tan Wang Leng
9423143211 Change the default value of showsTagField to true
The default value of showsTagField in macOS's NSSavePanel is true.

Therefore, in order to follow the standard behavior and not break
backwards-compatibility, let's change the default value of
showsTagField to true.

Reference:
https://developer.apple.com/reference/appkit/nssavepanel/1525589-showstagfield?language=objc
2017-02-09 21:01:40 +08:00
Tan Wang Leng
b0487b7d84 Fix wrong signature for gtk's ShowSaveDialog() 2017-02-09 20:10:57 +08:00
Tan Wang Leng
1bf8270c0d 🏁 Fix dialog method calls for Windows 2017-02-09 20:10:57 +08:00
Tan Wang Leng
8843fef065 📝 Update docs for new attributes in showOpenDialog() 2017-02-09 20:10:57 +08:00
Tan Wang Leng
36209ddd90 🍎 Add additional options for Mac's open dialog
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
cc22149beb 📝 Update docs for new attributes in showSaveDialog() 2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1 🍎 Add additional options for Mac's save dialog
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Weiqiang Lin
e267a0dd41 Class: MenuItem to zh-CN 2017-02-09 17:57:27 +08:00
Weiqiang Lin
eba65eb4d3 Class: Menu to zh-CN 2017-02-09 17:34:45 +08:00
Weiqiang Lin
c7b639e282 ipcMain to zh-CN 2017-02-09 17:16:27 +08:00
Weiqiang Lin
8f542b1d69 globalShortcut to zh-CN 2017-02-09 17:08:58 +08:00
Weiqiang Lin
4a78490a6a dialog to zh-CN 2017-02-09 17:01:30 +08:00
Weiqiang Lin
db4ad8c692 contentTracing to zh-CN 2017-02-09 16:57:41 +08:00
Weiqiang Lin
f949f83a57 BrowserWindow to zh-CN 2017-02-09 16:17:38 +08:00
Cheng Zhao
a3c5eafb16 Update libchromiumcontent to include debug symbols 2017-02-09 16:52:19 +09:00
Cheng Zhao
90492df1cb Fix exception when executing create-dist directly 2017-02-09 16:52:19 +09:00
Weiqiang Lin
6adf1640e5 autoUpdater to zh-CN 2017-02-09 15:51:48 +08:00
Weiqiang Lin
5d35d2476d window.open Function to zh-cn 2017-02-09 15:24:29 +08:00
Kevin Sawicki
9163b601a4 Merge pull request #8636 from electron/update-certificate-verifier-specs-for-linux-ci
Allow multiple verification results in specs
2017-02-08 13:56:59 -08:00
Kevin Sawicki
22b9c6e539 Allow multiple verification results 2017-02-08 13:33:07 -08:00
Kevin Sawicki
bad130f623 Merge pull request #7955 from deepak1556/veto-ssl-verify
session: provide chromium cert verification result to setCertificateVerifiy callback
2017-02-08 13:12:24 -08:00
Kevin Sawicki
18e15a1e53 Add spec for rejecting using old signature 2017-02-08 12:51:24 -08:00
Kevin Sawicki
1e581d6814 Use unique_ptr for passing VerifyRequestParams 2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e Use object for verification request 2017-02-08 11:59:43 -08:00
Kevin Sawicki
5245d42d15 Only document deprecation for now 2017-02-08 11:59:43 -08:00
Kevin Sawicki
9c134e7bf3 Assert certificate error 2017-02-08 11:59:43 -08:00
Kevin Sawicki
6b56dfd94b Add spec for remote callback length 2017-02-08 11:59:43 -08:00
Kevin Sawicki
37db804099 Use NetLogWithSource since BoundNetLog no longer exists 2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a modify CertVerifier Class
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Kevin Sawicki
d00a96ce35 Merge pull request #8618 from electron/forward-this-in-require-wrapper
Forward `this` in require wrapper
2017-02-08 10:33:48 -08:00
Kevin Sawicki
e9226aa354 Assert test.coffee outside of doesNotThrow 2017-02-08 09:02:46 -08:00
Kevin Sawicki
c1773a2c94 Add coffee-script dependency to specs 2017-02-08 09:00:14 -08:00
Kevin Sawicki
090255c3f4 Upgrade node for require wrapper this fix 2017-02-08 09:00:14 -08:00
Kevin Sawicki
84f8bfbdef Add spec for registering/requiring Coffeescript 2017-02-08 09:00:14 -08:00
Kevin Sawicki
83d31cefeb Merge pull request #8626 from dengyaolong/master
complete download-item translation docs
2017-02-08 08:50:26 -08:00
Gary Wilber
11e1f6b56c Fix lint errors 2017-02-08 00:05:16 -08:00
Gary Wilber
ed44b32ff5 Convert indentation to spaces 2017-02-07 23:08:03 -08:00
Gary Wilber
148898fb75 Implement invalidate for non-offscreen mode 2017-02-07 23:03:42 -08:00
Cheng Zhao
5cd18fe32a Merge pull request #8619 from electron/mac-os-version-checks
Use IsAtLeastOS10_* version checks
2017-02-08 13:58:26 +09:00
dengyaolong
0748f4fef2 complete download-item translation docs 2017-02-08 12:38:08 +08:00
Kevin Sawicki
f9b319e4f8 Merge pull request #8624 from electron/disable-file-icon-specs-on-linux
Disable getFileIcon specs on Linux CI
2017-02-07 18:30:00 -08:00
Kevin Sawicki
ba03f04017 Disable getFileIcon specs on Linux CI 2017-02-07 18:24:35 -08:00
Cheng Zhao
0643d98d99 Merge pull request #8616 from electron/renew-symbol-trick
Simplify the trick used for referencing symbols
2017-02-08 07:56:28 +09:00
Kevin Sawicki
4630f4488e Merge pull request #7851 from YurySolovyov/image-from-icon
Add an API to fetch file icon
2017-02-07 11:37:06 -08:00
Kevin Sawicki
82ac4ddf19 Large is only 48x48 on Linux 2017-02-07 11:20:27 -08:00
Kevin Sawicki
fc1b7431c7 Tweak optional syntax 2017-02-07 10:35:31 -08:00
Kevin Sawicki
a4277bb616 Document sizes 2017-02-07 10:33:44 -08:00
Kevin Sawicki
dddc6aec49 Tweak spec descriptions 2017-02-07 10:21:20 -08:00
Kevin Sawicki
683a758dab Call done instead of skip 2017-02-07 10:16:09 -08:00
Kevin Sawicki
ee66776450 Update IconManager for Chrome 56 upgrade 2017-02-07 10:15:46 -08:00
Yury Solovyov
a9dae243b4 Fix large icon spec 2017-02-07 09:55:18 -08:00
Yury Solovyov
c810e64fda Fix doc lint 2017-02-07 09:55:18 -08:00
Yury Solovyov
bcf0964c61 Fix more review 2017-02-07 09:55:18 -08:00
Yury Solovyov
2b60df3d8b Fix some feedback 2017-02-07 09:55:18 -08:00
Yury Solovyov
29452364f3 Use isolate() method to get isolate 2017-02-07 09:54:22 -08:00
Yury Solovyov
c36cdb8580 Properly skip large size test on macOS 2017-02-07 09:54:22 -08:00
Yury Solovyov
1aa4fcae08 Lint tests 2017-02-07 09:54:22 -08:00
Yury Solovyov
00748889f9 Add tests 2017-02-07 09:54:22 -08:00
Yury Solovyov
c2bf5bb986 Put locker and handle scope to the top of the function. Remove unneeded header 2017-02-07 09:53:34 -08:00
Yury Solovyov
11ef2c539b Update docs 2017-02-07 09:53:34 -08:00
Yury Solovyov
5794138ed4 Normalize path 2017-02-07 09:53:34 -08:00
Yury
1b4ee6e0d8 Image from icon node-style callback (#2)
* Try implementing node-style callbacks

* Add locker and handle scope
2017-02-07 09:53:34 -08:00
deepak1556
2e85ff1f57 Fix code style 2017-02-07 09:53:34 -08:00
Yury Solovyov
3d47c9b71d Fix lint 2017-02-07 09:53:34 -08:00
Yury Solovyov
fe99b255c4 Add docs 2017-02-07 09:53:34 -08:00
Yury Solovyov
05cb26a174 Use object for options 2017-02-07 09:53:34 -08:00
Yury Solovyov
bec671bac8 Make size optional 2017-02-07 09:52:11 -08:00
deepak1556
ff3aaa55f7 define icon loader for liunx as separate target 2017-02-07 09:52:11 -08:00
Robo
b25b141642 create iconmanager as singleton class and cleanup code (#1)
* create iconmanager as singleton class and cleanup code
2017-02-07 09:52:11 -08:00
Yury Solovyov
1b3cd87fc9 Add icon manager to browser process 2017-02-07 09:50:17 -08:00
Yury Solovyov
602aba8723 Include proper header 2017-02-07 09:48:12 -08:00
Yury Solovyov
eb889b9b86 Get it compiling, linking till fails though 2017-02-07 09:48:12 -08:00
Yury Solovyov
d118fed5c2 Try my own class 2017-02-07 09:48:12 -08:00
Yury Solovyov
8e4ed664d9 Add icon fetching sources 2017-02-07 09:48:12 -08:00
Yury Solovyov
1d24a3a175 Add callback converters 2017-02-07 09:48:12 -08:00
Yury Solovyov
be5b907179 WIP 2017-02-07 09:48:12 -08:00
Kevin Sawicki
0f98c9d3fb Use at least OS version checks 2017-02-07 09:32:40 -08:00
Kevin Sawicki
c3c5470a7c Merge pull request #8542 from yamgent/webpref-numeric
Fix webpreferences not accepting numeric options
2017-02-07 09:15:55 -08:00
Kevin Sawicki
4de637779b Make int converter helper an instance method 2017-02-07 09:13:42 -08:00
Tan Wang Leng
7ec88d16a6 Use base::StringToInt() instead of std::stringstream 2017-02-07 09:05:55 -08:00
Tan Wang Leng
42f65c52fb 🐛 Fix webpreferences not accepting numeric options
The webpreferences attribute values are parsed as strings instead
of numbers. Therefore, a conversion is required.
2017-02-07 09:05:55 -08:00
Cheng Zhao
84c180ac69 Simplify the trick used for referencing symbols 2017-02-07 17:09:43 +09:00
Kevin Sawicki
852519a826 Bump v1.6.0 2017-02-06 16:42:00 -08:00
Kevin Sawicki
e6fe2a93f2 Merge pull request #8607 from electron/fix-win32-link
Fix missing of symbols when linking win32 build
2017-02-06 16:41:22 -08:00
Cheng Zhao
85e84cc0da Fix missing of symbols when linking win32 build 2017-02-07 09:14:50 +09:00
Kevin Sawicki
a2ecef26a2 Merge pull request #8606 from electron/fix-broken-link
Fix broken Squirrel.Windows link
2017-02-06 16:01:40 -08:00
Charlie Hess
a35424ef25 Fix broken Squirrel.Windows link. 2017-02-06 15:54:05 -08:00
Jacob Groundwater
b8e12a0d21 Update ISSUE_TEMPLATE.md 2017-02-06 14:57:04 -08:00
Kevin Sawicki
8359c72347 Merge pull request #8501 from electron/chrome56
Upgrade to Chrome 56
2017-02-06 11:17:20 -08:00
Kevin Sawicki
dbb81e34e8 Upgrade node for modules version bump 2017-02-06 10:34:30 -08:00
Kevin Sawicki
997799ad68 Update libcc to e0da1e9 2017-02-06 10:34:30 -08:00
Cheng Zhao
ec650b3773 Update to Chrome 56.0.2924.87 2017-02-06 10:34:30 -08:00
Cheng Zhao
864a23f72b Fix print() not working 2017-02-06 10:34:30 -08:00
Cheng Zhao
86215d4300 Allow filter to use any scheme 2017-02-06 10:34:30 -08:00
Cheng Zhao
e0c021bfef Fix compilation waring on Mac 2017-02-06 10:34:29 -08:00
Cheng Zhao
1ed8743da8 Update Windows printing code to latest 2017-02-06 10:34:29 -08:00
Cheng Zhao
d483352f78 Fix PrintToPDF not receiving results 2017-02-06 10:34:29 -08:00
Cheng Zhao
3024d0563f There were new defaultPrintingSetting fields added 2017-02-06 10:34:29 -08:00
Cheng Zhao
ab783413a2 Update printing code to latest 2017-02-06 10:34:29 -08:00
Cheng Zhao
75627ba6ad Fix sync printing not working 2017-02-06 10:34:29 -08:00
Cheng Zhao
85961a0dd9 Update libchromiumcontent to fix duplicate main functions 2017-02-06 10:34:29 -08:00
Cheng Zhao
c69626336d Link with xcb on Linux 2017-02-06 10:34:29 -08:00
Cheng Zhao
82d796ded4 Fix missing of symbols issue on Release build 2017-02-06 10:34:29 -08:00
Cheng Zhao
41f356a94d icu's namespace has become icu_58 2017-02-06 10:34:29 -08:00
Cheng Zhao
a98e69a80d Work around the compilation error of v8_value_converter.cc
We should apply this patch in future:
0232f57400%5E%21/
2017-02-06 10:34:29 -08:00
Cheng Zhao
be29ea4dad libgtk2ui => libgtkui 2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0 Fix cpplint warnings 2017-02-06 10:34:29 -08:00
Cheng Zhao
55d4d44f02 Fix Debug building on Windows 2017-02-06 10:34:29 -08:00
Cheng Zhao
6165d36351 There is a new INSERTED type of ChangeCause
For the purpose of compatibility, we treat it as "explicit".
2017-02-06 10:34:29 -08:00
Cheng Zhao
09fcb7fb27 Fix crash when using webview 2017-02-06 10:34:29 -08:00
Cheng Zhao
c72438f09f WebInspector has been split up 2017-02-06 10:34:29 -08:00
Cheng Zhao
0a7c51b9aa Fix linking on Mac 2017-02-06 10:34:29 -08:00
Cheng Zhao
fa4b8cff45 Fix error due to search for openssl headers 2017-02-06 10:34:29 -08:00
Cheng Zhao
eb3b77f43b ScopedTempDir::path is replaced with GetPath 2017-02-06 10:34:29 -08:00
Cheng Zhao
6763977316 Update URLPattern to its latest version 2017-02-06 10:34:29 -08:00
Cheng Zhao
81784827ff PrintWebViewHelper is attached to RenderFrame 2017-02-06 10:34:29 -08:00
Cheng Zhao
234e1bb811 base::Bind now prevents the case with no arguments 2017-02-06 10:34:29 -08:00
Cheng Zhao
411696ca19 Clear is replaced with ClearEntriesAddedWithin 2017-02-06 10:34:29 -08:00
Cheng Zhao
8a6fd685e3 Interface of crashpad_client.StartHandler has changed
Refs:
7b9234c4b2%5E%21/
2017-02-06 10:34:29 -08:00
Cheng Zhao
4a14b17255 WindowOpenDisposition has become enum class 2017-02-06 10:34:29 -08:00
Cheng Zhao
6d5339b74e insertText is deprecated 2017-02-06 10:34:29 -08:00
Cheng Zhao
5e43ea227e purgedSize and purgeableSize are removed by Chrome 2017-02-06 10:34:29 -08:00
Cheng Zhao
6d323dd6fe web/WebInputEvent.h is moved to platform/WebInputEvent.h 2017-02-06 10:34:29 -08:00
Cheng Zhao
53bf82dd7c Update URLRequestFetchJob 2017-02-06 10:34:29 -08:00
Cheng Zhao
e7f3a25626 Update OffScreenRenderWidgetHostView 2017-02-06 10:34:29 -08:00
Cheng Zhao
2e0780308c allowDisplayingInsecureContent is removed by Chrome 2017-02-06 10:34:29 -08:00
Cheng Zhao
47c1bc9f66 Update ResponsePiper 2017-02-06 10:34:29 -08:00
Cheng Zhao
5cf2873b77 net::FtpProtocolHandler has changed its constructor 2017-02-06 10:34:29 -08:00
Cheng Zhao
5162905fe4 Update widevine_cdm_messages.h 2017-02-06 10:34:29 -08:00
Cheng Zhao
1a15b45736 --cipher-suite-blacklist is also removed 2017-02-06 10:34:29 -08:00
Cheng Zhao
dc9000f344 --ssl-version-fallback-min is removed by Chrome 2017-02-06 10:34:28 -08:00
Cheng Zhao
3ea6d88763 Update AtomCertVerifier 2017-02-06 10:34:28 -08:00
Cheng Zhao
c0697d8abe SetupFilter is replaced with SetUpSourceStream 2017-02-06 10:34:28 -08:00
Cheng Zhao
9882e87fbd Update OffScreenOutputDevice 2017-02-06 10:34:28 -08:00
Cheng Zhao
c2f3bbb3e6 Update OffScreenWebContentsView 2017-02-06 10:34:28 -08:00
Cheng Zhao
a95bd227c3 Update atom::Browser 2017-02-06 10:34:28 -08:00
Cheng Zhao
e91eed6758 FOR_EACH_OBSERVER is removed 2017-02-06 10:34:28 -08:00
Cheng Zhao
85749e4dbd Update AtomJavaScriptDialogManager 2017-02-06 10:34:28 -08:00
Cheng Zhao
6eaa30e94c Update AtomResourceDispatcherHostDelegate 2017-02-06 10:34:28 -08:00
Cheng Zhao
13a1d79ca6 Deperecate AtomSecurityStateModelClient with SecurityStateTabHelper 2017-02-06 10:34:28 -08:00
Cheng Zhao
3224c39371 Mac's version checking function has changed 2017-02-06 10:34:28 -08:00
Cheng Zhao
1d29b23662 Update api::WebContents 2017-02-06 10:34:28 -08:00
Cheng Zhao
231173aa90 Namespace of ChangeCause has changed 2017-02-06 10:34:28 -08:00
Cheng Zhao
d4e3dade39 WindowCapturer and ScreenCapturer are merged to DesktopCapturer 2017-02-06 10:34:28 -08:00
Cheng Zhao
7a7b72ce04 SimpleMenuModel::MenuClosed renamed to MenuWillClose 2017-02-06 10:34:28 -08:00
Cheng Zhao
c10eb73166 Signature of OnCreateWindow has changed 2017-02-06 10:34:28 -08:00
Cheng Zhao
d8e9432b0d contentTracing.setWatchEvent/cancelWatchEvent is removed 2017-02-06 10:34:28 -08:00
Cheng Zhao
0a91779dfa Node also defines LIKELY 2017-02-06 10:34:28 -08:00
Cheng Zhao
074cad9146 A few new V8 defines 2017-02-06 10:34:28 -08:00
Cheng Zhao
406224edff enable_pepper_cdms is now a feature flag
So we should not define it anymore.
2017-02-06 10:34:28 -08:00
Cheng Zhao
c1df762656 Update crashpad to 556c4e4 2017-02-06 10:34:28 -08:00
Cheng Zhao
b83676f9e9 Update to Chrome 56 2017-02-06 10:34:28 -08:00
Kevin Sawicki
1518ff5ddf Bump v1.5.1 2017-02-06 08:56:48 -08:00
Kevin Sawicki
18357512f3 Merge pull request #8515 from electron/auto-launch-squirrel-support
Support custom launch path in app.setLoginItemSettings
2017-02-06 08:55:32 -08:00
Kevin Sawicki
1b3d3b6b75 Use return value of GetProcessExecPath 2017-02-06 08:34:35 -08:00
CharlieHess
1178915f30 Ensure backwards compatibility with getLoginItemSettings.
We need to make sure the executable path is not quoted.
2017-02-06 08:34:35 -08:00
Kevin Sawicki
b7b200c874 Fix typo in getLoginItemSettings doc 2017-02-06 08:34:35 -08:00
Kevin Sawicki
1c6a07c68d Clear Update.exe login item settings in afterEach 2017-02-06 08:34:35 -08:00
Kevin Sawicki
3c2539eced Update example to use new option keys 2017-02-06 08:34:35 -08:00
Kevin Sawicki
e2501a80e4 Add path and args to LoginItemSettings struct 2017-02-06 08:34:35 -08:00
Charlie Hess
29d0a30d63 Oh, browser_linux is a thing too. 2017-02-06 08:34:35 -08:00
CharlieHess
25bc02f332 Don't append "%1" in the Run registry key.
It's only necessary for the protocol launch path.
2017-02-06 08:34:35 -08:00
Charlie Hess
d2ffd87668 I will never appreciate standard. 2017-02-06 08:34:35 -08:00
CharlieHess
852e158cc6 Make sure the spec takes arguments into account. 2017-02-06 08:34:35 -08:00
Charlie Hess
4fce00148d Add a spec for this behavior on Windows. 2017-02-06 08:34:35 -08:00
Charlie Hess
26d4a3b0ba Fix method signature on macOS. 2017-02-06 08:34:35 -08:00
CharlieHess
02dfdf75a0 Line Lengths! 2017-02-06 08:34:35 -08:00
CharlieHess
45e2f35eff Provide guidance in the docs. 2017-02-06 08:34:35 -08:00
CharlieHess
62c8a00347 This is rubbish let's pull the escape hatch.
Make all these arguments user-provided instead.
2017-02-06 08:34:35 -08:00
CharlieHess
0a6a8192b6 Close to a working Squirrel shortcut. 2017-02-06 08:34:35 -08:00
Charlie Hess
39b6bcb621 First pass at auto-launch supporting Squirrel. 2017-02-06 08:34:35 -08:00
Kevin Sawicki
093b844859 Merge pull request #8509 from electron/upgrading-chrome-doc
Add initial upgrading chrome checklist
2017-02-03 09:58:29 -08:00
Zeke Sikelianos
6df446baba Merge pull request #8583 from crowchirp/docs-typo-fixes
Docs typo fixes
2017-02-03 09:55:43 -08:00
Kevin Sawicki
de18f09588 Add initial upgrading chrome checklist 2017-02-03 09:54:34 -08:00
Kevin Sawicki
2f3578679f Merge pull request #8572 from electron/content-tracing-app-ready
Document using content tracing after app ready
2017-02-03 09:53:53 -08:00
Kevin Sawicki
7b3e998cc6 Use content tracing after app ready 2017-02-03 09:45:18 -08:00
Kevin Sawicki
cf694ef32b Merge pull request #8570 from electron/force-refresh-menu-role
Add forcereload menu item role
2017-02-03 09:44:57 -08:00
Kevin Sawicki
b1f260ac87 Add forcereload to MenuItem doc 2017-02-03 09:39:41 -08:00
Kevin Sawicki
fb08f56fc8 Add forcereload menu item role 2017-02-03 09:39:41 -08:00
Kevin Sawicki
555347e726 Merge pull request #8569 from electron/webview-default-node-integration
Mention presence of webview attributes enables them
2017-02-03 09:39:22 -08:00
Kevin Sawicki
50b9dfa61a Use querySelector to make examples more portable 2017-02-03 09:32:15 -08:00
Kevin Sawicki
4539a6f4d5 Change wording from on to present 2017-02-03 09:32:15 -08:00
Kevin Sawicki
4abbd65628 Merge pull request #8568 from electron/initialize-color-listener-after-app-is-ready
Initialize color listener after app is ready
2017-02-03 09:31:58 -08:00
Kevin Sawicki
5973aa36ad Initialize color listener after app is ready 2017-02-03 09:00:18 -08:00
Kevin Sawicki
62a400b7d6 Merge pull request #8566 from electron/prompt-to-create-property
Support returning non-existent file paths from Windows open dialog
2017-02-03 08:58:52 -08:00
Chandan Rai
75ec73d6fe Merge remote-tracking branch 'origin/patch-3' into docs-typo-fixes 2017-02-03 22:23:35 +05:30
Chandan Rai
1a3abb61ed Merge remote-tracking branch 'origin/patch-2' into docs-typo-fixes 2017-02-03 22:23:21 +05:30
Chandan Rai
4a6cbd76c8 corrected typo 2017-02-03 19:26:37 +05:30
Chandan Rai
9e7bcda07d corrected typo 2017-02-03 19:11:37 +05:30
Chandan Rai
93b0a2caa1 corrected typo 2017-02-03 18:58:21 +05:30
Kevin Sawicki
930a5c6de2 Merge pull request #8565 from electron/protocol-client-specs
Add protocol client specs on Windows
2017-02-02 12:48:19 -08:00
Kevin Sawicki
daff671afc Add protocol constant 2017-02-02 12:48:09 -08:00
Kevin Sawicki
a60f341968 Add procotol client specs on Windows 2017-02-02 12:48:09 -08:00
Kevin Sawicki
604c2470bc Merge pull request #8561 from liusy182/!-liusy182-br
add 'code' property in 'before-input-event''s 'input' argument
2017-02-02 10:33:20 -08:00
Kevin Sawicki
9fef6a1fd7 Add support for FOS_CREATEPROMPT option 2017-02-02 08:51:10 -08:00
liusy182
2cf6a026d8 fix linting error 2017-02-02 21:16:30 +08:00
liusi
87392ff046 'before-input-event' is missing the code property #8471 2017-02-02 16:23:07 +08:00
Kevin Sawicki
dc1c11a841 Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
Feature/macOS relative window levels
2017-01-30 15:34:24 -08:00
Kevin Sawicki
9b2b6da3a3 Wrap params at 80 characters 2017-01-30 15:32:05 -08:00
Kevin Sawicki
2cacaa443a Indent relativeLevel docs 2017-01-30 15:27:51 -08:00
Zeke Sikelianos
f0882a5058 use consistent headings 2017-01-30 10:57:53 -08:00
Zeke Sikelianos
1945771f37 Add SECURITY.md 2017-01-30 10:49:17 -08:00
Kevin Sawicki
37eebb1dd0 Merge pull request #8539 from electron/require-wrapper
Update require wrapper to allow redefinition of process and global
2017-01-30 10:36:15 -08:00
Kevin Sawicki
94cb605993 Use strictEqual for global variable asserts 2017-01-30 10:08:12 -08:00
Kevin Sawicki
e99b1709d9 Redeclare process/global as strings 2017-01-30 09:58:44 -08:00
Kevin Sawicki
4e5b8ac3ee Remove throws and assert object directly 2017-01-30 09:38:15 -08:00
James Ide
0430380de1 Update the Node submodule to use the new module wrapper
See the fixed issue for the context. This pulls in a vendored copy of Node that includes the described patch.

Fixes #8358

Test Plan: Built Electron and verified it loaded the sample app correctly and that the module wrapper is the new one by viewing Node's source code in the Blink Inspector.

Added specs and tested with `npm test -- --grep "global variables"`
2017-01-30 09:37:14 -08:00
leethomas
edbb786fb4 use kCGMinimumWindowLevelKey to get the minimum level 2017-01-26 19:12:10 -08:00
Kevin Sawicki
6e2f977f7a Merge pull request #8511 from electron/start-drag-crash
Fix startDrag crash on macOS with empty image
2017-01-26 17:10:21 -08:00
Kevin Sawicki
76e5589a31 Schedule function after executeJavaScript completes 2017-01-26 16:15:10 -08:00
Kevin Sawicki
651ea7ef02 Merge pull request #8421 from oukan/feature/translate-zh-CN
translate zh cn
2017-01-26 15:48:57 -08:00
Kevin Sawicki
eb6d92d427 Mention image cannot be empty on macOS 2017-01-26 15:46:04 -08:00
Kevin Sawicki
e683f28e32 Require a non-empty drag image to prevent crash 2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d Add specs for missing startDrag options 2017-01-26 15:46:04 -08:00
Kevin Sawicki
2ee5f6f358 Merge pull request #8507 from electron/fix-node-upgrade-patches
Redo node 7.4 error handling patch
2017-01-26 15:43:58 -08:00
Kevin Sawicki
06c025050e Fix typo in spec description 2017-01-26 14:46:51 -08:00
Kevin Sawicki
ff718b19db Upgrade node for new 7.4 patches and changes 2017-01-26 14:46:50 -08:00
Kevin Sawicki
1004d205d8 Add spec for unhandledRejection event in main process 2017-01-26 14:46:50 -08:00
Kevin Sawicki
24fb560a9d Add failing spec for uncaught main process errors 2017-01-26 14:46:50 -08:00
Kevin Sawicki
a4e25a8917 Merge pull request #8519 from electron/consolidate-panel-showing
Use helper function to show last dev tools panel
2017-01-26 14:44:45 -08:00
Kevin Sawicki
2cfa67bdff Remove linter warning 2017-01-26 09:59:07 -08:00
Kevin Sawicki
a851695bb9 Clear interval before setting new one 2017-01-26 09:57:53 -08:00
Kevin Sawicki
e2e33a8cf0 Guard against destroyed window or web contents 2017-01-26 09:57:00 -08:00
Kevin Sawicki
515f689814 Use helper function to show last dev tools panel 2017-01-26 09:42:45 -08:00
Kevin Sawicki
640b03f7d0 Merge pull request #8510 from electron/empty-image-crashes
Fix empty image crashes
2017-01-26 09:08:52 -08:00
leethomas
b67d515a76 fix signature for SetAlwaysOnTop in native window views 2017-01-26 07:24:20 -08:00
leethomas
9e189b9d2d fix js lint errors 2017-01-26 07:14:47 -08:00
leethomas
1234b61fa6 spec to ensure an error is thrown when relativeLevel is set out of bounds 2017-01-25 19:39:57 -08:00
Kevin Sawicki
104cae8f68 Only call getNativeHandle on macOS 2017-01-25 14:26:05 -08:00
Kevin Sawicki
e1281342f6 Return empty buffers when image is empty 2017-01-25 14:26:05 -08:00
Kevin Sawicki
2ad46f1842 Add failing spec for empty image crashes 2017-01-25 14:26:05 -08:00
Kevin Sawicki
8e69f94df0 Merge pull request #8357 from electron/remote-events-error-message
Don't crash when calling stale remote listeners
2017-01-25 14:23:57 -08:00
Kevin Sawicki
330ac5f266 Fix standard linting error 2017-01-25 12:36:55 -08:00
Kevin Sawicki
56a8eb3a94 Check that sender is a WebContents instance 2017-01-25 12:36:55 -08:00
Charlie Hess
ddedcf22d1 Move console.warn inside the helper method. 2017-01-25 12:36:55 -08:00
Charlie Hess
f6410d3b77 Assert that listener count decreases after a remove event. 2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d Write a warning instead of crashing. 2017-01-25 12:36:55 -08:00
Charlie Hess
bc2f1e8199 Argh. 2017-01-25 12:36:55 -08:00
Charlie Hess
63d8137da2 Use EventEmitter public methods instead of _events. 2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8 Assert remote event names 2017-01-25 12:36:55 -08:00
Charlie Hess
b04db2e546 Add a spec for the "renderer window closed" error. 2017-01-25 12:36:55 -08:00
Charlie Hess
a0b24bd155 Simplify. 2017-01-25 12:36:55 -08:00
Charlie Hess
67f7a60524 Review CommentZ 2017-01-25 12:36:55 -08:00
Charlie Hess
41ea169784 L I N T I N G P T I I 2017-01-25 12:36:55 -08:00
Charlie Hess
49c6446267 L I N T I N G 2017-01-25 12:36:55 -08:00
Charlie Hess
26e3ad3c2e Display more information about remote event crashes.
If possible, we'll dig into the function args and print the ones that are attached remotely.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
c13ea6eb36 Merge pull request #8497 from electron/enable-crash-reporter-specs-on-ci
Run crash reporter server specs on CI
2017-01-25 10:54:56 -08:00
Kevin Sawicki
f104e019be Run crash reporter server specs on CI 2017-01-25 10:36:16 -08:00
Kevin Sawicki
8e39aea34a Merge pull request #8478 from deepak1556/load_url_max_char_patch
WebContents: emit did-fail-load event when url exceeds character limit
2017-01-25 09:46:40 -08:00
deepak1556
d8a16a8ffb fix spec 2017-01-25 14:20:33 +05:30
leethomas
1f5518b91e throw an error for out of bounds window levels 2017-01-24 20:14:09 -08:00
Kevin Sawicki
90470617ab Merge pull request #8430 from ramya-rao-a/crash-for-children-docs
Updated docs for crash reporter to support child processes
2017-01-24 14:08:36 -08:00
Kevin Sawicki
ce6a46ee59 Use template strings 2017-01-24 14:08:10 -08:00
Kevin Sawicki
108a3473ed Use crashesDirectory in example 2017-01-24 14:07:00 -08:00
Kevin Sawicki
4985e073c4 Mention how to test 2017-01-24 14:04:56 -08:00
Kevin Sawicki
7b03c05b4e Capitalize Electron, fence as JS 2017-01-24 14:03:54 -08:00
Kevin Sawicki
ce472315f4 Merge pull request #8109 from ramya-rao-a/crash-for-children
Expose crash reporter start for child node processes
2017-01-24 14:02:47 -08:00
Kevin Sawicki
43ef4faf79 🎨 2017-01-24 14:00:03 -08:00
Kevin Sawicki
795b674996 Add StartInstance helper on CrashReporter 2017-01-24 13:54:46 -08:00
Kevin Sawicki
170c51ae85 Add spec for crashing node process 2017-01-24 13:49:45 -08:00
Ramya Achutha Rao
241773f2f0 Clean up testing code written for crash for children 2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
d453dbdb40 Support crash reporting from child process in Windows 2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
2814e04e7d Getting rid of linting errors 2017-01-24 12:44:39 -08:00
Kevin Sawicki
f1cd1c6dff Use mate::Dictionary::CreateEmpty 2017-01-24 12:44:39 -08:00
Kevin Sawicki
4107174cfd Group includes 2017-01-24 12:44:39 -08:00
Kevin Sawicki
91f8d6092b Take options object in process.crashReporter.start 2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
1f07cf2545 Add crashReporter property to process 2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
d4b44d8b69 Expose crash reporter start for child node processes 2017-01-24 12:44:39 -08:00
Kevin Sawicki
61aff5ed35 Merge pull request #8495 from electron/fullscreen-spec
Wait for window to transition before leaving full screen
2017-01-24 12:32:14 -08:00
Kevin Sawicki
6bb331356e Finish spec when full screen is left 2017-01-24 11:55:13 -08:00
Kevin Sawicki
284ca3114b Wait for window to transition before leaving full screen 2017-01-24 11:55:13 -08:00
Kevin Sawicki
e1fe5f4fbf Merge pull request #8496 from electron/upgrade-ffi
Upgrade to ffi@2.2.0
2017-01-24 11:54:59 -08:00
Kevin Sawicki
2762ead5a4 Upgrade to ffi@2.2.0 2017-01-24 11:25:21 -08:00
Kevin Sawicki
0ca5ad754e Merge pull request #8452 from electron/document-build
Document toolchains used for building official Electron releases
2017-01-24 10:53:33 -08:00
Kevin Sawicki
4f6750a460 Update build doc to Xcode 8.2.1 2017-01-24 10:49:42 -08:00
Kevin Sawicki
1960327918 Bump v1.5.0 2017-01-24 08:27:37 -08:00
Kevin Sawicki
8c9ebbeec2 Merge pull request #8483 from electron/upgrade-libcc
Upgrade libcc to b4dd78df
2017-01-24 08:26:42 -08:00
Kevin Sawicki
9f03a166f7 Upgrade libcc to b4dd78df 2017-01-24 08:01:22 -08:00
leethomas
fb741285c6 update documentation 2017-01-23 23:42:38 -08:00
leethomas
7a0a87a6f3 implement relative window levels, closes #8153 2017-01-23 23:42:33 -08:00
Kevin Sawicki
034230e2ae Merge pull request #8475 from milkit/fix-translation-jp
Fix Japanese translation
2017-01-23 09:35:01 -08:00
Kevin Sawicki
68ca873fa8 Merge pull request #8472 from javan/patch-1
Remove note in "did-fail-load" about redirect responses
2017-01-23 09:34:42 -08:00
Kevin Sawicki
3312f98121 Merge pull request #8467 from electron/upgrade-multiparty
Upgrade multiparty for os.tmpdir fix
2017-01-23 09:27:34 -08:00
Kevin Sawicki
33820ffb85 Upgrade multiparty for os.tmpdir fix 2017-01-23 09:22:08 -08:00
deepak1556
593a3de850 add spec 2017-01-23 19:57:47 +05:30
Shunki Tan
05b6f95ab8 Fix Japanese translation 2017-01-23 11:35:06 +09:00
Javan Makhmali
68eaf1fb9f Remove note in "did-fail-load" about redirect responses
ERR_ABORTED is suppressed now (https://github.com/electron/electron/pull/6201)
2017-01-22 16:39:42 -05:00
Weiqiang Lin
851a7578fa <webview> Tag to zh-CN 2017-01-22 14:18:34 +08:00
Weiqiang Lin
0d259a6eb0 File Object to zh-CN 2017-01-22 14:17:59 +08:00
Weiqiang Lin
86521f325b Synopsis to zh-CN 2017-01-22 14:17:29 +08:00
Weiqiang Lin
64a1b1c474 Supported Chrome Command Line Switches to zh-CN 2017-01-22 14:16:59 +08:00
Weiqiang Lin
cf54c4cbb2 testing-on-headless-ci.md to zh-CN 2017-01-22 14:15:51 +08:00
Kevin Sawicki
91ed9aeeee Merge pull request #8464 from schwalbe10/translation_jp
Fix a typo
2017-01-21 10:41:30 -08:00
Kevin Sawicki
bc001f8816 Merge pull request #8463 from electron/patch-about-md
Fixing missing link
2017-01-21 10:41:14 -08:00
schwalbe10
56882c31bd Fix a typo 2017-01-21 23:12:37 +09:00
Samuel Attard
8fe8dfa410 Fixing missing link 2017-01-22 00:12:43 +11:00
deepak1556
f9dc08baf6 emit did-fail-load event when the url char length exceeds limit 2017-01-21 14:59:20 +05:30
deepak1556
54559f99a0 Fix dereferencing nullptr
RenderWidgetHostView might not be available when
the navigator fails to load a url.
2017-01-21 14:56:58 +05:30
Kevin Sawicki
91c70a66cb Link to Xcode 7.3.1 DMG 2017-01-20 08:16:17 -08:00
Kevin Sawicki
edcea3e800 Merge pull request #8456 from yuya-oc/docs-security
Add to security checklist about permission requests
2017-01-20 08:04:01 -08:00
Yuya Ochiai
11f2574fda 📝 Add to security checklist about permission requests
If the handler is not set, remote content can access to user's
information without allowing the permission. e.g. UserMedia
[ci skip]
2017-01-20 23:58:21 +09:00
Yuya Ochiai
a7a3aa848e 📝 Fix typo
[ci skip]
2017-01-20 23:45:48 +09:00
Birunthan Mohanathas
b145131505 Mention VS2015 Update 3 to match CI environment 2017-01-20 07:19:43 +02:00
Birunthan Mohanathas
410f3c03d4 Document use of Xcode 7.3.1 with 10.10 SDK for release builds 2017-01-20 07:19:07 +02:00
Kevin Sawicki
8a22139d57 Merge pull request #8451 from electron/upgrade-clang
Upgrade to clang 278861
2017-01-19 15:56:38 -08:00
Kevin Sawicki
6a80cd2b7e Upgrade to clang 278861 2017-01-19 15:32:03 -08:00
Kevin Sawicki
22b21d04bd Merge pull request #8406 from electron/use_gn-chrome54
Use gn chrome54
2017-01-19 13:33:48 -08:00
Kevin Sawicki
2cddb5bb4e Bump v1.4.15 2017-01-19 08:32:42 -08:00
Birunthan Mohanathas
a560df3327 Update node to pick up Windows compilation fix 2017-01-19 09:05:59 +02:00
Kevin Sawicki
14d48e9653 Update .node-version to 7.4 2017-01-19 09:05:59 +02:00
Kevin Sawicki
c374e37cc4 Leak IsolateData since Environment is also leaked 2017-01-19 09:05:59 +02:00
Kevin Sawicki
54e2c480cb Upgrade to node 7.4 2017-01-19 09:05:59 +02:00
Kevin Sawicki
43067e01e9 Upgrade to latest libcc 2017-01-19 09:05:59 +02:00
Birunthan Mohanathas
ab4a055c05 Correct version in chrome_version.h 2017-01-19 09:05:59 +02:00
Cheng Zhao
c774bb47c5 Update to latest libchromiumcontent 2017-01-19 09:05:59 +02:00
Ales Pergl
a52d780e7a Update brightray and crashpad 2017-01-19 09:05:59 +02:00
Kevin Sawicki
b6d0201c73 Upgrade to Chrome 54.0.2840.101 2017-01-19 09:05:59 +02:00
Kevin Sawicki
1b036a284d Add basic inspectElement spec 2017-01-19 09:05:59 +02:00
Kevin Sawicki
602db2e04f 🎨 2017-01-19 09:05:59 +02:00
Kevin Sawicki
f0ceb4f065 Use SetNeedsBeginFrames from IPC handler 2017-01-19 09:05:59 +02:00
Kevin Sawicki
d71f10c5a3 Implement GetScreenInfo 2017-01-19 09:05:59 +02:00
Kevin Sawicki
39ddeff5c3 Implement SetNeedsBeginFrames 2017-01-19 09:05:59 +02:00
Kevin Sawicki
cc183524fd Only remove webview when non-null 2017-01-19 09:05:59 +02:00
Kevin Sawicki
b0ee46f862 Use === in specs 2017-01-19 09:05:59 +02:00
Kevin Sawicki
443040e8d7 Call InspectElement directly on InspectableWebContents 2017-01-19 09:05:59 +02:00
Kevin Sawicki
d6eb0d6629 Implement insertCSS on webFrame 2017-01-19 09:05:59 +02:00
Kevin Sawicki
017df93ffa Add failing spec for insertCSS 2017-01-19 09:05:59 +02:00
Kevin Sawicki
2f5acfedcd Add spec for denying perm requests when handler is cleared 2017-01-19 09:05:59 +02:00
Kevin Sawicki
18675cc6c1 Implement RequestPermissions using request handler 2017-01-19 09:05:59 +02:00
Kevin Sawicki
977680d00b Add spec for midi without sysex permission 2017-01-19 09:05:59 +02:00
Kevin Sawicki
2f26dbf39e Update type to level in debugger message spec 2017-01-19 09:05:59 +02:00
Kevin Sawicki
873e6e5e6b Append form to body before submitting 2017-01-19 09:05:59 +02:00
Cheng Zhao
20b70b367e Update to latest libchromiumcontent 2017-01-19 09:05:59 +02:00
Cheng Zhao
f2a30afcf1 Fix linking for arm build 2017-01-19 09:05:59 +02:00
Cheng Zhao
ec134e7536 Fix building error for arm linux 2017-01-19 09:05:59 +02:00
Cheng Zhao
0568fa30ca Fix linking for Windows 2017-01-19 09:05:59 +02:00
Cheng Zhao
6e0762a540 Fix building on Windows 2017-01-19 09:05:59 +02:00
Cheng Zhao
af212a9f67 Update libchromiumcontent for the rebase 2017-01-19 09:05:59 +02:00
Cheng Zhao
ebb4c93994 Fix linking error for x64 Linux build 2017-01-19 09:05:59 +02:00
Cheng Zhao
fd2fdb5475 Fix linking problem with libgtk2ui 2017-01-19 09:05:59 +02:00
Cheng Zhao
88f6f5d1b2 Fix compilation errors for Linux 2017-01-19 09:05:59 +02:00
Cheng Zhao
93a27fd3a9 Fix linking errors on Mac 2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199 Update files for Chrome 54 API changes 2017-01-19 09:05:59 +02:00
Cheng Zhao
bdc334d797 Update brightray and libchromiumcontent to Chrome 54 2017-01-19 09:05:59 +02:00
Jacob Groundwater
6520396466 update atom_browser_client.h 2017-01-19 09:05:44 +02:00
Jacob Groundwater
9716e2745b WIP: chrome 54 update 2017-01-19 09:05:44 +02:00
Ales Pergl
5b3d0f86f7 Adjustments after migrating libchromiumcontent to GN 2017-01-19 09:05:44 +02:00
Kevin Sawicki
b90e23306e Merge pull request #8428 from electron/upgrade-libcc-for-webm-muxer-fix
Upgrade libcc for webm muxer patch
2017-01-18 21:15:58 -08:00
Kevin Sawicki
8cc29c2e22 Upgrade libcc for webm muxer patch 2017-01-18 20:56:44 -08:00
Kevin Sawicki
a3af6bd9f5 Merge pull request #8441 from watilde/feature/tweak-kiosk
do not call SetFullScreen in SetKiosk if it's already fullscreen mode
2017-01-18 16:17:31 -08:00
Daijiro Wachi
a23d8ed702 do not call SetFullScreen in SetKiosk if it's already fullscreen mode 2017-01-19 00:40:34 +01:00
Kevin Sawicki
3766fb6652 Merge pull request #8437 from electron/set-version-for-electron-api-json
set version arg when creating electron-api.json
2017-01-18 15:13:30 -08:00
Kevin Sawicki
a7891e584a Merge pull request #8438 from electron/restore-thick-frame-fullscreen-handler
Restore thick frame full screen code path
2017-01-18 15:12:50 -08:00
Kevin Sawicki
e82b41724d Restore thick frame full screen case 2017-01-18 14:40:42 -08:00
Zeke Sikelianos
6af7cfff33 fix syntax and use relative path to electron-api.json target 2017-01-18 11:52:09 -08:00
Zeke Sikelianos
057fda5352 set version arg when creating electron-api.json 2017-01-18 11:00:13 -08:00
Kevin Sawicki
71512ad244 Merge pull request #8432 from hrubilov/patch-1
Typo fixed
2017-01-18 09:02:18 -08:00
hrubilov
edb3967a0f Typo fixed 2017-01-18 14:12:27 +03:00
Ramya Achutha Rao
dc5129f32e Updated docs for crash reporter to support child processes 2017-01-17 21:59:23 -08:00
Zeke Sikelianos
ade16a7823 Merge pull request #8365 from destan/patch-3
printToPDF: `landscape` ignored if `@page` is used
2017-01-17 13:50:37 -08:00
Kevin Sawicki
f7bdf5d04e Merge pull request #8399 from watilde/feature/fixes-8338
save a fullscreen state when Kiosk mode is called
2017-01-17 13:03:51 -08:00
Kevin Sawicki
dcbc10ac38 Merge pull request #8417 from electron/flaky-travis-specs
Disable flaky specs on Travis
2017-01-17 08:48:59 -08:00
Kevin Sawicki
feac8685f4 Merge pull request #8348 from electron/isolated-world
Add context isolation option to windows and webview tags
2017-01-17 08:47:44 -08:00
Weiqiang Lin
11259b0ea2 Online/Offline Event Detection to zh-CN 2017-01-17 17:50:16 +08:00
Weiqiang Lin
ac0ba74e87 Desktop Environment Integration to zh-CN 2017-01-17 17:49:18 +08:00
Weiqiang Lin
96b7d3653c Quick Start to zh-CN 2017-01-17 17:48:51 +08:00
Kevin Sawicki
9ccc78c62f Use options constants for keys 2017-01-16 13:09:38 -08:00
Kevin Sawicki
1d824d4645 Assert document visibility in main context 2017-01-16 13:03:38 -08:00
Kevin Sawicki
b26428c43c 🎨 2017-01-16 12:38:16 -08:00
Kevin Sawicki
815cb1b31c Include atom_natives after builtin includes 2017-01-16 12:38:16 -08:00
Kevin Sawicki
dcf9a395c2 Only create isolated context in main frame 2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e62d81c24 Access getter instead of variable 2017-01-16 12:38:16 -08:00
Kevin Sawicki
13acf7a6a3 Mention accessing context in dev tools 2017-01-16 12:38:16 -08:00
Kevin Sawicki
f35224b0e4 🎨 2017-01-16 12:38:16 -08:00
Kevin Sawicki
6bcfd0630c Document implemented APIs at the top 2017-01-16 12:38:16 -08:00
Kevin Sawicki
f4f0174746 Parse guestInstanceId and opener as ints 2017-01-16 12:38:16 -08:00
Kevin Sawicki
37b7dda3c5 Remove use of now private guestId 2017-01-16 12:38:16 -08:00
Kevin Sawicki
fbcbfbda6a Add back BrowserWindowProxy location property 2017-01-16 12:38:16 -08:00
Kevin Sawicki
de4be56b09 Use internal open event name with fully parsed options 2017-01-16 12:38:16 -08:00
Kevin Sawicki
f3852c57fc Use empty string for comparison 2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e6d08c652 Remove unneeded this prefix 2017-01-16 12:38:16 -08:00
Kevin Sawicki
bb260343de Move more functions to outer scope 2017-01-16 12:38:16 -08:00
Kevin Sawicki
3f7b3c4bd7 Implement window overrides in main context 2017-01-16 12:38:16 -08:00
Kevin Sawicki
95054f443f Enable context isolation on child windows 2017-01-16 12:38:16 -08:00
Kevin Sawicki
eef72647b4 Set human readable context name 2017-01-16 12:38:16 -08:00
Kevin Sawicki
33b6ab11f2 Assert context state after reload 2017-01-16 12:38:16 -08:00
Kevin Sawicki
dacfb2f596 Mention contextIsolation is experimental 2017-01-16 12:38:16 -08:00
Kevin Sawicki
3ac6019f42 Mention context isolation 2017-01-16 12:38:16 -08:00
Kevin Sawicki
0f7af8043a Upgrade libcc for world context patch 2017-01-16 12:38:16 -08:00
Kevin Sawicki
14a1e673c6 Add spec for webview context isolation 2017-01-16 12:38:16 -08:00
Kevin Sawicki
802ed62d5b Remove trailing comma 2017-01-16 12:38:16 -08:00
Kevin Sawicki
572fc058d3 Document contextIsolation option 2017-01-16 12:38:16 -08:00
Kevin Sawicki
b348cdeae8 Set page variable using webFrame.executeJavaScript 2017-01-16 12:38:16 -08:00
Kevin Sawicki
ea2273dde5 Assert built-in prototype isolation 2017-01-16 12:38:16 -08:00
Kevin Sawicki
ad3b837ad5 Rename option to contextIsolation 2017-01-16 12:38:16 -08:00
Kevin Sawicki
b56bdc83af 🎨 2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e7dbe6c6b Use patch worldScriptContext to get isolated context 2017-01-16 12:38:16 -08:00
Kevin Sawicki
309ac75284 Upgrade libcc for worlds patch 2017-01-16 12:38:16 -08:00
Kevin Sawicki
4f5c725dde 🎨 Use enum for world ids 2017-01-16 12:38:16 -08:00
Kevin Sawicki
5b6397aaa6 Store context that API is running in to deliver IPC events 2017-01-16 12:38:16 -08:00
Kevin Sawicki
2928fe5c43 Add initial isolated world spec 2017-01-16 12:38:16 -08:00
Kevin Sawicki
5da4f032c3 Notify client each time main context is created 2017-01-16 12:38:16 -08:00
Kevin Sawicki
c5e68ec165 🎨 2017-01-16 12:38:16 -08:00
Kevin Sawicki
78e0b80dc7 Support IPC messages in isolated context 2017-01-16 12:38:16 -08:00
Kevin Sawicki
073d8c2177 Add world id constants 2017-01-16 12:38:16 -08:00
Kevin Sawicki
d194a84ae4 Setup isolated context from AtomRenderFrameObserver 2017-01-16 12:38:16 -08:00
Kevin Sawicki
4bca6fe672 Add isolated world web preference option 2017-01-16 12:38:15 -08:00
Kevin Sawicki
cdf33ff3dc Add null guards 2017-01-16 12:38:15 -08:00
Kevin Sawicki
08b203fed1 Match extension name to class name 2017-01-16 12:38:15 -08:00
Kevin Sawicki
736befe90f Add initial support for loading into isolated world 2017-01-16 12:38:15 -08:00
Kevin Sawicki
b6c5e9a126 Disable disableguestresize spec that times out on Travis 2017-01-16 11:48:20 -08:00
Kevin Sawicki
4ebe54043a Merge pull request #8395 from Arcath/patch-1
Add Squirrel Release Server to the update server list.
2017-01-16 11:41:43 -08:00
Kevin Sawicki
e6f5f60f3a Merge pull request #8355 from oukan/feature/translate-zh-CN
translate to zh-CN
2017-01-16 11:40:19 -08:00
Kevin Sawicki
48facf6343 Add space after // 2017-01-16 11:38:58 -08:00
Kevin Sawicki
170f2f61f9 Merge pull request #8404 from bsclifton/fix-dpi-borders
Properly handle borders on frameless window for DPI > 100% (Windows only)
2017-01-16 11:24:39 -08:00
Kevin Sawicki
0244a73c49 Fix cpp linter errors 2017-01-16 09:26:07 -08:00
Kevin Sawicki
9089d55342 Merge pull request #8409 from javan/add-context-menu-event-to-webview
Add "context-menu" DOM event to <webview>
2017-01-16 09:04:32 -08:00
Brian Clifton
9e0547b98f Fix the rendering for the rounded edges 2017-01-14 01:15:22 -08:00
Daijiro Wachi
b97db68f0c add tests to fullScreen and Kiosk 2017-01-14 00:05:04 +01:00
Daijiro Wachi
436a6d5c0f Save a fullScreen state for Kiosk mode 2017-01-14 00:04:51 +01:00
Javan Makhmali
a64bdbd306 Add "context-menu" DOM event to <webview> 2017-01-13 17:04:09 -05:00
Kevin Sawicki
ac6aeae915 Merge pull request #8390 from electron/upgrade-brightray-for-devtools-fix
Upgrade brightray for dev tools fix
2017-01-13 10:57:57 -08:00
Kevin Sawicki
f92f851f11 Upgrade brightray for dev tools fix 2017-01-13 09:19:17 -08:00
Kevin Sawicki
99e21a2235 Merge pull request #8401 from czipperz/BrowserProcess_constructor
Reorder BrowserProcess constructor to avoid invalid memory
2017-01-13 09:12:51 -08:00
Kevin Sawicki
f7d3dc742d Merge pull request #8400 from electron/keyboardevent-link
Switch to footer link syntax for keyboard event docs
2017-01-13 09:09:44 -08:00
Brian Clifton
cf6e215a66 Properly handle borders for DPI > 100% on Windows
Fixes https://github.com/electron/electron/issues/4573

cc: @zcbenz, @kevinsawicki, @zeke
2017-01-13 00:18:42 -07:00
Czipperz
e4688f1c5a Reorder BrowserProcess constructor to avoid invalid memory 2017-01-12 16:55:26 -08:00
Kevin Sawicki
315daf1a10 Switch to footer link syntax 2017-01-12 16:54:07 -08:00
Zeke Sikelianos
75e81f00e2 Merge pull request #8381 from electron/lint-without-side-effects
create electron-api.json in dist, not as a side-effect of linting
2017-01-12 14:58:55 -08:00
Kevin Sawicki
ec71440f09 Merge pull request #8391 from electron/read-only-versions
Make process.versions.electron/chrome read-only
2017-01-12 14:58:01 -08:00
Zeke Sikelianos
2a825310ea use one line 2017-01-12 14:37:18 -08:00
Kevin Sawicki
323edb9d53 Add read-only version to planned 2.0 API 2017-01-12 13:51:35 -08:00
Kevin Sawicki
726bab0293 Add specs for process.versions.electron/chrome 2017-01-12 13:50:19 -08:00
Kevin Sawicki
b52367e3b2 Update native-mate to electron org 2017-01-12 13:50:19 -08:00
Kevin Sawicki
9ff1f6bbde Merge pull request #8377 from electron/sandbox-open-crash
Destroy web contents if new-window event is prevented
2017-01-12 11:43:35 -08:00
Kevin Sawicki
97dd680b32 Remove linter errors 2017-01-12 10:28:08 -08:00
Kevin Sawicki
8098ca3b66 Remove unneeded nextTick and assert array 2017-01-12 10:28:08 -08:00
Kevin Sawicki
8f63fdb278 Destroy web contents when preventing default 2017-01-12 10:28:08 -08:00
Kevin Sawicki
c5da330cdf Add failing spec for sandboxed window.open 2017-01-12 10:28:08 -08:00
Adam Laycock
9e89ec041e Add Squirrel Release Server to the update server list. 2017-01-12 13:40:14 +00:00
Kevin Sawicki
070bbcfc3d Merge pull request #8380 from electron/auto-submit-rename
Rename autoSubmit to uploadToServer in example
2017-01-11 08:42:33 -08:00
Zeke Sikelianos
cef9cd3cfc create electron-api.json in dist, not as a side-effect of linting 2017-01-10 18:17:08 -08:00
Kevin Sawicki
ed4f4b3954 Rename autoSubmit to uploadToServer in example 2017-01-10 16:07:10 -08:00
Kevin Sawicki
cfb6069b83 Bump v1.4.14 2017-01-10 11:01:39 -08:00
Kevin Sawicki
caacc4580f Merge pull request #8376 from electron/revert-8354-vibrancy-corner-fix
Revert "Smooth corners for vibrancy view"
2017-01-10 10:36:47 -08:00
Kevin Sawicki
f3b03908f9 Revert "Smooth corners for vibrancy view" 2017-01-10 10:34:55 -08:00
Kevin Sawicki
c6ccf9f2b5 Merge pull request #8371 from electron/upgrade-brightray-for-emulation-fix
Upgrade brightray for network emulation fix
2017-01-09 11:22:10 -08:00
Kevin Sawicki
5204d6ce45 Merge pull request #8354 from gerhardberger/vibrancy-corner-fix
Smooth corners for vibrancy view
2017-01-09 11:12:02 -08:00
Kevin Sawicki
24b5abcc39 Upgrade brightray for network emulation fix 2017-01-09 10:42:48 -08:00
Kevin Sawicki
8ada7fe30b Merge pull request #8370 from electron/resizable-specs
Add spec for resizable frameless window
2017-01-09 10:41:51 -08:00
Kevin Sawicki
d8366115f5 Add spec for resizable frameless window 2017-01-09 10:01:38 -08:00
Kevin Sawicki
e5aad9857d Merge pull request #7765 from liusy182/maximize-fix
fix for Window hidden behind taskbar after maximize #7672
2017-01-09 09:47:39 -08:00
Kevin Sawicki
75a05c2814 Merge pull request #8369 from electron/start-executable
Make start script executable
2017-01-09 09:28:37 -08:00
Kevin Sawicki
64a36170a9 Make start script executable 2017-01-09 09:27:20 -08:00
Kevin Sawicki
871c3fc11e Merge pull request #8341 from electron/dialog-manager
Implement alert/confirm through Chrome's dialog manager
2017-01-09 09:17:40 -08:00
Kevin Sawicki
6ef1a9150c Add OK button to alert 2017-01-09 08:30:13 -08:00
Kevin Sawicki
222734b5f5 Use correct param ordering in header file 2017-01-09 08:30:13 -08:00
Kevin Sawicki
1f08634d62 Implement alert/confirm through dialog manager 2017-01-09 08:30:13 -08:00
Kevin Sawicki
52390120ae Merge pull request #8340 from electron/options-cycle
Handle cycles when merging browser window options
2017-01-09 08:29:56 -08:00
Destan Sarpkaya
fb35f06114 printToPDF: landscape ignored if @page is used
This is very frustrating to find out via debugging, I think it should be in docs.
2017-01-09 02:31:34 +02:00
gellert
bfafc6d5fd indentation fix 2017-01-06 23:54:24 +01:00
Kevin Sawicki
1f07977f09 Remove lint errors 2017-01-06 09:58:40 -08:00
Kevin Sawicki
fd23c7bf76 Assert duplicate objects are supported 2017-01-06 09:58:40 -08:00
Kevin Sawicki
1944fdc962 Track visited parents and null out cycles 2017-01-06 09:58:40 -08:00
Kevin Sawicki
12382f064b Add failing spec for cycle in options 2017-01-06 09:58:40 -08:00
Kevin Sawicki
b942c54bea Use closeWindow helper 2017-01-06 09:58:40 -08:00
Kevin Sawicki
0a7dccbad8 Merge pull request #8308 from electron/normalize-access-keys
Support normalizing access keys in dialog buttons
2017-01-06 09:55:06 -08:00
Kevin Sawicki
5f862effaa Access directly on options object 2017-01-06 09:17:32 -08:00
Kevin Sawicki
d200cf2e77 Document normalizeAccessKeys option 2017-01-06 08:56:24 -08:00
Kevin Sawicki
eb533e04b9 Add option to normalize dialog access keys 2017-01-06 08:56:24 -08:00
Weiqiang Lin
58fa8add31 Using Widevine CDM Plugin to zh-CN 2017-01-06 21:41:25 +08:00
Weiqiang Lin
34afa3b8a5 Using Pepper Flash Plugin to zh-CN 2017-01-06 21:40:36 +08:00
Weiqiang Lin
17ef05672b Using Selenium and WebDriver to zh-CN 2017-01-06 21:38:58 +08:00
gellert
c5fe173e47 adds autorelease to nsimage 2017-01-06 14:32:34 +01:00
gellert
456ea04683 adds mask image for smooth vibrant view corners 2017-01-06 14:26:16 +01:00
Haojian Wu
0e5fc9c4e4 Merge pull request #8343 from oukan/feature/translate-zh-CN
Debugging the Main Process to zh-CN
2017-01-06 08:32:42 +01:00
Weiqiang Lin
cf5689371a debugging-main-process-node-inspector to zh-CN 2017-01-06 10:02:44 +08:00
Kevin Sawicki
e788b9f959 Merge pull request #8258 from deepak1556/net_header_patch
net: disallow cookies from cookie store
2017-01-05 16:47:44 -08:00
Kevin Sawicki
d3d09ff25f Merge pull request #8347 from Rastaban/master
fix permissive C++ code (MSVC /permissive-)
2017-01-05 14:53:11 -08:00
Phil Christensen
2c259990da fix permissive C++ code (MSVC /permissive-)
These were found by the C++ compiler group when doing "Real world code"
build tests using /permissive-.  We are sharing these with you to help clean up
your code before the new version of the compiler comes out.  For more information on
/permissive- see https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/.
In paticular, see the "Do not treat copy initialization as direct initialization"
section of the blog.
2017-01-05 09:38:41 -08:00
Weiqiang Lin
e2d60940a2 Debugging the Main Process to zh-CN 2017-01-05 14:49:07 +08:00
Weiqiang Lin
dc786996ef Debugging the Main Process in node-inspector to zh-CN 2017-01-05 14:47:39 +08:00
Weiqiang Lin
cc3ac9b1da Debugging the Main Process to zh-CN 2017-01-05 14:45:43 +08:00
Weiqiang Lin
431faf58ff Debugging the Main Process in VSCode to zh-CN 2017-01-05 14:43:17 +08:00
Weiqiang Lin
63ae55be2b Debugging the Main Process to zh-CN 2017-01-05 14:42:51 +08:00
Kevin Sawicki
14d6a70fa8 Merge pull request #8335 from liuderchi/i18n_zhTW_repl
translate repl.md into zh-TW
2017-01-04 09:00:06 -08:00
Kevin Sawicki
1ff6fc6491 Merge pull request #8326 from nicmitchell/copyright-year
Update copyright year in LICENSE file
2017-01-04 08:59:33 -08:00
Kevin Sawicki
a376d09be5 Merge pull request #8319 from oukan/feature/translate-zh-CN
application-distribution to zh-CN
2017-01-04 08:59:01 -08:00
liuderchi
02d7203b4f [ci skip] 📝 translate repl.md 2017-01-04 17:03:25 +08:00
liuderchi
e65cc8a245 [ci skip] 📝 copy repl.md source 2017-01-04 16:59:59 +08:00
Nic Mitchell
dc1eca14f0 Update copyright year in LICENSE file 2017-01-02 21:19:38 -08:00
Weiqiang Lin
0b7b2f5a57 Using Native Node Modules to zh-CN 2017-01-02 11:17:46 +08:00
Weiqiang Lin
6cff48112d application-distribution to zh-CN 2017-01-02 00:20:29 +08:00
Haojian Wu
fe0a577c8b Merge pull request #8318 from oukan/feature/translate-zh-CN
mac-app-store-submission-guide to zh-CN
2017-01-01 16:57:53 +01:00
Weiqiang Lin
91e93e6a5a mac-app-store-submission-guide to zh-CN 2017-01-01 20:44:06 +08:00
Weiqiang Lin
a1ef49c26f mac-app-store-submission-guide to zh-CN 2017-01-01 10:17:58 +08:00
Haojian Wu
339f4b8c31 Merge pull request #8313 from oukan/feature/translated-supported-platforms
translated supported platforms to zh-CN
2016-12-31 09:39:33 +01:00
Weiqiang Lin
406b0fdbcc no actual change 2016-12-31 16:36:20 +08:00
Zeke Sikelianos
349972368c Merge pull request #8312 from oukan/feature/translated-readme
add glossary page link to readme
2016-12-30 18:32:20 -08:00
Weiqiang Lin
4225524b6f . to 。 2016-12-31 09:50:41 +08:00
林伟强
aac916857d translated supported platforms to zh-CN 2016-12-30 23:58:54 +08:00
林伟强
25246c6db7 add glossary page link to readme 2016-12-30 23:51:25 +08:00
Haojian Wu
800689fc81 Merge pull request #8303 from ldehai/master
fix some expression
2016-12-30 16:00:34 +01:00
Andy
d9fbead8ca fix some expression 2016-12-30 22:50:44 +08:00
Haojian Wu
496c741513 Merge pull request #8311 from oukan/feature/process-translated
docs-translations API process Translated into zh-CN
2016-12-30 14:48:15 +01:00
林伟强
c392710802 s/./。 2016-12-30 17:48:48 +08:00
林伟强
b0886e2abf docs-translations API process Translated into zh-CN 2016-12-30 17:15:28 +08:00
林伟强
3d35f01bd1 docs-translations API process Translated into zh-CN 2016-12-30 10:45:39 +08:00
Kevin Sawicki
d86662cb80 Merge pull request #8309 from electron/optional-before-dash
Put optional label before dash
2016-12-29 15:51:39 -08:00
Kevin Sawicki
afa3bd2143 Put optional label before dash 2016-12-29 14:11:26 -08:00
Kevin Sawicki
196cb2dda4 Merge pull request #8306 from electron/link-to-offscreen-tutorial
Link to offscreen rendering tutorial
2016-12-29 13:33:06 -08:00
Kevin Sawicki
fc75080c28 Merge pull request #8298 from electron/configure-throttling-on-created-callback
Configure background throttling on RenderViewCreated callback
2016-12-29 13:31:09 -08:00
Kevin Sawicki
f8d41f1f68 Link to offscreen rendering tutorial 2016-12-29 09:15:28 -08:00
Kevin Sawicki
6ea1bacc73 Merge pull request #8250 from gerhardberger/osr-window-size-fix
Always create offscreen window frameless
2016-12-29 09:10:14 -08:00
Andy
6324270221 fix some expression 2016-12-29 21:53:53 +08:00
Kevin Sawicki
41afeb744a Configure background throttling on RenderViewCreated callback 2016-12-28 15:52:47 -08:00
Kevin Sawicki
219693d91f Merge pull request #8295 from electron/more-default-font-families
Support cursive/fantasy default font families
2016-12-28 13:42:35 -08:00
Kevin Sawicki
25c80f314b Merge pull request #8281 from abouthiroppy/fix-electron-jp-link
Fix electron-jp's link in README.md
2016-12-28 13:41:52 -08:00
Kevin Sawicki
5d505f9139 Support cursive/fantasy default font families 2016-12-28 13:40:53 -08:00
Kevin Sawicki
bc39964ece Merge pull request #8254 from electron/webcontents-will-navigate-crash
Don't load URL if web contents is destroyed
2016-12-28 13:40:31 -08:00
Kevin Sawicki
abea1196de Add spec for closing from will-navigate listener 2016-12-28 13:40:07 -08:00
Kevin Sawicki
1308f790ad Don't load URL if web contents is destroyed 2016-12-28 13:40:06 -08:00
Haojian Wu
095f304d7d Merge pull request #8284 from x-yao/zh-cn-docs
Add glossary.md in Simplified Chinese docs
2016-12-28 09:13:36 +01:00
x-yao
5a54d90d72 [ci skip]update glossary.md translation changes 2016-12-28 15:54:51 +08:00
x-yao
003fdd2382 Merge branch 'master' of github.com:electron/electron into zh-cn-docs 2016-12-28 15:47:24 +08:00
Zeke Sikelianos
5b9b33f32d Merge pull request #8285 from electron/update-glossary
📝 Fix a broken asar link.
2016-12-26 10:23:17 -08:00
x-yao
5ee3915c40 [ci skip]fixed glossary.md incorrect words 2016-12-26 17:57:20 +08:00
Haojian Wu
dcead89507 📝 Fix a broken asar link. 2016-12-26 10:28:08 +01:00
x-yao
6f2f3ed1ac Merge branch 'master' of github.com:electron/electron into zh-cn-docs 2016-12-26 12:03:00 +08:00
x-yao
738c8c047e [ci skip]add glossary.md in Simplified Chinese docs 2016-12-26 12:02:24 +08:00
abouthiroppy
d224f5d998 Fix electron-jp's link in README.md 2016-12-25 18:08:25 +09:00
Zeke Sikelianos
f8a9f628ae Merge pull request #7888 from electron/rename-webview-doc
Rename web-view to webview for consistency
2016-12-22 15:54:39 -08:00
Zeke Sikelianos
6995b51f2c set webview spec timeout to three minutes 2016-12-22 13:31:30 -08:00
Zeke Sikelianos
c989ea43f5 bump webview spec timeout to two minutes 2016-12-22 12:30:34 -08:00
Zeke Sikelianos
b0c4c79c49 remove unused webview fixture 2016-12-22 10:41:05 -08:00
Zeke Sikelianos
eb4038d626 more internal web-view reverting 2016-12-22 10:41:05 -08:00
Zeke Sikelianos
7562a8b662 revert renames of internal web-view stuff 2016-12-22 10:41:05 -08:00
Zeke Sikelianos
c75a1f08fd replace all web-view code with webview 2016-12-22 10:41:05 -08:00
Zeke Sikelianos
1085c28612 rename all web-view files to webview 2016-12-22 10:41:05 -08:00
Kevin Sawicki
eca9bffb01 Merge pull request #8269 from drewchandler/fix-clear-storage-data-docs
Use localstorage in clearStorageData docs
2016-12-22 10:07:31 -08:00
Drew Chandler
b28a865436 Use localstorage in clearStorageData docs
It won't work if you use include the space that is currently in the docs.
2016-12-22 09:51:39 -08:00
Kevin Sawicki
57d682a050 Merge pull request #8252 from electron/dialog-window-crash
Don't crash when window is closed by dialog callback
2016-12-22 09:34:07 -08:00
Kevin Sawicki
8c5f26373b Add override 2016-12-22 09:33:21 -08:00
Kevin Sawicki
87f09131aa Observe window and only use it when it is open 2016-12-22 09:33:21 -08:00
Kevin Sawicki
371b347ee9 Merge pull request #8268 from electron/update-production-variables
Move a couple env vars from development to production
2016-12-22 09:32:43 -08:00
Kevin Sawicki
ad2627b05a Move variables from development to production 2016-12-22 09:22:04 -08:00
Zeke Sikelianos
bb012c3db2 Merge pull request #8265 from thorbenegberts/patch-1
🐛 Fix link to Quick Start [ci skip]
2016-12-22 08:01:32 -08:00
x-yao
387dd67b60 [ci skip]fix chinese incorrect words 2016-12-22 17:10:27 +08:00
Thorben Egberts
b22eb0d65f Change Quick Start link from absolute to relative 2016-12-22 08:45:51 +01:00
Zeke Sikelianos
ec46d57816 Merge pull request #8267 from cesarandreu/patch-2
Fix a typo, there => their
2016-12-21 20:49:36 -08:00
Cesar Andreu
e296d4826f Fix a typo, there => their 2016-12-21 19:21:04 -08:00
Thorben Egberts
3cfe94c5ef Fixed link to Quick Start 2016-12-21 23:41:34 +01:00
gellert
7e82e12468 adds note to offscreen tutorial 2016-12-21 23:15:39 +01:00
gellert
f81908711b use only one if statement 2016-12-21 23:15:05 +01:00
Zeke Sikelianos
2b955a5ae1 Merge pull request #7878 from electron/glossary
Add a glossary of terms
2016-12-21 14:12:07 -08:00
Zeke Sikelianos
aeedd36168 see also 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
e57cb713b2 link process annotations to glossary 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
a098bf30d4 add DMG and NSIS to glossary 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
f1692f3274 lint to glossary from docs readme 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
a39dc1b78a 🎨 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
ead5275d63 fix heading level 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
4e8c21549b define process and webview 2016-12-21 13:47:40 -08:00
Zeke Sikelianos
ed081c8834 WIP 2016-12-21 13:47:40 -08:00
Kevin Sawicki
f99dabbac6 Merge pull request #8078 from electron/dts-docs-update-again
Update Docs
2016-12-21 13:39:53 -08:00
Kevin Sawicki
707b1d1b79 Merge pull request #8207 from philwyett-hemi/rpm_dev
Doc updates related to Fedora and RHEL / CentOS
2016-12-21 13:38:09 -08:00
Kevin Sawicki
026711e750 Merge pull request #8249 from electron/nsscreens-crash
Use firstObject instead of objectAtIndex:0
2016-12-21 10:58:14 -08:00
Kevin Sawicki
b9f569f7fb Merge pull request #8248 from electron/secure-options
Add options to protocol.registerStandardSchemes docs
2016-12-21 09:40:30 -08:00
Kevin Sawicki
0a5f51fd03 Merge pull request #8259 from mawie81/fix-screen-docs
[Docs] fix link in screen docs
2016-12-21 09:40:13 -08:00
mawie81
d20e2ec349 [ci skip] fix link in screen docs 2016-12-21 09:43:47 +01:00
deepak1556
f9417e3fcc net: disallow cookies from the cookie store 2016-12-21 11:54:48 +05:30
deepak1556
41c352c306 add failing spec 2016-12-21 11:52:27 +05:30
gellert
1ef0f6beff creates offscreen window frameless 2016-12-20 23:43:52 +01:00
Kevin Sawicki
c70eb81e32 Use firstObject instead of objectAtIndex:0 2016-12-20 13:49:35 -08:00
Kevin Sawicki
38681d0a2b Bump v1.4.13 2016-12-20 10:37:16 -08:00
Kevin Sawicki
c5097ae483 Add options to protocol.registerStandardSchemes docs 2016-12-20 09:44:58 -08:00
Kevin Sawicki
5bb196dce3 Merge pull request #8240 from electron/fix-structures-link
fix relative link to CertificatePrincipal doc
2016-12-20 09:13:01 -08:00
Kevin Sawicki
cb47de5eca Merge pull request #8225 from Golasowski/docs-translations-cz
Create Czech translate
2016-12-20 09:09:39 -08:00
Kevin Sawicki
56a8e17b21 Merge pull request #8243 from x-yao/zh-cn-docs
[DOC] Add systemPreferences API Simplified Chinese translation
2016-12-20 09:09:01 -08:00
x-yao
e3b23842dd [ci skip]add net API Simplified Chinese translation 2016-12-20 17:03:32 +08:00
Zeke Sikelianos
12cb35ef61 Merge pull request #8242 from DustinX/patch-1
Corrected some grammatical errors
2016-12-19 20:05:28 -08:00
longbotao
2fb8839d31 [ci skip]add systemPreferences API Simplified Chinese translation 2016-12-20 12:03:59 +08:00
Zeke Sikelianos
6578498e31 Merge pull request #8229 from electron/do-not-recommend-yarn
do not recommend yarn
2016-12-19 20:03:51 -08:00
Dustin
2e1feb63e4 Corrected some grammatical errors 2016-12-19 19:01:35 -08:00
Zeke Sikelianos
9e626c5fee fix relative link to CertificatePrincipal doc 2016-12-19 13:49:02 -08:00
Kevin Sawicki
78a89c666b Merge pull request #8238 from electron/doc-links
Link to return class type
2016-12-19 10:48:27 -08:00
Kevin Sawicki
6352afb07a Link to return class type 2016-12-19 09:40:07 -08:00
Kevin Sawicki
683d8033f0 Merge pull request #8235 from x-yao/zh-cn-docs
[DOC]update electron-faq.md in  Simplified Chinese docs
2016-12-19 09:22:24 -08:00
longbotao
e2bb8088d4 [ci skip]update electron-faq.md in Simplified Chinese docs and fix a little words 2016-12-19 15:01:50 +08:00
Zeke Sikelianos
64116e5d7c do not recommend yarn 2016-12-17 20:35:06 -08:00
O.G.olasowski
219a6b175b Create README.md 2016-12-17 00:31:37 +00:00
Kevin Sawicki
2a8b36c761 Merge pull request #8134 from deepak1556/empty_client_certificate_patch
app: select-client-certificate event callback can accept certificate optionally
2016-12-15 08:31:12 -08:00
liusi
b853671132 fix fullscreen, maximize, unmaximize 2016-12-15 14:01:03 +08:00
Phil Wyett
2fbf560668 Commit...
* Update build instructions to correctly reflect python version on CentOS
  that has Python 2.6.
* Correct Fedora package install command. Fedora now uses 'dnf' not 'yum'.
* Add RHEL / CentOS section that does use 'yum' for package install.
2016-12-15 03:05:24 +00:00
Kevin Sawicki
cd067bca37 Merge pull request #8175 from gerhardberger/createfrombuffer-bitmap
Add bitmap support to nativeImage.createFromBuffer
2016-12-14 13:24:45 -08:00
Kevin Sawicki
98d4e186e3 Move details next to params 2016-12-14 10:19:38 -08:00
Kevin Sawicki
8680a08a8d Add deprecated comment to scaleFactor parameter 2016-12-14 10:18:01 -08:00
Kevin Sawicki
3b259b4243 Add createFromBuffer to planned breaking changes 2016-12-14 10:12:37 -08:00
Kevin Sawicki
25feb9232d Merge pull request #8143 from poiru/webcontents-before-input-event
Add before-input-event event for webContents (fixes #7586)
2016-12-14 10:05:32 -08:00
Kevin Sawicki
590bde5e14 Remove unused include 2016-12-13 16:00:37 -08:00
Kevin Sawicki
88dac36c91 Move footer link to bottom 2016-12-13 15:58:03 -08:00
Kevin Sawicki
7842040d9d Add ToV8 converter for NativeWebKeyboardEvent 2016-12-13 15:54:13 -08:00
Kevin Sawicki
3237c6751a Use DCHECK instead of assert 2016-12-13 15:54:13 -08:00
Kevin Sawicki
7a5ec96d53 Prevent input event from main process 2016-12-13 15:54:13 -08:00
Kevin Sawicki
5ae80d541b Remove will-navigate spec 2016-12-13 15:54:13 -08:00
Kevin Sawicki
25ac23ab17 Upgrade brightray 2016-12-13 15:54:13 -08:00
Birunthan Mohanathas
a3b65ad481 Add before-input-event event for webContents (fixes #7586)
Embedding arbitrary web content is problematic when it comes to keyboard
shortcuts because:

* Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408)

* Blocked web content (e.g. a focused <webview> performing expensive
computation) will also prevent app shortcuts from firing immediately

The new before-input-event event can be used to overcome these issues by
always handle certain keyboard events in the main process.

Note that this requires electron/brightray#261 to compile.
2016-12-13 15:54:13 -08:00
gellert
9d2c9df992 adds empty bitmap test for createFromBuffer 2016-12-14 00:24:57 +01:00
gellert
7ceb8d1ab8 additional tests for createFromBuffer 2016-12-14 00:18:24 +01:00
gellert
a609e52a14 moves bitmap parameters to options object 2016-12-13 21:32:17 +01:00
gellert
39875c90f1 adds bitmap support to createFromBuffer 2016-12-13 21:32:17 +01:00
Kevin Sawicki
3290c6b335 Merge pull request #8201 from electron/docs-lint
Remove trailing spaces
2016-12-13 10:43:05 -08:00
Kevin Sawicki
0f93515ede Remove trailing spaces 2016-12-13 10:42:13 -08:00
Kevin Sawicki
dfc25d0ca5 Merge pull request #8199 from Casimodo/patch-2
Create quick-start.md
2016-12-13 08:30:57 -08:00
Kevin Sawicki
db0beb6c36 Merge pull request #8192 from rhysd/patch-1
Fixed a broken link in dialog.md [ci skip]
2016-12-13 08:30:28 -08:00
Casimodo
7b240d82fd Create quick-start.md 2016-12-13 15:50:23 +01:00
Linda_pp
704433f3d6 Fix broken link in dialog.md [ci skip] 2016-12-13 17:48:49 +09:00
Kevin Sawicki
8ae7d01d1a Merge pull request #8189 from electron/undefined-browser-window-in-dialog
Undefined browser causes error in dialog APIs
2016-12-12 16:44:16 -08:00
Kevin Sawicki
2bd8ef83d1 Use != null to handle undefined 2016-12-12 16:25:56 -08:00
Kevin Sawicki
c108088110 Test with some null/undefined windows 2016-12-12 16:25:14 -08:00
Kevin Sawicki
cb7715a572 Merge pull request #8187 from electron/optional-buttons
Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:52:17 -08:00
Kevin Sawicki
2e1e893675 Merge pull request #8159 from seanchas116/devtools
Record JavaScript calls in DevTools timeline on Node/ipc callback
2016-12-12 13:50:42 -08:00
Kevin Sawicki
3796d7a6a1 Use trace event with zero args 2016-12-12 13:49:58 -08:00
Kevin Sawicki
b08bc02cde Merge pull request #8137 from deepak1556/media_device_id_patch
session: reset media device id salt when cookies are cleared
2016-12-12 13:34:24 -08:00
Kevin Sawicki
04e873f78e Make deviceIds const 2016-12-12 13:33:18 -08:00
Kevin Sawicki
04da9257ef Catch any close window errors 2016-12-12 13:32:27 -08:00
Kevin Sawicki
cae601a682 Upgrade brightray for media device salt fix 2016-12-12 13:31:08 -08:00
Kevin Sawicki
f2aabeefd5 Merge pull request #8085 from deepak1556/protocol_http_session_patch
protocol: support custom session with interceptHttpProtocol
2016-12-12 13:07:14 -08:00
Kevin Sawicki
1d288b69e2 Merge pull request #7947 from beakerbrowser/register-standard-secure-schemes
Add {secure:} opt to protocol.registerStandardSchemes
2016-12-12 12:52:28 -08:00
Kevin Sawicki
cac85d2a12 Remove linter errors 2016-12-12 12:51:48 -08:00
Kevin Sawicki
381f55b3cb Remove unneeded empty checks 2016-12-12 12:51:48 -08:00
Paul Frazee
04fa85f67f removed unused iostream include 2016-12-12 12:51:48 -08:00
Paul Frazee
bacf6511a6 remove unneeded deprecations couts 2016-12-12 12:51:48 -08:00
Paul Frazee
4e01ab59c1 fix documentation for planned breaking changes 2016-12-12 12:51:48 -08:00
Paul Frazee
a46040a4fa log deprecation notices for webframe 2016-12-12 12:51:48 -08:00
Paul Frazee
b458201874 add deprecation notices to webframe 2016-12-12 12:51:48 -08:00
Paul Frazee
99ea50649a finish implementation of {secure:true} opt on protocol.registerStandardScehesm, and add working test 2016-12-12 12:49:57 -08:00
Paul Frazee
9d2e23413e add {secure:} opt to protocol.registerStandardSchemes 2016-12-12 12:49:57 -08:00
Daniel Pham
4b53cd9c3c 🐛 Allow buttons to be optional in 'showMessageBox' 2016-12-12 13:25:32 -05:00
Kevin Sawicki
ee88e0054b Merge pull request #8186 from devjin0617/devjin0617-docs-browser-window-proxy
[Docs] Add translations of broswer-window-proxy in korean docs
2016-12-12 10:06:28 -08:00
Kevin Sawicki
e77fa72d6d Merge pull request #8167 from seanchas116/fix-modal-corner
🍎 Make sure no round corners for modal windows
2016-12-12 10:05:47 -08:00
Kevin Sawicki
2fa9ca1f6d Merge pull request #8156 from sindresorhus/remove-dock-window-level
🍎 Document that the `dock` window level is deprecated
2016-12-12 09:39:08 -08:00
Kevin Sawicki
a2d1a5258b Merge pull request #8178 from lgeiger/native-modules-prebuild
Add instructions for native modules using prebuild
2016-12-12 09:29:27 -08:00
Kevin Sawicki
009c00cdc6 Merge pull request #8177 from Geo1088/patch-1
[Docs] Fix list item number rendering in distribution tutorial
2016-12-12 09:28:46 -08:00
Kevin Sawicki
1a0fbf84f9 Merge pull request #8165 from geoff-addepar/geoff/fix-sandbox-printing
Fix printing with the sandbox enabled
2016-12-12 09:26:52 -08:00
cheongjin.kim
9ea391e03d Add translations of broswer-window-proxy in korean docs 2016-12-13 00:11:16 +09:00
Lukas Geiger
6bcf4b1112 📝 Add instructions for native modules using prebuild 2016-12-10 20:23:33 +01:00
George
82bd1d98d5 Indent tree structure to fix Markdown list number rendering 2016-12-10 11:14:10 -05:00
Kevin Sawicki
de625bfb65 Bump v1.4.12 2016-12-09 21:43:27 -08:00
Kevin Sawicki
c751d42d1a Merge pull request #8176 from electron/upgrade-libcc-for-ct-timebomb-patch
Upgrade libcc for CT timebomb patch
2016-12-09 19:24:59 -08:00
Kevin Sawicki
198f5f237f Upgrade libcc for CT timebomb patch 2016-12-09 10:47:09 -08:00
Kevin Sawicki
dc5b27069a Merge pull request #8107 from deepak1556/clear_auth_cache_patch
session: add api to clear http auth cache
2016-12-09 10:08:02 -08:00
Kevin Sawicki
6a829e0179 Throw error when options object is invalid 2016-12-09 10:07:04 -08:00
deepak1556
4085ba309a fix spec 2016-12-09 09:56:16 -08:00
deepak1556
975d677f55 add docs 2016-12-09 09:56:16 -08:00
deepak1556
21be9a3309 add spec 2016-12-09 09:55:55 -08:00
deepak1556
7456b9ae17 net: add api to set request flags for testing 2016-12-09 09:54:30 -08:00
deepak1556
35349643af session: api to clear auth cache 2016-12-09 09:54:30 -08:00
Kevin Sawicki
952e3bac2c Merge pull request #8061 from deepak1556/resume_download_api
session: api to resume canceled downloads from previous session
2016-12-09 09:39:14 -08:00
Kevin Sawicki
d705f4cbac Fix issue where actual/expected was same variable 2016-12-09 09:37:46 -08:00
deepak1556
5d94221c61 fix code style 2016-12-09 09:37:46 -08:00
deepak1556
f124732431 add spec 2016-12-09 09:37:46 -08:00
deepak1556
d944219b28 add docs 2016-12-09 09:37:46 -08:00
deepak1556
86961d0f44 session: add api to create interrupted downloads 2016-12-09 09:37:46 -08:00
Sindre Sorhus
3dde669ee8 🍎 Remove deprecated dock window level
According to the Apple docs, the `NSDockWindowLevel` constant is deprecated: https://developer.apple.com/reference/appkit/nsdockwindowlevel?language=objc
2016-12-09 12:46:49 +01:00
Ryohei Ikegami
ccdeb915fa 🍎 Make sure no round corners for modal windows 2016-12-08 12:12:53 +09:00
Geoff Lywood
5345b08d24 Fix printing with the sandbox enabled
Closes #7984
2016-12-07 17:40:18 -08:00
Kevin Sawicki
54d27a390b Merge pull request #8155 from salomvary/explain-macos-modal-sheet
Clarify modal windows being sheets on macOS
2016-12-07 10:29:42 -08:00
Kevin Sawicki
ba44dca34a Merge pull request #8158 from jdfwarrior/master
Add detail for the browserWindow argument in dialog docs
2016-12-07 10:28:34 -08:00
Kevin Sawicki
61d91579df Merge pull request #8157 from electron/post-data-example
Add simple postData example to docs
2016-12-07 10:28:00 -08:00
Kevin Sawicki
ea2e2def55 Bump v1.4.11 2016-12-07 08:53:58 -08:00
Ryohei Ikegami
a7a06a483e Record JavaScript calls in DevTools timeline on Node/ipc callback 2016-12-07 20:22:13 +09:00
deepak1556
388b601503 URLRequestFetchJob should report start error 2016-12-07 16:34:28 +05:30
deepak1556
2b8b76a527 protocol: support custom session with interceptHttpProtocol 2016-12-07 16:22:34 +05:30
deepak1556
cbddbdb296 fix code style 2016-12-07 15:33:56 +05:30
deepak1556
06701786c4 update docs 2016-12-07 13:26:06 +05:30
deepak1556
1c45285fe3 add spec 2016-12-07 13:26:06 +05:30
deepak1556
18c0cfa6f5 app: optionally pass cert with select-client-certificate event 2016-12-07 13:26:06 +05:30
David Ferguson
32ae3a52b8 add detail for the browserWindow argument in dialog docs 2016-12-06 22:23:14 -06:00
Kevin Sawicki
e198b6945c Add simple postData example 2016-12-06 16:49:22 -08:00
Kevin Sawicki
f1f73eff04 Merge pull request #8152 from electron/dont-show-window
Don't show window in specs
2016-12-06 13:54:55 -08:00
Márton Salomváry
9adb232d99 Clarify modal windows being sheets on macOS 2016-12-06 22:47:26 +01:00
Kevin Sawicki
63bffbc460 Don't show window 2016-12-06 13:25:46 -08:00
Kevin Sawicki
3e128abb73 Merge pull request #8144 from electron/from-devtools-webcontents-fix
Guard against missing devToolsWebContents
2016-12-06 11:05:16 -08:00
Kevin Sawicki
820fb3b82b Guard against no devtools web contents 2016-12-06 10:36:59 -08:00
Kevin Sawicki
03263bb5b6 Add failing BrowserWindow.fromDevToolsWebContents spec 2016-12-06 10:36:59 -08:00
Kevin Sawicki
b0a1e2988b Add spec for BrowserWindow.fromWebContents 2016-12-06 10:36:59 -08:00
Kevin Sawicki
571592a5a4 Merge pull request #8147 from electron/upgrade-libcc-for-linux-keyevent-fix
Upgrade libcc for Chrome 56 Linux key event fix
2016-12-06 10:36:25 -08:00
Kevin Sawicki
d1da48ff0f Upgrade libcc for Chrome 56 Linux key event fix 2016-12-06 09:55:22 -08:00
Kevin Sawicki
6c214ed386 Merge pull request #8148 from electron/clear-interval-before-done
Clear interval before done
2016-12-06 09:54:48 -08:00
Kevin Sawicki
b29f7b9acb Clear interval before assert 2016-12-06 09:25:55 -08:00
Kevin Sawicki
c2f516067f Add missing r in variable name 2016-12-06 09:22:29 -08:00
Kevin Sawicki
58cae1d8de Clear interval before destroying window 2016-12-06 09:22:08 -08:00
Kevin Sawicki
a9d4d9ad85 Merge pull request #8120 from electron/implement-window-methods-in-main-process
Implement window methods in main process
2016-12-05 09:29:11 -08:00
deepak1556
e043dabcb8 add spec 2016-12-04 00:22:57 +05:30
deepak1556
3de3fb53bd session: reset media device id salt when cookies are cleared 2016-12-03 16:44:33 +05:30
Kevin Sawicki
d6d85ade8e 🎨 Assign binding as const 2016-12-02 13:40:31 -08:00
Kevin Sawicki
1278e8cebc Remove unused variable 2016-12-02 13:40:31 -08:00
Kevin Sawicki
de0ec9b33c Tweak cancelId docs 2016-12-02 13:40:31 -08:00
Kevin Sawicki
3b99827540 Coerce features to string 2016-12-02 13:40:31 -08:00
Kevin Sawicki
635c909aab Implement window.alert/confirm/close in main process 2016-12-02 13:40:31 -08:00
Kevin Sawicki
f894da13b0 Pass args array instead of arguments object 2016-12-02 13:40:31 -08:00
Kevin Sawicki
c27633dff4 Merge pull request #8110 from electron/track-render-view-by-process-id
Don't clear until render view is deleted for process id
2016-12-02 13:40:20 -08:00
Kevin Sawicki
c1a02d6556 Add spec for render-view-deleted issue 2016-12-02 10:42:09 -08:00
Kevin Sawicki
ec43dd067c Co-locate with other private methods 2016-12-02 10:41:42 -08:00
Kevin Sawicki
f3d391e3f2 Don't clear until render view is deleted for process id 2016-12-02 10:41:42 -08:00
Kevin Sawicki
851f490168 Merge pull request #8123 from electron/dont-write-back-to-passed-options
Don't write back to passed in options object
2016-12-02 09:10:02 -08:00
Kevin Sawicki
07f99c06ea Don't write back to passed in options object 2016-12-01 17:16:18 -08:00
Kevin Sawicki
d0643250f7 Merge pull request #8122 from electron/use-spread-instead-of-apply
Use spread syntax instead of apply
2016-12-01 17:15:22 -08:00
Kevin Sawicki
f56b00718b Remove unused method 2016-12-01 14:56:00 -08:00
Kevin Sawicki
af555bd879 Use spread syntax instead of apply 2016-12-01 14:56:00 -08:00
Kevin Sawicki
b61e1fd69f Add spec for error on removing all IPC listeners 2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75 Use spread syntax instead of function apply 2016-12-01 14:56:00 -08:00
Kevin Sawicki
f72942bff1 Merge pull request #8121 from electron/add-basic-dialog-specs
Add basic dialog specs
2016-12-01 14:55:49 -08:00
Kevin Sawicki
36371357cd buttonLabel -> Button label for consistency 2016-12-01 14:16:33 -08:00
Kevin Sawicki
750bd9a88b Add initial dialog specs 2016-12-01 14:15:34 -08:00
Kevin Sawicki
5660b1e225 Merge pull request #8115 from ArisLittle/patch-1
fix typos
2016-12-01 08:25:39 -08:00
Zheng Guoli
acfded9687 fix typos
a more ‘允许’ word should be removed
2016-12-01 10:03:33 +08:00
Guerin
a9f4c208a0 Adding French translations for the documentation (#8097)
* Adding French translation of electron-versioning.md

* Adding French translation of security.md

* Fixing typos and rewriting some text

* Update security.md
2016-11-30 09:49:36 -08:00
Kevin Sawicki
bca7a6baa9 Merge pull request #8105 from electron/ci-build-scripts
Add Linux CI builds scripts
2016-11-30 09:44:46 -08:00
Kevin Sawicki
3cb3d8f981 Log build type 2016-11-30 09:32:20 -08:00
Kevin Sawicki
9904da9a48 Add initial arm specific cibuild script 2016-11-30 09:22:30 -08:00
Kevin Sawicki
8d9328fbee Merge pull request #8098 from electron/clean-up-specs
Unify spec timeouts
2016-11-30 09:06:37 -08:00
Kevin Sawicki
eaa5d071ef Remove unneeded timeout call 2016-11-29 16:27:18 -08:00
Kevin Sawicki
d86f0a1686 Add missing call to done 2016-11-29 14:52:47 -08:00
Kevin Sawicki
f0566f3790 isCi -> isCI 2016-11-29 14:48:28 -08:00
Kevin Sawicki
f5f790863d Use 1 or 2 minute timeout for long specs 2016-11-29 14:31:57 -08:00
Kevin Sawicki
10386edea5 Default timeout to 30 seconds on CI and 10 seconds locally 2016-11-29 14:29:35 -08:00
Kevin Sawicki
4ccc3d9fb3 Remove unneeded return 2016-11-29 14:19:20 -08:00
Kevin Sawicki
77fa7ce977 Run more crashReporter specs on CI 2016-11-29 14:18:42 -08:00
Kevin Sawicki
2c8ab72269 Merge pull request #8084 from poiru/systempreferences-setuserdefault
Add systemPreferences.setUserDefault for macOS
2016-11-29 14:07:35 -08:00
Kevin Sawicki
df179ed28d Merge pull request #8092 from poiru/setcursorautohide
Add BrowserWindow.setCursorAutoHide
2016-11-29 13:36:58 -08:00
Kevin Sawicki
3ec0e2f132 Add override to SetAutoHideCursor signature 2016-11-29 13:36:08 -08:00
Kevin Sawicki
477ac313ab Merge pull request #8086 from deepak1556/devtools_remove_workspace_patch
override window.confirm in devtools
2016-11-29 13:31:21 -08:00
Kevin Sawicki
72e559458f Inline buttons and cancelId values 2016-11-29 13:30:28 -08:00
Kevin Sawicki
21f0b2bd2a Merge pull request #8096 from electron/dont-use-skip
Don't use Mocha's skip method
2016-11-29 12:53:13 -08:00
Kevin Sawicki
cc2936cfdf closeWindow in an afterEach block 2016-11-29 12:30:40 -08:00
Kevin Sawicki
d20e664ea8 Close window in an afterEach 2016-11-29 12:13:33 -08:00
Kevin Sawicki
fee7683b86 Reuse window variable and only close from root afterEach 2016-11-29 11:52:31 -08:00
Kevin Sawicki
d7e7c2b17f Assert single window from closeWindow helper 2016-11-29 11:29:20 -08:00
Kevin Sawicki
1afa41477d Don't use this.skip() since after hooks won't be run 2016-11-29 10:56:58 -08:00
Kevin Sawicki
217848ca52 Assert windows are not leaking across tests 2016-11-29 10:56:17 -08:00
Birunthan Mohanathas
486b6b9096 Add systemPreferences.setUserDefault for macOS
This API can be used to e.g. enable key repeat by setting
`ApplePressAndHoldEnabled` to `false` (see also #47).
2016-11-29 09:46:32 -08:00
Birunthan Mohanathas
18c49285a8 Add BrowserWindow.setAutoHideCursor for macOS
The `disableAutoHideCursor` BrowserWindow option can be used to control
auto-hiding behavior when the window is created. This new API is needed
to dynamically change the behavior after the fact.
2016-11-29 09:46:00 -08:00
Kevin Sawicki
fb74f5576d Merge pull request #8082 from aaronang/doc-electron-resources
Clarify where Electron's resources directory can be found
2016-11-28 15:39:07 -08:00
Kevin Sawicki
4aa2b093ff Merge pull request #8072 from ramya-rao-a/doc-update
Clarifying crash reporter behviour in Mac
2016-11-28 15:37:21 -08:00
Kevin Sawicki
446065b88c Minor updates to crash reporter notes 2016-11-28 15:37:06 -08:00
Kevin Sawicki
594aaec7bb Merge pull request #7901 from electron/rename-auto-upload
Rename autoUpload to uploadToServer
2016-11-28 15:34:07 -08:00
Kevin Sawicki
07994f50f3 Remove include now included in parent header 2016-11-28 15:11:50 -08:00
Kevin Sawicki
1c6e166af5 Value should be true on non-macOS platforms 2016-11-28 15:08:28 -08:00
Kevin Sawicki
0b9a2f6be6 Add autoSubmit crashReporter option 2016-11-28 15:08:28 -08:00
Kevin Sawicki
0c73140b07 used -> called 2016-11-28 15:08:28 -08:00
Kevin Sawicki
02cbd24165 Mention setUploadToServer only has effect after start 2016-11-28 15:08:28 -08:00
Kevin Sawicki
f4be3782a2 Add spec for get/setUploadToServer 2016-11-28 15:08:28 -08:00
Kevin Sawicki
bb9876bd6e Remove deprecation warning for autoSubmit 2016-11-28 15:08:28 -08:00
Samuel Attard
2bf6f28152 shouldUpload --> uploadToServer 2016-11-28 15:08:28 -08:00
Samuel Attard
a7dedb3a13 Update crash_reporter.cc 2016-11-28 15:08:28 -08:00
Samuel Attard
4b61a4d3de Fix linting 2016-11-28 15:08:28 -08:00
Samuel Attard
285a36f9de Use GetUploadsEnabled to return GetShouldUpload 2016-11-28 15:08:28 -08:00
Samuel Attard
5a1a2616aa Fix build issues 2016-11-28 15:08:12 -08:00
Samuel Attard
0d1804b2a0 Fix issues and deprecate the old prop 2016-11-28 15:08:12 -08:00
Samuel Attard
0b9530efd7 shouldUpload API's are macOS only 2016-11-28 15:08:12 -08:00
Samuel Attard
6bbd92368f Add docs for getShouldUpload 2016-11-28 15:08:12 -08:00
Samuel Attard
7b8eb3e09c Rename autoUpload to shouldUpload 2016-11-28 15:08:12 -08:00
Kevin Sawicki
774b2f99f2 Merge pull request #8038 from electron/danhp/close-file-preview
Add 'win.closeFilePreview()'
2016-11-28 14:47:06 -08:00
Kevin Sawicki
a7395118af Merge pull request #7952 from the-ress/window-setappid
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
2016-11-28 14:46:14 -08:00
Kevin Sawicki
3897a88082 Use skip for setAppDetails spec 2016-11-28 14:43:18 -08:00
Kevin Sawicki
0a61aad499 Add initial previewFile/closeFilePreview test 2016-11-28 14:32:15 -08:00
Kevin Sawicki
5abecadfd3 Tweak setAppDetails docs 2016-11-28 14:29:21 -08:00
Kevin Sawicki
fff59271af Initialize app icon index to 0 2016-11-28 14:26:30 -08:00
Daniel Pham
d5a0dd39a1 🎁 Add 'win.closeFilePreview()' 2016-11-28 14:25:11 -08:00
Kevin Sawicki
ccabee764b Bump v1.4.10 2016-11-28 12:50:12 -08:00
Kevin Sawicki
5283b94bf9 Merge branch 'access-url-through-web-contents' 2016-11-28 10:56:35 -08:00
Kevin Sawicki
6f6c5c07f0 Remove unintended returns 2016-11-28 10:56:23 -08:00
Kevin Sawicki
3a29555772 Access URL through webContents directly 2016-11-28 10:56:23 -08:00
Kevin Sawicki
145e40c2f6 Add more origin comparison specs 2016-11-28 10:56:23 -08:00
Kevin Sawicki
41dea03007 window.opener location should be webview src URL 2016-11-28 10:56:23 -08:00
deepak1556
3ac9858726 override window.confirm in devtools 2016-11-28 01:08:48 +05:30
Cheng Zhao
bbaab755e3 Merge pull request #8049 from electron/prevent-remove-all-ipc
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-27 14:29:49 +08:00
Cheng Zhao
8fd6463ab0 Merge pull request #8024 from pedro/handle-drop-mac-os-fix
Fix support for dragging urls in Mac
2016-11-27 14:24:35 +08:00
Aaron Ang
92fe82a208 📝 Clarify where Electron's resources directory can be found
[ci skip]
2016-11-26 00:44:08 +01:00
Samuel Attard
4ff7cf2bcc Update web-frame docs 2016-11-25 23:33:31 +11:00
Samuel Attard
f6a6ca8a22 Update cookies docs 2016-11-25 23:27:11 +11:00
Samuel Attard
c9615a201c Update app docs 2016-11-25 23:23:45 +11:00
Samuel Attard
921b474919 Fixup app and bw docs 2016-11-25 23:21:25 +11:00
Samuel Attard
06960704c4 Update docs for dts again 2016-11-25 23:17:31 +11:00
Ramya Achutha Rao
f8b738e6c2 Clarifying crash reporter behviour in Mac 2016-11-23 15:36:03 -08:00
Kevin Sawicki
b036fdfee0 Bump v1.4.9 2016-11-23 14:36:32 -08:00
Kevin Sawicki
3930f17d9d Merge pull request #8071 from electron/fix-doc-indentation
Fix indentation in menu template example
2016-11-23 14:36:18 -08:00
Kevin Sawicki
9eb521fb38 Fix indentation in menu template example 2016-11-23 14:34:55 -08:00
Kevin Sawicki
27625d2665 Merge pull request #8070 from electron/remove-unnecessary-escape-characters
Remove unnecessary escape characters
2016-11-23 14:31:32 -08:00
Kevin Sawicki
0593696344 Remove unnecessary escape characters 2016-11-23 14:27:54 -08:00
Kevin Sawicki
2cabfa5589 Merge branch 'check-sender-web-contents-access' 2016-11-23 12:30:25 -08:00
Kevin Sawicki
0134d62681 Always use guest contents for canAccessWindow check 2016-11-23 12:01:09 -08:00
Kevin Sawicki
0799317ff5 Add failing specs window.opener from <webview> opened window 2016-11-23 12:01:09 -08:00
Kevin Sawicki
686a26d948 Merge pull request #8065 from DanTheMan827/patch-1
Fixed language code for Aragonese
2016-11-23 09:10:48 -08:00
Kevin Sawicki
cd5bfbfead Sort by codes 2016-11-23 09:10:27 -08:00
Kevin Sawicki
9a7209d58e Merge pull request #8016 from the-ress/windows-lint
Fixed linting on Windows
2016-11-23 09:09:39 -08:00
DanTheMan827
f89a045605 Fixed language code to Aragonese 2016-11-23 09:21:27 -06:00
Zeke Sikelianos
a353a94b70 use new docs linter, remove cross-conf-env dep 2016-11-23 08:19:42 +01:00
Tereza Tomcova
5498a31493 Fixed linting on Windows 2016-11-23 08:18:46 +01:00
Zeke Sikelianos
6b34b97c29 Merge pull request #8057 from electron/fixup-docs-for-ts
Docs update
2016-11-22 19:18:37 -08:00
Samuel Attard
6a8ee19bf0 Docs update 2016-11-23 11:51:44 +11:00
Kevin Sawicki
cf690ae513 Merge pull request #7986 from salomvary/fix-before-quit-docs
Clarify docs on a `before-quit` behavior edge case
2016-11-22 16:51:26 -08:00
LuisHsu
cd8b7f5219 zh_TW translation of some tutorial document (#8054)
* 📝 zh_TW translation of tutorial

docs-translations/zh-TW/tutorial/debugging-main-process-
node-inspector.md

* 📝 zh_TW translation of tutorial

[ci skip]

debugging-main-process-vscode.md

* 📝 Translate zh_TW DE integration

desktop-environment-integration.md

* 📝 Translate zh_TW DE integration

[ci skip]
desktop-environment-integration.md
2016-11-22 15:59:28 -08:00
Kevin Sawicki
37b18243f4 Bump v1.4.8 2016-11-22 14:02:52 -08:00
Kevin Sawicki
e356168c9a Merge pull request #8047 from electron/fix-incorrect-window-size
Fix incorrect window size after restore on Windows
2016-11-22 14:01:50 -08:00
Kevin Sawicki
6f29d7211e Move restore/unmaximize specs near state ones 2016-11-22 13:32:39 -08:00
Kevin Sawicki
414db313c6 Merge pull request #8056 from electron/mocha-only-check
Check runner.hasOnly for focused spec check
2016-11-22 13:30:08 -08:00
Kevin Sawicki
63eec70350 Assert bounds when restoring 2016-11-22 13:22:30 -08:00
Kevin Sawicki
c0d9175bc3 Try specs without setTimeout calls 2016-11-22 13:14:17 -08:00
Kevin Sawicki
89965aa5db Check runner.hasOnly for focused spec check 2016-11-22 13:06:18 -08:00
Kevin Sawicki
238beb72ee Remove .only call 2016-11-22 11:41:02 -08:00
Zeke Sikelianos
6c046704c7 Merge pull request #8022 from electron/lint-required-and-optional-params
use updated docs linter with required param parsing
2016-11-22 10:47:32 -08:00
Zeke Sikelianos
5dc4b22d31 Merge pull request #7992 from electron/process-doc-followup
Process doc followup
2016-11-22 10:46:57 -08:00
Kevin Sawicki
95ab4815de Merge pull request #8041 from electron/webview-zoom-factor
Add new method to set layout-based zoom level limit
2016-11-22 09:08:00 -08:00
Kevin Sawicki
a7aed98d59 Add initial spec for zoom level limits 2016-11-22 08:43:14 -08:00
Kevin Sawicki
c4b68d88e9 Add setZoomLevelLimits to planned breaking changes 2016-11-22 08:11:14 -08:00
Kevin Sawicki
d4368fabb9 Add 2.0 comment about setZoomLevelLimits 2016-11-22 08:09:14 -08:00
Kevin Sawicki
9a5df9da41 Expose setVisualZoomLevelLimits on webContents and <web-view> 2016-11-22 08:07:55 -08:00
Kevin Sawicki
756a338b05 Document webFrame.setVisualZoomLevelLimits as public 2016-11-22 08:03:04 -08:00
Kevin Sawicki
e887fb69bd Export a setVisualZoomLevelLimits method 2016-11-22 07:53:02 -08:00
Kevin Sawicki
fb5bca8bc5 Merge pull request #8046 from electron/bengotow/url-schemes-docs-patch
Update open-url docs to mention NSPrincipalClass
2016-11-22 07:50:13 -08:00
Kevin Sawicki
0d317a2e49 Add backticks around Info.plist 2016-11-22 07:49:56 -08:00
Kevin Sawicki
77e317c1eb Merge pull request #8043 from electron/crash-reporter-docs
crash-reporter -> crashReporter
2016-11-22 07:49:11 -08:00
Samuel Attard
db729b5b52 Throw an error when users attempt to remove all listeners from the IPC modules 2016-11-22 18:30:58 +11:00
Samuel Attard
97b4f12112 Fix linting issues 2016-11-22 16:13:08 +11:00
Samuel Attard
926cabec78 Add spec for maximize restore positioning 2016-11-22 16:07:19 +11:00
Samuel Attard
621a934160 Fix maximize --> unmaximize positioning issue 2016-11-22 16:07:05 +11:00
Samuel Attard
c65033a13b Revert "incorrect position when restored from maximize-on-top-drag under Windows #7630"
This reverts commit a2b3abbf47.
2016-11-22 15:49:56 +11:00
Samuel Attard
67f33cdb60 Add failing spec for window size after restore 2016-11-22 15:49:47 +11:00
Ben Gotow
964c88a189 Update open-url docs to mention NSPrincipalClass
We got bit by a nasty bug today - if you change your app's info.plist `NSPrincipalClass` to something other to `AtomApplication` (We set it to NylasApplication via a bad find-replace), everything works except open-url is never fired. Add a small reference to the docs so folks know to check this key.
2016-11-21 16:55:18 -08:00
Kevin Sawicki
62b39d58ca crash-reporter -> crashReporter 2016-11-21 15:42:24 -08:00
Paul Betts
3e85d7759b 📝 2016-11-21 15:16:13 -05:00
Paul Betts
7445f9bdcc Lint 2016-11-21 15:13:34 -05:00
Paul Betts
e2649ce7d8 Add new method to set layout-based zoom level limit 2016-11-21 14:59:55 -05:00
Kevin Sawicki
71f94c7a3a Merge pull request #8030 from LuisHsu/master
zh_TW translation of tutorial docs
2016-11-21 09:53:25 -08:00
Kevin Sawicki
41d6207376 Merge pull request #8027 from bowbowbow/patch-1
Fix missed parameter in example.
2016-11-21 09:51:44 -08:00
Kevin Sawicki
82d17cb05d Merge pull request #7993 from electron/get-user-default-crash
Prevent systemPreferences.getUserDefault crash for missing arrays/dictionaries
2016-11-21 09:50:37 -08:00
Kevin Sawicki
26137977cd Fix crash when return value pointer is null 2016-11-21 09:22:30 -08:00
Kevin Sawicki
cbffd598f9 Add failing spec for unknown user defaults 2016-11-21 09:22:30 -08:00
Kevin Sawicki
2e35b1c855 Merge pull request #7776 from electron/zoom-to-web-contents-size
Add zoomToPageWidth window option
2016-11-21 09:21:55 -08:00
Kevin Sawicki
ea6b53578f Mention preferred size 2016-11-21 08:45:46 -08:00
Kevin Sawicki
2fc46f638f 🎨 2016-11-21 08:45:46 -08:00
Kevin Sawicki
a991570677 intrinsicWidth -> pageWidth 2016-11-21 08:45:46 -08:00
Kevin Sawicki
d4ba5b4638 Add spec for zoomToPageWidth 2016-11-21 08:45:46 -08:00
Kevin Sawicki
b02c0e6f46 Remove unneeded proportion calculation 2016-11-21 08:45:46 -08:00
Kevin Sawicki
7916981da2 zoomToContentSize -> zoomToPageWidth 2016-11-21 08:45:46 -08:00
Kevin Sawicki
7896ee23a2 Document zoomToContentSize 2016-11-21 08:45:46 -08:00
Kevin Sawicki
c5790e39dc Add support for zooming to content size 2016-11-21 08:45:46 -08:00
Zeke Sikelianos
8bc3dcd17a Merge pull request #8031 from muryoimpl/fix-broken-link-in-api-dialog
Fix typo in docs/api/dialog
2016-11-20 17:54:47 -08:00
muryoimpl
eab5376c25 Fix typo 2016-11-21 00:49:11 +09:00
LuisHsu
56b15eadea 📝 zh_TW of tutorial/accessibility.md
[ci skip]

 * Translate tutorial/about.md
2016-11-20 22:35:32 +08:00
LuisHsu
61c31f8e21 📝 zh_TW translation of tutorial/about.md
[ci skip]

1. Translate tutorial/about.md

2. Fix some broken links

3. Untranslated links are keep in English
2016-11-20 22:01:43 +08:00
bowbowbow
8918770892 I modified missed parameter in example.
Below example (in line 43 ~ 45) not working like comment. Because `ipcRenderer` callback function have two parameters (event, arg).

```javascript
ipcRenderer.on('asynchronous-reply', (arg) => {
  console.log(arg) // "pong" 출력
})
```
2016-11-20 21:30:50 +09:00
Pedro Belo
89e8ad4947 Fix support for dragging urls in Mac 2016-11-19 21:18:24 -08:00
Zeke Sikelianos
94988f89b0 use updated docs linter with required param parsing 2016-11-19 11:34:19 -08:00
Tereza Tomcova
b305020c1d Added documentation for BrowserWindow.setAppDetails 2016-11-18 21:43:03 +01:00
Tereza Tomcova
782417b1fa Added tests for BrowserWindow.setAppDetails 2016-11-18 21:34:01 +01:00
Tereza Tomcova
38b14fc912 Include shell.h only for Windows 2016-11-18 21:33:55 +01:00
Tereza Tomcova
ac9e0b458d Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command 2016-11-18 21:33:55 +01:00
Zeke Sikelianos
d6e3360aef Merge pull request #8009 from deed02392/master
Update docs
2016-11-18 08:33:24 -08:00
deed02392
1ee0efbe5c Merge pull request #1 from deed02392/patch-1
Patch 1
2016-11-18 00:38:24 +00:00
George Hafiz
aac31159b8 Update formatting to prevent '[] ()' sequences (e.g. String[] (optional)), which breaks MD rendering on GitHub and hides the array indication 2016-11-18 00:34:48 +00:00
deed02392
0aa1c3c6c3 Update dialog.md
Fix syntax to support docs parser and MD.
2016-11-17 22:39:24 +00:00
Kevin Sawicki
02a95a3eba Merge pull request #7981 from electron/more-menu-item-roles
Add reload and toggledevtools menu item roles
2016-11-17 13:04:13 -08:00
Kevin Sawicki
996ddba715 Add rpc error for ELECTRON_BROWSER_MEMBER_GET 2016-11-17 12:29:23 -08:00
Kevin Sawicki
88809b0e0b Document reload and toggledevtools roles 2016-11-17 10:57:20 -08:00
Kevin Sawicki
88959079bd Add toggledevtools menu item role 2016-11-17 10:57:20 -08:00
Kevin Sawicki
0698b5f1be Add reload menu item role 2016-11-17 10:57:20 -08:00
Kevin Sawicki
28c39d5151 Merge pull request #8003 from electron/missing-remote-object-error
Throw custom error when remote object is missing from registry
2016-11-17 10:57:03 -08:00
Kevin Sawicki
5427ec4844 Negate code as per node docs 2016-11-17 10:22:29 -08:00
Kevin Sawicki
aef898ad93 Set errno on RPC error 2016-11-17 10:09:29 -08:00
Kevin Sawicki
c05ca68811 Throw custom error when remote object is missing from registry 2016-11-17 09:55:13 -08:00
deed02392
489d873306 Update dialog.md
Fix 'properties' type in documentation (was missing `[]` notation due to lack of Markdown escaping).
2016-11-17 07:36:37 +00:00
Cheng Zhao
3834f0c6a6 Merge pull request #7974 from electron/chrome-runtime-response-callback
Implement chrome.runtime.onMessage response callback
2016-11-17 13:01:38 +09:00
Samuel Attard
7c26ec8bd4 Remove semicolon 2016-11-17 14:56:44 +11:00
Cheng Zhao
eb63bea87c Merge branch 'gabriel-master' 2016-11-17 12:15:38 +09:00
Cheng Zhao
5639faf069 Also fix the Windows and Linux side of async openExternal 2016-11-17 12:13:07 +09:00
Cheng Zhao
090a5d9a61 platform_util code should not involve V8 code 2016-11-17 11:22:09 +09:00
Cheng Zhao
622bad1cff Simplify getting callback 2016-11-17 10:36:16 +09:00
Gabriel Handford
5b260dbee3 Fix win/linux compile (again) 2016-11-17 10:33:24 +09:00
Gabriel Handford
f0ca9dff81 Fix win/linux compile 2016-11-17 10:33:24 +09:00
Gabriel Handford
9382d48708 Update docs 2016-11-17 10:33:24 +09:00
Gabriel Handford
54222bdf28 More general string for OSStatus 2016-11-17 10:33:24 +09:00
Gabriel Handford
2931c27395 More readable 2016-11-17 10:33:24 +09:00
Gabriel Handford
31123f908d Fix ternary 2016-11-17 10:33:24 +09:00
Gabriel Handford
99a5258999 Callback uses (platform specific) error, with message 2016-11-17 10:33:24 +09:00
Gabriel Handford
5e8059e0fa Fix method names, move to anon namespace 2016-11-17 10:33:24 +09:00
Gabriel Handford
08a9af3a85 Linting 2016-11-17 10:33:24 +09:00
Gabriel Handford (linux)
d186fd78e3 Fix header 2016-11-17 10:33:23 +09:00
Gabriel Handford
6524a33ffc Include callback header 2016-11-17 10:33:23 +09:00
Gabriel Handford
21df08d536 Remove redundant comment 2016-11-17 10:33:23 +09:00
Gabriel Handford
cfd2a029ad Fix linting 2016-11-17 10:33:23 +09:00
Gabriel Handford
c78567aba6 Update shell openExternal docs (from review) 2016-11-17 10:33:23 +09:00
Gabriel Handford
9ca684d87f Remove redundant method 2016-11-17 10:33:23 +09:00
Gabriel Handford
128feb17cb Fix method call 2016-11-17 10:33:23 +09:00
Gabriel Handford
3eb5f8d521 Fix typo 2016-11-17 10:33:23 +09:00
Gabriel Handford
b266533dfc Shell openExternal can take optional callback (macOS) 2016-11-17 10:33:23 +09:00
Zeke Sikelianos
1b5b29901c Merge pull request #7969 from electron/one-file-per-api
move each API doc into its own file
2016-11-16 11:12:36 -08:00
Zeke Sikelianos
468d8b7707 reference node's process object 2016-11-16 09:54:29 -08:00
Zeke Sikelianos
1da97f729e process object is available in renderer processes too 2016-11-16 09:54:19 -08:00
Zeke Sikelianos
f9683ff99f use unreleased linter 2016-11-16 09:03:17 -08:00
Zeke Sikelianos
a7fdd04751 move menu constructor docs to top of file 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
5979dab13c fix some class headings 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
c9739abf7f add description and process for BrowserWindow class 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
39330affda DownloadItem only needs one heading 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
d6684c4dcd fix UploadBlob heading 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
4770d2b526 returns an instance, not the module 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
2b689a21e7 fix structure headings 2016-11-16 09:02:49 -08:00
Zeke Sikelianos
b084dc29ea move each API doc into its own file 2016-11-16 09:02:49 -08:00
Kevin Sawicki
c4d74c48e4 Bump v1.4.7 2016-11-16 08:11:28 -08:00
Kevin Sawicki
436775b1e4 Merge branch 'opener-origin-check' 2016-11-16 08:10:18 -08:00
Kevin Sawicki
aa2824621a Make scheme const 2016-11-16 08:03:07 -08:00
Kevin Sawicki
651eaec64f Use sender.id instead of sender.webContents.id 2016-11-16 07:50:30 -08:00
Kevin Sawicki
92577c37c8 Don't log blocked messages when guestWindow is null 2016-11-16 07:50:30 -08:00
Kevin Sawicki
04c68745db Always call done callback in before block 2016-11-16 07:50:30 -08:00
Cheng Zhao
81f2e76e36 Fix standard linting errors 2016-11-16 07:50:30 -08:00
Cheng Zhao
18fca785c4 Print error messages 2016-11-16 07:50:30 -08:00
Cheng Zhao
a1066617a8 Do permission check when calling guest window methods 2016-11-16 07:50:30 -08:00
Cheng Zhao
a1dfdbdde4 spec: Should check origin before accessing window.opener 2016-11-16 07:50:30 -08:00
Kevin Sawicki
63a138b6de Merge pull request #7980 from electron/guard-against-missing-members
Guard against missing members in setObjectMembers
2016-11-16 07:46:42 -08:00
Kevin Sawicki
5167ccd147 Guard against missing members in setObjectMembers 2016-11-16 07:45:34 -08:00
Kevin Sawicki
cb0845fc49 Merge pull request #7979 from electron/credits-attributed-string
Convert about credits to NSAttributedString
2016-11-16 07:45:07 -08:00
Kevin Sawicki
11449b2e8c Convert about credits to NSAttributedString 2016-11-16 07:42:24 -08:00
Kevin Sawicki
bee5ced8f4 Merge pull request #7978 from electron/memoize-no-asar-env-check
Memoize ELECTRON_NO_ASAR env var check
2016-11-16 07:41:48 -08:00
Kevin Sawicki
bea1a0643c Memoize ELECTRON_NO_ASAR env var check 2016-11-16 07:37:53 -08:00
Kevin Sawicki
f111bb4107 Merge pull request #7989 from electron/pin-electron-docs-linter
Pin electron-docs-linter version
2016-11-16 07:37:08 -08:00
Kevin Sawicki
f20ca63dd0 Pin electron-docs-linter to 1.14.1 2016-11-16 07:33:36 -08:00
Márton Salomváry
98e18a62e2 Clarify docs on a before-quit behavior edge case
See #7875
2016-11-16 10:38:57 +01:00
Kevin Sawicki
9624bc1403 Merge pull request #7917 from voidbridge/feature/expose-cert-chain
Expose whole certificate chain to verify proc
2016-11-15 16:37:58 -08:00
Kevin Sawicki
fc1ce3eeab Assert certs further up the chain 2016-11-15 16:32:12 -08:00
Kevin Sawicki
095d711848 Remove select-client-certificate issueCert assert 2016-11-15 16:24:50 -08:00
Kevin Sawicki
a1dca8afc9 🎨 Remove buildup asserts and just use assert.equal 2016-11-15 15:53:42 -08:00
Greg Nolle
86321a2c60 Fixed incorrect subject name of test client certificate. 2016-11-15 15:53:42 -08:00
Greg Nolle
2e5c92d41e Fix listing issues: remove semicolons. 2016-11-15 15:53:42 -08:00
Greg Nolle
f767f0f048 Remove unnecessary ConvertToV8 calls. 2016-11-15 15:53:42 -08:00
Greg Nolle
93ce2f7800 Add assertions for new fields in existing specs. 2016-11-15 15:53:42 -08:00
Greg Nolle
5d028f9163 Expose extra certificate information: full breakdown of issuer and subject principals, as well as full structure of intermediate issuer certificates. 2016-11-15 15:53:42 -08:00
Greg Nolle
446399c3c1 Expose whole certificate chain to verify proc and certificate-error event. 2016-11-15 15:53:42 -08:00
Kevin Sawicki
0ef6d4631d Merge pull request #7658 from figma/webview-manual-guest-resize
Allow webview guests to be resized manually
2016-11-15 14:21:56 -08:00
Kevin Sawicki
b87d86e9d5 Merge pull request #7982 from kirly-af/kirly-af-tray-example-fix
[ci skip] Correct Linux limitation example
2016-11-15 14:19:03 -08:00
Kevin Sawicki
35e000024c Minor doc updates to setSize/disableguestresize 2016-11-15 13:59:01 -08:00
Kevin Sawicki
9e51c779e1 Assert expected height 2016-11-15 13:54:25 -08:00
Alexandre
6f8eb282b7 [ci skip] Correct Linux limitation example 2016-11-15 21:53:54 +01:00
Kevin Sawicki
301b8ec39a Merge pull request #7962 from liusy182/disable-accelerator
disable accelerator when menu item is disabled
2016-11-15 11:05:36 -08:00
Birunthan Mohanathas
2986b7bc4a Allow webview guests to be resized manually
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.

These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905.
2016-11-15 11:00:09 -08:00
张树源
89feefac2c update app.md Chinese translation to latest version (#7973)
* Update Chinese translation to latest version.

* Update app.md translation

* update app.md Chinese translation to latest version.
2016-11-15 10:04:00 -08:00
Kevin Sawicki
68a6b39920 Merge pull request #7971 from electron/modify-install-docs
make npm install instructions more prominent
2016-11-15 10:03:23 -08:00
Kevin Sawicki
eeffa42513 Merge pull request #7923 from jhen0409/patch-1
Add support remove / clear for chrome.storage
2016-11-15 09:04:45 -08:00
Jhen
8b30439d7f Update devtools extension spec for chrome.storage 2016-11-15 19:58:08 +08:00
Samuel Attard
01005688b6 Implement chrome.runtime.onMessage response callback 2016-11-15 21:30:40 +11:00
liusi
00d9baa605 fix linting error 2016-11-15 13:23:59 +08:00
liusi
9e91f319c1 fix linting error 2016-11-15 13:19:34 +08:00
Kevin Sawicki
619bb31de2 Merge pull request #7972 from electron/macos-10-11-constants
Use visual effect values directly since enums are 10.11+
2016-11-14 17:04:55 -08:00
Kevin Sawicki
dcb3a13361 Use values directly since constants are 10.11+ 2016-11-14 16:43:05 -08:00
Kevin Sawicki
c2663e48c1 Merge pull request #7967 from veleek/patch-1
Update electron-squirrel-startup link
2016-11-14 15:46:34 -08:00
Zeke Sikelianos
621715e5e5 link to more relevant yarn doc 2016-11-14 13:57:12 -08:00
Zeke Sikelianos
b9991f0494 make npm install instructions more prominent 2016-11-14 13:52:07 -08:00
Ben Randall
c259b4294d Update electron-squirrel-startup link
The currently link points to a non-existent page.  I'm pointing it to another link that seems to be appropriate, but I'm not positive.
If someone else knows that this is the correct place to link that would be nice to hear.
2016-11-14 10:16:24 -08:00
Kevin Sawicki
4867475cee Merge pull request #7540 from deepak1556/form_post_new_window_patch
webContents: handle POST navigation for new windows
2016-11-14 07:39:54 -08:00
Kevin Sawicki
8822c7d87d Merge pull request #7958 from jhen0409/patch-2
Add Redux DevTools Extension to support list
2016-11-14 07:32:53 -08:00
liusi
06cfcd612d disable accelerator when menu item is disabled 2016-11-14 12:29:27 +08:00
Jhen
1404ea1c2c Add Redux DevTools Extension to support list 2016-11-14 00:32:31 +08:00
deepak1556
4deb7c6fa7 fix lint error 2016-11-12 07:16:48 +05:30
Kevin Sawicki
b9e950f5c7 Mark postData as optional 2016-11-12 07:15:21 +05:30
Kevin Sawicki
134f8afbe6 Add specs for content type on POST forms 2016-11-11 10:54:01 -08:00
Kevin Sawicki
50019f39e9 🎨 2016-11-11 10:54:01 -08:00
deepak1556
5f596b22c7 specify content type depending on post data 2016-11-11 10:54:01 -08:00
Kevin Sawicki
cbb68f6980 Remove quotes around key 2016-11-11 10:54:01 -08:00
deepak1556
61576c39be uploadData => uploadRawData 2016-11-11 10:54:01 -08:00
deepak1556
9536ebc0ad fix build error 2016-11-11 10:54:01 -08:00
deepak1556
723a3eda8b update docs 2016-11-11 10:54:01 -08:00
deepak1556
a5fd6507a9 set default values in converter 2016-11-11 10:54:01 -08:00
deepak1556
dbe57c4ad4 update docs 2016-11-11 10:54:01 -08:00
deepak1556
ad5f944185 add spec 2016-11-11 10:53:36 -08:00
deepak1556
2044208fd6 add docs 2016-11-11 10:53:36 -08:00
deepak1556
2d7ceae320 fix js lint error 2016-11-11 10:53:00 -08:00
deepak1556
0410a184ce webContents: handle POST navigation for new windows 2016-11-11 10:53:00 -08:00
Kevin Sawicki
7cfe1dd0af Merge pull request #7946 from electron/move-footer-links-to-bottom
Move footer links to bottom
2016-11-11 10:23:03 -08:00
Kevin Sawicki
4de2493d89 Move footer links to bottom 2016-11-11 10:22:27 -08:00
Jhen
b86dff45d7 Add support remove / clear for chrome.storage 2016-11-12 02:16:51 +08:00
Zeke Sikelianos
fb8339830e Merge pull request #7945 from electron/add-process-to-content-tracing-doc
add process to contentTracing doc
2016-11-11 10:09:07 -08:00
Zeke Sikelianos
ec7cae4a34 add process to contentTracing doc 2016-11-11 10:07:36 -08:00
Zeke Sikelianos
80a7835cdf Merge pull request #7884 from electron/optional-things
Update docs to correctly identify props and params that are optional
2016-11-11 09:47:31 -08:00
Zeke Sikelianos
50be8b65d1 update docs linter 2016-11-11 09:22:55 -08:00
Samuel Attard
174e51507d Update menu.md 2016-11-11 09:22:55 -08:00
Samuel Attard
494afec01d remote require could resolve to strings/numbers not just objects 2016-11-11 09:22:55 -08:00
Samuel Attard
aeefee7348 Fix the download-item doc so it correctly resembles a class 2016-11-11 09:22:55 -08:00
Samuel Attard
c1af62a3b3 Move crash-report object to it's own struct 2016-11-11 09:22:55 -08:00
Samuel Attard
11f8923c43 Fix tray and menu docs 2016-11-11 09:22:55 -08:00
Samuel Attard
63ebc41778 More docs updates 2016-11-11 09:22:55 -08:00
Samuel Attard
1a9b4b4671 First few docs made optional 2016-11-11 09:22:55 -08:00
Kevin Sawicki
8a29604f1e Merge pull request #7944 from electron/autorelease-effect-view
Autorelease NSVisualEffectView
2016-11-11 09:05:32 -08:00
Kevin Sawicki
483e007b69 🎨 2016-11-11 08:51:33 -08:00
Kevin Sawicki
2d8a61a775 autorelease NSVisualEffectView 2016-11-11 08:51:29 -08:00
gellert
5e62d28e50 adds test, adds view to AtomNSWindow and minor fixes 2016-11-11 08:49:57 -08:00
gellert
2cf30c0d63 remove method transferred to set with null 2016-11-11 08:49:57 -08:00
gellert
16253fe708 doc fixes 2016-11-11 08:49:57 -08:00
gellert
84a3fe50dc little fix in docs 2016-11-11 08:49:57 -08:00
gellert
8ad50d1e35 adds vibrancy effect for macos 2016-11-11 08:49:57 -08:00
Zeke Sikelianos
ad638097b6 Merge pull request #7933 from joshaber/patch-1
Update external frameworks version
2016-11-11 07:43:35 -08:00
liusi
356d0520ae fix linting error 2016-11-11 17:57:22 +08:00
joshaber
999b349e94 Docit 2016-11-10 13:35:56 -05:00
Kevin Sawicki
76375a83eb Merge pull request #7925 from mrxf/patch-5
Modify the error terms
2016-11-10 09:34:14 -08:00
Kevin Sawicki
ea534aa564 Merge pull request #7922 from mrxf/patch-4
Modify some translation errors
2016-11-10 09:33:55 -08:00
Kevin Sawicki
055e49ab9c Merge pull request #7921 from mrxf/patch-3
fix some translation problems
2016-11-10 09:33:04 -08:00
Josh Abernathy
0d43e239d4 Update to version 1.2.0 of external frameworks. 2016-11-10 11:33:01 -05:00
张树源
c04a0381dc Modify the error terms
There is an error in the translation of the last sentence.It may make reader confuse.
2016-11-10 14:42:41 +08:00
张树源
5cebe65310 Modify some translation errors 2016-11-10 11:13:54 +08:00
张树源
ab5a49b6ae fix some translation problems
update translation.
2016-11-10 10:29:43 +08:00
Kevin Sawicki
7b463297c6 Merge pull request #7908 from deepak1556/about_scheme_patch
protocol: register about scheme handler
2016-11-09 16:13:27 -08:00
Kevin Sawicki
debdce1e66 Bump v1.4.6 2016-11-09 11:59:25 -08:00
Kevin Sawicki
8a2706d2f4 Merge pull request #7906 from electron/upgrade-chrome-53
Upgrade to Chrome 53.0.2785.143
2016-11-09 11:49:33 -08:00
Kevin Sawicki
709dd0bf18 Upgrade to Chrome 53.0.2785.143 2016-11-09 11:03:44 -08:00
Kevin Sawicki
de78f3441e Merge pull request #7916 from thompsonemerson/patch-7
add link for powerSaveBlocker | pt-br
2016-11-09 08:28:21 -08:00
Emerson Thompson
f23624755e add link for powerSaveBlocker | pt-br 2016-11-09 13:25:24 -03:00
Kevin Sawicki
0c265f8ed4 Merge pull request #7912 from mrxf/patch-2
Update translation
2016-11-09 08:17:59 -08:00
Kevin Sawicki
c1f2e30c5a Merge pull request #7910 from mrxf/patch-1
update simplified Chinese translation
2016-11-09 08:17:31 -08:00
Kevin Sawicki
3b415b2e99 Merge pull request #7907 from thompsonemerson/patch-5
power-save-blocker.md file translation
2016-11-09 08:16:20 -08:00
张树源
bea9f78ddb Update translation
change link to a simple Chinese page.
2016-11-09 18:29:49 +08:00
张树源
95484a1b1a 修改翻译不完善部分
完善翻译内容
2016-11-09 16:53:53 +08:00
deepak1556
a0065e62fa add about: protocol handler 2016-11-09 13:22:58 +05:30
deepak1556
3aab713d24 add failing spec 2016-11-09 11:00:50 +05:30
Emerson Thompson
5d6f180413 power-save-blocker.md file translation 2016-11-08 14:51:53 -03:00
liusi
a69ee76705 fix review comments 2016-11-08 15:36:37 +08:00
Kevin Sawicki
7971ce0dd9 Merge pull request #7895 from electron/windows-symbol-server
Update Windows symbols server URL
2016-11-07 15:14:53 -08:00
Lee Dohm
4159a6a41d Merge pull request #7900 from electron/more-license-clarification
More license section clarification and update copyright year
2016-11-07 14:57:46 -08:00
Lee Dohm
e49af23a7d Add copyright range of 2013-2016 to LICENSE 2016-11-07 14:54:54 -08:00
Lee Dohm
30117816be More license section clarification 2016-11-07 14:26:21 -08:00
Kevin Sawicki
b6ece7d16c Merge pull request #7852 from electron/webview-guestinstance
Fix reload/destroy webview guestinstance issues
2016-11-07 13:48:01 -08:00
Kevin Sawicki
6fda4fc45c Guard against attachedCallback firing while handling detachedCallback 2016-11-07 13:42:36 -08:00
Kevin Sawicki
18e1de105f Add failing spec for deleted guestinstance when moving webview 2016-11-07 13:42:36 -08:00
Kevin Sawicki
133ad6e18b Only set size and load URL on first attach 2016-11-07 13:42:36 -08:00
Kevin Sawicki
b84fed5cb2 Add failing spec for hide/show reload issue 2016-11-07 13:42:36 -08:00
Kevin Sawicki
a737732521 Only remove guest from embedder when view id changes 2016-11-07 13:42:36 -08:00
Kevin Sawicki
f454cb3408 Add failing spec for hide/show webview issue 2016-11-07 13:42:36 -08:00
Lee Dohm
d18a9eaf65 Merge pull request #7897 from electron/logo-clarification
Add logo clarification and standardized licensing language
2016-11-07 12:23:08 -08:00
Lee Dohm
059433511c Add logo clarification and standardized licensing language 2016-11-07 12:08:11 -08:00
Kevin Sawicki
acacb3f551 Update symbols server URL 2016-11-07 10:58:27 -08:00
Kevin Sawicki
0008bc5f82 Merge pull request #7893 from tinydew4/translate-ko
Update the korean docs up to 'ef9d8fe' commit.
2016-11-07 08:55:22 -08:00
Kevin Sawicki
a3e10aba95 Merge pull request #7863 from electron/coffee-script-webview-cleanup
Clean up CoffeeScript leftovers in webview code
2016-11-07 08:53:08 -08:00
Kevin Sawicki
73774f21b7 🎨 2016-11-07 08:28:02 -08:00
Kevin Sawicki
3c18de9c5a Only return when guestInstance is non-null 2016-11-07 08:25:01 -08:00
Kevin Sawicki
19a5d2ba2b Use window close helper instead of destroying for coverage 2016-11-07 08:25:01 -08:00
Kevin Sawicki
16f57b219b Add resize event spec 2016-11-07 08:25:01 -08:00
Kevin Sawicki
0485069c7b Use spread operator 2016-11-07 08:25:01 -08:00
Kevin Sawicki
e4d6aa30a1 Do truthy check in if block 2016-11-07 08:25:01 -08:00
Kevin Sawicki
89a26684e5 Return webContents directly 2016-11-07 08:25:01 -08:00
Kevin Sawicki
0e1c2b0fcb Use for/of and remove loop variables 2016-11-07 08:25:01 -08:00
Kevin Sawicki
6eab14359c Use ES6 style class for WebViewImpl 2016-11-07 08:25:01 -08:00
Kevin Sawicki
76f96bd99c Destructure requires 2016-11-07 08:25:01 -08:00
Kevin Sawicki
48bcad87c2 Use template strings 2016-11-07 08:25:01 -08:00
Kevin Sawicki
712b15286c Use let/const instead of var 2016-11-07 08:25:01 -08:00
Kevin Sawicki
3053be345b Remove unneeded returns 2016-11-07 08:25:01 -08:00
Kevin Sawicki
8e834e9047 Merge pull request #7869 from electron/less-browserify-build-time
Only run browserify when sandbox files change
2016-11-07 08:20:20 -08:00
Kevin Sawicki
3e34760eef Run browserify with --silent 2016-11-07 08:19:59 -08:00
Kevin Sawicki
e0afb814aa Only call browserify when one of sandbox sources change 2016-11-07 08:19:59 -08:00
tinydew4
0fd35cf768 Update the korean docs up to 'ef9d8fe' commit. 2016-11-07 13:59:53 +00:00
Kevin Sawicki
0b86acfef4 Merge pull request #7881 from electron/node-headers-url
Update dist url to be electron instead of atom-shell
2016-11-04 16:22:34 -07:00
Kevin Sawicki
36ee417d3b Update more download URLs from atom-shell to electron 2016-11-04 16:21:30 -07:00
Kevin Sawicki
a1a07aed44 Add atom-shell URL to planned breaking changes 2016-11-04 16:21:30 -07:00
Kevin Sawicki
f0731be20b Update dist url to be electron instead of atom-shell 2016-11-04 16:21:30 -07:00
Zeke Sikelianos
58278ee095 Merge pull request #7867 from electron/update-issue-template
ask for more info in the issue template
2016-11-04 15:12:20 -07:00
Zeke Sikelianos
494a025fb8 🎨 2016-11-04 15:11:40 -07:00
Zeke Sikelianos
ade8401b5b add a preamble 2016-11-04 12:12:37 -07:00
Zeke Sikelianos
ef9d8fe9bd Merge pull request #7843 from electron/process-docs
document the process(es) in which APIs are available
2016-11-03 13:14:30 -07:00
Zeke Sikelianos
471b9980ec line up process annotations consistently 2016-11-03 13:13:21 -07:00
Zeke Sikelianos
9c65b9a9f2 ask for more info in the issue template 2016-11-03 12:58:31 -07:00
Zeke Sikelianos
21105271a4 document processes for APIs nested in parent docs 2016-11-03 11:50:00 -07:00
Kevin Sawicki
7e90bb47a5 Merge pull request #7533 from electron/async-executeJavaScript
Allow web frame methods to return async promises
2016-11-03 10:32:21 -07:00
Zeke Sikelianos
ac68de6215 document process(es) for all APIs 2016-11-03 10:26:00 -07:00
Kevin Sawicki
8e203592e2 🎨 Remove extra returns 2016-11-03 09:51:01 -07:00
Samuel Attard
9f18a6e65c Use ES6 template strings, fix docs and remove _ERROR_ IPC event 2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3 Make executeJavaScript return a Promise so that caught errors can be sent to the caller 2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63 Add sync executeJavaScript test 2016-11-03 09:33:47 -07:00
Samuel Attard
124fbdbd74 Allow web frame methods to return async promises 2016-11-03 09:33:47 -07:00
Kevin Sawicki
cf0cd5b50b Merge pull request #7823 from kanemontreuil/consolidate-gitignore
Consolidate log files
2016-11-03 09:26:48 -07:00
liusi
0e9d973715 toggle thick_frame_ along with resizable change 2016-11-03 12:13:06 +08:00
Zeke Sikelianos
cc18670ae1 Merge pull request #7854 from electron/fix-ipc-docs
Fix the IPC docs so the docs-linter finds the methods
2016-11-02 20:14:47 -07:00
Samuel Attard
6228ce3f35 Fix the IPC docs so the docs-linter finds the methods 2016-11-03 14:04:03 +11:00
Kevin Sawicki
89511bb0cb Merge pull request #7847 from tinydew4/translate-ko
[ko] Add net document on README.md
2016-11-02 09:23:54 -07:00
Kevin Sawicki
11bc993344 Merge pull request #7846 from thomsonreuters/net-doc-samples
Documentation: Formatting JavaScript sample code.
2016-11-02 09:23:35 -07:00
tinydew4
9126ab6766 Add net document on README.md 2016-11-02 11:22:21 +00:00
ali.ibrahim
49cb675057 Fixing a trivial js lint issue. 2016-11-02 11:16:37 +01:00
ali.ibrahim
e8b119e636 Formatting JavaScript sample code. 2016-11-02 10:40:51 +01:00
Zeke Sikelianos
e8bb79310c document the process(es) in which APIs are available 2016-11-01 16:35:31 -07:00
Zeke Sikelianos
da3dbdcb9b Merge pull request #7837 from electron/lightweight-docs-linter
use docs linter with lots of stuff npmignored
2016-11-01 12:12:04 -07:00
Zeke Sikelianos
b400edcc88 use docs linter with lots of stuff npmignored 2016-11-01 10:45:29 -07:00
Kevin Sawicki
6580088574 Bump v1.4.5 2016-11-01 08:51:10 -07:00
Haojian Wu
794479519c Add missing net document entry. 2016-11-01 16:50:55 +01:00
Kevin Sawicki
97d468cf35 Merge pull request #7822 from tinydew4/translate-ko
Update the korean docs up to '379c347' commit.
2016-11-01 08:44:10 -07:00
Kevin Sawicki
af6a3b3173 Merge pull request #7821 from electron/lint-net-docs
use new docs linter with support for the new net APIs
2016-11-01 08:43:46 -07:00
Kevin Sawicki
0c8160bfe3 Merge pull request #7820 from tinydew4/trimming
Trim: docs/api/net.md
2016-11-01 08:43:28 -07:00
Kane Montreuil
a584acef46 Consolidate log files 2016-11-01 00:47:34 -04:00
tinydew4
691ad97abe Update the korean docs up to '379c347' commit.
Swap two debugging tutorials with each other.
2016-11-01 04:20:23 +00:00
tinydew4
836cd017a9 Trim: docs/api/net.md 2016-11-01 03:53:45 +00:00
Zeke Sikelianos
e70f8acf47 use new docs linter with support for the new net APIs 2016-10-31 20:53:13 -07:00
Zeke Sikelianos
721924b749 Merge pull request #7818 from electron/more-net-doc-fixes
fix formatting of new net API doc
2016-10-31 19:36:31 -07:00
liusi
7880d37d73 merge changes from master 2016-11-01 10:20:47 +08:00
Kevin Sawicki
ba6bb45f70 Merge pull request #7813 from electron/ready-to-show-spec
Add initial ready-to-show event spec
2016-10-31 16:28:09 -07:00
Zeke Sikelianos
379c3470c8 fix formatting of new net API doc 2016-10-31 15:48:06 -07:00
Kevin Sawicki
038718717c Add initial ready-to-show spec 2016-10-31 12:40:49 -07:00
Kevin Sawicki
b8f09ecf4f Merge pull request #7812 from electron/url-format-in-quick-start
Format URL passed to BrowserWindow.loadURL
2016-10-31 11:37:41 -07:00
Kevin Sawicki
e9a2792b55 Format URL passed to BrowserWindow.loadURL 2016-10-31 11:34:53 -07:00
Kevin Sawicki
aa3bc13ca3 Merge pull request #7788 from electron/notification-crash
Fix notification crash when using permission handler
2016-10-31 09:39:38 -07:00
Kevin Sawicki
ed3a2dae1b Merge pull request #7787 from julianengel/patch-1
Added example usage for the default port
2016-10-31 09:28:20 -07:00
Kevin Sawicki
48eaee0c0e Match example to node inspector doc 2016-10-31 09:27:42 -07:00
Kevin Sawicki
6b2848307d Merge pull request #7807 from electron/net-docs-fixup
Quick fix up of net docs
2016-10-31 09:23:07 -07:00
DaLun
651a2d4399 ZH_TW docs update (#7797)
* Update cookie.md

* Update cookie.md

* Update task.md

* ZH_TW docs /structures/cookie add

* Fix a word && add new docs

* Update task.md

* Update cookie.md

* new update
2016-10-31 09:21:56 -07:00
DaLun
7c48dd54e1 ZH_TW docs api/structures/cookie add (#7793)
* Update cookie.md

* Update cookie.md

* Update task.md

* ZH_TW docs /structures/cookie add

* Fix a word && add new docs

* Update task.md

* Update cookie.md
2016-10-31 09:21:43 -07:00
Zeke Sikelianos
5968346c1e Merge pull request #7809 from shiftkey/typos-for-net-docs
fixed a couple of typos
2016-10-31 09:16:32 -07:00
Zeke Sikelianos
266d3b553b Merge pull request #7745 from electron/inline-enums
update docs linter to add support for inline ENUM values
2016-10-31 09:05:05 -07:00
Kevin Sawicki
53ff706cd2 Upgrade brigthray for notification crash fix 2016-10-31 09:02:18 -07:00
Brendan Forster
651b0c0f82 fixed a couple of typos 2016-10-31 08:59:26 -07:00
Kevin Sawicki
3f8e173452 Call callback asynchronously to match original issue 2016-10-31 08:54:57 -07:00
Kevin Sawicki
078c924760 Upgrade brightray for notification crash fix 2016-10-31 08:54:57 -07:00
Kevin Sawicki
611614c649 Use equal/deepEqual for channel/args asserts 2016-10-31 08:54:57 -07:00
Kevin Sawicki
dda3fcef91 Add failing spec for notification permission crash 2016-10-31 08:54:56 -07:00
Cheng Zhao
92f8c105d9 Merge pull request #7766 from liusy182/window-size-restore
incorrect position when restored from maximize-on-top-drag under Windows #7630
2016-10-31 11:04:35 +09:00
Samuel Attard
4ee308fcc2 Quick fix up of net docs 2016-10-31 12:43:57 +11:00
Cheng Zhao
dfefa00a50 Merge pull request #7577 from thomsonreuters/net_module
net module
2016-10-31 10:31:56 +09:00
Zeke Sikelianos
44146009ad Merge pull request #7795 from LaurentLeVan/master
[docs-translations\fr-FR]Add section supported platforms
2016-10-30 09:40:22 -07:00
Laurent Le Van
b376c29937 [docs-translations/fr-FR]Correct some typos (double space deletion and 'de' to 'ne') in supported-platforms.md 2016-10-30 14:22:35 +02:00
liusy182
c657186920 address review comments 2016-10-30 09:50:22 +08:00
Laurent Le Van
f613d8d0d0 [docs-translations\fr-FR]Add of the tutorial folder and create supported-platforms.md in French 2016-10-29 18:10:57 +03:00
Kevin Sawicki
a506df4d25 Merge pull request #7791 from electron/io-doc-link-fix
Fix README link to Mac debug instructions
2016-10-28 14:49:43 -07:00
Ian Olsen
a0772dbbe9 fix link to Mac debug instructions 2016-10-28 14:32:48 -07:00
Kevin Sawicki
f603e47226 Merge pull request #7785 from tinydew4/translate-ko
[ko] Update the korean docs up to '2006d64' commit.
2016-10-28 09:46:28 -07:00
Julian Engel
4b0b875d6f Added example usage for the default port
According to Issue ##7756 I added the example usage.
2016-10-28 18:04:51 +03:00
tinydew4
d50cabddc0 [ko] Update the korean docs up to '2006d64' commit. 2016-10-28 08:42:57 +00:00
Kevin Sawicki
cbda2a3e60 Merge pull request #7770 from vitaliel/patch-1
Fixed typo in ru-RU/tutorial/application-distribution.md
2016-10-27 10:43:11 -07:00
Kevin Sawicki
2006d64939 Merge pull request #7757 from crilleengvall/master
Adding documentation about hidden-inset
2016-10-28 02:42:57 +09:00
Kevin Sawicki
d9f3355dea Remove excess newlines 2016-10-27 10:42:31 -07:00
Kevin Sawicki
c8263a9a18 Add newlines and backticks 2016-10-27 10:41:43 -07:00
Kevin Sawicki
6d2e9f5311 Merge pull request #7753 from tinydew4/translate-ko
[ko] Update the korean docs up to '02a7094' commit.
2016-10-28 02:40:08 +09:00
Kevin Sawicki
bb6d15ee10 Merge pull request #7750 from bheart/master
Document the fact that Accelerators are used by the globalShortcut module
2016-10-28 02:39:46 +09:00
Kevin Sawicki
56f7aceec7 Merge pull request #7743 from doraeric/trans-zhtw
add zh-tw docs
2016-10-28 02:38:00 +09:00
Vitalie Lazu
933e013e7e Fixed typo 2016-10-27 14:58:16 +03:00
liusi
a2b3abbf47 incorrect position when restored from maximize-on-top-drag under Windows #7630 2016-10-27 17:42:43 +08:00
liusi
c61414e11b fix for Window hidden behind taskbar after maximize #7672 2016-10-27 17:14:31 +08:00
Christian Engvall
29470dd018 Adding documentation about hidden-inset 2016-10-26 21:33:48 +02:00
Zeke Sikelianos
ed878b400e Merge pull request #7752 from tinydew4/clean-up
Clean unnecessary sentences on web-contents.md
2016-10-26 11:40:23 -07:00
tinydew4
fbe4394bbd Clean unnecessary sentences on web-contents.md 2016-10-26 15:41:47 +00:00
tinydew4
3e0d8841ea Update the korean docs up to '02a7094' commit. 2016-10-26 15:36:06 +00:00
Will Tange
aeb774730b Link Accelerator docs to globalShortcut module
Usage of Accelerators (i.e. `globalShortcut.register`) is now documented in the Accelerator docs themselves.
2016-10-26 14:48:09 +02:00
ali.ibrahim
6d92457095 Fixing code review issues: refactoring emit methods using CustomEmit. 2016-10-26 11:10:15 +02:00
Zeke Sikelianos
8fa3057e19 update docs linter to add support for inline ENUM values 2016-10-25 23:48:48 -07:00
Zeke Sikelianos
eed8f201e2 Merge pull request #7741 from electron/shuffle-bw-docs
Clean up nested objects and string ENUMS in the docs
2016-10-25 23:47:32 -07:00
Zeke Sikelianos
0add800240 Merge pull request #7715 from electron/docs-linter-function-param-types
update docs linter to support parsing of function parameter types
2016-10-25 23:42:50 -07:00
doraeric
9356843e27 add zh-tw docs 2016-10-26 14:09:36 +08:00
Samuel Attard
02a7094529 Follow docs style guide for string ENUMS 2016-10-26 16:19:41 +11:00
Samuel Attard
76da80c5e9 Further clean up 2016-10-26 16:18:55 +11:00
Samuel Attard
7078ed80fa Move webPreferences and titleBarStyle to the correct place in the docs
In their previous location `electron-docs-linter` would not output an Object structure for `webPreferences` (which is a key part of the constructor)
2016-10-26 14:31:30 +11:00
Cheng Zhao
e97d3c21a3 Merge pull request #7719 from electron/find-pasteboard
Add macOS find pasteboard support
2016-10-26 11:23:14 +09:00
Kevin Sawicki
9e266642f9 Merge pull request #7592 from frontapp/master
Preview file with QuickLook
2016-10-26 10:12:15 +09:00
Kevin Sawicki
0f5bfadd2b Merge pull request #7740 from mauriciofauth/pt-br/api/window-open
Update docs-translations/pt-BR/api/window-open.md
2016-10-26 09:58:48 +09:00
Kevin Sawicki
d85c4da11b Minor formatting tweaks 2016-10-26 09:55:34 +09:00
Kevin Sawicki
d982376fc4 filename -> displayName 2016-10-26 09:47:38 +09:00
Pierre Laurac
d26601f695 Convention naming 2016-10-26 09:07:38 +09:00
Pierre Laurac
0ec57cca32 last linter commit 2016-10-26 09:06:50 +09:00
Pierre Laurac
cf5fc3f922 more linter 2016-10-26 09:06:44 +09:00
Pierre Laurac
1f60aff73d linter 2016-10-26 09:06:39 +09:00
Pierre Laurac
9b19e6ee38 Changing names and memory leak fix 2016-10-26 09:05:42 +09:00
Pierre Laurac
6bac17fb9a Linter 2016-10-26 09:05:36 +09:00
Pierre Laurac
e759ce72b5 Using UTF8 String for filepath and filename 2016-10-26 09:05:27 +09:00
Pierre Laurac
b44371f4bf filename as Optional argument 2016-10-26 09:05:01 +09:00
Pierre Laurac
9736dc3115 Specifying macOS only method 2016-10-26 09:04:30 +09:00
Pierre Laurac
18ac4178fe Validation with linter 2016-10-26 09:04:22 +09:00
Pierre Laurac
2f7cceb11c Removing extra line break 2016-10-26 09:03:55 +09:00
Pierre Laurac
002462ce7b Removing unused header dependencies 2016-10-26 09:03:49 +09:00
Pierre Laurac
4d305b06d1 Adding documentation 2016-10-26 09:03:14 +09:00
Pierre Laurac
9673cee4d7 Using string from the std 2016-10-26 09:02:36 +09:00
Pierre Laurac
526debb5ab Adding easy way to preview files 2016-10-26 09:02:29 +09:00
Pierre Laurac
fb444f646b default template for PreviewFile 2016-10-26 09:02:21 +09:00
Kevin Sawicki
26f76f8d41 Merge pull request #7739 from electron/fix-incorrect-types-registerURLSchemeAsPrivileged
Update web-frame.md
2016-10-26 08:50:20 +09:00
Maurício Meneghini Fauth
9ae18c6194 📝 Update docs-translations/pt-BR/api/window-open.md [ci skip] 2016-10-25 21:48:22 -02:00
Samuel Attard
9e425cd01e Update web-frame.md 2016-10-26 10:04:18 +11:00
Zeke Sikelianos
171b901c61 Merge pull request #7736 from mauriciofauth/pt-br/readme
Fix links in docs-translations/pt-BR/README.md
2016-10-25 14:18:01 -07:00
Zeke Sikelianos
fbade9305c Merge pull request #7730 from tinydew4/translate-ko
[ko] Update the korean docs depend on the '1c7d5df' commit.
2016-10-25 13:55:42 -07:00
Maurício Meneghini Fauth
082cd9b72c 📝 Fix links in docs-translations/pt-BR/README.md [ci skip] 2016-10-25 15:53:33 -02:00
ali.ibrahim
e9db926b48 Fixing code review issues: fixing linter issues in spec file. 2016-10-25 16:55:17 +02:00
ali.ibrahim
bdb3f4d4cb Fixing code review issues: adding some test cases for partition/session options. 2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2 Fixing code review issues: adding a partition options and making the session option only takes Session objects. 2016-10-25 15:47:54 +02:00
tinydew4
6a36deec3b Update the korean docs depend on the '1c7d5df' commit. 2016-10-25 13:34:48 +00:00
ali.ibrahim
6d7f179a9b Fixing code review issues: making delegate_ a raw pointer. 2016-10-25 15:02:35 +02:00
ali.ibrahim
61278f9ace Fixing code review issues. 2016-10-25 12:41:01 +02:00
Kevin Sawicki
7ffc1faf5b Document read/writeFindText 2016-10-25 14:16:40 +09:00
Kevin Sawicki
1c3b5835f4 Add spec for read/write find text 2016-10-25 14:15:54 +09:00
Kevin Sawicki
1718697ef0 Read/write find pasteboard text via IPC in renderer process 2016-10-25 14:15:54 +09:00
Kevin Sawicki
144a61c5a3 Add find text support to clipboard 2016-10-25 14:15:54 +09:00
Kevin Sawicki
f7bf8c4fdc Merge pull request #7718 from mike-engel/mengel/update-docs
Clarify the setMenuBarVisibility api
2016-10-25 13:08:37 +09:00
Mike Engel
6f64ad30cb Clarify the setMenuBarVisibility api
The setMenuBarVisibility api is only supported on Windows and Linux.
This adds some minor documentation to make that clearer. Fixes #7686
2016-10-24 22:04:45 -06:00
Kevin Sawicki
1c7d5df2fe Merge pull request #7717 from electron/doc-lists
Add newlines before lists
2016-10-25 12:40:32 +09:00
Kevin Sawicki
65e6da2673 Add newlines before lists 2016-10-25 12:38:08 +09:00
Kevin Sawicki
39a5c7dab9 Merge pull request #7631 from beakerbrowser/webview-policy-flags2
Add 'webpreferences' attribute to webview
2016-10-25 12:14:25 +09:00
Kevin Sawicki
b4cc3541a8 Minor tweaks to webpreferences docs 2016-10-25 12:08:19 +09:00
Kevin Sawicki
68c2c9825f Remove lint warnings 2016-10-25 10:36:43 +09:00
Kevin Sawicki
3aad6a0c99 Use forEach and destructuring for parsing features 2016-10-25 10:31:50 +09:00
Kevin Sawicki
2556ed8744 Add parse-features-strings.js 2016-10-25 10:28:36 +09:00
Paul Frazee
f35536bdc5 factor out parse-features-string.js 2016-10-24 20:21:42 -05:00
Cheng Zhao
775328d5d5 Merge pull request #7707 from electron/focus-window-on-menu-bar-click
Focus window on menu bar click
2016-10-25 09:09:45 +09:00
Zeke Sikelianos
1a03e62717 update docs linter to support parsing of function parameter types 2016-10-24 12:04:37 -07:00
Kevin Sawicki
31b4f61815 Merge pull request #7651 from deepak1556/session_cert_verifier_patch
session: exclude hosts from CT verification if they are handled by custom cert verifiers
2016-10-24 16:53:04 +09:00
Kevin Sawicki
076e033236 Merge pull request #7711 from tinydew4/translate-ko
[ko] Apply the changes till the 'a2a4462' commit.
2016-10-24 16:49:37 +09:00
tinydew4
2c50f14346 Apply the changes till the 'a2a4462' commit. 2016-10-24 07:41:15 +00:00
Kevin Sawicki
82e593b44f Merge pull request #7709 from tinydew4/translate-ko
[ko] 	Apply the changes till the 'b2559d7' commit.
2016-10-24 16:36:58 +09:00
Kevin Sawicki
224d2ca93c Merge pull request #7710 from electron/web-frame-lint
Remove RegisterURLSchemeAsPrivileged lint error
2016-10-24 16:29:10 +09:00
Kevin Sawicki
0841c4291a Remove RegisterURLSchemeAsPrivileged lint error 2016-10-24 16:27:54 +09:00
Kevin Sawicki
271733fc53 Add tests for ses.setCertificateVerifyProc 2016-10-24 16:12:49 +09:00
Kevin Sawicki
a2a44621fd Merge pull request #7708 from tinydew4/fix-typo
Fix typo, and trimming.
2016-10-24 16:12:29 +09:00
Cheng Zhao
ad48aeeea4 Merge pull request #7665 from beakerbrowser/privilegedschemeopts
Add options to webFrame.registerURLSchemeAsPrivileged
2016-10-24 15:56:18 +09:00
Kevin Sawicki
83f47bc980 Upgrade brighray for RequireCTDelegate 2016-10-24 15:44:21 +09:00
tinydew4
67a09d9fe0 Fix typo, and trimming. 2016-10-24 06:34:09 +00:00
tinydew4
189ae97732 Apply the changes till the 'b2559d7' commit. 2016-10-24 06:32:28 +00:00
Kevin Sawicki
632739ec6e Merge pull request #7590 from electron/docs-cleanup
Cleanup docs and standardize structs
2016-10-24 15:13:39 +09:00
Cheng Zhao
88ac376382 Merge pull request #7628 from deepak1556/geo_request_context_patch
browser: fix race in creation of default browser context by AtomAccessTokenStore
2016-10-24 14:57:37 +09:00
Kevin Sawicki
b2559d7d28 Merge pull request #7596 from electron/function-param-types
Function param types
2016-10-24 12:40:41 +09:00
Kevin Sawicki
98387e50cc Focus window on menu bar click 2016-10-24 11:49:51 +09:00
Constantin Dumitrescu
93464b8100 [ci skip] Update docs/README.md to point to the right location of styleguide.md (#7697) 2016-10-24 10:22:22 +09:00
kok liu
52783bb67f update the zh-CN docs README.md and find a error in en docs README.md (#7676)
* update the zh-CN readme and find a error in en readme

* fix a style problem
2016-10-24 10:21:02 +09:00
Kevin Sawicki
c90d4abcf0 Merge pull request #7654 from scotttrinh/flash-frame-doc
📝 Add flashFrame to desktop env integration
2016-10-24 10:20:08 +09:00
Kevin Sawicki
6f85d85c12 Minor tweaks to flash frame section 2016-10-24 10:19:51 +09:00
Kevin Sawicki
280235872b Add flashframe link 2016-10-24 10:14:52 +09:00
Kevin Sawicki
e93eaed5d0 Merge pull request #7666 from amtj/issue#6939
📝Remove ambiguous default value of nodeintegration Issue #6939
2016-10-24 09:54:46 +09:00
Kevin Sawicki
32cff67fd4 Merge pull request #7641 from rogerlista/master
📝 Link to README.md pt-br [ci skip]
2016-10-24 09:19:08 +09:00
Kevin Sawicki
d3f40212db Merge pull request #7622 from Haraldson/flash-trust
Add a note on Flash permissions to Troubleshooting
2016-10-24 09:16:07 +09:00
Zeke Sikelianos
11ad9e7f25 Merge pull request #7650 from davej/patch-3
Docs: Fix relative link to MAS builds tutorial
2016-10-22 23:51:59 +09:00
ali.ibrahim
0c44d19249 net module: documenting the session property. 2016-10-20 15:48:36 +02:00
ali.ibrahim
7c17aeb6da Documenting net module: fixing linter issues. 2016-10-20 14:42:15 +02:00
ali.ibrahim
8c19d3b210 Documenting net module: various fixes. 2016-10-20 13:57:08 +02:00
ali.ibrahim
9f15191280 Formatting net documentation. 2016-10-20 12:30:03 +02:00
ali.ibrahim
69790bd7ed Documenting ClientRequest constructor options. 2016-10-20 11:58:06 +02:00
ali.ibrahim
fdfa0f4a6d Documenting the login event. 2016-10-20 11:45:45 +02:00
ali.ibrahim
7f8b180f70 Fixing authentication cancel with null/undefined credentials. 2016-10-20 11:43:26 +02:00
tinydew4
43ae784a40 Translate releasing 2016-10-20 08:58:48 +00:00
Kevin Sawicki
6a4d9f8a87 Merge pull request #7674 from electron/tweak-releasing-doc
Push after bumping version
2016-10-20 16:12:33 +09:00
Kevin Sawicki
e2c646a14b Push after bumping 2016-10-20 11:34:51 +09:00
Kevin Sawicki
337db9fbb9 Merge pull request #7660 from electron/document-release-process
Document release process
2016-10-20 11:31:51 +09:00
Zeke Sikelianos
63267031e9 💲 2016-10-20 11:30:36 +09:00
Zeke Sikelianos
88b288502a Add note about Python HTTPS warning 2016-10-20 11:29:02 +09:00
Zeke Sikelianos
b0fb0c6492 Document S3 creds 2016-10-20 11:22:32 +09:00
Zeke Sikelianos
3a44663003 Add note about setting $ELECTRON_GITHUB_TOKEN 2016-10-20 11:19:18 +09:00
Zeke Sikelianos
147addbce1 Bump v1.4.4 2016-10-20 09:17:29 +09:00
ali.ibrahim
7549adcfce Documenting net module: various fixes. 2016-10-19 18:31:08 +02:00
ali.ibrahim
fddbde2fd5 Documenting net module: various fixes. 2016-10-19 18:19:28 +02:00
ali.ibrahim
6e5951b764 Documenting net module: formatting. 2016-10-19 18:11:07 +02:00
ali.ibrahim
3b620b8c0c Documenting net module: various fixes. 2016-10-19 18:05:38 +02:00
ali.ibrahim
0d82fbcf37 Documenting net.IncomingMessage. 2016-10-19 16:51:44 +02:00
ali.ibrahim
5cd20a8e5d Documenting net.ClientRequest 2016-10-19 15:34:21 +02:00
Amitoj
4ff73d8b56 📝 Small tweaks
[ci skip] Remove ambiguous default value of nodeintegration.
Issue #6939
2016-10-19 13:38:46 +05:30
ali.ibrahim
f651b21cda Fixing net doc file name. 2016-10-19 09:24:59 +02:00
Zeke Sikelianos
7a73c0189f bump-release -> bump-version 2016-10-19 11:40:40 +09:00
Paul Frazee
0345b62369 update webFrame.registerURLSchemeAsPrivileged docs to be more specific 2016-10-18 17:13:33 -05:00
Amitoj
3a31f28f27 📝Remove ambiguous default value of nodeintegration
Remove ambiguous default value for nodeintegration in webview.
Issue #6939
2016-10-19 02:38:29 +05:30
Paul Frazee
a5c62bb264 add options to webFrame.registerURLSchemeAsPrivileged 2016-10-18 15:52:41 -05:00
ali.ibrahim
9bddc2cbaa Adding net documentation skeleton. 2016-10-18 19:14:43 +02:00
ali.ibrahim
43113fcfb4 Fixing net response objects being piped into writable streams test. 2016-10-18 10:28:35 +02:00
Zeke Sikelianos
6b207d65bf update releasing 2016-10-18 14:04:52 +09:00
Samuel Attard
9d0d1c8341 Fix bd object name 2016-10-18 15:47:18 +11:00
Zeke Sikelianos
82a16ee41f document the electron release process 2016-10-18 13:41:57 +09:00
Kevin Sawicki
104f8d6057 Merge pull request #7659 from electron/jacob/ally
Fire a11y event on touch screens using screen readers
2016-10-18 13:41:48 +09:00
Jacob Groundwater
9c9ba80978 Fire a11y event on touch screens using screen readers 2016-10-18 13:28:32 +09:00
Scott Trinh
a06a1fa262 📝 Add flashFrame to desktop env integration 2016-10-17 16:22:45 -04:00
ali.ibrahim
c198828e58 Adding gc tests: fixing a memory leak with C++ URLRequest objects. 2016-10-17 19:02:25 +02:00
Cheng Zhao
cbe9768529 Merge pull request #7566 from electron/always-shorten-path
Shorten Socket path for makeSingleInstance in sandboxed apps
2016-10-17 20:43:51 +08:00
Cheng Zhao
ce847fc3ca Merge pull request #7578 from electron/windows-logging
Show console output from Windows when ELECTRON_RUN_AS_NODE is set
2016-10-17 20:22:39 +08:00
deepak1556
5cbbd6efe6 session: exclude hosts from CT verification if they are handled by custom cert verifiers 2016-10-17 16:35:28 +05:30
Dave Jeffery
00d641aaf7 Docs: Fix relative link to MAS builds tutorials
The link was 404'ing
2016-10-17 11:26:28 +01:00
ali.ibrahim
9b4e9c642a Making test code run directly in main browser context to avoid rpc persistent handles. 2016-10-17 11:51:20 +02:00
ali.ibrahim
c6ae27c7c9 Adding a stability test: non referenced, unused requests are collected without crash. 2016-10-17 10:38:10 +02:00
Rogério
9ead3ad0a0 📝 Link to README.md pt-br [ci skip] 2016-10-15 21:01:37 -03:00
Paul Frazee
e7962c7ba2 fixes and tests for webview 'webpreferences' attr 2016-10-14 18:04:33 -05:00
Paul Frazee
194b14100e add the 'webpreferences' attribute to webviews 2016-10-14 17:16:39 -05:00
Kevin Sawicki
3dd8377218 Merge pull request #7611 from electron/only-enable-msaa-if-needed
Check harder before enabling Accessibility support on Win32
2016-10-14 12:46:32 -07:00
deepak1556
bd34db256b browser: fix race in creation of default browser context by AtomAccessTokenStore 2016-10-15 01:00:54 +05:30
Paul Betts
6fdf40b038 Code Cleanup 2016-10-14 12:17:32 -07:00
Kevin Sawicki
988e2334f5 Merge pull request #7614 from tinydew4/translate-ko
[ko] Apply the changes till the '9367c76' commit.
2016-10-14 09:19:04 -07:00
ali.ibrahim
0e13b8dd01 making the net module usable only after the ready event. 2016-10-14 17:57:37 +02:00
ali.ibrahim
ac9e6eda95 Fixing a crash with pending URLRequests on shutdown. 2016-10-14 17:37:39 +02:00
Samuel Attard
ba91bbd397 Fix spaces 2016-10-14 22:54:04 +11:00
Hein Haraldson Berg
63e1b2fb46 Add a note on Flash permissions to Troubleshooting 2016-10-14 12:51:26 +02:00
ali.ibrahim
c0c9e3ac3d Formatting C++ code using ClangFormat. 2016-10-14 11:51:45 +02:00
ali.ibrahim
4347ce4a53 Formatting C++ code using ClangFormat. 2016-10-14 11:50:47 +02:00
ali.ibrahim
9cc8bfae1c fixing space formatting issues. 2016-10-14 10:58:16 +02:00
tinydew4
741ae488d5 Apply the changes till the '9367c76' commit. 2016-10-14 02:24:27 +00:00
Samuel Attard
10ef6749b3 Source -> DesktopCapturerSource 2016-10-14 13:10:37 +11:00
Samuel Attard
32c3f17f5a Rename dcs object 2016-10-14 13:00:03 +11:00
Samuel Attard
ad45c084cc Fix uploaddata naming 2016-10-14 11:37:36 +11:00
Kevin Sawicki
a13ed2a005 Merge pull request #7610 from LShun/patch-1
Word addition and revision for Readme,md
2016-10-13 14:18:56 -07:00
Kevin Sawicki
9367c764be Merge pull request #7608 from nabeelomer/master
Add further information to online-offline event documentation
2016-10-13 14:17:07 -07:00
Kevin Sawicki
4f57b685bd Add backticks around true/false values 2016-10-13 14:16:37 -07:00
Kevin Sawicki
902a8c57bd Merge pull request #7602 from danburzo/cli_switches_docs
Docs: Command-line switches -- note about node.js flags, added debug flags
2016-10-13 14:13:08 -07:00
Kevin Sawicki
21cfd330c0 Switch from node man to node --help 2016-10-13 14:11:56 -07:00
Long Nhat Nguyen
c017a7a1c7 Update url (#7598)
* Update EventEmitter URL

* Update EventEmitter URL

* Enable click

* Update EventEmitter URL

* Update EventEmitter URL

* Update URL

* Update URL

* Update EventEmitter URL

* Tweak sentence and add perios
2016-10-13 14:09:14 -07:00
Kevin Sawicki
0756aa663b Merge pull request #7587 from electron/update-standard
Update standard to v8 to be inline with standard-markdown
2016-10-13 14:04:24 -07:00
Kevin Sawicki
4ee94917a0 Merge pull request #7576 from tinydew4/translate-ko
Apply the changes of docs on ko-KR
2016-10-13 13:56:39 -07:00
Paul Betts
0df21afcdf Check harder before enabling Accessibility support 2016-10-13 11:46:55 -07:00
ali.ibrahim
de29f2dde5 Fixing build: removing constness on net::HttpResponseHeaders as otherwise we would need a change in libchromiumcontent. 2016-10-13 17:51:19 +02:00
ali.ibrahim
6f5b0a28c5 Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion. 2016-10-13 17:14:23 +02:00
LShun
433a825006 Word addition and revision for Readme,md
I edited some words as well as added some information ( for example the License ) that was missing in the translation but found in the main site README.md,
2016-10-13 22:58:48 +08:00
Nabeel Omer
4f288e3ba2 Update 2016-10-13 20:22:40 +05:30
Nabeel Omer
392b59be4e Made relevant changes 2016-10-13 20:12:44 +05:30
Nabeel Omer
6d8d211631 Update online-offline-events.md 2016-10-13 19:45:39 +05:30
Dan Burzo
af17253a72 Changed link to Node docs in MD reference format 2016-10-13 13:03:29 +03:00
Dan Burzo
cfdea04c83 Added note about sending flags to Node.js, additional debug flags 2016-10-13 12:54:22 +03:00
Samuel Attard
5cf03e68d4 Fix missing type 2016-10-13 17:33:12 +11:00
Samuel Attard
20323e7032 Specifiy function param types in docs 2016-10-13 17:30:57 +11:00
Samuel Attard
78343a62b8 Cleanup docs and standardize structs 2016-10-13 14:38:06 +11:00
Zeke Sikelianos
7584e73d70 Merge pull request #7580 from electron/docs-linter-rectangle-rename
Update docs linter with Rectangle structure fixes
2016-10-12 19:06:44 -07:00
Samuel Attard
eac5ba4c56 Fix spec linting issues 2016-10-13 12:47:43 +11:00
Samuel Attard
a9d5699a52 Update standard to v8 to be inline with standard-markdown 2016-10-13 12:46:00 +11:00
tinydew4
4e08264522 Apply the changes on early Oct 13, 2016 2016-10-13 00:49:20 +00:00
tinydew4
6b39e4a210 Apply the changes about #7379 to ko_KR 2016-10-13 00:34:39 +00:00
tinydew4
4a1c8f6cb7 Apply the changes 2016-10-13 00:33:12 +00:00
tinydew4
468d5f6c7a Apply the changes on Oct 12, 2016 2016-10-13 00:32:05 +00:00
Kevin Sawicki
a8382d6794 Moving atom_bindings include to Windows block 2016-10-12 13:48:49 -07:00
Kevin Sawicki
e899050500 Add basic test of spawned ELECTRON_RUN_AS_NODE process 2016-10-12 13:48:49 -07:00
Kevin Sawicki
b01fd9715b Only expose process.log on Windows 2016-10-12 13:48:48 -07:00
Kevin Sawicki
0417a3e51e Upgrade node for process logging fix patch 2016-10-12 13:48:48 -07:00
Kevin Sawicki
0740b2f66b Reuse Log method 2016-10-12 13:48:48 -07:00
Kevin Sawicki
d686916fe2 Expose process.log when running as node 2016-10-12 13:48:48 -07:00
Kevin Sawicki
fefc7c23f9 Merge pull request #7479 from bpasero/process-no-asar
Introduce ELECTRON_NO_ASAR
2016-10-12 13:48:03 -07:00
Kevin Sawicki
cef7525d00 Merge pull request #7583 from torn4dom4n/master
Update devDependency Status URL
2016-10-12 13:20:16 -07:00
Long Nhat Nguyen
b448b0c796 Update devDependency Status URL
[ci skip]
2016-10-12 20:17:26 +00:00
Kevin Sawicki
a97dc6d17a Merge pull request #7570 from preco21/korean-docs-12
docs: Update Korean docs as upstream and small improves
2016-10-12 13:06:02 -07:00
Kevin Sawicki
fcfc13c1ea Merge pull request #7579 from electron/tweak-about-panel-key-names
Use lower-case about panel option keys
2016-10-12 11:32:01 -07:00
Kevin Sawicki
1e4ef195bb Use lower-case about panel option keys 2016-10-12 11:18:21 -07:00
Kevin Sawicki
566d76def2 Mention spawning with ELECTRON_RUN_AS_NODE 2016-10-12 11:11:27 -07:00
Kevin Sawicki
f553d16539 Only support ELECTRON_NO_ASAR in non browser/renderer processes 2016-10-12 11:11:27 -07:00
Kevin Sawicki
8897a7a926 Add specs for ELECTRON_NO_ASAR env var 2016-10-12 11:11:27 -07:00
Benjamin Pasero
656ee0d9c3 introduce ELECTRON_NO_ASAR 2016-10-12 11:11:27 -07:00
Zeke Sikelianos
ecc03fdd40 update docs linter with Rectangle structure fixes 2016-10-12 11:04:53 -07:00
ali.ibrahim
b290415bbd Fixing build on Mac OS 2016-10-12 19:41:13 +02:00
ali.ibrahim
16069cd477 Commenting some test code. 2016-10-12 17:13:06 +02:00
ali.ibrahim
ae1c33b863 fixing linter issues. 2016-10-12 14:54:32 +02:00
ali.ibrahim
d21def7b8d Fixing various issues in tests. 2016-10-12 14:54:32 +02:00
ali.ibrahim
bd5e622bec Adding request/response piping tests. 2016-10-12 14:54:31 +02:00
ali.ibrahim
a5c508d2d7 Adding abort, webRequest interception and creation tests. 2016-10-12 14:54:31 +02:00
ali.ibrahim
b731ca50bc Adding HTTP request headers manipulation tests. 2016-10-12 14:54:30 +02:00
ali.ibrahim
4eb9fc1bb6 Adding chunked uploading test. 2016-10-12 14:54:29 +02:00
ali.ibrahim
9b94dfcbdc Adding basic http tests, fixing issues in ClientRequest constructor. 2016-10-12 14:54:29 +02:00
Ali Ibrahim
046f48db51 Fixing build on Linux 2016-10-12 14:54:28 +02:00
ali.ibrahim
b57ffbf1ab Temporary fix for the post data test. 2016-10-12 14:54:28 +02:00
ali.ibrahim
42bae9d71d Making the HTTP response a full-fledged Readable stream. 2016-10-12 14:54:27 +02:00
ali.ibrahim
dcffb51e5e Adding net module spec file skeleton. 2016-10-12 14:54:26 +02:00
ali.ibrahim
8c5751e9f7 Adding systematic checks on the atom_request_ pointer as it may be reset to null. 2016-10-12 14:54:26 +02:00
ali.ibrahim
a655cca0a1 Request/Response state simplification. Removing redundant state flags. 2016-10-12 14:54:25 +02:00
ali.ibrahim
e472d11761 Caching response headers so that AtomURLRequest can be freed after the close event. 2016-10-12 14:54:25 +02:00
ali.ibrahim
ec1fc5a17b Implementing error, close, finish, abort events management. 2016-10-12 14:54:24 +02:00
ali.ibrahim
bde30b90e8 Adding some implementation comments. Enforcing Chromium coding conventions. 2016-10-12 14:54:23 +02:00
ali.ibrahim
42adb2afd4 Fixing lint-js issues. 2016-10-12 14:54:22 +02:00
ali.ibrahim
0588435882 Fixing cpplint issues. 2016-10-12 14:54:22 +02:00
ali.ibrahim
08947682b0 Implementing abort workflow, emitting error events. 2016-10-12 14:54:21 +02:00
ali.ibrahim
cbbc4376ca Adding support for upload chunked encoding. 2016-10-12 14:54:20 +02:00
ali.ibrahim
9498a5738a Refactoring net module, adding a ClientRequest and IncomingMessage classes. 2016-10-12 14:54:20 +02:00
ali.ibrahim
fcaf9cb031 Some code cleaning. 2016-10-12 14:54:19 +02:00
ali.ibrahim
f7525d7877 Adding support for POST requests. 2016-10-12 14:54:18 +02:00
ali.ibrahim
2b3b41d5f9 Implementing authentication callback. 2016-10-12 14:54:18 +02:00
ali.ibrahim
2d9d4af98d Implementing URLRequest API, getting response body. 2016-10-12 14:54:17 +02:00
ali.ibrahim
81eab9887b Adding URLResponse to emit response events, implementing status code. 2016-10-12 14:54:16 +02:00
ali.ibrahim
7521aeea09 Implement URLRequest::Delegate, handle thread sync. 2016-10-12 14:54:15 +02:00
ali.ibrahim
e8d4abe78f Adding net module and URLRequest class. 2016-10-12 14:54:15 +02:00
Cheng Zhao
46cd8708a4 Merge pull request #7561 from electron/windows-system-colors
Support retrieving Windows system colors
2016-10-12 15:35:18 +09:00
Zeke Sikelianos
27e1938e9f Merge pull request #7471 from electron/update-standard-markdown
Use standard style JavaScript in all docs translations
2016-10-11 22:37:54 -07:00
Zeke Sikelianos
17198c26d9 update standard-markdown 2016-10-11 22:37:32 -07:00
Zeke Sikelianos
eaeebd3ebd use newer function syntax 2016-10-11 22:37:32 -07:00
Zeke Sikelianos
253a383168 standardize docs-translations by hand 2016-10-11 22:37:32 -07:00
Zeke Sikelianos
3e4a0705e9 standardize docs 2016-10-11 22:37:32 -07:00
Zeke Sikelianos
7ef374477d lint docs-translations with standard-markdown 2016-10-11 22:36:11 -07:00
Zeke Sikelianos
4ae6103356 auto-standardize javascript in docs-translations 2016-10-11 22:36:11 -07:00
Zeke Sikelianos
2e4322c230 update to new standard-markdown with --fix feature 2016-10-11 22:36:11 -07:00
Zeke Sikelianos
6b7e375963 Merge pull request #7379 from electron/seperate-structs
Move reused object structures to a standard structures folder
2016-10-11 22:28:39 -07:00
Zeke Sikelianos
c46c1dbb1e Merge pull request #7505 from electron/testing-docs
Update test dependencies and documentation
2016-10-11 22:28:16 -07:00
Plusb Preco
af79f4793e 📝 Improve grammar
[ci skip]
2016-10-12 12:24:21 +09:00
Plusb Preco
774a15f4c8 📝 Improve grammar
[ci skip]

* Use `formal` tense.
* Small fixes.
2016-10-12 12:24:14 +09:00
Plusb Preco
b7c4cde11a 📝 Adjust line wrap to 80
[ci skip]
2016-10-12 12:13:59 +09:00
Plusb Preco
9857aa25a3 📝 Update Korean docs as upstream
[ci skip]
2016-10-12 12:02:04 +09:00
Zeke Sikelianos
d4a8a64ba7 Merge pull request #7498 from electron/custom-props-in-menu-item-constructor
Preserve custom properties passed to MenuItem constructor
2016-10-11 14:24:13 -07:00
Zeke Sikelianos
af0098f064 remove badge count after each setBadgeCount test 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
37c53f2e09 clarify mocha test exclusion 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
a8e59ccd3d fix links to testing docs 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
57852366bb mention building before testing 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
a4832c304e unify testing docs for all platforms 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
156d823b7f remove badge after setBadgeCount test finishes 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
45d9cc6405 update test dependencies 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
0aeb53435e add tips for testing 2016-10-11 14:22:48 -07:00
Paul Betts
7dd1ebc734 Fix oops typos 2016-10-11 14:02:29 -07:00
Kevin Sawicki
ce694760bc Remove const since SkColor is an int 2016-10-11 13:15:27 -07:00
Kevin Sawicki
c8189046fe Emit color-changed event on Windows 2016-10-11 13:15:27 -07:00
Kevin Sawicki
2656812dea Doc systemPreferences.getColor 2016-10-11 13:15:27 -07:00
Kevin Sawicki
1978b39337 Remove duplicate colors 2016-10-11 13:15:27 -07:00
Kevin Sawicki
e7bfd1c959 Add systemPreferences.getColor specs 2016-10-11 13:15:26 -07:00
Kevin Sawicki
663f8f4b54 Add systemPreferences.getColor on Windows 2016-10-11 13:15:26 -07:00
Kevin Sawicki
9b0a32f62c Add ToRGBHex color helper 2016-10-11 13:15:26 -07:00
Paul Betts
06065d1c5d Instead of gating the path shortening to MAS_BUILD, figure it out at runtime 2016-10-11 13:06:29 -07:00
Paul Betts
e84ae6e2aa Add a method to determine whether we're in the Apple sandbox 2016-10-11 13:06:29 -07:00
Kevin Sawicki
13f9a6c273 Merge pull request #7563 from rogerlista/master
📝 Translation of security.md to pt-BR [ci skip]
2016-10-11 10:06:02 -07:00
Rogério
d89b23c120 📝 Translation of security.md to pt-BR [ci skip] 2016-10-11 14:01:07 -03:00
Kevin Sawicki
479451e7c7 Merge pull request #7562 from odedhb/patch-1
Update mac-app-store-submission-guide.md
2016-10-11 10:00:56 -07:00
Oded Breiner
ea8a4f2b51 Update mac-app-store-submission-guide.md 2016-10-11 19:58:53 +03:00
Kevin Sawicki
e26189ba87 Merge pull request #7560 from electron/upgrade-brigthray
Upgrade brightray for devtools dock state preference fix
2016-10-11 09:48:39 -07:00
Kevin Sawicki
003522d6f7 Merge pull request #7558 from danburzo/build_instructions
Adds link to PyObjC installation instructions
2016-10-11 09:48:20 -07:00
Kevin Sawicki
4db6ccd579 Merge pull request #7555 from tinydew4/translate-ko
Apply the changes of docs to ko-KR
2016-10-11 09:47:51 -07:00
Kevin Sawicki
39aa740c88 Merge pull request #7552 from electron/fix-menu-docs
fix Menu API example
2016-10-11 09:47:30 -07:00
Kevin Sawicki
66f825beb1 Upgrade brightray for devtools dock state preference fix 2016-10-11 08:45:42 -07:00
Dan Burzo
75feeca0f0 Small fix to grammar in Build instructions (macOS) 2016-10-11 17:41:28 +03:00
Dan Burzo
120aa1c9ce Adds link to PyObjC installation instructions 2016-10-11 17:34:35 +03:00
tinydew4
7fa2ffc2a7 Apply the changes on Oct 11, 2016 2016-10-11 12:25:34 +00:00
tinydew4
15fae91ac7 Apply changes about crash-reporter 2016-10-11 12:06:32 +00:00
Cheng Zhao
4ae190dab9 Merge pull request #7549 from electron/about-panel-options
Support setting about panel options
2016-10-11 20:18:23 +09:00
Cheng Zhao
0baa60caab Merge pull request #7528 from electron/key-and-code-on-sent-input-events
Set key and code on sendInputEvent keyboard events
2016-10-11 19:34:05 +09:00
Cheng Zhao
2a3bcdcaab Merge pull request #7518 from electron/inverted-color-scheme
Support detecting inverted color scheme on Windows
2016-10-11 19:31:34 +09:00
Zeke Sikelianos
619f74fa12 fix Menu example 2016-10-10 23:01:35 -07:00
Zeke Sikelianos
8aaf029e55 remove unused var 2016-10-10 15:38:27 -07:00
Zeke Sikelianos
bcce7aff18 test that overrideProperty is not overwritten 2016-10-10 15:25:56 -07:00
Zeke Sikelianos
b575055d7e inherit user-specific MenuItem properties more safely 2016-10-10 14:40:49 -07:00
Kevin Sawicki
d5b3ef5380 Merge pull request #7548 from malept/electron-packager-mas-doc-fix
Docs: clarify ignoring object files with electron-packager
2016-10-10 13:50:41 -07:00
Kevin Sawicki
58ef0bea17 Doc app.setAboutPanelOptions 2016-10-10 13:40:57 -07:00
Kevin Sawicki
7de6a06acf Support setting about panel options 2016-10-10 13:30:58 -07:00
Zeke Sikelianos
2cd10d339f remove duplicated prop copying 2016-10-10 11:07:01 -07:00
Kevin Sawicki
38281f3364 Implement SysColorChangeListener directly on Windows 2016-10-10 10:43:09 -07:00
Kevin Sawicki
25bcc2dd0d 🎨 2016-10-10 10:43:09 -07:00
Kevin Sawicki
af27c62b07 Doc inverted-color-scheme-changed event 2016-10-10 10:43:08 -07:00
Kevin Sawicki
8b16b82ce9 Add inverted-color-scheme-changed event 2016-10-10 10:43:08 -07:00
Kevin Sawicki
223e9d97a0 Doc systemPreferences.isInvertedColorScheme 2016-10-10 10:43:08 -07:00
Kevin Sawicki
7b49d94e9f Add systemPreferences.isInvertedColorScheme API 2016-10-10 10:43:08 -07:00
Mark Lee
a677eb0f95 📝 clarify ignoring object files with electron-packager
Note that Electron Packager 8.1.0 ignores object files by default.
2016-10-10 13:08:36 -04:00
Kevin Sawicki
987579d391 Send initial keyDown before char event 2016-10-10 09:35:44 -07:00
Kevin Sawicki
99414065a9 Add char/keypress event tests 2016-10-10 09:35:44 -07:00
Kevin Sawicki
e4b0577cb0 Assert key and code in keyup input event spec 2016-10-10 09:35:44 -07:00
Kevin Sawicki
424afd3faf Update expected key and code values 2016-10-10 09:35:43 -07:00
Kevin Sawicki
6fac14ad3f Set key and code on keyboard events 2016-10-10 09:35:43 -07:00
Kevin Sawicki
d69367aa9b Add keydown sendInputEvent specs 2016-10-10 09:35:43 -07:00
Kevin Sawicki
2efb7a12cb Merge pull request #7544 from tinydew4/fix-docs
Fix dot
2016-10-10 09:19:13 -07:00
Kevin Sawicki
9f616b934b Merge pull request #7542 from Menq/patch-1
update
2016-10-10 09:18:41 -07:00
Kevin Sawicki
c016e83eb3 Merge pull request #7541 from tinydew4/translate-ko
Translate clang-format
2016-10-10 09:18:23 -07:00
Kevin Sawicki
7015dbf0d2 Merge pull request #7536 from rogerlista/master
📝 Translation of faq.md to pt-BR [ci skip]
2016-10-10 09:18:02 -07:00
tinydew4
9f42c4c441 Fix dot 2016-10-10 14:31:05 +00:00
孟强
1841f826fe update
rename electron-prebuild to electron
2016-10-10 17:08:26 +08:00
Cheng Zhao
e24267d060 Update brightray for #7503 2016-10-10 11:35:59 +09:00
Cheng Zhao
91591f37e6 Merge pull request #7500 from electron/store-crashes-in-configured-temp-dir
Store crash reports in configured temp dir
2016-10-10 10:19:02 +09:00
tinydew4
8875296338 Translate clang-format.md 2016-10-10 00:53:13 +00:00
Rogério
98eb8cd3c1 📝 Translation of faq.md to pt-BR [ci skip] 2016-10-09 10:56:55 -03:00
Zeke Sikelianos
2acd7f4d12 fix NativeImage link path 2016-10-07 21:25:39 -07:00
Samuel Attard
4d49156dac Rename bounds -> rectangle 2016-10-08 13:09:31 +11:00
Kevin Sawicki
c147e72c8e Merge pull request #7499 from electron/clang-format
Add a guide to use clang-format
2016-10-07 14:06:18 -07:00
Kevin Sawicki
f872799f5c Minor edits to clang-format guide 2016-10-07 14:05:33 -07:00
Kevin Sawicki
913bc8e198 Merge pull request #7527 from electron/only-set-global-app-name-on-audio-manager-on-linux
Only call media::AudioManager::SetGlobalAppName on Linux
2016-10-07 14:04:03 -07:00
Kevin Sawicki
c37740273f Add linux guard for SetGlobalAppName call 2016-10-07 13:44:54 -07:00
Kevin Sawicki
f09ed4b677 Merge pull request #7524 from deepak1556/pa_app_name_patch
media: set the application name for audio streams shown in external apps
2016-10-07 10:15:35 -07:00
Kevin Sawicki
e52f5933a0 Merge pull request #7522 from tinydew4/translate-ko
Add REPL doc in ko-KR and apply other changes
2016-10-07 10:11:24 -07:00
Kevin Sawicki
9339853448 Merge pull request #7520 from electron/fix-undef-webprefs
Default webPreferences to empty object always
2016-10-07 10:10:40 -07:00
deepak1556
12fb9f1f18 media: set the application name for audio streams shown in external apps 2016-10-07 16:15:30 +05:30
tinydew4
f3b182606b Add REPL doc in ko-KR and apply other changes 2016-10-07 08:34:27 +00:00
Samuel Attard
a0284a9bc5 Add spec for window.open with webPreferences set to null 2016-10-07 12:13:04 +11:00
Samuel Attard
09e5035ab5 Default webPreferences to empty object always 2016-10-07 11:45:13 +11:00
Zeke Sikelianos
b7e078e98d sanitize MenuItem options 2016-10-06 14:37:13 -07:00
Zeke Sikelianos
f80e81bf9f standardize 2016-10-06 12:20:00 -07:00
Zeke Sikelianos
c34d868609 update docs-linter 2016-10-06 12:20:00 -07:00
Samuel Attard
2b05c61ae3 Update docs for parsing 2016-10-06 12:19:38 -07:00
Samuel Attard
b859afc118 Update docs to follow the 'link first instance' standard 2016-10-06 12:19:38 -07:00
Samuel Attard
03979936f3 Move reused object structures to a standard structures folder 2016-10-06 11:59:42 -07:00
Kevin Sawicki
4d7050553c Merge pull request #7449 from amtj/repl-docs
add REPL documentation
2016-10-06 11:38:48 -07:00
Kevin Sawicki
c104858079 Update Node.js docs link and Windows note 2016-10-06 11:38:09 -07:00
Kevin Sawicki
2c8781ed69 Merge pull request #7511 from tinydew4/translate-ko
Update korean docs
2016-10-06 11:12:26 -07:00
Kevin Sawicki
e38fc724f8 Merge pull request #7508 from miniak/docs-fix
Add missing documentation
2016-10-06 11:11:31 -07:00
Kevin Sawicki
3bbfc4d420 Merge pull request #7507 from toonborgers/translate-nl
Add link to dutch translation in CONTRIBUTING.md [ci skip]
2016-10-06 11:06:18 -07:00
Kevin Sawicki
217010a669 Merge pull request #7515 from electron/newline-before-list
Add newline before list
2016-10-06 11:03:52 -07:00
Kevin Sawicki
451cea4675 Add newline before list 2016-10-06 11:02:30 -07:00
Kevin Sawicki
d39182b41a Pass crashes directory instead of product name and temp dir 2016-10-06 10:55:11 -07:00
Zeke Sikelianos
2cda2bd718 Merge pull request #7502 from squarejaw/patch-1
Fix misspelling in docs/api/app.md
2016-10-06 10:44:11 -07:00
Kevin Sawicki
16e3991ffa Guard against app.getPath throwing with OS fallback 2016-10-06 10:07:40 -07:00
Kevin Sawicki
fbbffe03a5 Add getPath specs 2016-10-06 09:57:25 -07:00
Kevin Sawicki
f61ace74bb Sort includes 2016-10-06 09:50:06 -07:00
Kevin Sawicki
4a8dcec63a Wait for crash report to become available 2016-10-06 09:47:07 -07:00
Kevin Sawicki
30c6ca6751 Only call UTF8ToUTF16 on Windows 2016-10-06 09:14:16 -07:00
Kevin Sawicki
84b7bb29f0 Fix Windows compiler errors 2016-10-06 09:02:03 -07:00
Kevin Sawicki
9d1d1f21e9 Use FilePath for crash reporter temp directory 2016-10-06 09:02:03 -07:00
Kevin Sawicki
883c4b63d0 temp_path -> temp_dir 2016-10-06 09:02:02 -07:00
Kevin Sawicki
0380d3ae50 Pass crashes directory to crash service process 2016-10-06 09:02:02 -07:00
Kevin Sawicki
2fbb98a97c Remove directory assert 2016-10-06 09:02:02 -07:00
Kevin Sawicki
43702e0f8e Support calling getUploadedReports on unstarted crash reporter 2016-10-06 09:02:02 -07:00
Kevin Sawicki
56d9ce34e4 Use valid Linux report id 2016-10-06 09:02:02 -07:00
Kevin Sawicki
76abb2e18d Add missing temp_dir arg to override 2016-10-06 09:02:02 -07:00
Kevin Sawicki
a0db484510 Use app.getPath directly for temp path 2016-10-06 09:02:02 -07:00
Kevin Sawicki
b3b856f476 Set productName in main process on Linux 2016-10-06 09:02:02 -07:00
Kevin Sawicki
69a7025c96 Fix Linux compiler errors 2016-10-06 09:02:01 -07:00
Kevin Sawicki
773bfea386 Remove unused rimraf spec dependency 2016-10-06 09:02:01 -07:00
Kevin Sawicki
eafc694bba Mention crash report locations 2016-10-06 09:02:01 -07:00
Kevin Sawicki
81733a523e DRY up temp directory logging 2016-10-06 09:02:01 -07:00
Kevin Sawicki
1afe501a36 Add tests for crash reports in custom temp directory 2016-10-06 09:02:01 -07:00
Kevin Sawicki
f282b51c98 🎨 Use ES6 class, destructuring, and let/const 2016-10-06 09:02:01 -07:00
Kevin Sawicki
ac0658bbf1 Use PathService for temp dir path for crashes 2016-10-06 09:02:01 -07:00
tinydew4
116dbc0581 Update ko docs 2016-10-06 14:53:57 +00:00
tinydew4
6af8a0fae4 Update ko docs 2016-10-06 14:27:48 +00:00
tinydew4
79b5ae3d57 Modify docs to refelect the latest 2016-10-06 14:27:48 +00:00
Milan Burda
cb15181f43 Fix typo 2016-10-06 12:03:37 +02:00
Milan Burda
9f342ebbd1 Add missing documentation 2016-10-06 11:30:34 +02:00
Toon Borgers
27795015ff Add link to dutch translation in CONTRIBUTING.md 2016-10-06 10:56:59 +02:00
Cheng Zhao
79a5de3fd8 Bump v1.4.3 2016-10-06 17:12:07 +09:00
Cheng Zhao
2624738534 Lock the version of electron-docs-linter 2016-10-06 17:12:06 +09:00
Cheng Zhao
10b91b1291 Merge pull request #7488 from electron/native-image-resize-and-crop
Support resizing and cropping native images
2016-10-06 15:01:41 +09:00
Cheng Zhao
1781ceb25b Merge pull request #7494 from thomsonreuters/Update_Test_For_Missing_Additional_Features
Update BrowserWindow's test to check additional features upon window.open() call
2016-10-06 14:45:28 +09:00
Cheng Zhao
051e5c27b3 Update brightray for #7332 2016-10-06 14:42:14 +09:00
Cheng Zhao
5285b729be Merge pull request #7407 from thomsonreuters/New_Window_Handler_Can_Create_And_Return_Window
New-window event handler can return its own BrowserWindow instance
2016-10-06 14:37:48 +09:00
Bryan Bess
9bc6000cb5 📝 Fix misspelling in docs/api/app.md [ci skip] 2016-10-05 19:17:49 -05:00
Zeke Sikelianos
fdf3f6ce30 remove unneeded new keyword 2016-10-05 13:44:28 -07:00
Haojian Wu
0d930b65f1 📝 clang-format on Electron C++ code. 2016-10-05 22:12:48 +02:00
Zeke Sikelianos
16b3962b66 preserve custom properties passed to MenuItem constructor 2016-10-05 12:24:08 -07:00
Kevin Sawicki
4b95f3a462 Mark width/height as optional 2016-10-05 11:02:58 -07:00
Kevin Sawicki
4ffae1d563 Add spec for getAspectRatio 2016-10-05 11:02:58 -07:00
Kevin Sawicki
abffd98e29 Resize images with preserve aspect ratio 2016-10-05 11:02:58 -07:00
Kevin Sawicki
56f9cc683a bounds -> rect 2016-10-05 11:02:57 -07:00
Kevin Sawicki
49cc00dedf Add tests of resizing/cropping an empty image 2016-10-05 11:02:57 -07:00
Kevin Sawicki
9fa13710aa Document crop and resize 2016-10-05 11:02:57 -07:00
Kevin Sawicki
0eda33f057 Add tests for cropping native images 2016-10-05 11:02:57 -07:00
Kevin Sawicki
2b4fff70d5 Add initial crop method 2016-10-05 11:02:57 -07:00
Kevin Sawicki
a80f4c1605 Add specs for other create image helpers 2016-10-05 11:02:57 -07:00
Kevin Sawicki
6aba4e916a 🎨 Use deepEqual asserts 2016-10-05 11:02:57 -07:00
Kevin Sawicki
6a7f0d70fd Add native image resize tests 2016-10-05 11:02:56 -07:00
Kevin Sawicki
042684fb38 Add resize method to native image 2016-10-05 11:02:56 -07:00
Kevin Sawicki
018575de71 Merge pull request #7496 from electron/app-doc-fix
Add newline before return list
2016-10-05 09:36:01 -07:00
Kevin Sawicki
8c0588d4e0 Merge pull request #7495 from toonborgers/translate-nl
📝 Dutch translation for CONTRIBUTING.md [ci skip]
2016-10-05 09:34:08 -07:00
Kevin Sawicki
aaa8c56686 Merge pull request #7487 from fplucas/master
📝 Fix the link source-code-directory-structure.md on pt-br [ci skip]
2016-10-05 09:33:07 -07:00
Kevin Sawicki
5e936a24ac Add newline before list 2016-10-05 09:24:33 -07:00
Michael Vasseur
edd80d88a9 Update BrowserWindow's test to check additional features upon window.open() call 2016-10-05 13:45:15 +02:00
Toon Borgers
25659e482e Fix relative url 2016-10-05 12:28:36 +02:00
Toon Borgers
a097d17166 Fix relative link, added translation link for dutch 2016-10-05 12:28:08 +02:00
Toon Borgers
d4bbc24031 Translate CONTRIBUTING.md 2016-10-05 12:25:50 +02:00
Michael Vasseur
3dd41bc09a Fix errors 2016-10-05 11:46:55 +02:00
Michael Vasseur
9490ec7686 Fix JS Lint issues 2016-10-05 09:47:39 +02:00
Michael Vasseur
a2b3cf95a7 Sets correct openerId in mergeBrowserWindowOptions() to give correct options to 'new-window' event handler 2016-10-05 09:47:39 +02:00
Michael Vasseur
cc7f4fedf6 Rebase with recent changes 2016-10-05 09:47:39 +02:00
Michael Vasseur
22bd7c0271 Updated the related documentation 2016-10-05 09:47:38 +02:00
Michael Vasseur
3408c8038e Fix indentation 2016-10-05 09:47:38 +02:00
Michael Vasseur
5a4cdcfde1 'new-window' event handlers can return their window when default behavior is prevented 2016-10-05 09:46:54 +02:00
Toon Borgers
0babe4a5ed Add english version to start from 2016-10-05 09:27:20 +02:00
Toon Borgers
a538b37854 Create CONTRIBUTING.md 2016-10-05 09:16:34 +02:00
Cheng Zhao
ebaeec1677 Merge pull request #7491 from electron/initialize-direct-write-font-proxy
Enable emoji as fallback font on Windows 10
2016-10-05 14:15:55 +09:00
Kevin Sawicki
1f1d9cefca Update libchromiumcontent for #7334 2016-10-04 17:28:46 -07:00
Haojian Wu
a846088eac Add clang-format config file. 2016-10-04 22:42:49 +02:00
Kevin Sawicki
43f4eb76c4 Merge pull request #7489 from davej/patch-2
Docs: Correct image.getSize() type signature
2016-10-04 13:36:48 -07:00
Dave Jeffery
29b9fbcc9a Docs: Move buffer link to end of file 2016-10-04 21:34:24 +01:00
Dave Jeffery
4d10b9a31b Docs: Correct image.getSize() type signature 2016-10-04 21:20:42 +01:00
Lucas Pugliesi
0727102c5e 📝 Fix the link source-code-directory-structure.md on pt-br [ci skip] 2016-10-04 14:43:11 -03:00
Kevin Sawicki
4c2590ed92 Merge pull request #7486 from fplucas/master
📝 Translation of build-instructions-osx.md to pt-br [ci skip]
2016-10-04 10:31:08 -07:00
Lucas Pugliesi
66ce176b22 Merge remote-tracking branch 'upstream/master' 2016-10-04 14:27:00 -03:00
Lucas Pugliesi
a824ff479a 📝 Translation of build-instructions-osx.md to pt-br [ci skip] 2016-10-04 14:26:41 -03:00
Kevin Sawicki
c88c6b1323 Merge pull request #7481 from fplucas/master
📝 Translation of synopsis.md to pt-br [ci skip]
2016-10-04 09:11:16 -07:00
Kevin Sawicki
b459f00bd3 Merge pull request #7478 from tinydew4/translate-ko
Update the ko-KR docs related to the `additionalFeatures`.
2016-10-04 09:10:55 -07:00
Amitoj
00376c1d59 add note about windows
note "REPL is not available on Windows."
2016-10-04 19:32:46 +05:30
Lucas Pugliesi
85a8b149bb 📝 Translation of synopsis.md to pt-br [ci skip] 2016-10-04 09:37:18 -03:00
tinydew4
3fcb57559a Update the ko-KR docs related to the . 2016-10-04 08:35:07 +00:00
Cheng Zhao
bf21892cfa Merge pull request #7291 from thomsonreuters/Fix_Missing_Additional_Features_New_Popup_Windows
Fix for missing additional features fields when creating new popup windows
2016-10-04 15:42:36 +09:00
Cheng Zhao
c4576463e2 Format the docs according to style guide 2016-10-04 14:41:37 +09:00
Michael Vasseur
3af686daff Documented JavasScript API changes related to the fix for additional features processing 2016-10-04 14:38:32 +09:00
Michael Vasseur
c811188e22 Updated required code to handle missing additional features for popup windows 2016-10-04 14:38:32 +09:00
Cheng Zhao
ef88a06f08 Update libchromiumcontent for #7291 2016-10-04 14:30:59 +09:00
Cheng Zhao
cf050ff9e2 Merge pull request #7468 from electron/focus-window-when-menu-is-clicked
Focus window when menu button is pressed
2016-10-04 14:22:49 +09:00
Kevin Sawicki
bb04069e83 Merge pull request #7437 from fplucas/master
📝 Translation of CONTRIBUTING.md to pt-br [ci skip]
2016-10-03 15:37:52 -07:00
Amitoj
a938859eb8 repl-docs: move file to tutorials
also add note for renderer processes.
2016-10-04 00:12:25 +05:30
Lucas Pugliesi
8d35576a36 Merge CONTRIBUTING.md 2016-10-03 15:18:03 -03:00
Kevin Sawicki
9cae04edde Remove unused ButtonListener 2016-10-03 10:26:18 -07:00
Kevin Sawicki
11684c2c73 Focus submenu buttons when clicked 2016-10-03 10:13:41 -07:00
Kevin Sawicki
e258973490 Merge pull request #7434 from rafaelstz/patch-2
Update year in LICENSE file
2016-10-03 09:29:54 -07:00
Kevin Sawicki
00d57fa547 Merge pull request #7433 from rafaelstz/patch-1
Update license in README file
2016-10-03 09:29:26 -07:00
Kevin Sawicki
24106469c5 Merge pull request #7456 from amitmerchant1990/patch-1
Update accessibility.md
2016-10-03 09:28:22 -07:00
Kevin Sawicki
9c55280917 Merge pull request #7457 from josephfrazier/fix-findinpage-links
Fix webContents.findInPage links in docs
2016-10-03 09:22:53 -07:00
Cheng Zhao
98333049ec Merge pull request #7452 from enlight/node-buffer-safe-free
Prevent undefined behavior when some Node Buffer objects are destroyed
2016-10-03 21:57:37 +09:00
Cheng Zhao
63b45a873b Merge pull request #7451 from was4444/master
keep up with en version
2016-10-03 21:35:06 +09:00
Cheng Zhao
ec34bfde26 Merge pull request #7432 from electron/check-if-window-closed
Ignore already closed windows
2016-10-03 21:21:35 +09:00
Cheng Zhao
8ae91ea2ee Merge pull request #7444 from rogerlista/master
📝 Translation of CODE OF CONDUCT.md to pt-BR [ci skip]
2016-10-03 21:19:35 +09:00
Cheng Zhao
772c456513 Merge pull request #7335 from miniak/set-default-error-mode
Add process.setDefaultErrorMode()
2016-10-03 20:53:42 +09:00
Cheng Zhao
3a4cd19226 Merge pull request #7461 from electron/revert-7416-fix-windows-draggable-high-dpi
Revert "Fix for issues seen on frameless window (Windows) when at 200% resolution"
2016-10-03 20:42:44 +09:00
Cheng Zhao
4d8c1c61a5 Revert "Fix for issues seen on frameless window (Windows) when at 200% resolution" 2016-10-03 20:41:52 +09:00
Cheng Zhao
bee3abe334 Merge pull request #7416 from bsclifton/fix-windows-draggable-high-dpi
Fix for issues seen on frameless window (Windows) when at 200% resolution
2016-10-03 18:34:18 +09:00
Joseph Frazier
5d1c626a53 Fix webContents.findInPage links in docs 2016-10-03 02:07:52 -04:00
Amit Merchant
fb612075c4 Update accessibility.md 2016-10-03 11:13:25 +05:30
Vadim Macagon
7c5d3296e7 Prevent undefined behavior when some Node Buffer objects are destroyed
If node::Buffer::New() is used to wrap an existing chunk of memory
without providing a custom callback to release that memory then Node
will just use `free()`. In a couple of places Node buffer objects were
constructed from chunks of memory that were allocated with `new[]`, but
a custom callback to release that memory was omitted, this resulted in
undefined behavior when those buffers were destroyed because `free()`
was used to release memory allocated with `new[]`.

To avoid undefined behavior the aforementioned buffer objects are now
constructed with a custom callback that safely releases the underlying
chunk of memory.
2016-10-03 10:26:26 +07:00
Amitoj
002b9b5d4b add link to repl documentation 2016-10-02 23:47:11 +05:30
Amitoj
a0a23e04cf s/provides/provides a/ 2016-10-02 23:42:37 +05:30
wxf
763fdb4be1 keep up with en version 2016-10-02 21:45:22 +08:00
Amitoj
4d0cef5070 add REPL documentation 2016-10-02 18:20:29 +05:30
Rogério
18c7ba94f8 📝 Translation of accessibility.md to pt-BR [ci skip] 2016-10-01 21:28:17 -03:00
Rogério
5fb72b5e05 📝 Translation of README.md to pt-BR [ci_skip] 2016-10-01 20:55:12 -03:00
Rogério
960971b195 📝 Translation of CONTRIBUTING.md to pt-BR[ci skip] 2016-10-01 19:56:01 -03:00
Rogério
b10a6422d4 Translation of CODE OF CONDUCT.md to pt-BR [ci skip] 2016-10-01 17:59:30 -03:00
Lucas Pugliesi
2714f280f5 📝 Translation of file-object.md to pt-br [ci skip] 2016-10-01 09:07:49 -03:00
Lucas Pugliesi
9c53d241fa 📝 Translation of CONTRIBUTING.md to pt-br [ci skip] 2016-10-01 08:45:31 -03:00
Rafael Corrêa Gomes
f4d33e366d Update year in LICENSE file 2016-10-01 00:34:29 -03:00
Rafael Corrêa Gomes
73cdf35c98 Update license in README file 2016-10-01 00:33:51 -03:00
Kevin Sawicki
140651c258 Ignore already closed windows 2016-09-30 15:04:13 -07:00
Kevin Sawicki
ff6a8fac2a Merge pull request #7417 from electron/check-sheet-parent-before-beginning
Only begin sheet when no sheet parent
2016-09-30 13:08:35 -07:00
Kevin Sawicki
1807458c66 Only begin sheet when no sheet parent 2016-09-30 10:43:43 -07:00
Kevin Sawicki
fb41474555 Merge pull request #7429 from electron/webview-max-listeners
Ensure webviews get reset after spec finishes
2016-09-30 10:43:27 -07:00
Kevin Sawicki
3f390c6849 Ensure webviews get reset after spec finishes 2016-09-30 10:15:11 -07:00
Kevin Sawicki
4a186069d9 Merge pull request #7428 from electron/sandbox-specs
Explicitly close popup window from sandbox spec
2016-09-30 09:28:59 -07:00
Kevin Sawicki
d942694695 openedWindow -> popupWindow 2016-09-30 08:54:24 -07:00
Kevin Sawicki
766f5afabd Explicitly close popup window 2016-09-30 08:50:41 -07:00
Kevin Sawicki
e16fa08e61 🎨 2016-09-30 08:38:21 -07:00
Kevin Sawicki
b07d4eba11 Merge pull request #7427 from tinydew4/translate-ko
Update ko-KR/api/session.md
2016-09-30 08:14:46 -07:00
tinydew4
f1d1070baa Update ko-KR/api/session.md 2016-09-30 15:09:11 +00:00
Kevin Sawicki
0c146de7dd Merge pull request #7422 from tinydew4/translate-ko
Update korean CODE_OF_CONDUCT.md
2016-09-30 07:56:07 -07:00
Cheng Zhao
5a56de501a Bump v1.4.2 2016-09-30 17:39:27 +08:00
Cheng Zhao
11d16a7342 Merge pull request #7415 from electron/disable-tab-menu-on-sierra
Hide Show Tab Bar menu item on macOS Sierra
2016-09-30 17:23:54 +08:00
Cheng Zhao
1b5db42ec6 Merge pull request #7398 from electron/cookie-changed-event
Add cookie changed event
2016-09-30 17:10:44 +08:00
tinydew4
0b6b4ca50d Update CODE_OF_CONDUCT.md 2016-09-30 06:32:07 +00:00
tinydew4
e7e8b3fdb6 Remove BOM to korean docs 2016-09-30 00:03:29 +00:00
Milan Burda
5bfa898a02 Always drop SEM_NOGPFAULTERRORBOX flag from error mode (enables WER if crashReporter is not started) 2016-09-29 13:57:41 -07:00
Kevin Sawicki
770a3509cf Add forward declaration of NSWindow.allowsAutomaticWindowTabbing 2016-09-29 10:54:59 -07:00
Kevin Sawicki
b14870d9a1 Merge pull request #7413 from deepak1556/devtools_filesystemapi_patch
browser: allow filesystem access for devtools scheme
2016-09-29 10:52:47 -07:00
Brian Clifton
52340b43f5 Possible fix for issues seen on frameless window (Windows) when at 200% 2016-09-29 10:48:36 -07:00
deepak1556
1323542373 browser: allow filesystem access for devtools scheme 2016-09-29 22:54:39 +05:30
Kevin Sawicki
24b9313958 Disable Show Tab Bar menu item on macOS Sierrra 2016-09-29 10:18:15 -07:00
Kevin Sawicki
0e1290fc10 Upgrade brightray for merged cookie delegate support 2016-09-29 09:18:21 -07:00
Kevin Sawicki
8abe8fe01d Remove unneeded locker and handle scope 2016-09-29 09:16:35 -07:00
Kevin Sawicki
77b35ba7ab Use separate session for cookies change event test 2016-09-29 09:16:35 -07:00
Kevin Sawicki
96e48ac13c Document cookie changed event 2016-09-29 09:16:35 -07:00
Kevin Sawicki
d83534d513 Add specs for cookie changed event 2016-09-29 09:16:35 -07:00
Kevin Sawicki
19c7ee0932 Use scoped_refptr for cookie delegate 2016-09-29 09:16:35 -07:00
Kevin Sawicki
24bcf6ac16 Add initial cookie changed event support 2016-09-29 09:16:29 -07:00
Kevin Sawicki
5d23d165a9 Upgrade brigthray for cookie monster delegate 2016-09-29 09:16:29 -07:00
Kevin Sawicki
b3b9994ce8 Configure ink drops on menu bar buttons (#7397)
* Add ink drop to menu bar buttons

* Pass background color to submenu button

* Sort includes
2016-09-29 09:15:12 -07:00
Arus
df0bda058f Update korean docs, according to most recent changes and other missing. (#7400)
* Apply changes

* Apply changes

* Apply changes

* Apply changes

* Fix all JS standard syntax errors

* Apply of recent changes, #7374
2016-09-29 08:52:40 -07:00
Cheng Zhao
15b8449411 Merge pull request #7393 from electron/upgrade-brigthray-for-ct-fix
Upgrade Brightray for certificate transparency crash fix
2016-09-29 16:56:31 +08:00
Cheng Zhao
e1d68fa3cd Merge pull request #7374 from electron/fixup-return-values
Update docs to contain more specific return values
2016-09-29 16:44:08 +08:00
Cheng Zhao
2c9ce3f3e0 Merge pull request #7372 from electron/update-docs-linter
update electron-docs-linter
2016-09-29 16:43:22 +08:00
Cheng Zhao
734f42b5f9 Merge pull request #7319 from Menci/master
Workaround for electron/electron#5050
2016-09-29 16:42:30 +08:00
Kevin Sawicki
3cff64001d Upgrade brightray for CT crash fix 2016-09-28 16:02:48 -07:00
Kevin Sawicki
241297fb2e Merge pull request #7388 from electron/custom-window-level-test
Add test for BrowserWindow.setAlwaysOnTop
2016-09-28 15:47:29 -07:00
Kevin Sawicki
d4583006b3 Merge pull request #7391 from kiavashps/patch-1
docs: app.md - fix relaunch arg concat syntax
2016-09-28 10:30:59 -07:00
Kiavash Page
d42e51e33a app.md - fix relaunch arg concat syntax 2016-09-28 10:23:03 -07:00
Kevin Sawicki
3bed19d70d Add spec for BrowserWindow.setAlwaysOnTop 2016-09-28 09:23:52 -07:00
Kevin Sawicki
fd6ef6712f Link to window level macOS docs 2016-09-28 09:20:22 -07:00
Cheng Zhao
c51982a231 Merge pull request #7362 from bsclifton/fix-windows-draggable-high-dpi
Fixes mouse coordinates for Windows when display is set to a higher DPI
2016-09-28 19:42:17 +08:00
Cheng Zhao
53d4c36332 Merge pull request #7353 from electron/no-login-item-apis-on-mas
document lack of MAS support for login item APIs
2016-09-28 19:20:32 +08:00
Cheng Zhao
de76bf5f63 Merge pull request #7296 from adammeyer/custom-window-level
Allow custom window level when sending window to top
2016-09-28 19:18:12 +08:00
Samuel Attard
e0e47ea9a1 Update docs to contain more specific return values 2016-09-28 18:28:44 +13:00
Zeke Sikelianos
3989139378 update electron-docs-linter 2016-09-27 22:04:22 -07:00
Menci
ca68dfe097 🎨 Remove extra semicolon 2016-09-28 06:45:15 +08:00
Kevin Sawicki
5114d571df Merge pull request #7364 from tiagotol/patch-1
Update quick-start.md
2016-09-27 13:02:25 -07:00
tiagotol
08808664b6 Update quick-start.md 2016-09-27 14:29:35 -03:00
Brian Clifton
13de65d310 Fixes mouse coordinates for Windows when display is set to a higher DPI (ex: enlarged by 150% using display settings) 2016-09-27 08:23:48 -07:00
Zeke Sikelianos
6728efe87e Merge pull request #7339 from electron/document-return-values
Document the return values of all methods in the docs
2016-09-27 07:39:25 -07:00
Cheng Zhao
458c4dd129 Merge branch 'support-chromium-sandbox' of https://github.com/tarruda/electron into tarruda-support-chromium-sandbox 2016-09-27 20:02:23 +08:00
Menci
ef45b67dbf 🐧 🐛 Move the workaround to lib/browser/init.js 2016-09-27 19:19:52 +08:00
Cheng Zhao
604700187d Merge pull request #7327 from MaxWhere/osr-fixes
Small fixes for offscreen rendering
2016-09-27 19:17:10 +08:00
Cheng Zhao
7e1ae369ed Merge pull request #7356 from electron/fix-typo
fix typo
2016-09-27 19:05:06 +08:00
Cheng Zhao
9850af93c9 Merge pull request #7313 from electron/add-type-to-webview-style-tag
add type to webview style tag
2016-09-27 19:03:08 +08:00
Cheng Zhao
4c8d0ab804 Merge pull request #7298 from deepak1556/content_settings_patch
protocol: disable storage for non standard custom schemes
2016-09-27 18:52:36 +08:00
Thiago de Arruda
47fd41715f Add some tests for "sandbox" option 2016-09-27 06:01:47 -03:00
Thiago de Arruda
a64978b812 Use the routing id on api::WebContents::GetID
The sandbox option allows multiple webContents in one renderer process, so using
the only the renderer id to identify WebContents instances is no longer an
option.

WebContents::GetID now returns a 64-bit integer, which is composed of both the
process id(high 32), and the RenderViewHost routing id(low 32). Also add a
`GetProcessID` that retrieves the renderer process id, a requirement in some of
our javascript code.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
524bab530a Improve AtomSandboxedRendererClient to support preload scripts.
Add RenderFrameObserver/RenderViewObserver subclasses that implement the
necessary support for preload scripts in sandboxed renderers.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
72154b64ed Embed setup bundle for preload scripts in sandboxed renderers.
Add a gyp target that creates a browserify bundle starting with
`lib/sandboxed_renderer/init.js`, which is embedded into the executable using
the `atom_js2c` target.

The goal of this bundle is to provide a very basic environment for preload
scripts where a `require` function is available.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
695509e267 Add browser side support for reading files from renderer. 2016-09-27 06:01:46 -03:00
Thiago de Arruda
0f7652dc85 Move code that defines ipcRenderer methods into another file. 2016-09-27 06:01:46 -03:00
Thiago de Arruda
1713200084 Refactor the atom_js2c target to include javascript from multiple dirs.
Before invoking js2c, copy all files that must be embedded into the shared
intermediate directory, and modify the js2c wrapper script to include all files
from that directory(which is passed as argument).

This allows the build system to embed files that don't share a common base
directory, such as javascript generated at build time.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
6afe8aa7f2 Move EmitIPCEvent into AtomRenderViewObserver.
Refactor this function as a method so it is possible to inherit most behavior
from AtomRenderViewObserver and override EmitIPCEvent.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
c8629019f5 Expose atom_api_renderer_ipc module API 2016-09-27 06:01:46 -03:00
Thiago de Arruda
a7b6332ed0 Add atom::AtomSandboxedRendererClient class 2016-09-27 06:01:46 -03:00
Thiago de Arruda
06cc9a44fe Add support for native chromium popups on sandboxed renderers.
- Allow `api::Window` instances to be created from existing `api::WebContents`.
- Override `WebContentsCreated` and `AddNewContents` to wrap renderer-created
  `content::WebContents` into `api::WebContents`.
- For `content::WebContents` that should be displayed in new windows, pass the
  wrapped `api::WebContents` object to window manager.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
0b3b29938f Allow api::WebContents to fully wrap an existing content::WebContents.
- Add an overload to `WebContents::CreateFrom` that accepts a type parameter. If
  type is `REMOTE`, initialization is the same as before(a thin wrapper). If
  not, the `api::WebContents` will be fully initialized, as if it was created by
  `api::WebContents::Create`.
- Move common initialization code to `InitWithSessionAndOptions`.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
1b1541fe1a Decouple api::Window initialization from api::WebContents construction. 2016-09-27 06:01:46 -03:00
Thiago de Arruda
1d228446db Expose --enable-sandbox command-line switch.
When `--enable-sandbox` is passed, electron will use chromium sandbox to spawn
all renderers, and every new BrowserWindow will automatically have "sandboxed"
passed as a web preference(since the renderer would not work properly
otherwise).
2016-09-27 06:01:46 -03:00
Thiago de Arruda
c783ec72bc Add "sandboxed" option to "webPreferences".
When "sandboxed" is passed as a web preference for `BrowserWindow`, the newly
created renderer won't run any node.js code/integration, only communicating with
the system via the IPC API of the content module. This is a requirement for
running the renderer under chrome OS-level sandbox.

Beyond that, certain behaviors of AtomBrowserClient are modified when dealing
with sandboxed renderers:

- `OverrideSiteInstanceNavigation` no longer create a new `SiteInstance` for
  every navigation. Instead, it reuses the source `SiteInstance` when not
  navigating to a different site.
- `CanCreateWindow` will return true and allow javascript access.
2016-09-27 06:01:46 -03:00
Zeke Sikelianos
90c5972fce Merge pull request #7342 from tinydew4/update-changes
Update changes to korean docs.
2016-09-26 22:19:45 -07:00
Zeke Sikelianos
1f677ed361 fix typo 2016-09-26 22:12:51 -07:00
Zeke Sikelianos
9c19b4e3d5 Merge pull request #7343 from tinydew4/translate-ko
Translate newest styleguide.md and update changes to system-preferences.md
2016-09-26 21:47:42 -07:00
Zeke Sikelianos
d4a1f396fb tweak wording about complex objects 2016-09-26 21:04:54 -07:00
arus
72e3816143 Change a word 2016-09-27 09:38:23 +09:00
arus
9dd181c206 Change some sentences after review 2016-09-27 09:34:59 +09:00
Zeke Sikelianos
9828926002 Merge pull request #7340 from tinydew4/fix-link
Fix broken link in original docs
2016-09-26 12:04:22 -07:00
Zeke Sikelianos
bb955b6202 document lack of MAS support for login item APIs 2016-09-26 11:00:13 -07:00
Cheng Zhao
1dd05ff520 Merge pull request #7338 from electron/fix-get-accent-color-docs
Fix getAccentColor() docs in system-preferences.md
2016-09-26 15:39:40 +08:00
Cheng Zhao
19bd5ea8ba Merge pull request #7316 from tinydew4/update-ko
Update debugging-main-process and Add planned-breaking-changes
2016-09-26 12:56:22 +08:00
arus
bcf7a86dc7 Update changes to ko-KR/api 2016-09-26 00:03:32 +09:00
arus
2fbdac1034 Update changes to ko-KR/api/app.md 2016-09-25 23:50:36 +09:00
arus
577585df63 Update changes to ko-KR/api/power-monitor.md 2016-09-25 23:48:09 +09:00
arus
f13bd655a1 Update changes to ko-KR/api/screen.md 2016-09-25 23:45:56 +09:00
arus
81de0518d9 Update changes to ko-KR/api/web-contents.md 2016-09-25 23:43:24 +09:00
arus
d93a86e8cc Remove some changes 2016-09-25 23:37:34 +09:00
arus
7e186cee55 Remove some changes 2016-09-25 23:28:59 +09:00
arus
97da066ae2 Update changes to ko-KR/api/web-contents.md 2016-09-25 23:25:05 +09:00
arus
b58f73b5c9 Update change to ko-KR/README.md 2016-09-25 23:18:18 +09:00
arus
ad1cb16a76 Update changes to web-view-tag.md 2016-09-25 22:58:41 +09:00
arus
cd4a66dca5 Update changes to browser-window.md 2016-09-25 22:40:05 +09:00
arus
cc282a1114 Update /ko-KR/api/system-preferences.md 2016-09-25 21:57:43 +09:00
arus
270d6f774a Update changes to browser-window and correct a word 2016-09-25 21:40:33 +09:00
Samuel Attard
987a2e173a Fix docs linting 2016-09-25 21:57:37 +13:00
arus
66efaa5e0f Update /ko-KR/styleguide.md 2016-09-25 17:04:34 +09:00
arus
27a9f960de Fix broken link 2016-09-25 16:15:16 +09:00
arus
74e03d285e Fix broken link 2016-09-25 16:13:34 +09:00
arus
123f2a8265 Update /ko-KR/styleguide.md 2016-09-25 16:05:45 +09:00
arus
d25c2d0f41 Update /ko-KR/api/system-preferences.md 2016-09-25 16:05:45 +09:00
Samuel Attard
d2a701a465 Document the return values of all methods in the docs 2016-09-25 12:59:30 +13:00
Vadim Macagon
1df30821db Fix getAccentColor() docs in system-preferences.md
Example was using a non-existent method.
2016-09-25 01:45:34 +07:00
Zeke Sikelianos
bf88fe32fd Merge pull request #7333 from tinydew4/translate-ko
Translate CODE_OF_CONDUCT and change a word as other docs, in korean
2016-09-24 10:04:04 -07:00
arus
e21d5bd380 Change some sentences more smoothly 2016-09-24 15:58:58 +09:00
arus
04bdc87283 Change some smoothly 2016-09-24 11:33:31 +09:00
arus
177ccbc014 Translate CODE_OF_CONDUCT and change a word as other docs, in korean 2016-09-24 10:37:17 +09:00
Zeke Sikelianos
d6cd9e3034 Merge pull request #7331 from tinydew4/fix-link
Fix broken links
2016-09-23 17:19:07 -07:00
Zeke Sikelianos
d391f1b527 Merge pull request #7330 from tinydew4/translate-ko
Translate accessibility and change some in korean
2016-09-23 17:07:40 -07:00
arus
8c7a4de27b Fix broken links 2016-09-24 08:26:25 +09:00
Arus
7cd7894878 Update accessibility.md 2016-09-24 08:23:36 +09:00
arus
d7fc7ef2ee Fix errata 2016-09-24 08:19:24 +09:00
arus
6aef061362 Translate accessibility.md in korean 2016-09-24 08:14:19 +09:00
arus
e4943b3ab3 Change more smoothly 2016-09-24 07:18:39 +09:00
arus
091136908d Replace changes as link of original docs 2016-09-24 06:51:28 +09:00
Zeke Sikelianos
c6390e71d9 Merge pull request #7314 from tinydew4/translate-ko
Translate ko, debug-instructions-macos.md
2016-09-23 11:53:45 -07:00
gellert
ab5e51c209 fixes software rendering on macos and small resizing addition 2016-09-23 20:27:05 +02:00
Menci
938b9e897a 🐧 🐛 Workaround for electron/electron#5050
Chromium only show the Tray icon with libappindicator when the env `XDG_CURRENT_DESKTOP`'s value is `Unity`. But under elementaryOS its value is 'Pantheon'.

Set it to `Unity` before app startup make the tray icon show under elementaryOS.
2016-09-23 18:07:43 +08:00
arus
924033c2ba Remove notice on top 2016-09-23 14:03:42 +09:00
arus
99e256f461 Translate debug-instructinos-macos.md in korean 2016-09-23 14:03:42 +09:00
arus
d2bcbafe73 Translate additonally 2016-09-23 12:56:21 +09:00
arus
5c07643d24 Apply debugging-main-process changes in korean 2016-09-23 12:51:28 +09:00
Zeke Sikelianos
56d62ff589 add html doctype 2016-09-22 14:47:20 -07:00
Zeke Sikelianos
62375663ab add type to webview style tag 2016-09-22 14:34:03 -07:00
Kevin Sawicki
f5694daeb7 Merge pull request #7299 from Gioggio/master
Docs: Start Italian translations
2016-09-22 12:21:09 -07:00
Gioggio
3a73625ece 📝 Update translation for faq.md
[ci skip]
2016-09-22 21:07:13 +02:00
Gioggio
3b45f5a8e9 📝 Add styleguide.md
[ci skip]
2016-09-22 21:07:13 +02:00
Gioggio
78791763cf 📝 Fix typos and improve translations in README.md
[ci skip]
2016-09-22 21:07:13 +02:00
Gioggio
81b55c1700 📝 Add faq.md
[ci skip]
2016-09-22 21:07:13 +02:00
Gioggio
39a3ffdb9d 📝 Add README.md
[ci skip]
2016-09-22 21:07:13 +02:00
Kevin Sawicki
df03c92249 Compare against NSNormalWindowLevel in IsAlwaysOnTop 2016-09-22 09:41:06 -07:00
Kevin Sawicki
c336cf59c1 Ignore level when calling SetAlwaysOnTop on Widget 2016-09-22 09:38:04 -07:00
Kevin Sawicki
fcd6fd9fd5 Merge pull request #7310 from BenV/patch-1
Add npm_config_target_arch to native module doc
2016-09-22 09:34:19 -07:00
Kevin Sawicki
1ec173ad81 Merge pull request #7308 from tinydew4/translate-ko
Apply docs changes to korean docs
2016-09-22 09:32:41 -07:00
Kevin Sawicki
bce62622bb Fix compiler errors 2016-09-22 09:22:28 -07:00
Ben Vinson
1290ddb5c9 Add npm_config_target_arch to native module doc
We ran into an issue when creating a 32-bit binary on 64-bit Windows where node-pre-gyp kept using the 64-bit library. Setting the `npm_config_target_arch` environment variable resolved the problem for us and caused the 32-bit binary to be built and used.
2016-09-22 09:46:31 -06:00
Kevin Sawicki
ea42722918 Merge pull request #7284 from enlight/debugging-with-electron-inspector
Split up debugging-main-process.md, add electron-inspector guide
2016-09-22 08:40:38 -07:00
arus
aac09e5234 Fix erratum 2016-09-22 22:56:19 +09:00
arus
df3896b143 Apply docs changes to korean docs 2016-09-22 22:53:11 +09:00
Cheng Zhao
903bf444d9 Bump v1.4.1 2016-09-22 19:05:58 +09:00
Cheng Zhao
3dad8734a0 Do not copy api.json on Windows 2016-09-22 19:05:58 +09:00
Vadim Macagon
762a5bbefa Split up debugging-main-process.md, add electron-inspector guide
- Move the debugging guides for VSCode and node-inspector into separate
  files.
- Add instructions for using electron-inspector to the node-inspector
  guide.
- Remove note in node-inspector guide about crashing when inspecting
  `process` (it was fixed a long time ago:
  https://github.com/nodejs/node-v0.x-archive/issues/8205)
2016-09-22 15:43:06 +07:00
Cheng Zhao
d3a175cea8 Merge pull request #7303 from electron/fix-out-dir
electron-api.json is under out/ instead of out/R/
2016-09-22 14:39:33 +09:00
Cheng Zhao
4e0f810148 electron-api.json is under out/ instead of out/R/ 2016-09-22 14:31:28 +09:00
Cheng Zhao
32543997d4 Merge pull request #7297 from electron/clean-docs
Mention build cleaning on all three platforms
2016-09-22 14:14:36 +09:00
Cheng Zhao
c9a3ab3a81 Merge pull request #7295 from electron/native-image-bad-path-docs
Mention createFromPath bad path return value
2016-09-22 14:14:15 +09:00
Cheng Zhao
3b4a071723 Merge pull request #7294 from electron/mutate-remote-array-docs
Mention mutating remote arrays and buffers
2016-09-22 14:13:49 +09:00
Cheng Zhao
de9b01409b Merge pull request #7293 from electron/bookmark-windows-docs
Mention using fallback text when writing bookmarks on Windows
2016-09-22 14:13:28 +09:00
Cheng Zhao
296a53536d Merge pull request #7292 from electron/ct-log-verifiers
Upgrade Brigthray for CT log verifier fix
2016-09-22 14:11:20 +09:00
adammeyer
783d47f78b custom window level as string 2016-09-21 22:49:06 -04:00
adammeyer
b35bde662a custom window level docs 2016-09-21 19:06:36 -04:00
deepak1556
ad783652c8 update docs 2016-09-22 00:20:34 +05:30
deepak1556
7ba947aee9 add spec 2016-09-22 00:15:25 +05:30
Kevin Sawicki
696e5e73bc Upgrade Brigthray for CT log verifier fix 2016-09-21 11:29:09 -07:00
Kevin Sawicki
a723d17f49 Mention cleaning on all three platforms 2016-09-21 11:10:52 -07:00
Kevin Sawicki
f8236c1a65 Add more failure asserts for nativeImage.createFromPath 2016-09-21 10:48:24 -07:00
Kevin Sawicki
546c0e7822 Mention createFromPath failure cases 2016-09-21 10:48:01 -07:00
Kevin Sawicki
e7c4d2523b Mention mutating remote arrays and buffers 2016-09-21 10:44:54 -07:00
adammeyer
fbb3a288ec Allow custom window level when sending window to top 2016-09-21 13:35:59 -04:00
Kevin Sawicki
cae15ad6b5 Mention using fallback text when writing bookmarks on Windows 2016-09-21 10:31:01 -07:00
deepak1556
ed465208a2 renderer: add content settings class for managing storage 2016-09-21 21:47:30 +05:30
Kevin Sawicki
c2c48c4079 Merge pull request #7290 from tinydew4/translate-ko
Translate tutorial/about.md
2016-09-21 09:04:20 -07:00
Kevin Sawicki
dc7d2dab68 Merge pull request #7287 from tinydew4/translate-update
Update windows-store-guide.md in ko-KR docs
2016-09-21 09:03:48 -07:00
arus
146970d29d Add missing sample codes 2016-09-22 00:35:27 +09:00
arus
ba2cb42f0d Remove incorrect letters 2016-09-22 00:30:20 +09:00
arus
7dfe1a59b1 Translate remains in about.md 2016-09-22 00:18:28 +09:00
arus
4343f762ac Translate some in about.md 2016-09-22 00:15:57 +09:00
arus
e2f53c6bcc Translate some in about.md 2016-09-22 00:13:44 +09:00
arus
5c22f2ca5d Translate some in about.md 2016-09-22 00:05:26 +09:00
arus
b6d4014bd5 Translate some in about.md 2016-09-22 00:04:24 +09:00
arus
6b8f5f5b7f Translate some in about.md 2016-09-22 00:01:21 +09:00
arus
b7e2f819a3 Translate Core Philosophy in about.md 2016-09-21 23:55:16 +09:00
arus
a8e0e8d7fd Translate LTS in about.md 2016-09-21 23:42:07 +09:00
arus
beea9a7c36 Translate Update dependencies and Versioning in about.md 2016-09-21 23:35:19 +09:00
arus
a44d7a3bc6 Translate some in aboud.md 2016-09-21 23:11:29 +09:00
arus
b45db70d21 Translate Releases in about.md 2016-09-21 23:08:32 +09:00
arus
8feff471ce Modify some in about.md 2016-09-21 23:04:41 +09:00
arus
00dec166e9 Translate Core Team and Contributors in about.md 2016-09-21 23:03:23 +09:00
arus
ebbbaf1ab0 Translate Core Team and Contributors in about.md 2016-09-21 23:03:02 +09:00
arus
29312186de Translate about/about electron in Korean 2016-09-21 22:38:17 +09:00
arus
e1d9e4ffcb Merge branch 'translate-update' of https://github.com/tinydew4/electron into translate-update 2016-09-21 22:01:54 +09:00
arus
b6c04c9e35 Update windows-store-guide.md in ko-KR docs 2016-09-21 22:00:48 +09:00
arus
405b411a29 Merge branch 'translate-update' of https://github.com/tinydew4/electron into translate-update 2016-09-21 21:44:07 +09:00
arus
582fc50cf6 Update windows-store-guide.md in ko-KR docs 2016-09-21 21:43:18 +09:00
arus
b74cfda7b9 Update windows-store-guide.md in ko-KR docs 2016-09-21 21:35:35 +09:00
Cheng Zhao
805ce0dee9 Merge pull request #7276 from electron/google-api-key-env2
allow GOOGLE_API_KEY to be set
2016-09-21 15:16:29 +09:00
Zeke Sikelianos
f4a8fb9eb4 🎨 standard 2016-09-20 14:55:45 -07:00
Kevin Sawicki
85702604c3 Merge pull request #7277 from electron/dictionary-to-object
Set parameter type to Object instead of Dictionary
2016-09-20 14:48:48 -07:00
Kevin Sawicki
98999f4850 Add missing s in progress 2016-09-20 14:46:17 -07:00
Kevin Sawicki
b5e1571204 Set parameter type to Object 2016-09-20 14:26:55 -07:00
Zeke Sikelianos
d7934e7525 add link to chromium API keys doc 2016-09-20 14:13:30 -07:00
Zeke Sikelianos
7fcba6ba0f document the GOOGLE_API_KEY env var 2016-09-20 13:58:39 -07:00
Kevin Sawicki
ea1927f428 Store api_key_ on TokenLoadingJob 2016-09-20 13:24:45 -07:00
Zeke Sikelianos
fa2aaa48b1 allow GOOGLE_API_KEY to be set in environment 2016-09-20 12:01:59 -07:00
Kevin Sawicki
dee383db07 Merge pull request #7273 from tinydew4/fix-links
Fix some bronken links
2016-09-20 09:00:08 -07:00
Kevin Sawicki
04a1dc8e1e Merge pull request #7272 from tinydew4/translate-ko
Translate "offscreen rendering" in Korean
2016-09-20 08:59:53 -07:00
Kevin Sawicki
ae31ded165 Merge pull request #7265 from octref/patch-1
Add instruction for debugging main process in VSCode
2016-09-20 08:59:37 -07:00
arus
402e977b40 Fix some bronken links 2016-09-20 23:36:20 +09:00
arus
a65c8cae63 modify some 2016-09-20 23:30:46 +09:00
arus
47a03d3ca1 modify some 2016-09-20 23:29:34 +09:00
arus
b4a13fda3a Translate offscreen rendering in Korean 2016-09-20 23:19:15 +09:00
Cheng Zhao
e11672d42b Merge pull request #7262 from tinydew4/patch-1
Update browser-window.md
2016-09-20 16:04:25 +09:00
Cheng Zhao
30a6b597a5 Merge pull request #7239 from darkdh/6873
Emit scroll-touch-edge event instead of changing the behavior of scrollll-touch-begin/end
2016-09-20 14:51:10 +09:00
Pine
c45ca254e3 Add instruction for debugging main process in VSCode
I hope you don't mind me putting the VSCode part before `node-inspector`, because VSCode seems easier to setup, and VSCode could inspect `process` without crashing.
2016-09-19 22:43:05 -07:00
Cheng Zhao
143d7ab98f Merge pull request #7264 from electron/docs-readme
Docs Readme
2016-09-20 14:31:31 +09:00
Cheng Zhao
e3e450613d Merge pull request #7157 from Mossop/moveguest
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Cheng Zhao
77fdc67235 Merge pull request #7173 from electron/windows-system-color
Add an app API method to fetch the system ColorizationColor
2016-09-20 14:06:21 +09:00
Zeke Sikelianos
61e50046bd link to the documentation styleguide 2016-09-19 21:10:36 -07:00
Zeke Sikelianos
1cdf8bbc10 break up run-on sentence 2016-09-19 21:09:31 -07:00
Zeke Sikelianos
a3d2cdaa2c website doesn't display docs for old versions any more 2016-09-19 21:09:02 -07:00
Arus
159e2f2dab Update browser-window.md 2016-09-20 11:26:04 +09:00
Kevin Sawicki
e8f3cf164b Merge pull request #7227 from electron/felix-cmd-strings
Ensure correct types for commandLine
2016-09-19 10:22:28 -07:00
Samuel Attard
456f102cdc Fix k typo 2016-09-20 02:42:41 +10:00
Samuel Attard
ba98109d33 Remove semicolons from spec 2016-09-20 02:41:26 +10:00
Samuel Attard
9f94652792 Add basic spec for getAccentColor 2016-09-20 02:41:26 +10:00
Samuel Attard
1454510549 Alphabetical method ordering 2016-09-20 02:41:26 +10:00
Samuel Attard
c0f8b4895d Update docs 2016-09-20 02:41:26 +10:00
Samuel Attard
5dd5dbb3d8 Add a systemPreferences API method to fetch the system ColorizationColor
This is useful for automatical app theming

* Fetches the color from the registry
* Returns an empty string if the fetch fails (a falsey value)
2016-09-20 02:41:26 +10:00
Kevin Sawicki
48fd2bd35f binding -> bindings 2016-09-19 09:31:59 -07:00
Felix Rieseberg
29fa48d8c3 🔧 Ensure correct types for commandLine
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Felix Rieseberg
90bff4d9de 🔧 Ensure correct types for commandLine
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Cheng Zhao
b05254807b Merge pull request #7253 from electron/osr-crash
Unsubscribe observer when OffScreenRenderWidgetHostView is destroyed
2016-09-19 17:54:31 +09:00
Cheng Zhao
e504d82554 spec: Suppress the download.pdf test on AppVeyor 2016-09-19 17:12:33 +09:00
Cheng Zhao
5bf746700e Unsubscribe observer when OffScreenRenderWidgetHostView is destroyed 2016-09-19 16:51:03 +09:00
Cheng Zhao
07a08077a2 Revert electron/brightray#246 2016-09-19 16:31:00 +09:00
Cheng Zhao
26004f1a66 Merge pull request #7241 from miniak/crashed-killed
Add killed argument for webContents.on("crashed") and app.on("gpu-process-crashed") events
2016-09-19 16:02:52 +09:00
Cheng Zhao
1c6586c4b9 Merge pull request #7238 from electron/felix-windows-store-docs
Update Windows Store Language
2016-09-19 15:54:23 +09:00
Cheng Zhao
0ac4b89a0a Merge pull request #7236 from yuya-oc/accelerator-for-redo
Use Ctrl+Y as the accelerator of redo on Windows
2016-09-19 15:53:44 +09:00
Cheng Zhao
6de1eef078 Merge pull request #7234 from Mossop/testhistoryreplace
 Test that replacement history entries don't break forward navigation.
2016-09-19 15:47:30 +09:00
Cheng Zhao
1fd819e500 Merge pull request #7231 from miniak/default-error-mode
Fix ELECTRON_DEFAULT_ERROR_MODE
2016-09-19 15:44:52 +09:00
Cheng Zhao
a260647b4f Merge pull request #7062 from MaxWhere/osr-sizing-fix
Offscreen invalidate and sizing fix
2016-09-19 15:38:11 +09:00
Cheng Zhao
ffe931bde7 Merge pull request #7226 from electron/power-monitor-error
Rethrow caught errors from process.binding
2016-09-19 15:25:18 +09:00
Cheng Zhao
27bc6c7883 Merge pull request #7233 from electron/deprecate-atom-shell-version
Deprecate process.versions['atom-shell']
2016-09-19 15:24:10 +09:00
Cheng Zhao
6c340cece8 Merge pull request #7229 from electron/update-clang
Update clang to r274142.
2016-09-19 15:23:57 +09:00
Cheng Zhao
64718173ef Merge pull request #7230 from electron/windows-x64-link-crypt32
Link against crypt32.lib
2016-09-19 15:23:41 +09:00
Yuya Ochiai
43f955194e 🏁 Use Ctrl+Y as the accelerator of redo on Windows 2016-09-18 17:07:34 +09:00
Milan Burda
8567f79e67 Add killed argument for webContents.on("crashed") and app.on("gpu-process-crashed") events 2016-09-17 17:02:36 -07:00
Anthony Tseng
269a87b26f Emit scroll-touch-edge event instead of changing the behavior of scroll-touch-begin/end
fix #6873
2016-09-17 22:50:10 +08:00
Felix Rieseberg
084110c56f 📝 Update Windows Store Language 2016-09-17 04:19:55 -07:00
Dave Townsend
47df447e4f Test that replacement history entries don't break forward navigation.
This is a test for #7175
2016-09-16 17:08:54 -07:00
Kevin Sawicki
1072519488 Mark atom-shell version as deprecated 2016-09-16 15:59:00 -07:00
gellert
37de2301f7 moves setsize call to osr renderwidgethostview 2016-09-16 23:28:51 +02:00
gellert
fec5a7d67a removes extra header 2016-09-16 23:27:51 +02:00
gellert
8baaad4e0d cleanup and adds docs 2016-09-16 23:27:51 +02:00
gellert
10ea0268e5 calling setsize only on osr windows 2016-09-16 23:27:11 +02:00
gellert
b4c220613f adds invalidate method and proper resizing 2016-09-16 23:27:11 +02:00
Zeke Sikelianos
d4b204799d Merge pull request #7120 from electron/lint-docs
Publish the public API as a JSON object
2016-09-16 14:05:32 -07:00
Milan Burda
12a2b144f3 Only drop the SEM_NOGPFAULTERRORBOX flag when calling SetErrorMode (ELECTRON_DEFAULT_ERROR_MODE) 2016-09-16 14:01:33 -07:00
Kevin Sawicki
7df86c48fa Link against crypt32.lib 2016-09-16 13:17:58 -07:00
Kevin Sawicki
0c3ad527e3 initialize -> require 2016-09-16 13:09:06 -07:00
Haojian Wu
37e30cef60 Update clang to r274142. 2016-09-16 21:59:25 +02:00
Kevin Sawicki
0fda86f79a Mention not requiring module until app is ready 2016-09-16 11:42:02 -07:00
Kevin Sawicki
e77d7e7f62 🎨 2016-09-16 11:41:53 -07:00
Kevin Sawicki
5d0f3534eb Rethrow binding errors 2016-09-16 11:34:52 -07:00
Kevin Sawicki
577394442b power-monitor -> powerMonitor 2016-09-16 09:58:27 -07:00
Cheng Zhao
d1274bb79f Update brightray for #7073 2016-09-16 21:28:24 +09:00
Cheng Zhao
da677b683b Merge pull request #7163 from MaxWhere/frame-sub-scale-fix
Frame subscriber improvements
2016-09-16 21:24:53 +09:00
Cheng Zhao
9dad9478fa Merge pull request #7169 from deepak1556/download_defaultname_patch
browser: provide a default filename when unable to generate from download data
2016-09-16 21:19:21 +09:00
Cheng Zhao
ea244a5188 Merge pull request #7209 from electron/remote-function-missing-properties
Guard against missing remote function properties
2016-09-16 21:11:12 +09:00
Cheng Zhao
69d4cac760 Merge branch 'release' 2016-09-16 21:03:54 +09:00
deepak1556
e7f1265b64 add save-to-disk disposition for new-window event 2016-09-16 16:30:26 +05:30
deepak1556
94faaf7d58 provide a default file name for downloads 2016-09-16 16:02:57 +05:30
deepak1556
d426d4ad90 add failing spec 2016-09-16 16:02:57 +05:30
gellert
64e53a17bd reverts subscriber api 2016-09-16 11:18:15 +02:00
Cheng Zhao
20d5a50ac9 Merge pull request #7178 from aichingm/master
🐧 Add support for different trash implementations
2016-09-16 17:43:09 +09:00
Cheng Zhao
9714348260 Merge pull request #6941 from deepak1556/blob_data_patch
protocol: provide blob uuid with uploadData
2016-09-16 17:01:15 +09:00
Plusb Preco
787bc85703 docs: Update Korean docs as upstream (#7211)
* 📝 Update `README-ko.md`

* Remove Korean readme specified header.
* Add Indonesia community link.

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Mark untranslated docs

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Add untranslated files

[ci skip]

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Update Korean docs as upstream

* 📝 Update `README-ko.md`

* Remove Korean readme specified header.
* Add Indonesia community link.

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Update Korean docs as upstream

* 📝 Mark untranslated docs

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Add untranslated files

[ci skip]

* 📝 Update Korean docs as upstream

[ci skip]

* 📝 Update Korean docs as upstream

* 📝 Correct readme name

[ci skip]

* 📝 Update Korean docs as upstream

[ci skip]
2016-09-15 09:27:10 -07:00
Cheng Zhao
e62e62292a Bump v1.4.0 2016-09-15 14:44:38 +09:00
Cheng Zhao
b84d29fb32 Merge pull request #7213 from electron/chrome-update
Update to Chrome 53.0.2785.113
2016-09-15 14:44:10 +09:00
Cheng Zhao
5be8104104 Update to Chrome 53.0.2785.113 2016-09-15 14:27:56 +09:00
Kevin Sawicki
eef42770c6 Don't load remote properties until they are accessed 2016-09-14 13:29:49 -07:00
Kevin Sawicki
f792c720f4 Allow spec to be run multiple times in same runner 2016-09-14 11:16:44 -07:00
Kevin Sawicki
359ab2f9b3 Only set members when members exist 2016-09-14 10:54:23 -07:00
Kevin Sawicki
bc13536208 Add failing spec for missing remote properties 2016-09-14 10:53:25 -07:00
Kevin Sawicki
0d4872755c Merge pull request #7195 from Joshua-Anderson/update-node-req
Update nodejs requirement for building on linux
2016-09-14 09:52:23 -07:00
Cheng Zhao
4627311c34 Merge pull request #7104 from electron/chrome53
Upgrade to Chrome 53 and Node 6.5.0
2016-09-14 22:18:08 +09:00
Cheng Zhao
dc2ced14b8 Node module version should be 50 2016-09-14 17:08:13 +09:00
deepak1556
eafb6307d5 fix crash when using geolocation api with enableHighAccuracy option 2016-09-14 16:23:01 +09:00
Cheng Zhao
fbac635687 Only emit finalUpdate found-in-page events
Since Chrome 53 all meaningful results of found-in-page are finalUpdate.
2016-09-14 16:23:01 +09:00
Cheng Zhao
5ccd0a24e9 Fix compatibility with canScroll 2016-09-14 16:23:01 +09:00
Cheng Zhao
f8bdc7437d module search paths have changed 2016-09-14 16:23:01 +09:00
Cheng Zhao
1de2b77ee4 Update to Node 6.5.0 2016-09-14 16:23:00 +09:00
Cheng Zhao
18fd3e0329 Fix js linting error 2016-09-14 16:23:00 +09:00
Cheng Zhao
a510642a25 finalUpdate can be false 2016-09-14 16:23:00 +09:00
Cheng Zhao
30dd65e3a9 Fix failing spec when refreshing test window 2016-09-14 16:23:00 +09:00
Cheng Zhao
5708e86a05 Fix API change of findInPage API 2016-09-14 16:23:00 +09:00
Cheng Zhao
937ae7ef8f Fix crash caused by new network parameters 2016-09-14 16:23:00 +09:00
Cheng Zhao
4c56c1c2b2 Fix crash in offscreen renderer 2016-09-14 16:22:59 +09:00
Cheng Zhao
6d8f900916 Fix building on Windows 2016-09-14 16:22:43 +09:00
Cheng Zhao
4aa292c7cd Fix building on Linux 2016-09-14 16:22:43 +09:00
Cheng Zhao
f28e8d7168 Fix API changes of Chrome 53 2016-09-14 16:22:43 +09:00
Cheng Zhao
2e0a1a8a64 Upgrade to Chrome 53 2016-09-14 16:22:41 +09:00
Cheng Zhao
cfe7bfd7eb Bump v1.3.6 2016-09-14 14:36:11 +09:00
Cheng Zhao
7086bb8973 Merge pull request #7189 from electron/both-arm-names
Upload ARM assets with and without v7l suffix
2016-09-14 14:31:10 +09:00
Cheng Zhao
23ae57fe79 Merge pull request #7188 from electron/app-is-ready-public
Mark app.isReady() as public
2016-09-14 14:30:46 +09:00
Joshua Anderson
56b40ae6d2 Update nodejs requirement for building on linux 2016-09-13 19:41:53 -07:00
Kevin Sawicki
34b9ba2edc Upload ARM assets without v7l suffix 2016-09-13 10:06:09 -07:00
Kevin Sawicki
4c4d585b84 initialization -> initializing 2016-09-13 09:37:03 -07:00
Kevin Sawicki
f373f2ae15 Mark app.isReady() as public 2016-09-13 09:35:39 -07:00
Cheng Zhao
b13bab6fae Merge pull request #7182 from electron/shell-return-values
Return booleans from more shell APIs
2016-09-13 16:46:05 +09:00
Cheng Zhao
4eba8094d4 Merge pull request #7096 from minggo/add-option-to-disable-devtools
add option to disable devtools
2016-09-13 16:01:56 +09:00
Cheng Zhao
df3f0a4516 Merge pull request #7175 from bsuh/fix-twitch-navigation
Fix navigation controller
2016-09-13 16:01:00 +09:00
Cheng Zhao
036a35ab64 Merge pull request #7160 from PierBover/patch-1
added clarification for common Windows pitfalls
2016-09-13 15:09:04 +09:00
Kevin Sawicki
07304e5950 Add missing return value 2016-09-12 14:33:22 -07:00
Kevin Sawicki
00d0887cab Document shell.moveItemToTrash return value 2016-09-12 14:30:01 -07:00
Kevin Sawicki
55eab8e385 Return boolean from shell.openItem 2016-09-12 14:29:06 -07:00
Kevin Sawicki
72558654ef Return boolean from shell.showItemInFolder 2016-09-12 14:22:29 -07:00
Zeke Sikelianos
9e8b0953f3 fix indentation 2016-09-12 10:47:36 -07:00
Kevin Sawicki
05043432dd Merge pull request #7162 from electron/network-entitlements
Document com.apple.security.network entitlements
2016-09-12 09:31:11 -07:00
Mario Aichinger
893fc2cd53 🐧 Add support for different trash implementations
Make the trash implemantation in MoveItemToTrash selectable via an environment variable
2016-09-12 10:41:23 +02:00
Cheng Zhao
9a56959647 Merge pull request #7140 from liusy182/url-fix
fix a bug in navigation-controller where string is used as object
2016-09-12 14:46:05 +09:00
Brian Suh
5fc1f57fb5 Fix navigation controller
In-page navigation has not actually started if the current entry is
being replaced. Do not set inPageIndex if replaceEntry is true.
2016-09-11 14:46:17 -07:00
gellert
2435f1b660 lint fix 2016-09-09 23:50:01 +02:00
gellert
afb551e94a updates tests 2016-09-09 23:40:10 +02:00
gellert
5754f3aea0 update docs 2016-09-09 23:26:14 +02:00
gellert
d3dc66e308 adds scale factor check and simplifies frame subscription 2016-09-09 23:17:17 +02:00
Kevin Sawicki
b128264ae4 Document com.apple.security.network entitlements 2016-09-09 13:55:32 -07:00
Pier Bover
70c1d194ef added clarification for common Windows pitfalls 2016-09-09 13:51:42 -05:00
Dave Townsend
313b2faa3c Add a guestinstance attribute to webviews reflecting their current guest
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Zeke Sikelianos
18585204b7 wrap line to stay under 80 chars 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
3d40c720dd fix indentation and rename function 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
8d201ae1ad generate electron-api.json and upload with release 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
67c89b68d3 use new electron-docs-linter with node 4 support 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
5937d37fc5 move linting work to electron-docs-linter's new CLI 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
56a644d49f move electron.json to docs/api.json 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
0c54700b16 add electron.json (compiled to target 1.2.7 release) 2016-09-09 10:07:22 -07:00
Zeke Sikelianos
3a5bf51d1d add lint-docs script 2016-09-09 10:07:22 -07:00
Kevin Sawicki
01fa9827b4 Merge pull request #7153 from VarunAgw/patch-1
SSL issue in links
2016-09-09 08:05:38 -07:00
Phil Haack
cadbd7beb1 Merge pull request #7145 from electron/device-scale-factor-failures
Get specs passing on displays using certain device scale factors
2016-09-09 07:38:23 -07:00
Cheng Zhao
e189132176 Merge pull request #7123 from deepak1556/asar_range_patch
protocol: respect range header when reading from asar
2016-09-09 20:59:12 +09:00
Varun Agrawal
95206682a0 SSL issue in links 2016-09-09 17:27:27 +05:30
Cheng Zhao
7ed33dfbee Merge pull request #7077 from miniak/title-bar-style
Add support for titleBarStyle: 'hidden-inset' on OS X 10.9
2016-09-09 20:27:26 +09:00
Cheng Zhao
b6079ff90b Merge pull request #7053 from electron/launch-from-notification
Send notification info to app.ready, on macOS
2016-09-09 20:01:39 +09:00
Cheng Zhao
693ba1375b Merge pull request #7146 from electron/resolve-empty-url-values
Tweak how empty URLs are resolved
2016-09-09 19:58:41 +09:00
Cheng Zhao
932b6dc0cf Merge pull request #7142 from electron/require-buffer
Require Buffer explicitly instead of relying on global
2016-09-09 19:52:53 +09:00
Kevin Sawicki
64d436682c Verify resolving URL via console-message event 2016-09-08 17:38:40 -07:00
Kevin Sawicki
7c26fe46b8 === -> !== 2016-09-08 17:12:53 -07:00
Kevin Sawicki
daf1eec5ec Use === for string comparison 2016-09-08 17:11:10 -07:00
Kevin Sawicki
7d24df34fc Place resolve specs in correct outer block 2016-09-08 17:08:49 -07:00
Kevin Sawicki
bfd48fe2ad Add specs for resolving attribute URLs 2016-09-08 16:56:29 -07:00
Kevin Sawicki
1dbaf4987e Don't resolve empty src/preload attribute values 2016-09-08 16:48:30 -07:00
Kevin Sawicki
ea069805d1 Add failing specs for empty preload/src attribute 2016-09-08 16:40:31 -07:00
Kevin Sawicki
68c67b64c5 Use delta when scale factor is above 2 and odd 2016-09-08 16:24:11 -07:00
Charlie Hess
32e0e8a151 Use smart pointers in a couple places. 2016-09-08 16:23:55 -07:00
Kevin Sawicki
59a49f6f96 Use bounds helper in failing specs 2016-09-08 16:20:46 -07:00
Kevin Sawicki
7494e286d9 Put actual value first 2016-09-08 16:20:45 -07:00
Kevin Sawicki
d88f70caa2 Use single assert bounds helper 2016-09-08 16:20:45 -07:00
Kevin Sawicki
71fac07a93 Add scale factor assert helpers 2016-09-08 16:20:45 -07:00
Kevin Sawicki
de6f405d98 Merge pull request #7143 from electron/windows-spec-failures
Fix windows spec failures
2016-09-08 16:13:16 -07:00
Kevin Sawicki
9829baed46 Open about:blank when window.open is called with no URL 2016-09-08 16:10:21 -07:00
Kevin Sawicki
e4e4e8b2eb Add missing {} 2016-09-08 13:12:00 -07:00
Kevin Sawicki
4d20c4f3fd Update productName default in docs 2016-09-08 11:52:29 -07:00
Kevin Sawicki
d407eab0ff Set crashReporter productName in specs 2016-09-08 11:52:29 -07:00
Kevin Sawicki
63e9bc4804 Assert isTTY is undefined on Windows 2016-09-08 11:52:29 -07:00
Kevin Sawicki
638c96345d Merge pull request #7133 from electron/update-travis-node-versions
Upgrade Travis node version
2016-09-08 11:13:00 -07:00
Kevin Sawicki
74bb4bacd7 Add section about Buffer global 2016-09-08 10:42:43 -07:00
Kevin Sawicki
aaf2bb2751 Add spec for deleting Buffer global in preload 2016-09-08 10:34:09 -07:00
Kevin Sawicki
d476227e16 Remove unneeded return 2016-09-08 10:20:39 -07:00
Kevin Sawicki
902bd0564e Require Buffer explicitly instead of relying on global 2016-09-08 10:17:06 -07:00
Kevin Sawicki
24da3d181f Merge pull request #7129 from adamkidder/override_libchromium
Allow LIBCHROMIUMCONTENT_COMMIT to be overridden from the environment
2016-09-08 09:37:05 -07:00
Kevin Sawicki
e8fcdebf6d Update Travis config to build on node 4.5.0 2016-09-08 09:24:59 -07:00
Kevin Sawicki
803943bff8 Merge pull request #7128 from electron/api-breakage-list
Document what APIs will break in Electron 2.0
2016-09-08 09:21:26 -07:00
Kevin Sawicki
ae933140af Add variables to options example 2016-09-08 09:15:05 -07:00
Kevin Sawicki
d1876aa313 Add headings for each module 2016-09-08 09:09:49 -07:00
Kevin Sawicki
25f5135134 Move breaking changes doc to /docs 2016-09-08 09:07:58 -07:00
Kevin Sawicki
2aa64853f4 Add planned 2.0 API breakage 2016-09-08 09:05:49 -07:00
Kevin Sawicki
224d3aef3e Mark detach option for 2.0 removal 2016-09-08 09:05:49 -07:00
liusy182
2c7690be45 simplify logic 2016-09-08 21:36:39 +08:00
liusy182
180a77e671 fix a minor bug in navigation-controller where a string is used as an object 2016-09-08 21:31:42 +08:00
Cheng Zhao
2885e980a5 Merge pull request #7131 from electron/end-sheet-on-close
End sheet in parent when closing modal window
2016-09-08 15:53:07 +09:00
deepak1556
c003c3e28f increase spec timeout 2016-09-08 11:38:24 +05:30
Cheng Zhao
a0eccdfe1e Merge pull request #7130 from electron/windows-stdin-renderer
Add EOF process.stdin in  render process
2016-09-08 15:04:10 +09:00
deepak1556
bd291b9601 protocol: respect range header when reading from asar 2016-09-08 10:14:49 +05:30
deepak1556
1ae7b2fcbc update 2016-09-08 10:12:23 +05:30
deepak1556
7e6cba1482 add failing spec 2016-09-08 09:37:06 +05:30
Kevin Sawicki
45e8c40ae8 Merge pull request #7132 from electron/lint-python-via-npm-run-lint
Run pylint as part of main lint task
2016-09-07 16:49:21 -07:00
Kevin Sawicki
d6b1d61438 Run pylint as part of main lint task 2016-09-07 16:23:59 -07:00
Kevin Sawicki
8652888e27 End sheet in parent when closing modal window 2016-09-07 15:24:37 -07:00
Kevin Sawicki
d76c970da6 Assert read value instead of exception 2016-09-07 14:51:05 -07:00
Kevin Sawicki
28b33074cf Setup stdin in both processes on Windows 2016-09-07 14:45:56 -07:00
Kevin Sawicki
b5e9bb9e6a Add spec for accessing process.stdin 2016-09-07 14:40:18 -07:00
Adam Kidder
8ec49fe57c Allow LIBCHROMIUMCONTENT_COMMIT to be overridden from the environment 2016-09-07 12:06:06 -07:00
Kevin Sawicki
691aec701f Merge pull request #7119 from electron/arrange-project-translations
Arrange meta docs translations
2016-09-07 08:46:37 -07:00
Cheng Zhao
e561608c0d Merge pull request #7116 from electron/restore-no-asar
Restore process.noAsar in finally block
2016-09-07 16:50:26 +09:00
Cheng Zhao
ade60ed482 Merge pull request #7110 from electron/circular-menu-require
Prevent circular Menu require
2016-09-07 16:32:23 +09:00
minggo
3fdc99c3c6 change the option name to devTools 2016-09-07 10:16:52 +08:00
minggo
7d712b77ba remove duplicate comment 2016-09-07 09:43:06 +08:00
Kevin Sawicki
0686908461 Link to translations 2016-09-06 14:58:50 -07:00
Kevin Sawicki
22368d0f06 Move translated project docs to docs-translations folder 2016-09-06 14:54:17 -07:00
Kevin Sawicki
076d957ab9 Merge pull request #7068 from duncup/master
Create translate docs.
2016-09-06 14:47:18 -07:00
Kevin Sawicki
540b1960a8 Merge pull request #7113 from electron/const-default-app
Use const instead of var in default app
2016-09-06 13:42:36 -07:00
Kevin Sawicki
46fbb6ed61 Reset process.noAsar in finally block 2016-09-06 13:40:25 -07:00
Kevin Sawicki
b186d752da Add failing spec for restoring noAsar value 2016-09-06 13:40:15 -07:00
Kevin Sawicki
7bc45c328b Use const instead of var 2016-09-06 11:58:06 -07:00
Kevin Sawicki
b54b74c310 Prevent missing Menu.buildFromTemplate function 2016-09-06 11:31:14 -07:00
minggo
91fb85947d WebContents::InspectElement and WebContents::InspenctServiceWorker return immediately if DevTools is disabled 2016-09-06 17:53:42 +08:00
minggo
2db5aa8294 update browser-window.md to add disableDevTools option 2016-09-06 17:46:55 +08:00
minggo
baa55caf83 remove unneeded whitespace 2016-09-06 11:48:48 +08:00
minggo
19f6811312 initialize disable_devtools_ 2016-09-06 11:08:50 +08:00
minggo
1f1180f857 use webPreferences to disable devtools 2016-09-05 18:25:57 +08:00
minggo
0d7e7be748 add option to disable devtools 2016-09-05 16:27:56 +08:00
Charlie Hess
80f046c8df Update docs. 2016-09-03 12:03:58 -07:00
Milan Burda
9911e60f5b Add support for titleBarStyle: 'hidden-inset' on OS X 10.9 2016-09-03 01:33:20 +02:00
duncup
742a498f13 Create translate docs. 2016-09-02 14:25:56 +08:00
Cheng Zhao
02ce727ff6 Bump v1.3.5 2016-09-02 13:59:28 +09:00
Cheng Zhao
cdfcca147a Fix warning when compiling for win32 ia32 build 2016-09-02 13:59:28 +09:00
Cheng Zhao
8471f647a1 Fix arm's zip name 2016-09-02 13:57:56 +09:00
Kevin Sawicki
0c2da5dcea Merge pull request #7059 from malept/docs-typos
Fix documentation typos
2016-09-01 17:37:28 -07:00
Mark Lee
38e1a24304 📝 Make arch references more consistent
[ci skip]
2016-09-01 07:53:32 -07:00
Mark Lee
00154c7f9c 📝 Add missing words
[ci skip]
2016-09-01 07:49:36 -07:00
Cheng Zhao
249777721c Fix symbols zip's name 2016-09-01 19:18:19 +09:00
Cheng Zhao
31e947a9f7 Update brightray submodule 2016-09-01 19:12:44 +09:00
Cheng Zhao
308f3bb77b Update libchromiumcontent for #5665 2016-09-01 16:38:52 +09:00
Cheng Zhao
14f625d61b Merge pull request #6826 from enlight/set-jump-list
Extend the custom Jump List API provided by Electron
2016-09-01 15:35:21 +09:00
deepak1556
7b85ca0301 create helper class to read blob data 2016-09-01 08:52:44 +05:30
Vadim Macagon
c64294cf60 Extend the custom Jump List API
Add `app.getJumpListSettings()` and `app.setJumpList(callback)` that
make it possible to fully customize the Jump List of an Electron app.
It is now possible to:
- Add tasks to the standard `Tasks` category.
- Add separators to the standard `Tasks` category.
- Add custom categories containing tasks and file links.
- Add system managed Recent/Frequent categories.
- Remove the custom Jump List.
2016-09-01 09:56:14 +07:00
Charlie Hess
f0517812b1 Linter fascism. 2016-08-31 18:12:35 -07:00
Charlie Hess
cd25066c9f Fix oops on Windows / Linux. 2016-08-31 17:26:25 -07:00
Charlie Hess
af9e010162 Send notification userInfo to app.ready, on macOS.
Check if the user launched the app from a notification and send the notification args across if so.
2016-08-31 17:17:44 -07:00
deepak1556
5cbc8d5c71 fix ambiguous constructor call 2016-09-01 01:01:52 +05:30
deepak1556
be4bc6b7ef fix docs and update specs 2016-09-01 01:01:52 +05:30
deepak1556
d2e40d4fc1 update api to work on public url and uuid 2016-09-01 01:01:52 +05:30
deepak1556
a23e7ecf8f add docs 2016-09-01 01:01:52 +05:30
deepak1556
0fb2339e3d session: api to retrieve blob data from uuid 2016-09-01 01:01:52 +05:30
deepak1556
2b0f632d51 provide blob uuid from upload data 2016-09-01 01:01:52 +05:30
Cheng Zhao
a37544cef4 Merge pull request #7041 from Ikana/document-webcontents-fromId
documents webContents.fromId
2016-08-31 21:01:49 +09:00
Cheng Zhao
4833c4800e Merge pull request #6998 from electron/ipc-v8-converter-crash
Don't serialize external values over IPC
2016-08-31 20:45:25 +09:00
Cheng Zhao
5c051c9941 Merge pull request #6986 from electron/arm-release-asset-name
Add v7l to ARM release assets
2016-08-31 20:35:59 +09:00
Cheng Zhao
f854b27bfb Merge pull request #6867 from electron/remote-function-properties
Allow accessing remote function properties
2016-08-31 17:28:09 +09:00
roderik
1ff58a6066 documents webContents.fromId 2016-08-30 22:25:04 -05:00
Kevin Sawicki
3e7a0e4b43 Test external value as send argument 2016-08-30 09:27:12 -07:00
Kevin Sawicki
8a9776b227 Move IsExternal check to FromV8ValueImpl 2016-08-30 08:51:22 -07:00
Cheng Zhao
e2d70fb92b Merge pull request #7028 from electron/default-exit-code
Default app exit code to 0
2016-08-30 19:36:03 +09:00
Cheng Zhao
f30ebc6839 Merge pull request #7026 from Menci/master
Add guide for force new page in print / printToPDF
2016-08-30 19:31:31 +09:00
Cheng Zhao
572f58bc34 Merge pull request #7018 from HanaeKae/jpfont-in-flash
Japanese font rendering in flash.
2016-08-30 17:52:05 +09:00
Cheng Zhao
46b2579441 Merge pull request #7029 from electron/revert-7003-exit-tab-fullscreen
Revert "exit tab fullscreen on destroy"
2016-08-30 17:09:37 +09:00
Cheng Zhao
ee1571e556 Revert "exit tab fullscreen on destroy" 2016-08-30 17:08:51 +09:00
Samuel Attard
adf9acc468 Default app exit code to 0 2016-08-30 13:30:56 +10:00
Menci
ec60c149f5 Add guide for force new page in print / printToPDF 2016-08-30 08:45:39 +08:00
Kevin Sawicki
679ee95e8a Explicitly mention external objects 2016-08-29 10:38:17 -07:00
Kevin Sawicki
625bfe53f7 🎨 2016-08-29 10:38:17 -07:00
Kevin Sawicki
558ee08be9 Add explicit test for IPC cycle detection 2016-08-29 10:38:16 -07:00
Kevin Sawicki
434e7cb5e9 Add test for sending webContents instance over IPC 2016-08-29 10:38:16 -07:00
Kevin Sawicki
0f7e43aa47 Re-enable DOM object over IPC asserts 2016-08-29 10:38:16 -07:00
Kevin Sawicki
58fc1b7933 Ignore external values when serializing 2016-08-29 10:38:16 -07:00
Kevin Sawicki
b17a2874f8 Add empty request error handler 2016-08-29 10:38:16 -07:00
Kevin Sawicki
e38bc17a7b Add regression spec for HTTP request over IPC 2016-08-29 10:38:16 -07:00
Kevin Sawicki
3f4af3a2ba Convert specs to expect empty objects 2016-08-29 10:38:16 -07:00
Kevin Sawicki
4579ec6094 Don't convert values with internal fields 2016-08-29 10:38:16 -07:00
Cheng Zhao
b5dec9990e Merge pull request #7003 from brave/exit-tab-fullscreen
exit tab fullscreen on destroy
2016-08-29 16:36:44 +09:00
Hanae Kae
6ea5e50179 Japanese font rendering in flash. 2016-08-29 16:02:09 +09:00
Cheng Zhao
4e800e7fef Merge pull request #7002 from electron/include-alpha
Enable alphabetical include order cpplint rule
2016-08-29 15:19:05 +09:00
Cheng Zhao
ac9e64cfd4 Merge pull request #7001 from electron/debug-wait-connect
Port --debug-brk support to Node 6.3.0
2016-08-29 15:15:14 +09:00
Kevin Sawicki
9965423c4d Merge pull request #7006 from electron/fix-optional-param-spacing
fix optional param spacing
2016-08-27 12:18:45 -07:00
Zeke Sikelianos
7ff5649965 fix optional param spacing 2016-08-26 23:47:04 -07:00
Kevin Sawicki
3dd5628ded Include windows.h first 2016-08-26 16:00:05 -07:00
bridiver
4532114965 exit tab fullscreen on destroy 2016-08-26 15:52:15 -07:00
Kevin Sawicki
6285500cdc Sort includes alphabetically 2016-08-26 15:30:02 -07:00
Kevin Sawicki
56c17ae516 Enable alphabetical include order lint filter 2016-08-26 15:29:53 -07:00
Kevin Sawicki
307b504eb4 Merge pull request #6925 from BraveNewMath/patch-1
fix windows command prompt error
2016-08-26 14:17:55 -07:00
Kevin Sawicki
8d194691fe Add separate platform examples for running electron 2016-08-26 14:16:30 -07:00
Kevin Sawicki
7dd1a7e6f4 Only set _debugWaitConnect in main process 2016-08-26 12:30:27 -07:00
Kevin Sawicki
a2f0111205 Remove v8debug flag no longer supported by node 2016-08-26 12:08:18 -07:00
Kevin Sawicki
056e5b951b Set process._debugWaitConnect with --debug-brk is specified 2016-08-26 12:06:15 -07:00
Cheng Zhao
723c74ace6 Merge pull request #6989 from Menci/master
[doc] Add support for titleBarStyle hidden on macOS 10.9
2016-08-26 20:57:26 +09:00
Cheng Zhao
c5ece2bfb1 Merge pull request #6984 from electron/zoom-webview
Document <webview>.setZoomFactor/Level as public
2016-08-26 20:56:47 +09:00
Cheng Zhao
cd469b5f31 Merge pull request #6983 from electron/download-item-prompt
Check DownloadItem save path before prompting
2016-08-26 20:41:03 +09:00
Cheng Zhao
d35613b5ad Merge pull request #6977 from electron/ipc-cycle-detection
Improve cycle detection in IPC arguments
2016-08-26 20:26:00 +09:00
Menci
a9eb6b7238 Add support for titleBarStyle hidden on macOS 10.9
"titleBarStyle: 'hidden'" supports macOS 10.9 now. See https://github.com/electron/electron/pull/6848 and ab8fd49c72 for more info.
2016-08-26 12:06:56 +08:00
Kevin Sawicki
fd38cfd88c Remove unused imports 2016-08-25 17:57:14 -07:00
Kevin Sawicki
d0b95e9298 Add v7l suffix to ARM build assets 2016-08-25 17:51:37 -07:00
Kevin Sawicki
87e60466d3 Add helper for generating zip file names 2016-08-25 17:50:12 -07:00
Zeke Sikelianos
34e0f8c644 Merge pull request #6985 from electron/more-parameter-fixes
More parameter fixes
2016-08-25 17:28:36 -07:00
Zeke Sikelianos
e91dc83b2c capitalize 2016-08-25 17:26:57 -07:00
Zeke Sikelianos
0ba9564629 use the right bullet 2016-08-25 17:26:52 -07:00
Zeke Sikelianos
ab1238d8fd add a description for BrowserWindowProxy 2016-08-25 15:20:05 -07:00
Kevin Sawicki
bdaea02d8a Document <webview>.setZoomFactor/Level as public 2016-08-25 14:55:01 -07:00
Zeke Sikelianos
5619558689 document some missing parameters 2016-08-25 14:43:06 -07:00
Zeke Sikelianos
0e4e60625f fix method heading level 2016-08-25 14:42:53 -07:00
Kevin Sawicki
3108b8aacd Use path to non-existent file 2016-08-25 14:40:15 -07:00
Kevin Sawicki
cf93e3e713 Check download item save path before prompting 2016-08-25 14:34:48 -07:00
Kevin Sawicki
1de8a0dcf9 Add failing spec for unwanted save dialog 2016-08-25 14:27:37 -07:00
Kevin Sawicki
e14e92147d Merge pull request #6981 from electron/typo-in-method-name
Correct misspelling of destroy in method name
2016-08-25 13:45:42 -07:00
Kevin Sawicki
7a0129bbc7 Correct misspelling of destroy in method name 2016-08-25 12:28:57 -07:00
Zeke Sikelianos
9548184b15 Merge pull request #6980 from electron/method-params-take-2
Document all Method Parameters
2016-08-25 11:25:01 -07:00
Zeke Sikelianos
28d42ba35b document missing method parameters 2016-08-25 10:52:19 -07:00
Kevin Sawicki
50e2e26e4f Improve cycle detection in V8ValueConverter 2016-08-25 09:26:07 -07:00
Kevin Sawicki
10d39f673a Add failing spec for duplicate references over IPC 2016-08-25 09:25:13 -07:00
Cheng Zhao
97a004a357 Merge pull request #6963 from electron/remote-buffers
Serialize ArrayBuffers as Buffers instead of Arrays over remote
2016-08-25 17:29:12 +09:00
Cheng Zhao
764c84f569 Merge pull request #6952 from deepak1556/custom_scheme_filesystem_patch
protocol: allow standard schemes to support filesystem api
2016-08-25 09:28:34 +09:00
Cheng Zhao
6e75e8e2bf Merge pull request #6961 from electron/fullscreen-linux
Only change window state when fullscreen is true
2016-08-25 09:23:02 +09:00
Kevin Sawicki
b688539fe9 🎨 Use const 2016-08-24 17:00:03 -07:00
Kevin Sawicki
e1cf61f0cb Add spec for Int16Array remote parameter 2016-08-24 16:47:14 -07:00
Kevin Sawicki
a1a7b1779c Add missing space after comma 2016-08-24 16:41:59 -07:00
Kevin Sawicki
01e69353d5 Don't serialize ArrayBuffer as Array 2016-08-24 15:18:42 -07:00
Kevin Sawicki
363a02b82d Add more remote Buffer specs 2016-08-24 15:01:52 -07:00
Kevin Sawicki
554e944105 Add test of sending Buffer 2016-08-24 14:49:25 -07:00
Zeke Sikelianos
a97b40eff5 Install node 4 on GitHub CI (#6948) 2016-08-24 14:37:19 -07:00
Kevin Sawicki
459c80da4e Only change window state when fullscreen is true 2016-08-24 14:30:29 -07:00
Kevin Sawicki
4ce2c221c9 Minor doc edits and link to MDN page 2016-08-24 09:03:44 -07:00
deepak1556
62cb8428fb use schemes from global instead of commandline 2016-08-24 20:22:35 +05:30
Cheng Zhao
7bdce52290 Merge pull request #6944 from electron/check-window-from-native-view
Access native window through native view
2016-08-24 16:25:27 +09:00
Cheng Zhao
dc73a5afea Merge pull request #6896 from malept/fix-checksum-format
The checksum file needs to indicate that the files should be opened in binary mode
2016-08-24 16:15:22 +09:00
deepak1556
ae297760af add spec and docs 2016-08-24 06:53:14 +05:30
deepak1556
ad0c86db7a register custom schemes to access files through filesystem api 2016-08-24 05:46:54 +05:30
Kevin Sawicki
21de91d6e2 Don't open dev tools if already initialized 2016-08-23 15:26:13 -07:00
Kevin Sawicki
1276587ebe Merge pull request #6934 from electron/add-missing-class-descriptions
Give every class a description
2016-08-23 10:16:29 -07:00
Kevin Sawicki
463b3de199 Use correct GetToplevelWindow signature 2016-08-23 10:12:55 -07:00
Kevin Sawicki
399470e281 Add spec for detached window crash 2016-08-23 10:06:05 -07:00
Kevin Sawicki
dd5ee28b2f Access window through native view 2016-08-23 09:51:54 -07:00
Jessica Lord
bb7599cddd Merge pull request #6938 from electron/add-accessibility-doc
Add accessibility doc
2016-08-23 09:30:02 -07:00
Cheng Zhao
88979a9844 Bump v1.3.4 2016-08-23 17:03:07 +09:00
Cheng Zhao
4ca6587660 Merge pull request #6935 from electron/default-network-conditions
Default network conditions to 0.0
2016-08-23 16:40:36 +09:00
Zeke Sikelianos
098d4dc0ca improve wording about class instantiation 2016-08-22 21:45:25 -07:00
Kevin Sawicki
ec44a5d198 Add tests for setting remote function properties 2016-08-22 17:07:18 -07:00
Kevin Sawicki
666a668d91 Support remote function keys and property descriptors 2016-08-22 17:07:18 -07:00
Kevin Sawicki
d226b7bc6c Use Proxy for accessing properties of remote function 2016-08-22 17:07:18 -07:00
Kevin Sawicki
8b38018ab4 Add helper for including function properties 2016-08-22 17:07:17 -07:00
Kevin Sawicki
3245bb99b2 Only register methods with members 2016-08-22 17:07:17 -07:00
Kevin Sawicki
600076b46d Remove lint from fixtures 2016-08-22 17:07:17 -07:00
Kevin Sawicki
d333cc5e38 Support remote function properties 2016-08-22 17:07:17 -07:00
Kevin Sawicki
9e4665fbc4 Add failing spec for remote static members 2016-08-22 17:07:17 -07:00
Kevin Sawicki
5cc61089d9 Add failing spec for remote function with properties 2016-08-22 17:07:17 -07:00
Jessica Lord
d2ad88978a Add accessibility doc 2016-08-22 16:27:33 -07:00
Kevin Sawicki
0485e9eb36 🎨 Go back to single line declaration 2016-08-22 16:26:31 -07:00
Kevin Sawicki
0955c2fd4d Merge pull request #6936 from electron/add-missing-require
add missing require to win.loadURL doc
2016-08-22 15:49:48 -07:00
Zeke Sikelianos
84fc1d022f add missing require to win.loadURL doc 2016-08-22 14:25:48 -07:00
Kevin Sawicki
4fc6cf48b0 Document enableNetworkEmulation defaults 2016-08-22 14:25:42 -07:00
Kevin Sawicki
ad3dc3766e Default network values to 0.0 2016-08-22 14:19:09 -07:00
Zeke Sikelianos
3d371e09b7 add a blockquote for every class 2016-08-22 14:11:03 -07:00
Kevin Sawicki
e84d0ebb7e Merge pull request #6932 from electron/fix-power-save-blocker-doc-bug
Fix some invalid docs
2016-08-22 12:30:00 -07:00
Zeke Sikelianos
8c0a551d25 fix linting errors in docs 2016-08-22 11:47:55 -07:00
Zeke Sikelianos
ee44ab7ecd wrap MenuItem constructor in backticks 2016-08-22 11:29:15 -07:00
Zeke Sikelianos
39c5ff2077 missing space in doc 2016-08-22 11:17:05 -07:00
Cheng Zhao
d6a63855c4 Merge pull request #6926 from electron/fix-fetch
Use scoped policy for micro tasks
2016-08-22 20:08:08 +09:00
Cheng Zhao
103fea5cdf Use scoped policy for micro tasks 2016-08-22 19:34:59 +09:00
Cheng Zhao
9bc6302aea spec: Add test case for fetch 2016-08-22 19:26:07 +09:00
Cheng Zhao
374e23fc37 Merge pull request #6922 from TomKaltz/patch-1
Update devtools-extension.md
2016-08-22 16:52:18 +09:00
Elias
1fe3b70a23 fix windows command prompt error
path to electron needs to be wrapped in quotes or else windows command prompt will error out
2016-08-22 00:29:33 -07:00
Cheng Zhao
c1989fb794 Merge pull request #6913 from markwylde/bugfix-spelling-fix
Fix spelling mistake from registred to registered
2016-08-22 11:19:09 +09:00
Cheng Zhao
be9fa3c9d3 Merge pull request #6923 from electron/fix-path-compatibility
Do not add extra space when args is empty
2016-08-22 11:00:07 +09:00
Cheng Zhao
23ca9fcd02 Merge pull request #6900 from electron/loadurl-example
Improve doc for loadURL
2016-08-22 10:46:03 +09:00
Cheng Zhao
31b82731ac Cleanup the usages of std::wstring 2016-08-22 09:57:52 +09:00
Cheng Zhao
77dfd3a76c Do not add extra space when args is empty 2016-08-22 09:50:58 +09:00
Cheng Zhao
8b9fd8a76e Merge pull request #6858 from electron/default-protocol-launch-args
Allow settings of launch args when using defaultProtocol
2016-08-22 09:32:54 +09:00
Thomas Kaltz III
77dc700c51 Update devtools-extension.md
Cerebral Debugger is now supported under Electron
2016-08-21 17:36:26 -04:00
Mark Wylde
c55b1e87ed Fix spelling mistake from registred to registered 2016-08-20 14:25:13 +01:00
Zeke Sikelianos
1985432e8e recommend url.format for file URLs 2016-08-19 13:31:57 -07:00
Zeke Sikelianos
d9901e62b6 improve doc for loadURL 2016-08-18 22:20:55 -07:00
Will Eccles
488fe53276 fixed grammar for 32bit 2016-08-18 08:56:12 -07:00
Mark Lee
aaf9c5327c The checksum file needs to indicate that the files should be opened in binary mode 2016-08-18 08:35:54 -07:00
Samuel Attard
ab7899d0fb Fix linting issues 2016-08-18 20:42:06 +10:00
Samuel Attard
73246112d2 Use base::string16 and base::JoinString instead of custom methods 2016-08-18 20:35:57 +10:00
Samuel Attard
ca971e978e Return boolean instead of empty string when error occurs. Update docs 2016-08-18 18:02:13 +10:00
Cheng Zhao
293ba4230d Merge pull request #6888 from electron/show-spec-runner-initially
Show spec window initially when not on CI
2016-08-18 15:27:09 +09:00
Cheng Zhao
b9b6fc238e docs: Correctly fomart titleBarStyle line 2016-08-18 14:42:10 +09:00
Cheng Zhao
105597c7e8 Merge pull request #6848 from miniak/titlebar-style-hidden
Add support for titleBarStyle: 'hidden' on OS X 10.9
2016-08-18 14:40:54 +09:00
Cheng Zhao
06d2dfe119 Merge pull request #6788 from electron/felix-progress-enum
Use enum to declare ProgressState
2016-08-18 14:35:00 +09:00
Cheng Zhao
56d17a1449 Merge pull request #6829 from electron/fix-thumbar-buttons-vanishing
Save the thumbar buttons when setting them to restore later
2016-08-18 14:34:26 +09:00
Cheng Zhao
9b00e3f432 Merge pull request #6882 from duncup/patch-1
Fix typos
2016-08-18 11:51:43 +09:00
Kevin Sawicki
dfb6a9b07d Show window when not on CI 2016-08-17 14:25:42 -07:00
Kevin Sawicki
6813c03f30 Merge pull request #6853 from electron/about-documentation
Add About Electron documentation
2016-08-17 08:53:33 -07:00
Kevin Sawicki
b8971ae185 Merge pull request #6871 from electron/update-docs-for-electron-npm
Update docs re: electron module update
2016-08-17 08:52:42 -07:00
Kevin Sawicki
09adffe48f Merge pull request #6870 from electron/more-permissive-standard-markdown
Use a more permissive version of standard-markdown
2016-08-17 08:52:06 -07:00
Kevin Sawicki
bc3d2cfc34 Merge pull request #6875 from electron/remove-styleguide-rule-about-endlines
source files DO have newlines at the end
2016-08-17 08:51:20 -07:00
wolf
e9b5833ed4 Fix typos
Fix typos,`当前也` change to `当前页`
修正错别字,`当前也`改为`当前页`
2016-08-17 22:16:28 +08:00
Cheng Zhao
0b7b6b38c0 Merge pull request #6872 from electron/only-show-extension-button-on-save-dialog
Only call setCanSelectHiddenExtension on save dialogs
2016-08-17 22:35:15 +09:00
Cheng Zhao
faebe5259d Merge pull request #6861 from megahertz/bug_window_location
Apply resolveURL when set a location of a window opened by window.open()
2016-08-17 22:04:46 +09:00
Cheng Zhao
fc57201406 Merge pull request #6857 from brave/object-registry
clear the storage for the webContentsId when the render view is deleted
2016-08-17 21:47:39 +09:00
Cheng Zhao
79f35fa475 Merge pull request #6850 from electron/disable-resize-when-changing-style-mask
Disable all resizes when changing the window's style mask
2016-08-17 21:19:35 +09:00
Cheng Zhao
2e8d7cd6db Merge pull request #6881 from electron/data-string
Certificate data is now a string
2016-08-17 21:13:31 +09:00
Cheng Zhao
8f9a0100e3 Certificate data is now a string 2016-08-17 20:48:09 +09:00
Cheng Zhao
47c37d6f51 Merge pull request #6814 from brave/net-converter-fix
don't convert a string to an array buffer
2016-08-17 20:44:13 +09:00
Cheng Zhao
bd03ae53f2 Merge pull request #6832 from hammerandchisel/bug/remote_object_freer_crash
fix intermittent crash in RemoteObjectFreer
2016-08-17 20:31:06 +09:00
Cheng Zhao
4e355355a9 Merge pull request #6851 from electron/focused-web-contents-from-hidden-windows
Prevent web contents in hidden windows from reporting as focused
2016-08-17 20:15:37 +09:00
Zeke Sikelianos
515e25b749 source files DO have newlines at the end 2016-08-16 21:24:53 -07:00
Kevin Sawicki
4fc4f0ae53 Only call setCanSelectHiddenExtension for save dialogs 2016-08-16 17:22:44 -07:00
Kevin Sawicki
925fb27b1e Merge pull request #6874 from electron/tweak-flaky-web-contents-spec
Tweak flaky web contents spec
2016-08-16 16:42:01 -07:00
Kevin Sawicki
6cca62788d Assert first and last web contents types 2016-08-16 16:19:32 -07:00
Jessica Lord
3ebd5fbd8f Update docs re: electron module update 2016-08-16 15:57:07 -07:00
Zeke Sikelianos
cc2b95fac3 js → javascript 2016-08-16 14:50:21 -07:00
Zeke Sikelianos
e71280f31c restore js label to orphan code blocks 2016-08-16 14:49:42 -07:00
Zeke Sikelianos
8527bc360a bump standard-markdown for orphan array support 2016-08-16 14:48:35 -07:00
Zeke Sikelianos
6b298213ab update standard-markdown to 1.2.0 2016-08-16 14:07:50 -07:00
Jessica Lord
8d9aaf1d5e Fix date 2016-08-16 11:34:20 -07:00
Kevin Sawicki
959613bb04 Merge pull request #6865 from electron/test-for-request-headers-without-path-expansion
Add test for header with . characters
2016-08-16 10:05:48 -07:00
Kevin Sawicki
1f46574efe Add test for header with . characters 2016-08-16 09:08:36 -07:00
Kevin Sawicki
c93a8fb4ea Merge pull request #6856 from brave/nested-header-fix
don't convert header names to nested values
2016-08-16 08:54:26 -07:00
Alexey Prokhorov
16f2702495 Apply resolveURL when set a location of a window opened by window.open() 2016-08-16 16:24:49 +05:00
Samuel Attard
88bf089504 Pass args through correctly 2016-08-16 17:40:44 +10:00
Samuel Attard
14154e374a Fix cpp linting issues 2016-08-16 15:54:30 +10:00
Samuel Attard
ce986590cf Clarify defaults 2016-08-16 15:39:36 +10:00
Samuel Attard
db27da5db0 Document the optional params 2016-08-16 15:38:35 +10:00
Samuel Attard
e5daf63b0e Allow client to specify EXE file and args to set as default handler
* Optional path param to setAsDefaultProtocolClient
* Optional args param to setAsDefaultProtocolClient
2016-08-16 15:35:33 +10:00
bridiver
3b11bf5e41 clear the storage for the webContentsId when the render view is deleted 2016-08-15 21:53:58 -07:00
bridiver
ca4cbe34a0 don't convert header names to nested values
fixes #6855
2016-08-15 17:21:14 -07:00
Jessica Lord
fd9a032839 Add About Electron documentation 2016-08-15 16:26:30 -07:00
Kevin Sawicki
0755349e70 Ensure hidden windows don't have focused webContents 2016-08-15 14:13:24 -07:00
Kevin Sawicki
cc7fe82b74 Add failing webContents.isFocused spec 2016-08-15 14:11:08 -07:00
Kevin Sawicki
86e5bd3552 Disable resize during any stylemask change 2016-08-15 13:18:22 -07:00
Milan Burda
ab8fd49c72 Add support for titleBarStyle: 'hidden' on OS X 10.9 (hidden-inset falls back to hidden) 2016-08-15 22:10:38 +02:00
Kevin Sawicki
c754b5efdc Add failing spec for state changes resizing frameless window 2016-08-15 12:30:26 -07:00
Kevin Sawicki
420f756c47 Merge pull request #6846 from ysagal/patch-1
Added `title` to `page-title-updated` return args
2016-08-15 10:11:16 -07:00
Stan
c9f80dfc7b Added title to page-title-updated return args 2016-08-15 13:06:29 -04:00
Kevin Sawicki
2a67b05fcf Merge pull request #6838 from Gerhut/master
📝 Rename `electron-prebuilt` to `electron` when install [ci skip]
2016-08-15 08:53:45 -07:00
程启翔
91ed01df26 📝 Rename electron-prebuilt to electron when install [ci skip]
ref electron-userland/electron-prebuilt#160
2016-08-14 12:42:26 +08:00
bridiver
94c60379d1 don't convert a string to an array buffer 2016-08-13 13:35:23 -07:00
Andy Dill
704561b255 use MSG_ROUTING_NONE to initialize routing_id_ rather than 0 2016-08-12 13:03:31 -07:00
Haojian Wu
6a9801b82c Remove an extra space in front of #. 2016-08-12 22:01:30 +02:00
Andy Dill
a3bd54a41a 👕 fix lint line length error in remote_object_freer 2016-08-12 09:38:49 -07:00
Andy Dill
067aa3dbef cache routing_id so we can look up the render_view in RunDestructor with no v8 calls 2016-08-12 09:16:10 -07:00
Samuel Attard
2fa7aa3c71 Save the thumbar buttons when setting them
Then restore the buttons when restoring the taskbar icon
2016-08-13 01:55:42 +10:00
Cheng Zhao
05518ccd52 Merge pull request #6817 from deepak1556/context_menu_image_patch
webContents: fix value of contextMenu hasImageContents property
2016-08-12 17:51:40 +09:00
Cheng Zhao
d84098c4c1 Merge pull request #6816 from deepak1556/webframe_scheme_patch
webFrame: enable privileged schemes to send CORS requests
2016-08-12 17:48:50 +09:00
Cheng Zhao
620847d2fd Merge pull request #6755 from electron/upgrade-clang
Upgrade clang
2016-08-12 17:38:03 +09:00
Cheng Zhao
c41183302b Update brightray for #6755 2016-08-12 17:37:38 +09:00
Cheng Zhao
f30fe5643a Merge pull request #6812 from electron/bootstrap-defines
Support build variable setting during bootstrap
2016-08-12 17:11:22 +09:00
Cheng Zhao
6a7c6cae3a Merge pull request #6810 from electron/iframe-ismainpage-event
Send isMainFrame as argument to did-navigate-in-page event
2016-08-12 17:10:47 +09:00
deepak1556
ee298ea0e3 webContents: fix value of contextMenu hasImageContents property 2016-08-12 00:55:20 +05:30
Haojian Wu
fc36048d78 Move project-specific flags to common.gypi. 2016-08-11 21:08:12 +02:00
Haojian Wu
42a5b1f5bc Don't show -Wvarargs warning in libuv. 2016-08-11 20:59:06 +02:00
Haojian Wu
2e5eeef70e Pass compilation on mac. 2016-08-11 20:59:06 +02:00
Haojian Wu
cd169f933e Upgrade clang to r269902. 2016-08-11 20:59:06 +02:00
deepak1556
77173be1c6 webFrame: enable privileged schemes to send CORS requests 2016-08-11 23:01:10 +05:30
Kevin Sawicki
d07e40b415 Support build variable setting during bootstrap 2016-08-11 09:50:40 -07:00
Samuel Attard
0b624315b2 Fix attribute typo in docs 2016-08-12 01:49:56 +10:00
Samuel Attard
5b07e8dd5b Send isMainFrame as argument to did-navigate-in-page event 2016-08-12 01:27:50 +10:00
Cheng Zhao
58b391cb77 Merge pull request #6801 from electron/libchromiumcontent-packages
Add gperf and bison to package install commands
2016-08-11 17:23:33 +09:00
Cheng Zhao
b285b22b07 Update native_mate 2016-08-11 17:23:03 +09:00
Cheng Zhao
919571a5fc Merge pull request #6804 from electron/clean-libchromiumcontent-src
Clean libchromiumcontent/src
2016-08-11 17:20:44 +09:00
Cheng Zhao
e491b7932f Merge pull request #6789 from electron/felix-ignore-vscode
Gitignore Visual Studio Files
2016-08-11 17:16:41 +09:00
Kevin Sawicki
bc28f8d3cc Add clean npm run script 2016-08-10 17:36:58 -07:00
Kevin Sawicki
321e953a1d Clean libchromiumcontent/src 2016-08-10 17:36:57 -07:00
Kevin Sawicki
252aca8834 Add gperf and bison to package install commands 2016-08-10 17:34:58 -07:00
Kevin Sawicki
e290d51412 Merge pull request #6796 from electron/disable-global-shortcut-spec-on-windows-ci
Disable globalShortcut spec on Windows CI
2016-08-10 09:57:51 -07:00
Felix Rieseberg
8b85ee8a20 🔧 Use enum to declare ProgressState
As recommended in #6768, this commit adds an enum for progress states for windows.
2016-08-10 08:56:26 -07:00
Felix Rieseberg
96632370b2 Gitignore Visual Studio Files
Adds Visual Studio and Visual Studio Code configuration files (auto-generated) to .gitignore.
2016-08-10 08:54:50 -07:00
Kevin Sawicki
b017d2d324 Disable globalShortcut spec on Windows CI 2016-08-10 08:52:50 -07:00
Cheng Zhao
912c7716b3 Bump v1.3.3 2016-08-10 16:00:24 +09:00
Cheng Zhao
d9b872b073 Merge pull request #6787 from electron/api-specs
Add initial specs for untested modules
2016-08-10 15:55:23 +09:00
Kevin Sawicki
2a0eb72334 Add asserts for crash report APIs 2016-08-09 15:44:04 -07:00
Kevin Sawicki
ce0165367c Add spec for invalid capture options 2016-08-09 15:31:24 -07:00
Kevin Sawicki
a6353eb98f Add initial global shortcut spec 2016-08-09 15:13:05 -07:00
Kevin Sawicki
39e1541a7e Add initial power save blocker spec 2016-08-09 15:05:56 -07:00
Kevin Sawicki
ab0d726594 Merge pull request #6782 from electron/dip-thumbnail-clip
Convert DIP to screen rect for thumbnail clip
2016-08-09 09:16:10 -07:00
Kevin Sawicki
2802d2f3f9 Use gfx::Rect::ToRECT 2016-08-09 08:50:06 -07:00
Kevin Sawicki
5f2a13d01b Convert dip to screen rect for thumbnail clip 2016-08-09 08:40:38 -07:00
Cheng Zhao
6cd99ebf6b Merge pull request #6752 from lgalabru/feature/macos-native-notifications
Send events as native macOS notifications
2016-08-09 21:34:52 +09:00
Cheng Zhao
dd79c71302 Style fixes for SetProgressBar 2016-08-09 21:02:14 +09:00
Cheng Zhao
81244c2221 Merge pull request #6768 from electron/felix-set-progress
Enable mode indication for setProgressBar
2016-08-09 20:58:07 +09:00
Cheng Zhao
01f92a83ab Merge pull request #6780 from electron/update-available-check
Mark update available until restart
2016-08-09 20:44:26 +09:00
Cheng Zhao
25f29e30f5 Merge pull request #6776 from electron/remove-has-real-name-callback-property-check
Remove HasRealNamedCallbackProperty check when converting objects
2016-08-09 20:26:26 +09:00
Cheng Zhao
4a9bb87f31 Merge pull request #6777 from electron/zoom-roles
Add zoom menu item roles
2016-08-09 20:24:06 +09:00
Ludovic Galabru
a5351407c5 Fixing indentation 2016-08-09 05:57:02 -04:00
Felix Rieseberg
73c91dae9e 🔧 Enable mode indication for setProgressBar
This commit enables setting a mode for the setProgressBar method.
Old behavior is kept intact, usage is entirely optional.
2016-08-08 15:52:20 -07:00
Kevin Sawicki
0747957919 Add spec for quitAndInstall with no update on Windows 2016-08-08 13:13:08 -07:00
Kevin Sawicki
dd6c69c90b Use const instead of var 2016-08-08 13:07:01 -07:00
Kevin Sawicki
49908fd818 Keep update available flag set until restart 2016-08-08 13:03:02 -07:00
Kevin Sawicki
11b14f7621 Add zoom items to menu template 2016-08-08 11:09:30 -07:00
Kevin Sawicki
af607f8b67 🎨 function -> => 2016-08-08 11:09:30 -07:00
Kevin Sawicki
bcc372568f Add zoom menu item roles 2016-08-08 11:09:30 -07:00
Kevin Sawicki
59ffe35781 Merge pull request #6765 from miniak/menu-speaking-roles
Add macOS specific speaking roles for MenuItem
2016-08-08 11:06:45 -07:00
Kevin Sawicki
e767d3c131 Add spec for executeJavaScript DOM class prototype 2016-08-08 09:42:43 -07:00
Kevin Sawicki
42a1136c88 Remove HasRealNamedCallbackProperty check 2016-08-08 09:35:40 -07:00
Kevin Sawicki
8b3aa4dbb4 Add spec for sending document.location over IPC 2016-08-08 09:35:30 -07:00
Cheng Zhao
872fbe8ba0 Merge pull request #6762 from miniak/set-thumbnail-clip
Add BrowserWindow.prototype.setThumbnailToolTip
2016-08-08 20:27:15 +09:00
Cheng Zhao
3dd57d1171 Update brightray and libchromiumcontent to latest for #6769 2016-08-08 20:17:41 +09:00
Cheng Zhao
f5abae31a3 Code cleanup for native_window_mac
Method definitions should matche sequence of declarations.
2016-08-08 20:15:45 +09:00
Milan Burda
a6125c538e Add BrowserWindow.prototype.setThumbnailToolTip 2016-08-08 12:05:47 +02:00
Cheng Zhao
a432fb0c34 Merge pull request #6766 from miniak/set-user-tasks-result
Report app.setUserTasks success/failure
2016-08-08 17:43:08 +09:00
Cheng Zhao
850ea37abd Merge pull request #6761 from bbondy/master
Fix printing on Windows when sandbox is enabled
2016-08-08 16:52:07 +09:00
Cheng Zhao
d1b9d03c74 Merge pull request #6754 from darkdh/swipe_conflict
Fix scroll conflict
2016-08-08 16:23:52 +09:00
Cheng Zhao
b6becdeae7 Merge pull request #6741 from MaxWhere/native-window-widget-mac
Offscreen rendering fixes for macOS
2016-08-08 16:10:30 +09:00
Cheng Zhao
443761b047 Merge pull request #6745 from electron/remove-lint-ignore-files
Remove files from cpplint ignore list
2016-08-08 16:04:07 +09:00
Cheng Zhao
2137c42215 Merge pull request #6744 from sairoutine/jpdocs
Japanese: add build-instructions-linux.md
2016-08-08 16:03:30 +09:00
Cheng Zhao
fd461cdd27 Merge pull request #6743 from electron/recovery-suggestion
Add recovery suggestion to auto update failure string
2016-08-08 16:02:13 +09:00
Milan Burda
e84c82b4a7 Document boolean return value of app.setAsDefaultProtocolClient + app.removeAsDefaultProtocolClient 2016-08-08 02:26:27 +02:00
Milan Burda
a0cf013112 Report app.setUserTasks success/failure 2016-08-08 02:22:51 +02:00
Milan Burda
edc1a9614c Add macOS specific speaking roles for MenuItem 2016-08-08 00:02:32 +02:00
Brian R. Bondy
95d5de1444 Fix printing on Windows when sandbox is enabled
Auditors:  @bridiver

This makes it closer to how it works in Chromium and fixes the forever spooling problem on Windows.

The old way worked when the sandbox was disabled but failed on the call for shared_buf.CreateAndMapAnonymous when the sandbox was enabled

This also fixes a handle leak which Chromium already had fixed.
2016-08-07 10:46:08 -04:00
Ludovic Galabru
38cc56efee 🍎 Send events as native macOS notifications 2016-08-06 14:54:07 +02:00
Anthony Tseng
1aedccaeeb Fix scroll conflict 2016-08-06 14:02:40 +08:00
gellert
541116ff24 removes recycling of compositors on mac 2016-08-06 00:00:32 +02:00
Kevin Sawicki
a9c6ee997f Remove ignore files that are lint free 2016-08-05 10:53:10 -07:00
Kevin Sawicki
fdc666708f Use ATOM_COMMON_ATOM_VERSION_H_ as ifdef guar 2016-08-05 10:52:56 -07:00
sairoutine
c8369c8890 📝 Japanese: add build-instructions-linux.md [ci skip] 2016-08-06 02:03:15 +09:00
Kevin Sawicki
0c5b49c402 Add recovery suggestion to failure string 2016-08-05 09:24:13 -07:00
gellert
f29dc3402b reverts AcceleratedWidgetMacNSView into offscreen class 2016-08-05 15:23:36 +02:00
Cheng Zhao
5eeadb0ad4 Merge pull request #6737 from MaxWhere/setpainting-fix
Fix for transparent frames when offscreen window restarted painting
2016-08-05 20:47:35 +09:00
Cheng Zhao
d23418728f Merge pull request #6721 from electron/osr-refactor
Emit NativeImage objects in paint event
2016-08-05 20:44:40 +09:00
Heilig Benedek
29f30aa6ba added checks for painting_ when setting the outputdevice to active state and removed show/hide from start/stoppainting since during testing they caused transparent frames to appear when a window was set to paint again after stopping 2016-08-05 12:30:47 +02:00
gellert
795753286b moves AcceleratedWidgetMacNSView to NativeWindowMac 2016-08-05 12:29:35 +02:00
Cheng Zhao
7173d8b01b Use getBitmap in docs 2016-08-05 18:08:36 +09:00
Cheng Zhao
1be253e1aa Cleanup the code of getBitmap 2016-08-05 18:05:44 +09:00
Heilig Benedek
b5c19a9c6d update docs 2016-08-05 17:40:42 +09:00
Heilig Benedek
37f5ef5712 add getBitmap to NativeImage 2016-08-05 17:40:42 +09:00
Cheng Zhao
736fbd46c6 docs: Show how to use bitmap data directly 2016-08-05 17:40:42 +09:00
Cheng Zhao
8c4ebdc88e Emit NativeImage objects in paint event 2016-08-05 17:40:42 +09:00
Cheng Zhao
3be68ba136 Merge pull request #6736 from electron/maximizable-state
Always restore maximizable state after changing window behavior/style
2016-08-05 17:25:22 +09:00
Cheng Zhao
8a33464d41 Merge pull request #6654 from electron/content-bounds
Add BrowserWindow.get/setContentBounds()
2016-08-05 17:23:24 +09:00
Cheng Zhao
2ef33bc158 Merge pull request #6739 from electron/cookies-refactor
Remove AtomBrowserContext::SetCookieableSchemes
2016-08-05 16:46:40 +09:00
Cheng Zhao
a14b2c1cf8 Remove AtomBrowserContext::SetCookieableSchemes
The standard schemes are already stored, we don't have to duplicate the
list for every session.
2016-08-05 16:35:37 +09:00
Cheng Zhao
6cd1aa21af Merge pull request #6708 from deepak1556/cookieable_schemes_patch
protocol: custom standard schemes should support cookies
2016-08-05 16:25:23 +09:00
Cheng Zhao
ce5bdaf46f Update brightray for #6708 2016-08-05 16:23:59 +09:00
Kevin Sawicki
23203daf95 Non-resizable windows should only maximizable on Mac 2016-08-04 17:22:09 -07:00
Kevin Sawicki
b77a553de7 Always reset maximizable state 2016-08-04 16:50:22 -07:00
Kevin Sawicki
41a0a3fff2 Add failing spec 2016-08-04 16:46:40 -07:00
Kevin Sawicki
dbddf5028a Adjust y position if menu bar is visible 2016-08-04 13:18:58 -07:00
Kevin Sawicki
2a20630f2f Use same position as setPosition test 2016-08-04 13:02:41 -07:00
Kevin Sawicki
3a0ceb40b9 Assert new content bounds after resize event 2016-08-04 12:54:45 -07:00
Kevin Sawicki
3041fcc79e Add spec for BrowserWindow.setContentBounds 2016-08-04 12:34:09 -07:00
Kevin Sawicki
01f95c149a Doc BrowserWindow.setContentBounds 2016-08-04 12:15:29 -07:00
Kevin Sawicki
7bca105e15 Set max size on window constraints 2016-08-04 12:14:23 -07:00
Kevin Sawicki
7ae9c7616d Use empty origin when only adjusting size 2016-08-04 12:10:01 -07:00
Kevin Sawicki
52199a008d Add initial setContentBounds method 2016-08-04 12:02:24 -07:00
Kevin Sawicki
5681ee5220 Use current content position when adjusting content size 2016-08-04 11:41:32 -07:00
Kevin Sawicki
a190495df3 Use bounds for converting window/content sizes 2016-08-04 11:27:27 -07:00
Kevin Sawicki
4751f971e2 Use View::GetBoundsInScreen to compute content bounds 2016-08-04 09:58:36 -07:00
Kevin Sawicki
4f90abce23 Set bounds size to content size 2016-08-04 09:58:36 -07:00
Kevin Sawicki
a868bffd73 Document BrowserWindow.getContentBounds() 2016-08-04 09:58:36 -07:00
Kevin Sawicki
79eee0fdf1 Assert after size through getContentBounds() API 2016-08-04 09:58:35 -07:00
Kevin Sawicki
48cc13d009 Add BrowserWindow.getClientBounds API 2016-08-04 09:58:35 -07:00
Cheng Zhao
cdfbeb1a0a Merge pull request #6726 from MaxWhere/dummy-view-fix
Omits setMouseDownCanMoveWindow call for OffScreenView
2016-08-04 22:07:30 +09:00
gellert
0bb5dabf99 omits setMouseDownCanMoveWindow call for OffScreenView 2016-08-04 12:00:35 +02:00
Cheng Zhao
7624958cf2 Merge pull request #6723 from electron/dummy-view
Show a dummy view in the offscreen window
2016-08-04 17:04:32 +09:00
Cheng Zhao
c0c7b81aed Fix building on Linux 2016-08-04 16:43:30 +09:00
Cheng Zhao
31d8e1b9c9 Also show the text on Windows and Linux 2016-08-04 16:36:01 +09:00
deepak1556
2aa1c9e556 register cookieable schemes with browser context 2016-08-04 12:17:30 +05:30
Cheng Zhao
41df037f64 Show dummy view under offscreen mode 2016-08-04 15:35:08 +09:00
deepak1556
52431506ba protocol: custom standard schemes should support cookies 2016-08-04 11:06:21 +05:30
Cheng Zhao
64334fd40b Pass SkBitmap directly 2016-08-04 13:22:19 +09:00
Cheng Zhao
530fcc8de1 Pass OnPaint callback in constructor
This can catch the paint events happened before onload event.
2016-08-04 13:03:24 +09:00
Cheng Zhao
32d9382417 Merge pull request #6713 from MaxWhere/offscreen-rendering-fixes
Fixes buffer size in offscreen mode
2016-08-04 13:00:54 +09:00
Heilig Benedek
1b0af6f6f1 removed bpp (it can be calculated)
fixed buffer size calculation (we actually send the whole image, not just the dirty part)
removed the unnecessary resets and const
now we use Copy instead of New
2016-08-04 05:18:27 +02:00
Cheng Zhao
01d3f76f92 Merge pull request #6718 from electron/coverage
Add JavaScript code coverage reporting
2016-08-04 10:59:54 +09:00
Cheng Zhao
4a5a4729b4 Merge pull request #6720 from deepak1556/extension_scheme_patch
browser: register extension scheme as web safe scheme
2016-08-04 10:51:48 +09:00
Cheng Zhao
6e63ea7d91 Merge pull request #6719 from electron/is-destroyed-public
Mark isDestroyed as public on BrowserWindow/WebContents
2016-08-04 10:49:01 +09:00
Cheng Zhao
f9a3ed10b8 Merge pull request #6714 from sairoutine/jpdocs
Add: japanese build-instructions-osx.md
2016-08-04 10:26:00 +09:00
Cheng Zhao
28cb0c7f6b Merge pull request #6709 from saghul/uv-fixes
A couple of small libuv related fixes
2016-08-04 10:09:58 +09:00
Cheng Zhao
361161df0a Merge pull request #6711 from miniak/cleanup
isSwipeTrackingFromScrollEventsEnabled cleanup
2016-08-04 10:09:39 +09:00
Kevin Sawicki
1ee244c1b2 Upgrade to electabul@0.0.4 2016-08-03 16:37:53 -07:00
Kevin Sawicki
e1eef5f7ca Upgrade to electabul@0.0.3 2016-08-03 16:23:40 -07:00
Kevin Sawicki
a665cf1935 Remove unused spec modules 2016-08-03 16:23:40 -07:00
Kevin Sawicki
ad07a20d9a Use electabul to instrument and report coverage 2016-08-03 16:23:39 -07:00
Kevin Sawicki
2c0de93f06 Use once when calling done callback 2016-08-03 16:23:39 -07:00
Kevin Sawicki
0ebe142b2f Close windows instead of destroying them 2016-08-03 16:23:39 -07:00
Kevin Sawicki
cce6be1900 Only prevent unload the first time it is attempted 2016-08-03 16:23:39 -07:00
Kevin Sawicki
916920844e Use once instead of on 2016-08-03 16:23:39 -07:00
Kevin Sawicki
60e60d86d1 Send coverage from chrome extension iframe 2016-08-03 16:23:39 -07:00
Kevin Sawicki
9aec425ea8 Save dev tools coverage when available 2016-08-03 16:23:39 -07:00
Kevin Sawicki
e034bd05d3 Save type in coverage filename 2016-08-03 16:23:39 -07:00
Kevin Sawicki
88dc281242 Use web contents id when pid is unavailable 2016-08-03 16:23:38 -07:00
Kevin Sawicki
eaa567dd86 Ignore windows with no URLs 2016-08-03 16:23:38 -07:00
Kevin Sawicki
016faacf86 Save coverage on beforeunload event 2016-08-03 16:23:38 -07:00
Kevin Sawicki
300bf24241 Save coverage data when browser windows are destroyed 2016-08-03 16:23:38 -07:00
Kevin Sawicki
9299921ee9 Delete output lib folder before instrumenting 2016-08-03 16:23:38 -07:00
Kevin Sawicki
491f69df80 Add ability to run tests with coverage report 2016-08-03 16:23:38 -07:00
Kevin Sawicki
e17e195479 Add run script to generate instrumented code coverage .asar 2016-08-03 16:23:38 -07:00
Kevin Sawicki
5b5d51ecf4 Add helper to instrument electron.asar 2016-08-03 16:23:38 -07:00
Kevin Sawicki
afdff69482 Add initial code coverage reporting 2016-08-03 16:23:37 -07:00
deepak1556
835891b373 browser: register extension scheme as web safe scheme 2016-08-04 04:30:25 +05:30
Kevin Sawicki
05ab7d39ad Mark isDestroyed as public on BrowserWindow/WebContents 2016-08-03 14:58:22 -07:00
Kevin Sawicki
15e6028f38 Merge pull request #6710 from miniak/docs-fixes
docs: fix cwd description for shell.writeShortcutLink
2016-08-03 14:36:27 -07:00
gellert
ca16132268 renames to bytesPerPixel and use nullptr 2016-08-03 19:39:23 +02:00
Milan Burda
d8f79bf29b docs: fix cwd description for shell.writeShortcutLink 2016-08-03 18:27:15 +02:00
sairoutine
cedb3714a1 📝 delete no need text in japanese readme.md [ci skip] 2016-08-04 01:17:01 +09:00
sairoutine
ca0ac9c586 📝 build-instructions-osx.md [ci skip] 2016-08-04 01:13:57 +09:00
gellert
8a5e96056e adds resets to destructor 2016-08-03 17:38:56 +02:00
Milan Burda
136f10c4e8 Remove unnecessary comment + respondsToSelector for isSwipeTrackingFromScrollEventsEnabled implementation 2016-08-03 15:46:39 +02:00
Saúl Ibarra Corretgé
d6ff804b9a Remove unneeded flag check
stop_flag is only set if uv_stop was called, which is never the case, so
skipping the test should be harmless.
2016-08-03 12:52:17 +01:00
Saúl Ibarra Corretgé
0da72be8a9 Remove unneeded libuv callback 2016-08-03 12:48:58 +01:00
gellert
50485a28d3 fixes buffer size and adds pixel size to paint event 2016-08-03 13:28:19 +02:00
Cheng Zhao
3ea48a822e Merge pull request #6706 from sairoutine/jpdocs
Japanese: add atom-shell-vs-node-webkit.md
2016-08-03 20:06:03 +09:00
Cheng Zhao
230943d425 Merge pull request #6707 from electron/auto-run-micro-tasks
Revert Node's call of SetAutorunMicrotasks(false)
2016-08-03 18:14:01 +09:00
Cheng Zhao
1445ea8baf Revert Node's call of SetAutorunMicrotasks(false) 2016-08-03 17:57:10 +09:00
sairoutine
cdeef7c20a 📝 japanese: add atom-shell-vs-node-webkit.md [ci skip] 2016-08-03 17:21:30 +09:00
Cheng Zhao
617820dfc2 Merge pull request #6705 from electron/remove-view-painted
Remove the view-painted event
2016-08-03 16:55:48 +09:00
Cheng Zhao
5dabc47440 Remove the view-painted event 2016-08-03 16:20:55 +09:00
Cheng Zhao
1e4c83eb93 Cleanup atom_api_system_preferences_mac.mm 2016-08-03 16:13:51 +09:00
Cheng Zhao
322fb97d8d Merge pull request #6686 from darkdh/swipe_prefs
Swipe back/forward should respect system preferences
2016-08-03 16:10:29 +09:00
Cheng Zhao
b9bcba7abe docs: Do not repeat processes for multiple times in menu.md 2016-08-03 16:08:54 +09:00
Cheng Zhao
163a6bd5c5 Merge pull request #6700 from calidion/patch-1
Update menu.md
2016-08-03 16:00:52 +09:00
Cheng Zhao
53831d71e3 Merge pull request #6703 from electron/merge-offscreen
Merge #6691
2016-08-03 15:58:31 +09:00
Cheng Zhao
2e8ccfd8df Add Offscreen Rendering to guides 2016-08-03 15:38:24 +09:00
Cheng Zhao
1f41e22614 Put constants in annoymouse namespace 2016-08-03 14:09:38 +09:00
Cheng Zhao
82da3b6c66 Fix accidentally changed lines 2016-08-03 14:03:57 +09:00
Cheng Zhao
4d85c1a557 Refactor osr_render_widget_host_view 2016-08-03 13:53:11 +09:00
Cheng Zhao
ea8ea1543f Refactor osr_output_device 2016-08-03 13:06:38 +09:00
Cheng Zhao
9d8e510a55 Refactor the code in atom_api_web_contents 2016-08-03 13:06:34 +09:00
Cheng Zhao
921aaf9aa3 Move osr related files to atom/browser/osr 2016-08-03 13:05:47 +09:00
Anthony Tseng
e0c0e3e5f7 Add IsSwipeTrackingFromScrollEventsEnabled in system prefs 2016-08-03 10:27:56 +08:00
Eric
5ae112677b Update menu.md
1. add difference notice
2.  changed `render process` to `main process`
2016-08-03 10:10:56 +08:00
Cheng Zhao
b0e36ec93a Revert unnecessary changes 2016-08-03 10:48:07 +09:00
Cheng Zhao
aefd99ec7f Only enable kEnableBeginFrameScheduling for offscreen
It has effects on performance and only gets turned on after Chrome 54.
2016-08-03 10:40:12 +09:00
Cheng Zhao
63c34f3dcf docs: Use app.disableHardwareAcceleration() instead of --disable-gpu
The --disable-gpu switch does not work when passed with `appendSwitch`.
2016-08-03 10:32:29 +09:00
Cheng Zhao
c8b544ee1f spec: Remove duplicate code in tests 2016-08-03 10:27:55 +09:00
Cheng Zhao
ba9aa13bd8 Fix lint warnings in documentations 2016-08-03 10:15:38 +09:00
Cheng Zhao
d8a030fa9b Revert the change on default_app 2016-08-03 10:13:32 +09:00
Cheng Zhao
7b34b8d183 Update libchromiumcontent for offscreen patches 2016-08-03 10:12:41 +09:00
Cheng Zhao
c68e9cb595 Use electron/brightray 2016-08-03 10:10:58 +09:00
Cheng Zhao
363fabdcb4 Merge branch 'offscreen-rendering' of https://github.com/MaxWhere/electron into merge-offscreen 2016-08-03 10:09:48 +09:00
Cheng Zhao
1fa18aeba2 Merge pull request #6693 from sairoutine/jpdocs
Japanese: add coding-style.md
2016-08-03 08:30:32 +09:00
Cheng Zhao
549aa59d18 Merge pull request #6694 from ssdong/fixed_typo_in_chinese_doc_translation
fixed typo in simplified chinese doc translation
2016-08-03 08:30:18 +09:00
Cheng Zhao
59076711cb Bump v1.3.2 2016-08-03 07:18:31 +09:00
Susu Dong (LCL)
ddb7b5cff9 fixed typo in simplified chinese doc translation 2016-08-02 15:21:49 -04:00
sairoutine
93e37a92a2 📝 Japanese: add coding-style.md [ci skip] 2016-08-03 03:21:22 +09:00
gellert
1663a9cd13 fixes linendings 2016-08-02 19:31:30 +02:00
Kevin Sawicki
820f3968aa Merge pull request #6677 from miniak/default-app-menu
Add zooming commands to menu in default app
2016-08-02 10:27:56 -07:00
Milan Burda
87c9926fe8 Move Toggle Fullscreen to the bottom of the View menu 2016-08-02 18:08:41 +02:00
Milan Burda
2e043453c0 Add zooming commands to menu (default app) 2016-08-02 18:08:35 +02:00
gellert
362f3deb93 fixes linting 2016-08-02 16:39:07 +02:00
gellert
9872fa0f52 restoring default app 2016-08-02 15:17:50 +02:00
gellert
8eed91d87a Merge remote-tracking branch 'upstream/master' into speedup-gpu 2016-08-02 14:59:03 +02:00
Cheng Zhao
217156f76c Update libchromiumcontent: close #6668 2016-08-02 21:38:34 +09:00
Cheng Zhao
91169396f6 Merge pull request #6688 from electron/constructor-refactor
Use FunctionTemplate instead of ObjectTemplate for native classes
2016-08-02 21:37:56 +09:00
Cheng Zhao
8c0a033b6f Fix lint errors of using __proto__ 2016-08-02 21:02:28 +09:00
Cheng Zhao
edb573d69e Make WebContents inherit NavigationController 2016-08-02 20:55:56 +09:00
Cheng Zhao
025034127a Set JavaScript APIs on prototype of WebContents 2016-08-02 20:52:07 +09:00
Cheng Zhao
844f32aa36 Set prototype of constructor directly 2016-08-02 20:38:35 +09:00
Heilig Benedek
4088f0eb33 remove unneeded windows specific things 2016-08-02 12:57:23 +02:00
Heilig Benedek
9068182664 small fixes 2016-08-02 12:56:03 +02:00
Cheng Zhao
8c3232dc56 Every native class now gets a name 2016-08-02 19:28:12 +09:00
Cheng Zhao
cb19efe49c Pass FunctionTemplate in BuildPrototype 2016-08-02 18:08:12 +09:00
Cheng Zhao
895b8b47ee Save the prototype of EventEmitter 2016-08-02 18:07:58 +09:00
Cheng Zhao
892026458d Cleanup init.js 2016-08-02 17:45:46 +09:00
Cheng Zhao
8f62e79243 GetConstructor now returns FunctionTemplate 2016-08-02 17:20:58 +09:00
Cheng Zhao
6e0cde5b24 All native objects have prototype now 2016-08-02 17:12:17 +09:00
Cheng Zhao
8cd4612fe0 Get rid of Constructor class 2016-08-02 17:02:04 +09:00
Cheng Zhao
846ec5ba49 AttachAsUserData now can assume the existence of wrapper 2016-08-02 15:28:32 +09:00
Cheng Zhao
1505a46ed0 Do not rely on Constructor to call Init
This makes it deterministic when the JavaScript is initialized, which
can make our logic more clear.
2016-08-02 15:15:40 +09:00
Cheng Zhao
84bb82866d docs: the callbacks 2016-08-02 14:44:06 +09:00
Cheng Zhao
56b1abd64a Merge pull request #6685 from electron/document-contents-zoom
Implement and Document the zoom methods that are mapped to the webContents object
2016-08-02 14:41:09 +09:00
Cheng Zhao
7ac28b53e6 Merge pull request #6683 from gabriel/master
Add isVisible() to app.dock
2016-08-02 12:33:36 +09:00
Cheng Zhao
2330f927ed Merge pull request #6684 from electron/felix-debugging-link-fix
Fix link to macOS Debugging Instructions
2016-08-02 12:19:05 +09:00
Anthony Tseng
beca2d26f3 Swipe back/forward should respect system preferences 2016-08-02 11:18:46 +08:00
Samuel Attard
a498cf5b79 Fix linting issues 2016-08-02 13:13:17 +10:00
Samuel Attard
b59f37de98 Document the async versions of getZoomFactor and getZoomLevel 2016-08-02 13:04:21 +10:00
Samuel Attard
e4f6083753 Implement asynchronous versions of getZoomFactor and GetZoomLevel on the webContents object 2016-08-02 13:02:55 +10:00
Samuel Attard
a1f5ca1ad2 Document the zoom methods that are mapped to the webContents object 2016-08-02 12:28:13 +10:00
Felix Rieseberg
c36bcf47d3 📝 Fix link to macOS Debugging Instructions 2016-08-01 19:15:03 -07:00
Cheng Zhao
f8025d95b8 Merge pull request #6678 from sairoutine/jpdocs
Japanese: add system-preferences.md
2016-08-02 09:31:39 +09:00
Cheng Zhao
f7150228d8 Merge pull request #6675 from miniak/docs-ico-sizes
docs: Improve ICO size list
2016-08-02 09:31:19 +09:00
Gabriel Handford
7bde92deb9 Add isVisible() to app.dock 2016-08-01 15:22:37 -07:00
sairoutine
0e6c2f9971 📝 Japanese: add system-preferences.md [ci skip] 2016-08-01 23:43:07 +09:00
Cheng Zhao
eb73303f28 Merge pull request #6676 from electron/fix-upload
Fix a few errors when running the script to upload checksum files
2016-08-01 22:54:10 +09:00
Cheng Zhao
9765599b49 Must pass unicode to StringIO 2016-08-01 22:08:52 +09:00
Cheng Zhao
94a17bb494 Use spaces between checksum and filename 2016-08-01 22:08:52 +09:00
Cheng Zhao
217b639597 Fix filename when uploading to github 2016-08-01 22:08:52 +09:00
Cheng Zhao
c943e4a61f Fix error in run_boto_script 2016-08-01 22:08:52 +09:00
Cheng Zhao
d00bff4d94 Fix error of run_python_script 2016-08-01 21:41:55 +09:00
Cheng Zhao
079a7a1a1c Do not put the upload logic in make_zip 2016-08-01 21:16:16 +09:00
Cheng Zhao
8f75f10239 Merge pull request #6588 from malept/dist-checksums
Generate and upload checksums for released ZIPs to GitHub
2016-08-01 20:47:07 +09:00
Cheng Zhao
d56057b186 Merge pull request #6674 from electron/session-no-gc
Do not garbage collect sessions
2016-08-01 20:40:55 +09:00
gellert
935d47d83e Merge branch 'speedup-gpu' of https://github.com/MaxWhere/electron into speedup-gpu 2016-08-01 13:28:12 +02:00
gellert
56f5749675 adds transparency 2016-08-01 13:27:39 +02:00
Cheng Zhao
e1152ae96c Remove usages of linked_ptr
It is no longer needed since we now have move semantic.
2016-08-01 20:26:06 +09:00
Heilig Benedek
a4a2579423 brightray commit update 2016-08-01 13:22:16 +02:00
Milan Burda
e7322edb3a docs: Improve ICO size list 2016-08-01 13:13:40 +02:00
Cheng Zhao
ffed3e9c0c Move the code to native 2016-08-01 20:11:17 +09:00
Cheng Zhao
d23d9dcf01 Do not garbage collect sessions 2016-08-01 19:35:51 +09:00
gellert
36918250ec a possible fix for dragging 2016-08-01 12:06:46 +02:00
gellert
439ad94afe Merge remote-tracking branch 'upstream/master' into speedup-gpu 2016-08-01 12:00:34 +02:00
Mark Lee
59de146a9f Use S3 as an intermediary store & merge shasum files before uploading to GitHub 2016-07-31 19:25:26 -07:00
Mark Lee
5b07154b8e Generate and upload checksums for released ZIPs to GitHub
When generating an Electron release, create a `sha256sum`-compatible
file for each ZIP file, and upload them to the corresponding GitHub release.
This is primarily to confirm that the download of a given ZIP completed
successfully, as opposed to verifying that an Electron team member uploaded
the given ZIP files (which would require using a trusted GPG key).
2016-07-31 19:00:57 -07:00
Cheng Zhao
01ebc77228 Fix styling issues 2016-08-01 09:58:33 +09:00
Cheng Zhao
fb76aaac39 Merge pull request #6667 from liusy182/restore-issue
fix maximize restore issue caused by restore window size change
2016-08-01 09:56:08 +09:00
Cheng Zhao
1d33275374 Merge pull request #6661 from MaxWhere/minor-fixes
A minor fix for sendInputEvent and improvements related to cursor-changed event
2016-08-01 09:45:41 +09:00
Heilig Benedek
c39ded0481 Merge branch 'speedup-gpu' of https://github.com/MaxWhere/electron into speedup-gpu 2016-08-01 02:18:37 +02:00
Heilig Benedek
0eacee0058 add documentation for changes 2016-08-01 02:18:19 +02:00
Heilig Benedek
64f220fb50 fix UTF character sending as suggested by @zcbenz 2016-08-01 02:18:07 +02:00
Heilig Benedek
bc9adcd5ca fix toBUFFER naming issue and cursor-changed parameter order 2016-08-01 02:17:49 +02:00
Heilig Benedek
2b05be64b4 add documentation for changes 2016-08-01 02:14:45 +02:00
Heilig Benedek
7a471e1ab7 fix UTF character sending as suggested by @zcbenz 2016-08-01 02:14:11 +02:00
Heilig Benedek
bc7c5c567c fix toBUFFER naming issue and cursor-changed parameter order 2016-08-01 02:13:31 +02:00
Cheng Zhao
3d47ab20c2 Merge pull request #6663 from simonmysun/patch-1
Typo fix
2016-08-01 08:45:15 +09:00
Cheng Zhao
feb8a4b905 Merge pull request #6662 from sairoutine/jpdocs
Japanese: add testing-on-headless-ci.md
2016-08-01 08:44:54 +09:00
gellert
8e1214fc3a paint toggling fix cleanup 2016-08-01 01:01:55 +02:00
gellert
aac5fb0377 fixes paint toggling, for real tho hopefully 2016-08-01 00:47:53 +02:00
gellert
690ca7ec2a filtering out offscreen webcontents in getAllWebcontents call 2016-07-31 22:06:34 +02:00
gellert
1cd1c5e01c fixes paint toggling 2016-07-31 22:05:36 +02:00
Heilig Benedek
0098d5bca7 Hide when not painting + cursor event fix 2016-07-31 18:40:35 +02:00
gellert
35ee99265e adds tests for osr 2016-07-31 17:10:53 +02:00
liusi
db671702df fix maximize restore issue caused by restore window size change 2016-07-31 21:49:54 +08:00
gellert
5525ac36b8 does linting 2016-07-31 12:19:56 +02:00
孙茂胤
1d5a126135 Typo fix 2016-07-31 16:11:03 +08:00
sairoutine
a77a83761f 📝 Japanese: add testing-on-headless-ci.md [ci skip] 2016-07-31 17:05:13 +09:00
Heilig Benedek
f3b723c9fa Send some more data with the cursor-changed event 2016-07-31 05:24:54 +02:00
Heilig Benedek
21962be60e Adds option to get raw data from NativeImage 2016-07-31 05:24:44 +02:00
Heilig Benedek
af80b9a7df Fixes not being able to send UTF8 characters anymore 2016-07-31 05:24:28 +02:00
Heilig Benedek
015516497c Merge pull request #13 from electron/master
update as upstream
2016-07-31 05:19:43 +02:00
Heilig Benedek
0a349ef16c remove fpscounter, can be enabled from node 2016-07-31 05:13:29 +02:00
Heilig Benedek
3e7ff466cd Merge branch 'speedup-gpu' of https://github.com/MaxWhere/electron into speedup-gpu 2016-07-31 05:12:34 +02:00
Heilig Benedek
3a1285aeac Send some more data with the cursor-changed event 2016-07-31 05:11:56 +02:00
Heilig Benedek
d0bda76a2d Adds option to get raw data from NativeImage 2016-07-31 05:11:18 +02:00
Heilig Benedek
94e52f0738 Fixes not being able to send UTF8 characters anymore 2016-07-31 05:10:14 +02:00
gellert
092fc92cb8 adds tutorial 2016-07-31 00:47:08 +02:00
gellert
f60d791fa8 adds docs for osr 2016-07-31 00:22:34 +02:00
gellert
e4000850cd head part updates 2016-07-30 21:35:14 +02:00
gellert
916063f370 handles destroyed renderer process 2016-07-30 21:25:49 +02:00
gellert
976277ffbf webcontentsview cleanup 2016-07-30 20:39:17 +02:00
gellert
6486d80f87 api impl + cleanups + stability improvements 2016-07-30 15:40:16 +02:00
Cheng Zhao
a769996b8d Merge pull request #6641 from electron/felix-macos-debugging
Add debugging instructions for macOS
2016-07-30 11:55:05 +09:00
gellert
2190c4dd8d adds destructors + more code cleanup 2016-07-30 00:51:19 +02:00
Heilig Benedek
70656dc991 revert framesubscription 2016-07-29 19:54:35 +02:00
Felix Rieseberg
ab69ae07b7 📝 Add debugging instructions for macOS
I already wrote up debugging instructions for Windows, but never got
around to writing them for macOS - until now! This adds a very basic
introduction to LLDB from the command line, which should empower people
to figure out what’s happening inside Electron when they call an
Electron method from JavaScript.
2016-07-29 10:19:58 -07:00
Cheng Zhao
67ef47104f Merge pull request #6649 from miniak/docs-fix
docs: fix argument types
2016-07-29 22:51:26 +09:00
gellert
6abf7475b8 cleaning up osr pt1 2016-07-29 14:50:27 +02:00
Milan Burda
e428d5db4f docs: fix argument types 2016-07-29 11:56:32 +02:00
Cheng Zhao
ea6e6dab8c Merge pull request #6644 from electron/webcontents-is-focused-crash
Check view before checking top level native window
2016-07-29 11:08:11 +09:00
Cheng Zhao
6bb342ef2a Merge pull request #6646 from electron/linux-200
Load 200 DPI resources on Linux
2016-07-29 11:07:23 +09:00
Cheng Zhao
5643feabc3 Load 200 DPI resources on Linux 2016-07-29 10:51:31 +09:00
Cheng Zhao
72612ed2f5 Merge pull request #6637 from electron/check-window-class
Check that window is an EventDispatchingWindow
2016-07-29 10:42:36 +09:00
Cheng Zhao
e5e4c53b1e Merge pull request #6645 from electron/ico-125
Update ico to include sizes for 125% DPI
2016-07-29 10:33:55 +09:00
Cheng Zhao
5e7ee675f7 Update ico to include sizes for 125% DPI 2016-07-29 10:32:48 +09:00
Cheng Zhao
8bf30ace4b Merge pull request #6636 from yuya-oc/docs-win32-icon
docs: Add recommended sizes for Windows ICO icons
2016-07-29 10:11:05 +09:00
Cheng Zhao
6d3120b05c Merge pull request #6626 from Starefossen/patch-1
docs: mention app ready event for DevTools Extension tutorial
2016-07-29 10:02:01 +09:00
Heilig Benedek
fdff60132c update brightray commit 2016-07-29 01:48:29 +02:00
Kevin Sawicki
5982e3a75e Fix typo in comment 2016-07-28 15:48:01 -07:00
Kevin Sawicki
bd2ce5327c Return early when render widget host view is null 2016-07-28 15:47:52 -07:00
Heilig Benedek
ab38e7700f brightray url update 2016-07-28 22:18:21 +02:00
Kevin Sawicki
5eaae8136e Check that window is an EventDispatchingWindow 2016-07-28 08:48:56 -07:00
Yuya Ochiai
29d66eb0d0 📝 Add recommended sizes for Windows ICO icons
For #6396
Please refer to https://msdn.microsoft.com/en-us/library/windows/desktop/dn742485(v=vs.85).aspx
[ci skip]
2016-07-28 23:22:41 +09:00
Heilig Benedek
7b61c5c9d0 removed some junk and added offscreen webcontents type 2016-07-28 12:10:56 +02:00
Cheng Zhao
b790ad6c1a Merge pull request #6631 from amor520/master
update Prerequisites
2016-07-28 18:07:33 +09:00
amor
46e707fd6d update Prerequisites 2016-07-28 15:01:36 +08:00
Cheng Zhao
e73bd00854 Merge pull request #6629 from electron/download-item-get-save-path
Set download item save path to selected path from dialog
2016-07-28 15:23:43 +09:00
Kevin Sawicki
55d6e0de1a Assert save path of download item 2016-07-27 17:52:36 -07:00
Kevin Sawicki
4e9b19074f Make downloadItem.getSavePath() public 2016-07-27 17:33:36 -07:00
Kevin Sawicki
0ad8c66b65 Use selected dialog path as item save path 2016-07-27 17:31:26 -07:00
Heilig Benedek
0dbe4bc417 api base 2016-07-28 01:58:23 +02:00
Cheng Zhao
bf20bbc247 Merge pull request #6623 from electron/shortcut
Add shell.writeShortcutLink/readShortcutLink APIs
2016-07-28 08:48:52 +09:00
Kevin Sawicki
34f33c3b45 Merge pull request #6627 from davej/patch-1
docs: Explain how to use highlightMode with BrowserWindow
2016-07-27 15:57:34 -07:00
DaveJ
42640b6170 docs: Add click handler to tray window example 2016-07-27 23:56:00 +01:00
DaveJ
322fe36dea docs: Fix undefined variables 2016-07-27 23:23:26 +01:00
Dave Jeffery
4823b5582f docs: Explain how to use highlightMode with BrowserWindow
As discussed on https://github.com/electron/electron/pull/6620
2016-07-27 21:35:13 +01:00
Hans Kristian Flaatten
ba2b8c8d3e docs: mention app ready event for DevTools Extension tutorial 2016-07-27 22:01:01 +02:00
gellert
c45d9555e7 cleans up class names 2016-07-27 20:31:03 +02:00
gellert
f90e62a7a5 apply fixes 2016-07-27 19:59:01 +02:00
gellert
6e1db86a77 fixes software output device rendering 2016-07-27 19:44:41 +02:00
Heilig Benedek
221714e141 added onpaint to software path 2016-07-27 19:19:53 +02:00
Heilig Benedek
783c9d9218 Merge branch 'speedup-gpu' of https://github.com/MaxWhere/electron into speedup-gpu 2016-07-27 18:25:28 +02:00
Heilig Benedek
da5c95710f software bump 2016-07-27 18:24:58 +02:00
gellert
d0bd4816cb adds tracing calls and osx fix 2016-07-27 18:02:54 +02:00
Heilig Benedek
a39bb35744 use electron nativewindow 2016-07-27 14:36:22 +02:00
Cheng Zhao
242ce4f818 Fix building on non-Windows 2016-07-27 19:55:05 +09:00
Cheng Zhao
ac8a490d56 Fix lint warnings 2016-07-27 19:51:16 +09:00
Cheng Zhao
eadffc6db8 docs: icon and iconIndex have to be set together 2016-07-27 19:49:17 +09:00
Cheng Zhao
57dbf284c1 spec: shell.writeShortcutLink/readShortcutLink 2016-07-27 19:43:11 +09:00
Cheng Zhao
d6234e11df docs: shell.writeShortcutLink/readShortcutLink 2016-07-27 16:47:24 +09:00
Cheng Zhao
ff5b8047a1 Throw exception when ReadShortcutLink failed 2016-07-27 16:32:32 +09:00
Cheng Zhao
25538fe7fb All fields are always returned 2016-07-27 16:23:35 +09:00
Cheng Zhao
60ba2d624e Initialize COM before using the API 2016-07-27 16:20:53 +09:00
Cheng Zhao
7f3443b138 Add shell.writeShortcutLink/readShortcutLink 2016-07-27 16:16:21 +09:00
Cheng Zhao
367f94aa76 Bump v1.3.1 2016-07-27 13:21:17 +09:00
Cheng Zhao
1e61743242 Merge pull request #6602 from electron/appusermodelid-remove-spaces
Remove all spaces from potential appUserModelID as it isn't allowed by the spec
2016-07-27 10:53:52 +09:00
Cheng Zhao
b8bafbc5a3 Merge pull request #6620 from electron/tray-highlight-toggle
Add option to always highlight the tray icon
2016-07-27 10:49:38 +09:00
Cheng Zhao
99b523176b Merge pull request #6619 from electron/web-contents-copy-image-at
Add webContents.copyImageAt(x, y)
2016-07-27 10:15:38 +09:00
Cheng Zhao
7994f087fb Merge pull request #6618 from electron/code-range-registration
Only register code range in Windows crash reporter once
2016-07-27 09:52:18 +09:00
Cheng Zhao
4dc8e90586 Merge pull request #6603 from electron/standard-markdown
Standardize JavaScript code snippets in the documentation
2016-07-27 09:36:44 +09:00
Cheng Zhao
0bfd31e7cb Update brightray for #6613 2016-07-27 08:53:55 +09:00
Cheng Zhao
b3530a55a9 Merge pull request #6613 from deepak1556/pref_init_patch
browser: initialize pref registry in brightray
2016-07-27 08:53:33 +09:00
Samuel Attard
9f0299cc31 Use better regex to match spaces 2016-07-27 09:38:49 +10:00
Kevin Sawicki
c4e743d207 Add TODO to deprecate boolean param 2016-07-26 14:18:15 -07:00
Kevin Sawicki
8e1de88512 Correct typo in variable name 2016-07-26 14:17:41 -07:00
Kevin Sawicki
0ff6b87f8c Update tray.setHighlightMode docs 2016-07-26 13:59:19 -07:00
Kevin Sawicki
b2f9cce297 Add option to always highlight the tray icon 2016-07-26 13:51:43 -07:00
Kevin Sawicki
31564f079f Document webContents.copyImageAt(x,y) 2016-07-26 12:08:05 -07:00
Kevin Sawicki
bde432b64d Add webContents.copyImageAt 2016-07-26 12:06:11 -07:00
Kevin Sawicki
7a1b796dd0 Change registered flag from InitBreakpad 2016-07-26 10:54:30 -07:00
Kevin Sawicki
3279f5c80a Add spec for starting crash reporter twice 2016-07-26 10:43:57 -07:00
Kevin Sawicki
8956388804 Only register code range once 2016-07-26 10:40:11 -07:00
Zeke Sikelianos
c3f26df577 standardize electron-capturer doc snippets 2016-07-26 09:49:02 -07:00
Zeke Sikelianos
c38f505001 update standard-markdown to use linux-friendly local require statements 2016-07-26 09:48:19 -07:00
Zeke Sikelianos
3a16a9b0bf update to standard-markdown with node 0.10 support 2016-07-26 09:48:19 -07:00
Zeke Sikelianos
784bee8faa update npm run lint to include docs 2016-07-26 09:48:19 -07:00
Zeke Sikelianos
06a354a2eb standardize all javascript blocks in English docs 2016-07-26 09:48:19 -07:00
Zeke Sikelianos
dd9935a9d7 add npm script to lint all javascript blocks in the docs using standard 2016-07-26 09:47:16 -07:00
gellert
8392ece321 updates impl to newer version of chromium 2016-07-26 16:52:43 +02:00
deepak1556
e65bc481a8 browser: initialize pref registry in brightray 2016-07-26 16:34:04 +05:30
Cheng Zhao
7c1f48808b Merge pull request #6612 from electron/cc-cxx
Do not overwrite CC and CXX in bootstrap
2016-07-26 19:55:25 +09:00
Cheng Zhao
7d11912a03 No more need to overwrite env when running update.py 2016-07-26 19:24:58 +09:00
Cheng Zhao
49181403ef Ignore CC and CXX in env 2016-07-26 19:24:28 +09:00
Cheng Zhao
0cdd764161 Merge pull request #6609 from electron/msvs
Add --msvs parameter to bootstrap.py
2016-07-26 19:03:25 +09:00
Cheng Zhao
89de791e9d docs: Mention the --msvs 2016-07-26 17:42:12 +09:00
Cheng Zhao
b34deb1d2f docs: x64 is the default build 2016-07-26 17:40:58 +09:00
Cheng Zhao
9bf3150237 Add --msvs parameter to bootstrap.py 2016-07-26 17:38:31 +09:00
Cheng Zhao
a4d983c236 Merge pull request #6607 from enlight/patch-4
Normalize string quotes in desktopCapturer docs
2016-07-26 16:29:01 +09:00
Cheng Zhao
61d16d5caa Merge pull request #6606 from electron/font-settings
Set page's font settings with system settings
2016-07-26 14:11:20 +09:00
Vadim Macagon
6cc68638e7 Normalize string quotes in desktopCapturer docs
Missed one string in my previous PR :(
2016-07-26 11:57:39 +07:00
Cheng Zhao
2b0cd97bb8 Merge pull request #6593 from enlight/improved-desktop-capturer-docs
Improve readability, and add a link to the navigator.getUserMedia API
2016-07-26 13:35:54 +09:00
Cheng Zhao
d2ce50e3dd c++11 styling 2016-07-26 13:32:17 +09:00
Cheng Zhao
0da1a772be Set page's font settings with system settings 2016-07-26 13:29:27 +09:00
Vadim Macagon
89309244b5 Improve the desktopCapturer docs
Made minor improvements to readability, and added a link to the
`navigator.getUserMedia` docs on MDN for convenience.
2016-07-26 10:48:38 +07:00
Cheng Zhao
8d941a6559 Merge pull request #6566 from electron/win-autoupdater-es6
Move autoUpdater to ES6
2016-07-26 12:46:00 +09:00
Cheng Zhao
b139d5ad1c Merge pull request #6598 from electron/fs-access-asar
Add asar implementation of fs.access/accessSync
2016-07-26 12:42:59 +09:00
Cheng Zhao
7b6d74fdc2 Merge pull request #6596 from liusy182/restore-issue
Window position doesn't restore correctly minimize and restore window
2016-07-26 11:21:59 +09:00
Cheng Zhao
c70ec47138 Merge pull request #6595 from lukeapage/patch-8
Clarify the default arguments for Menu popup
2016-07-26 11:16:57 +09:00
Samuel Attard
12dba2cb67 Remove all spaces from potential appUserModelID as it isn't allowed by the spec 2016-07-26 11:44:01 +10:00
Samuel Attard
20e26a9639 Move auto-updater-win to ES6 2016-07-26 11:40:55 +10:00
Kevin Sawicki
c730800f0c Merge pull request #6601 from feross/master
Fix test for PR #6600
2016-07-25 17:45:50 -07:00
Feross Aboukhadijeh
9bc144c880 Fix test for PR #6600
Just realized that the tests don't pass after my PR. This fixes that :)
2016-07-25 17:27:45 -07:00
Kevin Sawicki
8c7d28de27 Merge pull request #6600 from feross/master
MenuItem: Use 'Close Window' for 'close' role label
2016-07-25 15:21:05 -07:00
Feross Aboukhadijeh
d6a7ced32c MenuItem: Use 'Close Window' for 'close' role label
On OS X, the standard label that's used for the 'close' role is 'Close
Window'. You can see this in the default macOS apps from Apple.
2016-07-25 15:13:17 -07:00
gellert
9d83ce1676 resolves 2016-07-25 21:09:49 +02:00
Kevin Sawicki
b627b8711a Add spec for accessing normal files 2016-07-25 11:17:40 -07:00
Kevin Sawicki
8eca019157 Support paths as Buffers 2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970 Add asar-supported fs.accessSync implementation 2016-07-25 11:05:18 -07:00
gellert
8fb7872b84 removes logs and adds webcontentsview init 2016-07-25 19:58:21 +02:00
gellert
0ad0c79202 adds beginframe scheduling 2016-07-25 19:58:14 +02:00
Kevin Sawicki
3ad5504194 Add asar-supported fs.access implementation 2016-07-25 10:50:30 -07:00
gellert
9e10f211d7 removes commented includes 2016-07-25 19:44:44 +02:00
gellert
8090278708 breaks down osr api to separate files 2016-07-25 19:44:44 +02:00
gellert
14836cef02 using damage_rect 2016-07-25 19:44:44 +02:00
gellert
96e1ba9c14 gpu acclereted osr added 2016-07-25 19:44:44 +02:00
Heilig Benedek
5371921f8a speed(up) bump 2016-07-25 19:44:44 +02:00
Heilig Benedek
4a0f0063a0 speedup base 2016-07-25 19:44:44 +02:00
Kevin Sawicki
a518c47f4c Use let/const instead of var 2016-07-25 10:43:38 -07:00
liusi
8129c27a4a Merge branch 'master' of https://github.com/electron/electron into restore-issue 2016-07-25 22:53:18 +08:00
liusi
2cc01eea30 issue 6574 - Window position doesn't restore correctly 2016-07-25 22:51:27 +08:00
gellert
6eba509d53 removes logs and adds webcontentsview init 2016-07-25 15:55:00 +02:00
Luke Page
c365aa85c2 Clarify the default arguments for popup
The null / -1 defaults weren't very helpful, so changed to follow other documentation and write the behaviour if that param is missing.
2016-07-25 13:57:38 +02:00
Cheng Zhao
729b84f2ca Merge pull request #6576 from electron/browser-window-proxy-docs
Fix BrowserWindowProxy documentation
2016-07-25 16:55:49 +09:00
Cheng Zhao
66086880e2 Merge pull request #6575 from electron/asar-doc-fixes
fix wording in asar doc
2016-07-25 16:55:20 +09:00
Cheng Zhao
a30997867f Merge pull request #6573 from electron/native-image-doc
Fix documentation for NativeImage
2016-07-25 16:55:09 +09:00
Cheng Zhao
72c4952907 Merge pull request #6590 from electron/reliable-typed-array
Use ArrayBuffer.isView to detect Buffer and ArrayBuffer
2016-07-25 16:54:54 +09:00
Cheng Zhao
7a61966423 Use deepEqual for comparing type arrays 2016-07-25 16:41:20 +09:00
Cheng Zhao
9ddb62c42a Use Buffer.from instead of deprecated new Buffer 2016-07-25 16:40:22 +09:00
Cheng Zhao
1c9421bc89 Use ArrayBuffer.isView to detect Buffer and ArrayBuffer 2016-07-25 16:39:09 +09:00
Cheng Zhao
eb51e080e5 spec: TypeArray should work in remote 2016-07-25 16:30:40 +09:00
Cheng Zhao
200d09cc70 Merge pull request #6572 from haadcode/master
Add support for TypedArrays in IPC.
2016-07-25 16:22:29 +09:00
Cheng Zhao
fb251ac09b Update brightray for #6156 2016-07-25 16:08:38 +09:00
Cheng Zhao
e95da6ad1b Merge pull request #6565 from TiagoDanin/Update-Doc
Update docs-translations
2016-07-25 16:05:04 +09:00
Cheng Zhao
fd8cc63ca9 Merge pull request #6558 from deepak1556/session_proxy_patch
session: add proxyBypassRules option to setProxy api
2016-07-25 16:03:50 +09:00
Cheng Zhao
c497765dea Merge pull request #6524 from liusy182/painted-event-6426
add "view-painted" event to WebContent.
2016-07-25 16:02:50 +09:00
Cheng Zhao
c0f81d14e4 Bump v1.3.0 2016-07-25 12:57:10 +09:00
Cheng Zhao
4af72617ee Merge pull request #6589 from electron/200-resources
Load a few resources pak added in Chrome 52
2016-07-25 12:54:45 +09:00
Cheng Zhao
b013abf829 Copy a few more files to out dir 2016-07-25 12:11:01 +09:00
Cheng Zhao
221f53ab08 Load a few more pak files 2016-07-25 11:10:53 +09:00
Cheng Zhao
f4207560f2 Update libchromiumcontent: fix linking error on Linux 2016-07-25 08:53:58 +09:00
Cheng Zhao
f09fc2f6e9 Merge pull request #6585 from electron/win-release
Do not export symbols of OpenSSL on Windows
2016-07-24 22:23:19 +09:00
Cheng Zhao
e8c03f2555 Do not export symbols of OpenSSL on Windows 2016-07-24 21:56:16 +09:00
Cheng Zhao
ed14f661dd Merge pull request #6584 from electron/fix-ci
Do not throw exception when channel name is "error"
2016-07-24 21:55:11 +09:00
Cheng Zhao
751ee53683 Do not throw exception when channel name is "error" 2016-07-24 21:08:25 +09:00
haad
fac330fb50 Fix TypedArray check, add check when instanceof doesn't work for TypedArrays. 2016-07-23 12:43:49 +01:00
haad
2757046e71 Add isTypedArray to Electron exports 2016-07-23 11:30:14 +01:00
Zeke Sikelianos
a2ffab40f9 use an instance-variable-style name for BrowserWindowProxy 2016-07-22 15:00:10 -07:00
Zeke Sikelianos
3a9c57231e fix wording in asar doc 2016-07-22 14:52:43 -07:00
Zeke Sikelianos
9432cb9170 use standard-style javascript in nativeImage doc 2016-07-22 13:47:05 -07:00
Zeke Sikelianos
9ca0fbaeb7 fix capitalization and headings for NativeImage class 2016-07-22 13:42:27 -07:00
haad
e6c8900a18 Fix linting 2016-07-22 20:20:24 +01:00
haad
c717cd9192 🐛 Add support for TypedArrays in IPC.
Fixes https://github.com/electron/electron/issues/2104.
2016-07-22 19:44:19 +01:00
Cheng Zhao
99ec841a8e Merge pull request #6342 from electron/chrome52
Upgrade to Chrome 52
2016-07-22 08:53:33 -06:00
Cheng Zhao
0c1d91a895 display.h needs to be used together with screen.h 2016-07-22 23:37:20 +09:00
gellert
81be0bc123 adds beginframe scheduling 2016-07-22 13:55:58 +02:00
TiagoDanin
c7c6dda122 Replace OSX to macOS and Update references 2016-07-21 16:07:03 -05:00
Cheng Zhao
cf6f4708bc Fix building on Windows 2016-07-21 11:20:43 -06:00
Kevin Sawicki
7bcd76aa93 Merge pull request #6562 from liusy182/hasImageContents
fix documentation error pointed out in issue #6541
2016-07-21 10:38:22 -06:00
liusy182
6e83f454d7 documentation error pointed out in issue #6541 2016-07-21 22:46:46 +08:00
Cheng Zhao
6850500a65 Fix building on Linux 2016-07-21 07:09:01 -06:00
Cheng Zhao
0fa4e58557 Bump node module version 2016-07-21 06:32:29 -06:00
Cheng Zhao
d22dc6c7d3 Update to Chrome 52.0.2743.82 2016-07-21 06:07:05 -06:00
Cheng Zhao
f6f7b41f0a Fix compilation error after merge 2016-07-21 06:03:38 -06:00
Cheng Zhao
b57665330c Merge branch 'master' into chrome52 2016-07-21 05:34:36 -06:00
Cheng Zhao
50b6b500fd Merge pull request #6557 from LittleboyHarry/patch-1
Translate the comments
2016-07-21 04:55:56 -06:00
Cheng Zhao
9cdc74e431 Merge pull request #6559 from electron/node-6-3
Update to Node.js 6.3.0
2016-07-21 03:28:37 -06:00
Cheng Zhao
fbfae70803 spec: Fix exception when refreshing test window 2016-07-21 17:08:43 +09:00
Cheng Zhao
39bd2bee8e Avoid using CHECK in files using node headesr
Node has its own CHECK macro which requires linking with node::Assert.
2016-07-21 16:56:48 +09:00
Cheng Zhao
cef86f5257 Use node::FreeEnvironment 2016-07-21 16:43:21 +09:00
Cheng Zhao
334f03fc42 Fix compilation errors on Windows 2016-07-21 16:36:50 +09:00
Cheng Zhao
5fc0201ca1 There is no node_extern.h anymore 2016-07-21 16:36:31 +09:00
Cheng Zhao
8488b84b53 Update .node-version 2016-07-21 01:17:07 -06:00
Cheng Zhao
567714f07c Add a few new node defines 2016-07-21 00:57:34 -06:00
Cheng Zhao
39e39ae913 Make use of some new Node config flags 2016-07-21 00:57:34 -06:00
Cheng Zhao
7d42797c1f Update node headers including 2016-07-21 00:57:34 -06:00
Cheng Zhao
8f5bd4afaf Update to Node 6.3.0 2016-07-21 00:57:34 -06:00
Cheng Zhao
498e9089b3 Bump v1.2.8 2016-07-20 23:57:08 -06:00
deepak1556
aa6d79a3d8 session: add proxyBypassRules option to setProxy api 2016-07-21 10:14:54 +05:30
Harry
9b12cf75ec Translate the comments 2016-07-21 10:37:55 +08:00
Cheng Zhao
a0c5749ac1 Merge pull request #6547 from electron/update-web-view-docs
docs: Update nodeintegration of web-view-tag.md
2016-07-20 05:18:47 -06:00
Cheng Zhao
99524bf490 Merge pull request #6540 from mattslay/patch-1
Update file-object.md
2016-07-20 05:13:43 -06:00
Cheng Zhao
e9e67179c3 docs: Update nodeintegration of web-view-tag.md
webview is now disabled when nodeIntegration is off.
2016-07-20 05:13:05 -06:00
Cheng Zhao
81c790dfdb Merge pull request #6529 from darkdh/serial_number
serial number in hex string
2016-07-20 05:00:57 -06:00
gellert
504c79cae7 removes commented includes 2016-07-20 11:32:59 +02:00
gellert
84a5c50b62 breaks down osr api to separate files 2016-07-20 11:30:06 +02:00
Matt Slay
0e24d148fd Update file-object.md
Added a for loop to iterate over the array of files, which allows processing of multiple files being dropped over the "holder" div.
2016-07-19 23:51:58 -05:00
gellert
7fc9df4f8f using damage_rect 2016-07-19 23:50:49 +02:00
Anthony Tseng
9e6f623a5c Using base::HexEncode() 2016-07-19 11:06:56 +08:00
Anthony Tseng
42eb0c3eae serial number in hex string 2016-07-18 23:42:42 +08:00
Cheng Zhao
4081381700 Merge pull request #6527 from electron/mac-relaunch
Apply #6412 on macOS
2016-07-18 09:00:36 -06:00
Cheng Zhao
1a0199c2ad Merge pull request #6520 from MagiCarbon/master
error link
2016-07-18 08:49:13 -06:00
Cheng Zhao
2ed733fedc Redirect relaunch process's stdout to /dev/null 2016-07-18 08:46:01 -06:00
gellert
50dc71d1c2 gpu acclereted osr added 2016-07-18 16:16:23 +02:00
liusi
d335d7d706 add "view-painted" event to WebContent. 2016-07-18 14:54:52 +08:00
Moriarty!~~
d10323b057 error link
> `[security introduction](../tutorial/security.md)`.
it should be `[security introduction](tutorial/security.md)`
2016-07-17 09:22:53 +08:00
Cheng Zhao
08491e1ceb Merge pull request #6511 from electron/more-docs-cleanup
Clean up API Docs
2016-07-16 09:57:04 +09:00
Kevin Sawicki
12cb678562 Merge pull request #6510 from electron/reset-thumbnail-docs
Mention how to reset thumbnail to entire window
2016-07-15 10:40:32 -07:00
Kevin Sawicki
e24885b160 Mention how to reset thumbnail to entire window 2016-07-15 10:38:11 -07:00
Kevin Sawicki
efcdad2751 Merge pull request #6509 from electron/brightray-devtools-focus-fix
Upgrade brightray for undocked devtools focus fix
2016-07-15 10:17:59 -07:00
Kevin Sawicki
e15d7a1fd3 Upgrade brightray for undocked devtools focus fix 2016-07-15 09:21:08 -07:00
Cheng Zhao
4d46189928 Fix cpplint warnings 2016-07-15 22:47:40 +09:00
Cheng Zhao
43b5e655a4 Merge pull request #6502 from liusy182/optional-callback-6491
Make the callback of session.clearStorageData optional
2016-07-15 22:45:49 +09:00
liusi
154daa8d6a make Session::ClearStorageData's callback optional 2016-07-15 14:13:56 +08:00
Cheng Zhao
9eacd07eda Merge pull request #6489 from electron/webcontents-static-api
Document static methods on webContents
2016-07-15 11:02:00 +09:00
Cheng Zhao
2791f71c03 webContents is now a public module 2016-07-15 10:59:19 +09:00
Cheng Zhao
52808d5342 Merge pull request #6499 from electron/drop-vista
Remove implicit references to Vista in docs
2016-07-15 10:20:14 +09:00
Cheng Zhao
d186a01815 Merge pull request #6497 from electron/windows-thumbnail
Add setThumbnailClip API on Windows
2016-07-15 10:18:39 +09:00
Cheng Zhao
5db758297f Merge pull request #6486 from MarshallOfSound/master
Add a getFeedURL API for the autoUpdater
2016-07-15 10:02:05 +09:00
Kevin Sawicki
297365b4f0 Add require example for webContents 2016-07-14 17:54:18 -07:00
Kevin Sawicki
4de4774325 Update headings/sections to follow docs styleguide 2016-07-14 17:46:58 -07:00
Cheng Zhao
7c56169633 Merge pull request #6495 from electron/link-to-boilerplates
link to boilerplates
2016-07-15 09:44:29 +09:00
Cheng Zhao
c3ed4b5527 Merge pull request #6493 from electron/elecron-devtools-installer
mention electron-devtools-installer as an alternative
2016-07-15 09:44:01 +09:00
Kevin Sawicki
1aa645522a Remove implicit references to Vista 2016-07-14 17:33:48 -07:00
Cheng Zhao
16e43a7f15 Merge pull request #6490 from wilsonpage/add-drop-text-support
Add support for dropped text in osx
2016-07-15 09:12:35 +09:00
Cheng Zhao
3ace677b41 Merge pull request #6474 from darkdh/cert_detail
Add more detail attributes for certificate-error
2016-07-15 08:45:36 +09:00
Zeke Sikelianos
7700c5e249 denote return type on process memory info methods methods 2016-07-14 16:10:19 -07:00
Zeke Sikelianos
595b827a13 Use common style to denote OS-specific arguments 2016-07-14 16:09:29 -07:00
Kevin Sawicki
f4a160d0fb Add properties as sub-list 2016-07-14 16:02:06 -07:00
Kevin Sawicki
ccee3e1fc2 Document setThumbnailClip 2016-07-14 15:54:57 -07:00
Kevin Sawicki
86218fe773 win: Add setThumbnailClip window API 2016-07-14 15:50:31 -07:00
Samuel Attard
450c181da3 Add autoUpdater getFeedURL specs 2016-07-15 10:13:41 +12:00
Samuel Attard
d42e6b3c1f Fix casing issue on the windows update JS file 2016-07-15 10:05:36 +12:00
Zeke Sikelianos
ee677ea212 link to boilerplates 2016-07-14 14:57:06 -07:00
Zeke Sikelianos
52a2ed9205 fix typo 2016-07-14 14:16:02 -07:00
Zeke Sikelianos
f857be431a mention electron-devtools-installer as an automated alternative 2016-07-14 14:12:06 -07:00
Wilson Page
90f8a7e828 Add support for dropped text in osx 2016-07-14 18:25:58 +01:00
Kevin Sawicki
a4001fbc55 Sort contents by id for consistent ordering 2016-07-14 09:41:10 -07:00
Kevin Sawicki
34f454a0f5 Use let and const 2016-07-14 09:33:16 -07:00
Kevin Sawicki
d9e15151fb Use getCurrentWebContents() 2016-07-14 09:25:59 -07:00
Kevin Sawicki
446e3f06c9 Add spec for webContents.getFocusedWebContents() 2016-07-14 09:17:16 -07:00
Kevin Sawicki
ebdf8e1fa1 Add initial webContents spec 2016-07-14 09:10:40 -07:00
Kevin Sawicki
c680c0b85e Document static webContents methods 2016-07-14 09:00:29 -07:00
Kevin Sawicki
a7badd43d5 Expose getAllWebContents() API 2016-07-14 08:59:49 -07:00
Samuel Attard
84a8c393a8 Fix linting, removes additional semicolon 2016-07-15 00:29:53 +12:00
Samuel Attard
fa7526202b Remove unnecessary method 2016-07-15 00:13:04 +12:00
Samuel Attard
b367c65bcd Add docs for getFeedURL 2016-07-15 00:07:17 +12:00
Samuel Attard
51687e1bc9 Add the getFeedURL API for macOS and Windows 2016-07-15 00:04:48 +12:00
Anthony Tseng
02e89d60f1 Use CalculateFingerprint256() 2016-07-14 19:09:11 +08:00
Cheng Zhao
ba887dbde7 Merge pull request #6482 from deepak1556/webcontents_navigation_obs_patch
webcontents: replace deprecated navigation observers
2016-07-14 12:57:26 +09:00
Cheng Zhao
21a2feaf23 Merge pull request #6480 from electron/webcontents-focus
Execute role-based menu items on focused web contents
2016-07-14 12:47:07 +09:00
Cheng Zhao
183b599b9c Merge pull request #6470 from electron/session-options
Ad options for creating Session
2016-07-14 12:07:39 +09:00
deepak1556
c8bf6edcc6 webcontents: replace deprecated navigation observers 2016-07-14 06:47:38 +05:30
Kevin Sawicki
72cdba2b8e 🎨 2016-07-13 14:49:25 -07:00
Kevin Sawicki
e1459b7db7 Doc webContents.isFocused 2016-07-13 14:20:33 -07:00
Kevin Sawicki
d8eb8f4007 Sort filenames 2016-07-13 14:18:41 -07:00
Kevin Sawicki
f9a8bd3ea5 Call role method on focused web contents 2016-07-13 14:16:56 -07:00
Kevin Sawicki
06e595e7cc Add webContents.getFocusedWebContents() 2016-07-13 14:16:56 -07:00
Kevin Sawicki
7877fa7c0a Add webContents.isFocused() 2016-07-13 14:16:56 -07:00
Kevin Sawicki
5d95b544dd Merge pull request #6476 from AndrewTsao/patch-1
fix a typo.
2016-07-13 09:41:10 -07:00
andi
7807310c02 fix a typo. 2016-07-14 00:37:55 +08:00
Heilig Benedek
6e25aea49f speed(up) bump 2016-07-13 17:43:00 +02:00
Anthony Tseng
db39867ad9 Add more detail attributes for certificate-error 2016-07-13 22:14:47 +08:00
Cheng Zhao
6d2e633c82 Merge pull request #6469 from abdihaikal/master
Add electron-id.slack.com for Indonesia
2016-07-13 17:24:28 +09:00
Cheng Zhao
1faa567d09 Merge pull request #6467 from electron/enforce-new-docs-styleguide
Update documentation guidelines for Classes
2016-07-13 16:41:13 +09:00
Cheng Zhao
41d2799514 Run background pages in separate partition
This avoids the default partition always being created on startup, so it
gives users a chance to run session.fromParititon.
2016-07-13 16:22:55 +09:00
Abdi Haikal
de352f71cb Add electron-id.slack.com for Indonesia 2016-07-13 14:07:46 +07:00
Zeke Sikelianos
9b1d1dc2c7 clarify rules for documenting classes 2016-07-12 22:00:28 -07:00
Zeke Sikelianos
4905d30dd6 fix heading levels on BrowserWindowProxy 2016-07-12 21:57:07 -07:00
Zeke Sikelianos
5ab4fd261c 🎨 2016-07-12 21:50:43 -07:00
Zeke Sikelianos
b20606c718 fix heading levels in Menu doc 2016-07-12 21:47:28 -07:00
Zeke Sikelianos
2486512c71 use h3/h4 for instance headings and children 2016-07-12 21:42:08 -07:00
Zeke Sikelianos
f8045fd743 💄 2016-07-12 21:40:46 -07:00
Cheng Zhao
749ed3473b spec: Fix js lint warning 2016-07-13 13:34:19 +09:00
Zeke Sikelianos
6d8a6e6471 use consistent wording for instances 2016-07-12 21:30:27 -07:00
Zeke Sikelianos
a304a59d36 use h3/h4 for static method headings and methods 2016-07-12 21:29:09 -07:00
Zeke Sikelianos
fff036b6ab distinguish static methods from module methods 2016-07-12 21:28:27 -07:00
Zeke Sikelianos
a08ee97fb0 use h3/h4 for instance events headings and events 2016-07-12 21:24:22 -07:00
Zeke Sikelianos
67dbff1d4a events -> instance events 2016-07-12 21:22:54 -07:00
Zeke Sikelianos
e866c68938 📝 minor style changes and typos 2016-07-12 21:21:25 -07:00
Cheng Zhao
e653c67153 Move chromeExtensionHandler out of ready handler
This code were in ready handler because we could not require "protocol"
before ready before. It is now safe to move the code out.
2016-07-13 12:23:14 +09:00
Cheng Zhao
6db75a3458 Fix building on Linux 2016-07-13 12:23:14 +09:00
Cheng Zhao
fd73279d16 spec: Test lifetime of sessions returned by session.fromPartition 2016-07-13 12:23:14 +09:00
Cheng Zhao
62153f4117 spec: Name of tests should match docs 2016-07-13 12:23:14 +09:00
Cheng Zhao
3ce3004595 spec: session.defaultSession test case 2016-07-13 12:23:14 +09:00
Cheng Zhao
e7666b0448 docs: options of session.fromPartition 2016-07-13 12:23:14 +09:00
Cheng Zhao
753e92c845 Add cache option for session 2016-07-13 12:23:14 +09:00
Cheng Zhao
e213e09c3e Add options to session.fromPartition 2016-07-13 12:23:14 +09:00
Cheng Zhao
00804e5f98 Move the ability to create BrowserContext to embedder 2016-07-13 12:23:14 +09:00
Cheng Zhao
400bb8d0f3 Hide in_memory parameter in native interface 2016-07-13 12:23:14 +09:00
Cheng Zhao
06a41cedab Move check of isReady to native code 2016-07-13 12:23:14 +09:00
Cheng Zhao
d739d8772c Move session-created event to app
This follows the convention of other *-created events.
2016-07-13 12:23:14 +09:00
Cheng Zhao
45500701f1 Do not access default session before app is ready 2016-07-13 12:23:14 +09:00
Cheng Zhao
fcd3357fb8 Use Proxy to provide protocol APIs
In this way we can avoid initializing defaultSession when protocol
module is used.
2016-07-13 12:23:14 +09:00
Cheng Zhao
4ebb83e999 Move the warning of registerStandardSchemes to native code 2016-07-13 12:23:14 +09:00
Cheng Zhao
13e1818bf7 Bump v1.2.7 2016-07-13 12:22:42 +09:00
Cheng Zhao
e96d7a5fd9 Merge pull request #6466 from electron/cert-verifier-io-thread
Create AtomCertVerifier on IO thread
2016-07-13 12:22:17 +09:00
Cheng Zhao
e5ccb3fd5d Remove lock in AtomCertVerifier 2016-07-13 12:07:57 +09:00
Cheng Zhao
24c60019b7 Create AtomCertVerifier on IO thread 2016-07-13 12:05:57 +09:00
Cheng Zhao
12d646a48b Merge pull request #6459 from electron/devtools-context-menu
Add edit menu items to editable elements in dev tools
2016-07-13 10:43:48 +09:00
Cheng Zhao
606931d737 Merge pull request #6455 from electron/use-current-content-constraints
Initialize new size constraints to current constraints
2016-07-13 10:14:33 +09:00
Kevin Sawicki
181b8d799e Add spec for min/max window size 2016-07-12 16:36:25 -07:00
Kevin Sawicki
15f7dc6609 Initialize to constraints to current constraints 2016-07-12 16:36:25 -07:00
Kevin Sawicki
e02cf5905c Execute command on devtools web contents when focused 2016-07-12 13:24:53 -07:00
Kevin Sawicki
fa36d2e8c6 Add standard edit items to text context menus 2016-07-12 11:54:45 -07:00
Kevin Sawicki
63b98b1ea0 Use const instead of var 2016-07-12 11:31:40 -07:00
Kevin Sawicki
d3e63777cb Merge pull request #6457 from preco21/document-fixes-6
docs: Small document fixes
2016-07-12 11:08:28 -07:00
Plusb Preco
9ea4039887 📝 Fix grammatical typo
[ci skip]
2016-07-13 03:02:14 +09:00
Kevin Sawicki
2f17c0ba74 Merge pull request #6456 from preco21/korean-docs-10
docs: Update Korean docs as upstream
2016-07-12 10:59:38 -07:00
Plusb Preco
039aebb74a 📝 Fix isolated link
[ci skip]
2016-07-13 02:59:29 +09:00
Plusb Preco
19765e70cf 📝 Fix typo
[ci skip]
2016-07-13 02:57:11 +09:00
Plusb Preco
797aef60ee 📝 Update Korean docs as upstream
[ci skip]
2016-07-13 02:53:26 +09:00
Kevin Sawicki
d842604d16 Merge pull request #6444 from electron/windows-login-items
Implement login item API on Windows
2016-07-12 10:26:02 -07:00
Plusb Preco
56e679632f 📝 Update Korean docs as upstream
[ci skip]
2016-07-13 01:12:04 +09:00
Kevin Sawicki
afd5e51d6a Add Browser namespace 2016-07-12 09:10:48 -07:00
Kevin Sawicki
66d16b2871 Add Windows label to login items settings API 2016-07-12 09:10:48 -07:00
Kevin Sawicki
64513f8c69 Enable login item spec on Windows 2016-07-12 09:10:47 -07:00
Kevin Sawicki
3d358ee7ea Fix Windows compilation issues 2016-07-12 09:10:47 -07:00
Kevin Sawicki
af907163a2 Enable LoginItemSettings converter on all platforms 2016-07-12 09:10:47 -07:00
Kevin Sawicki
5a36c5596c Add initial windows login item implementation 2016-07-12 09:10:47 -07:00
Kevin Sawicki
64f9c6a1d7 Add get/setLoginItemSettings on all platforms 2016-07-12 09:10:47 -07:00
Cheng Zhao
230b4ac241 Merge pull request #6449 from electron/10.9-transparent
Fix transparent window having border on OS X 10.9
2016-07-12 15:25:37 +09:00
Cheng Zhao
3335792200 Remove some unneeded hacks for old OS X versions 2016-07-12 15:15:47 +09:00
Cheng Zhao
2ee8142136 Fix transparent window having border on OS X 10.9 2016-07-12 15:01:37 +09:00
Cheng Zhao
056166ea17 Merge pull request #6448 from electron/tray-next-tick
Destroy the native tray in next tick
2016-07-12 14:55:34 +09:00
Cheng Zhao
5a604f8e79 Destroy the native tray in next tick 2016-07-12 14:23:38 +09:00
Cheng Zhao
3eaa32fc87 Merge pull request #6447 from ellerbrock/broken-link-fix
fix broken link
2016-07-12 11:01:52 +09:00
Cheng Zhao
df0d2b89cd Merge pull request #6446 from electron/accessibility-api
Add API for Chrome's accessibility support state
2016-07-12 10:59:12 +09:00
Cheng Zhao
21a8a727f8 Merge pull request #6442 from electron/circular-references
Maintain stack of visited objects for cycle detection
2016-07-12 10:39:16 +09:00
Cheng Zhao
53440e8993 Merge pull request #6441 from miniak/remove-windows-vista-check
Remove unnecessary >= Windows Vista check
2016-07-12 10:33:29 +09:00
Maik Ellerbrock
01cb024f44 fix broken link
fixed broken link "how to share data between web pages" in section "Differences Between Main Process and Renderer Process"
2016-07-12 07:31:18 +08:00
Kevin Sawicki
4e22d5dd8a Add missing typeof 2016-07-11 14:48:48 -07:00
Kevin Sawicki
f5d371e180 Remove linter warnings 2016-07-11 14:46:28 -07:00
Kevin Sawicki
131bff48ea IsAccessibilitySupportEnabled -> isAccessibilitySupportEnabled 2016-07-11 14:44:32 -07:00
Kevin Sawicki
46a1e0382d Document accessibility support API 2016-07-11 14:41:35 -07:00
Kevin Sawicki
67b647322f Add spec to verify app.isAccessibilitySupportEnabled return type 2016-07-11 14:32:24 -07:00
Kevin Sawicki
34f7ddec9f Update API to isAccessibilitySupportEnabled 2016-07-11 14:32:14 -07:00
Kevin Sawicki
3fcbac78ac Implement accessiblity change events on Windows 2016-07-11 14:23:25 -07:00
Kevin Sawicki
68d7ae75b0 Implement accessiblity change events on mac 2016-07-11 14:09:01 -07:00
Kevin Sawicki
fc36ac8c1b Add API for accessibility state and changes 2016-07-11 14:04:56 -07:00
Kevin Sawicki
1a080266c5 Merge pull request #6443 from robertfirespotter/patch-1
Fix link to locales.md
2016-07-11 12:09:30 -07:00
Robert D
2d40ced3be Fix link to locales.md 2016-07-11 11:37:22 -07:00
Kevin Sawicki
2d9391f7d7 Add more cycle tests 2016-07-11 10:49:23 -07:00
Kevin Sawicki
00f82aaffe Only check arrays and objects for cycles 2016-07-11 10:39:45 -07:00
Kevin Sawicki
bd58e1b2c3 Remove linter errors 2016-07-11 10:33:13 -07:00
Kevin Sawicki
564b0cace5 Maintain visted objects as a stack for cycle detection 2016-07-11 10:33:13 -07:00
Kevin Sawicki
71a8bac12a Add more failing circular reference specs 2016-07-11 10:33:13 -07:00
Kevin Sawicki
5da0b856f9 Call includes directly on visited array 2016-07-11 10:33:13 -07:00
Kevin Sawicki
2cc2b8a146 Return empty array for circular references 2016-07-11 10:33:04 -07:00
Kevin Sawicki
ab1786c17d Add spec for circular array/object references 2016-07-11 09:52:50 -07:00
Milan Burda
38016b8144 Remove unnecessary >= Windows Vista check 2016-07-11 18:23:33 +02:00
Cheng Zhao
b06e6e9ce5 Merge pull request #6438 from develar/patch-2
docs: electron-userland package tools links
2016-07-11 20:12:59 +09:00
Vladimir Krivosheev
d824e3a959 docs: electron-userland package tools links
`electron-packager` and `electron-builder` now in the `electron-userland` github org — links fixed.
2016-07-11 13:05:02 +02:00
Cheng Zhao
6164139167 Merge pull request #6436 from electron/open-external-string16
win: Fix openExternal not working with non-ASCII characters
2016-07-11 17:31:17 +09:00
Cheng Zhao
5208bbd2e8 Remove unneeded include 2016-07-11 17:13:21 +09:00
Cheng Zhao
86338290fb win: Fix openExternal not working with non-ASCII characters 2016-07-11 17:12:11 +09:00
Cheng Zhao
5abe726678 Merge pull request #6434 from electron/fullscreen-set-bounds
mac: Do not change window size when in fullscreen
2016-07-11 17:11:51 +09:00
Cheng Zhao
31e67788a2 mac: Do not change window size when in fullscreen 2016-07-11 16:44:42 +09:00
Cheng Zhao
381366daf1 Fix indention 2016-07-11 16:43:01 +09:00
Cheng Zhao
70a29bd46a Merge pull request #6433 from electron/fullscreen-button
The fullscreen button should always be hidden for frameless window
2016-07-11 16:23:10 +09:00
Cheng Zhao
db8787fce1 The fullscreen button should always be hidden for frameless window 2016-07-11 16:00:29 +09:00
Cheng Zhao
2220534df3 Merge pull request #6432 from electron/global-unresponsive-suppresser
Suppress the unresponsive event globally
2016-07-11 15:45:36 +09:00
Cheng Zhao
8269e7b1ef Suppress unresponsive event when showing menu 2016-07-11 15:31:24 +09:00
Cheng Zhao
7848608198 Replace DialogScope with UnresponsiveSuppressor
The latter is global-wide.
2016-07-11 15:29:03 +09:00
Cheng Zhao
c58bddffe3 Update brightray for #2565 2016-07-11 15:10:43 +09:00
Cheng Zhao
d5a7b3b7fd Merge pull request #6431 from electron/show-hidden-files
Add showHiddenFiles property for dialog.showOpenDialog
2016-07-11 14:58:33 +09:00
Cheng Zhao
26fe38a296 docs: showHiddenFiles 2016-07-11 13:52:44 +09:00
Cheng Zhao
fc72df3ba1 win: Use FOS_FORCESHOWHIDDEN for showHiddenFiles 2016-07-11 13:49:51 +09:00
Cheng Zhao
6e0fadbe26 gtk: Set show-hidden property for showHiddenFiles 2016-07-11 13:47:24 +09:00
Cheng Zhao
f08ac07737 mac: Add showHiddenFiles property for showOpenDialog 2016-07-11 13:30:18 +09:00
Cheng Zhao
33e8d5e0aa Merge pull request #6429 from electron/fullscreen-menu-bar
Auto-hide menubar when in fullscreen
2016-07-11 13:28:00 +09:00
Cheng Zhao
a1a870fe43 Auto-hide menubar when in fullscreen 2016-07-11 13:10:19 +09:00
Cheng Zhao
32f3f3244e Merge pull request #6428 from electron/toolbar
win: Add toolbar type for BrowserWindow
2016-07-11 13:00:48 +09:00
Cheng Zhao
e8e2763131 win: Add toolbar type for BrowserWindow 2016-07-11 12:46:50 +09:00
Cheng Zhao
c644353726 Update brightray for #6423 2016-07-11 09:04:34 +09:00
Cheng Zhao
eae69f9728 Merge pull request #6423 from electron/modernize-to-c11
Modernize to c++11
2016-07-11 09:03:03 +09:00
Haojian Wu
4ac4dacffe Some manual change to for-ranged loop.
Use "const auto&" where possible.
2016-07-10 15:57:51 +02:00
Haojian Wu
2717b96310 Don't change chromium_src files. 2016-07-10 15:35:54 +02:00
Haojian Wu
55b3f1936f Modernize to C++11: Use for-range loop. 2016-07-10 13:33:15 +02:00
Haojian Wu
3bdeac98bf Modernize to C++11: use override. 2016-07-10 13:21:42 +02:00
Haojian Wu
04f9d35312 Modernize to C++11: Use auto key to improve code readability and maintainability. 2016-07-10 13:11:47 +02:00
Cheng Zhao
11ebb15fd2 Merge pull request #6420 from pedrro/master
Fixed broken links in documentation PT-BR
2016-07-10 19:30:41 +09:00
Cheng Zhao
f35bbb9131 Merge pull request #6419 from electron/remove-unused-using-decls
Remove unused using decls.
2016-07-10 19:29:40 +09:00
Cheng Zhao
c7a483aaef Merge pull request #6418 from vsemozhetbyt/patch-1
Fix typo in the web-contents.md
2016-07-10 19:29:18 +09:00
Haojian Wu
fab02809c6 Modernize to C++11: NULL => nullptr.
No functional change.
2016-07-10 11:57:04 +02:00
pedro silva
77ef70cd92 Fixed broken links in documentation PT-BR 2016-07-09 18:47:19 -03:00
Haojian Wu
59e44c13e0 Remove unused using decls. 2016-07-09 22:23:57 +02:00
vsemozhetbyt
4f62050b01 Fix typo in the web-contents.md
📝 `false` -> `true` in the `webContents.print` `silent` explanation.

[ci skip]
2016-07-09 20:31:02 +03:00
Machisté N. Quintana
9c74ea4bf4 Merge pull request #6416 from mihaipocorschi/fix-docs-readme
Fixed broken FAQ link in docs/README.md
2016-07-09 08:49:30 -07:00
Cheng Zhao
c5dd345b98 Merge pull request #6417 from electron/thick-frame-maximze
Correctly handle maximize/fullscreen in window without thickFrame
2016-07-09 23:37:39 +09:00
Cheng Zhao
f77b9db069 Fix unmaximize() not working 2016-07-09 23:16:57 +09:00
Cheng Zhao
5979c1464f Remember bounds instead of size 2016-07-09 23:10:36 +09:00
Cheng Zhao
c4de246bfb Correctly handle unmaximize 2016-07-09 23:04:42 +09:00
Cheng Zhao
baff744601 Use setBounds to implement maximize for window without thickFrame 2016-07-09 22:49:55 +09:00
mihaipocorschi
a3388b1d25 Fixed broken FAQ link in docs/README.md 2016-07-09 16:14:42 +03:00
Cheng Zhao
b87c3c4b2d Merge pull request #6415 from electron/thick-frame
Add thickFrame option for BrowserWindow
2016-07-09 22:09:23 +09:00
Cheng Zhao
b70090170d docs: thickFrame option 2016-07-09 21:52:45 +09:00
Cheng Zhao
2ece9e2885 Add thickFrame option 2016-07-09 21:49:15 +09:00
Cheng Zhao
187b68b8b2 Merge pull request #6412 from electron/relaunch-dev-null
Redirect relaunch process's stdout to /dev/null
2016-07-09 18:16:12 +09:00
Cheng Zhao
54f74e8160 Redirect relaunch process's stdout to /dev/null 2016-07-09 17:59:40 +09:00
Cheng Zhao
1beba5bdc0 Merge pull request #6411 from electron/clear-protocol-handlers
Clear protocol handlers on exit
2016-07-09 17:18:31 +09:00
Cheng Zhao
627028e3a0 Clear protocol handlers on exit 2016-07-09 17:02:55 +09:00
Cheng Zhao
3481acd570 Merge pull request #6404 from electron/default-app-accessibility
Adjust default app styles for accessibility
2016-07-09 12:08:11 +09:00
Kevin Sawicki
d02a453c51 Merge pull request #6391 from electron/getlocale-oneline
New title and one-liner for app.getLocale() doc
2016-07-08 12:45:41 -07:00
Kevin Sawicki
85ff4c4dab Merge pull request #6405 from vsemozhetbyt/patch-1
Fix typo in the web-view-tag.md
2016-07-08 12:18:54 -07:00
vsemozhetbyt
1726327bfa Fix typo in the web-view-tag.md
📝 Remove a redundant # from a href hash.

web-contents.md##webcontentssendinputeventevent ->
web-contents.md#webcontentssendinputeventevent

[ci skip]
2016-07-08 22:15:51 +03:00
Kevin Sawicki
8aee04bb24 Improve text and link contrast ratio 2016-07-08 11:31:00 -07:00
Kevin Sawicki
a4754212dc Add lang attribute to html element 2016-07-08 11:26:22 -07:00
Jessica Lord
e25001e277 Rename file 2016-07-08 09:43:48 -07:00
Kevin Sawicki
7dc336606d Merge pull request #6403 from devjin0617/devjin0617-patch-1
Update README-ko.md
2016-07-08 09:26:18 -07:00
devjin0617
5fd77cbf2e Update README-ko.md
Add meetup community link of turkish
2016-07-09 01:22:35 +09:00
Cheng Zhao
6e81c55880 Merge pull request #6385 from electron/only-use-role-accelerator-in-app-menu
Only use default role accelerator in app menu
2016-07-08 11:22:21 +09:00
Cheng Zhao
5713e0599b Merge pull request #6375 from electron/login-item
Add login item API
2016-07-08 10:39:20 +09:00
Cheng Zhao
204734f80b Merge pull request #6392 from vsemozhetbyt/patch-2
Fix typos in the remote.md
2016-07-08 10:03:32 +09:00
vsemozhetbyt
ba9baec27f Fix typos in the remote.md
📝 Fixes #6387

[ci skip]
2016-07-08 04:00:22 +03:00
Cheng Zhao
b02a83c96e Merge pull request #6390 from vsemozhetbyt/patch-1
One alphabetical reordering in the docs/README.md
2016-07-08 09:52:32 +09:00
Jessica Lord
ea64db9e5c More concise wording 2016-07-07 17:45:35 -07:00
Cheng Zhao
2c56cd4ffa Merge pull request #6384 from electron/move-faq
Move and rename FAQ
2016-07-08 09:35:08 +09:00
vsemozhetbyt
9c5d36f0c6 One alphabetical reordering in the docs/README.md
📝 webContents, Tray -> Tray, webContents

If I get it right, only API TOCs should be ordered alphabetically,
so I've left other ones (Guides, Tutorials, Development) untouched.
I'm not so sure about API TOC Intro (three links below the "Synopsis"),
tell me if they should be sorted alphabetically too.

[ci skip]
2016-07-08 03:33:22 +03:00
Jessica Lord
ae8b78aff8 New title and one-liner 2016-07-07 17:33:06 -07:00
Cheng Zhao
a0eaf8aca6 Merge pull request #6383 from electron/quit-menu-on-linux
Use Ctrl+Q as default accelerator for quit role on Linux
2016-07-08 09:32:07 +09:00
Kevin Sawicki
cde594775d Remove API that is no longer available 2016-07-07 16:41:08 -07:00
Kevin Sawicki
7326d3d3d5 🎨 2016-07-07 16:38:12 -07:00
Kevin Sawicki
10bb8df09a Update login item API docs 2016-07-07 16:33:26 -07:00
Kevin Sawicki
2633c2f735 Add was prefix to current launch settings 2016-07-07 16:29:58 -07:00
Kevin Sawicki
c100300764 Update API to get/setLoginItemSettings 2016-07-07 16:29:09 -07:00
Kevin Sawicki
e4906f2d87 Add back getCurrentActivityType 2016-07-07 14:29:43 -07:00
Kevin Sawicki
cb943cec77 🎨 2016-07-07 14:28:01 -07:00
Kevin Sawicki
10a2454921 Remove unneeded atom:: prefix 2016-07-07 14:25:09 -07:00
Kevin Sawicki
791cbc929a Update spec to request defualt accelerator from item 2016-07-07 11:55:59 -07:00
Kevin Sawicki
2faf00dc19 Only use default accelerator in Windows/Linux app menu 2016-07-07 11:50:19 -07:00
Cheng Zhao
6381f44f26 mac: Pass useDefaultAccelerator to getAcceleratorForCommandId 2016-07-07 11:50:19 -07:00
Jessica Lord
00fab4688b Move and rename FAQ 2016-07-07 10:13:19 -07:00
Kevin Sawicki
1e0e5b0eff Use CommandOrControl+Q for quit role on Linux 2016-07-07 09:19:20 -07:00
Kevin Sawicki
583122ee3e Add quit menu item on Linux 2016-07-07 09:15:36 -07:00
Kevin Sawicki
77cdc2c4a7 Merge pull request #6382 from vsemozhetbyt/patch-1
Fix a hash of a link href in the remote.md
2016-07-07 08:54:23 -07:00
vsemozhetbyt
34ed2c4da4 Fix a hash of a link href in the remote.md
📝 web-contents.md#webcontentsexecutejavascriptcode-usergesture ->
web-contents.md#webcontentsexecutejavascriptcode-usergesture-callback
2016-07-07 18:52:49 +03:00
Cheng Zhao
d23c1bf917 Cleanup the code of SetBounds 2016-07-07 20:02:18 +09:00
Cheng Zhao
43e9f30b21 Merge pull request #6363 from MarshallOfSound/master
Bound the target width and height of window when calling SetSize
2016-07-07 19:52:47 +09:00
Cheng Zhao
c3ce53a7b2 Merge pull request #6379 from Crocmagnon/patch-1
Highlight the whole eval() override
2016-07-07 19:49:42 +09:00
Gabriel Augendre
72e811fea4 Highlight the whole eval() override
I updated the link to hightlight not only the first line but the whole `window.eval()` override.
2016-07-07 12:22:12 +02:00
Samuel Attard
ceb2864881 Move size bounding logic to SetBounds 2016-07-07 20:55:10 +12:00
Cheng Zhao
eedac775e4 Merge pull request #6377 from electron/docs-update
docs: Some dlls are not there anymore
2016-07-07 10:45:55 +09:00
Cheng Zhao
a053dc2f7d Merge pull request #6376 from electron/require-package-json-in-default-app
Use require to load package.json in default app
2016-07-07 10:25:56 +09:00
Cheng Zhao
26af0999cd Merge pull request #6372 from electron/linux-icon
Set default app window icon on Linux
2016-07-07 10:19:02 +09:00
Cheng Zhao
c70635daff docs: Some dlls are not there anymore 2016-07-07 10:17:49 +09:00
Cheng Zhao
c7e0df09bc Merge pull request #6370 from electron/send-key-event-to-main-menu
Give menu a chance to handle keydown event before window
2016-07-07 10:11:12 +09:00
Cheng Zhao
bbfdaf7679 Merge pull request #6355 from electron/webview-capture-page
Add <webview>.capturePage([rect,] callback)
2016-07-07 10:09:40 +09:00
Cheng Zhao
0a64d6ee30 Merge pull request #6369 from electron/remote-object-with-no-constructor
Handle remote arguments with no constructor
2016-07-07 09:47:46 +09:00
Kevin Sawicki
2e02994277 Add parens about constructor 2016-07-06 15:45:35 -07:00
Kevin Sawicki
88fe667f66 Use require to load package json 2016-07-06 14:19:47 -07:00
Kevin Sawicki
49b32b8380 Mention open as hidden is manually configurable 2016-07-06 14:17:19 -07:00
Kevin Sawicki
667b6d6370 Doc login item APIs 2016-07-06 14:10:25 -07:00
Kevin Sawicki
60ab71a706 Combine launch and current status login item APIs 2016-07-06 13:57:46 -07:00
Kevin Sawicki
2406c82ef5 Add specs for login item APIs 2016-07-06 13:34:14 -07:00
Kevin Sawicki
c5610b2186 Add API to add/remove app as login item 2016-07-06 13:26:16 -07:00
Kevin Sawicki
b55f55cfc4 Add app.getLoginItemStatus API 2016-07-06 13:17:39 -07:00
Kevin Sawicki
56739e10e3 Add anonymous class to exports and assert it 2016-07-06 13:11:25 -07:00
Kevin Sawicki
a9b43a0fc9 Use empty string constructor name when missing 2016-07-06 13:06:48 -07:00
Kevin Sawicki
79c00d8938 Shrink icon using pngcrush 2016-07-06 12:51:16 -07:00
Kevin Sawicki
98a97a52ea Add getLoginItemLaunchStatus API 2016-07-06 12:49:08 -07:00
Kevin Sawicki
cf480f8e17 Set default app window icon on Linux 2016-07-06 11:47:21 -07:00
Kevin Sawicki
bd33961964 Give menu a chance to handle key event before window 2016-07-06 10:12:40 -07:00
Kevin Sawicki
07ccb6af2b 🎨 2016-07-06 09:42:43 -07:00
Kevin Sawicki
b900ff93e4 Make OnCapturePageDone static 2016-07-06 09:32:58 -07:00
Kevin Sawicki
c2ecc49be2 Defer to webContents docs 2016-07-06 09:21:29 -07:00
Kevin Sawicki
4a4a8528ea Fix linter warnings 2016-07-06 09:21:29 -07:00
Kevin Sawicki
ce4ef1ccb8 Update capturePage documentation for new location 2016-07-06 09:21:28 -07:00
Kevin Sawicki
12dddae2ca Remove unused callback 2016-07-06 09:21:28 -07:00
Kevin Sawicki
f7b72f0948 Move capturePage to WebContents 2016-07-06 09:21:28 -07:00
Kevin Sawicki
d67dfd09fd Pass through empty constructor names 2016-07-06 09:18:20 -07:00
Kevin Sawicki
a1209b69b3 Add spec for constructor-less param 2016-07-06 09:11:04 -07:00
Maksim
b444b35215 Update remote.js 2016-07-06 09:11:04 -07:00
Kevin Sawicki
d42d10a47c Merge pull request #6368 from vsemozhetbyt/patch-1
Fix disordered definitions in webContents doc
2016-07-06 09:02:35 -07:00
vsemozhetbyt
c2bf6c2460 Fix disordered definitions in webContents doc
📝 Swap `clearSelection` and `keepSelection` definitions
for `webContents.stopFindInPage(action)` that seems to be in wrong order.

[ci skip]
2016-07-06 18:58:50 +03:00
Samuel Attard
6bd343b112 Bound the target width and height of window when calling SetSize 2016-07-07 00:49:35 +12:00
Heilig Benedek
74120493fd Merge pull request #12 from electron/master
update as upstream
2016-07-06 14:12:24 +02:00
Cheng Zhao
92b97d3576 Bump v1.2.6 2016-07-06 13:20:36 +09:00
Paul Betts
7ffab11f1a Merge pull request #6356 from jonathansampson/patch-1
modern.ie is no longer in use
2016-07-05 19:37:38 -07:00
Jonathan Sampson
7baf7372af modern.ie is no longer in use
The URL exists for historical reasons, but is no longer the primary URL for developer resources.
2016-07-05 19:34:33 -07:00
Cheng Zhao
6fe4653b54 Merge pull request #6354 from electron/package-json-bom
Use require to load package.json
2016-07-06 09:48:37 +09:00
Kevin Sawicki
b8e5180132 Use require to load package.json instead of fs/JSON 2016-07-05 15:50:12 -07:00
Heilig Benedek
6fb6b93003 speedup base 2016-07-05 21:33:22 +02:00
Cheng Zhao
437164deec Force linking with MeasureFormat of icu 2016-07-05 14:49:03 +09:00
Cheng Zhao
41b8dda071 For hidden window focus() should do nothing 2016-07-05 10:34:52 +09:00
Cheng Zhao
de502d8012 Initialize MaterialDesignController 2016-07-05 09:41:23 +09:00
Cheng Zhao
381689d3ed Fix building on Windows 2016-07-05 09:31:29 +09:00
Cheng Zhao
8d3e09747a directWrite option is removed 2016-07-05 09:20:57 +09:00
Cheng Zhao
d0719e9b4b Fix cpplint warnings 2016-07-04 19:19:20 +09:00
Cheng Zhao
6c2825c0c4 spec: Ignore cache when testing protocol module 2016-07-04 18:08:41 +09:00
Cheng Zhao
ea5c5d2680 Fix building on Linux 2016-07-04 16:41:18 +09:00
Cheng Zhao
0a6bb9c36a Fix crash when creating protocol module 2016-07-04 15:32:43 +09:00
Cheng Zhao
48f819f337 Do not use home cooked SkUserConfig.h 2016-07-04 15:32:43 +09:00
Cheng Zhao
1ba3907038 Update to API changes of Chrome 52 2016-07-04 15:32:43 +09:00
Cheng Zhao
eb378bef3a Upgrade to Chrome 52 2016-07-04 15:32:43 +09:00
Cheng Zhao
83ae14f2ed Merge pull request #6333 from electron/drag-item
Add `webContents.startDrag(item)` API
2016-07-04 13:30:56 +09:00
Cheng Zhao
23582cc9d3 Reduce the scope of ScopedNestableTaskAllower 2016-07-03 15:30:27 +09:00
Cheng Zhao
ba1fe322e9 docs: Use <a> as example 2016-07-03 15:27:26 +09:00
Cheng Zhao
b7459d50f9 docs: Dragging files out of the window 2016-07-03 15:26:22 +09:00
Cheng Zhao
f072d9dd3a docs: webContents.startDrag(item) 2016-07-03 15:10:59 +09:00
Cheng Zhao
7916f0ea18 win: Use drag_utils::CreateDragImageForFile 2016-07-03 14:44:47 +09:00
Cheng Zhao
63a8961ed1 views: Implement webContents.startDrag 2016-07-03 14:34:35 +09:00
Cheng Zhao
fa468a529b Support dragging multiple files 2016-07-03 13:58:31 +09:00
Cheng Zhao
13c668f22b mac: Implement webContents.startDrag 2016-07-03 12:26:43 +09:00
Cheng Zhao
74ebbf9c78 docs: Add trailing period 2016-07-02 20:27:14 +09:00
Cheng Zhao
ff5745f36f Merge pull request #6324 from MarshallOfSound/master
Document possible getLocale returns values.
2016-07-02 11:25:15 +00:00
Samuel Attard
7f914c65de Update docs to match style guide 2016-07-02 23:21:45 +12:00
Samuel Attard
bbaab9b355 Document possible getLocale returns values. Closes #5363 2016-07-02 21:17:37 +12:00
Cheng Zhao
14c4be50c1 Avoid calling GetWebContentsFromProcessID for twice 2016-07-02 16:54:12 +09:00
Cheng Zhao
b0faa62f76 Merge pull request #6313 from MarshallOfSound/silent-notification-when-muted
Override the Notification API constructor to create silent notificatons when the webContents is muted
2016-07-02 07:44:33 +00:00
Cheng Zhao
6eda76336f Merge pull request #6323 from electron/icon-fix
Set window icon before showing window
2016-07-02 07:41:30 +00:00
Cheng Zhao
e76ec92812 Set window icon before showing window 2016-07-02 16:16:47 +09:00
Cheng Zhao
6ffcb9f06c Merge pull request #6322 from electron/chrome-51.0.2704.106
Update to Chrome 51.0.2704.106
2016-07-02 07:12:23 +00:00
Cheng Zhao
cd38e5c85e Update to Chrome 51.0.2704.106 2016-07-02 13:54:34 +09:00
Cheng Zhao
ee0eb9ae08 Merge pull request #6309 from electron/app-launcher-rename
Implement app.setBadgeCount on Mac
2016-07-02 01:51:47 +00:00
Cheng Zhao
767124c45c Update for reviews 2016-07-02 10:36:46 +09:00
Samuel Attard
4f660f3e6f Implement WebContenstAudioMuted in AtomBrowserClient 2016-07-02 13:28:28 +12:00
Kevin Sawicki
5dcc354432 Merge pull request #6298 from jhen0409/patch-5
Support background.page in extension manifest
2016-07-01 08:59:39 -07:00
Kevin Sawicki
b47d0e3e58 Tweak launcher note text 2016-07-01 08:51:25 -07:00
Jhen
d4f64ce943 Use background page path instead of generated path
if extension use manifest.background.page
2016-07-01 23:50:31 +08:00
Cheng Zhao
df3e651fbf Merge pull request #6315 from electron/fix-extension-match
Don't use MatchesExtension for matching filters
2016-07-01 14:14:18 +00:00
Cheng Zhao
cff50614e5 Merge pull request #6314 from electron/suppress-session-protocol
spec: Suppress the session.protocol test
2016-07-01 13:56:48 +00:00
Cheng Zhao
431ea61ff8 Don't use MatchesExtension for matching filters
MatchesExtension compares double extensions like .tar.gz, which does not
match the filters.
2016-07-01 22:55:15 +09:00
Cheng Zhao
bb92765ecf spec: Suppress the session.protocol test 2016-07-01 22:24:30 +09:00
Cheng Zhao
1da2a1c2ae app.setBadgeCount should return boolean 2016-07-01 22:20:05 +09:00
Samuel Attard
54f06b0ba9 Override the Notification API constructor to create silent notifications when the webContents is muted 2016-07-01 23:26:40 +12:00
Cheng Zhao
f8ec377123 docs: app.setBadgeCount 2016-07-01 17:44:09 +09:00
Cheng Zhao
cb00d3cfb3 mac: Implement app.setBadgeCount 2016-07-01 17:39:26 +09:00
Cheng Zhao
36a0a491c9 Merge pull request #6216 from electron/class-docs
Add details to docs/styleguide.md
2016-07-01 05:34:01 +00:00
Cheng Zhao
3965440952 conjunctions don't have to be capitalized 2016-07-01 14:33:22 +09:00
Cheng Zhao
1626c3bf0a Use * instead of - for lists
`*` is used in most lists in our docs, let's keep consistency.
2016-07-01 14:30:55 +09:00
Cheng Zhao
83e9521d13 Update atom-shell-vs-node-webkit.md 2016-07-01 14:27:56 +09:00
Kevin Sawicki
0959143e2d Merge pull request #6294 from preco21/korean-docs-9
docs: Update Korean docs as upstream
2016-06-30 14:41:50 -07:00
Jhen
76f4bd01eb Support background.page in extension manifest 2016-06-30 16:04:13 +08:00
Plusb Preco
21f0e65735 📝 Update Korean docs as upstream
[ci skip]
2016-06-30 11:32:14 +09:00
Kevin Sawicki
511dceda4e Merge pull request #6225 from miniak/publish-pdb
Publish Windows PDBs to allow debugging without Symbol server
2016-06-29 16:54:26 -07:00
Kevin Sawicki
7279fc46bc Merge pull request #6280 from electron/pop-up-context-menu-windows
Use previously set context menu when popup menu is null
2016-06-29 13:00:10 -07:00
Kevin Sawicki
45dbbfdfe9 Use nullptr comparisons 2016-06-29 11:52:58 -07:00
Kevin Sawicki
e797eb5ca3 Use set context menu when param is not specified 2016-06-29 11:52:58 -07:00
Kevin Sawicki
6d7b52eceb Merge pull request #6243 from jnugh/master
Ubuntu Unity launcher counter badge
2016-06-29 11:45:19 -07:00
Jonas Schwabe
9aa8807f83 add specs for app.launcher api
fix linter errors
2016-06-29 20:28:16 +02:00
Kevin Sawicki
0991d2bf47 Merge pull request #6290 from electron/updated-apis-in-doc-translations
Update renamed nativeImage APIs in translated docs
2016-06-29 11:25:44 -07:00
Kevin Sawicki
90048abd0a Update renamed nativeImage APIs 2016-06-29 11:23:11 -07:00
Jonas Schwabe
768ff7af5a Add additional method isUnityRunning, fix multiple typos in docs 2016-06-29 20:22:17 +02:00
Jonas Schwabe
8ac205685d Add ifdef for property, which should only be availabe on Linux 2016-06-29 20:22:17 +02:00
Jonas Schwabe
e2d389fbd4 Rename the unityLauncher api to launcher and make it available on linux in general. + Document it only works on ubuntu 2016-06-29 20:22:17 +02:00
Jonas Schwabe
336a55cb23 📝 docs for unity launcher badge api 2016-06-29 20:22:17 +02:00
Jonas Schwabe
e3ba6818af Fix linter errors 2016-06-29 20:22:17 +02:00
Jonas Schwabe
b22ce93477 Implement libunity launcher badge counter to be set via electron, fixes #4193 2016-06-29 20:22:17 +02:00
Kevin Sawicki
90ea0a365c Merge pull request #6289 from electron/lint-specs
Remove standard linter warnings from specs
2016-06-29 11:14:53 -07:00
Plusb Preco
4a40369b6d 📝 Update Korean docs as upstream
[ci skip]
2016-06-30 02:50:41 +09:00
Kevin Sawicki
03497fb984 Update buffer length asserts 2016-06-29 09:46:16 -07:00
Kevin Sawicki
8b35814d10 🎨 2016-06-29 09:46:16 -07:00
Kevin Sawicki
197ec98800 Remove standard linter warnings 2016-06-29 09:46:16 -07:00
Kevin Sawicki
4afa32a7bb Add WebInspector as global 2016-06-29 09:46:16 -07:00
Kevin Sawicki
9922261f9e Set browser env in specs 2016-06-29 09:46:16 -07:00
Kevin Sawicki
e94c066c03 change into spec directory before running standard 2016-06-29 09:46:15 -07:00
Kevin Sawicki
3090d1f85e Upgrade to standard 7.1.2+ 2016-06-29 09:46:15 -07:00
Kevin Sawicki
cde1254e29 Merge pull request #6282 from electron/cookie-set-failed-message
Mention setting cookie in failure message
2016-06-29 09:46:02 -07:00
Kevin Sawicki
8c52279531 Tweak cookie set failure message and add spec 2016-06-29 08:53:52 -07:00
Kevin Sawicki
2cf0843f82 Merge pull request #6281 from electron/cookies-http-only
Update key to be httpOnly instead of session
2016-06-29 08:46:37 -07:00
Kevin Sawicki
5b8c4f55e7 Update key to be httpOnly instead of session 2016-06-29 08:39:20 -07:00
Kevin Sawicki
42fe27b25b Merge pull request #6288 from thompsonemerson/patch-4
word correction
2016-06-29 08:15:34 -07:00
Milan Burda
43eba3dada Publish Windows PDBs to allow debugging without Symbol server 2016-06-29 16:58:56 +02:00
Emerson Thompson
68ef327c81 word correction 2016-06-29 11:15:52 -03:00
Plusb Preco
b73d90094f 📝 Update Korean docs as upstream
[ci skip]
2016-06-29 22:34:51 +09:00
Kevin Sawicki
8155e71925 Merge pull request #6279 from electron/chrome-storage-return
Always call chrome.storage.*.get callback
2016-06-28 14:47:32 -07:00
Kevin Sawicki
d2d11ce8bd Invoke callback instead of returning 2016-06-28 13:04:59 -07:00
Kevin Sawicki
2fe83bc5f0 Add failing spec for no specified storage keys 2016-06-28 13:01:51 -07:00
Kevin Sawicki
6081cba15d Merge pull request #6269 from Draivin/master
Add chrome.storage.local
2016-06-28 12:44:45 -07:00
Kevin Sawicki
49bec9165c Merge pull request #6278 from electron/ico-native-image-crash
Fix nativeImage.createFromPath for non-existent .ico
2016-06-28 12:41:48 -07:00
Kevin Sawicki
14df90fd19 Add spec for valid .ico file 2016-06-28 12:17:05 -07:00
Kevin Sawicki
8fb86e10fc Add assert for non-existent .ico 2016-06-28 12:17:05 -07:00
Milan Burda
a886261518 Fix crash in ReadImageSkiaFromICO when CreateSkBitmapFromHICON fails 2016-06-28 12:17:05 -07:00
Daniel Pham
a47e30dd82 Merge pull request #6274 from thompsonemerson/patch-3
word correction
2016-06-28 09:43:29 -04:00
Daniel Pham
3dbe4a5c71 Merge pull request #6272 from thompsonemerson/patch-1
link correction
2016-06-28 09:43:06 -04:00
Daniel Pham
509fd3948c Merge pull request #6273 from thompsonemerson/patch-2
link to the translation
2016-06-28 09:40:47 -04:00
Emerson Thompson
1551a96223 word correction 2016-06-28 09:43:10 -03:00
Emerson Thompson
8faf2f10e1 link to the translation 2016-06-28 09:38:02 -03:00
Emerson Thompson
918f25b76c link correction 2016-06-28 09:22:53 -03:00
Ian Ornelas
d6ab353438 Add chrome.storage.local 2016-06-28 07:21:03 -03:00
Kevin Sawicki
b38eef066e Merge pull request #6266 from thompsonemerson/patch-3
Translated: power-monitor.md
2016-06-27 16:58:42 -07:00
Emerson Thompson
393829b674 Translated: power-monitor.md 2016-06-27 20:48:58 -03:00
Kevin Sawicki
4d910618d0 Merge pull request #6265 from thompsonemerson/patch-2
broken link (404)
2016-06-27 16:28:07 -07:00
Kevin Sawicki
739334f521 Merge pull request #6263 from thompsonemerson/patch-1
Portuguese error - word "atualização"
2016-06-27 16:27:49 -07:00
Emerson Thompson
3da41e03aa broken link (404)
Broken link (404) to DesktopCapturer
2016-06-27 20:27:09 -03:00
Emerson Thompson
e457207b20 Portuguese error 2016-06-27 20:19:46 -03:00
Cheng Zhao
4e747b56b0 Update docs-translations/zh-CN/api/shell.md
Close #6099.
2016-06-26 13:36:05 +09:00
Cheng Zhao
7d38384bdd Merge pull request #6244 from electron/frame-subscription-cleanup
Cleanup code of beginFrameSubscription
2016-06-26 04:27:06 +00:00
Cheng Zhao
090c8b89bb spec: Make beginFrameSubscription test more reliable 2016-06-26 11:53:58 +09:00
Cheng Zhao
e1ad64013e Cleanup code of beginFrameSubscription 2016-06-26 11:46:40 +09:00
Cheng Zhao
3d2ad0080d Merge pull request #6164 from MaxWhere/master
beginFrameSubscription bugfix and improvement
2016-06-26 02:39:59 +00:00
Cheng Zhao
dd7cf3d7b1 Merge pull request #6238 from fdelayen/click-top-level-menu
Execute click handlers for top level menu items
2016-06-26 01:59:31 +00:00
Heilig Benedek
5118def724 damaged -> dirty rename, fixed misc issues, changed signature, updated docs and added tests 2016-06-25 18:23:40 +02:00
Florent Delayen
4d55175649 Execute click handlers for top level menu items 2016-06-25 16:51:43 +02:00
Cheng Zhao
04b30afbed Merge pull request #6233 from electron/clipboard-bookmark-support
Add support for reading/writing bookmarks from the clipboard
2016-06-25 05:23:32 +00:00
Cheng Zhao
8a4c8eb305 Merge pull request #6226 from miniak/fix-uninitialized-member-var
Fix uninitialized member variable in CrashReporterWin
2016-06-25 01:18:19 +00:00
Kevin Sawicki
f90ef12814 read/writeBookmark is not implemented on Linux 2016-06-24 17:16:38 -07:00
Zeke Sikelianos
aee111bf2f minor wording changes and tweaks 2016-06-24 15:59:30 -07:00
Kevin Sawicki
9479536bb8 Tweak return value description 2016-06-24 15:35:30 -07:00
Kevin Sawicki
5fbba2d27b Add assertions for no available bookmark 2016-06-24 15:32:52 -07:00
Kevin Sawicki
6588b85ac9 Mention empty strings 2016-06-24 15:31:15 -07:00
Kevin Sawicki
30a628b46f Remove unsupported type 2016-06-24 15:29:39 -07:00
Kevin Sawicki
a2ba778adc Document clipboard bookmark support 2016-06-24 15:20:49 -07:00
Kevin Sawicki
9fab641ecb Add missing rtf key 2016-06-24 15:17:31 -07:00
Kevin Sawicki
e802d0e4a0 Add bookmark key to clipboard.write 2016-06-24 15:14:28 -07:00
Kevin Sawicki
358bf1bf69 Add read/writeBookmark spec 2016-06-24 15:10:32 -07:00
Kevin Sawicki
271808b278 Support reading/writing bookmarks to clipboard 2016-06-24 15:08:12 -07:00
Kevin Sawicki
63e2ee8e10 Add link to Boolean 2016-06-24 12:45:22 -07:00
Kevin Sawicki
47504c5a53 Use more lists 2016-06-24 12:40:55 -07:00
Kevin Sawicki
5dd7bf67e7 Minor formatting and wording tweaks 2016-06-24 12:28:41 -07:00
Milan Burda
dfc2f3f0c6 Fix uninitialized member variable in CrashReporterWin 2016-06-24 18:30:38 +02:00
Zeke Sikelianos
6ea59803a8 Merge pull request #6221 from SudarAbisheck/master
Update quick-start.md
2016-06-23 23:08:23 -07:00
Cheng Zhao
0c53317eea Merge pull request #6220 from electron/promise-in-main-process
Handle v8::MicrotasksScope in the main process
2016-06-24 06:07:28 +00:00
Sudar Abisheck
0e1caa5961 Update quick-start.md
Corrected the anchor text
2016-06-24 11:29:55 +05:30
Cheng Zhao
ee28f4fc32 Handle v8::MicrotasksScope in the main process 2016-06-24 14:45:31 +09:00
Cheng Zhao
5826a8f9a9 Merge pull request #6218 from electron/clean-up-callback-id
Remove callbackId when callback is removed from registry
2016-06-24 03:17:46 +00:00
Cheng Zhao
f792b6c752 Remove callbackId when callback is removed from registry 2016-06-24 11:22:48 +09:00
Cheng Zhao
38592aaef7 Add details to docs/styleguide.md 2016-06-24 10:45:37 +09:00
Cheng Zhao
552c9b7f0a Merge pull request #6213 from electron/reset-search-paths
Reuse node's implementation of Module._nodeModulePaths
2016-06-24 00:26:33 +00:00
Cheng Zhao
eb55fba9f4 Merge pull request #6211 from electron/debugging-main-process-docs
Update debugging main process docs
2016-06-24 00:25:26 +00:00
Cheng Zhao
fa023842d3 Merge pull request #6111 from electron/docs-formatting
Docs formatting
2016-06-24 00:24:57 +00:00
Kevin Sawicki
bac4d51169 Reuse root path variable 2016-06-23 15:56:29 -07:00
Kevin Sawicki
905e9e9645 Include trailing separator in comparisons 2016-06-23 15:45:08 -07:00
Kevin Sawicki
c6906deef2 Add failing spec for trailing separator bug 2016-06-23 15:39:21 -07:00
Kevin Sawicki
b273b70eee Filter existing search paths instead reimplementing 2016-06-23 15:27:45 -07:00
Kevin Sawicki
eed240be1c Add specs for Module._nodeModulesPath 2016-06-23 15:20:14 -07:00
Kevin Sawicki
adc8c54a81 Minor formatting updates 2016-06-23 14:23:34 -07:00
Kevin Sawicki
eb8c1b1a50 Make update number message a note 2016-06-23 14:20:52 -07:00
Kevin Sawicki
5e389021eb Use upstream node-pre-gyp 2016-06-23 14:19:23 -07:00
Zeke Sikelianos
3dcbbe9f20 remove parens from type 2016-06-23 14:13:03 -07:00
Zeke Sikelianos
cfebf7aa6b fix list indentation 2016-06-23 10:36:16 -07:00
Cheng Zhao
d959ccb47c Merge pull request #6201 from electron/did-fail-load
Do not emit did-fail-load for canceled requests
2016-06-23 11:55:39 +00:00
Cheng Zhao
ed6213e951 Do not emit did-fail-load for canceled requests 2016-06-23 20:32:19 +09:00
Cheng Zhao
a00c5e3363 Bump v1.2.5 2016-06-23 14:37:58 +09:00
Cheng Zhao
e70c622a70 Merge pull request #6190 from electron/default-label-and-accelerator
Add default label and accelerator for menu item roles
2016-06-23 05:34:10 +00:00
Cheng Zhao
19d8a366b3 Merge pull request #6180 from jhen0409/patch-4
Fix chrome.runtime.sendMessage
2016-06-23 04:58:30 +00:00
Cheng Zhao
6aef8f4fea Merge pull request #6197 from electron/fix-api-call-yosemite
mac: Avoid calling setTitleVisibility for OS X 10.9
2016-06-23 04:49:11 +00:00
Cheng Zhao
d313639bbb Merge pull request #6198 from electron/fix-session-protocol-test
Split the session.protocol test into multiple tests
2016-06-23 04:49:06 +00:00
Cheng Zhao
2893974c05 spec: Set mimeType for protocol's handler 2016-06-23 13:29:18 +09:00
Cheng Zhao
a04c0ce196 spec: Split the session.protocol test into multiple tests 2016-06-23 13:16:53 +09:00
Cheng Zhao
71ab69314c spec: Put protocol registration in beforeEach 2016-06-23 13:11:19 +09:00
Cheng Zhao
6cfd078d19 Merge pull request #6174 from electron/session-docs-cleanup
docs: Separate Cookies and WebRequest classes in session.md
2016-06-23 04:05:18 +00:00
Cheng Zhao
7f3a296050 mac: Avoid calling setTitleVisibility for OS X 10.9 2016-06-23 13:00:14 +09:00
Cheng Zhao
74a2b77359 Merge pull request #6195 from electron/eagerly-require-protocol
Eagerly require protocol
2016-06-23 03:31:26 +00:00
Cheng Zhao
75972abc84 Merge pull request #6192 from electron/native-image-api-names
Upper case initialisms in nativeImage API
2016-06-23 03:06:42 +00:00
Cheng Zhao
7fa4a7889b Update brightray for #6178 2016-06-23 12:05:10 +09:00
Kevin Sawicki
5a122b5ea0 Eagerly require protocol 2016-06-22 18:51:39 -07:00
Kevin Sawicki
c686997209 Ctrl -> Control for consistency 2016-06-22 16:56:45 -07:00
Jhen
233355ed09 Fix chrome.runtime.sendMessage
add a case of not provide extension-id: (message, responseCallback)
2016-06-23 07:40:15 +08:00
Cheng Zhao
293a1edc35 Merge pull request #6183 from joshaber/patch-1
Update external frameworks version
2016-06-22 23:33:30 +00:00
Kevin Sawicki
e9222583cb toPng/toJpeg -> toPNG/toJPEG 2016-06-22 15:47:42 -07:00
Kevin Sawicki
813e528350 Update expected accelerator 2016-06-22 15:41:45 -07:00
Kevin Sawicki
6165908ba7 Incorporate review feedback 2016-06-22 15:26:17 -07:00
Kevin Sawicki
be642612c0 Export app before requiring modules 2016-06-22 15:21:45 -07:00
Kevin Sawicki
4dbdcad05e Remove label/accelerators with role defaults 2016-06-22 14:37:16 -07:00
Kevin Sawicki
b7afe44a5c Add assert for role with app name in label 2016-06-22 14:22:15 -07:00
Kevin Sawicki
ece319a687 🎨 2016-06-22 14:14:32 -07:00
Kevin Sawicki
58c1d38c96 Remove lint errors 2016-06-22 14:13:12 -07:00
Kevin Sawicki
c98f419bc8 Doc role defaults 2016-06-22 14:10:44 -07:00
Kevin Sawicki
5096d7835f Add spec for default role label/accelerator 2016-06-22 14:07:46 -07:00
Kevin Sawicki
c6dc6a8905 Specify focused window to execute call 2016-06-22 14:02:31 -07:00
Kevin Sawicki
30e3a6ed83 Add app require 2016-06-22 13:59:49 -07:00
Kevin Sawicki
66f2fb2fe4 Add execute helper to roles file 2016-06-22 13:48:26 -07:00
Kevin Sawicki
653370974a 🎨 Sort roles alphabetically 2016-06-22 13:15:20 -07:00
Kevin Sawicki
c0562d16d5 Add more role defaults 2016-06-22 13:09:49 -07:00
Kevin Sawicki
888068b597 Add default help/window labels 2016-06-22 13:09:49 -07:00
Kevin Sawicki
566a407b36 Use default labels and accelerators 2016-06-22 13:09:49 -07:00
Kevin Sawicki
13a6d32ee9 Add default label/accelerator to role menu items 2016-06-22 13:09:48 -07:00
Kevin Sawicki
25b2724ab9 Add menu item role defaults 2016-06-22 13:09:48 -07:00
Kevin Sawicki
56b3478760 Merge pull request #6184 from electron/read-only-command-id
Make MenuItem.commandId read only
2016-06-22 13:09:16 -07:00
Kevin Sawicki
ad110fc806 Make commandId a read only property 2016-06-22 10:07:02 -07:00
Kevin Sawicki
90600ba653 Add failing spec for writeable command id 2016-06-22 10:06:54 -07:00
Josh Abernathy
bd74412501 Update external frameworks version
Bump to [1.1.0](https://github.com/electron/electron-frameworks/releases/tag/v1.1.0) which upgraded Squirrel.Mac.
2016-06-22 13:00:31 -04:00
Kevin Sawicki
c6db5f6baa Merge pull request #6182 from electron/format-menu-item
Reformat MenuItem class
2016-06-22 10:00:01 -07:00
Kevin Sawicki
50a62429e4 Add back event param 2016-06-22 09:35:11 -07:00
Kevin Sawicki
4e8d4dfda9 Move click variable near this.click 2016-06-22 09:21:46 -07:00
Kevin Sawicki
38e1abc599 🎨 Destructure requires 2016-06-22 09:21:46 -07:00
Kevin Sawicki
51b8c0292c Add spec for submenu type with no submenu 2016-06-22 09:21:46 -07:00
Kevin Sawicki
93cbe6539f Add spec for invalid menu item type 2016-06-22 09:21:46 -07:00
Kevin Sawicki
ca57f8a391 Remove CoffeeScript class wrapper 2016-06-22 09:21:46 -07:00
Cheng Zhao
7274c69bc6 Merge pull request #6175 from miniak/content-protection
Add BrowserWindow.prototype.setContentProtection(enable)
2016-06-22 11:25:49 +00:00
Cheng Zhao
86e98950cc Merge pull request #6173 from arifcakiroglu/patch-1
Update README.md
2016-06-22 10:31:36 +00:00
Milan Burda
c243cf0c0f Add BrowserWindow.prototype.setContentProtection(enable) 2016-06-22 10:40:33 +02:00
Arif Çakıroğlu
7e7c085dc7 Update README.md 2016-06-22 11:02:14 +03:00
Cheng Zhao
1a74177e2d docs: Separate Cookies and WebRequest classes in session.md 2016-06-22 16:34:58 +09:00
Cheng Zhao
fd40f3d344 Merge pull request #6172 from electron/session-setuseragent
Add Session.setUserAgent(userAgent[, acceptLanguages]) API
2016-06-22 07:34:10 +00:00
Arif Çakıroğlu
5a702e0153 Update README.md
add `electron-tr` community
2016-06-22 10:11:13 +03:00
Cheng Zhao
6f9c4766fc Fix usages of global BrowserContext in App::ImportCertificate 2016-06-22 16:10:36 +09:00
Cheng Zhao
6b1df5838c docs: ses.setUserAgent(userAgent[, acceptLanguages]) 2016-06-22 16:05:38 +09:00
Cheng Zhao
01bc8305f8 Add ses.getUserAgent()/setUserAgent(...) APIs 2016-06-22 15:57:51 +09:00
Cheng Zhao
9c8e64f268 Cache the BrowserContext::GetUserAgent 2016-06-22 15:46:46 +09:00
Cheng Zhao
b0f04de50c Do not force creating default session in C++ 2016-06-22 15:41:56 +09:00
Zeke Sikelianos
271c39ceb3 OS X → macOS 2016-06-21 23:02:01 -07:00
Zeke Sikelianos
72403c1a8d use consistent verb style 2016-06-21 22:56:51 -07:00
Zeke Sikelianos
90d1b9169f prepositions are hard 2016-06-21 22:55:26 -07:00
Zeke Sikelianos
2a079b2e0a wether → whether 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
46c1ef60aa restore headings in translated session docs 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
0ff50650d2 document drop-files event type 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
574e8974b6 undo heading changes to special-case session 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
a82a2485d7 fix debugger event headings 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
49fd3ff41b document platform-specific arguments 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
74e0535659 use unformatted raw code examples in styleguide 2016-06-21 22:54:43 -07:00
Zeke Sikelianos
0d481aaeb8 📝 use h3 headings for events and methods, per the styleguide 2016-06-21 22:54:43 -07:00
Cheng Zhao
40c195cf5c Merge pull request #6171 from electron/maximize/minimize
mac: Fix maximize/unmaximize event emitted before window is maximized
2016-06-22 05:26:27 +00:00
Cheng Zhao
8ffd069689 mac: Fix maximize/unmaximize event emitted before window is maximized 2016-06-22 14:06:54 +09:00
Cheng Zhao
a5976055bf Merge pull request #6170 from electron/click-event
Add "event" parameter for "click" handler of MenuItem
2016-06-22 05:06:25 +00:00
Cheng Zhao
90b64504fc spec: Fix failing tests of Menu 2016-06-22 13:36:10 +09:00
Cheng Zhao
62d0dbea5a docs: Reformat the menu-item.md 2016-06-22 13:23:07 +09:00
Cheng Zhao
8d08e215b2 Add "event" parameter for "click" handler of MenuItem 2016-06-22 11:22:14 +09:00
Cheng Zhao
e6327fb015 Add EventEmitter::CreateEventFromFlags 2016-06-22 11:00:45 +09:00
Cheng Zhao
08a1e92650 Bump v1.2.4 2016-06-22 10:26:54 +09:00
Cheng Zhao
4e811fc377 Merge pull request #6169 from electron/map-roles-by-command-id
Map roles by command id instead of index
2016-06-22 01:24:20 +00:00
Cheng Zhao
c0aebc9d4f Merge pull request #6168 from electron/forward-delete
Support forward delete menu item accelerator
2016-06-22 01:12:10 +00:00
Cheng Zhao
85c163e58a Merge pull request #6166 from electron/fullscreen-role
Add togglefullscreen menu item role
2016-06-22 00:58:39 +00:00
Kevin Sawicki
812dea9a8b Add comment about map key/values 2016-06-21 15:28:02 -07:00
Kevin Sawicki
583cc925ac Map roles by command id 2016-06-21 15:25:14 -07:00
Kevin Sawicki
9486df1303 Add delete accelerator to delete menu 2016-06-21 12:38:44 -07:00
Kevin Sawicki
738edb650d Make NSDeleteFunctionKey to NSDeleteCharacter 2016-06-21 12:33:02 -07:00
Kevin Sawicki
3505e98a46 Access function in methodInBrowserWindow 2016-06-21 10:08:30 -07:00
Kevin Sawicki
35097b244e Doc togglefullscreen menu item role 2016-06-21 09:43:29 -07:00
Kevin Sawicki
dcd832e88c 🎨 2016-06-21 09:38:35 -07:00
Kevin Sawicki
3cdf36c536 Use togglefullscreen role 2016-06-21 09:34:41 -07:00
Kevin Sawicki
2536e62fb0 Add togglefullscreen role selector 2016-06-21 09:34:29 -07:00
Kevin Sawicki
e3e1ed41ca Add togglefullscreen role 2016-06-21 09:31:17 -07:00
Kevin Sawicki
59ff3dc2f3 Merge pull request #6154 from electron/quit-role
Add quit menu item role
2016-06-21 09:20:22 -07:00
Kevin Sawicki
fbfac6d49b Fix lint errors 2016-06-21 09:08:13 -07:00
Kevin Sawicki
395c372702 Document quit role 2016-06-21 09:08:13 -07:00
Kevin Sawicki
32ea5a5e27 Remove CoffeeScript ref variables 2016-06-21 09:08:13 -07:00
Kevin Sawicki
2d8ec60eed Use const/let instead of var 2016-06-21 09:08:13 -07:00
Kevin Sawicki
11ba7eaa91 Add File > Exit menu on Windows 2016-06-21 09:08:13 -07:00
Kevin Sawicki
7a6436014e Use quit role 2016-06-21 09:08:13 -07:00
Kevin Sawicki
67f7b4d4c5 Map quit role to terminate selector 2016-06-21 09:08:13 -07:00
Kevin Sawicki
a16d907684 Add quit role 2016-06-21 09:08:12 -07:00
Heilig Benedek
3c92825e2a Fix init list order 2016-06-21 14:32:22 +02:00
Heilig Benedek
712141f153 Updated docs for beginFrameSubscription 2016-06-21 13:35:30 +02:00
Cheng Zhao
f45e6c6c38 Merge pull request #6161 from electron/refresh-menu-bar-color
Update menubar color when theme changes
2016-06-21 09:34:55 +00:00
Cheng Zhao
aca37c8974 Update menubar color when theme changes 2016-06-21 18:05:01 +09:00
Cheng Zhao
816b2ea8f2 linux: Disable parent window when showing modal dialogs (#6160) 2016-06-21 08:54:55 +00:00
Cheng Zhao
00f5fa440d Merge pull request #6159 from electron/tray-get-bounds 2016-06-21 16:38:03 +09:00
Cheng Zhao
9d63199c37 docs: Make tray.md follow docs style guide 2016-06-21 16:20:33 +09:00
Cheng Zhao
11f242a241 docs: Tray.getBounds() 2016-06-21 16:13:50 +09:00
Cheng Zhao
324153d394 win: Use DIP rect for tray icon's bounds 2016-06-21 16:05:28 +09:00
Cheng Zhao
886ef1717c win: Implement tray.getBounds() API 2016-06-21 15:49:22 +09:00
Cheng Zhao
db98e256f2 mac: Add tray.getBounds() API 2016-06-21 15:40:30 +09:00
Cheng Zhao
9993aab5b1 Update brightray for electron/brightray#228 2016-06-21 12:24:25 +09:00
Kevin Sawicki
8a9f2261d0 Add default error handler to remote promises (#6151)
* Add failing spec for unhandled main process exception

* Remove unused return

* Use let/const instead of var

* Add spec for unhandled rejection in renderer process

* Prevent unhandled rejection defaul

* Use once instead of on

* Add default fulfilled/rejection handler to promise
2016-06-21 00:54:15 +00:00
Charlie Hess
74321dce74 Add systemPreferences.subscribeLocalNotification. (#6150) 2016-06-21 00:48:42 +00:00
Heilig Benedek
3529f8a40a Frame subscriber bugfix + added only_damaged option 2016-06-21 02:42:00 +02:00
Heilig Benedek
a35915ee9f Merge pull request #11 from electron/master
update as upstream
2016-06-21 00:08:48 +02:00
Cheng Zhao
1837a938a1 Merge pull request #6147 from electron/open-item-in-folder
mac: Convert path to absolute path in ShowItemInFolder
2016-06-20 13:03:16 +00:00
Cheng Zhao
c9d5c4e45c mac: Convert path to absolute path in ShowItemInFolder 2016-06-20 21:14:17 +09:00
Cheng Zhao
b87cf3771b Merge pull request #6145 from electron/app-indicator-id
Use fixed ID for app indicators
2016-06-20 08:50:16 +00:00
Cheng Zhao
5e459b057e Use fixed ID for app indicators 2016-06-20 17:35:45 +09:00
Cheng Zhao
6bd1a2dec6 Merge pull request #6144 from electron/crash-release-renderer
Avoid calling Environment::GetCurrent for unjected contexts
2016-06-20 08:09:42 +00:00
Cheng Zhao
a3dd6c635f Avoid calling Environment::GetCurrent for unjected contexts
It seems to cause crashes when it is called for contexts that do not
have node integrations.
2016-06-20 16:51:42 +09:00
Cheng Zhao
3428874907 Merge pull request #6140 from electron/parent
Add support for child windows
2016-06-20 07:27:05 +00:00
Cheng Zhao
f7a9b1ae04 docs: modal window is greatly simplified 2016-06-20 16:00:38 +09:00
Cheng Zhao
5674e8d114 Only define enable/disable API for views 2016-06-20 15:44:50 +09:00
Cheng Zhao
e33e4be257 macOS: Use sheet window as modal window 2016-06-20 14:49:24 +09:00
Cheng Zhao
1866dbe608 Move disable counter to NativeWindow from api::Window 2016-06-20 11:48:46 +09:00
Cheng Zhao
946d246aea docs: Parent and child windows 2016-06-20 11:21:34 +09:00
Cheng Zhao
02acce8991 linux: Make modal dialog show more smoothly 2016-06-20 11:16:41 +09:00
Cheng Zhao
9aa7291627 linux: Implement win.disable/enable/isEnabled() API 2016-06-20 11:16:41 +09:00
Cheng Zhao
074903ca33 Do not emit "unresponsive" when there is modal dialog 2016-06-20 11:16:41 +09:00
Cheng Zhao
f4bec78ccb linux: Implement win.setParentWindow(parent) 2016-06-20 11:16:41 +09:00
Cheng Zhao
4c3c4437da win: Implement win.disable/enable/isEnabled() API 2016-06-20 11:16:41 +09:00
Cheng Zhao
a6c4bf098b spec: Avoid calling setParentWindow for unrelated tests 2016-06-20 11:16:41 +09:00
Cheng Zhao
85ba382027 Add "parent" option for BrowserWindow 2016-06-20 11:16:41 +09:00
Cheng Zhao
473413e874 views: Initial implementation of win.setParentWindow(parent)
But it doesn't work, aparrently Chromium doesn't support changing
parent window dynamically on desktop.
2016-06-20 11:16:41 +09:00
Cheng Zhao
f2cbd7cb36 mac: Add win.beginSheet(sheet)/endSheet(sheet) API 2016-06-20 11:16:41 +09:00
Cheng Zhao
2c5f4aadfb spec: Test cases for win.setModal(modal) 2016-06-20 11:16:41 +09:00
Cheng Zhao
1104dded24 Handle multiple modal windows correctly 2016-06-20 11:16:41 +09:00
Cheng Zhao
3f34f80433 Add win.setModal(modal) API 2016-06-20 11:16:41 +09:00
Cheng Zhao
1a4b4a65c9 mac: Add win.disable/enable/isEnabled() API 2016-06-20 11:16:41 +09:00
Cheng Zhao
214dd97165 spec: Test cases for parent window 2016-06-20 11:16:41 +09:00
Cheng Zhao
6cef29e4ee Add win.getChildWindows() API 2016-06-20 11:16:41 +09:00
Cheng Zhao
22513efd55 Add win.getParentWindow() API 2016-06-20 11:16:41 +09:00
Cheng Zhao
fb7e7b315c mac: Close all child windows before closing current window 2016-06-20 11:16:41 +09:00
Cheng Zhao
fd42e3dc84 mac: Add win.setParentWindow(parent) API 2016-06-20 11:16:41 +09:00
Cheng Zhao
e4d30ccfc3 spec: Suppress isCI test on CI 2016-06-20 11:16:17 +09:00
Cheng Zhao
a87fe61f3a Merge branch 'preco21-korean-docs-8' 2016-06-20 09:48:25 +09:00
Cheng Zhao
c44a6ad8b8 Merge pull request #6135 from blainesch/patch-1
Add copy/pasta example for system preferences.
2016-06-20 00:34:40 +00:00
Cheng Zhao
b4232d9230 Merge pull request #6128 from gerhardberger/webview-size-issue
Fixes transformed webview size
2016-06-20 00:13:30 +00:00
Plusb Preco
08782e319a 📝 Update Korean docs as upstream
[ci skip]
2016-06-20 03:23:36 +09:00
Plusb Preco
4c5fd1bf14 📝 Update Korean docs as upstream
[ci skip]
2016-06-20 02:18:51 +09:00
Machisté N. Quintana
786863a88f Merge pull request #6136 from MarshallOfSound/master
Fix typo in DevTools Extensions tutorial
2016-06-19 09:56:22 -07:00
Samuel Attard
ea38916c27 Fix typo in DevTools Extensions tutorial 2016-06-20 02:24:00 +10:00
Blaine Schmeisser
c75f3a8b5e Add copy/pasta example for system preferences.
Most of the other api docs have one example of where to find the module in a copy/paste format. This pull request adds one for the system preferences.
2016-06-19 08:53:34 -07:00
Cheng Zhao
c4c768ea8c Merge pull request #6134 from electron/chrome-51.0.2704.103
Update to Chrome 51.0.2704.103
2016-06-19 12:32:56 +00:00
Cheng Zhao
b74522d9f3 Merge pull request #6130 from rahatarmanahmed/fix-renderer-stdout
🐛 Don't load 'repl' unless needed
2016-06-19 12:32:06 +00:00
Cheng Zhao
ce2199d96a Update to Chrome 51.0.2704.103 2016-06-19 21:09:29 +09:00
Cheng Zhao
6d6f0cae62 Pyhton => Python, close #6126 2016-06-19 20:55:26 +09:00
Cheng Zhao
6f4899bd94 Merge pull request #6068 from electron/redispatch-events
Redispatch events to handle native OSX shortcuts
2016-06-19 11:22:02 +00:00
Cheng Zhao
d3bf400d56 Use class extension to avoid type conversion 2016-06-19 20:16:19 +09:00
Cheng Zhao
31d619f748 Merge pull request #6115 from electron/load-extension-when-added
Call loadExtension from addDevToolsExtension
2016-06-19 10:55:45 +00:00
Cheng Zhao
78193a0608 Merge pull request #6125 from leo/master
Replace "Mac OS" and "OS X" with "macOS"
2016-06-19 10:53:43 +00:00
Cheng Zhao
7c2c0ce709 Merge pull request #6105 from zephyrzoom/master
Update electron-faq.md
2016-06-19 10:11:32 +00:00
Rahat Ahmed
3c7c584444 🐛 Don't load 'repl' unless needed
Git bisect revealed that process.stdout failed to initiate (and was replaced with a write stream that does nothing) when the 'repl' module was loaded. This commit moves `require('repl')` so that it is only loaded when the --interactive flag is present.

Fixes #5051
2016-06-19 02:34:48 -05:00
gellert
3d010a8988 fixes transformed webview size 2016-06-19 00:41:42 +02:00
Leonard Lamprecht
511bf83fe7 Improved wording 2016-06-18 15:28:22 +02:00
Leonard Lamprecht
67dd19ed0f Replace OS X and Mac OS with macOS 2016-06-18 15:26:26 +02:00
Kevin Sawicki
754c4654d4 Add back window check 2016-06-17 16:23:54 -07:00
Kevin Sawicki
52350b5e35 Merge pull request #6116 from electron/extensions-app-ready
Mark which APIs are unavailable before app ready
2016-06-17 15:11:10 -07:00
Kevin Sawicki
6709e3c338 Mark which APIs are unavailable before app ready 2016-06-17 15:06:59 -07:00
Kevin Sawicki
df22082110 Call loadExtension from addDevToolsExtension 2016-06-17 14:53:51 -07:00
Kevin Sawicki
9afff89748 Merge pull request #6110 from electron/dan/iss6109
Fix context menus selecting first item by default.
2016-06-17 14:06:09 -07:00
Daniel Pham
a8a6f6f856 🍎 Fix context menus selecting first item by default. 2016-06-17 17:03:15 -04:00
Kevin Sawicki
c9fdd52f7e Upgrade brightray 2016-06-17 11:38:39 -07:00
Kevin Sawicki
13e554ab11 🎨 2016-06-17 11:32:56 -07:00
Kevin Sawicki
711c3abaeb Remove isKindOfClass check 2016-06-17 11:13:28 -07:00
Kevin Sawicki
0e65977a3c Use EventDispatchingWindow from brightray 2016-06-17 11:11:50 -07:00
Kevin Sawicki
3bc4f188ef Handle redispatch in devtools undocked windows 2016-06-17 10:27:53 -07:00
Kevin Sawicki
e0f06d582d Remove unneeded method declaration 2016-06-17 10:02:35 -07:00
Kevin Sawicki
1e73d48198 🎨 2016-06-17 09:13:00 -07:00
Kevin Sawicki
02abda4be8 Use isKindOfClass 2016-06-17 09:13:00 -07:00
Kevin Sawicki
b80f20912f Remove unused property 2016-06-17 09:12:59 -07:00
Kevin Sawicki
1762599df0 Remove unused variable 2016-06-17 09:12:59 -07:00
Kevin Sawicki
a2bbfea9e0 Redispatch events to handle native shortcuts 2016-06-17 09:12:59 -07:00
Kevin Sawicki
785ae8daef Merge pull request #6106 from mjudd/master
📝 Fix minor text issues.
2016-06-17 08:58:16 -07:00
Mark Judd
bf6133d61f 📝 Fix minor text issues. 2016-06-17 11:45:12 -04:00
707
ab41965124 Update electron-faq.md 2016-06-17 23:00:26 +08:00
Cheng Zhao
66fe1e48e8 Merge pull request #6095 from electron/protocol-ready-bug
Setup protocol after ready has already fired
2016-06-17 03:40:46 +00:00
Cheng Zhao
57ed682e34 Merge pull request #6091 from electron/icon-progress-crash
Fix crash setting progress after setting dock icon
2016-06-17 03:29:49 +00:00
Cheng Zhao
9a22aba308 Merge pull request #6090 from electron/web-navigation-api
Add webNavigation APIs to background pages
2016-06-17 03:21:16 +00:00
Cheng Zhao
0ccf49f7b8 Merge pull request #6097 from electron/should-set-tittle
Use the setTitleVisibility to control tittlebar's visibility
2016-06-17 03:21:04 +00:00
Cheng Zhao
6b20d6c189 Don't change the behavior of transparent window 2016-06-17 11:02:37 +09:00
Cheng Zhao
9eea973d31 Use the setTitleVisibility to control tittlebar's visibility 2016-06-17 10:54:50 +09:00
Cheng Zhao
d2a831aea5 Merge pull request #6089 from brave/window-menu
set the title for hidden and hidden-inset windows so they show up in …
2016-06-17 00:49:51 +00:00
Cheng Zhao
1a70fd8efe Merge pull request #6087 from electron/public-app-menu-getter
Make Menu.getApplicationMenu() public
2016-06-17 00:40:14 +00:00
Cheng Zhao
245f9cdd7d Merge pull request #6076 from electron/build-from-source
Update the using-native-node-modules.md
2016-06-17 00:21:57 +00:00
Kevin Sawicki
802fca28f7 Setup protocol after ready has already fired 2016-06-16 16:23:08 -07:00
Kevin Sawicki
a6e3eeee2d Merge pull request #6092 from electron/doc-typos
Minor doc typo fixes
2016-06-16 15:27:59 -07:00
Kevin Sawicki
a3b933f1f8 Fence block as yml 2016-06-16 15:26:58 -07:00
Kevin Sawicki
094098b571 Correct typos in docs 2016-06-16 15:19:38 -07:00
Kevin Sawicki
b6f87574ee Reset icon and clear progress bar 2016-06-16 15:01:37 -07:00
Kevin Sawicki
5f0238ebf4 Add subview whenever content view is empty 2016-06-16 14:57:23 -07:00
Kevin Sawicki
52525ef6bc Add failing spec for icon progress crash 2016-06-16 14:57:07 -07:00
bridiver
2094b39460 set the title for hidden and hidden-inset windows so they show up in the window menu list
fixes #6088
2016-06-16 13:12:53 -07:00
Machisté N. Quintana
296d49dc56 Make Menu.getApplicationMenu() public
Closes https://github.com/electron/electron/issues/6085
2016-06-16 12:43:01 -07:00
Kevin Sawicki
65abaee299 Forward will/did navigate events to extensions 2016-06-16 12:07:59 -07:00
Kevin Sawicki
64ae5cf5a1 Merge pull request #6084 from wolfgang42/master
Fix typo: 'arugments'
2016-06-16 10:46:58 -07:00
Wolfgang
b349c381fa 🎨 Fix typo: 'arugments' 2016-06-16 13:41:45 -04:00
Kevin Sawicki
567622c126 Drop unneeded .js extensions 2016-06-16 09:52:14 -07:00
Kevin Sawicki
3aecb11094 Extract Event clas to own file 2016-06-16 09:51:54 -07:00
Kevin Sawicki
7f9fa92e2d Add chrome.webNavigation stubs 2016-06-16 09:46:26 -07:00
Cheng Zhao
611791ea30 Update the using-native-node-modules.md 2016-06-16 17:10:57 +09:00
Cheng Zhao
58bce74255 Merge pull request #6071 from banyudu/patch-2
DocFixit: fix spell error
2016-06-16 05:19:26 +00:00
Cheng Zhao
0630b2d519 Merge pull request #6070 from banyudu/patch-1
DocFixit: fix spell error
2016-06-16 05:19:13 +00:00
Cheng Zhao
553341db87 Bump v1.2.3 2016-06-16 12:38:00 +09:00
Cheng Zhao
59fc30e6ae Merge pull request #6073 from electron/protocol-crash
Make api::Protocol thread safe
2016-06-16 03:35:37 +00:00
Cheng Zhao
9e947d3973 Merge pull request #6072 from electron/fix-crash-windows
Work around a compiler bug that crashes on Windows
2016-06-16 03:09:37 +00:00
Cheng Zhao
335cd8779c spec: Correctly cleanup the protocol test 2016-06-16 11:09:52 +09:00
Cheng Zhao
fe0e17d1c3 Make api::Protocol thread safe 2016-06-16 11:09:52 +09:00
Cheng Zhao
659384383e Avoid storing JobFactory in BrowserContext
JobFactory should always be created and accessed in IO thread.
2016-06-16 11:09:51 +09:00
Cheng Zhao
9372d4df32 Make sure BrowserContext is deleted after Protocol 2016-06-16 11:09:51 +09:00
Cheng Zhao
bb10551d23 Work around a compiler bug that crashes on Windows 2016-06-16 10:55:25 +09:00
Yudu Ban
17a4b61d54 fix spell error 2016-06-16 09:32:58 +08:00
Yudu Ban
d014f7fc76 fix spell error 2016-06-16 09:31:10 +08:00
Kevin Sawicki
9267004b53 Merge pull request #6052 from electron/doc-entitlements
Document entitlements needed for dialog APIs
2016-06-15 11:14:00 -07:00
Kevin Sawicki
2d6986d270 Merge pull request #6061 from zephyrzoom/master
Update online-offline-events.md
2016-06-15 11:11:30 -07:00
707
6567b4c8bf Update online-offline-events.md
漏掉了一个字
2016-06-15 19:30:02 +08:00
Cheng Zhao
efa667fa0a Merge pull request #6035 from electron/content-scripts-in-web-views
Load content scripts in webview devtools
2016-06-15 07:26:27 +00:00
Cheng Zhao
0615fbda84 Merge pull request #6053 from electron/flash-docs
Improve the docs on loading flash plugin
2016-06-15 01:31:32 +00:00
Cheng Zhao
e6ba0ac52a Merge pull request #6049 from electron/sys-executable
Include sys.executable in build libchromiumcontent args
2016-06-15 01:06:38 +00:00
Cheng Zhao
be90e2e9ff Improve the docs on loading flash plugin 2016-06-15 09:41:47 +09:00
Kevin Sawicki
ae6ffa6d5e unkown -> unknown 2016-06-14 15:47:33 -07:00
Kevin Sawicki
4e89656538 🎨 2016-06-14 15:47:33 -07:00
Kevin Sawicki
bf791c110f Tweak type check to consider windows and webviews 2016-06-14 15:47:33 -07:00
Kevin Sawicki
85517a1eea Add 2 spaces before comment 2016-06-14 15:47:33 -07:00
Kevin Sawicki
ee09c7534a Only add extensions to windows and webviews 2016-06-14 15:47:33 -07:00
Kevin Sawicki
f29801ad2b Add background page web contents type 2016-06-14 15:47:33 -07:00
Kevin Sawicki
ee0bab6389 Specify type instead of isGuest 2016-06-14 15:47:33 -07:00
Kevin Sawicki
c7b2545b1b Use web contents type enum and add converter 2016-06-14 15:47:32 -07:00
Kevin Sawicki
fc2b5eebc0 Remove unused includes 2016-06-14 15:47:32 -07:00
Kevin Sawicki
f25c1f864b Use RenderProcessPreferences for non-remote web contents 2016-06-14 15:47:32 -07:00
Kevin Sawicki
5c5fb0e39e Tweak documentation link 2016-06-14 15:24:05 -07:00
Kevin Sawicki
bfde8b02bb Drop the certain 2016-06-14 15:22:12 -07:00
Kevin Sawicki
54d1647a5c Mention dialog entitlements 2016-06-14 15:20:29 -07:00
Kevin Sawicki
45a9b0e0a5 Include sys.executable in build libchromiumcontent args 2016-06-14 11:49:54 -07:00
Kevin Sawicki
9223019af8 Merge pull request #6043 from JimiC/patch-1
Improved test exit
2016-06-14 10:07:57 -07:00
Jimi (Dimitris) Charalampidis
8121f913ca Improving test exit
Test should always exit (app.stop()) either on success or failure.
2016-06-14 16:36:54 +03:00
Cheng Zhao
12a35a05c6 Merge pull request #6038 from electron/check-alert
Fix exception in alert for inavlid parameter
2016-06-14 06:36:00 +00:00
Cheng Zhao
18a38dbfc1 Fix exception in alert for inavlid parameter 2016-06-14 15:22:01 +09:00
Cheng Zhao
b0f3443d72 Merge pull request #6037 from electron/auto-updater-wait
Use "--processStartAndWait" when launching Update.exe
2016-06-14 05:59:40 +00:00
Cheng Zhao
3f2c3e0448 Wait for current app to quit before launching new app 2016-06-14 14:31:41 +09:00
Cheng Zhao
f4c10060af Update brightray for #4261 2016-06-14 13:40:37 +09:00
Cheng Zhao
ae22980ee3 Merge pull request #6030 from electron/repl-error-on-windows
Log error when repling on Windows
2016-06-13 23:43:51 +00:00
Cheng Zhao
af722cc104 Merge pull request #6029 from electron/web-contents-created-app-api
Add web-contents-created event to app
2016-06-13 23:31:47 +00:00
Cheng Zhao
fcc7dc774a Merge pull request #6026 from electron/ready-to-show
Add "ready-to-show" event and docs on showing window gracefully
2016-06-13 23:24:14 +00:00
Kevin Sawicki
82d0d06d61 Log error when repling on Windows 2016-06-13 09:46:33 -07:00
Kevin Sawicki
f67e2043c8 Add back options param 2016-06-13 09:06:42 -07:00
Kevin Sawicki
d160be5daa Add web-contents-created event spec 2016-06-13 09:05:04 -07:00
Kevin Sawicki
88a81ef946 Doc web-contents-created 2016-06-13 09:01:06 -07:00
Kevin Sawicki
56001b481e Emit web-contents-created on app 2016-06-13 08:59:57 -07:00
Kevin Sawicki
c422613169 Merge pull request #6027 from Kushagra8888/patch-2
remove extraneous 'not'
2016-06-13 08:54:55 -07:00
Kushagra Sharma
61c0981ac7 remove extraneous 'not'
[ci skip]
2016-06-13 20:14:42 +05:30
Plusb Preco
e4cc55f86c 📝 Add missing changes
[ci skip]
2016-06-13 22:20:49 +09:00
Cheng Zhao
fc09c98bec Use once for 'ready-to-show' 2016-06-13 22:19:44 +09:00
Cheng Zhao
f7f86160c1 Only do the trick when window is hidden 2016-06-13 22:18:57 +09:00
Cheng Zhao
8a50a1b9d3 docs: Showing window gracefully 2016-06-13 22:11:40 +09:00
Cheng Zhao
4d65af3c60 Add ready-to-show event 2016-06-13 21:20:16 +09:00
Cheng Zhao
2dc453b4be Merge pull request #6023 from electron/ignore-focus
Add focusable option
2016-06-13 09:17:55 +00:00
Cheng Zhao
d92570a04b Merge pull request #6022 from tjctw/patch-1
Update mac-app-store-submission-guide.md
2016-06-13 08:53:55 +00:00
Cheng Zhao
e284deb7e1 docs: The side effect of focusable: false on Linux 2016-06-13 17:53:08 +09:00
Cheng Zhao
50f1837097 On Windows focusable: false also means skipTaskbar: true 2016-06-13 17:24:45 +09:00
Cheng Zhao
8eca728e0a Add focusable option 2016-06-13 17:10:28 +09:00
TJC
f255bb1b04 Update mac-app-store-submission-guide.md
typo
2016-06-13 16:07:35 +08:00
Cheng Zhao
5aecd10502 docs: Document the behavior of win.setIgnoreFocus on OS X 2016-06-13 16:40:02 +09:00
Cheng Zhao
ce00f4a273 Merge pull request #6013 from miniak/setIgnoreFocus
Add BrowserWindow.prototype.setIgnoreFocus
2016-06-13 07:18:10 +00:00
Cheng Zhao
927436de1a Merge pull request #6019 from preco21/korean-docs-7
docs: Update Korean docs as upstream
2016-06-13 06:43:41 +00:00
Cheng Zhao
04479b40a7 Merge pull request #6012 from miniak/menu-item-roles
Document 'zoom' role + add missing menu items (Delete / Paste and Match Style / Zoom)
2016-06-13 06:21:53 +00:00
Cheng Zhao
33a69fe50b Merge pull request #6008 from develar/patch-1
Add info about electron-builder to build windows installer
2016-06-13 06:16:53 +00:00
Plusb Preco
951aa72847 📝 Update Korean docs as upstream
[ci skip]
2016-06-13 12:19:37 +09:00
Cheng Zhao
4f1f0add27 docs: Reword the requirement of setApplication Menu 2016-06-13 10:52:12 +09:00
Cheng Zhao
9b566d8a40 Merge pull request #5999 from greggman/update-menu-docs-1
Document Menu.setApplicationMenu from main process
2016-06-13 01:42:47 +00:00
Cheng Zhao
8fe5dd22b2 Merge pull request #6018 from electron/string-map
Cleanup code for autoUpdater
2016-06-13 01:02:53 +00:00
Cheng Zhao
853d7b1b79 Merge pull request #5965 from electron/installed-extension-api
Add BrowserWindow.getDevToolsExtensions API
2016-06-13 00:45:58 +00:00
Cheng Zhao
26c4fc34cb Reset SQRLUpdater when setFeedURL is called 2016-06-13 09:41:14 +09:00
Cheng Zhao
a3786f66c9 Do not add JS wrapper for setFeedURL
When possible we should avoid adding wrappers in JS, it usually makes
code more difficult to mantain
2016-06-13 09:38:47 +09:00
Cheng Zhao
e2442fb052 Move converter for std::map to native_mate 2016-06-13 09:27:13 +09:00
Cheng Zhao
85379e3148 Merge pull request #5879 from miniak/autoUpdater
Add optional requestHeaders argument to autoUpdater.setFeedURL
2016-06-13 00:17:24 +00:00
Plusb Preco
68e99be9f6 📝 Update Korean docs as upstream
[ci skip]
2016-06-13 03:42:26 +09:00
Plusb Preco
bab8f6f60f 📝 Update Korean docs as upstream
* Small fixes

[ci skip]
2016-06-13 03:28:11 +09:00
Milan Burda
7a1d1ee0ea Add BrowserWindow.prototype.setIgnoreFocus 2016-06-12 20:20:57 +02:00
Plusb Preco
6176f65759 📝 Fix grammatical issue
[ci skip]
2016-06-13 02:51:47 +09:00
Plusb Preco
3ebf0fd335 📝 Update Korean docs as upstream
[ci skip]
2016-06-13 02:40:39 +09:00
Plusb Preco
d73d803a57 📝 Small fixes
[ci skip]
2016-06-13 02:28:25 +09:00
Milan Burda
f5699ad3a6 Document 'zoom' role + add missing menu items (Delete / Paste and Match Style / Zoom) 2016-06-12 19:21:52 +02:00
Milan Burda
c89d8b19b6 Add optional requestHeaders argument to autoUpdater.setFeedURL + allow calling mulitple times 2016-06-12 12:46:16 +02:00
Vladimir Krivosheev
109596501c Add info about electron-builder to build windows installer 2016-06-12 10:48:50 +02:00
Heilig Benedek
70aa706524 Merge pull request #10 from electron/master
update as upstream
2016-06-11 13:43:25 +02:00
Greggman
19c9170d6c Document Menu.setApplicationMenu from main process
You can't call Menu.setApplicationMenu until the app is ready.


[ci skip]
2016-06-11 14:09:53 +09:00
Jessica Lord
c68ca16148 Merge pull request #5974 from electron/chrome-storage-sync
Add chrome.storage.sync and chrome.storage.get APIs
2016-06-10 12:20:03 -07:00
Kevin Sawicki
88b62a33ab Merge pull request #5989 from electron/dan-remove-node-version-file
Bump .node-version file
2016-06-10 11:23:25 -07:00
Daniel Pham
47350bba8f ⬆️ node@6.1.0 2016-06-10 14:19:42 -04:00
Kevin Sawicki
4ab6429f1d Merge pull request #5986 from electron/doc-requires
Access remote from electron require
2016-06-10 10:27:57 -07:00
Kevin Sawicki
5e88abed7e Access remote from electron require in translated doc 2016-06-10 10:27:25 -07:00
Kevin Sawicki
9438ba3aaf Access remote from electron require 2016-06-10 10:24:35 -07:00
Jessica Lord
39e6081a00 🔥 line 2016-06-10 09:59:47 -07:00
Kevin Sawicki
f9b7033f43 Fix typo in example 2016-06-10 09:34:34 -07:00
Kevin Sawicki
2804272c7d Doc getDevToolsExtensions 2016-06-10 09:29:26 -07:00
Kevin Sawicki
1f245d5ff6 Add getDevToolsExtensions API 2016-06-10 09:26:38 -07:00
Kevin Sawicki
091682a039 Doc BrowserWindow.isDevToolsExtensionInstalled 2016-06-10 09:24:04 -07:00
Kevin Sawicki
0a26075699 Add BrowserWindow.isDevToolsExtensionInstalled API 2016-06-10 09:24:04 -07:00
Cheng Zhao
e824603f37 Merge pull request #5979 from cyberkatze/patch-7
fixed errors in text
2016-06-10 12:22:04 +00:00
Cheng Zhao
39b918fbfe Merge pull request #5978 from cyberkatze/patch-6
fixed errors in text
2016-06-10 12:21:58 +00:00
Cheng Zhao
0cbcc6db39 Merge pull request #5977 from cyberkatze/patch-5
fixed errors in text
2016-06-10 12:21:49 +00:00
Cheng Zhao
90a1b45135 Merge pull request #5975 from electron/disable-only-specs-on-ci
Log and exit when calling only in specs on CI
2016-06-10 12:11:31 +00:00
Cheng Zhao
4373dc1eac Merge pull request #5972 from electron/non-writeable-guest-id
Make guestId on BrowserWindowProxy non-writeable
2016-06-10 12:02:07 +00:00
Josh Bernitt
4219513457 issue 2813 add app name after Quit
Adding the application name after the Quit string for Mac OS systems.
2016-06-10 21:01:06 +09:00
Cheng Zhao
21081549fd Merge pull request #5967 from electron/window-opener-webview
Support window.opener from windows opened from a <webview>
2016-06-10 11:52:37 +00:00
Ali Elderov
538a4f61ee fixed errors in text 2016-06-10 08:39:28 +02:00
Ali Elderov
9bc536a95f fixed errors in text 2016-06-10 08:31:46 +02:00
Ali Elderov
cf4b40d3e6 fixed errors in text 2016-06-10 08:21:32 +02:00
Cheng Zhao
ccaf837da4 Merge pull request #5964 from electron/manifest-errors
Throw errors reading/parsing manifest.json files
2016-06-10 03:28:57 +00:00
Kevin Sawicki
34e01833d3 Merge pull request #5966 from electron/felix-docs-windows-store
Update Guide for Windows Store Apps
2016-06-09 17:36:55 -07:00
Kevin Sawicki
110f1f8b75 Tweak error message 2016-06-09 17:00:32 -07:00
Felix Rieseberg
8204412f9b 📝 Update Guide for Windows Store Apps
- Updated the guide to reflect that electron-windows-store no longer
   requires container conversion prerequisites
 - Added a link and a note about using background tasks to include
   UWP features
2016-06-09 16:59:42 -07:00
Kevin Sawicki
55a4e2589b Log/exit when only called in specs on CI 2016-06-09 16:56:25 -07:00
Jessica Lord
8fa4d66a5e Remove .only from spec 2016-06-09 16:39:42 -07:00
Jessica Lord
ede3dbd201 🚿 Lint 2016-06-09 16:39:24 -07:00
Jessica Lord
f121f46a24 Merge branch 'master' into chrome-storage-sync 2016-06-09 16:35:00 -07:00
Jessica Lord
dc10568917 Handle the three get cases 2016-06-09 16:26:42 -07:00
Jessica Lord
d6d4d51173 Fix spec case 2016-06-09 16:26:25 -07:00
Cheng Zhao
3dbef4ab8f Merge pull request #5959 from electron/download-item-interrupt
Add more bindings to DownloadItem
2016-06-09 22:50:34 +00:00
Kevin Sawicki
50f5025447 Merge pull request #5924 from electron/chrome-i18n-get-message
Implement chrome.i18n.getMessage
2016-06-09 14:47:37 -07:00
Kevin Sawicki
2efc913222 Remove standard lint warnings 2016-06-09 14:17:54 -07:00
Jessica Lord
d6b108b272 Add spec 2016-06-09 14:14:20 -07:00
Jessica Lord
41d6ddd588 Add storage file 2016-06-09 14:14:14 -07:00
Kevin Sawicki
01f96fe6af Default locale to en 2016-06-09 14:00:53 -07:00
Jessica Lord
0ed10658a3 Add spec 2016-06-09 13:57:51 -07:00
Kevin Sawicki
9f64c39f8c Remove lint warnings 2016-06-09 13:57:08 -07:00
Kevin Sawicki
2367cd574e Cache extension metadata 2016-06-09 13:57:08 -07:00
Kevin Sawicki
ea9d2dadf8 Add fixme for sync ipc 2016-06-09 13:57:08 -07:00
Kevin Sawicki
d4925e6226 Add initial support for placeholders and substitutions 2016-06-09 13:57:08 -07:00
Kevin Sawicki
d54de73e03 🎨 2016-06-09 13:57:08 -07:00
Kevin Sawicki
84960af793 Add initial chrome.i18n.getMessage API 2016-06-09 13:57:08 -07:00
Kevin Sawicki
939ae567ac 🎨 2016-06-09 13:53:36 -07:00
Kevin Sawicki
39180e6539 Get webContents from guestId 2016-06-09 13:50:42 -07:00
Kevin Sawicki
2f88bec177 Add guestId non-writeable assertions 2016-06-09 13:45:09 -07:00
Kevin Sawicki
2f93735909 Make BrowserWindowProxy guestId non-writeable 2016-06-09 13:41:42 -07:00
Kevin Sawicki
c8180ab301 Update spec description 2016-06-09 12:06:49 -07:00
Kevin Sawicki
a184b6afb3 Add spec for window.open from <webview> 2016-06-09 12:02:01 -07:00
Kevin Sawicki
bbc3a71c9f Use webContents id as guest id in opened windows 2016-06-09 11:29:38 -07:00
Kevin Sawicki
ebf9773269 Use const/let and removes CoffeeScript ref vars 2016-06-09 10:35:48 -07:00
Kevin Sawicki
6d3fc611bd Tweak duplicate extension message 2016-06-09 10:08:21 -07:00
Kevin Sawicki
f46edd5186 Throw errors reading/parsing manifest.json 2016-06-09 09:45:02 -07:00
Kevin Sawicki
d1ac5dd29b Add specs for manifest.json read/parse error 2016-06-09 09:44:49 -07:00
Kevin Sawicki
a3899f17f9 Merge pull request #5963 from agustinwang/patch-1
fix typo
2016-06-09 08:56:45 -07:00
agustin.wang
6f8893b42b fix typo 2016-06-09 23:16:46 +08:00
Cheng Zhao
054446a8bf Merge pull request #5958 from cyberkatze/patch-4
fixed errors in text
2016-06-09 12:06:58 +00:00
Cheng Zhao
cc6b812d96 Merge pull request #5957 from cyberkatze/patch-3
updated translation for README.md
2016-06-09 12:06:49 +00:00
Cheng Zhao
573a8320c1 Merge pull request #5956 from cyberkatze/patch-2
updated translation for supported-platforms.md
2016-06-09 12:06:37 +00:00
Cheng Zhao
cbcbcaeb41 docs: Make the example cover all cases 2016-06-09 20:57:29 +09:00
Cheng Zhao
dcad25c98c Add isPaused and canResume 2016-06-09 20:51:01 +09:00
Cheng Zhao
3f1dba3016 docs: Update DownloadItem for getState 2016-06-09 20:35:12 +09:00
Cheng Zhao
0321e23c7a Add DownloadItem.getState 2016-06-09 20:27:39 +09:00
Ali Elderov
c9e8c7f1b6 fixed errors in text 2016-06-09 10:38:28 +02:00
Ali Elderov
0dc49ca713 updated translation for README.md 2016-06-09 10:26:55 +02:00
Ali Elderov
8a2aa018ff updated translation for supported-platforms.md 2016-06-09 10:25:02 +02:00
Cheng Zhao
2ec5406ca6 Merge pull request #5904 from deepak1556/extension_partition_patch
browser: set up extension protocol handler for each browser context
2016-06-09 08:04:58 +00:00
Cheng Zhao
c6eda51b43 Merge pull request #5955 from enlight/fix-atom-taskbarhost-typo
Fix typo in `atom::TaskbarHost::InitializeTaskbar()`
2016-06-09 07:11:25 +00:00
Cheng Zhao
bfac5ba6f2 Merge pull request #5954 from agustinwang/patch-1
update `win` to `mainWindow`
2016-06-09 07:11:07 +00:00
Cheng Zhao
5f1e9d4ea7 Merge pull request #5952 from enlight/patch-3
Update Build System Overview doc
2016-06-09 07:07:32 +00:00
Vadim Macagon
a6f0fcf89f Fix typo in atom::TaskbarHost::InitializeTaskbar()
`InitailizeTaskbar` -> `InitializeTaskbar`
2016-06-09 12:21:21 +07:00
deepak1556
4749e18fc0 fix spec and docs 2016-06-09 10:48:05 +05:30
deepak1556
b91217f29e emit once for each session and add spec 2016-06-09 10:40:51 +05:30
deepak1556
cb5e648502 register extension handler for every session created 2016-06-09 10:40:51 +05:30
deepak1556
ebff40b5a5 add docs 2016-06-09 10:39:18 +05:30
deepak1556
aa853dd3be move protocol to session properties for working with partitions 2016-06-09 10:39:18 +05:30
deepak1556
0e0235407b fill net::URLRequest details on IO thread 2016-06-09 10:39:18 +05:30
deepak1556
414183e0fd fix dereferencing null pointer 2016-06-09 10:39:18 +05:30
agustin.wang
48a939ac7e 更新浏览器窗口变量名称
最新的 electron-quick-start 仓库中的变量已由 win 变更为 mainWindow
2016-06-09 12:55:07 +08:00
Cheng Zhao
d5bb7d7525 Merge pull request #5950 from VReality64/master
📝 Update Korean doc to a latest version.
2016-06-09 04:20:27 +00:00
Vadim Macagon
537c62a9a8 Update Build System Overview doc
`atom.gyp` was renamed to `electron.gyp` not long ago but this document wasn't updated.
2016-06-09 10:58:58 +07:00
Cheng Zhao
8a92ee403c Merge pull request #5945 from electron/default-title-to-app-name
Default window title to app name
2016-06-09 02:06:30 +00:00
Cheng Zhao
0abd55221d Merge pull request #5944 from electron/set-maximizable-last
Set maximizable state after installing view
2016-06-09 01:52:35 +00:00
Cheng Zhao
b422c47b67 Merge pull request #5943 from bbondy/master
Allow obtaining system Pepper Flash path
2016-06-09 01:48:53 +00:00
Cheng Zhao
20372f057e Merge pull request #5913 from electron/webview-devtools-extensions
Enable DevTools extensions in webviews
2016-06-09 01:45:55 +00:00
VReality64
9c10ecd13f 📝 Update Korean doc to a latest version.
[ci skip]
2016-06-09 09:59:14 +09:00
Kevin Sawicki
7d48827199 Default window title to app name 2016-06-08 14:17:33 -07:00
Kevin Sawicki
9f93f4e27f Set maximizable state after installing view 2016-06-08 13:56:45 -07:00
Brian R. Bondy
352a9cd6f2 Allow obtaining system Pepper Flash path 2016-06-08 16:40:15 -04:00
Kevin Sawicki
f33537336b Add default statement 2016-06-08 12:00:14 -07:00
Kevin Sawicki
4823a04a44 hookWindowForTabEvents -> hookWebContentsForTabEvents 2016-06-08 12:00:13 -07:00
Kevin Sawicki
11e68ff932 Only add extensions to non-remote webContents 2016-06-08 12:00:13 -07:00
Kevin Sawicki
c8c60dd313 Add devtools from web-contents-created event 2016-06-08 12:00:13 -07:00
Kevin Sawicki
d8fe5da3ea 🎨 2016-06-08 12:00:13 -07:00
Kevin Sawicki
ec8b9e3f35 Export loadDevToolsExtensions API to use in guest view manager 2016-06-08 12:00:13 -07:00
Kevin Sawicki
219d177731 Load extensions for all web contents 2016-06-08 12:00:13 -07:00
Kevin Sawicki
4f7bde38a9 Assert on tab id as well 2016-06-08 12:00:13 -07:00
Kevin Sawicki
bf47056561 Pluralize extension 2016-06-08 12:00:13 -07:00
Kevin Sawicki
78e3bb0660 🎨 2016-06-08 12:00:13 -07:00
Kevin Sawicki
4c1ede32cf Use destroyed event instead of closed event 2016-06-08 12:00:12 -07:00
Kevin Sawicki
4f46f75d8f Load dev tools extensions in webviews 2016-06-08 12:00:12 -07:00
Kevin Sawicki
19787544b5 Add failing spec for webview devtools extension 2016-06-08 12:00:12 -07:00
Kevin Sawicki
82bee12c00 Merge pull request #5911 from mafintosh/patch-1
support --abi
2016-06-08 11:57:16 -07:00
Mathias Buus
7dcb939338 support --abi 2016-06-08 20:55:06 +02:00
Kevin Sawicki
f4c1cd11a0 Merge pull request #5921 from electron/webview-show-definition-for-selection
Add showDefinitionForSelection to webContents/webview
2016-06-08 10:40:10 -07:00
Kevin Sawicki
7250c461be Remove NOTIMPLEMENTED() call 2016-06-08 10:21:28 -07:00
Kevin Sawicki
70996c79ba Add showDefinitionForSelection webContents proxy method 2016-06-08 10:19:43 -07:00
Kevin Sawicki
6337e93e6d Check for Mac in if block 2016-06-08 10:15:37 -07:00
Kevin Sawicki
c66299bf66 Document webview.showDefinitionForSelection 2016-06-08 10:15:36 -07:00
Kevin Sawicki
8c520cf158 🎨 2016-06-08 10:15:36 -07:00
Kevin Sawicki
6360a5cae4 Add deprecation TODO for BrowserWindow.showDefinitionForSelection 2016-06-08 10:15:36 -07:00
Kevin Sawicki
ce19c2c0ad Document webContents.showDefinitionForSelection 2016-06-08 10:15:36 -07:00
Kevin Sawicki
4f0a52628e Add showDefinitionForSelection to webContents/webview 2016-06-08 10:15:36 -07:00
Kevin Sawicki
e4398dde42 Merge pull request #5942 from enlight/patch-2
Fix location of code snippet in nativeImage docs
2016-06-08 09:36:42 -07:00
Vadim Macagon
8e2ae9b9e7 Fix location of code snippet in nativeImage docs
The code snippet for `nativeImage.createFromPath` somehow ended up in the wrong section of the document, this PR moves it back where it belongs.
2016-06-08 23:34:45 +07:00
Cheng Zhao
b2bea57eff Bump v1.2.2 2016-06-08 16:47:41 +09:00
Cheng Zhao
3cb5649f07 Merge pull request #5932 from electron/fix-standard-scheme
Fix crash when using fetch in custom protocols
2016-06-08 07:47:04 +00:00
Cheng Zhao
1bfbd215ea Don't rely on AddAdditionalSchemes for setting standard schemes
On Linux because of the existence of zygote process, it becomes very
tricky to correctly set standard schemes, basically we have to:
1. Pass --standard-schemes to both zygote and render processes
2. Init standard schemes for both zygote and render processes

The )1 is very hard to achieve, so instead of using
AddAdditionalSchemes, we just call url::AddStandardScheme directly.
2016-06-08 16:32:02 +09:00
Cheng Zhao
7108cc5f2b Mark standard scheme as safe scheme 2016-06-08 15:49:26 +09:00
Cheng Zhao
920ebee333 Make sure standard schemes are also set in child process 2016-06-08 15:46:50 +09:00
Cheng Zhao
1146b2d5c1 spec: Custom protocol can have "fetch" working in it 2016-06-08 14:44:30 +09:00
Cheng Zhao
2696c0a693 Merge pull request #5929 from electron/chrome-update
Update to Chrome 51.0.2704.84
2016-06-08 02:25:58 +00:00
Cheng Zhao
77dc08f2f9 Update to Chrome 51.0.2704.84 2016-06-08 11:08:24 +09:00
Cheng Zhao
2ed2db2068 Merge pull request #5928 from electron/bellow
bellow => below
2016-06-08 02:07:14 +00:00
Cheng Zhao
3ec4fcb3ec bellow => below 2016-06-08 11:03:01 +09:00
Cheng Zhao
6c5eaf6178 Merge pull request #5923 from electron/disable-blink-features
Support disabling Blink features
2016-06-08 02:00:30 +00:00
Cheng Zhao
013bd004c9 Merge pull request #5922 from ekonstantinidis/patch-1
Move example to the correct place
2016-06-08 01:57:56 +00:00
Cheng Zhao
d2331bc2c0 Merge pull request #5915 from electron/remove-result-collection
Remove unused results collection
2016-06-08 00:58:16 +00:00
Kevin Sawicki
02e0ca60ef Use lowercase param key 2016-06-07 16:35:23 -07:00
Kevin Sawicki
cd2041375b Add missing A in constant name 2016-06-07 16:31:16 -07:00
Kevin Sawicki
96012d6523 Remove trailing comma 2016-06-07 16:24:05 -07:00
Kevin Sawicki
f7b0bb2bf3 Add TODO about blinkFeatures -> enableBlinkFeatures 2016-06-07 16:23:09 -07:00
Emmanouil Konstantinidis
9b979f3b49 Move example to the correct place 2016-06-07 23:40:07 +01:00
Kevin Sawicki
c7f2c25bc9 Mention enabling/disabling 2016-06-07 13:59:30 -07:00
Kevin Sawicki
1b6a95adcb Document disableblinkfeatures attribute 2016-06-07 13:57:54 -07:00
Kevin Sawicki
636e356977 Document disableBlinkFeatures option 2016-06-07 13:56:33 -07:00
Kevin Sawicki
b941e25bf5 Link to RuntimeEnabledFeatures.in 2016-06-07 13:55:44 -07:00
Kevin Sawicki
ca6e3ed1ef Add webview support for disabled blink features 2016-06-07 13:49:31 -07:00
Kevin Sawicki
ae71cf3df1 Add disableBlinkFeatures option 2016-06-07 13:42:42 -07:00
Kevin Sawicki
ba762464d2 More let/const-ing 2016-06-07 10:29:29 -07:00
Kevin Sawicki
5c880b7c99 We -> we 2016-06-07 10:25:21 -07:00
Kevin Sawicki
ce1a9740f6 🎨 Use const and for/of loops 2016-06-07 10:24:48 -07:00
Kevin Sawicki
3bcb411e28 Don't collect unused results array 2016-06-07 10:24:33 -07:00
Cheng Zhao
4948bcc806 Merge pull request #5910 from electron/win-click-through
Implement win.setIgnoreMouseEvents for Windows and Linux
2016-06-07 12:05:07 +00:00
Cheng Zhao
5f838a1ee4 Merge pull request #5907 from VReality64/master
Update Korean documentation translation to a latest version
2016-06-07 11:39:25 +00:00
Cheng Zhao
e7754fa55a Merge pull request #5906 from ThaddeusJiang/master
update Quick Start Page[zh-CN]
2016-06-07 11:38:51 +00:00
Cheng Zhao
6192eef1b6 Update docs on win.setIgnoreMouseEvents 2016-06-07 20:32:52 +09:00
Cheng Zhao
f8b69c1fac Implement SetIgnoreMouseEvents for Linux 2016-06-07 20:23:29 +09:00
Cheng Zhao
cae25cab3e Implement SetIgnoreMouseEvents for Windows 2016-06-07 19:38:41 +09:00
VReality64
219bc2fc51 Update Korean documentation translation to a latest version 2016-06-07 19:19:21 +09:00
Cheng Zhao
fe4b957587 Merge pull request #5905 from electron/frameless-title
Fix title of frameless window showing as empty under fullscreen
2016-06-07 10:18:59 +00:00
jf_jiang
ece468681f fix outside link 2016-06-07 18:57:45 +09:00
jf_jiang
7e5f9fef52 update Quick Start Page[zh-CN]
Based on electron ver 1.1.3 update Quick Start Page[Simplified
Chinese].
2016-06-07 18:52:01 +09:00
Cheng Zhao
b444211d6f Fix title of frameless window showing as empty under fullscreen 2016-06-07 17:26:26 +09:00
Cheng Zhao
d3d2ca9a31 Merge pull request #5903 from electron/update-target-url
Add update-target-url event
2016-06-07 07:10:54 +00:00
Cheng Zhao
3c873736d7 Add update-target-url event 2016-06-07 15:56:19 +09:00
Cheng Zhao
1c504ec45d Merge pull request #5901 from electron/screen-docs
docs: Update the code sample of screen module
2016-06-07 05:04:55 +00:00
Cheng Zhao
1a22caabe8 docs: Update the code sample of screen module
* We should not require it before the ready event;
* There is no need to use electronScreen as name in the main process.
2016-06-07 13:56:57 +09:00
Cheng Zhao
08f8e06c55 Merge pull request #5894 from electron/chrome-runtime-id
Implement chrome.runtime.id
2016-06-07 01:54:58 +00:00
Cheng Zhao
2701ed6dd7 Merge pull request #5893 from electron/remove-extension-id-logging
Don't log devtools extension id
2016-06-07 01:54:16 +00:00
Cheng Zhao
243052742e Merge pull request #5898 from electron/native-module-signing
docs: Move "Sign Native Modules" to MAS Guide
2016-06-07 01:40:55 +00:00
Cheng Zhao
5fc64aea38 docs: Move "Sign Native Modules" to MAS Guide 2016-06-07 10:26:53 +09:00
Cheng Zhao
cb5f5660e1 Merge pull request #5890 from jpittner/patch-1
Update using-native-node-modules.md
2016-06-07 01:09:40 +00:00
Kevin Sawicki
61ce19ba7e Set chrome.runtime.id 2016-06-06 14:42:07 -07:00
Kevin Sawicki
d6311daea3 Add failing spec for chrome.runtime.id 2016-06-06 14:41:55 -07:00
Kevin Sawicki
a906336b1e Don't log extension id 2016-06-06 13:03:01 -07:00
Cheng Zhao
7e7186933f Merge pull request #5889 from electron/disable-gpu
Add app.disableHardwareAcceleration() API
2016-06-06 12:08:37 +00:00
jpittner
3edde9143b Update using-native-node-modules.md
Explains how native modules to be signed and packaged.
2016-06-06 13:46:34 +02:00
Cheng Zhao
02cfe30df9 Add app.disableHardwareAcceleration() API 2016-06-06 20:19:55 +09:00
Cheng Zhao
3e809901e0 Merge pull request #5888 from electron/linux-focus
Fix NativeWindow::Focus not moving focus to window
2016-06-06 08:26:47 +00:00
Cheng Zhao
32b692b60c Fix NativeWindow::Focus not moving focus to window
Chromium's implementation is somehow not working as expected, the new
implementation follows the behavior of wmctrl.
2016-06-06 16:59:31 +09:00
Cheng Zhao
438cab1f56 Merge pull request #5886 from electron/chrome-update
Update to Chrome 51.0.2704.79
2016-06-06 07:47:43 +00:00
Cheng Zhao
adec511891 Update to Chrome 51.0.2704.79 2016-06-06 15:59:07 +09:00
Cheng Zhao
14210174d3 Merge pull request #5883 from sethlu/update-mas-submission-guide
Update Chinese translation for MAS Submission Guide
2016-06-06 06:20:16 +00:00
Cheng Zhao
1066c1acaf Merge pull request #5882 from electron/felix-extension-warning-2
Log a warning if an extension's manifest cannot be parsed
2016-06-06 06:20:02 +00:00
Cheng Zhao
ec691a3a64 Merge pull request #5870 from danhp/missing-roles
Add 'delete' and 'pasteandmatchstyle' roles
2016-06-06 06:16:53 +00:00
sethlu
8cca8d66e3 Update Chinese translation 2016-06-06 09:57:07 +08:00
Daniel Pham
bd1eae86a1 Add 'delete' and 'pasteandmatchstyle' roles 2016-06-05 21:50:37 -04:00
Cheng Zhao
08f5322658 Merge pull request #5873 from sourenaraya/patch-1
Fix shared data example in FAQ
2016-06-06 01:48:13 +00:00
Felix Rieseberg
eb62abcc23 🎨 Log a warning if an extension's manifest cannot be parsed
Also logs a clean warning if an extension's manifest is incomplete,
missing, or can otherwise not be parsed.
2016-06-05 18:30:49 -07:00
Cheng Zhao
8847af0e54 Merge pull request #5859 from electron/felix-extension-warning
Log a warning if an extension has already been loaded
2016-06-06 01:22:47 +00:00
sourenaraya
506bc4db4c Fix shared data example
since `remote` module unaviable
2016-06-05 20:39:10 +10:00
Felix Rieseberg
b42e6583f7 🎨 Log a warning if an extension has already been loaded
If an extension has already been loaded (for instance because it’s
persisted), `addDevToolsExtension` will return nothing, which is
confusing. This adds a little `console.warn` to educate people about
what’s happening.

Closes #5854
2016-06-03 14:32:22 -07:00
Heilig Benedek
9aaa6c7a8f Merge pull request #9 from electron/master
update as upstream
2016-06-03 15:35:12 +02:00
Cheng Zhao
9d55424c48 Merge pull request #5849 from preco21/korean-docs-6
docs: Update Korean docs as upstream
2016-06-03 11:29:13 +00:00
Plusb Preco
6f8ebee3e8 📝 Update Korean docs as upstream
[ci skip]
2016-06-03 18:41:47 +09:00
Plusb Preco
d4ab4bee93 📝 Update Korean docs as upstream
[ci skip]
2016-06-03 18:37:46 +09:00
Plusb Preco
41f99187e7 📝 Update Korean docs as upstream
[ci skip]
2016-06-03 17:47:21 +09:00
Cheng Zhao
f59eecb1cc Merge pull request #5833 from CharlieHess/osx-global-defaults
Support array / dictionary types in getUserDefault
2016-06-03 08:36:44 +00:00
Cheng Zhao
567a7ed829 Merge pull request #5839 from sqrthree/patch-1
Correct wrong words
2016-06-03 04:50:58 +00:00
Cheng Zhao
4ec064d311 Merge pull request #5837 from electron/restart
Add app.relaunch API
2016-06-03 04:00:12 +00:00
Cheng Zhao
7f9e296f9c Merge pull request #5826 from Pym/patch-1
Add nuts link to the docs
2016-06-03 03:30:13 +00:00
Cheng Zhao
707d68f719 spec: Add test case for app.relaunch 2016-06-03 12:12:20 +09:00
Cheng Zhao
be6ed84ff2 args should always be checked 2016-06-03 12:08:45 +09:00
Paul Betts
4d8c73734c Merge pull request #5841 from envygeeks/patch-1
List all the possible folders for Linux.
2016-06-02 19:36:38 -07:00
Jordon Bedwell
020da553ff List all the possible folders for Linux.
Linux has several folders, depending on who is using the Linux install.  On our systems it could be any one of those depending on the user and what software they prefer to use, they all have the React plugin however, each one sits in a different folder.  I prefer Chrome because of Netflix, she prefers Chromium and we also have Chrome Beta available.
2016-06-02 20:29:25 -05:00
Kevin Sawicki
b0ccf6fd74 Merge pull request #5840 from electron/code-block-name
Correct typo in code block name
2016-06-02 09:40:07 -07:00
Kevin Sawicki
96ca8edbb4 javascript -> javascript 2016-06-02 09:39:17 -07:00
Plusb Preco
d234467682 📝 Update Korean docs as upstream
[ci skip]
2016-06-02 23:50:50 +09:00
sqrthree
2ef2c1af02 Correct wrong words
修正错别字
2016-06-02 22:35:40 +08:00
Cheng Zhao
d3fe80991c docs: app.relaunch 2016-06-02 22:06:27 +09:00
Cheng Zhao
91a9e67dca Provide a flexible API for app.relaunch 2016-06-02 21:49:29 +09:00
Cheng Zhao
3de41fb22d Correctly quotes the argv on Windows 2016-06-02 21:10:39 +09:00
Cheng Zhao
8435f1c900 Allow using current argv for relaunch 2016-06-02 20:48:36 +09:00
Cheng Zhao
9a08cbce27 Uniform when to use args or argv 2016-06-02 20:41:59 +09:00
Cheng Zhao
0d066de53e Make sure the new instance inherite cwd on mac 2016-06-02 20:32:29 +09:00
Cheng Zhao
0646f6ea9e Implement Relaunch on Windows 2016-06-02 19:49:36 +09:00
Cheng Zhao
a3f39e9d0b Implement Relaunch on Linux 2016-06-02 16:54:21 +09:00
Cheng Zhao
c3fe2dae9d Separate LaunchProgram from mac implementation 2016-06-02 16:23:46 +09:00
Charlie Hess
e377298cd2 Be consistent in spec organization. 2016-06-01 19:29:24 -07:00
Charlie Hess
fa3b17444f All we really need to do is make getUserDefault support array / object types. 2016-06-01 19:21:17 -07:00
Charlie Hess
587dd2fe51 Expose the method to JS and write a simple test. 2016-06-01 18:56:25 -07:00
Charlie Hess
0230567891 Write a new method that returns prefs under the NSGlobalDomain. 2016-06-01 18:55:20 -07:00
Charlie Hess
aa1b8cd74b Expose the NSArrayToListValue converter. 2016-06-01 18:53:49 -07:00
Cheng Zhao
060829da64 Separate implementations of RelauncherMain and RelauncherSynchronizeWithParent 2016-06-02 09:09:32 +09:00
Charlie Hess
10dcb10898 Merge remote-tracking branch 'upstream/master' 2016-06-01 14:38:49 -07:00
Kevin Sawicki
c3e9ce34a1 Merge pull request #5829 from electron/rename-frameworks-repo
Rename and move atom-shell-frameworks repo
2016-06-01 13:32:19 -07:00
Kevin Sawicki
789a878f07 Rename atom-shell-frameworks repo name and org 2016-06-01 13:25:36 -07:00
Pierre-Yves Jamon
3b11355521 Add nuts link to the docs
Add link to GitbookIO/nuts in the docs page for autoUpdater
2016-06-01 15:22:08 +02:00
Cheng Zhao
fc30a2a084 Use AtomCommandLine to process command line parameters 2016-06-01 22:15:50 +09:00
Cheng Zhao
6df18956cd Get ready to make relauncher cross-platform 2016-06-01 22:04:20 +09:00
Cheng Zhao
abdcb9d481 Implement app.relaunch on OS X 2016-06-01 18:22:14 +09:00
Cheng Zhao
7b3ba739bf Import chrome/browser/mac/relauncher.{cc,h} 2016-06-01 16:26:08 +09:00
Cheng Zhao
97dd71d79e Bump v1.2.1 2016-06-01 16:15:53 +09:00
Cheng Zhao
e46ef5a15a Merge pull request #5824 from electron/cleanup-web-contents
Cleanup the web-contents.js code
2016-06-01 07:14:31 +00:00
Cheng Zhao
8f49d43b69 Merge pull request #5781 from deepak1556/bluetooth_patch
webContents: add event to select bluetooth device
2016-06-01 06:40:08 +00:00
Cheng Zhao
f4dc8f6d26 Merge pull request #5823 from ColinEberhardt/patch-1
minor typo fixes
2016-06-01 06:34:57 +00:00
Cheng Zhao
01b10b3b39 Slightly improve docs of webContents.printToPDF 2016-06-01 15:32:37 +09:00
Cheng Zhao
0864d3b1ee Cleanup the printToPDF code 2016-06-01 15:32:37 +09:00
deepak1556
7434838463 fix docs 2016-06-01 11:44:29 +05:30
deepak1556
de4bff003f fix header paths and comments 2016-06-01 11:44:29 +05:30
deepak1556
db4dc4757a move bluetooth_chooser to atom/browser/lib 2016-06-01 11:43:39 +05:30
deepak1556
51daf8e194 add docs 2016-06-01 11:43:39 +05:30
deepak1556
a70749e80a browser: implement bluetooth chooser interface 2016-06-01 11:43:39 +05:30
Cheng Zhao
eb882855bc Cleanup the CoffeeScript converted code 2016-06-01 15:08:51 +09:00
Cheng Zhao
5bb8da6073 Explicitly initialize session before webContents 2016-06-01 14:57:35 +09:00
Cheng Zhao
523e8c2e1c Update libchromiumcontent and brightray for #5781 2016-06-01 14:53:05 +09:00
Cheng Zhao
0565c42add Merge pull request #5812 from vasumahesh1/feature-pdf
webContents: custom pageSize for printToPDF
2016-06-01 05:52:08 +00:00
Colin Eberhardt
89adc122c3 Minor typo fixes 2016-06-01 06:36:45 +01:00
Cheng Zhao
28c9dcc393 Merge pull request #5817 from electron/plist-vars
Add variables for plist paths
2016-06-01 04:33:27 +00:00
Cheng Zhao
15d32a9096 Merge pull request #5820 from electron/session-check
Throw error when session module is used before app is ready
2016-06-01 03:22:00 +00:00
Cheng Zhao
8dfbbcefc8 Throw error when session module is used before app is ready 2016-06-01 10:53:06 +09:00
Cheng Zhao
d105524135 Cleanup the JavaScript code of session 2016-06-01 10:42:24 +09:00
Kevin Sawicki
18f005092b Merge pull request #5819 from gjtorikian/patch-1
Fix typo
2016-05-31 17:56:16 -07:00
Garen Torikian
2aa1aedd92 Fix typo 2016-05-31 17:51:09 -07:00
Kevin Sawicki
606fc1a5b7 Add plist path variables 2016-05-31 16:48:03 -07:00
Vasu Mahesh
fc6628d159 Add: custom pageSize for printToPDF 2016-05-31 22:40:11 +05:30
Cheng Zhao
f5839c3a5b Merge pull request #5782 from electron/store-icons
Keep copies of window icons
2016-05-31 10:07:15 +00:00
Cheng Zhao
aea2135016 Keep copies of window icons 2016-05-31 17:47:45 +09:00
Plusb Preco
a454cc8260 📝 Update Korean docs as upstream
[ci skip]
2016-05-31 16:14:56 +09:00
Plusb Preco
31f2ac8bf3 📝 Update README.md
[ci skip]
2016-05-31 16:14:40 +09:00
Cheng Zhao
6c705fdd70 Merge pull request #5776 from electron/fix-node-output
Correctly redirect output to console on Windows
2016-05-31 03:19:58 +00:00
Cheng Zhao
4d8994df92 spec: child_process.fork shouble be able to pipe stdio 2016-05-31 11:05:58 +09:00
Cheng Zhao
381da76967 Correctly redirect output to console 2016-05-31 10:19:13 +09:00
Cheng Zhao
543d4bb2b1 Merge pull request #5770 from electron/clear-before-notice
Clear the buffers before notifying the other end of the pipe
2016-05-30 22:52:01 +00:00
Cheng Zhao
f02143b8f2 Clear the buffers before notifying the other end of the pipe 2016-05-30 22:38:01 +09:00
Cheng Zhao
0c93b21a5f Merge pull request #5769 from electron/fetch-job-cleanup
Refactor the URLRequestFetchJob code
2016-05-30 12:08:12 +00:00
Cheng Zhao
49f1278601 Refactor the URLRequestFetchJob code
This makes the read end and write end of the pipe have same logic, so it
is more easy to maintain.
2016-05-30 20:31:00 +09:00
Cheng Zhao
912cedc593 Merge pull request #5753 from deepak1556/url_request_fetch_job_patch
protocol: store initial response data for when resource loader becomes ready
2016-05-30 10:53:53 +00:00
Cheng Zhao
6e14a55817 Merge pull request #5768 from electron/fix-web-securiy-node-integration
Initialize script context in DidClearWindowObject
2016-05-30 08:01:48 +00:00
Cheng Zhao
ad3b3e0162 Merge pull request #5766 from kcrt/jpdocs
Japanese: add web-view-tag.md
2016-05-30 07:51:55 +00:00
Cheng Zhao
6755aa44f6 Initialize script context in DidClearWindowObject
Doing it in RunScriptsAtDocumentStart would somehow result in weird
results when webSecurity is off.
2016-05-30 16:34:28 +09:00
Cheng Zhao
ce0d3d93ab spec: disablewebsecurity should not break preload and node integration 2016-05-30 15:23:09 +09:00
TAKAHASHI Kyohei
5ab86cc2df 📝 trivial change in web-view-tag.md
There is a mistake about the information of `stopFindInPage`.
[ci skip]
2016-05-30 14:02:15 +09:00
TAKAHASHI Kyohei
12631a18c0 📝 Japanese: add web-view-tag.md 2016-05-30 13:59:43 +09:00
Cheng Zhao
7ec467e337 docs: Move the "Packaging Tools" out of "Rebranding" chapter 2016-05-30 10:37:32 +09:00
Cheng Zhao
a176aaee01 Merge pull request #5734 from danhp/fix-aspect-ratio
Fix 'setAspectRatio(0)' not resetting the default behaviour.
2016-05-30 01:14:03 +00:00
Cheng Zhao
3e41aebaa7 Merge pull request #5763 from electron/window-icon-size
Choose the correct icon size for Windows taskbar
2016-05-30 01:01:28 +00:00
Cheng Zhao
26fa963a70 Merge pull request #5720 from danhp/release-single-instance
Add 'app.releaseSingleInstance()'
2016-05-30 00:51:13 +00:00
Cheng Zhao
5a9eb5cfa6 Choose the correct icon size for Windows taskbar 2016-05-30 09:46:42 +09:00
Cheng Zhao
79cb648b6b Merge pull request #5726 from danhp/fix-context-menu
Fix context menus only showing on primary monitor.
2016-05-30 00:16:21 +00:00
Cheng Zhao
09796587b4 Remove trailing whitespaces and cleanup the code logic 2016-05-30 09:12:16 +09:00
Cheng Zhao
ec53e49fad Merge pull request #5718 from felixrieseberg/windows-fullscreenable
Fix setFullscreen() on Windows
2016-05-30 00:08:16 +00:00
Cheng Zhao
9f0fc96025 Merge pull request #5711 from electron/extension-code-cleanup
Implement partial chrome.* API for devtools extension
2016-05-29 23:29:08 +00:00
Plusb Preco
b78f7701e5 📝 Update Korean docs as upstream
[ci skip]
2016-05-30 01:59:32 +09:00
Daniel Pham
34af9794a2 Add test for 'setAspectRatio(0)' 2016-05-29 08:47:42 -04:00
deepak1556
9d8af43617 add spec 2016-05-29 13:43:26 +05:30
deepak1556
23fbb57d72 protocol: store response data when reader is not ready 2016-05-29 13:17:31 +05:30
Cheng Zhao
d1e56f416c Update the docs on using DevTools extension 2016-05-29 15:19:41 +09:00
Cheng Zhao
5f3fdbe635 Simplify the implementation of sendToAll 2016-05-29 12:10:32 +09:00
Cheng Zhao
de001a9bbf Use meaningful name for extensionId 2016-05-29 11:57:20 +09:00
Cheng Zhao
ec1944c146 Implement chrome.tab.onCreated/onRemoved APIs 2016-05-29 11:50:14 +09:00
Cheng Zhao
2431d886bf Current handle sender.tab for background pages 2016-05-29 10:46:48 +09:00
Cheng Zhao
dd804d7432 Enable specifying custom command line switches 2016-05-29 10:34:53 +09:00
Cheng Zhao
f693b042b5 Fix js lint warnings 2016-05-28 22:46:15 +09:00
Cheng Zhao
747f910ce0 Merge pull request #5736 from electron/missing-has-own-property
Support objects with no prototype over IPC
2016-05-28 13:42:30 +00:00
Cheng Zhao
3c7d94f2d9 Merge pull request #5742 from electron/duplicate-hidden-inset-check
Remove duplicate hidden-inset check
2016-05-28 13:42:15 +00:00
Cheng Zhao
f4fe60d126 Set default mimeType for BufferJob 2016-05-28 22:36:22 +09:00
Cheng Zhao
30dca2b4e1 Pages in chrome extension should not have node integration 2016-05-28 21:46:53 +09:00
Cheng Zhao
9ed4730cba Pass sender for chrome.runtime.onMessage 2016-05-28 21:45:23 +09:00
Cheng Zhao
5eb9ed1729 Implement chrome.tabs.sendMessage 2016-05-28 21:35:07 +09:00
Cheng Zhao
62fb4f9820 Implement chrome.runtime.sendMessage 2016-05-28 21:23:43 +09:00
Cheng Zhao
ba315248e0 Use ipcRenderer.sendTo to get rid of routers in main process 2016-05-28 21:13:00 +09:00
Cheng Zhao
a58b84bbd7 spec: ipcRenderer.sendTo sends message to WebContents 2016-05-28 20:50:30 +09:00
Cheng Zhao
ae1f442b02 Add ipcRenderer.sendTo 2016-05-28 20:50:28 +09:00
Cheng Zhao
d55b96fdf5 Clean up the Chrome API implementation code 2016-05-28 20:33:18 +09:00
Cheng Zhao
31628abadc Implement chrome.tabs.executeScript 2016-05-28 16:41:12 +09:00
Cheng Zhao
db94121360 Implement port.sender 2016-05-28 16:01:16 +09:00
Cheng Zhao
f5b430d9e1 Inject chrome.* to content scripts 2016-05-28 15:37:44 +09:00
Cheng Zhao
d8db695712 Handle port disconnecting 2016-05-28 12:07:08 +09:00
Cheng Zhao
599d3c147b Background pages and content script should be loaded on startup 2016-05-28 10:39:11 +09:00
Cheng Zhao
e76c36a9a8 Make simple runtime.connect work 2016-05-28 10:26:41 +09:00
Cheng Zhao
dfe7ae2124 Add webContents.fromId 2016-05-28 10:10:24 +09:00
Kevin Sawicki
5deb86d6f9 Merge pull request #5744 from aaronang/docs-improve-structure-of-source-code
📝 Indicate directories in the Structure of Source Code section
2016-05-27 15:41:28 -07:00
Aaron Ang
0a03dcd481 📝 Indicate directories in the Structure of Source Code section
[ci skip]
2016-05-28 00:22:47 +02:00
Kevin Sawicki
6e8945d7fa Merge pull request #5738 from electron/remove-deprecated-apis-from-docs
Remove deprecated APIs from the docs
2016-05-27 15:10:45 -07:00
Kevin Sawicki
1704b1ad53 Remove APIs that are no longer present 2016-05-27 15:08:29 -07:00
Kevin Sawicki
d02c1fbbf4 Merge pull request #5670 from electron/custom-fork-docs
Create guide for how to create your own from-source Electron fork
2016-05-27 14:34:49 -07:00
Kevin Sawicki
6add7f8d49 we -> it 2016-05-27 14:34:23 -07:00
Kevin Sawicki
ba6c8b531f Add ELECTRON_REPO example 2016-05-27 14:06:40 -07:00
Kevin Sawicki
82bc98ec3c Put - at end of previous line 2016-05-27 14:06:04 -07:00
Kevin Sawicki
1e28e3fc27 Add trailing slashes to directories 2016-05-27 14:06:04 -07:00
Kevin Sawicki
2effa32e3e Tighten up section title 2016-05-27 14:06:04 -07:00
Kevin Sawicki
f17e64e726 Tweak fork section 2016-05-27 14:06:04 -07:00
Kevin Sawicki
556b39c6f2 ATOM_SHELL -> ELECTRON in env vars 2016-05-27 14:06:04 -07:00
Kevin Sawicki
4734cbaf1c Move custom fork content to app distribution doc 2016-05-27 14:06:04 -07:00
Paul Betts
153a7f19ae Add notes on S3 directory structure 2016-05-27 14:06:04 -07:00
Paul Betts
0b27db2ef4 Create guide for how to create your own from-source Electron fork
This PR adds the notes on how to use Surf to build and upload a custom version of Electron
2016-05-27 14:06:04 -07:00
Kevin Sawicki
b465f2c3c4 Remove duplicate hidden-inset check 2016-05-27 13:27:35 -07:00
Kevin Sawicki
1e99f656cc Merge pull request #5737 from electron/browser-window-proxy-print
Add print() to BrowserWindowProxy
2016-05-27 11:33:08 -07:00
Kevin Sawicki
84f6015037 Call print on webContents 2016-05-27 11:11:55 -07:00
Felix Rieseberg
fa7f084625 📠 Add print() to BrowserWindowProxy
Closes #5685
2016-05-27 11:11:19 -07:00
Kevin Sawicki
fc4b224dec Add asserts for properties 2016-05-27 10:52:56 -07:00
Kevin Sawicki
59dd7ca9df Guard against object with no hasOwnProperty 2016-05-27 10:46:02 -07:00
Kevin Sawicki
7cf6be07a6 Add failing spec for remote property with no prototype 2016-05-27 10:45:39 -07:00
Kevin Sawicki
ac394ec3ef Merge pull request #5725 from electron/clipboard-api-names
Upper case initialisms in clipboard API
2016-05-27 09:09:12 -07:00
Daniel Pham
0c710fce33 🍎 Fix 'setAspectRatio(0)' not resetting the default behaviour. 2016-05-27 08:56:34 -04:00
Cheng Zhao
9ab76fb884 Add webContents.sendToAll to send message to all frames 2016-05-27 16:58:49 +09:00
Cheng Zhao
c1facec5a6 No need to hijack setInjectedScriptForOrigin 2016-05-27 15:12:49 +09:00
Cheng Zhao
134f9019eb Enable node integration for pages in devtools extension 2016-05-27 15:10:46 +09:00
Cheng Zhao
7e1f159185 Run content scripts at correct phase 2016-05-27 11:12:51 +09:00
Cheng Zhao
49d9446cce Implement a simple content script injector 2016-05-27 10:29:57 +09:00
Cheng Zhao
97c04735a2 Handle unloading devtools correctly 2016-05-27 09:55:59 +09:00
Cheng Zhao
a63ff714f8 Read content_scripts to preferences 2016-05-27 09:47:37 +09:00
Cheng Zhao
7eab259d92 Make it possible to only set preferences for BrowserWindow 2016-05-27 09:20:46 +09:00
Cheng Zhao
4fb9e20c33 Add API to set render process preferences 2016-05-27 08:51:02 +09:00
Daniel Pham
f4c3f0423a 🎁 Add 'app.releaseSingleInstance()' 2016-05-26 18:50:06 -04:00
Cheng Zhao
b646d7a55c The consts 2016-05-27 07:43:23 +09:00
Daniel Pham
b0c72adbe1 🍎 Fix context menus only showing on primary monitor. 2016-05-26 17:43:38 -04:00
Kevin Sawicki
23962e133e Use correct TODO format 2016-05-26 14:28:33 -07:00
Kevin Sawicki
efeb9647ff Update docs for new API names 2016-05-26 14:26:12 -07:00
Kevin Sawicki
71b73a9cfb Use new APIs 2016-05-26 14:24:47 -07:00
Kevin Sawicki
dc7316f52f Upper case abbreviations 2016-05-26 14:23:20 -07:00
Felix Rieseberg
836f8ab33c 🐛 Fix setFullscreen() on Windows
This ensures that a BrowserWindow responds to `setFullscreen(true)` if
`full screenable` was not defined during creation.

This bug was on Windows only.
2016-05-26 11:52:25 -07:00
Cheng Zhao
cdfbe876a5 Make sure chrome.devtools.inspectedWindow.tabId is set 2016-05-26 19:57:10 +09:00
Cheng Zhao
edd8210ae5 Add simple support for background page 2016-05-26 19:57:10 +09:00
Cheng Zhao
99c1434051 Store the original manifest file 2016-05-26 18:38:20 +09:00
Cheng Zhao
513b66f207 Cleanup chrome-extension.js after the Coffe2ES transfer 2016-05-26 18:38:20 +09:00
Cheng Zhao
f29598d907 getHostForPath => generateHostForPath
The original name implies no side effect, but is is not true.
2016-05-26 18:38:20 +09:00
Cheng Zhao
c1272743b9 Bump v1.2.0 2016-05-26 18:07:52 +09:00
Cheng Zhao
eeb996e92f Merge pull request #5710 from electron/chrome-lastest-stable
Update to Chrome 51.0.2704.63
2016-05-26 09:07:24 +00:00
Cheng Zhao
eb8284e285 Update to Chrome 51.0.2704.63 2016-05-26 18:06:55 +09:00
Cheng Zhao
20b09e9d03 Merge pull request #5701 from danhp/propagate-close
Properly notify observers when window prevents close
2016-05-26 05:33:55 +00:00
Cheng Zhao
93b8237e1f Merge pull request #5700 from felixrieseberg/standard-7
Implement JavaScript Standard Style 7
2016-05-26 04:57:36 +00:00
Cheng Zhao
8a4b7eb062 Merge pull request #5689 from cdaringe/master
Support non-native promises
2016-05-26 04:49:40 +00:00
Cheng Zhao
4ea7602871 Merge pull request #5684 from electron/webview-visibilitychange
Support document visibility and events in webviews
2016-05-26 01:07:24 +00:00
Cheng Zhao
fa1246ccf7 Merge pull request #5683 from electron/no-more-atom-shell
Rename remaining Atom Shell references
2016-05-26 01:06:36 +00:00
Cheng Zhao
0b9c11a5f2 Fix pylint warnings 2016-05-26 10:06:25 +09:00
Kevin Sawicki
4e44900930 Initialize guest_instance_id 2016-05-25 18:05:37 -07:00
Daniel Pham
d1c302800f Fix: Properly notify observers when window prevents close 2016-05-25 19:26:57 -04:00
Felix Rieseberg
bef6748c06 🎨 Implement JS Standard Code Style 7
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.

 * camelCase is now enforced
 * No assignments in return statements
2016-05-25 16:20:49 -07:00
Kevin Sawicki
75754804af Use auto for embedder var 2016-05-25 10:34:33 -07:00
Kevin Sawicki
88f665bc1b Restore original include location 2016-05-25 10:28:35 -07:00
Kevin Sawicki
814e4377a4 Restore original comment position 2016-05-25 10:26:59 -07:00
Kevin Sawicki
6632547b17 parent -> embedder 2016-05-25 10:26:20 -07:00
Kevin Sawicki
89ffa02d75 Tweak comment 2016-05-25 10:26:05 -07:00
Kevin Sawicki
b1ce57faa9 Remove redundant atom:: namespace use 2016-05-25 10:22:43 -07:00
Kevin Sawicki
03c6fbf80f 🎨 2016-05-25 10:20:00 -07:00
Kevin Sawicki
f58322891b Remove added switch/option 2016-05-25 10:17:35 -07:00
Kevin Sawicki
583bb49f6c Get hidden state by using parent window directly 2016-05-25 10:13:12 -07:00
Kevin Sawicki
69c69880e5 Tweak spec description 2016-05-25 09:12:52 -07:00
Kevin Sawicki
4e68a8d16e Remove logging in parent page 2016-05-25 09:12:52 -07:00
Kevin Sawicki
73b07f76a3 Support document visiblity state and events in webviews 2016-05-25 09:12:52 -07:00
Kevin Sawicki
1e15ce6ccd Add failing spec for webview visiblity changes 2016-05-25 09:12:52 -07:00
cdaringe
32073fa079 🎨 Support non-native promises 2016-05-25 10:11:18 -06:00
Kevin Sawicki
9684f61e12 atom_gyp -> electron_gyp 2016-05-25 09:10:46 -07:00
Kevin Sawicki
6c8cf16508 Deprecate ATOM_SHELL_GITHUB_TOKEN 2016-05-25 09:08:10 -07:00
Kevin Sawicki
43f0dfd0ab Deprecate old S3 env vars 2016-05-25 09:08:09 -07:00
Kevin Sawicki
1bdb9f3de0 Add fallback s3 config values 2016-05-25 09:08:09 -07:00
Kevin Sawicki
94c8b0e1b1 atom_shell -> electron 2016-05-25 09:08:09 -07:00
Kevin Sawicki
7e209dd982 ATOM_SHELL_INTERNAL_CRASH_SERVICE -> ELECTRON_INTERNAL_CRASH_SERVICE 2016-05-25 09:08:09 -07:00
Kevin Sawicki
8f1943bc7b Link to other apps 2016-05-25 09:08:09 -07:00
Kevin Sawicki
3dd2f709e0 Remove mention of Atom Shell 2016-05-25 09:08:09 -07:00
Cheng Zhao
b86ded3b54 Merge pull request #5688 from enlight/patch-1
Improve documentation of `ses.cookies.set()`
2016-05-25 10:44:33 +00:00
Cheng Zhao
3ef0947718 Merge pull request #5687 from electron/fix-invalid-parameter
Ignore invalid parameter error on Window
2016-05-25 07:03:33 +00:00
Vadim Macagon
c2633460eb Improve documentation of ses.cookies.set()
Fix description of the `details.url` param in `ses.cookies.set()`, and clarify the fact that cookies without an expiration date will not be retained between sessions.
2016-05-25 12:46:17 +07:00
Cheng Zhao
34c4e797bb Truncate the strings passed to google_breakpad::CustomInfoEntry 2016-05-25 14:46:15 +09:00
Cheng Zhao
545c9f5bed Ignore invalid parameter error in Electron 2016-05-25 14:46:15 +09:00
Cheng Zhao
4cd0de0e87 Merge pull request #5682 from electron/remove-old-run-as-node-env-var
Remove ATOM_SHELL_INTERNAL_RUN_AS_NODE support
2016-05-25 02:17:18 +00:00
Cheng Zhao
b1226a908b Update node: remove ATOM_SHELL_INTERNAL_RUN_AS_NODE 2016-05-25 10:55:02 +09:00
Cheng Zhao
f34cd8767c Merge pull request #5658 from danhp/handoff-fallback
Add fallback URL to handoff
2016-05-25 01:13:03 +00:00
Daniel Pham
eb0889de38 🍎 Add fallback URL to handoff. 2016-05-24 21:06:14 -04:00
Cheng Zhao
e97ce6f7e1 Merge pull request #5669 from felixrieseberg/build-instructions
Update Windows Build Instructions
2016-05-24 23:49:37 +00:00
Kevin Sawicki
89538b19ee Upgrade node for ELECTRON_RUN_AS_NODE change 2016-05-24 10:42:09 -07:00
Kevin Sawicki
b68d1ecb83 Remove ATOM_SHELL_INTERNAL_RUN_AS_NODE support 2016-05-24 10:17:57 -07:00
Kevin Sawicki
407a5d4415 Merge pull request #5681 from electron/default-app-error-handling
Tweak default app error handling
2016-05-24 10:15:56 -07:00
Kevin Sawicki
3e15021c12 Remove . after path to prevent confusion 2016-05-24 09:56:36 -07:00
Kevin Sawicki
ca72d4346b application -> app for consitency 2016-05-24 09:53:23 -07:00
Kevin Sawicki
74cde4e714 Log stack when available 2016-05-24 09:51:09 -07:00
Kevin Sawicki
48522d4b70 Remove custom MODULE_NOT_FOUND code check 2016-05-24 09:45:32 -07:00
Kevin Sawicki
63b84923ce Update copy 2016-05-24 09:43:25 -07:00
Kevin Sawicki
4a35206302 🎨 2016-05-24 09:42:31 -07:00
Kevin Sawicki
6de4249af8 Tweak resolve filename error message 2016-05-24 09:41:31 -07:00
Kevin Sawicki
deb15e60b5 Lead with package.json path 2016-05-24 09:38:04 -07:00
Kevin Sawicki
f691a46d4d Use dialog.showErrorBox 2016-05-24 09:37:52 -07:00
Kevin Sawicki
67c88d2f8a Move Module require to top 2016-05-24 09:33:55 -07:00
Kevin Sawicki
4d56437a26 Merge pull request #5610 from bigtimebuddy/master
The "Error opening app" dialog
2016-05-24 09:22:11 -07:00
Felix Rieseberg
2a7590529e 📝 Update Windows Build Instructions
Closes #5655
2016-05-24 06:12:07 -07:00
Cheng Zhao
28e2058ff1 Merge pull request #5648 from electron/chrome51
Update to Chrome 51
2016-05-24 10:59:11 +00:00
Cheng Zhao
1dd98171f4 Bump v1.1.2 2016-05-24 15:59:21 +09:00
Cheng Zhao
994cc62031 Merge pull request #5668 from electron/strip-ffmpeg
Strip ffmpeg in zip file
2016-05-24 04:33:09 +00:00
Cheng Zhao
cd444e82f9 Merge pull request #5666 from electron/remote-promise-reject
Handle rejection of remote promises
2016-05-24 04:30:25 +00:00
Cheng Zhao
9d924bb6d7 Merge pull request #5662 from electron/electron-require
Always return internal module when requiring electron
2016-05-24 01:46:36 +00:00
Cheng Zhao
995a20a125 Merge pull request #5653 from electron/menu-position-fix
Fix context menu not showing correctly in devtools
2016-05-24 01:02:48 +00:00
Kevin Sawicki
677a317274 Strip ffmpeg in zip file 2016-05-23 15:47:07 -07:00
Jessica Lord
1ba07a9d6d Merge pull request #5659 from danhp/patch-2
Mention that x and y have to be used together when creating new window
2016-05-23 15:44:42 -07:00
Kevin Sawicki
a4f94b89b4 Add comment about Module path 2016-05-23 15:15:39 -07:00
Kevin Sawicki
5e2f36387f Move require spec to api-app-spec 2016-05-23 15:14:55 -07:00
Kevin Sawicki
4a41311409 Test that calling regular module succeeds 2016-05-23 15:14:55 -07:00
Kevin Sawicki
6ac0151e65 Remove lint warnings 2016-05-23 15:14:55 -07:00
Kevin Sawicki
fe0ec67623 Add spec for electron module require 2016-05-23 15:14:55 -07:00
Kevin Sawicki
19fd841c30 🎨 2016-05-23 15:14:55 -07:00
Kevin Sawicki
566b0676bc Pre-resolve electron require path 2016-05-23 15:14:55 -07:00
Kevin Sawicki
daea448b61 .coffee -> .js 2016-05-23 15:14:55 -07:00
Kevin Sawicki
7929daa48c Pass both callback values to then 2016-05-23 15:07:01 -07:00
Kevin Sawicki
f3af1dbd54 Add failing spec for rejected remote promise 2016-05-23 15:06:46 -07:00
Matt Karl
ee61a2880a Removes main error, fixes messaging for JSON parse 2016-05-23 16:47:55 -04:00
Kevin Sawicki
1c9fe8d23e Merge pull request #5664 from electron/cibuild-ps1
Add a Windows script to just invoke cibuild
2016-05-23 13:07:18 -07:00
Paul Betts
52888c97b5 Add a Windows script to just invoke cibuild 2016-05-23 12:37:47 -07:00
Matt Karl
58d9d2cf41 Adds JSON parse, invalid and missing main field errors 2016-05-23 15:00:55 -04:00
Daniel Pham
5010150c8c 📝 Mention that x and y have to be used together when creating new window
[ci skip]
2016-05-23 13:00:43 -04:00
Cheng Zhao
3402c7be3f Suppress ffi test on Windows 2016-05-23 23:31:00 +09:00
Cheng Zhao
37a4267450 Update brightray: fix Windows linking problem 2016-05-23 23:24:43 +09:00
Cheng Zhao
2208b8bd6e Update symbol names of icu 2016-05-23 22:53:50 +09:00
Cheng Zhao
2edf559571 Update brightray: fix OS X linking problem 2016-05-23 22:05:26 +09:00
Cheng Zhao
0d4f1abdf9 Move the menu sightly higher when repositioning the menu
Otherwise the menu is not able to show the last menu item and the arrow
will show.
2016-05-23 21:54:06 +09:00
Cheng Zhao
b866b34ac8 The unit of position is CGFloat 2016-05-23 21:53:50 +09:00
Cheng Zhao
fca91db133 Fix showing context menu in devtools 2016-05-23 21:08:16 +09:00
Cheng Zhao
badecb49f3 Update brightray: fix Linux linking problem 2016-05-23 19:50:05 +09:00
Cheng Zhao
9f858e1243 Merge branch 'master' into chrome51 2016-05-23 19:49:43 +09:00
Cheng Zhao
c489d6d4b3 Merge pull request #5638 from deepak1556/iwa_patch
browser: flags to control iwa enabled server whitelist
2016-05-23 10:48:30 +00:00
Cheng Zhao
208acd1b9c Update brightray: Manage NetLog in BrowserClient 2016-05-23 19:02:40 +09:00
Cheng Zhao
1b9bced8c0 Merge pull request #5644 from leethomas/fix/osx-aspect-ratio
🍎  let Cocoa handle keeping aspect ratio on window resize
2016-05-23 08:15:44 +00:00
Cheng Zhao
f756a3e682 Fix crash when quitting 2016-05-23 17:03:49 +09:00
Cheng Zhao
44651656dd Fix building on Windows 2016-05-23 16:39:19 +09:00
Cheng Zhao
9d82041923 Fix js lint warnings 2016-05-23 16:15:39 +09:00
Cheng Zhao
d6f9e57e33 Fix chrome.devtools not available in devtools extensions 2016-05-23 16:04:37 +09:00
Cheng Zhao
de1fc9d432 Fix building on Linux 2016-05-23 15:27:01 +09:00
deepak1556
f68d0f324f deprecate app.allowNTLMCredentialsForAllDomains 2016-05-23 11:44:21 +05:30
Cheng Zhao
a92b4a6da4 Make |button| default to left button
This fixes the failing test of sendInputEvent.
2016-05-23 14:27:39 +09:00
Cheng Zhao
fa0ce7ad5f Adjust to the new behaviors of beforeunload handler 2016-05-23 14:27:39 +09:00
Cheng Zhao
06800940ec Fix cpplint warnings 2016-05-23 13:03:43 +09:00
Cheng Zhao
4b675a741d Init feature list in node process
It is a new dependency of gin.
2016-05-23 13:01:47 +09:00
Cheng Zhao
530f19e956 Fix crash due to site_instace being freed early 2016-05-23 12:57:46 +09:00
Cheng Zhao
899cdb48d7 Fix using invalid pointer as SiteInstance 2016-05-23 12:46:14 +09:00
Cheng Zhao
a2bd55dd3c Adapt to changes of Chrome 51 API changes (Part 2) 2016-05-23 12:29:14 +09:00
leethomas
de27b34891 disregard extraSize when initially setting the aspect ratio 2016-05-22 19:09:21 -07:00
Cheng Zhao
7ba391da7c Update to API changes of Chrome 51 2016-05-23 10:59:39 +09:00
leethomas
1d61f987cb code styling 2016-05-22 18:59:00 -07:00
Cheng Zhao
05c2999651 Update to Chrome 51.0.2704.54 2016-05-23 10:11:19 +09:00
Cheng Zhao
fd5f120434 Merge pull request #5646 from electron/update-breakpad
Fix crash reporter not working on x64 Windows
2016-05-23 00:25:24 +00:00
leethomas
09de0c2766 call base SetAspectRatio in NativeWindowMac implementation 2016-05-22 17:22:57 -07:00
leethomas
ac6e4aff5e comments 2016-05-22 17:00:14 -07:00
Cheng Zhao
13b4c8bb06 Ignore invalid parameter error in crash service process 2016-05-23 08:59:34 +09:00
leethomas
7aaf974362 override SetAspectRatio for NativeWindowMac 2016-05-22 16:50:50 -07:00
leethomas
8f7a04f9c3 🍎 let Cocoa handle keeping the aspect ratio whenever the edges are dragged 2016-05-22 15:43:47 -07:00
deepak1556
62cad610e0 bring back app.allowNTLMCredentialsForAllDomains 2016-05-23 01:52:09 +05:30
Cheng Zhao
4c531e909b Update breakpad to lastest master 2016-05-22 22:06:12 +09:00
Cheng Zhao
b52b6e12c4 Merge pull request #5640 from electron/update-crashpad
Update crashpad to latest master
2016-05-22 12:47:34 +00:00
Cheng Zhao
48b161f210 Update crashpad to 35da3b6 2016-05-22 21:00:16 +09:00
Cheng Zhao
06da5d543c Merge pull request #5622 from kcrt/jpmanual
Japanese manual: Update tutorials and api
2016-05-22 07:57:36 +00:00
Cheng Zhao
5267d734bb Merge pull request #5634 from deepak1556/net_error_description_patch
renderer: generate net error strings when requested
2016-05-22 00:34:56 +00:00
deepak1556
3db2daf790 browser: flags to control iwa enabled server whitelist 2016-05-21 23:38:50 +05:30
TAKAHASHI Kyohei
9d02292dec Japanese manual: modified template string
modified based on the comments from Flatta
[ci skip]
2016-05-22 00:22:51 +09:00
TAKAHASHI Kyohei
77eb0e8e3f Japanese manual: Update tutorials and api
[ci skip]
2016-05-22 00:17:20 +09:00
Cheng Zhao
6f3d0e1782 Merge pull request #5603 from leethomas/osx-horizontal-sheet-offset
Osx horizontal sheet offset
2016-05-21 14:07:53 +00:00
Cheng Zhao
6c8ffcf7a0 Merge pull request #5631 from electron/x64-by-default-win32
Default to amd64 on Windows
2016-05-21 13:39:25 +00:00
Cheng Zhao
363ab2075c Update libchromiumcontent for #5618 2016-05-21 20:48:06 +09:00
deepak1556
c9b314d43c renderer: generate net error strings when requested 2016-05-21 10:21:15 +05:30
Paul Betts
0e63050916 Default to amd64 on Windows 2016-05-20 14:20:48 -07:00
Kevin Sawicki
8821cae34f Merge pull request #5630 from electron/env-var-headings
Use ### for env var headings
2016-05-20 14:05:15 -07:00
Kevin Sawicki
f16f48aa7c Tweak example intros 2016-05-20 14:04:01 -07:00
Kevin Sawicki
e1d9229507 Tweak intro sentence 2016-05-20 14:03:28 -07:00
Kevin Sawicki
588420ecd2 Use active voice 2016-05-20 14:02:10 -07:00
Kevin Sawicki
d56c36b4a7 Minor wording updates 2016-05-20 14:01:08 -07:00
Kevin Sawicki
d983eb42e6 Use ### for headings for consistency 2016-05-20 13:58:48 -07:00
Matt Karl
b08393a663 Fixed linting error 2016-05-20 16:01:08 -04:00
Matt Karl
a1e59b814c Changed default button, updated link 2016-05-20 13:29:42 -04:00
Kevin Sawicki
f52cd31d0d Merge pull request #5625 from electron/doc-headings
Capitalize Object in doc heading
2016-05-20 10:01:54 -07:00
Kevin Sawicki
f266b979af Capitalize Object 2016-05-20 09:25:10 -07:00
Matt Karl
25cb0fcbb9 Added Learn More button 2016-05-20 11:04:10 -04:00
Cheng Zhao
8b9d189671 Merge pull request #5624 from electron/hicon
Feed Windows APIs with ICO icons of appropriate size
2016-05-20 14:30:00 +00:00
Cheng Zhao
3182485e68 No need to reference the icon in Tray 2016-05-20 22:44:02 +09:00
Cheng Zhao
a93c9462ed Add BrowserWindow.setIcon 2016-05-20 22:22:15 +09:00
Cheng Zhao
b33c04d041 docs: Recommend to use ICO icon 2016-05-20 19:58:47 +09:00
Cheng Zhao
d26480b74e Correctly set window icon from ICO 2016-05-20 19:46:05 +09:00
Cheng Zhao
ea2807c890 Make it possible to get different size of icons from ICO 2016-05-20 17:51:05 +09:00
Cheng Zhao
0059e7bcf9 Use LoadIconMetric to load correct icon 2016-05-20 17:12:07 +09:00
Cheng Zhao
9e26e5c121 Load HICON directly in NotifyIcon 2016-05-20 16:55:22 +09:00
Cheng Zhao
67d9ae27c3 Remove the JavaScript wrapper for setContextMenu 2016-05-20 16:18:38 +09:00
Cheng Zhao
adfd99f5f0 Convert to mate::Handle<NativeImage> instead of gfx::Image 2016-05-20 16:14:40 +09:00
leethomas
9196a9f334 update docs 2016-05-19 20:32:14 -07:00
leethomas
7d93642f42 extend setSheetOffset to accept an optional 2nd offset 2016-05-19 20:32:06 -07:00
Cheng Zhao
7c34d8333c Store ico image in HCION 2016-05-20 11:31:02 +09:00
Cheng Zhao
d5f3e5d59a Bump v1.1.1 2016-05-20 09:30:24 +09:00
Cheng Zhao
8ac93e02c6 Merge pull request #5616 from electron/inherit-zoom
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Cheng Zhao
4193fb1742 Merge pull request #5617 from electron/dont-return-from-on-functions
Remove returns from event listeners
2016-05-20 00:26:29 +00:00
Cheng Zhao
844f9e989b Merge pull request #5611 from jviotti/fix/invalid-archive-asar-exec
Override `child_process.execFile` asar patch for `child_process.exec`
2016-05-20 00:24:10 +00:00
Cheng Zhao
d6dffc570c Merge pull request #5614 from electron/bengotow-remote-docs
Update remote.md to mention enumerable property limitation
2016-05-19 23:54:20 +00:00
Cheng Zhao
4a075866de Merge pull request #5608 from Gaserd/patch-4
docs : Russian
2016-05-19 23:51:22 +00:00
Kevin Sawicki
cc7395eea8 Remove returns from event listeners 2016-05-19 15:28:08 -07:00
Kevin Sawicki
b09c81202a Add test for webview zoomFactor inheritance 2016-05-19 14:46:52 -07:00
Kevin Sawicki
4754e4aabb Add zoomFactor to guest params 2016-05-19 14:32:16 -07:00
Kevin Sawicki
fef2f789cd 🎨 2016-05-19 14:30:53 -07:00
Juan Cruz Viotti
1a27ecdad4 Override child_process.execFile asar patch for child_process.exec
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:

- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99

Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.

In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:

- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37

If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.

Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Ben Gotow
2bade868bb Update remote.md to mention enumerable property limitation
#5599
2016-05-19 09:31:02 -07:00
Matt Karl
e87ced60e5 The "Error opening app" dialog, now with less attitude 2016-05-19 10:33:22 -04:00
Sergey
836e2e4e91 docs : Russian
Russian language for http://electron.atom.io/docs/tutorial/mac-app-store-submission-guide/
2016-05-19 16:46:42 +03:00
Cheng Zhao
a2b6731bf2 Merge pull request #5606 from electron/process-docs
Cleanup the docs of process object
2016-05-19 11:59:37 +00:00
Cheng Zhao
983d611e96 Cleanup the docs of process object 2016-05-19 20:12:56 +09:00
Cheng Zhao
0bd3e28a05 Merge pull request #5526 from electron/process-stats
Process and System memory statistics API
2016-05-19 10:34:01 +00:00
Cheng Zhao
480f0fbfd7 Merge pull request #5600 from tensor5/update_clang_only_if_needed
Update Clang only if needed
2016-05-19 10:29:29 +00:00
Cheng Zhao
590c2bcf23 Merge pull request #5604 from preco21/korean-docs-5
docs: Update Korean docs as upstream
2016-05-19 10:27:03 +00:00
Cheng Zhao
8fd9957453 Merge pull request #5605 from preco21/document-fixes-5
docs: Improve docs
2016-05-19 10:26:38 +00:00
Cheng Zhao
e488320d37 Ignore failures of OS X on Travis CI 2016-05-19 19:23:02 +09:00
Cheng Zhao
195e0e64d0 Update brightray for #5578 2016-05-19 19:22:32 +09:00
Cheng Zhao
17528a4dfd Merge pull request #5578 from deepak1556/disable_http2_patch
browser: flag to disable HTTP/2 and SPDY/3.1 protocols
2016-05-19 10:21:36 +00:00
Cheng Zhao
53d0db0a28 Merge pull request #5602 from electron/static-linking-vs-runtime
Link with VS2015 libraries statically for Release build
2016-05-19 09:50:53 +00:00
Plusb Preco
d6ab81c1da 📝 Fix link to improve readability
[ci skip]
2016-05-19 18:36:26 +09:00
Plusb Preco
3ee9eef308 📝 Remove unused link
[ci skip]
2016-05-19 18:34:08 +09:00
Plusb Preco
9cbcd228f3 📝 Adjust line length to 80
[ci skip]
2016-05-19 18:32:43 +09:00
Plusb Preco
e1bf0ea2b4 📝 Adjust line length to 80
[ci skip]
2016-05-19 18:28:29 +09:00
Plusb Preco
5c8ecd8a97 📝 Small fixes
* Adjust line length to `80`.
* Fix typos

[ci skip]
2016-05-19 18:28:00 +09:00
Plusb Preco
2b7c3735bd 📝 Update Korean docs as upstream
[ci skip]
2016-05-19 17:22:51 +09:00
Cheng Zhao
f8c1db160e Only use the osfhandle hack on Windows 2016-05-19 17:02:40 +09:00
Cheng Zhao
e609a5bee2 Fix passing fd across modules 2016-05-19 16:38:37 +09:00
leethomas
eaacbc86c7 📝 update english docs to include setSheetOffsets 2016-05-18 23:59:25 -07:00
Cheng Zhao
4702d8b640 No need to download and ship vs runtime libraries 2016-05-19 15:49:26 +09:00
leethomas
359123458d 🍎 allow x-axis offset to be set for sheets 2016-05-18 23:45:54 -07:00
Cheng Zhao
d8c05ecc0d Link with Vs2015 runtime statically for Release build 2016-05-19 15:06:47 +09:00
Cheng Zhao
f441ba2694 Merge pull request #5601 from electron/team-id
Include team ID in the base bundle ID
2016-05-19 03:24:31 +00:00
Cheng Zhao
5d906c0e4e docs: Team ID is now required for signing 2016-05-19 11:13:09 +09:00
Cheng Zhao
a361d50b95 Add team ID to base Bundle ID 2016-05-19 10:57:57 +09:00
Nicola Squartini
18b2094198 Update Clang only if needed 2016-05-19 10:14:57 +09:00
Kevin Sawicki
1032287511 Merge pull request #5588 from brunoqueiros/error-message
Improve error message
2016-05-18 17:41:57 -07:00
Cheng Zhao
d3beaa0b16 Merge pull request #5595 from miniak/asar-fix
Make js2asar.py more robust
2016-05-18 23:40:11 +00:00
Bruno Queiros
046cb0df8d 🎨 Use the same stack trace for both cases 2016-05-18 19:02:42 -03:00
Kevin Sawicki
97d903bca3 Merge pull request #5587 from kcrt/master
Japanese manual: add electron-versioning.
2016-05-18 13:55:10 -07:00
Kevin Sawicki
0456be1535 Merge pull request #5594 from Gaserd/patch-3
Create supported-platforms.md
2016-05-18 13:52:47 -07:00
Milan Burda
161bd89a24 Make js2asar.py more robust 2016-05-18 12:54:53 -07:00
Sergey
5f9976c46a Create supported-platforms.md
Create new file - supported-platforms.
Russian language for this page - http://electron.atom.io/docs/tutorial/supported-platforms/
2016-05-18 22:40:12 +03:00
Paul Betts
872c6ea763 📝 2016-05-18 11:08:04 -07:00
Paul Betts
e995befcd0 Move everything into atom_bindings 2016-05-18 11:07:30 -07:00
Paul Betts
d49302858b Merge pull request #5589 from Gaserd/patch-2
исправление ошибки в слове
2016-05-18 10:57:53 -07:00
Sergey
d3e0c08255 исправление ошибки в слове
ничего критичного, просто букву не ту поставили.
2016-05-18 18:04:52 +03:00
Bruno Queiros
06e3e65c1b 🎨 Improve error message 2016-05-18 11:00:08 -03:00
TAKAHASHI Kyohei
962ce6c44c Japanese manual: add electron-versioning.
electron-versioning.md is translated.
Other tutorial files are updated.
[ci skip]
2016-05-18 22:33:21 +09:00
Cheng Zhao
e05f795d1d Merge pull request #5584 from electron/sandbox-no-expl
Enable sandboxing without using temporary-exception
2016-05-18 10:02:30 +00:00
Cheng Zhao
906948218f docs: Update MAS guide without using temporary-exception 2016-05-18 16:48:22 +09:00
Cheng Zhao
deddf98533 Currently set base bundle ID 2016-05-18 16:42:26 +09:00
Plusb Preco
d7fdb16078 📝 Update Korean docs as upstream
[ci skip]
2016-05-18 16:41:21 +09:00
Cheng Zhao
d2a567d6ab Merge pull request #5582 from electron/notification-user-info
Pass userInfo in systemPreferences.subscribeNotification
2016-05-18 07:36:31 +00:00
Cheng Zhao
3d0b98c9ca Use string description for unknown types 2016-05-18 16:01:08 +09:00
Cheng Zhao
68cf267b1d Do not convert NSDictionary to JSON 2016-05-18 15:49:33 +09:00
Cheng Zhao
240c346d02 Ignore invalid JSON object when converting NSDictionary 2016-05-18 14:54:37 +09:00
Cheng Zhao
97250b53e8 Pass userInfo in subscribeNotification 2016-05-18 14:40:19 +09:00
Cheng Zhao
49cca0978d Merge pull request #5580 from electron/annoymous-web-contents
Add support for anonymous WebContents
2016-05-18 05:31:10 +00:00
Cheng Zhao
87c10b3ac2 Make non-public module accesible via remote 2016-05-18 13:57:48 +09:00
Cheng Zhao
5f6c468f0f Handle keyboard events for WebContents that do not have owner window 2016-05-18 13:57:48 +09:00
Cheng Zhao
dc9b3fcef7 Remove WebViewGuestDelegate::HandleKeyboardEvent 2016-05-18 13:57:48 +09:00
Cheng Zhao
d6cb84f8a3 WebContents without owner window should always open detached devtools 2016-05-18 13:57:48 +09:00
Cheng Zhao
998ce73ad9 Add webContents.id property 2016-05-18 13:57:48 +09:00
Cheng Zhao
8a061b7183 A normal WebContents can have no owner window 2016-05-18 13:57:48 +09:00
Cheng Zhao
118afab67b Make sure BrowserContext is always destroyed after WebContents 2016-05-18 13:57:48 +09:00
Plusb Preco
7fd3149031 📝 Update Korean docs as upstream
[ci skip]
2016-05-18 12:15:29 +09:00
Cheng Zhao
242508e22f Merge pull request #5574 from electron/devtools-extension-test
Add test that loads a devtools extension
2016-05-18 01:46:44 +00:00
Cheng Zhao
5368da18ad Merge pull request #5575 from electron/link-to-spectron
Add spectron to ChromeDriver doc
2016-05-18 01:34:56 +00:00
deepak1556
467ccabb7e browser: flag to disable HTTP/2 and SPDY/3.1 protocols 2016-05-18 06:56:58 +05:30
Cheng Zhao
397d0e34ee Merge pull request #5559 from electron/disable-webview
Disable webview when nodeIntegration is off
2016-05-18 01:26:58 +00:00
Cheng Zhao
27da0f3338 Merge pull request #5576 from electron/title-tweaks
Tweak doc headings
2016-05-18 01:26:27 +00:00
Cheng Zhao
c7f5210b50 Merge pull request #5567 from felixrieseberg/versioning
Add Information about Versioning
2016-05-18 00:43:23 +00:00
Cheng Zhao
7bd11c14f6 Update brightray to fix linking problem on Linux 2016-05-18 09:42:38 +09:00
Kevin Sawicki
cee31ff67a Remove semicolon 2016-05-17 16:42:37 -07:00
Kevin Sawicki
9266f9abfc Update interval id variable name 2016-05-17 16:42:21 -07:00
Kevin Sawicki
f95c46d987 Show last panel by id 2016-05-17 16:40:34 -07:00
Kevin Sawicki
866260a2a6 with -> on 2016-05-17 16:05:47 -07:00
Kevin Sawicki
bfb75df49c Tweak doc headings 2016-05-17 16:02:54 -07:00
Kevin Sawicki
b301c473cd Simplify sentence 2016-05-17 15:14:50 -07:00
Kevin Sawicki
3f3871b1be Add spectron section 2016-05-17 15:13:26 -07:00
Kevin Sawicki
2043356fa3 Recommend electron-chromedriver 2016-05-17 15:09:09 -07:00
Kevin Sawicki
13cfc2d2a0 Add comment about panel switching via input event 2016-05-17 15:05:58 -07:00
Kevin Sawicki
8d0c5c30b8 Use consistent function styles 2016-05-17 15:05:27 -07:00
Kevin Sawicki
0b4b79d0a4 Use control on non-mac platforms 2016-05-17 15:01:32 -07:00
Kevin Sawicki
7db2601ea8 DRY up specs 2016-05-17 14:59:33 -07:00
Kevin Sawicki
77b074fbad Add spec for undocked devtools 2016-05-17 14:56:00 -07:00
Paul Betts
dc86ec8ddd Come Correct with Wrapping 2016-05-17 14:54:33 -07:00
Kevin Sawicki
189380d4ea Add spec for devtools extension 2016-05-17 14:52:45 -07:00
Paul Betts
bfb4867e10 🔥 old docs 2016-05-17 14:52:01 -07:00
Paul Betts
1623622073 Dox 2016-05-17 14:48:49 -07:00
Paul Betts
ae2eec3efa Move process-stats methods to process 2016-05-17 14:47:56 -07:00
Paul Betts
b51be9b83f Add docs 2016-05-17 14:47:56 -07:00
Paul Betts
60bc2acd6c Linting 2016-05-17 14:47:56 -07:00
Paul Betts
cd7bc0e50c Rename Metrics => MemoryInfo so it's consistent 2016-05-17 14:47:56 -07:00
Paul Betts
75362450cd Everything is in KB 2016-05-17 14:47:56 -07:00
Paul Betts
191b054ff0 Implement process and system memory statistics 2016-05-17 14:47:56 -07:00
Paul Betts
f4538daa0a Wire it up 2016-05-17 14:47:56 -07:00
Paul Betts
a7ac7ba4c1 Add the dumbest new builtin that works 2016-05-17 14:47:56 -07:00
Felix Rieseberg
7e09b1664a 📝 Add Information about Versioning 2016-05-17 20:20:25 +02:00
Plusb Preco
ee9e28dfdf 📝 Update Korean docs as upstream
[ci skip]
2016-05-17 21:18:31 +09:00
Cheng Zhao
fb6f5320e7 Update brightray for #5348 2016-05-17 20:33:44 +09:00
Cheng Zhao
7ce87c470a docs: webview is only available with nodeIntegration on 2016-05-17 17:10:33 +09:00
Cheng Zhao
90f52169af No more need to check for nodeIntegration when creating guest view 2016-05-17 17:06:02 +09:00
Cheng Zhao
0140015500 spec: WebView is disabled when nodeIntegration is disabled 2016-05-17 17:04:13 +09:00
Cheng Zhao
c1399f9bdc Disable webview when nodeIntegration is off 2016-05-17 16:51:06 +09:00
Cheng Zhao
3fedea4b9e Merge pull request #5557 from electron/osx-buttons
Implement titleBarStyle without using NSFullSizeContentViewWindowMask
2016-05-17 16:48:45 +09:00
Cheng Zhao
13bfb099a2 Fix the toolbar showing when titleBarStyle is hidden-inset 2016-05-17 16:25:18 +09:00
Cheng Zhao
f53aabaef5 Implement titleBarStyle without using NSFullSizeContentViewWindowMask 2016-05-17 15:48:14 +09:00
Cheng Zhao
ecbb088ea6 Merge pull request #5542 from stevekinney/standardize-requires
Standardize requires
2016-05-16 10:42:12 +09:00
Cheng Zhao
f5442a4888 Merge pull request #5540 from kcrt/master
Update: Japanese version of MAS submission guide
2016-05-16 10:33:25 +09:00
Cheng Zhao
57f082055a Merge pull request #5509 from electron/bengotow/dialog-titles
Add buttonLabel param to showOpen/showSave dialogs
2016-05-16 10:27:28 +09:00
Cheng Zhao
e53bfad018 Fix building on Windows 2016-05-16 10:09:41 +09:00
Steve Kinney
0d3d097ce8 💄 Standarize requires in JavaScript API 2016-05-15 09:41:30 -04:00
Steve Kinney
2317b56ac4 💄 Make the power-save-blocker a bit more concise 2016-05-15 09:36:13 -04:00
TAKAHASHI Kyohei
16c870191f Update: Japanese version of MAS submission-guide 2016-05-15 15:42:35 +09:00
Ben Gotow
54c654530e Fix linux support 2016-05-15 01:29:13 -05:00
Ben Gotow
6217d497ed Fix build issues 2016-05-15 01:03:32 -05:00
Ben Gotow
84cce6c2c1 Don't default to "Open", "Save", just let OS decide 2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d Add buttonLabel param to showOpen/showSave dialogs 2016-05-15 01:03:32 -05:00
Cheng Zhao
88f3c34412 Merge pull request #5532 from stevekinney/patch-2
💄 Use ES6; clean up CoffeeScript conversion in BrowserWindow module
2016-05-15 12:38:28 +09:00
Steve Kinney
fd9c9c3be7 💄 Use spread operator instead of arguments object 2016-05-14 22:33:21 -04:00
Steve Kinney
236810a923 💄 Use ES6; clean up CoffeeScript conversion
💄 Destructure app module

Address linting errors
2016-05-14 22:33:20 -04:00
Cheng Zhao
88dc73ec3f Merge pull request #5533 from stevekinney/patch-3
💄 Destructure globalShortcut module
2016-05-15 11:16:19 +09:00
Cheng Zhao
195a4bb3c1 Merge pull request #5538 from electron/vs2015-runtime
Ship with runtime libraries of Visual Studio 2015
2016-05-15 11:15:49 +09:00
Cheng Zhao
c540721bd3 Merge pull request #5537 from electron/suppress-more-tests
Suppress the tests that need to call window.open on Travis CI
2016-05-15 11:15:42 +09:00
Steve Kinney
c11d18fe06 💄 Destructure globalShortcut module
💄 Remove globalShortcut property

Add back the globalShortcut property
2016-05-14 21:53:42 -04:00
Cheng Zhao
8ed3659bb8 Link with libraries of Visual Studio 2015 2016-05-15 10:41:43 +09:00
Cheng Zhao
ba7a32b16e Sync submodule recursively 2016-05-15 10:33:23 +09:00
Cheng Zhao
800ab50b56 Download redist files of VS2015 2016-05-15 10:30:19 +09:00
Cheng Zhao
f43b9665c1 And increase timeout for the rest 2016-05-15 10:00:29 +09:00
Cheng Zhao
14906eb6c8 Merge pull request #5530 from stevekinney/patch-1
💄 Add ES6; Clean up from CoffeeScript conversion in app module
2016-05-15 09:57:49 +09:00
Cheng Zhao
c53e47265d Merge pull request #5535 from Godoy/translate-pt-br
Translate tutorial/devtools-extension.md to Portuguese (pt-br).
2016-05-15 09:47:29 +09:00
Cheng Zhao
5986a302d1 Merge pull request #5531 from kcrt/patch-1
wrong link destination
2016-05-15 09:46:59 +09:00
Cheng Zhao
f5acc8b599 Merge pull request #5525 from stanfieldr/doc-improvements
A little confused by docs
2016-05-15 09:45:43 +09:00
Cheng Zhao
e5af03547f Merge pull request #5534 from kcrt/master
Translate tutorial/security.md to Japanese.
2016-05-15 09:41:52 +09:00
Cheng Zhao
861a79dd6a Suppress the tests that need to call window.open on Travis CI 2016-05-15 09:41:02 +09:00
Cheng Zhao
5fe270a78f Merge pull request #5522 from Wolfer/patch-1
Update application-distribution.md
2016-05-15 09:38:31 +09:00
Steve Kinney
b1275420a3 Require download_items inline 2016-05-14 19:43:30 -04:00
Adriano Godoy
fb161d5f1f PT-BR link to devtools-extension tutorial on README.md 2016-05-14 16:06:11 -03:00
Adriano Godoy
6ac24f592c Translate tutorial/devtools-extension.md to Portuguese (pt-br). 2016-05-14 16:01:52 -03:00
TAKAHASHI Kyohei
88d158f2c1 Translate tutorial/security.md to Japanese. 2016-05-15 02:37:55 +09:00
Steve Kinney
e5036c0988 Use anonymous function for wrapping native classes 2016-05-14 12:28:28 -04:00
TAKAHASHI, Kyohei
0b5efcbc75 wrong link destination 2016-05-15 00:36:11 +09:00
Steve Kinney
0785c3bd15 💄 Add spaces to comply with Standard 2016-05-14 11:31:08 -04:00
Steve Kinney
5dc88aa543 💄 Add ES6; Clean up from CoffeeScript conversion 2016-05-14 11:17:46 -04:00
Cheng Zhao
5ec2e8d7e5 Merge pull request #5413 from electron/process-resource-usage
Fetch Process resource usage from WebContents
2016-05-14 23:28:51 +09:00
Cheng Zhao
3214fdd73f Fix failing CI on OS X 2016-05-14 23:11:13 +09:00
Cheng Zhao
d3e359ab2d No need for explicit type conversion 2016-05-14 22:50:05 +09:00
Cheng Zhao
c740438032 Rename webFrame.purgeCaches to webFrame.clearCache
This matches the name of session.clearCache.
2016-05-14 22:48:25 +09:00
Cheng Zhao
7459581d13 Fix cpplint warnings 2016-05-14 22:40:18 +09:00
Cheng Zhao
03052e81c1 Merge pull request #5519 from danhp/context-menu-docs
Fix indentation for context menu docs.
2016-05-14 21:49:16 +09:00
Daniel Pham
1bac1a9028 📝 Fix styling of the context-menu docs
[ci skip]
2016-05-14 08:43:23 -04:00
Cheng Zhao
de08473ea3 Merge pull request #5518 from danhp/popup-show-all
Fix context menu positioning on OS X
2016-05-14 20:00:30 +09:00
Robert Stanfield
2d46f6f66f It isn't entirely clear to me that 'window-all-closed' is used for
this purpose. I originally looked for an event that would fire if
all windows were closed and the reason was NOT due to the application
quitting; however, this differs in that it is called regardless of
whether the app was quitting.
2016-05-13 21:34:42 -04:00
Serg F
2287ad6d37 Update application-distribution.md 2016-05-13 23:19:56 +03:00
Paul Betts
2234307d41 Whitespace issues 2016-05-13 10:54:10 -07:00
Paul Betts
652913f8d6 Just return the type directly 2016-05-13 10:54:10 -07:00
Paul Betts
19cba3ff85 Use doubles to represent memory size in bytes 2016-05-13 10:54:10 -07:00
Paul Betts
6f0057532a Forgot scripts 2016-05-13 10:54:10 -07:00
Paul Betts
908084c0fd Document resource methods 2016-05-13 10:54:10 -07:00
Paul Betts
d83c36e0fd Add a way to drop all cached memory 2016-05-13 10:54:10 -07:00
Paul Betts
22a3765394 Wire up a new method in web frame 2016-05-13 10:54:10 -07:00
Paul Betts
61e775c055 Write native_mate converters for WebCache::ResourceTypeStat and friends 2016-05-13 10:54:10 -07:00
Daniel Pham
bebf8eabca 🍎 Fix context menu positioning 2016-05-13 10:54:40 -04:00
Cheng Zhao
847d9580b7 Bump v1.1.0 2016-05-13 17:00:02 +09:00
Cheng Zhao
faf896db67 Merge pull request #5461 from electron/chrome50
Continue the work of Chrome 50 upgrade
2016-05-13 14:52:09 +09:00
Cheng Zhao
10f144069d Allow using __weak keyword 2016-05-13 13:49:53 +09:00
Cheng Zhao
29b799de73 Update clang revision to 261368 2016-05-13 11:18:16 +09:00
Cheng Zhao
525d456f7c Update to Chrome 50.0.2661.102 2016-05-13 11:14:43 +09:00
Cheng Zhao
f1142cf2b5 Adapt to changes on hash functions of Chrome 50 2016-05-13 11:12:15 +09:00
Cheng Zhao
08779eb6d9 Use VS2015 on appveyor 2016-05-13 11:12:15 +09:00
Cheng Zhao
2d7b5c53b1 Change version number so native modules can build 2016-05-13 11:12:15 +09:00
Cheng Zhao
8dc8f8f485 Update libchromiumcontent: fix Release build on Windows 2016-05-13 11:12:01 +09:00
Cheng Zhao
4a409b870e chromedriver's version is now v2.21 2016-05-13 11:12:01 +09:00
Cheng Zhao
bb5b30b8a0 It is not allowed to run scripts in DidCreateDocumentElement 2016-05-13 11:12:01 +09:00
Cheng Zhao
906ae043f9 Fix crash when creating external buffer 2016-05-13 11:12:01 +09:00
Cheng Zhao
0ad03d9ff7 Suppress crashReporter test on x64 Windows for now 2016-05-13 11:12:01 +09:00
Cheng Zhao
3aaff23f78 Do not call import_vs_env for non-win32 2016-05-13 11:12:01 +09:00
Cheng Zhao
e77582baee Fix compilation warnings introduced by VS 2015 2016-05-13 11:12:01 +09:00
Cheng Zhao
2497c73009 Import build env from VS 2015 2016-05-13 11:12:01 +09:00
Cheng Zhao
73223fe5c3 Upgrade to Node v6 2016-05-13 11:12:01 +09:00
Cheng Zhao
9c0f298064 Update libchromiumcontent to fix renderer process crash 2016-05-13 11:12:01 +09:00
Cheng Zhao
525e3ee9c6 Update crashpad with AppKit patch 2016-05-13 11:11:50 +09:00
Cheng Zhao
9ccb495f60 Do not remove the patch for Command key 2016-05-13 11:11:50 +09:00
Cheng Zhao
35d9e37220 Simplify the check for web_frame_widget 2016-05-13 11:11:50 +09:00
Brian R. Bondy
e8c4fb6903 setBaseBackgroundColor moved to WebFrameWidget 2016-05-13 11:11:50 +09:00
Brian R. Bondy
a9652052c4 Update Brightray and libchromiumcontent v50 ref (Electron maintainer use
your refs)
2016-05-13 11:11:50 +09:00
Brian R. Bondy
a52dbf0784 Update SharedMemory buf constructor 2016-05-13 11:07:17 +09:00
Brian R. Bondy
900001e547 Update PlatformCanvas to SKCanvas 2016-05-13 11:07:17 +09:00
Brian R. Bondy
37ccd34a88 Update x11 global shortcut listeners 2016-05-13 11:07:17 +09:00
Brian R. Bondy
f93fa53aea Update linux menu overrides 2016-05-13 11:07:17 +09:00
Brian R. Bondy
0253aec0cd Add SkUserConfig.h with blank SkDebugf macro
This file was copied from:
./third_party/skia/include/config/SkUserConfig.h

But because of this linking error we needed to
define a macro for SkDebugf.

```
"SkDebugf(char const*, ...)", referenced from:
      SkBitmap::allocPixels(SkImageInfo const&, unsigned long) in
      libbrave_lib.a(brave_lib.native_desktop_media_list.o)
      ld: symbol(s) not found for architecture x86_64
```

There used to be a hack to copy this file here which was removed:
8de9d9e2bc
2016-05-13 11:07:17 +09:00
Brian R. Bondy
ce7c1023d5 Minimum fixes needed for chromium_src 2016-05-13 11:07:17 +09:00
Brian R. Bondy
02d72c81af Fix linking problem with IPC::MessageT
IPC::MessageT<ChromeUtilityHostMsg_ProcessStarted_Meta, std::__1::tuple<>, void>::MessageT(IPC::Routing)
2016-05-13 11:07:17 +09:00
Brian R. Bondy
22863b9f31 Fix GURL coonstructor from webkit string error 2016-05-13 11:07:17 +09:00
Brian R. Bondy
48e62ac0b5 Remove wwebaudio from web_preferences
Becauseit doesn't exist there anymore
2016-05-13 11:07:17 +09:00
Brian R. Bondy
732936713a GetNativeScreen -> GetScreen 2016-05-13 11:07:17 +09:00
Brian R. Bondy
f418ac5b5d Update to brave crashpad dep (Electron maintainer rebase this to use
your ref)
2016-05-13 11:07:17 +09:00
Brian R. Bondy
d889bdef49 Remove user_gesture parameter from PermissionManager::RequestPermission 2016-05-13 11:07:17 +09:00
Brian R. Bondy
c04353a845 WebFindOptions in its own header 2016-05-13 11:07:17 +09:00
Brian R. Bondy
ff91aeb5d4 Iterator to use size_t 2016-05-13 11:07:17 +09:00
Brian R. Bondy
8a2aebd03f PermissionStatus constant update 2016-05-13 11:07:17 +09:00
Brian R. Bondy
82f3bb26ce AccessTokenSet -> AccessTokenMap 2016-05-13 11:07:17 +09:00
Brian R. Bondy
2da39d31aa Update to new pref service location in components 2016-05-13 11:07:17 +09:00
Brian R. Bondy
5fda9bc6ae LoadAccessTokensCallbackType -> LoadAccessTokensCallback 2016-05-13 11:07:17 +09:00
Brian R. Bondy
93e9cf4ac1 No more GetCookieMonster 2016-05-13 11:07:17 +09:00
Brian R. Bondy
dc7928021d Widevine AAC CDM no longer avail
See chromium ./third_party /widevine/cdm/widevine_cdm_common.h
2016-05-13 11:07:17 +09:00
Brian R. Bondy
b78fe04f8f Remove Vorbis from CDM support
See https://codereview.chromium.org/1690353002
2016-05-13 11:07:17 +09:00
Brian R. Bondy
8d4ed037a2 Add referrer_schems to AddAdditionalSchemes 2016-05-13 11:07:17 +09:00
Cheng Zhao
57b0f288cb Bump v1.0.2 2016-05-13 09:21:33 +09:00
Cheng Zhao
ceea7adf98 Update brightray for electron/brightray#219 2016-05-13 09:19:46 +09:00
Cheng Zhao
751ebe7377 Merge pull request #5513 from danhp/patch-1
Document 'Tab' as a supported accelerator.
2016-05-13 09:08:32 +09:00
Cheng Zhao
c59f38c370 Merge pull request #5508 from electron/bengotow/docs-tweaks
Add to security checklist
2016-05-13 08:46:08 +09:00
Daniel Pham
9a72afc963 📝 Document 'Tab' as a supported accelerator.
[ci skip]
2016-05-12 16:00:58 -04:00
Ben Gotow
b9b6e8aa68 Add to security checklist 2016-05-12 10:42:29 -07:00
Cheng Zhao
b32bc8cf3e Merge pull request #5502 from anthonyryan1/master
Replace gtk_widget_hide_all with gtk_widget_hide
2016-05-12 19:37:25 +09:00
Cheng Zhao
01dcee6449 Update brightray for #5503 2016-05-12 18:01:03 +09:00
Machisté N. Quintana
83e3d059b4 Merge pull request #5504 from dalabarge/patch-1
Fixed grammar issue.
2016-05-11 19:29:36 -07:00
Daniel LaBarge
eef9d9beaf Fixed grammar issue. 2016-05-11 21:08:01 -05:00
Cheng Zhao
f86bd75f82 Merge pull request #5501 from ecmadao/patch-1
Update screen.md
2016-05-12 10:36:38 +09:00
Cheng Zhao
9a35d54ecf Merge pull request #5500 from radarhere/master
Fixed typo
2016-05-12 10:26:39 +09:00
Cheng Zhao
989dfe01e1 Merge pull request #5496 from deepak1556/linux_dialog_icon_patch
dialog: resize icon on linux before showing
2016-05-12 10:24:32 +09:00
ecmadao
b81742f335 Update screen.md
bugfix-修改错别字
2016-05-12 09:21:10 +08:00
Cheng Zhao
5a702425eb Merge pull request #5489 from felixrieseberg/windows-store-guide
Add Windows Store Guide
2016-05-12 09:30:18 +09:00
Cheng Zhao
f6d4af8882 Merge pull request #5487 from felixrieseberg/windows-dialog-array
Document Dialog Buttons Behavior on Windows
2016-05-12 09:26:28 +09:00
Andrew Murray
2d19d8108b Fixed typo 2016-05-12 08:14:17 +10:00
Anthony Ryan
c29b844a97 Replace gtk_widget_hide_all with gtk_widget_hide
gtk_widget_hide_all was deprecated in gtk+ 2.24 and was removed
entirely in recent versions. This is a pretty straight forward
replacement.
2016-05-11 15:33:43 -04:00
deepak1556
64718888dd dialog: resize icon on linux before showing 2016-05-11 22:30:10 +05:30
Cheng Zhao
064af6ecb2 Merge branch '1-0-release' 2016-05-11 22:11:08 +09:00
Cheng Zhao
959f7a1911 Merge pull request #5491 from electron/key-weak-map
Extend the IDWeakMap to accept arbitrary key type
2016-05-11 22:10:43 +09:00
Cheng Zhao
ff3104b44b hash function for pair is already defined in VS 2016-05-11 21:32:28 +09:00
Cheng Zhao
12d40cd310 Add typename hint to fix compilation error on VS2015 2016-05-11 20:57:21 +09:00
Cheng Zhao
759a46f3d6 Use DoubleIDWeakMap for |rendererFunctions| 2016-05-11 20:40:48 +09:00
Cheng Zhao
6578c4f0b3 Bump v1.0.1 2016-05-11 20:10:38 +09:00
Cheng Zhao
b2d83fd8a8 Merge pull request #5490 from electron/webcontents-event
Listen for devtools-opened on webContents
2016-05-11 19:59:09 +09:00
Kevin Sawicki
a32f50ef64 Use arrow function for this binding 2016-05-11 12:54:52 +02:00
Kevin Sawicki
1b2b7fc4ce Listen for devtools-opened on webContents 2016-05-11 12:48:46 +02:00
Cheng Zhao
49ac160ff7 Move createIDWeakMap to v8Util 2016-05-11 19:30:06 +09:00
Cheng Zhao
a077355d70 Turn api::IDWeakMap into api::KeyWeakMap<T> 2016-05-11 18:21:35 +09:00
Felix Rieseberg
ffa5abe99b 📝 Add Windows Store Guide
This commit adds a guide about how to compile your app as a Windows Store app, analog to the Mac App Store guide.
2016-05-11 10:50:46 +02:00
Felix Rieseberg
9200e32b0e 📝 Document Dialog Buttons Behavior on Windows
Closes #5464
2016-05-11 10:27:37 +02:00
Cheng Zhao
04d59991b0 Use create function instead of IDWeakMap constructor 2016-05-11 16:15:32 +09:00
Cheng Zhao
c708ae8eb5 Remove IDWeakMap 2016-05-11 15:51:22 +09:00
Cheng Zhao
ea93553225 Make KeyWeakMap a template class 2016-05-11 15:17:35 +09:00
Cheng Zhao
e6c0b1fe0c Fix leak when KeyWeakMap::Remove is called directly
Usually the KeyObject would be destroyed when GC happens, but then
Remove is called before GC happens, the KeyObject would be leaked
forever. This fixes it by keeping KeyObject as a member of map.
2016-05-11 15:17:35 +09:00
Cheng Zhao
79c1ad85f9 Add KeyWeakMap without Add method 2016-05-11 15:17:35 +09:00
Cheng Zhao
7f2a46cdd5 Remove unused methods of IDWeakMap 2016-05-11 15:17:35 +09:00
Cheng Zhao
2cd41b2f84 Merge branch 'master' of https://github.com/electron/electron 2016-05-11 15:15:15 +09:00
Cheng Zhao
0f52a6da39 Merge branch '1-0-release' 2016-05-11 15:14:56 +09:00
Cheng Zhao
71704fc5d8 Merge pull request #5486 from electron/fix-dump-version-info-js
Do not use require('app') in dump-version-info.js
2016-05-11 15:12:04 +09:00
Cheng Zhao
e5890728dc Do not use require('app') in dump-version-info.js 2016-05-11 15:07:09 +09:00
Cheng Zhao
08d2320ad6 Merge pull request #5485 from preco21/korean-docs-4
docs: Update Korean docs as upstream
2016-05-11 14:48:43 +09:00
Plusb Preco
95c9e48822 📝 Update Korean docs as upstream
[ci skip]
2016-05-11 13:48:40 +09:00
Machisté N. Quintana
8bb097e0a4 Merge pull request #5480 from preco21/patch-3
docs: Match object notation style
2016-05-10 21:27:45 -07:00
Plusb Preco
01c483e0dd 📝 Update README-ko.md
[ci skip]
2016-05-11 10:48:54 +09:00
Plusb Preco
4cdba29fbd 📝 Match object notation style
[ci skip]
2016-05-11 10:30:02 +09:00
Cheng Zhao
ed70a11ff8 Merge pull request #5477 from danhp/download-bounce
Add API: app.dock.downloadFinished(filePath)
2016-05-11 09:41:08 +09:00
Cheng Zhao
8dd5f58161 Merge pull request #5479 from electron/widevine-path
Fix passing paths in command line
2016-05-11 09:24:24 +09:00
Cheng Zhao
1d6f05c9bb Merge branch 'document-fixes-4' of https://github.com/preco21/electron into preco21-document-fixes-4 2016-05-11 09:23:52 +09:00
Cheng Zhao
d0b39bc4fe Merge pull request #5473 from preco21/korean-docs-3
docs: Update Korean docs as upstream
2016-05-11 09:20:51 +09:00
Cheng Zhao
dec971a889 Merge pull request #5471 from nickytonline/fix-readme
Fixed code snippet in read me
2016-05-11 09:12:01 +09:00
Cheng Zhao
0dad2581ef Fix passing paths in command line 2016-05-11 08:57:35 +09:00
Nick Taylor
b54af73782 fixed code snippet in menu api documentation. 2016-05-10 22:32:45 +02:00
Daniel Pham
6dae07b76f Add API: app.dock.downloadFinished(filePath) 2016-05-10 15:02:56 -04:00
Plusb Preco
ebc7f5cba0 📝 Remove whitespace
[ci skip]
2016-05-11 03:34:06 +09:00
Plusb Preco
c4d34eb465 📝 Update Korean docs as upstream
[ci skip]
2016-05-11 03:14:06 +09:00
Plusb Preco
5146befa46 📝 Match variable names
[ci skip]
2016-05-11 02:38:42 +09:00
Plusb Preco
885aeec442 📝 Match variable names
[ci skip]
2016-05-11 02:16:32 +09:00
Plusb Preco
f1b184ef78 📝 Fix code style issue
* Change `var` to `let`.
* Change `function() {}` to `() => {}`.
* Use shorthand function syntax on object notation.
* Remove spaces between object notation brackets.
* Small fixes.
2016-05-11 02:15:09 +09:00
Plusb Preco
139a4f984a 📝 Add missing semicolons
[ci skip]
2016-05-11 01:57:55 +09:00
Plusb Preco
6e0112bf9f 📝 Cleanup codes
[ci skip]
2016-05-11 01:34:51 +09:00
Plusb Preco
552102b88d 📝 Remove whitespace after code block
[ci skip]
2016-05-11 01:32:13 +09:00
Plusb Preco
4d7296e1db 📝 Match destructuring style
[ci skip]
2016-05-11 01:26:38 +09:00
Cheng Zhao
61bf3ae1ee Merge pull request #5462 from zicai/patch-1
Docs:fix a minor typo
2016-05-10 19:44:36 +09:00
Plusb Preco
5787bb0226 📝 Fix code style issue
* Match equality operators for consistent that `==`, `!=` by `===`,
`!==`.
* Match string expression notation `"` by `'`.

[ci skip]
2016-05-10 18:42:21 +09:00
zicai
8e48fde5ac Docs:fix a minor typo 2016-05-10 16:53:14 +08:00
Plusb Preco
3cc2dd216f 📝 Adjust line length to 80
[ci skip]
2016-05-10 17:41:16 +09:00
Plusb Preco
cd3d154cc3 📝 Small fixes
[ci skip]
2016-05-10 17:35:12 +09:00
Plusb Preco
6bad16377d 📝 Update Korean docs as upstream
[ci skip]
2016-05-10 16:27:14 +09:00
Cheng Zhao
3014e61792 Update native_mate: close #5392 2016-05-10 16:10:02 +09:00
Plusb Preco
12e62746b3 📝 Add security.md
[ci skip]
2016-05-10 13:48:26 +09:00
Cheng Zhao
61ec3acde9 Merge pull request #5459 from electron/soft-warning
Turn exception in protocol.registerStandardSchemes into warning warning
2016-05-10 11:11:00 +09:00
Cheng Zhao
8e7a5adc60 spec: protocol.registerStandardSchemes does not throw 2016-05-10 09:57:13 +09:00
Cheng Zhao
4dc431043f docs: When to use protocol.registerStandardSchemes 2016-05-10 09:53:35 +09:00
Cheng Zhao
566bb1f708 Turn the exception in protocol.registerStandardSchemes to warning 2016-05-10 09:53:35 +09:00
Cheng Zhao
ab3122ef2a No need to keep the deprecated APIs
They will be removed in next release.
2016-05-10 09:53:35 +09:00
Cheng Zhao
c40fb67890 Bump v1.0.0 2016-05-09 21:17:35 +09:00
Cheng Zhao
797b0ddb9a Fix exception when refreshing specs window 2016-05-09 20:08:50 +09:00
Cheng Zhao
e139012f9a Merge pull request #5373 from electron/remove-deprecated-apis
Remove deprecated apis
2016-05-09 19:16:38 +09:00
Plusb Preco
60d7dd991d 📝 Fix small typos
[ci skip]
2016-05-09 16:23:11 +09:00
Plusb Preco
897d376978 📝 Update Korean docs as upstream
[ci skip]
2016-05-09 16:20:05 +09:00
Plusb Preco
ad4450ec88 📝 Small fixes
[ci skip]
2016-05-09 11:23:46 +09:00
Plusb Preco
fe5dc5d28e 📝 Update Korean docs as upstream
[ci skip]
2016-05-09 10:43:52 +09:00
Cheng Zhao
af0afecb45 Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch
protocol: fix registerStandardSchemes api
2016-05-09 09:12:35 +09:00
Cheng Zhao
6b79f53416 Merge pull request #5440 from electron/bengotow/remove-default-protocol
Implement RemoveAsDefaultProtocolClient on OS X
2016-05-09 08:36:21 +09:00
Ben Gotow
ac905e7080 Add docs, avoid side effects when not currently default 2016-05-08 10:50:17 -07:00
deepak1556
70dac71639 delay protocol object creation 2016-05-08 16:44:14 +05:30
Cheng Zhao
4841e37502 Merge pull request #5445 from electron/fix-flaky-tests
Suppress the window.open tests on travis CI's mac machine
2016-05-08 16:44:29 +09:00
Cheng Zhao
c682ccd9d0 Suppress the window.open tests on travis CI's mac machine 2016-05-08 15:15:16 +09:00
Cheng Zhao
b358dff689 Merge pull request #5444 from electron/expiration-date
Fix `expirationDate` not showing for persistent cookies
2016-05-08 15:13:36 +09:00
Cheng Zhao
e24ce97731 Set expirationDate for persistent cookie 2016-05-08 14:38:07 +09:00
Cheng Zhao
1dcbd352cc Merge pull request #5436 from stevekinney/refactor-parse-args-in-dialog
Refactor parseArgs function in dialog module
2016-05-08 11:57:02 +09:00
Cheng Zhao
85f700f458 Merge pull request #5432 from stevekinney/default-app-to-es6
Update default_app to ES6 conventions
2016-05-08 11:21:01 +09:00
Cheng Zhao
3fcb4be303 Merge pull request #5418 from felixrieseberg/security-guide
Add Security Tutorial
2016-05-08 11:20:21 +09:00
deepak1556
9c71c9fa6a fix docs and spec 2016-05-08 01:37:57 +05:30
deepak1556
0f2ae385ed allow protocol module initialization before app ready.
* ensure registerStandardSchemes can only be called before app ready
 * ensure other protocol methods can only be used after app ready
2016-05-08 01:36:34 +05:30
deepak1556
1ff33b7c81 protocol: fix registerStandardSchemes api 2016-05-08 01:36:34 +05:30
Ben Gotow
19d5d3b7d1 Implement RemoveAsDefaultProtocolClient on OS X 2016-05-07 11:07:58 -07:00
Steve Kinney
91220f2a98 💄 Simplify conditional check for BrowserWindow 2016-05-07 09:13:40 -06:00
Steve Kinney
f3e633eb2c 💄 Use destructuring to shift arguments 2016-05-07 08:55:26 -06:00
Steve Kinney
6708e2a302 💄 Cache last argument in parseArgs
This is to eliminate the need to access the array twice.
2016-05-07 08:52:52 -06:00
Steve Kinney
b6fd4fed38 💄 Update default_app to ES6 conventions
Add space before object literal method
2016-05-07 08:18:22 -06:00
Felix Rieseberg
02e8e929e1 📝 Add Security Tutorial
Add basic information about Electron and Security, including an
invitation to contribute to security features. Contains information by
@zcbenz, @zeke, and @paulcbetts.
2016-05-07 10:57:36 +01:00
Cheng Zhao
b05fa2ed5b Merge pull request #5430 from deepak1556/ipc_renderer_patch
ipcRenderer: fix crash with multiple listeners to sync message
2016-05-07 16:32:54 +09:00
Cheng Zhao
e46a50512d Merge pull request #5428 from miniak/update-app-manifest
Update app manifest
2016-05-07 11:20:25 +09:00
Cheng Zhao
8f4b6afa64 Merge pull request #5431 from deepak1556/devtools_file_system_indexer_patch
devtools: handle file system indexing requests
2016-05-07 10:55:12 +09:00
Cheng Zhao
e6f4dd0f85 Update brightray for #5431 2016-05-07 10:54:34 +09:00
Cheng Zhao
767c235708 Fix compilation error 2016-05-07 10:38:41 +09:00
Milan Burda
bc8689889d Add dpiAware to app manifest instead of calling SetProcessDpiAwareness / SetProcessDPIAware 2016-05-07 01:18:01 +02:00
Milan Burda
bb32039fde Add disableWindowFiltering to app manifest to enable enumeration of modern app windows in node modules 2016-05-07 01:17:27 +02:00
deepak1556
53ac79cb19 devtools: handle file system indexing requests 2016-05-07 04:32:54 +05:30
Kevin Sawicki
081c8e1f28 Merge pull request #5426 from electron/vendor-link-in-docs
Link to vendor folder on GitHub
2016-05-06 13:31:23 -07:00
Kevin Sawicki
6861d645ad Link to vendor folder on GitHub 2016-05-06 13:25:01 -07:00
Kevin Sawicki
ef459c7676 Remove support for options now on webPreferences 2016-05-06 10:12:56 -07:00
Cheng Zhao
28f1aef7b4 Remove ELECTRON_HIDE_INTERNAL_MODULES in docs 2016-05-06 10:12:56 -07:00
Cheng Zhao
fd432ddbc9 Fix the toDataUrl call in desktopCapturer 2016-05-06 10:12:56 -07:00
Cheng Zhao
446da677b5 Remove NativeImage.toDataUrl 2016-05-06 10:12:56 -07:00
Kevin Sawicki
7685380105 Remove crashed event forwarding 2016-05-06 10:12:56 -07:00
Kevin Sawicki
56cd57872c Remove BrowserWindow events now on WebContents 2016-05-06 10:12:56 -07:00
Kevin Sawicki
f2d8eadf4e Remove deprecated prototol APIs 2016-05-06 10:12:55 -07:00
deepak1556
14661819c2 move session wrapper to webcontents 2016-05-06 10:12:55 -07:00
Kevin Sawicki
609f5dcaaf Update read path to something that exists 2016-05-06 10:12:55 -07:00
Kevin Sawicki
4d6b95aa52 Tweak spec description 2016-05-06 10:12:55 -07:00
Kevin Sawicki
0eefb282ca Test no handler via call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
722a07de86 Add explicit call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
30b60516fe Initialize session explicitly 2016-05-06 10:12:55 -07:00
Kevin Sawicki
814ae7b4a4 🎨 2016-05-06 10:12:55 -07:00
Kevin Sawicki
d627ead273 Remove linter errors 2016-05-06 10:12:55 -07:00
Kevin Sawicki
16d4c436cb Keep exporting deprecate/deprecations 2016-05-06 10:12:55 -07:00
Kevin Sawicki
7ad86a12b4 Remove empty _init 2016-05-06 10:12:54 -07:00
Kevin Sawicki
58473f41ab Remove deprecated BrowserWindow options specs 2016-05-06 10:12:54 -07:00
Kevin Sawicki
4cb620c195 Remove support for translating hyphenated options 2016-05-06 10:12:54 -07:00
Kevin Sawicki
bea232f53a Update specs for internal module require 2016-05-06 10:12:54 -07:00
Kevin Sawicki
ef801d5543 Remove .only call 2016-05-06 10:12:54 -07:00
Kevin Sawicki
1e140fb32c Remove ipc.js files 2016-05-06 10:12:54 -07:00
Kevin Sawicki
2ce4237083 Remove hideInternalModules API 2016-05-06 10:12:54 -07:00
Kevin Sawicki
dafa14fe42 Don't export deprecate API 2016-05-06 10:12:54 -07:00
Kevin Sawicki
bf91410a22 Remove deprecated main process ipc module 2016-05-06 10:12:54 -07:00
Kevin Sawicki
d988cae16d Remove deprecated ipc module 2016-05-06 10:12:53 -07:00
Kevin Sawicki
a6cf7a1095 Remove deprecated crashReporter.start options 2016-05-06 10:12:53 -07:00
Kevin Sawicki
6f0471f6cb Remove deprecated options check in BrowserWindow 2016-05-06 10:12:53 -07:00
Kevin Sawicki
0342db9328 Remove hyphenated options 2016-05-06 10:12:53 -07:00
Kevin Sawicki
dae68be2ce Remove deprecated APIs 2016-05-06 10:12:53 -07:00
Kevin Sawicki
0cf50b1c0b Merge pull request #5425 from electron/remove-atom-org-links
Update links to electron org in docs
2016-05-06 10:12:02 -07:00
Kevin Sawicki
7cca287b60 Update links to electron org 2016-05-06 10:11:43 -07:00
Kevin Sawicki
476aea5a3f Merge pull request #5424 from electron/windows-installer-docs
Link to electron-winstaller
2016-05-06 10:11:33 -07:00
Kevin Sawicki
f84b5a7642 Link to electron-winstaller 2016-05-06 10:05:12 -07:00
Kevin Sawicki
9a56974c83 Merge pull request #5423 from electron/fix-spacing-app-doc
Fix spacing on lines and url
2016-05-06 09:59:58 -07:00
Jessica Lord
0e8636cb2a Fix spacing on lines and url 2016-05-06 18:56:07 +02:00
Cheng Zhao
f58b3f853e Merge pull request #5421 from electron/default-app-flag
Add a flag indicating app is started from default app
2016-05-06 22:09:02 +09:00
Cheng Zhao
c18880bd77 Add a flag indicating app is started from default app 2016-05-06 21:49:49 +09:00
Cheng Zhao
7b83d920fa Merge pull request #5412 from electron/osx-disable-rubber-banding
Add scrollBounce option and disable it by default
2016-05-06 15:35:14 +09:00
Cheng Zhao
df397dab30 Add scrollBounce option and disable it by default 2016-05-06 14:57:43 +09:00
Cheng Zhao
4ce26dfa68 Merge pull request #5409 from electron/did-fail-load-clarification
Clarify how did-fail-load handles redirects
2016-05-06 14:27:46 +09:00
Cheng Zhao
16bfc19547 Merge pull request #5411 from electron/min-max-size-docs
docs: Make it clear that size constraints only apply for users
2016-05-06 14:24:59 +09:00
Cheng Zhao
a4405dad45 docs: Make it clear that size constraints only apply for users
[ci skip]
2016-05-06 14:21:19 +09:00
Cheng Zhao
aa516ae01a Merge pull request #5408 from electron/ld-update-code-of-conduct
📝 Update to v1.4 of the Code of Conduct
2016-05-06 10:41:25 +09:00
Charlie Hess
69c4c7e3be Clarify how did-fail-load handles redirects. 2016-05-05 15:52:00 -07:00
deepak1556
45b3bd3a22 ipcRenderer: fix crash with multiple listeners to sync message 2016-05-06 02:52:59 +05:30
Lee Dohm
edfb1b5d0e 📝 Update to v1.4 of the Code of Conduct
Also, switch email address for reporting.
2016-05-05 13:48:44 -07:00
Cheng Zhao
969a30fc3b Merge branch 'update-code-samples' of https://github.com/stevekinney/electron into stevekinney-update-code-samples 2016-05-05 20:55:25 +09:00
Cheng Zhao
636570306a Merge pull request #5401 from electron/ns-js-object
Fully support the userInfo object in app.setUserActivity and continue-activity event
2016-05-05 17:59:43 +09:00
Cheng Zhao
2c31d7c1e8 Revert "Generalize this mate converter for reuse."
This reverts commit 92606579d3.
2016-05-05 17:26:31 +09:00
Cheng Zhao
c9c4ba39ab docs: We support arbitrary NSDictionary now 2016-05-05 17:07:46 +09:00
Cheng Zhao
2f9fee0c8a Move the job of creating userActivity to AtomApplication 2016-05-05 16:38:47 +09:00
Cheng Zhao
60bd60e1ed Fully support converting NSDictionary to JS userInfo object 2016-05-05 16:26:44 +09:00
Cheng Zhao
8e1d2479ac spec: Should not run app.setUserActivity test on non-OS X 2016-05-05 12:27:25 +09:00
Cheng Zhao
7268f434b2 Fix code styling problems 2016-05-05 12:26:23 +09:00
Cheng Zhao
3f2a25d07c Merge pull request #5352 from CharlieHess/hands-on-hand-off
OS X Handoff Feature
2016-05-05 12:06:56 +09:00
Cheng Zhao
f10ab71f60 Merge pull request #5388 from electron/default-app-styling
Make the drag box fill the remaining height of window in default app
2016-05-05 11:16:16 +09:00
Cheng Zhao
4b42fe1b24 Merge pull request #5393 from appetizermonster/patch-2
Fix small mistakes in Korean Doc
2016-05-05 11:15:35 +09:00
Cheng Zhao
0901a70166 Merge pull request #5379 from danhp/context-menu
Expose the 'context-menu' event.
2016-05-05 11:12:58 +09:00
Charlie Hess
b2fb95f857 Use scoped_nsobject to ensure our intermediate objects get cleaned up. 2016-05-04 11:28:49 -07:00
Steve Kinney
55babea2bb 📝 Update tutorials to ES6 [ci skip] 2016-05-04 12:11:51 -06:00
Steve Kinney
3271492c86 📝 Update FAQ to ES6 [ci skip] 2016-05-04 12:02:24 -06:00
Steve Kinney
afe0296e0f 📝 Rewrite docs on destructuring assignment [ci skip] 2016-05-04 11:59:40 -06:00
Steve Kinney
5a9f28e034 📝 Update API documentation to ES6 [ci skip] 2016-05-04 11:59:02 -06:00
Steve Kinney
178496afe5 📝 Update documentation style guide to ES6 [ci skip] 2016-05-04 10:55:05 -06:00
Heejin Lee
2b079588bb Fix small mistakes in CONTRIBUTING-ko.md 2016-05-05 00:02:53 +09:00
Daniel Pham
a6f2d401fa Follow object naming conventions for params in the 'context-menu' event 2016-05-04 10:41:10 -04:00
Cheng Zhao
6fba72a40c Merge pull request #5383 from preco21/korean-docs-2
docs: Update Korean docs as upstream
2016-05-04 23:20:44 +09:00
Cheng Zhao
fe73688975 Merge pull request #5387 from preco21/patch-1
docs: Match code syntax
2016-05-04 23:20:23 +09:00
Cheng Zhao
ef561fb919 Merge pull request #5378 from CGamesPlay/master
Use select to query the uv kqueue
2016-05-04 23:08:12 +09:00
Plusb Preco
9483cd351a 📝 Update Korean docs as upstream
[ci skip]
2016-05-04 18:45:52 +09:00
Cheng Zhao
28d12166fd Fix margin of elements in flex 2016-05-04 18:01:29 +09:00
Cheng Zhao
7074789011 Remove some unnecessary css rules 2016-05-04 18:01:29 +09:00
Cheng Zhao
5e73b0372d Make the drag box fill the remaining height of window 2016-05-04 18:01:29 +09:00
Cheng Zhao
540076e9d5 Fix code styling issue 2016-05-04 17:12:10 +09:00
Cheng Zhao
8957ba5222 Merge pull request #5371 from adambuckland/fix_auto_update_error
Fix autoUpdater error on OS X
2016-05-04 16:58:25 +09:00
Cheng Zhao
4c1a0d29b0 Merge pull request #5367 from sindresorhus/patch-1
improve the `webContents.openDevTools` docs
2016-05-04 16:52:48 +09:00
Charlie Hess
7b207aa1b6 Don't run this spec on platforms where the method is unavailable. 2016-05-03 23:33:40 -07:00
Plusb Preco
9fcafc6f9e 📝 Update Korean docs as upstream
[ci skip]
2016-05-04 15:00:59 +09:00
Plusb Preco
8be2239a45 📝 Match code syntax
[ci skip]
2016-05-04 14:34:11 +09:00
Plusb Preco
d63d570327 📝 Fix typo
[ci skip]
2016-05-04 09:46:14 +09:00
Charlie Hess
12764a66ed Add an accessor for the current activity type and write the simplest possible test. 2016-05-03 15:51:31 -07:00
Charlie Hess
42768bcc2b Save the activity on the application instance to ensure we hold a reference. Activities that enable search need to persist. 2016-05-03 14:57:16 -07:00
Daniel Pham
81eb3e3428 📝 Document 'context-menu' event 2016-05-03 17:52:24 -04:00
Daniel Pham
0fffbea79d Add 'context-menu' event to 'WebContents' 2016-05-03 17:50:54 -04:00
Plusb Preco
ebd8d30f25 📝 Small fixes
[ci skip]
2016-05-04 02:55:10 +09:00
Charlie Hess
a5a2e20449 📝 on using only strings. 2016-05-03 10:34:59 -07:00
Charlie Hess
03d25ce6c0 Revert "Add some shady methods to get V8 objects or arrays from NSDictionary or NSArray."
This reverts commit 2295f3a832.
2016-05-03 10:32:42 -07:00
Charlie Hess
f84a973d69 Revert "Use a DictionaryValue everywhere instead of a string map."
This reverts commit 90cc10944a.
2016-05-03 10:31:53 -07:00
Paul Betts
2606f8020a Merge pull request #5382 from danhp/patch-1
Fix Windows debug doc pointing to OS X
2016-05-03 09:28:45 -07:00
Daniel Pham
e9c9e22a9e 📝 Fix Windows debug doc pointing to OS X
[ci skip]
2016-05-03 11:51:57 -04:00
Cheng Zhao
513b07b3b3 Merge pull request #5377 from electron/custom_compiler
Add more options for building on Linux
2016-05-03 22:23:31 +09:00
Ryan Patterson
b15c07e1a8 Use select to query the uv kqueue
This resolves #38. I've verified that events still get processed like they
should on El Capitan 10.11.3 (15D21).
2016-05-02 23:54:21 -07:00
Plusb Preco
0e7de568a2 📝 Small fixes
[ci skip]
2016-05-03 15:34:47 +09:00
Plusb Preco
f984536523 📝 Improve grammar
[ci skip]
2016-05-03 12:07:06 +09:00
Cheng Zhao
67a768fc77 Do not download clang on Windows 2016-05-03 09:38:15 +09:00
Cheng Zhao
49eed1ebb9 Ignore CC and CXX if user didn't change build configuration 2016-05-03 09:31:39 +09:00
Cheng Zhao
0567f09d6d docs: The building environment variables 2016-05-03 08:29:23 +09:00
Charlie Hess
90cc10944a Use a DictionaryValue everywhere instead of a string map. 2016-05-02 16:18:58 -07:00
Charlie Hess
2295f3a832 Add some shady methods to get V8 objects or arrays from NSDictionary or NSArray. 2016-05-02 14:45:59 -07:00
Charlie Hess
b53480e15c Merge remote-tracking branch 'origin/master' into hands-on-hand-off 2016-05-02 12:18:26 -07:00
Charlie Hess
dbe36748d4 Merge branch 'master' of https://github.com/atom/atom-shell 2016-05-02 12:18:10 -07:00
Plusb Preco
be32039cf9 📝 Update Korean docs as upstream
[ci skip]
2016-05-03 02:43:21 +09:00
Kevin Sawicki
543211b53a Merge pull request #5372 from electron/update-appveyor
Update link to AppVeyor build badge
2016-05-02 09:26:14 -07:00
Kevin Sawicki
fecd9ee4a0 Update link to AppVeyor build badge 2016-05-02 09:07:14 -07:00
Cheng Zhao
e39d5a9eb9 docs: Introduce clang flags 2016-05-02 22:32:43 +09:00
Cheng Zhao
ac3a704abc Avoid overriding environment variables 2016-05-02 12:38:17 +00:00
Cheng Zhao
34b4ebd9f3 Fix logic errors 2016-05-02 12:15:10 +00:00
Cheng Zhao
098d72b741 Convert --clang_dir and --disable_clang to --defines 2016-05-02 21:19:16 +09:00
Cheng Zhao
26e4ce30bb Pass --disable_clang and --clang_dir to libchromiumcontent 2016-05-02 20:06:21 +09:00
Cheng Zhao
7cbe6bc8bd Merge pull request #5366 from electron/bootstrap-libchromiumcontent
Add --build_libchromiumcontent command line switch
2016-05-02 19:07:22 +09:00
Cheng Zhao
bd70d9008f Update modules before calling build_libchromiumcontent 2016-05-02 07:45:48 +00:00
Sindre Sorhus
ad09196433 improve the webContents.openDevTools docs
consistent value notation and explain the difference between `undocked` and `detach` mode.
2016-05-02 14:39:46 +07:00
Cheng Zhao
cc24bea813 Fix pylint warnings 2016-05-02 16:38:58 +09:00
Cheng Zhao
459a65d296 docs: the --build_libchromiumcontent switch 2016-05-02 16:35:33 +09:00
Cheng Zhao
64abae0b3c docs: Cleanup unnecessary parts in build-instructions-linux.md 2016-05-02 16:26:18 +09:00
Cheng Zhao
26c0ad1c2f Add --build_libchromiumcontent option 2016-05-02 16:17:38 +09:00
Plusb Preco
a83b891a95 📝 Update Korean docs as upstream
[ci skip]
2016-05-02 10:21:27 +09:00
Plusb Preco
51f095e5c3 Merge remote-tracking branch 'refs/remotes/electron/master' 2016-05-02 10:18:38 +09:00
Plusb Preco
a60bb9031a Merge remote-tracking branch 'refs/remotes/electron/master' 2016-05-02 10:18:25 +09:00
Cheng Zhao
f1edd88e56 Merge pull request #5365 from TyanNN/master
Translated application distribution and application packaging to ru_RU
2016-05-02 10:08:20 +09:00
Cheng Zhao
c48598a5bc Merge pull request #5360 from miniak/patch-1
Fix systemPreferences docs
2016-05-02 09:43:35 +09:00
TyanNN
6cb8f278a2 Translated application distribution and application packaging to ru_RU 2016-05-01 21:18:49 +03:00
Milan Burda
91911d2d32 Fix systemPreferences docs 2016-05-01 18:03:58 +02:00
Adam Buckland
abb60ecd2e Fix autoUpdater error on OS X
If there is no localizedFailureReason, then then this will no longer be
added to the error string (which would result previously in it printing
'(null)' as part of the string)
2016-05-01 13:43:56 +01:00
Cheng Zhao
586e5e2ba5 Merge pull request #5361 from preco21/korean-docs
docs: Update Korean docs as upstream
2016-05-01 14:34:00 +09:00
Cheng Zhao
b2e77b2e6b Merge pull request #5357 from TyanNN/master
Translated Quickstart to ru_RU
2016-05-01 11:46:15 +09:00
Charlie Hess
21ae288ee7 📝 about the plist changes. 2016-04-30 13:03:10 -07:00
Charlie Hess
05493502ea Value first, key second. 2016-04-30 11:17:29 -07:00
Plusb Preco
33aecb9978 📝 Update Korean docs as upstream
[ci skip]
2016-05-01 02:46:19 +09:00
Plusb Preco
a554f9e683 📝 Update Korean docs as upstream
[ci skip]
2016-05-01 02:10:23 +09:00
Plusb Preco
6fda14ce88 📝 Update Korean docs as upstream
[ci skip]
2016-05-01 01:53:21 +09:00
Plusb Preco
f426c9c951 📝 Improve grammar
[ci skip]
2016-05-01 01:12:54 +09:00
Plusb Preco
bde412dd69 📝 Fix typos
[ci skip]
2016-05-01 01:11:21 +09:00
Cheng Zhao
03ce8a195a Merge pull request #5359 from electron/windows-pdb
Upload PDBs to Windows symbol server
2016-05-01 00:10:34 +09:00
Cheng Zhao
47f7f7b02e Revert "Don't upload PDB files in CI"
This reverts commit 7ab8134613.
2016-04-30 21:43:33 +09:00
Cheng Zhao
d91cd424fe Revert "Run tests for branches on appveyor"
This reverts commit 33370b18b3.

This commit was wrongly pushed.
2016-04-30 21:21:11 +09:00
Cheng Zhao
5766f4703a Merge pull request #5358 from electron/windows-ci
Run tests on Windows CI machine
2016-04-30 21:18:23 +09:00
Cheng Zhao
f65f8918c9 Fix specs on Windows when running without desktop session 2016-04-30 21:03:22 +09:00
Cheng Zhao
33370b18b3 Run tests for branches on appveyor 2016-04-30 20:42:24 +09:00
TyanNN
dae63ec4f1 Translated Quickstart to ru_RU 2016-04-30 13:54:19 +03:00
Cheng Zhao
214eb0430c Fix a few failing tests on Windows 2016-04-30 18:21:18 +09:00
Cheng Zhao
2a55d93501 Remove the output file after testing 2016-04-30 17:52:53 +09:00
Cheng Zhao
b68a25835f Make sure output is written when test fails 2016-04-30 17:48:07 +09:00
Cheng Zhao
3dcf69eab3 Also run tests on 32bit Windows 2016-04-30 17:17:23 +09:00
Cheng Zhao
8aa88067ca Do not write to stdout in Electron when running on win32 CI machine
This makes Electron crash on CI machine somehow.
2016-04-30 17:08:51 +09:00
Cheng Zhao
6756f8c7af Make win32 CI machine run tests 2016-04-30 15:38:23 +09:00
Charlie Hess
cea1b49db0 Add some documentation in app.md. 2016-04-29 22:25:09 -07:00
Charlie Hess
195940292d This is preventDefault by convention. 2016-04-29 22:08:19 -07:00
Charlie Hess
88805ec7e2 Make the Linter happy. 2016-04-29 22:05:36 -07:00
Cheng Zhao
fe3c78ad84 Merge pull request #5353 from electron/update-old-bracket-notation-in-translations
update all references to old atom-log bracket notation
2016-04-30 12:13:07 +09:00
Cheng Zhao
47a2a3a13f Merge pull request #5349 from electron/link-to-electron-prebuilt
describe electron-prebuilt and link to it
2016-04-30 11:59:44 +09:00
Cheng Zhao
b693ced765 Merge pull request #5346 from electron/update-quick-start-code
update quick-start code to match quick-start repo
2016-04-30 11:56:50 +09:00
Zeke Sikelianos
9f99ba3b73 update all references to old atom-log bracket notation 2016-04-29 18:35:02 -07:00
Charlie Hess
3a9a1d35d7 Add the AppDelegate override for restoring from hand-off, and fire the app event. 2016-04-29 17:37:01 -07:00
Charlie Hess
c20acb0361 Implement a "continue-activity" event on app for resuming from hand-off. 2016-04-29 17:36:04 -07:00
Charlie Hess
6df4bb176d Implement app.setUserActivity(type, userInfo). 2016-04-29 17:35:07 -07:00
Charlie Hess
92606579d3 Generalize this mate converter for reuse. 2016-04-29 17:32:25 -07:00
Kevin Sawicki
1bbc6211ca Merge pull request #5347 from rhedshi/patch-1
Update mac-app-store-submission-guide.md
2016-04-29 13:34:02 -07:00
Zeke Sikelianos
0c9c1229e3 describe electron-prebuilt and link to it 2016-04-29 13:32:00 -07:00
rhedshi
95476a81ae Update mac-app-store-submission-guide.md 2016-04-29 13:28:41 -07:00
Zeke Sikelianos
2f71d6afe0 update quick-start code to match quick-start repo 2016-04-29 13:17:50 -07:00
Charlie Hess
e9514bf35d Merge branch 'master' of https://github.com/atom/atom-shell 2016-04-29 13:12:56 -07:00
Cheng Zhao
edb73fb734 Bump v0.37.8 2016-04-29 20:48:19 +09:00
Cheng Zhao
cb45c94db9 Merge pull request #5340 from electron/create-user-data
Make sure the userData directory is created before ready event
2016-04-29 20:36:27 +09:00
Cheng Zhao
66853344c0 Make sure the userData directory is created before ready event 2016-04-29 20:20:52 +09:00
Plusb Preco
83af5de572 📝 Small fixes
[ci skip]
2016-04-29 10:32:33 +09:00
Arif Çakıroğlu
f7d4ff90ea added accelerator.md to api folders and translated (#5316)
* added accelerator.md to api folders and translated 🎉

* added file-object.md to api folder and translated

* added all folders to /tr-TR for broken links

* removed untouched documentation file

* broken link fix
2016-04-29 08:28:46 +09:00
Cheng Zhao
4001f10e2d Merge pull request #5334 from miniak/fix-screen-events
Fix #3075 by not caching the displays (id is not persistent on Windows)
2016-04-29 08:24:55 +09:00
Cheng Zhao
c2833274bf Merge pull request #5332 from Stone-Jay/patch-7
Update desktop-environment-integration.md (zh-CN)
2016-04-29 08:22:26 +09:00
Kevin Sawicki
9f82620bb0 Merge pull request #5300 from electron/default-app-styles
Update default app styles
2016-04-28 09:27:33 -07:00
Kevin Sawicki
b0dc7ff841 Remove header link hover color 2016-04-28 09:12:13 -07:00
Kevin Sawicki
80bece5640 Add links to nav bar 2016-04-28 09:12:13 -07:00
simurai
5995e3f400 Make drag&drop text wrap-able 2016-04-28 09:12:13 -07:00
simurai
3e4ecd6d6e Fix logo
So the inner dot is filled
2016-04-28 09:12:12 -07:00
Kevin Sawicki
6979ea7fda Use default cursor on holder area 2016-04-28 09:12:12 -07:00
Kevin Sawicki
068909dc03 Tweak header text color 2016-04-28 09:12:12 -07:00
Kevin Sawicki
dd337640f5 🎨 2016-04-28 09:12:12 -07:00
Kevin Sawicki
c6edab0950 Tweak link style 2016-04-28 09:12:12 -07:00
Kevin Sawicki
7e9d790070 Tweak font weight on holder div 2016-04-28 09:12:12 -07:00
Kevin Sawicki
54aa458ba4 Tweak font 2016-04-28 09:12:12 -07:00
Kevin Sawicki
09b036f07b Update header colors 2016-04-28 09:12:12 -07:00
Milan Burda
340b7220f1 Fix #3075 by not caching the displays (id is not persistent on Windows) 2016-04-28 17:46:41 +02:00
StoneStoneStone
1bac04c69d Update desktop-environment-integration.md 2016-04-28 22:30:14 +08:00
Cheng Zhao
850bc2d443 Merge pull request #5320 from deepak1556/desktopcapture_api_patch
renderer: fix desktop capture api not responding different subsequest calls
2016-04-28 20:14:58 +09:00
deepak1556
d64e3784f4 renderer: fix desktop capture api not responding different subsequest calls 2016-04-28 14:24:22 +05:30
Cheng Zhao
68192785e7 Merge pull request #5319 from deepak1556/webcontents_executejavascript_patch
webContents: fix executejavascript when called before page load
2016-04-28 16:43:50 +09:00
Cheng Zhao
d9db23185c Merge pull request #5302 from ritazh/default-protocol-handler
Add API: IsDefaultProtocolClient
2016-04-28 16:13:06 +09:00
Cheng Zhao
122652a368 Merge pull request #5315 from deepak1556/download_manager_patch
browser: fix some edge cases with download manager
2016-04-28 16:08:22 +09:00
Cheng Zhao
77573281b5 Merge pull request #5314 from Stone-Jay/patch-6
Translate `testing-on-headless-ci.md` to Chinese
2016-04-28 11:12:55 +09:00
deepak1556
4e6b148eaa webContents: fix executejavascript when called before page load 2016-04-28 01:54:08 +05:30
Rita Zhang
df2141d9e6 Add API: IsDefaultProtocolClient 2016-04-27 12:24:46 -07:00
deepak1556
6dbd2ce243 use DownloadItem to determine download initiator 2016-04-27 20:29:39 +05:30
StoneStoneStone
bfae925b0f Translate testing-on-headless-ci.md to Chinese 2016-04-27 22:49:07 +08:00
deepak1556
46208b5b3e session: dont attach download dialog to deleted webContents window 2016-04-27 20:00:31 +05:30
Cheng Zhao
0fa92923da Merge pull request #5311 from electron/fix-singleton
Create user_data_dir before creating singleton lock
2016-04-27 22:25:15 +09:00
Cheng Zhao
4435cdc576 Create user_data_dir before creating singleton lock 2016-04-27 21:52:50 +09:00
Cheng Zhao
302a6e42bd Merge pull request #5310 from electron/ci-no-clean
Do not run clean in cibuild
2016-04-27 20:21:55 +09:00
Cheng Zhao
f3c3042deb Do not run clean in cibuild 2016-04-27 19:55:01 +09:00
Cheng Zhao
7b8a05f01f Merge pull request #5298 from phamdaniel/fix-mac-accelerators
Fix converting from windows virtual keycode back to mac keycode
2016-04-27 10:23:28 +09:00
Kevin Sawicki
32c93f713a Merge pull request #5301 from electron/webframe-docs
Update module names in docs
2016-04-26 13:46:38 -07:00
Kevin Sawicki
4080442f80 content-tracing -> contentTracing 2016-04-26 10:28:20 -07:00
Kevin Sawicki
b1c0e7e2ab web-frame -> webFrame 2016-04-26 10:28:04 -07:00
Daniel Pham
21af03d71a 🍎 Fix converting from windows virtual keycode back to mac keycode 2016-04-26 10:53:26 -04:00
Cheng Zhao
cdb4444caa Merge pull request #5293 from electron/native-gc
Dereference remote objects with native code
2016-04-26 19:39:48 +09:00
Cheng Zhao
76a954077d Simplify RemoteCallbackFreer 2016-04-26 16:37:46 +09:00
Cheng Zhao
4f21a50d23 Remove duplicated converter for content::WebContents 2016-04-26 16:31:56 +09:00
Cheng Zhao
d9778413e1 Should also destory RemoteCallbackFreer when page is reloaded 2016-04-26 16:30:26 +09:00
Cheng Zhao
06cf0406fe Dereference remote objects with native code
Previously we rely on the v8util.setDestructor to dereference the remote
objects in JavaScript, however as documented in V8, it is forbidden to
call V8 APIs in object's destructor (e.g. the weak callback), and doing
so would result in crashs.

This commit removes the JavaScript setDestructor method, and avoids
doing the dereference work with V8.
2016-04-26 16:16:22 +09:00
Cheng Zhao
570dc7ca9b Merge branch 'MarshallOfSound-master' 2016-04-26 11:15:56 +09:00
Cheng Zhao
f081c77422 Fix compilation error 2016-04-26 11:15:36 +09:00
Cheng Zhao
f3a9d3eed7 Merge pull request #5290 from arifcakiroglu/master
Translate docs to Turkish
2016-04-26 11:13:09 +09:00
Samuel Attard
315cd9d2c8 Emit an error if quitAndInstall is called without an update being available 2016-04-26 11:55:57 +10:00
Cheng Zhao
db91adc2e8 Merge branch 'michal1106-patch-1' 2016-04-26 10:24:57 +09:00
Cheng Zhao
a0c14eed04 Revise the using-pepper-flash-plugin.md 2016-04-26 10:24:43 +09:00
Cheng Zhao
63d0704490 Merge pull request #5282 from electron/system-preferences
Add systemPreferences module
2016-04-26 08:21:43 +09:00
arifcakiroglu
64db17dde7 Added Turkish Docs link to README-ko 2016-04-26 01:03:17 +03:00
arifcakiroglu
d02125bde5 Update README 2016-04-26 00:49:34 +03:00
michal1106
62d00163a8 Update using-pepper-flash-plugin.md 2016-04-25 16:45:56 +03:00
Cheng Zhao
b5d2e51100 docs: platform-theme-changed is deprecated 2016-04-25 22:27:44 +09:00
Cheng Zhao
11653aa9c8 docs: systemPreferences 2016-04-25 15:36:38 +09:00
Cheng Zhao
067e9c1a85 Add systemPreferences.getUserDefault 2016-04-25 15:35:52 +09:00
Cheng Zhao
a421c66f3f Deprecate the platform-theme-changed event 2016-04-25 14:35:34 +09:00
Cheng Zhao
9557226223 Add systemPreferences.subscribeNotification 2016-04-25 14:25:14 +09:00
Cheng Zhao
ddd8eae661 Move isAeroGlassEnabled and isDarkMode to systemPreferences 2016-04-25 12:35:09 +09:00
Cheng Zhao
d72a0e452f BuildPrototype should not be empty 2016-04-25 12:24:11 +09:00
Cheng Zhao
13f8599ba1 Add systemPreferences module 2016-04-25 11:32:33 +09:00
Cheng Zhao
60b9ff3948 Merge pull request #5280 from electron/better-wrappable
Clean up the Wrappable class
2016-04-25 11:22:56 +09:00
Cheng Zhao
9fe3dbcfe0 Make VS happy 2016-04-25 10:40:19 +09:00
Cheng Zhao
272592415d Fix building on non-mac 2016-04-25 10:34:41 +09:00
Cheng Zhao
993695af07 Remove unneeded cleanup code 2016-04-25 10:23:36 +09:00
Cheng Zhao
60d2cb8a84 Remove the isolate parameter of GetWrapper 2016-04-25 10:19:25 +09:00
Cheng Zhao
2ae52d0ff4 Make Wrappable a template class 2016-04-25 10:17:54 +09:00
Cheng Zhao
a8f08e1fab Merge pull request #5263 from miniak/mac-fix-maximize
Fix BrowserWindow.maximize/unmaximize on Mac
2016-04-24 13:58:36 +09:00
Cheng Zhao
096b948570 Merge pull request #5249 from electron/api-summaries
create a one-liner description for each API
2016-04-24 13:50:17 +09:00
Cheng Zhao
c7f338a5ef Merge pull request #5260 from fierroformo/fix-spanish-docs
Fix spanish docs
2016-04-24 13:45:13 +09:00
Cheng Zhao
c7754e712d Merge pull request #5253 from preco21/master
docs: Update Korean docs as Upstream
2016-04-24 13:38:06 +09:00
Cheng Zhao
2f06a2af81 Merge pull request #5252 from miniak/doc-fix
Documentation fixes
2016-04-24 13:37:45 +09:00
Milan Burda
e1516d4244 Fix BrowserWindow.maximize/unmaximize on Mac 2016-04-23 01:16:31 +02:00
Alejandro Betancourt
778d18a510 Fix links in readme for spanish translation 2016-04-22 17:13:51 -05:00
Milan Burda
dfd1a46956 Document process.crash method 2016-04-22 23:58:41 +02:00
Alejandro Betancourt
28381757d5 Fix translations to spanish 2016-04-22 14:34:46 -05:00
Zeke Sikelianos
799fd13c50 more updates to api summaries based on feedback 2016-04-22 11:42:54 -07:00
Zeke Sikelianos
2c8261b429 update excerpts based on feedback 2016-04-22 10:32:28 -07:00
Zeke Sikelianos
0527b17e42 blockquote summaries 2016-04-22 10:32:28 -07:00
Zeke Sikelianos
ee190ca62a create a one-liner description for each API 2016-04-22 10:32:28 -07:00
Jessica Lord
a4de40ec89 Merge pull request #5254 from preco21/document-fixes-3
docs: Improve documentations
2016-04-22 09:55:25 -07:00
Kevin Sawicki
08e18d46ea Merge pull request #5244 from electron/disable-node-in-web-view-when-disabled-in-parent
Disable node in webviews when disabled in parent window
2016-04-22 09:05:58 -07:00
Plusb Preco
6205dfa25f 📝 Remove additional whitespaces
[ci skip]
2016-04-22 23:30:41 +09:00
Plusb Preco
a14014941b 📝 Fix coding style issues
[ci skip]
2016-04-22 23:26:19 +09:00
Plusb Preco
ba9fa95653 📝 Remove additional whitespaces
[ci skip]
2016-04-22 23:23:39 +09:00
Plusb Preco
66f4701d93 📝 Remove additional whitespaces
[ci skip]
2016-04-22 23:23:15 +09:00
Plusb Preco
b6f8dcea20 📝 Add missing platform specified tag
[ci skip]
2016-04-22 23:21:42 +09:00
Plusb Preco
7fa4b7c8b5 📝 Normalize code tags
[ci skip]
2016-04-22 23:15:31 +09:00
Plusb Preco
b862cee6ec 📝 Correct heading order
[ci skip]
2016-04-22 23:11:39 +09:00
Plusb Preco
741f8091b4 📝 Fix coding style issues
* Correct heading order
* Adjust line length to `80`
* Beautify docs
* Apply small fixes
* Normalize whitespaces

[ci skip]
2016-04-22 23:09:59 +09:00
Plusb Preco
cbc2a869e3 📝 Fix typos
[ci skip]
2016-04-22 22:56:24 +09:00
Plusb Preco
c72bb6df33 📝 Remove unused link reference
[ci skip]
2016-04-22 22:55:38 +09:00
Plusb Preco
4f4277e25e 📝 Fix coding style issues
* Adjust line length to `80`
* Normalize whitespaces

[ci skip]
2016-04-22 22:54:43 +09:00
Plusb Preco
0282180b9c 📝 Correct description style
[ci skip]
2016-04-22 22:20:41 +09:00
Plusb Preco
08dbd35ced 📝 Apply small fixes
[ci skip]
2016-04-22 22:14:42 +09:00
Plusb Preco
552609db73 📝 Apply small fixes
[ci skip]
2016-04-22 22:13:02 +09:00
Plusb Preco
57115a447c 📝 Update README-ko.md
[ci skip]
2016-04-22 22:12:46 +09:00
Plusb Preco
d125483c13 📝 Update Korean docs as upstream
[ci skip]
2016-04-22 22:02:39 +09:00
Milan Burda
da727a3c1b Fix display.rotation documentation 2016-04-22 12:32:11 +02:00
Cheng Zhao
c04d43ca13 Bump v0.37.7 2016-04-22 17:39:11 +09:00
Cheng Zhao
394ffa88dd Merge pull request #5250 from electron/felix/camelCase
Windows Store Camels
2016-04-22 11:23:15 +09:00
Felix Rieseberg
c0f63eed4e 🎨 Windows Store Camels 2016-04-21 19:11:25 -07:00
Kevin Sawicki
bb2cab2858 Merge pull request #5247 from djpereira/patch-1
Update desktop-capturer.md
2016-04-21 15:32:56 -07:00
Daniel Pereira
b45f683655 Update desktop-capturer.md
Fixed native image link.
2016-04-21 17:00:19 -05:00
Kevin Sawicki
8e7bf1051d Disable node integration on webview when disabled on window 2016-04-21 11:52:10 -07:00
Kevin Sawicki
e4bd592e0e Add failing spec 2016-04-21 11:49:42 -07:00
Plusb Preco
67f672541c 📝 Update Korean docs as upstream
[ci skip]
2016-04-21 18:51:27 +09:00
Cheng Zhao
c92e622ce0 Merge pull request #5238 from electron/felix/appx-detection
Add Windows Store Detection
2016-04-21 16:21:38 +09:00
Felix Rieseberg
2a2a8d3263 Add Windows Store Detection
If we're running as a Windows Store appx package,
`process.windowsstore` will be `true`, otherwise
`undefined`.
2016-04-21 00:02:03 -07:00
Cheng Zhao
b30143c67d Merge pull request #5237 from electron/set-path-no-create
Do not create the folder passed to app.setPath
2016-04-21 14:49:55 +09:00
Cheng Zhao
df97be30e5 Do not create the folder passed to app.setPath 2016-04-21 14:37:29 +09:00
Cheng Zhao
1c75baa8b3 Merge pull request #5236 from electron/short-ss-path
Make the length of SingletonSocket's path as short as we can
2016-04-21 14:14:24 +09:00
Cheng Zhao
0900762507 Make the length of SingletonSocket's path as short as we can 2016-04-21 13:58:11 +09:00
Plusb Preco
30d37fcba4 📝 Small fixes
[ci skip]
2016-04-21 12:33:56 +09:00
Cheng Zhao
ec832f418a Merge pull request #5233 from electron/remove-no-exception
Guard against unexist owner when removing ref to remote object
2016-04-21 11:50:27 +09:00
Cheng Zhao
a836ee4ea7 Merge pull request #5231 from deepak1556/open_external_pemission_patch
session: allow providing permission to handle external protocols
2016-04-21 11:50:01 +09:00
Cheng Zhao
b5c1db9ad9 Guard against unexist owner when removing ref to remote object 2016-04-21 11:23:20 +09:00
deepak1556
ca756c3c24 session: allow providing permission to handle external protocols 2016-04-21 05:27:07 +05:30
Cheng Zhao
aa29dc0c8a Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Plusb Preco
720fbc1003 📝 Update Korean docs as upstream
* Update docs
* Small fixes

[ci skip]
2016-04-20 18:45:07 +09:00
Rob Brackett
dc8fc7c079 📝 Add English docs for webContents.isLoadingMainFrame()
[ci skip]
2016-04-19 23:27:22 -07:00
Cheng Zhao
823c4f91a8 Merge pull request #5219 from atdrago/master
Add note for OS X about using `role` on MenuItem
2016-04-20 15:11:43 +09:00
Cheng Zhao
809135f657 Merge pull request #5222 from Stone-Jay/master
fixes some translation mistakes
2016-04-20 15:05:25 +09:00
Cheng Zhao
47ec7dcaa0 Merge pull request #5213 from rmcdonald/patch-1
Correct transposition errors by changing xfvb to xvfb
2016-04-20 15:05:04 +09:00
Cheng Zhao
3fdcbcef03 Merge pull request #5223 from electron/remote-cleanup
Small cleanup of the code determining value's type
2016-04-20 14:47:16 +09:00
Cheng Zhao
965c3f605e Merge pull request #5197 from deepak1556/client_certificate_patch
app: api to import client certificate
2016-04-20 14:35:00 +09:00
Cheng Zhao
680652d01c buffer, null, array etc. all belong to object 2016-04-20 14:32:32 +09:00
Cheng Zhao
ff1b7d18f6 Cleanup the code determining value's type 2016-04-20 14:26:49 +09:00
Rob Brackett
d3e879cd7f Change WebContents::IsLoadingMainFrame to compare SiteInstances
(per @deepak1556's recommendation)

Also updates tests to cover the situation where navigating between pages from the same potential "site" and adds generalized tests for `isLoadingMainFrame()`.
2016-04-19 22:05:09 -07:00
Cheng Zhao
d7a391dc61 Merge pull request #5214 from alexgleason/docs-downloaditem-typo
Fixed docs sample code programming error for DownloadItem
2016-04-20 13:44:31 +09:00
Cheng Zhao
d3bff7fffc Merge pull request #5208 from deepak1556/devtools_dock_state_patch
devtools: allow opening in specified dock state
2016-04-20 13:34:52 +09:00
Cheng Zhao
a3e8591a41 Update brightray for #5208 2016-04-20 13:34:30 +09:00
deepak1556
794d120754 rename importClientCertificate => importCertificate 2016-04-20 08:45:49 +05:30
StoneStoneStone
bdde5fd7ad Update screen.md 2016-04-20 10:58:32 +08:00
StoneStoneStone
57bdbd8185 Update download-item.md 2016-04-20 10:39:47 +08:00
StoneStoneStone
16b54e1502 Update screen.md 2016-04-20 10:37:41 +08:00
StoneStoneStone
7468118df5 Update screen.md 2016-04-20 10:26:31 +08:00
Rob Brackett
942971b01a Fix linting errors. 2016-04-19 19:20:59 -07:00
Cheng Zhao
652110707e Merge pull request #5202 from electron/updating-submodules
keeping submodules up to date
2016-04-20 10:51:12 +09:00
Adam Drago
b80272dbb4 Add note for OS X about using role on MenuItem 2016-04-19 18:12:37 -07:00
Cheng Zhao
5b7637687c Merge pull request #5143 from felixrieseberg/debug-instructions
Add Debugging Instructions for Windows
2016-04-20 09:33:25 +09:00
Cheng Zhao
b2a3aabc90 Merge pull request #5218 from electron/style-fix
Fix some coding style issues
2016-04-20 09:31:53 +09:00
Cheng Zhao
18f5fcde60 Fix some coding style issues 2016-04-20 09:18:50 +09:00
Cheng Zhao
eb9e0e5534 Merge pull request #4922 from electron/bengotow/sheet-offset
Allow sheets to be attached at a custom offset #4679
2016-04-20 08:55:42 +09:00
Cheng Zhao
8ca1a6961c Merge pull request #5147 from deepak1556/devtools_network_controller_patch
session: set client id when enabling network emulation
2016-04-20 08:52:59 +09:00
Cheng Zhao
37e500dc10 Merge pull request #5203 from Stone-Jay/master
Translate download-item.md to Chinese
2016-04-20 08:50:25 +09:00
Cheng Zhao
873e9c44db Merge pull request #5196 from raybooysen/patch-1
Update screen.md
2016-04-20 08:44:41 +09:00
Jessica Lord
5e9fe1c6eb Merge pull request #5168 from electron/jlord-patch-1
A few style updates 2 docs
2016-04-19 12:29:42 -07:00
Alex Gleason
02c8c58c0b Fixed docs sample code programming error for DownloadItem 2016-04-19 12:47:05 -04:00
Zeke Sikelianos
8f04dd1b9c remove the git 2016-04-19 09:46:48 -07:00
rmcdonald
838cf0ffdc Correct transposition errors by changing xfvb to xvfb 2016-04-19 09:31:04 -07:00
deepak1556
58dfad4d01 devtools: allow opening in specified dock state 2016-04-19 18:12:05 +05:30
Cheng Zhao
34ee29871b Merge pull request #5205 from electron/mas-fix
Fix the support for Mac App Store
2016-04-19 20:56:24 +09:00
Cheng Zhao
fd6747483a Update the codesign code for latest Xcode 2016-04-19 20:31:31 +09:00
Cheng Zhao
bd406ab046 Update the MAS submission guide 2016-04-19 20:31:31 +09:00
deepak1556
2d8286515d expose api only on platforms using nss cert database 2016-04-19 11:29:24 +05:30
Ben Gotow
414245f4d8 Keep function placement consistent 2016-04-18 22:45:38 -07:00
Ben Gotow
8f89cd2d59 Move "setSheetOffset" to the BrowserWindow 2016-04-18 22:39:12 -07:00
deepak1556
ddf962c6ea client_id is accessed on different threads 2016-04-19 10:01:38 +05:30
StoneStoneStone
591f8fed88 Update frameless-window.md 2016-04-19 12:03:34 +08:00
StoneStoneStone
fcad4ee186 Create download-item.md 2016-04-19 11:58:58 +08:00
Zeke Sikelianos
916114dd28 📝 keeping submodules up to date 2016-04-18 20:23:11 -07:00
StoneStoneStone
ace235b2fe Merge pull request #3 from electron/master
update from electron
2016-04-19 09:13:30 +08:00
Jessica Lord
c3200ba7f6 Revert "Fix headers"
This reverts commit 4dd2716865.
2016-04-18 18:00:32 -07:00
Cheng Zhao
1c87acbb75 Merge pull request #5194 from Stone-Jay/patch-5
Create frameless-window.md
2016-04-19 08:59:45 +09:00
Cheng Zhao
5c75fbe369 Merge pull request #5192 from andrewda/patch-1
Update link to setFeatureEnabledFromString
2016-04-19 08:59:15 +09:00
Rob Brackett
64a84dee3b Add isLoadingMainFrame method to WebContents.
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183.
2016-04-18 10:37:08 -07:00
Rob Brackett
3a9bbe30ac Test for #5183 - webContents.executeJavaScript hangs on subframe load. 2016-04-18 10:33:56 -07:00
deepak1556
2c0494dcef fix spec 2016-04-18 22:57:37 +05:30
deepak1556
919be67cd2 remove --client-certificate flag 2016-04-18 22:26:37 +05:30
deepak1556
2ddac9352f add spec 2016-04-18 21:53:44 +05:30
Ray Booysen
5a9b86dd05 Update screen.md 2016-04-18 17:04:47 +01:00
deepak1556
1240c83e40 set trust bits for CA certs 2016-04-18 21:05:33 +05:30
StoneStoneStone
142300aeb9 Create frameless-window.md
Translate `frameless-window.md` to Chinese.  And I'm not sure that the `non-client frame`'s translation is accurate.
2016-04-18 22:38:15 +08:00
Cheng Zhao
eeccd90455 Merge pull request #5191 from electron/initialize-embedder
Initialize the embedder_ member data
2016-04-18 15:13:41 +09:00
Cheng Zhao
a8032e8fef Merge pull request #5184 from miniak/fix-docs
Fix documentation
2016-04-18 15:13:27 +09:00
deepak1556
b8e04f4947 set client id on AtomNetworkDelegate instead of cmd line switch 2016-04-18 11:35:24 +05:30
Andrew Dassonville
12483486c0 Update link to setFeatureEnabledFromString 2016-04-17 23:04:02 -07:00
Cheng Zhao
34319abf4a Initialize the embedder_ member data
Otherwise it is going to be some random value and bite us.
2016-04-18 14:52:03 +09:00
deepak1556
e81cec4058 app: api to import client certificate 2016-04-18 10:54:43 +05:30
deepak1556
fcf04377d7 set network emulation client id in request headers 2016-04-18 10:49:00 +05:30
Cheng Zhao
0bf1e56156 Update brightray for electron/brightray#212 2016-04-18 13:59:15 +09:00
Plusb Preco
c8e77f47ab 📝 Fix typos
[ci skip]
2016-04-18 02:39:05 +09:00
Milan Burda
d512421084 Fix documentation 2016-04-16 19:58:03 +02:00
Ben Gotow
1976c271ec Fix JS linter errors 2016-04-16 11:04:48 -04:00
Ben Gotow
65c37fe64b Create local variable to typecast view 2016-04-16 10:57:39 -04:00
Ben Gotow
c87c49f4c8 Allow sheets to be attached at a custom offset #4679
Adds a new "setSheetOffset" API to the `dialog` module, which allows you to change the attachment point for sheets on Mac OS X. I put the API on the dialog module, even though Mac OS X requires that the native window hold and return the desired offset.

1. I was originally hoping to make this an argument on the actual dialog.show* calls, but it seems the parameter set is defined in `libchromiumcontent` and I wasn't sure it would be appropriate to add there?

2.  The API could also be on the BrowserWindow (eg `BrowserWindow.setSheetOffset`). I don't have a strong preference, but I think it's more discoverable on the `dialog` module.
2016-04-16 10:16:43 -04:00
Zeke Sikelianos
8d08c3241d Merge pull request #5176 from shokmaster/patch-1
Correct misspellings
2016-04-15 12:46:30 -07:00
Cheng Zhao
16de30dd04 Merge pull request #5169 from Stone-Jay/patch-4
Update sample code in online-offline-events.md
2016-04-15 22:16:07 +09:00
Cheng Zhao
522d592832 Merge pull request #5167 from Stone-Jay/patch-3
translation error in browser-window.md
2016-04-15 21:14:09 +09:00
Cheng Zhao
2414096560 Merge pull request #5166 from preco21/master
docs: Update Korean docs as upstream
2016-04-15 20:39:55 +09:00
Cheng Zhao
cb947873c4 Merge pull request #5161 from electron/felix/iss5097
AutoUpdate Windows: Don't spawn if running
2016-04-15 20:10:03 +09:00
Cheng Zhao
44bc24174c Merge pull request #5159 from djpereira/patch-1
Sample missing reference to webContents for toggleDevTools
2016-04-15 19:59:50 +09:00
Cheng Zhao
9574f79d0f Merge pull request #5157 from christoth/master
webview: add CSS styling notes to doc
2016-04-15 19:58:54 +09:00
Juan Antonio Gómez
132ac20ccf Correct misspellings
Correct misspellings
2016-04-15 11:49:08 +02:00
StoneStoneStone
7d788cfa7a Merge pull request #2 from Stone-Jay/patch-4
Patch 4
2016-04-15 16:02:58 +08:00
Cheng Zhao
aefb672393 Bump v0.37.6 2016-04-15 16:48:09 +09:00
Cheng Zhao
059ca01767 Update brightray for printing fix 2016-04-15 16:47:17 +09:00
Cheng Zhao
38f0088844 Update brightray for #4973 2016-04-15 16:35:51 +09:00
StoneStoneStone
07346ae858 Update sample code in online-offline-events.md
change `ipc` to `ipcMain`/`ipcRenderer`
2016-04-15 14:10:11 +08:00
Jessica Lord
4dd2716865 Fix headers 2016-04-14 20:55:43 -07:00
StoneStoneStone
1985e1b8e0 translation error in browser-window.md
'same-origin policy' means '同源策略' in Chinese
2016-04-15 10:04:01 +08:00
Cheng Zhao
075da45b74 Merge pull request #5155 from electron/mac-background-color
Set the backgroundColor of RenderWidgetHostView
2016-04-15 08:48:09 +09:00
Jessica Lord
7d96f3d720 Add new line
so that the list is styled correctly on website
2016-04-14 15:53:34 -07:00
Felix Rieseberg
a5b93211e6 AutoUpdate Windows: Don't spawn if running
Previously, the auto updater would run as many squirrel processes
as told. This introduces a little change where instead of spawning
a second process, we attach to the already running process - or, if
different arguments are passed, return and emit an error.

This is not failsafe, but it ensures that we don't run into simple
race condition crashes.

Closes $5097
2016-04-14 11:22:28 -07:00
Daniel Pereira
7b56085a0a Update menu.md
There was a missing reference to webContents.
2016-04-14 10:50:08 -05:00
christoth
4708477f5a webview: add CSS styling notes
Create a new section for CSS and add notes to avoid hiding the webview via hidden or display:none; and provide a recommended approach.
2016-04-14 10:29:55 -04:00
Plusb Preco
95a53fc832 📝 Small fixes
[ci skip]
2016-04-14 22:56:56 +09:00
Plusb Preco
b8e64ac40e 📝 Update Korean docs as upstream
[ci skip]
2016-04-14 22:55:09 +09:00
Cheng Zhao
b84a178ceb Set the backgroundColor of RenderWidgetHostView 2016-04-14 21:52:17 +09:00
Cheng Zhao
64d37065bd Merge pull request #5117 from deepak1556/devtools_security_panel_patch
provide security style for devtools security panel
2016-04-14 20:23:58 +09:00
Cheng Zhao
7501a02b34 Merge pull request #5153 from electron/fix-frameless-background
Fix wrong default transparent background for frameless window
2016-04-14 20:05:35 +09:00
deepak1556
54545a8a6e provide security style for devtools security panel 2016-04-14 16:20:14 +05:30
Cheng Zhao
11ba1832d1 Only transparent window does not have background color 2016-04-14 19:35:31 +09:00
Cheng Zhao
9e85cb4c11 Merge pull request #5152 from electron/fix-win-printing
Fix printing not working on Windows
2016-04-14 19:22:56 +09:00
Cheng Zhao
7d4e0629d6 Fix the link error 2016-04-14 18:22:29 +09:00
Cheng Zhao
ae0d007c5e Do no load PDF library from DLL
We already have them compiled in.
2016-04-14 17:15:20 +09:00
Cheng Zhao
b9ad09db91 Update libchromiumcontent with necessary headers and libs 2016-04-14 17:14:45 +09:00
Cheng Zhao
47cc390e41 Merge pull request #5146 from Stone-Jay/patch-2
Update process.md
2016-04-14 15:11:55 +09:00
Cheng Zhao
7787dee638 Merge pull request #5141 from electron/optimize-visibility-state
Optimize the implementation of document.visibilityState
2016-04-14 11:56:13 +09:00
StoneStoneStone
cb2343c69e Update process.md
translation error, change "实效" to “失效".
2016-04-14 10:08:01 +08:00
Cheng Zhao
31eb793fb0 Avoid adding a new option to webPreferences 2016-04-14 10:50:07 +09:00
Felix Rieseberg
3c6e933231 📝 Add Debugging Instructions for Windows
Ref #5140
2016-04-13 15:39:05 -07:00
Cheng Zhao
8f0e594007 Fix lint warnings 2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b Correctly set initial visibilityState 2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919 Reduces the IPC messages used for visibilityState 2016-04-13 21:36:43 +09:00
Cheng Zhao
c3ac92b500 Update brightray for the linux notification improvements 2016-04-13 20:13:45 +09:00
Cheng Zhao
07572965df Merge pull request #5137 from electron/fix-did-fail-load
Revert #3643
2016-04-13 20:12:50 +09:00
Cheng Zhao
65c612a66d Avoid external URLs 2016-04-13 19:55:59 +09:00
Cheng Zhao
0a39449694 spec: loadUrl should not crash in did-fail-provisional-load handler 2016-04-13 19:39:11 +09:00
Cheng Zhao
92882c358a No more need to delay did-fail-load event 2016-04-13 19:33:59 +09:00
Cheng Zhao
49d25693ee Merge pull request #5136 from electron/gc-timer
Use LowMemoryNotification for GC
2016-04-13 18:47:28 +09:00
Cheng Zhao
3780d9f033 Use LowMemoryNotification for GC 2016-04-13 17:58:36 +09:00
Cheng Zhao
de51f2c1ba Merge pull request #5131 from electron/focus-delay
Delay the focus/blur event to next tick
2016-04-13 13:00:18 +09:00
Cheng Zhao
99a9aa085e views: Delay the focus/blur event to next tick 2016-04-13 11:02:34 +09:00
christoth
1379e4f2dc Merge pull request #1 from electron/master
Update
2016-04-12 12:38:40 -04:00
Cheng Zhao
313883b1fc Merge pull request #5119 from electron/hijack-reload
Handle the Page.reload command coming from devtools
2016-04-12 17:57:27 +09:00
Cheng Zhao
2fbe06a2a5 Handle the Page.reload command coming from devtools 2016-04-12 16:36:12 +09:00
Cheng Zhao
c9a3fc4317 Merge pull request #5118 from electron/webview-no-script
Fix webview and preload script not working when there is no script tag in page
2016-04-12 15:32:28 +09:00
Cheng Zhao
17446f4284 Make sure every page will get a script context created 2016-04-12 15:11:10 +09:00
Cheng Zhao
bb70defcb8 spec: webview should work without script tag in page 2016-04-12 15:10:26 +09:00
Cheng Zhao
5efa075aca spec: preload attribute should work without script tag in page 2016-04-12 14:57:40 +09:00
Cheng Zhao
d6b4c2a842 Merge pull request #5114 from anshao/master
Delete the extra text
2016-04-12 14:02:23 +09:00
Cheng Zhao
41e771d011 Merge pull request #5108 from preco21/master
docs: Update Korean docs as upstream
2016-04-12 08:46:22 +09:00
zenganshao
337d105104 Delete the extra text 2016-04-11 22:43:02 +08:00
Cheng Zhao
d3fb123920 Merge pull request #5102 from Stone-Jay/patch-1
Update quick-start.md
2016-04-11 21:48:59 +09:00
Cheng Zhao
a07612c1ed Merge branch '5074-did-get-response-details-resource-type' of https://github.com/Mr0grog/electron into Mr0grog-5074-did-get-response-details-resource-type 2016-04-11 21:05:40 +09:00
Cheng Zhao
a2f7458e07 Merge pull request #5091 from electron/electron-asar-in-stack-traces
Rename ATOM_SHELL_ASAR to ELECTRON_ASAR
2016-04-11 20:27:15 +09:00
Cheng Zhao
5659ee5c0b Merge pull request #5030 from deepak1556/webrequest_response_headers_patch
session: webRequest.OnHeadersReceived should accept status line.
2016-04-11 20:04:32 +09:00
Cheng Zhao
056aaa2a62 Update brightray for #4931 2016-04-11 19:30:59 +09:00
Cheng Zhao
107d759ea2 Merge pull request #5072 from sneakypete81/master
Don't wait for xdg-open to exit when OpenExternal is called (Linux)
2016-04-11 19:27:53 +09:00
Cheng Zhao
796f6614f7 Merge pull request #5073 from electron/naming-things
Document API naming conventions
2016-04-11 19:16:31 +09:00
Plusb Preco
726d0d6b60 📝 Update Korean docs as upstream
[ci skip]
2016-04-11 11:18:25 +09:00
Plusb Preco
a048bddaa5 📝 Fix url to relative
[ci skip]
2016-04-11 10:51:31 +09:00
Plusb Preco
c1f64b3f85 📝 Add missing changes
[ci skip]
2016-04-11 10:39:23 +09:00
Plusb Preco
3c44dfa210 📝 Fix grammatical typos
[ci skip]
2016-04-11 10:39:18 +09:00
Plusb Preco
1fe97ddf2e 📝 Fix url locale
[ci skip]
2016-04-11 10:38:34 +09:00
Plusb Preco
0a80618263 📝 Add missing changes
[ci skip]
2016-04-11 10:18:47 +09:00
StoneStoneStone
fca3a5f853 Update quick-start.md
Translation error about system events(line43).
2016-04-10 11:23:26 +08:00
Rob Brackett
1a842bf9d5 Fix trailing whitespace caught by linter. 2016-04-08 13:15:40 -07:00
Rob Brackett
50f51899de Document resourceType arg for did-get-response-details event. 2016-04-08 13:03:22 -07:00
Rob Brackett
15b042b5f6 Add support/tests for did-get-response-details event on <WebView> 2016-04-08 12:55:20 -07:00
Rob Brackett
c1b1348735 Add resourceType arg to webContents did-get-response-details event.
Fixes #5074 and follows @zcbenz's recommendation to expose ResourceTypeToString from atom_network_delegate publicly.
Also adds testing for other arguments to the `did-get-response-details` events, since there were no existing tests for them.
2016-04-08 11:19:36 -07:00
Kevin Sawicki
732697a8a2 Rename ATOM_SHELL_ASAR to ELECTRON_ASAR 2016-04-08 08:53:58 -07:00
Kevin Sawicki
066092abb6 Merge pull request #5079 from electron/set-node-version-to-5-dot-10
Upgrade .node-version to 5.10.0
2016-04-08 08:24:53 -07:00
Kevin Sawicki
37119768a0 ⬆️ node@5.10.0 2016-04-08 08:24:40 -07:00
deepak1556
3fb39ad3ef provide option to override status line 2016-04-08 14:03:57 +05:30
Pete Burgers
00ff209fe7 Ensure process is cleaned up, to avoid leaks 2016-04-08 08:35:35 +01:00
Pete Burgers
46365f4076 wait_for_exit param should be const 2016-04-08 08:32:45 +01:00
Cheng Zhao
5ff97317fe Merge pull request #5086 from electron/no-throttling
Add backgroundThrottling option to webPreferences
2016-04-08 16:25:09 +09:00
Cheng Zhao
d169ebf737 Merge pull request #5070 from christoth/master
webview: Update doc to reflect use of flexbox layout
2016-04-08 16:09:12 +09:00
Cheng Zhao
2f6796bd7f Disable throttling in tests 2016-04-08 15:57:14 +09:00
Cheng Zhao
d156846036 Add backgroundThrottling option to webPreferences 2016-04-08 15:54:33 +09:00
Cheng Zhao
d703a87317 Update libchromiumcontent with disable_hidden.patch 2016-04-08 15:22:57 +09:00
deepak1556
4fc35a4587 session: webRequest.OnHeadersReceived should follow server redirect
Its required to follow server redirects.
2016-04-08 11:40:43 +05:30
Kevin Sawicki
f403950503 Merge pull request #5064 from electron/upgrade-asar-for-graceful-fs-warning
Upgrade asar to remove graceful-fs warning
2016-04-07 11:40:04 -07:00
Kevin Sawicki
f20950702d ⬆️ asar@0.11 2016-04-07 10:36:41 -07:00
Kevin Sawicki
1a3ede6ca5 Merge pull request #5075 from electron/upgrade-ci-node
Use node 0.10 instead of 0.8 on internal CI machines
2016-04-07 10:35:52 -07:00
Kevin Sawicki
4041d52864 Use single quotes 2016-04-07 10:15:31 -07:00
Kevin Sawicki
10860e4ec5 Use npm.cmd on Windows to print version 2016-04-07 10:14:52 -07:00
Kevin Sawicki
687a512b11 Log node and npm versions 2016-04-07 10:03:16 -07:00
Kevin Sawicki
e95224deab Remove += 2016-04-07 10:00:23 -07:00
Kevin Sawicki
a74b9607b6 Add more logging 2016-04-07 09:59:46 -07:00
Kevin Sawicki
0fad8fdc4b Add missing .path 2016-04-07 09:56:04 -07:00
Kevin Sawicki
7e87973d60 Log version to verify 2016-04-07 09:55:23 -07:00
Kevin Sawicki
d3308cf8c3 Use node 0.10.21 on CI 2016-04-07 09:53:33 -07:00
Zeke Sikelianos
348a0e958b wrap cases in backticks 2016-04-07 09:49:55 -07:00
Zeke Sikelianos
4d8d4d5f2a use globalShortcut as a better mixedCase example 2016-04-07 09:49:17 -07:00
Zeke Sikelianos
193c6d6e93 📝 document API naming conventions 2016-04-07 09:40:31 -07:00
Kevin Sawicki
49b82decd8 Merge pull request #5061 from electron/rename-ipc-events
Rename internal IPC events to start with ELECTRON_
2016-04-07 09:37:07 -07:00
Kevin Sawicki
8d8d5878a3 Rename ATOM_ ipc event prefix to ELECTRON_ 2016-04-07 09:04:55 -07:00
Pete Burgers
79ba8feaf8 Don't wait for xdg-open to exit when OpenExternal is called (Linux)
Some browsers (eg. Firefox) may not return until the browser window is
closed. This causes the Electron application to lock up while the browser
window is open.

See https://github.com/atom/atom/issues/6320
2016-04-07 17:04:15 +01:00
Kevin Sawicki
577480421d Merge pull request #5063 from electron/mention-codesigning
Mention signing is required on OS X for automatic updates
2016-04-07 09:04:00 -07:00
Kevin Sawicki
59991f2fd8 Mention codesigning is required on OS X 2016-04-07 09:03:31 -07:00
christoth
a79c63581d Update doc to reflect use of flexbox layout
Updated documentation, changed `display:inline-block` to `display:inline-flex', explicitly noted the use of the new layout and how it can be broken by overwriting the CSS `display' property.
2016-04-07 10:42:42 -04:00
Cheng Zhao
cf2a17cf88 Merge pull request #5048 from preco21/master
Docs: Update Korean docs as upstream
2016-04-07 21:22:24 +09:00
Cheng Zhao
82856eb099 Merge pull request #5029 from Mr0grog/5013-add-main-frame-param-for-did-fail-load
Add `isMainFrame` param to WebContents `did-fail-load` event
2016-04-07 20:22:02 +09:00
Cheng Zhao
7d3f8cb222 Merge pull request #5009 from deepak1556/context_creation_patch
browser: create cert verifier when browser context is created
2016-04-07 16:18:55 +09:00
Cheng Zhao
efb0fc2ea5 Merge pull request #4968 from phamdaniel/exit-events
Don't emit 'will-quit' when 'app.exit()' is called.
2016-04-07 16:14:35 +09:00
Cheng Zhao
aae83cbce8 Merge pull request #4986 from Aluxian/Aluxian-patch-1
Add squirrel-updates-server link in the docs
2016-04-07 16:11:49 +09:00
Cheng Zhao
adb112e970 Merge pull request #5056 from electron/fix-a11y-reader
Fix NVDA/JAWS support in Electron
2016-04-07 16:11:05 +09:00
Cheng Zhao
bcb4ba6f99 Merge pull request #5040 from electron/python2
Allow bootstrap to be invoked via python2
2016-04-07 16:10:51 +09:00
Cheng Zhao
cb47dfa90e Fix problem with old Node 2016-04-07 15:59:28 +09:00
Cheng Zhao
71b67534a8 Fix coding styles 2016-04-07 15:45:20 +09:00
Paul Betts
3ee366257c Allow bootstrap to be invoked via python2
This means that on most Linux distributions where python3 is the default, we
can invoke `python2 script/bootstrap.py` and have it all work
2016-04-07 15:43:57 +09:00
Cheng Zhao
d171cfe8d0 Merge pull request #4924 from electron/bengotow/osx-tray-templates
Fix broken template image support in Tray icon
2016-04-07 15:40:35 +09:00
Cheng Zhao
548febfa4c Fix style issues 2016-04-07 15:23:16 +09:00
Ben Gotow
e0ee60f290 Fix memory leak 2016-04-07 15:21:07 +09:00
Ben Gotow
91457fe739 Support images larger than self.bounds 2016-04-07 15:21:07 +09:00
Ben Gotow
f9644463a9 Fix broken template image support in Tray icon
Between Electron `0.30.x` and `0.37.x`, the tray icon stopped automatically inverting template images when highlighted. NSImageView normally uses the correct color for template images magicaly, but I think the addition of event handlers in the container view prevents the image view from determining highlight state.

This PR switches to drawing the image manually. The `drawRect` function decides whether to use `image` or `alternateImage`(pressed image) and then if that image is marked as a template, it fills it with the same color used for the text before drawing it.
2016-04-07 15:21:07 +09:00
Cheng Zhao
80f66031cb Merge pull request #5068 from electron/fix-ci
Update node: bring CI back to green
2016-04-07 15:20:16 +09:00
Cheng Zhao
fb299c7fcb Update node: bring CI back to green 2016-04-07 14:58:14 +09:00
Cheng Zhao
55b8e9aa44 Bump v0.37.5 2016-04-07 10:34:25 +09:00
Cheng Zhao
b4885b9a37 atom => electron in upload script 2016-04-07 10:34:25 +09:00
Paul Betts
6e7aa6d299 Even though this call is probably fast, it can potentially happen a lot, make it _really_ fast 2016-04-06 10:44:39 -07:00
Paul Betts
c474ad0913 Revert "Remove custom WM_GETOBJECT"
This reverts commit 705001a50e.
2016-04-06 10:16:41 -07:00
Plusb Preco
5dfc64120f Merge remote-tracking branch 'refs/remotes/electron/master' 2016-04-06 14:03:03 +09:00
Cheng Zhao
b48788af43 Merge pull request #5033 from electron/fix-buffer-crash
Rebase on the correct Node commit
2016-04-05 20:44:09 +09:00
Cheng Zhao
dd283ff8d7 spec: We should not use pre release of Node 2016-04-05 19:53:07 +09:00
Cheng Zhao
7796dbb7ce Update node: rebase on v5.10.0 tag instead of master branch 2016-04-05 19:34:13 +09:00
Cheng Zhao
c562b24df8 spec: Add test case for #5028 2016-04-05 17:08:27 +09:00
Rob Brackett
884c9cc2f5 Document isMainFrame argument for WebContents did-fail-load event. 2016-04-04 19:36:34 -07:00
Rob Brackett
f12f87d6f0 Add isMainFrame as last argument to WebContents did-fail-load event.
Fixes #5013.
2016-04-04 19:26:06 -07:00
Kevin Sawicki
fa27120429 Merge pull request #4978 from electron/new-electron-org
Updates links for new GitHub organization
2016-04-04 12:34:50 -07:00
Kevin Sawicki
c2bcf8cbde Update links for new Electron org 2016-04-04 12:18:37 -07:00
Kevin Sawicki
b553981644 Update readme and contributing guide for new org 2016-04-04 12:07:22 -07:00
Kevin Sawicki
fc84c952f2 Update source code for new org 2016-04-04 12:07:22 -07:00
Kevin Sawicki
102f7e8e33 Update docs for new org 2016-04-04 12:05:53 -07:00
Kevin Sawicki
5ffa30a563 Update submodules for new org 2016-04-04 12:05:53 -07:00
Plusb Preco
492a7d0ffe 📝 Update Korean docs as upstream
[ci skip]
2016-04-04 01:01:01 +09:00
Plusb Preco
6e9c27fdaa 📝 Update Korean docs as upstream
[ci skip]
2016-04-04 00:56:07 +09:00
Cheng Zhao
fdb138f79c Bump v0.37.4 2016-04-03 18:31:23 +09:00
Cheng Zhao
d62d8bbf0a Merge pull request #4998 from atom/node-5.10.0
Upgrade Node to v5.10.0
2016-04-03 16:53:11 +09:00
Cheng Zhao
39a20ea4fb Upgrade Node to v5.10.0 2016-04-03 15:05:47 +09:00
Cheng Zhao
442ccbe204 Merge pull request #4997 from atom/default-app-background-color
Set backgroundColor for the default app
2016-04-03 14:07:39 +09:00
Cheng Zhao
a9ea8b92f0 Merge pull request #4988 from atom/accelerator-docs
use example accelerators that align with best practices
2016-04-03 14:03:32 +09:00
Cheng Zhao
eb82f7cea9 Update docs for backgroundColor 2016-04-03 13:55:33 +09:00
Cheng Zhao
165009681b Set backgroundColor for the default app 2016-04-03 13:53:09 +09:00
Cheng Zhao
a6f19c4292 Merge pull request #4996 from atom/osx-no-white-flash
Remove the white flash when loading page on OS X
2016-04-03 13:44:43 +09:00
deepak1556
769ba02b2a browser: create cert verifier when browser context is created 2016-04-03 10:01:47 +05:30
Cheng Zhao
491bf30a15 Window with frame should have white background by default 2016-04-03 12:04:58 +09:00
Cheng Zhao
f94661547c mac: backgroundColor should not change titlebar color 2016-04-03 11:59:21 +09:00
Cheng Zhao
4a724e91e0 Update libchromiumcontent: remove white background on OS X 2016-04-03 11:17:57 +09:00
Cheng Zhao
e5aa712bf3 Merge pull request #4995 from atom/fix-white-flash
Set the background color of RenderViewHost to transparent
2016-04-03 11:14:27 +09:00
Cheng Zhao
9828875ebc Set the background color of RenderViewHost to transparent 2016-04-03 10:42:49 +09:00
Cheng Zhao
8c3ff97ba4 Make the logic of ParseHexColor more easy to understand
This also fixes the #FFFF style of color hex.
2016-04-03 10:42:49 +09:00
Cheng Zhao
8bc95fe279 Merge pull request #4993 from atom/background-color
Use BrowserWindow's backgroundColor as renderer view's background color
2016-04-03 09:39:10 +09:00
Charlie Hess
a66565fd3f Merge remote-tracking branch 'upstream/master' 2016-04-02 11:54:16 -07:00
Cheng Zhao
19a172f2f5 Remove the hacks because of transparent background 2016-04-02 21:21:30 +09:00
Cheng Zhao
1980d85f3e Fix converting SkColor to NSColor
Close #4992.
2016-04-02 21:18:15 +09:00
Cheng Zhao
cb470cb94b Use BrowserWindow's backgroundColor as renderer view's background color 2016-04-02 20:46:50 +09:00
Cheng Zhao
70ca49e36a Merge pull request #4989 from atom/document-option-vs-alt
use alt, not option
2016-04-02 19:19:09 +09:00
Cheng Zhao
7bfe80f835 Merge pull request #4897 from atom/node-integration-inheritance
Disable node on child window when disabled on parent
2016-04-02 19:14:58 +09:00
Kevin Sawicki
527ff66115 Pull app/session from remote 2016-04-01 16:59:13 -07:00
Kevin Sawicki
3695e38719 Remove duplicate require 2016-04-01 16:53:44 -07:00
Kevin Sawicki
7734f6af62 Remove semicolons 2016-04-01 16:52:55 -07:00
Kevin Sawicki
909ed54bef Remove stray log 2016-04-01 16:52:28 -07:00
Kevin Sawicki
230ed78dd6 Remove lint warnings 2016-04-01 16:51:17 -07:00
Kevin Sawicki
ef2a28ca86 Listen for browser-window-created event for asserts 2016-04-01 16:50:20 -07:00
Kevin Sawicki
55b12c184b Doc node integration inheritance 2016-04-01 16:48:21 -07:00
Kevin Sawicki
eafe9c245b Disable guest node integration when embedder has it disabled 2016-04-01 16:48:21 -07:00
Kevin Sawicki
fd12e1f506 Add failing spec for webview nodeIntegration inheritance 2016-04-01 16:47:17 -07:00
Kevin Sawicki
4890734f66 Add missing title param 2016-04-01 16:42:53 -07:00
Kevin Sawicki
e5164d2255 Check of nodeIntegration is strictly equal to false 2016-04-01 16:42:21 -07:00
Kevin Sawicki
dbe1c1d4e4 Check nodeIntegration on embedder's webPreferences 2016-04-01 16:40:50 -07:00
Kevin Sawicki
9e66df23d0 Add clearer assertion of process being undefined 2016-04-01 16:40:33 -07:00
Kevin Sawicki
d7b1792503 Use template strings 2016-04-01 16:39:31 -07:00
Kevin Sawicki
2713580d09 Remove stray log 2016-04-01 16:39:31 -07:00
Kevin Sawicki
463e077c3a Disable node on child when disabled on parent 2016-04-01 16:39:18 -07:00
Kevin Sawicki
777704e659 Add failing spec for nodeIntegration inheritance 2016-04-01 16:39:06 -07:00
Kevin Sawicki
afdad927b7 Merge pull request #4976 from atom/electron-resources
Rename atom to electron in bundled resources
2016-04-01 16:26:05 -07:00
Kevin Sawicki
3c96d7b726 Rename atom.asar to electron.asar in specs 2016-04-01 16:12:57 -07:00
Kevin Sawicki
ee9128268e Rename atom.icns to electron.icns 2016-04-01 16:12:12 -07:00
Kevin Sawicki
ce95747a25 atom.asar -> electron.asar 2016-04-01 16:12:12 -07:00
Kevin Sawicki
c036986cc4 atom.gyp -> electron.gyp 2016-04-01 16:11:40 -07:00
Kevin Sawicki
ef08138a8d Merge pull request #4969 from atom/null-dialog-callback
Add dialog callback fallback
2016-04-01 16:11:09 -07:00
Zeke Sikelianos
2853356b10 use alt, not option 2016-04-01 15:48:12 -07:00
Zeke Sikelianos
b92e86301a use cross-platform accelerator in globalShorcut documentation 2016-04-01 14:54:25 -07:00
Zeke Sikelianos
ac419038c6 use example accelerators that align with best practices 2016-04-01 14:09:01 -07:00
Kevin Sawicki
400efa1b7d Fallback to using the last argument as the callback 2016-04-01 12:54:06 -07:00
Kevin Sawicki
b2ad0a05d7 Merge pull request #4956 from atom/default-app-asar
Store default_app in .asar archive
2016-04-01 12:52:51 -07:00
Kevin Sawicki
5221154653 Remove logging 2016-04-01 12:40:32 -07:00
Kevin Sawicki
464dad3135 Store default_app in .asar archive 2016-04-01 12:40:32 -07:00
Alexandru Rosianu
ff7bb1e6cb Add squirrel-updates-server link in the docs
Add link to Aluxian/squirrel-updates-server in the docs page for autoUpdater
2016-04-01 14:28:52 +03:00
Cheng Zhao
4b9b630e80 Merge pull request #4982 from atom/fix-windows
Fix various problems on Windows build
2016-04-01 16:57:27 +09:00
Cheng Zhao
b35f4c1805 spec: Fix failing test due to path delimiter 2016-04-01 16:42:44 +09:00
Cheng Zhao
247b3f3605 Fix the background color in test app 2016-04-01 16:35:19 +09:00
Cheng Zhao
576b54320a Fix compilation errors on Windows 2016-04-01 16:34:20 +09:00
Cheng Zhao
6f7a98d7c9 Merge pull request #4981 from atom/member-object-reference
Remote object should be referenced by its members
2016-04-01 16:11:21 +09:00
Cheng Zhao
39d2b95a33 Reference the remote object in its prototype chain's methods 2016-04-01 15:46:01 +09:00
Cheng Zhao
b9ead472a5 spec: Remote object should be referenced by methods in its prototype chain 2016-04-01 15:35:34 +09:00
Cheng Zhao
4ebb01f8c9 Remote object's members should reference itself 2016-04-01 15:26:30 +09:00
Cheng Zhao
f36851fcff spec: Remote object should be referenced by its members 2016-04-01 15:05:05 +09:00
Cheng Zhao
0416e65b8b Merge pull request #4917 from deepak1556/new_window_disposition_patch
browser: fix disposition value for new-window event
2016-04-01 13:52:29 +09:00
deepak1556
e14c91771b removed redundant delegation 2016-04-01 08:14:29 +05:30
deepak1556
7e366dd5c8 Update libchromiumcontent 2016-04-01 08:14:29 +05:30
deepak1556
e0fe478ae7 decide early on render initiated window creations 2016-04-01 08:14:29 +05:30
Robo
7016fbe258 browser: fix disposition value for new-window event 2016-04-01 08:14:29 +05:30
Cheng Zhao
7353fb4296 Merge pull request #4955 from atom/remove-node-integration-disable-path
Remove path for nodeIntegration value of 'disable'
2016-04-01 11:14:30 +09:00
Cheng Zhao
7023528042 Merge pull request #4909 from atom/standard
Use `standard` JavaScript Style
2016-04-01 11:13:56 +09:00
Kevin Sawicki
1eddaecef8 Merge pull request #4964 from jwheare/app-command-docs
Improve app-command docs, list arguments and explain command string
2016-03-31 15:45:16 -07:00
Kevin Sawicki
389b2b5cdd Merge pull request #4963 from preco21/document-fixes-2
Docs: Improve docs styles
2016-03-31 15:44:31 -07:00
Kevin Sawicki
f87e417f7f Merge pull request #4962 from erkyrath/doc-issue-4884
Added information about the enabled, visible, and checked properties
2016-03-31 15:43:22 -07:00
Kevin Sawicki
9e2dd13f9a Merge pull request #4959 from atom/check-url-before-opening
Only open http/https links in new-window example
2016-03-31 15:41:33 -07:00
Jessica Lord
ccbbf35696 Merge pull request #4970 from felixrieseberg/dialog-note
Add "remote" note to dialog docs
2016-03-31 11:20:08 -07:00
Felix Rieseberg
ae5a6e61c5 📝 Add "remote" note to dialog docs
Ref #4943
2016-03-31 09:54:01 -07:00
Kevin Sawicki
f033f259b4 Only check for nodeIntegration being true 2016-03-31 08:33:38 -07:00
Kevin Sawicki
daa09ea9e7 Remove path for nodeIntgration value of 'disable' 2016-03-31 08:33:38 -07:00
Daniel Pham
6e46753499 Don't emit 'will-quit' when 'app.exit()' is called. Fixes #4643 2016-03-31 10:18:18 -04:00
Cheng Zhao
293ca4ef55 Merge pull request #4929 from deepak1556/url_request_fetch_job_patch
protocol: return status of ReadRawData instead of relying on SetStatus
2016-03-31 19:37:28 +09:00
Cheng Zhao
07fc0880fb Merge pull request #4926 from preco21/master
Docs: Update Korean docs as upstream
2016-03-31 19:31:29 +09:00
Cheng Zhao
303290bfb4 Merge pull request #4965 from atom/docs-get-locale
docs: Add notes on app.getLocale
2016-03-31 17:38:39 +09:00
Cheng Zhao
e23faceba0 docs: Add notes on app.getLocale 2016-03-31 17:22:09 +09:00
James Wheare
d4a14bc215 Improve app-command docs, list arguments and explain command string 2016-03-31 08:56:49 +01:00
Cheng Zhao
996ad10344 Merge pull request #4902 from hdwong/master
fix translation
2016-03-31 16:02:39 +09:00
Plusb Preco
546ad643e4 📝 Add missing docs
[ci skip]
2016-03-31 14:30:14 +09:00
Plusb Preco
a648528f43 📝 Normailze note markers
* Normalize note markers syntax `__` to `**`

[ci skip]
2016-03-31 14:22:28 +09:00
Plusb Preco
346ef9df0c 📝 Update docs styles
* Adjust line length to `80`
* Normalize whitespaces

[ci skip]
2016-03-31 14:16:14 +09:00
Plusb Preco
f7e5c65802 📝 Update Korean docs as upstream
[ci skip]
2016-03-31 14:03:35 +09:00
Andrew Plotkin
cfd2cdb9c4 Added information about the enabled, visible, and checked properties --
when they can be set and what they mean.

Also tidied up the grammar and clarified wording.
2016-03-30 23:57:28 -04:00
Cheng Zhao
72878d0de6 Merge pull request #4901 from yucheng-inc/master
translations   zh-CN    doc
2016-03-31 11:23:01 +09:00
Cheng Zhao
be5e787edf Merge pull request #4885 from ArekSredzki/patch-1
Added electron-release-server link to the docs
2016-03-31 11:07:14 +09:00
Cheng Zhao
c220753c60 Merge pull request #4896 from felixrieseberg/default-protocol-handler
Enable Electron to set/unset itself as default protocol handler (OS X, Windows)
2016-03-31 10:38:57 +09:00
Cheng Zhao
0e3737423b Merge pull request #4843 from jwheare/mac-swipe-events
OSX: Expose 3-finger swipe events in browser-window
2016-03-31 10:37:27 +09:00
Cheng Zhao
c307478d5d Merge pull request #4892 from deepak1556/v8_util_patch
common: use v8::private symbols as identifiers for object properties
2016-03-31 10:22:23 +09:00
Cheng Zhao
afb82fcc1f Update native-mate for #4892 2016-03-31 10:21:21 +09:00
Zeke Sikelianos
252121ac70 give anonymous function a name 2016-03-30 17:00:35 -07:00
Zeke Sikelianos
9efd29d059 fix a minor style issue 2016-03-30 17:00:35 -07:00
Zeke Sikelianos
d5e8bb7f12 derp 2016-03-30 17:00:35 -07:00
Zeke Sikelianos
7c58f7fb02 eradicate all per-file eslint globals 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
aadc0bee25 do not lint on windows CI 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
0d11b755db say we are linting 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
afbc914f8b try to fix CI linting 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
47a61e9f27 use window.location instead of location 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
6425ef4261 restrict mocha scope to /spec; break out link tasks 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
b5afad9da7 avoid using eslint comment exceptions 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
1a18151eff remove eslint from devDependencies 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
0fd0887407 use standard.env.mocha instead of a list of globals 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
71f8ba6f7a update CONTRIBUTING doc 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
e156faea5c replace eslint with standard 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
6f845373a7 do not return and assign 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
98b4353ef8 replace snazzy with standard; autoformat package.json 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
42e7ee2b4a finish standardizing! 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4e2f1311e0 replace __proto__ with Object.setPrototype 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
2c3cacdc08 standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9 standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
fd0f9519f1 remove useless constructors 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
14fb3c4598 throw error if it exists 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c5f70c8d99 dance around error checking with this one weird trick 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
5e4696f4a7 standardize more 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
9db733a4ff mostly more globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
c4b6cf4a8e do more manual cleanup and specify globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f47fa25e39 tiptoe 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
68510cbe49 standardize more 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
3a55f0d1f7 set standard.globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
09635ae50e reduce ignore list in favor of one-liner ignores 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
67d189474c autoformat more files 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
2fb92076b6 standard-format has done its work; on to snazzy 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
7404b848a2 tell standard to ignore /vendor directory 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
f35f362272 autoformat more files 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
06b556c34c ignore more files that are confusing standard-format 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
bd9b0b8ed3 wrap conditional, because return can only be used in a function 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
3855a774ab autoformat more easy files 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
67fa250020 standardize asar.js by hand 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
c845ea8372 autoformat more easy files 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
80f7c82f93 finish standardizing crash reporter 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
f61010df96 do not standardize rpc-server.js because reasons
standard-format freaks out on this line:

let obj = new (Function.prototype.bind.apply(constructor,
[null].concat(args)))

http://stackoverflow.com/questions/1606797/use-of-apply-with-new-operato
r-is-this-possible
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
ca7b492b97 tiptoeing along, keeping the suite passing 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
ee181294b3 manual syntax fixes on rpc server 2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4d4f479721 manually standardize this tricky file 2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4794385fac first pass at standardizing; suite still passing! 2016-03-30 17:00:30 -07:00
Zeke Sikelianos
f25c3d33b6 mention standard in coding style doc 2016-03-30 17:00:05 -07:00
Zeke Sikelianos
6e31e51292 add standard-format to devDeps 2016-03-30 17:00:05 -07:00
Kevin Sawicki
dd23b09569 Only open http/https links 2016-03-30 16:55:10 -07:00
Kevin Sawicki
8bcede8019 Merge pull request #4887 from sergeybekrin/master
Improve error reporting when passing invalid argument types for dialog API methods
2016-03-30 16:34:42 -07:00
Sergey Bekrin
4ac08870d0 Tweak error messages for dialog API 2016-03-30 23:07:13 +03:00
Kevin Sawicki
ad67070f23 Merge pull request #4861 from OctoHuman/master
Fix alert()
2016-03-30 12:40:41 -07:00
Zeke Sikelianos
839ab07fd4 Merge pull request #4947 from preco21/document-fixes
Docs: Update docs styles
2016-03-29 20:38:42 -07:00
Plusb Preco
c4a2329665 📝 Update docs styles
* Adjust line length to `80`
* Change platform marker `*` to `_`
* Enhance a note section

[ci skip]
2016-03-30 10:57:42 +09:00
Plusb Preco
edbb2b4a26 📝 Update Korean docs as upstream
[ci skip]
2016-03-30 10:42:59 +09:00
Zeke Sikelianos
7dbf07edfc Merge pull request #4941 from atom/black-background
Add "black background?" to FAQ
2016-03-29 16:31:51 -07:00
Felix Rieseberg
ff2d005058 Add "black background?" to FAQ
Closes #4937
2016-03-29 15:06:05 -07:00
Felix Rieseberg
1231360b2f Add API: RemoveAsDefaultProtocolHandler 2016-03-28 15:31:01 -07:00
Kevin Sawicki
664f59a8eb Merge pull request #4921 from roramirez/curl_build_linux
add curl package into Ubuntu section missing for the build
2016-03-28 10:59:40 -07:00
Kevin Sawicki
534fa7073e Merge pull request #4920 from PierBover/master
Update desktop-environment-integration.md
2016-03-28 10:44:15 -07:00
Pier Bover
116aa2f483 Update desktop-environment-integration.md 2016-03-28 11:41:16 -06:00
Kevin Sawicki
48cea8aa35 Merge pull request #4923 from guatedude2/master
Update power-monitor.md
2016-03-28 09:36:01 -07:00
Alejandro Gonzalez Sole
ab685ac335 Update power-monitor.md
Updated docs in power-monitor to reflect windows only events
2016-03-27 23:03:34 -04:00
deepak1556
73201e419d protocol: return status of ReadRawData instead of relying on SetStatus 2016-03-28 02:09:56 +05:30
Cheng Zhao
4ebd24d128 Merge pull request #4927 from atom/node-5.9.1
Upgrade to Node v5.9.1
2016-03-27 21:35:20 +09:00
Cheng Zhao
a4d2dd9b4d Export symbols of node::Environment 2016-03-27 20:36:39 +09:00
Cheng Zhao
e401335ebb Get rid of the global_env 2016-03-27 19:21:12 +09:00
Cheng Zhao
e5886dda9b Avoid re-evaluating internal modules 2016-03-27 19:16:26 +09:00
Cheng Zhao
896ea7b79d Do not create dummy node environment
There is a bug in V8 that using Private in a dummy environment would
result in crash.
2016-03-27 19:16:26 +09:00
Cheng Zhao
70f9cb098f Use Environment::KickNextTick 2016-03-27 19:13:44 +09:00
Cheng Zhao
d83cb53997 Type of native array has changed 2016-03-27 19:13:44 +09:00
Cheng Zhao
f23729acdb Upgrade to node v5.9.1 2016-03-27 19:13:44 +09:00
Plusb Preco
2ffe891cc8 📝 Update Korean docs as upstream
[ci skip]
2016-03-27 18:07:58 +09:00
Cheng Zhao
5a3552f577 Merge pull request #4854 from preco21/master
Docs: Update Korean docs as upstream
2016-03-27 14:47:50 +09:00
Cheng Zhao
75f0942057 Bump v0.37.3 2016-03-27 12:16:12 +09:00
Cheng Zhao
247a63efe3 Merge pull request #4869 from atom/fix-set-destructor
Run callback of setDestructor immediately when GC happens
2016-03-27 10:35:28 +09:00
Rodrigo Ramírez Norambuena
c4128e6b4b add curl package into Ubuntu section missing for the build 2016-03-25 23:47:47 -03:00
Pier Bover
a3f30ca822 Update desktop-environment-integration.md 2016-03-25 16:26:14 -06:00
Kevin Sawicki
19931397ac Merge pull request #4883 from atom/repl
Add repl option in default app
2016-03-24 20:06:14 -07:00
Kevin Sawicki
09710d6c47 Don't quit on window-all-closed when in repl mode 2016-03-24 16:02:02 -07:00
Kevin Sawicki
832ac97088 Exit process when repl exits 2016-03-24 16:02:02 -07:00
Kevin Sawicki
8685f8e6c8 Add repl run script 2016-03-24 16:02:02 -07:00
Kevin Sawicki
e49eae4047 Document -i/--interactive option 2016-03-24 16:02:02 -07:00
Kevin Sawicki
0066833887 Add repl CLI option 2016-03-24 16:02:02 -07:00
Kevin Sawicki
4a1e060832 Merge pull request #4911 from atom/link-newline
Put link on same line as name
2016-03-24 16:01:07 -07:00
Kevin Sawicki
8feb0f0440 Put link on same line as name 2016-03-24 15:57:42 -07:00
Kevin Sawicki
8ce1ca4590 Merge pull request #4910 from atom/update-structure-doc
Update source tree docs for new layout
2016-03-24 15:57:31 -07:00
Kevin Sawicki
8839cc51c2 Update source tree docs for new layout 2016-03-24 14:47:31 -07:00
小奔奔
f7a82987f4 fix translation 2016-03-24 15:30:46 +08:00
wujingke
ff3e29041e Merge pull request #9 from heyunjiang/master
modify the latest files
2016-03-24 14:29:48 +08:00
Felix Rieseberg
d2567b0381 Add API: SetASDefaultProtocolHandler
This PR adds an API enabling Electron to set itself as the default
protocol handler for a custom porotocl on both oS X and Windows.

For details, please see `docs/app.md`.

Closes #4857
2016-03-23 22:12:17 -07:00
Robo
5fccbfc7c6 common: use v8::private symbols as identifiers for object properties 2016-03-24 01:24:01 +05:30
James Wheare
8482109dea Switch to a single OS X swipe event with a direction argument 2016-03-23 15:20:11 +00:00
heyunjiang
0bd45c7d75 modify 2016.3.23 2016-03-23 16:11:23 +08:00
Sergey Bekrin
7f78781800 Improve error reporting when using invalid argument types for dialog API methods 2016-03-23 10:44:11 +03:00
Plusb Preco
8939c6ac12 📝 Update Korean readme as upstream
[ci skip]
2016-03-23 09:42:14 +09:00
Plusb Preco
c0f13103a4 📝 Update Korean docs as upstream
[ci skip]
2016-03-23 09:39:03 +09:00
Arek Sredzki
951bd745aa Added electron-release-server link to the docs
By request from a couple users, I've added a link to the electron-release-server, that makes using the auto-updater much easier.
2016-03-22 16:35:03 -07:00
Kevin Sawicki
6041c7edf9 Merge pull request #4872 from atom/destructured-assignment
Destructuring assignment
2016-03-22 13:57:42 -07:00
Kevin Sawicki
2d32956903 Destructure objects 2016-03-22 13:11:42 -07:00
Kevin Sawicki
4127b524d5 Destructure params directly 2016-03-22 13:11:42 -07:00
Kevin Sawicki
43746727aa Use direct params instead of rest params 2016-03-22 13:11:42 -07:00
Kevin Sawicki
4f4dc2f4d8 Use destructuring assigment 2016-03-22 13:11:42 -07:00
Kevin Sawicki
baa566adae Merge pull request #4851 from k0kubun/app-doc-set-name
Document `app.setName()`
2016-03-22 09:35:49 -07:00
Plusb Preco
8fac75f4ee 📝 Update Korean docs as upstream
[ci skip]
2016-03-22 13:48:14 +09:00
Takashi Kokubun
8cf4574198 Document app.setName()
[ci skip]
2016-03-22 11:01:23 +09:00
Jessica Lord
b4f1a63f64 Merge pull request #4864 from miniak/fix-menu-api-doc
Fix Menu documentation
2016-03-21 13:40:50 -07:00
Kevin Sawicki
8cff36967e Merge pull request #4871 from atom/add-more-camel-case-options
Add minWidth and maxWidth to ints array
2016-03-21 11:12:35 -07:00
Kevin Sawicki
cbfe8b9228 Add minWidth and maxWidth to ints array 2016-03-21 09:12:47 -07:00
Cheng Zhao
52d09e9600 Run callback of setDestructor immediately when GC happens
Fix #4733.
2016-03-21 21:42:12 +09:00
Cheng Zhao
a52285596e Merge pull request #4846 from atom/rest-parameters
Use rest parameters
2016-03-21 21:03:28 +09:00
Cheng Zhao
e08b48ab48 Merge pull request #4840 from atom/undefined-menu-accelerator
Undefined menu accelerator
2016-03-21 21:02:44 +09:00
Cheng Zhao
663e42070f Merge pull request #4845 from atom/node-version-file
Add .node-version pinned to 5.1.1
2016-03-21 21:02:03 +09:00
Cheng Zhao
43cb48295b Merge pull request #4831 from atom/docs-cleanup
[WIP] Docs cleanup
2016-03-21 20:57:26 +09:00
Jessica Lord
4abed1f83f Merge pull request #4853 from preco21/patch-9
Docs: Correct link anchor
2016-03-20 21:38:24 -07:00
Jessica Lord
dd1cfdd31c Merge pull request #4860 from chadluo/master
fix link
2016-03-20 21:30:34 -07:00
Milan Burda
f84c41f684 Fix Menu documentation 2016-03-20 19:05:18 +01:00
OctoHuman
116d61185a Refix alert() 2016-03-20 03:40:12 -05:00
OctoHuman
9f6541228d Fix alert() 2016-03-20 02:09:30 -05:00
chadluo
a89e79a7ed fix link 2016-03-20 14:20:43 +11:00
Plusb Preco
d73dc0958b 📝 Update Korean docs as upstream
[ci skip]
2016-03-20 04:04:39 +09:00
Plusb Preco
70baf86ce2 📝 Correct link anchor 2016-03-20 03:36:27 +09:00
Kevin Sawicki
a53c7529c1 Remove unneeded slice call 2016-03-18 11:54:34 -07:00
Kevin Sawicki
8889c29866 Use rest parameters 2016-03-18 11:51:02 -07:00
Kevin Sawicki
99d6afb3a1 Add .node-version pinned to 5.1.1 2016-03-18 11:11:56 -07:00
Zeke Sikelianos
827730144b style nit 2016-03-18 10:53:49 -07:00
Kevin Sawicki
e05804848f Merge pull request #4829 from atom/deprecated-browser-window-options
Report deprecated BrowserWindow options
2016-03-18 09:36:49 -07:00
Kevin Sawicki
6aa452cda4 Set _setDeprecatedOptionsCheck on exports 2016-03-18 09:06:03 -07:00
Kevin Sawicki
7668c1ea0b Use deprecate.warn instead of deprecate.log 2016-03-18 09:02:58 -07:00
James Wheare
03319a5426 OSX: Capture 3-finger swipe events in NativeWindow 2016-03-18 15:21:19 +00:00
Zeke Sikelianos
344dda4029 ignore set menu item fields 2016-03-17 16:20:23 -07:00
Zeke Sikelianos
e9ba5abe03 test for null accelerator too 2016-03-17 16:14:31 -07:00
Zeke Sikelianos
87395cdef8 add failing spec for undefined accelerator 2016-03-17 16:09:16 -07:00
Kevin Sawicki
737ffd8d7c Improve deprecated message on webPreferences options 2016-03-17 13:37:08 -07:00
Kevin Sawicki
c31882749d Correct typos in comments 2016-03-17 13:37:08 -07:00
Kevin Sawicki
90d815ce6c Add todo about removing hyphenated options 2016-03-17 13:37:08 -07:00
Kevin Sawicki
3e7501579f Add camel case versions to ints array 2016-03-17 13:37:08 -07:00
Kevin Sawicki
a14380ed01 Set webPrereferences from features tring 2016-03-17 13:37:07 -07:00
Kevin Sawicki
2acfb8ad82 node-integration -> nodeIntegration 2016-03-17 13:37:07 -07:00
Kevin Sawicki
15397bf879 Report deprecated BrowserWindow options 2016-03-17 13:37:07 -07:00
Kevin Sawicki
1b6e01ce6d Add missing semicolons 2016-03-17 13:37:07 -07:00
Kevin Sawicki
dfd13cf4ca persistented -> persisted 2016-03-17 13:37:07 -07:00
Kevin Sawicki
1e8e8f18b4 Add failing specs for deprecated options usage 2016-03-17 13:37:07 -07:00
Kevin Sawicki
5c9b19b508 web-preferences -> webPreferences 2016-03-17 13:37:07 -07:00
Cheng Zhao
67db92d500 Merge pull request #4821 from yucheng-inc/master
translations   zh-CN    doc
2016-03-17 22:55:01 +09:00
Cheng Zhao
38d99950f8 Merge pull request #4837 from atom/breakpad-server
List breakpad server implementations in crashReporter docs
2016-03-17 22:54:52 +09:00
Cheng Zhao
cbd37ad3b9 docs: List breakpad server implementations 2016-03-17 22:29:32 +09:00
Cheng Zhao
912ec1437b Merge pull request #4812 from thanpolas/patch-1
More info for crash reporter form type and payload
2016-03-17 22:24:10 +09:00
Cheng Zhao
242be31440 Merge pull request #4805 from atom/automatically-set-app-model-id
Automatically set app user model ID
2016-03-17 22:21:29 +09:00
Cheng Zhao
48f1eb4584 Merge pull request #4836 from atom/get-native-handle-osx
Make it clear that image.getNativeHandle is OS X only
2016-03-17 22:21:21 +09:00
Cheng Zhao
939d69df6e Throw error with message of "Not implemented". 2016-03-17 22:01:31 +09:00
Cheng Zhao
f8b9a66ead docs: Make it clear image.getNativeHandle is OS X only 2016-03-17 21:55:44 +09:00
Cheng Zhao
081ab17e13 Merge pull request #4791 from atom/nativeimage-as-nsimage
Convert NativeImage instances to OS-specific representations
2016-03-17 21:49:46 +09:00
Cheng Zhao
75ec7a057a Update brightray for #4681 2016-03-17 21:45:13 +09:00
Zeke Sikelianos
01980dea11 s/troubles/problems/ 2016-03-17 00:03:24 -07:00
Zeke Sikelianos
5acfa8611a link to gyp 2016-03-16 13:15:34 -07:00
Paul Betts
e94da877c2 Fix compile oopses on non-OS X 2016-03-16 12:49:34 -07:00
Paul Betts
148014f99a Fix spec failure 2016-03-16 12:42:23 -07:00
Paul Betts
fa197ad583 Fix failing test 2016-03-16 12:40:28 -07:00
Zeke Sikelianos
6503f32ef9 add another link to ninja 2016-03-16 09:47:12 -07:00
Zeke Sikelianos
da47b569e8 link to the ninja website 2016-03-16 09:42:33 -07:00
Zeke Sikelianos
0d8994d81d improve wording in the FAQ 2016-03-16 09:37:04 -07:00
scycbx
c3f343e6c4 Merge pull request #8 from heyunjiang/master
final first
2016-03-16 16:02:22 +08:00
heyunjiang
25931d16ab modify 2days ago update 2files 2016-03-16 15:56:52 +08:00
heyunjiang
7bcb99f823 add last three files first 2016-03-16 15:41:12 +08:00
heyunjiang
3eac767e72 add build-instructions three first 2016-03-16 11:54:33 +08:00
heyunjiang
12f218c747 add build-system-overview first 2016-03-16 10:26:49 +08:00
Thanasis Polychronakis
492269a0fd More info for crash reporter form type and payload 2016-03-15 15:49:34 +02:00
Cheng Zhao
141f909b68 Merge pull request #4803 from yucheng-inc/master
translations   zh-CN    doc
2016-03-15 21:21:49 +09:00
Cheng Zhao
e50ba35871 Merge pull request #4777 from deepak1556/webview_background_patch
webview: allow setting background color
2016-03-15 21:12:04 +09:00
Cheng Zhao
98be7b6299 Merge pull request #4804 from deepak1556/devtools_workspace_patch
devtools: update filesystem api
2016-03-15 21:09:54 +09:00
Cheng Zhao
dbb8a6bf52 Update brightray for atom/brightray#204 2016-03-15 21:08:43 +09:00
scycbx
ce855c5685 Merge pull request #7 from heyunjiang/master
add web-contents first
2016-03-15 17:10:34 +08:00
heyunjiang
b105bf59c1 add last api files first 2016-03-15 17:03:48 +08:00
heyunjiang
c2c91b6477 add three render process's files first 2016-03-15 15:11:28 +08:00
heyunjiang
3c007d1333 add tray first 2016-03-15 14:00:40 +08:00
Paul Betts
665d3166ed Update the tests 2016-03-14 21:00:58 -07:00
Paul Betts
3ee4790dab Automatically set app user model ID
We shouldn't ask users to figure out this piece of Windows Arcana when
they're using Squirrel, let's just do it automatically.
2016-03-14 20:36:48 -07:00
heyunjiang
ae701977c6 add web-contents first 2016-03-15 11:13:43 +08:00
Paul Betts
f59752bf4f Update the docs to match 2016-03-14 19:51:37 -07:00
Paul Betts
d344c1e408 AsNativeRepresentation => getNativeHandle 2016-03-14 19:50:31 -07:00
Paul Betts
e3e6cd6fd8 Remove type parameter 2016-03-14 19:48:40 -07:00
Robo
cdc7b8d15e devtools: fix filesyatem api usage and use prefs to track filesystem paths 2016-03-15 07:51:36 +05:30
scycbx
cc4da371ff Merge pull request #6 from heyunjiang/master
add session end 3.15
2016-03-15 09:48:37 +08:00
Robo
fd53a4b24d modify default background for all render views 2016-03-14 19:26:20 +05:30
Robo
f8f3fba433 webview: allow setting background color 2016-03-14 15:01:36 +05:30
Cheng Zhao
e92d002eec Bump v0.37.2 2016-03-14 17:22:09 +09:00
Cheng Zhao
17f97bed30 Merge pull request #4793 from atom/gtk-dialog-extension
Add extension to filename automatically for GTK+ save dialog
2016-03-14 17:21:49 +09:00
Cheng Zhao
c2797e1864 Replace extension with the one in filter 2016-03-14 17:08:32 +09:00
heyunjiang
06a8db8a66 add protocol && session first 2016-03-14 15:43:04 +08:00
Cheng Zhao
81a16b424f Add extension to filename automatically for GTK+ save dialog 2016-03-14 16:28:01 +09:00
Cheng Zhao
73a5f323e7 Merge pull request #4788 from deepak1556/find_in_page_patch
webcontents: provide position of match with found-in-page event
2016-03-14 15:03:38 +09:00
Cheng Zhao
152e6af4b4 spec: Add test case for #4785 2016-03-14 14:54:45 +09:00
Cheng Zhao
5bc400e31f Merge pull request #4792 from atom/shutdown-v8
Leak the JavascriptEnvironment on exit
2016-03-14 14:34:24 +09:00
Cheng Zhao
9a13d559e9 Leak the JavascriptEnvironment on exit
This is to work around the bug that V8 would be waiting for background
tasks to finish on exit, while somehow it waits forever in Electron, more
about this can be found at https://github.com/atom/electron/issues/4767.

On the other handle there is actually no need to gracefully shutdown V8
on exit in the main process, we already ensured all necessary resources get
cleaned up, and it would make quitting faster.
2016-03-14 13:59:31 +09:00
Paul Betts
63d9174822 🔥 build warning on Win32 2016-03-13 20:27:44 -07:00
Paul Betts
248ac5c37b Add unit tests 2016-03-13 20:25:49 -07:00
Paul Betts
7233c83874 Linting 2016-03-13 20:18:03 -07:00
Paul Betts
5dea4b9b1c Add documentation 2016-03-13 20:11:43 -07:00
Paul Betts
262abc43f8 First hack at being able to return NSImage pointers 2016-03-13 20:08:53 -07:00
Paul Betts
b3da5370c0 Add a new method to get the representation of an image 2016-03-13 20:08:09 -07:00
Cheng Zhao
92a9c49a77 Update brightray for atom/brightray#203 2016-03-14 10:41:32 +09:00
Cheng Zhao
b428b2e1d5 Merge pull request #4787 from deepak1556/permission_handler_patch
browser: fix retrieving webcontents from associated process id
2016-03-14 10:40:59 +09:00
Robo
8378cbb1e8 webcontents: provide position of match with found-in-page event 2016-03-14 06:49:45 +05:30
Robo
48064ee7e9 browser: fix retrieving webcontents from associated process id 2016-03-14 04:14:04 +05:30
heyunjiang
d96836e608 add power-save-blocker first 2016-03-13 22:06:19 +08:00
Cheng Zhao
b2059ec8af Merge pull request #4774 from twolfson/dev/add.location.to.window.open.sqwished
Added support for window.location on window.open windows
2016-03-13 22:22:48 +09:00
Cheng Zhao
a2d86c998f Merge pull request #4773 from preco21/master
Docs: Update Korean docs as upstream
2016-03-13 22:02:45 +09:00
Cheng Zhao
4a6186bfa0 Merge pull request #4763 from HR/patch-3
Fix broken/outdated link and push up the version
2016-03-13 20:43:53 +09:00
heyunjiang
29609b6e5d add powerMonitor first 2016-03-13 14:15:11 +08:00
Cheng Zhao
dd158e172f Merge pull request #4743 from atom/clean-up-this-wrappers
Use arrow functions instead of CoffeeScript this wrapper functions
2016-03-13 13:17:30 +09:00
Cheng Zhao
bc9c48261a Merge pull request #4775 from atom/delay-load-powrprof
Delay loading powrprof.dll
2016-03-13 11:38:39 +09:00
Cheng Zhao
d96e03c402 Bump v0.37.1 2016-03-13 10:11:26 +09:00
Cheng Zhao
78c66da9e8 Update brightray: dealy loading powrprof.dll 2016-03-13 10:11:15 +09:00
Cheng Zhao
c036e8fa3b Merge pull request #4769 from bbondy/master
Fix libffmpeg.dylib path for install_name_tool
2016-03-13 09:39:42 +09:00
Todd Wolfson
7569d180c9 Added support for window.location on window.open windows 2016-03-12 18:05:01 -06:00
Plusb Preco
96d271e57c 📝 Update Korean docs as upstream
[ci skip]
2016-03-13 06:10:00 +09:00
Brian R. Bondy
c937568846 Fix libffmpeg.dylib path for install_name_tool 2016-03-12 10:16:26 -05:00
Cheng Zhao
b10f196d16 Bump v0.37.0 2016-03-12 09:54:10 +09:00
Habib Rehman
0e1bb98913 Fix broken/outdated link and push up the version 2016-03-12 00:26:29 +00:00
Cheng Zhao
71fb684069 spec: Skip webview.executeJavaScript in Travis on OS X
It is very easy to get timeout.
2016-03-12 09:18:12 +09:00
Cheng Zhao
a8d34ebac9 Merge pull request #4757 from atom/no-copy-system-libraries
Do not copy system libraries on Linux
2016-03-12 09:15:28 +09:00
Kevin Sawicki
3556507ab9 Use arrow functions for this binding 2016-03-11 14:08:14 -08:00
Kevin Sawicki
28e9d87d86 Add back return in getter 2016-03-11 11:25:56 -08:00
Kevin Sawicki
0e5e230c03 Remove lint errors due to rebase 2016-03-11 11:25:56 -08:00
Kevin Sawicki
3c11f5dc4d Remove returns from event handlers 2016-03-11 11:25:56 -08:00
Kevin Sawicki
0ee3446109 Use undefined instead of void 0 2016-03-11 11:25:56 -08:00
Kevin Sawicki
a3f08c9b51 Use arrow functions to replace old CoffeeScript => this wrappers 2016-03-11 11:25:56 -08:00
Kevin Sawicki
100ea975bd Merge pull request #4761 from atom/appveyor-badge
Add AppVeyor badge to README
2016-03-11 11:25:49 -08:00
Kevin Sawicki
a95d0078b5 Link to root build page 2016-03-11 09:39:12 -08:00
Kevin Sawicki
c2b1f630f6 Add AppVeyor badge 2016-03-11 09:37:56 -08:00
Kevin Sawicki
1346122d35 Merge pull request #4744 from atom/remove-unneeded-results-collecting
Remove unneeded results collecting/returning
2016-03-11 09:36:02 -08:00
Kevin Sawicki
6b1748d6d6 Don't collect results from delegate.menuWillShow 2016-03-11 08:55:48 -08:00
Kevin Sawicki
3a08aa37de Don't collect results from Menu::_callMenuWillShow 2016-03-11 08:55:48 -08:00
Kevin Sawicki
93939089ec Don't collect results in Menu.setApplicationMenu 2016-03-11 08:55:48 -08:00
Kevin Sawicki
3a1e837f8b Don't collect results in exit event callback 2016-03-11 08:55:47 -08:00
Kevin Sawicki
5ed6c7714b Don't return attributes from from WebViewImpl::setupWebViewAttributes 2016-03-11 08:55:47 -08:00
Cheng Zhao
0f620a5393 Do not copy system libraries on Linux 2016-03-11 22:29:03 +09:00
Cheng Zhao
cd327e65cb Revert "Bump v0.37.0"
This reverts commit aebfbf7782.

We have troubles with linux-ia32 release.
2016-03-11 22:20:11 +09:00
Cheng Zhao
aebfbf7782 Bump v0.37.0 2016-03-11 21:47:32 +09:00
Cheng Zhao
6aec1e6949 Merge pull request #4714 from atom/chrome49
Upgrade to Chrome 49
2016-03-11 21:39:52 +09:00
Cheng Zhao
ead94b7b1f Bump v0.36.11 2016-03-11 20:09:19 +09:00
Cheng Zhao
5f63df248a Fix the chrome version 2016-03-11 19:53:41 +09:00
Plusb Preco
288ef13fb5 📝 Update Korean docs as upstream
[ci skip]

📝 Update Korean docs as upstream

[ci skip]
2016-03-11 19:37:03 +09:00
Cheng Zhao
4765445b4f Merge pull request #4752 from yucheng-inc/master
translations   zh-CN    doc
2016-03-11 19:36:41 +09:00
Cheng Zhao
03ec5ced05 Merge pull request #4751 from maxbeatty/window-blur
Add blur method to window
2016-03-11 19:15:51 +09:00
heyunjiang
3e04884a57 add menu.md first 2016-03-11 17:25:38 +08:00
heyunjiang
fe248ac03f add ipc-main first 2016-03-11 16:05:02 +08:00
scycbx
e2e18200fb Merge pull request #5 from heyunjiang/master
update && add
2016-03-11 15:45:26 +08:00
heyunjiang
328583575d modify again and add dialog.md 2016-03-11 15:09:08 +08:00
Max Beatty
704b8335aa Add blur method to window ref #4724 2016-03-10 21:45:51 -08:00
heyunjiang
d25d1f3f8b add content-tracing && update browser-window 2016-03-11 11:53:04 +08:00
Cheng Zhao
d564727583 spec: Increase timeout for executeJavaScript 2016-03-11 11:17:02 +09:00
Cheng Zhao
83809cef09 Update to master branch of brightray and libchromiumcontent 2016-03-11 10:47:15 +09:00
Cheng Zhao
256c2684ee spec: Do not enter fullscreen in travis on OS X
It is too flaky
2016-03-11 10:36:08 +09:00
Cheng Zhao
abd466ee4a Merge pull request #4700 from ArekSredzki/async-document-hidden
Cache browser visibility state & emit visibilitychange event on change
2016-03-11 10:19:06 +09:00
Arek Sredzki
fcc1f4d7ed Finalized browser-window show & hide events, added tests & fixed os x implementation 2016-03-10 13:51:31 -08:00
Arek Sredzki
c1267b2320 Added 'show' & 'hide' events to browser-window, fixed visibilitychange event in renderer 2016-03-10 13:51:31 -08:00
Arek Sredzki
ee61ab2d26 Cache browser visibility state & emit visibilitychange event on change
Fixes #3788
2016-03-10 13:51:31 -08:00
heyunjiang
0ec7f35c24 finish browser-window first 2016-03-10 23:12:57 +08:00
Cheng Zhao
8e19edd1b5 Move toolchain related configures into one place 2016-03-10 22:40:09 +09:00
Robo
ed2103a49f update sysroot image revisions 2016-03-10 17:34:42 +05:30
Robo
dfe1641d1e set path for pkg-config when using sysroot 2016-03-10 17:34:42 +05:30
Robo
91951472bf use sysroot by default on linux 2016-03-10 17:34:42 +05:30
Robo
e27e3d641c linux: optionaly allow building x64 targets with sysroot 2016-03-10 17:34:42 +05:30
Cheng Zhao
60f40a6704 Fix linking error for Release build on Linux 2016-03-10 21:01:45 +09:00
Cheng Zhao
0794980d01 pdf.dll is not shipped any more 2016-03-10 17:36:11 +09:00
Cheng Zhao
cadd1969d9 Fix compilation errors on Windows 2016-03-10 17:06:23 +09:00
Cheng Zhao
20466bad8f Fix cpplint warnings 2016-03-10 17:06:23 +09:00
Cheng Zhao
89f17e0baf Create complete URLRequestContextGetter for URLRequestFetchJob
The trivial one is causing crashes.
2016-03-10 17:06:23 +09:00
Paul Betts
e3af5de7d7 Update pdf_to_emf_converter 2016-03-10 17:06:23 +09:00
Paul Betts
f4ec369873 More boring fixups 2016-03-10 17:06:22 +09:00
Paul Betts
1c01e4955f Modifiers moved under UI 2016-03-10 17:06:22 +09:00
Paul Betts
7b60ef6261 SetIsDraftMode no longer a thing, see https://groups.google.com/a/chromium.org/forum/m/#!topic/chromium-checkins/6qohfKmEYyg 2016-03-10 17:06:22 +09:00
Paul Betts
e835111195 More type fixups 2016-03-10 17:06:22 +09:00
Paul Betts
12e9b7ab88 Use assignment operator since both sides are scoped now 2016-03-10 17:06:22 +09:00
Paul Betts
60a2495b30 Update Get() => get(), Set() => reset() 2016-03-10 17:06:22 +09:00
Paul Betts
a737baafbf We don't need Metro 2016-03-10 17:06:22 +09:00
Cheng Zhao
d36b8bca86 Fix compilation errors on Linux 2016-03-10 17:06:22 +09:00
Cheng Zhao
044daee086 Update printing code to latest 2016-03-10 17:06:22 +09:00
Cheng Zhao
bfc6d77bb3 Pending renderer process no longer has render view attached 2016-03-10 17:06:22 +09:00
Cheng Zhao
6de9c4332f Fix passing Promise with remote
Somehow using value.then.bind(value) would result in infinite loop,
could be bug of Chromium.
2016-03-10 17:06:22 +09:00
Cheng Zhao
dd4d3db47b Fix node integration not working 2016-03-10 17:06:21 +09:00
Cheng Zhao
a31cbd24a1 Final pieces of int16 and .Pass() 2016-03-10 17:06:21 +09:00
Cheng Zhao
f29d633563 Fix cpplint warnings 2016-03-10 17:06:21 +09:00
Cheng Zhao
5fae63a2f5 Fix compilation errors on OS X 2016-03-10 17:06:21 +09:00
Paul Betts
4503aafe64 int32 => int32_t 2016-03-10 17:06:21 +09:00
Paul Betts
d2944c62a5 basictypes.h => macros.h 2016-03-10 17:06:21 +09:00
Paul Betts
7f15a77f3c startup helper is renamed 2016-03-10 17:06:21 +09:00
Paul Betts
8d021f2596 Goodbye pdf.dll 2016-03-10 17:06:21 +09:00
Cheng Zhao
3600645575 Fix the compilation errors from brightray and crashpad 2016-03-10 17:06:21 +09:00
Cheng Zhao
30643cf118 Update crashpad to lastest branch 2016-03-10 17:06:21 +09:00
Cheng Zhao
9bc9a1a2bd Upgrade to Chrome 49 2016-03-10 17:06:20 +09:00
Cheng Zhao
377a8eefb2 Merge pull request #4722 from atom/colocate-js
[WIP] Colocate JavaScript in root lib folder
2016-03-10 17:05:34 +09:00
Cheng Zhao
1ee4caae2d Merge pull request #4736 from preco21/patch-7
Docs: Adjust 80 chars per line
2016-03-10 16:55:10 +09:00
Plusb Preco
ebf509bbe4 📝 Adjust 80 chars per line
[ci skip]
2016-03-10 16:54:07 +09:00
Plusb Preco
4c45c80fb4 📝 Update as upstream 2016-03-10 16:36:50 +09:00
Cheng Zhao
b40a0e6e0c Merge pull request #4725 from phamdaniel/doc-app-focus
Document 'app.focus()'
2016-03-10 16:29:33 +09:00
heyunjiang
51f60d8d73 add window.open 2016-03-09 23:23:22 +08:00
Daniel Pham
0b8c2545b9 📝 Document 'app.focus()'
[ci skip]
2016-03-09 09:03:38 -05:00
Cheng Zhao
5efb88e7ea Merge pull request #4723 from yucheng-inc/master
translations   zh-CN    doc
2016-03-09 21:45:40 +09:00
heyunjiang
937668097a web-view-tag first finish 2016-03-09 17:00:01 +08:00
wujingke
da0a1eac24 Merge pull request #3 from heyunjiang/master
api doc 4th
2016-03-09 09:35:24 +08:00
Kevin Sawicki
c3b058cea3 Update path to ipc.js 2016-03-08 11:22:58 -08:00
Kevin Sawicki
2e9fd7ce77 Update common api path 2016-03-08 11:22:13 -08:00
Kevin Sawicki
4c9f5b71f7 Run eslint over lib folder 2016-03-08 11:14:22 -08:00
Kevin Sawicki
418efbe660 Remove unneeded resolve calls 2016-03-08 11:14:22 -08:00
Kevin Sawicki
006c77a00f Update requires paths 2016-03-08 11:14:22 -08:00
Kevin Sawicki
f109591d03 Look for JS in lib dir 2016-03-08 11:14:21 -08:00
Kevin Sawicki
c47ad29124 Move default_app to root of repo 2016-03-08 11:14:21 -08:00
Kevin Sawicki
6e3cb9e8eb Update paths for new JS location 2016-03-08 11:14:21 -08:00
Kevin Sawicki
70aa9b06ee Move JavaScript to root lib/ folder 2016-03-08 11:14:21 -08:00
heyunjiang
c8a2246952 complete command line switch && add enviroment variables 2016-03-08 20:40:54 +08:00
heyunjiang
d35996b4a0 position modify 2016-03-08 19:57:53 +08:00
Cheng Zhao
a9c40de393 Merge pull request #4680 from atom/resizable-linux
Respect initial resizable window option on Linux
2016-03-08 19:46:40 +09:00
Cheng Zhao
549cccfce4 Merge pull request #4715 from dongjoon-hyun/fix_typos_in_comments
Fix typos in comments.
2016-03-08 19:45:05 +09:00
Cheng Zhao
1da75f5c18 Merge pull request #4712 from atom/mq-map-selectors-to-roles
Map missing selectors to roles
2016-03-08 19:44:26 +09:00
Cheng Zhao
68c413c391 Merge pull request #4674 from atom/normalize-native-image-paths
Normalize native image paths
2016-03-08 18:59:56 +09:00
wujingke
83111ad84c Merge pull request #2 from heyunjiang/master
add api doc begin 2.5
2016-03-08 16:36:32 +08:00
heyunjiang
89328c873c add api doc begin 2.5 2016-03-08 16:30:09 +08:00
Dongjoon Hyun
0c92d44077 Fix typos in comments. 2016-03-07 20:22:03 -08:00
wujingke
6f221cb6b1 Merge pull request #1 from heyunjiang/master
menuItem add
2016-03-08 11:01:55 +08:00
heyunjiang
11f64b714d menuItem add 2016-03-08 10:47:23 +08:00
Kevin Sawicki
4c23e3950a Add missing semicolon 2016-03-07 16:45:15 -08:00
Kevin Sawicki
44376374b0 path -> paths 2016-03-07 16:45:14 -08:00
Kevin Sawicki
022c2c0d8c absolute_path -> normalize_path 2016-03-07 16:45:14 -08:00
Kevin Sawicki
0dba0b9cad MakePathAbsolute -> NormalizePath 2016-03-07 16:45:14 -08:00
Kevin Sawicki
97930fcd84 Add specs for more image path cases 2016-03-07 16:45:14 -08:00
Kevin Sawicki
9c88a5c1ab Check ReferencesParent before calling MakeAbsoluteFilePath 2016-03-07 16:45:14 -08:00
Kevin Sawicki
7692edf50e Assert image size as well 2016-03-07 16:45:14 -08:00
Kevin Sawicki
8215d661ca Add api- prefix to spec 2016-03-07 16:45:14 -08:00
Kevin Sawicki
8f820e09be Use template string and arrow functions 2016-03-07 16:45:14 -08:00
Kevin Sawicki
145d5abe80 Mention explicit using original path on failures 2016-03-07 16:45:14 -08:00
Kevin Sawicki
b90c0c7895 Use MakeAbsoluteFilePath when creating native image from path 2016-03-07 16:45:13 -08:00
Kevin Sawicki
dda7740399 Add failing spec for native image path normalization 2016-03-07 16:45:13 -08:00
Kevin Sawicki
3f4455a79d Merge pull request #4713 from atom/mq-doc-actions
Link to OS X Cocoa Event Handling guide on actions
2016-03-07 16:40:23 -08:00
Machisté N. Quintana
f47851f1e7 📝 🎨 Hard wrap 2016-03-07 16:19:00 -08:00
Machisté N. Quintana
eb064240f8 📝 Link to OS X Cocoa Event Handling guide on actions 2016-03-07 16:11:58 -08:00
Kevin Sawicki
7b881ebc23 Merge pull request #4711 from atom/realpath-asar-unpacked-specs
Add specs for realpath of unpacked asar path
2016-03-07 16:10:50 -08:00
Machisté N. Quintana
2bfc7aa152 Add mapping for performZoom 2016-03-07 16:01:46 -08:00
Machisté N. Quintana
eae5cc9d2c 🎨 [ci skip] 2016-03-07 15:53:09 -08:00
Machisté N. Quintana
03434f45bb Map webContents.delete to role 2016-03-07 15:50:33 -08:00
Machisté N. Quintana
4ded709307 Map selectors for delete and pasteAndMatchStyle to roles 2016-03-07 15:42:32 -08:00
Kevin Sawicki
4b6639c9fd Add missing done param 2016-03-07 15:30:33 -08:00
Kevin Sawicki
4b65610d40 Add specs for realpath of unpacked asar path 2016-03-07 15:27:21 -08:00
Kevin Sawicki
755c1f5238 Merge pull request #4706 from atom/update-styleguide
Remove CoffeeScript from styleguide
2016-03-07 13:59:07 -08:00
Kevin Sawicki
04c8bc38b2 Tweak lint sentence 2016-03-07 13:58:49 -08:00
Kevin Sawicki
ad3f4a26fd Restore setting resizable property from ctor on Windows 2016-03-07 13:53:57 -08:00
Kevin Sawicki
7de37859f0 Set resizable on Linux from InitWithOptions 2016-03-07 13:48:33 -08:00
Kevin Sawicki
993b878925 🎨 2016-03-07 10:37:01 -08:00
Kevin Sawicki
38acc7090b Contrain size in ctor on non-resizable windows 2016-03-07 10:11:30 -08:00
Kevin Sawicki
4ec79d5d18 Add Linux exclusion to describe 2016-03-07 09:53:20 -08:00
Kevin Sawicki
1c68aae43e Mention npm run lint 2016-03-07 09:46:05 -08:00
Kevin Sawicki
686af28f54 Mention indent and semicolons 2016-03-07 09:45:13 -08:00
Kevin Sawicki
6725523042 Remove CoffeeScript from styleguide 2016-03-07 09:43:04 -08:00
Cheng Zhao
aa8dbbf6b6 Merge pull request #4695 from dongjoon-hyun/fix_link_name
Fix link name.
2016-03-07 10:31:49 +09:00
Cheng Zhao
0e2ac2d802 Merge pull request #4646 from phamdaniel/dark-mode
Add API to check OSX's Dark theme
2016-03-07 09:53:03 +09:00
Daniel Pham
68b453770b 🍎 Rename 'isDarkModeEnabled' to 'isDarkMode' 2016-03-06 10:55:47 -05:00
Cheng Zhao
2a0be28111 Merge pull request #4682 from phamdaniel/ismaximized
Fix `isMaximized()` in window for when resizable is set to false on OSX
2016-03-06 19:23:46 +09:00
Dongjoon Hyun
f9f20957a4 Fix link name. 2016-03-05 23:28:39 -08:00
Cheng Zhao
d93ccd47a8 Merge pull request #4670 from atom/cmd-backtick-order
Use sendAction for cycling windows
2016-03-06 16:17:38 +09:00
Cheng Zhao
e152b8850c Merge pull request #4665 from christoth/christoth-webview-flexbox
Use flexbox layout for browserplugin
2016-03-06 15:36:20 +09:00
Cheng Zhao
5bb2c2c5c9 Merge pull request #4666 from SLiNv/zh-CN-documentation
Add Pepper Flash doc and match doc style
2016-03-06 15:36:05 +09:00
Cheng Zhao
816b10d8f3 Merge pull request #4694 from atom/common-accelerator
Remove duplicated keyboard code
2016-03-06 15:31:59 +09:00
Cheng Zhao
b7a40f3097 docs: Add missing key codes 2016-03-06 15:12:04 +09:00
Cheng Zhao
2515425cd5 Remove duplicated keyboard code 2016-03-06 15:04:05 +09:00
Cheng Zhao
a0c39c64cc Merge pull request #4686 from atom/fullscreen-logic
Improve fullscreen related logic code
2016-03-05 22:20:43 +09:00
Cheng Zhao
114801d412 Remove the duplicate logic on OS X 2016-03-05 21:54:41 +09:00
Cheng Zhao
2be368bded SetFullScreen should not work at all when not fullscreenable
This follows the logic of OS X.
2016-03-05 21:38:06 +09:00
Cheng Zhao
f5d79677fa Merge branch 'will-fullscreen' of https://github.com/MaxWhere/electron 2016-03-05 21:30:41 +09:00
Cheng Zhao
5f95fea3e2 docs: OS X also has progress bar 2016-03-05 21:20:02 +09:00
Cheng Zhao
c0b87c1a62 Merge pull request #4656 from princejwesley/menu-item-click
Add platform predicate for menu item action
2016-03-05 21:13:59 +09:00
Cheng Zhao
054c55a9bb Merge pull request #4683 from atom/fix-select-certificate
Fix passing certificate to select-client-certificate's callback
2016-03-05 19:47:27 +09:00
Cheng Zhao
23b92ef9ec Fix passing certificate to select-client-certificate's callback 2016-03-05 18:57:46 +09:00
Daniel Pham
d5f5cdb45a :apple:Fix 'isMaximized()' for non resizable windows 2016-03-05 01:39:48 -05:00
Cheng Zhao
33978455b8 Bump v0.36.10 2016-03-05 12:00:06 +09:00
Cheng Zhao
2bd167663d Merge pull request #4678 from atom/writable-member-functions
Make remote member functions writable/configurable
2016-03-05 11:56:56 +09:00
Kevin Sawicki
bda5bb4a74 Add missing semicolon 2016-03-04 16:15:04 -08:00
Kevin Sawicki
67edcc8f91 Initially set resizable property on Linux 2016-03-04 16:12:58 -08:00
Kevin Sawicki
73f6162f5c Enable resizable spec on Linux 2016-03-04 16:12:14 -08:00
Kevin Sawicki
fe9e026f9e getObjectMemebers -> getObjectMembers 2016-03-04 15:57:21 -08:00
Kevin Sawicki
3230927f10 Mention deleting 2016-03-04 15:56:18 -08:00
Kevin Sawicki
f460d81dd0 Allow remote member functions to be deleted 2016-03-04 15:51:17 -08:00
Kevin Sawicki
610a503188 Make member functions writable 2016-03-04 15:49:46 -08:00
Kevin Sawicki
a9e22801e9 Add failing spec for reassigning remote function 2016-03-04 15:44:50 -08:00
Kevin Sawicki
ee1f69062e Merge pull request #4675 from atom/report-error-in-enumerate-devices-spec
Always call done callback in enumerateDevices spec
2016-03-04 14:42:21 -08:00
Kevin Sawicki
20e9a87158 Don't run mediaDevices spec on Linux CI 2016-03-04 13:23:12 -08:00
Kevin Sawicki
a4e04e6083 Always call done callback 2016-03-04 12:29:50 -08:00
Daniel Pham
63294892f0 Rename dark-mode-changed to platform-theme-changed 2016-03-03 23:58:58 -05:00
Kevin Sawicki
be67dca686 Use _cycleWindows selector to implement cmd-` 2016-03-03 20:53:58 -08:00
Daniel Pham
b1eefbdcd9 Simplify the isDarkModeEnabled check 2016-03-03 23:48:30 -05:00
christoth
fed77d1837 Use flexbox layout for browserplugin 2016-03-03 17:22:20 -05:00
Victor Zhu
b46fc8bc4c Add Pepper Flash doc and match doc style
- Add Pepper Flash plugin documentation
- Use and  match the same documentaion style for other CN docs.
- Fix some typos and grammar.
2016-03-03 15:42:14 -05:00
Cheng Zhao
b4c48664f8 Merge pull request #4635 from akameco/master
Fix JP docs tranlation
2016-03-03 21:00:46 +09:00
Plusb Preco
b6958e5221 Update as upstream
[ci skip]
2016-03-03 20:56:46 +09:00
Prince J Wesley
f02affbc18 🐛 Add platform predicate for menu item action 2016-03-03 08:38:32 +05:30
Cheng Zhao
46c6233b62 Merge pull request #4630 from preco21/patch-6
Docs: Cleanup docs
2016-03-03 11:37:48 +09:00
Cheng Zhao
d6144d63fb Merge pull request #4629 from RacioN/master
Update docs-translations/jp/README.md tranlation.
2016-03-03 11:32:40 +09:00
Daniel Pham
c4049cb393 🍎 Add 'dark-mode-changed' event to app api 2016-03-01 15:43:38 -05:00
Daniel Pham
eaac67ac60 🍎 Add 'isDarkModeEnabled' to app api 2016-03-01 13:12:21 -05:00
akameco
9c7bb0b370 Fix JP docs tranlation 2016-03-01 01:41:46 +09:00
Plusb Preco
24ae9b0ea9 Cleanup docs
* Adjust 80 chars per line
* Line feed after header
2016-02-29 01:38:32 +09:00
RacioN
2d11b1d9eb Update read me tranlation 2016-02-28 20:55:47 +09:00
RacioN
e3dde12c45 Update read me tranlation 2016-02-28 20:50:16 +09:00
RacioN
681a772f5f Add list 2016-02-28 20:42:14 +09:00
Cheng Zhao
5839d7dcd5 Merge pull request #4623 from parro-it/patch-1
Removed duplicate `isDevToolsFocused` entry
2016-02-28 10:41:27 +08:00
brenca
a06392459e Making fullsceenable work on Linux 2016-02-27 22:37:42 +01:00
Andrea Parodi
fd11b7e7db Removed duplicate isDevToolsFocused entry 2016-02-27 20:34:51 +01:00
Heilig Benedek
bb42c85df8 resolve update conflicts 2016-02-27 03:23:10 +01:00
Heilig Benedek
bb0ac688b2 Reverted SetFullscreenable disabling maximize button on Windows and removed that from the docs. 2016-02-27 03:07:53 +01:00
Cheng Zhao
7de97a55f7 Merge pull request #4609 from MaxWhere/framesubscriber-fix
🐎 framesubscriber speed and quality improvement
2016-02-26 23:21:42 +08:00
Cheng Zhao
b25c8ca621 Merge pull request #4616 from deepak1556/media_device_enumeration_patch
browser: allow enumeration of media device labels
2016-02-26 22:07:35 +08:00
Cheng Zhao
db46e9c203 Merge pull request #4596 from felixrieseberg/ci-docs
Add Headless CI Tutorial
2016-02-26 21:32:03 +08:00
Cheng Zhao
ebfc127628 Merge pull request #4522 from deepak1556/async_execute_javascript_patch
webContents: provide responses for executeJavscript method
2016-02-26 21:17:47 +08:00
gellert
070772b4b9 Added special key identifiers for OSX and Windows 2016-02-26 20:22:46 +08:00
Cheng Zhao
d9ad51e989 Merge pull request #4607 from rglyall/master
Fix Menu template API example
2016-02-26 20:13:40 +08:00
Robo
fce641aab6 browser: allow enumeration of media device labels 2016-02-26 16:31:20 +05:30
Cheng Zhao
a21e095a59 Merge pull request #4515 from deepak1556/ipc_value_conversion_patch
ipc: allow passing date instances
2016-02-26 16:16:33 +08:00
Cheng Zhao
a67b29d8d2 Bump v0.36.9 2016-02-26 02:18:27 +00:00
Cheng Zhao
795ac86266 Merge pull request #4608 from atom/harfbuzz
Use harfbuzz 1.06
2016-02-26 09:51:13 +08:00
Cheng Zhao
8a744255fa Update libchromiumcontent, use harfbuzz 1.06
Close #4513.
2016-02-26 09:23:39 +08:00
Felix Rieseberg
a3b8e81c21 📝 Add Headless CI Tutorial 2016-02-25 17:14:43 -08:00
Heilig Benedek
4bfa03e5f4 Removed an include no longer needed 2016-02-26 02:13:17 +01:00
Heilig Benedek
3f0d598a59 Merge atom/master 2016-02-26 02:05:57 +01:00
Robo
1235907835 run webframe methods for webview in its context 2016-02-26 05:14:45 +05:30
Heilig Benedek
1282d6eedb Merge pull request #6 from atom/master
update as upstream
2016-02-25 23:50:13 +01:00
Heilig Benedek
9a0372b61b Removed size_ since it's not needed anymore 2016-02-25 23:48:58 +01:00
Robert Lyall
6f45678e9c Fix Menu template API example 2016-02-25 18:28:03 +00:00
Cheng Zhao
0ea80f674b Merge pull request #4595 from dongjoon-hyun/rename_function_filter_accelerator
Rename function `FilterAccecelator` to `FilterAccelerator` in `submenu.cc`
2016-02-25 21:18:57 +08:00
Cheng Zhao
316e6850ae Merge pull request #4592 from miniak/fix-url-request-converter-crash
Fix crash in mate::Converter<const net::URLRequest*>::ToV8
2016-02-25 21:11:43 +08:00
Robo
8386baf267 add spec 2016-02-25 11:46:30 +05:30
Robo
a734326907 track async api requests 2016-02-25 11:45:59 +05:30
Robo
2b547bd44a webContents: provide responses for executeJavscript method 2016-02-25 11:45:59 +05:30
Robo
a1a17b7ee8 use v8::Object::Get 2016-02-25 11:21:21 +05:30
Cheng Zhao
d00490271b Merge pull request #4518 from deepak1556/webview_host_window_patch
webview: api to get host browser window
2016-02-25 12:26:53 +08:00
Dongjoon Hyun
fee56df400 Rename function FilterAccecelator to FilterAccelerator in submenu_button.cc. 2016-02-24 11:15:21 -08:00
Milan Burda
d2b48b2aa7 Fix crash in mate::Converter<const net::URLRequest*>::ToV8
The net::URLRequest::url() method calls vector<GURL>::back(), which is undefined when the url_chain is empty
2016-02-24 14:01:26 +01:00
Robo
467870deb6 use builtin method 2016-02-24 16:30:23 +05:30
Robo
6fcc197db8 webview: api to get webcontents and associated host webcontents 2016-02-24 11:55:15 +05:30
Cheng Zhao
f3c7965cea Merge pull request #4588 from atom/fix-protocol-crash
Revert  #4551
2016-02-24 13:48:33 +08:00
Cheng Zhao
8ff30a2abc Revert "protocol: respect requests from partition"
This reverts commit 85800256de.
2016-02-24 13:25:30 +08:00
Cheng Zhao
bb1e4c2208 Revert "add docs"
This reverts commit bdfc19ad20.
2016-02-24 13:25:22 +08:00
Cheng Zhao
820c72af55 Merge pull request #4560 from magicae/magica-translate-docs-to-zh_CN
docs: update zh-CN docs translation [WIP]
2016-02-24 13:06:17 +08:00
Cheng Zhao
a63193c826 Merge pull request #4551 from deepak1556/protocol_session_patch
protocol: respect requests from partition
2016-02-24 12:03:37 +08:00
Cheng Zhao
3a3a95b0a9 Merge pull request #4581 from atom/linux-menu-fix
Notify the global menu bar when window is mapped
2016-02-23 20:41:50 +08:00
Robo
367d12402a ipc: allow passing date instances 2016-02-23 16:23:15 +05:30
Cheng Zhao
49f995925c Notify the global menu bar when window is mapped 2016-02-23 15:43:32 +08:00
Robo
bdfc19ad20 add docs 2016-02-23 12:54:20 +05:30
Cheng Zhao
1b3b35926a Merge pull request #4580 from kanatapple/master
docs: update jp doc ipc-renderer.md
2016-02-23 15:11:07 +08:00
Yasunari Fujieda
23268531ae docs: update jp doc ipc-renderer.md 2016-02-23 15:10:38 +09:00
Cheng Zhao
f47ae3c02f Merge pull request #4579 from jin5354/master
docs: update zh-CN doc debugging-main-process.md
2016-02-23 14:08:46 +08:00
Cheng Zhao
9c6ab6f1e0 Merge pull request #4566 from yamatoya/master
Update as upstream
2016-02-23 13:39:34 +08:00
jin5354
331bc42d57 docs: update zh-CN doc debugging-main-process.md
update zh-CN doc debugging-main-process.md to be up-to-date with
English ver.
2016-02-23 10:00:28 +08:00
Heilig Benedek
39bb670719 Revert will-enter-full-screen event, matching osx fullscreen: false behaviour on windows instead 2016-02-22 10:23:56 +01:00
Cheng Zhao
537ead8917 Merge pull request #4570 from atom/cleanup-remote
Cleanup code of remote module
2016-02-22 16:10:55 +08:00
Cheng Zhao
96b2705bd3 Fix render-view-deleted being emitted twice 2016-02-22 15:24:19 +08:00
Cheng Zhao
6753fcc1b4 Get rid of the ATOM_BROWSER_RELEASE_RENDER_VIEW event 2016-02-22 15:24:19 +08:00
Cheng Zhao
593a79ce20 Separate renderer functions by renderer process ID
Close #4324.
2016-02-22 15:24:18 +08:00
Cheng Zhao
d4c954870a Remove a few CoffeeScript generated junks 2016-02-22 15:24:18 +08:00
Cheng Zhao
59d6e7d6ef ObjectsRegistry no longer needs to send events 2016-02-22 15:24:18 +08:00
Cheng Zhao
2b04af4349 No longer need to count the references in webContents
All remote objects are now cached in renderer process, so there is
always only one reference to one remote object for each webContents.
2016-02-22 15:24:18 +08:00
Cheng Zhao
fe7462b352 No longer needs cache for methods of remote
Refs #4517.
2016-02-22 13:05:58 +08:00
Cheng Zhao
c65cfadd09 v8Util.createObjectWithName is no longer used 2016-02-22 13:05:58 +08:00
Cheng Zhao
34658473c9 Merge pull request #4568 from atom/remote-proto
Keep prototype chain in remote objects
2016-02-22 13:04:34 +08:00
Cheng Zhao
f610e332b3 spec: Tests for remote ES6 class 2016-02-22 12:35:51 +08:00
Cheng Zhao
67324ce732 Keep the prototype chain in remote objects 2016-02-22 12:35:51 +08:00
Takahito Yamatoya
9e1da8f097 Update as upstream 2016-02-22 00:59:18 +09:00
Cheng Zhao
361b9cad0f Merge pull request #4564 from dongjoon-hyun/rename_const_persist_prefix
Rename constant `PERSIST_PERFIX` to `PERSIST_PREFIX` in `session.js`.
2016-02-21 21:53:41 +08:00
Plusb Preco
f63532fa95 📝 Update as upstream
[ci skip]
2016-02-21 21:15:36 +08:00
Cheng Zhao
4a47deafc2 Merge pull request #4558 from cesine/update/deps
a new version of asar is out 0.10.0
2016-02-21 19:04:06 +08:00
Cheng Zhao
cad26fa606 Merge pull request #4517 from deepak1556/remote_browser_window_patch
remote: return webcontents instance from cache
2016-02-21 17:54:48 +08:00
Dongjoon Hyun
078c7bf8ab Rename constant PERSIST_PERFIX to PERSIST_PREFIX in session.js. 2016-02-21 00:16:53 -08:00
Magica
a05e98f463 Translate auto-updater.md in commit 45739ce434 2016-02-21 14:09:34 +08:00
Magica
f64dc5f57d Translate app.md in commit 45739ce434 2016-02-21 13:49:51 +08:00
Magica
1db72f8010 Translate accelerator.md of 45739ce434 2016-02-20 18:51:04 +08:00
Magica
060d06d396 Translate electron-faq.md#45739ce434ec3c3eb190d35d3948b702b54706cd 2016-02-20 17:00:58 +08:00
Magica
a737e15ddb Update README.md to 45739ce434 2016-02-20 16:09:56 +08:00
cesine
e45e246027 a new version of asar is out 0.10.0 2016-02-19 23:24:56 -05:00
Kevin Sawicki
45739ce434 Merge pull request #4547 from Rafaelgfirmino/master
Translated
2016-02-19 11:22:15 -08:00
Kevin Sawicki
777ff450cf Merge pull request #4543 from baconface/patch-2
Changed session to app to reflect rest of document
2016-02-19 11:21:10 -08:00
Robo
85800256de protocol: respect requests from partition 2016-02-19 19:39:01 +05:30
Cheng Zhao
4b18317e7c Bump v0.36.8 2016-02-19 14:38:36 +08:00
Cheng Zhao
54a7eefa28 Merge pull request #4548 from atom/free-ffmpeg
Provide ffmpeg binaries without proprietary codecs
2016-02-19 14:37:09 +08:00
Lee Dohm
bd2c13527d Merge pull request #4528 from atom/wl-templates
Add issue template
2016-02-18 20:49:42 -08:00
Cheng Zhao
daffb4881e Create and upload free version of ffmpeg 2016-02-19 12:06:48 +08:00
Cheng Zhao
cd30308711 Update libchromiumcontent with free version of ffmpeg 2016-02-19 12:06:48 +08:00
Rafael G Firmino
632c18ab37 Translated 2016-02-18 22:51:23 -02:00
Brad Metcalf
2a6fcf48e5 Changed session to app to reflect rest of document 2016-02-18 13:41:22 -06:00
Kevin Sawicki
d5f4a32435 Merge pull request #4524 from atom/update-default-app-styles
Match default app styles to website styles
2016-02-18 10:47:45 -08:00
Kevin Sawicki
d3c6075841 Use background color as border color 2016-02-18 10:15:44 -08:00
Kevin Sawicki
1c37731065 under -> in 2016-02-18 10:15:44 -08:00
Kevin Sawicki
9b373f2e15 on -> to learn 2016-02-18 10:15:44 -08:00
Kevin Sawicki
4d011057b0 Only change background on hover 2016-02-18 10:15:44 -08:00
Kevin Sawicki
de37de1785 Add docs sentence in new paragraph 2016-02-18 10:15:43 -08:00
Kevin Sawicki
1520b2271a Remove v before version 2016-02-18 10:15:43 -08:00
Kevin Sawicki
793527f82e Update header style 2016-02-18 10:15:43 -08:00
Kevin Sawicki
db1c29f2f9 Remove parens around version 2016-02-18 10:15:43 -08:00
Kevin Sawicki
d48a61fdff Tweak holder styles 2016-02-18 10:15:43 -08:00
Kevin Sawicki
c4859c3dc6 Use colors from Electron site 2016-02-18 10:15:43 -08:00
Lee Dohm
cc6ba0fd10 Remove all but prompts for version numbers 2016-02-18 08:57:31 -08:00
Plusb Preco
8ce3ab1e26 📝 Update as upstream
[ci skip]
2016-02-18 23:35:29 +08:00
Cheng Zhao
68f48c9456 docs: Add note on Chrome version when using widevine
Refs #4519.
2016-02-18 23:28:19 +08:00
Cheng Zhao
aa03a9d0ef Merge pull request #4534 from apoco/menu-documentation
Link to Menu documentation
2016-02-18 20:14:08 +08:00
Robo
0d77fd4a2c remote: return webcontents instance from cache 2016-02-18 17:40:10 +05:30
Cheng Zhao
35815387ab Ship ffmpeg in dist, close #4536 2016-02-18 18:57:31 +08:00
Cheng Zhao
a8cd435e30 Merge pull request #4538 from atom/cmd-tilde
mac: Simulate the behavior of cmd+~ when OS X didn't handle it
2016-02-18 18:57:04 +08:00
Cheng Zhao
0446f07884 Merge pull request #4508 from atom/open-external-without-activation
Allow shell.openExternal to open URLs in the background
2016-02-18 18:40:22 +08:00
Cheng Zhao
12569f2c9d mac: Simulate the behavior of cmd+~ when OS X didn't handle it 2016-02-18 18:32:13 +08:00
Jacob Page
9c9759a683 Link to Menu documentation
Added link to documentation about `Menu` objects
2016-02-17 21:30:01 -08:00
Cheng Zhao
25156dbd53 Merge pull request #4532 from atom/no-drop-capacities
Update libchromiumcontent, fix #3666
2016-02-18 13:01:18 +08:00
Cheng Zhao
1e894df102 Update libchromiumcontent, fix #3666 2016-02-18 12:14:25 +08:00
Cheng Zhao
b13a2fe260 Merge pull request #4531 from atom/fix-win32-specs
spec: Fix failing tests on Windows
2016-02-18 12:12:32 +08:00
Cheng Zhao
651264d098 spec: Fix failing tests on Windows 2016-02-18 11:39:35 +08:00
Cheng Zhao
5f42429af1 Merge pull request #4523 from atom/spec-clean-up
Clean up specs post CoffeeScript conversion
2016-02-18 11:15:37 +08:00
Cheng Zhao
233961ea29 Merge pull request #4530 from atom/shared-ffmpeg
Link with ffmpeg dynamically
2016-02-18 11:13:57 +08:00
Wliu
1f248e6ea6 📝 Move Electron and OS versions above the description
[ci skip]
2016-02-17 21:41:14 -05:00
Wliu
f81f4479b6 Drastically simplify the template
[ci skip]
2016-02-17 21:29:36 -05:00
Heilig Benedek
2610aa60e9 🎨 lint fix 2016-02-18 01:19:41 +01:00
Heilig Benedek
7bf17f2541 Improved frame subscriber - now we only use framesubscription events as an event, and we copy from the backing store directly (instead of accessing it through a videoframe) 2016-02-18 01:15:00 +01:00
Wliu
a252b9b570 Initial ISSUE_TEMPLATE draft 2016-02-17 16:31:26 -05:00
Kevin Sawicki
31028ab636 Update var declarations 2016-02-17 09:27:25 -08:00
Kevin Sawicki
54d7c580bd Remove unneeded returns 2016-02-17 09:08:34 -08:00
Kevin Sawicki
8a9395101e Remove unused results 2016-02-17 09:08:34 -08:00
Kevin Sawicki
12adaa0570 Remove unneeded returns 2016-02-17 09:08:34 -08:00
Kevin Sawicki
e63c3c727a Add newlines between describe/it blocks 2016-02-17 09:08:34 -08:00
Kevin Sawicki
709661156a Use const for requires 2016-02-17 09:08:34 -08:00
Kevin Sawicki
b3ac48cf52 Handle argument parsing in C++ 2016-02-17 09:05:21 -08:00
Kevin Sawicki
3f42909ecf Call OpenExternal with new true default to activate arg 2016-02-17 08:56:59 -08:00
Kevin Sawicki
04517caf36 Add missing semicolon 2016-02-17 08:56:59 -08:00
Kevin Sawicki
5e5313d8b1 Return value from bindings method 2016-02-17 08:56:59 -08:00
Kevin Sawicki
42041cd402 Use markdown list for new options param 2016-02-17 08:56:59 -08:00
Kevin Sawicki
f5bed87199 without_activation -> activate 2016-02-17 08:56:58 -08:00
Ben Gotow
52db43eee5 Fix linter error 2016-02-17 08:56:58 -08:00
Ben Gotow
d8679b3899 Allow openExternal to open URLs in the background #3224 2016-02-17 08:56:58 -08:00
Cheng Zhao
3d3fc18a3a Update libchromiumcontent to use shared ffmpeg 2016-02-17 23:23:36 +08:00
Cheng Zhao
7fece7e9b3 Link with ffmpeg 2016-02-17 22:21:14 +08:00
Cheng Zhao
57f322a818 Merge pull request #4509 from caibirdme/feature-translate-into-Chinese
tanslate file-object.md
2016-02-17 19:38:57 +08:00
deenjun
28635e5f2c remove original English text 2016-02-17 14:54:57 +08:00
Cheng Zhao
723acfa1a1 Merge pull request #4510 from atom/skip-eslint
Skip eslint on our Windows build machine for now
2016-02-17 12:07:51 +08:00
Cheng Zhao
01ede11cb8 Skip eslint on our Windows build machine for now 2016-02-17 10:54:44 +08:00
Cheng Zhao
c02a49a1db Merge pull request #4507 from atom/mb-add-deprecation-handler-api
Add API for custom handling of deprecations
2016-02-17 10:51:30 +08:00
deenjun
baf44c7a41 tanslate file-object.md 2016-02-17 10:42:59 +08:00
Cheng Zhao
7810f4293f Merge pull request #4447 from KevinMartin/patch-3
Add ability to specify v8 flags in package.json
2016-02-17 10:42:29 +08:00
Kevin Jose Martin
ee0cac7d54 Remove command line switches, add v8 flags 2016-02-16 21:23:13 -05:00
Plusb Preco
407bef5727 📝 Update as upstream
[ci skip]
2016-02-17 09:37:09 +08:00
Max Brunsfeld
3e3e593366 👕 Add missing semicolons 2016-02-16 15:28:33 -08:00
Max Brunsfeld
ccef805e9b Add API for custom handling of deprecations 2016-02-16 15:21:32 -08:00
Kevin Sawicki
175449f096 Merge pull request #4503 from x87/master
fixed typo in the russian translation of README.md
2016-02-16 12:52:37 -08:00
Seemann
2346caf6fb fixed typo in the russian translation of README.md 2016-02-16 23:19:20 +03:00
Kevin Sawicki
73518cdc8d Merge pull request #4501 from dmnlk/feature/add_community_jp
add Japanese Elecron Community
2016-02-16 10:45:30 -08:00
dmnlk
959c08a1ec add Japanese Electron Community 2016-02-17 02:28:10 +09:00
Cheng Zhao
0ba86b9716 docs: Make variable names follow previous example 2016-02-16 23:10:05 +08:00
Cheng Zhao
18e7825ff3 Merge pull request #4498 from destan/patch-2
add a new platform definition for linux
2016-02-16 23:08:34 +08:00
Destan Sarpkaya
afacca252e add a new platform definition for linux
On Linux in order for changes made to individual `MenuItem`s to take effect, you have to call `setContextMenu` again

Regarding https://github.com/atom/electron/issues/1473
2016-02-16 16:24:05 +02:00
Cheng Zhao
61a9316f67 Merge pull request #4496 from cesine/update/deps
fix dependencies badge  which shows out of date
2016-02-16 22:18:51 +08:00
Cheng Zhao
e47a815c38 Merge pull request #4482 from lukeapage/patch-7
spelling fixes and americanisms
2016-02-16 20:22:31 +08:00
Cheng Zhao
25ac6f0f37 Merge pull request #4480 from apoco/single-instance-clarification
makeSingleInstance clarification
2016-02-16 20:17:18 +08:00
Cheng Zhao
5b4f29e7ed Merge pull request #4471 from rsezille/master
Docs: Start french translation
2016-02-16 16:22:55 +08:00
Cheng Zhao
aaca93046c spec: Give beginFrameSubscription test more time to run 2016-02-16 16:20:15 +08:00
Cheng Zhao
bce11c8913 Merge commit 'd76f6fe' 2016-02-16 16:15:59 +08:00
Cheng Zhao
44260634af Merge pull request #4364 from atom/launch-url-or-file-directly-from-cli
Launch URL or HTML file directly
2016-02-16 16:13:10 +08:00
Cheng Zhao
7ca09de386 Merge remote-tracking branch 'origin/dont-write-empty-dev-tools-extensions-file' 2016-02-16 12:30:42 +08:00
Cheng Zhao
55642d257d Merge pull request #4494 from pra85/patch-3
docs: fix a minor typo
2016-02-16 12:28:08 +08:00
Plusb Preco
81ffde3c2a 📝 Update as upstream
[ci skip]
2016-02-16 12:20:21 +08:00
Cheng Zhao
95d8716ffa Merge pull request #4497 from atom/docs-revise
Improve the IPC related docs
2016-02-16 12:20:00 +08:00
Cheng Zhao
fded8d80b1 docs: Remove unnecessary "properties: " suffix 2016-02-16 12:11:05 +08:00
Cheng Zhao
2b406ccaf7 Optional => optional 2016-02-16 11:54:41 +08:00
Cheng Zhao
f58bab70c5 docs: Improve the docs on sharing data 2016-02-16 11:52:47 +08:00
Cheng Zhao
b8e8e4c930 docs: Cleanup the IPC docs 2016-02-16 11:34:39 +08:00
cesine
2aff0c47d0 ⬆️ 👕 updated to eslint 2.1.0
Verified migration doc (nothing to be done)
http://eslint.org/docs/user-guide/migrating-to-2.0.0

And made sure the eslint tasks passed
2016-02-15 22:30:29 -05:00
Cheng Zhao
63578f9d2b Merge pull request #4392 from madarche/doc-howto-share-objects
Document different techniques to share objects
2016-02-16 11:18:20 +08:00
Cheng Zhao
40a0a6aa8e Merge pull request #4495 from atom/frame-subscriber
Use weak pointer instead of manual bookkeeping
2016-02-16 11:13:11 +08:00
Cheng Zhao
d035fc2816 Merge pull request #4453 from lukeapage/patch-6
Docs - clarify ipc arguments
2016-02-16 11:08:35 +08:00
Cheng Zhao
3c4043fd39 spec: Skip autoUpdater tests in MAS build 2016-02-16 11:00:36 +08:00
Cheng Zhao
66bb6a8534 Use weak pointer instead of manual bookkeeping 2016-02-16 10:44:10 +08:00
Cheng Zhao
ed1966ac76 spec: Bring back beginFrameSubscription test 2016-02-16 10:30:18 +08:00
Prayag Verma
367a3524b9 docs: fix a minor typo
Remove extra `will`
2016-02-16 07:51:14 +05:30
Cheng Zhao
1232a285e6 Merge pull request #4451 from MaxWhere/framesubscriber-fix
Fixing FrameSubscriber memory issue
2016-02-16 10:20:44 +08:00
Cheng Zhao
f3f6fa958e Merge pull request #4449 from deepak1556/permission_helper_media_patch
browser: handle desktop capture devices in media permission request
2016-02-15 23:12:57 +08:00
Cheng Zhao
08e5c1f6fe Merge branch 'webcontent_invalid_loadurl_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webcontent_invalid_loadurl_patch 2016-02-15 21:14:54 +08:00
Cheng Zhao
e244d0db0c Merge pull request #4421 from atom/dialog-icon-on-mac
Support configurable dialog icon on Mac
2016-02-15 16:48:43 +07:00
Cheng Zhao
7c7e6ffc77 Fix broken links in desktop-environment-integration.md
Close #4404.
2016-02-15 16:36:01 +08:00
Cheng Zhao
18f31d7db9 Merge pull request #4398 from LartSimZ/master
Fix for issue #4369
2016-02-15 15:30:06 +07:00
Luke Page
a141d6b3d4 spelling fixes and americanisms 2016-02-15 06:51:20 +01:00
Luke Page
2c6e5d0464 Clarify arguments sent via ipc 2016-02-15 06:29:52 +01:00
Jacob Page
17603d5dfb makeSingleInstance clarification
Removed callback return value from the sample code for makeSingleInstance because it appears to not be used for anything.
2016-02-14 19:13:11 -08:00
Cheng Zhao
09b658b50a Merge pull request #4361 from ShiningRay/patch-2
translate remote.md into Chinese
2016-02-15 09:13:02 +07:00
Plusb Preco
f63d8b4d5e 📝 Update as upstream
[ci skip]
2016-02-15 10:05:29 +08:00
Remi Sezille
ef290ffcf2 Add styleguide in french
[ci skip]
2016-02-13 19:28:12 +01:00
Remi Sezille
efd25efaf4 Add FAQ
[ci skip]
2016-02-13 18:20:34 +01:00
Remi Sezille
a69341f551 Fix line length wrap
[ci skip]
2016-02-13 18:19:49 +01:00
Remi Sezille
940c325e7f Add french docs link on main README
[ci skip]
2016-02-13 11:32:47 +01:00
Remi Sezille
adf89a1e0e Translate README in french
[ci skip]
2016-02-13 11:29:08 +01:00
Yuya Ochiai
d76f6fe8e0 :memo:🏁 Add icon overlays in taskbar to docs
[ci skip]
2016-02-13 17:34:12 +09:00
Kevin Sawicki
440eccb7ee Merge pull request #4455 from preco21/patch-5
Remove unnecessary line feeds
2016-02-12 09:38:27 -08:00
Plusb Preco
e71eeda73c Remove unnecessary line feeds
[ci skip]
2016-02-12 22:38:08 +09:00
Marc-Aurèle DARCHE
2677dc6844 Fix: add missing fragment in FAQ section URL 2016-02-12 13:50:15 +01:00
Heilig Benedek
f36e2841bf Don't fire callbacks after we end the subscription 2016-02-12 13:30:11 +01:00
Heilig Benedek
91c96559fa Fixing the problem related to FrameSubscriber 2016-02-12 02:18:13 +01:00
Kevin Sawicki
03dd94d2b2 Merge pull request #4450 from HR/patch-1
Fix electron binary relative path
2016-02-11 17:00:05 -08:00
Heilig Benedek
a2b0e30714 Merge pull request #5 from atom/master
update as upstream
2016-02-12 01:57:08 +01:00
Habib Rehman
3adcaa7681 Fix electron binary relative path
The relative path for Electron's binary is Contents/MacOS/Electron
2016-02-12 00:11:02 +00:00
Robo
c09ff40916 browser: handle desktop capture devices in media permission request 2016-02-12 05:07:06 +05:30
Kevin Sawicki
9d6344704e Merge pull request #4382 from atom/throw-explicit-error-when-webview-api-is-unavailable
Throw explicit error when WebView API isn't ready
2016-02-11 13:34:01 -08:00
Kevin Sawicki
042825e8fb emmitted -> emitted 2016-02-11 13:32:34 -08:00
Kevin Sawicki
9609b36b3c Add missing semicolon 2016-02-11 13:28:33 -08:00
Kevin Sawicki
da6ebac742 Use assert.throws 2016-02-11 13:28:33 -08:00
Kevin Sawicki
bad4816976 Expand error message 2016-02-11 13:28:33 -08:00
Kevin Sawicki
674af4211c Use interpolated string 2016-02-11 13:28:33 -08:00
Kevin Sawicki
42a8674cea Add missing semicolon 2016-02-11 13:28:33 -08:00
Kevin Sawicki
8cacd0b931 Throw custom error when WebView API is unavailable 2016-02-11 13:28:33 -08:00
Kevin Sawicki
6bc48ba123 Add failing spec for custom error message 2016-02-11 13:28:33 -08:00
Kevin Sawicki
a4d21cadfa Format webview spec post CoffeeScript conversion 2016-02-11 13:28:33 -08:00
Kevin Sawicki
174a492cdb Merge pull request #4430 from atom/dont-crash-when-missing-ipc-channel
Don't crash when IPC channel is missing
2016-02-11 13:28:08 -08:00
Kevin Sawicki
704bd4d191 Improve error message 2016-02-11 13:25:58 -08:00
Kevin Sawicki
3e399d09d7 Match existing function style 2016-02-11 13:25:58 -08:00
Kevin Sawicki
c94f1fc857 Throw error when IPC channel is missing 2016-02-11 13:25:58 -08:00
Kevin Sawicki
cead84d5d1 Add failing spec 2016-02-11 13:25:57 -08:00
Kevin Sawicki
4828835998 Clean up returns after CoffeeScript migration 2016-02-11 13:25:57 -08:00
Kevin Sawicki
55d4db1387 🎨 2016-02-11 13:25:57 -08:00
Kevin Jose Martin
dbb4e21684 Fix index increment 2016-02-11 15:41:36 -05:00
Kevin Jose Martin
6d2ad5ae58 Add ability to specify command line switches in package.json 2016-02-11 15:34:19 -05:00
Robo
5a8bebc2f8 browser: emit did-fail-load for invalid url 2016-02-12 01:52:42 +05:30
Kevin Sawicki
fd30ed0edd Merge pull request #4439 from atom/add-more-npm-scripts
Add more npm scripts
2016-02-11 11:29:46 -08:00
Kevin Sawicki
a8e6e24e58 Sort scripts keys 2016-02-11 11:28:20 -08:00
Kevin Sawicki
03482a4427 Add build script 2016-02-11 11:28:20 -08:00
Kevin Sawicki
16594d6ed0 Add bootstrap script 2016-02-11 11:28:20 -08:00
Kevin Sawicki
38e8208639 Merge pull request #4350 from atom/dont-use-es6-class-for-auto-updater
Don't use ES6 class for auto updater
2016-02-11 11:27:10 -08:00
Heilig Benedek
f8fd5dc2a3 Merge pull request #4 from atom/master
update as upstream
2016-02-11 02:36:10 +01:00
Kevin Sawicki
3ab14e14e9 Add initial auto updater specs 2016-02-09 14:54:18 -08:00
Kevin Sawicki
7da4c3acf7 Use const for util require 2016-02-09 14:54:18 -08:00
Kevin Sawicki
6617592224 Remove lint errors 2016-02-09 14:54:18 -08:00
Kevin Sawicki
c842ca1f12 Don't use ES6 class for AutoUpdater windows class 2016-02-09 14:54:17 -08:00
Kevin Sawicki
3af20729bd Merge pull request #4363 from Vj3k0/master
Adding support to write RTF to clipboard.
2016-02-09 13:23:47 -08:00
Heilig Benedek
157a290e38 📝 Adding documentation for will-enter-full-screen event 2016-02-09 02:41:19 +01:00
gellert
664f95a7b4 fixes osx request call 2016-02-09 01:39:27 +01:00
Heilig Benedek
a8ae14e94f Introducing a will-enter-full-screen event that's cancellable 2016-02-09 01:17:05 +01:00
Heilig Benedek
d5bdb17144 Merge pull request #3 from atom/master
update as upstream
2016-02-09 00:52:19 +01:00
Kevin Sawicki
756aeffe03 Set icon on NSAlert when specified 2016-02-08 15:18:05 -08:00
Paul Betts
1d0179b192 Merge pull request #4406 from adam-lynch/patch-4
Docs: app: small process.argv clarification
2016-02-07 22:40:34 +01:00
Adam Lynch
5911c45b54 Docs: app: small process.argv clarification 2016-02-07 17:31:37 +00:00
Michael Vasseur
702455674b Using node::Buffer::Copy() instead of node::Buffer::New() to copy the handle bytes to buffer make the buffer really contains the data. 2016-02-07 10:20:38 +01:00
Marc-Aurèle DARCHE
fa734d7824 Document different techniques to share objects
This has been discussed in
2016-02-06 19:57:21 +01:00
Kevin Sawicki
18631df88b Merge pull request #4378 from markisadesignerd/ipc-renderer-doc-typo
📝 Fixing typo in ipc-renderer
2016-02-05 10:10:26 -08:00
Vjekoslav Ratkajec
d0d336eee7 Merge remote-tracking branch 'upstream/master' 2016-02-05 09:11:24 +01:00
Vjekoslav Ratkajec
252b12be13 Add readRtf feature with appropriate spec test. Docs updated as well. 2016-02-05 09:06:21 +01:00
Kevin Sawicki
027b5345f8 Merge pull request #4367 from atom/remove-resedit
Remove ResEdit link from docs
2016-02-04 13:37:15 -08:00
Kevin Sawicki
bf03be3541 Remove ResEdit links from translations 2016-02-04 13:32:13 -08:00
Kevin Sawicki
45ce16b73f Remove ResEdit 2016-02-04 13:29:32 -08:00
Kevin Sawicki
fa4ad9d95f Tweak help message for new path options 2016-02-04 10:45:52 -08:00
Vjekoslav Ratkajec
acd5d40ab0 Adding support to write RTF to clipboard. 2016-02-04 19:38:47 +01:00
Kevin Sawicki
f482ea4902 loadPackagePath -> loadApplicationPackage 2016-02-04 10:35:17 -08:00
Kevin Sawicki
b74dd43ff5 Support opening file: URLs directly 2016-02-04 10:34:36 -08:00
Kevin Sawicki
312182e0bd Add support for launching HTML files directly 2016-02-04 10:33:22 -08:00
Kevin Sawicki
69687c92e9 Add support for launching http URL directly 2016-02-04 10:26:11 -08:00
Kevin Sawicki
2e96cab6aa Extract helper function to load specified app 2016-02-04 10:07:19 -08:00
Kevin Sawicki
8df3856c8f Use const for fs/path requires 2016-02-04 09:16:40 -08:00
Kevin Sawicki
2b5cbe825a Merge pull request #4356 from chris-ls/patch-1
Clarify overlay description
2016-02-04 09:09:44 -08:00
ShiningRay
55950281e8 translate 2016-02-04 23:07:13 +08:00
ShiningRay
6c8d9a5ccf translate 2016-02-04 23:07:07 +08:00
ShiningRay
e9aa24e340 fix broken link 2016-02-04 18:10:26 +08:00
chris-ls
48c6692311 Clarify overlay description
'16px' is ambiguous and not clear (4 x 4 px? or 16 x 16px)
2016-02-04 15:36:41 +13:00
Kevin Sawicki
00261a5571 Remove lint warnings 2016-02-03 17:17:11 -08:00
Kevin Sawicki
adfa4844d1 Don't return anything from will-quit handler 2016-02-03 17:15:28 -08:00
Kevin Sawicki
6252511b7f Delete extensions file when there are no loaded extensions 2016-02-03 17:12:09 -08:00
Kevin Sawicki
5714ae0b73 Add failing spec for dev tools extensions file 2016-02-03 17:11:12 -08:00
Kevin Sawicki
8bd07af5e5 Correct typo in comment 2016-02-03 16:22:16 -08:00
Mark Potnick
b9e2806042 Fixing typo 2016-02-03 15:15:13 -05:00
Kevin Sawicki
a0792237a0 Merge pull request #4339 from ShiningRay/patch-1
fix typo
2016-02-03 09:56:49 -08:00
Cheng Zhao
ff6bf92ee4 Merge pull request #4329 from atom/reliable-shutdown
Emit exit event reliably in renderer process
2016-02-03 12:07:39 +08:00
Cheng Zhao
5b8b167cbb Merge pull request #4333 from Rafaelgfirmino/master
translation for pt_BR
2016-02-03 11:49:34 +08:00
ShiningRay
86ed7ca725 fix typo
Broswer -> Browser
2016-02-03 11:37:20 +08:00
Rafael Firmino
77d005c5c8 translation for pt_BR 2016-02-02 17:02:43 -02:00
Cheng Zhao
47de3f3f24 Fix failing specs 2016-02-03 00:05:27 +08:00
Cheng Zhao
bc196c016b Do process.emit('exit') in WillReleaseScriptContext 2016-02-02 23:47:19 +08:00
Cheng Zhao
ffcf609de1 Ensure only main frame get notifications 2016-02-02 23:44:33 +08:00
Cheng Zhao
4b67ff9534 Override WillReleaseScriptContext 2016-02-02 23:38:49 +08:00
Cheng Zhao
808b02edda Merge pull request #4325 from atom/download-item-cleanup
Cleanup DownloadItem related code
2016-02-02 20:36:54 +08:00
Cheng Zhao
50d69fd9bb Get rid of SavePathData 2016-02-02 20:11:39 +08:00
Cheng Zhao
eaa60e9c17 Destroy the item once item is downloaded 2016-02-02 19:54:41 +08:00
Cheng Zhao
12d311fd29 Gracefully destroy downloadItem 2016-02-02 19:52:09 +08:00
Cheng Zhao
65cf85808f Calling cancel() should destroy the downloadItem 2016-02-02 19:05:58 +08:00
Cheng Zhao
f1f91828ba Rely on OnDownloadDestroyed to destroy downloadItem 2016-02-02 18:49:43 +08:00
Cheng Zhao
f624800881 Merge pull request #4314 from deepak1556/download_cancel_patch
fix crash when default download is canceled
2016-02-02 18:40:44 +08:00
Robo
2819af9586 fix lifetime of downloadItem class when defaultdownload canceled 2016-02-02 15:54:51 +05:30
Cheng Zhao
fabd897d49 Merge pull request #4320 from runinspring/patch-1
Update app.md
2016-02-02 14:34:34 +08:00
ZhangYu
c69971c381 Update app.md 2016-02-02 13:59:02 +08:00
Cheng Zhao
b2d44a94ce Merge pull request #4312 from deepak1556/host_resolver_cache_clear_patch
session: api to clear host resolver cache
2016-02-02 13:49:35 +08:00
Rafael Dantas
aadb131bc7 Update Portuguse docs translation 2016-02-02 10:23:07 +08:00
Plusb Preco
683f9745ad 📝 Update as upstream
[ci skip]
2016-02-02 10:12:42 +08:00
Cheng Zhao
1a3c01efca Update native-mate for #4307 2016-02-02 10:11:04 +08:00
Robo
ce2ea963b9 session: api to clear host resolver cache 2016-02-02 02:06:49 +05:30
Kevin Sawicki
9341f9a6bc Merge pull request #4309 from diracdeltas/fix/use-strict
Fix 'user strict' typo
2016-02-01 12:36:24 -08:00
yan
035c1dd5a1 Fix 'user strict' typo 2016-02-01 11:46:02 -08:00
Robo
045e42a10c fix crash when default download is canceled 2016-02-02 00:26:37 +05:30
Cheng Zhao
a575192c5f Merge pull request #4305 from atom/remove-unnecessary-methods
Remove a few unneeded overrides
2016-02-01 21:37:24 +08:00
Cheng Zhao
7d68ca21c8 No need of DefaultWebContentsDelegate 2016-02-01 21:09:12 +08:00
Cheng Zhao
159fb857f4 No need to override RequestToLockMouse in CommonWebContentsDelegate 2016-02-01 21:05:29 +08:00
Cheng Zhao
69f93a7528 Merge pull request #4223 from deepak1556/notification_disable_patch
session: add setPermissionRequestHandler api
2016-02-01 20:51:22 +08:00
Robo
ff5fb512b8 use mediastreamdevicescontroller from brightray to enumerate available devices 2016-02-01 17:45:53 +05:30
Robo
b575cd0ef9 add fullscreen permission type 2016-02-01 16:22:05 +05:30
Cheng Zhao
9d2cc4f2cc Merge pull request #4302 from pra85/patch-1
docs: fix minor typo
2016-02-01 18:46:42 +08:00
Cheng Zhao
6c282775a9 Merge pull request #4301 from ragingwind/set-icon-crash
Fix type cast of sharedApplication
2016-02-01 18:46:20 +08:00
Robo
45eada306f add pointerlock permission type 2016-02-01 15:13:49 +05:30
Prayag Verma
d8086b6532 docs: fix minor typo
Replace `an` with `a`
2016-02-01 14:40:36 +05:30
Cheng Zhao
e450d1586e Merge pull request #4288 from MaxWhere/master
Adding cursor-changed event to webContents
2016-02-01 17:03:16 +08:00
ragingwind
d2ec311c55 Fix type cast of sharedApplication 2016-02-01 17:17:22 +09:00
Robo
db26dcaf4c expose handler from session and remove permission-request event 2016-02-01 12:23:51 +05:30
Heilig Benedek
745253a369 Quick fix for the memory leak + docs 2016-02-01 07:17:58 +01:00
Cheng Zhao
7fdff522d6 Merge pull request #4292 from be5invis/patch-1
Add link to BrowserWindow::setMenu in docs/api/menu.md
2016-02-01 13:19:59 +08:00
Cheng Zhao
e16154889a Merge pull request #4291 from yamatoya/master
📝 Update as upstream
2016-02-01 13:11:01 +08:00
Cheng Zhao
ea2f170b7d Merge pull request #4289 from wgrafael/patch-1
PT/BR Docs Translation: update the "janelas" to "windows"
2016-02-01 13:10:26 +08:00
Plusb Preco
d471952adf 📝 Update as upstream
[ci skip]
2016-02-01 12:56:24 +08:00
Cheng Zhao
457c7f55e6 Merge pull request #4271 from thingsinjars/master
🍎 Add 'Hide' to App API for OS X only
2016-02-01 12:54:07 +08:00
Robo
04c3e083fb remove unnecessary getter 2016-02-01 00:43:29 +05:30
Belleve Invis
1d629640bf Add link to BrowserWindow::setMenu 2016-02-01 00:28:44 +08:00
Heilig Benedek
066c189249 Renamed some cursor types to their CSS names and added a way to handle custom cursors properly. 2016-01-31 17:00:14 +01:00
Takahito Yamatoya
0f539adab9 📝 Update as upstream
[ci skip]
2016-02-01 00:20:36 +09:00
wgrafael
07721c28b6 update the "janelas" to "windows"
System Operation windows and not literal windows!
2016-01-31 00:02:06 -02:00
Heilig Benedek
61e0219e91 Added documentation, restructured the files to fit better with electron's style and fixed a typo in keyboard_util's name. 2016-01-31 02:27:14 +01:00
Simon Madine
f9efdc4435 🍎 Add Show to API for OS X 2016-01-30 22:30:38 +01:00
Robo
f7556de9fb add spec for new permissions 2016-01-30 19:10:52 +05:30
Cheng Zhao
0aa0efa439 Do not print warning for FILE_ERROR_NOT_FOUND
Close #4282.
2016-01-30 20:49:35 +08:00
Robo
2a278ceb8f delegate to permission manager for other permissions 2016-01-30 16:49:18 +05:30
Heilig Benedek
0c9174bc7c Introduced the cursor-changed event with one parameter - the name of the cursor type 2016-01-30 06:33:55 +01:00
Cheng Zhao
9d8e23c822 Bump v0.36.7 2016-01-30 13:20:46 +08:00
Cheng Zhao
11e2058136 Merge pull request #4281 from atom/fix-object-destroyed
Fix the occasional `Object has been destroyed` exception in the main process
2016-01-30 13:20:09 +08:00
Cheng Zhao
d2c757e2a5 Merge pull request #4277 from lukeadams/osx-min-version-bump
OS X min version bump (10.8=>10.9)
2016-01-30 13:02:24 +08:00
Cheng Zhao
3f68b2f227 Check whether sender is destroyed before calling sender.send
Fix #4279.
2016-01-30 12:58:21 +08:00
Cheng Zhao
5d16257c2d Fix "Object has been destroyed" error in "page-title-updated" event
Close #4249.
2016-01-30 12:20:28 +08:00
Cheng Zhao
899294a040 win: Don't close the handle since we already closed the fd
Fix #4266.
2016-01-30 11:47:22 +08:00
Heilig Benedek
e22cb0ca9f Merge pull request #1 from atom/master
update as upstream
2016-01-30 00:14:40 +01:00
Simon Madine
6a643ec3c8 Only add Hide if OS_X is defined 2016-01-29 22:51:06 +01:00
Kevin Sawicki
d89bda5c68 Merge pull request #4274 from petrfelzmann/doc-bullets-formatting
fix bullets formatting in documentation
2016-01-29 13:08:13 -08:00
Kevin Sawicki
2194640d20 Merge pull request #4275 from baconface/patch-1
Added missing angle bracket to replace() method
2016-01-29 13:07:29 -08:00
Luke Adams
1002d0de74 Bump minimum OSX version to 10.9 (documentation) 2016-01-29 14:03:49 -06:00
Luke Adams
839612c9ae Bump minimum OSX version to 10.9 2016-01-29 13:57:48 -06:00
Brad Metcalf
bdc2b2559c Added missing angle bracket to replace() method 2016-01-29 13:27:47 -06:00
Petr Felzmann
0169f31feb fix bullets formatting in documentation 2016-01-29 20:10:18 +01:00
Simon Madine
7a370ccd0f 🍎 Add 'Hide' to App API for OS X only 2016-01-29 16:09:54 +01:00
Robo
f32bf08eb3 add spec 2016-01-29 15:23:28 +05:30
Robo
85e13333c3 webview: add permission-request event 2016-01-29 15:23:28 +05:30
Cheng Zhao
30b35644f6 Bump v0.36.6 2016-01-29 12:43:35 +08:00
Cheng Zhao
a26cbf640c docs: cryptographic algorithms used by Electron
Fix #3995.
2016-01-29 12:38:50 +08:00
Cheng Zhao
367590a32f Merge pull request #4264 from atom/revert-3918
Revert "renderer: dont fork the process when there is server redirect"
2016-01-29 12:17:52 +08:00
Cheng Zhao
77cf30f758 Revert "renderer: dont fork the process when there is server redirect"
This reverts commit ab9d1bf97e.
2016-01-29 11:52:31 +08:00
Plusb Preco
0fe829cff7 📝 Update as upstream
[ci skip]
2016-01-29 09:17:34 +08:00
Cheng Zhao
8348910483 Merge pull request #4260 from fbukevin/master
Finished current entries translation of Guides part into zh-TW
2016-01-29 09:14:14 +08:00
fbukevin
8309e38ce9 translate zh-TW tutorial using-pepper-flash-plugin.md 2016-01-28 23:37:16 +08:00
fbukevin
15ce59be64 translate zh-TW tutorial devtools-extension.md 2016-01-28 23:23:19 +08:00
fbukevin
93f268cbd1 translate zh-TW tutorial using-selenium-and-webdriver.md 2016-01-28 22:52:57 +08:00
fbukevin
3b9fb6f9e6 translate zh-TW tutorial debugging-main-process.md 2016-01-28 22:40:13 +08:00
Cheng Zhao
516b01e398 win: Call _close before close file handle
Fix #4258.
2016-01-28 22:38:53 +08:00
fbukevin
7d54bb54cd translate zh-TW tutorial using-native-node-modules.md 2016-01-28 22:17:48 +08:00
fbukevin
4305e98fcb translate zh-TW tutorial mac-app-store-submission-guide.md 2016-01-28 21:16:59 +08:00
Paul Betts
05aeceeb52 Always fall back to OpenFolderViaShell when trying to reveal a file
We should always fallback to OpenFolderViaShell when revealing a file fails,
since this API seems to be highly subject to Random Bad Things happening to
you.
2016-01-28 19:05:16 +08:00
Cheng Zhao
d195cc3796 docs: uploadData is optional 2016-01-28 18:59:58 +08:00
Cheng Zhao
f820b0db83 docs: Revise the webRequest and protocol docs 2016-01-28 18:59:07 +08:00
Cheng Zhao
30ff18ac64 Merge branch 'webrequest_upload_data_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webrequest_upload_data_patch 2016-01-28 18:41:39 +08:00
fbukevin
223b440bc8 prepare for retaining "Guides" pages 2016-01-28 18:20:39 +08:00
Veck Hsiao
3c9e08faf1 finished translate application-packaging.md 2016-01-28 18:15:44 +08:00
fbukevin
1da13625d1 WIP: docs-translations/zh-TW/tutorial/application-packaging.md 2016-01-28 16:46:28 +08:00
fbukevin
e6fbb0adfa translate zh-TW tutorial application-distribution.md 2016-01-28 14:20:35 +08:00
Plusb Preco
172fc91768 📝 Update as upstream
[ci skip]
2016-01-28 10:44:45 +08:00
Cheng Zhao
e9d00b1fc0 Merge pull request #4247 from deepak1556/common_exports_patch
common: export hideInternalModules
2016-01-27 23:20:59 +08:00
Cheng Zhao
c4df96df67 Update brightray to fix compilation error 2016-01-27 23:19:22 +08:00
Robo
a6bcc5d110 common: export hideInternalModules 2016-01-27 18:44:47 +05:30
Robo
dc0151099c session: provide uploadData with webrequest api when available 2016-01-27 18:39:40 +05:30
Cheng Zhao
3ca941a949 Update brightray for #4223 2016-01-27 21:03:23 +08:00
Cheng Zhao
ab96150016 Merge pull request #4246 from fbukevin/master
Add Traditional Chinese Translation Page
2016-01-27 20:12:41 +08:00
Cheng Zhao
f32a486441 Merge pull request #4245 from yamatoya/master
Add Japanes translated docs.
2016-01-27 20:12:14 +08:00
Cheng Zhao
3a5949d66a Merge pull request #4244 from vaenow/patch-1
Update application-distribution.md
2016-01-27 20:11:45 +08:00
Cheng Zhao
1ce85a69b9 Merge pull request #4235 from Bipsync/master
Autoupdate: Fixed crash after update is downloaded on windows
2016-01-27 20:03:51 +08:00
Veck Hsiao
8011578e8c Add Traditional Chinese Translation Page
supported-platforms.md
2016-01-27 14:48:06 +08:00
Takahito Yamatoya
4ab6846123 :memo:Add Japanes translated docs.
[ci skip]
2016-01-27 15:17:24 +09:00
Wen Luo
b01d677086 Update application-distribution.md
Remove duplicated words.
2016-01-27 11:41:03 +08:00
Paul P
cbf11f38ca remove unused variable 2016-01-26 14:55:31 +00:00
Paul P
864449db89 prevent assignment to constant variable (url) 2016-01-26 14:44:46 +00:00
Cheng Zhao
2c7717d98e Merge pull request #4233 from atom/update-node
Ignore errors happened in Node's stdout/stdin stream
2016-01-26 20:50:23 +08:00
Cheng Zhao
f87edba7fb Merge pull request #4231 from yamatoya/master
:memo:Add Japanes translated docs.
2016-01-26 20:32:01 +08:00
Cheng Zhao
d0587a9c52 spec: process.stdout.write 2016-01-26 20:26:42 +08:00
Cheng Zhao
205b2455f2 Update node 2016-01-26 20:23:32 +08:00
Takahito Yamatoya
ab8e6650bd :memo:Add Japanes translated docs.
[ci skip]
2016-01-26 18:17:42 +09:00
Cheng Zhao
4c43be2148 docs: Add more on the "electron.xxx" undefined question 2016-01-26 17:00:12 +08:00
Plusb Preco
2af7c37d13 📝 Update as upstream
[ci skip]
2016-01-26 11:29:19 +08:00
Cheng Zhao
b461969114 docs: Add "require('electron').xxx is undefined." to FAQ 2016-01-25 18:47:46 +08:00
Cheng Zhao
a34618866f Merge pull request #4221 from yamatoya/master
Add Japanes translated docs.
2016-01-25 18:21:46 +08:00
Takahito Yamatoya
d8c8214f33 Add Japanes translated docs. 2016-01-25 18:10:34 +09:00
Cheng Zhao
a83aee90e5 No need to use scoped_nsobject for id 2016-01-25 15:15:58 +08:00
Cheng Zhao
059d97e1aa Merge pull request #4181 from bengotow/scroll-touch-events
Extend NativeWindow to track touch-based scroll events on OS X
2016-01-25 14:47:54 +08:00
Cheng Zhao
58127e3d52 Merge pull request #4217 from yamatoya/master
Add Japanes translated docs, improve a doc style.
2016-01-24 22:42:51 +08:00
Cheng Zhao
253a4f226f Merge pull request #4211 from ragingwind/dock-seticon
Add app.dock.setIcon to change icon of dock
2016-01-24 22:36:28 +08:00
Cheng Zhao
93cdc91f1a Merge pull request #4206 from ragingwind/paramter-consistency
Update name of paramter for consistency
2016-01-24 22:11:01 +08:00
Cheng Zhao
e1e58b642e Merge pull request #4182 from deepak1556/debugger_api_patch
browser: add webContents.debugger api
2016-01-24 21:43:18 +08:00
Cheng Zhao
7761815339 Merge branch 'bg-color-pr' of https://github.com/evgenyzinoviev/electron 2016-01-24 21:33:53 +08:00
Takahito Yamatoya
42493a7ed3 Add Japanes translated docs, improve a doc style. 2016-01-24 19:47:12 +09:00
Cheng Zhao
45798d1933 Merge pull request #4215 from atom/fix-fullscreenable
Add tests for "-able" options and methods
2016-01-24 15:20:16 +08:00
Cheng Zhao
cc560a3900 spec: Fix failing tests on Windows 2016-01-24 14:31:37 +08:00
Cheng Zhao
8239f69139 spec: hasShadow state 2016-01-24 14:31:37 +08:00
Cheng Zhao
c33e8de676 spec: Improve the test for resizable 2016-01-24 14:31:37 +08:00
Cheng Zhao
c41de501cb spec: Test the -able methods 2016-01-24 14:31:37 +08:00
Cheng Zhao
010cc3276a Simplify the setStyleMask calls 2016-01-24 14:31:37 +08:00
Cheng Zhao
239bfe970c Make hasShadow work on Windows/Linux 2016-01-24 14:31:37 +08:00
Cheng Zhao
d704b3f7ba Reorgnize how attributes work 2016-01-24 14:31:37 +08:00
Cheng Zhao
ae7e96f181 Fix fullscreenable on EL Capitan 2016-01-24 14:31:36 +08:00
Cheng Zhao
5372b6cd91 Fullscreenable => FullScreenable 2016-01-24 14:31:36 +08:00
Plusb Preco
d6f2b7c982 📝 Update as upstream
* Update as upstream
* Fix typos
* Improve grammar
[ci skip]
2016-01-24 14:31:23 +08:00
Cheng Zhao
6ab236f9c0 Merge pull request #4204 from yamatoya/master
Add Japanes translated docs.
2016-01-24 14:28:59 +08:00
ragingwind
7229d2462a Add app.dock.setIcon to change icon of dock 2016-01-24 08:30:14 +09:00
ragingwind
09966aec38 Update name of paramter for consistency 2016-01-23 22:59:05 +09:00
Takahito Yamatoya
85df3157c7 Add Japanes translated docs. 2016-01-23 20:03:10 +09:00
Cheng Zhao
31624995bc Merge pull request #4202 from evgenyzinoviev/shadow-pr
Added hasShadow option to BrowserWindow on OS X
2016-01-22 23:56:38 -08:00
Cheng Zhao
8cabe0f008 Merge pull request #4156 from evgenyzinoviev/windows-pr
Improvements in BrowserWindow
2016-01-22 23:42:41 -08:00
Robo
d938dd68b0 wrap debugger for lazy initialization 2016-01-23 09:32:21 +05:30
evgenyzinoviev
000af78d41 doc fix 2016-01-23 01:37:18 +01:00
evgenyzinoviev
e071e4f310 doc updated 2016-01-23 01:20:42 +01:00
evgenyzinoviev
ff41b4a267 added hasShadow option to BrowserWindow (osx) 2016-01-23 01:16:08 +01:00
evgenyzinoviev
2fcd3ce7cd Support alpha in backgroundColor 2016-01-23 00:55:08 +01:00
evgenyzinoviev
85991d312a mac: SetResizable fix 2016-01-22 23:44:17 +01:00
evgenyzinoviev
3182504969 maximizable, fullscreenable docs 2016-01-22 23:32:09 +01:00
evgenyzinoviev
ef51e4e108 maximizable and fullscreenable 2016-01-22 23:21:46 +01:00
Cheng Zhao
9b28b0e943 Merge pull request #4198 from atom/default-popup-x-y
Cleanup the Menu::popup code
2016-01-22 13:33:14 -07:00
Cheng Zhao
984462be44 Remove Menu::Popup 2016-01-22 11:59:08 -07:00
Cheng Zhao
d1051b55cc docs: Default value of positioningItem 2016-01-22 11:32:14 -07:00
Cheng Zhao
2d8e5e3a16 docs: Default parameter for Menu.popup 2016-01-22 11:29:26 -07:00
Cheng Zhao
ca77c95c6d No more need to override Menu::Popup 2016-01-22 11:27:17 -07:00
Cheng Zhao
0e3a3d0748 views: Remove PopupAtPoint 2016-01-22 11:25:16 -07:00
Cheng Zhao
5f195a789a mac: Remove duplicate code of Popup 2016-01-22 11:17:12 -07:00
Cheng Zhao
360266ba5b positioningItem => positioning_item 2016-01-22 10:51:51 -07:00
Cheng Zhao
ea9b0cfed0 Merge pull request #4192 from evgenyzinoviev/menu-pr
Menu.popup: specify positioning item (OS X)
2016-01-22 10:49:17 -07:00
Cheng Zhao
985131d25e Merge pull request #4190 from ragingwind/strict-compare
Using strict comparation
2016-01-22 09:48:40 -07:00
Robo
3a60ab386c add spec 2016-01-22 19:10:48 +05:30
Robo
df5bad3f89 fix api and docs 2016-01-22 10:27:25 +05:30
evgenyzinoviev
072ab0ddea specify positioning item for popup menus 2016-01-22 03:18:27 +01:00
Ben Gotow
d186dceb4b Add correct window check for wheel events. See description
Tested that with two windows, events are fired on the correct BrowserWindow instance and not both, and that scrolling a window which is in the background works properly.
2016-01-21 16:36:48 -08:00
Ben Gotow
e96e674201 Properly clean up NSEvent monitor 2016-01-21 16:31:31 -08:00
Ben Gotow
d492ff45d5 Rename up/down => begin/end 2016-01-21 16:31:09 -08:00
ragingwind
63ae73b281 Using strict comparation 2016-01-22 09:04:59 +09:00
Cheng Zhao
a230a89de4 Bump v0.36.5 2016-01-21 17:04:38 -07:00
Cheng Zhao
b039741c6b Merge pull request #3902 from bengotow/asar-perf
Add env var to export a hint file to optimize ASAR ordering
2016-01-21 16:46:49 -07:00
Jessica Lord
b614c484dc Merge pull request #4189 from atom/update-accelerator
Use Alt in OS X 'Hide Others' menu item accelerator
2016-01-21 16:14:14 -07:00
Jessica Lord
980bc7bf32 Use Alt in accelerator 2016-01-21 15:48:06 -07:00
Ben Gotow
ed34e33fbf Fix typos in environment-variables.md 2016-01-21 14:46:08 -08:00
Ben Gotow
b9d62d2cab Turn on logging via a command line env var 2016-01-21 14:46:08 -08:00
Jessica Lord
1b8200ea34 Merge pull request #4188 from Rosey/update-menu-doc
📝 Use correct shortcut for 'Hide Others' menu item example
2016-01-21 15:45:49 -07:00
Ben Gotow
a3b6f69772 Log ASAR file access to build ordering hint file
This is a work in progress—need to make this behavior optional via a new flag.
2016-01-21 14:45:22 -08:00
Cheng Zhao
21f5e27a5e Merge pull request #4161 from gabriel/master
Support backgroundColor for window on mac
2016-01-21 15:42:21 -07:00
Rose Robertson
859d9763e9 📝 Use correct shortcut for 'Hide Others' menu item example
As per https://support.apple.com/en-gb/HT201236, the correct keyboard shortcut
for hiding all but the current window is Command-Option(Alt)-H.
2016-01-21 14:31:18 -08:00
Plusb Preco
4b02a8ead0 📝 Update as upstream
[ci skip]
2016-01-21 15:23:07 -07:00
Cheng Zhao
bbf622187c Merge pull request #4178 from deepak1556/webview_blinkfeatures_attributes_patch
webview: add blinkfeatures attribute
2016-01-21 15:03:33 -07:00
Cheng Zhao
a98d576b48 Merge pull request #4177 from deepak1556/default_download_dir_patch
browser: change location of default download dir
2016-01-21 14:54:21 -07:00
Cheng Zhao
56e8ddbdaf Merge pull request #4186 from CharlieHess/webview-load-url
Expose loadURL for the webview tag.
2016-01-21 14:53:32 -07:00
Cheng Zhao
000625e23f Merge pull request #4163 from deepak1556/web_preferences_fonts_patch
browser: add font related settings to webpreferences
2016-01-21 14:35:30 -07:00
Charlie Hess
7192a8517b Expose loadURL for the webview tag. 2016-01-21 13:31:35 -08:00
Cheng Zhao
4cf5982e92 Update brightray for #4169 2016-01-21 14:08:10 -07:00
Gabriel Handford
239baa3e9a Support backgroundColor for window on mac 2016-01-21 11:07:33 -08:00
Robo
0e2323c9c8 browser: add webContents.debugger api 2016-01-21 23:52:23 +05:30
Ben Gotow
bd2252ea55 Extend NativeWindow to track touch-based scroll events on OS X
In N1, we want to implement the famous "swipe to archive" action on threads in the user's inbox. Chrome exposes `scroll` and `wheel` events, but these aren't sufficient to implement the interaction because the element needs to "snap" when the user lifts their fingers from the trackpad, not when they / we stop receiving `wheel` / `scroll` events. These events may stop before the user lifts their fingers, or continue after the user has lifted their fingers if they had enough momentum for the gesture to continue.

This exposes BrowserWindow `scroll-touch-down` and `scroll-touch-up`, which fire immeditaely when the user touches two fingers to the trackpad, and again when the user lifts their fingers. Combined with the existing wheel event should allow for "swipe-to-archive" and other similar interactions.

Note: This is only implemented on Mac OS X and the events don't fire unless you're using a trackpad!

Related: #1486, #2683, https://github.com/nylas/N1/issues/541
2016-01-21 09:40:21 -08:00
Kevin Sawicki
fda480d1aa Merge pull request #4172 from atom/enable-eslint-rules
Enable more eslint rules
2016-01-21 09:56:07 -07:00
Kevin Sawicki
3a55647ae3 Add WebView to globals 2016-01-21 09:32:22 -07:00
Kevin Sawicki
b46d8ec91b Enable no-undef eslint rule 2016-01-21 09:32:22 -07:00
Kevin Sawicki
e9b3a51703 Add missing fs require 2016-01-21 09:32:22 -07:00
Kevin Sawicki
669b815758 Add missing semicolons 2016-01-21 09:32:22 -07:00
Kevin Sawicki
b5cf352312 Add globals to eslint config 2016-01-21 09:32:22 -07:00
Kevin Sawicki
b399455808 Run cpplint from lint npm script 2016-01-21 09:32:21 -07:00
Kevin Sawicki
16b4b58de1 e -> error 2016-01-21 09:32:21 -07:00
Kevin Sawicki
b1f679ff6d Clean up semicolon lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
70bcb0ac5a Clean up no-unused-vars lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
ccce284a5b Clean up no-empty lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
4f4456bde8 Clean up indent eslint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
45ddbb6d67 Clean up no-unreachable lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
fbfbf2158a Add npm run lint script 2016-01-21 09:32:21 -07:00
Robo
fab34b400e webview: add blinkfeatures attribute 2016-01-21 15:43:41 +05:30
Robo
c14dd71df1 browser: change location of default download dir 2016-01-21 13:51:37 +05:30
Robo
8a00406862 browser: add font related settings to webpreferences 2016-01-21 13:30:05 +05:30
Cheng Zhao
2e8a2c3a7f Merge pull request #4170 from arniu/patch-1
Update coding-style.md
2016-01-20 15:47:32 -07:00
Cheng Zhao
2fba39d719 Merge pull request #4166 from ragingwind/patch-1
Add Korean community
2016-01-20 15:34:31 -07:00
Cheng Zhao
40557083f0 Merge pull request #4164 from deepak1556/menu_toggle_crash_patch
browser: fix crash when switching to sibling menu from submenus
2016-01-20 15:32:53 -07:00
Cheng Zhao
ee2d2cc532 Merge pull request #4165 from yamatoya/master
Add Japanes translated docs.
2016-01-20 15:28:17 -07:00
Kevin Sawicki
cac8466fb1 Merge pull request #4168 from atom/cpplint-utility-folder
Run cpplint on utility folder
2016-01-20 10:00:50 -07:00
Cheng Zhao
5bd2d4b08d docs: win.destroy() is safe 2016-01-20 09:46:38 -07:00
Kevin Sawicki
8140adb6bc Remove trailing whitespace 2016-01-20 09:43:32 -07:00
Kevin Sawicki
5d249e2a94 Run cpplint on utility folder 2016-01-20 09:43:32 -07:00
Cheng Zhao
54b5369215 Merge pull request #4158 from atom/desktop-capturer-error-message
Fix error calling desktopCapturer.getSources twice
2016-01-20 09:42:51 -07:00
Hailin Tseng
f1ef24b359 Update coding-style.md 2016-01-21 00:03:41 +08:00
Jimmy Moon
9a82c5a1c0 Add Korean community 2016-01-20 19:05:35 +09:00
Takahito Yamatoya
a874abd5a8 Add Japanes translated docs. 2016-01-20 16:09:01 +09:00
Robo
65325dc63f browser: fix crash when switching to sibling menu from submenus 2016-01-20 10:54:12 +05:30
Cheng Zhao
af3def91f2 Merge pull request #4146 from yamatoya/master
Add Japanes translated docs.
2016-01-19 12:12:41 -08:00
Kevin Sawicki
b014eea8d3 Tweak spec description 2016-01-19 11:05:57 -08:00
Kevin Sawicki
517dce443b Remove unused errorMessage reference 2016-01-19 11:02:12 -08:00
Kevin Sawicki
c719b252cb Add failing spec 2016-01-19 10:57:18 -08:00
Kevin Sawicki
fb3ab9e1f1 Use const and remove extra returns 2016-01-19 10:54:12 -08:00
Kevin Sawicki
01e1d0dfef Merge pull request #4153 from sunaiwen/patch-1
Update debugging-main-process.md
2016-01-19 10:12:26 -08:00
Kevin Sawicki
d3186a9665 Merge pull request #4150 from hamxiaoz/patch-1
Fix a broken link
2016-01-19 10:10:17 -08:00
evgenyzinoviev
fd5c249cb8 fix for windows 2016-01-19 16:58:19 +01:00
evgenyzinoviev
0a79204abb IsMovable to return true on Linux 2016-01-19 16:44:04 +01:00
evgenyzinoviev
c3049e1e99 docs updated 2016-01-19 16:14:59 +01:00
evgenyzinoviev
2a554cb138 added or/and improved closable, minimizable, movable, resizable features for windows on os x and windows 2016-01-19 16:14:57 +01:00
Takahito Yamatoya
140bc4effc Add Japanes translated docs. 2016-01-19 17:23:17 +09:00
Niven Su
b9c9da3f4e Update debugging-main-process.md
fix doc typo
2016-01-19 13:49:49 +08:00
Andrew Zheng
b4aaaed843 Fix a broken link
The reference-style link uses a relative path, which doesn't work well on the main site http://electron.atom.io/.
2016-01-18 13:50:33 -08:00
Takahito Yamatoya
fc42e97144 Add Japanes translated docs. 2016-01-18 23:38:44 +09:00
Cheng Zhao
7842a657d0 Merge pull request #4142 from Rokt33r/patch-2
Update frameless-window.md
2016-01-18 18:33:03 +08:00
Dick Choi
2907c4f068 Update frameless-window.md
`-title-bar-style` => `titleBarStyle“

https://github.com/atom/electron/blob/master/docs/api/browser-window.md#class-browserwindow
2016-01-18 18:35:14 +09:00
Cheng Zhao
307add22b2 Merge pull request #4138 from yamatoya/master
Add Japanes translated docs.
2016-01-18 15:37:07 +08:00
Takahito Yamatoya
def1477466 Add Japanes translated docs. 2016-01-18 01:00:28 +09:00
Cheng Zhao
40a93f1374 Merge pull request #4135 from atom/add-npm-start
Add npm start script
2016-01-17 14:33:28 +08:00
Kevin Sawicki
4e183df997 Add npm start script 2016-01-16 12:31:09 -08:00
Cheng Zhao
6f1fe2e478 Merge pull request #4133 from yamatoya/master
Update Japanese translated docs.
2016-01-17 00:11:52 +08:00
Takahito Yamatoya
6ecacd18be Update Japanese translated docs. 2016-01-17 01:02:02 +09:00
Cheng Zhao
3b62ce7fa6 modules.exports => module.exports 2016-01-16 14:26:01 +08:00
Cheng Zhao
775e475d5c Merge pull request #4131 from etiktin/add_is_DWM_enabled
Add API for checking if DWM composition (Aero Glass) is enabled
2016-01-16 14:16:22 +08:00
Cheng Zhao
5a83f94524 Merge pull request #4126 from atom/add-eslint
Run eslint on CI
2016-01-16 13:26:07 +08:00
Cheng Zhao
25afcf2673 Merge pull request #4121 from atom/format-coffee-helpers
Format leftover CoffeeScript helpers
2016-01-16 13:24:26 +08:00
Eran Tiktin
f42d283fcd Add documentation 2016-01-16 07:18:20 +02:00
Eran Tiktin
83b36ce40b Add API for checking if AeroGlass/DWM is enabled
Resolves #1020
2016-01-16 06:27:44 +02:00
Cheng Zhao
712f11a9a3 Merge pull request #4112 from evgenyzinoviev/resize-animate-pr
Animate window resizing on OS X
2016-01-16 12:12:00 +08:00
Cheng Zhao
b132c0dde8 Update brightray, close #4124 2016-01-16 11:43:46 +08:00
Cheng Zhao
d779f8d898 Merge pull request #4129 from etiktin/fix_4127
Fix freeing asar fd on Windows
2016-01-16 11:41:28 +08:00
Eran Tiktin
85449e953e Fix Windows crash when trying to free asar fd 2016-01-16 03:48:07 +02:00
Kevin Sawicki
0fe539f2c3 Remove unneeded semicolon 2016-01-15 15:30:07 -08:00
Kevin Sawicki
ae20292322 Add missing { 2016-01-15 15:30:07 -08:00
Kevin Sawicki
f830af49c2 Use ES6 style class 2016-01-15 15:30:01 -08:00
Kevin Sawicki
503cd04c75 Disable linebreak-style rule 2016-01-15 14:58:46 -08:00
Kevin Sawicki
da120d8874 Lint entire atom folder 2016-01-15 14:43:23 -08:00
Kevin Sawicki
2869869a99 Combine duplicate eslint keys 2016-01-15 14:40:37 -08:00
Kevin Sawicki
1d3e7dc6e4 Run eslint on CI 2016-01-15 14:38:07 -08:00
Kevin Sawicki
b87599a6a2 Rename eslintrc-src to eslintrc-base 2016-01-15 14:37:51 -08:00
Kevin Sawicki
5fc671f522 Add back v8Util binding 2016-01-15 14:29:36 -08:00
Kevin Sawicki
aab2821122 Use ES6 style class 2016-01-15 14:28:12 -08:00
Kevin Sawicki
aab1568682 Use ES6 style class 2016-01-15 14:16:38 -08:00
Kevin Sawicki
02f055b784 Use ES6 style class 2016-01-15 14:12:57 -08:00
Kevin Sawicki
756f8039e5 Lint spec js files 2016-01-15 14:02:05 -08:00
Kevin Sawicki
0a3331a07c Add eslint dev dependency 2016-01-15 13:52:42 -08:00
Kevin Sawicki
4db4d409a7 Add initial eslint script 2016-01-15 13:52:18 -08:00
Kevin Sawicki
ad3376b9dc Add initial eslint config 2016-01-15 13:37:03 -08:00
Kevin Sawicki
caf7cf5582 Use const instead of var 2016-01-15 11:46:52 -08:00
Eran Tiktin
b9789ef191 Merge pull request #11 from atom/master
Update from upstream
2016-01-15 21:00:37 +02:00
Kevin Sawicki
79f1029d59 Remove unneeded .constructor segments 2016-01-15 10:29:00 -08:00
Kevin Sawicki
34030d7b2b Use util.inherits instead of CoffeeScript's extend function 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2b95aeba3c Declare vars one per line 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2833db78ad Use [].inclues where appropriate 2016-01-15 10:17:45 -08:00
Kevin Sawicki
c2d473cf65 Remove unneeded [].indexOf fallback 2016-01-15 10:17:45 -08:00
Kevin Sawicki
1b0da44f38 Merge pull request #4122 from atom/remove-cpp-lint-warning
Fix lint errors in archive.cc
2016-01-15 10:17:16 -08:00
Kevin Sawicki
741d148776 Add missing semicolon 2016-01-15 10:09:19 -08:00
Kevin Sawicki
b119704ea9 Use 2 space indent instead of 3 2016-01-15 10:05:35 -08:00
evgenyzinoviev
64f310168c code style fix 2016-01-15 17:40:42 +01:00
evgenyzinoviev
b75dccb0be arguments handing rewritten, doc updated 2016-01-15 17:31:31 +01:00
Cheng Zhao
63278aeec2 Merge pull request #4118 from Ivshti/patch-1
Ensure we close FD on Windows
2016-01-15 23:58:57 +08:00
Cheng Zhao
d6e2db22b3 Merge pull request #4116 from 0b61d29/patch-1
Spelling: bellow → below
2016-01-15 23:33:25 +08:00
Cheng Zhao
7e7175b6a5 Merge pull request #4113 from importcjj/master
fix incorrect markdown tag
2016-01-15 23:32:39 +08:00
Cheng Zhao
0937144849 Merge pull request #4111 from evgenyzinoviev/movable
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
evgenyzinoviev
4b0119f996 added a note that this option is only implemented on osx 2016-01-15 16:02:23 +01:00
Ivo Georgiev
7586078d0a Ensure we close FD on Windows 2016-01-15 16:54:29 +02:00
Florian Hämmerle
187cb54c25 spelling: bellow -> below 2016-01-15 13:43:44 +01:00
Cheng Zhao
233e2d7288 Merge pull request #4082 from atom/web-contents-lifetime
Fix some junk output when running tests
2016-01-15 17:24:47 +08:00
Cheng Zhao
9ccc7ee30d Small ajustments on lifetime of webContents 2016-01-15 16:36:35 +08:00
Cheng Zhao
63c646242a spec: Group session.cookies tests 2016-01-15 16:36:35 +08:00
Cheng Zhao
60d44b3b04 spec: Remove annoying outputs from savePage test 2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d No need to call sender.callbacks.remove
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf Merge pull request #4109 from atom/const
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Importcjj
a5cc105311 fix incorrect markdown tag 2016-01-15 15:26:16 +08:00
Cheng Zhao
39225ac5ec Bump v0.36.4 2016-01-15 14:27:19 +08:00
evgenyzinoviev
f93d890874 Fix doc 2016-01-15 06:00:06 +01:00
evgenyzinoviev
2598b00b41 Animate window resizing on OS X 2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c Added option to prevent a window from being moved on OS X 2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe Clean up variable declarations 2016-01-14 18:07:29 -08:00
Kevin Sawicki
d4b8c65017 Merge pull request #4110 from atom/add-missing-spec-suffix
Add missing spec suffix to desktopCapturer spec filename
2016-01-14 17:50:02 -08:00
Kevin Sawicki
572f53dc5e Expand spec description 2016-01-14 17:20:44 -08:00
Jessica Lord
5a4a8e1fa7 🔥 stray ref 2016-01-14 17:03:55 -08:00
Kevin Sawicki
047975609d Add missing -spec suffix to desktop capturer spec 2016-01-14 17:03:51 -08:00
Jessica Lord
2be7f6c693 Merge pull request #4102 from Mingling94/documentation
Styled the removeListener & removeAllListeners
2016-01-14 15:48:09 -08:00
Jessica Lord
ae2893ceaa Inline var 2016-01-14 15:44:33 -08:00
Jessica Lord
5412ecdcc1 Use const 2016-01-14 14:52:05 -08:00
Jessica Lord
ab8908a4af Use const 2016-01-14 14:41:46 -08:00
Jessica Lord
1779701445 Use const 2016-01-14 14:40:12 -08:00
Jessica Lord
3a0fb42737 Use const 2016-01-14 14:33:45 -08:00
Jessica Lord
9103253f62 Use const 2016-01-14 14:26:10 -08:00
Kevin Sawicki
f31289c735 Merge pull request #4106 from atom/clean-up-comments
Clean up comments from CoffeeScript migration
2016-01-14 14:10:26 -08:00
Kevin Sawicki
030d2a843c Remove extra newlines around comments 2016-01-14 11:10:12 -08:00
Kevin Sawicki
990dc30e8d Use // for multi-line comments 2016-01-14 10:44:21 -08:00
Kevin Sawicki
f4af744519 Use // for single line comments 2016-01-14 10:35:29 -08:00
Ming Luo
ad9c254730 Styled the removeListener & removeAllListeners
They were previously not written with the same style as other parts of
the doc. Also there was a couple grammar errors
2016-01-14 09:27:24 -05:00
Cheng Zhao
26350f4ccb GetHttpCacheInIO => DoCacheActionInIO 2016-01-14 20:48:14 +08:00
Cheng Zhao
f93b4e76cb Merge pull request #4098 from deepak1556/session_cache_size_patch
session: api to get current cache size
2016-01-14 20:18:21 +08:00
Robo
10e4698baa session: api to get current cache size 2016-01-14 17:15:45 +05:30
Cheng Zhao
88725d4fd7 Merge pull request #4091 from deepak1556/webview_attributes_patch
webview: respect properties provided during webview creation
2016-01-14 12:22:57 +08:00
Cheng Zhao
bc699a9dbe Merge pull request #4088 from Mingling94/documentation
Detail ipc.removeListener & ipc.removeAllListeners
2016-01-14 12:19:47 +08:00
Plusb Preco
918825cb58 📝 Update as upstream
[ci skip]
2016-01-14 09:56:28 +08:00
Cheng Zhao
463bc8738a Merge pull request #4089 from yamatoya/master
Add  Japanese translated docs.
2016-01-14 09:48:18 +08:00
Robo
8b38bbcf18 webview: respect properties provided during webview creation 2016-01-13 22:40:55 +05:30
Kevin Sawicki
9bfc8c9bd0 Merge pull request #4090 from lukeapage/patch-5
docs - fix typo leading to bad link
2016-01-13 09:00:17 -08:00
Luke Page
edbf1994dd docs - fix typo leading to bad link 2016-01-13 16:52:07 +00:00
大和屋 貴仁
b373fbc552 Add Japanese translated docs. 2016-01-14 01:33:06 +09:00
Ming Luo
a82ecfda06 Detail ipc.removeListener & ipc.removeAllListeners 2016-01-13 10:18:12 -05:00
Cheng Zhao
489539d62e Merge pull request #4071 from deepak1556/session_flush_data_patch
session: api to flush DOMStorage data
2016-01-13 16:18:37 +08:00
Cheng Zhao
884a8a753f Merge pull request #4080 from atom/insert-text
Add insertText API for webFrame, webContents and webview tag
2016-01-13 16:17:49 +08:00
Cheng Zhao
8ae836d82d Unlisten the zoom-level-changed event when webview is detached 2016-01-13 14:58:16 +08:00
Cheng Zhao
44b8343585 Fix crash when closing page with webview 2016-01-13 14:47:39 +08:00
Cheng Zhao
af02739c4e Change webview's zoom level on JavaScript side 2016-01-13 12:50:02 +08:00
Cheng Zhao
118924ba7a docs: webFrame.executeJavaScript 2016-01-13 12:20:49 +08:00
Cheng Zhao
350c572a8c Handle default parameter of executeJavaScript in C++ 2016-01-13 12:17:56 +08:00
Cheng Zhao
55dfddba77 Handle executeJavaScript in JavaScript 2016-01-13 12:11:46 +08:00
Cheng Zhao
5b7d1a9890 Add insertText to WebContents 2016-01-13 11:55:49 +08:00
Robo
8433d94cac session: api to flush DOMStorage data 2016-01-13 08:56:00 +05:30
Cheng Zhao
5567baf335 Add webFrame.insertText API 2016-01-13 11:21:16 +08:00
Cheng Zhao
d9d821cea5 Merge pull request #4065 from atom/coffee-to-js
[WIP] Convert from CoffeeScript to JavaScript
2016-01-13 11:13:04 +08:00
Cheng Zhao
640ad65cc2 Merge pull request #4075 from j5a/japanese-translation-patch
Add and update Japanese translated docs.
2016-01-13 09:57:52 +08:00
Kevin Sawicki
b547a38b3f Add wrapper functions to mirror old CoffeeScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
78aff6a39f 🎨 2016-01-12 16:24:06 -08:00
Kevin Sawicki
ab73f4c94a Copy JS files to tempdir before packing asar 2016-01-12 16:24:06 -08:00
Kevin Sawicki
ed63441688 Remove coffee compile script 2016-01-12 16:24:06 -08:00
Kevin Sawicki
61af98cf94 Remove CoffeeScript register in specs 2016-01-12 16:24:06 -08:00
Kevin Sawicki
dd902c61fa Expect .js specs 2016-01-12 16:24:06 -08:00
Kevin Sawicki
088a39ea9d Convert gyp targets to use JavaScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
ddfe4809e7 Remove unused dependencies 2016-01-12 16:24:06 -08:00
Kevin Sawicki
714e544b51 Remove coffeelint usage 2016-01-12 16:24:06 -08:00
Kevin Sawicki
1f9691ae13 Convert all source files to JavaScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
403870a27e Migrate to block comments 2016-01-12 16:22:34 -08:00
Joe Naha
1fd1ae9694 📝 Add and update Japanese translated docs.
[ci skip]
2016-01-13 08:46:14 +09:00
Cheng Zhao
630cd091a0 Merge pull request #4070 from atom/flash-drm
Respond to GetDeviceID message from pepper plugin
2016-01-12 23:45:59 +08:00
Cheng Zhao
57da8908b2 Use volume serial number as device id 2016-01-12 23:17:07 +08:00
Cheng Zhao
8832d7b77b Import PepperFlashDRMHost class 2016-01-12 22:17:24 +08:00
Cheng Zhao
c2f6f64e6a Merge pull request #4069 from atom/destroyed-webcontents-methods
Destroy the native class when webContents is destroyed
2016-01-12 21:40:18 +08:00
Cheng Zhao
d674db6606 spec: Calling methods of destroyed webContents should not crash 2016-01-12 21:15:12 +08:00
Cheng Zhao
eb63e6b9a7 Destroy the native class when webContents is destroyed 2016-01-12 21:10:24 +08:00
Cheng Zhao
554575b029 Upgrade to Chrome 47.0.2526.110 2016-01-12 20:46:47 +08:00
Cheng Zhao
6d850ea61f docs: Mention the session object 2016-01-12 10:59:45 +08:00
Cheng Zhao
1242fe04a8 Merge pull request #4062 from j5a/master
Update some Japanese translated docs.
2016-01-12 10:07:45 +08:00
Kevin Sawicki
17be978ced Merge pull request #4064 from weiway/patch-1
missing "var" in line 201 menu.md
2016-01-11 10:52:33 -08:00
Wei Wang
7333e403b7 missing "var" in line 201 menu.md
in line 201 at menu.md, 
should be ```var menu = Menu.buildFromTemplate(template);```
2016-01-11 10:47:32 -08:00
Joe Naha
4702b3e0c7 📝 Update some Japanese translated docs.
[ci skip]
2016-01-12 02:58:50 +09:00
Cheng Zhao
c7a89b6e29 Merge pull request #4058 from kyku/master
Pass --touch-devices to chromium contents under X11
2016-01-11 22:57:00 +08:00
Cheng Zhao
9e82334b67 Merge pull request #4057 from princejwesley/browser-window
Return null for no focused window when calling BrowserWindow.getFocusedWindow
2016-01-11 22:53:38 +08:00
Cheng Zhao
192fa4c86b Cleanup docs and code of setProxy 2016-01-11 22:45:34 +08:00
Cheng Zhao
34c9279fc5 Merge pull request #4046 from deepak1556/session_proxy_patch
session: allow user to isolate pac script and proxy bypass rules
2016-01-11 21:49:15 +08:00
Cheng Zhao
a1da3c278b Merge pull request #4056 from cdaringe/patch-1
Specify enumerable property accessibility
2016-01-11 21:42:54 +08:00
Cheng Zhao
b25435c465 Merge pull request #4054 from yamatoya/master
Add Japanese translation documentation for faq and tutorial
2016-01-11 21:42:10 +08:00
Cheng Zhao
26bd97d6cf Fix style issues of #4029 2016-01-11 21:12:07 +08:00
Cheng Zhao
edcd34d4ce Merge pull request #4029 from leethomas/show-message-box-default-button
Show message box default button
2016-01-11 20:58:03 +08:00
Cheng Zhao
e3d3cd1198 docs: Update link of VS Community
Also fix the version of VS requried.

Close #3962.
2016-01-11 20:52:32 +08:00
Krzysztof
440c588a33 Pass --touch-devices to chromium contents under X11 2016-01-11 12:23:53 +01:00
Cheng Zhao
91ca84d106 Merge pull request #4050 from etiktin/cosmetic
Remove unneeded extra semicolons (;; -> ;)
2016-01-11 15:41:06 +08:00
Cheng Zhao
fe45a4ac98 Merge pull request #4048 from etiktin/fix_win_failing_test
Fix failing test on Windows
2016-01-11 15:40:08 +08:00
Prince J Wesley
018ae5189b Return null for no focused window when calling BrowserWindow.getFocusedWindow() 2016-01-11 12:58:44 +05:30
Robo
8557cd223c maintain api compatibility 2016-01-11 12:24:01 +05:30
Cheng Zhao
33b7b774c1 docs: Notification on Windows can use http:// icon now 2016-01-11 14:41:38 +08:00
Cheng Zhao
1944472c2f docs: Make win.getNativeWindowHandle more clear 2016-01-11 13:43:24 +08:00
Cheng Zhao
54e1d7b3bf Merge pull request #4023 from omrilitov/master
Added getNativeWindowHandle method
2016-01-11 13:32:29 +08:00
Cheng Zhao
76a34a27ea Merge pull request #4055 from atom/backport-1500713003
Backport https://codereview.chromium.org/1500713003
2016-01-11 13:24:55 +08:00
大和屋 貴仁
630819e1d6 Merge branch 'master' of https://github.com/atom/electron 2016-01-11 14:12:43 +09:00
Christopher Dieringer
12f5e5072d Specify enumerable property accessibility 2016-01-10 21:02:07 -08:00
Cheng Zhao
1de9cfd4eb Backport https://codereview.chromium.org/1500713003 2016-01-11 12:59:02 +08:00
大和屋 貴仁
4f1be903c4 Fix a document 2016-01-11 13:19:14 +09:00
Cheng Zhao
20a92d7d1e Merge pull request #4044 from j5a/translate_docs_into_japanese
Update docs-translations/jp/tutorial/quick-start.md
2016-01-11 12:06:39 +08:00
Cheng Zhao
7bec597ea0 Merge pull request #4042 from ZhangYueqiu/patch-1
Update supported-platforms.md
2016-01-11 12:06:16 +08:00
Plusb Preco
373bed33c5 📝 Update as upstream
[ci skip]
2016-01-11 12:04:48 +08:00
大和屋 貴仁
595a3469d9 Add Japanese translation documentation for faq and tutorial 2016-01-11 13:03:37 +09:00
Cheng Zhao
1ee565ab81 Merge pull request #4030 from lukeapage/patch-4
Correct misleading sentence on progress for transparent click through
2016-01-11 11:21:18 +08:00
leethomas
fee301e768 follow style guidelines 2016-01-10 19:15:40 -08:00
Cheng Zhao
0f2c35e2b8 Merge pull request #4052 from atom/right-way-to-fix-path
Change brightray's PATH_START to 11000
2016-01-11 11:04:06 +08:00
Cheng Zhao
adcdf123af Change brightray's PATH_START to 11000 2016-01-11 10:40:45 +08:00
Cheng Zhao
da52017d82 Revert "fix chrome app and user path conflicts"
This reverts commit 25aaafde45.
2016-01-11 10:30:17 +08:00
Eran Tiktin
29939dc0b7 Remove unneeded extra semicolons (;; -> ;) 2016-01-11 02:11:40 +02:00
leethomas
803b06b7de 🏁 support defaultId for dialog boxes on Windows 2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11 rename all references to default_button_index -> default_id to keep consistent with cancel_id 2016-01-10 15:33:27 -08:00
Eran Tiktin
f1d388fb36 Fix failing test on Windows
The exit code tests include an assert on the output we get from a
spawned electron process. This doesn't currently work on Windows, so we
skip it for now
2016-01-11 01:33:22 +02:00
Robo
be50ca2653 session: allow user to isolate pac script and proxy bypass rules 2016-01-11 03:55:56 +05:30
Joe Naha
8b07918650 📝 Update to follow the latest version.
[ci skip]
2016-01-11 04:00:03 +09:00
ZhangYueqiu
56d1235bbd Update supported-platforms.md
Change a wrong word
2016-01-10 15:43:25 +08:00
Eran Tiktin
c5dee6a3d8 Merge pull request #10 from atom/master
Update from upstream
2016-01-10 01:46:26 +02:00
Omri Litov
a4636ba18c Update browser-window.md 2016-01-08 20:53:59 +02:00
leethomas
dfce803045 🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it 2016-01-08 08:23:06 -08:00
leethomas
c4c145ef6a 📝 add defaultButtonIndex to dialog docs 2016-01-08 08:22:11 -08:00
leethomas
22c455175a 🐧 add default button index for linux/gtk 2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f 🍎 add default button index for osx 2016-01-08 08:21:54 -08:00
Luke Page
6728d9291d Correct misleading sentence on progress for transparent click through 2016-01-08 10:56:51 +00:00
Cheng Zhao
df27cda36c Bump v0.36.3 2016-01-08 13:40:47 +08:00
Cheng Zhao
9a707b7c69 Merge pull request #4027 from atom/fix-locale
Fix loading locale on OS X
2016-01-08 13:32:53 +08:00
Cheng Zhao
5514e89276 Copy locales in Cocoa format 2016-01-08 12:38:00 +08:00
Cheng Zhao
ec4c5e58ff Initialize resource bundle on browser process separately 2016-01-08 12:06:06 +08:00
Cheng Zhao
5f6a8a7c24 Merge pull request #4009 from atom/remove-getobject-handler
Remove custom WM_GETOBJECT handler
2016-01-08 09:55:24 +08:00
Omri Litov
943e46f3bd Fix linux and mac build errors 2016-01-08 00:27:53 +02:00
Omri Litov
224955d6ac Update browser-window.md 2016-01-07 23:17:23 +02:00
Omri Litov
3f0c007578 Added getNativeWindowHandle 2016-01-07 22:38:35 +02:00
Cheng Zhao
9e254821bb docs: Mention the limitation of globalShortcut
Close #3816.
2016-01-07 21:28:14 +08:00
Cheng Zhao
0d799601d7 Merge pull request #4018 from imiuka/faq-link
update faq link
2016-01-07 20:34:13 +08:00
Cheng Zhao
3d908f1483 docs: Mention third party packing tools
Fix #1723.
2016-01-07 20:32:57 +08:00
Cheng Zhao
04d626f0b0 docs: Document the display object
Fix #3571.
2016-01-07 20:21:11 +08:00
foxy
e323c6dad9 update faq link 2016-01-07 22:26:21 +11:00
Cheng Zhao
3a32dc5da7 Fix "name" of Error object not serialized
Close #3364.
2016-01-07 16:35:05 +08:00
Cheng Zhao
24779a8589 Merge pull request #4016 from atom/el-capitan-fullscreen
Fix hiding fullscreen button on EL Capitan
2016-01-07 16:24:35 +08:00
Cheng Zhao
10f663d017 Fix hiding fullscreen button on EL Capitan 2016-01-07 15:46:40 +08:00
Cheng Zhao
ae6c2d46b8 Merge pull request #4014 from atom/blink-features
Add blinkFeatures option
2016-01-07 14:58:10 +08:00
Cheng Zhao
c0e728ab6a docs: Orgnize the options of BrowserWindow 2016-01-07 14:23:21 +08:00
Cheng Zhao
3f2b26ddb7 Add blinkFeatures option 2016-01-07 14:10:18 +08:00
Cheng Zhao
bd20b3f32a Rely on content switches for implementing experimental features 2016-01-07 12:49:00 +08:00
Cheng Zhao
16d23bbda5 Remove pageVisibility option
The original purpose of this option is not working anymore, also adds
docs on the current way to disable process backgrounding.
2016-01-07 12:28:20 +08:00
Cheng Zhao
c6e03f8390 Remove overlayScrollbars and sharedWorker options
They are already enabled by default.
2016-01-07 12:17:19 +08:00
Paul Betts
705001a50e Remove custom WM_GETOBJECT
As of Chromium 47 this seems to be handled automatically, nvda still reports
elements and the typing lag issue described in #4001 is fixed
2016-01-06 10:37:12 -08:00
Cheng Zhao
3ca5b0ce23 win: Don't change transparent window's style
Close #1952.
2016-01-06 23:02:33 +08:00
Cheng Zhao
0c287d0424 Merge pull request #4007 from atom/fix-offiline-protocol
Fix crash when request failed
2016-01-06 22:21:52 +08:00
Cheng Zhao
e6b9b0e5dc Merge pull request #4006 from DerNivel/patch-1
Update debugging-main-process.md
2016-01-06 22:11:11 +08:00
Levin Rickert
062253bdfc Update debugging-main-process.md 2016-01-06 14:43:13 +01:00
Levin Rickert
aaf5f3331a Update debugging-main-process.md 2016-01-06 14:41:51 +01:00
Cheng Zhao
89fccb7eb2 Fix crash when request failed 2016-01-06 21:07:07 +08:00
Cheng Zhao
aefddc0146 Merge pull request #4004 from lukeapage/patch-3
Add info on how to debug from 0.30 onwards
2016-01-06 20:37:27 +08:00
Luke Page
3259664637 Add info on how to debug from 0.30 onwards 2016-01-06 07:13:25 +00:00
Cheng Zhao
4401991e15 Merge pull request #4003 from atom/asar-mkdir
Throw ENOTDIR when calling mkdir inside asar archive
2016-01-06 13:10:24 +08:00
Cheng Zhao
9a55021609 spec: Fix failing specs on Windows 2016-01-06 12:27:12 +08:00
Cheng Zhao
c4071a7f66 Throw ENOTDIR when calling mkdir inside asar archive 2016-01-06 12:04:16 +08:00
Cheng Zhao
ace7c62e5e Merge pull request #3997 from leethomas/fix-tray-icon-toggle
:apple:🐛 make displaying alternate tray image depend on mouse dow…
2016-01-06 11:04:40 +08:00
Plusb Preco
bf327cf5f0 📝 Update as upstream
[ci skip]
2016-01-06 10:52:46 +08:00
Cheng Zhao
99e2871be1 Merge pull request #3992 from atom/faqs
Add FAQ
2016-01-06 10:40:51 +08:00
leethomas
59eda67ba4 :apple:🐛 make displaying alternate tray image depend on mouse down event instead of highlight state 2016-01-05 09:49:27 -08:00
Cheng Zhao
554bb69101 Add FAQ 2016-01-05 19:57:15 +08:00
Cheng Zhao
5f0be5636a Merge pull request #3987 from atom/dialog
Do not write our own filter code
2016-01-05 14:13:28 +08:00
Cheng Zhao
2b6ac966c0 Do not write our own filter code
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
96c8bd677b Merge pull request #3986 from atom/fix-menu
Fix problems of window menu bar
2016-01-05 12:38:24 +08:00
Cheng Zhao
698700716b Show menu by clicking the menu button 2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7 Do not behave like bookmarkbar menu 2016-01-05 11:57:58 +08:00
Cheng Zhao
48451032e3 Update brightray to fix menu not loading resources 2016-01-05 10:22:42 +08:00
Cheng Zhao
88ba4fb36a Merge pull request #3983 from atom/fix-capture-page
Fix distorted image when calling `capturePage` with no rect
2016-01-04 20:52:17 +08:00
Cheng Zhao
0df03a23a3 Pass origin in capturePage 2016-01-04 20:06:36 +08:00
Cheng Zhao
7a1717156e Revert "browser: dont lose coordinates in capturepage src rect"
This reverts commit 3c5e5053e3.
2016-01-04 19:37:25 +08:00
Cheng Zhao
9f40309487 Merge pull request #3981 from atom/did-navigate
Rename did-navigate-to-different-page to did-navigate
2016-01-04 12:32:59 +08:00
Cheng Zhao
4844e68ba1 Rename did-navigate-to-different-page to did-navigate 2016-01-04 12:09:11 +08:00
Cheng Zhao
941232a76b Merge pull request #3975 from leethomas/add-webview-navigation-events
Add webview navigation events
2016-01-04 11:24:27 +08:00
Cheng Zhao
cf09e7cb51 Update libchromiumcontent for #3958 2016-01-04 10:59:52 +08:00
Cheng Zhao
6ff79eddb4 Merge pull request #3958 from deepak1556/content_strings_localzation_patch
browser: provide localized string from resourcebundle
2016-01-04 10:59:09 +08:00
Cheng Zhao
14db4a1946 Add isDevToolsFocused to webview 2016-01-04 10:46:30 +08:00
Cheng Zhao
4cdee5547f Merge pull request #3974 from leethomas/fix-devtools-api
Fix devtools api
2016-01-04 10:41:33 +08:00
Plusb Preco
ef58c6d36b 📝 Update as upstream
* Update as upstream
* Add `using-widevine-cdm-plugin.md`
2016-01-04 10:25:33 +08:00
leethomas
ce733e5927 add tests to insure window.location.hash changes & window.history.replaceState cause 'did-navigate-in-page' to fire 2016-01-01 18:51:47 -08:00
leethomas
26397d9155 add tests for will-navigate, did-navigate-to-different-page, did-navigate-in-page events in webview 2016-01-01 18:13:07 -08:00
leethomas
9e2b76361f 📝 add 'did-navigate-in-page', 'did-navigate-to-different-page', 'will-navigate' to docs 2016-01-01 17:22:25 -08:00
leethomas
911e60b507 add did-navigate-in-page event to webview & webcontents (triggers on hash/ref changes, anchor links...), pass url into events 2016-01-01 17:13:39 -08:00
leethomas
9f6319dd71 add will-navigate, did-navigate-to-different-page events to webview 2016-01-01 13:36:35 -08:00
leethomas
54c8c3e3fc 📝 update webview docs to include devtools-* events 2016-01-01 04:49:34 -08:00
leethomas
8857eb9cba add tests for webview devtools-* events 2016-01-01 04:49:29 -08:00
leethomas
96d68b9285 🐛 add isDevToolsFocused to WebContents to fix #3928, add devtools-[focused|open|close] events to WebView to fix #3783. 2015-12-31 22:21:54 -08:00
Cheng Zhao
8aced2c31e Add comment on why checking empty set 2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96 Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
Cheng Zhao
be2f900d93 Merge pull request #3968 from leethomas/fix-window-submenu-crashes
🍎 only add sub menus to Window when they actually have menu ite…
2015-12-31 18:51:45 +08:00
Cheng Zhao
af5e76f6ae Merge pull request #3959 from deepak1556/remote_object_patch
remote: support arguments of type Date
2015-12-31 18:46:22 +08:00
leethomas
eac2f6fec3 🍎 only add sub menus to Window when they actually have menu items. fixes #3873 2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6 🍎 fix #3864 where saving a file causes a crash if file extension array is empty 2015-12-30 13:26:38 -08:00
Cheng Zhao
d4de4505b8 Merge pull request #3961 from atom/widevine-docs
Add documentation for using Widevine plugin
2015-12-30 16:46:31 +08:00
Cheng Zhao
b3832629a2 Update libchromiumcontent: component_updater is not needed 2015-12-30 16:14:50 +08:00
Cheng Zhao
fe87570876 docs: Using Widevine CDM Plugin 2015-12-30 16:10:00 +08:00
Robo
1585a7a0ad browser: provide localized string from resourcebundle 2015-12-30 10:58:46 +05:30
Cheng Zhao
cb5d79e0df Merge pull request #3957 from atom/widevine
Merge #3830
2015-12-30 12:46:19 +08:00
Cheng Zhao
82a293a132 Merge pull request #3955 from nishanths/feature/osx-clear-recent-docs
osx: Implement clear recent documents
2015-12-30 12:07:41 +08:00
Cheng Zhao
d8d3a56c25 Merge pull request #3926 from adam-lynch/patch-3
Fixing link to web contents from ipcMain
2015-12-30 12:00:35 +08:00
Plusb Preco
1f7d72bcc0 📝 Update as upstream
[ci skip]
2015-12-30 11:57:57 +08:00
Cheng Zhao
c5238bb8f0 Update brightray and libchromiumcontent with widevine support 2015-12-30 11:45:39 +08:00
Nishanth Shanmugham
20d03b10d9 osx: Implement clear recent documents
Fixes #3932
2015-12-29 18:36:16 -06:00
Robo
72374b6e31 remote: support arguments of type Date 2015-12-30 01:41:31 +05:30
Adam Lynch
4fd08cccb4 Fixing link to web contents from ipcMain 2015-12-29 16:30:00 +00:00
Cheng Zhao
c47aebaeb4 Do not ship widevine plugin 2015-12-29 21:38:01 +08:00
Cheng Zhao
c0f0685296 Merge pull request #3944 from nishanths/feature/tray-file-drop-osx-dock
tray: Support file-drop from OS X Dock
2015-12-29 19:59:24 +08:00
Cheng Zhao
b392aeb16a Merge pull request #3945 from deepak1556/web_frame_api_patch
webFrame: support fetch api for schemes that are privileged.
2015-12-29 19:48:50 +08:00
Cheng Zhao
c76db0ba1d Fix coding styles 2015-12-29 18:59:27 +08:00
Robo
2e78aba090 webFrame: support fetch api for schemes that are privileged. 2015-12-29 15:57:59 +05:30
Nishanth Shanmugham
2bbf86c524 tray: Support file-drop from OS X Dock
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).

References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403

However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cheng Zhao
8ca1bea58b Do not link with unnecessary libraries 2015-12-29 15:45:34 +08:00
Cheng Zhao
38adaf5b3c Remove hacky build settings 2015-12-29 14:51:00 +08:00
Cheng Zhao
19ab68abfb Update libchromiumcontent to include widevine libraries 2015-12-29 14:51:00 +08:00
Cyrille Lebeaupin
9d878ad6b2 Add widevine third party
Add 2 new command options to use widevine:
- widevine-cdm-path: Path to widevine plugin
- widevine-cdm-version: Version of the widevine plugin
2015-12-29 14:50:59 +08:00
Cheng Zhao
5f3c6107d5 Merge pull request #3942 from atom/remote-memory-leak
Fix memory leak in remote module
2015-12-29 11:03:34 +08:00
Cheng Zhao
2294a5ce69 Leak FunctionTemplateHandle
They are cached through the app's lifetime, and freeing them at the
right time is complicate, so just leak them.
2015-12-29 10:40:10 +08:00
Cheng Zhao
d8d963b780 Cache function templates created by CreateObjectWithName 2015-12-29 10:29:48 +08:00
Cheng Zhao
ffc2870ccb Fix circular reference caused by Object.defineProperty 2015-12-29 10:17:35 +08:00
Cheng Zhao
3d2163230b Optimize the case when creating plain object 2015-12-28 22:51:40 +08:00
Cheng Zhao
6785870dde Variables are not shadowed in inline class 2015-12-28 22:51:40 +08:00
Cheng Zhao
b5fd491c2d Fix circular reference caused by RemoteMemberFunction 2015-12-28 22:51:40 +08:00
Cheng Zhao
6fe39e79f4 Merge pull request #3931 from leftstick/master
add zh-CN translation for devtools
2015-12-28 19:22:57 +08:00
Howard.Zuo
6e43be99d7 add zh-CN translation for devtools 2015-12-28 13:10:15 +08:00
Cheng Zhao
dad2586a8a Merge pull request #3920 from flaub/patch-1
s/Phrase/Phase
2015-12-28 09:58:40 +08:00
Frank Laub
ab53e04a80 s/Phrase/Phase 2015-12-24 23:04:44 -08:00
Cheng Zhao
9ffe502fb1 Bump v0.36.2 2015-12-25 13:45:07 +08:00
Cheng Zhao
fb032b03b0 Merge pull request #3918 from deepak1556/renderer_process_fork_patch
renderer: dont fork the process when there is server redirect
2015-12-25 13:43:34 +08:00
Plusb Preco
2f99a1ac8e 📝 Update as upstream
[ci skip]
2015-12-25 12:20:08 +08:00
Cheng Zhao
26f9f83cfd Upgrade brightray for atom/brightray#188 2015-12-25 11:57:35 +08:00
Robo
ab9d1bf97e renderer: dont fork the process when there is server redirect 2015-12-25 02:19:56 +05:30
Cheng Zhao
f5a093db58 Merge pull request #3915 from juanpaulo/master
Removed unnecessary backtick
2015-12-24 20:11:59 +08:00
Cheng Zhao
673c6e6917 Upgrade brightray for #3866 2015-12-24 20:08:16 +08:00
Juan Paulo Gutierrez
67e19cac85 Removed unnecessary backtick. 2015-12-24 20:22:22 +09:00
Cheng Zhao
7f02e0a716 spec: Surppess did-change-theme-color test
It is too flaky.
2015-12-24 19:05:28 +08:00
Cheng Zhao
405aadc7d8 Merge pull request #3914 from atom/fix-remvoe-headers
onBeforeSendHeaders should reset the whole headers
2015-12-24 18:39:04 +08:00
Cheng Zhao
c36ae86fab spec: Increase timeout for window.open 2015-12-24 17:08:32 +08:00
Cheng Zhao
2b5c91bbb5 spec: onBeforeSendHeaders should reset the whole headers 2015-12-24 17:02:30 +08:00
Cheng Zhao
e96f89133c Reset whole headers when requestHeaders is set 2015-12-24 16:59:13 +08:00
Cheng Zhao
6aa3464aad Merge pull request #3912 from tylergibson/FixingMoveItemToTrash-Windows7
Adding check for Windows version and alternate flags for Windows Vista/7
2015-12-24 15:32:09 +08:00
Tyler Gibson
2d0e1c313a Adding check for Windows version and alternate flags for Windows Vista/7 2015-12-24 06:08:43 +00:00
Cheng Zhao
e41dad5153 Merge pull request #3913 from atom/fix-nsurl
Fix converting string to NSURL
2015-12-24 13:06:08 +08:00
Cheng Zhao
7bd9f2e5d0 Fix converting string to NSURL 2015-12-24 12:43:07 +08:00
Cheng Zhao
aa85258d56 Merge pull request #3911 from atom/fix-alt
linux: Fix pressing Alt not toggling window menu bar
2015-12-24 12:10:07 +08:00
Cheng Zhao
d3d8ab7c66 linux: Fix pressing Alt not toggling window menu bar 2015-12-24 11:43:14 +08:00
Cheng Zhao
c9fafc0c3a Merge pull request #3910 from atom/no-ship-libnotify
No longer need to ship with libnotify.so
2015-12-24 11:37:52 +08:00
Cheng Zhao
8b88c99685 No longer need to ship with libnotify.so 2015-12-24 11:17:32 +08:00
Cheng Zhao
046839cb56 Update brightray for #2294 2015-12-24 11:16:46 +08:00
Cheng Zhao
9e9d74a5a4 Merge pull request #3905 from fscherwi/patch-2
upgrade asar
2015-12-24 10:14:16 +08:00
fscherwi
3cdd5dd418 ⬆️ asar 2015-12-23 19:08:51 +01:00
Cheng Zhao
a6074f89a3 Merge pull request #3900 from bbondy/theme-color
Theme color
2015-12-23 16:09:57 +08:00
Cheng Zhao
7f1081a594 Merge pull request #3904 from atom/hidden-inset-no-visual-artifacts
Fix visual artifacts of hidden-inset window
2015-12-23 13:14:50 +08:00
Cheng Zhao
e90435e236 Remove visual artifacts of hidden-inset window 2015-12-23 12:38:11 +08:00
Brian R. Bondy
29b00ae0d6 Add tests for did-change-theme-color event 2015-12-22 23:05:03 -05:00
Cheng Zhao
79b507bda6 Merge pull request #3890 from jaanus/hidden-inset-fullscreen-fix
Fixes #2810: correct look of hidden-inset windows in full screen.
2015-12-23 11:26:06 +08:00
Cheng Zhao
a1936ecf82 Merge pull request #3903 from atom/fix-webrequest-crash
Fix crash when using webRequest API
2015-12-23 10:44:19 +08:00
Cheng Zhao
3e1edfc9d0 Cancel callback in OnComplete event 2015-12-23 10:20:59 +08:00
Brian R. Bondy
11b2015535 Add did-change-theme-color event to webview 2015-12-22 17:28:22 -05:00
jaanus
aa2f7aaf3a Fixes #2810: correct look of hidden-inset windows in full screen.
`hidden` and `hidden-inset` windows differ only by the hidden-inset window having a toolbar. Yet, the toolbar yields an incorrect look in fullscreen mode. So, we hide and recreate the toolbar for such windows when going to/from fullscreen.

There are some visible artifacts during the fullscreen animations, as the toolbar gets created and destroyed. When entering fullscreen, you see a toolbar that then disappears. When going back to normal window, you see the traffic light buttons jump around a little bit. Yet, this is definitely better than the current broken fullscreen look.
2015-12-22 20:31:55 +02:00
Cheng Zhao
c8c4381085 Cancel callback when URLRequest is destroyed 2015-12-22 23:35:23 +08:00
Cheng Zhao
e14d472934 Merge pull request #3892 from jasssonpet/patch-1
Formatting app.md
2015-12-22 19:16:04 +08:00
Plusb Preco
9aa37580e3 📝 Update as upstream
[ci skip]
2015-12-22 19:11:29 +08:00
Cheng Zhao
c4931bb2d1 Merge pull request #3865 from deepak1556/visibility_api_patch
browser: fix document.hidden value
2015-12-22 19:04:23 +08:00
Cheng Zhao
8ca42e9d9f Merge pull request #3855 from deepak1556/find_api_patch
webContents: adding findInPage api
2015-12-22 19:01:39 +08:00
Jason Zhekov
2f732a7c0f Formatting app.md
This looks a bit odd on the site: http://electron.atom.io/docs/v0.36.0/api/app/#app-setusertasks-tasks-windows
2015-12-22 09:04:36 +02:00
Robo
61004f0e46 fix cpplint warning 2015-12-21 19:16:02 +05:30
Robo
cc7040d75f add test 2015-12-21 18:47:52 +05:30
Robo
ff51e4033a browser: fix value of document.hidden 2015-12-21 17:43:46 +05:30
Robo
d162180196 add api to webview 2015-12-21 17:13:23 +05:30
Robo
39e615ed87 webContents: adding findInPage api 2015-12-21 17:09:56 +05:30
Cheng Zhao
c68e38f480 Merge pull request #3882 from deepak1556/chromium_spec_patch
spec: serviceWorker registration with file scheme
2015-12-21 18:39:18 +08:00
Cheng Zhao
144b73c267 Merge pull request #3877 from bbondy/master
Add media play events to webview
2015-12-21 18:22:30 +08:00
Cheng Zhao
fa8d251370 Merge pull request #3875 from deepak1556/history_navigation_patch
navigaton: handle history operations from renderer
2015-12-21 18:18:45 +08:00
Cheng Zhao
b269485d37 Merge pull request #3867 from WenryXu/master
docs: Fix markdown code language
2015-12-21 14:38:41 +08:00
Cheng Zhao
d08b7fdb5d Merge pull request #3880 from adam-lynch/patch-1
Desktop Environment Integration: typo
2015-12-21 11:33:21 +08:00
Cheng Zhao
3fcfe24b82 Merge pull request #3881 from adam-lynch/patch-2
Desktop Environment Integration: rearranged sentence
2015-12-21 11:33:14 +08:00
Plusb Preco
6c26aa8d05 📝 Update as upstream
[ci skip]
2015-12-21 11:31:38 +08:00
Cheng Zhao
99a661e2d2 Code cleanup of browser_mac.mm 2015-12-21 10:52:49 +08:00
Cheng Zhao
8d094d99da Merge pull request #3853 from jrehbein/fix-issue-3739-mac-dockshow
DockShow workaround for issue #3739
2015-12-21 10:38:52 +08:00
Cheng Zhao
3b3c5a0edb Update brightray for #3831 2015-12-21 10:09:20 +08:00
Robo
68733eb8df spec: serviceWorker registration with file scheme 2015-12-21 01:32:08 +05:30
Adam Lynch
520b537362 Desktop Environment Integration: rearranged sentence 2015-12-20 18:34:57 +00:00
Adam Lynch
da9c202d86 Desktop Environment Integration: typo 2015-12-20 18:34:05 +00:00
Brian R. Bondy
fed0c43970 Add media play events to webview 2015-12-19 22:37:51 -05:00
Robo
7b03ac6d61 navigaton: handle history operations from renderer 2015-12-20 01:23:47 +05:30
WenryXu
7e0775f9d7 docs: Fix markdown code language 2015-12-19 14:27:47 +08:00
Cheng Zhao
bff2861311 Bump v0.36.1 2015-12-18 13:16:30 +08:00
Cheng Zhao
7d66b37901 Merge pull request #3859 from atom/phantom-callback
Update node: Use phantom callback in CallbackInfo
2015-12-18 13:15:56 +08:00
Cheng Zhao
62c4a471d9 Merge pull request #3854 from deepak1556/browser_client_crash_patch
browser: check for rvh existence
2015-12-18 12:10:41 +08:00
Cheng Zhao
cefce45ffa Update node: Use phantom callback in CallbackInfo 2015-12-18 12:00:10 +08:00
Cheng Zhao
4ad79b2a8c docs: Standarize the "(**required**)" 2015-12-18 11:12:48 +08:00
Cheng Zhao
d5168f09d6 docs: Use "(optional)" instead of "__optional__" 2015-12-18 11:12:48 +08:00
Cheng Zhao
d7946b9c41 Merge pull request #3851 from preco21/master
Update as upstream
2015-12-18 09:53:45 +08:00
Cheng Zhao
7d000807c5 Merge pull request #3849 from herrmannplatz/improvement/escape-url-openexternal
escape url string
2015-12-18 09:45:39 +08:00
Cheng Zhao
177cfd9958 Revert "Upgrade node to fix crash in Buffer"
This reverts commit fe9c09ef64.
2015-12-18 09:19:13 +08:00
Robo
836c13b330 browser: check for rvh existence 2015-12-18 04:45:32 +05:30
Jeff Rehbein
a39834740c DockShow workaround
Implemented workaround in DockShow for TransformProcessType bugginess
based on discussion at http://stackoverflow.com/questions/7596643/
2015-12-17 14:00:04 -06:00
Plusb Preco
ac92917353 📝 Update as upstream
[ci skip]
2015-12-18 03:10:08 +09:00
rehez
9eb797296c escape url string 2015-12-17 16:23:30 +01:00
Cheng Zhao
fe016d393f Merge pull request #3848 from atom/no-sync-message-on-start
Remove usages of synchronous messages on startup
2015-12-17 22:31:33 +08:00
Cheng Zhao
353f08e477 Remove sync call in remote module 2015-12-17 22:03:16 +08:00
Cheng Zhao
0282d424bf Pass opener ID in command line 2015-12-17 21:27:14 +08:00
Cheng Zhao
c7bfd5f09d Upgrade libchromiumcontent: enable sending sync message to UI thread 2015-12-17 20:12:05 +08:00
Cheng Zhao
afedce0b18 docs: |options| is not optional
Close #3845.
2015-12-17 18:40:52 +08:00
Cheng Zhao
19835cf346 Merge pull request #3844 from atom/fix-node-crash
Upgrade node to fix crash in Buffer
2015-12-17 15:04:03 +08:00
Cheng Zhao
fe9c09ef64 Upgrade node to fix crash in Buffer 2015-12-17 13:07:41 +08:00
Cheng Zhao
b7cbc49c01 Merge pull request #3833 from atom/no-renderer-pump
Don't pump message loop when sending sync msg
2015-12-16 23:38:43 +08:00
Cheng Zhao
71303d4804 Fix context menu not working in devtools 2015-12-16 22:57:03 +08:00
Cheng Zhao
c6634b1ea5 Don't pump message loop when sending sync msg
In old days sending sync message to browser process requires pumping
message loop in the renderer process, but now in Chrome 47 it is not
true anymore. And even when we do it, the Send method may fail
sometimes, so this change seems to be required for the Chrome 47
upgrade.
2015-12-16 22:38:04 +08:00
Cheng Zhao
349f401476 Merge pull request #3829 from atom/remote-xpc-call
Update libchromiumcontent
2015-12-16 19:42:04 +08:00
Cheng Zhao
a29abf1e34 Update libchromiumcontent
Remove usages of private xpc_ APIs, fix #3823.
2015-12-16 18:06:47 +08:00
Cheng Zhao
2b4e6080a8 Merge pull request #3826 from atom/remote-crash-reporting-defaults
Require submitURL and companyName options to crashReporter.start
2015-12-16 12:02:28 +08:00
Cheng Zhao
c39a6c49de Merge pull request #3825 from atom/maxogden-patch-1
mention getUserMedia options in desktop-capturer docs
2015-12-16 11:30:05 +08:00
Cheng Zhao
bc33b4e594 Merge pull request #3822 from hashedhyphen/support-strict-mode
🐛 Support strict mode on Tutorial
2015-12-16 11:13:26 +08:00
Kevin Sawicki
d863fd5c6c Set process.throwDeprecation as early as possible 2015-12-15 17:02:33 -08:00
Kevin Sawicki
5fb5526b06 Improve spec description 2015-12-15 16:49:19 -08:00
Kevin Sawicki
67c0de36a3 📝 Add missing period 2015-12-15 16:47:19 -08:00
Kevin Sawicki
d44a9d1fcc 🎨 Remove parens 2015-12-15 16:46:53 -08:00
Kevin Sawicki
aedfd3bf0e Add specs for companyName/submitURL being required 2015-12-15 16:44:38 -08:00
Kevin Sawicki
80e9631220 Use better signature match in deprecation message 2015-12-15 16:27:01 -08:00
Kevin Sawicki
4718c726f6 Remove starting crash reporter from quick start 2015-12-15 16:24:24 -08:00
Kevin Sawicki
524649797f Make companyName and submitURL required options 2015-12-15 16:22:31 -08:00
Kevin Sawicki
dcc99dd5cb Remove duplicate start calls 2015-12-15 16:10:04 -08:00
Kevin Sawicki
58106e53c8 Mark companyName and submitURL as required 2015-12-15 16:09:01 -08:00
=^._.^=
c98db82668 mention getUserMedia options in desktop-capturer docs 2015-12-15 14:07:55 -08:00
Hashed Hyphen
e729104d00 🐛 Support strict mode on Tutorial
[ci skip]
2015-12-16 00:52:14 +09:00
Cheng Zhao
063231cf0c Merge pull request #3819 from preco21/master
Update as upstream
2015-12-15 22:40:09 +08:00
Cheng Zhao
8d2a41a987 Merge pull request #3818 from atom/fix-add-recent-document-crash
Fix crash when passing invalid path to addRecentDocument
2015-12-15 18:28:04 +08:00
Plusb Preco
2470ff1b14 📝 Update as upstream
[ci skip]
2015-12-15 18:45:13 +09:00
Cheng Zhao
d0962b1a93 Fix crash when passing empty path to addRecentDocument 2015-12-15 17:17:24 +08:00
Cheng Zhao
02e0c169a2 Merge pull request #3815 from bjrmatos/master
Add A5 Page Size to printToPDF
2015-12-15 16:55:17 +08:00
Cheng Zhao
dcd71cb835 Merge pull request #3817 from atom/fix-node-crash
Upgrade node, fix #3786
2015-12-15 16:54:24 +08:00
Cheng Zhao
6347f0e321 Upgrade node, fix #3786 2015-12-15 16:25:44 +08:00
Cheng Zhao
8ddf4da9ad Merge pull request #3809 from deepak1556/capture_page_api_patch
browser: dont lose coordinates in capturepage src rect
2015-12-15 15:33:02 +08:00
Cheng Zhao
e7090887d9 Merge pull request #3812 from atom/make-opener-a-proxy
Make window.opener a BrowserWindowProxy
2015-12-15 15:01:28 +08:00
BJR Matos
86bf7341b7 Add A5 Page Size to printToPDF 2015-12-14 23:28:25 -05:00
Kevin Sawicki
aa9c7662a3 Inline JSON message response 2015-12-14 17:09:31 -08:00
Kevin Sawicki
d1989b3624 Mention source in spec description 2015-12-14 17:02:58 -08:00
Kevin Sawicki
b8de1bd9de Assert that source id matches opener 2015-12-14 17:02:36 -08:00
Kevin Sawicki
d133553c6a Remove unused ipc event handler 2015-12-14 16:58:32 -08:00
Kevin Sawicki
c5936a024d Remove unneeded custom postMessage on window.opener 2015-12-14 16:54:26 -08:00
Kevin Sawicki
184b11be4c Use id from source window when building proxy for event source 2015-12-14 16:47:33 -08:00
Kevin Sawicki
0ef0ce7345 Add comment about window.opener tweaks 2015-12-14 14:57:38 -08:00
Kevin Sawicki
574eec3e74 Make window.opener a BrowserWindowProxy 2015-12-14 14:55:48 -08:00
Plusb Preco
4fa6d4aead 📝 Update as upstream
[ci skip]
2015-12-15 05:40:13 +09:00
Cheng Zhao
606fb0615f Merge pull request #3805 from andela-earinde/patch-1
Remove typo in auto-updater doc
2015-12-14 20:01:22 +08:00
Plusb Preco
bd1b6fdc74 📝 Update as upstream
[ci skip]
2015-12-14 19:18:27 +08:00
Cheng Zhao
551f07860d Merge pull request #3799 from bbondy/patch-1
Indicate that Update 5 is required for VS2013
2015-12-14 19:11:49 +08:00
Sean Francis N. Ballais
2d2ad0d33b Addeda versionin package.json. 2015-12-14 18:17:04 +08:00
Cheng Zhao
2fa7088fd1 Upgrade brightray for atom/brightray#184 2015-12-14 18:11:01 +08:00
Arinde Eniola
f48c28f22b Update auto-updater.md 2015-12-14 01:02:30 +01:00
Robo
3c5e5053e3 browser: dont lose coordinates in capturepage src rect 2015-12-14 00:52:05 +05:30
Plusb Preco
582fb6f519 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-12-13 16:37:26 +09:00
Plusb Preco
d0fe2ac904 📝 Fix confused translation
[ci skip]
2015-12-13 16:33:27 +09:00
Plusb Preco
db73647d07 Revert "📝 Update as upstream"
This reverts commit efac12ed89.
2015-12-13 16:29:18 +09:00
Brian R. Bondy
8ae99ebd1f Indicate that Update 5 is required for VS2013 2015-12-12 22:25:45 -05:00
Cheng Zhao
550830c4d9 Merge pull request #3792 from atom/backport-v8-patch
Backport https://codereview.chromium.org/1406133003
2015-12-12 22:44:10 +08:00
Cheng Zhao
0df9eeb2dd Backport https://codereview.chromium.org/1406133003 2015-12-12 22:16:28 +08:00
Plusb Preco
c6085f5178 📝 Update as upstream
[ci skip]
2015-12-12 21:41:17 +09:00
Cheng Zhao
84cea1b494 Merge pull request #3789 from atom/template-web-request
Cleanup the webRequest and cookies code
2015-12-12 16:34:10 +08:00
Cheng Zhao
10cad5d9ec Passing '' to fromPartiion should return default partition 2015-12-12 15:47:15 +08:00
Cheng Zhao
56c1f04a51 docs: Update webRequest API 2015-12-12 15:45:02 +08:00
Cheng Zhao
ab14a4466d docs: Improve the cookies docs 2015-12-12 15:41:04 +08:00
Cheng Zhao
4d1e223044 Cleanup the cookies code 2015-12-12 15:33:51 +08:00
Cheng Zhao
3c48198c3c spec: Suppress navigator.webkitGetUserMedia test
It is stressing the whole test case.
2015-12-12 15:32:49 +08:00
Cheng Zhao
9438d42322 Use generic function to handle events 2015-12-12 13:49:58 +08:00
Cheng Zhao
f976e1eda3 Add generic version for FillDetailsObject 2015-12-12 13:20:53 +08:00
Cheng Zhao
d3e723557e spec: Add test cases for webRequest 2015-12-12 11:31:19 +08:00
Cheng Zhao
fed94aada0 Make the webRequest listener asynchronous 2015-12-12 00:09:03 +08:00
Cheng Zhao
d3c8363450 EventType can not be OR'ed 2015-12-11 21:22:23 +08:00
Cheng Zhao
15cc8164b8 Use lower case for getters 2015-12-11 21:21:02 +08:00
Cheng Zhao
67886cf513 Parse filters in API code 2015-12-11 21:14:13 +08:00
Cheng Zhao
79a627014c Unify how listeners are handled 2015-12-11 21:02:44 +08:00
Cheng Zhao
9d406b695f Simpily the code that fills |details| 2015-12-11 20:40:39 +08:00
Cheng Zhao
e295eb0de7 Fix memory leak 2015-12-11 20:11:59 +08:00
Cheng Zhao
467e3b25b2 EvenTypes => EventType 2015-12-11 20:11:22 +08:00
Cheng Zhao
62f4b25cf9 Allow passing null to webRequest 2015-12-11 19:13:56 +08:00
Cheng Zhao
b7fce578d5 docs: Improve the webRequets docs 2015-12-11 19:02:56 +08:00
Cheng Zhao
98ba1a24db Merge pull request #3640 from deepak1556/webrequest_api_patch
session: add webrequest api
2015-12-11 16:56:00 +08:00
Plusb Preco
efac12ed89 📝 Update as upstream
[ci skip]
2015-12-11 14:26:01 +09:00
Cheng Zhao
9495392a1a Bump v0.36.0 2015-12-11 11:49:01 +08:00
Cheng Zhao
ced6aae6df Merge pull request #3762 from atom/run-specs-with-grep
Allow running specs with --grep option from command line
2015-12-11 11:21:57 +08:00
Laekh
fdef3d56b8 Update browser-window.md
Made it more clear on how to define BrowserWindow (outside of the main process, specifically)
2015-12-11 11:20:44 +08:00
Cheng Zhao
a6976b7d83 Merge pull request #3768 from atom/window-post-message-origin
Fix window.postMessage event.origin value
2015-12-11 11:18:37 +08:00
Cheng Zhao
6351e28f00 Merge pull request #3769 from atom/reuse-browser-window-proxies
Reuse BrowserWindowProxy objects across events
2015-12-11 11:16:42 +08:00
Kevin Sawicki
8401ece537 removeWindow -> remove 2015-12-10 17:22:05 -08:00
Kevin Sawicki
49ca7509c7 Reuse BrowserWindowProxy instances 2015-12-10 17:20:10 -08:00
Kevin Sawicki
7dfca3c293 Expect event source and opened window to be equal 2015-12-10 17:04:36 -08:00
Kevin Sawicki
dd01466f3c sequnce -> sequence 2015-12-10 17:02:35 -08:00
Kevin Sawicki
9bc7c62588 Use source origin in window.postMessage event 2015-12-10 16:52:39 -08:00
Kevin Sawicki
2cb752e3de Add failing spec for event origin 2015-12-10 16:49:23 -08:00
Kevin Sawicki
afd736d9f9 Guard against null guest or embedder
Uncaught exceptions would occur when these were null and
the target origin was '*'
2015-12-10 15:51:15 -08:00
Robo
053c77d6f4 default session should be persistent 2015-12-11 00:27:15 +05:30
Robo
658accab94 fix pointer usage 2015-12-11 00:25:25 +05:30
Kevin Sawicki
49b6e5bcac Add npm test script 2015-12-10 10:44:11 -08:00
Kevin Sawicki
065887e712 Pass through mocha invert option from test CLI 2015-12-10 10:42:07 -08:00
Kevin Sawicki
69c0a33c85 Pass mocha grep command line option through to spec app 2015-12-10 10:33:43 -08:00
Kevin Sawicki
a42fa5d5c2 Parse spec arguments using yargs library 2015-12-10 10:33:18 -08:00
Cheng Zhao
1683dd6197 Merge pull request #3759 from preco21/master
Update as upstream
2015-12-10 23:28:28 +08:00
Plusb Preco
ec16c6a146 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-12-10 23:30:55 +09:00
Plusb Preco
5f75bc36d9 📝 Update as upstream
[ci skip]
2015-12-10 23:19:50 +09:00
Cheng Zhao
a05aa81570 Merge pull request #3701 from deepak1556/protocol_post_data_patch
protocol: provide upload data when available
2015-12-10 19:38:35 +08:00
Cheng Zhao
991c8b1aa6 Merge pull request #3733 from deepak1556/service_worker_scheme_patch
protocol: api to register schemes that can handle service worker
2015-12-10 19:29:51 +08:00
Cheng Zhao
b42695a0b5 win: Don't attach console for third party terms
Close #3692.
2015-12-10 14:37:09 +08:00
Cheng Zhao
150250f3d9 Merge pull request #3752 from atom/appveyor
Run tests on Appveyor
2015-12-10 13:38:12 +08:00
Cheng Zhao
bf5c3bc9dd Avoid duplicate building for PR 2015-12-10 13:18:23 +08:00
Cheng Zhao
5cf369086c Also disable test phase 2015-12-10 13:16:22 +08:00
Cheng Zhao
f11f408420 Do not automatically build everything 2015-12-10 12:48:10 +08:00
Cheng Zhao
8c31148f7d Remove unneeded things 2015-12-10 12:35:22 +08:00
Cheng Zhao
cb806aa362 Use default node 0.12.7
Otherwise we would spend some time reinstalling node.
2015-12-10 12:23:39 +08:00
Cheng Zhao
33db4a6ac1 Run cibuild 2015-12-10 12:22:35 +08:00
Plusb Preco
966bc8408e 📝 Update as upstream
[ci skip]
2015-12-10 13:21:08 +09:00
Cheng Zhao
aa8efd90cc Bring back AppVeyor 2015-12-10 12:09:46 +08:00
Cheng Zhao
f4f4b9428d Merge pull request #3750 from atom/fullscreen-menu-item
Don't add the "Enter Full Screen" menu item automatically
2015-12-10 11:54:26 +08:00
Cheng Zhao
c180607ef6 Merge pull request #3721 from atom/emit-process-exit-event-with-code
Emit process exit event with app exit code
2015-12-10 11:39:14 +08:00
Cheng Zhao
2d940b7df7 Don't add the "Enter Full Screen" menu item automatically 2015-12-10 11:27:41 +08:00
Cheng Zhao
388a18b265 Don't emit will-quit event when calling app.exit 2015-12-10 11:22:55 +08:00
Kevin Sawicki
f5774e3fb2 Exit from a setImmediate callback 2015-12-09 18:40:10 -08:00
Kevin Sawicki
516ff0644c Just include exit code in spec output 2015-12-09 18:24:24 -08:00
Kevin Sawicki
e1654ee334 📝 Document quit event includes exit code 2015-12-09 18:22:54 -08:00
Kevin Sawicki
ea1479a651 Revert comment tweak 2015-12-09 18:20:53 -08:00
Kevin Sawicki
3e5caf7e54 Get exit code from within App::OnQuit 2015-12-09 18:19:51 -08:00
Kevin Sawicki
c4389ad70f Remove grep value setting 2015-12-09 18:12:19 -08:00
Kevin Sawicki
fc724b51e8 Move event forwarding back to init 2015-12-09 18:11:38 -08:00
Kevin Sawicki
92433be888 Include exit code with quit event 2015-12-09 18:09:59 -08:00
Kevin Sawicki
aa82eddca8 Add spec for exit code on event 2015-12-09 14:40:53 -08:00
Kevin Sawicki
63c0095efb Emit process exit event with app exit code 2015-12-09 14:40:53 -08:00
Robo
461ee49988 fix response headers modification 2015-12-09 20:14:18 +05:30
Robo
c5b5bbbeb2 add documentation 2015-12-09 20:14:18 +05:30
Robo
29f32c5ec7 support filtering event with url regex 2015-12-09 20:14:18 +05:30
Robo
13b5cab738 session: add webrequest api 2015-12-09 20:14:18 +05:30
Robo
e80a95dc37 add test 2015-12-09 20:10:57 +05:30
deepak1556
fbb5091f94 provide option to set content for POST request with url_fetcher 2015-12-09 20:10:57 +05:30
deepak1556
940289639e protocol: provide upload data when available 2015-12-09 20:10:57 +05:30
Cheng Zhao
d2e63dfc64 Use HTTPS for libchromiumcontent's URL
Without using the subdomain we should be able to work around the domain
license problem of python.
2015-12-09 18:14:37 +08:00
Cheng Zhao
f3c67586dc Merge pull request #3743 from preco21/master
Update as upstream
2015-12-09 18:10:48 +08:00
Plusb Preco
4943414274 Update as upstream
[ci skip]
2015-12-09 17:16:54 +09:00
Plusb Preco
a190b964c8 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-12-09 16:41:23 +09:00
Cheng Zhao
f7b7b3407c Update brightray for #3720 2015-12-09 12:34:10 +08:00
Cheng Zhao
0a81697116 Merge pull request #3732 from deepak1556/path_config_patch
fix chrome app and user path conflicts
2015-12-09 12:25:54 +08:00
Cheng Zhao
d4355a0533 Merge pull request #3729 from preco21/master
Update as upstream
2015-12-09 12:15:40 +08:00
Cheng Zhao
8aee0f52e9 Merge pull request #3715 from atom/do-not-edit-menu-template
Do not modify the specified menu template
2015-12-09 12:13:07 +08:00
Cheng Zhao
7bb3bf0f48 docs: win.setIgnoreMouseEvents 2015-12-09 12:05:47 +08:00
Cheng Zhao
774ba2a235 Merge pull request #3706 from billyct/master
support an api with SetIgnoreMouseEvents for osx
2015-12-09 12:00:16 +08:00
Cheng Zhao
3db78202da Merge pull request #3705 from arturts/pt-br-linux-build-instructions
📝 [ci skip] translation build instructions
2015-12-09 11:56:01 +08:00
Cheng Zhao
445b4a1834 Merge pull request #3704 from leftstick/master
add ZH-CN translation for using-selenium-and-webdriver
2015-12-09 11:43:26 +08:00
Cheng Zhao
9df0fd53a6 Merge pull request #3703 from Cfeusier/patch-1
Fix broken link in Docs > Synopsis
2015-12-09 11:43:07 +08:00
Cheng Zhao
5be45dc268 Merge pull request #3700 from arturts/pt-br-browser-window
📝 [ci skip] browser window translation
2015-12-09 11:38:39 +08:00
Cheng Zhao
2f0e732351 Merge pull request #3698 from lukeapage/patch-2
Docs: Fix link to webcontents send channel
2015-12-09 11:38:05 +08:00
Andriy Tsok
48d07423f9 Ukrainian translation (uk-UA) 2015-12-09 11:30:04 +08:00
Robo
855d49100f protocol: api to register schemes that can handle service worker 2015-12-09 03:11:58 +05:30
Robo
f77bb44952 fix chrome app and user path conflicts 2015-12-08 23:00:08 +05:30
Kevin Sawicki
8cdddcd562 Merge pull request #3726 from acburdine/patch-1
Fix grammatical error in desktop notification docs
2015-12-08 08:21:14 -08:00
Cheng Zhao
5e9aca4524 Merge pull request #3727 from atom/desktop-capture-api-continue
Merge the desktopCapturer API
2015-12-08 19:46:01 +08:00
Cheng Zhao
505193e239 Link with libyuv_neon.a on ARM 2015-12-08 18:15:01 +08:00
Cheng Zhao
9daeafbace Install libxtst-dev on travis ci 2015-12-08 17:32:42 +08:00
Cheng Zhao
9548a3801b Update brightray: Link a few more X libraries 2015-12-08 17:03:10 +08:00
Cheng Zhao
640b4c3c66 Update brightray for various linking problems 2015-12-08 16:56:20 +08:00
Cheng Zhao
98169032fd Update libchromiumcontent and brightray 2015-12-08 14:49:13 +08:00
Plusb Preco
54b62a2f31 Update as upstream
[ci skip]
2015-12-08 15:39:58 +09:00
Plusb Preco
ea2054c516 Revert "Update as upstream"
This reverts commit 06acc8b208.
2015-12-08 15:39:01 +09:00
Plusb Preco
06acc8b208 Update as upstream 2015-12-08 15:38:10 +09:00
Cheng Zhao
9eb5627225 Update clang to the same version with Chrome 47 2015-12-08 14:21:23 +08:00
Cheng Zhao
836a8b1794 Simplify the desktopCapturer code 2015-12-08 13:49:26 +08:00
Cheng Zhao
f6c9000f5f spec: Add a simple test case for desktopCapturer 2015-12-08 13:49:11 +08:00
Austin Burdine
468dd9e7c8 📝 fix grammatical error in desktop notification docs [ci skip] 2015-12-07 23:13:45 -06:00
Cheng Zhao
b517b0c598 docs: Improve docs of desktopCapturer 2015-12-08 13:09:36 +08:00
Cheng Zhao
51368952a2 Remove deprecated API usages 2015-12-08 12:58:39 +08:00
Cheng Zhao
785bc2986b Update brightray and libchromium for desktopCapturer 2015-12-08 12:47:07 +08:00
Cheng Zhao
d458b24945 Add desktopCapturer to electron 2015-12-08 12:44:55 +08:00
Cheng Zhao
04f7ceab73 Merge branch 'master' into desktop-capture-api 2015-12-08 12:43:44 +08:00
Cheng Zhao
ed2c18c724 Merge pull request #3724 from atom/node5
Upgrade to Node v5.1.1
2015-12-08 12:26:24 +08:00
Cheng Zhao
407e88cbad Update brightray 2015-12-08 12:08:33 +08:00
Cheng Zhao
da208b5155 We are now on 0.36.0 2015-12-08 11:41:47 +08:00
Cheng Zhao
0f2f9b5543 No need to use CommandDispatcher 2015-12-08 11:20:07 +08:00
Cheng Zhao
4af2190890 Upgrade to Node v5.1.1 2015-12-08 11:14:30 +08:00
Cheng Zhao
c1673eb666 Merge pull request #3714 from atom/chrome47
Upgrade to Chrome 47
2015-12-08 10:48:04 +08:00
Cheng Zhao
c63a8c944b Fix release title 2015-12-08 10:42:51 +08:00
Cheng Zhao
c3f7f2447c Update the libspeechd_loader 2015-12-08 10:26:32 +08:00
Cheng Zhao
e8b5a6dedf Merge pull request #3718 from atom/chrome47-linux
Port Chrome47 on Linux
2015-12-08 10:14:27 +08:00
Cheng Zhao
e78a02806e Make it safe to use sendSync 2015-12-08 10:07:47 +08:00
Cheng Zhao
ac2e500cf7 Merge pull request #3716 from atom/chrome47-win
Port Chrome47 on Windows
2015-12-08 09:52:50 +08:00
Paul Betts
9a0cecf943 Rig GlobalMenuBarRegistrarX11 for Atom 2015-12-07 14:30:26 -08:00
Paul Betts
fe86239a9c Update to Chrome47 version of tts_linux 2015-12-07 14:28:42 -08:00
Paul Betts
4a8d58f914 Update to Chrome47 version of GlobalMenuBarRegistrarX11 2015-12-07 14:25:52 -08:00
Paul Betts
8d5c153e9b Update to Chrome 47 version of tts_win 2015-12-07 14:23:01 -08:00
Paul Betts
af28900189 Fix up Chrome47 changes 2015-12-07 13:27:05 -08:00
Kevin Sawicki
68d937ed47 🎨 2015-12-07 11:20:15 -08:00
Kevin Sawicki
96ef09742c Directly assign submenu when constructor is Menu 2015-12-07 11:16:36 -08:00
Kevin Sawicki
83c69b56a4 Use ipc eval in spec 2015-12-07 11:12:55 -08:00
Paul Betts
3931ebb7ef Fix up Windows build errors 2015-12-07 10:02:06 -08:00
Kevin Sawicki
e62092ebb2 Move ipc handler to be near others 2015-12-07 09:47:15 -08:00
Kevin Sawicki
a139a62ebf Mention conversion using Menu.buildFromTemplate 2015-12-07 09:36:21 -08:00
Kevin Sawicki
d5c740957f 🎨 2015-12-07 09:29:03 -08:00
Kevin Sawicki
26ac86c95c Convert submenu when non-Menu is passed into MenuItem ctor 2015-12-07 09:28:48 -08:00
Kevin Sawicki
f178787737 Add failing spec for Menu.buildFromTemplate 2015-12-07 09:28:17 -08:00
Cheng Zhao
d0be6c7411 Fix cppling warning 2015-12-07 22:44:35 +08:00
Cheng Zhao
27dd233820 spec: Make the "remote listeners" test more reliable 2015-12-07 21:28:58 +08:00
Cheng Zhao
647f151906 Fix the failing sendSync 2015-12-07 21:25:19 +08:00
Cheng Zhao
95e7c796ec V8 now checks strictly when callin Neuter() 2015-12-07 20:48:39 +08:00
Cheng Zhao
73e7773d84 Update to API changes of Chrome 47 2015-12-07 19:56:23 +08:00
Cheng Zhao
766bbfcb05 Chrome 47.0.2526.73 2015-12-07 15:14:31 +08:00
billyct
5f092a6c65 support an api with SetIgnoreMouseEvents, and worked fine with osx 2015-12-06 10:14:54 +08:00
Artur de Oliveira Tsuda
e6adf36d98 📝 [ci skip] translation build instructions 2015-12-05 10:39:03 -02:00
howard.zuo
a1154ad816 add ZH-CN translation for using-selenium-and-webdriver 2015-12-05 14:49:01 +08:00
Clark Feusier
c6167bdf0a Fix broken link in Docs > Synopsis 2015-12-04 21:51:33 -08:00
Artur de Oliveira Tsuda
dcfbd294bb 📝 [ci skip] browser window translation 2015-12-04 21:55:03 -02:00
Luke Page
220d05a398 Docs: Fix link to webcontents send channel 2015-12-04 21:07:33 +00:00
Cheng Zhao
e1d7ef7e24 Bump v0.35.4 2015-12-04 19:23:48 +08:00
Cheng Zhao
d14f15c33a Update native_mate: isDestroy => isDestroyed 2015-12-04 19:23:30 +08:00
Cheng Zhao
af2eee603c Merge pull request #3690 from leftstick/master
add translation of using-native-node-modules for ZH-CN
2015-12-04 18:46:56 +08:00
Cheng Zhao
427a2642a9 Merge pull request #3688 from preco21/master
Update as upstream
2015-12-04 18:46:33 +08:00
Cheng Zhao
c8e2be7b28 Bump v0.35.3 2015-12-04 16:43:23 +08:00
Howard.Zuo
c4f2d946e1 add translation of using-native-node-modules for ZH-CN 2015-12-04 15:18:55 +08:00
Cheng Zhao
ec541b2a18 Merge pull request #3686 from atom/fix-flaky-tests
Fix a few flaky tests
2015-12-04 13:53:07 +08:00
Cheng Zhao
7c1ea0b0f4 spec: Suppress flaky tests on Travis 2015-12-04 13:17:36 +08:00
Plusb Preco
0bcc23d8fe Update as upstream
[ci skip]
2015-12-04 13:52:03 +09:00
Plusb Preco
01f9107f00 Update as upstream
[ci skip]
2015-12-04 13:48:38 +09:00
Plusb Preco
4a2bfa0b06 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-12-04 13:38:21 +09:00
Cheng Zhao
1cb35cd172 Merge pull request #3664 from clevertonh/master
Add electron-br
2015-12-04 12:10:00 +08:00
Cheng Zhao
13c737823b spec: Suppress execFileSync test
It somehow makes the test flaky after refresh.
2015-12-04 11:52:34 +08:00
Cheng Zhao
5e5ae81c53 'key of' is better than Object.keys 2015-12-04 11:40:35 +08:00
Cheng Zhao
973ae06f21 Destroy the native window in next tick
It fixes a possible crash when native code is iterating all windows
while the JavaScript code decides to destroy a window.
2015-12-04 11:35:04 +08:00
Cheng Zhao
2c6d232254 Don't add too much listeners in BrowserWindowProxy 2015-12-04 11:12:36 +08:00
Cheng Zhao
504d3d3088 Merge pull request #3670 from mixmaxhq/jeff/fix_window_open
Fix `window.open` not respecting the features string
2015-12-04 10:55:51 +08:00
Cheng Zhao
f6dbc3001e Merge pull request #3683 from zeke/coc
add Contributor Covenant 1.3 code of conduct
2015-12-04 10:52:44 +08:00
Cheng Zhao
afa8f8b166 Merge pull request #3672 from CharlieHess/web-contents-download-url
DownloadURL from webContents
2015-12-04 10:52:11 +08:00
Plusb Preco
06a9ad3984 Add contributing guide
[ci skip]
2015-12-04 10:06:37 +09:00
Zeke Sikelianos
53350d26ae add placeholder CoC content to Korean README 2015-12-03 18:08:10 -06:00
Zeke Sikelianos
7951226f5c link to CoC from README and CONTRIBUTING 2015-12-03 18:06:58 -06:00
Zeke Sikelianos
149859c97b add CODE_OF_CONDUCT.md 2015-12-03 18:06:18 -06:00
Plusb Preco
d583cf7d8c Update as upstream
[ci skip]
2015-12-04 07:54:09 +09:00
Jessica Lord
37bcdfdd45 Merge pull request #3680 from atom/newline-before-code-block
Add newline before example code block
2015-12-03 12:16:32 -08:00
Charlie Hess
c412b9b892 Revert accidental change to this submodule. 2015-12-03 12:14:08 -08:00
Charlie Hess
f2797d2eab Merge commit '58567834c7cb9c290ef48c9e8f54ae37246ef665' into web-contents-download-url
Conflicts:
	atom/browser/api/atom_api_web_contents.cc
2015-12-03 10:31:51 -08:00
Kevin Sawicki
dec714bda4 Add newline before example code block 2015-12-03 08:40:47 -08:00
Cheng Zhao
58567834c7 Merge pull request #3663 from preco21/master
Update as upstream
2015-12-03 21:44:54 +08:00
Cheng Zhao
f3645c6661 Merge pull request #3676 from atom/callback-race-condition
Make sure V8 handles are deleted on UI thread
2015-12-03 18:06:34 +08:00
Cheng Zhao
48a11bd237 Weak map only needs to be deleted for once 2015-12-03 17:10:14 +08:00
Cheng Zhao
eb8426269f Remove itself from the cleanup list when it is destroyed 2015-12-03 17:04:40 +08:00
Cheng Zhao
1e7c8c9fda It is fine to leak a V8 handle on exit 2015-12-03 16:33:57 +08:00
Cheng Zhao
117b7462de window.id is no longer available when window is closed 2015-12-03 16:17:10 +08:00
Cheng Zhao
a15f9fab5b Use BuildPrototype to build prototype
This saves the step of manually keeping the global template object,
which is easy to forget then leak.
2015-12-03 16:04:46 +08:00
Cheng Zhao
6795bd1d96 Do not manually manage native resources
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
e5358d405a Make sure V8 Function passed to native code are destroyed on UI thread 2015-12-03 11:24:33 +08:00
Charlie Hess
b1391270ed This spec is a little unreliable; up the timeout. 2015-12-02 18:40:57 -08:00
Charlie Hess
b369d4991e Write a spec for downloading from the webview tag. 2015-12-02 18:40:39 -08:00
Charlie Hess
0d30a8d70c Make downloadURL available on the webview tag. 2015-12-02 18:40:02 -08:00
Charlie Hess
5839df66e4 Document the new method. 2015-12-02 13:49:42 -08:00
Charlie Hess
c311c6cf1b Add a DownloadURL method on WebContents. 2015-12-02 13:49:30 -08:00
Jeff Wear
225fe72d03 Ensure that window.open does not override the child options
Fixes https://github.com/atom/electron/issues/3652.
2015-12-02 12:00:51 -08:00
Jeff Wear
32e949efed Read window size properly in window.open test
`BrowserWindow#getSize` returns `[width, height]`, not `{width, height}`.
2015-12-02 11:50:44 -08:00
Cléverton Heming
0553b9c672 Add electron-br 2015-12-02 15:27:23 +00:00
Plusb Preco
75c28ff993 Update as upstream 2015-12-03 00:21:34 +09:00
Plusb Preco
cc841242b5 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-12-03 00:21:28 +09:00
Cheng Zhao
4252c17db0 Merge pull request #3660 from atom/tray-custom-menu
Add `menu` parameter for Tray.popUpContextMenu
2015-12-02 20:55:02 +08:00
Cheng Zhao
47b74ff820 Merge pull request #3659 from lukeapage/patch-1
Update debugging-main-process.md
2015-12-02 19:59:43 +08:00
Cheng Zhao
615ce45849 win: Implement menu parameter 2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7 mac: Implement menu parameter 2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7 Add menu parameter for Tray.popUpContextMenu 2015-12-02 18:43:11 +08:00
Luke Page
9567599698 Update debugging-main-process.md 2015-12-02 10:23:21 +00:00
Cheng Zhao
202475f5a9 Deprecating a property with method of same name causes trouble
Close #3511.
2015-12-02 17:29:58 +08:00
Cheng Zhao
c493bec089 Make sure temp file will be cleaned up when base::Move fails 2015-12-02 11:36:29 +08:00
Cheng Zhao
c3645e3f95 Don't call Move if there is no need to move 2015-12-02 11:07:48 +08:00
Cheng Zhao
c691094aa1 spec: Fix failing tests on win32 2015-12-02 11:00:28 +08:00
Cheng Zhao
0d50e08ed1 Merge pull request #3648 from jviotti/jviotti/fix/exec-file-asar-bat
🏁 Preserve file extension when extracting from asar
2015-12-02 10:45:24 +08:00
Cheng Zhao
17f4bf2ce8 Merge pull request #3650 from arturts/patch-5
📝 [ci skip] Update to match english docs, fix typos
2015-12-02 10:21:10 +08:00
Cheng Zhao
8122d63cd2 Merge pull request #3649 from arturts/pt-BR-auto-updater
📝 [ci skip] Add translation to auto-updater, change links
2015-12-02 10:20:58 +08:00
Artur de Oliveira Tsuda
5cae8397cc 📝 [ci skip] fix more typos 2015-12-01 21:57:07 -02:00
Artur de Oliveira Tsuda
9a93ecc3cf 📝 [ci skip] fix typos 2015-12-01 21:46:13 -02:00
Artur de Oliveira Tsuda
d76e21853b Change header 2015-12-01 21:38:25 -02:00
Artur de Oliveira Tsuda
229dc02a41 📝 [ci skip] Update to match english docs, fix typos 2015-12-01 21:34:35 -02:00
Artur de Oliveira Tsuda
1b1c4bec4e 📝 [ci skip] Add translation to auto-updater, change links 2015-12-01 21:09:20 -02:00
Juan Cruz Viotti
a99c193cf2 🏁 Preserve file extension when extracting from asar
Currently, when calling `copyFileOut`, the original extension from the
file is lost, and a generic `*.tmp` is added instead.

This becomes problematic in the scenario where we use
`child_process.execFile` on a Windows Batch script that lives inside the
`asar` package.

Windows relies on the extension being present in order to interpret the
script accordingly, which results in the following bug because the
operating system doesn't know what do to with this `*.tmp` file:

```
Error: spawn UNKNOWN
```

Steps to reproduce:

1. Create a dummy batch script (test.bat):

```
@echo off
echo "Hello world"
```

2. Create an electron app that attemps to call this script with
`child_process.execFile`:

```js
var child_process = require('child_process');
var path = require('path');

child_process.execFile(path.join(__dirname, 'test.bat'), function(error, stdout) {
    if (error) throw error;
    console.log(stdout);
});
```

3. Package this small application as an asar archive:

```sh
> asar pack mytestapp app.asar
```

4. Execute the application:

```sh
> electron.exe app.asar
```
2015-12-01 14:55:58 -04:00
Cheng Zhao
85b7aa6933 Merge pull request #3645 from atom/fix-page-title-set
Delay the page-title-updated event to next tick
2015-12-01 19:12:34 +08:00
Cheng Zhao
e5974e44ed Deprecate the page-title-set event
We have two names for the same event, page-title-updated wins.
2015-12-01 18:50:56 +08:00
Cheng Zhao
c95117fb22 Delay the page-title-set event to next tick 2015-12-01 18:34:58 +08:00
Cheng Zhao
83ee78451a Emit event when title becomes empty 2015-12-01 17:53:13 +08:00
Cheng Zhao
8d20dda6d7 No need to override TitleWasSet in NativeWindow 2015-12-01 17:51:09 +08:00
Cheng Zhao
782af41c7c Merge pull request #3643 from atom/fix-did-fail-load-crash
Delay the did-fail-provisional-load event to next tick
2015-12-01 17:19:52 +08:00
Cheng Zhao
1b3eb1cc5d Delay the did-fail-provisional-load event to next tick
Chrome is doing some stuff after the DidFailProvisionalLoad event, if we
call LoadURL at this time crash would happen.
2015-12-01 17:00:42 +08:00
Cheng Zhao
0f17a0163d Put common constants in atom_constants 2015-12-01 16:21:15 +08:00
Cheng Zhao
a2f1390b0d Merge pull request #3641 from atom/process-no-asar
Add process.noAsar to toggle asar support
2015-12-01 14:40:37 +08:00
Cheng Zhao
165b464a15 docs: process.noAsar 2015-12-01 13:43:52 +08:00
Cheng Zhao
900dc78a47 spec: process.noAsar 2015-12-01 13:09:50 +08:00
Cheng Zhao
e3ec1fe8ab Add process.noAsar to turn off asar support 2015-12-01 13:09:37 +08:00
Cheng Zhao
757b644909 Merge pull request #3567 from atom/cors
Enable all origins via CORS header for custom schemes
2015-12-01 12:43:38 +08:00
Paul Betts
7fd1db192b Lint harder 2015-11-30 18:12:00 -08:00
Cheng Zhao
bd5d52f825 Merge pull request #3638 from arturts/pt-br-translation
📝 [ci skip] Add translation to app.md
2015-12-01 10:06:55 +08:00
Cheng Zhao
dd0b2bc8d5 Merge pull request #3636 from arturts/patch-4
📝 [ci skip] Update to match english docs.
2015-12-01 10:06:38 +08:00
Cheng Zhao
290c0c37f4 Merge pull request #3635 from arturts/patch-3
📝 [ci skip] Fix typos
2015-12-01 10:06:13 +08:00
Artur de Oliveira Tsuda
7da78a9fa8 📝 [ci skip] Add translation to app.md 2015-11-30 21:56:19 -02:00
Artur de Oliveira Tsuda
97f535251b 📝 [ci skip] Update to match english docs. 2015-11-30 19:43:19 -02:00
Artur de Oliveira Tsuda
c83976dfdc 📝 [ci skip] Fix typos 2015-11-30 19:14:33 -02:00
Paul Betts
549da7fd91 Linting 2015-11-30 11:10:18 -08:00
Paul Betts
15b8d7680e Add tests to verify behavior 2015-11-30 11:08:45 -08:00
Paul Betts
7cce3987eb Add CORS header to file jobs 2015-11-30 11:08:45 -08:00
Paul Betts
65cb1488b0 Fix CORS header code to be cleaner 2015-11-30 11:08:44 -08:00
Paul Betts
7622bb40a9 Enable all origins via CORS header for custom schemes
This PR disables CORS for custom schemes, which allows you to serve Font
resources from custom schemes after using registerCustomSchemeAsSecure
2015-11-30 11:08:43 -08:00
Cheng Zhao
f931e165d5 Merge pull request #3634 from atom/fix-crash-on-exit
Delete BridgeTaskRunner when main message loop is ready
2015-11-30 22:40:48 +08:00
Cheng Zhao
44e24ebf7a Delete BridgeTaskRunner when main message loop is ready 2015-11-30 22:29:01 +08:00
Cheng Zhao
a7dd6596f1 Merge pull request #3628 from lovemyliwu/patch-1
🎨 add miss charactor
2015-11-30 18:26:04 +08:00
Smite Chow
4d5028fb4c 🎨 add miss charactor 2015-11-30 17:16:35 +08:00
Plusb Preco
9fa6527460 Update as upstream 2015-11-30 17:24:43 +09:00
Cheng Zhao
dbdfac1133 Merge pull request #3626 from arturts/patch-2
Update 'Estilo de código' link.
2015-11-30 16:01:05 +08:00
Cheng Zhao
b9c6f719f3 Merge pull request #3625 from arturts/patch-1
Remove 'Google Translator'-like translation
2015-11-30 16:01:01 +08:00
Cheng Zhao
f30a7f5636 Merge pull request #3622 from atom/wl-docs-skip-ci
Suggest [ci skip] in documentation-only commits
2015-11-30 15:33:49 +08:00
Cheng Zhao
bf4b94561e docs: Mention submitting to MAC costs money
Close #3617.
2015-11-30 15:21:39 +08:00
Cheng Zhao
91395102cf Merge pull request #3618 from preco21/master
Update as upstream
2015-11-30 15:01:08 +08:00
Cheng Zhao
23560ff570 Merge pull request #3616 from leftstick/master
add packaging translation for ZH-CN
2015-11-30 15:00:33 +08:00
Cheng Zhao
8ba02fb899 Merge pull request #3612 from gunmetal313/translate_to_ru
init russian lang docs
2015-11-30 14:57:16 +08:00
Artur de Oliveira Tsuda
45e9ed5f0c Update 'Estilo de código' link.
'Estilo de código' in 'Desenvolvimento' section now points to the translated coding-style.md
2015-11-29 23:25:16 -02:00
Artur de Oliveira Tsuda
7d827c2f3e Remove 'Google Translator'-like translation 2015-11-29 22:56:34 -02:00
Paul Betts
b67e70334a Merge pull request #3621 from lukewestby/patch-1
fix misspelling in "rotation" string
2015-11-29 15:33:55 -08:00
Wliu
9c0afcd901 Wrap [ci skip] in backticks 2015-11-29 14:57:48 -05:00
Wliu
c7420e17ab Suggest [ci skip] in documentation-only commits 2015-11-29 14:04:57 -05:00
Luke Westby
df9ecefe01 fix typo in "rotation" string 2015-11-29 12:22:53 -06:00
Plusb Preco
22dbf5e9fc Small fixes 2015-11-29 23:06:01 +09:00
Plusb Preco
dab7058aa2 Update as upstream 2015-11-29 23:03:31 +09:00
Plusb Preco
9fbe2e6c0f Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-29 18:46:01 +09:00
howard.zuo
5bbc46930f add packaging translation for ZH-CN 2015-11-29 12:14:49 +08:00
Ivan Kulikov
eeb1143deb init russian lang docs 2015-11-27 22:32:45 +03:00
Cheng Zhao
62add3abcc Bump v0.35.2 2015-11-27 22:23:19 +08:00
Cheng Zhao
b529efcd8e Merge pull request #3608 from atom/cp-execfile
Add docs and tests for child_process.execFile
2015-11-27 22:21:33 +08:00
Cheng Zhao
cfdcfcbd80 Add executable permission in CopyFileOut 2015-11-27 22:06:37 +08:00
Cheng Zhao
6ef6a83042 spec: Test execFile and execFileSync 2015-11-27 21:38:43 +08:00
Cheng Zhao
a1fdc701ee docs: Add notes on spawn and exec 2015-11-27 21:29:31 +08:00
Cheng Zhao
6fb944c842 Merge pull request #3604 from niedzielski/patch-2
Update docs for webContents.addWorkSpace
2015-11-27 18:39:11 +08:00
Cheng Zhao
8472528909 Merge pull request #3603 from niedzielski/patch-1
Update docs for globalShortcut.register
2015-11-27 18:38:39 +08:00
Cheng Zhao
628ee93b0b Merge pull request #3606 from preco21/master
Update as upstream
2015-11-27 18:38:13 +08:00
Plusb Preco
a96c408df5 Update as upstream 2015-11-27 17:28:09 +09:00
Plusb Preco
8a7aa0171b Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-27 17:27:58 +09:00
Stephen Niedzielski
62c65280a1 Update docs for webContents.addWorkSpace
Specify that webContents.addWorkSpace cannot be called before DevTools
creation and include example.

Fix: #3536
2015-11-26 23:16:00 -07:00
Stephen Niedzielski
0b245b96e4 Update docs for globalShortcut.register
Document return value for globalShortcut.register and common failure scenario.

Fix: #3600
2015-11-26 22:38:47 -07:00
Cheng Zhao
42454b07d0 Merge pull request #3595 from jviotti/jviotti/fix/3512/execFile-override-exec-permissions
🐛 Fix missing execution permission bit in execFile override
2015-11-27 11:39:45 +08:00
Juan Cruz Viotti
585ff9062c 🐛 Fix missing execution permission bit in execFile override
Consider an electron application that uses `execFile` to run a script
that lives within the application code base:

```coffee
child_process = require 'child_process'
child_process.execFile __dirname + '/script.sh', (error) ->
  throw error if error?
```

An application like this will fail when being packaged in an `asar` with
an following error:

```
Error: spawn EACCES
```

Electron overrides certain `fs` functions to make them work within an
`asar` package. In the case of `execFile`, the file to be executed is
extracted from the `asar` package into a temporary file and ran from
there.

The problem is that during the extraction, the original permissions of
the file are lost.

We workaround this by:

1. Extending `asar.stat` to return whether a file is executable or not,
  which is information that's already saved in the `asar` header.

2. Setting execution permissions on the extracted file if the above
  property holds true.

Fixes: https://github.com/atom/electron/issues/3512
2015-11-26 23:30:23 -04:00
Plusb Preco
43b73a0ced Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-27 12:19:47 +09:00
Cheng Zhao
932cd92bf6 Fix wrong deprecation wrappers of BrowserWindow 2015-11-27 10:30:51 +08:00
Cheng Zhao
ed866900e7 Merge pull request #3594 from atom/public-env
Add ELECTRON_RUN_AS_NODE environment variable
2015-11-26 21:51:35 +08:00
Cheng Zhao
59402eb23f Add ELECTRON_NO_ATTACH_CONSOLE env var
Close #1556.
2015-11-26 21:11:28 +08:00
Cheng Zhao
682b48095a docs: Add example 2015-11-26 20:44:07 +08:00
Cheng Zhao
6534a0e616 docs: Add Environment Variables 2015-11-26 20:37:48 +08:00
Cheng Zhao
b1e6d4f64c Check ELECTRON_RUN_AS_NODE env var 2015-11-26 20:37:21 +08:00
Cheng Zhao
5ee9e61445 Update brightray for #1369 2015-11-26 19:10:43 +08:00
Cheng Zhao
a551b8eaaa Merge pull request #3590 from vQuagliaro/doc-windows-open-file
[doc] open-file and open-url events are only available on OS X
2015-11-26 18:34:12 +08:00
Vincent Quagliaro
fe4638ef33 📝 open-file and open-url events are only available on OS X 2015-11-26 09:09:45 +01:00
Cheng Zhao
086734cb57 Merge pull request #3588 from atom/fix-fullscreen-crash
Clears the delegate when window is going to be closed
2015-11-26 14:10:17 +08:00
Cheng Zhao
b0d4aa211d Fix compatibility with activate-with-no-open-windows event 2015-11-26 13:57:48 +08:00
Cheng Zhao
6c1878d15b mac: Clears the delegate when window is going to be closed
Since EL Capitan it is possible that the methods of delegate would get
called after the window has been closed.

Refs atom/atom#9584.
2015-11-26 13:56:56 +08:00
Cheng Zhao
8ce19d8059 Merge pull request #3586 from atom/ipc-fasterer
Ensure calling webview.send will not block the renderer
2015-11-26 13:15:08 +08:00
Cheng Zhao
9c62be8fc9 Improve the deprecation notice for ipc module
Close #3577.
2015-11-26 11:06:56 +08:00
Cheng Zhao
873bfd0538 Merge pull request #3574 from preco21/master
Update as upstream
2015-11-26 11:02:01 +08:00
Cheng Zhao
ec88567683 Merge pull request #3573 from rprichard/fix_3565
Fix https://github.com/atom/electron/issues/3565 by adding a typeof
2015-11-26 11:00:29 +08:00
Paul Betts
789380dfad Ensure calling webview.send will not block the renderer
When the browser process is busy, calling webview.send (a method that appears
on its face to be non-blocking) will actually block, because most webview methods
are remoted to a guest view instance in the browser. Instead, define a few methods
which will instead send its call over an async IPC message.
2015-11-25 15:54:30 -08:00
Plusb Preco
34aecc9327 Update as upstream 2015-11-25 08:55:04 +09:00
Ryan Prichard
0f5a3baff4 Fix https://github.com/atom/electron/issues/3565 by adding a typeof 2015-11-24 16:49:52 -06:00
Cheng Zhao
bf5e9e4f4d Merge pull request #3568 from laiso/fix_docs
docs: s/loadUrl/loadURL/g in docs-translations/
2015-11-24 22:03:46 +08:00
laiso
4acbd3e03f s/loadUrl/loadURL/g in docs-translations/ 2015-11-24 21:02:14 +09:00
Cheng Zhao
b9fd095b04 docs: Mark code blocks 2015-11-24 18:40:50 +08:00
Cheng Zhao
24e892dd17 Update brightray for #3550 2015-11-24 18:39:16 +08:00
Cheng Zhao
bab603d33a Merge pull request #3550 from etiktin/support_proxy_bypass_list
Add support for --proxy-bypass-list command line argument
2015-11-24 18:38:33 +08:00
Cheng Zhao
fe88cb01fc Merge pull request #3531 from deepak1556/fetch_job_nocontent_patch
protocol: handle http responses with no content
2015-11-24 15:45:07 +08:00
Cheng Zhao
a4a14a5f0e Update brightray for #3458 2015-11-24 15:14:48 +08:00
Cheng Zhao
e634dc567e Merge pull request #3561 from preco21/master
Update as upstream
2015-11-24 13:40:16 +08:00
Plusb Preco
6e6cee3ac6 Small fixes 2015-11-24 10:23:52 +09:00
Plusb Preco
6636effb1d Update as upstream
* Update as upstream
* Add caution of translation version
2015-11-24 10:21:30 +09:00
Plusb Preco
d353a3a204 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-23 20:34:00 +09:00
Cheng Zhao
c2197d8a05 Merge pull request #3554 from meowlab/docs-fix
docs: Fix deprecated usage tips
2015-11-23 18:19:37 +08:00
Cheng Zhao
9e74b10825 Merge pull request #3548 from dongjoon-hyun/fix_typos_in_koKR_api_ipc_main
Fix typos in Korean api/ipc-main.md
2015-11-23 17:45:48 +08:00
Cheng Zhao
422e40d08c Merge pull request #3544 from dongjoon-hyun/fix_typo
Fix a typo in Korean quick-start tutotial
2015-11-23 17:45:44 +08:00
Cheng Zhao
e98d4c4a2e Merge pull request #3549 from bengotow/fix-hide-others
Remove trailing colons from default menu roles
2015-11-23 17:44:06 +08:00
Plusb Preco
54f16a5568 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-23 18:23:15 +09:00
Cheng Zhao
360a747acf Merge pull request #3542 from etiktin/fix_menu_item_using_deprcated_api
Fix menu-item using deprecated API
2015-11-23 17:11:44 +08:00
Cheng Zhao
ba8b448c36 docs: Add indent for items in list
Some markdown renderers require it to be able to render the list
correctly.
2015-11-23 16:59:15 +08:00
Cheng Zhao
634fef2508 Merge pull request #3537 from etiktin/make_BrowserWindow_options_optional
Make BrowserWindow options argument optional
2015-11-23 16:56:30 +08:00
Cheng Zhao
812e105d4f Merge pull request #3535 from etiktin/use_the_correct_docs_version
Use the correct docs version
2015-11-23 16:45:26 +08:00
Cheng Zhao
1a1d5aba94 Merge pull request #3533 from preco21/master
Update as upstream
2015-11-23 16:41:02 +08:00
Sunny
6d46c3a75e docs: Fix deprecated usage tips 2015-11-23 13:40:23 +08:00
Eran Tiktin
baab0486f0 Add documentation for --proxy-bypass-list
Depends on atom/brightray#179
2015-11-22 23:44:20 +02:00
Robo
167f11e797 protocol: handle http responses with no content 2015-11-23 01:07:14 +05:30
Ben Gotow
fbdef9e112 Remove trailing colons from default menu roles
`hideothers` and `unhide` had trailing colons which prevented them from being enabled / working in the default app. #3543
2015-11-22 09:08:35 -08:00
Dongjoon Hyun
df570269e3 Fix typos in Korean api/ipc-main.md 2015-11-22 23:16:56 +09:00
Dongjoon Hyun
10a7ecee46 Add space, too 2015-11-22 19:55:36 +09:00
Dongjoon Hyun
b406774055 Fix a typo in Korean quick-start tutotial 2015-11-22 19:50:52 +09:00
Eran Tiktin
6db6842c14 Fix menu-item using deprecated API
Some of the roles in menu-item use methods on BrowserWindow instead of
WebContents which outputs a deprecation warning.
I changed it to use the correct methods.
2015-11-22 01:13:57 +02:00
Eran Tiktin
651254424d Expand the descriptions of options with defaults
Resolves #3367
2015-11-21 21:50:23 +02:00
Eran Tiktin
4027d04662 Add test 2015-11-21 06:58:17 +02:00
Eran Tiktin
ab693ca571 Update docs 2015-11-21 06:42:40 +02:00
Eran Tiktin
18de28c3ff Make BrowserWindow options argument optional
Resolves #3473
2015-11-21 06:22:19 +02:00
Plusb Preco
1cf3216f50 Add missed translation 2015-11-21 13:15:37 +09:00
Eran Tiktin
df8cc85d2c Rephrased the note 2015-11-21 04:22:16 +02:00
Eran Tiktin
5730d588d0 Add a note to readme about docs versioning
Added a note to readme about using the correct docs version. Hopefully
this will reduce users confusion.
2015-11-21 03:31:52 +02:00
Eran Tiktin
4d4bb0a73e Added ctags cache files to .gitignore 2015-11-21 02:32:53 +02:00
Eran Tiktin
9341b9d640 Make links to docs, point to the correct version
- Links to docs in the default app, pointed to the docs in the master
branch. I changed them to point to the docs that match Electron's
version.
- Added Electron's version to the header of the default app, so it will
be easier to figure out what version is currently running.
2015-11-21 02:26:59 +02:00
Plusb Preco
ecdce2b214 Update as upstream 2015-11-21 07:51:52 +09:00
Eran Tiktin
f374508a61 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-20 19:25:23 +02:00
Eran Tiktin
50083017bc Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-20 18:44:51 +02:00
Cheng Zhao
29052b0498 Bump v0.35.1 2015-11-20 13:36:59 +08:00
Cheng Zhao
153c751fd7 Update brightray for #3493 2015-11-20 13:33:42 +08:00
Cheng Zhao
8e2faba8f7 Small style fix 2015-11-20 13:06:42 +08:00
Cheng Zhao
c1d6d68783 Merge pull request #3509 from bengotow/macosx-desktop-window
Support the "desktop" window type on Mac OS X
2015-11-20 13:02:05 +08:00
Cheng Zhao
866cff8b9c Merge pull request #3519 from preco21/master
Update as upstream, some cleanups
2015-11-20 10:52:53 +08:00
Cheng Zhao
784d2633a9 Make child_process.execFileSync support asar 2015-11-20 10:33:57 +08:00
Cheng Zhao
eec93665b7 Merge pull request #3514 from atom/session
Add session module
2015-11-20 10:23:38 +08:00
Plusb Preco
79397abbeb Update as upstream 2015-11-20 04:58:51 +09:00
Plusb Preco
80dfa4bf09 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-20 04:46:07 +09:00
Plusb Preco
962134c612 Cleanup docs
* Adjust line wrap to 80
* Fix typos
* Improve grammar
2015-11-20 04:46:05 +09:00
Ben Gotow
65c823407d Address feedback 2015-11-19 10:14:14 -08:00
Plusb Preco
eca98b85fc Cleanup docs, fix typos 2015-11-20 02:25:44 +09:00
Cheng Zhao
026a1f9a4f Merge pull request #3515 from sotayamashita/japanese-localization
Format structure
2015-11-19 22:23:14 +08:00
Sota Yamashita
fd3b8ad623 Rename: READE.md -> README.md 2015-11-19 22:54:40 +09:00
Sota Yamashita
bee1af3264 Create README.md 2015-11-19 22:54:01 +09:00
Sota Yamashita
f2472274b7 Rename quick-start.md -> tutorial/quick-start.md 2015-11-19 22:52:37 +09:00
Cheng Zhao
1b464c82e1 docs: Put webContents.session under Properties 2015-11-19 21:48:45 +08:00
Cheng Zhao
611f87d17f spec: Use session.defaultSession in tests 2015-11-19 21:42:22 +08:00
Cheng Zhao
08c13cf446 Deprecate app.resolveProxy
There is now a public API to get default session, this helper is no
longer necessary.
2015-11-19 21:32:46 +08:00
Cheng Zhao
44c562ebd9 docs: New session methods 2015-11-19 21:31:39 +08:00
Cheng Zhao
dd8ef33e42 docs: webContents.savePage is placed at wrong place 2015-11-19 21:10:50 +08:00
Cheng Zhao
1392873cbc Add session.defaultSession and remove app.defaultSession
The latter has never been a public API, no need to keep it.
2015-11-19 21:03:42 +08:00
Cheng Zhao
47d7d49d19 Add session module 2015-11-19 20:47:11 +08:00
Cheng Zhao
b9ddb0c268 Merge pull request #3510 from atom/is-destroyed
Add "isDestroyed" method for objects with "destroy" method
2015-11-19 17:28:59 +08:00
Cheng Zhao
9a20b33d97 Add isDestroyed method for classes with destroy method 2015-11-19 17:08:16 +08:00
Ben Gotow
d427ae1030 Support the "desktop" window type on Mac OS X
Adds the desktop window type referenced in https://github.com/atom/electron/issues/2899 for compatiblity with the linux version. Note that on Mac OS X, the desktop window cannot receive input events (seems to be a limitation of being behind the desktop).

In this diff I also removed the `standardWindow` option from the docs, in favor of an additional `textured` value for window `type` on Mac OS X. The old `standardWindow` option continues to work, but seemed more confusing. If this seems like a bad idea, I can revert that change.
2015-11-19 00:39:45 -08:00
Cheng Zhao
ed1f9989b0 Merge pull request #3507 from atom/upload-dsym
Upload the dSYM symbols
2015-11-19 16:38:58 +08:00
Cheng Zhao
2c06afad6a Upload the dSYM symbols 2015-11-19 15:10:33 +08:00
Cheng Zhao
52e34ca0f9 Merge pull request #3506 from atom/linux-dpi
Update libchromiumcontent
2015-11-19 14:45:30 +08:00
Cheng Zhao
c63121c2f6 Update libchromiumcontent
Backport https://codereview.chromium.org/1324513002.
2015-11-19 13:50:54 +08:00
Cheng Zhao
69388e185c Merge pull request #3504 from KevinRamsunder/patch-1
mac-app-store-submission-guide.md: typo correction
2015-11-19 11:00:43 +08:00
Cheng Zhao
2affc44000 Merge pull request #3503 from etiktin/patch-2
Update ipc-renderer.md
2015-11-19 11:00:13 +08:00
Cheng Zhao
afbceab2ab Merge pull request #3496 from preco21/master
Update as upstream and some fixes
2015-11-19 10:57:21 +08:00
Cheng Zhao
e9b8e66f2b Merge pull request #3497 from etiktin/patch-1
Update browser-window.md
2015-11-19 10:54:32 +08:00
Cheng Zhao
8900d67c67 Merge pull request #3492 from vitorgalvao/patch-2
web-view-tag.md: small typo correction ('the' position swap)
2015-11-19 10:44:15 +08:00
Kevin Ramsunder
ba5f8aa096 mac-app-store-submission-guide.md: typo correction 2015-11-18 20:04:16 -05:00
Plusb Preco
0232b77ce3 Cleanup docs, Improve grammar 2015-11-19 09:32:44 +09:00
Eran Tiktin
b7ae9d3337 Update ipc-renderer.md
Removed duplication.
2015-11-19 02:11:32 +02:00
Plusb Preco
e4803e6f97 Translate docs 2015-11-19 05:12:38 +09:00
Eran Tiktin
f581730516 Update browser-window.md
Changed the description of the preload key to make it clear you need to provide an absolute file path and not a file url.
Also mentioned that it's possible to reintroduce Node globals when node integration is off and referenced the example from process.md (related to https://github.com/atom/electron/issues/254#issuecomment-157769756).
2015-11-18 21:06:06 +02:00
Plusb Preco
ef64a211a2 Standardize platform labels 2015-11-19 04:01:50 +09:00
Plusb Preco
82e2da1d9a Translate docs 2015-11-19 03:53:10 +09:00
Vítor Galvão
e2cd0578f3 web-view-tag.md: small typo correction ('the' position swap) 2015-11-18 18:13:48 +00:00
Plusb Preco
70c7abbbfe Small changes 2015-11-19 02:51:27 +09:00
Plusb Preco
f0d2bc87e8 Add translation, improve grammar 2015-11-19 02:50:04 +09:00
Plusb Preco
cc5a4f1dfe Update as upstream 2015-11-18 23:42:03 +09:00
Plusb Preco
9db4af4cf3 Fix platform label to uppercase (ko) 2015-11-18 23:36:20 +09:00
Plusb Preco
0c2d769b8a Fix platform label to uppercase 2015-11-18 23:35:36 +09:00
Plusb Preco
6058c7e14d Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-18 23:33:38 +09:00
Plusb Preco
250575719d Translate docs 2015-11-18 23:32:47 +09:00
Plusb Preco
6892f0d2d4 Add missed translation 2015-11-18 22:14:24 +09:00
Cheng Zhao
87546bd4f8 Merge pull request #3479 from bengotow/tray-resizing
Fix sizing of Mac OS X tray icon after image change
2015-11-18 18:49:15 +08:00
Cheng Zhao
1ee69540b0 Merge pull request #3484 from bengotow/remote-errors
Improve exception messages from remote calls
2015-11-18 18:21:02 +08:00
Cheng Zhao
151f8e7f8a Merge pull request #3485 from leftstick/master
[Doc update]: Use loadURL since loadUrl is deprecated
2015-11-18 18:12:09 +08:00
Cheng Zhao
a3460e8e19 Merge pull request #3483 from preco21/patch-4
'app-command' event is only available in Windows
2015-11-18 18:11:37 +08:00
Cheng Zhao
bcdd0952f8 docs: Fix typo 2015-11-18 17:56:50 +08:00
Cheng Zhao
9e67dc385b Merge pull request #3476 from preco21/master
Update as upstream, add new translation and some fixes
2015-11-18 13:18:44 +08:00
Cheng Zhao
45e3d4ea6b Merge pull request #3487 from atom/certificate-api
Rework of the certificate API
2015-11-18 12:06:52 +08:00
Plusb Preco
25e5c38556 Small changes 2015-11-18 12:45:33 +09:00
Cheng Zhao
47d7f2c050 Fix cpplint warning 2015-11-18 11:45:15 +08:00
Cheng Zhao
9ca022c98a docs: Update the certificate APIs 2015-11-18 11:35:26 +08:00
Cheng Zhao
c5bfac1969 Add session.setCertificateVerifyProc 2015-11-18 11:17:08 +08:00
Plusb Preco
3af4a40860 Translation docs 2015-11-18 11:43:16 +09:00
Cheng Zhao
e432abfb42 Add certificate-error event 2015-11-18 10:39:25 +08:00
Plusb Preco
74e8c8d6a5 Translate docs, small changes 2015-11-18 11:28:03 +09:00
Cheng Zhao
341341bf28 Rename select-certificate to select-client-certificate 2015-11-18 10:10:21 +08:00
Cheng Zhao
9a0dc3bfd7 Add Delegate for AtomBrowserClient 2015-11-18 10:07:03 +08:00
Howard.Zuo
c2eddb20f7 use loadURL since loadUrl is deprecated 2015-11-18 09:37:45 +08:00
Ben Gotow
1022179a1f Improve exception messages from remote calls
Spent a while tracking down `Error processing argument -1`, caused by a missing param (`app.exit()` now takes an exit code.) Improve the rpc-server so that it prints the function name when possible, so it's much easier to identify which remote call is causing the error.
2015-11-17 17:36:37 -08:00
Plusb Preco
d129aa9085 Update as upstream 2015-11-18 09:50:14 +09:00
Plusb Preco
0e8ab0688d Fix wrong markdown 2015-11-18 09:43:28 +09:00
Plusb Preco
0dd14ad204 'app-command' event is only available in Windows 2015-11-18 09:36:14 +09:00
Plusb Preco
7cc965b178 Translate docs 2015-11-18 09:21:49 +09:00
Plusb Preco
57aecbc415 Small changes 2015-11-18 07:09:10 +09:00
Ben Gotow
9c69416e32 Fix sizing of Mac OS X tray icon after image change
- Consolidate logic that applies view dimensions into a function
- Use `NSVariableStatusItemLength` instead of trying to sync status item width
- Use modern Obj-C syntax `@[], @{}` in a few places
- Recompute view bounds after updating image in `setImage:`
2015-11-17 13:43:55 -08:00
Plusb Preco
c21d7b537a Update as upstream 2015-11-18 03:40:58 +09:00
Plusb Preco
78dac21b84 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-18 03:10:18 +09:00
Plusb Preco
b4eca40d07 Improve grammar
* Improve grammar
* Standardize docs
* Fix typos
2015-11-18 03:09:51 +09:00
Plusb Preco
456154a6a2 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-18 02:13:01 +09:00
Plusb Preco
247a0a8ae2 Add BrowserWindow translation 2015-11-18 02:12:40 +09:00
Cheng Zhao
ab54fedc9a Merge pull request #3469 from atom/cleanup-verify-certificate
Emit verify-certificate only when default verifier fails
2015-11-17 21:57:58 +08:00
Cheng Zhao
961ee5a4d9 Rename verify-certificate to untrusted-certificate 2015-11-17 21:41:36 +08:00
Cheng Zhao
ebe66daa56 Emit verify-certificate only when default verifier fails 2015-11-17 21:36:36 +08:00
Cheng Zhao
e3517b701e Create a new CertVerifierRequest for each request
It greatly simplifies the code.
2015-11-17 19:44:55 +08:00
Cheng Zhao
ea1e4160ea Move AtomSSLConfigService to atom/browser/net 2015-11-17 19:05:38 +08:00
Cheng Zhao
37f355724a Move AtomCertVerifier to atom/browser/net 2015-11-17 19:03:09 +08:00
Cheng Zhao
217311ef21 No need to use weak reference
Ref-counting manages everything.
2015-11-17 19:00:33 +08:00
Cheng Zhao
24f573eceb Merge pull request #3344 from deepak1556/certificate_verifier_api_patch
session: api to allow handling certificate verification
2015-11-17 18:53:35 +08:00
Moises lopes ferreira
855c1ead00 Portuguese translation of coding-style.md 2015-11-17 18:42:03 +08:00
Cheng Zhao
9a9f912f24 Merge pull request #3464 from dongjoon-hyun/add_missing_translations_in_menu_items
Add missing Korean translations in menu-item.md
2015-11-17 18:20:17 +08:00
Dongjoon Hyun
5995451366 Add missing translations 2015-11-17 16:49:08 +09:00
tom
099da729c7 Added korean translations for webContents 2015-11-17 11:58:37 +08:00
Cheng Zhao
69a6e80ab8 Merge pull request #3462 from atom/absolut-url-docs
docs: Use absolute URLs
2015-11-17 11:50:19 +08:00
Cheng Zhao
68099a71b0 docs: Use absolute URLs
Relative paths in GitHub's repo do not work very well, and our docs site
can not recognize them.
2015-11-17 11:47:57 +08:00
Cheng Zhao
b4d3c8f248 Merge pull request #3460 from preco21/master
Small fixes, add translation
2015-11-17 11:42:57 +08:00
Cheng Zhao
3b826ed1a5 Update brightray: fix #3458 2015-11-17 11:22:14 +08:00
Plusb Preco
ee12dc3d17 Improve grammar 2015-11-17 11:22:05 +09:00
Plusb Preco
83dfef2e66 Fix missed changes 2015-11-17 10:53:24 +09:00
Plusb Preco
5b8e94ca28 Improve grammar 2015-11-17 10:50:06 +09:00
Plusb Preco
7ef347e69e Small changes 2015-11-17 10:44:30 +09:00
Plusb Preco
d05def1e3e Small changes 2015-11-17 05:17:24 +09:00
Plusb Preco
f312a4e6ec Change the translation encoding 2015-11-17 05:09:27 +09:00
Plusb Preco
66816ea2e0 Add Mac App Store guide translation 2015-11-17 05:05:11 +09:00
Robo
92c3ee8e16 use delegate to notify verification requests 2015-11-16 20:45:49 +05:30
Plusb Preco
62e6332366 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-16 23:55:46 +09:00
Plusb Preco
7dcc537359 Update as upstream 2015-11-16 23:47:09 +09:00
Cheng Zhao
202d2eeb8a Merge pull request #3454 from brenca/keyboard-pr
Adding further options to specify the character being sent with sendInputEvent (keyboard)
2015-11-16 22:13:09 +08:00
Heilig Benedek
14740eeb8a Merging keyCode and keyIdentifier and adjusting the docs accordingly 2015-11-16 14:51:26 +01:00
Cheng Zhao
1d800d5e26 Merge pull request #3432 from deepak1556/navigation_patch
browser: fix reloadignoringcache api
2015-11-16 20:55:16 +08:00
Cheng Zhao
9e70d35afa Bump v0.35.0 2015-11-16 16:48:51 +08:00
Cheng Zhao
728a5db3b4 Update brightray: fix building on Windows 2015-11-16 16:47:51 +08:00
Cheng Zhao
feedd0c43d Merge pull request #3456 from meowlab/improve-translation-zh-CN
Fix a dead link and add a new Chinese document translation
2015-11-16 16:29:09 +08:00
Cheng Zhao
3f0f1a2ce9 Update brightray 2015-11-16 16:18:57 +08:00
Cheng Zhao
2a9a66144c Merge pull request #3453 from preco21/master
Update as upstream
2015-11-16 16:11:51 +08:00
Cheng Zhao
0f89573719 Merge pull request #3441 from brenca/master
Fixing memory leak in FrameSubscriber
2015-11-16 16:03:58 +08:00
Sunny
c27c7b05fe Add Simplified Chinese translation for source code structure 2015-11-16 13:06:14 +08:00
Plusb Preco
ceee820d4a Fix typos in download-item.md 2015-11-16 13:44:25 +09:00
Plusb Preco
266c22903b Small fixes 2015-11-16 13:43:16 +09:00
Plusb Preco
c5e706bc30 Add download-item.md translation 2015-11-16 13:41:47 +09:00
Plusb Preco
19a2c24927 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-16 13:41:29 +09:00
Heilig Benedek
5fff06d2c2 Added documentation for the changes in KeyboardEvent and added missing mouseMove event type 2015-11-16 04:54:48 +01:00
Heilig Benedek
bb6d7d1498 Added the option to KeyboardEvent to specify the sent character by it's name (if it can't be sent via the keyCode parameter) 2015-11-16 04:54:21 +01:00
Cheng Zhao
abba83397b Merge pull request #3450 from eddiezane/patch-1
Fix typo in notifications example docs
2015-11-16 11:17:41 +08:00
Plusb Preco
1254331c5e Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-16 12:15:38 +09:00
Plusb Preco
e12e119381 Update as upstream
* Update as upstream
* Fix typos
* Improve grammar
2015-11-16 12:15:21 +09:00
Plusb Preco
ad776887da Update README.md 2015-11-16 08:34:41 +09:00
Plusb Preco
42a3771f98 Small change 2015-11-16 08:30:08 +09:00
Eddie Zaneski
c1373d7480 Fix typo in notifications example docs 2015-11-15 10:48:09 -05:00
Heilig Benedek
9f9436d6dc Moved scope creation before the allocation of the buffer in FrameSubscriber 2015-11-14 23:59:38 +01:00
Plusb Preco
78542ab54c Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-15 07:58:21 +09:00
Heilig Benedek
9987082de5 Merge pull request #3 from atom/master
Update from original
2015-11-14 21:11:26 +01:00
Robo
e2959ed3fc add docs 2015-11-14 12:09:18 +05:30
Robo
2a7f874373 browser: fix reloadignoringcache api 2015-11-14 02:25:23 +05:30
Cheng Zhao
fe214e0806 Merge pull request #3428 from atom/remote-enhance
Make it easier to use browser side modules
2015-11-14 00:26:03 +08:00
Cheng Zhao
5cacf79bc5 docs: Document the new style of remote module 2015-11-13 22:34:00 +08:00
Cheng Zhao
94e24abb99 Use the new style remote module in Electron 2015-11-13 22:22:25 +08:00
Cheng Zhao
b925ac0056 Send sync message to get list of modules 2015-11-13 22:15:16 +08:00
Cheng Zhao
099278855c Simplify how remote.require('electron') is optimized 2015-11-13 21:54:56 +08:00
Cheng Zhao
9bf0a8647e Make it easier to use remote 2015-11-13 21:52:27 +08:00
Cheng Zhao
e76a7f7b7d Fix typo, tray => Tray 2015-11-13 21:52:05 +08:00
Cheng Zhao
5d52ff76ab Merge pull request #3425 from atom/tray-api
Rename the "clicked" event to "click" in Tray
2015-11-13 18:52:56 +08:00
Cheng Zhao
e8ffd24e4e Rename the "clicked" event to "click" in Tray 2015-11-13 16:41:33 +08:00
Cheng Zhao
52f1431bde Merge pull request #3424 from atom/api-rename
Replace "Url" in API names with "URL"
2015-11-13 16:27:38 +08:00
Cheng Zhao
fbb8e61958 Replace "Url" in API names with "URL" 2015-11-13 16:03:40 +08:00
Sunny
9ac87e844a Fix node_bindings link in Simplified Chinese document translation 2015-11-13 15:41:20 +08:00
Cheng Zhao
8f56387bd9 Merge pull request #3422 from atom/windows-fix
Separate options from switches
2015-11-13 15:04:51 +08:00
Cheng Zhao
860c46b3c1 Separate options from switches
On Windows the case sensitivity of command line switches are ignored, so
--nodeIntegraion will become --nodeintegration.

We should separate options from switches so we use "nodeIntegraion" in
options, while passing "--node-integration" in command line.
2015-11-13 14:05:49 +08:00
Cheng Zhao
0f23d6faa9 Merge pull request #3421 from atom/chrome-paths
Add a few more paths for app.getPath
2015-11-13 13:53:55 +08:00
Cheng Zhao
fdc19f2d3a Fix building on Windows 2015-11-13 13:23:13 +08:00
Cheng Zhao
d3caea91b0 Add paths from chrome_paths 2015-11-13 13:05:16 +08:00
Cheng Zhao
05d2e431de Fix building on OS X 2015-11-13 13:03:00 +08:00
Cheng Zhao
83ae9f8d71 Import the chrome_paths code 2015-11-13 12:45:02 +08:00
Cheng Zhao
996a3c2a35 Merge branch 'content_tracing_patch' of https://github.com/deepak1556/atom-shell into deepak1556-content_tracing_patch 2015-11-13 12:29:18 +08:00
Cheng Zhao
78934dceb9 Cleanup and docs for the --js-flags 2015-11-13 12:22:08 +08:00
Cheng Zhao
0321a77a94 Merge pull request #3412 from skhameneh/master
Add --js-flags support for main thread.
2015-11-13 12:10:59 +08:00
Cheng Zhao
3a5160f799 Merge pull request #3415 from atom/exports-electron
Move all public APIs to "electron" module
2015-11-13 11:21:45 +08:00
Cheng Zhao
f2439cefd0 linux: Don't throw error when using autoUpdater
Fix #3194.
2015-11-13 10:58:10 +08:00
Robo
bfaa50a79e retrieve download directory using on linux 2015-11-13 07:44:05 +05:30
Cheng Zhao
852500e5fa Fix a few places using old style require 2015-11-13 09:38:22 +08:00
Robo
37e6e6fab7 emit verify-certificate event for handling verification 2015-11-13 06:44:49 +05:30
Robo
bb439c5f1c browser: check window liveness before setting title 2015-11-13 02:43:21 +05:30
Robo
3d5437e0a4 tracing: fix docs and allow null values in file path conversion fromv8 2015-11-13 02:36:38 +05:30
Robo
d072e61282 session: api to allow handling certificate verification 2015-11-13 01:27:30 +05:30
Cheng Zhao
ce6a7c7d08 spec: Disable old APIs in tests 2015-11-12 23:02:39 +08:00
Cheng Zhao
edd807d227 Fix a typo 2015-11-12 22:56:18 +08:00
Cheng Zhao
c5913c3149 docs: Add notes on old APIs 2015-11-12 22:24:11 +08:00
Cheng Zhao
2ca5a33d28 Add electron.hideInternalModules 2015-11-12 21:46:03 +08:00
Cheng Zhao
c649c4cf4f Rename the env to ELECTRON_HIDE_INTERNAL_MODULES 2015-11-12 21:37:44 +08:00
Cheng Zhao
eac2e7cc61 docs: Update codes in docs to use require('electron') 2015-11-12 21:20:09 +08:00
Cheng Zhao
8b2942c279 Optimize remote.require('electron') 2015-11-12 20:30:40 +08:00
Cheng Zhao
1d1f911b09 Use require('electron') in Electron's code 2015-11-12 20:29:30 +08:00
Shawn K
fb5beb9af5 Add --js-flags support for main thread.
Allow use of flags that must be set before V8 is initialized, such as
"--harmony_proxies", e.g. --js-flags="--harmony_proxies
--harmony_collections"
2015-11-12 01:48:23 -08:00
Cheng Zhao
f9d7e7ce55 Add ELECTRON_DISABLE_OLD_STYLE_MODULES env 2015-11-12 17:02:04 +08:00
Cheng Zhao
c2c09daa23 Add "electron" module 2015-11-12 16:40:27 +08:00
Cheng Zhao
ce0167756e Update node for atom/node#13 2015-11-12 16:27:28 +08:00
Cheng Zhao
cb1dc6b2e2 Merge pull request #3409 from preco21/master
Update as upstream
2015-11-12 12:49:51 +08:00
Plusb Preco
020214ff95 Update as upstream 2015-11-12 12:24:28 +09:00
Cheng Zhao
ca49ddc95d Update brightray 2015-11-12 09:49:15 +08:00
Heilig Benedek
c571776da6 Merge pull request #2 from atom/master
Update from original
2015-11-12 01:20:33 +01:00
Cheng Zhao
28db51ad83 docs: Update BrowserWindow's options 2015-11-11 23:56:17 +08:00
Cheng Zhao
f08bd721f3 Merge pull request #3392 from Mingling94/master
Suggest adding arguments when running webdriver
2015-11-11 22:57:30 +08:00
Cheng Zhao
0e9415a256 docs: More notes on --proxy-server, close #3390 2015-11-11 22:55:32 +08:00
Cheng Zhao
0a5b234e3d Merge pull request #3354 from nishanths/master
Add drag-entered and drag-exited events to Tray
2015-11-11 22:44:05 +08:00
Cheng Zhao
e41cf8111a Merge pull request #3400 from atom/browser-window-options
Remove the "-" in BrowserWindow's option names
2015-11-11 11:29:02 +08:00
Cheng Zhao
f63a4a05b7 spec: Make the crash-reporter test more reliable 2015-11-11 10:37:34 +08:00
Cheng Zhao
60ec1ca3f7 Use new styles of browserWindow options 2015-11-11 10:37:34 +08:00
Cheng Zhao
ba457681b2 Avoid storing unrelated things in WebContentsPreferences 2015-11-11 10:37:34 +08:00
Cheng Zhao
b807685453 Deep copy the options
Otherwise a window's options is possible to be affected by others.
2015-11-11 10:37:34 +08:00
Cheng Zhao
960d325a58 Be compatible with old BrowserWindow options 2015-11-11 10:37:34 +08:00
Cheng Zhao
5cca947f4d Remove unneeded override code 2015-11-11 10:37:34 +08:00
Cheng Zhao
737e22b003 Use minWidth style for options instead of min-width 2015-11-11 10:37:34 +08:00
Cheng Zhao
d37aa8bed9 Reorder switches 2015-11-11 10:37:34 +08:00
Cheng Zhao
961e06ba6c Merge pull request #3398 from preco21/master
Update as upstream
2015-11-11 10:06:47 +08:00
Cheng Zhao
3af1d907d8 Merge pull request #3397 from preco21/patch-2
Standardize the webContents object names
2015-11-11 10:06:12 +08:00
Plusb Preco
319acc1e8a Update as upstream 2015-11-11 09:44:33 +09:00
Plusb Preco
b611154f43 Standardize the webContents object name 2015-11-11 09:03:49 +09:00
Plusb Preco
8774e7cf8d Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-11 07:57:59 +09:00
Ming Luo
916671d4d2 Suggest adding arguments when running webdriver 2015-11-10 14:58:38 -05:00
Nishanth Shanmugham
ed179ecf03 docs: Update tray docs with drop and drag-end events 2015-11-10 10:14:55 -06:00
Nishanth Shanmugham
d1e8e71e3f Tray: Add drag-end and drop events 2015-11-10 10:02:50 -06:00
Nishanth Shanmugham
f98147ea01 Tray: Rename events to drag-enter and drag-leave
Previously, the names were drag-entered and drag-exited. The new names mirror the HTML Drag and Drop event names
2015-11-10 09:27:39 -06:00
Cheng Zhao
f6a0e5ad31 Update brightray for atom/brightray#167 2015-11-10 20:32:16 +08:00
Cheng Zhao
6c7acd8aa5 Merge pull request #3385 from DerNivel/patch-1
Fix typo
2015-11-10 20:25:48 +08:00
Levin Rickert
08e245e3dc Fix typo 2015-11-10 12:42:05 +01:00
Cheng Zhao
1f01a4535a Fix compilation error of brightray 2015-11-10 18:04:59 +08:00
Cheng Zhao
d582ddf790 Update brightray for win7 crash of using notification 2015-11-10 17:44:14 +08:00
Cheng Zhao
682433028c docs: Clean up the desktop-environment-integration.md 2015-11-10 17:43:29 +08:00
Cheng Zhao
20c8637810 Merge pull request #3382 from felixrieseberg/notifications
Document Notifications
2015-11-10 17:30:08 +08:00
Cheng Zhao
0af1308ad7 Merge pull request #3384 from atom/ipc-renderer
Use different names for "ipc" module in main and renderer processes
2015-11-10 17:29:07 +08:00
Cheng Zhao
d234f10177 Implement event.sender for ipcRenderer 2015-11-10 16:59:08 +08:00
Cheng Zhao
90a7d4a906 docs: Update with new IPC modules 2015-11-10 16:48:24 +08:00
Cheng Zhao
05611f5e60 spec: Use multiparty instead of formidable
The latter is buggy and affects our specs.
2015-11-10 16:21:08 +08:00
Cheng Zhao
751af25f37 Use ipcMain in Electron's code 2015-11-10 16:04:34 +08:00
Cheng Zhao
844cea8f21 Deprecate ipc module for ipcMain 2015-11-10 15:41:24 +08:00
Cheng Zhao
6515a445a0 Use ipcRenderer in Electron's code 2015-11-10 15:29:43 +08:00
Felix Rieseberg
765cfb1094 Document Notifications 2015-11-10 08:28:14 +01:00
Cheng Zhao
828d911ed1 Deprecate ipc module for ipcRenderer 2015-11-10 15:12:07 +08:00
Cheng Zhao
5d1f7ed029 Update brightray for atom/brightray#161 2015-11-09 22:56:12 +08:00
Cheng Zhao
bd1f6e2edf Merge pull request #3372 from atom/deprecation-notice
Show warnings for deprecated APIs
2015-11-09 22:40:36 +08:00
Cheng Zhao
91c4ed26fc Print warnings for deprecated APIs 2015-11-09 21:51:30 +08:00
Cheng Zhao
f0bd28ca8d Do not turn off deprecation notice by default
It is v4 now, people should be punished if they are still using
deprecated Node.js APIs.
2015-11-09 21:19:16 +08:00
Cheng Zhao
89ff62b1b5 Add "deprecate" module 2015-11-09 21:19:16 +08:00
Cheng Zhao
a23ffd7a1b Rely on "download" script for argument verification 2015-11-09 18:24:32 +08:00
Cheng Zhao
13b917dd95 Update brightray for atom/electron#3310 2015-11-09 16:38:51 +08:00
Cheng Zhao
dd8fb9739d Merge pull request #3368 from tejaspathak/master
Add option to build local libchromiumcontent
2015-11-09 16:37:00 +08:00
Cheng Zhao
5e3b8d51e4 docs: Fix typo 2015-11-09 11:42:37 +08:00
Plusb Preco
91c7043a1b Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-09 08:17:12 +09:00
Plusb Preco
429723c8a9 Update as upstream 2015-11-09 07:48:40 +09:00
tejaspathak
ae2b004db7 Fix pylint errors 2015-11-08 17:41:16 +09:00
tejaspathak
09169ed402 Add option to build local libchromiumcontent
- Currently libchromiumcontent is downloaded by default.
- Now developer can choose to provide local libchromiumcontent src, shared and static path
2015-11-08 16:18:22 +09:00
Cheng Zhao
3465095c49 Update brightray for #3357 2015-11-07 12:12:17 +08:00
Cheng Zhao
312a79165b Bump v0.34.3 2015-11-06 21:37:37 +08:00
Cheng Zhao
829c396efe Merge pull request #3356 from atom/process-exit
Make process.exit() quit program gracefully
2015-11-06 21:25:27 +08:00
Cheng Zhao
c4ee8c1b1f spec: Fix refreshing on Windows 2015-11-06 21:00:38 +08:00
Cheng Zhao
d70706f876 Make sure handles of callbacks are releases on exit
Some callbacks are stored in native resources that not managed by
JavaScript, so when those resources are destroyed the JavaScript context
may already be destroyed, and releasing callbacks then would result in
crash.
2015-11-06 21:00:32 +08:00
Cheng Zhao
acf4372cf7 win: Add ELECTRON_DEFAULT_ERROR_MODE env
It is useful to help debugging crashes without opening debugger.
2015-11-06 20:25:20 +08:00
Cheng Zhao
863199348f Make process.exit() quit gracefully
Instead of abrupting the whole program immediately, we should close all
windows and release all native resources gracefully on exit. This avoids
possible crashes.

Fix #3350.
2015-11-06 20:25:20 +08:00
Cheng Zhao
c10c74b23a Merge pull request #3355 from preco21/master
Update as upstream
2015-11-06 11:31:44 +08:00
Plusb Preco
0e950e6d26 Update as upstream 2015-11-06 10:52:55 +09:00
Nishanth Shanmugham
8a296f82a0 Tray: Remove extra qualification in header 2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
ee783a13ad docs: Add Tray drag-entered and drag-exited events 2015-11-05 18:49:34 -06:00
Nishanth Shanmugham
818892d474 Tray: Add drag-entered and drag-exited events 2015-11-05 18:46:49 -06:00
Cheng Zhao
5b0ea5bd46 Merge pull request #3343 from atom/fix-crash-of-crash-reporter
win: Guard against failure of RtlAddFunctionTable
2015-11-05 22:41:52 +08:00
Cheng Zhao
2505ebb9a6 win: Guard against failure of RtlAddFunctionTable
On some machines this call will fail and CHECK will abort the
application.
2015-11-05 22:00:40 +08:00
Cheng Zhao
47649ffd17 win: Fix calling showItemInFolder in renderer process 2015-11-05 20:47:27 +08:00
Tyler Gibson
4ff5ce4d6d Fixing MoveItemToTrash behavior in Windows
Modifying MoveItemToTrash for Windows to actually verify file can be
moved to a drive's recycle bin before attempting to delete it.

PR: #3337.
2015-11-05 20:42:30 +08:00
Ryan Molden
4ce840d8e6 Re-enable accessibility in Electron on Windows
In conjunction with commit 7c41f0e.
2015-11-05 19:49:48 +08:00
Cheng Zhao
fbe1200dc7 Merge pull request #3313 from kevinsimper/patch-1
Update devtools-extension with a note about it not working
2015-11-05 10:12:03 +08:00
Kevin Simper
e4f74bb87e Update devtools-extension with a note about it not working 2015-11-04 15:21:02 +01:00
Cheng Zhao
9f536f4783 Merge pull request #3328 from atom/wrapper-cleanup
Clean up native resources on exit
2015-11-04 19:24:32 +08:00
Cheng Zhao
d56b34de3b Make sure all native resources get freed on exit 2015-11-04 18:21:03 +08:00
Cheng Zhao
07c55f321f Destroy JS env immediately after running destruction callbacks 2015-11-04 17:31:10 +08:00
Cheng Zhao
84410a7e1c mac: Destroy the app delegate before running destruction callbacks
Otherwise users might be able to access wrapper functions after they are
destroyed.
2015-11-04 17:23:27 +08:00
Cheng Zhao
323abef362 Merge pull request #3326 from preco21/master
Update as upstream
2015-11-04 17:13:14 +08:00
Cheng Zhao
75f49477ca Cleanup wrapper function when app has done quitting
The app may still do something when quitting, we need to make sure the
wrapper function is still there at that time.
2015-11-04 16:54:36 +08:00
Cheng Zhao
441cc3e57e Style fix 2015-11-04 16:50:19 +08:00
Plusb Preco
96cc5485cb Update as upstream 2015-11-04 17:47:14 +09:00
Plusb Preco
526b2083c4 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-04 17:47:03 +09:00
mgarciaisaia
4013b652ff :checkered_flag:🐛 Buffer overflows in tooltips
Fixes #3290.
2015-11-04 15:34:58 +08:00
Cheng Zhao
28abc8defe Merge pull request #3323 from joaomoreno/win-keyboard-accessibility
Enable Windows keyboard accessibility
2015-11-04 15:14:36 +08:00
Cheng Zhao
1ad77da9d6 Merge pull request #3308 from frankenbot/master
Update redirects
2015-11-04 10:08:13 +08:00
Plusb Preco
df5a3d4e68 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-04 10:50:33 +09:00
Joao Moreno
7c41f0e0e3 remove kDisableLegacyIntermediateWindow switch set 2015-11-03 16:12:01 -08:00
frankenbot
8c989c4630 Update nodejs url 2015-11-03 09:13:48 -08:00
Cheng Zhao
053cd3dad0 Merge pull request #3309 from atom/app-model-id
Fix a few problems around Application User Model ID
2015-11-03 17:58:03 +08:00
Cheng Zhao
1b165559f5 win: Use electron.app.$1 as default user model id
This is to keep compatibility with old apps that don't set app user
model id explicitly.
2015-11-03 15:50:43 +08:00
Cheng Zhao
726910df39 docs: app.setAppUserModelId 2015-11-03 15:36:44 +08:00
Cheng Zhao
8a3268b70c docs: Add notes for working together with Squirrel 2015-11-03 15:30:54 +08:00
Cheng Zhao
7b47b70c9e Fix building on POSIX 2015-11-03 15:30:37 +08:00
Cheng Zhao
9047f81835 win: Set app user model ID in one place
Fix #3297.
Fix #2573.
2015-11-03 15:09:31 +08:00
Cheng Zhao
7c7a7b96de win: Do not set app user model id by default
When user drags exe file into taskbar directly the pinned icon will not
has an app user model id, so if we set app user model id in the
application two icons will show in the taskbar.

For apps installed with a installer it is not a problem since the
shortcut icon will be created with app user model id, but we should also
keep the ability to make portable apps work out of box.

Fix #3303.
2015-11-03 14:55:43 +08:00
frankenbot
d332f2ab1c Update redirects 2015-11-02 21:16:12 -08:00
Cheng Zhao
9236adfbf5 Translate menu template directly in C++ 2015-11-02 23:31:44 +08:00
Cheng Zhao
56e6b28370 Merge pull request #3288 from deepak1556/flash_context_menu_pathc
browser: handle flash context menu request
2015-11-02 21:20:44 +08:00
Cheng Zhao
f7c0418bd8 Ignore case for type of savePage 2015-11-02 21:19:00 +08:00
Cheng Zhao
4804d6b79b Update native-mate 2015-11-02 21:08:29 +08:00
Cheng Zhao
b5f7c433c6 Merge pull request #3292 from ggamel/patch-2
Update auto-updater.md to improve readability
2015-11-02 20:30:47 +08:00
Cheng Zhao
647a0c4e2b Code cleanup for remote module 2015-11-02 20:28:01 +08:00
Cheng Zhao
88fc4e9d05 Merge pull request #3291 from maxcnunes/better-error-handling
Improve error handling from remote
2015-11-02 19:10:50 +08:00
Cheng Zhao
72d7fb7b8a Merge pull request #3281 from MrSurly/patch-1
Update dialog.md
2015-11-02 19:08:47 +08:00
Cheng Zhao
c763cbe298 Merge pull request #3282 from bureken/master
Replace Mac with OS X
2015-11-02 18:33:27 +08:00
Jesus David Rojas
f7108af36b Spanish translations of the documents 2015-11-02 12:41:42 +08:00
Greg Gamel
d097082baf Update auto-updater.md to improve readability
Fix minor grammatical mistakes, correct sentence structures, and improve readability.
2015-10-31 21:25:07 -05:00
Max Claus Nunes
bbb5aef5d2 Improve error handling from remote
This way copy all properties available in the error object and keep the real stack trace
2015-10-31 21:20:54 -02:00
Eric Poulsen
5b49655d1f Update dialog.md 2015-10-31 16:04:01 -07:00
Robo
c969052f12 browser: handle flash context menu 2015-11-01 01:13:17 +05:30
Paul Betts
6a02586176 Add Windows version of running cmd 2015-10-31 08:57:04 -07:00
Cheng Zhao
cb91d4487b Clean up the code handling renderer callback 2015-10-31 15:00:06 +08:00
Cheng Zhao
323ab92299 Merge pull request #3251 from deepak1556/remote_callback_patch
remote: track listeners on browser side
2015-10-31 14:18:58 +08:00
Jesus David Rojas
db3cd1af36 Translate "Diferencias Técnicas con NW.js" 2015-10-31 14:10:24 +08:00
bureken
a957ea1ed9 Replace Mac with OS X 2015-10-31 05:30:18 +03:00
Eric Poulsen
aa98720356 Update dialog.md
Clarification of showErrorBox behavior on Linux if called before app `ready` event.
2015-10-30 14:46:18 -07:00
Robo
2c59f4567e use webcontents id to identify callbacks 2015-10-30 19:51:19 +05:30
Cheng Zhao
d223faa9f4 Merge pull request #3275 from atom/as-optimize-fs-read-file-sync
Allow v8 to optimize fs.readFileSync
2015-10-30 20:02:34 +08:00
Cheng Zhao
58595a23fe Merge pull request #3278 from michaelzoidl/patch-1
Update autoUpdater api docs
2015-10-30 19:52:03 +08:00
Michael J. Zoidl
95ef73ebc1 Update autoUpdater api docs
The event `quitAndUpdate` event changed to `quitAndInstall`
2015-10-30 12:17:30 +01:00
Antonio Scandurra
9c69877421 Allow v8 to optimize fs.readFileSync 2015-10-30 10:30:27 +01:00
Cheng Zhao
21a7c459d8 Bump v0.34.2 2015-10-30 14:50:57 +08:00
Thomas Johansen
aeeada546f Merge pull request #3272 from sk2/patch-1
fix capital I -> i in isDocumentEdited
2015-10-30 07:41:52 +01:00
Simon Knight
8cd8495df7 fix capital I -> i in isDocumentEdited
Uncaught Exception:
TypeError: mainWindow.IsDocumentEdited is not a function
2015-10-30 16:10:46 +10:30
Cheng Zhao
28fb0d0e92 Merge pull request #3270 from preco21/master
Update as upstream
2015-10-30 10:24:48 +08:00
Robo
3a154ab8ea add line and column values to callback id 2015-10-29 21:21:30 +05:30
Robo
ac4df34ecd create binding to idweakmap 2015-10-29 17:51:56 +05:30
Robo
eae7c840b7 use idweakmap for holding callbacks in browser 2015-10-29 17:51:56 +05:30
Robo
62d15953ff remote: track listeners for browser side 2015-10-29 17:51:56 +05:30
Cheng Zhao
386325915b Merge pull request #3261 from preco21/patch-1
Remove extra spaces
2015-10-29 13:53:02 +08:00
Plusb Preco
72e8660245 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-29 14:23:21 +09:00
Plusb Preco
b8cc2e1649 Remove extra spaces 2015-10-29 14:22:00 +09:00
Plusb Preco
c7372f8f93 Update as upstream 2015-10-29 14:18:07 +09:00
Cheng Zhao
917b33dbe7 Small code cleanup 2015-10-29 10:55:08 +08:00
Cheng Zhao
0f89f67a84 Merge pull request #3254 from templateK/master
Fix remove boolean parameter at IsSwitchEnabled function
2015-10-29 10:54:56 +08:00
Cheng Zhao
bf9e6ba11e Merge pull request #3256 from omrilitov/master
Use WPARAM as uint64_t and LPARAM as int64_t
2015-10-29 10:41:11 +08:00
Cheng Zhao
f13a02e4fa Merge pull request #3250 from atom/basic-auth
Add support for basic auth
2015-10-29 10:20:51 +08:00
Omri Litov
ef038257d1 Returns buffer instead of WPARAM and LPARAM 2015-10-29 03:00:44 +02:00
Omri Litov
f22837523f Use WPARAM as uint64_t and LPARAM as int64_t 2015-10-28 21:54:50 +02:00
Omri Litov
2ac40cc28e Added .idea to .gitignore 2015-10-28 21:30:52 +02:00
taemu
16eafdb0ce Fix remove boolean parameter at IsSwitchEnabled function 2015-10-29 03:22:08 +09:00
Jessica Lord
2384c9f493 Merge pull request #3249 from antoinepairet/patch-1
Fix documentation for module types available in the renderer process
2015-10-28 09:58:22 -07:00
Antoine Pairet
4efff08007 Fix comments from @jlord 2015-10-28 17:55:18 +01:00
Antoine Pairet
974b5005bc Update from @jlord 2015-10-28 14:28:30 +01:00
Cheng Zhao
51ba37440d Guard against multiple calls of auth 2015-10-28 21:20:08 +08:00
Cheng Zhao
862c3187f5 docs: login event 2015-10-28 21:14:00 +08:00
Cheng Zhao
569e87035a Also emit "login" on WebContents 2015-10-28 21:00:39 +08:00
Cheng Zhao
f40a3f72d7 Converted callback can only be called for once 2015-10-28 20:44:46 +08:00
Cheng Zhao
4eac6b31b1 Also pass "webContents" in "login" event 2015-10-28 20:23:18 +08:00
Cheng Zhao
131531219e Pass auth_info and request in "login" event 2015-10-28 20:13:06 +08:00
Cheng Zhao
d05255179a Add login event for "app" module 2015-10-28 19:54:59 +08:00
Cheng Zhao
54dad72d92 Don't leak TranslaterHolder 2015-10-28 19:54:59 +08:00
Cheng Zhao
9847747736 Use the callback converter in JsAsker 2015-10-28 19:54:59 +08:00
Cheng Zhao
5d8a31c140 spec: Return early on error 2015-10-28 19:54:59 +08:00
Cheng Zhao
3881ad1c4b Don't leak FunctionTemplate when converting C++ callback 2015-10-28 19:54:59 +08:00
Cheng Zhao
9df89cf79b Add dummy LoginHandler 2015-10-28 19:54:59 +08:00
Cheng Zhao
b86267aa3b Use uint64_t instead of LPARAM
LPARAM is defined to differnt types on differnt machines with different
SDKs, so there is no way to represent it on all platforms safely, using
uint64_t seems to be the only safe choice.
2015-10-28 19:51:24 +08:00
Cheng Zhao
5fd310c75f Add converter for LPARAM 2015-10-28 19:43:05 +08:00
Antoine Pairet
0c5fe03999 Fix module types available in the renderer process
The doc previously stated `only GUI-unrelated` modules are available to the renderer process. I think it should be `only GUI-related`
2015-10-28 11:40:01 +01:00
Cheng Zhao
079796de26 Merge pull request #3247 from matiasinsaurralde/master
+supported-platforms.md (spanish version)
2015-10-28 14:52:30 +08:00
Matias Insaurralde
e90961ac4f Creating supported-platforms.md 2015-10-28 03:19:19 -03:00
Cheng Zhao
c9b53a6e8b Merge pull request #3240 from atom/reland-win-remove-wildcard-extension
Reland win remove wildcard extension
2015-10-27 20:52:43 +08:00
Cheng Zhao
142f380376 Merge pull request #3231 from omrilitov/master
Hooking windows messages
2015-10-27 20:48:19 +08:00
Haojian Wu
f69bafd48a Win: Fix adding '.*' to filename in callback. 2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b Win: Remove adding '*.*' to file name in a save dialog. 2015-10-27 20:15:20 +08:00
Omri Litov
e355532d27 Change windows messages api to hook instead of emitter 2015-10-27 14:00:08 +02:00
Cheng Zhao
b4d9b92ecb Merge pull request #3236 from atom/mas-fix
Update libchromiumcontent: fix private API call
2015-10-27 15:05:11 +08:00
Cheng Zhao
dacd921a04 Revert "Win: Remove adding default file filter(*.*) in a save dialog."
This reverts commit 00493f64b7.
2015-10-27 14:58:44 +08:00
Cheng Zhao
9b17241f6f Merge pull request #3235 from sitdh/master
Translate docs to Thai
2015-10-27 14:31:01 +08:00
Cheng Zhao
3042f604cc Merge pull request #3234 from atom/win-remove-default-filter
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 14:30:35 +08:00
Cheng Zhao
2a85bd3360 Update libchromiumcontent: fix private API call 2015-10-27 14:25:42 +08:00
Sitdhibong Laokok
f1fad96b56 Fix missing spell 2015-10-27 12:36:43 +07:00
Sitdhibong Laokok
a84f4dc3e6 Remove original msg 2015-10-27 12:20:54 +07:00
Haojian Wu
00493f64b7 Win: Remove adding default file filter(*.*) in a save dialog. 2015-10-27 13:10:34 +08:00
Sitdhibong Laokok
2e3a5f5a3e Translate README.md 2015-10-27 12:09:49 +07:00
Cheng Zhao
d1c5d07451 Merge pull request #3227 from nekuz0r/load-url-headers
Add extra headers option to webContents.loadUrl
2015-10-27 11:37:27 +08:00
Omri Litov
edbebf84b9 Added browser-window event 'message' 2015-10-27 03:12:01 +02:00
Gohy Leandre
b29a8c94b9 Add extra headers option to webContents.loadUrl 2015-10-26 22:18:16 +01:00
Cheng Zhao
65ece4b1ca Merge pull request #3215 from atom/fix-remote-call
Fix calling showItemInFolder in renderer
2015-10-26 17:13:20 +08:00
Cheng Zhao
f399f50e9e Fix calling showItemInFolder in renderer
The remote method always assumes the existence of the remote object but
doesn't keep a reference to it, so if we only keep the reference of a
remote method we will get into troubles once the remote object is
garbage collected.

We should probably fix this in remote module, but since most things are
already working quite good, I'm using the work-around for now.

Fix #3139.
2015-10-26 16:48:27 +08:00
Cheng Zhao
e6f54f447c Merge pull request #3213 from rubixware/source-code-directory-structure-translation
Add source code directory structure spanish translation
2015-10-26 16:17:48 +08:00
Cheng Zhao
adb11225d2 Ship LICENSES.chromium.html in zip archive 2015-10-26 16:16:50 +08:00
Cheng Zhao
c973357752 Merge pull request #3198 from deepak1556/callback_patch
nativemate: use maybe version of v8::Function::call to avoid unhandled exceptions
2015-10-26 16:15:58 +08:00
Everardo Medina
b71ec748ad 📝 Add source code directory structure spanish translation 2015-10-26 00:04:11 -06:00
Robo
70fe169b0f nativemate: use maybe version of v8::Function::Call to avoid exceptions 2015-10-26 10:59:40 +05:30
Cheng Zhao
8976708e67 Merge pull request #3212 from rubixware/coding-style-translation
Add coding style spanish translation
2015-10-26 13:01:37 +08:00
Everardo Medina
da82eaefa7 📝 Add coding style spanish translation 2015-10-25 22:37:06 -06:00
Cheng Zhao
3dd6425592 Merge pull request #3203 from etiktin/patch-1
Update web-contents.md
2015-10-26 10:34:13 +08:00
Cheng Zhao
37240c2235 Merge pull request #3200 from jhen0409/patch-3
Sync zh-TW docs from upstream
2015-10-26 09:19:50 +08:00
Paul Betts
d528704bd6 Merge pull request #3207 from diegowifi/patch-1
Remove english words in description
2015-10-25 13:29:34 -07:00
Diego Ponce
fd94ff97e7 Remove english words in description 2015-10-25 14:04:03 -06:00
Eran Tiktin
9b36abc816 Update web-contents.md
The `did-fail-load` event returns an error code and error description. The error description is at least sometimes empty (e.g. when the error code is -102 on Windows), so you're left with an error code without knowing what happened. So I add a link to Chromium's net_error_list.h.
2015-10-25 17:00:29 +02:00
Jhen
8e5c1a505e Update tutorial/quick-start.md for zh-TW docs 2015-10-25 01:34:17 +08:00
Cheng Zhao
2effe6eff5 Merge pull request #3192 from preco21/master
Update as upstream
2015-10-24 15:46:59 +08:00
Plusb Preco
8555aea40f Update as upstream 2015-10-24 05:57:37 +09:00
Cheng Zhao
30ec7fdeed Bump v0.34.1 2015-10-23 20:32:02 +08:00
Cheng Zhao
0e3e1be85c Merge pull request #3186 from atom/auto-updater-fix
Clean up the code of auto-updater
2015-10-23 20:31:20 +08:00
Cheng Zhao
df9ea104c2 Merge pull request #3188 from alexandrubau/master
Updated docs
2015-10-23 20:13:00 +08:00
Cheng Zhao
88b05cff3e docs: auto-updater on Windows 2015-10-23 20:11:59 +08:00
Cheng Zhao
fae2c7bc7a win: Make auto-updater really work
Apparently that PR was never tested.
2015-10-23 19:41:54 +08:00
Alexandru Bau
96130dd4c2 Updated docs
Updated docs to better understand how to use electron-rebuild on all
platforms
2015-10-23 14:15:39 +03:00
Alexandru Bau
79e593aca6 Updated docs
Updated docs to better understand how to use electron-rebuild on Windows
2015-10-23 11:37:51 +03:00
Cheng Zhao
aeafc46ded Keep compatibility with old API style 2015-10-23 15:50:55 +08:00
Cheng Zhao
f89d28a63e Simplify the auto-updater implementations
We used to use Sparkle on OS X, and the design was reserved to be
extended to all platforms, which are all wrong now.
2015-10-23 15:40:56 +08:00
Cheng Zhao
d74ef5c078 Move implementation of auto-updater on OS X to another file 2015-10-23 15:13:24 +08:00
Cheng Zhao
85c84a0eb0 Emit Date object in C++ directly 2015-10-23 14:58:19 +08:00
Cheng Zhao
a3f62da615 Fix passing Date object in remote
Close #2017.
2015-10-23 14:51:41 +08:00
Cheng Zhao
95fe4beda8 Pass real Error object in error event 2015-10-23 14:37:35 +08:00
Cheng Zhao
d5c964c68c Fix passing Error object in remote
Closes #3089
2015-10-23 14:37:28 +08:00
Cheng Zhao
07adbc8e8a Merge pull request #1984 from patrickdet/windows-auto-updater
Windows Auto Updater
2015-10-23 13:54:29 +08:00
Cheng Zhao
90e3f726e4 Merge pull request #3184 from atom/windows-background-color
Make background-color work on Windows
2015-10-23 13:53:12 +08:00
Cheng Zhao
83ef23ff8d docs: background-color on Windows 2015-10-23 13:32:04 +08:00
Cheng Zhao
e36d455d51 Add setBackgroundColor method 2015-10-23 11:35:33 +08:00
Cheng Zhao
4a6134f3f7 win: Set native window's background color 2015-10-23 11:17:14 +08:00
Cheng Zhao
6182e4ce81 Merge pull request #3179 from deepak1556/session_api_patch
session: allow setproxy to use external pac script
2015-10-23 10:36:37 +08:00
Cheng Zhao
79d4d52172 Merge pull request #3178 from deepak1556/node_debugger_patch
debugger: expose v8debug
2015-10-23 10:36:06 +08:00
Cheng Zhao
e3ce1b50ec Merge pull request #3175 from atom/improve-make-single-instance
Fix some problems of makeSingleInstance
2015-10-23 09:13:57 +08:00
Robo
e9a5d05b27 session: allow setproxy to use external pac script 2015-10-22 23:03:47 +05:30
Cheng Zhao
61f07307cb docs: New behaviors of makeSingleInstance 2015-10-22 19:26:05 +08:00
Cheng Zhao
6bfe06ec4e Pass original argv in callback 2015-10-22 19:02:21 +08:00
Robo
7b5a1b06ba debugger: expose v8debug 2015-10-22 16:20:48 +05:30
Cheng Zhao
d52ef50b01 win: Pass original command line 2015-10-22 17:52:06 +08:00
Cheng Zhao
93a3a946f3 posix: Pass original command line 2015-10-22 17:43:55 +08:00
Cheng Zhao
afc1fff792 Remove the need for ProcessSingletonStartupLock 2015-10-22 17:12:09 +08:00
Cheng Zhao
70e74d05e0 Revert "app.makeSingleInstance is not available on OS X"
This reverts commit bcb78ebc00.
2015-10-22 17:03:18 +08:00
Cheng Zhao
f9d797d1ea win: Fix compiler warning 2015-10-22 16:55:54 +08:00
Cheng Zhao
e14fd62f46 Correctly handle notification callback when shutting down
When returning false in the notification callback the ProcessSingleton
will assume current process is quitting, we should met its expectation.
2015-10-22 16:24:35 +08:00
Cheng Zhao
ca876e424b Fix crash when calling app.quit() before app is ready 2015-10-22 16:06:37 +08:00
Cheng Zhao
230f2760e7 linux: Delay creating watcher until message loop is ready 2015-10-22 15:57:37 +08:00
Cheng Zhao
f01e84a418 linux: Delay listening to socket until message loop is ready 2015-10-22 15:54:58 +08:00
Cheng Zhao
05c6300329 Don't discard tasks in BridgeTaskRunner 2015-10-22 15:54:27 +08:00
Cheng Zhao
bcb78ebc00 app.makeSingleInstance is not available on OS X 2015-10-22 15:02:32 +08:00
Cheng Zhao
310954713f Simplify the usage of singleton 2015-10-22 14:59:12 +08:00
Cheng Zhao
acb2c099f6 Make sure current task runner is available
When calling makeSingleInstance we have to ensure current task runnder
is available, otherwise crash may happen.
2015-10-22 14:56:57 +08:00
Cheng Zhao
63cc2ec369 docs: Make code more JS-style 2015-10-22 14:24:09 +08:00
Cheng Zhao
04d3eed60e Merge pull request #3145 from atom/single-instance
Implement Single-Instance for Windows / Linux
2015-10-22 14:18:31 +08:00
Cheng Zhao
f7840e7379 docs: background-color is Linux-only for now 2015-10-22 14:16:17 +08:00
Cheng Zhao
15e0248d82 Merge pull request #3168 from deepak1556/window_background_color_patch
browser: option to set window background color
2015-10-22 14:13:37 +08:00
Robo
9411508d3e browser: option to set window background color 2015-10-22 09:54:29 +05:30
Cheng Zhao
f5659cd9a9 Merge pull request #3173 from tommoor/patch-5
Update crash-reporter.md
2015-10-22 11:10:30 +08:00
Cheng Zhao
803b3c8d5b Merge pull request #3172 from thomasjfox1/master
quick fix removing excess character
2015-10-22 11:08:30 +08:00
Tom Moor
bac3d2e372 Update crash-reporter.md 2015-10-21 17:07:36 -07:00
Paul Betts
759b6a1534 📝 for makeSingleInstance 2015-10-21 13:52:17 -07:00
Paul Betts
de66888051 Remove atom_process_singleton, just use the Chrome classes directly 2015-10-21 13:38:39 -07:00
Paul Betts
d020a7dc86 cpplinting 2015-10-21 13:17:56 -07:00
Paul Betts
938d68eb36 Move all the browser.cc code over to atom_api_app.cc 2015-10-21 13:04:50 -07:00
Thomas J Fox
b61c2e6ff7 quick fix removing excess character 2015-10-21 15:03:12 -05:00
Paul Betts
658a9872fb Only cleanup if we are the main process 2015-10-21 12:29:21 -07:00
Paul Betts
a160891a27 If a user calls makeSingleInstance more than once, just ignore it 2015-10-21 12:29:00 -07:00
Plusb Preco
acbd7d7541 Update as upstream 2015-10-22 03:36:14 +09:00
Paul Betts
38d6ff79c8 Need to free this early or get a SIGSEGV on Linux 2015-10-21 11:06:42 -07:00
Plusb Preco
bca88c1fb9 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-22 02:58:07 +09:00
Cheng Zhao
73f4aa1113 Merge pull request #3169 from atom/fix-node-buffer
Fix memory corruption when cleaning timer
2015-10-21 21:23:25 +08:00
Cheng Zhao
444f461269 Fix memory corruption when cleaning timer 2015-10-21 20:46:16 +08:00
Cheng Zhao
2d410ede48 Initialize things in the same sequence with main process 2015-10-21 16:24:54 +08:00
Cheng Zhao
ed9579a2f7 Merge pull request #3165 from roadev/master
Grammatical corrections for spanish translations at api, styleguide a…
2015-10-21 13:28:48 +08:00
Cheng Zhao
567d8e7434 Merge pull request #3163 from atom/fix-osx-app-region
osx: Implement draggable region with mouseDownCanMoveWindow
2015-10-21 09:53:02 +08:00
Cheng Zhao
d092c6acc9 osx: Implement draggable region with mouseDownCanMoveWindow
Previously we implemented draggable region by tracking mouse position,
it is buggy and causing some problems. But it is interesting that until
this didn't cause troubles until recently.
2015-10-21 08:54:46 +08:00
Paul Betts
99c496471b Allow WM_COPYDATA from all processes 2015-10-20 17:36:05 -07:00
Paul Betts
e5094fff3e Since setting up process_singleton is now conditional, its cleanup / unlock must be too 2015-10-20 17:27:28 -07:00
Juan Roa
fe25f3e747 grammatical corrections for spanish translations at api, styleguide and README 2015-10-20 18:10:08 -05:00
Cheng Zhao
b6859cab91 Merge pull request #3158 from ngoldman/patch-1
use webContents.openDevTools for quick start guide
2015-10-21 06:58:16 +08:00
Cheng Zhao
26d922d18d Merge pull request #3156 from preco21/master
Update as upstream
2015-10-21 06:52:10 +08:00
Paul Betts
15f00db1bf I don't think we need this 2015-10-20 15:03:59 -07:00
Paul Betts
4a7a09aae1 Infinite Linting 2015-10-20 15:00:10 -07:00
Paul Betts
f759471e01 Update to use Chromium sources 2015-10-20 14:36:01 -07:00
Paul Betts
4bc54ac5e3 Fix up filenames to include Chrome source 2015-10-20 14:33:34 -07:00
Paul Betts
5886398f22 Port our changes over 2015-10-20 14:24:45 -07:00
Paul Betts
7491d5cfb5 Copy back the original versions of Chromium files in 2015-10-20 14:05:07 -07:00
Paul Betts
b6f1729acd Move initialization of Single Instance into MakeSingleInstance call 2015-10-20 13:38:57 -07:00
Paul Betts
5d4c29a1e3 Ditch double-callback, just use mate directly 2015-10-20 13:27:34 -07:00
Paul Betts
a2eedcc027 Wire up the final callback to JS 2015-10-20 13:17:26 -07:00
Paul Betts
63417bc975 I am not good at C++ at all 2015-10-20 13:17:25 -07:00
Paul Betts
4a4b829cfc Fix callback handle usage 2015-10-20 13:17:25 -07:00
Paul Betts
50fab0733b At Browser ctor time, DIR_USER_DATA is unset, wait 2015-10-20 13:16:49 -07:00
Paul Betts
b02f89e63b Typo 2015-10-20 13:16:49 -07:00
Paul Betts
cdd51fa96d Wire everything up 2015-10-20 13:16:48 -07:00
Paul Betts
c38f2fcf75 Add a native mate converter for command lines 2015-10-20 13:15:12 -07:00
Paul Betts
7491ae4000 Set up Browser to create the process singleton 2015-10-20 13:15:12 -07:00
Paul Betts
4d5495a0a0 Bring in chrome_process_singleton but nuke the active dialog bits 2015-10-20 13:15:11 -07:00
Paul Betts
717aba9631 Create a dummy method in app that we'll twerk 2015-10-20 13:15:11 -07:00
Paul Betts
8288a22458 Fix build against old OneShotTimer 2015-10-20 13:14:08 -07:00
Paul Betts
88dd1480cc Get POSIX mostly compiling 2015-10-20 13:14:08 -07:00
Paul Betts
c46579b1ac Remove a bunch of stuff we don't need in process_singleton_win 2015-10-20 13:14:07 -07:00
Paul Betts
1b3363c811 Get process finder working 2015-10-20 13:14:07 -07:00
Paul Betts
daa65a138b Come Correct with headers 2015-10-20 13:14:06 -07:00
Paul Betts
d3b23a2032 Renames to avoid confusion, add file 2015-10-20 13:14:06 -07:00
Paul Betts
05b22b9372 Import process_finder verbatim 2015-10-20 13:14:05 -07:00
Paul Betts
ff2d9759d5 Start to remove / rearrange some header files 2015-10-20 13:14:05 -07:00
Paul Betts
90b997ef08 Add the files to filenames.gypi 2015-10-20 13:14:05 -07:00
Paul Betts
27fa5d880a Copy some relevant files over from Chromium 2015-10-20 13:14:04 -07:00
Paul Betts
285a4789b3 Update app.md 2015-10-20 12:35:56 -07:00
Nate Goldman
da7161d5a7 use webContents.openDevTools
https://github.com/atom/electron/issues/3125#issuecomment-148975593
2015-10-20 10:44:02 -07:00
Patrick Detlefsen
db3bc28937 PR feedback adressed 2015-10-20 19:25:03 +02:00
Jessica Lord
a0e2af6fac Merge pull request #3157 from IonicaBizauKitchen/doc-improvements
Doc improvements
2015-10-20 10:20:11 -07:00
Ionică Bizău
1ad979f9bd Add some missing words ("be" and "the") 2015-10-20 19:44:01 +03:00
Plusb Preco
f7a9b02c63 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-21 00:26:30 +09:00
Plusb Preco
7a0db35d91 Update as upstream 2015-10-21 00:25:24 +09:00
Cheng Zhao
c928894627 docs: app.allowNTLMCredentialsForAllDomains 2015-10-20 13:56:31 +08:00
Cheng Zhao
a7a399dcd8 Code cleanup 2015-10-20 13:52:39 +08:00
Cheng Zhao
14e2bbe4c7 Update brightray for #3120 2015-10-20 13:50:19 +08:00
Cheng Zhao
370cb5b5e1 Merge pull request #3120 from atom/ntlm-part-two
Optionally allow NTLM authentication for all domains
2015-10-20 13:48:12 +08:00
Cheng Zhao
78261973fb Merge pull request #3153 from atom/development-env
Add a few environment variables helpful for debugging
2015-10-20 13:47:17 +08:00
Cheng Zhao
be36a17dbf docs: Mention the ELECTRON_ENABLE_LOGGING env 2015-10-20 13:06:41 +08:00
Cheng Zhao
fb8ca33d5d Add ELECTRON_ENABLE_STACK_DUMPING env
It enables in-process stack dumping, which is convenient for debugging.
2015-10-20 13:02:48 +08:00
Cheng Zhao
2c4a24d26b Add ELECTRON_ENABLE_LOGGING env
It is the same with --enable-logging.
2015-10-20 13:00:28 +08:00
Cheng Zhao
4005e65e28 Merge pull request #3150 from atom/jl-upadate-qs
Update Quick Start HTML
2015-10-20 11:17:30 +08:00
Cheng Zhao
86327fb4bb Merge pull request #3149 from atom/jl-add-quick-start-repo
Add links to electron-quick-start Repository
2015-10-20 11:17:23 +08:00
Cheng Zhao
5a46147e9b Update brightray for atom/brightray#158 2015-10-20 10:34:33 +08:00
Cheng Zhao
bb8bb3dbea Merge pull request #3147 from deepak1556/cipher_suite_disable_patch
browser: flag to disable specified cipher suites
2015-10-20 10:29:49 +08:00
Jessica Lord
d09b09b744 Match the electron-quick-start repo 2015-10-19 16:37:18 -07:00
Jessica Lord
bc7c7da799 Add links to electron-quick-start 2015-10-19 15:52:02 -07:00
Robo
9f8479e9d8 browser: flag to diable specified cipher suites 2015-10-20 02:51:56 +05:30
Paul Betts
e3535d664b Fixed linter issues but now the code looks awful 2015-10-19 13:12:17 -07:00
Paul Betts
b3c7e2bf33 Plumb the method back 2015-10-19 13:07:14 -07:00
Paul Betts
489090fcf8 Set up our browser context to use new delegate-based API 2015-10-19 13:03:20 -07:00
Cheng Zhao
0afefe13f6 Merge pull request #3141 from jhen0409/patch-2
Sync recently updated docs to zh-TW docs-translations
2015-10-19 22:09:06 +08:00
Jhen
7f15d63552 Update README.md for zh-TW docs-translations 2015-10-19 21:54:29 +08:00
Jhen
09ee24514e Replace Mac with OS X for zh-TW docs translation 2015-10-19 21:49:57 +08:00
Jhen
d9c7401d0b Replace io.js with node.js for zh-TW docs translation 2015-10-19 21:29:10 +08:00
Cheng Zhao
de3e16ce60 Merge pull request #3129 from brandoncash/fix-tray-notify-typo
Fix: tray NotfiyDropFiles typo
2015-10-19 19:11:26 +08:00
Haojian Wu
9c861b9ad3 Fix always passing the first result to renderer when the API is called multiple
time at once.
2015-10-19 18:07:35 +08:00
Cheng Zhao
72e0da069c Merge pull request #3132 from princejwesley/issue-readFileSync
Fix: honor fs.readFileSync contract for empty packed asar file
2015-10-19 16:59:47 +08:00
Cheng Zhao
0d9e0a38c0 Merge pull request #3128 from atom/fix-save-page-position
Fix: 'savePage API' saves external resources in a wrong directory.
2015-10-19 16:40:45 +08:00
Prince J Wesley
810af2f95d 🐛 Honor fs.readFileSync contract for empty packed asar file 2015-10-19 08:43:50 +05:30
Haojian Wu
fb4efec55d Add options check.
This patch avoids main process never response back to renderer if the options is
invalid.
2015-10-19 11:06:56 +08:00
Plusb Preco
0aefa98e5a Small fix in README 2015-10-19 11:34:13 +09:00
Cheng Zhao
0e50b00fdf Merge pull request #3111 from preco21/master
Add app.md translation into ko-KR, some fixes
2015-10-18 21:45:25 +08:00
Brandon Cash
60b14d03e9 Fix: tray NotfiyDropFiles typo 2015-10-18 00:32:13 -05:00
Haojian Wu
49d25d0069 Fix: savePage API saves external resources in a wrong directory. 2015-10-18 11:28:05 +08:00
Plusb Preco
82e6058607 Update as upstream 2015-10-18 03:30:37 +09:00
Plusb Preco
c46ed897dd Update translation progress in README.md 2015-10-18 03:22:35 +09:00
Haojian Wu
214f8477b3 Fix some typos. 2015-10-17 19:28:14 +08:00
Ivan Žužak
c7d9352972 Merge pull request #3118 from learningjs/thcm
[Tiny correction of misspelling]
2015-10-17 10:10:06 +02:00
Jessica Lord
cd2f924db8 Merge pull request #3117 from ggamel/patch-1
Update MAS tutorial to improve readability
2015-10-16 17:56:32 -07:00
Paul Betts
b958982d99 Rollback submodule change 2015-10-16 17:00:31 -07:00
Paul Betts
a3fc25110e Linter fixes 2015-10-16 16:55:28 -07:00
Paul Betts
5ae6bd2ef4 Wire it up 2015-10-16 16:46:05 -07:00
Paul Betts
7ac643d5f8 Create a new method on App to override URL Security Manager's decisions wrt NTLM 2015-10-16 16:45:54 -07:00
Greg Gamel
5e7a30deea Additional updates to adhere to styleguide
Per @jlord's recommendations.
2015-10-16 18:25:30 -05:00
max_devjs
72078f7b02 [truly humble correction of a misspelling]
Substituting webp with web in frameless-window.md .
2015-10-16 19:56:45 -03:00
Greg Gamel
b5478eaef7 Update MAS tutorial to improve readability
Adjusted tutorial body copy and headings to improve readability, clarify sentences, and fix some (minor) grammatical missteps.
2015-10-16 17:50:41 -05:00
Jessica Lord
1ae4be7571 Merge pull request #3115 from romankl/doc-osx
replace Mac with OS X
2015-10-16 14:21:54 -07:00
Roman Klauke
32523ae352 replace Mac with OS X
Commit 691d8dd replaced "Mac" with "OS X". This commit replaces some
other occurrences.
2015-10-16 22:03:47 +02:00
Eran Tiktin
f0c4c806b5 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-16 22:30:18 +03:00
Plusb Preco
c0ee8f4e60 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-16 22:36:01 +09:00
Plusb Preco
edd6032ed0 Improve grammar for more readability 2015-10-16 22:26:27 +09:00
Plusb Preco
f05fc3c0ea Improve grammar, some fixes
* Improve grammar
* Fix typos
* Fix some mistranslations
* Fix quotes (' to `)
2015-10-16 22:23:31 +09:00
Cheng Zhao
f0825bf7ef Merge pull request #3109 from fplucas/master
Translation of debugging-main-process to pt-br.
2015-10-16 20:28:34 +08:00
Cheng Zhao
d9fdfb711f Clean up CallbackRegistry
There were some ancient code there.
2015-10-16 20:25:30 +08:00
Cheng Zhao
94f64c755d spec: Load url after event listener is set up 2015-10-16 20:22:04 +08:00
Cheng Zhao
4871ea715c Merge pull request #3103 from bengotow/bengotow/debug-release
Allow "released callback" errors to be traced to remote calls
2015-10-16 20:21:46 +08:00
Cheng Zhao
115bb31ab4 docs: Small fix on mas guide 2015-10-16 20:21:06 +08:00
Lucas
2725068a0c Updating README.md 2015-10-16 09:11:30 -03:00
Lucas Pugliesi
5e5caf2e86 Translation of debugging-main-process to pt-br. 2015-10-16 09:09:24 -03:00
Cheng Zhao
22e9c2f4eb Bump v0.34.0 2015-10-16 18:53:25 +08:00
Cheng Zhao
c371c713a9 Merge pull request #3108 from atom/mas-build
Prepare for MAS build and add a guide
2015-10-16 18:51:45 +08:00
Cheng Zhao
776077c8de Bump v0.33.9 2015-10-16 17:42:55 +08:00
Cheng Zhao
16b9f8995d Revert "Go back to using node's console.* and std*.write"
This reverts commit 4e8db2c3be.

It seems that we still have problems with Node.js's console.* calls, I'm
reverting this for now unitl we get a solution.

Fixes #3100.
2015-10-16 17:38:11 +08:00
Cheng Zhao
18fd126c64 docs: Mac App Store Submission Guide 2015-10-16 17:16:12 +08:00
Cheng Zhao
7bdbe45c91 subpixel-font-scaling option is removed 2015-10-16 15:01:28 +08:00
Cheng Zhao
fb99e72484 Update libchromiumcontent to have mas build 2015-10-16 15:01:28 +08:00
Cheng Zhao
0e94ccb72b Merge pull request #3080 from atom/save-page-api
Implement webContents.savePage API.
2015-10-16 09:52:43 +08:00
Ben Gotow
aeb24b784d Allow "released callback" errors to be traced to remote calls 2015-10-15 18:46:59 -07:00
Cheng Zhao
125444df15 Merge pull request #3101 from fplucas/master
Translation of using-pepper-flash-plugin to pt-br.
2015-10-16 09:25:34 +08:00
Haojian Wu
facd0fbc08 Implement webContents.savePage API. 2015-10-16 09:23:08 +08:00
Lucas Pugliesi
3dba56c335 Translation of using-pepper-flash-plugin to pt-br. 2015-10-15 17:16:48 -03:00
Cheng Zhao
89527ec232 Merge pull request #3097 from fplucas/master
Translation of using-native-node-modules to pt-br.
2015-10-15 23:14:30 +08:00
Lucas Pugliesi
904f3c2564 Translation of using-native-node-modules to pt-br. 2015-10-15 10:52:30 -03:00
Cheng Zhao
d2b3d6d129 Merge pull request #3092 from atom/crash-reporter
Fix problems of crash-reporter on Windows
2015-10-15 19:29:29 +08:00
Cheng Zhao
909779babf spec: Bring back crash-reporter spec on x64 Windows 2015-10-15 18:25:34 +08:00
Cheng Zhao
f5c25d6277 win: Only install breakpad hook when crash-reporter is used 2015-10-15 18:25:07 +08:00
Cheng Zhao
d90b598125 win: Hook up V8 to breakpad
This fixes the crashes happens from V8 not caught by the crash reporter,
for more context, see http://code.google.com/p/v8/issues/detail?id=3597.

Fix #2365.
2015-10-15 16:36:30 +08:00
Cheng Zhao
55d5660ddb win: Make the event in crash service signaled by default
Otherwise it seems to block the crash client on some machines.

Fix #2769.
2015-10-15 16:36:29 +08:00
Cheng Zhao
11a49bba35 win: Fix "enable-larger-than-screen" option spec 2015-10-15 16:36:29 +08:00
Cheng Zhao
6aec8b092c views: Fix crash when setSizeConstrains is called early 2015-10-15 16:36:28 +08:00
Cheng Zhao
f52c4af605 win: Don't output newline except for main process 2015-10-15 12:44:55 +08:00
Plusb Preco
b61baacfe1 Merge pull request #1 from ibocon/translateIntoKR
Add `app.md` translation
2015-10-15 07:59:25 +09:00
Yegun Kim
79311af8eb translate "/docs-translations/ko-KR/api/app.md" 2015-10-15 16:26:24 -05:00
Jessica Lord
7a6ef0ec6e Merge pull request #3084 from kokdemo/master
translate the debugging-main-process.md
2015-10-14 13:58:27 -07:00
kokdemo
4270eba438 translate the debugging-main-process.md 2015-10-15 00:00:52 +08:00
Thomas Johansen
d14b59c754 Merge pull request #3082 from nikarc/patch-1
Update application-distribution.md
2015-10-14 12:42:18 +02:00
Nicholas Arcuri
95c4847d60 Update application-distribution.md
Fix typo on line 38
2015-10-14 06:28:27 -04:00
Cheng Zhao
74d389b2b0 Bump v0.33.8 2015-10-14 12:36:03 +08:00
Cheng Zhao
eb344f3f04 Merge pull request #2920 from atom/mas
Add MAS build
2015-10-14 12:34:46 +08:00
Cheng Zhao
b47076231c mas: Do not link with QTKit for mas build 2015-10-14 11:57:01 +08:00
Cheng Zhao
51335934c1 mac: Set CFBundleExecutable for Electron Framework 2015-10-14 11:54:59 +08:00
Cheng Zhao
d6842751bb mac: Don't specify CFBundleExecutable in framework 2015-10-14 11:54:59 +08:00
Cheng Zhao
96c15f19e3 mac: Set LSApplicationCategoryType in Info.plist 2015-10-14 11:54:58 +08:00
Cheng Zhao
9e51ff2b4b mac: Set CFBundleShortVersionString in Info.plist 2015-10-14 11:54:26 +08:00
Cheng Zhao
48faf74f7f mas: Use mas as platform name in dist 2015-10-14 11:53:53 +08:00
Cheng Zhao
df7a9b80b1 Fix linking error 2015-10-14 11:53:53 +08:00
Cheng Zhao
3afc9c4ebe spec: Disable crash reporter test for MAS build 2015-10-14 11:53:53 +08:00
Cheng Zhao
7b57a945f8 mac: Set process.mas to true for MAS build 2015-10-14 11:53:52 +08:00
Cheng Zhao
b62e3554dc mac: Disable auto updater in MAS build 2015-10-14 11:53:52 +08:00
Cheng Zhao
a9f5667899 mac: Disable crash reporter for MAS build 2015-10-14 11:53:52 +08:00
Cheng Zhao
644af0800c Update brightray for atom/brightray#156 2015-10-14 09:47:46 +08:00
Cheng Zhao
699dafc5db Merge pull request #3076 from kokdemo/master
translate the supported-platforms.md and update the README.md
2015-10-14 09:15:41 +08:00
kokdemo
d152b25fb6 translate the supported-platforms.md and update the README.md 2015-10-14 00:27:17 +08:00
Plusb Preco
af8049941e Update as upstream 2015-10-13 20:53:04 +09:00
Cheng Zhao
d9a4a41293 Merge pull request #3073 from wangdashuaihenshuai/master
doc-translations-zh-CN
2015-10-13 16:13:36 +08:00
Cheng Zhao
ddea2fced4 Merge pull request #3071 from alex-sherwin/patch-1
Fixing "tile" -> "title" typo
2015-10-13 09:32:22 +08:00
Cheng Zhao
34d49441b1 Merge pull request #3070 from deepak1556/v8_value_converter_patch
nativemate: handle binary types in v8 value conversion
2015-10-13 09:05:14 +08:00
Cheng Zhao
b9b25180f8 Update brightray for #2903 2015-10-13 09:04:10 +08:00
Alex Sherwin
b9d838975d Fixing "tile" -> "title" typo 2015-10-12 20:17:06 -04:00
Robo
5ff97c686a nativemate: handle binary types in v8 value conversion 2015-10-13 01:13:59 +05:30
Cheng Zhao
460adfa1bc Merge branch 'master' of https://github.com/preco21/electron into preco21-master 2015-10-12 09:42:10 +08:00
Cheng Zhao
ff9846da48 Merge pull request #3062 from kokdemo/master
translate the application-distrubution.md
2015-10-12 09:39:16 +08:00
Plusb Preco
9de9d2ecc1 Add missing paragraphs 2015-10-12 08:23:30 +09:00
Plusb Preco
799748cc5d Update as upstream, improve grammar 2015-10-12 08:19:44 +09:00
kokdemo
ab1f39589a Merge remote-tracking branch 'atom/master' 2015-10-11 22:28:44 +08:00
kokdemo
9419a2ec2c translate the application-distrubution.md 2015-10-11 22:26:14 +08:00
Cheng Zhao
c58ca76cac Merge pull request #3061 from flying-sheep/patch-1
fixed devtools instructions
2015-10-11 21:45:36 +08:00
Philipp A.
36bbf5d51f fixed devtools instructions 2015-10-11 15:18:27 +02:00
Cheng Zhao
8012792457 Merge pull request #3060 from etiktin/output_fixes
Output to console fixes
2015-10-11 15:19:07 +08:00
Cheng Zhao
2820fa8fd4 Merge pull request #3059 from osanyin/docs-translation
Some docs translated to pt-BR
2015-10-11 15:18:35 +08:00
jinhai.wang
bd95be23f3 fix docs-translations/zh-CN/api ipc-main-process.md '' -> bug 2015-10-11 14:56:23 +08:00
jinhai.wang
6ec184a2ce add new file: ipc-main-process.md 2015-10-11 13:52:06 +08:00
Eran Tiktin
cb903a09c0 Block all internal logs when running without --enable-logging 2015-10-10 20:44:22 +03:00
Eran Tiktin
4e8db2c3be Go back to using node's console.* and std*.write
It seems that whatever issues we had with using the original
implementation of node for `console.*` calls and for
`process.std*.write` on Windows were solved.
So I removed the patch.

Tested it with cmd, cygwin and used spawn and exec and everything seems
to work (except for colors/ansi escape codes, but that didn't work
before anyway).
2015-10-10 20:17:08 +03:00
Rafael Guimarães
692816f9d2 online-offline-events.md translated to pt-BR 2015-10-10 14:01:55 -03:00
Rafael Guimarães
0cd1195eea online-offline-events.md translated to pt-BR 2015-10-10 13:41:32 -03:00
Eran Tiktin
71fdb91f5c Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-10 18:16:55 +03:00
Cheng Zhao
6d20d37101 Bump v0.33.7 2015-10-10 17:43:56 +08:00
Cheng Zhao
df12f181a4 Can not print string16 in wcout on POSIX 2015-10-10 17:43:56 +08:00
Cheng Zhao
be5f1b09f4 Merge pull request #3056 from etiktin/fix_console_windows
Fix console.* calls on Windows
2015-10-10 17:32:15 +08:00
Plusb Preco
b5b6e30c8b Update as upstream 2015-10-10 15:10:34 +09:00
Plusb Preco
ccd17f060d Merge remote-tracking branch 'atom/master' 2015-10-10 15:10:24 +09:00
Eran Tiktin
c71efc8ca5 Fix process.std*.write
- Support printing Buffer
- Don't add '\n' at the end the chunk
2015-10-10 08:13:27 +03:00
Cheng Zhao
8278ee533d Merge pull request #3055 from kokdemo/master
add translate of app.md in zh-CN
2015-10-10 12:25:48 +08:00
Rafael Guimarães
b6cfa6f967 Copying online-offline-events.md file 2015-10-10 01:20:42 -03:00
Eran Tiktin
1896deb10e Fix console.* calls on Windows
- Calls for console.* on browser process are printed with no need for
--enable-logging
- The output is without the logging prefix
- The cursor in the terminal is always after the last output
- The first output starts on a new line and not at the prompt
- console.* from renderer are not printed to cmd
- Added a missing '\n' in the default_app help output
2015-10-10 06:39:02 +03:00
kokdemo
095b2e6047 add translate of app.md in zh-CN 2015-10-10 11:33:14 +08:00
Eran Tiktin
e682dc7544 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-10-10 06:01:01 +03:00
Rafael Guimarães
4392f1d77c Some fixes 2015-10-09 22:47:07 -03:00
Rafael Guimarães
288572f08e README.md updated 2015-10-09 22:17:21 -03:00
Rafael Guimarães
6cbbce544f Translation to pt-BR of the desktop-environment-integration.md file 2015-10-09 22:15:14 -03:00
Cheng Zhao
8127bbc992 Merge pull request #3046 from mariozaizar/better-translations
Missing translations for ES lang.
2015-10-10 09:13:53 +08:00
Mario Zaizar
9fd46ac4db Revert vendor/ changes added by mistake. 2015-10-09 09:17:54 -07:00
Mario Zaizar
1e13159157 Merge branch 'master' of https://github.com/atom/electron into better-translations 2015-10-09 08:58:07 -07:00
Cheng Zhao
215ca78c7f Update brightray for #3048 2015-10-09 21:08:00 +08:00
Cheng Zhao
0404cc850b Merge pull request #3048 from deepak1556/accept_language_patch
browser: get accept-language header from system locale
2015-10-09 21:05:57 +08:00
Robo
fb5260eb30 browser: get accept-language header from system locale 2015-10-09 13:18:37 +05:30
Mario Zaizar
28b3678159 Removing "Rebranding", "Empaquetamiento" and other minor changes to es/tutorial/application-distribution.md 2015-10-08 23:55:32 -07:00
Mario Zaizar
965471d9f8 Merge branch 'master' of https://github.com/atom/electron into better-translations 2015-10-08 23:24:23 -07:00
Mario Zaizar
d7c67d795b Merge remote-tracking branch 'atom/master' into better-translations 2015-10-08 23:19:32 -07:00
Mario Zaizar
841407a619 Breakdown a super long line inside styleguide.md 2015-10-08 23:19:16 -07:00
Mario Zaizar
1759a71814 Adding /docs-translations/es/styleguide.md 2015-10-08 23:16:15 -07:00
Mario Zaizar
d61bec0fb8 Adding missing links to /docs-translations/es/README.md and improving some texts. 2015-10-08 22:56:11 -07:00
Cheng Zhao
442db4c5ba Merge branch 'xcode-7' of https://github.com/joshaber/electron into joshaber-xcode-7 2015-10-09 12:29:45 +08:00
Cheng Zhao
922fce1892 Merge pull request #3040 from theojulienne/accessibility-fixes
Fix Text to Speech on OS X 10.11
2015-10-09 12:25:11 +08:00
Cheng Zhao
38b27bbd66 Merge pull request #3036 from renatoalencar/master
Add pt-BR translation for quick-start guide
2015-10-09 10:17:02 +08:00
Theo Julienne
6bc59cf2d7 Enable accessibility tree only when VoiceOver enabled, fixes atom/atom#3288. 2015-10-08 15:56:26 -07:00
Theo Julienne
957de56343 NSWorkspace selectFile:inFileViewerRootedAtPath: requires a non-null second argument. 2015-10-08 11:25:05 -07:00
Renato Alencar
1a2b5834ed Merge branch 'master' of https://www.github.com/atom/electron 2015-10-08 12:41:56 -03:00
Cheng Zhao
59b43a6571 Merge pull request #3025 from janwiemers/master
add a --app parameter to the default_app
2015-10-08 16:26:05 +08:00
Jan Wiemers
1a55cd3efe remove the --app option from the default_app documentation 2015-10-08 10:22:37 +02:00
Cheng Zhao
c8122392de Merge pull request #3033 from deepak1556/response_headers_patch
webcontents: dont modify response header value
2015-10-08 16:16:23 +08:00
Cheng Zhao
8b7d2b5ce3 Update brightray and crashpad for XCode 7 fixes 2015-10-08 16:09:22 +08:00
Robo
d9c6cf7b75 webcontents: dont modify response header value 2015-10-08 11:31:41 +05:30
Cheng Zhao
e1318ffb34 Merge pull request #3010 from deepak1556/guest_zoom_level_patch
webcontents: notify guests of embedders' zoom level change
2015-10-08 13:52:22 +08:00
Robo
7756bb6762 webcontents: notify guests of embedders' zoom level change 2015-10-08 10:38:22 +05:30
Cheng Zhao
d9cf9a7cbc docs: Fix wrong level for API titles 2015-10-08 11:14:04 +08:00
Cheng Zhao
87faae1b13 Merge pull request #3027 from stevekinney/minor-style-update-global-shortcut
Minor style update to the global-shortcut documentation
2015-10-08 10:47:39 +08:00
Cheng Zhao
051548aa69 Merge pull request #3024 from preco21/master
Improve grammar, fix small typos
2015-10-08 10:47:00 +08:00
Cheng Zhao
9dd714f056 Fix postMessage not working for windows opened by window.open 2015-10-08 10:44:30 +08:00
Cheng Zhao
fe4d86925b Merge pull request #3020 from atom/fix-switch-path
Fix a wrong usage of switch commandline.
2015-10-08 10:37:09 +08:00
Cheng Zhao
617892400f Merge pull request #3030 from atom/fix-xcode-6
Fix building with Xcode 6
2015-10-08 10:31:41 +08:00
Cheng Zhao
73ab6d409b Fix building with Xcode 6 2015-10-08 10:19:24 +08:00
Cheng Zhao
55715bec23 Merge pull request #3017 from Meyito/API-es
Translations of some of the Electron docs API in Spanish
2015-10-08 09:37:21 +08:00
Cheng Zhao
115526424a Move native modules to optionalDependencies
Fixes #3016.
2015-10-08 09:25:31 +08:00
Renato Alencar
aebc1d0650 grammar and corrections 2015-10-07 18:57:43 -03:00
Jan Wiemers
c7dc901607 add --app parameter and update the example usage in the default_app #1877 2015-10-07 23:22:00 +02:00
Renato Alencar
b1ae60a639 grammar corrections 2015-10-07 14:24:09 -03:00
Renato Alencar
7e7b6df72b Merge branch 'master' of https://github.com/renatoalencar/electron 2015-10-07 14:13:27 -03:00
Renato Alencar
05f0b5a8a4 add quick-start guide pt-BR translation 2015-10-07 14:11:58 -03:00
Steve Kinney
2978beaeb7 💄 Add preposition to globalShortcut.unregisterAll() 2015-10-07 09:03:46 -07:00
Steve Kinney
6f61832a34 💄 Add semicolon to global-shortcut code example
This keeps this line consistent with the rest of the documentation.
2015-10-07 09:03:11 -07:00
Plusb Preco
63c1fdd22a Improve grammar
* Improve the `auto-updater.md` content grammar.
2015-10-07 20:46:57 +09:00
Plusb Preco
3966441d21 Fix small typos 2015-10-07 20:20:34 +09:00
Plusb Preco
579f253340 Fix small typo 2015-10-07 20:19:37 +09:00
Haojian Wu
821005e6b4 Fix a wrong usage of switch commandline.
We should not always save switch path as ascii string, which will not be
handled well on Windows.
2015-10-07 12:17:49 +08:00
Haojian Wu
dcb457e76e Refine API design: desktopCapturer.getSources. 2015-10-07 11:10:35 +08:00
Meyito
871571c65e Translations of some of the Electron docs API in Spanish 2015-10-06 22:09:57 -05:00
joshaber
326af3cbe3 Use Xcode 7. 2015-10-06 16:34:20 -04:00
joshaber
4c3fd38774 This now has to be non-nil. 2015-10-06 16:15:03 -04:00
joshaber
74be1d5b25 ++brightray 2015-10-06 16:14:49 -04:00
joshaber
cab466f999 ++crashpad 2015-10-06 16:14:44 -04:00
joshaber
4cb3e2ecb5 Merge remote-tracking branch 'atom/master' 2015-10-06 14:24:05 -04:00
Eran Tiktin
cb22b88e6a Merge pull request #9 from atom/master
Update from original
2015-10-06 19:26:36 +03:00
Cheng Zhao
5bdc077b48 Update brightray for #2855 2015-10-06 22:45:00 +08:00
Cheng Zhao
927c3f34c3 Guard against undefined, fix #2995
In theory this should never happen, seems like some object is garbage
collected after the JavaScript context has been destroyed.
2015-10-06 22:25:55 +08:00
Cheng Zhao
c916baa939 Update brightray, fix #2315 2015-10-06 21:40:08 +08:00
Cheng Zhao
3a97439fe9 Merge pull request #3005 from preco21/master
Update as upstream
2015-10-06 21:27:50 +08:00
Plusb Preco
c6d5a92d34 Update as upstream 2015-10-06 19:53:35 +09:00
Cheng Zhao
2d802d6f1e Merge branch 'master' into no-vistas-no-problem 2015-10-06 17:02:08 +08:00
Cheng Zhao
fa59ea3bc5 Merge pull request #2998 from brenca/master
Minor fixes to sendInputEvent API.
2015-10-06 16:56:26 +08:00
Cheng Zhao
804cf5e8ba Merge pull request #2994 from etiktin/update_native_modules_doc
Update native modules doc
2015-10-06 16:55:25 +08:00
Cheng Zhao
fc0153f0bc Merge pull request #2993 from etiktin/update_screen_doc
Update screen.md
2015-10-06 16:55:16 +08:00
Cheng Zhao
c823e31904 Merge pull request #2992 from etiktin/update_process_doc
Update process.md
2015-10-06 16:55:10 +08:00
Cheng Zhao
2ef66cb660 Merge pull request #2997 from atom/size-constraints
Improve how we handle min/max sizes
2015-10-06 16:54:45 +08:00
Cheng Zhao
f607e81fac views: Make size constraints work immediately after set 2015-10-06 16:16:02 +08:00
Cheng Zhao
e06778178a linux: Restore size constraints when became sizable 2015-10-06 16:09:03 +08:00
Cheng Zhao
f6327de7f7 spec: Increase timeout for window.open specs 2015-10-06 16:08:32 +08:00
Cheng Zhao
8e40947938 spec: Make window.open specs more reliable 2015-10-06 15:43:36 +08:00
Cheng Zhao
898db4d6bd osx: Set resizable flag when creating window
Setting resizable for frameless window before it is shown will change
its size.
2015-10-06 15:23:23 +08:00
Cheng Zhao
6fea6cf58a osx: Fix setting size constraints for frameless window 2015-10-06 15:15:23 +08:00
Cheng Zhao
428c5b6d01 Setting "x" and "y" should not change window size 2015-10-06 14:50:18 +08:00
Plusb Preco
3f37439da3 Merge remote-tracking branch 'atom/master' 2015-10-06 13:55:06 +09:00
Plusb Preco
db46c1b925 Update as upstream 2015-10-06 13:48:39 +09:00
Eran Tiktin
c3cd438d34 Replace io.js references with node.js references 2015-10-05 21:12:29 +03:00
Heilig Benedek
ccf4ed907a Fix some minor bugs related to KeyboardEvent sending 2015-10-05 19:11:20 +02:00
Cheng Zhao
b70e7c6a4c Remove default definition of ContentSizeToWindowSize 2015-10-06 00:39:16 +08:00
Heilig Benedek
4d302956d3 Merge pull request #1 from atom/master
update
2015-10-05 18:32:04 +02:00
Cheng Zhao
c8723238f8 win: Fix building on Windows 2015-10-06 00:21:37 +08:00
Cheng Zhao
60fb406c61 views: Fix content size constraints in window with menubar 2015-10-06 00:15:47 +08:00
Cheng Zhao
bb49515145 Separate Windows specific code of NativeWindow to another file 2015-10-06 00:13:57 +08:00
Eran Tiktin
87e0c812e9 Update native modules doc 2015-10-05 17:48:48 +03:00
Eran Tiktin
ea3e84e7ff Update screen.md
Removed a trailing comma.
2015-10-05 16:56:36 +03:00
Eran Tiktin
239b97cde1 Update process.md
Fixed the `loaded` example according to
[this](https://github.com/atom/electron/issues/2984#issuecomment-145465907)
comment.
2015-10-05 16:51:49 +03:00
Eran Tiktin
c22ffd863b Merge pull request #8 from atom/master
Update from original
2015-10-05 16:41:30 +03:00
Cheng Zhao
857acd2574 win: Fix GetContentSize for minimized window 2015-10-05 21:06:57 +08:00
Cheng Zhao
3b1ee994e2 views: Remove hack on setting min/max size for frameless window 2015-10-05 20:37:08 +08:00
Cheng Zhao
e675407552 Make min/max size respect use-content-size 2015-10-05 20:36:28 +08:00
Cheng Zhao
d19ead1907 osx: Call setContentMinSize in SetContentSizeConstraints 2015-10-05 20:09:29 +08:00
Cheng Zhao
a9b0111c3e views: Use the quicker way of return content size
Converting content size to window size on high DPI systems will lose
percise and have 1px offset sometimes.
2015-10-05 20:07:20 +08:00
Cheng Zhao
279407f7a3 osx: Fix converting size for frameless window 2015-10-05 20:07:20 +08:00
Cheng Zhao
a76ea00249 views: Implement NativeWindow::SetSizeConstraints 2015-10-05 20:07:20 +08:00
Cheng Zhao
8577f2b52f osx: Add NativeWindow::SetSizeConstraints 2015-10-05 20:07:20 +08:00
Cheng Zhao
526cee7ec3 Merge tag 'v0.33.6' 2015-10-05 19:58:47 +08:00
Cheng Zhao
2b9b4c6789 Merge pull request #2979 from etiktin/fix_calculating_min_max_4_frameless
Fix calculating min/max size in frameless view
2015-10-05 15:10:27 +08:00
Cheng Zhao
de24ed7cea Merge pull request #2985 from etiktin/fix_restore_size_windows
[Windows] Fix restore/unmaximize wrong window size
2015-10-05 15:09:24 +08:00
Haojian Wu
36c0ad7fda Refine more about desktop capturer API.
* Simplify the coffeescript code.
* Add more options in desktopCapturer.startUpdating.
2015-10-05 12:47:01 +08:00
Eran Tiktin
c34c123b33 Make it work only on Windows
Limiting the solution to Windows only.
2015-10-05 04:01:25 +03:00
Eran Tiktin
4d02fc58fa Fix restore/unmaximize wrong window size
This resolves #2498.
2015-10-05 03:29:02 +03:00
Haojian Wu
1e69ef79de Refine: make desktop-capturer as a renderer module. 2015-10-04 22:04:41 +08:00
Eran Tiktin
aea1f8aebb Fix calculating min/max size in frameless views
The minimum and maximum size that frameless windows had used, was
incorrect. It included the border, so when it was called it actually
added that to the size, so window increased in size. The fix makes sure
that the view will use the frameless size.

This fixes #2945 and partially fixes #1806 (it also refers to some other
issues with hidpi which might still exist).
2015-10-03 22:09:57 +03:00
Paul Betts
bb938b02d8 Remove Vista as possibly working
Vista crashes on startup because Win7 touch APIs aren't present - this is fine, but we want to tell people out of the gate that it won't work
2015-10-03 09:02:50 -07:00
Haojian Wu
48fbd47416 Make desktop capture API work on Windows. 2015-10-03 10:51:02 +08:00
Eran Tiktin
8c31c7fb59 Merge pull request #7 from atom/master
Update from original
2015-10-03 01:25:23 +03:00
Haojian Wu
c9fbde321c Implement desktop capture API on OS X. 2015-10-02 19:17:28 +08:00
joshaber
2365ffe143 Merge remote-tracking branch 'atom/master' 2015-09-20 22:46:36 +01:00
Patrick Detlefsen
6c4016af46 make sure the query params are stripped from the updateUrl 2015-06-22 15:51:47 +02:00
Patrick Detlefsen
154ca8575c limit the auto-updater-win api to very few methods 2015-06-22 15:33:08 +02:00
Patrick Detlefsen
ae5411c37b move squirrel bahaviour into proper place 2015-06-22 15:17:07 +02:00
Patrick Detlefsen
62882fe49e auto updater win is an EventEmitter already 2015-06-16 16:13:23 +02:00
Patrick Detlefsen
a8469fc79d auto-updater extends event-emitter 2015-06-16 12:31:55 +02:00
Patrick Detlefsen
7aa60baafb switch statement coffee else instead of default 2015-06-16 11:48:39 +02:00
Patrick Detlefsen
99f352228c addresses suggestions from pull-request 2015-06-16 11:04:37 +02:00
Patrick Detlefsen
621178f558 initial idea 2015-06-15 20:28:47 +02:00
1470 changed files with 117679 additions and 21589 deletions

35
.clang-format Normal file
View File

@@ -0,0 +1,35 @@
# Defines the Chromium style for automatic reformatting.
# http://clang.llvm.org/docs/ClangFormatStyleOptions.html
BasedOnStyle: Chromium
# This defaults to 'Auto'. Explicitly set it for a while, so that
# 'vector<vector<int> >' in existing files gets formatted to
# 'vector<vector<int>>'. ('Auto' means that clang-format will only use
# 'int>>' if the file already contains at least one such instance.)
Standard: Cpp11
# Make sure code like:
# IPC_BEGIN_MESSAGE_MAP()
# IPC_MESSAGE_HANDLER(WidgetHostViewHost_Update, OnUpdate)
# IPC_END_MESSAGE_MAP()
# gets correctly indented.
MacroBlockBegin: "^\
BEGIN_MSG_MAP|\
BEGIN_MSG_MAP_EX|\
BEGIN_SAFE_MSG_MAP_EX|\
CR_BEGIN_MSG_MAP_EX|\
IPC_BEGIN_MESSAGE_MAP|\
IPC_BEGIN_MESSAGE_MAP_WITH_PARAM|\
IPC_PROTOBUF_MESSAGE_TRAITS_BEGIN|\
IPC_STRUCT_BEGIN|\
IPC_STRUCT_BEGIN_WITH_PARENT|\
IPC_STRUCT_TRAITS_BEGIN|\
POLPARAMS_BEGIN|\
PPAPI_BEGIN_MESSAGE_MAP$"
MacroBlockEnd: "^\
CR_END_MSG_MAP|\
END_MSG_MAP|\
IPC_END_MESSAGE_MAP|\
IPC_PROTOBUF_MESSAGE_TRAITS_END|\
IPC_STRUCT_END|\
IPC_STRUCT_TRAITS_END|\
POLPARAMS_END|\
PPAPI_END_MESSAGE_MAP$"

14
.gitignore vendored
View File

@@ -1,9 +1,12 @@
.DS_Store
.tags*
/.idea/
/build/
/dist/
/external_binaries/
/out/
/vendor/brightray/vendor/download/
/vendor/debian_wheezy_amd64-sysroot/
/vendor/debian_wheezy_arm-sysroot/
/vendor/debian_wheezy_i386-sysroot/
/vendor/python_26/
@@ -15,5 +18,12 @@ node_modules/
*.xcodeproj
*.swp
*.pyc
debug.log
npm-debug.log
*.VC.db
*.VC.VC.opendb
.vs/
.vscode/
*.vcxproj
*.vcxproj.user
*.vcxproj.filters
*.sln
*.log

13
.gitmodules vendored
View File

@@ -1,24 +1,27 @@
[submodule "vendor/brightray"]
path = vendor/brightray
url = https://github.com/atom/brightray.git
url = https://github.com/electron/brightray.git
[submodule "vendor/node"]
path = vendor/node
url = https://github.com/atom/node.git
url = https://github.com/electron/node.git
[submodule "vendor/depot_tools"]
path = vendor/depot_tools
url = https://chromium.googlesource.com/chromium/tools/depot_tools.git
[submodule "vendor/breakpad"]
path = vendor/breakpad
url = https://github.com/atom/chromium-breakpad.git
url = https://github.com/electron/chromium-breakpad.git
[submodule "vendor/native_mate"]
path = vendor/native_mate
url = https://github.com/zcbenz/native-mate.git
url = https://github.com/electron/native-mate.git
[submodule "vendor/crashpad"]
path = vendor/crashpad
url = https://github.com/atom/crashpad.git
url = https://github.com/electron/crashpad.git
[submodule "vendor/requests"]
path = vendor/requests
url = https://github.com/kennethreitz/requests
[submodule "vendor/boto"]
path = vendor/boto
url = https://github.com/boto/boto.git
[submodule "vendor/pdf_viewer"]
path = vendor/pdf_viewer
url = https://github.com/electron/pdf-viewer.git

1
.node-version Normal file
View File

@@ -0,0 +1 @@
v7.4.0

View File

@@ -3,13 +3,15 @@ git:
notifications:
email: false
language: cpp
compiler: clang
language: node_js
node_js:
- "4"
os:
- linux
- osx
env:
- TARGET_ARCH=x64
osx_image: xcode7.3
matrix:
include:
@@ -18,8 +20,7 @@ matrix:
- os: linux
env: TARGET_ARCH=ia32
allow_failures:
- env: TARGET_ARCH=arm
- env: TARGET_ARCH=ia32
- os: osx
script: './script/cibuild'

46
CODE_OF_CONDUCT.md Normal file
View File

@@ -0,0 +1,46 @@
# Contributor Covenant Code of Conduct
## Our Pledge
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
## Our Standards
Examples of behavior that contributes to creating a positive environment include:
* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
Examples of unacceptable behavior by participants include:
* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting
## Our Responsibilities
Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
## Scope
This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
## Enforcement
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [electron@github.com](mailto:electron@github.com). All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
## Attribution
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/

View File

@@ -1,9 +1,12 @@
# Contributing to Electron
:memo: Available Translations: [Korean](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Simplified Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Brazilian Portuguese](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) | [Dutch](https://github.com/electron/electron/tree/master/docs-translations/nl/project/CONTRIBUTING.md)
:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
This project adheres to the [Contributor Covenant 1.2](http://contributor-covenant.org/version/1/2/0).
By participating, you are expected to uphold this code. Please report unacceptable behavior to atom@github.com.
This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDUCT.md).
By participating, you are expected to uphold this code. Please report unacceptable
behavior to atom@github.com.
The following is a set of guidelines for contributing to Electron.
These are just guidelines, not rules, use your best judgment and feel free to
@@ -11,7 +14,7 @@ propose changes to this document in a pull request.
## Submitting Issues
* You can create an issue [here](https://github.com/atom/electron/issues/new),
* You can create an issue [here](https://github.com/electron/electron/issues/new),
but before doing that please read the notes below and include as many details as
possible with your report. If you can, please include:
* The version of Electron you are using
@@ -21,13 +24,13 @@ possible with your report. If you can, please include:
* Other things that will help resolve your issue:
* Screenshots and animated GIFs
* Error output that appears in your terminal, dev tools or as an alert
* Perform a [cursory search](https://github.com/atom/electron/issues?utf8=✓&q=is%3Aissue+)
* Perform a [cursory search](https://github.com/electron/electron/issues?utf8=✓&q=is%3Aissue+)
to see if a similar issue has already been submitted
## Submitting Pull Requests
* Include screenshots and animated GIFs in your pull request whenever possible.
* Follow the CoffeeScript, JavaScript, C++ and Python [coding style defined in docs](/docs/development/coding-style.md).
* Follow the JavaScript, C++, and Python [coding style defined in docs](/docs/development/coding-style.md).
* Write documentation in [Markdown](https://daringfireball.net/projects/markdown).
See the [Documentation Styleguide](/docs/styleguide.md).
* Use short, present tense commit messages. See [Commit Message Styleguide](#git-commit-messages).
@@ -57,13 +60,14 @@ possible with your report. If you can, please include:
* Use the imperative mood ("Move cursor to..." not "Moves cursor to...")
* Limit the first line to 72 characters or less
* Reference issues and pull requests liberally
* When only changing documentation, include `[ci skip]` in the commit description
* Consider starting the commit message with an applicable emoji:
* :art: `:art:` when improving the format/structure of the code
* :racehorse: `:racehorse:` when improving performance
* :non-potable_water: `:non-potable_water:` when plugging memory leaks
* :memo: `:memo:` when writing docs
* :penguin: `:penguin:` when fixing something on Linux
* :apple: `:apple:` when fixing something on Mac OS
* :apple: `:apple:` when fixing something on macOS
* :checkered_flag: `:checkered_flag:` when fixing something on Windows
* :bug: `:bug:` when fixing a bug
* :fire: `:fire:` when removing code or files

35
ISSUE_TEMPLATE.md Normal file
View File

@@ -0,0 +1,35 @@
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version:
* Operating system:
### Expected behavior
<!-- What do you think should happen? -->
### Actual behavior
<!-- What actually happens? -->
### How to reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run.
You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes.
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
-->

View File

@@ -1,4 +1,4 @@
Copyright (c) 2014 GitHub Inc.
Copyright (c) 2013-2017 GitHub Inc.
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the

View File

@@ -1,58 +0,0 @@
[![Electron Logo](http://electron.atom.io/images/electron-logo.svg)](http://electron.atom.io/)
[![Build Status](https://travis-ci.org/atom/electron.svg?branch=master)](https://travis-ci.org/atom/electron)
[![devDependency Status](https://david-dm.org/atom/electron/dev-status.svg)](https://david-dm.org/atom/electron#info=devDependencies)
[![Join the Electron Community on Slack](http://atom-slack.herokuapp.com/badge.svg)](http://atom-slack.herokuapp.com/)
### [Electron](https://github.com/atom/electron/) 한국어 참조문서
:zap: *프레임워크 이름이 Atom Shell에서 Electron으로 변경되었습니다* :zap:
Electron 프레임워크는 JavaScript, HTML 그리고 CSS를 사용하여 Cross-Platform 데스크톱 어플리케이션을 개발할 수 있도록 해주는 프레임워크입니다. 이 프레임워크는 [io.js](http://iojs.org) 와
[Chromium](http://www.chromium.org)을 기반으로 만들어 졌으며 [Atom Editor](https://github.com/atom/atom)에 사용되고 있습니다.
Electron에 대한 중요한 알림을 받고 싶다면 Twitter에서 [@ElectronJS](https://twitter.com/electronjs)를 팔로우 하세요.
이 프로젝트는 기여자 규약 1.2를 준수합니다. 이 프로젝트에 참여할 때 코드를 유지해야 합니다. 받아들일 수 없는 행동은 atom@github.com로 보고 하십시오.
## 다운로드
Linux, Windows, Mac용으로 미리 빌드된 Electron 바이너리와 디버그 심볼이 준비되어 있습니다. [releases](https://github.com/atom/electron/releases) 페이지에서 받아 볼 수 있습니다.
또한 [`npm`](https://docs.npmjs.com/)을 통해 미리 빌드된 Electron 바이너리를 받을 수도 있습니다:
```sh
# $PATH에 `electron` 커맨드를 등록하고 전역에 설치합니다.
npm install electron-prebuilt -g
# 개발 의존성 모듈 형태로 설치합니다.
npm install electron-prebuilt --save-dev
```
### 미러
- [China](https://npm.taobao.org/mirrors/electron)
## 참조 문서
[Docs](https://github.com/atom/electron/tree/master/docs/README.md)에 개발 가이드와 API 레퍼런스가 있습니다.
Electron을 빌드 하는 방법과 프로젝트에 기여하는 방법도 문서에 포함되어 있으니 참고하시기 바랍니다.
## 참조 문서 (번역)
- [브라질 포르투칼어](https://github.com/atom/electron/tree/master/docs-translations/pt-BR)
- [한국어](https://github.com/atom/electron/tree/master/docs-translations/ko-KR)
- [일본어](https://github.com/atom/electron/tree/master/docs-translations/jp)
- [스페인어](https://github.com/atom/electron/tree/master/docs-translations/es)
- [중국어 간체](https://github.com/atom/electron/tree/master/docs-translations/zh-CN)
- [중국어 번체](https://github.com/atom/electron/tree/master/docs-translations/zh-TW)
## 커뮤니티
다음 링크를 통해 커뮤니티에 질문을 올리거나 토론을 나누실 수 있습니다:
- Atom 포럼의 [`electron`](http://discuss.atom.io/category/electron) 카테고리
- Freenode 채팅의 `#atom-shell` 채널
- Slack의 [`Atom`](http://atom-slack.herokuapp.com/) 채널
[awesome-electron](https://github.com/sindresorhus/awesome-electron) 프로젝트엔 커뮤니티가 운영중인 유용한 예제 어플리케이션과 도구, 리소스가 있으니 한번 참고해 보시기 바랍니다.

View File

@@ -1,39 +1,40 @@
[![Electron Logo](http://electron.atom.io/images/electron-logo.svg)](http://electron.atom.io/)
[![Electron Logo](https://electron.atom.io/images/electron-logo.svg)](https://electron.atom.io/)
[![Build Status](https://travis-ci.org/atom/electron.svg?branch=master)](https://travis-ci.org/atom/electron)
[![devDependency Status](https://david-dm.org/atom/electron/dev-status.svg)](https://david-dm.org/atom/electron#info=devDependencies)
[![Travis Build Status](https://travis-ci.org/electron/electron.svg?branch=master)](https://travis-ci.org/electron/electron)
[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/bc56v83355fi3369/branch/master?svg=true)](https://ci.appveyor.com/project/electron-bot/electron/branch/master)
[![devDependency Status](https://david-dm.org/electron/electron/dev-status.svg)](https://david-dm.org/electron/electron?type=dev)
[![Join the Electron Community on Slack](http://atom-slack.herokuapp.com/badge.svg)](http://atom-slack.herokuapp.com/)
:zap: *Formerly known as Atom Shell* :zap:
:memo: Available Translations: [Korean](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/README.md) | [Simplified Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/README.md) | [Brazilian Portuguese](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/README.md) | [Traditional Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-TW/project/README.md) | [Spanish](https://github.com/electron/electron/tree/master/docs-translations/es/project/README.md) | [Turkish](https://github.com/electron/electron/tree/master/docs-translations/tr-TR/project/README.md)
The Electron framework lets you write cross-platform desktop applications
using JavaScript, HTML and CSS. It is based on [io.js](http://iojs.org) and
[Chromium](http://www.chromium.org) and is used in the [Atom
editor](https://github.com/atom/atom).
using JavaScript, HTML and CSS. It is based on [Node.js](https://nodejs.org/) and
[Chromium](http://www.chromium.org) and is used by the [Atom
editor](https://github.com/atom/atom) and many other [apps](https://electron.atom.io/apps).
Follow [@ElectronJS](https://twitter.com/electronjs) on Twitter for important
announcements.
This project adheres to the [Contributor Covenant 1.2](http://contributor-covenant.org/version/1/2/0).
By participating, you are expected to uphold this code. Please report
unacceptable behavior to atom@github.com.
This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDUCT.md).
By participating, you are expected to uphold this code. Please report unacceptable
behavior to electron@github.com.
## Downloads
Prebuilt binaries and debug symbols of Electron for Linux, Windows and Mac can
be found on the [releases](https://github.com/atom/electron/releases) page.
You can also use [`npm`](https://docs.npmjs.com/) to install prebuilt electron
binaries:
To install prebuilt Electron binaries, use
[`npm`](https://docs.npmjs.com/):
```sh
# Install the `electron` command globally in your $PATH
npm install electron-prebuilt -g
# Install as a development dependency
npm install electron-prebuilt --save-dev
npm install electron --save-dev
# Install the `electron` command globally in your $PATH
npm install electron -g
```
See the [releases page](https://github.com/electron/electron/releases) for
prebuilt binaries, debug symbols, and more.
### Mirrors
- [China](https://npm.taobao.org/mirrors/electron)
@@ -41,26 +42,48 @@ npm install electron-prebuilt --save-dev
## Documentation
Guides and the API reference are located in the
[docs](https://github.com/atom/electron/tree/master/docs) directory. It also
[docs](https://github.com/electron/electron/tree/master/docs) directory. It also
contains documents describing how to build and contribute to Electron.
## Documentation Translations
- [Brazilian Portuguese](https://github.com/atom/electron/tree/master/docs-translations/pt-BR)
- [Korean](https://github.com/atom/electron/tree/master/docs-translations/ko-KR)
- [Japanese](https://github.com/atom/electron/tree/master/docs-translations/jp)
- [Spanish](https://github.com/atom/electron/tree/master/docs-translations/es)
- [Simplified Chinese](https://github.com/atom/electron/tree/master/docs-translations/zh-CN)
- [Traditional Chinese](https://github.com/atom/electron/tree/master/docs-translations/zh-TW)
- [Brazilian Portuguese](https://github.com/electron/electron/tree/master/docs-translations/pt-BR)
- [Korean](https://github.com/electron/electron/tree/master/docs-translations/ko-KR)
- [Japanese](https://github.com/electron/electron/tree/master/docs-translations/jp)
- [Spanish](https://github.com/electron/electron/tree/master/docs-translations/es)
- [Simplified Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-CN)
- [Traditional Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-TW)
- [Turkish](https://github.com/electron/electron/tree/master/docs-translations/tr-TR)
- [Thai](https://github.com/electron/electron/tree/master/docs-Translations/th-TH)
- [Ukrainian](https://github.com/electron/electron/tree/master/docs-translations/uk-UA)
- [Russian](https://github.com/electron/electron/tree/master/docs-translations/ru-RU)
- [French](https://github.com/electron/electron/tree/master/docs-translations/fr-FR)
## Quick Start
Clone and run the [`electron/electron-quick-start`](https://github.com/electron/electron-quick-start)
repository to see a minimal Electron app in action.
## Community
You can ask questions and interact with the community in the following
locations:
- [`electron`](http://discuss.atom.io/category/electron) category on the Atom
- [`electron`](http://discuss.atom.io/c/electron) category on the Atom
forums
- `#atom-shell` channel on Freenode
- [`Atom`](http://atom-slack.herokuapp.com/) channel on Slack
- [`electron-ru`](https://telegram.me/electron_ru) *(Russian)*
- [`electron-br`](https://electron-br.slack.com) *(Brazilian Portuguese)*
- [`electron-kr`](http://www.meetup.com/electron-kr/) *(Korean)*
- [`electron-jp`](https://electron-jp.slack.com) *(Japanese)*
- [`electron-tr`](http://electron-tr.herokuapp.com) *(Turkish)*
- [`electron-id`](https://electron-id.slack.com) *(Indonesia)*
Check out [awesome-electron](https://github.com/sindresorhus/awesome-electron)
for a community maintained list of useful example apps, tools and resources.
## License
[MIT](https://github.com/electron/electron/blob/master/LICENSE)
When using the Electron or other GitHub logos, be sure to follow the [GitHub logo guidelines](https://github.com/logos).

9
SECURITY.md Normal file
View File

@@ -0,0 +1,9 @@
# Reporting Security Issues
The Electron team and community take security bugs in Electron seriously. We appreciate your efforts to responsibly disclose your findings, and will make every effort to acknowledge your contributions.
To report a security issue, email [electron@github.com](mailto:electron@github.com) and include the word "SECURITY" in the subject line.
The Electron team will send a response indicating the next steps in handling your report. After the initial reply to your report, the security team will keep you informed of the progress towards a fix and full announcement, and may ask for additional information or guidance.
Report security bugs in third-party modules to the person or team maintaining the module. You can also report a vulnerability through the [Node Security Project](https://nodesecurity.io/report).

25
appveyor.yml Normal file
View File

@@ -0,0 +1,25 @@
# appveyor file
# http://www.appveyor.com/docs/appveyor-yml
version: "{build}"
os: Visual Studio 2015
init:
- git config --global core.autocrlf input
platform:
- x86
- x64
install:
- cmd: SET PATH=C:\Program Files (x86)\MSBuild\14.0\bin\;%PATH%
- cmd: SET PATH=C:\python27;%PATH%
- cmd: python script/cibuild
branches:
only:
- master
# disable build and test pahses
build: off
test: off

1
atom/CPPLINT.cfg Normal file
View File

@@ -0,0 +1 @@
filter=+build/include_alpha

View File

@@ -7,16 +7,27 @@
#include <string>
#include <vector>
#include "atom/common/atom_constants.h"
#include "atom/common/atom_version.h"
#include "atom/common/chrome_version.h"
#include "atom/common/options_switches.h"
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/pepper_plugin_info.h"
#include "content/public/common/user_agent.h"
#include "pdf/pdf.h"
#include "ppapi/shared_impl/ppapi_permissions.h"
#include "third_party/widevine/cdm/stub/widevine_cdm_version.h"
#include "ui/base/l10n/l10n_util.h"
#include "url/url_constants.h"
#if defined(WIDEVINE_CDM_AVAILABLE) && BUILDFLAG(ENABLE_PEPPER_CDMS)
#include "chrome/common/widevine_cdm_constants.h"
#endif
namespace atom {
@@ -31,9 +42,9 @@ content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
plugin.path = path;
plugin.permissions = ppapi::PERMISSION_ALL_BITS;
std::vector<std::string> flash_version_numbers;
base::SplitString(version, '.', &flash_version_numbers);
if (flash_version_numbers.size() < 1)
std::vector<std::string> flash_version_numbers = base::SplitString(
version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
if (flash_version_numbers.empty())
flash_version_numbers.push_back("11");
// |SplitString()| puts in an empty string given an empty string. :(
else if (flash_version_numbers[0].empty())
@@ -47,7 +58,7 @@ content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
// E.g., "Shockwave Flash 10.2 r154":
plugin.description = plugin.name + " " + flash_version_numbers[0] + "." +
flash_version_numbers[1] + " r" + flash_version_numbers[2];
plugin.version = JoinString(flash_version_numbers, '.');
plugin.version = base::JoinString(flash_version_numbers, ".");
content::WebPluginMimeType swf_mime_type(
content::kFlashPluginSwfMimeType,
content::kFlashPluginSwfExtension,
@@ -62,8 +73,111 @@ content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
return plugin;
}
#if defined(WIDEVINE_CDM_AVAILABLE) && BUILDFLAG(ENABLE_PEPPER_CDMS)
content::PepperPluginInfo CreateWidevineCdmInfo(const base::FilePath& path,
const std::string& version) {
content::PepperPluginInfo widevine_cdm;
widevine_cdm.is_out_of_process = true;
widevine_cdm.path = path;
widevine_cdm.name = kWidevineCdmDisplayName;
widevine_cdm.description = kWidevineCdmDescription +
std::string(" (version: ") +
version + ")";
widevine_cdm.version = version;
content::WebPluginMimeType widevine_cdm_mime_type(
kWidevineCdmPluginMimeType,
kWidevineCdmPluginExtension,
kWidevineCdmPluginMimeTypeDescription);
// Add the supported codecs as if they came from the component manifest.
std::vector<std::string> codecs;
codecs.push_back(kCdmSupportedCodecVp8);
codecs.push_back(kCdmSupportedCodecVp9);
#if defined(USE_PROPRIETARY_CODECS)
codecs.push_back(kCdmSupportedCodecAvc1);
#endif // defined(USE_PROPRIETARY_CODECS)
std::string codec_string = base::JoinString(
codecs, std::string(1, kCdmSupportedCodecsValueDelimiter));
widevine_cdm_mime_type.additional_param_names.push_back(
base::ASCIIToUTF16(kCdmSupportedCodecsParamName));
widevine_cdm_mime_type.additional_param_values.push_back(
base::ASCIIToUTF16(codec_string));
widevine_cdm.mime_types.push_back(widevine_cdm_mime_type);
widevine_cdm.permissions = kWidevineCdmPluginPermissions;
return widevine_cdm;
}
#endif
void ComputeBuiltInPlugins(std::vector<content::PepperPluginInfo>* plugins) {
content::PepperPluginInfo pdf_info;
pdf_info.is_internal = true;
pdf_info.is_out_of_process = true;
pdf_info.name = "Chromium PDF Viewer";
pdf_info.description = "Portable Document Format";
pdf_info.path = base::FilePath::FromUTF8Unsafe(kPdfPluginPath);
content::WebPluginMimeType pdf_mime_type(kPdfPluginMimeType, "pdf",
"Portable Document Format");
pdf_info.mime_types.push_back(pdf_mime_type);
pdf_info.internal_entry_points.get_interface = chrome_pdf::PPP_GetInterface;
pdf_info.internal_entry_points.initialize_module =
chrome_pdf::PPP_InitializeModule;
pdf_info.internal_entry_points.shutdown_module =
chrome_pdf::PPP_ShutdownModule;
pdf_info.permissions = ppapi::PERMISSION_PRIVATE | ppapi::PERMISSION_DEV;
plugins->push_back(pdf_info);
}
void ConvertStringWithSeparatorToVector(std::vector<std::string>* vec,
const char* separator,
const char* cmd_switch) {
auto command_line = base::CommandLine::ForCurrentProcess();
auto string_with_separator = command_line->GetSwitchValueASCII(cmd_switch);
if (!string_with_separator.empty())
*vec = base::SplitString(string_with_separator, separator,
base::TRIM_WHITESPACE,
base::SPLIT_WANT_NONEMPTY);
}
} // namespace
void AddPepperFlashFromCommandLine(
std::vector<content::PepperPluginInfo>* plugins) {
auto command_line = base::CommandLine::ForCurrentProcess();
base::FilePath flash_path = command_line->GetSwitchValuePath(
switches::kPpapiFlashPath);
if (flash_path.empty())
return;
auto flash_version = command_line->GetSwitchValueASCII(
switches::kPpapiFlashVersion);
plugins->push_back(CreatePepperFlashInfo(flash_path, flash_version));
}
#if defined(WIDEVINE_CDM_AVAILABLE) && BUILDFLAG(ENABLE_PEPPER_CDMS)
void AddWidevineCdmFromCommandLine(
std::vector<content::PepperPluginInfo>* plugins) {
auto command_line = base::CommandLine::ForCurrentProcess();
base::FilePath widevine_cdm_path = command_line->GetSwitchValuePath(
switches::kWidevineCdmPath);
if (widevine_cdm_path.empty())
return;
if (!base::PathExists(widevine_cdm_path))
return;
auto widevine_cdm_version = command_line->GetSwitchValueASCII(
switches::kWidevineCdmVersion);
if (widevine_cdm_version.empty())
return;
plugins->push_back(CreateWidevineCdmInfo(widevine_cdm_path,
widevine_cdm_version));
}
#endif
AtomContentClient::AtomContentClient() {
}
@@ -80,35 +194,45 @@ std::string AtomContentClient::GetUserAgent() const {
ATOM_PRODUCT_NAME "/" ATOM_VERSION_STRING);
}
base::string16 AtomContentClient::GetLocalizedString(int message_id) const {
return l10n_util::GetStringUTF16(message_id);
}
void AtomContentClient::AddAdditionalSchemes(
std::vector<std::string>* standard_schemes,
std::vector<url::SchemeWithType>* standard_schemes,
std::vector<url::SchemeWithType>* referrer_schemes,
std::vector<std::string>* savable_schemes) {
auto command_line = base::CommandLine::ForCurrentProcess();
auto custom_schemes = command_line->GetSwitchValueASCII(
switches::kRegisterStandardSchemes);
if (!custom_schemes.empty()) {
std::vector<std::string> schemes;
base::SplitString(custom_schemes, ',', &schemes);
standard_schemes->insert(standard_schemes->end(),
schemes.begin(),
schemes.end());
}
standard_schemes->push_back("chrome-extension");
standard_schemes->push_back({"chrome-extension", url::SCHEME_WITHOUT_PORT});
}
void AtomContentClient::AddPepperPlugins(
std::vector<content::PepperPluginInfo>* plugins) {
auto command_line = base::CommandLine::ForCurrentProcess();
auto flash_path = command_line->GetSwitchValueNative(
switches::kPpapiFlashPath);
if (flash_path.empty())
return;
auto flash_version = command_line->GetSwitchValueASCII(
switches::kPpapiFlashVersion);
plugins->push_back(
CreatePepperFlashInfo(base::FilePath(flash_path), flash_version));
AddPepperFlashFromCommandLine(plugins);
#if defined(WIDEVINE_CDM_AVAILABLE) && BUILDFLAG(ENABLE_PEPPER_CDMS)
AddWidevineCdmFromCommandLine(plugins);
#endif
ComputeBuiltInPlugins(plugins);
}
void AtomContentClient::AddServiceWorkerSchemes(
std::set<std::string>* service_worker_schemes) {
std::vector<std::string> schemes;
ConvertStringWithSeparatorToVector(&schemes, ",",
switches::kRegisterServiceWorkerSchemes);
for (const std::string& scheme : schemes)
service_worker_schemes->insert(scheme);
service_worker_schemes->insert(url::kFileScheme);
}
void AtomContentClient::AddSecureSchemesAndOrigins(
std::set<std::string>* secure_schemes,
std::set<GURL>* secure_origins) {
std::vector<std::string> schemes;
ConvertStringWithSeparatorToVector(&schemes, ",", switches::kSecureSchemes);
for (const std::string& scheme : schemes)
secure_schemes->insert(scheme);
}
} // namespace atom

View File

@@ -5,6 +5,7 @@
#ifndef ATOM_APP_ATOM_CONTENT_CLIENT_H_
#define ATOM_APP_ATOM_CONTENT_CLIENT_H_
#include <set>
#include <string>
#include <vector>
@@ -21,11 +22,18 @@ class AtomContentClient : public brightray::ContentClient {
// content::ContentClient:
std::string GetProduct() const override;
std::string GetUserAgent() const override;
base::string16 GetLocalizedString(int message_id) const override;
void AddAdditionalSchemes(
std::vector<std::string>* standard_schemes,
std::vector<url::SchemeWithType>* standard_schemes,
std::vector<url::SchemeWithType>* referrer_schemes,
std::vector<std::string>* savable_schemes) override;
void AddPepperPlugins(
std::vector<content::PepperPluginInfo>* plugins) override;
void AddServiceWorkerSchemes(
std::set<std::string>* service_worker_schemes) override;
void AddSecureSchemesAndOrigins(
std::set<std::string>* secure_schemes,
std::set<GURL>* secure_origins) override;
private:
DISALLOW_COPY_AND_ASSIGN(AtomContentClient);

View File

@@ -5,7 +5,7 @@
#ifndef ATOM_APP_ATOM_LIBRARY_MAIN_H_
#define ATOM_APP_ATOM_LIBRARY_MAIN_H_
#include "base/basictypes.h"
#include "build/build_config.h"
#if defined(OS_MACOSX)
extern "C" {

View File

@@ -10,6 +10,7 @@
#include "base/at_exit.h"
#include "base/i18n/icu_util.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/scoped_nsautorelease_pool.h"
#include "brightray/common/mac/main_application_bundle.h"
#include "content/public/app/content_main.h"
@@ -25,6 +26,7 @@ int AtomMain(int argc, const char* argv[]) {
int AtomInitializeICUandStartNode(int argc, char *argv[]) {
base::AtExitManager atexit_manager;
base::mac::ScopedNSAutoreleasePool pool;
base::mac::SetOverrideFrameworkBundlePath(
brightray::MainApplicationBundlePath()
.Append("Contents")

View File

@@ -5,25 +5,21 @@
#include "atom/app/atom_main.h"
#include <stdlib.h>
#include <string.h>
#if defined(OS_WIN)
#include <stdio.h>
#include <io.h>
#include <fcntl.h>
#include <windows.h> // windows.h must be included first
#include <windows.h>
#include <shellapi.h>
#include <shellscalingapi.h>
#include <tchar.h>
#include <shellapi.h>
#include "atom/app/atom_main_delegate.h"
#include "atom/common/crash_reporter/win/crash_service_main.h"
#include "base/environment.h"
#include "base/process/launch.h"
#include "base/win/windows_version.h"
#include "content/public/app/startup_helper_win.h"
#include "content/public/app/sandbox_helper_win.h"
#include "sandbox/win/src/sandbox_types.h"
#include "ui/gfx/win/dpi.h"
#elif defined(OS_LINUX) // defined(OS_WIN)
#include "atom/app/atom_main_delegate.h" // NOLINT
#include "content/public/app/content_main.h"
@@ -36,66 +32,33 @@
#include "base/at_exit.h"
#include "base/i18n/icu_util.h"
#if defined(OS_WIN)
namespace {
// Win8.1 supports monitor-specific DPI scaling.
bool SetProcessDpiAwarenessWrapper(PROCESS_DPI_AWARENESS value) {
typedef HRESULT(WINAPI *SetProcessDpiAwarenessPtr)(PROCESS_DPI_AWARENESS);
SetProcessDpiAwarenessPtr set_process_dpi_awareness_func =
reinterpret_cast<SetProcessDpiAwarenessPtr>(
GetProcAddress(GetModuleHandleA("user32.dll"),
"SetProcessDpiAwarenessInternal"));
if (set_process_dpi_awareness_func) {
HRESULT hr = set_process_dpi_awareness_func(value);
if (SUCCEEDED(hr)) {
VLOG(1) << "SetProcessDpiAwareness succeeded.";
return true;
} else if (hr == E_ACCESSDENIED) {
LOG(ERROR) << "Access denied error from SetProcessDpiAwareness. "
"Function called twice, or manifest was used.";
}
}
return false;
}
const char* kRunAsNode = "ELECTRON_RUN_AS_NODE";
// This function works for Windows Vista through Win8. Win8.1 must use
// SetProcessDpiAwareness[Wrapper].
BOOL SetProcessDPIAwareWrapper() {
typedef BOOL(WINAPI *SetProcessDPIAwarePtr)(VOID);
SetProcessDPIAwarePtr set_process_dpi_aware_func =
reinterpret_cast<SetProcessDPIAwarePtr>(
GetProcAddress(GetModuleHandleA("user32.dll"),
"SetProcessDPIAware"));
return set_process_dpi_aware_func &&
set_process_dpi_aware_func();
}
void EnableHighDPISupport() {
if (!SetProcessDpiAwarenessWrapper(PROCESS_SYSTEM_DPI_AWARE)) {
SetProcessDPIAwareWrapper();
}
bool IsEnvSet(const char* name) {
#if defined(OS_WIN)
size_t required_size;
getenv_s(&required_size, nullptr, 0, name);
return required_size != 0;
#else
char* indicator = getenv(name);
return indicator && indicator[0] != '\0';
#endif
}
} // namespace
#if defined(OS_WIN)
int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd, int) {
int argc = 0;
wchar_t** wargv = ::CommandLineToArgvW(::GetCommandLineW(), &argc);
scoped_ptr<base::Environment> env(base::Environment::Create());
bool run_as_node = IsEnvSet(kRunAsNode);
// Make output work in console if we are not in cygiwn.
std::string os;
if (env->GetVar("OS", &os) && os != "cygwin") {
AttachConsole(ATTACH_PARENT_PROCESS);
FILE* dontcare;
freopen_s(&dontcare, "CON", "w", stdout);
freopen_s(&dontcare, "CON", "w", stderr);
freopen_s(&dontcare, "CON", "r", stdin);
}
// Make sure the output is printed to console.
if (run_as_node || !IsEnvSet("ELECTRON_NO_ATTACH_CONSOLE"))
base::RouteStdioToConsole(false);
// Convert argv to to UTF8
char** argv = new char*[argc];
@@ -131,16 +94,12 @@ int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd, int) {
}
}
std::string node_indicator, crash_service_indicator;
if (env->GetVar("ATOM_SHELL_INTERNAL_RUN_AS_NODE", &node_indicator) &&
node_indicator == "1") {
if (run_as_node) {
// Now that argv conversion is done, we can finally start.
base::AtExitManager atexit_manager;
base::i18n::InitializeICU();
return atom::NodeMain(argc, argv);
} else if (env->GetVar("ATOM_SHELL_INTERNAL_CRASH_SERVICE",
&crash_service_indicator) &&
crash_service_indicator == "1") {
} else if (IsEnvSet("ELECTRON_INTERNAL_CRASH_SERVICE")) {
return crash_service::Main(cmd);
}
@@ -148,24 +107,18 @@ int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd, int) {
content::InitializeSandboxInfo(&sandbox_info);
atom::AtomMainDelegate delegate;
// We don't want to set DPI awareness on pre-Win7 because we don't support
// DirectWrite there. GDI fonts are kerned very badly, so better to leave
// DPI-unaware and at effective 1.0. See also ShouldUseDirectWrite().
if (base::win::GetVersion() >= base::win::VERSION_WIN7)
EnableHighDPISupport();
content::ContentMainParams params(&delegate);
params.instance = instance;
params.sandbox_info = &sandbox_info;
atom::AtomCommandLine::Init(argc, argv);
atom::AtomCommandLine::InitW(argc, wargv);
return content::ContentMain(params);
}
#elif defined(OS_LINUX) // defined(OS_WIN)
int main(int argc, const char* argv[]) {
char* node_indicator = getenv("ATOM_SHELL_INTERNAL_RUN_AS_NODE");
if (node_indicator != NULL && strcmp(node_indicator, "1") == 0) {
if (IsEnvSet(kRunAsNode)) {
base::i18n::InitializeICU();
base::AtExitManager atexit_manager;
return atom::NodeMain(argc, const_cast<char**>(argv));
@@ -182,8 +135,7 @@ int main(int argc, const char* argv[]) {
#else // defined(OS_LINUX)
int main(int argc, const char* argv[]) {
char* node_indicator = getenv("ATOM_SHELL_INTERNAL_RUN_AS_NODE");
if (node_indicator != NULL && strcmp(node_indicator, "1") == 0) {
if (IsEnvSet(kRunAsNode)) {
return AtomInitializeICUandStartNode(argc, const_cast<char**>(argv));
}

View File

@@ -4,22 +4,46 @@
#include "atom/app/atom_main_delegate.h"
#include <iostream>
#include <string>
#include "atom/app/atom_content_client.h"
#include "atom/browser/atom_browser_client.h"
#include "atom/browser/relauncher.h"
#include "atom/common/google_api_key.h"
#include "atom/common/options_switches.h"
#include "atom/renderer/atom_renderer_client.h"
#include "atom/renderer/atom_sandboxed_renderer_client.h"
#include "atom/utility/atom_content_utility_client.h"
#include "base/command_line.h"
#include "base/debug/stack_trace.h"
#include "base/environment.h"
#include "base/logging.h"
#include "chrome/common/chrome_paths.h"
#include "content/public/common/content_switches.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
namespace atom {
namespace {
const char* kRelauncherProcess = "relauncher";
bool IsBrowserProcess(base::CommandLine* cmd) {
std::string process_type = cmd->GetSwitchValueASCII(::switches::kProcessType);
return process_type.empty();
}
#if defined(OS_WIN)
void InvalidParameterHandler(const wchar_t*, const wchar_t*, const wchar_t*,
unsigned int, uintptr_t) {
// noop.
}
#endif
} // namespace
AtomMainDelegate::AtomMainDelegate() {
}
@@ -27,8 +51,14 @@ AtomMainDelegate::~AtomMainDelegate() {
}
bool AtomMainDelegate::BasicStartupComplete(int* exit_code) {
auto command_line = base::CommandLine::ForCurrentProcess();
logging::LoggingSettings settings;
#if defined(OS_WIN)
// On Windows the terminal returns immediately, so we add a new line to
// prevent output in the same line as the prompt.
if (IsBrowserProcess(command_line))
std::wcout << std::endl;
#if defined(DEBUG)
// Print logging to debug.log on Windows
settings.logging_dest = logging::LOG_TO_ALL;
@@ -43,18 +73,38 @@ bool AtomMainDelegate::BasicStartupComplete(int* exit_code) {
#endif // !defined(OS_WIN)
// Only enable logging when --enable-logging is specified.
auto command_line = base::CommandLine::ForCurrentProcess();
if (!command_line->HasSwitch(switches::kEnableLogging))
std::unique_ptr<base::Environment> env(base::Environment::Create());
if (!command_line->HasSwitch(::switches::kEnableLogging) &&
!env->HasVar("ELECTRON_ENABLE_LOGGING")) {
settings.logging_dest = logging::LOG_NONE;
logging::SetMinLogLevel(logging::LOG_NUM_SEVERITIES);
}
logging::InitLogging(settings);
// Logging with pid and timestamp.
logging::SetLogItems(true, false, true, false);
#if defined(DEBUG) && defined(OS_LINUX)
// Enable convient stack printing.
base::debug::EnableInProcessStackDumping();
bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING");
#if defined(DEBUG) && defined(OS_LINUX)
enable_stack_dumping = true;
#endif
if (enable_stack_dumping)
base::debug::EnableInProcessStackDumping();
chrome::RegisterPathProvider();
#if defined(OS_MACOSX)
SetUpBundleOverrides();
#endif
#if defined(OS_WIN)
// Ignore invalid parameter errors.
_set_invalid_parameter_handler(InvalidParameterHandler);
// Disable the ActiveVerifier, which is used by Chrome to track possible
// bugs, but no use in Electron.
base::win::DisableHandleVerifier();
#endif
return brightray::MainDelegate::BasicStartupComplete(exit_code);
@@ -64,34 +114,29 @@ void AtomMainDelegate::PreSandboxStartup() {
brightray::MainDelegate::PreSandboxStartup();
// Set google API key.
scoped_ptr<base::Environment> env(base::Environment::Create());
std::unique_ptr<base::Environment> env(base::Environment::Create());
if (!env->HasVar("GOOGLE_API_KEY"))
env->SetVar("GOOGLE_API_KEY", GOOGLEAPIS_API_KEY);
auto command_line = base::CommandLine::ForCurrentProcess();
std::string process_type = command_line->GetSwitchValueASCII(
switches::kProcessType);
if (process_type == switches::kUtilityProcess) {
AtomContentUtilityClient::PreSandboxStartup();
}
::switches::kProcessType);
// Only append arguments for browser process.
if (!process_type.empty())
if (!IsBrowserProcess(command_line))
return;
#if defined(OS_WIN)
// Disable the LegacyRenderWidgetHostHWND, it made frameless windows unable
// to move and resize. We may consider enabling it again after upgraded to
// Chrome 38, which should have fixed the problem.
command_line->AppendSwitch(switches::kDisableLegacyIntermediateWindow);
#endif
// Disable renderer sandbox for most of node's functions.
command_line->AppendSwitch(switches::kNoSandbox);
if (command_line->HasSwitch(switches::kEnableSandbox)) {
// Disable setuid sandbox since it is not longer required on linux(namespace
// sandbox is available on most distros).
command_line->AppendSwitch(::switches::kDisableSetuidSandbox);
} else {
// Disable renderer sandbox for most of node's functions.
command_line->AppendSwitch(::switches::kNoSandbox);
}
// Allow file:// URIs to read other file:// URIs by default.
command_line->AppendSwitch(switches::kAllowFileAccessFromFiles);
command_line->AppendSwitch(::switches::kAllowFileAccessFromFiles);
#if defined(OS_MACOSX)
// Enable AVFoundation.
@@ -106,7 +151,13 @@ content::ContentBrowserClient* AtomMainDelegate::CreateContentBrowserClient() {
content::ContentRendererClient*
AtomMainDelegate::CreateContentRendererClient() {
renderer_client_.reset(new AtomRendererClient);
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableSandbox)) {
renderer_client_.reset(new AtomSandboxedRendererClient);
} else {
renderer_client_.reset(new AtomRendererClient);
}
return renderer_client_.get();
}
@@ -115,20 +166,29 @@ content::ContentUtilityClient* AtomMainDelegate::CreateContentUtilityClient() {
return utility_client_.get();
}
scoped_ptr<brightray::ContentClient> AtomMainDelegate::CreateContentClient() {
return scoped_ptr<brightray::ContentClient>(new AtomContentClient).Pass();
int AtomMainDelegate::RunProcess(
const std::string& process_type,
const content::MainFunctionParams& main_function_params) {
if (process_type == kRelauncherProcess)
return relauncher::RelauncherMain(main_function_params);
else
return -1;
}
void AtomMainDelegate::AddDataPackFromPath(
ui::ResourceBundle* bundle, const base::FilePath& pak_dir) {
#if defined(OS_WIN)
bundle->AddDataPackFromPath(
pak_dir.Append(FILE_PATH_LITERAL("ui_resources_200_percent.pak")),
ui::SCALE_FACTOR_200P);
bundle->AddDataPackFromPath(
pak_dir.Append(FILE_PATH_LITERAL("content_resources_200_percent.pak")),
ui::SCALE_FACTOR_200P);
#if defined(OS_MACOSX)
bool AtomMainDelegate::ShouldSendMachPort(const std::string& process_type) {
return process_type != kRelauncherProcess;
}
bool AtomMainDelegate::DelaySandboxInitialization(
const std::string& process_type) {
return process_type == kRelauncherProcess;
}
#endif
std::unique_ptr<brightray::ContentClient>
AtomMainDelegate::CreateContentClient() {
return std::unique_ptr<brightray::ContentClient>(new AtomContentClient);
}
} // namespace atom

View File

@@ -5,8 +5,10 @@
#ifndef ATOM_APP_ATOM_MAIN_DELEGATE_H_
#define ATOM_APP_ATOM_MAIN_DELEGATE_H_
#include "brightray/common/main_delegate.h"
#include <string>
#include "brightray/common/content_client.h"
#include "brightray/common/main_delegate.h"
namespace atom {
@@ -22,21 +24,30 @@ class AtomMainDelegate : public brightray::MainDelegate {
content::ContentBrowserClient* CreateContentBrowserClient() override;
content::ContentRendererClient* CreateContentRendererClient() override;
content::ContentUtilityClient* CreateContentUtilityClient() override;
int RunProcess(
const std::string& process_type,
const content::MainFunctionParams& main_function_params) override;
#if defined(OS_MACOSX)
bool ShouldSendMachPort(const std::string& process_type) override;
bool DelaySandboxInitialization(const std::string& process_type) override;
#endif
// brightray::MainDelegate:
scoped_ptr<brightray::ContentClient> CreateContentClient() override;
void AddDataPackFromPath(
ui::ResourceBundle* bundle, const base::FilePath& pak_dir) override;
std::unique_ptr<brightray::ContentClient> CreateContentClient() override;
#if defined(OS_MACOSX)
void OverrideChildProcessPath() override;
void OverrideFrameworkBundlePath() override;
#endif
private:
#if defined(OS_MACOSX)
void SetUpBundleOverrides();
#endif
brightray::ContentClient content_client_;
scoped_ptr<content::ContentBrowserClient> browser_client_;
scoped_ptr<content::ContentRendererClient> renderer_client_;
scoped_ptr<content::ContentUtilityClient> utility_client_;
std::unique_ptr<content::ContentBrowserClient> browser_client_;
std::unique_ptr<content::ContentRendererClient> renderer_client_;
std::unique_ptr<content::ContentUtilityClient> utility_client_;
DISALLOW_COPY_AND_ASSIGN(AtomMainDelegate);
};

View File

@@ -7,7 +7,10 @@
#include "base/mac/bundle_locations.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_nsautorelease_pool.h"
#include "base/path_service.h"
#include "base/strings/sys_string_conversions.h"
#include "brightray/common/application_info.h"
#include "brightray/common/mac/main_application_bundle.h"
#include "content/public/common/content_paths.h"
@@ -48,4 +51,15 @@ void AtomMainDelegate::OverrideChildProcessPath() {
PathService::Override(content::CHILD_PROCESS_EXE, helper_path);
}
void AtomMainDelegate::SetUpBundleOverrides() {
base::mac::ScopedNSAutoreleasePool pool;
NSBundle* bundle = brightray::MainApplicationBundle();
std::string base_bundle_id =
base::SysNSStringToUTF8([bundle bundleIdentifier]);
NSString* team_id = [bundle objectForInfoDictionaryKey:@"ElectronTeamID"];
if (team_id)
base_bundle_id = base::SysNSStringToUTF8(team_id) + "." + base_bundle_id;
base::mac::SetBaseBundleID(base_bundle_id.c_str());
}
} // namespace atom

View File

@@ -7,45 +7,65 @@
#include "atom/app/uv_task_runner.h"
#include "atom/browser/javascript_environment.h"
#include "atom/browser/node_debugger.h"
#include "atom/common/node_includes.h"
#include "atom/common/api/atom_bindings.h"
#include "atom/common/crash_reporter/crash_reporter.h"
#include "atom/common/native_mate_converters/string16_converter.h"
#include "base/command_line.h"
#include "base/thread_task_runner_handle.h"
#include "base/feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "gin/array_buffer.h"
#include "gin/public/isolate_holder.h"
#include "gin/v8_initializer.h"
#include "native_mate/dictionary.h"
#include "atom/common/node_includes.h"
namespace atom {
int NodeMain(int argc, char *argv[]) {
base::CommandLine::Init(argc, argv);
argv = uv_setup_args(argc, argv);
int exec_argc;
const char** exec_argv;
node::Init(&argc, const_cast<const char**>(argv), &exec_argc, &exec_argv);
int exit_code = 1;
{
// Feed gin::PerIsolateData with a task runner.
argv = uv_setup_args(argc, argv);
uv_loop_t* loop = uv_default_loop();
scoped_refptr<UvTaskRunner> uv_task_runner(new UvTaskRunner(loop));
base::ThreadTaskRunnerHandle handle(uv_task_runner);
// Initialize feature list.
std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->InitializeFromCommandLine("", "");
base::FeatureList::SetInstance(std::move(feature_list));
gin::V8Initializer::LoadV8Snapshot();
gin::V8Initializer::LoadV8Natives();
gin::IsolateHolder::Initialize(
gin::IsolateHolder::kNonStrictMode,
gin::ArrayBufferAllocator::SharedInstance());
JavascriptEnvironment gin_env;
int exec_argc;
const char** exec_argv;
node::Init(&argc, const_cast<const char**>(argv), &exec_argc, &exec_argv);
node::IsolateData isolate_data(gin_env.isolate(), loop);
node::Environment* env = node::CreateEnvironment(
gin_env.isolate(), loop, gin_env.context(), argc, argv,
&isolate_data, gin_env.context(), argc, argv,
exec_argc, exec_argv);
// Start our custom debugger implementation.
NodeDebugger node_debugger(gin_env.isolate());
if (node_debugger.IsRunning())
env->AssignToContext(v8::Debug::GetDebugContext());
env->AssignToContext(v8::Debug::GetDebugContext(gin_env.isolate()));
mate::Dictionary process(gin_env.isolate(), env->process_object());
#if defined(OS_WIN)
process.SetMethod("log", &AtomBindings::Log);
#endif
process.SetMethod("crash", &AtomBindings::Crash);
// Setup process.crashReporter.start in child node processes
auto reporter = mate::Dictionary::CreateEmpty(gin_env.isolate());
reporter.SetMethod("start", &crash_reporter::CrashReporter::StartInstance);
process.Set("crashReporter", reporter);
node::LoadEnvironment(env);
@@ -66,7 +86,7 @@ int NodeMain(int argc, char *argv[]) {
exit_code = node::EmitExit(env);
node::RunAtExit(env);
env->Dispose();
node::FreeEnvironment(env);
}
v8::V8::Dispose();

View File

@@ -21,7 +21,7 @@ UvTaskRunner::~UvTaskRunner() {
bool UvTaskRunner::PostDelayedTask(const tracked_objects::Location& from_here,
const base::Closure& task,
base::TimeDelta delay) {
uv_timer_t* timer = new uv_timer_t;
auto* timer = new uv_timer_t;
timer->data = this;
uv_timer_init(loop_, timer);
uv_timer_start(timer, UvTaskRunner::OnTimeout, delay.InMilliseconds(), 0);
@@ -37,7 +37,7 @@ bool UvTaskRunner::PostNonNestableDelayedTask(
const tracked_objects::Location& from_here,
const base::Closure& task,
base::TimeDelta delay) {
return PostDelayedTask(from_here, task, delay);;
return PostDelayedTask(from_here, task, delay);
}
// static
@@ -48,8 +48,13 @@ void UvTaskRunner::OnTimeout(uv_timer_t* timer) {
self->tasks_[timer].Run();
self->tasks_.erase(timer);
uv_unref(reinterpret_cast<uv_handle_t*>(timer));
delete timer;
uv_timer_stop(timer);
uv_close(reinterpret_cast<uv_handle_t*>(timer), UvTaskRunner::OnClose);
}
// static
void UvTaskRunner::OnClose(uv_handle_t* handle) {
delete reinterpret_cast<uv_timer_t*>(handle);
}
} // namespace atom

View File

@@ -31,6 +31,7 @@ class UvTaskRunner : public base::SingleThreadTaskRunner {
private:
static void OnTimeout(uv_timer_t* timer);
static void OnClose(uv_handle_t* handle);
uv_loop_t* loop_;

File diff suppressed because it is too large Load Diff

View File

@@ -6,11 +6,25 @@
#define ATOM_BROWSER_API_ATOM_API_APP_H_
#include <string>
#include <vector>
#include "atom/browser/api/event_emitter.h"
#include "atom/browser/atom_browser_client.h"
#include "atom/browser/browser.h"
#include "atom/browser/browser_observer.h"
#include "atom/common/native_mate_converters/callback.h"
#include "base/process/process_iterator.h"
#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/icon_manager.h"
#include "chrome/browser/process_singleton.h"
#include "content/public/browser/gpu_data_manager_observer.h"
#include "native_mate/dictionary.h"
#include "native_mate/handle.h"
#include "net/base/completion_callback.h"
#if defined(USE_NSS_CERTS)
#include "chrome/browser/certificate_manager_model.h"
#endif
namespace base {
class FilePath;
@@ -18,21 +32,51 @@ class FilePath;
namespace mate {
class Arguments;
}
} // namespace mate
namespace atom {
#if defined(OS_WIN)
enum class JumpListResult : int;
#endif
namespace api {
class App : public mate::EventEmitter,
class App : public AtomBrowserClient::Delegate,
public mate::EventEmitter<App>,
public BrowserObserver,
public content::GpuDataManagerObserver {
public:
using FileIconCallback = base::Callback<void(v8::Local<v8::Value>,
const gfx::Image&)>;
static mate::Handle<App> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// Called when window with disposition needs to be created.
void OnCreateWindow(
const GURL& target_url,
const std::string& frame_name,
WindowOpenDisposition disposition,
const std::vector<std::string>& features,
const scoped_refptr<content::ResourceRequestBodyImpl>& body,
int render_process_id,
int render_frame_id);
#if defined(USE_NSS_CERTS)
void OnCertificateManagerModelCreated(
std::unique_ptr<base::DictionaryValue> options,
const net::CompletionCallback& callback,
std::unique_ptr<CertificateManagerModel> model);
#endif
base::FilePath GetAppPath() const;
protected:
App();
virtual ~App();
explicit App(v8::Isolate* isolate);
~App() override;
// BrowserObserver:
void OnBeforeQuit(bool* prevent_default) override;
@@ -43,20 +87,40 @@ class App : public mate::EventEmitter,
void OnOpenURL(const std::string& url) override;
void OnActivate(bool has_visible_windows) override;
void OnWillFinishLaunching() override;
void OnFinishLaunching() override;
void OnSelectCertificate(
void OnFinishLaunching(const base::DictionaryValue& launch_info) override;
void OnLogin(LoginHandler* login_handler,
const base::DictionaryValue& request_details) override;
void OnAccessibilitySupportChanged() override;
#if defined(OS_MACOSX)
void OnContinueUserActivity(
bool* prevent_default,
const std::string& type,
const base::DictionaryValue& user_info) override;
#endif
// content::ContentBrowserClient:
void AllowCertificateError(
content::WebContents* web_contents,
int cert_error,
const net::SSLInfo& ssl_info,
const GURL& request_url,
content::ResourceType resource_type,
bool overridable,
bool strict_enforcement,
bool expired_previous_decision,
const base::Callback<void(content::CertificateRequestResultType)>&
callback) override;
void SelectClientCertificate(
content::WebContents* web_contents,
net::SSLCertRequestInfo* cert_request_info,
scoped_ptr<content::ClientCertificateDelegate> delegate) override;
std::unique_ptr<content::ClientCertificateDelegate> delegate) override;
// content::GpuDataManagerObserver:
void OnGpuProcessCrashed(base::TerminationStatus exit_code) override;
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
void OnGpuProcessCrashed(base::TerminationStatus status) override;
private:
void SetAppPath(const base::FilePath& app_path);
// Get/Set the pre-defined path in PathService.
base::FilePath GetPath(mate::Arguments* args, const std::string& name);
void SetPath(mate::Arguments* args,
@@ -64,11 +128,41 @@ class App : public mate::EventEmitter,
const base::FilePath& path);
void SetDesktopName(const std::string& desktop_name);
void SetAppUserModelId(const std::string& app_id);
std::string GetLocale();
v8::Local<v8::Value> DefaultSession(v8::Isolate* isolate);
bool MakeSingleInstance(
const ProcessSingleton::NotificationCallback& callback);
void ReleaseSingleInstance();
bool Relaunch(mate::Arguments* args);
void DisableHardwareAcceleration(mate::Arguments* args);
bool IsAccessibilitySupportEnabled();
Browser::LoginItemSettings GetLoginItemSettings(mate::Arguments* args);
#if defined(USE_NSS_CERTS)
void ImportCertificate(const base::DictionaryValue& options,
const net::CompletionCallback& callback);
#endif
void GetFileIcon(const base::FilePath& path,
mate::Arguments* args);
v8::Global<v8::Value> default_session_;
std::vector<mate::Dictionary> GetAppMemoryInfo(v8::Isolate* isolate);
#if defined(OS_WIN)
// Get the current Jump List settings.
v8::Local<v8::Value> GetJumpListSettings();
// Set or remove a custom Jump List for the application.
JumpListResult SetJumpList(v8::Local<v8::Value> val, mate::Arguments* args);
#endif // defined(OS_WIN)
std::unique_ptr<ProcessSingleton> process_singleton_;
#if defined(USE_NSS_CERTS)
std::unique_ptr<CertificateManagerModel> certificate_manager_model_;
#endif
// Tracks tasks requesting file icons.
base::CancelableTaskTracker cancelable_task_tracker_;
base::FilePath app_path_;
DISALLOW_COPY_AND_ASSIGN(App);
};

View File

@@ -4,27 +4,57 @@
#include "atom/browser/api/atom_api_auto_updater.h"
#include "base/time/time.h"
#include "atom/browser/auto_updater.h"
#include "atom/browser/browser.h"
#include "atom/browser/native_window.h"
#include "atom/browser/window_list.h"
#include "atom/common/api/event_emitter_caller.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/node_includes.h"
#include "base/time/time.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
namespace mate {
template<>
struct Converter<base::Time> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const base::Time& val) {
v8::MaybeLocal<v8::Value> date = v8::Date::New(
isolate->GetCurrentContext(), val.ToJsTime());
if (date.IsEmpty())
return v8::Null(isolate);
else
return date.ToLocalChecked();
}
};
} // namespace mate
namespace atom {
namespace api {
AutoUpdater::AutoUpdater() {
AutoUpdater::AutoUpdater(v8::Isolate* isolate) {
auto_updater::AutoUpdater::SetDelegate(this);
Init(isolate);
}
AutoUpdater::~AutoUpdater() {
auto_updater::AutoUpdater::SetDelegate(NULL);
auto_updater::AutoUpdater::SetDelegate(nullptr);
}
void AutoUpdater::OnError(const std::string& error) {
Emit("error", error);
void AutoUpdater::OnError(const std::string& message) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
auto error = v8::Exception::Error(mate::StringToV8(isolate(), message));
mate::EmitEvent(
isolate(),
GetWrapper(),
"error",
error->ToObject(isolate()->GetCurrentContext()).ToLocalChecked(),
// Message is also emitted to keep compatibility with old code.
message);
}
void AutoUpdater::OnCheckingForUpdate() {
@@ -42,31 +72,48 @@ void AutoUpdater::OnUpdateNotAvailable() {
void AutoUpdater::OnUpdateDownloaded(const std::string& release_notes,
const std::string& release_name,
const base::Time& release_date,
const std::string& update_url,
const base::Closure& quit_and_install) {
quit_and_install_ = quit_and_install;
Emit("update-downloaded-raw", release_notes, release_name,
release_date.ToJsTime(), update_url);
const std::string& url) {
Emit("update-downloaded", release_notes, release_name, release_date, url,
// Keep compatibility with old APIs.
base::Bind(&AutoUpdater::QuitAndInstall, base::Unretained(this)));
}
mate::ObjectTemplateBuilder AutoUpdater::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("setFeedUrl", &auto_updater::AutoUpdater::SetFeedURL)
.SetMethod("checkForUpdates", &auto_updater::AutoUpdater::CheckForUpdates)
.SetMethod("_quitAndInstall", &AutoUpdater::QuitAndInstall);
void AutoUpdater::OnWindowAllClosed() {
QuitAndInstall();
}
void AutoUpdater::SetFeedURL(const std::string& url, mate::Arguments* args) {
auto_updater::AutoUpdater::HeaderMap headers;
args->GetNext(&headers);
auto_updater::AutoUpdater::SetFeedURL(url, headers);
}
void AutoUpdater::QuitAndInstall() {
if (quit_and_install_.is_null())
Browser::Get()->Shutdown();
else
quit_and_install_.Run();
// If we don't have any window then quitAndInstall immediately.
if (WindowList::IsEmpty()) {
auto_updater::AutoUpdater::QuitAndInstall();
return;
}
// Otherwise do the restart after all windows have been closed.
WindowList::AddObserver(this);
WindowList::CloseAllWindows();
}
// static
mate::Handle<AutoUpdater> AutoUpdater::Create(v8::Isolate* isolate) {
return CreateHandle(isolate, new AutoUpdater);
return mate::CreateHandle(isolate, new AutoUpdater(isolate));
}
// static
void AutoUpdater::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "AutoUpdater"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("checkForUpdates", &auto_updater::AutoUpdater::CheckForUpdates)
.SetMethod("getFeedURL", &auto_updater::AutoUpdater::GetFeedURL)
.SetMethod("setFeedURL", &AutoUpdater::SetFeedURL)
.SetMethod("quitAndInstall", &AutoUpdater::QuitAndInstall);
}
} // namespace api
@@ -76,11 +123,14 @@ mate::Handle<AutoUpdater> AutoUpdater::Create(v8::Isolate* isolate) {
namespace {
using atom::api::AutoUpdater;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.Set("autoUpdater", atom::api::AutoUpdater::Create(isolate));
dict.Set("autoUpdater", AutoUpdater::Create(isolate));
dict.Set("AutoUpdater", AutoUpdater::GetConstructor(isolate)->GetFunction());
}
} // namespace

View File

@@ -7,45 +7,47 @@
#include <string>
#include "base/callback.h"
#include "atom/browser/api/event_emitter.h"
#include "atom/browser/auto_updater_delegate.h"
#include "atom/browser/auto_updater.h"
#include "atom/browser/window_list_observer.h"
#include "native_mate/arguments.h"
#include "native_mate/handle.h"
namespace atom {
namespace api {
class AutoUpdater : public mate::EventEmitter,
public auto_updater::AutoUpdaterDelegate {
class AutoUpdater : public mate::EventEmitter<AutoUpdater>,
public auto_updater::Delegate,
public WindowListObserver {
public:
static mate::Handle<AutoUpdater> Create(v8::Isolate* isolate);
protected:
AutoUpdater();
virtual ~AutoUpdater();
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// AutoUpdaterDelegate implementations.
protected:
explicit AutoUpdater(v8::Isolate* isolate);
~AutoUpdater() override;
// Delegate implementations.
void OnError(const std::string& error) override;
void OnCheckingForUpdate() override;
void OnUpdateAvailable() override;
void OnUpdateNotAvailable() override;
void OnUpdateDownloaded(
const std::string& release_notes,
const std::string& release_name,
const base::Time& release_date,
const std::string& update_url,
const base::Closure& quit_and_install) override;
void OnUpdateDownloaded(const std::string& release_notes,
const std::string& release_name,
const base::Time& release_date,
const std::string& update_url) override;
// mate::Wrappable implementations:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
// WindowListObserver:
void OnWindowAllClosed() override;
private:
std::string GetFeedURL();
void SetFeedURL(const std::string& url, mate::Arguments* args);
void QuitAndInstall();
base::Closure quit_and_install_;
DISALLOW_COPY_AND_ASSIGN(AutoUpdater);
};

View File

@@ -0,0 +1,162 @@
// Copyright (c) 2017 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_browser_view.h"
#include "atom/browser/api/atom_api_web_contents.h"
#include "atom/browser/browser.h"
#include "atom/browser/native_browser_view.h"
#include "atom/common/color_util.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/node_includes.h"
#include "atom/common/options_switches.h"
#include "native_mate/constructor.h"
#include "native_mate/dictionary.h"
#include "ui/gfx/geometry/rect.h"
namespace mate {
template <>
struct Converter<atom::AutoResizeFlags> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
atom::AutoResizeFlags* auto_resize_flags) {
mate::Dictionary params;
if (!ConvertFromV8(isolate, val, &params)) {
return false;
}
uint8_t flags = 0;
bool width = false;
if (params.Get("width", &width) && width) {
flags |= atom::kAutoResizeWidth;
}
bool height = false;
if (params.Get("height", &height) && height) {
flags |= atom::kAutoResizeHeight;
}
*auto_resize_flags = static_cast<atom::AutoResizeFlags>(flags);
return true;
}
};
} // namespace mate
namespace atom {
namespace api {
BrowserView::BrowserView(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options)
: api_web_contents_(nullptr) {
Init(isolate, wrapper, options);
}
void BrowserView::Init(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options) {
mate::Dictionary web_preferences = mate::Dictionary::CreateEmpty(isolate);
options.Get(options::kWebPreferences, &web_preferences);
web_preferences.Set("isBrowserView", true);
mate::Handle<class WebContents> web_contents =
WebContents::Create(isolate, web_preferences);
web_contents_.Reset(isolate, web_contents.ToV8());
api_web_contents_ = web_contents.get();
view_.reset(NativeBrowserView::Create(
api_web_contents_->managed_web_contents()->GetView()));
InitWith(isolate, wrapper);
}
BrowserView::~BrowserView() {
api_web_contents_->DestroyWebContents(true /* async */);
}
// static
mate::WrappableBase* BrowserView::New(mate::Arguments* args) {
if (!Browser::Get()->is_ready()) {
args->ThrowError("Cannot create BrowserView before app is ready");
return nullptr;
}
if (args->Length() > 1) {
args->ThrowError("Too many arguments");
return nullptr;
}
mate::Dictionary options;
if (!(args->Length() == 1 && args->GetNext(&options))) {
options = mate::Dictionary::CreateEmpty(args->isolate());
}
return new BrowserView(args->isolate(), args->GetThis(), options);
}
int32_t BrowserView::ID() const {
return weak_map_id();
}
void BrowserView::SetAutoResize(AutoResizeFlags flags) {
view_->SetAutoResizeFlags(flags);
}
void BrowserView::SetBounds(const gfx::Rect& bounds) {
view_->SetBounds(bounds);
}
void BrowserView::SetBackgroundColor(const std::string& color_name) {
view_->SetBackgroundColor(ParseHexColor(color_name));
}
v8::Local<v8::Value> BrowserView::WebContents() {
if (web_contents_.IsEmpty()) {
return v8::Null(isolate());
}
return v8::Local<v8::Value>::New(isolate(), web_contents_);
}
// static
void BrowserView::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "BrowserView"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("setAutoResize", &BrowserView::SetAutoResize)
.SetMethod("setBounds", &BrowserView::SetBounds)
.SetMethod("setBackgroundColor", &BrowserView::SetBackgroundColor)
.SetProperty("webContents", &BrowserView::WebContents)
.SetProperty("id", &BrowserView::ID);
}
} // namespace api
} // namespace atom
namespace {
using atom::api::BrowserView;
void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context,
void* priv) {
v8::Isolate* isolate = context->GetIsolate();
BrowserView::SetConstructor(isolate, base::Bind(&BrowserView::New));
mate::Dictionary browser_view(
isolate, BrowserView::GetConstructor(isolate)->GetFunction());
mate::Dictionary dict(isolate, exports);
dict.Set("BrowserView", browser_view);
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_browser_view, Initialize)

View File

@@ -0,0 +1,72 @@
// Copyright (c) 2017 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_BROWSER_VIEW_H_
#define ATOM_BROWSER_API_ATOM_API_BROWSER_VIEW_H_
#include <memory>
#include <string>
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/native_browser_view.h"
#include "native_mate/handle.h"
namespace gfx {
class Rect;
}
namespace mate {
class Arguments;
class Dictionary;
} // namespace mate
namespace atom {
class NativeBrowserView;
namespace api {
class WebContents;
class BrowserView : public mate::TrackableObject<BrowserView> {
public:
static mate::WrappableBase* New(mate::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
NativeBrowserView* view() const { return view_.get(); }
int32_t ID() const;
protected:
BrowserView(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options);
~BrowserView() override;
private:
void Init(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options);
void SetAutoResize(AutoResizeFlags flags);
void SetBounds(const gfx::Rect& bounds);
void SetBackgroundColor(const std::string& color_name);
v8::Local<v8::Value> WebContents();
v8::Global<v8::Value> web_contents_;
class WebContents* api_web_contents_;
std::unique_ptr<NativeBrowserView> view_;
DISALLOW_COPY_AND_ASSIGN(BrowserView);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_BROWSER_VIEW_H_

View File

@@ -7,12 +7,13 @@
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/node_includes.h"
#include "base/bind.h"
#include "base/files/file_util.h"
#include "content/public/browser/tracing_controller.h"
#include "native_mate/dictionary.h"
#include "atom/common/node_includes.h"
using content::TracingController;
namespace mate {
@@ -53,13 +54,7 @@ scoped_refptr<TracingController::TraceDataSink> GetTraceDataSink(
void StopRecording(const base::FilePath& path,
const CompletionCallback& callback) {
TracingController::GetInstance()->DisableRecording(
GetTraceDataSink(path, callback));
}
void CaptureMonitoringSnapshot(const base::FilePath& path,
const CompletionCallback& callback) {
TracingController::GetInstance()->CaptureMonitoringSnapshot(
TracingController::GetInstance()->StopTracing(
GetTraceDataSink(path, callback));
}
@@ -70,19 +65,10 @@ void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
dict.SetMethod("getCategories", base::Bind(
&TracingController::GetCategories, controller));
dict.SetMethod("startRecording", base::Bind(
&TracingController::EnableRecording, controller));
&TracingController::StartTracing, controller));
dict.SetMethod("stopRecording", &StopRecording);
dict.SetMethod("startMonitoring", base::Bind(
&TracingController::EnableMonitoring, controller));
dict.SetMethod("stopMonitoring", base::Bind(
&TracingController::DisableMonitoring, controller));
dict.SetMethod("captureMonitoringSnapshot", &CaptureMonitoringSnapshot);
dict.SetMethod("getTraceBufferUsage", base::Bind(
&TracingController::GetTraceBufferUsage, controller));
dict.SetMethod("setWatchEvent", base::Bind(
&TracingController::SetWatchEvent, controller));
dict.SetMethod("cancelWatchEvent", base::Bind(
&TracingController::CancelWatchEvent, controller));
}
} // namespace

View File

@@ -4,10 +4,10 @@
#include "atom/browser/api/atom_api_cookies.h"
#include "atom/browser/atom_browser_context.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "base/bind.h"
#include "base/time/time.h"
#include "base/values.h"
#include "content/public/browser/browser_context.h"
@@ -20,139 +20,22 @@
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
using atom::api::Cookies;
using atom::AtomCookieDelegate;
using content::BrowserThread;
namespace {
bool GetCookieListFromStore(
net::CookieStore* cookie_store,
const std::string& url,
const net::CookieMonster::GetCookieListCallback& callback) {
DCHECK(cookie_store);
GURL gurl(url);
net::CookieMonster* monster = cookie_store->GetCookieMonster();
// Empty url will match all url cookies.
if (url.empty()) {
monster->GetAllCookiesAsync(callback);
return true;
}
if (!gurl.is_valid())
return false;
monster->GetAllCookiesForURLAsync(gurl, callback);
return true;
}
void RunGetCookiesCallbackOnUIThread(v8::Isolate* isolate,
const std::string& error_message,
const net::CookieList& cookie_list,
const Cookies::CookiesCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
v8::Locker locker(isolate);
v8::HandleScope handle_scope(isolate);
if (!error_message.empty()) {
v8::Local<v8::Value> error = mate::ConvertToV8(isolate, error_message);
callback.Run(error, v8::Null(isolate));
return;
}
callback.Run(v8::Null(isolate), mate::ConvertToV8(isolate, cookie_list));
}
void RunRemoveCookiesCallbackOnUIThread(
v8::Isolate* isolate,
const std::string& error_message,
const Cookies::CookiesCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
v8::Locker locker(isolate);
v8::HandleScope handle_scope(isolate);
if (!error_message.empty()) {
v8::Local<v8::Value> error = mate::ConvertToV8(isolate, error_message);
callback.Run(error, v8::Null(isolate));
return;
}
callback.Run(v8::Null(isolate), v8::Null(isolate));
}
void RunSetCookiesCallbackOnUIThread(v8::Isolate* isolate,
const std::string& error_message,
bool set_success,
const Cookies::CookiesCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
v8::Locker locker(isolate);
v8::HandleScope handle_scope(isolate);
if (!error_message.empty()) {
v8::Local<v8::Value> error = mate::ConvertToV8(isolate, error_message);
callback.Run(error, v8::Null(isolate));
return;
}
if (!set_success) {
v8::Local<v8::Value> error = mate::ConvertToV8(
isolate, "Failed to set cookies");
callback.Run(error, v8::Null(isolate));
}
callback.Run(v8::Null(isolate), v8::Null(isolate));
}
bool MatchesDomain(const base::DictionaryValue* filter,
const std::string& cookie_domain) {
std::string filter_domain;
if (!filter->GetString("domain", &filter_domain))
return true;
// Add a leading '.' character to the filter domain if it doesn't exist.
if (net::cookie_util::DomainIsHostOnly(filter_domain))
filter_domain.insert(0, ".");
std::string sub_domain(cookie_domain);
// Strip any leading '.' character from the input cookie domain.
if (!net::cookie_util::DomainIsHostOnly(sub_domain))
sub_domain = sub_domain.substr(1);
// Now check whether the domain argument is a subdomain of the filter domain.
for (sub_domain.insert(0, ".");
sub_domain.length() >= filter_domain.length();) {
if (sub_domain == filter_domain) {
return true;
}
const size_t next_dot = sub_domain.find('.', 1); // Skip over leading dot.
sub_domain.erase(0, next_dot);
}
return false;
}
bool MatchesCookie(const base::DictionaryValue* filter,
const net::CanonicalCookie& cookie) {
std::string name, domain, path;
bool is_secure, session;
if (filter->GetString("name", &name) && name != cookie.Name())
return false;
if (filter->GetString("path", &path) && path != cookie.Path())
return false;
if (!MatchesDomain(filter, cookie.Domain()))
return false;
if (filter->GetBoolean("secure", &is_secure) &&
is_secure != cookie.IsSecure())
return false;
if (filter->GetBoolean("session", &session) &&
session != cookie.IsPersistent())
return false;
return true;
}
} // namespace
namespace mate {
template<>
struct Converter<atom::api::Cookies::Error> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
atom::api::Cookies::Error val) {
if (val == atom::api::Cookies::SUCCESS)
return v8::Null(isolate);
else
return v8::Exception::Error(StringToV8(isolate, "Setting cookie failed"));
}
};
template<>
struct Converter<net::CanonicalCookie> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
@@ -161,138 +44,172 @@ struct Converter<net::CanonicalCookie> {
dict.Set("name", val.Name());
dict.Set("value", val.Value());
dict.Set("domain", val.Domain());
dict.Set("host_only", net::cookie_util::DomainIsHostOnly(val.Domain()));
dict.Set("hostOnly", net::cookie_util::DomainIsHostOnly(val.Domain()));
dict.Set("path", val.Path());
dict.Set("secure", val.IsSecure());
dict.Set("http_only", val.IsHttpOnly());
dict.Set("session", val.IsPersistent());
if (!val.IsPersistent())
dict.Set("httpOnly", val.IsHttpOnly());
dict.Set("session", !val.IsPersistent());
if (val.IsPersistent())
dict.Set("expirationDate", val.ExpiryDate().ToDoubleT());
return dict.GetHandle();
}
};
template<>
struct Converter<net::CookieStore::ChangeCause> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const net::CookieStore::ChangeCause& val) {
switch (val) {
case net::CookieStore::ChangeCause::INSERTED:
case net::CookieStore::ChangeCause::EXPLICIT:
return mate::StringToV8(isolate, "explicit");
case net::CookieStore::ChangeCause::OVERWRITE:
return mate::StringToV8(isolate, "overwrite");
case net::CookieStore::ChangeCause::EXPIRED:
return mate::StringToV8(isolate, "expired");
case net::CookieStore::ChangeCause::EVICTED:
return mate::StringToV8(isolate, "evicted");
case net::CookieStore::ChangeCause::EXPIRED_OVERWRITE:
return mate::StringToV8(isolate, "expired-overwrite");
default:
return mate::StringToV8(isolate, "unknown");
}
}
};
} // namespace mate
namespace atom {
namespace api {
Cookies::Cookies(content::BrowserContext* browser_context)
: request_context_getter_(browser_context->GetRequestContext()) {
}
namespace {
Cookies::~Cookies() {
}
// Returns whether |domain| matches |filter|.
bool MatchesDomain(std::string filter, const std::string& domain) {
// Add a leading '.' character to the filter domain if it doesn't exist.
if (net::cookie_util::DomainIsHostOnly(filter))
filter.insert(0, ".");
void Cookies::Get(const base::DictionaryValue& options,
const CookiesCallback& callback) {
scoped_ptr<base::DictionaryValue> filter(
options.DeepCopyWithoutEmptyChildren());
std::string sub_domain(domain);
// Strip any leading '.' character from the input cookie domain.
if (!net::cookie_util::DomainIsHostOnly(sub_domain))
sub_domain = sub_domain.substr(1);
content::BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&Cookies::GetCookiesOnIOThread, base::Unretained(this),
Passed(&filter), callback));
}
void Cookies::GetCookiesOnIOThread(scoped_ptr<base::DictionaryValue> filter,
const CookiesCallback& callback) {
std::string url;
filter->GetString("url", &url);
if (!GetCookieListFromStore(GetCookieStore(), url,
base::Bind(&Cookies::OnGetCookies, base::Unretained(this),
Passed(&filter), callback))) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(&RunGetCookiesCallbackOnUIThread, isolate(),
"Url is not valid", net::CookieList(), callback));
// Now check whether the domain argument is a subdomain of the filter domain.
for (sub_domain.insert(0, "."); sub_domain.length() >= filter.length();) {
if (sub_domain == filter)
return true;
const size_t next_dot = sub_domain.find('.', 1); // Skip over leading dot.
sub_domain.erase(0, next_dot);
}
return false;
}
void Cookies::OnGetCookies(scoped_ptr<base::DictionaryValue> filter,
const CookiesCallback& callback,
const net::CookieList& cookie_list) {
// Returns whether |cookie| matches |filter|.
bool MatchesCookie(const base::DictionaryValue* filter,
const net::CanonicalCookie& cookie) {
std::string str;
bool b;
if (filter->GetString("name", &str) && str != cookie.Name())
return false;
if (filter->GetString("path", &str) && str != cookie.Path())
return false;
if (filter->GetString("domain", &str) && !MatchesDomain(str, cookie.Domain()))
return false;
if (filter->GetBoolean("secure", &b) && b != cookie.IsSecure())
return false;
if (filter->GetBoolean("session", &b) && b != !cookie.IsPersistent())
return false;
return true;
}
// Helper to returns the CookieStore.
inline net::CookieStore* GetCookieStore(
scoped_refptr<net::URLRequestContextGetter> getter) {
return getter->GetURLRequestContext()->cookie_store();
}
// Run |callback| on UI thread.
void RunCallbackInUI(const base::Closure& callback) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, callback);
}
// Remove cookies from |list| not matching |filter|, and pass it to |callback|.
void FilterCookies(std::unique_ptr<base::DictionaryValue> filter,
const Cookies::GetCallback& callback,
const net::CookieList& list) {
net::CookieList result;
for (const auto& cookie : cookie_list) {
for (const auto& cookie : list) {
if (MatchesCookie(filter.get(), cookie))
result.push_back(cookie);
}
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, base::Bind(
&RunGetCookiesCallbackOnUIThread, isolate(), "", result, callback));
RunCallbackInUI(base::Bind(callback, Cookies::SUCCESS, result));
}
void Cookies::Remove(const mate::Dictionary& details,
const CookiesCallback& callback) {
GURL url;
std::string name;
std::string error_message;
if (!details.Get("url", &url) || !details.Get("name", &name)) {
error_message = "Details(url, name) of removing cookie are required.";
}
if (error_message.empty() && !url.is_valid()) {
error_message = "Url is not valid.";
}
if (!error_message.empty()) {
RunRemoveCookiesCallbackOnUIThread(isolate(), error_message, callback);
return;
}
content::BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&Cookies::RemoveCookiesOnIOThread, base::Unretained(this),
url, name, callback));
}
void Cookies::RemoveCookiesOnIOThread(const GURL& url, const std::string& name,
const CookiesCallback& callback) {
GetCookieStore()->DeleteCookieAsync(url, name,
base::Bind(&Cookies::OnRemoveCookies, base::Unretained(this), callback));
}
void Cookies::OnRemoveCookies(const CookiesCallback& callback) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(&RunRemoveCookiesCallbackOnUIThread, isolate(), "", callback));
}
void Cookies::Set(const base::DictionaryValue& options,
const CookiesCallback& callback) {
// Receives cookies matching |filter| in IO thread.
void GetCookiesOnIO(scoped_refptr<net::URLRequestContextGetter> getter,
std::unique_ptr<base::DictionaryValue> filter,
const Cookies::GetCallback& callback) {
std::string url;
std::string error_message;
if (!options.GetString("url", &url)) {
error_message = "The url field is required.";
}
filter->GetString("url", &url);
GURL gurl(url);
if (error_message.empty() && !gurl.is_valid()) {
error_message = "Url is not valid.";
}
auto filtered_callback =
base::Bind(FilterCookies, base::Passed(&filter), callback);
if (!error_message.empty()) {
RunSetCookiesCallbackOnUIThread(isolate(), error_message, false, callback);
return;
}
scoped_ptr<base::DictionaryValue> details(
options.DeepCopyWithoutEmptyChildren());
content::BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&Cookies::SetCookiesOnIOThread, base::Unretained(this),
Passed(&details), gurl, callback));
// Empty url will match all url cookies.
if (url.empty())
GetCookieStore(getter)->GetAllCookiesAsync(filtered_callback);
else
GetCookieStore(getter)->GetAllCookiesForURLAsync(GURL(url),
filtered_callback);
}
void Cookies::SetCookiesOnIOThread(scoped_ptr<base::DictionaryValue> details,
const GURL& url,
const CookiesCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// Removes cookie with |url| and |name| in IO thread.
void RemoveCookieOnIOThread(scoped_refptr<net::URLRequestContextGetter> getter,
const GURL& url, const std::string& name,
const base::Closure& callback) {
GetCookieStore(getter)->DeleteCookieAsync(
url, name, base::Bind(RunCallbackInUI, callback));
}
std::string name, value, domain, path;
// Callback of SetCookie.
void OnSetCookie(const Cookies::SetCallback& callback, bool success) {
RunCallbackInUI(
base::Bind(callback, success ? Cookies::SUCCESS : Cookies::FAILED));
}
// Flushes cookie store in IO thread.
void FlushCookieStoreOnIOThread(
scoped_refptr<net::URLRequestContextGetter> getter,
const base::Closure& callback) {
GetCookieStore(getter)->FlushStore(base::Bind(RunCallbackInUI, callback));
}
// Sets cookie with |details| in IO thread.
void SetCookieOnIO(scoped_refptr<net::URLRequestContextGetter> getter,
std::unique_ptr<base::DictionaryValue> details,
const Cookies::SetCallback& callback) {
std::string url, name, value, domain, path;
bool secure = false;
bool http_only = false;
double creation_date;
double expiration_date;
double last_access_date;
details->GetString("url", &url);
details->GetString("name", &name);
details->GetString("value", &value);
details->GetString("domain", &domain);
details->GetString("path", &path);
details->GetBoolean("secure", &secure);
details->GetBoolean("http_only", &http_only);
details->GetBoolean("httpOnly", &http_only);
base::Time creation_time;
if (details->GetDouble("creationDate", &creation_date)) {
creation_time = (creation_date == 0) ?
base::Time::UnixEpoch() :
base::Time::FromDoubleT(creation_date);
}
base::Time expiration_time;
if (details->GetDouble("expirationDate", &expiration_date)) {
@@ -301,44 +218,90 @@ void Cookies::SetCookiesOnIOThread(scoped_ptr<base::DictionaryValue> details,
base::Time::FromDoubleT(expiration_date);
}
GetCookieStore()->GetCookieMonster()->SetCookieWithDetailsAsync(
url,
name,
value,
domain,
path,
expiration_time,
secure,
http_only,
false,
net::COOKIE_PRIORITY_DEFAULT,
base::Bind(&Cookies::OnSetCookies, base::Unretained(this), callback));
base::Time last_access_time;
if (details->GetDouble("lastAccessDate", &last_access_date)) {
last_access_time = (last_access_date == 0) ?
base::Time::UnixEpoch() :
base::Time::FromDoubleT(last_access_date);
}
GetCookieStore(getter)->SetCookieWithDetailsAsync(
GURL(url), name, value, domain, path, creation_time,
expiration_time, last_access_time, secure, http_only,
net::CookieSameSite::DEFAULT_MODE, false,
net::COOKIE_PRIORITY_DEFAULT, base::Bind(OnSetCookie, callback));
}
void Cookies::OnSetCookies(const CookiesCallback& callback,
bool set_success) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(&RunSetCookiesCallbackOnUIThread, isolate(), "", set_success,
callback));
} // namespace
Cookies::Cookies(v8::Isolate* isolate,
AtomBrowserContext* browser_context)
: request_context_getter_(browser_context->url_request_context_getter()),
cookie_delegate_(browser_context->cookie_delegate()) {
Init(isolate);
cookie_delegate_->AddObserver(this);
}
mate::ObjectTemplateBuilder Cookies::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("get", &Cookies::Get)
.SetMethod("remove", &Cookies::Remove)
.SetMethod("set", &Cookies::Set);
Cookies::~Cookies() {
cookie_delegate_->RemoveObserver(this);
}
net::CookieStore* Cookies::GetCookieStore() {
return request_context_getter_->GetURLRequestContext()->cookie_store();
void Cookies::Get(const base::DictionaryValue& filter,
const GetCallback& callback) {
std::unique_ptr<base::DictionaryValue> copied(filter.CreateDeepCopy());
auto getter = make_scoped_refptr(request_context_getter_);
content::BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(GetCookiesOnIO, getter, Passed(&copied), callback));
}
void Cookies::Remove(const GURL& url, const std::string& name,
const base::Closure& callback) {
auto getter = make_scoped_refptr(request_context_getter_);
content::BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(RemoveCookieOnIOThread, getter, url, name, callback));
}
void Cookies::Set(const base::DictionaryValue& details,
const SetCallback& callback) {
std::unique_ptr<base::DictionaryValue> copied(details.CreateDeepCopy());
auto getter = make_scoped_refptr(request_context_getter_);
content::BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(SetCookieOnIO, getter, Passed(&copied), callback));
}
void Cookies::FlushStore(const base::Closure& callback) {
auto getter = make_scoped_refptr(request_context_getter_);
content::BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(FlushCookieStoreOnIOThread, getter, callback));
}
void Cookies::OnCookieChanged(const net::CanonicalCookie& cookie,
bool removed,
net::CookieStore::ChangeCause cause) {
Emit("changed", cookie, cause, removed);
}
// static
mate::Handle<Cookies> Cookies::Create(
v8::Isolate* isolate,
content::BrowserContext* browser_context) {
return mate::CreateHandle(isolate, new Cookies(browser_context));
AtomBrowserContext* browser_context) {
return mate::CreateHandle(isolate, new Cookies(isolate, browser_context));
}
// static
void Cookies::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Cookies"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("get", &Cookies::Get)
.SetMethod("remove", &Cookies::Remove)
.SetMethod("set", &Cookies::Set)
.SetMethod("flushStore", &Cookies::FlushStore);
}
} // namespace api

View File

@@ -7,8 +7,9 @@
#include <string>
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/net/atom_cookie_delegate.h"
#include "base/callback.h"
#include "native_mate/wrappable.h"
#include "native_mate/handle.h"
#include "net/cookies/canonical_cookie.h"
@@ -16,69 +17,52 @@ namespace base {
class DictionaryValue;
}
namespace content {
class BrowserContext;
}
namespace mate {
class Dictionary;
}
namespace net {
class CookieStore;
class URLRequestContextGetter;
}
namespace atom {
class AtomBrowserContext;
namespace api {
class Cookies : public mate::Wrappable {
class Cookies : public mate::TrackableObject<Cookies>,
public AtomCookieDelegate::Observer {
public:
// node.js style callback function(error, result)
typedef base::Callback<void(v8::Local<v8::Value>, v8::Local<v8::Value>)>
CookiesCallback;
enum Error {
SUCCESS,
FAILED,
};
using GetCallback = base::Callback<void(Error, const net::CookieList&)>;
using SetCallback = base::Callback<void(Error)>;
static mate::Handle<Cookies> Create(v8::Isolate* isolate,
content::BrowserContext* browser_context);
AtomBrowserContext* browser_context);
// mate::TrackableObject:
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
protected:
explicit Cookies(content::BrowserContext* browser_context);
~Cookies();
Cookies(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Cookies() override;
void Get(const base::DictionaryValue& options,
const CookiesCallback& callback);
void Remove(const mate::Dictionary& details,
const CookiesCallback& callback);
void Set(const base::DictionaryValue& details,
const CookiesCallback& callback);
void Get(const base::DictionaryValue& filter, const GetCallback& callback);
void Remove(const GURL& url, const std::string& name,
const base::Closure& callback);
void Set(const base::DictionaryValue& details, const SetCallback& callback);
void FlushStore(const base::Closure& callback);
void GetCookiesOnIOThread(scoped_ptr<base::DictionaryValue> filter,
const CookiesCallback& callback);
void OnGetCookies(scoped_ptr<base::DictionaryValue> filter,
const CookiesCallback& callback,
const net::CookieList& cookie_list);
void RemoveCookiesOnIOThread(const GURL& url,
const std::string& name,
const CookiesCallback& callback);
void OnRemoveCookies(const CookiesCallback& callback);
void SetCookiesOnIOThread(scoped_ptr<base::DictionaryValue> details,
const GURL& url,
const CookiesCallback& callback);
void OnSetCookies(const CookiesCallback& callback,
bool set_success);
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
// AtomCookieDelegate::Observer:
void OnCookieChanged(const net::CanonicalCookie& cookie,
bool removed,
net::CookieStore::ChangeCause cause) override;
private:
// Must be called on IO thread.
net::CookieStore* GetCookieStore();
net::URLRequestContextGetter* request_context_getter_;
scoped_refptr<AtomCookieDelegate> cookie_delegate_;
DISALLOW_COPY_AND_ASSIGN(Cookies);
};

View File

@@ -0,0 +1,188 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_debugger.h"
#include <string>
#include "atom/browser/atom_browser_main_parts.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "base/json/json_writer.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/web_contents.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
#include "atom/common/node_includes.h"
using content::DevToolsAgentHost;
namespace atom {
namespace api {
Debugger::Debugger(v8::Isolate* isolate, content::WebContents* web_contents)
: web_contents_(web_contents),
previous_request_id_(0) {
Init(isolate);
}
Debugger::~Debugger() {
}
void Debugger::AgentHostClosed(DevToolsAgentHost* agent_host,
bool replaced_with_another_client) {
std::string detach_reason = "target closed";
if (replaced_with_another_client)
detach_reason = "replaced with devtools";
Emit("detach", detach_reason);
}
void Debugger::DispatchProtocolMessage(DevToolsAgentHost* agent_host,
const std::string& message) {
DCHECK(agent_host == agent_host_.get());
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
v8::Local<v8::String> local_message =
v8::String::NewFromUtf8(isolate(), message.data());
v8::MaybeLocal<v8::Value> parsed_message = v8::JSON::Parse(
isolate()->GetCurrentContext(), local_message);
if (parsed_message.IsEmpty()) {
return;
}
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
if (!mate::ConvertFromV8(isolate(), parsed_message.ToLocalChecked(),
dict.get())) {
return;
}
int id;
if (!dict->GetInteger("id", &id)) {
std::string method;
if (!dict->GetString("method", &method))
return;
base::DictionaryValue* params_value = nullptr;
base::DictionaryValue params;
if (dict->GetDictionary("params", &params_value))
params.Swap(params_value);
Emit("message", method, params);
} else {
auto send_command_callback = pending_requests_[id];
pending_requests_.erase(id);
if (send_command_callback.is_null())
return;
base::DictionaryValue* error_body = nullptr;
base::DictionaryValue error;
if (dict->GetDictionary("error", &error_body))
error.Swap(error_body);
base::DictionaryValue* result_body = nullptr;
base::DictionaryValue result;
if (dict->GetDictionary("result", &result_body))
result.Swap(result_body);
send_command_callback.Run(error, result);
}
}
void Debugger::Attach(mate::Arguments* args) {
std::string protocol_version;
args->GetNext(&protocol_version);
if (!protocol_version.empty() &&
!DevToolsAgentHost::IsSupportedProtocolVersion(protocol_version)) {
args->ThrowError("Requested protocol version is not supported");
return;
}
agent_host_ = DevToolsAgentHost::GetOrCreateFor(web_contents_);
if (!agent_host_.get()) {
args->ThrowError("No target available");
return;
}
if (agent_host_->IsAttached()) {
args->ThrowError("Another debugger is already attached to this target");
return;
}
agent_host_->AttachClient(this);
}
bool Debugger::IsAttached() {
return agent_host_.get() ? agent_host_->IsAttached() : false;
}
void Debugger::Detach() {
if (!agent_host_.get())
return;
agent_host_->DetachClient(this);
AgentHostClosed(agent_host_.get(), false);
agent_host_ = nullptr;
}
void Debugger::SendCommand(mate::Arguments* args) {
if (!agent_host_.get())
return;
std::string method;
if (!args->GetNext(&method)) {
args->ThrowError();
return;
}
base::DictionaryValue command_params;
args->GetNext(&command_params);
SendCommandCallback callback;
args->GetNext(&callback);
base::DictionaryValue request;
int request_id = ++previous_request_id_;
pending_requests_[request_id] = callback;
request.SetInteger("id", request_id);
request.SetString("method", method);
if (!command_params.empty())
request.Set("params", command_params.DeepCopy());
std::string json_args;
base::JSONWriter::Write(request, &json_args);
agent_host_->DispatchProtocolMessage(this, json_args);
}
// static
mate::Handle<Debugger> Debugger::Create(
v8::Isolate* isolate,
content::WebContents* web_contents) {
return mate::CreateHandle(isolate, new Debugger(isolate, web_contents));
}
// static
void Debugger::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Debugger"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("attach", &Debugger::Attach)
.SetMethod("isAttached", &Debugger::IsAttached)
.SetMethod("detach", &Debugger::Detach)
.SetMethod("sendCommand", &Debugger::SendCommand);
}
} // namespace api
} // namespace atom
namespace {
using atom::api::Debugger;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary(isolate, exports)
.Set("Debugger", Debugger::GetConstructor(isolate)->GetFunction());
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_debugger, Initialize);

View File

@@ -0,0 +1,75 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_DEBUGGER_H_
#define ATOM_BROWSER_API_ATOM_API_DEBUGGER_H_
#include <map>
#include <string>
#include "atom/browser/api/trackable_object.h"
#include "base/callback.h"
#include "base/values.h"
#include "content/public/browser/devtools_agent_host_client.h"
#include "native_mate/handle.h"
namespace content {
class DevToolsAgentHost;
class WebContents;
}
namespace mate {
class Arguments;
}
namespace atom {
namespace api {
class Debugger: public mate::TrackableObject<Debugger>,
public content::DevToolsAgentHostClient {
public:
using SendCommandCallback =
base::Callback<void(const base::DictionaryValue&,
const base::DictionaryValue&)>;
static mate::Handle<Debugger> Create(
v8::Isolate* isolate, content::WebContents* web_contents);
// mate::TrackableObject:
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
protected:
Debugger(v8::Isolate* isolate, content::WebContents* web_contents);
~Debugger() override;
// content::DevToolsAgentHostClient:
void AgentHostClosed(content::DevToolsAgentHost* agent_host,
bool replaced_with_another_client) override;
void DispatchProtocolMessage(content::DevToolsAgentHost* agent_host,
const std::string& message) override;
private:
using PendingRequestMap = std::map<int, SendCommandCallback>;
void Attach(mate::Arguments* args);
bool IsAttached();
void Detach();
void SendCommand(mate::Arguments* args);
content::WebContents* web_contents_; // Weak Reference.
scoped_refptr<content::DevToolsAgentHost> agent_host_;
PendingRequestMap pending_requests_;
int previous_request_id_;
DISALLOW_COPY_AND_ASSIGN(Debugger);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_DEBUGGER_H_

View File

@@ -0,0 +1,124 @@
// Copyright (c) 2015 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_desktop_capturer.h"
#include "atom/common/api/atom_api_native_image.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/media/desktop_media_list.h"
#include "native_mate/dictionary.h"
#include "third_party/webrtc/modules/desktop_capture/desktop_capture_options.h"
#include "third_party/webrtc/modules/desktop_capture/desktop_capturer.h"
#include "atom/common/node_includes.h"
namespace mate {
template<>
struct Converter<DesktopMediaList::Source> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const DesktopMediaList::Source& source) {
mate::Dictionary dict(isolate, v8::Object::New(isolate));
content::DesktopMediaID id = source.id;
dict.Set("name", base::UTF16ToUTF8(source.name));
dict.Set("id", id.ToString());
dict.Set(
"thumbnail",
atom::api::NativeImage::Create(isolate, gfx::Image(source.thumbnail)));
return ConvertToV8(isolate, dict);
}
};
} // namespace mate
namespace atom {
namespace api {
DesktopCapturer::DesktopCapturer(v8::Isolate* isolate) {
Init(isolate);
}
DesktopCapturer::~DesktopCapturer() {
}
void DesktopCapturer::StartHandling(bool capture_window,
bool capture_screen,
const gfx::Size& thumbnail_size) {
webrtc::DesktopCaptureOptions options =
webrtc::DesktopCaptureOptions::CreateDefault();
#if defined(OS_WIN)
// On windows, desktop effects (e.g. Aero) will be disabled when the Desktop
// capture API is active by default.
// We keep the desktop effects in most times. Howerver, the screen still
// fickers when the API is capturing the window due to limitation of current
// implemetation. This is a known and wontFix issue in webrtc (see:
// http://code.google.com/p/webrtc/issues/detail?id=3373)
options.set_disable_effects(false);
#endif
std::unique_ptr<webrtc::DesktopCapturer> screen_capturer(
capture_screen ? webrtc::DesktopCapturer::CreateScreenCapturer(options)
: nullptr);
std::unique_ptr<webrtc::DesktopCapturer> window_capturer(
capture_window ? webrtc::DesktopCapturer::CreateWindowCapturer(options)
: nullptr);
media_list_.reset(new NativeDesktopMediaList(
std::move(screen_capturer), std::move(window_capturer)));
media_list_->SetThumbnailSize(thumbnail_size);
media_list_->StartUpdating(this);
}
void DesktopCapturer::OnSourceAdded(int index) {
}
void DesktopCapturer::OnSourceRemoved(int index) {
}
void DesktopCapturer::OnSourceMoved(int old_index, int new_index) {
}
void DesktopCapturer::OnSourceNameChanged(int index) {
}
void DesktopCapturer::OnSourceThumbnailChanged(int index) {
}
bool DesktopCapturer::OnRefreshFinished() {
Emit("finished", media_list_->GetSources());
return false;
}
// static
mate::Handle<DesktopCapturer> DesktopCapturer::Create(v8::Isolate* isolate) {
return mate::CreateHandle(isolate, new DesktopCapturer(isolate));
}
// static
void DesktopCapturer::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "DesktopCapturer"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("startHandling", &DesktopCapturer::StartHandling);
}
} // namespace api
} // namespace atom
namespace {
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.Set("desktopCapturer", atom::api::DesktopCapturer::Create(isolate));
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_desktop_capturer, Initialize);

View File

@@ -0,0 +1,51 @@
// Copyright (c) 2015 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_DESKTOP_CAPTURER_H_
#define ATOM_BROWSER_API_ATOM_API_DESKTOP_CAPTURER_H_
#include "atom/browser/api/event_emitter.h"
#include "chrome/browser/media/desktop_media_list_observer.h"
#include "chrome/browser/media/native_desktop_media_list.h"
#include "native_mate/handle.h"
namespace atom {
namespace api {
class DesktopCapturer: public mate::EventEmitter<DesktopCapturer>,
public DesktopMediaListObserver {
public:
static mate::Handle<DesktopCapturer> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
void StartHandling(bool capture_window,
bool capture_screen,
const gfx::Size& thumbnail_size);
protected:
explicit DesktopCapturer(v8::Isolate* isolate);
~DesktopCapturer() override;
// DesktopMediaListObserver overrides.
void OnSourceAdded(int index) override;
void OnSourceRemoved(int index) override;
void OnSourceMoved(int old_index, int new_index) override;
void OnSourceNameChanged(int index) override;
void OnSourceThumbnailChanged(int index) override;
bool OnRefreshFinished() override;
private:
std::unique_ptr<DesktopMediaList> media_list_;
DISALLOW_COPY_AND_ASSIGN(DesktopCapturer);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_DESKTOP_CAPTURER_H_

View File

@@ -8,11 +8,13 @@
#include "atom/browser/api/atom_api_window.h"
#include "atom/browser/native_window.h"
#include "atom/browser/ui/certificate_trust.h"
#include "atom/browser/ui/file_dialog.h"
#include "atom/browser/ui/message_box.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/native_mate_converters/image_converter.h"
#include "atom/common/native_mate_converters/net_converter.h"
#include "native_mate/dictionary.h"
#include "atom/common/node_includes.h"
@@ -35,17 +37,41 @@ struct Converter<file_dialog::Filter> {
}
};
template<>
struct Converter<file_dialog::DialogSettings> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
file_dialog::DialogSettings* out) {
mate::Dictionary dict;
if (!ConvertFromV8(isolate, val, &dict))
return false;
dict.Get("window", &(out->parent_window));
dict.Get("title", &(out->title));
dict.Get("message", &(out->message));
dict.Get("buttonLabel", &(out->button_label));
dict.Get("nameFieldLabel", &(out->name_field_label));
dict.Get("defaultPath", &(out->default_path));
dict.Get("filters", &(out->filters));
dict.Get("properties", &(out->properties));
dict.Get("showsTagField", &(out->shows_tag_field));
return true;
}
};
} // namespace mate
namespace {
void ShowMessageBox(int type,
const std::vector<std::string>& buttons,
int default_id,
int cancel_id,
int options,
const std::string& title,
const std::string& message,
const std::string& detail,
const std::string& checkbox_label,
bool checkbox_checked,
const gfx::ImageSkia& icon,
atom::NativeWindow* window,
mate::Arguments* args) {
@@ -54,52 +80,44 @@ void ShowMessageBox(int type,
if (mate::Converter<atom::MessageBoxCallback>::FromV8(args->isolate(),
peek,
&callback)) {
atom::ShowMessageBox(window, (atom::MessageBoxType)type, buttons, cancel_id,
options, title, message, detail, icon, callback);
atom::ShowMessageBox(window, static_cast<atom::MessageBoxType>(type),
buttons, default_id, cancel_id, options, title,
message, detail, checkbox_label, checkbox_checked,
icon, callback);
} else {
int chosen = atom::ShowMessageBox(window, (atom::MessageBoxType)type,
buttons, cancel_id, options, title,
message, detail, icon);
int chosen = atom::ShowMessageBox(
window, static_cast<atom::MessageBoxType>(type), buttons, default_id,
cancel_id, options, title, message, detail, icon);
args->Return(chosen);
}
}
void ShowOpenDialog(const std::string& title,
const base::FilePath& default_path,
const file_dialog::Filters& filters,
int properties,
atom::NativeWindow* window,
void ShowOpenDialog(const file_dialog::DialogSettings& settings,
mate::Arguments* args) {
v8::Local<v8::Value> peek = args->PeekNext();
file_dialog::OpenDialogCallback callback;
if (mate::Converter<file_dialog::OpenDialogCallback>::FromV8(args->isolate(),
peek,
&callback)) {
file_dialog::ShowOpenDialog(window, title, default_path, filters,
properties, callback);
file_dialog::ShowOpenDialog(settings, callback);
} else {
std::vector<base::FilePath> paths;
if (file_dialog::ShowOpenDialog(window, title, default_path, filters,
properties, &paths))
if (file_dialog::ShowOpenDialog(settings, &paths))
args->Return(paths);
}
}
void ShowSaveDialog(const std::string& title,
const base::FilePath& default_path,
const file_dialog::Filters& filters,
atom::NativeWindow* window,
void ShowSaveDialog(const file_dialog::DialogSettings& settings,
mate::Arguments* args) {
v8::Local<v8::Value> peek = args->PeekNext();
file_dialog::SaveDialogCallback callback;
if (mate::Converter<file_dialog::SaveDialogCallback>::FromV8(args->isolate(),
peek,
&callback)) {
file_dialog::ShowSaveDialog(window, title, default_path, filters, callback);
file_dialog::ShowSaveDialog(settings, callback);
} else {
base::FilePath path;
if (file_dialog::ShowSaveDialog(window, title, default_path, filters,
&path))
if (file_dialog::ShowSaveDialog(settings, &path))
args->Return(path);
}
}
@@ -111,6 +129,10 @@ void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
dict.SetMethod("showErrorBox", &atom::ShowErrorBox);
dict.SetMethod("showOpenDialog", &ShowOpenDialog);
dict.SetMethod("showSaveDialog", &ShowSaveDialog);
#if defined(OS_MACOSX) || defined(OS_WIN)
dict.SetMethod("showCertificateTrustDialog",
&certificate_trust::ShowCertificateTrust);
#endif
}
} // namespace

View File

@@ -6,15 +6,17 @@
#include <map>
#include "atom/browser/atom_browser_main_parts.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/node_includes.h"
#include "base/memory/linked_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "native_mate/dictionary.h"
#include "net/base/filename_util.h"
#include "atom/common/node_includes.h"
namespace mate {
template<>
@@ -23,6 +25,9 @@ struct Converter<content::DownloadItem::DownloadState> {
content::DownloadItem::DownloadState state) {
std::string download_state;
switch (state) {
case content::DownloadItem::IN_PROGRESS:
download_state = "progressing";
break;
case content::DownloadItem::COMPLETE:
download_state = "completed";
break;
@@ -46,140 +51,173 @@ namespace atom {
namespace api {
namespace {
// The wrapDownloadItem funtion which is implemented in JavaScript
using WrapDownloadItemCallback = base::Callback<void(v8::Local<v8::Value>)>;
WrapDownloadItemCallback g_wrap_download_item;
char kDownloadItemSavePathKey[] = "DownloadItemSavePathKey";
std::map<uint32_t, v8::Global<v8::Object>> g_download_item_objects;
std::map<uint32, linked_ptr<v8::Global<v8::Value>>> g_download_item_objects;
} // namespace
DownloadItem::SavePathData::SavePathData(const base::FilePath& path) :
path_(path) {
}
const base::FilePath& DownloadItem::SavePathData::path() {
return path_;
}
DownloadItem::DownloadItem(content::DownloadItem* download_item) :
download_item_(download_item) {
DownloadItem::DownloadItem(v8::Isolate* isolate,
content::DownloadItem* download_item)
: download_item_(download_item) {
download_item_->AddObserver(this);
Init(isolate);
AttachAsUserData(download_item);
}
DownloadItem::~DownloadItem() {
Destroy();
}
void DownloadItem::Destroy() {
if (download_item_) {
// Destroyed by either garbage collection or destroy().
download_item_->RemoveObserver(this);
auto iter = g_download_item_objects.find(download_item_->GetId());
if (iter != g_download_item_objects.end())
g_download_item_objects.erase(iter);
download_item_ = nullptr;
download_item_->Remove();
}
}
bool DownloadItem::IsDestroyed() const {
return download_item_ == nullptr;
// Remove from the global map.
g_download_item_objects.erase(weak_map_id());
}
void DownloadItem::OnDownloadUpdated(content::DownloadItem* item) {
download_item_->IsDone() ? Emit("done", item->GetState()) : Emit("updated");
if (download_item_->IsDone()) {
Emit("done", item->GetState());
// Destroy the item once item is downloaded.
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, GetDestroyClosure());
} else {
Emit("updated", item->GetState());
}
}
void DownloadItem::OnDownloadDestroyed(content::DownloadItem* download) {
Destroy();
}
int64 DownloadItem::GetReceivedBytes() {
return download_item_->GetReceivedBytes();
}
int64 DownloadItem::GetTotalBytes() {
return download_item_->GetTotalBytes();
}
const GURL& DownloadItem::GetUrl() {
return download_item_->GetURL();
}
std::string DownloadItem::GetMimeType() {
return download_item_->GetMimeType();
}
bool DownloadItem::HasUserGesture() {
return download_item_->HasUserGesture();
}
std::string DownloadItem::GetFilename() {
return base::UTF16ToUTF8(net::GenerateFileName(GetUrl(),
GetContentDisposition(),
std::string(),
download_item_->GetSuggestedFilename(),
GetMimeType(),
std::string()).LossyDisplayName());
}
std::string DownloadItem::GetContentDisposition() {
return download_item_->GetContentDisposition();
}
void DownloadItem::SetSavePath(const base::FilePath& path) {
download_item_->SetUserData(UserDataKey(), new SavePathData(path));
void DownloadItem::OnDownloadDestroyed(content::DownloadItem* download_item) {
download_item_ = nullptr;
// Destroy the native class immediately when downloadItem is destroyed.
delete this;
}
void DownloadItem::Pause() {
download_item_->Pause();
}
bool DownloadItem::IsPaused() const {
return download_item_->IsPaused();
}
void DownloadItem::Resume() {
download_item_->Resume();
}
bool DownloadItem::CanResume() const {
return download_item_->CanResume();
}
void DownloadItem::Cancel() {
download_item_->Cancel(true);
}
mate::ObjectTemplateBuilder DownloadItem::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
int64_t DownloadItem::GetReceivedBytes() const {
return download_item_->GetReceivedBytes();
}
int64_t DownloadItem::GetTotalBytes() const {
return download_item_->GetTotalBytes();
}
std::string DownloadItem::GetMimeType() const {
return download_item_->GetMimeType();
}
bool DownloadItem::HasUserGesture() const {
return download_item_->HasUserGesture();
}
std::string DownloadItem::GetFilename() const {
return base::UTF16ToUTF8(net::GenerateFileName(GetURL(),
GetContentDisposition(),
std::string(),
download_item_->GetSuggestedFilename(),
GetMimeType(),
"download").LossyDisplayName());
}
std::string DownloadItem::GetContentDisposition() const {
return download_item_->GetContentDisposition();
}
const GURL& DownloadItem::GetURL() const {
return download_item_->GetURL();
}
const std::vector<GURL>& DownloadItem::GetURLChain() const {
return download_item_->GetUrlChain();
}
content::DownloadItem::DownloadState DownloadItem::GetState() const {
return download_item_->GetState();
}
bool DownloadItem::IsDone() const {
return download_item_->IsDone();
}
void DownloadItem::SetSavePath(const base::FilePath& path) {
save_path_ = path;
}
base::FilePath DownloadItem::GetSavePath() const {
return save_path_;
}
std::string DownloadItem::GetLastModifiedTime() const {
return download_item_->GetLastModifiedTime();
}
std::string DownloadItem::GetETag() const {
return download_item_->GetETag();
}
double DownloadItem::GetStartTime() const {
return download_item_->GetStartTime().ToDoubleT();
}
// static
void DownloadItem::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "DownloadItem"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("pause", &DownloadItem::Pause)
.SetMethod("isPaused", &DownloadItem::IsPaused)
.SetMethod("resume", &DownloadItem::Resume)
.SetMethod("canResume", &DownloadItem::CanResume)
.SetMethod("cancel", &DownloadItem::Cancel)
.SetMethod("getReceivedBytes", &DownloadItem::GetReceivedBytes)
.SetMethod("getTotalBytes", &DownloadItem::GetTotalBytes)
.SetMethod("getUrl", &DownloadItem::GetUrl)
.SetMethod("getMimeType", &DownloadItem::GetMimeType)
.SetMethod("hasUserGesture", &DownloadItem::HasUserGesture)
.SetMethod("getFilename", &DownloadItem::GetFilename)
.SetMethod("getContentDisposition", &DownloadItem::GetContentDisposition)
.SetMethod("setSavePath", &DownloadItem::SetSavePath);
}
void SetWrapDownloadItem(const WrapDownloadItemCallback& callback) {
g_wrap_download_item = callback;
}
void ClearWrapDownloadItem() {
g_wrap_download_item.Reset();
.SetMethod("getURL", &DownloadItem::GetURL)
.SetMethod("getURLChain", &DownloadItem::GetURLChain)
.SetMethod("getState", &DownloadItem::GetState)
.SetMethod("isDone", &DownloadItem::IsDone)
.SetMethod("setSavePath", &DownloadItem::SetSavePath)
.SetMethod("getSavePath", &DownloadItem::GetSavePath)
.SetMethod("getLastModifiedTime", &DownloadItem::GetLastModifiedTime)
.SetMethod("getETag", &DownloadItem::GetETag)
.SetMethod("getStartTime", &DownloadItem::GetStartTime);
}
// static
mate::Handle<DownloadItem> DownloadItem::Create(
v8::Isolate* isolate, content::DownloadItem* item) {
auto handle = mate::CreateHandle(isolate, new DownloadItem(item));
g_wrap_download_item.Run(handle.ToV8());
g_download_item_objects[item->GetId()] = make_linked_ptr(
new v8::Global<v8::Value>(isolate, handle.ToV8()));
return handle;
}
auto existing = TrackableObject::FromWrappedClass(isolate, item);
if (existing)
return mate::CreateHandle(isolate, static_cast<DownloadItem*>(existing));
// static
void* DownloadItem::UserDataKey() {
return &kDownloadItemSavePathKey;
auto handle = mate::CreateHandle(isolate, new DownloadItem(isolate, item));
// Reference this object in case it got garbage collected.
g_download_item_objects[handle->weak_map_id()] =
v8::Global<v8::Object>(isolate, handle.ToV8());
return handle;
}
} // namespace api
@@ -191,9 +229,9 @@ namespace {
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.SetMethod("_setWrapDownloadItem", &atom::api::SetWrapDownloadItem);
dict.SetMethod("_clearWrapDownloadItem", &atom::api::ClearWrapDownloadItem);
mate::Dictionary(isolate, exports)
.Set("DownloadItem",
atom::api::DownloadItem::GetConstructor(isolate)->GetFunction());
}
} // namespace

View File

@@ -6,6 +6,7 @@
#define ATOM_BROWSER_API_ATOM_API_DOWNLOAD_ITEM_H_
#include <string>
#include <vector>
#include "atom/browser/api/trackable_object.h"
#include "base/files/file_path.h"
@@ -17,49 +18,46 @@ namespace atom {
namespace api {
class DownloadItem : public mate::EventEmitter,
class DownloadItem : public mate::TrackableObject<DownloadItem>,
public content::DownloadItem::Observer {
public:
class SavePathData : public base::SupportsUserData::Data {
public:
explicit SavePathData(const base::FilePath& path);
const base::FilePath& path();
private:
base::FilePath path_;
};
static mate::Handle<DownloadItem> Create(v8::Isolate* isolate,
content::DownloadItem* item);
static void* UserDataKey();
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
void Pause();
bool IsPaused() const;
void Resume();
bool CanResume() const;
void Cancel();
int64_t GetReceivedBytes() const;
int64_t GetTotalBytes() const;
std::string GetMimeType() const;
bool HasUserGesture() const;
std::string GetFilename() const;
std::string GetContentDisposition() const;
const GURL& GetURL() const;
const std::vector<GURL>& GetURLChain() const;
content::DownloadItem::DownloadState GetState() const;
bool IsDone() const;
void SetSavePath(const base::FilePath& path);
base::FilePath GetSavePath() const;
std::string GetLastModifiedTime() const;
std::string GetETag() const;
double GetStartTime() const;
protected:
explicit DownloadItem(content::DownloadItem* download_item);
DownloadItem(v8::Isolate* isolate, content::DownloadItem* download_item);
~DownloadItem();
// Override content::DownloadItem::Observer methods
void OnDownloadUpdated(content::DownloadItem* download) override;
void OnDownloadDestroyed(content::DownloadItem* download) override;
void Pause();
void Resume();
void Cancel();
int64 GetReceivedBytes();
int64 GetTotalBytes();
std::string GetMimeType();
bool HasUserGesture();
std::string GetFilename();
std::string GetContentDisposition();
const GURL& GetUrl();
void SetSavePath(const base::FilePath& path);
private:
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
bool IsDestroyed() const override;
void Destroy();
base::FilePath save_path_;
content::DownloadItem* download_item_;
DISALLOW_COPY_AND_ASSIGN(DownloadItem);

View File

@@ -19,7 +19,8 @@ namespace atom {
namespace api {
GlobalShortcut::GlobalShortcut() {
GlobalShortcut::GlobalShortcut(v8::Isolate* isolate) {
Init(isolate);
}
GlobalShortcut::~GlobalShortcut() {
@@ -66,20 +67,22 @@ void GlobalShortcut::UnregisterAll() {
GlobalShortcutListener::GetInstance()->UnregisterAccelerators(this);
}
mate::ObjectTemplateBuilder GlobalShortcut::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
// static
mate::Handle<GlobalShortcut> GlobalShortcut::Create(v8::Isolate* isolate) {
return mate::CreateHandle(isolate, new GlobalShortcut(isolate));
}
// static
void GlobalShortcut::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "GlobalShortcut"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("register", &GlobalShortcut::Register)
.SetMethod("isRegistered", &GlobalShortcut::IsRegistered)
.SetMethod("unregister", &GlobalShortcut::Unregister)
.SetMethod("unregisterAll", &GlobalShortcut::UnregisterAll);
}
// static
mate::Handle<GlobalShortcut> GlobalShortcut::Create(v8::Isolate* isolate) {
return CreateHandle(isolate, new GlobalShortcut);
}
} // namespace api
} // namespace atom

View File

@@ -8,9 +8,9 @@
#include <map>
#include <string>
#include "atom/browser/api/trackable_object.h"
#include "base/callback.h"
#include "chrome/browser/extensions/global_shortcut_listener.h"
#include "native_mate/wrappable.h"
#include "native_mate/handle.h"
#include "ui/base/accelerators/accelerator.h"
@@ -19,17 +19,16 @@ namespace atom {
namespace api {
class GlobalShortcut : public extensions::GlobalShortcutListener::Observer,
public mate::Wrappable {
public mate::TrackableObject<GlobalShortcut> {
public:
static mate::Handle<GlobalShortcut> Create(v8::Isolate* isolate);
protected:
GlobalShortcut();
virtual ~GlobalShortcut();
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// mate::Wrappable implementations:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
protected:
explicit GlobalShortcut(v8::Isolate* isolate);
~GlobalShortcut() override;
private:
typedef std::map<ui::Accelerator, base::Closure> AcceleratorCallbackMap;

View File

@@ -19,16 +19,17 @@ namespace atom {
namespace api {
Menu::Menu()
Menu::Menu(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
: model_(new AtomMenuModel(this)),
parent_(NULL) {
parent_(nullptr) {
InitWith(isolate, wrapper);
}
Menu::~Menu() {
}
void Menu::AfterInit(v8::Isolate* isolate) {
mate::Dictionary wrappable(isolate, GetWrapper(isolate));
mate::Dictionary wrappable(isolate, GetWrapper());
mate::Dictionary delegate;
if (!wrappable.Get("delegate", &delegate))
return;
@@ -53,16 +54,21 @@ bool Menu::IsCommandIdVisible(int command_id) const {
return is_visible_.Run(command_id);
}
bool Menu::GetAcceleratorForCommandId(int command_id,
ui::Accelerator* accelerator) {
bool Menu::GetAcceleratorForCommandIdWithParams(
int command_id,
bool use_default_accelerator,
ui::Accelerator* accelerator) const {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Value> val = get_accelerator_.Run(command_id);
v8::Local<v8::Value> val = get_accelerator_.Run(
command_id, use_default_accelerator);
return mate::ConvertFromV8(isolate(), val, accelerator);
}
void Menu::ExecuteCommand(int command_id, int event_flags) {
execute_command_.Run(command_id);
void Menu::ExecuteCommand(int command_id, int flags) {
execute_command_.Run(
mate::internal::CreateEventFromFlags(isolate(), flags),
command_id);
}
void Menu::MenuWillShow(ui::SimpleMenuModel* source) {
@@ -149,8 +155,10 @@ bool Menu::IsVisibleAt(int index) const {
// static
void Menu::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype) {
mate::ObjectTemplateBuilder(isolate, prototype)
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Menu"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("insertItem", &Menu::InsertItemAt)
.SetMethod("insertCheckItem", &Menu::InsertCheckItemAt)
.SetMethod("insertRadioItem", &Menu::InsertRadioItemAt)
@@ -168,8 +176,8 @@ void Menu::BuildPrototype(v8::Isolate* isolate,
.SetMethod("isItemCheckedAt", &Menu::IsItemCheckedAt)
.SetMethod("isEnabledAt", &Menu::IsEnabledAt)
.SetMethod("isVisibleAt", &Menu::IsVisibleAt)
.SetMethod("_popup", &Menu::Popup)
.SetMethod("_popupAt", &Menu::PopupAt);
.SetMethod("popupAt", &Menu::PopupAt)
.SetMethod("closePopupAt", &Menu::ClosePopupAt);
}
} // namespace api
@@ -179,14 +187,15 @@ void Menu::BuildPrototype(v8::Isolate* isolate,
namespace {
using atom::api::Menu;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
using atom::api::Menu;
v8::Isolate* isolate = context->GetIsolate();
v8::Local<v8::Function> constructor = mate::CreateConstructor<Menu>(
isolate, "Menu", base::Bind(&Menu::Create));
Menu::SetConstructor(isolate, base::Bind(&Menu::New));
mate::Dictionary dict(isolate, exports);
dict.Set("Menu", static_cast<v8::Local<v8::Value>>(constructor));
dict.Set("Menu", Menu::GetConstructor(isolate)->GetFunction());
#if defined(OS_MACOSX)
dict.SetMethod("setApplicationMenu", &Menu::SetApplicationMenu);
dict.SetMethod("sendActionToFirstResponder",

View File

@@ -5,25 +5,25 @@
#ifndef ATOM_BROWSER_API_ATOM_API_MENU_H_
#define ATOM_BROWSER_API_ATOM_API_MENU_H_
#include <memory>
#include <string>
#include "atom/browser/api/atom_api_window.h"
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/ui/atom_menu_model.h"
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "native_mate/wrappable.h"
namespace atom {
namespace api {
class Menu : public mate::Wrappable,
class Menu : public mate::TrackableObject<Menu>,
public AtomMenuModel::Delegate {
public:
static mate::Wrappable* Create();
static mate::WrappableBase* New(mate::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype);
v8::Local<v8::FunctionTemplate> prototype);
#if defined(OS_MACOSX)
// Set the global menubar.
@@ -36,8 +36,8 @@ class Menu : public mate::Wrappable,
AtomMenuModel* model() const { return model_.get(); }
protected:
Menu();
virtual ~Menu();
Menu(v8::Isolate* isolate, v8::Local<v8::Object> wrapper);
~Menu() override;
// mate::Wrappable:
void AfterInit(v8::Isolate* isolate) override;
@@ -46,15 +46,18 @@ class Menu : public mate::Wrappable,
bool IsCommandIdChecked(int command_id) const override;
bool IsCommandIdEnabled(int command_id) const override;
bool IsCommandIdVisible(int command_id) const override;
bool GetAcceleratorForCommandId(int command_id,
ui::Accelerator* accelerator) override;
bool GetAcceleratorForCommandIdWithParams(
int command_id,
bool use_default_accelerator,
ui::Accelerator* accelerator) const override;
void ExecuteCommand(int command_id, int event_flags) override;
void MenuWillShow(ui::SimpleMenuModel* source) override;
virtual void Popup(Window* window) = 0;
virtual void PopupAt(Window* window, int x, int y) = 0;
virtual void PopupAt(
Window* window, int x, int y, int positioning_item, bool async) = 0;
virtual void ClosePopupAt(int32_t window_id) = 0;
scoped_ptr<AtomMenuModel> model_;
std::unique_ptr<AtomMenuModel> model_;
Menu* parent_;
private:
@@ -88,8 +91,8 @@ class Menu : public mate::Wrappable,
base::Callback<bool(int)> is_checked_;
base::Callback<bool(int)> is_enabled_;
base::Callback<bool(int)> is_visible_;
base::Callback<v8::Local<v8::Value>(int)> get_accelerator_;
base::Callback<void(int)> execute_command_;
base::Callback<v8::Local<v8::Value>(int, bool)> get_accelerator_;
base::Callback<void(v8::Local<v8::Value>, int)> execute_command_;
base::Callback<void()> menu_will_show_;
DISALLOW_COPY_AND_ASSIGN(Menu);

View File

@@ -7,28 +7,40 @@
#include "atom/browser/api/atom_api_menu.h"
#include <map>
#include <string>
#import "atom/browser/ui/cocoa/atom_menu_controller.h"
using base::scoped_nsobject;
namespace atom {
namespace api {
class MenuMac : public Menu {
protected:
MenuMac();
MenuMac(v8::Isolate* isolate, v8::Local<v8::Object> wrapper);
void Popup(Window* window) override;
void PopupAt(Window* window, int x, int y) override;
base::scoped_nsobject<AtomMenuController> menu_controller_;
void PopupAt(
Window* window, int x, int y, int positioning_item, bool async) override;
void PopupOnUI(const base::WeakPtr<NativeWindow>& native_window,
int32_t window_id, int x, int y, int positioning_item,
bool async);
void ClosePopupAt(int32_t window_id) override;
private:
friend class Menu;
static void SendActionToFirstResponder(const std::string& action);
scoped_nsobject<AtomMenuController> menu_controller_;
// window ID -> open context menu
std::map<int32_t, scoped_nsobject<AtomMenuController>> popup_controllers_;
base::WeakPtrFactory<MenuMac> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(MenuMac);
};

View File

@@ -5,75 +5,128 @@
#import "atom/browser/api/atom_api_menu_mac.h"
#include "atom/browser/native_window.h"
#include "atom/browser/unresponsive_suppressor.h"
#include "base/mac/scoped_sending_event.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/sys_string_conversions.h"
#include "brightray/browser/inspectable_web_contents.h"
#include "brightray/browser/inspectable_web_contents_view.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "atom/common/node_includes.h"
using content::BrowserThread;
namespace atom {
namespace api {
MenuMac::MenuMac() {
MenuMac::MenuMac(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
: Menu(isolate, wrapper),
weak_factory_(this) {
}
void MenuMac::Popup(Window* window) {
void MenuMac::PopupAt(
Window* window, int x, int y, int positioning_item, bool async) {
NativeWindow* native_window = window->window();
if (!native_window)
return;
content::WebContents* web_contents = native_window->web_contents();
if (!web_contents)
return;
NSWindow* nswindow = native_window->GetNativeWindow();
base::scoped_nsobject<AtomMenuController> menu_controller(
[[AtomMenuController alloc] initWithModel:model_.get()]);
// Fake out a context menu event.
NSEvent* currentEvent = [NSApp currentEvent];
NSPoint position = [nswindow mouseLocationOutsideOfEventStream];
NSTimeInterval eventTime = [currentEvent timestamp];
NSEvent* clickEvent = [NSEvent mouseEventWithType:NSRightMouseDown
location:position
modifierFlags:NSRightMouseDownMask
timestamp:eventTime
windowNumber:[nswindow windowNumber]
context:nil
eventNumber:0
clickCount:1
pressure:1.0];
// Show the menu.
[NSMenu popUpContextMenu:[menu_controller menu]
withEvent:clickEvent
forView:web_contents->GetContentNativeView()];
auto popup = base::Bind(&MenuMac::PopupOnUI, weak_factory_.GetWeakPtr(),
native_window->GetWeakPtr(), window->ID(), x, y,
positioning_item, async);
if (async)
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, popup);
else
popup.Run();
}
void MenuMac::PopupAt(Window* window, int x, int y) {
NativeWindow* native_window = window->window();
void MenuMac::PopupOnUI(const base::WeakPtr<NativeWindow>& native_window,
int32_t window_id, int x, int y, int positioning_item,
bool async) {
if (!native_window)
return;
content::WebContents* web_contents = native_window->web_contents();
brightray::InspectableWebContents* web_contents =
native_window->inspectable_web_contents();
if (!web_contents)
return;
base::scoped_nsobject<AtomMenuController> menu_controller(
[[AtomMenuController alloc] initWithModel:model_.get()]);
NSMenu* menu = [menu_controller menu];
NSView* view = web_contents->GetContentNativeView();
auto close_callback = base::Bind(&MenuMac::ClosePopupAt,
weak_factory_.GetWeakPtr(), window_id);
popup_controllers_[window_id] = base::scoped_nsobject<AtomMenuController>(
[[AtomMenuController alloc] initWithModel:model()
useDefaultAccelerator:NO]);
NSMenu* menu = [popup_controllers_[window_id] menu];
NSView* view = web_contents->GetView()->GetNativeView();
// Show the menu.
[menu popUpMenuPositioningItem:[menu itemAtIndex:0]
atLocation:NSMakePoint(x, [view frame].size.height - y)
inView:view];
// Which menu item to show.
NSMenuItem* item = nil;
if (positioning_item < [menu numberOfItems] && positioning_item >= 0)
item = [menu itemAtIndex:positioning_item];
// (-1, -1) means showing on mouse location.
NSPoint position;
if (x == -1 || y == -1) {
NSWindow* nswindow = native_window->GetNativeWindow();
position = [view convertPoint:[nswindow mouseLocationOutsideOfEventStream]
fromView:nil];
} else {
position = NSMakePoint(x, [view frame].size.height - y);
}
// If no preferred item is specified, try to show all of the menu items.
if (!positioning_item) {
CGFloat windowBottom = CGRectGetMinY([view window].frame);
CGFloat lowestMenuPoint = windowBottom + position.y - [menu size].height;
CGFloat screenBottom = CGRectGetMinY([view window].screen.frame);
CGFloat distanceFromBottom = lowestMenuPoint - screenBottom;
if (distanceFromBottom < 0)
position.y = position.y - distanceFromBottom + 4;
}
// Place the menu left of cursor if it is overflowing off right of screen.
CGFloat windowLeft = CGRectGetMinX([view window].frame);
CGFloat rightmostMenuPoint = windowLeft + position.x + [menu size].width;
CGFloat screenRight = CGRectGetMaxX([view window].screen.frame);
if (rightmostMenuPoint > screenRight)
position.x = position.x - [menu size].width;
if (async) {
[popup_controllers_[window_id] setCloseCallback:close_callback];
// Make sure events can be pumped while the menu is up.
base::MessageLoop::ScopedNestableTaskAllower allow(
base::MessageLoop::current());
// One of the events that could be pumped is |window.close()|.
// User-initiated event-tracking loops protect against this by
// setting flags in -[CrApplication sendEvent:], but since
// web-content menus are initiated by IPC message the setup has to
// be done manually.
base::mac::ScopedSendingEvent sendingEventScoper;
// Don't emit unresponsive event when showing menu.
atom::UnresponsiveSuppressor suppressor;
[menu popUpMenuPositioningItem:item atLocation:position inView:view];
} else {
// Don't emit unresponsive event when showing menu.
atom::UnresponsiveSuppressor suppressor;
[menu popUpMenuPositioningItem:item atLocation:position inView:view];
close_callback.Run();
}
}
void MenuMac::ClosePopupAt(int32_t window_id) {
popup_controllers_.erase(window_id);
}
// static
void Menu::SetApplicationMenu(Menu* base_menu) {
MenuMac* menu = static_cast<MenuMac*>(base_menu);
base::scoped_nsobject<AtomMenuController> menu_controller(
[[AtomMenuController alloc] initWithModel:menu->model_.get()]);
[[AtomMenuController alloc] initWithModel:menu->model_.get()
useDefaultAccelerator:YES]);
[NSApp setMainMenu:[menu_controller menu]];
// Ensure the menu_controller_ is destroyed after main menu is set.
@@ -87,8 +140,8 @@ void Menu::SendActionToFirstResponder(const std::string& action) {
}
// static
mate::Wrappable* Menu::Create() {
return new MenuMac();
mate::WrappableBase* Menu::New(mate::Arguments* args) {
return new MenuMac(args->isolate(), args->GetThis());
}
} // namespace api

View File

@@ -5,22 +5,23 @@
#include "atom/browser/api/atom_api_menu_views.h"
#include "atom/browser/native_window_views.h"
#include "atom/browser/unresponsive_suppressor.h"
#include "content/public/browser/render_widget_host_view.h"
#include "ui/gfx/screen.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/display/screen.h"
using views::MenuRunner;
namespace atom {
namespace api {
MenuViews::MenuViews() {
MenuViews::MenuViews(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
: Menu(isolate, wrapper),
weak_factory_(this) {
}
void MenuViews::Popup(Window* window) {
PopupAtPoint(window, gfx::Screen::GetNativeScreen()->GetCursorScreenPoint());
}
void MenuViews::PopupAt(Window* window, int x, int y) {
void MenuViews::PopupAt(
Window* window, int x, int y, int positioning_item, bool async) {
NativeWindow* native_window = static_cast<NativeWindow*>(window->window());
if (!native_window)
return;
@@ -31,25 +32,43 @@ void MenuViews::PopupAt(Window* window, int x, int y) {
if (!view)
return;
gfx::Point origin = view->GetViewBounds().origin();
PopupAtPoint(window, gfx::Point(origin.x() + x, origin.y() + y));
}
// (-1, -1) means showing on mouse location.
gfx::Point location;
if (x == -1 || y == -1) {
location = display::Screen::GetScreen()->GetCursorScreenPoint();
} else {
gfx::Point origin = view->GetViewBounds().origin();
location = gfx::Point(origin.x() + x, origin.y() + y);
}
void MenuViews::PopupAtPoint(Window* window, const gfx::Point& point) {
views::MenuRunner menu_runner(
model(),
views::MenuRunner::CONTEXT_MENU | views::MenuRunner::HAS_MNEMONICS);
ignore_result(menu_runner.RunMenuAt(
int flags = MenuRunner::CONTEXT_MENU | MenuRunner::HAS_MNEMONICS;
if (async)
flags |= MenuRunner::ASYNC;
// Don't emit unresponsive event when showing menu.
atom::UnresponsiveSuppressor suppressor;
// Show the menu.
int32_t window_id = window->ID();
auto close_callback = base::Bind(
&MenuViews::ClosePopupAt, weak_factory_.GetWeakPtr(), window_id);
menu_runners_[window_id] = std::unique_ptr<MenuRunner>(new MenuRunner(
model(), flags, close_callback));
ignore_result(menu_runners_[window_id]->RunMenuAt(
static_cast<NativeWindowViews*>(window->window())->widget(),
NULL,
gfx::Rect(point, gfx::Size()),
gfx::Rect(location, gfx::Size()),
views::MENU_ANCHOR_TOPLEFT,
ui::MENU_SOURCE_MOUSE));
}
void MenuViews::ClosePopupAt(int32_t window_id) {
menu_runners_.erase(window_id);
}
// static
mate::Wrappable* Menu::Create() {
return new MenuViews();
mate::WrappableBase* Menu::New(mate::Arguments* args) {
return new MenuViews(args->isolate(), args->GetThis());
}
} // namespace api

View File

@@ -5,8 +5,12 @@
#ifndef ATOM_BROWSER_API_ATOM_API_MENU_VIEWS_H_
#define ATOM_BROWSER_API_ATOM_API_MENU_VIEWS_H_
#include <map>
#include "atom/browser/api/atom_api_menu.h"
#include "ui/gfx/screen.h"
#include "base/memory/weak_ptr.h"
#include "ui/display/screen.h"
#include "ui/views/controls/menu/menu_runner.h"
namespace atom {
@@ -14,14 +18,18 @@ namespace api {
class MenuViews : public Menu {
public:
MenuViews();
MenuViews(v8::Isolate* isolate, v8::Local<v8::Object> wrapper);
protected:
void Popup(Window* window) override;
void PopupAt(Window* window, int x, int y) override;
void PopupAt(
Window* window, int x, int y, int positioning_item, bool async) override;
void ClosePopupAt(int32_t window_id) override;
private:
void PopupAtPoint(Window* window, const gfx::Point& point);
// window ID -> open context menu
std::map<int32_t, std::unique_ptr<views::MenuRunner>> menu_runners_;
base::WeakPtrFactory<MenuViews> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(MenuViews);
};

View File

@@ -0,0 +1,61 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_net.h"
#include "atom/browser/api/atom_api_url_request.h"
#include "atom/common/node_includes.h"
#include "native_mate/dictionary.h"
namespace atom {
namespace api {
Net::Net(v8::Isolate* isolate) {
Init(isolate);
}
Net::~Net() {}
// static
v8::Local<v8::Value> Net::Create(v8::Isolate* isolate) {
return mate::CreateHandle(isolate, new Net(isolate)).ToV8();
}
// static
void Net::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Net"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetProperty("URLRequest", &Net::URLRequest);
}
v8::Local<v8::Value> Net::URLRequest(v8::Isolate* isolate) {
return URLRequest::GetConstructor(isolate)->GetFunction();
}
} // namespace api
} // namespace atom
namespace {
using atom::api::Net;
using atom::api::URLRequest;
void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context,
void* priv) {
v8::Isolate* isolate = context->GetIsolate();
URLRequest::SetConstructor(isolate, base::Bind(URLRequest::New));
mate::Dictionary dict(isolate, exports);
dict.Set("net", Net::Create(isolate));
dict.Set("Net", Net::GetConstructor(isolate)->GetFunction());
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_net, Initialize)

View File

@@ -0,0 +1,35 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_NET_H_
#define ATOM_BROWSER_API_ATOM_API_NET_H_
#include "atom/browser/api/event_emitter.h"
namespace atom {
namespace api {
class Net : public mate::EventEmitter<Net> {
public:
static v8::Local<v8::Value> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
v8::Local<v8::Value> URLRequest(v8::Isolate* isolate);
protected:
explicit Net(v8::Isolate* isolate);
~Net() override;
private:
DISALLOW_COPY_AND_ASSIGN(Net);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_NET_H_

View File

@@ -5,17 +5,19 @@
#include "atom/browser/api/atom_api_power_monitor.h"
#include "atom/browser/browser.h"
#include "atom/common/node_includes.h"
#include "base/power_monitor/power_monitor.h"
#include "base/power_monitor/power_monitor_device_source.h"
#include "native_mate/dictionary.h"
#include "atom/common/node_includes.h"
namespace atom {
namespace api {
PowerMonitor::PowerMonitor() {
PowerMonitor::PowerMonitor(v8::Isolate* isolate) {
base::PowerMonitor::Get()->AddObserver(this);
Init(isolate);
}
PowerMonitor::~PowerMonitor() {
@@ -42,11 +44,17 @@ v8::Local<v8::Value> PowerMonitor::Create(v8::Isolate* isolate) {
if (!Browser::Get()->is_ready()) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate,
"Cannot initialize \"power-monitor\" module before app is ready")));
"Cannot require \"powerMonitor\" module before app is ready")));
return v8::Null(isolate);
}
return CreateHandle(isolate, new PowerMonitor).ToV8();
return mate::CreateHandle(isolate, new PowerMonitor(isolate)).ToV8();
}
// static
void PowerMonitor::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "PowerMonitor"));
}
} // namespace api
@@ -56,16 +64,19 @@ v8::Local<v8::Value> PowerMonitor::Create(v8::Isolate* isolate) {
namespace {
using atom::api::PowerMonitor;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
#if defined(OS_MACOSX)
base::PowerMonitorDeviceSource::AllocateSystemIOPorts();
#endif
using atom::api::PowerMonitor;
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.Set("powerMonitor", PowerMonitor::Create(isolate));
dict.Set("PowerMonitor",
PowerMonitor::GetConstructor(isolate)->GetFunction());
}
} // namespace

View File

@@ -5,7 +5,7 @@
#ifndef ATOM_BROWSER_API_ATOM_API_POWER_MONITOR_H_
#define ATOM_BROWSER_API_ATOM_API_POWER_MONITOR_H_
#include "atom/browser/api/event_emitter.h"
#include "atom/browser/api/trackable_object.h"
#include "base/compiler_specific.h"
#include "base/power_monitor/power_observer.h"
#include "native_mate/handle.h"
@@ -14,14 +14,17 @@ namespace atom {
namespace api {
class PowerMonitor : public mate::EventEmitter,
class PowerMonitor : public mate::TrackableObject<PowerMonitor>,
public base::PowerObserver {
public:
static v8::Local<v8::Value> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
protected:
PowerMonitor();
virtual ~PowerMonitor();
explicit PowerMonitor(v8::Isolate* isolate);
~PowerMonitor() override;
// base::PowerObserver implementations:
void OnPowerStateChange(bool on_battery_power) override;

View File

@@ -6,18 +6,21 @@
#include <string>
#include "atom/common/node_includes.h"
#include "content/public/browser/power_save_blocker.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/dictionary.h"
#include "atom/common/node_includes.h"
using content::BrowserThread;
namespace mate {
template<>
struct Converter<content::PowerSaveBlocker::PowerSaveBlockerType> {
struct Converter<device::PowerSaveBlocker::PowerSaveBlockerType> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
content::PowerSaveBlocker::PowerSaveBlockerType* out) {
using content::PowerSaveBlocker;
device::PowerSaveBlocker::PowerSaveBlockerType* out) {
using device::PowerSaveBlocker;
std::string type;
if (!ConvertFromV8(isolate, val, &type))
return false;
@@ -37,9 +40,10 @@ namespace atom {
namespace api {
PowerSaveBlocker::PowerSaveBlocker()
PowerSaveBlocker::PowerSaveBlocker(v8::Isolate* isolate)
: current_blocker_type_(
content::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension) {
device::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension) {
Init(isolate);
}
PowerSaveBlocker::~PowerSaveBlocker() {
@@ -57,30 +61,32 @@ void PowerSaveBlocker::UpdatePowerSaveBlocker() {
// higher precedence level than |kPowerSaveBlockPreventAppSuspension|.
//
// Only the highest-precedence blocker type takes effect.
content::PowerSaveBlocker::PowerSaveBlockerType new_blocker_type =
content::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension;
device::PowerSaveBlocker::PowerSaveBlockerType new_blocker_type =
device::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension;
for (const auto& element : power_save_blocker_types_) {
if (element.second ==
content::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep) {
device::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep) {
new_blocker_type =
content::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep;
device::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep;
break;
}
}
if (!power_save_blocker_ || new_blocker_type != current_blocker_type_) {
scoped_ptr<content::PowerSaveBlocker> new_blocker =
content::PowerSaveBlocker::Create(
std::unique_ptr<device::PowerSaveBlocker> new_blocker(
new device::PowerSaveBlocker(
new_blocker_type,
content::PowerSaveBlocker::kReasonOther,
ATOM_PRODUCT_NAME);
device::PowerSaveBlocker::kReasonOther,
ATOM_PRODUCT_NAME,
BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE)));
power_save_blocker_.swap(new_blocker);
current_blocker_type_ = new_blocker_type;
}
}
int PowerSaveBlocker::Start(
content::PowerSaveBlocker::PowerSaveBlockerType type) {
device::PowerSaveBlocker::PowerSaveBlockerType type) {
static int count = 0;
power_save_blocker_types_[count] = type;
UpdatePowerSaveBlocker();
@@ -97,17 +103,19 @@ bool PowerSaveBlocker::IsStarted(int id) {
return power_save_blocker_types_.find(id) != power_save_blocker_types_.end();
}
mate::ObjectTemplateBuilder PowerSaveBlocker::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("start", &PowerSaveBlocker::Start)
.SetMethod("stop", &PowerSaveBlocker::Stop)
.SetMethod("isStarted", &PowerSaveBlocker::IsStarted);
// static
mate::Handle<PowerSaveBlocker> PowerSaveBlocker::Create(v8::Isolate* isolate) {
return mate::CreateHandle(isolate, new PowerSaveBlocker(isolate));
}
// static
mate::Handle<PowerSaveBlocker> PowerSaveBlocker::Create(v8::Isolate* isolate) {
return CreateHandle(isolate, new PowerSaveBlocker);
void PowerSaveBlocker::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "PowerSaveBlocker"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("start", &PowerSaveBlocker::Start)
.SetMethod("stop", &PowerSaveBlocker::Stop)
.SetMethod("isStarted", &PowerSaveBlocker::IsStarted);
}
} // namespace api

View File

@@ -6,11 +6,11 @@
#define ATOM_BROWSER_API_ATOM_API_POWER_SAVE_BLOCKER_H_
#include <map>
#include <memory>
#include "base/memory/scoped_ptr.h"
#include "content/public/browser/power_save_blocker.h"
#include "atom/browser/api/trackable_object.h"
#include "device/power_save_blocker/power_save_blocker.h"
#include "native_mate/handle.h"
#include "native_mate/wrappable.h"
namespace mate {
class Dictionary;
@@ -20,35 +20,33 @@ namespace atom {
namespace api {
class PowerSaveBlocker : public mate::Wrappable {
class PowerSaveBlocker : public mate::TrackableObject<PowerSaveBlocker> {
public:
static mate::Handle<PowerSaveBlocker> Create(v8::Isolate* isolate);
protected:
PowerSaveBlocker();
virtual ~PowerSaveBlocker();
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// mate::Wrappable implementations:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
protected:
explicit PowerSaveBlocker(v8::Isolate* isolate);
~PowerSaveBlocker() override;
private:
void UpdatePowerSaveBlocker();
int Start(content::PowerSaveBlocker::PowerSaveBlockerType type);
int Start(device::PowerSaveBlocker::PowerSaveBlockerType type);
bool Stop(int id);
bool IsStarted(int id);
scoped_ptr<content::PowerSaveBlocker> power_save_blocker_;
std::unique_ptr<device::PowerSaveBlocker> power_save_blocker_;
// Currnet blocker type used by |power_save_blocker_|
content::PowerSaveBlocker::PowerSaveBlockerType current_blocker_type_;
device::PowerSaveBlocker::PowerSaveBlockerType current_blocker_type_;
// Map from id to the corresponding blocker type for each request.
using PowerSaveBlockerTypeMap =
std::map<int, content::PowerSaveBlocker::PowerSaveBlockerType>;
std::map<int, device::PowerSaveBlocker::PowerSaveBlockerType>;
PowerSaveBlockerTypeMap power_save_blocker_types_;
DISALLOW_COPY_AND_ASSIGN(PowerSaveBlocker);
};

View File

@@ -5,72 +5,85 @@
#include "atom/browser/api/atom_api_protocol.h"
#include "atom/browser/atom_browser_client.h"
#include "atom/browser/atom_browser_context.h"
#include "atom/browser/atom_browser_main_parts.h"
#include "atom/browser/browser.h"
#include "atom/browser/net/url_request_async_asar_job.h"
#include "atom/browser/net/url_request_buffer_job.h"
#include "atom/browser/net/url_request_fetch_job.h"
#include "atom/browser/net/url_request_string_job.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/node_includes.h"
#include "atom/common/options_switches.h"
#include "base/command_line.h"
#include "base/strings/string_util.h"
#include "content/public/browser/child_process_security_policy.h"
#include "native_mate/dictionary.h"
#include "url/url_util.h"
using content::BrowserThread;
namespace mate {
template<>
struct Converter<const net::URLRequest*> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const net::URLRequest* val) {
return mate::ObjectTemplateBuilder(isolate)
.SetValue("method", val->method())
.SetValue("url", val->url().spec())
.SetValue("referrer", val->referrer())
.Build()->NewInstance();
}
};
} // namespace mate
namespace atom {
namespace api {
Protocol::Protocol(AtomBrowserContext* browser_context)
namespace {
// List of registered custom standard schemes.
std::vector<std::string> g_standard_schemes;
// Clear protocol handlers in IO thread.
void ClearJobFactoryInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter) {
auto job_factory = static_cast<AtomURLRequestJobFactory*>(
request_context_getter->job_factory());
job_factory->Clear();
}
} // namespace
std::vector<std::string> GetStandardSchemes() {
return g_standard_schemes;
}
void RegisterStandardSchemes(const std::vector<std::string>& schemes,
mate::Arguments* args) {
g_standard_schemes = schemes;
auto* policy = content::ChildProcessSecurityPolicy::GetInstance();
for (const std::string& scheme : schemes) {
url::AddStandardScheme(scheme.c_str(), url::SCHEME_WITHOUT_PORT);
policy->RegisterWebSafeScheme(scheme);
}
// add switches to register as standard
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
atom::switches::kStandardSchemes, base::JoinString(schemes, ","));
mate::Dictionary opts;
bool secure = false;
if (args->GetNext(&opts) && opts.Get("secure", &secure) && secure) {
// add switches to register as secure
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
atom::switches::kSecureSchemes, base::JoinString(schemes, ","));
}
}
Protocol::Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context)
: request_context_getter_(browser_context->GetRequestContext()),
job_factory_(browser_context->job_factory()) {
CHECK(job_factory_);
weak_factory_(this) {
Init(isolate);
}
mate::ObjectTemplateBuilder Protocol::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("registerStandardSchemes", &Protocol::RegisterStandardSchemes)
.SetMethod("registerStringProtocol",
&Protocol::RegisterProtocol<URLRequestStringJob>)
.SetMethod("registerBufferProtocol",
&Protocol::RegisterProtocol<URLRequestBufferJob>)
.SetMethod("registerFileProtocol",
&Protocol::RegisterProtocol<UrlRequestAsyncAsarJob>)
.SetMethod("registerHttpProtocol",
&Protocol::RegisterProtocol<URLRequestFetchJob>)
.SetMethod("unregisterProtocol", &Protocol::UnregisterProtocol)
.SetMethod("isProtocolHandled", &Protocol::IsProtocolHandled)
.SetMethod("interceptStringProtocol",
&Protocol::InterceptProtocol<URLRequestStringJob>)
.SetMethod("interceptBufferProtocol",
&Protocol::InterceptProtocol<URLRequestBufferJob>)
.SetMethod("interceptFileProtocol",
&Protocol::InterceptProtocol<UrlRequestAsyncAsarJob>)
.SetMethod("interceptHttpProtocol",
&Protocol::InterceptProtocol<URLRequestFetchJob>)
.SetMethod("uninterceptProtocol", &Protocol::UninterceptProtocol);
Protocol::~Protocol() {
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
base::Bind(ClearJobFactoryInIO, request_context_getter_));
}
void Protocol::RegisterStandardSchemes(
void Protocol::RegisterServiceWorkerSchemes(
const std::vector<std::string>& schemes) {
atom::AtomBrowserClient::SetCustomSchemes(schemes);
atom::AtomBrowserClient::SetCustomServiceWorkerSchemes(schemes);
}
void Protocol::UnregisterProtocol(
@@ -80,30 +93,37 @@ void Protocol::UnregisterProtocol(
content::BrowserThread::PostTaskAndReplyWithResult(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&Protocol::UnregisterProtocolInIO,
base::Unretained(this), scheme),
request_context_getter_, scheme),
base::Bind(&Protocol::OnIOCompleted,
base::Unretained(this), callback));
GetWeakPtr(), callback));
}
// static
Protocol::ProtocolError Protocol::UnregisterProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme) {
if (!job_factory_->HasProtocolHandler(scheme))
auto job_factory = static_cast<AtomURLRequestJobFactory*>(
request_context_getter->job_factory());
if (!job_factory->HasProtocolHandler(scheme))
return PROTOCOL_NOT_REGISTERED;
job_factory_->SetProtocolHandler(scheme, nullptr);
job_factory->SetProtocolHandler(scheme, nullptr);
return PROTOCOL_OK;
}
void Protocol::IsProtocolHandled(const std::string& scheme,
const BooleanCallback& callback) {
const BooleanCallback& callback) {
content::BrowserThread::PostTaskAndReplyWithResult(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&Protocol::IsProtocolHandledInIO,
base::Unretained(this), scheme),
request_context_getter_, scheme),
callback);
}
bool Protocol::IsProtocolHandledInIO(const std::string& scheme) {
return job_factory_->IsHandledProtocol(scheme);
// static
bool Protocol::IsProtocolHandledInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme) {
return request_context_getter->job_factory()->IsHandledProtocol(scheme);
}
void Protocol::UninterceptProtocol(
@@ -113,18 +133,18 @@ void Protocol::UninterceptProtocol(
content::BrowserThread::PostTaskAndReplyWithResult(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&Protocol::UninterceptProtocolInIO,
base::Unretained(this), scheme),
request_context_getter_, scheme),
base::Bind(&Protocol::OnIOCompleted,
base::Unretained(this), callback));
GetWeakPtr(), callback));
}
// static
Protocol::ProtocolError Protocol::UninterceptProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme) {
if (!original_protocols_.contains(scheme))
return PROTOCOL_NOT_INTERCEPTED;
job_factory_->ReplaceProtocol(scheme,
original_protocols_.take_and_erase(scheme));
return PROTOCOL_OK;
return static_cast<AtomURLRequestJobFactory*>(
request_context_getter->job_factory())->UninterceptProtocol(scheme) ?
PROTOCOL_OK : PROTOCOL_NOT_INTERCEPTED;
}
void Protocol::OnIOCompleted(
@@ -147,18 +167,53 @@ void Protocol::OnIOCompleted(
std::string Protocol::ErrorCodeToString(ProtocolError error) {
switch (error) {
case PROTOCOL_FAIL: return "Failed to manipulate protocol factory";
case PROTOCOL_REGISTERED: return "The scheme has been registred";
case PROTOCOL_NOT_REGISTERED: return "The scheme has not been registred";
case PROTOCOL_REGISTERED: return "The scheme has been registered";
case PROTOCOL_NOT_REGISTERED: return "The scheme has not been registered";
case PROTOCOL_INTERCEPTED: return "The scheme has been intercepted";
case PROTOCOL_NOT_INTERCEPTED: return "The scheme has not been intercepted";
default: return "Unexpected error";
}
}
AtomURLRequestJobFactory* Protocol::GetJobFactoryInIO() const {
request_context_getter_->GetURLRequestContext(); // Force init.
return static_cast<AtomURLRequestJobFactory*>(
static_cast<brightray::URLRequestContextGetter*>(
request_context_getter_.get())->job_factory());
}
// static
mate::Handle<Protocol> Protocol::Create(
v8::Isolate* isolate, AtomBrowserContext* browser_context) {
return mate::CreateHandle(isolate, new Protocol(browser_context));
return mate::CreateHandle(isolate, new Protocol(isolate, browser_context));
}
// static
void Protocol::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Protocol"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("registerServiceWorkerSchemes",
&Protocol::RegisterServiceWorkerSchemes)
.SetMethod("registerStringProtocol",
&Protocol::RegisterProtocol<URLRequestStringJob>)
.SetMethod("registerBufferProtocol",
&Protocol::RegisterProtocol<URLRequestBufferJob>)
.SetMethod("registerFileProtocol",
&Protocol::RegisterProtocol<URLRequestAsyncAsarJob>)
.SetMethod("registerHttpProtocol",
&Protocol::RegisterProtocol<URLRequestFetchJob>)
.SetMethod("unregisterProtocol", &Protocol::UnregisterProtocol)
.SetMethod("isProtocolHandled", &Protocol::IsProtocolHandled)
.SetMethod("interceptStringProtocol",
&Protocol::InterceptProtocol<URLRequestStringJob>)
.SetMethod("interceptBufferProtocol",
&Protocol::InterceptProtocol<URLRequestBufferJob>)
.SetMethod("interceptFileProtocol",
&Protocol::InterceptProtocol<URLRequestAsyncAsarJob>)
.SetMethod("interceptHttpProtocol",
&Protocol::InterceptProtocol<URLRequestFetchJob>)
.SetMethod("uninterceptProtocol", &Protocol::UninterceptProtocol);
}
} // namespace api
@@ -167,13 +222,23 @@ mate::Handle<Protocol> Protocol::Create(
namespace {
void RegisterStandardSchemes(
const std::vector<std::string>& schemes, mate::Arguments* args) {
if (atom::Browser::Get()->is_ready()) {
args->ThrowError("protocol.registerStandardSchemes should be called before "
"app is ready");
return;
}
atom::api::RegisterStandardSchemes(schemes, args);
}
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
auto browser_context = static_cast<atom::AtomBrowserContext*>(
atom::AtomBrowserMainParts::Get()->browser_context());
dict.Set("protocol", atom::api::Protocol::Create(isolate, browser_context));
dict.SetMethod("registerStandardSchemes", &RegisterStandardSchemes);
dict.SetMethod("getStandardSchemes", &atom::api::GetStandardSchemes);
}
} // namespace

View File

@@ -5,47 +5,49 @@
#ifndef ATOM_BROWSER_API_ATOM_API_PROTOCOL_H_
#define ATOM_BROWSER_API_ATOM_API_PROTOCOL_H_
#include <string>
#include <map>
#include <string>
#include <vector>
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/atom_browser_context.h"
#include "atom/browser/net/atom_url_request_job_factory.h"
#include "base/callback.h"
#include "base/containers/scoped_ptr_hash_map.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/arguments.h"
#include "native_mate/dictionary.h"
#include "native_mate/handle.h"
#include "native_mate/wrappable.h"
#include "net/url_request/url_request_context.h"
namespace net {
class URLRequest;
class URLRequestContextGetter;
namespace base {
class DictionaryValue;
}
namespace atom {
class AtomBrowserContext;
class AtomURLRequestJobFactory;
namespace api {
class Protocol : public mate::Wrappable {
std::vector<std::string> GetStandardSchemes();
void RegisterStandardSchemes(const std::vector<std::string>& schemes,
mate::Arguments* args);
class Protocol : public mate::TrackableObject<Protocol> {
public:
using Handler =
base::Callback<void(const net::URLRequest*, v8::Local<v8::Value>)>;
base::Callback<void(const base::DictionaryValue&, v8::Local<v8::Value>)>;
using CompletionCallback = base::Callback<void(v8::Local<v8::Value>)>;
using BooleanCallback = base::Callback<void(bool)>;
static mate::Handle<Protocol> Create(
v8::Isolate* isolate, AtomBrowserContext* browser_context);
protected:
explicit Protocol(AtomBrowserContext* browser_context);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// mate::Wrappable implementations:
virtual mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate);
protected:
Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Protocol();
private:
// Possible errors.
@@ -77,20 +79,20 @@ class Protocol : public mate::Wrappable {
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const override {
RequestJob* request_job = new RequestJob(request, network_delegate);
request_job->SetHandlerInfo(isolate_, request_context_, handler_);
request_job->SetHandlerInfo(isolate_, request_context_.get(), handler_);
return request_job;
}
private:
v8::Isolate* isolate_;
net::URLRequestContextGetter* request_context_;
scoped_refptr<net::URLRequestContextGetter> request_context_;
Protocol::Handler handler_;
DISALLOW_COPY_AND_ASSIGN(CustomProtocolHandler);
};
// Register schemes to standard scheme list.
void RegisterStandardSchemes(const std::vector<std::string>& schemes);
// Register schemes that can handle service worker.
void RegisterServiceWorkerSchemes(const std::vector<std::string>& schemes);
// Register the protocol with certain request job.
template<typename RequestJob>
@@ -102,19 +104,24 @@ class Protocol : public mate::Wrappable {
content::BrowserThread::PostTaskAndReplyWithResult(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&Protocol::RegisterProtocolInIO<RequestJob>,
base::Unretained(this), scheme, handler),
request_context_getter_, isolate(), scheme, handler),
base::Bind(&Protocol::OnIOCompleted,
base::Unretained(this), callback));
GetWeakPtr(), callback));
}
template<typename RequestJob>
ProtocolError RegisterProtocolInIO(const std::string& scheme,
const Handler& handler) {
if (job_factory_->IsHandledProtocol(scheme))
static ProtocolError RegisterProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
v8::Isolate* isolate,
const std::string& scheme,
const Handler& handler) {
auto job_factory = static_cast<AtomURLRequestJobFactory*>(
request_context_getter->job_factory());
if (job_factory->IsHandledProtocol(scheme))
return PROTOCOL_REGISTERED;
scoped_ptr<CustomProtocolHandler<RequestJob>> protocol_handler(
std::unique_ptr<CustomProtocolHandler<RequestJob>> protocol_handler(
new CustomProtocolHandler<RequestJob>(
isolate(), request_context_getter_, handler));
if (job_factory_->SetProtocolHandler(scheme, protocol_handler.Pass()))
isolate, request_context_getter.get(), handler));
if (job_factory->SetProtocolHandler(scheme, std::move(protocol_handler)))
return PROTOCOL_OK;
else
return PROTOCOL_FAIL;
@@ -122,12 +129,16 @@ class Protocol : public mate::Wrappable {
// Unregister the protocol handler that handles |scheme|.
void UnregisterProtocol(const std::string& scheme, mate::Arguments* args);
ProtocolError UnregisterProtocolInIO(const std::string& scheme);
static ProtocolError UnregisterProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme);
// Whether the protocol has handler registered.
void IsProtocolHandled(const std::string& scheme,
const BooleanCallback& callback);
bool IsProtocolHandledInIO(const std::string& scheme);
static bool IsProtocolHandledInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme);
// Replace the protocol handler with a new one.
template<typename RequestJob>
@@ -139,32 +150,36 @@ class Protocol : public mate::Wrappable {
content::BrowserThread::PostTaskAndReplyWithResult(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&Protocol::InterceptProtocolInIO<RequestJob>,
base::Unretained(this), scheme, handler),
request_context_getter_, isolate(), scheme, handler),
base::Bind(&Protocol::OnIOCompleted,
base::Unretained(this), callback));
GetWeakPtr(), callback));
}
template<typename RequestJob>
ProtocolError InterceptProtocolInIO(const std::string& scheme,
const Handler& handler) {
if (!job_factory_->IsHandledProtocol(scheme))
static ProtocolError InterceptProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
v8::Isolate* isolate,
const std::string& scheme,
const Handler& handler) {
auto job_factory = static_cast<AtomURLRequestJobFactory*>(
request_context_getter->job_factory());
if (!job_factory->IsHandledProtocol(scheme))
return PROTOCOL_NOT_REGISTERED;
// It is possible a protocol is handled but can not be intercepted.
if (!job_factory_->HasProtocolHandler(scheme))
if (!job_factory->HasProtocolHandler(scheme))
return PROTOCOL_FAIL;
if (ContainsKey(original_protocols_, scheme))
return PROTOCOL_INTERCEPTED;
scoped_ptr<CustomProtocolHandler<RequestJob>> protocol_handler(
std::unique_ptr<CustomProtocolHandler<RequestJob>> protocol_handler(
new CustomProtocolHandler<RequestJob>(
isolate(), request_context_getter_, handler));
original_protocols_.set(
scheme,
job_factory_->ReplaceProtocol(scheme, protocol_handler.Pass()));
isolate, request_context_getter.get(), handler));
if (!job_factory->InterceptProtocol(scheme, std::move(protocol_handler)))
return PROTOCOL_INTERCEPTED;
return PROTOCOL_OK;
}
// Restore the |scheme| to its original protocol handler.
void UninterceptProtocol(const std::string& scheme, mate::Arguments* args);
ProtocolError UninterceptProtocolInIO(const std::string& scheme);
static ProtocolError UninterceptProtocolInIO(
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter,
const std::string& scheme);
// Convert error code to JS exception and call the callback.
void OnIOCompleted(const CompletionCallback& callback, ProtocolError error);
@@ -172,15 +187,14 @@ class Protocol : public mate::Wrappable {
// Convert error code to string.
std::string ErrorCodeToString(ProtocolError error);
net::URLRequestContextGetter* request_context_getter_;
AtomURLRequestJobFactory* GetJobFactoryInIO() const;
// Map that stores the original protocols of schemes.
using OriginalProtocolsMap = base::ScopedPtrHashMap<
std::string,
scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>>;
OriginalProtocolsMap original_protocols_;
base::WeakPtr<Protocol> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
AtomURLRequestJobFactory* job_factory_; // weak ref
scoped_refptr<brightray::URLRequestContextGetter> request_context_getter_;
base::WeakPtrFactory<Protocol> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(Protocol);
};

View File

@@ -0,0 +1,90 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_render_process_preferences.h"
#include "atom/browser/api/atom_api_web_contents.h"
#include "atom/browser/atom_browser_client.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "content/public/browser/render_process_host.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
#include "atom/common/node_includes.h"
namespace atom {
namespace api {
namespace {
bool IsWebContents(v8::Isolate* isolate, content::RenderProcessHost* process) {
content::WebContents* web_contents =
static_cast<AtomBrowserClient*>(AtomBrowserClient::Get())->
GetWebContentsFromProcessID(process->GetID());
if (!web_contents)
return false;
auto api_web_contents = WebContents::CreateFrom(isolate, web_contents);
auto type = api_web_contents->GetType();
return type == WebContents::Type::BROWSER_WINDOW ||
type == WebContents::Type::WEB_VIEW;
}
} // namespace
RenderProcessPreferences::RenderProcessPreferences(
v8::Isolate* isolate,
const atom::RenderProcessPreferences::Predicate& predicate)
: preferences_(predicate) {
Init(isolate);
}
RenderProcessPreferences::~RenderProcessPreferences() {
}
int RenderProcessPreferences::AddEntry(const base::DictionaryValue& entry) {
return preferences_.AddEntry(entry);
}
void RenderProcessPreferences::RemoveEntry(int id) {
preferences_.RemoveEntry(id);
}
// static
void RenderProcessPreferences::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(
mate::StringToV8(isolate, "RenderProcessPreferences"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("addEntry", &RenderProcessPreferences::AddEntry)
.SetMethod("removeEntry", &RenderProcessPreferences::RemoveEntry);
}
// static
mate::Handle<RenderProcessPreferences>
RenderProcessPreferences::ForAllWebContents(v8::Isolate* isolate) {
return mate::CreateHandle(
isolate,
new RenderProcessPreferences(isolate,
base::Bind(&IsWebContents, isolate)));
}
} // namespace api
} // namespace atom
namespace {
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
mate::Dictionary dict(context->GetIsolate(), exports);
dict.SetMethod("forAllWebContents",
&atom::api::RenderProcessPreferences::ForAllWebContents);
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_render_process_preferences,
Initialize)

View File

@@ -0,0 +1,44 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_RENDER_PROCESS_PREFERENCES_H_
#define ATOM_BROWSER_API_ATOM_API_RENDER_PROCESS_PREFERENCES_H_
#include "atom/browser/render_process_preferences.h"
#include "native_mate/handle.h"
#include "native_mate/wrappable.h"
namespace atom {
namespace api {
class RenderProcessPreferences
: public mate::Wrappable<RenderProcessPreferences> {
public:
static mate::Handle<RenderProcessPreferences>
ForAllWebContents(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
int AddEntry(const base::DictionaryValue& entry);
void RemoveEntry(int id);
protected:
RenderProcessPreferences(
v8::Isolate* isolate,
const atom::RenderProcessPreferences::Predicate& predicate);
~RenderProcessPreferences() override;
private:
atom::RenderProcessPreferences preferences_;
DISALLOW_COPY_AND_ASSIGN(RenderProcessPreferences);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_RENDER_PROCESS_PREFERENCES_H_

View File

@@ -12,7 +12,9 @@
#include "base/bind.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
#include "ui/gfx/screen.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
#include "ui/gfx/geometry/point.h"
#include "atom/common/node_includes.h"
@@ -34,22 +36,23 @@ typename T::iterator FindById(T* container, int id) {
// Convert the changed_metrics bitmask to string array.
std::vector<std::string> MetricsToArray(uint32_t metrics) {
std::vector<std::string> array;
if (metrics & gfx::DisplayObserver::DISPLAY_METRIC_BOUNDS)
if (metrics & display::DisplayObserver::DISPLAY_METRIC_BOUNDS)
array.push_back("bounds");
if (metrics & gfx::DisplayObserver::DISPLAY_METRIC_WORK_AREA)
if (metrics & display::DisplayObserver::DISPLAY_METRIC_WORK_AREA)
array.push_back("workArea");
if (metrics & gfx::DisplayObserver::DISPLAY_METRIC_DEVICE_SCALE_FACTOR)
if (metrics & display::DisplayObserver::DISPLAY_METRIC_DEVICE_SCALE_FACTOR)
array.push_back("scaleFactor");
if (metrics & gfx::DisplayObserver::DISPLAY_METRIC_ROTATION)
array.push_back("rotaion");
if (metrics & display::DisplayObserver::DISPLAY_METRIC_ROTATION)
array.push_back("rotation");
return array;
}
} // namespace
Screen::Screen(gfx::Screen* screen) : screen_(screen) {
displays_ = screen_->GetAllDisplays();
Screen::Screen(v8::Isolate* isolate, display::Screen* screen)
: screen_(screen) {
screen_->AddObserver(this);
Init(isolate);
}
Screen::~Screen() {
@@ -60,73 +63,64 @@ gfx::Point Screen::GetCursorScreenPoint() {
return screen_->GetCursorScreenPoint();
}
gfx::Display Screen::GetPrimaryDisplay() {
display::Display Screen::GetPrimaryDisplay() {
return screen_->GetPrimaryDisplay();
}
std::vector<gfx::Display> Screen::GetAllDisplays() {
return displays_;
std::vector<display::Display> Screen::GetAllDisplays() {
return screen_->GetAllDisplays();
}
gfx::Display Screen::GetDisplayNearestPoint(const gfx::Point& point) {
display::Display Screen::GetDisplayNearestPoint(const gfx::Point& point) {
return screen_->GetDisplayNearestPoint(point);
}
gfx::Display Screen::GetDisplayMatching(const gfx::Rect& match_rect) {
display::Display Screen::GetDisplayMatching(const gfx::Rect& match_rect) {
return screen_->GetDisplayMatching(match_rect);
}
void Screen::OnDisplayAdded(const gfx::Display& new_display) {
displays_.push_back(new_display);
void Screen::OnDisplayAdded(const display::Display& new_display) {
Emit("display-added", new_display);
}
void Screen::OnDisplayRemoved(const gfx::Display& old_display) {
auto iter = FindById(&displays_, old_display.id());
if (iter == displays_.end())
return;
displays_.erase(iter);
void Screen::OnDisplayRemoved(const display::Display& old_display) {
Emit("display-removed", old_display);
}
void Screen::OnDisplayMetricsChanged(const gfx::Display& display,
void Screen::OnDisplayMetricsChanged(const display::Display& display,
uint32_t changed_metrics) {
auto iter = FindById(&displays_, display.id());
if (iter == displays_.end())
return;
*iter = display;
Emit("display-metrics-changed", display, MetricsToArray(changed_metrics));
}
mate::ObjectTemplateBuilder Screen::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("getCursorScreenPoint", &Screen::GetCursorScreenPoint)
.SetMethod("getPrimaryDisplay", &Screen::GetPrimaryDisplay)
.SetMethod("getAllDisplays", &Screen::GetAllDisplays)
.SetMethod("getDisplayNearestPoint", &Screen::GetDisplayNearestPoint)
.SetMethod("getDisplayMatching", &Screen::GetDisplayMatching);
}
// static
v8::Local<v8::Value> Screen::Create(v8::Isolate* isolate) {
if (!Browser::Get()->is_ready()) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate,
"Cannot initialize \"screen\" module before app is ready")));
"Cannot require \"screen\" module before app is ready")));
return v8::Null(isolate);
}
gfx::Screen* screen = gfx::Screen::GetNativeScreen();
display::Screen* screen = display::Screen::GetScreen();
if (!screen) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate, "Failed to get screen information")));
return v8::Null(isolate);
}
return mate::CreateHandle(isolate, new Screen(screen)).ToV8();
return mate::CreateHandle(isolate, new Screen(isolate, screen)).ToV8();
}
// static
void Screen::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Screen"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("getCursorScreenPoint", &Screen::GetCursorScreenPoint)
.SetMethod("getPrimaryDisplay", &Screen::GetPrimaryDisplay)
.SetMethod("getAllDisplays", &Screen::GetAllDisplays)
.SetMethod("getDisplayNearestPoint", &Screen::GetDisplayNearestPoint)
.SetMethod("getDisplayMatching", &Screen::GetDisplayMatching);
}
} // namespace api
@@ -135,10 +129,14 @@ v8::Local<v8::Value> Screen::Create(v8::Isolate* isolate) {
namespace {
using atom::api::Screen;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
mate::Dictionary dict(context->GetIsolate(), exports);
dict.Set("screen", atom::api::Screen::Create(context->GetIsolate()));
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.Set("screen", Screen::Create(isolate));
dict.Set("Screen", Screen::GetConstructor(isolate)->GetFunction());
}
} // namespace

View File

@@ -9,7 +9,8 @@
#include "atom/browser/api/event_emitter.h"
#include "native_mate/handle.h"
#include "ui/gfx/display_observer.h"
#include "ui/display/display_observer.h"
#include "ui/display/screen.h"
namespace gfx {
class Point;
@@ -21,34 +22,32 @@ namespace atom {
namespace api {
class Screen : public mate::EventEmitter,
public gfx::DisplayObserver {
class Screen : public mate::EventEmitter<Screen>,
public display::DisplayObserver {
public:
static v8::Local<v8::Value> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
protected:
explicit Screen(gfx::Screen* screen);
virtual ~Screen();
Screen(v8::Isolate* isolate, display::Screen* screen);
~Screen() override;
gfx::Point GetCursorScreenPoint();
gfx::Display GetPrimaryDisplay();
std::vector<gfx::Display> GetAllDisplays();
gfx::Display GetDisplayNearestPoint(const gfx::Point& point);
gfx::Display GetDisplayMatching(const gfx::Rect& match_rect);
display::Display GetPrimaryDisplay();
std::vector<display::Display> GetAllDisplays();
display::Display GetDisplayNearestPoint(const gfx::Point& point);
display::Display GetDisplayMatching(const gfx::Rect& match_rect);
// gfx::DisplayObserver:
void OnDisplayAdded(const gfx::Display& new_display) override;
void OnDisplayRemoved(const gfx::Display& old_display) override;
void OnDisplayMetricsChanged(const gfx::Display& display,
// display::DisplayObserver:
void OnDisplayAdded(const display::Display& new_display) override;
void OnDisplayRemoved(const display::Display& old_display) override;
void OnDisplayMetricsChanged(const display::Display& display,
uint32_t changed_metrics) override;
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
private:
gfx::Screen* screen_;
std::vector<gfx::Display> displays_;
display::Screen* screen_;
DISALLOW_COPY_AND_ASSIGN(Screen);
};

View File

@@ -4,35 +4,54 @@
#include "atom/browser/api/atom_api_session.h"
#include <map>
#include <string>
#include <vector>
#include "atom/browser/api/atom_api_cookies.h"
#include "atom/browser/api/atom_api_download_item.h"
#include "atom/browser/api/atom_api_protocol.h"
#include "atom/browser/api/atom_api_web_request.h"
#include "atom/browser/atom_browser_context.h"
#include "atom/browser/api/atom_api_web_contents.h"
#include "atom/browser/atom_browser_main_parts.h"
#include "atom/browser/atom_permission_manager.h"
#include "atom/browser/browser.h"
#include "atom/browser/net/atom_cert_verifier.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/native_mate_converters/content_converter.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/native_mate_converters/net_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/node_includes.h"
#include "base/files/file_path.h"
#include "base/prefs/pref_service.h"
#include "base/guid.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/thread_task_runner_handle.h"
#include "base/threading/thread_task_runner_handle.h"
#include "brightray/browser/media/media_device_id_salt.h"
#include "brightray/browser/net/devtools_network_conditions.h"
#include "brightray/browser/net/devtools_network_controller.h"
#include "brightray/browser/net/devtools_network_controller_handle.h"
#include "chrome/common/pref_names.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/download_manager_delegate.h"
#include "content/public/browser/storage_partition.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
#include "net/base/load_flags.h"
#include "net/disk_cache/disk_cache.h"
#include "net/proxy/proxy_service.h"
#include "net/dns/host_cache.h"
#include "net/http/http_auth_handler_factory.h"
#include "net/http/http_auth_preferences.h"
#include "net/proxy/proxy_config_service_fixed.h"
#include "net/proxy/proxy_service.h"
#include "net/url_request/static_http_user_agent_settings.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
#include "ui/base/l10n/l10n_util.h"
using atom::api::Cookies;
using content::BrowserThread;
using content::StoragePartition;
@@ -40,14 +59,23 @@ namespace {
struct ClearStorageDataOptions {
GURL origin;
uint32 storage_types = StoragePartition::REMOVE_DATA_MASK_ALL;
uint32 quota_types = StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL;
uint32_t storage_types = StoragePartition::REMOVE_DATA_MASK_ALL;
uint32_t quota_types = StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL;
};
uint32 GetStorageMask(const std::vector<std::string>& storage_types) {
uint32 storage_mask = 0;
struct ClearAuthCacheOptions {
std::string type;
GURL origin;
std::string realm;
base::string16 username;
base::string16 password;
net::HttpAuth::Scheme auth_scheme;
};
uint32_t GetStorageMask(const std::vector<std::string>& storage_types) {
uint32_t storage_mask = 0;
for (const auto& it : storage_types) {
auto type = base::StringToLowerASCII(it);
auto type = base::ToLowerASCII(it);
if (type == "appcache")
storage_mask |= StoragePartition::REMOVE_DATA_MASK_APPCACHE;
else if (type == "cookies")
@@ -68,10 +96,10 @@ uint32 GetStorageMask(const std::vector<std::string>& storage_types) {
return storage_mask;
}
uint32 GetQuotaMask(const std::vector<std::string>& quota_types) {
uint32 quota_mask = 0;
uint32_t GetQuotaMask(const std::vector<std::string>& quota_types) {
uint32_t quota_mask = 0;
for (const auto& it : quota_types) {
auto type = base::StringToLowerASCII(it);
auto type = base::ToLowerASCII(it);
if (type == "temporary")
quota_mask |= StoragePartition::QUOTA_MANAGED_STORAGE_MASK_TEMPORARY;
else if (type == "persistent")
@@ -82,6 +110,27 @@ uint32 GetQuotaMask(const std::vector<std::string>& quota_types) {
return quota_mask;
}
net::HttpAuth::Scheme GetAuthSchemeFromString(const std::string& scheme) {
if (scheme == "basic")
return net::HttpAuth::AUTH_SCHEME_BASIC;
if (scheme == "digest")
return net::HttpAuth::AUTH_SCHEME_DIGEST;
if (scheme == "ntlm")
return net::HttpAuth::AUTH_SCHEME_NTLM;
if (scheme == "negotiate")
return net::HttpAuth::AUTH_SCHEME_NEGOTIATE;
return net::HttpAuth::AUTH_SCHEME_MAX;
}
void SetUserAgentInIO(scoped_refptr<net::URLRequestContextGetter> getter,
const std::string& accept_lang,
const std::string& user_agent) {
getter->GetURLRequestContext()->set_http_user_agent_settings(
new net::StaticHttpUserAgentSettings(
net::HttpUtil::GenerateAcceptLanguageHeader(accept_lang),
user_agent));
}
} // namespace
namespace mate {
@@ -104,6 +153,69 @@ struct Converter<ClearStorageDataOptions> {
}
};
template <>
struct Converter<ClearAuthCacheOptions> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
ClearAuthCacheOptions* out) {
mate::Dictionary options;
if (!ConvertFromV8(isolate, val, &options))
return false;
options.Get("type", &out->type);
options.Get("origin", &out->origin);
options.Get("realm", &out->realm);
options.Get("username", &out->username);
options.Get("password", &out->password);
std::string scheme;
if (options.Get("scheme", &scheme))
out->auth_scheme = GetAuthSchemeFromString(scheme);
return true;
}
};
template <>
struct Converter<net::ProxyConfig> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
net::ProxyConfig* out) {
std::string proxy_rules, proxy_bypass_rules;
GURL pac_url;
mate::Dictionary options;
// Fallback to previous API when passed String.
// https://git.io/vuhjj
if (ConvertFromV8(isolate, val, &proxy_rules)) {
pac_url = GURL(proxy_rules); // Assume it is PAC script if it is URL.
} else if (ConvertFromV8(isolate, val, &options)) {
options.Get("pacScript", &pac_url);
options.Get("proxyRules", &proxy_rules);
options.Get("proxyBypassRules", &proxy_bypass_rules);
} else {
return false;
}
// pacScript takes precedence over proxyRules.
if (!pac_url.is_empty() && pac_url.is_valid()) {
out->set_pac_url(pac_url);
} else {
out->proxy_rules().ParseFromString(proxy_rules);
out->proxy_rules().bypass_rules.ParseFromString(proxy_bypass_rules);
}
return true;
}
};
template<>
struct Converter<atom::VerifyRequestParams> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
atom::VerifyRequestParams val) {
mate::Dictionary dict = mate::Dictionary::CreateEmpty(isolate);
dict.Set("hostname", val.hostname);
dict.Set("certificate", val.certificate);
dict.Set("verificationResult", val.default_result);
return dict.GetHandle();
}
};
} // namespace mate
namespace atom {
@@ -112,19 +224,20 @@ namespace api {
namespace {
// The wrapSession funtion which is implemented in JavaScript
using WrapSessionCallback = base::Callback<void(v8::Local<v8::Value>)>;
WrapSessionCallback g_wrap_session;
const char kPersistPrefix[] = "persist:";
// Referenced session objects.
std::map<uint32_t, v8::Global<v8::Object>> g_sessions;
class ResolveProxyHelper {
public:
ResolveProxyHelper(AtomBrowserContext* browser_context,
const GURL& url,
Session::ResolveProxyCallback callback)
const Session::ResolveProxyCallback& callback)
: callback_(callback),
original_thread_(base::ThreadTaskRunnerHandle::Get()) {
scoped_refptr<net::URLRequestContextGetter> context_getter =
browser_context->GetRequestContext();
browser_context->url_request_context_getter();
context_getter->GetNetworkTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&ResolveProxyHelper::ResolveProxy,
@@ -153,8 +266,8 @@ class ResolveProxyHelper {
// Start the request.
int result = proxy_service->ResolveProxy(
url, net::LOAD_NORMAL, &proxy_info_, completion_callback,
&pac_req_, nullptr, net::BoundNetLog());
url, "GET", &proxy_info_, completion_callback, &pac_req_, nullptr,
net::NetLogWithSource());
// Completed synchronously.
if (result != net::ERR_IO_PENDING)
@@ -170,7 +283,10 @@ class ResolveProxyHelper {
};
// Runs the callback in UI thread.
template <typename ...T>
void RunCallbackInUI(const base::Callback<void()>& callback) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, callback);
}
template<typename ...T>
void RunCallbackInUI(const base::Callback<void(T...)>& callback, T... result) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE, base::Bind(callback, result...));
@@ -178,19 +294,35 @@ void RunCallbackInUI(const base::Callback<void(T...)>& callback, T... result) {
// Callback of HttpCache::GetBackend.
void OnGetBackend(disk_cache::Backend** backend_ptr,
Session::CacheAction action,
const net::CompletionCallback& callback,
int result) {
if (result != net::OK) {
RunCallbackInUI(callback, result);
} else if (backend_ptr && *backend_ptr) {
(*backend_ptr)->DoomAllEntries(base::Bind(&RunCallbackInUI<int>, callback));
if (action == Session::CacheAction::CLEAR) {
(*backend_ptr)->DoomAllEntries(base::Bind(&RunCallbackInUI<int>,
callback));
} else if (action == Session::CacheAction::STATS) {
base::StringPairs stats;
(*backend_ptr)->GetStats(&stats);
for (const auto& stat : stats) {
if (stat.first == "Current size") {
int current_size;
base::StringToInt(stat.second, &current_size);
RunCallbackInUI(callback, current_size);
break;
}
}
}
} else {
RunCallbackInUI<int>(callback, net::ERR_FAILED);
}
}
void ClearHttpCacheInIO(
void DoCacheActionInIO(
const scoped_refptr<net::URLRequestContextGetter>& context_getter,
Session::CacheAction action,
const net::CompletionCallback& callback) {
auto request_context = context_getter->GetURLRequestContext();
auto http_cache = request_context->http_transaction_factory()->GetCache();
@@ -199,96 +331,191 @@ void ClearHttpCacheInIO(
// Call GetBackend and make the backend's ptr accessable in OnGetBackend.
using BackendPtr = disk_cache::Backend*;
BackendPtr* backend_ptr = new BackendPtr(nullptr);
auto* backend_ptr = new BackendPtr(nullptr);
net::CompletionCallback on_get_backend =
base::Bind(&OnGetBackend, base::Owned(backend_ptr), callback);
base::Bind(&OnGetBackend, base::Owned(backend_ptr), action, callback);
int rv = http_cache->GetBackend(backend_ptr, on_get_backend);
if (rv != net::ERR_IO_PENDING)
on_get_backend.Run(net::OK);
}
void SetProxyInIO(net::URLRequestContextGetter* getter,
const std::string& proxy,
const net::ProxyConfig& config,
const base::Closure& callback) {
net::ProxyConfig config;
config.proxy_rules().ParseFromString(proxy);
auto proxy_service = getter->GetURLRequestContext()->proxy_service();
proxy_service->ResetConfigService(new net::ProxyConfigServiceFixed(config));
proxy_service->ResetConfigService(base::WrapUnique(
new net::ProxyConfigServiceFixed(config)));
// Refetches and applies the new pac script if provided.
proxy_service->ForceReloadProxyConfig();
RunCallbackInUI(callback);
}
void SetCertVerifyProcInIO(
const scoped_refptr<net::URLRequestContextGetter>& context_getter,
const AtomCertVerifier::VerifyProc& proc) {
auto request_context = context_getter->GetURLRequestContext();
static_cast<AtomCertVerifier*>(request_context->cert_verifier())->
SetVerifyProc(proc);
}
void ClearHostResolverCacheInIO(
const scoped_refptr<net::URLRequestContextGetter>& context_getter,
const base::Closure& callback) {
auto request_context = context_getter->GetURLRequestContext();
auto cache = request_context->host_resolver()->GetHostCache();
if (cache) {
cache->clear();
DCHECK_EQ(0u, cache->size());
if (!callback.is_null())
RunCallbackInUI(callback);
}
}
void ClearAuthCacheInIO(
const scoped_refptr<net::URLRequestContextGetter>& context_getter,
const ClearAuthCacheOptions& options,
const base::Closure& callback) {
auto request_context = context_getter->GetURLRequestContext();
auto network_session =
request_context->http_transaction_factory()->GetSession();
if (network_session) {
if (options.type == "password") {
auto auth_cache = network_session->http_auth_cache();
if (!options.origin.is_empty()) {
auth_cache->Remove(
options.origin, options.realm, options.auth_scheme,
net::AuthCredentials(options.username, options.password));
} else {
auth_cache->ClearEntriesAddedWithin(base::TimeDelta::Max());
}
} else if (options.type == "clientCertificate") {
auto client_auth_cache = network_session->ssl_client_auth_cache();
client_auth_cache->Remove(net::HostPortPair::FromURL(options.origin));
}
network_session->CloseAllConnections();
}
if (!callback.is_null())
RunCallbackInUI(callback);
}
void AllowNTLMCredentialsForDomainsInIO(
const scoped_refptr<net::URLRequestContextGetter>& context_getter,
const std::string& domains) {
auto request_context = context_getter->GetURLRequestContext();
auto auth_handler = request_context->http_auth_handler_factory();
if (auth_handler) {
auto auth_preferences = const_cast<net::HttpAuthPreferences*>(
auth_handler->http_auth_preferences());
if (auth_preferences)
auth_preferences->set_server_whitelist(domains);
}
}
void OnClearStorageDataDone(const base::Closure& callback) {
if (!callback.is_null())
callback.Run();
}
void DownloadIdCallback(content::DownloadManager* download_manager,
const base::FilePath& path,
const std::vector<GURL>& url_chain,
const std::string& mime_type,
int64_t offset,
int64_t length,
const std::string& last_modified,
const std::string& etag,
const base::Time& start_time,
uint32_t id) {
download_manager->CreateDownloadItem(
base::GenerateGUID(), id, path, path, url_chain, GURL(), GURL(), GURL(),
GURL(), mime_type, mime_type, start_time, base::Time(), etag,
last_modified, offset, length, std::string(),
content::DownloadItem::INTERRUPTED,
content::DownloadDangerType::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
content::DOWNLOAD_INTERRUPT_REASON_NETWORK_TIMEOUT, false);
}
} // namespace
Session::Session(AtomBrowserContext* browser_context)
: browser_context_(browser_context) {
AttachAsUserData(browser_context);
// Observe DownloadManger to get download notifications.
Session::Session(v8::Isolate* isolate, AtomBrowserContext* browser_context)
: devtools_network_emulation_client_id_(base::GenerateGUID()),
browser_context_(browser_context) {
// Observe DownloadManager to get download notifications.
content::BrowserContext::GetDownloadManager(browser_context)->
AddObserver(this);
Init(isolate);
AttachAsUserData(browser_context);
}
Session::~Session() {
content::BrowserContext::GetDownloadManager(browser_context())->
RemoveObserver(this);
Destroy();
g_sessions.erase(weak_map_id());
}
void Session::OnDownloadCreated(content::DownloadManager* manager,
content::DownloadItem* item) {
auto web_contents = item->GetWebContents();
bool prevent_default = Emit(
"will-download",
DownloadItem::Create(isolate(), item),
api::WebContents::CreateFrom(isolate(), web_contents));
if (item->IsSavePackageDownload())
return;
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
auto handle = DownloadItem::Create(isolate(), item);
if (item->GetState() == content::DownloadItem::INTERRUPTED)
handle->SetSavePath(item->GetTargetFilePath());
bool prevent_default = Emit("will-download", handle, item->GetWebContents());
if (prevent_default) {
item->Cancel(true);
item->Remove();
}
}
bool Session::IsDestroyed() const {
return !browser_context_;
}
void Session::Destroy() {
browser_context_ = nullptr;
}
void Session::ResolveProxy(const GURL& url, ResolveProxyCallback callback) {
new ResolveProxyHelper(browser_context(), url, callback);
}
void Session::ClearCache(const net::CompletionCallback& callback) {
template<Session::CacheAction action>
void Session::DoCacheAction(const net::CompletionCallback& callback) {
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&ClearHttpCacheInIO,
base::Bind(&DoCacheActionInIO,
make_scoped_refptr(browser_context_->GetRequestContext()),
action,
callback));
}
void Session::ClearStorageData(mate::Arguments* args) {
// clearStorageData([options, ]callback)
// clearStorageData([options, callback])
ClearStorageDataOptions options;
args->GetNext(&options);
base::Closure callback;
if (!args->GetNext(&callback)) {
args->ThrowError();
return;
}
args->GetNext(&options);
args->GetNext(&callback);
auto storage_partition =
content::BrowserContext::GetStoragePartition(browser_context(), nullptr);
if (options.storage_types & StoragePartition::REMOVE_DATA_MASK_COOKIES) {
// Reset media device id salt when cookies are cleared.
// https://w3c.github.io/mediacapture-main/#dom-mediadeviceinfo-deviceid
brightray::MediaDeviceIDSalt::Reset(browser_context()->prefs());
}
storage_partition->ClearData(
options.storage_types, options.quota_types, options.origin,
content::StoragePartition::OriginMatcherFunction(),
base::Time(), base::Time::Max(), callback);
base::Time(), base::Time::Max(),
base::Bind(&OnClearStorageDataDone, callback));
}
void Session::SetProxy(const std::string& proxy,
void Session::FlushStorageData() {
auto storage_partition =
content::BrowserContext::GetStoragePartition(browser_context(), nullptr);
storage_partition->Flush();
}
void Session::SetProxy(const net::ProxyConfig& config,
const base::Closure& callback) {
auto getter = browser_context_->GetRequestContext();
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&SetProxyInIO, base::Unretained(getter), proxy, callback));
base::Bind(&SetProxyInIO, base::Unretained(getter), config, callback));
}
void Session::SetDownloadPath(const base::FilePath& path) {
@@ -297,9 +524,9 @@ void Session::SetDownloadPath(const base::FilePath& path) {
}
void Session::EnableNetworkEmulation(const mate::Dictionary& options) {
scoped_ptr<brightray::DevToolsNetworkConditions> conditions;
std::unique_ptr<brightray::DevToolsNetworkConditions> conditions;
bool offline = false;
double latency, download_throughput, upload_throughput;
double latency = 0.0, download_throughput = 0.0, upload_throughput = 0.0;
if (options.Get("offline", &offline) && offline) {
conditions.reset(new brightray::DevToolsNetworkConditions(offline));
} else {
@@ -312,46 +539,165 @@ void Session::EnableNetworkEmulation(const mate::Dictionary& options) {
download_throughput,
upload_throughput));
}
auto controller = browser_context_->GetDevToolsNetworkController();
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&brightray::DevToolsNetworkController::SetNetworkState,
base::Unretained(controller),
std::string(),
base::Passed(&conditions)));
browser_context_->network_controller_handle()->SetNetworkState(
devtools_network_emulation_client_id_, std::move(conditions));
browser_context_->network_delegate()->SetDevToolsNetworkEmulationClientId(
devtools_network_emulation_client_id_);
}
void Session::DisableNetworkEmulation() {
scoped_ptr<brightray::DevToolsNetworkConditions> conditions(
new brightray::DevToolsNetworkConditions(false));
auto controller = browser_context_->GetDevToolsNetworkController();
std::unique_ptr<brightray::DevToolsNetworkConditions> conditions;
browser_context_->network_controller_handle()->SetNetworkState(
devtools_network_emulation_client_id_, std::move(conditions));
browser_context_->network_delegate()->SetDevToolsNetworkEmulationClientId(
std::string());
}
void Session::SetCertVerifyProc(v8::Local<v8::Value> val,
mate::Arguments* args) {
AtomCertVerifier::VerifyProc proc;
if (!(val->IsNull() || mate::ConvertFromV8(args->isolate(), val, &proc))) {
args->ThrowError("Must pass null or function");
return;
}
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&brightray::DevToolsNetworkController::SetNetworkState,
base::Unretained(controller),
std::string(),
base::Passed(&conditions)));
base::Bind(&SetCertVerifyProcInIO,
make_scoped_refptr(browser_context_->GetRequestContext()),
proc));
}
void Session::SetPermissionRequestHandler(v8::Local<v8::Value> val,
mate::Arguments* args) {
AtomPermissionManager::RequestHandler handler;
if (!(val->IsNull() || mate::ConvertFromV8(args->isolate(), val, &handler))) {
args->ThrowError("Must pass null or function");
return;
}
auto permission_manager = static_cast<AtomPermissionManager*>(
browser_context()->GetPermissionManager());
permission_manager->SetPermissionRequestHandler(handler);
}
void Session::ClearHostResolverCache(mate::Arguments* args) {
base::Closure callback;
args->GetNext(&callback);
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&ClearHostResolverCacheInIO,
make_scoped_refptr(browser_context_->GetRequestContext()),
callback));
}
void Session::ClearAuthCache(mate::Arguments* args) {
ClearAuthCacheOptions options;
if (!args->GetNext(&options)) {
args->ThrowError("Must specify options object");
return;
}
base::Closure callback;
args->GetNext(&callback);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&ClearAuthCacheInIO,
make_scoped_refptr(browser_context_->GetRequestContext()),
options, callback));
}
void Session::AllowNTLMCredentialsForDomains(const std::string& domains) {
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&AllowNTLMCredentialsForDomainsInIO,
make_scoped_refptr(browser_context_->GetRequestContext()),
domains));
}
void Session::SetUserAgent(const std::string& user_agent,
mate::Arguments* args) {
browser_context_->SetUserAgent(user_agent);
std::string accept_lang = l10n_util::GetApplicationLocale("");
args->GetNext(&accept_lang);
auto getter = browser_context_->GetRequestContext();
getter->GetNetworkTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&SetUserAgentInIO, getter, accept_lang, user_agent));
}
std::string Session::GetUserAgent() {
return browser_context_->GetUserAgent();
}
void Session::GetBlobData(
const std::string& uuid,
const AtomBlobReader::CompletionCallback& callback) {
if (callback.is_null())
return;
AtomBlobReader* blob_reader =
browser_context()->GetBlobReader();
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(&AtomBlobReader::StartReading,
base::Unretained(blob_reader),
uuid,
callback));
}
void Session::CreateInterruptedDownload(const mate::Dictionary& options) {
int64_t offset = 0, length = 0;
double start_time = 0.0;
std::string mime_type, last_modified, etag;
base::FilePath path;
std::vector<GURL> url_chain;
options.Get("path", &path);
options.Get("urlChain", &url_chain);
options.Get("mimeType", &mime_type);
options.Get("offset", &offset);
options.Get("length", &length);
options.Get("lastModified", &last_modified);
options.Get("eTag", &etag);
options.Get("startTime", &start_time);
if (path.empty() || url_chain.empty() || length == 0) {
isolate()->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate(), "Must pass non-empty path, urlChain and length.")));
return;
}
if (offset >= length) {
isolate()->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate(), "Must pass an offset value less than length.")));
return;
}
auto download_manager =
content::BrowserContext::GetDownloadManager(browser_context());
download_manager->GetDelegate()->GetNextId(base::Bind(
&DownloadIdCallback, download_manager, path, url_chain, mime_type, offset,
length, last_modified, etag, base::Time::FromDoubleT(start_time)));
}
v8::Local<v8::Value> Session::Cookies(v8::Isolate* isolate) {
if (cookies_.IsEmpty()) {
auto handle = atom::api::Cookies::Create(isolate, browser_context());
auto handle = Cookies::Create(isolate, browser_context());
cookies_.Reset(isolate, handle.ToV8());
}
return v8::Local<v8::Value>::New(isolate, cookies_);
}
mate::ObjectTemplateBuilder Session::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return mate::ObjectTemplateBuilder(isolate)
.SetMethod("resolveProxy", &Session::ResolveProxy)
.SetMethod("clearCache", &Session::ClearCache)
.SetMethod("clearStorageData", &Session::ClearStorageData)
.SetMethod("setProxy", &Session::SetProxy)
.SetMethod("setDownloadPath", &Session::SetDownloadPath)
.SetMethod("enableNetworkEmulation", &Session::EnableNetworkEmulation)
.SetMethod("disableNetworkEmulation", &Session::DisableNetworkEmulation)
.SetProperty("cookies", &Session::Cookies);
v8::Local<v8::Value> Session::Protocol(v8::Isolate* isolate) {
if (protocol_.IsEmpty()) {
auto handle = atom::api::Protocol::Create(isolate, browser_context());
protocol_.Reset(isolate, handle.ToV8());
}
return v8::Local<v8::Value>::New(isolate, protocol_);
}
v8::Local<v8::Value> Session::WebRequest(v8::Isolate* isolate) {
if (web_request_.IsEmpty()) {
auto handle = atom::api::WebRequest::Create(isolate, browser_context());
web_request_.Reset(isolate, handle.ToV8());
}
return v8::Local<v8::Value>::New(isolate, web_request_);
}
// static
@@ -361,25 +707,64 @@ mate::Handle<Session> Session::CreateFrom(
if (existing)
return mate::CreateHandle(isolate, static_cast<Session*>(existing));
auto handle = mate::CreateHandle(isolate, new Session(browser_context));
g_wrap_session.Run(handle.ToV8());
auto handle = mate::CreateHandle(
isolate, new Session(isolate, browser_context));
// The Sessions should never be garbage collected, since the common pattern is
// to use partition strings, instead of using the Session object directly.
g_sessions[handle->weak_map_id()] =
v8::Global<v8::Object>(isolate, handle.ToV8());
return handle;
}
// static
mate::Handle<Session> Session::FromPartition(
v8::Isolate* isolate, const std::string& partition, bool in_memory) {
auto browser_context = brightray::BrowserContext::From(partition, in_memory);
return CreateFrom(isolate,
static_cast<AtomBrowserContext*>(browser_context.get()));
v8::Isolate* isolate, const std::string& partition,
const base::DictionaryValue& options) {
scoped_refptr<AtomBrowserContext> browser_context;
if (partition.empty()) {
browser_context = AtomBrowserContext::From("", false, options);
} else if (base::StartsWith(partition, kPersistPrefix,
base::CompareCase::SENSITIVE)) {
std::string name = partition.substr(8);
browser_context = AtomBrowserContext::From(name, false, options);
} else {
browser_context = AtomBrowserContext::From(partition, true, options);
}
return CreateFrom(isolate, browser_context.get());
}
void SetWrapSession(const WrapSessionCallback& callback) {
g_wrap_session = callback;
}
void ClearWrapSession() {
g_wrap_session.Reset();
// static
void Session::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Session"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("resolveProxy", &Session::ResolveProxy)
.SetMethod("getCacheSize", &Session::DoCacheAction<CacheAction::STATS>)
.SetMethod("clearCache", &Session::DoCacheAction<CacheAction::CLEAR>)
.SetMethod("clearStorageData", &Session::ClearStorageData)
.SetMethod("flushStorageData", &Session::FlushStorageData)
.SetMethod("setProxy", &Session::SetProxy)
.SetMethod("setDownloadPath", &Session::SetDownloadPath)
.SetMethod("enableNetworkEmulation", &Session::EnableNetworkEmulation)
.SetMethod("disableNetworkEmulation", &Session::DisableNetworkEmulation)
.SetMethod("_setCertificateVerifyProc", &Session::SetCertVerifyProc)
.SetMethod("setPermissionRequestHandler",
&Session::SetPermissionRequestHandler)
.SetMethod("clearHostResolverCache", &Session::ClearHostResolverCache)
.SetMethod("clearAuthCache", &Session::ClearAuthCache)
.SetMethod("allowNTLMCredentialsForDomains",
&Session::AllowNTLMCredentialsForDomains)
.SetMethod("setUserAgent", &Session::SetUserAgent)
.SetMethod("getUserAgent", &Session::GetUserAgent)
.SetMethod("getBlobData", &Session::GetBlobData)
.SetMethod("createInterruptedDownload",
&Session::CreateInterruptedDownload)
.SetProperty("cookies", &Session::Cookies)
.SetProperty("protocol", &Session::Protocol)
.SetProperty("webRequest", &Session::WebRequest);
}
} // namespace api
@@ -388,13 +773,26 @@ void ClearWrapSession() {
namespace {
using atom::api::Session;
v8::Local<v8::Value> FromPartition(
const std::string& partition, mate::Arguments* args) {
if (!atom::Browser::Get()->is_ready()) {
args->ThrowError("Session can only be received when app is ready");
return v8::Null(args->isolate());
}
base::DictionaryValue options;
args->GetNext(&options);
return Session::FromPartition(args->isolate(), partition, options).ToV8();
}
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.SetMethod("fromPartition", &atom::api::Session::FromPartition);
dict.SetMethod("_setWrapSession", &atom::api::SetWrapSession);
dict.SetMethod("_clearWrapSession", &atom::api::ClearWrapSession);
dict.Set("Session", Session::GetConstructor(isolate)->GetFunction());
dict.Set("Cookies", Cookies::GetConstructor(isolate)->GetFunction());
dict.SetMethod("fromPartition", &FromPartition);
}
} // namespace

View File

@@ -8,6 +8,8 @@
#include <string>
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/atom_blob_reader.h"
#include "base/values.h"
#include "content/public/browser/download_manager.h"
#include "native_mate/handle.h"
#include "net/base/completion_callback.h"
@@ -23,6 +25,10 @@ class Arguments;
class Dictionary;
}
namespace net {
class ProxyConfig;
}
namespace atom {
class AtomBrowserContext;
@@ -34,44 +40,67 @@ class Session: public mate::TrackableObject<Session>,
public:
using ResolveProxyCallback = base::Callback<void(std::string)>;
enum class CacheAction {
CLEAR,
STATS,
};
// Gets or creates Session from the |browser_context|.
static mate::Handle<Session> CreateFrom(
v8::Isolate* isolate, AtomBrowserContext* browser_context);
// Gets the Session of |partition| and |in_memory|.
// Gets the Session of |partition|.
static mate::Handle<Session> FromPartition(
v8::Isolate* isolate, const std::string& partition, bool in_memory);
v8::Isolate* isolate, const std::string& partition,
const base::DictionaryValue& options = base::DictionaryValue());
AtomBrowserContext* browser_context() const { return browser_context_.get(); }
// mate::TrackableObject:
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// Methods.
void ResolveProxy(const GURL& url, ResolveProxyCallback callback);
template<CacheAction action>
void DoCacheAction(const net::CompletionCallback& callback);
void ClearStorageData(mate::Arguments* args);
void FlushStorageData();
void SetProxy(const net::ProxyConfig& config, const base::Closure& callback);
void SetDownloadPath(const base::FilePath& path);
void EnableNetworkEmulation(const mate::Dictionary& options);
void DisableNetworkEmulation();
void SetCertVerifyProc(v8::Local<v8::Value> proc, mate::Arguments* args);
void SetPermissionRequestHandler(v8::Local<v8::Value> val,
mate::Arguments* args);
void ClearHostResolverCache(mate::Arguments* args);
void ClearAuthCache(mate::Arguments* args);
void AllowNTLMCredentialsForDomains(const std::string& domains);
void SetUserAgent(const std::string& user_agent, mate::Arguments* args);
std::string GetUserAgent();
void GetBlobData(const std::string& uuid,
const AtomBlobReader::CompletionCallback& callback);
void CreateInterruptedDownload(const mate::Dictionary& options);
v8::Local<v8::Value> Cookies(v8::Isolate* isolate);
v8::Local<v8::Value> Protocol(v8::Isolate* isolate);
v8::Local<v8::Value> WebRequest(v8::Isolate* isolate);
protected:
explicit Session(AtomBrowserContext* browser_context);
Session(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Session();
// content::DownloadManager::Observer:
void OnDownloadCreated(content::DownloadManager* manager,
content::DownloadItem* item) override;
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
bool IsDestroyed() const override;
private:
// mate::TrackableObject:
void Destroy() override;
void ResolveProxy(const GURL& url, ResolveProxyCallback callback);
void ClearCache(const net::CompletionCallback& callback);
void ClearStorageData(mate::Arguments* args);
void SetProxy(const std::string& proxy, const base::Closure& callback);
void SetDownloadPath(const base::FilePath& path);
void EnableNetworkEmulation(const mate::Dictionary& options);
void DisableNetworkEmulation();
v8::Local<v8::Value> Cookies(v8::Isolate* isolate);
// Cached object for cookies API.
// Cached object.
v8::Global<v8::Value> cookies_;
v8::Global<v8::Value> protocol_;
v8::Global<v8::Value> web_request_;
// The X-DevTools-Emulate-Network-Conditions-Client-Id.
std::string devtools_network_emulation_client_id_;
scoped_refptr<AtomBrowserContext> browser_context_;

View File

@@ -0,0 +1,97 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_system_preferences.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/node_includes.h"
#include "native_mate/dictionary.h"
#include "ui/gfx/color_utils.h"
namespace atom {
namespace api {
SystemPreferences::SystemPreferences(v8::Isolate* isolate) {
Init(isolate);
#if defined(OS_WIN)
InitializeWindow();
#endif
}
SystemPreferences::~SystemPreferences() {
#if defined(OS_WIN)
Browser::Get()->RemoveObserver(this);
#endif
}
#if !defined(OS_MACOSX)
bool SystemPreferences::IsDarkMode() {
return false;
}
#endif
bool SystemPreferences::IsInvertedColorScheme() {
return color_utils::IsInvertedColorScheme();
}
// static
mate::Handle<SystemPreferences> SystemPreferences::Create(
v8::Isolate* isolate) {
return mate::CreateHandle(isolate, new SystemPreferences(isolate));
}
// static
void SystemPreferences::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "SystemPreferences"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
#if defined(OS_WIN)
.SetMethod("getAccentColor", &SystemPreferences::GetAccentColor)
.SetMethod("isAeroGlassEnabled", &SystemPreferences::IsAeroGlassEnabled)
.SetMethod("getColor", &SystemPreferences::GetColor)
#elif defined(OS_MACOSX)
.SetMethod("postNotification",
&SystemPreferences::PostNotification)
.SetMethod("postLocalNotification",
&SystemPreferences::PostLocalNotification)
.SetMethod("subscribeNotification",
&SystemPreferences::SubscribeNotification)
.SetMethod("unsubscribeNotification",
&SystemPreferences::UnsubscribeNotification)
.SetMethod("subscribeLocalNotification",
&SystemPreferences::SubscribeLocalNotification)
.SetMethod("unsubscribeLocalNotification",
&SystemPreferences::UnsubscribeLocalNotification)
.SetMethod("getUserDefault", &SystemPreferences::GetUserDefault)
.SetMethod("setUserDefault", &SystemPreferences::SetUserDefault)
.SetMethod("isSwipeTrackingFromScrollEventsEnabled",
&SystemPreferences::IsSwipeTrackingFromScrollEventsEnabled)
#endif
.SetMethod("isInvertedColorScheme",
&SystemPreferences::IsInvertedColorScheme)
.SetMethod("isDarkMode", &SystemPreferences::IsDarkMode);
}
} // namespace api
} // namespace atom
namespace {
using atom::api::SystemPreferences;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
mate::Dictionary dict(isolate, exports);
dict.Set("systemPreferences", SystemPreferences::Create(isolate));
dict.Set("SystemPreferences",
SystemPreferences::GetConstructor(isolate)->GetFunction());
}
} // namespace
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_browser_system_preferences, Initialize);

View File

@@ -0,0 +1,129 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_SYSTEM_PREFERENCES_H_
#define ATOM_BROWSER_API_ATOM_API_SYSTEM_PREFERENCES_H_
#include <string>
#include "atom/browser/api/event_emitter.h"
#include "base/callback.h"
#include "base/values.h"
#include "native_mate/handle.h"
#if defined(OS_WIN)
#include "atom/browser/browser.h"
#include "atom/browser/browser_observer.h"
#include "ui/gfx/sys_color_change_listener.h"
#endif
namespace base {
class DictionaryValue;
}
namespace atom {
namespace api {
class SystemPreferences : public mate::EventEmitter<SystemPreferences>
#if defined(OS_WIN)
, public BrowserObserver
, public gfx::SysColorChangeListener
#endif
{
public:
static mate::Handle<SystemPreferences> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
#if defined(OS_WIN)
bool IsAeroGlassEnabled();
typedef HRESULT (STDAPICALLTYPE *DwmGetColorizationColor)(DWORD *, BOOL *);
DwmGetColorizationColor dwmGetColorizationColor =
(DwmGetColorizationColor) GetProcAddress(LoadLibraryW(L"dwmapi.dll"),
"DwmGetColorizationColor");
std::string GetAccentColor();
std::string GetColor(const std::string& color, mate::Arguments* args);
void InitializeWindow();
// gfx::SysColorChangeListener:
void OnSysColorChange() override;
// BrowserObserver:
void OnFinishLaunching(const base::DictionaryValue& launch_info) override;
#elif defined(OS_MACOSX)
using NotificationCallback = base::Callback<
void(const std::string&, const base::DictionaryValue&)>;
void PostNotification(const std::string& name,
const base::DictionaryValue& user_info);
void PostLocalNotification(const std::string& name,
const base::DictionaryValue& user_info);
int SubscribeNotification(const std::string& name,
const NotificationCallback& callback);
void UnsubscribeNotification(int id);
int SubscribeLocalNotification(const std::string& name,
const NotificationCallback& callback);
void UnsubscribeLocalNotification(int request_id);
v8::Local<v8::Value> GetUserDefault(const std::string& name,
const std::string& type);
void SetUserDefault(const std::string& name,
const std::string& type,
mate::Arguments* args);
bool IsSwipeTrackingFromScrollEventsEnabled();
#endif
bool IsDarkMode();
bool IsInvertedColorScheme();
protected:
explicit SystemPreferences(v8::Isolate* isolate);
~SystemPreferences() override;
#if defined(OS_MACOSX)
void DoPostNotification(const std::string& name,
const base::DictionaryValue& user_info,
bool is_local);
int DoSubscribeNotification(const std::string& name,
const NotificationCallback& callback,
bool is_local);
void DoUnsubscribeNotification(int request_id, bool is_local);
#endif
private:
#if defined(OS_WIN)
// Static callback invoked when a message comes in to our messaging window.
static LRESULT CALLBACK
WndProcStatic(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam);
LRESULT CALLBACK
WndProc(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam);
// The window class of |window_|.
ATOM atom_;
// The handle of the module that contains the window procedure of |window_|.
HMODULE instance_;
// The window used for processing events.
HWND window_;
std::string current_color_;
bool invertered_color_scheme_;
std::unique_ptr<gfx::ScopedSysColorChangeListener> color_change_listener_;
#endif
DISALLOW_COPY_AND_ASSIGN(SystemPreferences);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_SYSTEM_PREFERENCES_H_

View File

@@ -0,0 +1,244 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_system_preferences.h"
#include <map>
#import <Cocoa/Cocoa.h>
#include "atom/browser/mac/dict_util.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "base/strings/sys_string_conversions.h"
#include "base/values.h"
#include "net/base/mac/url_conversions.h"
namespace atom {
namespace api {
namespace {
int g_next_id = 0;
// The map to convert |id| to |int|.
std::map<int, id> g_id_map;
} // namespace
void SystemPreferences::PostNotification(const std::string& name,
const base::DictionaryValue& user_info) {
DoPostNotification(name, user_info, false);
}
void SystemPreferences::PostLocalNotification(const std::string& name,
const base::DictionaryValue& user_info) {
DoPostNotification(name, user_info, true);
}
void SystemPreferences::DoPostNotification(const std::string& name,
const base::DictionaryValue& user_info, bool is_local) {
NSNotificationCenter* center = is_local ?
[NSNotificationCenter defaultCenter] :
[NSDistributedNotificationCenter defaultCenter];
[center
postNotificationName:base::SysUTF8ToNSString(name)
object:nil
userInfo:DictionaryValueToNSDictionary(user_info)
];
}
int SystemPreferences::SubscribeNotification(
const std::string& name, const NotificationCallback& callback) {
return DoSubscribeNotification(name, callback, false);
}
void SystemPreferences::UnsubscribeNotification(int request_id) {
DoUnsubscribeNotification(request_id, false);
}
int SystemPreferences::SubscribeLocalNotification(
const std::string& name, const NotificationCallback& callback) {
return DoSubscribeNotification(name, callback, true);
}
void SystemPreferences::UnsubscribeLocalNotification(int request_id) {
DoUnsubscribeNotification(request_id, true);
}
int SystemPreferences::DoSubscribeNotification(const std::string& name,
const NotificationCallback& callback, bool is_local) {
int request_id = g_next_id++;
__block NotificationCallback copied_callback = callback;
NSNotificationCenter* center = is_local ?
[NSNotificationCenter defaultCenter] :
[NSDistributedNotificationCenter defaultCenter];
g_id_map[request_id] = [center
addObserverForName:base::SysUTF8ToNSString(name)
object:nil
queue:nil
usingBlock:^(NSNotification* notification) {
std::unique_ptr<base::DictionaryValue> user_info =
NSDictionaryToDictionaryValue(notification.userInfo);
if (user_info) {
copied_callback.Run(
base::SysNSStringToUTF8(notification.name),
*user_info);
} else {
copied_callback.Run(
base::SysNSStringToUTF8(notification.name),
base::DictionaryValue());
}
}
];
return request_id;
}
void SystemPreferences::DoUnsubscribeNotification(int request_id, bool is_local) {
auto iter = g_id_map.find(request_id);
if (iter != g_id_map.end()) {
id observer = iter->second;
NSNotificationCenter* center = is_local ?
[NSNotificationCenter defaultCenter] :
[NSDistributedNotificationCenter defaultCenter];
[center removeObserver:observer];
g_id_map.erase(iter);
}
}
v8::Local<v8::Value> SystemPreferences::GetUserDefault(
const std::string& name, const std::string& type) {
NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
NSString* key = base::SysUTF8ToNSString(name);
if (type == "string") {
return mate::StringToV8(isolate(),
base::SysNSStringToUTF8([defaults stringForKey:key]));
} else if (type == "boolean") {
return v8::Boolean::New(isolate(), [defaults boolForKey:key]);
} else if (type == "float") {
return v8::Number::New(isolate(), [defaults floatForKey:key]);
} else if (type == "integer") {
return v8::Integer::New(isolate(), [defaults integerForKey:key]);
} else if (type == "double") {
return v8::Number::New(isolate(), [defaults doubleForKey:key]);
} else if (type == "url") {
return mate::ConvertToV8(isolate(),
net::GURLWithNSURL([defaults URLForKey:key]));
} else if (type == "array") {
std::unique_ptr<base::ListValue> list =
NSArrayToListValue([defaults arrayForKey:key]);
if (list == nullptr)
list.reset(new base::ListValue());
return mate::ConvertToV8(isolate(), *list);
} else if (type == "dictionary") {
std::unique_ptr<base::DictionaryValue> dictionary =
NSDictionaryToDictionaryValue([defaults dictionaryForKey:key]);
if (dictionary == nullptr)
dictionary.reset(new base::DictionaryValue());
return mate::ConvertToV8(isolate(), *dictionary);
} else {
return v8::Undefined(isolate());
}
}
void SystemPreferences::SetUserDefault(const std::string& name,
const std::string& type,
mate::Arguments* args) {
const auto throwConversionError = [&] {
args->ThrowError("Unable to convert value to: " + type);
};
NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
NSString* key = base::SysUTF8ToNSString(name);
if (type == "string") {
std::string value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
[defaults setObject:base::SysUTF8ToNSString(value) forKey:key];
} else if (type == "boolean") {
bool value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
[defaults setBool:value forKey:key];
} else if (type == "float") {
float value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
[defaults setFloat:value forKey:key];
} else if (type == "integer") {
int value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
[defaults setInteger:value forKey:key];
} else if (type == "double") {
double value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
[defaults setDouble:value forKey:key];
} else if (type == "url") {
GURL value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
if (NSURL* url = net::NSURLWithGURL(value)) {
[defaults setURL:url forKey:key];
}
} else if (type == "array") {
base::ListValue value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
if (NSArray* array = ListValueToNSArray(value)) {
[defaults setObject:array forKey:key];
}
} else if (type == "dictionary") {
base::DictionaryValue value;
if (!args->GetNext(&value)) {
throwConversionError();
return;
}
if (NSDictionary* dict = DictionaryValueToNSDictionary(value)) {
[defaults setObject:dict forKey:key];
}
} else {
args->ThrowError("Invalid type: " + type);
return;
}
}
bool SystemPreferences::IsDarkMode() {
NSString* mode = [[NSUserDefaults standardUserDefaults]
stringForKey:@"AppleInterfaceStyle"];
return [mode isEqualToString:@"Dark"];
}
bool SystemPreferences::IsSwipeTrackingFromScrollEventsEnabled() {
return [NSEvent isSwipeTrackingFromScrollEventsEnabled];
}
} // namespace api
} // namespace atom

View File

@@ -0,0 +1,190 @@
// Copyright (c) 2014 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_system_preferences.h"
#include "atom/common/color_util.h"
#include "base/win/wrapped_window_proc.h"
#include "ui/base/win/shell.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/win/hwnd_util.h"
namespace atom {
namespace {
const wchar_t kSystemPreferencesWindowClass[] =
L"Electron_SystemPreferencesHostWindow";
} // namespace
namespace api {
bool SystemPreferences::IsAeroGlassEnabled() {
return ui::win::IsAeroGlassEnabled();
}
std::string hexColorDWORDToRGBA(DWORD color) {
std::ostringstream stream;
stream << std::hex << color;
std::string hexColor = stream.str();
return hexColor.substr(2) + hexColor.substr(0, 2);
}
std::string SystemPreferences::GetAccentColor() {
DWORD color = 0;
BOOL opaque = FALSE;
if (FAILED(dwmGetColorizationColor(&color, &opaque))) {
return "";
}
return hexColorDWORDToRGBA(color);
}
std::string SystemPreferences::GetColor(const std::string& color,
mate::Arguments* args) {
int id;
if (color == "3d-dark-shadow") {
id = COLOR_3DDKSHADOW;
} else if (color == "3d-face") {
id = COLOR_3DFACE;
} else if (color == "3d-highlight") {
id = COLOR_3DHIGHLIGHT;
} else if (color == "3d-light") {
id = COLOR_3DLIGHT;
} else if (color == "3d-shadow") {
id = COLOR_3DSHADOW;
} else if (color == "active-border") {
id = COLOR_ACTIVEBORDER;
} else if (color == "active-caption") {
id = COLOR_ACTIVECAPTION;
} else if (color == "active-caption-gradient") {
id = COLOR_GRADIENTACTIVECAPTION;
} else if (color == "app-workspace") {
id = COLOR_APPWORKSPACE;
} else if (color == "button-text") {
id = COLOR_BTNTEXT;
} else if (color == "caption-text") {
id = COLOR_CAPTIONTEXT;
} else if (color == "desktop") {
id = COLOR_DESKTOP;
} else if (color == "disabled-text") {
id = COLOR_GRAYTEXT;
} else if (color == "highlight") {
id = COLOR_HIGHLIGHT;
} else if (color == "highlight-text") {
id = COLOR_HIGHLIGHTTEXT;
} else if (color == "hotlight") {
id = COLOR_HOTLIGHT;
} else if (color == "inactive-border") {
id = COLOR_INACTIVEBORDER;
} else if (color == "inactive-caption") {
id = COLOR_INACTIVECAPTION;
} else if (color == "inactive-caption-gradient") {
id = COLOR_GRADIENTINACTIVECAPTION;
} else if (color == "inactive-caption-text") {
id = COLOR_INACTIVECAPTIONTEXT;
} else if (color == "info-background") {
id = COLOR_INFOBK;
} else if (color == "info-text") {
id = COLOR_INFOTEXT;
} else if (color == "menu") {
id = COLOR_MENU;
} else if (color == "menu-highlight") {
id = COLOR_MENUHILIGHT;
} else if (color == "menubar") {
id = COLOR_MENUBAR;
} else if (color == "menu-text") {
id = COLOR_MENUTEXT;
} else if (color == "scrollbar") {
id = COLOR_SCROLLBAR;
} else if (color == "window") {
id = COLOR_WINDOW;
} else if (color == "window-frame") {
id = COLOR_WINDOWFRAME;
} else if (color == "window-text") {
id = COLOR_WINDOWTEXT;
} else {
args->ThrowError("Unknown color: " + color);
return "";
}
return ToRGBHex(color_utils::GetSysSkColor(id));
}
void SystemPreferences::InitializeWindow() {
invertered_color_scheme_ = IsInvertedColorScheme();
// Wait until app is ready before creating sys color listener
// Creating this listener before the app is ready causes global shortcuts
// to not fire
if (Browser::Get()->is_ready())
color_change_listener_.reset(new gfx::ScopedSysColorChangeListener(this));
else
Browser::Get()->AddObserver(this);
WNDCLASSEX window_class;
base::win::InitializeWindowClass(
kSystemPreferencesWindowClass,
&base::win::WrappedWindowProc<SystemPreferences::WndProcStatic>,
0, 0, 0, NULL, NULL, NULL, NULL, NULL,
&window_class);
instance_ = window_class.hInstance;
atom_ = RegisterClassEx(&window_class);
// Create an offscreen window for receiving broadcast messages for the system
// colorization color. Create a hidden WS_POPUP window instead of an
// HWND_MESSAGE window, because only top-level windows such as popups can
// receive broadcast messages like "WM_DWMCOLORIZATIONCOLORCHANGED".
window_ = CreateWindow(MAKEINTATOM(atom_),
0, WS_POPUP, 0, 0, 0, 0, 0, 0, instance_, 0);
gfx::CheckWindowCreated(window_);
gfx::SetWindowUserData(window_, this);
}
LRESULT CALLBACK SystemPreferences::WndProcStatic(HWND hwnd,
UINT message,
WPARAM wparam,
LPARAM lparam) {
SystemPreferences* msg_wnd = reinterpret_cast<SystemPreferences*>(
GetWindowLongPtr(hwnd, GWLP_USERDATA));
if (msg_wnd)
return msg_wnd->WndProc(hwnd, message, wparam, lparam);
else
return ::DefWindowProc(hwnd, message, wparam, lparam);
}
LRESULT CALLBACK SystemPreferences::WndProc(HWND hwnd,
UINT message,
WPARAM wparam,
LPARAM lparam) {
if (message == WM_DWMCOLORIZATIONCOLORCHANGED) {
DWORD new_color = (DWORD) wparam;
std::string new_color_string = hexColorDWORDToRGBA(new_color);
if (new_color_string != current_color_) {
Emit("accent-color-changed", hexColorDWORDToRGBA(new_color));
current_color_ = new_color_string;
}
}
return ::DefWindowProc(hwnd, message, wparam, lparam);
}
void SystemPreferences::OnSysColorChange() {
bool new_invertered_color_scheme = IsInvertedColorScheme();
if (new_invertered_color_scheme != invertered_color_scheme_) {
invertered_color_scheme_ = new_invertered_color_scheme;
Emit("inverted-color-scheme-changed", new_invertered_color_scheme);
}
Emit("color-changed");
}
void SystemPreferences::OnFinishLaunching(
const base::DictionaryValue& launch_info) {
color_change_listener_.reset(new gfx::ScopedSysColorChangeListener(this));
}
} // namespace api
} // namespace atom

View File

@@ -8,58 +8,94 @@
#include "atom/browser/api/atom_api_menu.h"
#include "atom/browser/browser.h"
#include "atom/browser/ui/tray_icon.h"
#include "atom/common/api/atom_api_native_image.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
#include "atom/common/native_mate_converters/image_converter.h"
#include "atom/common/native_mate_converters/string16_converter.h"
#include "atom/common/node_includes.h"
#include "base/threading/thread_task_runner_handle.h"
#include "native_mate/constructor.h"
#include "native_mate/dictionary.h"
#include "ui/events/event_constants.h"
#include "ui/gfx/image/image.h"
namespace mate {
template<>
struct Converter<atom::TrayIcon::HighlightMode> {
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
atom::TrayIcon::HighlightMode* out) {
std::string mode;
if (ConvertFromV8(isolate, val, &mode)) {
if (mode == "always") {
*out = atom::TrayIcon::HighlightMode::ALWAYS;
return true;
}
if (mode == "selection") {
*out = atom::TrayIcon::HighlightMode::SELECTION;
return true;
}
if (mode == "never") {
*out = atom::TrayIcon::HighlightMode::NEVER;
return true;
}
}
// Support old boolean parameter
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
bool highlight;
if (ConvertFromV8(isolate, val, &highlight)) {
if (highlight)
*out = atom::TrayIcon::HighlightMode::SELECTION;
else
*out = atom::TrayIcon::HighlightMode::NEVER;
return true;
}
return false;
}
};
} // namespace mate
namespace atom {
namespace api {
Tray::Tray(const gfx::Image& image)
Tray::Tray(v8::Isolate* isolate, v8::Local<v8::Object> wrapper,
mate::Handle<NativeImage> image)
: tray_icon_(TrayIcon::Create()) {
tray_icon_->SetImage(image);
SetImage(isolate, image);
tray_icon_->AddObserver(this);
InitWith(isolate, wrapper);
}
Tray::~Tray() {
// Destroy the native tray in next tick.
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(
FROM_HERE, tray_icon_.release());
}
// static
mate::Wrappable* Tray::New(v8::Isolate* isolate, const gfx::Image& image) {
mate::WrappableBase* Tray::New(mate::Handle<NativeImage> image,
mate::Arguments* args) {
if (!Browser::Get()->is_ready()) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate, "Cannot create Tray before app is ready")));
args->ThrowError("Cannot create Tray before app is ready");
return nullptr;
}
return new Tray(image);
return new Tray(args->isolate(), args->GetThis(), image);
}
void Tray::OnClicked(const gfx::Rect& bounds, int modifiers) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitCustomEvent("clicked",
ModifiersToObject(isolate(), modifiers), bounds);
EmitWithFlags("click", modifiers, bounds);
}
void Tray::OnDoubleClicked(const gfx::Rect& bounds, int modifiers) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitCustomEvent("double-clicked",
ModifiersToObject(isolate(), modifiers), bounds);
EmitWithFlags("double-click", modifiers, bounds);
}
void Tray::OnRightClicked(const gfx::Rect& bounds, int modifiers) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitCustomEvent("right-clicked",
ModifiersToObject(isolate(), modifiers), bounds);
EmitWithFlags("right-click", modifiers, bounds);
}
void Tray::OnBalloonShow() {
@@ -67,48 +103,69 @@ void Tray::OnBalloonShow() {
}
void Tray::OnBalloonClicked() {
Emit("balloon-clicked");
Emit("balloon-click");
}
void Tray::OnBalloonClosed() {
Emit("balloon-closed");
}
void Tray::OnDrop() {
Emit("drop");
}
void Tray::OnDropFiles(const std::vector<std::string>& files) {
Emit("drop-files", files);
}
bool Tray::IsDestroyed() const {
return !tray_icon_;
void Tray::OnDropText(const std::string& text) {
Emit("drop-text", text);
}
void Tray::Destroy() {
tray_icon_.reset();
void Tray::OnDragEntered() {
Emit("drag-enter");
}
void Tray::SetImage(mate::Arguments* args, const gfx::Image& image) {
tray_icon_->SetImage(image);
void Tray::OnDragExited() {
Emit("drag-leave");
}
void Tray::SetPressedImage(mate::Arguments* args, const gfx::Image& image) {
tray_icon_->SetPressedImage(image);
void Tray::OnDragEnded() {
Emit("drag-end");
}
void Tray::SetToolTip(mate::Arguments* args, const std::string& tool_tip) {
void Tray::SetImage(v8::Isolate* isolate, mate::Handle<NativeImage> image) {
#if defined(OS_WIN)
tray_icon_->SetImage(image->GetHICON(GetSystemMetrics(SM_CXSMICON)));
#else
tray_icon_->SetImage(image->image());
#endif
}
void Tray::SetPressedImage(v8::Isolate* isolate,
mate::Handle<NativeImage> image) {
#if defined(OS_WIN)
tray_icon_->SetPressedImage(image->GetHICON(GetSystemMetrics(SM_CXSMICON)));
#else
tray_icon_->SetPressedImage(image->image());
#endif
}
void Tray::SetToolTip(const std::string& tool_tip) {
tray_icon_->SetToolTip(tool_tip);
}
void Tray::SetTitle(mate::Arguments* args, const std::string& title) {
void Tray::SetTitle(const std::string& title) {
tray_icon_->SetTitle(title);
}
void Tray::SetHighlightMode(mate::Arguments* args, bool highlight) {
tray_icon_->SetHighlightMode(highlight);
void Tray::SetHighlightMode(TrayIcon::HighlightMode mode) {
tray_icon_->SetHighlightMode(mode);
}
void Tray::DisplayBalloon(mate::Arguments* args,
const mate::Dictionary& options) {
gfx::Image icon;
mate::Handle<NativeImage> icon;
options.Get("icon", &icon);
base::string16 title, content;
if (!options.Get("title", &title) ||
@@ -117,34 +174,39 @@ void Tray::DisplayBalloon(mate::Arguments* args,
return;
}
tray_icon_->DisplayBalloon(icon, title, content);
#if defined(OS_WIN)
tray_icon_->DisplayBalloon(
icon.IsEmpty() ? NULL : icon->GetHICON(GetSystemMetrics(SM_CXSMICON)),
title, content);
#else
tray_icon_->DisplayBalloon(
icon.IsEmpty() ? gfx::Image() : icon->image(), title, content);
#endif
}
void Tray::PopUpContextMenu(mate::Arguments* args) {
mate::Handle<Menu> menu;
args->GetNext(&menu);
gfx::Point pos;
args->GetNext(&pos);
tray_icon_->PopUpContextMenu(pos);
tray_icon_->PopUpContextMenu(pos, menu.IsEmpty() ? nullptr : menu->model());
}
void Tray::SetContextMenu(mate::Arguments* args, Menu* menu) {
void Tray::SetContextMenu(v8::Isolate* isolate, mate::Handle<Menu> menu) {
menu_.Reset(isolate, menu.ToV8());
tray_icon_->SetContextMenu(menu->model());
}
v8::Local<v8::Object> Tray::ModifiersToObject(v8::Isolate* isolate,
int modifiers) {
mate::Dictionary obj(isolate, v8::Object::New(isolate));
obj.Set("shiftKey", static_cast<bool>(modifiers & ui::EF_SHIFT_DOWN));
obj.Set("ctrlKey", static_cast<bool>(modifiers & ui::EF_CONTROL_DOWN));
obj.Set("altKey", static_cast<bool>(modifiers & ui::EF_ALT_DOWN));
obj.Set("metaKey", static_cast<bool>(modifiers & ui::EF_COMMAND_DOWN));
return obj.GetHandle();
gfx::Rect Tray::GetBounds() {
return tray_icon_->GetBounds();
}
// static
void Tray::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype) {
mate::ObjectTemplateBuilder(isolate, prototype)
.SetMethod("destroy", &Tray::Destroy, true)
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Tray"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("setImage", &Tray::SetImage)
.SetMethod("setPressedImage", &Tray::SetPressedImage)
.SetMethod("setToolTip", &Tray::SetToolTip)
@@ -152,7 +214,8 @@ void Tray::BuildPrototype(v8::Isolate* isolate,
.SetMethod("setHighlightMode", &Tray::SetHighlightMode)
.SetMethod("displayBalloon", &Tray::DisplayBalloon)
.SetMethod("popUpContextMenu", &Tray::PopUpContextMenu)
.SetMethod("_setContextMenu", &Tray::SetContextMenu);
.SetMethod("setContextMenu", &Tray::SetContextMenu)
.SetMethod("getBounds", &Tray::GetBounds);
}
} // namespace api
@@ -162,14 +225,15 @@ void Tray::BuildPrototype(v8::Isolate* isolate,
namespace {
using atom::api::Tray;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
using atom::api::Tray;
v8::Isolate* isolate = context->GetIsolate();
v8::Local<v8::Function> constructor = mate::CreateConstructor<Tray>(
isolate, "Tray", base::Bind(&Tray::New));
Tray::SetConstructor(isolate, base::Bind(&Tray::New));
mate::Dictionary dict(isolate, exports);
dict.Set("Tray", static_cast<v8::Local<v8::Value>>(constructor));
dict.Set("Tray", Tray::GetConstructor(isolate)->GetFunction());
}
} // namespace

View File

@@ -5,12 +5,14 @@
#ifndef ATOM_BROWSER_API_ATOM_API_TRAY_H_
#define ATOM_BROWSER_API_ATOM_API_TRAY_H_
#include <memory>
#include <string>
#include <vector>
#include "atom/browser/api/event_emitter.h"
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/ui/tray_icon.h"
#include "atom/browser/ui/tray_icon_observer.h"
#include "base/memory/scoped_ptr.h"
#include "native_mate/handle.h"
namespace gfx {
class Image;
@@ -28,18 +30,21 @@ class TrayIcon;
namespace api {
class Menu;
class NativeImage;
class Tray : public mate::EventEmitter,
class Tray : public mate::TrackableObject<Tray>,
public TrayIconObserver {
public:
static mate::Wrappable* New(v8::Isolate* isolate, const gfx::Image& image);
static mate::WrappableBase* New(mate::Handle<NativeImage> image,
mate::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype);
v8::Local<v8::FunctionTemplate> prototype);
protected:
explicit Tray(const gfx::Image& image);
virtual ~Tray();
Tray(v8::Isolate* isolate, v8::Local<v8::Object> wrapper,
mate::Handle<NativeImage> image);
~Tray() override;
// TrayIconObserver:
void OnClicked(const gfx::Rect& bounds, int modifiers) override;
@@ -48,25 +53,26 @@ class Tray : public mate::EventEmitter,
void OnBalloonShow() override;
void OnBalloonClicked() override;
void OnBalloonClosed() override;
void OnDrop() override;
void OnDropFiles(const std::vector<std::string>& files) override;
void OnDropText(const std::string& text) override;
void OnDragEntered() override;
void OnDragExited() override;
void OnDragEnded() override;
// mate::Wrappable:
bool IsDestroyed() const override;
void Destroy();
void SetImage(mate::Arguments* args, const gfx::Image& image);
void SetPressedImage(mate::Arguments* args, const gfx::Image& image);
void SetToolTip(mate::Arguments* args, const std::string& tool_tip);
void SetTitle(mate::Arguments* args, const std::string& title);
void SetHighlightMode(mate::Arguments* args, bool highlight);
void SetImage(v8::Isolate* isolate, mate::Handle<NativeImage> image);
void SetPressedImage(v8::Isolate* isolate, mate::Handle<NativeImage> image);
void SetToolTip(const std::string& tool_tip);
void SetTitle(const std::string& title);
void SetHighlightMode(TrayIcon::HighlightMode mode);
void DisplayBalloon(mate::Arguments* args, const mate::Dictionary& options);
void PopUpContextMenu(mate::Arguments* args);
void SetContextMenu(mate::Arguments* args, Menu* menu);
void SetContextMenu(v8::Isolate* isolate, mate::Handle<Menu> menu);
gfx::Rect GetBounds();
private:
v8::Local<v8::Object> ModifiersToObject(v8::Isolate* isolate, int modifiers);
scoped_ptr<TrayIcon> tray_icon_;
v8::Global<v8::Object> menu_;
std::unique_ptr<TrayIcon> tray_icon_;
DISALLOW_COPY_AND_ASSIGN(Tray);
};

View File

@@ -0,0 +1,481 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_url_request.h"
#include <string>
#include "atom/browser/api/atom_api_session.h"
#include "atom/browser/net/atom_url_request.h"
#include "atom/common/api/event_emitter_caller.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/native_mate_converters/net_converter.h"
#include "atom/common/native_mate_converters/string16_converter.h"
#include "atom/common/node_includes.h"
#include "native_mate/dictionary.h"
namespace mate {
template <>
struct Converter<scoped_refptr<const net::IOBufferWithSize>> {
static v8::Local<v8::Value> ToV8(
v8::Isolate* isolate,
scoped_refptr<const net::IOBufferWithSize> buffer) {
return node::Buffer::Copy(isolate, buffer->data(), buffer->size())
.ToLocalChecked();
}
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
scoped_refptr<const net::IOBufferWithSize>* out) {
auto size = node::Buffer::Length(val);
if (size == 0) {
// Support conversion from empty buffer. A use case is
// a GET request without body.
// Since zero-sized IOBuffer(s) are not supported, we set the
// out pointer to null.
*out = nullptr;
return true;
}
auto data = node::Buffer::Data(val);
if (!data) {
// This is an error as size is positive but data is null.
return false;
}
*out = new net::IOBufferWithSize(size);
// We do a deep copy. We could have used Buffer's internal memory
// but that is much more complicated to be properly handled.
memcpy((*out)->data(), data, size);
return true;
}
};
} // namespace mate
namespace atom {
namespace api {
template <typename Flags>
URLRequest::StateBase<Flags>::StateBase(Flags initialState)
: state_(initialState) {}
template <typename Flags>
void URLRequest::StateBase<Flags>::SetFlag(Flags flag) {
state_ =
static_cast<Flags>(static_cast<int>(state_) | static_cast<int>(flag));
}
template <typename Flags>
bool URLRequest::StateBase<Flags>::operator==(Flags flag) const {
return state_ == flag;
}
template <typename Flags>
bool URLRequest::StateBase<Flags>::IsFlagSet(Flags flag) const {
return static_cast<int>(state_) & static_cast<int>(flag);
}
URLRequest::RequestState::RequestState()
: StateBase(RequestStateFlags::kNotStarted) {}
bool URLRequest::RequestState::NotStarted() const {
return *this == RequestStateFlags::kNotStarted;
}
bool URLRequest::RequestState::Started() const {
return IsFlagSet(RequestStateFlags::kStarted);
}
bool URLRequest::RequestState::Finished() const {
return IsFlagSet(RequestStateFlags::kFinished);
}
bool URLRequest::RequestState::Canceled() const {
return IsFlagSet(RequestStateFlags::kCanceled);
}
bool URLRequest::RequestState::Failed() const {
return IsFlagSet(RequestStateFlags::kFailed);
}
bool URLRequest::RequestState::Closed() const {
return IsFlagSet(RequestStateFlags::kClosed);
}
URLRequest::ResponseState::ResponseState()
: StateBase(ResponseStateFlags::kNotStarted) {}
bool URLRequest::ResponseState::NotStarted() const {
return *this == ResponseStateFlags::kNotStarted;
}
bool URLRequest::ResponseState::Started() const {
return IsFlagSet(ResponseStateFlags::kStarted);
}
bool URLRequest::ResponseState::Ended() const {
return IsFlagSet(ResponseStateFlags::kEnded);
}
bool URLRequest::ResponseState::Failed() const {
return IsFlagSet(ResponseStateFlags::kFailed);
}
URLRequest::URLRequest(v8::Isolate* isolate, v8::Local<v8::Object> wrapper) {
InitWith(isolate, wrapper);
}
URLRequest::~URLRequest() {
// A request has been created in JS, it was not used and then
// it got collected, no close event to cleanup, only destructor
// is called.
if (atom_request_) {
atom_request_->Terminate();
}
}
// static
mate::WrappableBase* URLRequest::New(mate::Arguments* args) {
auto isolate = args->isolate();
v8::Local<v8::Object> options;
args->GetNext(&options);
mate::Dictionary dict(isolate, options);
std::string method;
dict.Get("method", &method);
std::string url;
dict.Get("url", &url);
std::string redirect_policy;
dict.Get("redirect", &redirect_policy);
std::string partition;
mate::Handle<api::Session> session;
if (dict.Get("session", &session)) {
} else if (dict.Get("partition", &partition)) {
session = Session::FromPartition(isolate, partition);
} else {
// Use the default session if not specified.
session = Session::FromPartition(isolate, "");
}
auto browser_context = session->browser_context();
auto api_url_request = new URLRequest(args->isolate(), args->GetThis());
auto atom_url_request = AtomURLRequest::Create(
browser_context, method, url, redirect_policy, api_url_request);
api_url_request->atom_request_ = atom_url_request;
return api_url_request;
}
// static
void URLRequest::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "URLRequest"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
// Request API
.MakeDestroyable()
.SetMethod("write", &URLRequest::Write)
.SetMethod("cancel", &URLRequest::Cancel)
.SetMethod("setExtraHeader", &URLRequest::SetExtraHeader)
.SetMethod("removeExtraHeader", &URLRequest::RemoveExtraHeader)
.SetMethod("setChunkedUpload", &URLRequest::SetChunkedUpload)
.SetMethod("followRedirect", &URLRequest::FollowRedirect)
.SetMethod("_setLoadFlags", &URLRequest::SetLoadFlags)
.SetProperty("notStarted", &URLRequest::NotStarted)
.SetProperty("finished", &URLRequest::Finished)
// Response APi
.SetProperty("statusCode", &URLRequest::StatusCode)
.SetProperty("statusMessage", &URLRequest::StatusMessage)
.SetProperty("rawResponseHeaders", &URLRequest::RawResponseHeaders)
.SetProperty("httpVersionMajor", &URLRequest::ResponseHttpVersionMajor)
.SetProperty("httpVersionMinor", &URLRequest::ResponseHttpVersionMinor);
}
bool URLRequest::NotStarted() const {
return request_state_.NotStarted();
}
bool URLRequest::Finished() const {
return request_state_.Finished();
}
bool URLRequest::Canceled() const {
return request_state_.Canceled();
}
bool URLRequest::Write(scoped_refptr<const net::IOBufferWithSize> buffer,
bool is_last) {
if (request_state_.Canceled() || request_state_.Failed() ||
request_state_.Finished() || request_state_.Closed()) {
return false;
}
if (request_state_.NotStarted()) {
request_state_.SetFlag(RequestStateFlags::kStarted);
// Pin on first write.
Pin();
}
if (is_last) {
request_state_.SetFlag(RequestStateFlags::kFinished);
EmitRequestEvent(true, "finish");
}
DCHECK(atom_request_);
if (atom_request_) {
return atom_request_->Write(buffer, is_last);
}
return false;
}
void URLRequest::Cancel() {
if (request_state_.Canceled() || request_state_.Closed()) {
// Cancel only once.
return;
}
// Mark as canceled.
request_state_.SetFlag(RequestStateFlags::kCanceled);
DCHECK(atom_request_);
if (atom_request_ && request_state_.Started()) {
// Really cancel if it was started.
atom_request_->Cancel();
}
EmitRequestEvent(true, "abort");
if (response_state_.Started() && !response_state_.Ended()) {
EmitResponseEvent(true, "aborted");
}
Close();
}
void URLRequest::FollowRedirect() {
if (request_state_.Canceled() || request_state_.Closed()) {
return;
}
DCHECK(atom_request_);
if (atom_request_) {
atom_request_->FollowRedirect();
}
}
bool URLRequest::SetExtraHeader(const std::string& name,
const std::string& value) {
// Request state must be in the initial non started state.
if (!request_state_.NotStarted()) {
// Cannot change headers after send.
return false;
}
if (!net::HttpUtil::IsValidHeaderName(name)) {
return false;
}
if (!net::HttpUtil::IsValidHeaderValue(value)) {
return false;
}
DCHECK(atom_request_);
if (atom_request_) {
atom_request_->SetExtraHeader(name, value);
}
return true;
}
void URLRequest::RemoveExtraHeader(const std::string& name) {
// State must be equal to not started.
if (!request_state_.NotStarted()) {
// Cannot change headers after send.
return;
}
DCHECK(atom_request_);
if (atom_request_) {
atom_request_->RemoveExtraHeader(name);
}
}
void URLRequest::SetChunkedUpload(bool is_chunked_upload) {
// State must be equal to not started.
if (!request_state_.NotStarted()) {
// Cannot change headers after send.
return;
}
DCHECK(atom_request_);
if (atom_request_) {
atom_request_->SetChunkedUpload(is_chunked_upload);
}
}
void URLRequest::SetLoadFlags(int flags) {
// State must be equal to not started.
if (!request_state_.NotStarted()) {
// Cannot change load flags after start.
return;
}
DCHECK(atom_request_);
if (atom_request_) {
atom_request_->SetLoadFlags(flags);
}
}
void URLRequest::OnReceivedRedirect(
int status_code,
const std::string& method,
const GURL& url,
scoped_refptr<net::HttpResponseHeaders> response_headers) {
if (request_state_.Canceled() || request_state_.Closed()) {
return;
}
DCHECK(atom_request_);
if (!atom_request_) {
return;
}
EmitRequestEvent(false, "redirect", status_code, method, url,
response_headers.get());
}
void URLRequest::OnAuthenticationRequired(
scoped_refptr<const net::AuthChallengeInfo> auth_info) {
if (request_state_.Canceled() || request_state_.Closed()) {
return;
}
DCHECK(atom_request_);
if (!atom_request_) {
return;
}
Emit("login", auth_info.get(),
base::Bind(&AtomURLRequest::PassLoginInformation, atom_request_));
}
void URLRequest::OnResponseStarted(
scoped_refptr<net::HttpResponseHeaders> response_headers) {
if (request_state_.Canceled() || request_state_.Failed() ||
request_state_.Closed()) {
// Don't emit any event after request cancel.
return;
}
response_headers_ = response_headers;
response_state_.SetFlag(ResponseStateFlags::kStarted);
Emit("response");
}
void URLRequest::OnResponseData(
scoped_refptr<const net::IOBufferWithSize> buffer) {
if (request_state_.Canceled() || request_state_.Closed() ||
request_state_.Failed() || response_state_.Failed()) {
// In case we received an unexpected event from Chromium net,
// don't emit any data event after request cancel/error/close.
return;
}
if (!buffer || !buffer->data() || !buffer->size()) {
return;
}
Emit("data", buffer);
}
void URLRequest::OnResponseCompleted() {
if (request_state_.Canceled() || request_state_.Closed() ||
request_state_.Failed() || response_state_.Failed()) {
// In case we received an unexpected event from Chromium net,
// don't emit any data event after request cancel/error/close.
return;
}
response_state_.SetFlag(ResponseStateFlags::kEnded);
Emit("end");
Close();
}
void URLRequest::OnError(const std::string& error, bool isRequestError) {
auto error_object = v8::Exception::Error(mate::StringToV8(isolate(), error));
if (isRequestError) {
request_state_.SetFlag(RequestStateFlags::kFailed);
EmitRequestEvent(false, "error", error_object);
} else {
response_state_.SetFlag(ResponseStateFlags::kFailed);
EmitResponseEvent(false, "error", error_object);
}
Close();
}
int URLRequest::StatusCode() const {
if (response_headers_) {
return response_headers_->response_code();
}
return -1;
}
std::string URLRequest::StatusMessage() const {
std::string result;
if (response_headers_) {
result = response_headers_->GetStatusText();
}
return result;
}
net::HttpResponseHeaders* URLRequest::RawResponseHeaders() const {
return response_headers_.get();
}
uint32_t URLRequest::ResponseHttpVersionMajor() const {
if (response_headers_) {
return response_headers_->GetHttpVersion().major_value();
}
return 0;
}
uint32_t URLRequest::ResponseHttpVersionMinor() const {
if (response_headers_) {
return response_headers_->GetHttpVersion().minor_value();
}
return 0;
}
void URLRequest::Close() {
if (!request_state_.Closed()) {
request_state_.SetFlag(RequestStateFlags::kClosed);
if (response_state_.Started()) {
// Emit a close event if we really have a response object.
EmitResponseEvent(true, "close");
}
EmitRequestEvent(true, "close");
}
Unpin();
if (atom_request_) {
// A request has been created in JS, used and then it ended.
// We release unneeded net resources.
atom_request_->Terminate();
}
atom_request_ = nullptr;
}
void URLRequest::Pin() {
if (wrapper_.IsEmpty()) {
wrapper_.Reset(isolate(), GetWrapper());
}
}
void URLRequest::Unpin() {
wrapper_.Reset();
}
template <typename... Args>
void URLRequest::EmitRequestEvent(Args... args) {
v8::HandleScope handle_scope(isolate());
mate::CustomEmit(isolate(), GetWrapper(), "_emitRequestEvent", args...);
}
template <typename... Args>
void URLRequest::EmitResponseEvent(Args... args) {
v8::HandleScope handle_scope(isolate());
mate::CustomEmit(isolate(), GetWrapper(), "_emitResponseEvent", args...);
}
} // namespace api
} // namespace atom

View File

@@ -0,0 +1,213 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_URL_REQUEST_H_
#define ATOM_BROWSER_API_ATOM_API_URL_REQUEST_H_
#include <array>
#include <string>
#include "atom/browser/api/event_emitter.h"
#include "atom/browser/api/trackable_object.h"
#include "base/memory/weak_ptr.h"
#include "native_mate/dictionary.h"
#include "native_mate/handle.h"
#include "native_mate/wrappable_base.h"
#include "net/base/auth.h"
#include "net/base/io_buffer.h"
#include "net/http/http_response_headers.h"
#include "net/url_request/url_request_context.h"
namespace atom {
class AtomURLRequest;
namespace api {
//
// The URLRequest class implements the V8 binding between the JavaScript API
// and Chromium native net library. It is responsible for handling HTTP/HTTPS
// requests.
//
// The current class provides only the binding layer. Two other JavaScript
// classes (ClientRequest and IncomingMessage) in the net module provide the
// final API, including some state management and arguments validation.
//
// URLRequest's methods fall into two main categories: command and event
// methods. They are always executed on the Browser's UI thread.
// Command methods are called directly from JavaScript code via the API defined
// in BuildPrototype. A command method is generally implemented by forwarding
// the call to a corresponding method on AtomURLRequest which does the
// synchronization on the Browser IO thread. The latter then calls into Chromium
// net library. On the other hand, net library events originate on the IO
// thread in AtomURLRequest and are synchronized back on the UI thread, then
// forwarded to a corresponding event method in URLRequest and then to
// JavaScript via the EmitRequestEvent/EmitResponseEvent helpers.
//
// URLRequest lifetime management: we followed the Wrapper/Wrappable pattern
// defined in native_mate. However, we augment that pattern with a pin/unpin
// mechanism. The main reason is that we want the JS API to provide a similar
// lifetime guarantees as the XMLHttpRequest.
// https://xhr.spec.whatwg.org/#garbage-collection
//
// The primary motivation is to not garbage collect a URLInstance as long as the
// object is emitting network events. For instance, in the following JS code
//
// (function() {
// let request = new URLRequest(...);
// request.on('response', (response)=>{
// response.on('data', (data) = > {
// console.log(data.toString());
// });
// });
// })();
//
// we still want data to be logged even if the response/request objects are n
// more referenced in JavaScript.
//
// Binding by simply following the native_mate Wrapper/Wrappable pattern will
// delete the URLRequest object when the corresponding JS object is collected.
// The v8 handle is a private member in WrappableBase and it is always weak,
// there is no way to make it strong without changing native_mate.
// The solution we implement consists of maintaining some kind of state that
// prevents collection of JS wrappers as long as the request is emitting network
// events. At initialization, the object is unpinned. When the request starts,
// it is pinned. When no more events would be emitted, the object is unpinned
// and lifetime is again managed by the standard native mate Wrapper/Wrappable
// pattern.
//
// pin/unpin: are implemented by constructing/reseting a V8 strong persistent
// handle.
//
// The URLRequest/AtmURLRequest interaction could have been implemented in a
// single class. However, it implies that the resulting class lifetime will be
// managed by two conflicting mechanisms: JavaScript garbage collection and
// Chromium reference counting. Reasoning about lifetime issues become much
// more complex.
//
// We chose to split the implementation into two classes linked via a
// reference counted/raw pointers. A URLRequest instance is deleted if it is
// unpinned and the corresponding JS wrapper object is garbage collected. On the
// other hand, an AtmURLRequest instance lifetime is totally governed by
// reference counting.
//
class URLRequest : public mate::EventEmitter<URLRequest> {
public:
static mate::WrappableBase* New(mate::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// Methods for reporting events into JavaScript.
void OnReceivedRedirect(
int status_code,
const std::string& method,
const GURL& url,
scoped_refptr<net::HttpResponseHeaders> response_headers);
void OnAuthenticationRequired(
scoped_refptr<const net::AuthChallengeInfo> auth_info);
void OnResponseStarted(
scoped_refptr<net::HttpResponseHeaders> response_headers);
void OnResponseData(scoped_refptr<const net::IOBufferWithSize> data);
void OnResponseCompleted();
void OnError(const std::string& error, bool isRequestError);
protected:
explicit URLRequest(v8::Isolate* isolate, v8::Local<v8::Object> wrapper);
~URLRequest() override;
private:
template <typename Flags>
class StateBase {
public:
void SetFlag(Flags flag);
protected:
explicit StateBase(Flags initialState);
bool operator==(Flags flag) const;
bool IsFlagSet(Flags flag) const;
private:
Flags state_;
};
enum class RequestStateFlags {
kNotStarted = 0x0,
kStarted = 0x1,
kFinished = 0x2,
kCanceled = 0x4,
kFailed = 0x8,
kClosed = 0x10
};
class RequestState : public StateBase<RequestStateFlags> {
public:
RequestState();
bool NotStarted() const;
bool Started() const;
bool Finished() const;
bool Canceled() const;
bool Failed() const;
bool Closed() const;
};
enum class ResponseStateFlags {
kNotStarted = 0x0,
kStarted = 0x1,
kEnded = 0x2,
kFailed = 0x4
};
class ResponseState : public StateBase<ResponseStateFlags> {
public:
ResponseState();
bool NotStarted() const;
bool Started() const;
bool Ended() const;
bool Canceled() const;
bool Failed() const;
bool Closed() const;
};
bool NotStarted() const;
bool Finished() const;
bool Canceled() const;
bool Failed() const;
bool Write(scoped_refptr<const net::IOBufferWithSize> buffer, bool is_last);
void Cancel();
void FollowRedirect();
bool SetExtraHeader(const std::string& name, const std::string& value);
void RemoveExtraHeader(const std::string& name);
void SetChunkedUpload(bool is_chunked_upload);
void SetLoadFlags(int flags);
int StatusCode() const;
std::string StatusMessage() const;
net::HttpResponseHeaders* RawResponseHeaders() const;
uint32_t ResponseHttpVersionMajor() const;
uint32_t ResponseHttpVersionMinor() const;
void Close();
void Pin();
void Unpin();
template <typename... Args>
void EmitRequestEvent(Args... args);
template <typename... Args>
void EmitResponseEvent(Args... args);
scoped_refptr<AtomURLRequest> atom_request_;
RequestState request_state_;
ResponseState response_state_;
// Used to implement pin/unpin.
v8::Global<v8::Object> wrapper_;
scoped_refptr<net::HttpResponseHeaders> response_headers_;
DISALLOW_COPY_AND_ASSIGN(URLRequest);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_URL_REQUEST_H_

File diff suppressed because it is too large Load Diff

View File

@@ -9,8 +9,12 @@
#include <vector>
#include "atom/browser/api/frame_subscriber.h"
#include "atom/browser/api/save_page_handler.h"
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/common_web_contents_delegate.h"
#include "content/common/cursors/webcursor.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/favicon_url.h"
#include "native_mate/handle.h"
@@ -24,6 +28,10 @@ namespace brightray {
class InspectableWebContents;
}
namespace content {
class ResourceRequestBodyImpl;
}
namespace mate {
class Arguments;
class Dictionary;
@@ -33,14 +41,25 @@ namespace atom {
struct SetSizeParams;
class AtomBrowserContext;
class WebContentsZoomController;
class WebViewGuestDelegate;
namespace api {
class WebContents : public mate::TrackableObject<WebContents>,
public CommonWebContentsDelegate,
public content::WebContentsObserver {
public content::WebContentsObserver,
public content::NotificationObserver {
public:
enum Type {
BACKGROUND_PAGE, // A DevTools extension background page.
BROWSER_WINDOW, // Used by BrowserWindow.
BROWSER_VIEW, // Used by BrowserView.
REMOTE, // Thin wrap around an existing WebContents.
WEB_VIEW, // Used by <webview>.
OFF_SCREEN, // Used for offscreen rendering
};
// For node.js callback function type: function(error, buffer)
using PrintToPDFCallback =
base::Callback<void(v8::Local<v8::Value>, v8::Local<v8::Value>)>;
@@ -48,36 +67,48 @@ class WebContents : public mate::TrackableObject<WebContents>,
// Create from an existing WebContents.
static mate::Handle<WebContents> CreateFrom(
v8::Isolate* isolate, content::WebContents* web_contents);
static mate::Handle<WebContents> CreateFrom(
v8::Isolate* isolate, content::WebContents* web_contents, Type type);
// Create a new WebContents.
static mate::Handle<WebContents> Create(
v8::Isolate* isolate, const mate::Dictionary& options);
// mate::TrackableObject:
void Destroy() override;
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
bool IsAlive() const;
int GetID() const;
// Notifies to destroy any guest web contents before destroying self.
void DestroyWebContents(bool async);
int64_t GetID() const;
int GetProcessID() const;
Type GetType() const;
bool Equal(const WebContents* web_contents) const;
void LoadURL(const GURL& url, const mate::Dictionary& options);
void DownloadURL(const GURL& url);
GURL GetURL() const;
base::string16 GetTitle() const;
bool IsLoading() const;
bool IsLoadingMainFrame() const;
bool IsWaitingForResponse() const;
void Stop();
void ReloadIgnoringCache();
void GoBack();
void GoForward();
void GoToOffset(int offset);
const std::string GetWebRTCIPHandlingPolicy() const;
void SetWebRTCIPHandlingPolicy(const std::string& webrtc_ip_handling_policy);
bool IsCrashed() const;
void SetUserAgent(const std::string& user_agent);
void SetUserAgent(const std::string& user_agent, mate::Arguments* args);
std::string GetUserAgent();
void InsertCSS(const std::string& css);
void ExecuteJavaScript(const base::string16& code,
bool has_user_gesture);
bool SavePage(const base::FilePath& full_file_path,
const content::SavePageType& save_type,
const SavePageHandler::SavePageCallback& callback);
void OpenDevTools(mate::Arguments* args);
void CloseDevTools();
bool IsDevToolsOpened();
bool IsDevToolsFocused();
void ToggleDevTools();
void EnableDeviceEmulation(const blink::WebDeviceEmulationParams& params);
void DisableDeviceEmulation();
@@ -88,6 +119,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
void SetAudioMuted(bool muted);
bool IsAudioMuted();
void Print(mate::Arguments* args);
void SetEmbedder(const WebContents* embedder);
// Print current page as PDF.
void PrintToPDF(const base::DictionaryValue& setting,
@@ -109,28 +141,68 @@ class WebContents : public mate::TrackableObject<WebContents>,
void Unselect();
void Replace(const base::string16& word);
void ReplaceMisspelling(const base::string16& word);
uint32_t FindInPage(mate::Arguments* args);
void StopFindInPage(content::StopFindAction action);
void ShowDefinitionForSelection();
void CopyImageAt(int x, int y);
// Focus.
void Focus();
bool IsFocused() const;
void TabTraverse(bool reverse);
// Send messages to browser.
bool SendIPCMessage(const base::string16& channel,
bool SendIPCMessage(bool all_frames,
const base::string16& channel,
const base::ListValue& args);
// Send WebInputEvent to the page.
void SendInputEvent(v8::Isolate* isolate, v8::Local<v8::Value> input_event);
// Subscribe to the frame updates.
void BeginFrameSubscription(
const FrameSubscriber::FrameCaptureCallback& callback);
void BeginFrameSubscription(mate::Arguments* args);
void EndFrameSubscription();
// Dragging native items.
void StartDrag(const mate::Dictionary& item, mate::Arguments* args);
// Captures the page with |rect|, |callback| would be called when capturing is
// done.
void CapturePage(mate::Arguments* args);
// Methods for creating <webview>.
void SetSize(const SetSizeParams& params);
void SetAllowTransparency(bool allow);
bool IsGuest() const;
// Methods for offscreen rendering
bool IsOffScreen() const;
void OnPaint(const gfx::Rect& dirty_rect, const SkBitmap& bitmap);
void StartPainting();
void StopPainting();
bool IsPainting() const;
void SetFrameRate(int frame_rate);
int GetFrameRate() const;
void Invalidate();
// Methods for zoom handling.
void SetZoomLevel(double level);
double GetZoomLevel();
void SetZoomFactor(double factor);
double GetZoomFactor();
// Callback triggered on permission response.
void OnEnterFullscreenModeForTab(content::WebContents* source,
const GURL& origin,
bool allowed);
// Create window with the given disposition.
void OnCreateWindow(
const GURL& target_url,
const std::string& frame_name,
WindowOpenDisposition disposition,
const std::vector<std::string>& features,
const scoped_refptr<content::ResourceRequestBodyImpl>& body);
// Returns the web preferences of current WebContents.
v8::Local<v8::Value> GetWebPreferences(v8::Isolate* isolate);
@@ -138,34 +210,44 @@ class WebContents : public mate::TrackableObject<WebContents>,
v8::Local<v8::Value> GetOwnerBrowserWindow();
// Properties.
int32_t ID() const;
v8::Local<v8::Value> Session(v8::Isolate* isolate);
content::WebContents* HostWebContents();
v8::Local<v8::Value> DevToolsWebContents(v8::Isolate* isolate);
v8::Local<v8::Value> Debugger(v8::Isolate* isolate);
WebContentsZoomController* GetZoomController() { return zoom_controller_; }
protected:
explicit WebContents(content::WebContents* web_contents);
WebContents(v8::Isolate* isolate,
content::WebContents* web_contents,
Type type);
WebContents(v8::Isolate* isolate, const mate::Dictionary& options);
~WebContents();
// mate::Wrappable:
mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
bool IsDestroyed() const override;
void InitWithSessionAndOptions(v8::Isolate* isolate,
content::WebContents *web_contents,
mate::Handle<class Session> session,
const mate::Dictionary& options);
// content::WebContentsDelegate:
bool AddMessageToConsole(content::WebContents* source,
int32 level,
const base::string16& message,
int32 line_no,
const base::string16& source_id) override;
bool ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
int main_frame_route_id,
WindowContainerType window_container_type,
const std::string& frame_name,
const GURL& target_url,
const std::string& partition_id,
content::SessionStorageNamespace* session_storage_namespace) override;
bool DidAddMessageToConsole(content::WebContents* source,
int32_t level,
const base::string16& message,
int32_t line_no,
const base::string16& source_id) override;
void WebContentsCreated(content::WebContents* source_contents,
int opener_render_process_id,
int opener_render_frame_id,
const std::string& frame_name,
const GURL& target_url,
content::WebContents* new_contents) override;
void AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_rect,
bool user_gesture,
bool* was_blocked) override;
content::WebContents* OpenURLFromTab(
content::WebContents* source,
const content::OpenURLParams& params) override;
@@ -176,18 +258,48 @@ class WebContents : public mate::TrackableObject<WebContents>,
const gfx::Rect& pos) override;
void CloseContents(content::WebContents* source) override;
void ActivateContents(content::WebContents* contents) override;
void UpdateTargetURL(content::WebContents* source, const GURL& url) override;
bool IsPopupOrPanel(const content::WebContents* source) const override;
void HandleKeyboardEvent(
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) override;
bool PreHandleKeyboardEvent(content::WebContents* source,
const content::NativeWebKeyboardEvent& event,
bool* is_keyboard_shortcut) override;
void EnterFullscreenModeForTab(content::WebContents* source,
const GURL& origin) override;
void ExitFullscreenModeForTab(content::WebContents* source) override;
void RendererUnresponsive(content::WebContents* source) override;
void RendererUnresponsive(
content::WebContents* source,
const content::WebContentsUnresponsiveState& unresponsive_state) override;
void RendererResponsive(content::WebContents* source) override;
bool HandleContextMenu(const content::ContextMenuParams& params) override;
bool OnGoToEntryOffset(int offset) override;
void FindReply(content::WebContents* web_contents,
int request_id,
int number_of_matches,
const gfx::Rect& selection_rect,
int active_match_ordinal,
bool final_update) override;
bool CheckMediaAccessPermission(
content::WebContents* web_contents,
const GURL& security_origin,
content::MediaStreamType type) override;
void RequestMediaAccessPermission(
content::WebContents* web_contents,
const content::MediaStreamRequest& request,
const content::MediaResponseCallback& callback) override;
void RequestToLockMouse(
content::WebContents* web_contents,
bool user_gesture,
bool last_unlocked_by_target) override;
std::unique_ptr<content::BluetoothChooser> RunBluetoothChooser(
content::RenderFrameHost* frame,
const content::BluetoothChooser::EventHandler& handler) override;
// content::WebContentsObserver:
void BeforeUnloadFired(const base::TimeTicks& proceed_time) override;
void RenderViewCreated(content::RenderViewHost*) override;
void RenderViewDeleted(content::RenderViewHost*) override;
void RenderProcessGone(base::TerminationStatus status) override;
void DocumentLoadedInFrame(
@@ -199,21 +311,16 @@ class WebContents : public mate::TrackableObject<WebContents>,
int error_code,
const base::string16& error_description,
bool was_ignored_by_handler) override;
void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
const base::string16& error_description,
bool was_ignored_by_handler) override;
void DidStartLoading() override;
void DidStopLoading() override;
void DidGetResourceResponseStart(
const content::ResourceRequestDetails& details) override;
void DidGetRedirectForResourceRequest(
content::RenderFrameHost* render_frame_host,
const content::ResourceRedirectDetails& details) override;
void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
bool OnMessageReceived(const IPC::Message& message) override;
void WebContentsDestroyed() override;
void NavigationEntryCommitted(
@@ -223,6 +330,20 @@ class WebContents : public mate::TrackableObject<WebContents>,
const std::vector<content::FaviconURL>& urls) override;
void PluginCrashed(const base::FilePath& plugin_path,
base::ProcessId plugin_pid) override;
void MediaStartedPlaying(const MediaPlayerInfo& video_type,
const MediaPlayerId& id) override;
void MediaStoppedPlaying(const MediaPlayerInfo& video_type,
const MediaPlayerId& id) override;
void DidChangeThemeColor(SkColor theme_color) override;
// content::NotificationObserver:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
void BeforeUnloadDialogCancelled() override;
// brightray::InspectableWebContentsDelegate:
void DevToolsReloadPage() override;
// brightray::InspectableWebContentsViewDelegate:
void DevToolsFocused() override;
@@ -230,14 +351,22 @@ class WebContents : public mate::TrackableObject<WebContents>,
void DevToolsClosed() override;
private:
enum Type {
BROWSER_WINDOW, // Used by BrowserWindow.
WEB_VIEW, // Used by <webview>.
REMOTE, // Thin wrap around an existing WebContents.
struct LoadURLParams {
LoadURLParams() : params(GURL()), id(0) {}
content::NavigationController::LoadURLParams params;
int id;
};
AtomBrowserContext* GetBrowserContext() const;
uint32_t GetNextRequestId() {
return ++request_id_;
}
// Called when we receive a CursorChange message from chromium.
void OnCursorChange(const content::WebCursor& cursor);
// Called when received a message from renderer.
void OnRendererMessage(const base::string16& channel,
const base::ListValue& args);
@@ -247,14 +376,43 @@ class WebContents : public mate::TrackableObject<WebContents>,
const base::ListValue& args,
IPC::Message* message);
// Called when received a synchronous message from renderer to
// set temporary zoom level.
void OnSetTemporaryZoomLevel(double level, IPC::Message* reply_msg);
// Called when received a synchronous message from renderer to
// get the zoom level.
void OnGetZoomLevel(IPC::Message* reply_msg);
v8::Global<v8::Value> session_;
v8::Global<v8::Value> devtools_web_contents_;
v8::Global<v8::Value> debugger_;
scoped_ptr<WebViewGuestDelegate> guest_delegate_;
std::unique_ptr<WebViewGuestDelegate> guest_delegate_;
// The host webcontents that may contain this webcontents.
WebContents* embedder_;
// The zoom controller for this webContents.
WebContentsZoomController* zoom_controller_;
// The type of current WebContents.
Type type_;
// Request id used for findInPage request.
uint32_t request_id_;
// Whether background throttling is disabled.
bool background_throttling_;
// Whether to enable devtools.
bool enable_devtools_;
// Container to hold url parms for deferred load when
// there is a pending navigation entry.
LoadURLParams deferred_load_url_;
content::NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(WebContents);
};

View File

@@ -0,0 +1,30 @@
// Copyright (c) 2016 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_web_contents.h"
#import <Cocoa/Cocoa.h>
namespace atom {
namespace api {
bool WebContents::IsFocused() const {
auto view = web_contents()->GetRenderWidgetHostView();
if (!view) return false;
if (GetType() != BACKGROUND_PAGE) {
auto window = [web_contents()->GetNativeView() window];
// On Mac the render widget host view does not lose focus when the window
// loses focus so check if the top level window is the key window.
if (window && ![window isKeyWindow])
return false;
}
return view->HasFocus();
}
} // namespace api
} // namespace atom

View File

@@ -0,0 +1,123 @@
// Copyright (c) 2015 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_web_request.h"
#include <string>
#include "atom/browser/atom_browser_context.h"
#include "atom/browser/net/atom_network_delegate.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/net_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
using content::BrowserThread;
namespace mate {
template<>
struct Converter<URLPattern> {
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
URLPattern* out) {
std::string pattern;
if (!ConvertFromV8(isolate, val, &pattern))
return false;
*out = URLPattern(URLPattern::SCHEME_ALL);
return out->Parse(pattern) == URLPattern::PARSE_SUCCESS;
}
};
} // namespace mate
namespace atom {
namespace api {
WebRequest::WebRequest(v8::Isolate* isolate,
AtomBrowserContext* browser_context)
: browser_context_(browser_context) {
Init(isolate);
}
WebRequest::~WebRequest() {
}
template<AtomNetworkDelegate::SimpleEvent type>
void WebRequest::SetSimpleListener(mate::Arguments* args) {
SetListener<AtomNetworkDelegate::SimpleListener>(
&AtomNetworkDelegate::SetSimpleListenerInIO, type, args);
}
template<AtomNetworkDelegate::ResponseEvent type>
void WebRequest::SetResponseListener(mate::Arguments* args) {
SetListener<AtomNetworkDelegate::ResponseListener>(
&AtomNetworkDelegate::SetResponseListenerInIO, type, args);
}
template<typename Listener, typename Method, typename Event>
void WebRequest::SetListener(Method method, Event type, mate::Arguments* args) {
// { urls }.
URLPatterns patterns;
mate::Dictionary dict;
args->GetNext(&dict) && dict.Get("urls", &patterns);
// Function or null.
v8::Local<v8::Value> value;
Listener listener;
if (!args->GetNext(&listener) &&
!(args->GetNext(&value) && value->IsNull())) {
args->ThrowError("Must pass null or a Function");
return;
}
auto delegate = browser_context_->network_delegate();
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(method, base::Unretained(delegate), type,
patterns, listener));
}
// static
mate::Handle<WebRequest> WebRequest::Create(
v8::Isolate* isolate,
AtomBrowserContext* browser_context) {
return mate::CreateHandle(isolate, new WebRequest(isolate, browser_context));
}
// static
void WebRequest::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "WebRequest"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("onBeforeRequest",
&WebRequest::SetResponseListener<
AtomNetworkDelegate::kOnBeforeRequest>)
.SetMethod("onBeforeSendHeaders",
&WebRequest::SetResponseListener<
AtomNetworkDelegate::kOnBeforeSendHeaders>)
.SetMethod("onHeadersReceived",
&WebRequest::SetResponseListener<
AtomNetworkDelegate::kOnHeadersReceived>)
.SetMethod("onSendHeaders",
&WebRequest::SetSimpleListener<
AtomNetworkDelegate::kOnSendHeaders>)
.SetMethod("onBeforeRedirect",
&WebRequest::SetSimpleListener<
AtomNetworkDelegate::kOnBeforeRedirect>)
.SetMethod("onResponseStarted",
&WebRequest::SetSimpleListener<
AtomNetworkDelegate::kOnResponseStarted>)
.SetMethod("onCompleted",
&WebRequest::SetSimpleListener<
AtomNetworkDelegate::kOnCompleted>)
.SetMethod("onErrorOccurred",
&WebRequest::SetSimpleListener<
AtomNetworkDelegate::kOnErrorOccurred>);
}
} // namespace api
} // namespace atom

View File

@@ -0,0 +1,49 @@
// Copyright (c) 2015 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_API_ATOM_API_WEB_REQUEST_H_
#define ATOM_BROWSER_API_ATOM_API_WEB_REQUEST_H_
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/net/atom_network_delegate.h"
#include "native_mate/arguments.h"
#include "native_mate/handle.h"
namespace atom {
class AtomBrowserContext;
namespace api {
class WebRequest : public mate::TrackableObject<WebRequest> {
public:
static mate::Handle<WebRequest> Create(v8::Isolate* isolate,
AtomBrowserContext* browser_context);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
protected:
WebRequest(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~WebRequest() override;
// C++ can not distinguish overloaded member function.
template<AtomNetworkDelegate::SimpleEvent type>
void SetSimpleListener(mate::Arguments* args);
template<AtomNetworkDelegate::ResponseEvent type>
void SetResponseListener(mate::Arguments* args);
template<typename Listener, typename Method, typename Event>
void SetListener(Method method, Event type, mate::Arguments* args);
private:
scoped_refptr<AtomBrowserContext> browser_context_;
DISALLOW_COPY_AND_ASSIGN(WebRequest);
};
} // namespace api
} // namespace atom
#endif // ATOM_BROWSER_API_ATOM_API_WEB_REQUEST_H_

View File

@@ -2,59 +2,41 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "atom/browser/api/atom_api_web_contents.h"
#include "atom/browser/web_contents_preferences.h"
#include "atom/browser/web_contents_zoom_controller.h"
#include "atom/browser/web_view_manager.h"
#include "atom/common/native_mate_converters/content_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/node_includes.h"
#include "atom/common/options_switches.h"
#include "content/public/browser/browser_context.h"
#include "native_mate/dictionary.h"
using atom::WebContentsPreferences;
namespace mate {
template<>
struct Converter<content::WebContents*> {
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
content::WebContents** out) {
atom::api::WebContents* contents;
if (!Converter<atom::api::WebContents*>::FromV8(isolate, val, &contents))
return false;
*out = contents->web_contents();
return true;
}
};
} // namespace mate
namespace {
atom::WebViewManager* GetWebViewManager(content::WebContents* web_contents) {
auto context = web_contents->GetBrowserContext();
if (context) {
auto manager = context->GetGuestManager();
return static_cast<atom::WebViewManager*>(manager);
} else {
return nullptr;
}
}
void AddGuest(int guest_instance_id,
int element_instance_id,
content::WebContents* embedder,
content::WebContents* guest_web_contents,
const base::DictionaryValue& options) {
auto manager = GetWebViewManager(embedder);
auto manager = atom::WebViewManager::GetWebViewManager(embedder);
if (manager)
manager->AddGuest(guest_instance_id, element_instance_id, embedder,
guest_web_contents);
double zoom_factor;
if (options.GetDouble(atom::options::kZoomFactor, &zoom_factor)) {
atom::WebContentsZoomController::FromWebContents(guest_web_contents)
->SetDefaultZoomFactor(zoom_factor);
}
WebContentsPreferences::FromWebContents(guest_web_contents)->Merge(options);
}
void RemoveGuest(content::WebContents* embedder, int guest_instance_id) {
auto manager = GetWebViewManager(embedder);
auto manager = atom::WebViewManager::GetWebViewManager(embedder);
if (manager)
manager->RemoveGuest(guest_instance_id);
}

View File

@@ -3,28 +3,39 @@
// found in the LICENSE file.
#include "atom/browser/api/atom_api_window.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/browser/api/atom_api_browser_view.h"
#include "atom/browser/api/atom_api_menu.h"
#include "atom/browser/api/atom_api_web_contents.h"
#include "atom/browser/browser.h"
#include "atom/browser/native_window.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
#include "atom/common/native_mate_converters/gurl_converter.h"
#include "atom/common/native_mate_converters/image_converter.h"
#include "atom/common/native_mate_converters/string16_converter.h"
#include "atom/common/node_includes.h"
#include "atom/common/options_switches.h"
#include "base/command_line.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/common/content_switches.h"
#include "native_mate/constructor.h"
#include "native_mate/dictionary.h"
#include "ui/gfx/geometry/rect.h"
#if defined(OS_WIN)
#if defined(TOOLKIT_VIEWS)
#include "atom/browser/native_window_views.h"
#include "atom/browser/ui/win/taskbar_host.h"
#endif
#if defined(OS_WIN)
#include "atom/browser/ui/win/taskbar_host.h"
#include "ui/base/win/shell.h"
#endif
#include "atom/common/node_includes.h"
#if defined(OS_WIN)
namespace mate {
@@ -51,78 +62,137 @@ namespace api {
namespace {
void OnCapturePageDone(
v8::Isolate* isolate,
const base::Callback<void(const gfx::Image&)>& callback,
const SkBitmap& bitmap) {
v8::Locker locker(isolate);
v8::HandleScope handle_scope(isolate);
callback.Run(gfx::Image::CreateFrom1xBitmap(bitmap));
// Converts binary data to Buffer.
v8::Local<v8::Value> ToBuffer(v8::Isolate* isolate, void* val, int size) {
auto buffer = node::Buffer::Copy(isolate, static_cast<char*>(val), size);
if (buffer.IsEmpty())
return v8::Null(isolate);
else
return buffer.ToLocalChecked();
}
} // namespace
Window::Window(v8::Isolate* isolate, const mate::Dictionary& options) {
// Use options['web-preferences'] to create WebContents.
mate::Dictionary web_preferences = mate::Dictionary::CreateEmpty(isolate);
options.Get(switches::kWebPreferences, &web_preferences);
Window::Window(v8::Isolate* isolate, v8::Local<v8::Object> wrapper,
const mate::Dictionary& options) {
mate::Handle<class WebContents> web_contents;
// If no WebContents was passed to the constructor, create it from options.
if (!options.Get("webContents", &web_contents)) {
// Use options.webPreferences to create WebContents.
mate::Dictionary web_preferences = mate::Dictionary::CreateEmpty(isolate);
options.Get(options::kWebPreferences, &web_preferences);
// Be compatible with old options which are now in web_preferences.
v8::Local<v8::Value> value;
if (options.Get(switches::kNodeIntegration, &value))
web_preferences.Set(switches::kNodeIntegration, value);
if (options.Get(switches::kPreloadScript, &value))
web_preferences.Set(switches::kPreloadScript, value);
if (options.Get(switches::kZoomFactor, &value))
web_preferences.Set(switches::kZoomFactor, value);
// Copy the backgroundColor to webContents.
v8::Local<v8::Value> value;
if (options.Get(options::kBackgroundColor, &value))
web_preferences.Set(options::kBackgroundColor, value);
// Creates the WebContents used by BrowserWindow.
auto web_contents = WebContents::Create(isolate, web_preferences);
v8::Local<v8::Value> transparent;
if (options.Get("transparent", &transparent))
web_preferences.Set("transparent", transparent);
// Offscreen windows are always created frameless.
bool offscreen;
if (web_preferences.Get("offscreen", &offscreen) && offscreen) {
auto window_options = const_cast<mate::Dictionary&>(options);
window_options.Set(options::kFrame, false);
}
// Creates the WebContents used by BrowserWindow.
web_contents = WebContents::Create(isolate, web_preferences);
}
Init(isolate, wrapper, options, web_contents);
}
void Window::Init(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options,
mate::Handle<class WebContents> web_contents) {
web_contents_.Reset(isolate, web_contents.ToV8());
api_web_contents_ = web_contents.get();
// Keep a copy of the options for later use.
mate::Dictionary(isolate, web_contents->GetWrapper(isolate)).Set(
mate::Dictionary(isolate, web_contents->GetWrapper()).Set(
"browserWindowOptions", options);
// The parent window.
mate::Handle<Window> parent;
if (options.Get("parent", &parent))
parent_window_.Reset(isolate, parent.ToV8());
// Creates BrowserWindow.
window_.reset(NativeWindow::Create(web_contents->managed_web_contents(),
options));
window_.reset(NativeWindow::Create(
web_contents->managed_web_contents(),
options,
parent.IsEmpty() ? nullptr : parent->window_.get()));
web_contents->SetOwnerWindow(window_.get());
#if defined(TOOLKIT_VIEWS)
// Sets the window icon.
mate::Handle<NativeImage> icon;
if (options.Get(options::kIcon, &icon))
SetIcon(icon);
#endif
window_->InitFromOptions(options);
window_->AddObserver(this);
InitWith(isolate, wrapper);
AttachAsUserData(window_.get());
// We can only append this window to parent window's child windows after this
// window's JS wrapper gets initialized.
if (!parent.IsEmpty())
parent->child_windows_.Set(isolate, ID(), wrapper);
}
Window::~Window() {
if (window_)
Destroy();
}
if (!window_->IsClosed())
window_->CloseContents(nullptr);
void Window::OnPageTitleUpdated(bool* prevent_default,
const std::string& title) {
*prevent_default = Emit("page-title-updated", title);
// Destroy the native window in next tick because the native code might be
// iterating all windows.
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, window_.release());
}
void Window::WillCloseWindow(bool* prevent_default) {
*prevent_default = Emit("close");
}
void Window::OnWindowClosed() {
if (api_web_contents_) {
api_web_contents_->DestroyWebContents();
api_web_contents_ = nullptr;
web_contents_.Reset();
void Window::WillDestroyNativeObject() {
// Close all child windows before closing current window.
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
for (v8::Local<v8::Value> value : child_windows_.Values(isolate())) {
mate::Handle<Window> child;
if (mate::ConvertFromV8(isolate(), value, &child))
child->window_->CloseImmediately();
}
}
void Window::OnWindowClosed() {
api_web_contents_->DestroyWebContents(true /* async */);
RemoveFromWeakMap();
window_->RemoveObserver(this);
// We can not call Destroy here because we need to call Emit first, but we
// also do not want any method to be used, so just mark as destroyed here.
MarkDestroyed();
Emit("closed");
// Clean up the resources after window has been closed.
base::MessageLoop::current()->DeleteSoon(FROM_HERE, window_.release());
RemoveFromParentChildWindows();
// Destroy the native class when window is closed.
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, GetDestroyClosure());
}
void Window::OnWindowEndSession() {
Emit("session-end");
}
void Window::OnWindowBlur() {
@@ -133,6 +203,18 @@ void Window::OnWindowFocus() {
Emit("focus");
}
void Window::OnWindowShow() {
Emit("show");
}
void Window::OnWindowHide() {
Emit("hide");
}
void Window::OnReadyToShow() {
Emit("ready-to-show");
}
void Window::OnWindowMaximize() {
Emit("maximize");
}
@@ -169,6 +251,30 @@ void Window::OnWindowLeaveFullScreen() {
Emit("leave-full-screen");
}
void Window::OnWindowScrollTouchBegin() {
Emit("scroll-touch-begin");
}
void Window::OnWindowScrollTouchEnd() {
Emit("scroll-touch-end");
}
void Window::OnWindowScrollTouchEdge() {
Emit("scroll-touch-edge");
}
void Window::OnWindowSwipe(const std::string& direction) {
Emit("swipe", direction);
}
void Window::OnWindowSheetBegin() {
Emit("sheet-begin");
}
void Window::OnWindowSheetEnd() {
Emit("sheet-end");
}
void Window::OnWindowEnterHtmlFullScreen() {
Emit("enter-html-full-screen");
}
@@ -189,38 +295,53 @@ void Window::OnExecuteWindowsCommand(const std::string& command_name) {
Emit("app-command", command_name);
}
void Window::OnTouchBarItemResult(const std::string& item_id,
const base::DictionaryValue& details) {
Emit("-touch-bar-interaction", item_id, details);
}
#if defined(OS_WIN)
void Window::OnWindowMessage(UINT message, WPARAM w_param, LPARAM l_param) {
if (IsWindowMessageHooked(message)) {
messages_callback_map_[message].Run(
ToBuffer(isolate(), static_cast<void*>(&w_param), sizeof(WPARAM)),
ToBuffer(isolate(), static_cast<void*>(&l_param), sizeof(LPARAM)));
}
}
#endif
// static
mate::Wrappable* Window::New(v8::Isolate* isolate,
const mate::Dictionary& options) {
mate::WrappableBase* Window::New(mate::Arguments* args) {
if (!Browser::Get()->is_ready()) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate, "Cannot create BrowserWindow before app is ready")));
args->ThrowError("Cannot create BrowserWindow before app is ready");
return nullptr;
}
return new Window(isolate, options);
}
bool Window::IsDestroyed() const {
return !window_ || window_->IsClosed();
}
if (args->Length() > 1) {
args->ThrowError();
return nullptr;
}
void Window::Destroy() {
if (window_)
window_->CloseContents(nullptr);
mate::Dictionary options;
if (!(args->Length() == 1 && args->GetNext(&options))) {
options = mate::Dictionary::CreateEmpty(args->isolate());
}
return new Window(args->isolate(), args->GetThis(), options);
}
void Window::Close() {
window_->Close();
}
bool Window::IsClosed() {
return window_->IsClosed();
}
void Window::Focus() {
window_->Focus(true);
}
void Window::Blur() {
window_->Focus(false);
}
bool Window::IsFocused() {
return window_->IsFocused();
}
@@ -230,6 +351,10 @@ void Window::Show() {
}
void Window::ShowInactive() {
// This method doesn't make sense for modal window..
if (IsModal())
return;
window_->ShowInactive();
}
@@ -241,6 +366,10 @@ bool Window::IsVisible() {
return window_->IsVisible();
}
bool Window::IsEnabled() {
return window_->IsEnabled();
}
void Window::Maximize() {
window_->Maximize();
}
@@ -273,16 +402,30 @@ bool Window::IsFullscreen() {
return window_->IsFullscreen();
}
void Window::SetBounds(const gfx::Rect& bounds) {
window_->SetBounds(bounds);
void Window::SetBounds(const gfx::Rect& bounds, mate::Arguments* args) {
bool animate = false;
args->GetNext(&animate);
window_->SetBounds(bounds, animate);
}
gfx::Rect Window::GetBounds() {
return window_->GetBounds();
}
void Window::SetSize(int width, int height) {
window_->SetSize(gfx::Size(width, height));
void Window::SetContentBounds(const gfx::Rect& bounds, mate::Arguments* args) {
bool animate = false;
args->GetNext(&animate);
window_->SetContentBounds(bounds, animate);
}
gfx::Rect Window::GetContentBounds() {
return window_->GetContentBounds();
}
void Window::SetSize(int width, int height, mate::Arguments* args) {
bool animate = false;
args->GetNext(&animate);
window_->SetSize(gfx::Size(width, height), animate);
}
std::vector<int> Window::GetSize() {
@@ -293,8 +436,10 @@ std::vector<int> Window::GetSize() {
return result;
}
void Window::SetContentSize(int width, int height) {
window_->SetContentSize(gfx::Size(width, height));
void Window::SetContentSize(int width, int height, mate::Arguments* args) {
bool animate = false;
args->GetNext(&animate);
window_->SetContentSize(gfx::Size(width, height), animate);
}
std::vector<int> Window::GetContentSize() {
@@ -329,6 +474,12 @@ std::vector<int> Window::GetMaximumSize() {
return result;
}
void Window::SetSheetOffset(double offsetY, mate::Arguments* args) {
double offsetX = 0.0;
args->GetNext(&offsetX);
window_->SetSheetOffset(offsetX, offsetY);
}
void Window::SetResizable(bool resizable) {
window_->SetResizable(resizable);
}
@@ -337,8 +488,59 @@ bool Window::IsResizable() {
return window_->IsResizable();
}
void Window::SetAlwaysOnTop(bool top) {
window_->SetAlwaysOnTop(top);
void Window::SetMovable(bool movable) {
window_->SetMovable(movable);
}
bool Window::IsMovable() {
return window_->IsMovable();
}
void Window::SetMinimizable(bool minimizable) {
window_->SetMinimizable(minimizable);
}
bool Window::IsMinimizable() {
return window_->IsMinimizable();
}
void Window::SetMaximizable(bool maximizable) {
window_->SetMaximizable(maximizable);
}
bool Window::IsMaximizable() {
return window_->IsMaximizable();
}
void Window::SetFullScreenable(bool fullscreenable) {
window_->SetFullScreenable(fullscreenable);
}
bool Window::IsFullScreenable() {
return window_->IsFullScreenable();
}
void Window::SetClosable(bool closable) {
window_->SetClosable(closable);
}
bool Window::IsClosable() {
return window_->IsClosable();
}
void Window::SetAlwaysOnTop(bool top, mate::Arguments* args) {
std::string level = "floating";
int relativeLevel = 0;
std::string error;
args->GetNext(&level);
args->GetNext(&relativeLevel);
window_->SetAlwaysOnTop(top, level, relativeLevel, &error);
if (!error.empty()) {
args->ThrowError(error);
}
}
bool Window::IsAlwaysOnTop() {
@@ -349,8 +551,10 @@ void Window::Center() {
window_->Center();
}
void Window::SetPosition(int x, int y) {
window_->SetPosition(gfx::Point(x, y));
void Window::SetPosition(int x, int y, mate::Arguments* args) {
bool animate = false;
args->GetNext(&animate);
window_->SetPosition(gfx::Point(x, y), animate);
}
std::vector<int> Window::GetPosition() {
@@ -385,6 +589,18 @@ bool Window::IsKiosk() {
return window_->IsKiosk();
}
void Window::SetBackgroundColor(const std::string& color_name) {
window_->SetBackgroundColor(color_name);
}
void Window::SetHasShadow(bool has_shadow) {
window_->SetHasShadow(has_shadow);
}
bool Window::HasShadow() {
return window_->HasShadow();
}
void Window::FocusOnWebView() {
window_->FocusOnWebView();
}
@@ -397,10 +613,6 @@ bool Window::IsWebViewFocused() {
return window_->IsWebViewFocused();
}
bool Window::IsDevToolsFocused() {
return window_->IsDevToolsFocused();
}
void Window::SetRepresentedFilename(const std::string& filename) {
window_->SetRepresentedFilename(filename);
}
@@ -417,23 +629,36 @@ bool Window::IsDocumentEdited() {
return window_->IsDocumentEdited();
}
void Window::CapturePage(mate::Arguments* args) {
gfx::Rect rect;
base::Callback<void(const gfx::Image&)> callback;
if (!(args->Length() == 1 && args->GetNext(&callback)) &&
!(args->Length() == 2 && args->GetNext(&rect)
&& args->GetNext(&callback))) {
args->ThrowError();
return;
}
window_->CapturePage(
rect, base::Bind(&OnCapturePageDone, args->isolate(), callback));
void Window::SetIgnoreMouseEvents(bool ignore) {
return window_->SetIgnoreMouseEvents(ignore);
}
void Window::SetProgressBar(double progress) {
window_->SetProgressBar(progress);
void Window::SetContentProtection(bool enable) {
return window_->SetContentProtection(enable);
}
void Window::SetFocusable(bool focusable) {
return window_->SetFocusable(focusable);
}
void Window::SetProgressBar(double progress, mate::Arguments* args) {
mate::Dictionary options;
std::string mode;
NativeWindow::ProgressState state = NativeWindow::PROGRESS_NORMAL;
args->GetNext(&options) && options.Get("mode", &mode);
if (mode == "error") {
state = NativeWindow::PROGRESS_ERROR;
} else if (mode == "paused") {
state = NativeWindow::PROGRESS_PAUSED;
} else if (mode == "indeterminate") {
state = NativeWindow::PROGRESS_INDETERMINATE;
} else if (mode == "none") {
state = NativeWindow::PROGRESS_NONE;
}
window_->SetProgressBar(progress, state);
}
void Window::SetOverlayIcon(const gfx::Image& overlay,
@@ -450,7 +675,7 @@ bool Window::SetThumbarButtons(mate::Arguments* args) {
}
auto window = static_cast<NativeWindowViews*>(window_.get());
return window->taskbar_host().SetThumbarButtons(
window->GetAcceleratedWidget(), buttons);
window_->GetAcceleratedWidget(), buttons);
#else
return false;
#endif
@@ -488,9 +713,70 @@ bool Window::IsMenuBarVisible() {
return window_->IsMenuBarVisible();
}
#if defined(OS_MACOSX)
void Window::ShowDefinitionForSelection() {
window_->ShowDefinitionForSelection();
#if defined(OS_WIN)
bool Window::HookWindowMessage(UINT message,
const MessageCallback& callback) {
messages_callback_map_[message] = callback;
return true;
}
void Window::UnhookWindowMessage(UINT message) {
if (!ContainsKey(messages_callback_map_, message))
return;
messages_callback_map_.erase(message);
}
bool Window::IsWindowMessageHooked(UINT message) {
return ContainsKey(messages_callback_map_, message);
}
void Window::UnhookAllWindowMessages() {
messages_callback_map_.clear();
}
bool Window::SetThumbnailClip(const gfx::Rect& region) {
auto window = static_cast<NativeWindowViews*>(window_.get());
return window->taskbar_host().SetThumbnailClip(
window_->GetAcceleratedWidget(), region);
}
bool Window::SetThumbnailToolTip(const std::string& tooltip) {
auto window = static_cast<NativeWindowViews*>(window_.get());
return window->taskbar_host().SetThumbnailToolTip(
window_->GetAcceleratedWidget(), tooltip);
}
void Window::SetAppDetails(const mate::Dictionary& options) {
base::string16 app_id;
base::FilePath app_icon_path;
int app_icon_index = 0;
base::string16 relaunch_command;
base::string16 relaunch_display_name;
options.Get("appId", &app_id);
options.Get("appIconPath", &app_icon_path);
options.Get("appIconIndex", &app_icon_index);
options.Get("relaunchCommand", &relaunch_command);
options.Get("relaunchDisplayName", &relaunch_display_name);
ui::win::SetAppDetailsForWindow(
app_id, app_icon_path, app_icon_index,
relaunch_command, relaunch_display_name,
window_->GetAcceleratedWidget());
}
#endif
#if defined(TOOLKIT_VIEWS)
void Window::SetIcon(mate::Handle<NativeImage> icon) {
#if defined(OS_WIN)
static_cast<NativeWindowViews*>(window_.get())->SetIcon(
icon->GetHICON(GetSystemMetrics(SM_CXSMICON)),
icon->GetHICON(GetSystemMetrics(SM_CXICON)));
#elif defined(USE_X11)
static_cast<NativeWindowViews*>(window_.get())->SetIcon(
icon->image().AsImageSkia());
#endif
}
#endif
@@ -500,6 +786,78 @@ void Window::SetAspectRatio(double aspect_ratio, mate::Arguments* args) {
window_->SetAspectRatio(aspect_ratio, extra_size);
}
void Window::PreviewFile(const std::string& path, mate::Arguments* args) {
std::string display_name;
if (!args->GetNext(&display_name))
display_name = path;
window_->PreviewFile(path, display_name);
}
void Window::CloseFilePreview() {
window_->CloseFilePreview();
}
void Window::SetParentWindow(v8::Local<v8::Value> value,
mate::Arguments* args) {
if (IsModal()) {
args->ThrowError("Can not be called for modal window");
return;
}
mate::Handle<Window> parent;
if (value->IsNull()) {
RemoveFromParentChildWindows();
parent_window_.Reset();
window_->SetParentWindow(nullptr);
} else if (mate::ConvertFromV8(isolate(), value, &parent)) {
parent_window_.Reset(isolate(), value);
window_->SetParentWindow(parent->window_.get());
parent->child_windows_.Set(isolate(), ID(), GetWrapper());
} else {
args->ThrowError("Must pass BrowserWindow instance or null");
}
}
v8::Local<v8::Value> Window::GetParentWindow() const {
if (parent_window_.IsEmpty())
return v8::Null(isolate());
else
return v8::Local<v8::Value>::New(isolate(), parent_window_);
}
std::vector<v8::Local<v8::Object>> Window::GetChildWindows() const {
return child_windows_.Values(isolate());
}
v8::Local<v8::Value> Window::GetBrowserView() const {
if (browser_view_.IsEmpty()) {
return v8::Null(isolate());
}
return v8::Local<v8::Value>::New(isolate(), browser_view_);
}
void Window::SetBrowserView(v8::Local<v8::Value> value) {
mate::Handle<BrowserView> browser_view;
if (value->IsNull()) {
window_->SetBrowserView(nullptr);
browser_view_.Reset();
} else if (mate::ConvertFromV8(isolate(), value, &browser_view)) {
window_->SetBrowserView(browser_view->view());
browser_view_.Reset(isolate(), value);
}
}
bool Window::IsModal() const {
return window_->is_modal();
}
v8::Local<v8::Value> Window::GetNativeWindowHandle() {
gfx::AcceleratedWidget handle = window_->GetAcceleratedWidget();
return ToBuffer(
isolate(), static_cast<void*>(&handle), sizeof(gfx::AcceleratedWidget));
}
void Window::SetVisibleOnAllWorkspaces(bool visible) {
return window_->SetVisibleOnAllWorkspaces(visible);
}
@@ -508,30 +866,67 @@ bool Window::IsVisibleOnAllWorkspaces() {
return window_->IsVisibleOnAllWorkspaces();
}
void Window::SetAutoHideCursor(bool auto_hide) {
window_->SetAutoHideCursor(auto_hide);
}
void Window::SetVibrancy(mate::Arguments* args) {
std::string type;
args->GetNext(&type);
window_->SetVibrancy(type);
}
void Window::SetTouchBar(const std::vector<mate::PersistentDictionary>& items) {
window_->SetTouchBar(items);
}
void Window::RefreshTouchBarItem(const std::string& item_id) {
window_->RefreshTouchBarItem(item_id);
}
void Window::SetEscapeTouchBarItem(const mate::PersistentDictionary& item) {
window_->SetEscapeTouchBarItem(item);
}
int32_t Window::ID() const {
return weak_map_id();
}
v8::Local<v8::Value> Window::WebContents(v8::Isolate* isolate) {
if (web_contents_.IsEmpty())
if (web_contents_.IsEmpty()) {
return v8::Null(isolate);
else
return v8::Local<v8::Value>::New(isolate, web_contents_);
}
return v8::Local<v8::Value>::New(isolate, web_contents_);
}
void Window::RemoveFromParentChildWindows() {
if (parent_window_.IsEmpty())
return;
mate::Handle<Window> parent;
if (!mate::ConvertFromV8(isolate(), GetParentWindow(), &parent))
return;
parent->child_windows_.Remove(ID());
}
// static
void Window::BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype) {
mate::ObjectTemplateBuilder(isolate, prototype)
.SetMethod("destroy", &Window::Destroy, true)
v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "BrowserWindow"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.MakeDestroyable()
.SetMethod("close", &Window::Close)
.SetMethod("isClosed", &Window::IsClosed)
.SetMethod("focus", &Window::Focus)
.SetMethod("blur", &Window::Blur)
.SetMethod("isFocused", &Window::IsFocused)
.SetMethod("show", &Window::Show)
.SetMethod("showInactive", &Window::ShowInactive)
.SetMethod("hide", &Window::Hide)
.SetMethod("isVisible", &Window::IsVisible)
.SetMethod("isEnabled", &Window::IsEnabled)
.SetMethod("maximize", &Window::Maximize)
.SetMethod("unmaximize", &Window::Unmaximize)
.SetMethod("isMaximized", &Window::IsMaximized)
@@ -541,18 +936,42 @@ void Window::BuildPrototype(v8::Isolate* isolate,
.SetMethod("setFullScreen", &Window::SetFullScreen)
.SetMethod("isFullScreen", &Window::IsFullscreen)
.SetMethod("setAspectRatio", &Window::SetAspectRatio)
.SetMethod("previewFile", &Window::PreviewFile)
.SetMethod("closeFilePreview", &Window::CloseFilePreview)
#if !defined(OS_WIN)
.SetMethod("setParentWindow", &Window::SetParentWindow)
#endif
.SetMethod("getParentWindow", &Window::GetParentWindow)
.SetMethod("getChildWindows", &Window::GetChildWindows)
.SetMethod("getBrowserView", &Window::GetBrowserView)
.SetMethod("setBrowserView", &Window::SetBrowserView)
.SetMethod("isModal", &Window::IsModal)
.SetMethod("getNativeWindowHandle", &Window::GetNativeWindowHandle)
.SetMethod("getBounds", &Window::GetBounds)
.SetMethod("setBounds", &Window::SetBounds)
.SetMethod("getSize", &Window::GetSize)
.SetMethod("setSize", &Window::SetSize)
.SetMethod("getContentBounds", &Window::GetContentBounds)
.SetMethod("setContentBounds", &Window::SetContentBounds)
.SetMethod("getContentSize", &Window::GetContentSize)
.SetMethod("setContentSize", &Window::SetContentSize)
.SetMethod("setMinimumSize", &Window::SetMinimumSize)
.SetMethod("getMinimumSize", &Window::GetMinimumSize)
.SetMethod("setMaximumSize", &Window::SetMaximumSize)
.SetMethod("getMaximumSize", &Window::GetMaximumSize)
.SetMethod("setSheetOffset", &Window::SetSheetOffset)
.SetMethod("setResizable", &Window::SetResizable)
.SetMethod("isResizable", &Window::IsResizable)
.SetMethod("setMovable", &Window::SetMovable)
.SetMethod("isMovable", &Window::IsMovable)
.SetMethod("setMinimizable", &Window::SetMinimizable)
.SetMethod("isMinimizable", &Window::IsMinimizable)
.SetMethod("setMaximizable", &Window::SetMaximizable)
.SetMethod("isMaximizable", &Window::IsMaximizable)
.SetMethod("setFullScreenable", &Window::SetFullScreenable)
.SetMethod("isFullScreenable", &Window::IsFullScreenable)
.SetMethod("setClosable", &Window::SetClosable)
.SetMethod("isClosable", &Window::IsClosable)
.SetMethod("setAlwaysOnTop", &Window::SetAlwaysOnTop)
.SetMethod("isAlwaysOnTop", &Window::IsAlwaysOnTop)
.SetMethod("center", &Window::Center)
@@ -564,15 +983,19 @@ void Window::BuildPrototype(v8::Isolate* isolate,
.SetMethod("setSkipTaskbar", &Window::SetSkipTaskbar)
.SetMethod("setKiosk", &Window::SetKiosk)
.SetMethod("isKiosk", &Window::IsKiosk)
.SetMethod("setBackgroundColor", &Window::SetBackgroundColor)
.SetMethod("setHasShadow", &Window::SetHasShadow)
.SetMethod("hasShadow", &Window::HasShadow)
.SetMethod("setRepresentedFilename", &Window::SetRepresentedFilename)
.SetMethod("getRepresentedFilename", &Window::GetRepresentedFilename)
.SetMethod("setDocumentEdited", &Window::SetDocumentEdited)
.SetMethod("isDocumentEdited", &Window::IsDocumentEdited)
.SetMethod("setIgnoreMouseEvents", &Window::SetIgnoreMouseEvents)
.SetMethod("setContentProtection", &Window::SetContentProtection)
.SetMethod("setFocusable", &Window::SetFocusable)
.SetMethod("focusOnWebView", &Window::FocusOnWebView)
.SetMethod("blurWebView", &Window::BlurWebView)
.SetMethod("isWebViewFocused", &Window::IsWebViewFocused)
.SetMethod("isDevToolsFocused", &Window::IsDevToolsFocused)
.SetMethod("capturePage", &Window::CapturePage)
.SetMethod("setProgressBar", &Window::SetProgressBar)
.SetMethod("setOverlayIcon", &Window::SetOverlayIcon)
.SetMethod("setThumbarButtons", &Window::SetThumbarButtons)
@@ -586,11 +1009,26 @@ void Window::BuildPrototype(v8::Isolate* isolate,
.SetMethod("isVisibleOnAllWorkspaces",
&Window::IsVisibleOnAllWorkspaces)
#if defined(OS_MACOSX)
.SetMethod("showDefinitionForSelection",
&Window::ShowDefinitionForSelection)
.SetMethod("setAutoHideCursor", &Window::SetAutoHideCursor)
#endif
.SetProperty("id", &Window::ID, true)
.SetProperty("webContents", &Window::WebContents, true);
.SetMethod("setVibrancy", &Window::SetVibrancy)
.SetMethod("_setTouchBarItems", &Window::SetTouchBar)
.SetMethod("_refreshTouchBarItem", &Window::RefreshTouchBarItem)
.SetMethod("_setEscapeTouchBarItem", &Window::SetEscapeTouchBarItem)
#if defined(OS_WIN)
.SetMethod("hookWindowMessage", &Window::HookWindowMessage)
.SetMethod("isWindowMessageHooked", &Window::IsWindowMessageHooked)
.SetMethod("unhookWindowMessage", &Window::UnhookWindowMessage)
.SetMethod("unhookAllWindowMessages", &Window::UnhookAllWindowMessages)
.SetMethod("setThumbnailClip", &Window::SetThumbnailClip)
.SetMethod("setThumbnailToolTip", &Window::SetThumbnailToolTip)
.SetMethod("setAppDetails", &Window::SetAppDetails)
#endif
#if defined(TOOLKIT_VIEWS)
.SetMethod("setIcon", &Window::SetIcon)
#endif
.SetProperty("id", &Window::ID)
.SetProperty("webContents", &Window::WebContents);
}
// static
@@ -598,7 +1036,7 @@ v8::Local<v8::Value> Window::From(v8::Isolate* isolate,
NativeWindow* native_window) {
auto existing = TrackableObject::FromWrappedClass(isolate, native_window);
if (existing)
return existing->GetWrapper(isolate);
return existing->GetWrapper();
else
return v8::Null(isolate);
}
@@ -615,9 +1053,10 @@ using atom::api::Window;
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) {
v8::Isolate* isolate = context->GetIsolate();
v8::Local<v8::Function> constructor = mate::CreateConstructor<Window>(
isolate, "BrowserWindow", base::Bind(&Window::New));
mate::Dictionary browser_window(isolate, constructor);
Window::SetConstructor(isolate, base::Bind(&Window::New));
mate::Dictionary browser_window(
isolate, Window::GetConstructor(isolate)->GetFunction());
browser_window.SetMethod("fromId",
&mate::TrackableObject<Window>::FromWeakMapID);
browser_window.SetMethod("getAllWindows",

View File

@@ -5,15 +5,19 @@
#ifndef ATOM_BROWSER_API_ATOM_API_WINDOW_H_
#define ATOM_BROWSER_API_ATOM_API_WINDOW_H_
#include <map>
#include <memory>
#include <string>
#include <vector>
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/image/image.h"
#include "atom/browser/api/trackable_object.h"
#include "atom/browser/native_window.h"
#include "atom/browser/native_window_observer.h"
#include "atom/common/api/atom_api_native_image.h"
#include "atom/common/key_weak_map.h"
#include "native_mate/handle.h"
#include "native_mate/persistent_dictionary.h"
#include "ui/gfx/image/image.h"
class GURL;
@@ -37,11 +41,10 @@ class WebContents;
class Window : public mate::TrackableObject<Window>,
public NativeWindowObserver {
public:
static mate::Wrappable* New(v8::Isolate* isolate,
const mate::Dictionary& options);
static mate::WrappableBase* New(mate::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> prototype);
v8::Local<v8::FunctionTemplate> prototype);
// Returns the BrowserWindow object from |native_window|.
static v8::Local<v8::Value> From(v8::Isolate* isolate,
@@ -49,17 +52,23 @@ class Window : public mate::TrackableObject<Window>,
NativeWindow* window() const { return window_.get(); }
int32_t ID() const;
protected:
Window(v8::Isolate* isolate, const mate::Dictionary& options);
virtual ~Window();
Window(v8::Isolate* isolate, v8::Local<v8::Object> wrapper,
const mate::Dictionary& options);
~Window() override;
// NativeWindowObserver:
void OnPageTitleUpdated(bool* prevent_default,
const std::string& title) override;
void WillCloseWindow(bool* prevent_default) override;
void WillDestroyNativeObject() override;
void OnWindowClosed() override;
void OnWindowEndSession() override;
void OnWindowBlur() override;
void OnWindowFocus() override;
void OnWindowShow() override;
void OnWindowHide() override;
void OnReadyToShow() override;
void OnWindowMaximize() override;
void OnWindowUnmaximize() override;
void OnWindowMinimize() override;
@@ -67,6 +76,12 @@ class Window : public mate::TrackableObject<Window>,
void OnWindowResize() override;
void OnWindowMove() override;
void OnWindowMoved() override;
void OnWindowScrollTouchBegin() override;
void OnWindowScrollTouchEnd() override;
void OnWindowScrollTouchEdge() override;
void OnWindowSwipe(const std::string& direction) override;
void OnWindowSheetBegin() override;
void OnWindowSheetEnd() override;
void OnWindowEnterFullScreen() override;
void OnWindowLeaveFullScreen() override;
void OnWindowEnterHtmlFullScreen() override;
@@ -74,23 +89,28 @@ class Window : public mate::TrackableObject<Window>,
void OnRendererUnresponsive() override;
void OnRendererResponsive() override;
void OnExecuteWindowsCommand(const std::string& command_name) override;
void OnTouchBarItemResult(const std::string& item_id,
const base::DictionaryValue& details) override;
// mate::Wrappable:
bool IsDestroyed() const override;
#if defined(OS_WIN)
void OnWindowMessage(UINT message, WPARAM w_param, LPARAM l_param) override;
#endif
private:
// mate::TrackableObject:
void Destroy() override;
void Init(v8::Isolate* isolate,
v8::Local<v8::Object> wrapper,
const mate::Dictionary& options,
mate::Handle<class WebContents> web_contents);
// APIs for NativeWindow.
void Close();
bool IsClosed();
void Focus();
void Blur();
bool IsFocused();
void Show();
void ShowInactive();
void Hide();
bool IsVisible();
bool IsEnabled();
void Maximize();
void Unmaximize();
bool IsMaximized();
@@ -99,22 +119,35 @@ class Window : public mate::TrackableObject<Window>,
bool IsMinimized();
void SetFullScreen(bool fullscreen);
bool IsFullscreen();
void SetBounds(const gfx::Rect& bounds);
void SetBounds(const gfx::Rect& bounds, mate::Arguments* args);
gfx::Rect GetBounds();
void SetSize(int width, int height);
void SetSize(int width, int height, mate::Arguments* args);
std::vector<int> GetSize();
void SetContentSize(int width, int height);
void SetContentSize(int width, int height, mate::Arguments* args);
std::vector<int> GetContentSize();
void SetContentBounds(const gfx::Rect& bounds, mate::Arguments* args);
gfx::Rect GetContentBounds();
void SetMinimumSize(int width, int height);
std::vector<int> GetMinimumSize();
void SetMaximumSize(int width, int height);
std::vector<int> GetMaximumSize();
void SetSheetOffset(double offsetY, mate::Arguments* args);
void SetResizable(bool resizable);
bool IsResizable();
void SetAlwaysOnTop(bool top);
void SetMovable(bool movable);
bool IsMovable();
void SetMinimizable(bool minimizable);
bool IsMinimizable();
void SetMaximizable(bool maximizable);
bool IsMaximizable();
void SetFullScreenable(bool fullscreenable);
bool IsFullScreenable();
void SetClosable(bool closable);
bool IsClosable();
void SetAlwaysOnTop(bool top, mate::Arguments* args);
bool IsAlwaysOnTop();
void Center();
void SetPosition(int x, int y);
void SetPosition(int x, int y, mate::Arguments* args);
std::vector<int> GetPosition();
void SetTitle(const std::string& title);
std::string GetTitle();
@@ -122,16 +155,20 @@ class Window : public mate::TrackableObject<Window>,
void SetSkipTaskbar(bool skip);
void SetKiosk(bool kiosk);
bool IsKiosk();
void SetBackgroundColor(const std::string& color_name);
void SetHasShadow(bool has_shadow);
bool HasShadow();
void FocusOnWebView();
void BlurWebView();
bool IsWebViewFocused();
bool IsDevToolsFocused();
void SetRepresentedFilename(const std::string& filename);
std::string GetRepresentedFilename();
void SetDocumentEdited(bool edited);
bool IsDocumentEdited();
void CapturePage(mate::Arguments* args);
void SetProgressBar(double progress);
void SetIgnoreMouseEvents(bool ignore);
void SetContentProtection(bool enable);
void SetFocusable(bool focusable);
void SetProgressBar(double progress, mate::Arguments* args);
void SetOverlayIcon(const gfx::Image& overlay,
const std::string& description);
bool SetThumbarButtons(mate::Arguments* args);
@@ -141,23 +178,62 @@ class Window : public mate::TrackableObject<Window>,
void SetMenuBarVisibility(bool visible);
bool IsMenuBarVisible();
void SetAspectRatio(double aspect_ratio, mate::Arguments* args);
void PreviewFile(const std::string& path, mate::Arguments* args);
void CloseFilePreview();
void SetParentWindow(v8::Local<v8::Value> value, mate::Arguments* args);
v8::Local<v8::Value> GetParentWindow() const;
std::vector<v8::Local<v8::Object>> GetChildWindows() const;
v8::Local<v8::Value> GetBrowserView() const;
void SetBrowserView(v8::Local<v8::Value> value);
bool IsModal() const;
v8::Local<v8::Value> GetNativeWindowHandle();
#if defined(OS_MACOSX)
void ShowDefinitionForSelection();
#if defined(OS_WIN)
typedef base::Callback<void(v8::Local<v8::Value>,
v8::Local<v8::Value>)> MessageCallback;
bool HookWindowMessage(UINT message, const MessageCallback& callback);
bool IsWindowMessageHooked(UINT message);
void UnhookWindowMessage(UINT message);
void UnhookAllWindowMessages();
bool SetThumbnailClip(const gfx::Rect& region);
bool SetThumbnailToolTip(const std::string& tooltip);
void SetAppDetails(const mate::Dictionary& options);
#endif
#if defined(TOOLKIT_VIEWS)
void SetIcon(mate::Handle<NativeImage> icon);
#endif
void SetVisibleOnAllWorkspaces(bool visible);
bool IsVisibleOnAllWorkspaces();
int32_t ID() const;
void SetAutoHideCursor(bool auto_hide);
void SetVibrancy(mate::Arguments* args);
void SetTouchBar(const std::vector<mate::PersistentDictionary>& items);
void RefreshTouchBarItem(const std::string& item_id);
void SetEscapeTouchBarItem(const mate::PersistentDictionary& item);
v8::Local<v8::Value> WebContents(v8::Isolate* isolate);
// Remove this window from parent window's |child_windows_|.
void RemoveFromParentChildWindows();
#if defined(OS_WIN)
typedef std::map<UINT, MessageCallback> MessageCallbackMap;
MessageCallbackMap messages_callback_map_;
#endif
v8::Global<v8::Value> browser_view_;
v8::Global<v8::Value> web_contents_;
v8::Global<v8::Value> menu_;
v8::Global<v8::Value> parent_window_;
KeyWeakMap<int> child_windows_;
api::WebContents* api_web_contents_;
scoped_ptr<NativeWindow> window_;
std::unique_ptr<NativeWindow> window_;
DISALLOW_COPY_AND_ASSIGN(Window);
};

View File

@@ -11,31 +11,15 @@
namespace mate {
namespace {
v8::Persistent<v8::ObjectTemplate> template_;
} // namespace
Event::Event()
: sender_(NULL),
message_(NULL) {
Event::Event(v8::Isolate* isolate)
: sender_(nullptr),
message_(nullptr) {
Init(isolate);
}
Event::~Event() {
}
ObjectTemplateBuilder Event::GetObjectTemplateBuilder(v8::Isolate* isolate) {
if (template_.IsEmpty())
template_.Reset(isolate, ObjectTemplateBuilder(isolate)
.SetMethod("preventDefault", &Event::PreventDefault)
.SetMethod("sendReply", &Event::SendReply)
.Build());
return ObjectTemplateBuilder(
isolate, v8::Local<v8::ObjectTemplate>::New(isolate, template_));
}
void Event::SetSenderAndMessage(content::WebContents* sender,
IPC::Message* message) {
DCHECK(!sender_);
@@ -47,26 +31,38 @@ void Event::SetSenderAndMessage(content::WebContents* sender,
}
void Event::WebContentsDestroyed() {
sender_ = NULL;
message_ = NULL;
sender_ = nullptr;
message_ = nullptr;
}
void Event::PreventDefault(v8::Isolate* isolate) {
GetWrapper(isolate)->Set(StringToV8(isolate, "defaultPrevented"),
GetWrapper()->Set(StringToV8(isolate, "defaultPrevented"),
v8::True(isolate));
}
bool Event::SendReply(const base::string16& json) {
if (message_ == NULL || sender_ == NULL)
if (message_ == nullptr || sender_ == nullptr)
return false;
AtomViewHostMsg_Message_Sync::WriteReplyParams(message_, json);
return sender_->Send(message_);
bool success = sender_->Send(message_);
message_ = nullptr;
sender_ = nullptr;
return success;
}
// static
Handle<Event> Event::Create(v8::Isolate* isolate) {
return CreateHandle(isolate, new Event);
return mate::CreateHandle(isolate, new Event(isolate));
}
// static
void Event::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::FunctionTemplate> prototype) {
prototype->SetClassName(mate::StringToV8(isolate, "Event"));
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
.SetMethod("preventDefault", &Event::PreventDefault)
.SetMethod("sendReply", &Event::SendReply);
}
} // namespace mate

View File

@@ -6,8 +6,8 @@
#define ATOM_BROWSER_API_EVENT_H_
#include "content/public/browser/web_contents_observer.h"
#include "native_mate/wrappable.h"
#include "native_mate/handle.h"
#include "native_mate/wrappable.h"
namespace IPC {
class Message;
@@ -15,11 +15,14 @@ class Message;
namespace mate {
class Event : public Wrappable,
class Event : public Wrappable<Event>,
public content::WebContentsObserver {
public:
static Handle<Event> Create(v8::Isolate* isolate);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
// Pass the sender and message to be replied.
void SetSenderAndMessage(content::WebContents* sender, IPC::Message* message);
@@ -30,11 +33,8 @@ class Event : public Wrappable,
bool SendReply(const base::string16& json);
protected:
Event();
virtual ~Event();
// Wrappable implementations:
ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate) override;
explicit Event(v8::Isolate* isolate);
~Event() override;
// content::WebContentsObserver implementations:
void WebContentsDestroyed() override;

View File

@@ -8,6 +8,9 @@
#include "native_mate/arguments.h"
#include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h"
#include "ui/events/event_constants.h"
#include "atom/common/node_includes.h"
namespace mate {
@@ -34,11 +37,13 @@ v8::Local<v8::Object> CreateEventObject(v8::Isolate* isolate) {
} // namespace
EventEmitter::EventEmitter() {
}
namespace internal {
v8::Local<v8::Object> EventEmitter::CreateJSEvent(
v8::Isolate* isolate, content::WebContents* sender, IPC::Message* message) {
v8::Local<v8::Object> CreateJSEvent(
v8::Isolate* isolate,
v8::Local<v8::Object> object,
content::WebContents* sender,
IPC::Message* message) {
v8::Local<v8::Object> event;
bool use_native_event = sender && message;
@@ -49,16 +54,29 @@ v8::Local<v8::Object> EventEmitter::CreateJSEvent(
} else {
event = CreateEventObject(isolate);
}
mate::Dictionary(isolate, event).Set("sender", GetWrapper(isolate));
mate::Dictionary(isolate, event).Set("sender", object);
return event;
}
v8::Local<v8::Object> EventEmitter::CreateCustomEvent(
v8::Isolate* isolate, v8::Local<v8::Object> custom_event) {
v8::Local<v8::Object> CreateCustomEvent(
v8::Isolate* isolate,
v8::Local<v8::Object> object,
v8::Local<v8::Object> custom_event) {
v8::Local<v8::Object> event = CreateEventObject(isolate);
(void)event->SetPrototype(custom_event->CreationContext(), custom_event);
mate::Dictionary(isolate, event).Set("sender", GetWrapper(isolate));
mate::Dictionary(isolate, event).Set("sender", object);
return event;
}
v8::Local<v8::Object> CreateEventFromFlags(v8::Isolate* isolate, int flags) {
mate::Dictionary obj = mate::Dictionary::CreateEmpty(isolate);
obj.Set("shiftKey", static_cast<bool>(flags & ui::EF_SHIFT_DOWN));
obj.Set("ctrlKey", static_cast<bool>(flags & ui::EF_CONTROL_DOWN));
obj.Set("altKey", static_cast<bool>(flags & ui::EF_ALT_DOWN));
obj.Set("metaKey", static_cast<bool>(flags & ui::EF_COMMAND_DOWN));
return obj.GetHandle();
}
} // namespace internal
} // namespace mate

View File

@@ -20,17 +20,49 @@ class Message;
namespace mate {
namespace internal {
v8::Local<v8::Object> CreateJSEvent(v8::Isolate* isolate,
v8::Local<v8::Object> object,
content::WebContents* sender,
IPC::Message* message);
v8::Local<v8::Object> CreateCustomEvent(
v8::Isolate* isolate,
v8::Local<v8::Object> object,
v8::Local<v8::Object> event);
v8::Local<v8::Object> CreateEventFromFlags(v8::Isolate* isolate, int flags);
} // namespace internal
// Provide helperers to emit event in JavaScript.
class EventEmitter : public Wrappable {
template<typename T>
class EventEmitter : public Wrappable<T> {
public:
typedef std::vector<v8::Local<v8::Value>> ValueArray;
// Make the convinient methods visible:
// https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members
v8::Local<v8::Object> GetWrapper() { return Wrappable<T>::GetWrapper(); }
v8::Isolate* isolate() const { return Wrappable<T>::isolate(); }
// this.emit(name, event, args...);
template<typename... Args>
bool EmitCustomEvent(const base::StringPiece& name,
v8::Local<v8::Object> event,
const Args&... args) {
return EmitWithEvent(name, CreateCustomEvent(isolate(), event), args...);
return EmitWithEvent(
name,
internal::CreateCustomEvent(isolate(), GetWrapper(), event), args...);
}
// this.emit(name, new Event(flags), args...);
template<typename... Args>
bool EmitWithFlags(const base::StringPiece& name,
int flags,
const Args&... args) {
return EmitCustomEvent(
name,
internal::CreateEventFromFlags(isolate(), flags), args...);
}
// this.emit(name, new Event(), args...);
@@ -47,12 +79,13 @@ class EventEmitter : public Wrappable {
const Args&... args) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Object> event = CreateJSEvent(isolate(), sender, message);
v8::Local<v8::Object> event = internal::CreateJSEvent(
isolate(), GetWrapper(), sender, message);
return EmitWithEvent(name, event, args...);
}
protected:
EventEmitter();
EventEmitter() {}
private:
// this.emit(name, event, args...);
@@ -62,17 +95,11 @@ class EventEmitter : public Wrappable {
const Args&... args) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitEvent(isolate(), GetWrapper(isolate()), name, event, args...);
EmitEvent(isolate(), GetWrapper(), name, event, args...);
return event->Get(
StringToV8(isolate(), "defaultPrevented"))->BooleanValue();
}
v8::Local<v8::Object> CreateJSEvent(v8::Isolate* isolate,
content::WebContents* sender,
IPC::Message* message);
v8::Local<v8::Object> CreateCustomEvent(
v8::Isolate* isolate, v8::Local<v8::Object> event);
DISALLOW_COPY_AND_ASSIGN(EventEmitter);
};

View File

@@ -4,61 +4,90 @@
#include "atom/browser/api/frame_subscriber.h"
#include "atom/common/node_includes.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
#include "base/bind.h"
#include "media/base/video_frame.h"
#include "media/base/yuv_convert.h"
#include "content/public/browser/render_widget_host.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
#include "atom/common/node_includes.h"
namespace atom {
namespace api {
FrameSubscriber::FrameSubscriber(v8::Isolate* isolate,
const gfx::Size& size,
const FrameCaptureCallback& callback)
: isolate_(isolate), size_(size), callback_(callback) {
content::RenderWidgetHostView* view,
const FrameCaptureCallback& callback,
bool only_dirty)
: isolate_(isolate),
view_(view),
callback_(callback),
only_dirty_(only_dirty),
weak_factory_(this) {
}
bool FrameSubscriber::ShouldCaptureFrame(
const gfx::Rect& damage_rect,
const gfx::Rect& dirty_rect,
base::TimeTicks present_time,
scoped_refptr<media::VideoFrame>* storage,
DeliverFrameCallback* callback) {
*storage = media::VideoFrame::CreateFrame(media::VideoFrame::YV12, size_,
gfx::Rect(size_), size_,
base::TimeDelta());
*callback = base::Bind(&FrameSubscriber::OnFrameDelivered,
base::Unretained(this),
*storage);
return true;
const auto host = view_ ? view_->GetRenderWidgetHost() : nullptr;
if (!view_ || !host)
return false;
if (dirty_rect.IsEmpty())
return false;
gfx::Rect rect = gfx::Rect(view_->GetVisibleViewportSize());
if (only_dirty_)
rect = dirty_rect;
gfx::Size view_size = rect.size();
gfx::Size bitmap_size = view_size;
const gfx::NativeView native_view = view_->GetNativeView();
const float scale =
display::Screen::GetScreen()->GetDisplayNearestWindow(native_view)
.device_scale_factor();
if (scale > 1.0f)
bitmap_size = gfx::ScaleToCeiledSize(view_size, scale);
rect = gfx::Rect(rect.origin(), bitmap_size);
host->CopyFromBackingStore(
rect,
rect.size(),
base::Bind(&FrameSubscriber::OnFrameDelivered,
weak_factory_.GetWeakPtr(), callback_, rect),
kBGRA_8888_SkColorType);
return false;
}
void FrameSubscriber::OnFrameDelivered(
scoped_refptr<media::VideoFrame> frame, base::TimeTicks, bool result) {
if (!result)
void FrameSubscriber::OnFrameDelivered(const FrameCaptureCallback& callback,
const gfx::Rect& damage_rect,
const SkBitmap& bitmap,
content::ReadbackResponse response) {
if (response != content::ReadbackResponse::READBACK_SUCCESS)
return;
gfx::Rect rect = frame->visible_rect();
size_t rgb_arr_size = rect.width() * rect.height() * 4;
v8::Locker locker(isolate_);
v8::HandleScope handle_scope(isolate_);
size_t rgb_arr_size = bitmap.width() * bitmap.height() *
bitmap.bytesPerPixel();
v8::MaybeLocal<v8::Object> buffer = node::Buffer::New(isolate_, rgb_arr_size);
if (buffer.IsEmpty())
return;
// Convert a frame of YUV to 32 bit ARGB.
media::ConvertYUVToRGB32(frame->data(media::VideoFrame::kYPlane),
frame->data(media::VideoFrame::kUPlane),
frame->data(media::VideoFrame::kVPlane),
reinterpret_cast<uint8*>(
node::Buffer::Data(buffer.ToLocalChecked())),
rect.width(), rect.height(),
frame->stride(media::VideoFrame::kYPlane),
frame->stride(media::VideoFrame::kUVPlane),
rect.width() * 4,
media::YV12);
bitmap.copyPixelsTo(
reinterpret_cast<uint8_t*>(node::Buffer::Data(buffer.ToLocalChecked())),
rgb_arr_size);
v8::Locker locker(isolate_);
v8::HandleScope handle_scope(isolate_);
callback_.Run(buffer.ToLocalChecked());
v8::Local<v8::Value> damage =
mate::Converter<gfx::Rect>::ToV8(isolate_, damage_rect);
callback_.Run(buffer.ToLocalChecked(), damage);
}
} // namespace api

View File

@@ -6,7 +6,11 @@
#define ATOM_BROWSER_API_FRAME_SUBSCRIBER_H_
#include "base/callback.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/readback_types.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/render_widget_host_view_frame_subscriber.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/geometry/size.h"
#include "v8/include/v8.h"
@@ -16,11 +20,13 @@ namespace api {
class FrameSubscriber : public content::RenderWidgetHostViewFrameSubscriber {
public:
using FrameCaptureCallback = base::Callback<void(v8::Local<v8::Value>)>;
using FrameCaptureCallback =
base::Callback<void(v8::Local<v8::Value>, v8::Local<v8::Value>)>;
FrameSubscriber(v8::Isolate* isolate,
const gfx::Size& size,
const FrameCaptureCallback& callback);
content::RenderWidgetHostView* view,
const FrameCaptureCallback& callback,
bool only_dirty);
bool ShouldCaptureFrame(const gfx::Rect& damage_rect,
base::TimeTicks present_time,
@@ -28,12 +34,17 @@ class FrameSubscriber : public content::RenderWidgetHostViewFrameSubscriber {
DeliverFrameCallback* callback) override;
private:
void OnFrameDelivered(
scoped_refptr<media::VideoFrame> frame, base::TimeTicks, bool);
void OnFrameDelivered(const FrameCaptureCallback& callback,
const gfx::Rect& damage_rect,
const SkBitmap& bitmap,
content::ReadbackResponse response);
v8::Isolate* isolate_;
gfx::Size size_;
content::RenderWidgetHostView* view_;
FrameCaptureCallback callback_;
bool only_dirty_;
base::WeakPtrFactory<FrameSubscriber> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(FrameSubscriber);
};

View File

@@ -1,68 +0,0 @@
EventEmitter = require('events').EventEmitter
bindings = process.atomBinding 'app'
sessionBindings = process.atomBinding 'session'
downloadItemBindings = process.atomBinding 'download_item'
app = bindings.app
app.__proto__ = EventEmitter.prototype
wrapSession = (session) ->
# session is an Event Emitter.
session.__proto__ = EventEmitter.prototype
wrapDownloadItem = (download_item) ->
# download_item is an Event Emitter.
download_item.__proto__ = EventEmitter.prototype
# Be compatible with old APIs.
download_item.url = download_item.getUrl()
download_item.filename = download_item.getFilename()
download_item.mimeType = download_item.getMimeType()
download_item.hasUserGesture = download_item.hasUserGesture()
app.setApplicationMenu = (menu) ->
require('menu').setApplicationMenu menu
app.getApplicationMenu = ->
require('menu').getApplicationMenu()
app.commandLine =
appendSwitch: bindings.appendSwitch,
appendArgument: bindings.appendArgument
if process.platform is 'darwin'
app.dock =
bounce: (type='informational') -> bindings.dockBounce type
cancelBounce: bindings.dockCancelBounce
setBadge: bindings.dockSetBadgeText
getBadge: bindings.dockGetBadgeText
hide: bindings.dockHide
show: bindings.dockShow
setMenu: bindings.dockSetMenu
appPath = null
app.setAppPath = (path) ->
appPath = path
app.getAppPath = ->
appPath
# Be compatible with old API.
app.once 'ready', -> @emit 'finish-launching'
app.terminate = app.quit
app.exit = process.exit
app.getHomeDir = -> @getPath 'home'
app.getDataPath = -> @getPath 'userData'
app.setDataPath = (path) -> @setPath 'userData', path
app.resolveProxy = -> @defaultSession.resolveProxy.apply @defaultSession, arguments
app.on 'activate', (event, hasVisibleWindows) -> @emit 'activate-with-no-open-windows' if not hasVisibleWindows
# Session wrapper.
sessionBindings._setWrapSession wrapSession
process.once 'exit', sessionBindings._clearWrapSession
downloadItemBindings._setWrapDownloadItem wrapDownloadItem
process.once 'exit', downloadItemBindings._clearWrapDownloadItem
# Only one App object pemitted.
module.exports = app

View File

@@ -1,6 +0,0 @@
module.exports =
browserMainParts:
preMainMessageLoopRun: ->
setImmediate ->
module.exports.browserMainParts.preMainMessageLoopRun()

View File

@@ -1,24 +0,0 @@
autoUpdater = process.atomBinding('auto_updater').autoUpdater
EventEmitter = require('events').EventEmitter
autoUpdater.__proto__ = EventEmitter.prototype
autoUpdater.on 'update-downloaded-raw', (args...) ->
args[3] = new Date(args[3]) # releaseDate
@emit 'update-downloaded', args..., => @quitAndInstall()
autoUpdater.quitAndInstall = ->
# If we don't have any window then quitAndInstall immediately.
BrowserWindow = require 'browser-window'
windows = BrowserWindow.getAllWindows()
if windows.length is 0
@_quitAndInstall()
return
# Do the restart after all windows have been closed.
app = require 'app'
app.removeAllListeners 'window-all-closed'
app.once 'window-all-closed', @_quitAndInstall.bind(this)
win.close() for win in windows
module.exports = autoUpdater

View File

@@ -1,102 +0,0 @@
EventEmitter = require('events').EventEmitter
app = require 'app'
ipc = require 'ipc'
BrowserWindow = process.atomBinding('window').BrowserWindow
BrowserWindow::__proto__ = EventEmitter.prototype
BrowserWindow::_init = ->
# Simulate the application menu on platforms other than OS X.
if process.platform isnt 'darwin'
menu = app.getApplicationMenu()
@setMenu menu if menu?
# Make new windows requested by links behave like "window.open"
@webContents.on '-new-window', (event, url, frameName) ->
options = show: true, width: 800, height: 600
ipc.emit 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', event, url, frameName, options
# window.resizeTo(...)
# window.moveTo(...)
@webContents.on 'move', (event, size) =>
@setBounds size
# Hide the auto-hide menu when webContents is focused.
@webContents.on 'activate', =>
if process.platform isnt 'darwin' and @isMenuBarAutoHide() and @isMenuBarVisible()
@setMenuBarVisibility false
# Forward the crashed event.
@webContents.on 'crashed', =>
@emit 'crashed'
# Sometimes the webContents doesn't get focus when window is shown, so we have
# to force focusing on webContents in this case. The safest way is to focus it
# when we first start to load URL, if we do it earlier it won't have effect,
# if we do it later we might move focus in the page.
# Though this hack is only needed on OS X when the app is launched from
# Finder, we still do it on all platforms in case of other bugs we don't know.
@webContents.once 'load-url', ->
@focus()
# Redirect focus/blur event to app instance too.
@on 'blur', (event) =>
app.emit 'browser-window-blur', event, this
@on 'focus', (event) =>
app.emit 'browser-window-focus', event, this
# Notify the creation of the window.
app.emit 'browser-window-created', {}, this
# Be compatible with old APIs.
@webContents.on 'devtools-focused', => @emit 'devtools-focused'
@webContents.on 'devtools-opened', => @emit 'devtools-opened'
@webContents.on 'devtools-closed', => @emit 'devtools-closed'
Object.defineProperty this, 'devToolsWebContents',
enumerable: true,
configurable: false,
get: -> @webContents.devToolsWebContents
BrowserWindow.getFocusedWindow = ->
windows = BrowserWindow.getAllWindows()
return window for window in windows when window.isFocused()
BrowserWindow.fromWebContents = (webContents) ->
windows = BrowserWindow.getAllWindows()
return window for window in windows when window.webContents?.equal webContents
BrowserWindow.fromDevToolsWebContents = (webContents) ->
windows = BrowserWindow.getAllWindows()
return window for window in windows when window.devToolsWebContents?.equal webContents
# Helpers.
BrowserWindow::loadUrl = -> @webContents.loadUrl.apply @webContents, arguments
BrowserWindow::send = -> @webContents.send.apply @webContents, arguments
# Be compatible with old API.
BrowserWindow::undo = -> @webContents.undo()
BrowserWindow::redo = -> @webContents.redo()
BrowserWindow::cut = -> @webContents.cut()
BrowserWindow::copy = -> @webContents.copy()
BrowserWindow::paste = -> @webContents.paste()
BrowserWindow::selectAll = -> @webContents.selectAll()
BrowserWindow::restart = -> @webContents.reload()
BrowserWindow::getUrl = -> @webContents.getUrl()
BrowserWindow::reload = -> @webContents.reload.apply @webContents, arguments
BrowserWindow::reloadIgnoringCache = -> @webContents.reloadIgnoringCache.apply @webContents, arguments
BrowserWindow::getPageTitle = -> @webContents.getTitle()
BrowserWindow::isLoading = -> @webContents.isLoading()
BrowserWindow::isWaitingForResponse = -> @webContents.isWaitingForResponse()
BrowserWindow::stop = -> @webContents.stop()
BrowserWindow::isCrashed = -> @webContents.isCrashed()
BrowserWindow::executeJavaScriptInDevTools = (code) -> @devToolsWebContents?.executeJavaScript code
BrowserWindow::openDevTools = -> @webContents.openDevTools.apply @webContents, arguments
BrowserWindow::closeDevTools = -> @webContents.closeDevTools()
BrowserWindow::isDevToolsOpened = -> @webContents.isDevToolsOpened()
BrowserWindow::toggleDevTools = -> @webContents.toggleDevTools()
BrowserWindow::inspectElement = -> @webContents.inspectElement.apply @webContents, arguments
BrowserWindow::inspectServiceWorker = -> @webContents.inspectServiceWorker()
BrowserWindow::print = -> @webContents.print.apply @webContents, arguments
BrowserWindow::printToPDF = -> @webContents.printToPDF.apply @webContents, arguments
module.exports = BrowserWindow

View File

@@ -1 +0,0 @@
module.exports = process.atomBinding 'content_tracing'

View File

@@ -1,125 +0,0 @@
binding = process.atomBinding 'dialog'
v8Util = process.atomBinding 'v8_util'
app = require 'app'
BrowserWindow = require 'browser-window'
fileDialogProperties =
openFile: 1 << 0
openDirectory: 1 << 1
multiSelections: 1 << 2
createDirectory: 1 << 3
messageBoxTypes = ['none', 'info', 'warning', 'error', 'question']
messageBoxOptions =
noLink: 1 << 0
parseArgs = (window, options, callback) ->
unless window is null or window?.constructor is BrowserWindow
# Shift.
callback = options
options = window
window = null
if not callback? and typeof options is 'function'
# Shift.
callback = options
options = null
[window, options, callback]
checkAppInitialized = ->
throw new Error('dialog module can only be used after app is ready') unless app.isReady()
module.exports =
showOpenDialog: (args...) ->
checkAppInitialized()
[window, options, callback] = parseArgs args...
options ?= title: 'Open', properties: ['openFile']
options.properties ?= ['openFile']
throw new TypeError('Properties need to be array') unless Array.isArray options.properties
properties = 0
for prop, value of fileDialogProperties
properties |= value if prop in options.properties
options.title ?= ''
options.defaultPath ?= ''
options.filters ?= []
wrappedCallback =
if typeof callback is 'function'
(success, result) -> callback(if success then result)
else
null
binding.showOpenDialog String(options.title),
String(options.defaultPath),
options.filters
properties,
window,
wrappedCallback
showSaveDialog: (args...) ->
checkAppInitialized()
[window, options, callback] = parseArgs args...
options ?= title: 'Save'
options.title ?= ''
options.defaultPath ?= ''
options.filters ?= []
wrappedCallback =
if typeof callback is 'function'
(success, result) -> callback(if success then result)
else
null
binding.showSaveDialog String(options.title),
String(options.defaultPath),
options.filters
window,
wrappedCallback
showMessageBox: (args...) ->
checkAppInitialized()
[window, options, callback] = parseArgs args...
options ?= type: 'none'
options.type ?= 'none'
messageBoxType = messageBoxTypes.indexOf options.type
throw new TypeError('Invalid message box type') unless messageBoxType > -1
throw new TypeError('Buttons need to be array') unless Array.isArray options.buttons
options.title ?= ''
options.message ?= ''
options.detail ?= ''
options.icon ?= null
# Choose a default button to get selected when dialog is cancelled.
unless options.cancelId?
options.cancelId = 0
for text, i in options.buttons
if text.toLowerCase() in ['cancel', 'no']
options.cancelId = i
break
flags = if options.noLink then messageBoxOptions.noLink else 0
binding.showMessageBox messageBoxType,
options.buttons,
options.cancelId,
flags,
options.title,
options.message,
options.detail,
options.icon,
window,
callback
showErrorBox: (args...) ->
binding.showErrorBox args...
# Mark standard asynchronous functions.
for api in ['showMessageBox', 'showOpenDialog', 'showSaveDialog']
v8Util.setHiddenValue module.exports[api], 'asynchronous', true

View File

@@ -1,5 +0,0 @@
bindings = process.atomBinding 'global_shortcut'
globalShortcut = bindings.globalShortcut
module.exports = globalShortcut

View File

@@ -1,3 +0,0 @@
EventEmitter = require('events').EventEmitter
module.exports = new EventEmitter

View File

@@ -1,63 +0,0 @@
BrowserWindow = require 'browser-window'
v8Util = process.atomBinding 'v8_util'
nextCommandId = 0
# Maps role to methods of webContents
rolesMap =
undo: 'undo'
redo: 'redo'
cut: 'cut'
copy: 'copy'
paste: 'paste'
selectall: 'selectAll'
minimize: 'minimize'
close: 'close'
class MenuItem
@types = ['normal', 'separator', 'submenu', 'checkbox', 'radio']
constructor: (options) ->
Menu = require 'menu'
{click, @selector, @type, @role, @label, @sublabel, @accelerator, @icon, @enabled, @visible, @checked, @submenu} = options
@type = 'submenu' if not @type? and @submenu?
throw new Error('Invalid submenu') if @type is 'submenu' and @submenu?.constructor isnt Menu
@overrideReadOnlyProperty 'type', 'normal'
@overrideReadOnlyProperty 'role'
@overrideReadOnlyProperty 'accelerator'
@overrideReadOnlyProperty 'icon'
@overrideReadOnlyProperty 'submenu'
@overrideProperty 'label', ''
@overrideProperty 'sublabel', ''
@overrideProperty 'enabled', true
@overrideProperty 'visible', true
@overrideProperty 'checked', false
throw new Error("Unknown menu type #{@type}") if MenuItem.types.indexOf(@type) is -1
@commandId = ++nextCommandId
@click = (focusedWindow) =>
# Manually flip the checked flags when clicked.
@checked = !@checked if @type in ['checkbox', 'radio']
if @role and rolesMap[@role] and process.platform isnt 'darwin'
focusedWindow?[rolesMap[@role]]()
else if typeof click is 'function'
click this, focusedWindow
else if typeof @selector is 'string'
Menu.sendActionToFirstResponder @selector
overrideProperty: (name, defaultValue=null) ->
this[name] ?= defaultValue
overrideReadOnlyProperty: (name, defaultValue=null) ->
this[name] ?= defaultValue
Object.defineProperty this, name,
enumerable: true
writable: false
value: this[name]
module.exports = MenuItem

View File

@@ -1,180 +0,0 @@
BrowserWindow = require 'browser-window'
EventEmitter = require('events').EventEmitter
MenuItem = require 'menu-item'
v8Util = process.atomBinding 'v8_util'
bindings = process.atomBinding 'menu'
# Automatically generated radio menu item's group id.
nextGroupId = 0
# Search between seperators to find a radio menu item and return its group id,
# otherwise generate a group id.
generateGroupId = (items, pos) ->
if pos > 0
for i in [pos - 1..0]
item = items[i]
return item.groupId if item.type is 'radio'
break if item.type is 'separator'
else if pos < items.length
for i in [pos..items.length - 1]
item = items[i]
return item.groupId if item.type is 'radio'
break if item.type is 'separator'
++nextGroupId
# Returns the index of item according to |id|.
indexOfItemById = (items, id) ->
return i for item, i in items when item.id is id
-1
# Returns the index of where to insert the item according to |position|.
indexToInsertByPosition = (items, position) ->
return items.length unless position
[query, id] = position.split '='
insertIndex = indexOfItemById items, id
if insertIndex is -1 and query isnt 'endof'
console.warn "Item with id '#{id}' is not found"
return items.length
switch query
when 'after'
insertIndex++
when 'endof'
# If the |id| doesn't exist, then create a new group with the |id|.
if insertIndex is -1
items.push id: id, type: 'separator'
insertIndex = items.length - 1
# Find the end of the group.
insertIndex++
while insertIndex < items.length and items[insertIndex].type isnt 'separator'
insertIndex++
insertIndex
Menu = bindings.Menu
Menu::__proto__ = EventEmitter.prototype
Menu::_init = ->
@commandsMap = {}
@groupsMap = {}
@items = []
@delegate =
isCommandIdChecked: (commandId) => @commandsMap[commandId]?.checked
isCommandIdEnabled: (commandId) => @commandsMap[commandId]?.enabled
isCommandIdVisible: (commandId) => @commandsMap[commandId]?.visible
getAcceleratorForCommandId: (commandId) => @commandsMap[commandId]?.accelerator
getIconForCommandId: (commandId) => @commandsMap[commandId]?.icon
executeCommand: (commandId) =>
@commandsMap[commandId]?.click BrowserWindow.getFocusedWindow()
menuWillShow: =>
# Make sure radio groups have at least one menu item seleted.
for id, group of @groupsMap
checked = false
for radioItem in group when radioItem.checked
checked = true
break
v8Util.setHiddenValue group[0], 'checked', true unless checked
Menu::popup = (window, x, y) ->
unless window?.constructor is BrowserWindow
# Shift.
y = x
x = window
window = BrowserWindow.getFocusedWindow()
if x? and y?
@_popupAt(window, x, y)
else
@_popup window
Menu::append = (item) ->
@insert @getItemCount(), item
Menu::insert = (pos, item) ->
throw new TypeError('Invalid item') unless item?.constructor is MenuItem
switch item.type
when 'normal' then @insertItem pos, item.commandId, item.label
when 'checkbox' then @insertCheckItem pos, item.commandId, item.label
when 'separator' then @insertSeparator pos
when 'submenu' then @insertSubMenu pos, item.commandId, item.label, item.submenu
when 'radio'
# Grouping radio menu items.
item.overrideReadOnlyProperty 'groupId', generateGroupId(@items, pos)
@groupsMap[item.groupId] ?= []
@groupsMap[item.groupId].push item
# Setting a radio menu item should flip other items in the group.
v8Util.setHiddenValue item, 'checked', item.checked
Object.defineProperty item, 'checked',
enumerable: true
get: -> v8Util.getHiddenValue item, 'checked'
set: (val) =>
for otherItem in @groupsMap[item.groupId] when otherItem isnt item
v8Util.setHiddenValue otherItem, 'checked', false
v8Util.setHiddenValue item, 'checked', true
@insertRadioItem pos, item.commandId, item.label, item.groupId
@setSublabel pos, item.sublabel if item.sublabel?
@setIcon pos, item.icon if item.icon?
@setRole pos, item.role if item.role?
# Make menu accessable to items.
item.overrideReadOnlyProperty 'menu', this
# Remember the items.
@items.splice pos, 0, item
@commandsMap[item.commandId] = item
# Force menuWillShow to be called
Menu::_callMenuWillShow = ->
@delegate?.menuWillShow()
item.submenu._callMenuWillShow() for item in @items when item.submenu?
applicationMenu = null
Menu.setApplicationMenu = (menu) ->
throw new TypeError('Invalid menu') unless menu is null or menu.constructor is Menu
applicationMenu = menu # Keep a reference.
if process.platform is 'darwin'
return if menu is null
menu._callMenuWillShow()
bindings.setApplicationMenu menu
else
windows = BrowserWindow.getAllWindows()
w.setMenu menu for w in windows
Menu.getApplicationMenu = -> applicationMenu
Menu.sendActionToFirstResponder = bindings.sendActionToFirstResponder
Menu.buildFromTemplate = (template) ->
throw new TypeError('Invalid template for Menu') unless Array.isArray template
positionedTemplate = []
insertIndex = 0
for item in template
if item.position
insertIndex = indexToInsertByPosition positionedTemplate, item.position
else
# If no |position| is specified, insert after last item.
insertIndex++
positionedTemplate.splice insertIndex, 0, item
menu = new Menu
for item in positionedTemplate
throw new TypeError('Invalid template for MenuItem') unless typeof item is 'object'
item.submenu = Menu.buildFromTemplate item.submenu if item.submenu?
menuItem = new MenuItem(item)
menuItem[key] = value for key, value of item when not menuItem[key]?
menu.append menuItem
menu
module.exports = Menu

View File

@@ -1,122 +0,0 @@
ipc = require 'ipc'
# The history operation in renderer is redirected to browser.
ipc.on 'ATOM_SHELL_NAVIGATION_CONTROLLER', (event, method, args...) ->
event.sender[method] args...
ipc.on 'ATOM_SHELL_SYNC_NAVIGATION_CONTROLLER', (event, method, args...) ->
event.returnValue = event.sender[method] args...
# JavaScript implementation of Chromium's NavigationController.
# Instead of relying on Chromium for history control, we compeletely do history
# control on user land, and only rely on WebContents.loadUrl for navigation.
# This helps us avoid Chromium's various optimizations so we can ensure renderer
# process is restarted everytime.
class NavigationController
constructor: (@webContents) ->
@clearHistory()
# webContents may have already navigated to a page.
if @webContents._getUrl()
@currentIndex++
@history.push @webContents._getUrl()
@webContents.on 'navigation-entry-commited', (event, url, inPage, replaceEntry) =>
if @inPageIndex > -1 and not inPage
# Navigated to a new page, clear in-page mark.
@inPageIndex = -1
else if @inPageIndex is -1 and inPage
# Started in-page navigations.
@inPageIndex = @currentIndex
if @pendingIndex >= 0 # Go to index.
@currentIndex = @pendingIndex
@pendingIndex = -1
@history[@currentIndex] = url
else if replaceEntry # Non-user initialized navigation.
@history[@currentIndex] = url
else # Normal navigation.
@history = @history.slice 0, @currentIndex + 1 # Clear history.
currentEntry = @history[@currentIndex]
if currentEntry?.url isnt url
@currentIndex++
@history.push url
loadUrl: (url, options={}) ->
@pendingIndex = -1
@webContents._loadUrl url, options
@webContents.emit 'load-url', url, options
getUrl: ->
if @currentIndex is -1
''
else
@history[@currentIndex]
stop: ->
@pendingIndex = -1
@webContents._stop()
reload: ->
@pendingIndex = @currentIndex
@webContents._loadUrl @getUrl(), {}
reloadIgnoringCache: ->
@webContents._reloadIgnoringCache() # Rely on WebContents to clear cache.
@reload()
canGoBack: ->
@getActiveIndex() > 0
canGoForward: ->
@getActiveIndex() < @history.length - 1
canGoToIndex: (index) ->
index >=0 and index < @history.length
canGoToOffset: (offset) ->
@canGoToIndex @currentIndex + offset
clearHistory: ->
@history = []
@currentIndex = -1
@pendingIndex = -1
@inPageIndex = -1
goBack: ->
return unless @canGoBack()
@pendingIndex = @getActiveIndex() - 1
if @inPageIndex > -1 and @pendingIndex >= @inPageIndex
@webContents._goBack()
else
@webContents._loadUrl @history[@pendingIndex], {}
goForward: ->
return unless @canGoForward()
@pendingIndex = @getActiveIndex() + 1
if @inPageIndex > -1 and @pendingIndex >= @inPageIndex
@webContents._goForward()
else
@webContents._loadUrl @history[@pendingIndex], {}
goToIndex: (index) ->
return unless @canGoToIndex index
@pendingIndex = index
@webContents._loadUrl @history[@pendingIndex], {}
goToOffset: (offset) ->
return unless @canGoToOffset offset
pendingIndex = @currentIndex + offset
if @inPageIndex > -1 and pendingIndex >= @inPageIndex
@pendingIndex = pendingIndex
@webContents._goToOffset offset
else
@goToIndex pendingIndex
getActiveIndex: ->
if @pendingIndex is -1 then @currentIndex else @pendingIndex
length: ->
@history.length
module.exports = NavigationController

View File

@@ -1,6 +0,0 @@
powerMonitor = process.atomBinding('power_monitor').powerMonitor
EventEmitter = require('events').EventEmitter
powerMonitor.__proto__ = EventEmitter.prototype
module.exports = powerMonitor

View File

@@ -1,3 +0,0 @@
bindings = process.atomBinding 'power_save_blocker'
module.exports = bindings.powerSaveBlocker

View File

@@ -1,24 +0,0 @@
app = require 'app'
throw new Error('Can not initialize protocol module before app is ready') unless app.isReady()
protocol = process.atomBinding('protocol').protocol
# Warn about removed APIs.
logAndThrow = (callback, message) ->
console.error message
if callback then callback(new Error(message)) else throw new Error(message)
protocol.registerProtocol = (scheme, handler, callback) ->
logAndThrow callback,
'registerProtocol API has been replaced by the
register[File/Http/Buffer/String]Protocol API family, please
switch to the new APIs.'
protocol.isHandledProtocol = (scheme, callback) ->
logAndThrow callback,
'isHandledProtocol API has been replaced by isProtocolHandled.'
protocol.interceptProtocol = (scheme, handler, callback) ->
logAndThrow callback,
'interceptProtocol API has been replaced by the
intercept[File/Http/Buffer/String]Protocol API family, please
switch to the new APIs.'
module.exports = protocol

View File

@@ -1,6 +0,0 @@
EventEmitter = require('events').EventEmitter
screen = process.atomBinding('screen').screen
screen.__proto__ = EventEmitter.prototype
module.exports = screen

Some files were not shown because too many files have changed in this diff Show More